soc/intel/skylake: Unify serial IRQ options
commit44e89af6e609874f2f18d30f1e66dce8b5a98eff
authorNico Huber <nico.h@gmx.de>
Sat, 23 Feb 2019 18:24:51 +0000 (23 19:24 +0100)
committerPatrick Georgi <pgeorgi@google.com>
Fri, 1 Mar 2019 10:07:10 +0000 (1 10:07 +0000)
tree2df8c24b9d6d5695e52257cd5211e6df3af3e46b
parentff79341a807d1754dadeb2001ccd9769ef11a34b
soc/intel/skylake: Unify serial IRQ options

We had two ways to configure the serial IRQ mode. One time in the
devicetree for FSP and one time through Kconfig for coreboot. We'll
use `enum serirq_mode` from soc/intel/common/ as a devicetree option
instead. As the default is `quiet mode` here and that is the most
common mode, this saves us a lot of lines.

In four cases kblrvp8, 11 and librem 13v2, 15v3, we had conflicting
settings in devicetree and Kconfig. We'll maintain the `continuous`
selection, although it might be that coreboot overrode this earlier
on the kblrvps.

Note: A lot of Google boards have serial IRQ enabled, while the pin
seems to be unconnected?

Change-Id: I79f0cd302e335d8dcf8bf6bc32f3d40ca6713e5c
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/31596
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
30 files changed:
src/mainboard/google/eve/devicetree.cb
src/mainboard/google/fizz/variants/baseboard/devicetree.cb
src/mainboard/google/glados/variants/asuka/devicetree.cb
src/mainboard/google/glados/variants/caroline/devicetree.cb
src/mainboard/google/glados/variants/cave/devicetree.cb
src/mainboard/google/glados/variants/chell/devicetree.cb
src/mainboard/google/glados/variants/glados/devicetree.cb
src/mainboard/google/glados/variants/lars/devicetree.cb
src/mainboard/google/glados/variants/sentry/devicetree.cb
src/mainboard/google/poppy/variants/atlas/devicetree.cb
src/mainboard/google/poppy/variants/baseboard/devicetree.cb
src/mainboard/google/poppy/variants/nami/devicetree.cb
src/mainboard/google/poppy/variants/nautilus/devicetree.cb
src/mainboard/google/poppy/variants/nocturne/devicetree.cb
src/mainboard/google/poppy/variants/rammus/devicetree.cb
src/mainboard/google/poppy/variants/soraka/devicetree.cb
src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb
src/mainboard/intel/kblrvp/variants/rvp11/overridetree.cb
src/mainboard/intel/kblrvp/variants/rvp8/overridetree.cb
src/mainboard/intel/kunimitsu/devicetree.cb
src/mainboard/intel/saddlebrook/Kconfig
src/mainboard/intel/saddlebrook/devicetree.cb
src/mainboard/purism/librem_skl/Kconfig
src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb
src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb
src/soc/intel/skylake/Kconfig
src/soc/intel/skylake/chip.c
src/soc/intel/skylake/chip.h
src/soc/intel/skylake/chip_fsp20.c
src/soc/intel/skylake/lpc.c