Rip out legacy reactivity from the typechecker and HackC
commit85eb2a4f5f69ea2f822276ecdd0d99ddf5017f35
authorDavid Snider <dizzy@fb.com>
Wed, 3 Mar 2021 19:50:14 +0000 (3 11:50 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Wed, 3 Mar 2021 19:54:31 +0000 (3 11:54 -0800)
tree35c5b8a882508987465e5d60299dc4a7ebded857
parent18a16e1f57601f954dcacc04e357ff860cbb8ac0
Rip out legacy reactivity from the typechecker and HackC

Summary:
Rip out everything necessary only for legacy reactivity.

See typing_local for some non-red changes related to how we handle mutability of `this` in constructors. Everything else should be pure deletion.

Reviewed By: vassilmladenov

Differential Revision: D26681322

fbshipit-source-id: 585e25f0eda9c776ec7e910a60658ea3c730c622
260 files changed:
hphp/hack/src/annotated_ast/aast_defs.ml
hphp/hack/src/decl/decl_class.ml
hphp/hack/src/decl/decl_defs.ml
hphp/hack/src/decl/decl_folded_class.ml
hphp/hack/src/decl/decl_fun_utils.ml
hphp/hack/src/decl/decl_fun_utils.mli
hphp/hack/src/decl/decl_hint.ml
hphp/hack/src/decl/decl_nast.ml
hphp/hack/src/decl/decl_pos_utils.ml
hphp/hack/src/decl/decl_to_typing.ml
hphp/hack/src/decl/direct_decl_smart_constructors.rs
hphp/hack/src/decl/shallow_decl.ml
hphp/hack/src/decl/shallow_decl_defs.ml
hphp/hack/src/decl/shallow_decl_defs.mli
hphp/hack/src/errors/error_codes.ml
hphp/hack/src/errors/errors.ml
hphp/hack/src/errors/errors.mli
hphp/hack/src/hh_single_type_check.ml
hphp/hack/src/hhbc/ast_scope.rs
hphp/hack/src/hhbc/closure_convert.rs
hphp/hack/src/hhbc/emit_body.rs
hphp/hack/src/hhbc/emit_function.rs
hphp/hack/src/hhbc/emit_memoize_function.rs
hphp/hack/src/hhbc/emit_memoize_method.rs
hphp/hack/src/hhbc/emit_method.rs
hphp/hack/src/hhbc/emit_native_opcode.rs
hphp/hack/src/hhbc/hhas_attribute.rs
hphp/hack/src/hhbc/hhas_body.rs
hphp/hack/src/hhbc/hhas_coeffects.rs
hphp/hack/src/hhbc/print.rs
hphp/hack/src/naming/elaborate_namespaces_visitor.rs
hphp/hack/src/naming/naming.ml
hphp/hack/src/naming/naming_elaborate_namespaces_endo.ml
hphp/hack/src/naming/naming_special_names.ml
hphp/hack/src/naming/naming_special_names.rs
hphp/hack/src/options/globalOptions.ml
hphp/hack/src/options/globalOptions.mli
hphp/hack/src/options/typecheckerOptions.ml
hphp/hack/src/oxidized/aast_visitor/node_impl_gen.rs
hphp/hack/src/oxidized/aast_visitor/node_mut_impl_gen.rs
hphp/hack/src/oxidized/aast_visitor/visitor.rs
hphp/hack/src/oxidized/aast_visitor/visitor_mut.rs
hphp/hack/src/oxidized/gen/aast_defs.rs
hphp/hack/src/oxidized/gen/error_codes.rs
hphp/hack/src/oxidized/gen/global_options.rs
hphp/hack/src/oxidized/impl_gen/aast_defs_impl_gen.rs
hphp/hack/src/oxidized/manual/global_options_impl.rs
hphp/hack/src/oxidized_by_ref/decl_visitor/node_impl_gen.rs
hphp/hack/src/oxidized_by_ref/decl_visitor/visitor.rs
hphp/hack/src/oxidized_by_ref/gen/aast_defs.rs
hphp/hack/src/oxidized_by_ref/gen/decl_defs.rs
hphp/hack/src/oxidized_by_ref/gen/global_options.rs
hphp/hack/src/oxidized_by_ref/gen/mod.rs
hphp/hack/src/oxidized_by_ref/gen/shallow_decl_defs.rs
hphp/hack/src/oxidized_by_ref/gen/tast.rs
hphp/hack/src/oxidized_by_ref/gen/typing_defs_core.rs
hphp/hack/src/oxidized_by_ref/gen/typing_env_return_info.rs
hphp/hack/src/oxidized_by_ref/gen/typing_env_types.rs
hphp/hack/src/oxidized_by_ref/gen/typing_mutability_env.rs [deleted file]
hphp/hack/src/oxidized_by_ref/lib.rs
hphp/hack/src/oxidized_by_ref/manual/global_options_impl.rs
hphp/hack/src/oxidized_by_ref/manual/tast_impl.rs
hphp/hack/src/oxidized_by_ref/manual/typing_defs_core_impl.rs
hphp/hack/src/oxidized_regen.sh
hphp/hack/src/parser/lowerer/lowerer.rs
hphp/hack/src/parser/rust_parser_errors.rs
hphp/hack/src/parser/syntax_error.rs
hphp/hack/src/server/fileOutline.ml
hphp/hack/src/server/serverConfig.ml
hphp/hack/src/server/serverFunDepsBatch.ml
hphp/hack/src/server/serverHover.ml
hphp/hack/src/typing/dune
hphp/hack/src/typing/nast_check/mutability_check.ml [deleted file]
hphp/hack/src/typing/nast_check/nast_check.ml
hphp/hack/src/typing/nast_check/nast_reactivity_check.ml [deleted file]
hphp/hack/src/typing/nast_check_env.ml
hphp/hack/src/typing/nast_visitor.ml
hphp/hack/src/typing/tast.ml
hphp/hack/src/typing/tast_check/basic_reactivity_check.ml [deleted file]
hphp/hack/src/typing/tast_check/foreach_collection_reactivity_check.ml [deleted file]
hphp/hack/src/typing/tast_check/instantiability_check.ml
hphp/hack/src/typing/tast_check/tast_check.ml
hphp/hack/src/typing/tast_check/type_serialization_identity_check.ml
hphp/hack/src/typing/tast_env.ml
hphp/hack/src/typing/tast_env.mli
hphp/hack/src/typing/tast_expand.ml
hphp/hack/src/typing/typing.ml
hphp/hack/src/typing/typing.mli
hphp/hack/src/typing/typing_arithmetic.ml
hphp/hack/src/typing/typing_check_decls.ml
hphp/hack/src/typing/typing_defs.ml
hphp/hack/src/typing/typing_defs_core.ml
hphp/hack/src/typing/typing_defs_core.mli
hphp/hack/src/typing/typing_env.ml
hphp/hack/src/typing/typing_env.mli
hphp/hack/src/typing/typing_env_return_info.ml
hphp/hack/src/typing/typing_env_types.ml
hphp/hack/src/typing/typing_env_types.mli
hphp/hack/src/typing/typing_extends.ml
hphp/hack/src/typing/typing_helpers.ml
hphp/hack/src/typing/typing_lenv.ml
hphp/hack/src/typing/typing_local_ops.ml
hphp/hack/src/typing/typing_log.ml
hphp/hack/src/typing/typing_make_type.rs
hphp/hack/src/typing/typing_mutability.ml [deleted file]
hphp/hack/src/typing/typing_mutability.mli [deleted file]
hphp/hack/src/typing/typing_mutability_env.ml [deleted file]
hphp/hack/src/typing/typing_mutability_env.mli [deleted file]
hphp/hack/src/typing/typing_object_get.ml
hphp/hack/src/typing/typing_print.ml
hphp/hack/src/typing/typing_reactivity.ml [deleted file]
hphp/hack/src/typing/typing_reactivity.mli [deleted file]
hphp/hack/src/typing/typing_return.ml
hphp/hack/src/typing/typing_solver.ml
hphp/hack/src/typing/typing_subtype.ml
hphp/hack/src/typing/typing_subtype.mli
hphp/hack/src/typing/typing_subtype_method.ml
hphp/hack/src/typing/typing_subtype_method.mli
hphp/hack/src/typing/typing_taccess.ml
hphp/hack/src/typing/typing_toplevel.ml
hphp/hack/src/typing/typing_union.ml
hphp/hack/src/typing/typing_utils.ml
hphp/hack/src/typing/typing_variance.ml
hphp/hack/src/utils/symbolDefinition.ml
hphp/hack/src/utils/symbolDefinition.mli
hphp/hack/test/decl/abstract_method.php.exp
hphp/hack/test/decl/accept_disposable.php.exp
hphp/hack/test/decl/array_typehints.php.exp
hphp/hack/test/decl/async_and_generator_functions.php.exp
hphp/hack/test/decl/at_most_rx_as_func.php [deleted file]
hphp/hack/test/decl/at_most_rx_as_func.php.exp [deleted file]
hphp/hack/test/decl/at_most_rx_as_func_with_optional_func.php [deleted file]
hphp/hack/test/decl/at_most_rx_as_func_with_optional_func.php.exp [deleted file]
hphp/hack/test/decl/at_most_rx_as_func_with_optional_func.php.typecheck.exp [deleted file]
hphp/hack/test/decl/atom.php.exp
hphp/hack/test/decl/auto_ns_use.php.exp
hphp/hack/test/decl/cipp.php [deleted file]
hphp/hack/test/decl/cipp.php.exp [deleted file]
hphp/hack/test/decl/cipp.php.typecheck.exp [deleted file]
hphp/hack/test/decl/class_in_namespace.php.exp
hphp/hack/test/decl/classes.php.exp
hphp/hack/test/decl/classes_consistent_construct.php.exp
hphp/hack/test/decl/classes_inferred_constant_types.php.exp
hphp/hack/test/decl/classes_inheritance.php.exp
hphp/hack/test/decl/classes_require.php.exp
hphp/hack/test/decl/classes_typeconst.php.exp
hphp/hack/test/decl/const_attribute.php.exp
hphp/hack/test/decl/constraints_mentioning_tparams_in_same_list.php.exp
hphp/hack/test/decl/denotable_unions.php.exp
hphp/hack/test/decl/deprecated.php.exp
hphp/hack/test/decl/deprecated_string_concat.php.exp
hphp/hack/test/decl/deprecated_string_escaping.php.exp
hphp/hack/test/decl/duplicate_fun_attributes.php.exp
hphp/hack/test/decl/dynamically_callable.php.exp
hphp/hack/test/decl/empty_method_name.php.exp
hphp/hack/test/decl/explicit_type_collection.php.exp
hphp/hack/test/decl/file_mode.php.exp
hphp/hack/test/decl/final_method.php.exp
hphp/hack/test/decl/function_where_constraints.php.exp
hphp/hack/test/decl/functions.php.exp
hphp/hack/test/decl/generic_classes.php.exp
hphp/hack/test/decl/generic_method_tparam_scope.php.exp
hphp/hack/test/decl/hhi.hhi.exp
hphp/hack/test/decl/higher_kinded.php.exp
hphp/hack/test/decl/ifc_policied.php.exp
hphp/hack/test/decl/inout.php.exp
hphp/hack/test/decl/interface.php.exp
hphp/hack/test/decl/interfaces.php.exp
hphp/hack/test/decl/like_types.php.exp
hphp/hack/test/decl/memoize_lsb.php.exp
hphp/hack/test/decl/missing_function_typehints.php.exp
hphp/hack/test/decl/mutable.php [deleted file]
hphp/hack/test/decl/mutable.php.exp [deleted file]
hphp/hack/test/decl/mutable.php.typecheck.exp [deleted file]
hphp/hack/test/decl/mutable_as_hint1.php [deleted file]
hphp/hack/test/decl/mutable_as_hint1.php.exp [deleted file]
hphp/hack/test/decl/mutable_as_hint1.php.typecheck.exp [deleted file]
hphp/hack/test/decl/namespace_body_plus_declarations_outside_body.php.exp
hphp/hack/test/decl/namespace_elaboration.php.exp
hphp/hack/test/decl/namespace_global_body_plus_declarations_outside_body.php.exp
hphp/hack/test/decl/namespace_import.php.exp
hphp/hack/test/decl/namespace_self.php.exp
hphp/hack/test/decl/namespace_unscoped.php.exp
hphp/hack/test/decl/only_rx_if_impl_method.php [deleted file]
hphp/hack/test/decl/only_rx_if_impl_method.php.exp [deleted file]
hphp/hack/test/decl/only_rx_if_impl_method.php.typecheck.exp [deleted file]
hphp/hack/test/decl/override_attribute.php.exp
hphp/hack/test/decl/php_std_lib.hhi.exp
hphp/hack/test/decl/property_declarations.php.exp
hphp/hack/test/decl/property_needs_init.hhi.exp
hphp/hack/test/decl/pure.php [deleted file]
hphp/hack/test/decl/pure.php.exp [deleted file]
hphp/hack/test/decl/pure.php.typecheck.exp [deleted file]
hphp/hack/test/decl/qualified_name_in_attribute_arg.php.exp
hphp/hack/test/decl/readonly.php.exp
hphp/hack/test/decl/ret_from_kind.php.exp
hphp/hack/test/decl/return_disposable.php.exp
hphp/hack/test/decl/returns_void_to_rx.php [deleted file]
hphp/hack/test/decl/returns_void_to_rx.php.exp [deleted file]
hphp/hack/test/decl/returns_void_to_rx.php.typecheck.exp [deleted file]
hphp/hack/test/decl/rewritten_tparams.php.exp
hphp/hack/test/decl/rx.php [deleted file]
hphp/hack/test/decl/rx.php.exp [deleted file]
hphp/hack/test/decl/rx.php.typecheck.exp [deleted file]
hphp/hack/test/decl/rx_example_provisional.php.exp [deleted file]
hphp/hack/test/decl/rx_example_provisional.php.typecheck.exp [deleted file]
hphp/hack/test/decl/self_in_type_constant.php.exp
hphp/hack/test/decl/self_param_mutability.php [deleted file]
hphp/hack/test/decl/self_param_mutability.php.exp [deleted file]
hphp/hack/test/decl/self_param_mutability.php.typecheck.exp [deleted file]
hphp/hack/test/decl/shapes.php.exp
hphp/hack/test/decl/soft_reified.php.exp
hphp/hack/test/decl/soft_type_hint.php.exp
hphp/hack/test/decl/static_method_call_with_explicit_targ.php.exp
hphp/hack/test/decl/tparams_on_class_and_method.php.exp
hphp/hack/test/decl/traits.php.exp
hphp/hack/test/decl/tuples.php.exp
hphp/hack/test/decl/type_param_attrs.php.exp
hphp/hack/test/decl/typeconst_property_promotion.php.exp
hphp/hack/test/decl/unnamed_variadic_method_parameter.php.exp
hphp/hack/test/decl/use_type.php.exp
hphp/hack/test/decl/variadic_parameter.php.exp
hphp/hack/test/decl/wildcard_invalid.php.exp
hphp/hack/test/decl/wildcard_invalid_targ.php.exp
hphp/hack/test/decl/xhp.php.exp
hphp/hack/test/decl/xhp_self.php.exp
hphp/hack/test/decl/yield_deeper.php.exp
hphp/hack/test/full_fidelity/cases/atted_attribute_syntax/test_atted_attribute_syntax.php [deleted file]
hphp/hack/test/full_fidelity/cases/atted_attribute_syntax/test_atted_attribute_syntax.php.json.exp [deleted file]
hphp/hack/test/full_fidelity/cases/purity-v1/parse_multiple_rx+pure.php [deleted file]
hphp/hack/test/full_fidelity/cases/purity-v1/parse_multiple_rx+pure.php.errors.exp [deleted file]
hphp/hack/test/full_fidelity/cases/purity-v1/parse_multiple_rx+pure.php.json.exp [deleted file]
hphp/hack/test/integration_ml/ide/test_auto_ns_aliasing.ml
hphp/hack/test/integration_ml/integration_test_base.ml
hphp/hack/test/integration_ml/runner.ml
hphp/hack/test/nast/coeffects/poly_ctx.php.exp
hphp/hack/test/tast/array_map.php.exp
hphp/hack/test/tast/lambda_contextual.php.exp
hphp/hack/test/tast/reactive.php.exp
hphp/hack/test/tast/singleton_unresolved_function_call.php.exp
hphp/hack/test/typecheck/coeffects/local/mutate_this_in_ctor.php [new file with mode: 0644]
hphp/hack/test/typecheck/coeffects/local/mutate_this_in_ctor.php.exp [moved from hphp/hack/test/decl/at_most_rx_as_func.php.typecheck.exp with 100% similarity]
hphp/test/slow/rx/closure_rx_of_scope.php.hphp_opts [deleted file]
hphp/test/slow/rx/closure_rx_of_scope.php.opts [deleted file]
hphp/test/slow/rx/freeze_mutable.php [deleted file]
hphp/test/slow/rx/freeze_mutable.php.expect [deleted file]
hphp/test/slow/rx/missing_reactivity1.php [deleted file]
hphp/test/slow/rx/missing_reactivity1.php.expectf [deleted file]
hphp/test/slow/rx/missing_reactivity2.php [deleted file]
hphp/test/slow/rx/missing_reactivity2.php.expectf [deleted file]
hphp/test/slow/rx/missing_reactivity3.php [deleted file]
hphp/test/slow/rx/missing_reactivity3.php.expectf [deleted file]
hphp/test/slow/rx/missing_reactivity4.php [deleted file]
hphp/test/slow/rx/missing_reactivity4.php.expectf [deleted file]
hphp/test/slow/rx/missing_reactivity5.php [deleted file]
hphp/test/slow/rx/missing_reactivity5.php.expectf [deleted file]
hphp/test/slow/rx/missing_reactivity6.php [deleted file]
hphp/test/slow/rx/missing_reactivity6.php.expectf [deleted file]
hphp/test/slow/rx/pure_type_hints1.php [deleted file]
hphp/test/slow/rx/pure_type_hints1.php.expect [deleted file]