2 * Copyright (C) 2012 Oracle.
4 * This program is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU General Public License
6 * as published by the Free Software Foundation; either version 2
7 * of the License, or (at your option) any later version.
9 * This program is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details.
14 * You should have received a copy of the GNU General Public License
15 * along with this program; if not, see http://www.gnu.org/copyleft/gpl.txt
19 * The point here is to store the relationships between two variables.
21 * To do that we create a state with the two variables in alphabetical order:
22 * ->name = "x vs y" and the state would be "<". On the false path the state
25 * Part of the trick of it is that if x or y is modified then we need to reset
26 * the state. We need to keep a list of all the states which depend on x and
27 * all the states which depend on y. The link_id code handles this.
32 #include "smatch_extra.h"
33 #include "smatch_slist.h"
37 static int inc_dec_id
;
38 static int inc_dec_link_id
;
40 static void add_comparison(struct expression
*left
, int comparison
, struct expression
*right
);
42 /* for handling for loops */
46 ALLOCATOR(compare_data
, "compare data");
48 static struct symbol
*vsl_to_sym(struct var_sym_list
*vsl
)
54 if (ptr_list_size((struct ptr_list
*)vsl
) != 1)
56 vs
= first_ptr_list((struct ptr_list
*)vsl
);
60 static const char *show_comparison(int comparison
)
62 if (comparison
== IMPOSSIBLE_COMPARISON
)
64 if (comparison
== UNKNOWN_COMPARISON
)
66 return show_special(comparison
);
69 struct smatch_state
*alloc_compare_state(
70 struct expression
*left
,
71 const char *left_var
, struct var_sym_list
*left_vsl
,
73 struct expression
*right
,
74 const char *right_var
, struct var_sym_list
*right_vsl
)
76 struct smatch_state
*state
;
77 struct compare_data
*data
;
79 state
= __alloc_smatch_state(0);
80 state
->name
= alloc_sname(show_comparison(comparison
));
81 data
= __alloc_compare_data(0);
83 data
->left_var
= alloc_sname(left_var
);
84 data
->left_vsl
= clone_var_sym_list(left_vsl
);
85 data
->comparison
= comparison
;
87 data
->right_var
= alloc_sname(right_var
);
88 data
->right_vsl
= clone_var_sym_list(right_vsl
);
93 int state_to_comparison(struct smatch_state
*state
)
95 if (!state
|| !state
->data
)
96 return UNKNOWN_COMPARISON
;
97 return ((struct compare_data
*)state
->data
)->comparison
;
101 * flip_comparison() reverses the op left and right. So "x >= y" becomes "y <= x".
103 int flip_comparison(int op
)
106 case UNKNOWN_COMPARISON
:
107 return UNKNOWN_COMPARISON
;
110 case SPECIAL_UNSIGNED_LT
:
111 return SPECIAL_UNSIGNED_GT
;
114 case SPECIAL_UNSIGNED_LTE
:
115 return SPECIAL_UNSIGNED_GTE
;
117 return SPECIAL_EQUAL
;
118 case SPECIAL_NOTEQUAL
:
119 return SPECIAL_NOTEQUAL
;
122 case SPECIAL_UNSIGNED_GTE
:
123 return SPECIAL_UNSIGNED_LTE
;
126 case SPECIAL_UNSIGNED_GT
:
127 return SPECIAL_UNSIGNED_LT
;
128 case IMPOSSIBLE_COMPARISON
:
129 return UNKNOWN_COMPARISON
;
131 sm_perror("unhandled comparison %d", op
);
136 int negate_comparison(int op
)
139 case UNKNOWN_COMPARISON
:
140 return UNKNOWN_COMPARISON
;
143 case SPECIAL_UNSIGNED_LT
:
144 return SPECIAL_UNSIGNED_GTE
;
147 case SPECIAL_UNSIGNED_LTE
:
148 return SPECIAL_UNSIGNED_GT
;
150 return SPECIAL_NOTEQUAL
;
151 case SPECIAL_NOTEQUAL
:
152 return SPECIAL_EQUAL
;
155 case SPECIAL_UNSIGNED_GTE
:
156 return SPECIAL_UNSIGNED_LT
;
159 case SPECIAL_UNSIGNED_GT
:
160 return SPECIAL_UNSIGNED_LTE
;
161 case IMPOSSIBLE_COMPARISON
:
162 return UNKNOWN_COMPARISON
;
164 sm_perror("unhandled comparison %d", op
);
169 static int rl_comparison(struct range_list
*left_rl
, struct range_list
*right_rl
)
171 sval_t left_min
, left_max
, right_min
, right_max
;
172 struct symbol
*type
= &int_ctype
;
174 if (!left_rl
|| !right_rl
)
175 return UNKNOWN_COMPARISON
;
177 if (type_positive_bits(rl_type(left_rl
)) > type_positive_bits(type
))
178 type
= rl_type(left_rl
);
179 if (type_positive_bits(rl_type(right_rl
)) > type_positive_bits(type
))
180 type
= rl_type(right_rl
);
182 left_rl
= cast_rl(type
, left_rl
);
183 right_rl
= cast_rl(type
, right_rl
);
185 left_min
= rl_min(left_rl
);
186 left_max
= rl_max(left_rl
);
187 right_min
= rl_min(right_rl
);
188 right_max
= rl_max(right_rl
);
190 if (left_min
.value
== left_max
.value
&&
191 right_min
.value
== right_max
.value
&&
192 left_min
.value
== right_min
.value
)
193 return SPECIAL_EQUAL
;
195 if (sval_cmp(left_max
, right_min
) < 0)
197 if (sval_cmp(left_max
, right_min
) == 0)
199 if (sval_cmp(left_min
, right_max
) > 0)
201 if (sval_cmp(left_min
, right_max
) == 0)
204 return UNKNOWN_COMPARISON
;
207 static int comparison_from_extra(struct expression
*a
, struct expression
*b
)
209 struct range_list
*left
, *right
;
211 if (!get_implied_rl(a
, &left
))
212 return UNKNOWN_COMPARISON
;
213 if (!get_implied_rl(b
, &right
))
214 return UNKNOWN_COMPARISON
;
216 return rl_comparison(left
, right
);
219 static struct range_list
*get_orig_rl(struct var_sym_list
*vsl
)
222 struct smatch_state
*state
;
226 sym
= vsl_to_sym(vsl
);
227 if (!sym
|| !sym
->ident
)
229 state
= get_orig_estate(sym
->ident
->name
, sym
);
230 return estate_rl(state
);
233 static struct smatch_state
*unmatched_comparison(struct sm_state
*sm
)
235 struct compare_data
*data
= sm
->state
->data
;
236 struct range_list
*left_rl
, *right_rl
;
237 int op
= UNKNOWN_COMPARISON
;
242 if (is_impossible_path()) {
243 op
= IMPOSSIBLE_COMPARISON
;
247 if (strstr(data
->left_var
, " orig"))
248 left_rl
= get_orig_rl(data
->left_vsl
);
249 else if (!get_implied_rl_var_sym(data
->left_var
, vsl_to_sym(data
->left_vsl
), &left_rl
))
252 if (strstr(data
->right_var
, " orig"))
253 right_rl
= get_orig_rl(data
->right_vsl
);
254 else if (!get_implied_rl_var_sym(data
->right_var
, vsl_to_sym(data
->right_vsl
), &right_rl
))
257 op
= rl_comparison(left_rl
, right_rl
);
260 return alloc_compare_state(data
->left
, data
->left_var
, data
->left_vsl
,
262 data
->right
, data
->right_var
, data
->right_vsl
);
265 /* remove_unsigned_from_comparison() is obviously a hack. */
266 int remove_unsigned_from_comparison(int op
)
269 case SPECIAL_UNSIGNED_LT
:
271 case SPECIAL_UNSIGNED_LTE
:
273 case SPECIAL_UNSIGNED_GTE
:
275 case SPECIAL_UNSIGNED_GT
:
283 * This is for when you merge states "a < b" and "a == b", the result is that
284 * we can say for sure, "a <= b" after the merge.
286 int merge_comparisons(int one
, int two
)
290 if (one
== UNKNOWN_COMPARISON
|| two
== UNKNOWN_COMPARISON
)
291 return UNKNOWN_COMPARISON
;
293 if (one
== IMPOSSIBLE_COMPARISON
)
295 if (two
== IMPOSSIBLE_COMPARISON
)
298 one
= remove_unsigned_from_comparison(one
);
299 two
= remove_unsigned_from_comparison(two
);
345 return UNKNOWN_COMPARISON
;
349 return SPECIAL_NOTEQUAL
;
356 return UNKNOWN_COMPARISON
;
360 * This is for if you have "a < b" and "b <= c" and you want to see how "a
361 * compares to c". You would call this like get_combined_comparison('<', '<=').
362 * The return comparison would be '<'.
364 int combine_comparisons(int left_compare
, int right_compare
)
368 left_compare
= remove_unsigned_from_comparison(left_compare
);
369 right_compare
= remove_unsigned_from_comparison(right_compare
);
373 switch (left_compare
) {
382 return right_compare
;
391 switch (right_compare
) {
420 return UNKNOWN_COMPARISON
;
424 * This is mostly used when you know from extra state that a <= b but you
425 * know from comparisons that a != b so then if take the intersection then
426 * we know that a < b. The name is taken from the fact that the intersection
429 int comparison_intersection(int left_compare
, int right_compare
)
431 int LT
, GT
, EQ
, NE
, total
;
433 if (left_compare
== IMPOSSIBLE_COMPARISON
||
434 right_compare
== IMPOSSIBLE_COMPARISON
)
435 return IMPOSSIBLE_COMPARISON
;
437 left_compare
= remove_unsigned_from_comparison(left_compare
);
438 right_compare
= remove_unsigned_from_comparison(right_compare
);
440 LT
= GT
= EQ
= NE
= total
= 0;
442 /* Only one side is known. */
444 return right_compare
;
448 switch (left_compare
) {
462 case SPECIAL_NOTEQUAL
:
476 return UNKNOWN_COMPARISON
;
479 switch (right_compare
) {
493 case SPECIAL_NOTEQUAL
:
507 return UNKNOWN_COMPARISON
;
522 return SPECIAL_EQUAL
;
523 if (total
== 2 && EQ
&& NE
)
524 return IMPOSSIBLE_COMPARISON
;
526 return IMPOSSIBLE_COMPARISON
;
532 return SPECIAL_NOTEQUAL
;
533 if (total
== 2 && (LT
|| GT
) && EQ
)
534 return IMPOSSIBLE_COMPARISON
;
536 return UNKNOWN_COMPARISON
;
539 static void pre_merge_hook(struct sm_state
*cur
, struct sm_state
*other
)
541 struct compare_data
*data
= cur
->state
->data
;
543 static bool in_recurse
;
545 // FIXME. No data is useless
552 extra
= comparison_from_extra(data
->left
, data
->right
);
556 new = comparison_intersection(extra
, data
->comparison
);
557 if (new == data
->comparison
)
560 // FIXME: we should always preserve implications
561 set_state(comparison_id
, cur
->name
, NULL
,
562 alloc_compare_state(data
->left
, data
->left_var
, data
->left_vsl
,
564 data
->right
, data
->right_var
, data
->right_vsl
));
567 struct smatch_state
*merge_compare_states(struct smatch_state
*s1
, struct smatch_state
*s2
)
569 struct compare_data
*data
= s1
->data
;
575 op
= merge_comparisons(state_to_comparison(s1
), state_to_comparison(s2
));
576 return alloc_compare_state(
577 data
->left
, data
->left_var
, data
->left_vsl
,
579 data
->right
, data
->right_var
, data
->right_vsl
);
582 static struct smatch_state
*alloc_link_state(struct string_list
*links
)
584 struct smatch_state
*state
;
585 static char buf
[256] = "";
589 state
= __alloc_smatch_state(0);
591 FOR_EACH_PTR(links
, tmp
) {
592 cnt
+= snprintf(buf
+ cnt
, sizeof(buf
) - cnt
, "%s%s", cnt
? ", " : "", tmp
);
593 if (cnt
>= sizeof(buf
))
595 } END_FOR_EACH_PTR(tmp
);
598 state
->name
= alloc_sname(buf
);
603 static void save_start_states(struct statement
*stmt
)
605 struct symbol
*param
;
607 char state_name
[128];
608 struct smatch_state
*state
;
609 struct string_list
*links
;
612 FOR_EACH_PTR(cur_func_sym
->ctype
.base_type
->arguments
, param
) {
613 struct var_sym_list
*left_vsl
= NULL
;
614 struct var_sym_list
*right_vsl
= NULL
;
618 snprintf(orig
, sizeof(orig
), "%s orig", param
->ident
->name
);
619 snprintf(state_name
, sizeof(state_name
), "%s vs %s", param
->ident
->name
, orig
);
620 add_var_sym(&left_vsl
, param
->ident
->name
, param
);
621 add_var_sym(&right_vsl
, orig
, param
);
622 state
= alloc_compare_state(
623 NULL
, param
->ident
->name
, left_vsl
,
625 NULL
, alloc_sname(orig
), right_vsl
);
626 set_state(comparison_id
, state_name
, NULL
, state
);
628 link
= alloc_sname(state_name
);
630 insert_string(&links
, link
);
631 state
= alloc_link_state(links
);
632 set_state(link_id
, param
->ident
->name
, param
, state
);
633 } END_FOR_EACH_PTR(param
);
636 static struct smatch_state
*merge_links(struct smatch_state
*s1
, struct smatch_state
*s2
)
638 struct smatch_state
*ret
;
639 struct string_list
*links
;
641 links
= combine_string_lists(s1
->data
, s2
->data
);
642 ret
= alloc_link_state(links
);
646 static void save_link_var_sym(const char *var
, struct symbol
*sym
, const char *link
)
648 struct smatch_state
*old_state
, *new_state
;
649 struct string_list
*links
;
652 old_state
= get_state(link_id
, var
, sym
);
654 links
= clone_str_list(old_state
->data
);
658 new = alloc_sname(link
);
659 insert_string(&links
, new);
661 new_state
= alloc_link_state(links
);
662 set_state(link_id
, var
, sym
, new_state
);
665 static void match_inc(struct sm_state
*sm
, bool preserve
)
667 struct string_list
*links
;
668 struct smatch_state
*state
, *new;
669 struct compare_data
*data
;
674 links
= sm
->state
->data
;
676 FOR_EACH_PTR(links
, tmp
) {
677 state
= get_state(comparison_id
, tmp
, NULL
);
685 if (strncmp(sm
->name
, tmp
, strlen(sm
->name
)) != 0 ||
686 tmp
[strlen(sm
->name
)] != ' ')
689 op
= state_to_comparison(state
);
691 switch (flip
? flip_comparison(op
) : op
) {
694 case SPECIAL_UNSIGNED_GTE
:
696 case SPECIAL_UNSIGNED_GT
:
699 new = alloc_compare_state(
700 data
->left
, data
->left_var
, data
->left_vsl
,
702 data
->right
, data
->right_var
, data
->right_vsl
);
703 set_state(comparison_id
, tmp
, NULL
, new);
706 case SPECIAL_UNSIGNED_LT
:
707 new = alloc_compare_state(
708 data
->left
, data
->left_var
, data
->left_vsl
,
709 flip
? SPECIAL_GTE
: SPECIAL_LTE
,
710 data
->right
, data
->right_var
, data
->right_vsl
);
711 set_state(comparison_id
, tmp
, NULL
, new);
714 new = alloc_compare_state(
715 data
->left
, data
->left_var
, data
->left_vsl
,
717 data
->right
, data
->right_var
, data
->right_vsl
);
718 set_state(comparison_id
, tmp
, NULL
, new);
720 } END_FOR_EACH_PTR(tmp
);
723 static void match_dec(struct sm_state
*sm
, bool preserve
)
725 struct string_list
*links
;
726 struct smatch_state
*state
;
729 links
= sm
->state
->data
;
731 FOR_EACH_PTR(links
, tmp
) {
732 struct compare_data
*data
;
733 struct smatch_state
*new;
735 state
= get_state(comparison_id
, tmp
, NULL
);
736 if (!state
|| !state
->data
)
741 switch (state_to_comparison(state
)) {
744 case SPECIAL_UNSIGNED_LTE
:
746 case SPECIAL_UNSIGNED_LT
: {
750 new = alloc_compare_state(
751 data
->left
, data
->left_var
, data
->left_vsl
,
753 data
->right
, data
->right_var
, data
->right_vsl
);
754 set_state(comparison_id
, tmp
, NULL
, new);
758 new = alloc_compare_state(
759 data
->left
, data
->left_var
, data
->left_vsl
,
761 data
->right
, data
->right_var
, data
->right_vsl
);
762 set_state(comparison_id
, tmp
, NULL
, new);
764 } END_FOR_EACH_PTR(tmp
);
767 static void reset_sm(struct sm_state
*sm
)
769 struct string_list
*links
;
772 links
= sm
->state
->data
;
774 FOR_EACH_PTR(links
, tmp
) {
775 struct smatch_state
*old
, *new;
777 old
= get_state(comparison_id
, tmp
, NULL
);
778 if (!old
|| !old
->data
) {
781 struct compare_data
*data
= old
->data
;
783 new = alloc_compare_state(
784 data
->left
, data
->left_var
, data
->left_vsl
,
786 data
->right
, data
->right_var
, data
->right_vsl
);
788 set_state(comparison_id
, tmp
, NULL
, new);
789 } END_FOR_EACH_PTR(tmp
);
790 set_state(link_id
, sm
->name
, sm
->sym
, &undefined
);
793 static bool match_add_sub_assign(struct sm_state
*sm
, struct expression
*expr
)
795 struct range_list
*rl
;
796 sval_t zero
= { .type
= &int_ctype
};
798 if (!expr
|| expr
->type
!= EXPR_ASSIGNMENT
)
800 if (expr
->op
!= SPECIAL_ADD_ASSIGN
&& expr
->op
!= SPECIAL_SUB_ASSIGN
)
803 get_absolute_rl(expr
->right
, &rl
);
804 if (sval_is_negative(rl_min(rl
))) {
809 if (expr
->op
== SPECIAL_ADD_ASSIGN
)
810 match_inc(sm
, rl_has_sval(rl
, zero
));
812 match_dec(sm
, rl_has_sval(rl
, zero
));
816 static void match_inc_dec(struct sm_state
*sm
, struct expression
*mod_expr
)
819 * if (foo > bar) then ++foo is also > bar.
823 if (match_add_sub_assign(sm
, mod_expr
))
825 if (mod_expr
->type
!= EXPR_PREOP
&& mod_expr
->type
!= EXPR_POSTOP
)
828 if (mod_expr
->op
== SPECIAL_INCREMENT
)
829 match_inc(sm
, false);
830 else if (mod_expr
->op
== SPECIAL_DECREMENT
)
831 match_dec(sm
, false);
834 static int is_self_assign(struct expression
*expr
)
836 if (!expr
|| expr
->type
!= EXPR_ASSIGNMENT
|| expr
->op
!= '=')
838 return expr_equiv(expr
->left
, expr
->right
);
841 static void match_modify(struct sm_state
*sm
, struct expression
*mod_expr
)
843 if (mod_expr
&& is_self_assign(mod_expr
))
846 /* handled by match_inc_dec() */
848 ((mod_expr
->type
== EXPR_PREOP
|| mod_expr
->type
== EXPR_POSTOP
) &&
849 (mod_expr
->op
== SPECIAL_INCREMENT
|| mod_expr
->op
== SPECIAL_DECREMENT
)))
851 if (mod_expr
&& mod_expr
->type
== EXPR_ASSIGNMENT
&&
852 (mod_expr
->op
== SPECIAL_ADD_ASSIGN
|| mod_expr
->op
== SPECIAL_SUB_ASSIGN
))
858 static void match_preop(struct expression
*expr
)
860 struct expression
*parent
;
861 struct range_list
*left
, *right
;
865 * This is an important special case. Say you have:
869 * Assume that we know the range of limit is higher than the start
870 * value for "j". Then the first thing that we process is the ++j. We
871 * have not comparison states set up so it doesn't get caught by the
872 * modification hook. But it does get caught by smatch_extra which sets
873 * j to unknown then we parse the "j == limit" and sets false to != but
874 * really we want false to be <.
876 * So what we do is we set j < limit here, then the match_modify catches
877 * it and we do a match_inc_dec().
881 if (expr
->type
!= EXPR_PREOP
||
882 (expr
->op
!= SPECIAL_INCREMENT
&& expr
->op
!= SPECIAL_DECREMENT
))
885 parent
= expr_get_parent_expr(expr
);
888 if (parent
->type
!= EXPR_COMPARE
|| parent
->op
!= SPECIAL_EQUAL
)
890 if (parent
->left
!= expr
)
893 if (!get_implied_rl(expr
->unop
, &left
) ||
894 !get_implied_rl(parent
->right
, &right
))
897 op
= rl_comparison(left
, right
);
898 if (op
== UNKNOWN_COMPARISON
)
901 add_comparison(expr
->unop
, op
, parent
->right
);
904 static char *chunk_to_var_sym(struct expression
*expr
, struct symbol
**sym
)
906 expr
= strip_expr(expr
);
912 if (expr
->type
== EXPR_PREOP
&&
913 (expr
->op
== SPECIAL_INCREMENT
||
914 expr
->op
== SPECIAL_DECREMENT
))
915 expr
= strip_expr(expr
->unop
);
917 if (expr
->type
== EXPR_CALL
) {
920 snprintf(buf
, sizeof(buf
), "return %p", expr
);
921 return alloc_string(buf
);
924 return expr_to_chunk_sym_vsl(expr
, sym
, NULL
);
927 static char *chunk_to_var(struct expression
*expr
)
929 return chunk_to_var_sym(expr
, NULL
);
932 static struct smatch_state
*get_state_chunk(int owner
, struct expression
*expr
)
936 struct smatch_state
*ret
;
938 name
= chunk_to_var_sym(expr
, &sym
);
942 ret
= get_state(owner
, name
, sym
);
947 static void save_link(struct expression
*expr
, char *link
)
952 expr
= strip_expr(expr
);
953 if (expr
->type
== EXPR_BINOP
) {
956 chunk
= chunk_to_var(expr
);
960 save_link(expr
->left
, link
);
961 save_link(expr
->right
, link
);
962 save_link_var_sym(chunk
, NULL
, link
);
966 var
= chunk_to_var_sym(expr
, &sym
);
970 save_link_var_sym(var
, sym
, link
);
974 static int get_orig_comparison(struct stree
*pre_stree
, const char *left
, const char *right
)
976 struct smatch_state
*state
;
977 struct compare_data
*data
;
979 char state_name
[256];
981 if (strcmp(left
, right
) > 0) {
982 const char *tmp
= right
;
989 snprintf(state_name
, sizeof(state_name
), "%s vs %s", left
, right
);
990 state
= get_state_stree(pre_stree
, comparison_id
, state_name
, NULL
);
991 if (!state
|| !state
->data
)
995 return flip_comparison(data
->comparison
);
996 return data
->comparison
;
1000 static int have_common_var_sym(struct var_sym_list
*left_vsl
, struct var_sym_list
*right_vsl
)
1002 struct var_sym
*tmp
;
1004 FOR_EACH_PTR(left_vsl
, tmp
) {
1005 if (in_var_sym_list(right_vsl
, tmp
->var
, tmp
->sym
))
1007 } END_FOR_EACH_PTR(tmp
);
1013 * The idea here is that we take a comparison "a < b" and then we look at all
1014 * the things which "b" is compared against "b < c" and we say that that implies
1015 * a relationship "a < c".
1017 * The names here about because the comparisons are organized like this
1021 static void update_tf_links(struct stree
*pre_stree
,
1022 struct expression
*left_expr
,
1023 const char *left_var
, struct var_sym_list
*left_vsl
,
1024 int left_comparison
, int left_false_comparison
,
1025 const char *mid_var
, struct var_sym_list
*mid_vsl
,
1026 struct string_list
*links
)
1028 struct smatch_state
*state
;
1029 struct smatch_state
*true_state
, *false_state
;
1030 struct compare_data
*data
;
1031 struct expression
*right_expr
;
1032 const char *left_var_orig
= left_var
;
1033 const char *right_var
;
1034 struct var_sym_list
*left_vsl_orig
= left_vsl
;
1035 struct var_sym_list
*right_vsl
;
1036 int orig_comparison
;
1037 int right_comparison
;
1038 int true_comparison
;
1039 int false_comparison
;
1041 char state_name
[256];
1044 FOR_EACH_PTR(links
, tmp
) {
1045 state
= get_state_stree(pre_stree
, comparison_id
, tmp
, NULL
);
1046 if (!state
|| !state
->data
)
1048 left_var
= left_var_orig
;
1049 left_vsl
= left_vsl_orig
;
1051 right_comparison
= data
->comparison
;
1052 right_expr
= data
->right
;
1053 right_var
= data
->right_var
;
1054 right_vsl
= data
->right_vsl
;
1055 if (strcmp(mid_var
, right_var
) == 0) {
1056 right_expr
= data
->left
;
1057 right_var
= data
->left_var
;
1058 right_vsl
= data
->left_vsl
;
1059 right_comparison
= flip_comparison(right_comparison
);
1061 if (have_common_var_sym(left_vsl
, right_vsl
))
1064 orig_comparison
= get_orig_comparison(pre_stree
, left_var
, right_var
);
1066 true_comparison
= combine_comparisons(left_comparison
, right_comparison
);
1067 false_comparison
= combine_comparisons(left_false_comparison
, right_comparison
);
1069 true_comparison
= comparison_intersection(orig_comparison
, true_comparison
);
1070 false_comparison
= comparison_intersection(orig_comparison
, false_comparison
);
1072 if (strcmp(left_var
, right_var
) > 0) {
1073 struct expression
*tmp_expr
= left_expr
;
1074 const char *tmp_var
= left_var
;
1075 struct var_sym_list
*tmp_vsl
= left_vsl
;
1077 left_expr
= right_expr
;
1078 left_var
= right_var
;
1079 left_vsl
= right_vsl
;
1080 right_expr
= tmp_expr
;
1081 right_var
= tmp_var
;
1082 right_vsl
= tmp_vsl
;
1083 true_comparison
= flip_comparison(true_comparison
);
1084 false_comparison
= flip_comparison(false_comparison
);
1087 if (!true_comparison
&& !false_comparison
)
1090 if (true_comparison
)
1091 true_state
= alloc_compare_state(
1092 left_expr
, left_var
, left_vsl
,
1094 right_expr
, right_var
, right_vsl
);
1097 if (false_comparison
)
1098 false_state
= alloc_compare_state(
1099 left_expr
, left_var
, left_vsl
,
1101 right_expr
, right_var
, right_vsl
);
1105 snprintf(state_name
, sizeof(state_name
), "%s vs %s", left_var
, right_var
);
1106 set_true_false_states(comparison_id
, state_name
, NULL
, true_state
, false_state
);
1107 FOR_EACH_PTR(left_vsl
, vs
) {
1108 save_link_var_sym(vs
->var
, vs
->sym
, state_name
);
1109 } END_FOR_EACH_PTR(vs
);
1110 FOR_EACH_PTR(right_vsl
, vs
) {
1111 save_link_var_sym(vs
->var
, vs
->sym
, state_name
);
1112 } END_FOR_EACH_PTR(vs
);
1113 if (!vsl_to_sym(left_vsl
))
1114 save_link_var_sym(left_var
, NULL
, state_name
);
1115 if (!vsl_to_sym(right_vsl
))
1116 save_link_var_sym(right_var
, NULL
, state_name
);
1117 } END_FOR_EACH_PTR(tmp
);
1120 static void update_tf_data(struct stree
*pre_stree
,
1121 struct expression
*left_expr
,
1122 const char *left_name
, struct var_sym_list
*left_vsl
,
1123 struct expression
*right_expr
,
1124 const char *right_name
, struct var_sym_list
*right_vsl
,
1125 int true_comparison
, int false_comparison
)
1127 struct smatch_state
*state
;
1129 state
= get_state_stree(pre_stree
, link_id
, right_name
, vsl_to_sym(right_vsl
));
1131 update_tf_links(pre_stree
, left_expr
, left_name
, left_vsl
, true_comparison
, false_comparison
, right_name
, right_vsl
, state
->data
);
1133 state
= get_state_stree(pre_stree
, link_id
, left_name
, vsl_to_sym(left_vsl
));
1135 update_tf_links(pre_stree
, right_expr
, right_name
, right_vsl
, flip_comparison(true_comparison
), flip_comparison(false_comparison
), left_name
, left_vsl
, state
->data
);
1138 static void iter_modify(struct sm_state
*sm
, struct expression
*mod_expr
)
1140 if (sm
->state
!= &start
||
1142 (mod_expr
->type
!= EXPR_PREOP
&& mod_expr
->type
!= EXPR_POSTOP
) ||
1143 mod_expr
->op
!= SPECIAL_INCREMENT
)
1144 set_state(inc_dec_id
, sm
->name
, sm
->sym
, &undefined
);
1146 set_state(inc_dec_id
, sm
->name
, sm
->sym
, &incremented
);
1149 static void handle_for_loops(struct expression
*expr
, char *state_name
, struct smatch_state
*false_state
)
1152 char *iter_name
, *cap_name
;
1153 struct symbol
*iter_sym
, *cap_sym
;
1154 struct compare_data
*data
;
1156 if (expr
->op
!= '<' && expr
->op
!= SPECIAL_UNSIGNED_LT
)
1159 if (!__cur_stmt
|| !__prev_stmt
)
1161 if (__cur_stmt
->type
!= STMT_ITERATOR
)
1163 if (__cur_stmt
->iterator_pre_condition
!= expr
)
1166 /* literals are handled in smatch_extra.c */
1167 if (get_value(expr
->right
, &sval
))
1170 /* First time checking the condition */
1171 if (__prev_stmt
== __cur_stmt
->iterator_pre_statement
) {
1172 if (!get_implied_value(expr
->left
, &sval
) ||
1176 iter_name
= expr_to_var_sym(expr
->left
, &iter_sym
);
1177 cap_name
= expr_to_var_sym(expr
->right
, &cap_sym
);
1178 if (!iter_name
|| !cap_name
|| !iter_sym
|| !cap_sym
) {
1179 free_string(iter_name
);
1180 free_string(cap_name
);
1184 set_state(inc_dec_id
, iter_name
, iter_sym
, &start
);
1185 store_link(inc_dec_link_id
, cap_name
, cap_sym
, iter_name
, iter_sym
);
1187 free_string(iter_name
);
1188 free_string(cap_name
);
1192 /* Second time checking the condtion */
1193 if (__prev_stmt
!= __cur_stmt
->iterator_post_statement
)
1196 if (get_state_chunk(inc_dec_id
, expr
->left
) != &incremented
)
1199 data
= false_state
->data
;
1200 false_state
= alloc_compare_state(
1201 data
->left
, data
->left_var
, data
->left_vsl
,
1203 data
->right
, data
->right_var
, data
->right_vsl
);
1205 // FIXME: This doesn't handle links correct so it doesn't set "param orig"
1206 set_true_false_states(comparison_id
, state_name
, NULL
, NULL
, false_state
);
1209 static int is_plus_one(struct expression
*expr
)
1213 if (expr
->type
!= EXPR_BINOP
|| expr
->op
!= '+')
1215 if (!get_implied_value(expr
->right
, &sval
) || sval
.value
!= 1)
1220 static int is_minus_one(struct expression
*expr
)
1224 if (expr
->type
!= EXPR_BINOP
|| expr
->op
!= '-')
1226 if (!get_implied_value(expr
->right
, &sval
) || sval
.value
!= 1)
1231 static void remove_plus_minus_zero(struct expression
**expr_p
)
1233 struct expression
*expr
= *expr_p
;
1236 if (!expr
|| expr
->type
!= EXPR_BINOP
)
1238 if (expr
->op
== '+') {
1239 if (get_implied_value(expr
->left
, &sval
) && sval
.value
== 0)
1240 *expr_p
= expr
->right
;
1241 else if (get_implied_value(expr
->right
, &sval
) && sval
.value
== 0)
1242 *expr_p
= expr
->left
;
1245 return remove_plus_minus_zero(expr_p
);
1247 if (expr
->op
== '-') {
1248 if (get_implied_value(expr
->right
, &sval
) && sval
.value
== 0) {
1249 *expr_p
= expr
->left
;
1250 return remove_plus_minus_zero(expr_p
);
1255 static void move_plus_to_minus_helper(struct expression
**left_p
, struct expression
**right_p
)
1257 struct expression
*left
= *left_p
;
1258 struct expression
*right
= *right_p
;
1261 * These two are basically equivalent: "foo + 1 != bar" and
1262 * "foo != bar - 1". There are issues with signedness and integer
1263 * overflows. There are also issues with type as well. But let's
1264 * pretend we can ignore all that stuff for now.
1268 if (!is_plus_one(left
))
1271 *left_p
= left
->left
;
1272 *right_p
= binop_expression(right
, '-', left
->right
);
1275 static void move_plus_to_minus(struct expression
**left_p
, struct expression
**right_p
)
1277 if (is_plus_one(*left_p
) && is_plus_one(*right_p
))
1280 move_plus_to_minus_helper(left_p
, right_p
);
1281 move_plus_to_minus_helper(right_p
, left_p
);
1284 static void simplify_binops(struct expression
**left_p
, struct expression
**right_p
)
1286 remove_plus_minus_zero(left_p
);
1287 remove_plus_minus_zero(right_p
);
1289 move_plus_to_minus(left_p
, right_p
);
1292 static void handle_comparison(struct expression
*left_expr
, int op
, struct expression
*right_expr
, char **_state_name
, struct smatch_state
**_false_state
)
1296 struct symbol
*left_sym
, *right_sym
;
1297 struct var_sym_list
*left_vsl
= NULL
;
1298 struct var_sym_list
*right_vsl
= NULL
;
1300 int orig_comparison
;
1301 struct smatch_state
*true_state
, *false_state
;
1302 static char state_name
[256];
1303 struct stree
*pre_stree
;
1306 if (!left_expr
|| !right_expr
)
1309 left_expr
= strip_parens(left_expr
);
1310 right_expr
= strip_parens(right_expr
);
1312 while (left_expr
->type
== EXPR_ASSIGNMENT
)
1313 left_expr
= strip_parens(left_expr
->left
);
1314 while (right_expr
->type
== EXPR_ASSIGNMENT
)
1315 right_expr
= strip_parens(right_expr
->left
);
1317 false_op
= negate_comparison(op
);
1319 simplify_binops(&left_expr
, &right_expr
);
1321 if (op
== SPECIAL_UNSIGNED_LT
&&
1322 get_implied_value(left_expr
, &sval
) &&
1324 false_op
= SPECIAL_EQUAL
;
1326 if (op
== SPECIAL_UNSIGNED_GT
&&
1327 get_implied_value(right_expr
, &sval
) &&
1329 false_op
= SPECIAL_EQUAL
;
1331 left
= chunk_to_var_sym(left_expr
, &left_sym
);
1335 add_var_sym(&left_vsl
, left
, left_sym
);
1337 left_vsl
= expr_to_vsl(left_expr
);
1338 right
= chunk_to_var_sym(right_expr
, &right_sym
);
1342 add_var_sym(&right_vsl
, right
, right_sym
);
1344 right_vsl
= expr_to_vsl(right_expr
);
1346 if (strcmp(left
, right
) > 0) {
1347 char *tmp_name
= left
;
1348 struct var_sym_list
*tmp_vsl
= left_vsl
;
1349 struct expression
*tmp_expr
= left_expr
;
1352 left_vsl
= right_vsl
;
1353 left_expr
= right_expr
;
1355 right_vsl
= tmp_vsl
;
1356 right_expr
= tmp_expr
;
1357 op
= flip_comparison(op
);
1358 false_op
= flip_comparison(false_op
);
1361 orig_comparison
= get_comparison(left_expr
, right_expr
);
1362 op
= comparison_intersection(orig_comparison
, op
);
1363 false_op
= comparison_intersection(orig_comparison
, false_op
);
1365 snprintf(state_name
, sizeof(state_name
), "%s vs %s", left
, right
);
1366 true_state
= alloc_compare_state(
1367 left_expr
, left
, left_vsl
,
1369 right_expr
, right
, right_vsl
);
1370 false_state
= alloc_compare_state(
1371 left_expr
, left
, left_vsl
,
1373 right_expr
, right
, right_vsl
);
1375 pre_stree
= clone_stree(__get_cur_stree());
1376 update_tf_data(pre_stree
, left_expr
, left
, left_vsl
, right_expr
, right
, right_vsl
, op
, false_op
);
1377 free_stree(&pre_stree
);
1379 set_true_false_states(comparison_id
, state_name
, NULL
, true_state
, false_state
);
1380 __compare_param_limit_hook(left_expr
, right_expr
, state_name
, true_state
, false_state
);
1381 save_link(left_expr
, state_name
);
1382 save_link(right_expr
, state_name
);
1385 *_false_state
= false_state
;
1387 *_state_name
= state_name
;
1393 void __comparison_match_condition(struct expression
*expr
)
1395 struct expression
*left
, *right
, *new_left
, *new_right
, *tmp
;
1396 struct smatch_state
*false_state
= NULL
;
1397 char *state_name
= NULL
;
1400 if (expr
->type
!= EXPR_COMPARE
)
1403 handle_comparison(expr
->left
, expr
->op
, expr
->right
, &state_name
, &false_state
);
1404 if (false_state
&& state_name
)
1405 handle_for_loops(expr
, state_name
, false_state
);
1407 left
= strip_parens(expr
->left
);
1408 right
= strip_parens(expr
->right
);
1410 if (left
->type
== EXPR_BINOP
&& left
->op
== '+') {
1411 new_left
= left
->left
;
1412 new_right
= binop_expression(right
, '-', left
->right
);
1413 handle_comparison(new_left
, expr
->op
, new_right
, NULL
, NULL
);
1415 new_left
= left
->right
;
1416 new_right
= binop_expression(right
, '-', left
->left
);
1417 handle_comparison(new_left
, expr
->op
, new_right
, NULL
, NULL
);
1421 left
= strip_parens(expr
->left
);
1422 right
= strip_parens(expr
->right
);
1423 if (get_last_expr_from_expression_stmt(expr
->left
)) {
1424 left
= get_last_expr_from_expression_stmt(expr
->left
);
1427 if (get_last_expr_from_expression_stmt(expr
->right
)) {
1428 right
= get_last_expr_from_expression_stmt(expr
->right
);
1436 while ((tmp
= get_assigned_expr(left
))) {
1439 left
= strip_expr(tmp
);
1442 while ((tmp
= get_assigned_expr(right
))) {
1445 right
= strip_expr(tmp
);
1448 handle_comparison(left
, expr
->op
, right
, NULL
, NULL
);
1451 static void add_comparison_var_sym(
1452 struct expression
*left_expr
,
1453 const char *left_name
, struct var_sym_list
*left_vsl
,
1455 struct expression
*right_expr
,
1456 const char *right_name
, struct var_sym_list
*right_vsl
)
1458 struct smatch_state
*state
;
1460 char state_name
[256];
1462 if (strcmp(left_name
, right_name
) > 0) {
1463 struct expression
*tmp_expr
= left_expr
;
1464 const char *tmp_name
= left_name
;
1465 struct var_sym_list
*tmp_vsl
= left_vsl
;
1467 left_expr
= right_expr
;
1468 left_name
= right_name
;
1469 left_vsl
= right_vsl
;
1470 right_expr
= tmp_expr
;
1471 right_name
= tmp_name
;
1472 right_vsl
= tmp_vsl
;
1473 comparison
= flip_comparison(comparison
);
1475 snprintf(state_name
, sizeof(state_name
), "%s vs %s", left_name
, right_name
);
1476 state
= alloc_compare_state(
1477 left_expr
, left_name
, left_vsl
,
1479 right_expr
, right_name
, right_vsl
);
1481 set_state(comparison_id
, state_name
, NULL
, state
);
1483 FOR_EACH_PTR(left_vsl
, vs
) {
1484 save_link_var_sym(vs
->var
, vs
->sym
, state_name
);
1485 } END_FOR_EACH_PTR(vs
);
1486 FOR_EACH_PTR(right_vsl
, vs
) {
1487 save_link_var_sym(vs
->var
, vs
->sym
, state_name
);
1488 } END_FOR_EACH_PTR(vs
);
1491 static void add_comparison(struct expression
*left
, int comparison
, struct expression
*right
)
1493 char *left_name
= NULL
;
1494 char *right_name
= NULL
;
1495 struct symbol
*left_sym
, *right_sym
;
1496 struct var_sym_list
*left_vsl
, *right_vsl
;
1497 struct smatch_state
*state
;
1498 char state_name
[256];
1500 left_name
= chunk_to_var_sym(left
, &left_sym
);
1503 left_vsl
= expr_to_vsl(left
);
1504 right_name
= chunk_to_var_sym(right
, &right_sym
);
1507 right_vsl
= expr_to_vsl(right
);
1509 if (strcmp(left_name
, right_name
) > 0) {
1510 struct expression
*tmp_expr
= left
;
1511 struct symbol
*tmp_sym
= left_sym
;
1512 char *tmp_name
= left_name
;
1513 struct var_sym_list
*tmp_vsl
= left_vsl
;
1516 left_name
= right_name
;
1517 left_sym
= right_sym
;
1518 left_vsl
= right_vsl
;
1520 right_name
= tmp_name
;
1521 right_sym
= tmp_sym
;
1522 right_vsl
= tmp_vsl
;
1523 comparison
= flip_comparison(comparison
);
1525 snprintf(state_name
, sizeof(state_name
), "%s vs %s", left_name
, right_name
);
1526 state
= alloc_compare_state(
1527 left
, left_name
, left_vsl
,
1529 right
, right_name
, right_vsl
);
1531 set_state(comparison_id
, state_name
, NULL
, state
);
1532 save_link(left
, state_name
);
1533 save_link(right
, state_name
);
1536 free_string(left_name
);
1537 free_string(right_name
);
1540 static void match_assign_add(struct expression
*expr
)
1542 struct expression
*right
;
1543 struct expression
*r_left
, *r_right
;
1544 sval_t left_tmp
, right_tmp
;
1546 right
= strip_expr(expr
->right
);
1547 r_left
= strip_expr(right
->left
);
1548 r_right
= strip_expr(right
->right
);
1550 get_absolute_min(r_left
, &left_tmp
);
1551 get_absolute_min(r_right
, &right_tmp
);
1553 if (left_tmp
.value
> 0)
1554 add_comparison(expr
->left
, '>', r_right
);
1555 else if (left_tmp
.value
== 0)
1556 add_comparison(expr
->left
, SPECIAL_GTE
, r_right
);
1558 if (right_tmp
.value
> 0)
1559 add_comparison(expr
->left
, '>', r_left
);
1560 else if (right_tmp
.value
== 0)
1561 add_comparison(expr
->left
, SPECIAL_GTE
, r_left
);
1564 static void match_assign_sub(struct expression
*expr
)
1566 struct expression
*right
;
1567 struct expression
*r_left
, *r_right
;
1571 right
= strip_expr(expr
->right
);
1572 r_left
= strip_expr(right
->left
);
1573 r_right
= strip_expr(right
->right
);
1575 if (get_absolute_min(r_right
, &min
) && sval_is_negative(min
))
1578 comparison
= get_comparison(r_left
, r_right
);
1580 switch (comparison
) {
1583 if (implied_not_equal(r_right
, 0))
1584 add_comparison(expr
->left
, '>', r_left
);
1586 add_comparison(expr
->left
, SPECIAL_GTE
, r_left
);
1591 static void match_assign_divide(struct expression
*expr
)
1593 struct expression
*right
;
1594 struct expression
*r_left
, *r_right
;
1597 right
= strip_expr(expr
->right
);
1598 r_left
= strip_expr(right
->left
);
1599 r_right
= strip_expr(right
->right
);
1600 if (!get_implied_min(r_right
, &min
) || min
.value
<= 1)
1603 add_comparison(expr
->left
, '<', r_left
);
1606 static void match_binop_assign(struct expression
*expr
)
1608 struct expression
*right
;
1610 right
= strip_expr(expr
->right
);
1611 if (right
->op
== '+')
1612 match_assign_add(expr
);
1613 if (right
->op
== '-')
1614 match_assign_sub(expr
);
1615 if (right
->op
== '/')
1616 match_assign_divide(expr
);
1619 static void copy_comparisons(struct expression
*left
, struct expression
*right
)
1621 struct string_list
*links
;
1622 struct smatch_state
*state
;
1623 struct compare_data
*data
;
1624 struct symbol
*left_sym
, *right_sym
;
1625 char *left_var
= NULL
;
1626 char *right_var
= NULL
;
1627 struct var_sym_list
*left_vsl
;
1628 struct expression
*expr
;
1630 struct var_sym_list
*vsl
;
1634 left_var
= chunk_to_var_sym(left
, &left_sym
);
1637 left_vsl
= expr_to_vsl(left
);
1638 right_var
= chunk_to_var_sym(right
, &right_sym
);
1642 state
= get_state(link_id
, right_var
, right_sym
);
1645 links
= state
->data
;
1647 FOR_EACH_PTR(links
, tmp
) {
1648 state
= get_state(comparison_id
, tmp
, NULL
);
1649 if (!state
|| !state
->data
)
1652 comparison
= data
->comparison
;
1654 var
= data
->right_var
;
1655 vsl
= data
->right_vsl
;
1656 if (strcmp(var
, right_var
) == 0) {
1658 var
= data
->left_var
;
1659 vsl
= data
->left_vsl
;
1660 comparison
= flip_comparison(comparison
);
1662 /* n = copy_from_user(dest, src, n); leads to n <= n which is nonsense */
1663 if (strcmp(left_var
, var
) == 0)
1665 add_comparison_var_sym(left
, left_var
, left_vsl
, comparison
, expr
, var
, vsl
);
1666 } END_FOR_EACH_PTR(tmp
);
1669 free_string(right_var
);
1672 static bool is_empty_fake_assign(struct expression
*expr
)
1674 if (!__in_fake_var_assign
)
1676 if (get_state_chunk(link_id
, expr
->right
))
1681 static void match_assign(struct expression
*expr
)
1683 struct expression
*right
;
1685 if (expr
->op
!= '=')
1687 if (__in_fake_assign
|| outside_of_function())
1690 if (is_struct(expr
->left
))
1693 if (is_self_assign(expr
))
1696 if (is_empty_fake_assign(expr
))
1699 copy_comparisons(expr
->left
, expr
->right
);
1700 add_comparison(expr
->left
, SPECIAL_EQUAL
, expr
->right
);
1702 right
= strip_expr(expr
->right
);
1703 if (right
->type
== EXPR_BINOP
)
1704 match_binop_assign(expr
);
1707 int get_comparison_strings(const char *one
, const char *two
)
1710 struct smatch_state
*state
;
1715 return UNKNOWN_COMPARISON
;
1717 if (strcmp(one
, two
) == 0)
1718 return SPECIAL_EQUAL
;
1720 if (strcmp(one
, two
) > 0) {
1721 const char *tmp
= one
;
1728 snprintf(buf
, sizeof(buf
), "%s vs %s", one
, two
);
1729 state
= get_state(comparison_id
, buf
, NULL
);
1731 ret
= state_to_comparison(state
);
1734 ret
= flip_comparison(ret
);
1739 static int get_comparison_helper(struct expression
*a
, struct expression
*b
, bool use_extra
)
1743 int ret
= UNKNOWN_COMPARISON
;
1744 int extra
= UNKNOWN_COMPARISON
;
1746 if (a
== UNKNOWN_COMPARISON
||
1747 b
== UNKNOWN_COMPARISON
)
1748 return UNKNOWN_COMPARISON
;
1750 a
= strip_parens(a
);
1751 b
= strip_parens(b
);
1753 move_plus_to_minus(&a
, &b
);
1755 simplify_binops(&a
, &b
);
1757 one
= chunk_to_var(a
);
1760 two
= chunk_to_var(b
);
1764 ret
= get_comparison_strings(one
, two
);
1768 if (is_plus_one(a
) || is_minus_one(a
)) {
1770 one
= chunk_to_var(a
->left
);
1771 ret
= get_comparison_strings(one
, two
);
1772 } else if (is_plus_one(b
) || is_minus_one(b
)) {
1774 two
= chunk_to_var(b
->left
);
1775 ret
= get_comparison_strings(one
, two
);
1778 if (ret
== UNKNOWN_COMPARISON
)
1781 if ((is_plus_one(a
) || is_minus_one(b
)) && ret
== '<')
1783 else if ((is_minus_one(a
) || is_plus_one(b
)) && ret
== '>')
1786 ret
= UNKNOWN_COMPARISON
;
1793 extra
= comparison_from_extra(a
, b
);
1794 return comparison_intersection(ret
, extra
);
1797 int get_comparison(struct expression
*a
, struct expression
*b
)
1799 return get_comparison_helper(a
, b
, true);
1802 int get_comparison_no_extra(struct expression
*a
, struct expression
*b
)
1804 return get_comparison_helper(a
, b
, false);
1807 int possible_comparison(struct expression
*a
, int comparison
, struct expression
*b
)
1813 struct sm_state
*sm
;
1816 one
= chunk_to_var(a
);
1819 two
= chunk_to_var(b
);
1824 if (strcmp(one
, two
) == 0 && comparison
== SPECIAL_EQUAL
) {
1829 if (strcmp(one
, two
) > 0) {
1834 comparison
= flip_comparison(comparison
);
1837 snprintf(buf
, sizeof(buf
), "%s vs %s", one
, two
);
1838 sm
= get_sm_state(comparison_id
, buf
, NULL
);
1842 FOR_EACH_PTR(sm
->possible
, sm
) {
1843 if (!sm
->state
->data
)
1845 saved
= ((struct compare_data
*)sm
->state
->data
)->comparison
;
1846 if (saved
== comparison
)
1848 if (comparison
== SPECIAL_EQUAL
&&
1849 (saved
== SPECIAL_LTE
||
1850 saved
== SPECIAL_GTE
||
1851 saved
== SPECIAL_UNSIGNED_LTE
||
1852 saved
== SPECIAL_UNSIGNED_GTE
))
1856 } END_FOR_EACH_PTR(sm
);
1865 struct state_list
*get_all_comparisons(struct expression
*expr
)
1867 struct smatch_state
*state
;
1868 struct string_list
*links
;
1869 struct state_list
*ret
= NULL
;
1870 struct sm_state
*sm
;
1873 state
= get_state_chunk(link_id
, expr
);
1876 links
= state
->data
;
1878 FOR_EACH_PTR(links
, tmp
) {
1879 sm
= get_sm_state(comparison_id
, tmp
, NULL
);
1882 // FIXME have to compare name with vsl
1883 add_ptr_list(&ret
, sm
);
1884 } END_FOR_EACH_PTR(tmp
);
1889 struct state_list
*get_all_possible_equal_comparisons(struct expression
*expr
)
1891 struct smatch_state
*state
;
1892 struct string_list
*links
;
1893 struct state_list
*ret
= NULL
;
1894 struct sm_state
*sm
;
1897 state
= get_state_chunk(link_id
, expr
);
1900 links
= state
->data
;
1902 FOR_EACH_PTR(links
, tmp
) {
1903 sm
= get_sm_state(comparison_id
, tmp
, NULL
);
1906 if (!strchr(sm
->state
->name
, '='))
1908 if (strcmp(sm
->state
->name
, "!=") == 0)
1910 add_ptr_list(&ret
, sm
);
1911 } END_FOR_EACH_PTR(tmp
);
1916 struct state_list
*get_all_possible_not_equal_comparisons(struct expression
*expr
)
1918 struct smatch_state
*state
;
1919 struct string_list
*links
;
1920 struct state_list
*ret
= NULL
;
1921 struct sm_state
*sm
;
1922 struct sm_state
*possible
;
1927 state
= get_state_chunk(link_id
, expr
);
1930 links
= state
->data
;
1932 FOR_EACH_PTR(links
, link
) {
1933 sm
= get_sm_state(comparison_id
, link
, NULL
);
1936 FOR_EACH_PTR(sm
->possible
, possible
) {
1937 if (strcmp(possible
->state
->name
, "!=") != 0)
1939 add_ptr_list(&ret
, sm
);
1941 } END_FOR_EACH_PTR(possible
);
1942 } END_FOR_EACH_PTR(link
);
1947 static void update_links_from_call(struct expression
*left
,
1949 struct expression
*right
)
1951 struct string_list
*links
;
1952 struct smatch_state
*state
;
1953 struct compare_data
*data
;
1954 struct symbol
*left_sym
, *right_sym
;
1955 char *left_var
= NULL
;
1956 char *right_var
= NULL
;
1957 struct var_sym_list
*left_vsl
;
1958 struct expression
*expr
;
1960 struct var_sym_list
*vsl
;
1964 left_var
= chunk_to_var_sym(left
, &left_sym
);
1967 left_vsl
= expr_to_vsl(left
);
1968 right_var
= chunk_to_var_sym(right
, &right_sym
);
1972 state
= get_state(link_id
, right_var
, right_sym
);
1975 links
= state
->data
;
1977 FOR_EACH_PTR(links
, tmp
) {
1978 state
= get_state(comparison_id
, tmp
, NULL
);
1979 if (!state
|| !state
->data
)
1982 comparison
= data
->comparison
;
1984 var
= data
->right_var
;
1985 vsl
= data
->right_vsl
;
1986 if (strcmp(var
, right_var
) == 0) {
1988 var
= data
->left_var
;
1989 vsl
= data
->left_vsl
;
1990 comparison
= flip_comparison(comparison
);
1992 comparison
= combine_comparisons(left_compare
, comparison
);
1995 add_comparison_var_sym(left
, left_var
, left_vsl
, comparison
, expr
, var
, vsl
);
1996 } END_FOR_EACH_PTR(tmp
);
1999 free_string(right_var
);
2002 void __add_return_comparison(struct expression
*call
, const char *range
)
2004 struct expression
*arg
;
2008 if (!str_to_comparison_arg(range
, call
, &comparison
, &arg
))
2010 snprintf(buf
, sizeof(buf
), "%s", show_comparison(comparison
));
2011 update_links_from_call(call
, comparison
, arg
);
2012 add_comparison(call
, comparison
, arg
);
2015 void __add_comparison_info(struct expression
*expr
, struct expression
*call
, const char *range
)
2017 copy_comparisons(expr
, call
);
2020 static char *get_mask_comparison(struct expression
*expr
, int ignore
)
2022 struct expression
*tmp
, *right
;
2026 /* The return value for "return foo & param;" is <= param */
2029 while ((tmp
= get_assigned_expr(expr
))) {
2030 expr
= strip_expr(tmp
);
2035 if (expr
->type
!= EXPR_BINOP
|| expr
->op
!= '&')
2038 right
= strip_expr(expr
->right
);
2039 param
= get_param_num(right
);
2040 if (param
< 0 || param
== ignore
)
2043 snprintf(buf
, sizeof(buf
), "[<=$%d]", param
);
2044 return alloc_sname(buf
);
2047 static char *range_comparison_to_param_helper(struct expression
*expr
, char starts_with
, int ignore
)
2049 struct symbol
*param
;
2052 char *ret_str
= NULL
;
2059 var
= chunk_to_var(expr
);
2064 FOR_EACH_PTR(cur_func_sym
->ctype
.base_type
->arguments
, param
) {
2070 snprintf(buf
, sizeof(buf
), "%s orig", param
->ident
->name
);
2071 compare
= get_comparison_strings(var
, buf
);
2072 if (compare
== UNKNOWN_COMPARISON
||
2073 compare
== IMPOSSIBLE_COMPARISON
)
2075 if (show_comparison(compare
)[0] != starts_with
)
2077 snprintf(buf
, sizeof(buf
), "[%s$%d]", show_comparison(compare
), i
);
2078 ret_str
= alloc_sname(buf
);
2080 } END_FOR_EACH_PTR(param
);
2089 if (starts_with
== '<')
2090 ret_str
= get_mask_comparison(expr
, ignore
);
2094 char *name_sym_to_param_comparison(const char *name
, struct symbol
*sym
)
2096 struct symbol
*param
;
2102 FOR_EACH_PTR(cur_func_sym
->ctype
.base_type
->arguments
, param
) {
2106 snprintf(buf
, sizeof(buf
), "%s orig", param
->ident
->name
);
2107 compare
= get_comparison_strings(name
, buf
);
2108 if (compare
== UNKNOWN_COMPARISON
||
2109 compare
== IMPOSSIBLE_COMPARISON
)
2111 snprintf(buf
, sizeof(buf
), "[%s$%d]", show_comparison(compare
), i
);
2112 return alloc_sname(buf
);
2113 } END_FOR_EACH_PTR(param
);
2118 char *expr_equal_to_param(struct expression
*expr
, int ignore
)
2120 return range_comparison_to_param_helper(expr
, '=', ignore
);
2123 char *expr_lte_to_param(struct expression
*expr
, int ignore
)
2125 return range_comparison_to_param_helper(expr
, '<', ignore
);
2128 char *expr_param_comparison(struct expression
*expr
, int ignore
)
2130 struct symbol
*param
;
2133 char *ret_str
= NULL
;
2137 var
= chunk_to_var(expr
);
2142 FOR_EACH_PTR(cur_func_sym
->ctype
.base_type
->arguments
, param
) {
2148 snprintf(buf
, sizeof(buf
), "%s orig", param
->ident
->name
);
2149 compare
= get_comparison_strings(var
, buf
);
2152 snprintf(buf
, sizeof(buf
), "[%s$%d]", show_comparison(compare
), i
);
2153 ret_str
= alloc_sname(buf
);
2155 } END_FOR_EACH_PTR(param
);
2162 char *get_printed_param_name(struct expression
*call
, const char *param_name
, struct symbol
*param_sym
)
2164 struct expression
*arg
;
2167 static char buf
[256];
2172 FOR_EACH_PTR(call
->args
, arg
) {
2175 name
= expr_to_var_sym(arg
, &sym
);
2178 if (sym
!= param_sym
)
2182 if (strncmp(name
, param_name
, len
) != 0)
2184 if (param_name
[len
] == '\0') {
2185 snprintf(buf
, sizeof(buf
), "$%d", i
);
2188 if (param_name
[len
] != '-')
2190 snprintf(buf
, sizeof(buf
), "$%d%s", i
, param_name
+ len
);
2192 } END_FOR_EACH_PTR(arg
);
2197 static void match_call_info(struct expression
*expr
)
2199 struct expression
*arg
;
2200 struct smatch_state
*state
;
2201 struct sm_state
*sm
;
2202 struct compare_data
*data
;
2204 struct string_list
*links
;
2206 const char *right_name
;
2212 FOR_EACH_PTR(expr
->args
, arg
) {
2215 state
= get_state_chunk(link_id
, arg
);
2219 links
= state
->data
;
2220 FOR_EACH_PTR(links
, link
) {
2221 struct var_sym_list
*right_vsl
;
2222 struct var_sym
*right_vs
;
2225 if (strstr(link
, " orig"))
2227 sm
= get_sm_state(comparison_id
, link
, NULL
);
2230 data
= sm
->state
->data
;
2232 data
->comparison
== UNKNOWN_COMPARISON
||
2233 data
->comparison
== IMPOSSIBLE_COMPARISON
)
2235 arg_name
= expr_to_var(arg
);
2240 if (strcmp(data
->left_var
, arg_name
) == 0) {
2241 comparison
= data
->comparison
;
2242 right_name
= data
->right_var
;
2243 right_vsl
= data
->right_vsl
;
2244 } else if (strcmp(data
->right_var
, arg_name
) == 0) {
2245 comparison
= flip_comparison(data
->comparison
);
2246 right_name
= data
->left_var
;
2247 right_vsl
= data
->left_vsl
;
2249 if (!right_vsl
|| ptr_list_size((struct ptr_list
*)right_vsl
) != 1)
2252 right_vs
= first_ptr_list((struct ptr_list
*)right_vsl
);
2253 if (strcmp(right_vs
->var
, right_name
) != 0)
2255 right_name
= get_printed_param_name(expr
, right_vs
->var
, right_vs
->sym
);
2258 snprintf(info_buf
, sizeof(info_buf
), "%s %s", show_comparison(comparison
), right_name
);
2259 sql_insert_caller_info(expr
, PARAM_COMPARE
, i
, "$", info_buf
);
2262 free_string(arg_name
);
2263 } END_FOR_EACH_PTR(link
);
2264 } END_FOR_EACH_PTR(arg
);
2267 static void struct_member_callback(struct expression
*call
, int param
, char *printed_name
, struct sm_state
*link_sm
)
2269 struct sm_state
*compare_sm
;
2270 struct string_list
*links
;
2272 struct compare_data
*data
;
2273 struct var_sym
*left
, *right
;
2274 static char info_buf
[256];
2275 const char *right_name
;
2277 if (strstr(printed_name
, " orig"))
2280 links
= link_sm
->state
->data
;
2281 FOR_EACH_PTR(links
, link
) {
2282 compare_sm
= get_sm_state(comparison_id
, link
, NULL
);
2285 data
= compare_sm
->state
->data
;
2286 if (!data
|| !data
->comparison
)
2289 if (ptr_list_size((struct ptr_list
*)data
->left_vsl
) != 1 ||
2290 ptr_list_size((struct ptr_list
*)data
->right_vsl
) != 1)
2292 left
= first_ptr_list((struct ptr_list
*)data
->left_vsl
);
2293 right
= first_ptr_list((struct ptr_list
*)data
->right_vsl
);
2294 if (left
->sym
== right
->sym
&&
2295 strcmp(left
->var
, right
->var
) == 0)
2298 * Both parameters link to this comparison so only
2299 * record the first one.
2301 if (left
->sym
!= link_sm
->sym
||
2302 strcmp(left
->var
, link_sm
->name
) != 0)
2305 right_name
= get_printed_param_name(call
, right
->var
, right
->sym
);
2308 snprintf(info_buf
, sizeof(info_buf
), "%s %s", show_comparison(data
->comparison
), right_name
);
2309 sql_insert_caller_info(call
, PARAM_COMPARE
, param
, printed_name
, info_buf
);
2310 } END_FOR_EACH_PTR(link
);
2313 static void print_return_value_comparison(int return_id
, char *return_ranges
, struct expression
*expr
)
2316 const char *tmp_name
;
2320 bool is_addr
= false;
2323 * TODO: This only prints == comparisons. That's probably the most
2324 * useful comparison because == max has lots of implications. But it
2325 * would be good to capture the rest as well.
2327 * This information is already in the DB but it's in the parameter math
2328 * bits and it's awkward to use it. This is is the simpler, possibly
2329 * cleaner way, but not necessarily the best, I don't know.
2334 name
= expr_to_var_sym(expr
, &sym
);
2338 param
= get_param_num_from_sym(sym
);
2341 if (param_was_set_var_sym(name
, sym
))
2344 tmp_name
= get_param_name_var_sym(name
, sym
);
2348 if (tmp_name
[0] == '&') {
2355 snprintf(info_buf
, sizeof(info_buf
), "== %s$%d%s", is_addr
? "&" : "", param
, tmp_name
);
2356 sql_insert_return_states(return_id
, return_ranges
,
2357 PARAM_COMPARE
, -1, "$", info_buf
);
2362 static void print_return_comparison(int return_id
, char *return_ranges
, struct expression
*expr
)
2364 struct sm_state
*tmp
;
2365 struct string_list
*links
;
2367 struct sm_state
*sm
;
2368 struct compare_data
*data
;
2369 struct var_sym
*left
, *right
;
2370 int left_param
, right_param
;
2372 char right_buf
[256];
2374 const char *tmp_name
;
2376 print_return_value_comparison(return_id
, return_ranges
, expr
);
2378 FOR_EACH_MY_SM(link_id
, __get_cur_stree(), tmp
) {
2379 if (get_param_num_from_sym(tmp
->sym
) < 0)
2381 links
= tmp
->state
->data
;
2382 FOR_EACH_PTR(links
, link
) {
2383 sm
= get_sm_state(comparison_id
, link
, NULL
);
2386 data
= sm
->state
->data
;
2388 data
->comparison
== UNKNOWN_COMPARISON
||
2389 data
->comparison
== IMPOSSIBLE_COMPARISON
)
2391 if (ptr_list_size((struct ptr_list
*)data
->left_vsl
) != 1 ||
2392 ptr_list_size((struct ptr_list
*)data
->right_vsl
) != 1)
2394 left
= first_ptr_list((struct ptr_list
*)data
->left_vsl
);
2395 right
= first_ptr_list((struct ptr_list
*)data
->right_vsl
);
2396 if (left
->sym
== right
->sym
&&
2397 strcmp(left
->var
, right
->var
) == 0)
2400 * Both parameters link to this comparison so only
2401 * record the first one.
2403 if (left
->sym
!= tmp
->sym
||
2404 strcmp(left
->var
, tmp
->name
) != 0)
2407 if (strstr(right
->var
, " orig"))
2410 left_param
= get_param_num_from_sym(left
->sym
);
2411 right_param
= get_param_num_from_sym(right
->sym
);
2412 if (left_param
< 0 || right_param
< 0)
2415 tmp_name
= get_param_name_var_sym(left
->var
, left
->sym
);
2418 snprintf(left_buf
, sizeof(left_buf
), "%s", tmp_name
);
2420 tmp_name
= get_param_name_var_sym(right
->var
, right
->sym
);
2421 if (!tmp_name
|| tmp_name
[0] != '$')
2423 snprintf(right_buf
, sizeof(right_buf
), "$%d%s", right_param
, tmp_name
+ 1);
2426 * FIXME: this should reject $ type variables (as
2427 * opposed to $->foo type). Those should come from
2428 * smatch_param_compare_limit.c.
2431 snprintf(info_buf
, sizeof(info_buf
), "%s %s", show_comparison(data
->comparison
), right_buf
);
2432 sql_insert_return_states(return_id
, return_ranges
,
2433 PARAM_COMPARE
, left_param
, left_buf
, info_buf
);
2434 } END_FOR_EACH_PTR(link
);
2436 } END_FOR_EACH_SM(tmp
);
2439 static int parse_comparison(char **value
, int *op
)
2447 if (**value
== '=') {
2455 *op
= SPECIAL_EQUAL
;
2460 *op
= SPECIAL_NOTEQUAL
;
2464 if (**value
== '=') {
2473 if (**value
!= ' ') {
2474 sm_perror("parsing comparison. %s", *value
);
2482 static int split_op_param_key(char *value
, int *op
, int *param
, char **key
)
2484 static char buf
[256];
2487 if (!parse_comparison(&value
, op
))
2490 snprintf(buf
, sizeof(buf
), "%s", value
);
2497 if (*param
< 0 || *param
> 99)
2509 static void db_return_comparison(struct expression
*expr
, int left_param
, char *key
, char *value
)
2511 struct expression
*left_arg
, *right_arg
;
2512 char *left_name
= NULL
;
2513 struct symbol
*left_sym
;
2514 char *right_name
= NULL
;
2515 struct symbol
*right_sym
;
2519 struct var_sym_list
*left_vsl
= NULL
, *right_vsl
= NULL
;
2521 if (left_param
== -1) {
2522 if (expr
->type
!= EXPR_ASSIGNMENT
)
2524 left_arg
= strip_expr(expr
->left
);
2526 while (expr
->type
== EXPR_ASSIGNMENT
)
2527 expr
= strip_expr(expr
->right
);
2528 if (expr
->type
!= EXPR_CALL
)
2531 while (expr
->type
== EXPR_ASSIGNMENT
)
2532 expr
= strip_expr(expr
->right
);
2533 if (expr
->type
!= EXPR_CALL
)
2536 left_arg
= get_argument_from_call_expr(expr
->args
, left_param
);
2541 if (!split_op_param_key(value
, &op
, &right_param
, &right_key
))
2544 right_arg
= get_argument_from_call_expr(expr
->args
, right_param
);
2548 left_name
= get_variable_from_key(left_arg
, key
, &left_sym
);
2549 if (!left_name
|| !left_sym
)
2552 right_name
= get_variable_from_key(right_arg
, right_key
, &right_sym
);
2553 if (!right_name
|| !right_sym
)
2556 add_var_sym(&left_vsl
, left_name
, left_sym
);
2557 add_var_sym(&right_vsl
, right_name
, right_sym
);
2559 add_comparison_var_sym(NULL
, left_name
, left_vsl
, op
, NULL
, right_name
, right_vsl
);
2562 free_string(left_name
);
2563 free_string(right_name
);
2566 int param_compare_limit_is_impossible(struct expression
*expr
, int left_param
, char *left_key
, char *value
)
2568 struct smatch_state
*state
;
2569 char *left_name
= NULL
;
2570 char *right_name
= NULL
;
2571 struct symbol
*left_sym
, *right_sym
;
2572 struct expression
*left_arg
, *right_arg
;
2579 while (expr
->type
== EXPR_ASSIGNMENT
)
2580 expr
= strip_expr(expr
->right
);
2581 if (expr
->type
!= EXPR_CALL
)
2584 if (!split_op_param_key(value
, &op
, &right_param
, &right_key
))
2587 left_arg
= get_argument_from_call_expr(expr
->args
, left_param
);
2591 right_arg
= get_argument_from_call_expr(expr
->args
, right_param
);
2595 left_name
= get_variable_from_key(left_arg
, left_key
, &left_sym
);
2596 right_name
= get_variable_from_key(right_arg
, right_key
, &right_sym
);
2597 if (!left_name
|| !right_name
)
2600 snprintf(buf
, sizeof(buf
), "%s vs %s", left_name
, right_name
);
2601 state
= get_state(comparison_id
, buf
, NULL
);
2604 state_op
= state_to_comparison(state
);
2608 if (!comparison_intersection(remove_unsigned_from_comparison(state_op
), op
))
2611 free_string(left_name
);
2612 free_string(right_name
);
2616 int impossibly_high_comparison(struct expression
*expr
)
2618 struct smatch_state
*link_state
;
2619 struct sm_state
*sm
;
2620 struct string_list
*links
;
2622 struct compare_data
*data
;
2624 link_state
= get_state_expr(link_id
, expr
);
2626 if (expr
->type
== EXPR_BINOP
&&
2627 (impossibly_high_comparison(expr
->left
) ||
2628 impossibly_high_comparison(expr
->right
)))
2633 links
= link_state
->data
;
2634 FOR_EACH_PTR(links
, link
) {
2635 sm
= get_sm_state(comparison_id
, link
, NULL
);
2638 data
= sm
->state
->data
;
2641 if (!possibly_true(data
->left
, data
->comparison
, data
->right
))
2643 } END_FOR_EACH_PTR(link
);
2648 static void free_data(struct symbol
*sym
)
2652 clear_compare_data_alloc();
2655 void register_comparison(int id
)
2658 set_dynamic_states(comparison_id
);
2659 add_hook(&save_start_states
, AFTER_DEF_HOOK
);
2660 add_unmatched_state_hook(comparison_id
, unmatched_comparison
);
2661 add_pre_merge_hook(comparison_id
, &pre_merge_hook
);
2662 add_merge_hook(comparison_id
, &merge_compare_states
);
2663 add_hook(&free_data
, AFTER_FUNC_HOOK
);
2664 add_hook(&match_call_info
, FUNCTION_CALL_HOOK
);
2665 add_split_return_callback(&print_return_comparison
);
2667 select_return_states_hook(PARAM_COMPARE
, &db_return_comparison
);
2668 add_hook(&match_preop
, OP_HOOK
);
2671 void register_comparison_late(int id
)
2673 add_hook(&match_assign
, ASSIGNMENT_HOOK
);
2676 void register_comparison_links(int id
)
2679 db_ignore_states(link_id
);
2680 set_dynamic_states(link_id
);
2681 add_merge_hook(link_id
, &merge_links
);
2682 add_modification_hook(link_id
, &match_modify
);
2683 add_modification_hook_late(link_id
, match_inc_dec
);
2685 add_member_info_callback(link_id
, struct_member_callback
);
2688 void register_comparison_inc_dec(int id
)
2691 add_modification_hook_late(inc_dec_id
, &iter_modify
);
2694 void register_comparison_inc_dec_links(int id
)
2696 inc_dec_link_id
= id
;
2697 set_dynamic_states(inc_dec_link_id
);
2698 set_up_link_functions(inc_dec_id
, inc_dec_link_id
);
2701 static struct sm_state
*clone_partial_sm(struct sm_state
*sm
, int comparison
)
2703 struct compare_data
*data
;
2704 struct sm_state
*clone
;
2705 struct stree
*stree
;
2707 data
= sm
->state
->data
;
2709 clone
= clone_sm(sm
);
2710 clone
->state
= alloc_compare_state(data
->left
, data
->left_var
, data
->left_vsl
,
2712 data
->right
, data
->right_var
, data
->right_vsl
);
2713 free_slist(&clone
->possible
);
2714 add_possible_sm(clone
, clone
);
2716 stree
= clone_stree(sm
->pool
);
2717 overwrite_sm_state_stree(&stree
, clone
);
2718 clone
->pool
= stree
;
2723 static void create_fake_history(struct sm_state
*sm
, int op
,
2724 struct state_list
**true_stack
,
2725 struct state_list
**false_stack
)
2727 struct sm_state
*true_sm
, *false_sm
;
2728 struct compare_data
*data
;
2729 int true_comparison
;
2730 int false_comparison
;
2732 data
= sm
->state
->data
;
2734 if (is_merged(sm
) || sm
->left
|| sm
->right
)
2737 true_comparison
= comparison_intersection(data
->comparison
, op
);
2738 false_comparison
= comparison_intersection(data
->comparison
, negate_comparison(op
));
2740 true_sm
= clone_partial_sm(sm
, true_comparison
);
2741 false_sm
= clone_partial_sm(sm
, false_comparison
);
2745 sm
->right
= false_sm
;
2747 add_ptr_list(true_stack
, true_sm
);
2748 add_ptr_list(false_stack
, false_sm
);
2751 static void filter_by_sm(struct sm_state
*sm
, int op
,
2752 struct state_list
**true_stack
,
2753 struct state_list
**false_stack
,
2756 struct compare_data
*data
;
2762 data
= sm
->state
->data
;
2765 if (data
->comparison
== IMPOSSIBLE_COMPARISON
)
2769 * We want to check that "data->comparison" is totally inside "op". So
2770 * if data->comparison is < and op is <= then that's true. Or if
2771 * data->comparison is == and op is <= then that's true. But if
2772 * data->comparison is <= and op is < than that's neither true nor
2775 if (data
->comparison
== comparison_intersection(data
->comparison
, op
))
2777 if (data
->comparison
== comparison_intersection(data
->comparison
, negate_comparison(op
)))
2780 if (!is_true
&& !is_false
&& !is_merged(sm
)) {
2781 create_fake_history(sm
, op
, true_stack
, false_stack
);
2785 if (debug_implied()) {
2786 sm_msg("%s: %s: op = '%s' negated '%s'. true_intersect = '%s' false_insersect = '%s' sm = '%s'",
2789 alloc_sname(show_comparison(op
)),
2790 alloc_sname(show_comparison(negate_comparison(op
))),
2791 alloc_sname(show_comparison(comparison_intersection(data
->comparison
, op
))),
2792 alloc_sname(show_comparison(comparison_intersection(data
->comparison
, negate_comparison(op
)))),
2798 add_ptr_list(true_stack
, sm
);
2800 add_ptr_list(false_stack
, sm
);
2802 filter_by_sm(sm
->left
, op
, true_stack
, false_stack
, useful
);
2803 filter_by_sm(sm
->right
, op
, true_stack
, false_stack
, useful
);
2806 struct sm_state
*comparison_implication_hook(struct expression
*expr
,
2807 struct state_list
**true_stack
,
2808 struct state_list
**false_stack
)
2810 struct sm_state
*sm
;
2813 static char buf
[256];
2814 bool useful
= false;
2816 if (expr
->type
!= EXPR_COMPARE
)
2821 left
= expr_to_var(expr
->left
);
2822 right
= expr_to_var(expr
->right
);
2823 if (!left
|| !right
) {
2829 if (strcmp(left
, right
) > 0) {
2834 op
= flip_comparison(op
);
2837 snprintf(buf
, sizeof(buf
), "%s vs %s", left
, right
);
2838 sm
= get_sm_state(comparison_id
, buf
, NULL
);
2844 filter_by_sm(sm
, op
, true_stack
, false_stack
, &useful
);
2848 if (debug_implied())
2849 sm_msg("implications from comparison: (%s)", show_sm(sm
));