2 * sparse/check_locking.c
4 * Copyright (C) 2009 Dan Carpenter.
6 * Licensed under the Open Software License version 1.1
11 * This test checks that locks are held the same across all returns.
13 * Of course, some functions are designed to only hold the locks on success.
14 * Oh well... We can rewrite it later if we want.
19 #include "smatch_slist.h"
21 static const char *lock_funcs
[] = {
27 "_spin_lock_irqsave_nested",
34 "_write_lock_irqsave",
43 static const char *unlock_funcs
[] = {
45 "_spin_unlock_irqrestore",
50 "_read_unlock_irqrestore",
54 "_write_unlock_irqrestore",
62 /* These are return 1 if they aquire the lock */
63 static const char *conditional_funcs
[] = {
68 "generic__raw_read_trylock",
74 "__raw_write_trylock",
75 "__raw_write_trylock",
80 /* These functions return 0 on success */
81 static const char *reverse_cond_funcs
[] = {
84 "mutex_lock_interruptible",
85 "mutex_lock_interruptible_nested",
86 "mutex_lock_killable",
87 "mutex_lock_killable_nested",
91 /* todo still need to handle__raw_spin_is_locked */
98 static struct locked_call lock_needed
[] = {
99 {"tty_ldisc_ref_wait", "tty_ldisc_lock"},
104 static struct tracker_list
*starts_locked
;
105 static struct tracker_list
*starts_unlocked
;
107 struct locks_on_return
{
109 struct tracker_list
*locked
;
110 struct tracker_list
*unlocked
;
112 DECLARE_PTR_LIST(return_list
, struct locks_on_return
);
113 static struct return_list
*all_returns
;
119 static struct smatch_state
*get_start_state(struct sm_state
*sm
)
124 if (in_tracker_list(starts_locked
, sm
->name
, my_id
, sm
->sym
))
126 if (in_tracker_list(starts_unlocked
, sm
->name
, my_id
, sm
->sym
))
128 if (is_locked
&& is_unlocked
)
137 static struct smatch_state
*unmatched_state(struct sm_state
*sm
)
142 static char *match_func(const char *list
[], char *fn_name
,
143 struct expression_list
*args
)
145 struct expression
*lock_expr
;
148 for (i
= 0; list
[i
]; i
++) {
149 if (!strcmp(fn_name
, list
[i
])) {
150 lock_expr
= get_argument_from_call_expr(args
, 0);
151 return get_variable_from_expr(lock_expr
, NULL
);
157 static char *get_lock_name(struct expression
*expr
, void *data
)
159 struct expression
*lock_expr
;
162 return alloc_string((char *)data
);
164 lock_expr
= get_argument_from_call_expr(expr
->args
, 0);
165 return get_variable_from_expr(lock_expr
, NULL
);
169 static void match_lock_func(const char *fn
, struct expression
*expr
, void *data
)
174 lock_name
= get_lock_name(expr
, data
);
177 sm
= get_sm_state(lock_name
, my_id
, NULL
);
179 add_tracker(&starts_unlocked
, lock_name
, my_id
, NULL
);
180 if (sm
&& slist_has_state(sm
->possible
, &locked
))
181 smatch_msg("error: double lock '%s'", lock_name
);
182 set_state(lock_name
, my_id
, NULL
, &locked
);
183 free_string(lock_name
);
186 static void match_unlock_func(const char *fn
, struct expression
*expr
,
192 lock_name
= get_lock_name(expr
, data
);
195 sm
= get_sm_state(lock_name
, my_id
, NULL
);
197 add_tracker(&starts_locked
, lock_name
, my_id
, NULL
);
198 if (sm
&& slist_has_state(sm
->possible
, &unlocked
))
199 smatch_msg("error: double unlock '%s'", lock_name
);
200 set_state(lock_name
, my_id
, NULL
, &unlocked
);
201 free_string(lock_name
);
204 static void match_lock_needed(const char *fn
, struct expression
*expr
,
207 struct smatch_state
*state
;
210 state
= get_state((char *)data
, my_id
, NULL
);
211 if (state
== &locked
)
213 fn_name
= get_variable_from_expr(expr
->fn
, NULL
);
215 smatch_msg("Internal error.");
218 smatch_msg("error: %s called without holding '%s' lock", fn_name
,
220 free_string(fn_name
);
223 static void match_condition(struct expression
*expr
)
228 if (expr
->type
!= EXPR_CALL
)
231 fn_name
= get_variable_from_expr(expr
->fn
, NULL
);
235 if ((lock_name
= match_func(conditional_funcs
, fn_name
, expr
->args
))) {
236 if (!get_state(lock_name
, my_id
, NULL
))
237 add_tracker(&starts_unlocked
, lock_name
, my_id
, NULL
);
238 set_true_false_states(lock_name
, my_id
, NULL
, &locked
, &unlocked
);
240 if ((lock_name
= match_func(reverse_cond_funcs
, fn_name
, expr
->args
))) {
241 if (!get_state(lock_name
, my_id
, NULL
))
242 add_tracker(&starts_unlocked
, lock_name
, my_id
, NULL
);
243 set_true_false_states(lock_name
, my_id
, NULL
, &unlocked
, &locked
);
245 free_string(lock_name
);
246 free_string(fn_name
);
250 static struct locks_on_return
*alloc_return(int line
)
252 struct locks_on_return
*ret
;
254 ret
= malloc(sizeof(*ret
));
257 ret
->unlocked
= NULL
;
261 static void check_possible(struct sm_state
*sm
)
263 struct sm_state
*tmp
;
268 FOR_EACH_PTR(sm
->possible
, tmp
) {
269 if (tmp
->state
== &locked
)
271 if (tmp
->state
== &unlocked
)
273 if (tmp
->state
== &start_state
) {
274 struct smatch_state
*s
;
276 s
= get_start_state(tmp
);
279 else if (s
== &unlocked
)
284 if (tmp
->state
== &undefined
)
285 undef
= 1; // i don't think this is possible any more.
286 } END_FOR_EACH_PTR(tmp
);
287 if ((islocked
&& isunlocked
) || undef
)
288 smatch_msg("warn: '%s' is sometimes locked here and "
289 "sometimes unlocked.", sm
->name
);
292 static void match_return(struct statement
*stmt
)
294 struct locks_on_return
*ret
;
295 struct state_list
*slist
;
296 struct sm_state
*tmp
;
298 ret
= alloc_return(get_lineno());
300 slist
= get_all_states(my_id
);
301 FOR_EACH_PTR(slist
, tmp
) {
302 if (tmp
->state
== &locked
) {
303 add_tracker(&ret
->locked
, tmp
->name
, tmp
->owner
,
305 } else if (tmp
->state
== &unlocked
) {
306 add_tracker(&ret
->unlocked
, tmp
->name
, tmp
->owner
,
308 } else if (tmp
->state
== &start_state
) {
309 struct smatch_state
*s
;
311 s
= get_start_state(tmp
);
313 add_tracker(&ret
->locked
, tmp
->name
, tmp
->owner
,
316 add_tracker(&ret
->unlocked
, tmp
->name
,
317 tmp
->owner
, tmp
->sym
);
321 } END_FOR_EACH_PTR(tmp
);
323 add_ptr_list(&all_returns
, ret
);
326 static void check_returns_consistently(struct tracker
*lock
,
327 struct smatch_state
*start
)
329 int returns_locked
= 0;
330 int returns_unlocked
= 0;
331 struct locks_on_return
*tmp
;
333 FOR_EACH_PTR(all_returns
, tmp
) {
334 if (in_tracker_list(tmp
->unlocked
, lock
->name
, lock
->owner
,
336 returns_unlocked
= tmp
->line
;
337 else if (in_tracker_list(tmp
->locked
, lock
->name
, lock
->owner
,
339 returns_locked
= tmp
->line
;
340 else if (start
== &locked
)
341 returns_locked
= tmp
->line
;
342 else if (start
== &unlocked
)
343 returns_unlocked
= tmp
->line
;
344 } END_FOR_EACH_PTR(tmp
);
346 if (returns_locked
&& returns_unlocked
)
347 smatch_msg("warn: lock '%s' held on line %d but not on %d.",
348 lock
->name
, returns_locked
, returns_unlocked
);
352 static void check_consistency(struct symbol
*sym
)
359 FOR_EACH_PTR(starts_locked
, tmp
) {
360 if (in_tracker_list(starts_unlocked
, tmp
->name
, tmp
->owner
,
362 smatch_msg("error: locking inconsistency. We assume "
363 "'%s' is both locked and unlocked at the "
366 } END_FOR_EACH_PTR(tmp
);
368 FOR_EACH_PTR(starts_locked
, tmp
) {
369 check_returns_consistently(tmp
, &locked
);
370 } END_FOR_EACH_PTR(tmp
);
372 FOR_EACH_PTR(starts_unlocked
, tmp
) {
373 check_returns_consistently(tmp
, &unlocked
);
374 } END_FOR_EACH_PTR(tmp
);
378 static void clear_lists(void)
380 struct locks_on_return
*tmp
;
382 free_trackers_and_list(&starts_locked
);
383 free_trackers_and_list(&starts_unlocked
);
385 FOR_EACH_PTR(all_returns
, tmp
) {
386 free_trackers_and_list(&tmp
->locked
);
387 free_trackers_and_list(&tmp
->unlocked
);
388 } END_FOR_EACH_PTR(tmp
);
389 __free_ptr_list((struct ptr_list
**)&all_returns
);
392 static void match_func_end(struct symbol
*sym
)
394 check_consistency(sym
);
398 void check_locking(int id
)
403 add_unmatched_state_hook(my_id
, &unmatched_state
);
404 add_hook(&match_condition
, CONDITION_HOOK
);
405 add_hook(&match_return
, RETURN_HOOK
);
406 add_hook(&match_func_end
, END_FUNC_HOOK
);
408 for (i
= 0; lock_funcs
[i
]; i
++) {
409 add_function_hook(lock_funcs
[i
], &match_lock_func
, NULL
);
411 add_function_hook("lock_kernel", &match_lock_func
, (void *)"kernel");
412 for (i
= 0; unlock_funcs
[i
]; i
++) {
413 add_function_hook(unlock_funcs
[i
], &match_unlock_func
, NULL
);
415 add_function_hook("unlock_kernel", &match_unlock_func
, (void *)"kernel");
416 for (i
= 0; i
< sizeof(lock_needed
)/sizeof(struct locked_call
); i
++) {
417 add_function_hook(lock_needed
[i
].function
, &match_lock_needed
,
418 (void *)lock_needed
[i
].lock
);