check_unwind.c

   1 /*
   2  * Copyright (C) 2020 Oracle.
   3  *
   4  * This program is free software; you can redistribute it and/or
   5  * modify it under the terms of the GNU General Public License
   6  * as published by the Free Software Foundation; either version 2
   7  * of the License, or (at your option) any later version.
   8  *
   9  * This program is distributed in the hope that it will be useful,
  10  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  11  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  12  * GNU General Public License for more details.
  13  *
  14  * You should have received a copy of the GNU General Public License
  15  * along with this program; if not, see http://www.gnu.org/copyleft/gpl.txt
  16  */
  17
  18 #include <ctype.h>
  19
  20 #include "smatch.h"
  21 #include "smatch_extra.h"
  22 #include "smatch_slist.h"
  23
  24 static int my_id;
  25
  26 STATE(alloc);
  27 STATE(release);
  28 STATE(param_released);
  29 STATE(ignore);
  30
  31 static unsigned long fn_has_alloc;
  32
  33 struct ref_func_info {
  34         const char *name;
  35         int type;
  36         int param;
  37         const char *key;
  38         const sval_t *implies_start, *implies_end;
  39         func_hook *call_back;
  40 };
  41
  42 static sval_t zero_sval = { .type = &int_ctype };
  43
  44 static struct ref_func_info func_table[] = {
  45         { "clk_prepare_enable",    ALLOC, 0, "$", &zero_sval, &zero_sval },
  46         { "clk_disable_unprepare", RELEASE, 0, "$" },
  47
  48         { "alloc_etherdev_mqs", ALLOC, -1, "$", &valid_ptr_min_sval, &valid_ptr_max_sval },
  49         { "free_netdev", RELEASE, 0, "$" },
  50
  51         /*
  52          * FIXME: A common pattern in release functions like amd76xrom_cleanup()
  53          * is to do:
  54          *
  55          *      if (window->rsrc.parent)
  56          *              release_resource(&window->rsrc);
  57          *
  58          * Which is slightly tricky to know how to merge the states so let's
  59          * hold off checking request_resource() for now.
  60          *
  61          * { "request_resource", ALLOC,   1, "$", &zero_sval, &zero_sval },
  62          * { "release_resource", RELEASE, 0, "$" },
  63          *
  64          */
  65
  66         { "pci_request_regions", ALLOC,   0, "$", &zero_sval, &zero_sval },
  67         { "pci_release_regions", RELEASE, 0, "$" },
  68
  69         { "request_free_mem_region", ALLOC,   -1, "$->start", &valid_ptr_min_sval, &valid_ptr_max_sval },
  70         { "__request_region", ALLOC,   1, "$", &valid_ptr_min_sval, &valid_ptr_max_sval },
  71         { "__release_region", RELEASE, 1, "$" },
  72
  73         { "ioremap", ALLOC,  -1, "$", &valid_ptr_min_sval, &valid_ptr_max_sval },
  74         { "of_iomap", ALLOC,  -1, "$", &valid_ptr_min_sval, &valid_ptr_max_sval },
  75         { "ioremap_encrypted", ALLOC,  -1, "$", &valid_ptr_min_sval, &valid_ptr_max_sval },
  76         { "iounmap", RELEASE, 0, "$" },
  77
  78         { "request_threaded_irq", ALLOC,   0, "$", &zero_sval, &zero_sval },
  79         { "request_irq", ALLOC,   0, "$", &zero_sval, &zero_sval },
  80         { "free_irq",    RELEASE, 0, "$" },
  81         { "pci_request_irq", ALLOC,   1, "$", &zero_sval, &zero_sval },
  82         { "pci_free_irq",    RELEASE, 1, "$" },
  83
  84         { "register_netdev",   ALLOC,   0, "$", &zero_sval, &zero_sval },
  85         { "unregister_netdev", RELEASE, 0, "$" },
  86
  87         { "misc_register",   ALLOC,   0, "$", &zero_sval, &zero_sval },
  88         { "misc_deregister", RELEASE, 0, "$" },
  89
  90         { "ieee80211_alloc_hw", ALLOC,  -1, "$", &valid_ptr_min_sval, &valid_ptr_max_sval },
  91         { "ieee80211_free_hw",  RELEASE, 0, "$" },
  92 };
  93
  94 struct smatch_state *unmatched_state(struct sm_state *sm)
  95 {
  96         struct smatch_state *state;
  97
  98         if (sm->state != &param_released)
  99                 return &undefined;
 100
 101         if (is_impossible_path())
 102                 return &param_released;
 103
 104         state = get_state(SMATCH_EXTRA, sm->name, sm->sym);
 105         if (!state)
 106                 return &undefined;
 107         if (!estate_rl(state) || is_err_or_null(estate_rl(state)))
 108                 return &param_released;
 109         if (parent_is_err_or_null_var_sym(sm->name, sm->sym))
 110                 return &param_released;
 111
 112          return &undefined;
 113 }
 114
 115 static struct sm_state *get_start_sm(const char *name, struct symbol *sym)
 116 {
 117         struct sm_state *sm;
 118
 119         sm = get_sm_state(my_id, name, sym);
 120         if (sm)
 121                 return sm;
 122
 123         FOR_EACH_MY_SM(my_id, __get_cur_stree(), sm) {
 124                 if (get_comparison_strings(name, sm->name) == SPECIAL_EQUAL)
 125                         return sm;
 126         } END_FOR_EACH_SM(sm);
 127
 128         return NULL;
 129 }
 130
 131 static bool is_param_var_sym(const char *name, struct symbol *sym)
 132 {
 133         const char *key;
 134
 135         return get_param_key_from_var_sym(name, sym, NULL, &key) >= 0;
 136 }
 137
 138 static void mark_matches_as_undefined(const char *key)
 139 {
 140         struct sm_state *sm;
 141         int start_pos, state_len, key_len;
 142         char *p;
 143
 144         while ((p = strchr(key, '-'))) {
 145                 if (p[1] != '>')
 146                         return;
 147                 key = p + 2;
 148         }
 149         key_len = strlen(key);
 150
 151         FOR_EACH_MY_SM(my_id, __get_cur_stree(), sm) {
 152                 state_len = strlen(sm->name);
 153                 if (state_len < key_len)
 154                         continue;
 155                 if (!slist_has_state(sm->possible, &alloc))
 156                         continue;
 157
 158                 start_pos = state_len - key_len;
 159                 if ((start_pos == 0 || !isalnum(sm->name[start_pos - 1])) &&
 160                     strcmp(sm->name + start_pos, key) == 0)
 161                         set_state(my_id, sm->name, sm->sym, &undefined);
 162
 163         } END_FOR_EACH_SM(sm);
 164 }
 165
 166 static void db_helper(struct expression *expr, int param, const char *key, int inc_dec)
 167 {
 168         struct sm_state *start_sm;
 169         char *name;
 170         struct symbol *sym;
 171
 172         if (inc_dec == ALLOC)
 173                 fn_has_alloc = true;
 174
 175         name = get_name_sym_from_key(expr, param, key, &sym);
 176         if (!name || !sym)
 177                 goto free;
 178
 179         start_sm = get_start_sm(name, sym);
 180         if (inc_dec == RELEASE && !start_sm) {
 181                 if (fn_has_alloc) {
 182                         mark_matches_as_undefined(key);
 183                         goto free;
 184                 }
 185                 if (is_param_var_sym(name, sym)) {
 186                         set_state(my_id, name, sym, &param_released);
 187                         goto free;
 188                 }
 189                 goto free;
 190         }
 191
 192         if (inc_dec == ALLOC)
 193                 set_state(my_id, name, sym, &alloc);
 194         else {
 195                 if (start_sm)
 196                         set_state(my_id, start_sm->name, start_sm->sym, &release);
 197                 else
 198                         set_state(my_id, name, sym, &release);
 199         }
 200 free:
 201         free_string(name);
 202 }
 203
 204 static void refcount_function(const char *fn, struct expression *expr, void *data)
 205 {
 206         struct ref_func_info *info = data;
 207
 208         db_helper(expr, info->param, info->key, info->type);
 209 }
 210
 211 static void refcount_implied(const char *fn, struct expression *call_expr,
 212                              struct expression *assign_expr, void *data)
 213 {
 214         struct ref_func_info *info = data;
 215
 216         db_helper(assign_expr ?: call_expr, info->param, info->key, info->type);
 217 }
 218
 219 static void ignore_path(const char *fn, struct expression *expr, void *data)
 220 {
 221         set_state(my_id, "path", NULL, &ignore);
 222 }
 223
 224 static bool is_alloc_primitive(struct expression *expr)
 225 {
 226         int i;
 227
 228         while (expr->type == EXPR_ASSIGNMENT)
 229                 expr = strip_expr(expr->right);
 230         if (expr->type != EXPR_CALL)
 231                 return false;
 232
 233         if (expr->fn->type != EXPR_SYMBOL)
 234                 return false;
 235
 236         for (i = 0; i < ARRAY_SIZE(func_table); i++) {
 237                 if (sym_name_is(func_table[i].name, expr->fn))
 238                         return true;
 239         }
 240
 241         return false;
 242 }
 243
 244 static void db_dec(struct expression *expr, int param, char *key, char *value)
 245 {
 246         if (is_alloc_primitive(expr))
 247                 return;
 248         db_helper(expr, param, key, RELEASE);
 249 }
 250
 251 static void match_return_info(int return_id, char *return_ranges, struct expression *expr)
 252 {
 253         struct sm_state *sm;
 254         const char *param_name;
 255         int param;
 256
 257         if (is_impossible_path())
 258                 return;
 259
 260         FOR_EACH_MY_SM(my_id, __get_cur_stree(), sm) {
 261                 if (sm->state != &param_released)
 262                         continue;
 263                 param = get_param_key_from_sm(sm, expr, &param_name);
 264                 if (param < 0)
 265                         continue;
 266                 sql_insert_return_states(return_id, return_ranges, RELEASE,
 267                                          param, param_name, "");
 268         } END_FOR_EACH_SM(sm);
 269 }
 270
 271 enum {
 272         EMPTY, NEGATIVE, ZERO, POSITIVE, NUM_BUCKETS
 273 };
 274
 275 static int success_fail_positive(struct range_list *rl)
 276 {
 277         if (!rl)
 278                 return EMPTY;
 279
 280         if (sval_is_negative(rl_min(rl)) && sval_is_negative(rl_max(rl)))
 281                 return NEGATIVE;
 282
 283         if (rl_min(rl).value == 0)
 284                 return ZERO;
 285
 286         return POSITIVE;
 287 }
 288
 289 static void check_balance(const char *name, struct symbol *sym)
 290 {
 291         struct range_list *inc_lines = NULL;
 292         int inc_buckets[NUM_BUCKETS] = {};
 293         struct stree *stree, *orig_stree;
 294         struct smatch_state *state;
 295         struct sm_state *return_sm;
 296         struct sm_state *sm;
 297         sval_t line = sval_type_val(&int_ctype, 0);
 298         int bucket;
 299
 300         FOR_EACH_PTR(get_all_return_strees(), stree) {
 301                 orig_stree = __swap_cur_stree(stree);
 302
 303                 if (is_impossible_path())
 304                         goto swap_stree;
 305                 if (db_incomplete())
 306                         goto swap_stree;
 307
 308                 return_sm = get_sm_state(RETURN_ID, "return_ranges", NULL);
 309                 if (!return_sm)
 310                         goto swap_stree;
 311                 line.value = return_sm->line;
 312
 313                 sm = get_sm_state(my_id, name, sym);
 314                 if (!sm)
 315                         goto swap_stree;
 316
 317                 state = sm->state;
 318                 if (state == &param_released)
 319                         state = &release;
 320
 321                 if (state != &alloc &&
 322                     state != &release)
 323                         goto swap_stree;
 324
 325                 bucket = success_fail_positive(estate_rl(return_sm->state));
 326                 if (bucket != NEGATIVE)
 327                         goto swap_stree;
 328
 329                 if (state == &alloc) {
 330                         add_range(&inc_lines, line, line);
 331                         inc_buckets[bucket] = true;
 332                 }
 333 swap_stree:
 334                 __swap_cur_stree(orig_stree);
 335         } END_FOR_EACH_PTR(stree);
 336
 337         if (inc_buckets[NEGATIVE])
 338                 goto complain;
 339
 340         return;
 341
 342 complain:
 343         sm_warning("'%s' not released on lines: %s.", name, show_rl(inc_lines));
 344 }
 345
 346 static void match_check_balanced(struct symbol *sym)
 347 {
 348         struct sm_state *sm;
 349
 350         FOR_EACH_MY_SM(my_id, get_all_return_states(), sm) {
 351                 check_balance(sm->name, sm->sym);
 352         } END_FOR_EACH_SM(sm);
 353 }
 354
 355 void check_unwind(int id)
 356 {
 357         struct ref_func_info *info;
 358         int i;
 359
 360         my_id = id;
 361
 362         if (option_project != PROJ_KERNEL)
 363                 return;
 364
 365         for (i = 0; i < ARRAY_SIZE(func_table); i++) {
 366                 info = &func_table[i];
 367
 368                 if (info->call_back) {
 369                         add_function_hook(info->name, info->call_back, info);
 370                 } else if (info->implies_start) {
 371                         return_implies_state_sval(info->name,
 372                                         *info->implies_start,
 373                                         *info->implies_end,
 374                                         &refcount_implied, info);
 375                 } else {
 376                         add_function_hook(info->name, &refcount_function, info);
 377                 }
 378         }
 379
 380         add_function_hook("devm_add_action_or_reset", &ignore_path, NULL);
 381
 382         add_unmatched_state_hook(my_id, &unmatched_state);
 383         add_function_data(&fn_has_alloc);
 384
 385         add_split_return_callback(match_return_info);
 386         select_return_states_hook(RELEASE, &db_dec);
 387         add_hook(&match_check_balanced, END_FUNC_HOOK);
 388 }