2 * Copyright (C) 2012 Oracle.
4 * This program is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU General Public License
6 * as published by the Free Software Foundation; either version 2
7 * of the License, or (at your option) any later version.
9 * This program is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details.
14 * You should have received a copy of the GNU General Public License
15 * along with this program; if not, see http://www.gnu.org/copyleft/gpl.txt
19 * The point here is to store the relationships between two variables.
21 * To do that we create a state with the two variables in alphabetical order:
22 * ->name = "x vs y" and the state would be "<". On the false path the state
25 * Part of the trick of it is that if x or y is modified then we need to reset
26 * the state. We need to keep a list of all the states which depend on x and
27 * all the states which depend on y. The link_id code handles this.
32 #include "smatch_extra.h"
33 #include "smatch_slist.h"
35 static int compare_id
;
37 static int inc_dec_id
;
38 static int inc_dec_link_id
;
40 /* for handling for loops */
44 ALLOCATOR(compare_data
, "compare data");
46 static struct symbol
*vsl_to_sym(struct var_sym_list
*vsl
)
52 if (ptr_list_size((struct ptr_list
*)vsl
) != 1)
54 vs
= first_ptr_list((struct ptr_list
*)vsl
);
58 struct smatch_state
*alloc_compare_state(
59 const char *var1
, struct var_sym_list
*vsl1
,
61 const char *var2
, struct var_sym_list
*vsl2
)
63 struct smatch_state
*state
;
64 struct compare_data
*data
;
66 state
= __alloc_smatch_state(0);
67 state
->name
= alloc_sname(show_special(comparison
));
68 data
= __alloc_compare_data(0);
69 data
->var1
= alloc_sname(var1
);
70 data
->vsl1
= clone_var_sym_list(vsl1
);
71 data
->comparison
= comparison
;
72 data
->var2
= alloc_sname(var2
);
73 data
->vsl2
= clone_var_sym_list(vsl2
);
78 int state_to_comparison(struct smatch_state
*state
)
80 if (!state
|| !state
->data
)
82 return ((struct compare_data
*)state
->data
)->comparison
;
86 * flip_comparison() reverses the op left and right. So "x >= y" becomes "y <= x".
88 int flip_comparison(int op
)
95 case SPECIAL_UNSIGNED_LT
:
96 return SPECIAL_UNSIGNED_GT
;
99 case SPECIAL_UNSIGNED_LTE
:
100 return SPECIAL_UNSIGNED_GTE
;
102 return SPECIAL_EQUAL
;
103 case SPECIAL_NOTEQUAL
:
104 return SPECIAL_NOTEQUAL
;
107 case SPECIAL_UNSIGNED_GTE
:
108 return SPECIAL_UNSIGNED_LTE
;
111 case SPECIAL_UNSIGNED_GT
:
112 return SPECIAL_UNSIGNED_LT
;
114 sm_msg("internal smatch bug. unhandled comparison %d", op
);
119 int negate_comparison(int op
)
126 case SPECIAL_UNSIGNED_LT
:
127 return SPECIAL_UNSIGNED_GTE
;
130 case SPECIAL_UNSIGNED_LTE
:
131 return SPECIAL_UNSIGNED_GT
;
133 return SPECIAL_NOTEQUAL
;
134 case SPECIAL_NOTEQUAL
:
135 return SPECIAL_EQUAL
;
138 case SPECIAL_UNSIGNED_GTE
:
139 return SPECIAL_UNSIGNED_LT
;
142 case SPECIAL_UNSIGNED_GT
:
143 return SPECIAL_UNSIGNED_LTE
;
145 sm_msg("internal smatch bug. unhandled comparison %d", op
);
150 static int rl_comparison(struct range_list
*left_rl
, struct range_list
*right_rl
)
152 sval_t left_min
, left_max
, right_min
, right_max
;
154 if (!left_rl
|| !right_rl
)
157 left_min
= rl_min(left_rl
);
158 left_max
= rl_max(left_rl
);
159 right_min
= rl_min(right_rl
);
160 right_max
= rl_max(right_rl
);
162 if (left_min
.value
== left_max
.value
&&
163 right_min
.value
== right_max
.value
&&
164 left_min
.value
== right_min
.value
)
165 return SPECIAL_EQUAL
;
167 if (sval_cmp(left_max
, right_min
) < 0)
169 if (sval_cmp(left_max
, right_min
) == 0)
171 if (sval_cmp(left_min
, right_max
) > 0)
173 if (sval_cmp(left_min
, right_max
) == 0)
179 static struct range_list
*get_orig_rl(struct var_sym_list
*vsl
)
182 struct smatch_state
*state
;
186 sym
= vsl_to_sym(vsl
);
187 if (!sym
|| !sym
->ident
)
189 state
= get_orig_estate(sym
->ident
->name
, sym
);
190 return estate_rl(state
);
193 static struct smatch_state
*unmatched_comparison(struct sm_state
*sm
)
195 struct compare_data
*data
= sm
->state
->data
;
196 struct range_list
*left_rl
, *right_rl
;
202 if (strstr(data
->var1
, " orig"))
203 left_rl
= get_orig_rl(data
->vsl1
);
204 else if (!get_implied_rl_var_sym(data
->var1
, vsl_to_sym(data
->vsl1
), &left_rl
))
206 if (strstr(data
->var2
, " orig"))
207 right_rl
= get_orig_rl(data
->vsl2
);
208 else if (!get_implied_rl_var_sym(data
->var2
, vsl_to_sym(data
->vsl2
), &right_rl
))
212 op
= rl_comparison(left_rl
, right_rl
);
214 return alloc_compare_state(data
->var1
, data
->vsl1
, op
, data
->var2
, data
->vsl2
);
219 /* remove_unsigned_from_comparison() is obviously a hack. */
220 static int remove_unsigned_from_comparison(int op
)
223 case SPECIAL_UNSIGNED_LT
:
225 case SPECIAL_UNSIGNED_LTE
:
227 case SPECIAL_UNSIGNED_GTE
:
229 case SPECIAL_UNSIGNED_GT
:
237 * This is for when you merge states "a < b" and "a == b", the result is that
238 * we can say for sure, "a <= b" after the merge.
240 int merge_comparisons(int one
, int two
)
244 one
= remove_unsigned_from_comparison(one
);
245 two
= remove_unsigned_from_comparison(two
);
295 return SPECIAL_NOTEQUAL
;
306 * This is for if you have "a < b" and "b <= c". Or in other words,
307 * "a < b <= c". You would call this like get_combined_comparison('<', '<=').
308 * The return comparison would be '<'.
310 * This function is different from merge_comparisons(), for example:
311 * merge_comparison('<', '==') returns '<='
312 * get_combined_comparison('<', '==') returns '<'
314 int combine_comparisons(int left_compare
, int right_compare
)
318 left_compare
= remove_unsigned_from_comparison(left_compare
);
319 right_compare
= remove_unsigned_from_comparison(right_compare
);
323 switch (left_compare
) {
332 return right_compare
;
341 switch (right_compare
) {
373 static int filter_comparison(int orig
, int op
)
385 case SPECIAL_NOTEQUAL
:
395 case SPECIAL_NOTEQUAL
:
404 case SPECIAL_UNSIGNED_LTE
:
405 case SPECIAL_UNSIGNED_GTE
:
406 return SPECIAL_EQUAL
;
409 case SPECIAL_NOTEQUAL
:
414 case SPECIAL_UNSIGNED_LT
:
415 case SPECIAL_UNSIGNED_LTE
:
416 return SPECIAL_UNSIGNED_LT
;
417 case SPECIAL_NOTEQUAL
:
422 case SPECIAL_UNSIGNED_GT
:
423 case SPECIAL_UNSIGNED_GTE
:
424 return SPECIAL_UNSIGNED_GT
;
430 return SPECIAL_EQUAL
;
435 case SPECIAL_NOTEQUAL
:
443 case SPECIAL_NOTEQUAL
:
447 case SPECIAL_UNSIGNED_LT
:
449 case SPECIAL_UNSIGNED_LT
:
450 case SPECIAL_UNSIGNED_LTE
:
451 case SPECIAL_NOTEQUAL
:
452 return SPECIAL_UNSIGNED_LT
;
455 case SPECIAL_UNSIGNED_LTE
:
457 case SPECIAL_UNSIGNED_LT
:
458 case SPECIAL_UNSIGNED_LTE
:
461 case SPECIAL_NOTEQUAL
:
462 return SPECIAL_UNSIGNED_LT
;
463 case SPECIAL_UNSIGNED_GTE
:
464 return SPECIAL_EQUAL
;
467 case SPECIAL_UNSIGNED_GTE
:
469 case SPECIAL_UNSIGNED_LTE
:
470 return SPECIAL_EQUAL
;
471 case SPECIAL_NOTEQUAL
:
472 return SPECIAL_UNSIGNED_GT
;
474 case SPECIAL_UNSIGNED_GTE
:
475 case SPECIAL_UNSIGNED_GT
:
479 case SPECIAL_UNSIGNED_GT
:
481 case SPECIAL_UNSIGNED_GT
:
482 case SPECIAL_UNSIGNED_GTE
:
483 case SPECIAL_NOTEQUAL
:
484 return SPECIAL_UNSIGNED_GT
;
491 struct smatch_state
*merge_compare_states(struct smatch_state
*s1
, struct smatch_state
*s2
)
493 struct compare_data
*data
= s1
->data
;
496 op
= merge_comparisons(state_to_comparison(s1
), state_to_comparison(s2
));
498 return alloc_compare_state(data
->var1
, data
->vsl1
, op
, data
->var2
, data
->vsl2
);
502 static struct smatch_state
*alloc_link_state(struct string_list
*links
)
504 struct smatch_state
*state
;
505 static char buf
[256];
509 state
= __alloc_smatch_state(0);
512 FOR_EACH_PTR(links
, tmp
) {
514 snprintf(buf
, sizeof(buf
), "%s", tmp
);
516 append(buf
, ", ", sizeof(buf
));
517 append(buf
, tmp
, sizeof(buf
));
519 } END_FOR_EACH_PTR(tmp
);
521 state
->name
= alloc_sname(buf
);
526 static void save_start_states(struct statement
*stmt
)
528 struct symbol
*param
;
530 char state_name
[128];
531 struct smatch_state
*state
;
532 struct string_list
*links
;
535 FOR_EACH_PTR(cur_func_sym
->ctype
.base_type
->arguments
, param
) {
536 struct var_sym_list
*vsl1
= NULL
;
537 struct var_sym_list
*vsl2
= NULL
;
541 snprintf(orig
, sizeof(orig
), "%s orig", param
->ident
->name
);
542 snprintf(state_name
, sizeof(state_name
), "%s vs %s", param
->ident
->name
, orig
);
543 add_var_sym(&vsl1
, param
->ident
->name
, param
);
544 add_var_sym(&vsl2
, orig
, param
);
545 state
= alloc_compare_state(param
->ident
->name
, vsl1
, SPECIAL_EQUAL
, alloc_sname(orig
), vsl2
);
546 set_state(compare_id
, state_name
, NULL
, state
);
548 link
= alloc_sname(state_name
);
550 insert_string(&links
, link
);
551 state
= alloc_link_state(links
);
552 set_state(link_id
, param
->ident
->name
, param
, state
);
553 } END_FOR_EACH_PTR(param
);
556 static struct smatch_state
*merge_links(struct smatch_state
*s1
, struct smatch_state
*s2
)
558 struct smatch_state
*ret
;
559 struct string_list
*links
;
561 links
= combine_string_lists(s1
->data
, s2
->data
);
562 ret
= alloc_link_state(links
);
566 static void save_link_var_sym(const char *var
, struct symbol
*sym
, const char *link
)
568 struct smatch_state
*old_state
, *new_state
;
569 struct string_list
*links
;
572 old_state
= get_state(link_id
, var
, sym
);
574 links
= clone_str_list(old_state
->data
);
578 new = alloc_sname(link
);
579 insert_string(&links
, new);
581 new_state
= alloc_link_state(links
);
582 set_state(link_id
, var
, sym
, new_state
);
585 static void match_inc(struct sm_state
*sm
)
587 struct string_list
*links
;
588 struct smatch_state
*state
;
591 links
= sm
->state
->data
;
593 FOR_EACH_PTR(links
, tmp
) {
594 state
= get_state(compare_id
, tmp
, NULL
);
596 switch (state_to_comparison(state
)) {
599 case SPECIAL_UNSIGNED_GTE
:
601 case SPECIAL_UNSIGNED_GT
: {
602 struct compare_data
*data
= state
->data
;
603 struct smatch_state
*new;
605 new = alloc_compare_state(data
->var1
, data
->vsl1
, '>', data
->var2
, data
->vsl2
);
606 set_state(compare_id
, tmp
, NULL
, new);
610 set_state(compare_id
, tmp
, NULL
, &undefined
);
612 } END_FOR_EACH_PTR(tmp
);
615 static void match_dec(struct sm_state
*sm
)
617 struct string_list
*links
;
618 struct smatch_state
*state
;
621 links
= sm
->state
->data
;
623 FOR_EACH_PTR(links
, tmp
) {
624 state
= get_state(compare_id
, tmp
, NULL
);
626 switch (state_to_comparison(state
)) {
629 case SPECIAL_UNSIGNED_LTE
:
631 case SPECIAL_UNSIGNED_LT
: {
632 struct compare_data
*data
= state
->data
;
633 struct smatch_state
*new;
635 new = alloc_compare_state(data
->var1
, data
->vsl1
, '<', data
->var2
, data
->vsl2
);
636 set_state(compare_id
, tmp
, NULL
, new);
640 set_state(compare_id
, tmp
, NULL
, &undefined
);
642 } END_FOR_EACH_PTR(tmp
);
645 static int match_inc_dec(struct sm_state
*sm
, struct expression
*mod_expr
)
649 if (mod_expr
->type
!= EXPR_PREOP
&& mod_expr
->type
!= EXPR_POSTOP
)
652 if (mod_expr
->op
== SPECIAL_INCREMENT
) {
656 if (mod_expr
->op
== SPECIAL_DECREMENT
) {
663 static void match_modify(struct sm_state
*sm
, struct expression
*mod_expr
)
665 struct string_list
*links
;
669 * if (foo > bar) then ++foo is also > bar.
671 if (match_inc_dec(sm
, mod_expr
))
674 links
= sm
->state
->data
;
676 FOR_EACH_PTR(links
, tmp
) {
677 set_state(compare_id
, tmp
, NULL
, &undefined
);
678 } END_FOR_EACH_PTR(tmp
);
679 set_state(link_id
, sm
->name
, sm
->sym
, &undefined
);
682 static char *chunk_to_var_sym(struct expression
*expr
, struct symbol
**sym
)
684 expr
= strip_expr(expr
);
690 if (expr
->type
== EXPR_PREOP
&&
691 (expr
->op
== SPECIAL_INCREMENT
||
692 expr
->op
== SPECIAL_DECREMENT
))
693 expr
= strip_expr(expr
->unop
);
695 return expr_to_chunk_sym_vsl(expr
, sym
, NULL
);
698 static char *chunk_to_var(struct expression
*expr
)
700 return chunk_to_var_sym(expr
, NULL
);
703 static void save_link(struct expression
*expr
, char *link
)
708 expr
= strip_expr(expr
);
709 if (expr
->type
== EXPR_BINOP
) {
712 chunk
= chunk_to_var(expr
);
716 save_link(expr
->left
, link
);
717 save_link(expr
->right
, link
);
718 save_link_var_sym(chunk
, NULL
, link
);
722 var
= expr_to_var_sym(expr
, &sym
);
726 save_link_var_sym(var
, sym
, link
);
731 static int get_orig_comparison(struct stree
*pre_stree
, const char *left
, const char *right
)
733 struct smatch_state
*state
;
734 struct compare_data
*data
;
736 char state_name
[256];
738 if (strcmp(left
, right
) > 0) {
739 const char *tmp
= right
;
746 snprintf(state_name
, sizeof(state_name
), "%s vs %s", left
, right
);
747 state
= get_state_stree(pre_stree
, compare_id
, state_name
, NULL
);
748 if (!state
|| !state
->data
)
752 return flip_comparison(data
->comparison
);
753 return data
->comparison
;
757 static int have_common_var_sym(struct var_sym_list
*left_vsl
, struct var_sym_list
*right_vsl
)
761 FOR_EACH_PTR(left_vsl
, tmp
) {
762 if (in_var_sym_list(right_vsl
, tmp
->var
, tmp
->sym
))
764 } END_FOR_EACH_PTR(tmp
);
770 * The idea here is that we take a comparison "a < b" and then we look at all
771 * the things which "b" is compared against "b < c" and we say that that implies
772 * a relationship "a < c".
774 * The names here about because the comparisons are organized like this
778 static void update_tf_links(struct stree
*pre_stree
,
779 const char *left_var
, struct var_sym_list
*left_vsl
,
780 int left_comparison
, int left_false_comparison
,
781 const char *mid_var
, struct var_sym_list
*mid_vsl
,
782 struct string_list
*links
)
784 struct smatch_state
*state
;
785 struct smatch_state
*true_state
, *false_state
;
786 struct compare_data
*data
;
787 const char *right_var
;
788 struct var_sym_list
*right_vsl
;
790 int right_comparison
;
792 int false_comparison
;
794 char state_name
[256];
797 FOR_EACH_PTR(links
, tmp
) {
798 state
= get_state_stree(pre_stree
, compare_id
, tmp
, NULL
);
799 if (!state
|| !state
->data
)
802 right_comparison
= data
->comparison
;
803 right_var
= data
->var2
;
804 right_vsl
= data
->vsl2
;
805 if (strcmp(mid_var
, right_var
) == 0) {
806 right_var
= data
->var1
;
807 right_vsl
= data
->vsl1
;
808 right_comparison
= flip_comparison(right_comparison
);
810 if (have_common_var_sym(left_vsl
, right_vsl
))
813 orig_comparison
= get_orig_comparison(pre_stree
, left_var
, right_var
);
815 true_comparison
= combine_comparisons(left_comparison
, right_comparison
);
816 false_comparison
= combine_comparisons(left_false_comparison
, right_comparison
);
818 true_comparison
= filter_comparison(orig_comparison
, true_comparison
);
819 false_comparison
= filter_comparison(orig_comparison
, false_comparison
);
821 if (strcmp(left_var
, right_var
) > 0) {
822 const char *tmp_var
= left_var
;
823 struct var_sym_list
*tmp_vsl
= left_vsl
;
825 left_var
= right_var
;
826 left_vsl
= right_vsl
;
829 true_comparison
= flip_comparison(true_comparison
);
830 false_comparison
= flip_comparison(false_comparison
);
833 if (!true_comparison
&& !false_comparison
)
837 true_state
= alloc_compare_state(left_var
, left_vsl
, true_comparison
, right_var
, right_vsl
);
840 if (false_comparison
)
841 false_state
= alloc_compare_state(left_var
, left_vsl
, false_comparison
, right_var
, right_vsl
);
845 snprintf(state_name
, sizeof(state_name
), "%s vs %s", left_var
, right_var
);
846 set_true_false_states(compare_id
, state_name
, NULL
, true_state
, false_state
);
847 FOR_EACH_PTR(left_vsl
, vs
) {
848 save_link_var_sym(vs
->var
, vs
->sym
, state_name
);
849 } END_FOR_EACH_PTR(vs
);
850 FOR_EACH_PTR(right_vsl
, vs
) {
851 save_link_var_sym(vs
->var
, vs
->sym
, state_name
);
852 } END_FOR_EACH_PTR(vs
);
853 if (!vsl_to_sym(left_vsl
))
854 save_link_var_sym(left_var
, NULL
, state_name
);
855 if (!vsl_to_sym(right_vsl
))
856 save_link_var_sym(right_var
, NULL
, state_name
);
857 } END_FOR_EACH_PTR(tmp
);
860 static void update_tf_data(struct stree
*pre_stree
,
861 const char *left_name
, struct var_sym_list
*left_vsl
,
862 const char *right_name
, struct var_sym_list
*right_vsl
,
863 int true_comparison
, int false_comparison
)
865 struct smatch_state
*state
;
867 state
= get_state_stree(pre_stree
, link_id
, right_name
, vsl_to_sym(right_vsl
));
869 update_tf_links(pre_stree
, left_name
, left_vsl
, true_comparison
, false_comparison
, right_name
, right_vsl
, state
->data
);
871 state
= get_state_stree(pre_stree
, link_id
, left_name
, vsl_to_sym(left_vsl
));
873 update_tf_links(pre_stree
, right_name
, right_vsl
, flip_comparison(true_comparison
), flip_comparison(false_comparison
), left_name
, left_vsl
, state
->data
);
876 static void iter_modify(struct sm_state
*sm
, struct expression
*mod_expr
)
878 if (sm
->state
!= &start
||
880 (mod_expr
->type
!= EXPR_PREOP
&& mod_expr
->type
!= EXPR_POSTOP
) ||
881 mod_expr
->op
!= SPECIAL_INCREMENT
)
882 set_state(inc_dec_id
, sm
->name
, sm
->sym
, &undefined
);
884 set_state(inc_dec_id
, sm
->name
, sm
->sym
, &incremented
);
887 static void handle_for_loops(struct expression
*expr
, char *state_name
, struct smatch_state
*false_state
)
890 char *iter_name
, *cap_name
;
891 struct symbol
*iter_sym
, *cap_sym
;
892 struct compare_data
*data
;
894 if (expr
->op
!= '<' && expr
->op
!= SPECIAL_UNSIGNED_LT
)
897 if (!__cur_stmt
|| !__prev_stmt
)
899 if (__cur_stmt
->type
!= STMT_ITERATOR
)
901 if (__cur_stmt
->iterator_pre_condition
!= expr
)
904 /* literals are handled in smatch_extra.c */
905 if (get_value(expr
->right
, &sval
))
908 /* First time checking the condition */
909 if (__prev_stmt
== __cur_stmt
->iterator_pre_statement
) {
910 if (!get_implied_value(expr
->left
, &sval
) ||
914 iter_name
= expr_to_var_sym(expr
->left
, &iter_sym
);
915 cap_name
= expr_to_var_sym(expr
->right
, &cap_sym
);
916 if (!iter_name
|| !cap_name
|| !iter_sym
|| !cap_sym
) {
917 free_string(iter_name
);
918 free_string(cap_name
);
922 set_state(inc_dec_id
, iter_name
, iter_sym
, &start
);
923 store_link(inc_dec_link_id
, cap_name
, cap_sym
, iter_name
, iter_sym
);
925 free_string(iter_name
);
926 free_string(cap_name
);
930 /* Second time checking the condtion */
931 if (__prev_stmt
!= __cur_stmt
->iterator_post_statement
)
934 if (get_state_expr(inc_dec_id
, expr
->left
) != &incremented
)
937 data
= false_state
->data
;
938 false_state
= alloc_compare_state(data
->var1
, data
->vsl1
, SPECIAL_EQUAL
, data
->var2
, data
->vsl2
);
940 set_true_false_states(compare_id
, state_name
, NULL
, NULL
, false_state
);
943 static void handle_comparison(struct expression
*left_expr
, int op
, struct expression
*right_expr
, char **_state_name
, struct smatch_state
**_false_state
)
947 struct symbol
*left_sym
, *right_sym
;
948 struct var_sym_list
*left_vsl
, *right_vsl
;
951 struct smatch_state
*true_state
, *false_state
;
952 static char state_name
[256];
953 struct stree
*pre_stree
;
956 false_op
= negate_comparison(op
);
958 if (op
== SPECIAL_UNSIGNED_LT
&&
959 get_implied_value(left_expr
, &sval
) &&
961 false_op
= SPECIAL_EQUAL
;
963 if (op
== SPECIAL_UNSIGNED_GT
&&
964 get_implied_value(right_expr
, &sval
) &&
966 false_op
= SPECIAL_EQUAL
;
968 left
= chunk_to_var_sym(left_expr
, &left_sym
);
971 left_vsl
= expr_to_vsl(left_expr
);
972 right
= chunk_to_var_sym(right_expr
, &right_sym
);
975 right_vsl
= expr_to_vsl(right_expr
);
977 if (strcmp(left
, right
) > 0) {
978 struct symbol
*tmp_sym
= left_sym
;
979 char *tmp_name
= left
;
980 struct var_sym_list
*tmp_vsl
= left_vsl
;
981 struct expression
*tmp_expr
= left_expr
;
984 left_sym
= right_sym
;
985 left_vsl
= right_vsl
;
986 left_expr
= right_expr
;
990 right_expr
= tmp_expr
;
991 op
= flip_comparison(op
);
992 false_op
= flip_comparison(false_op
);
995 orig_comparison
= get_comparison_strings(left
, right
);
996 op
= filter_comparison(orig_comparison
, op
);
997 false_op
= filter_comparison(orig_comparison
, false_op
);
999 snprintf(state_name
, sizeof(state_name
), "%s vs %s", left
, right
);
1000 true_state
= alloc_compare_state(left
, left_vsl
, op
, right
, right_vsl
);
1001 false_state
= alloc_compare_state(left
, left_vsl
, false_op
, right
, right_vsl
);
1003 pre_stree
= clone_stree(__get_cur_stree());
1004 update_tf_data(pre_stree
, left
, left_vsl
, right
, right_vsl
, op
, false_op
);
1005 free_stree(&pre_stree
);
1007 set_true_false_states(compare_id
, state_name
, NULL
, true_state
, false_state
);
1008 save_link(left_expr
, state_name
);
1009 save_link(right_expr
, state_name
);
1012 *_false_state
= false_state
;
1014 *_state_name
= state_name
;
1021 void __comparison_match_condition(struct expression
*expr
)
1023 struct expression
*left
, *right
, *new_left
, *new_right
;
1024 struct smatch_state
*false_state
= NULL
;
1025 char *state_name
= NULL
;
1027 if (expr
->type
!= EXPR_COMPARE
)
1030 handle_comparison(expr
->left
, expr
->op
, expr
->right
, &state_name
, &false_state
);
1031 if (false_state
&& state_name
)
1032 handle_for_loops(expr
, state_name
, false_state
);
1035 left
= strip_parens(expr
->left
);
1036 right
= strip_parens(expr
->right
);
1038 if (left
->type
== EXPR_BINOP
&& left
->op
== '+') {
1039 new_left
= left
->left
;
1040 new_right
= binop_expression(right
, '-', left
->right
);
1041 handle_comparison(new_left
, expr
->op
, new_right
, NULL
, NULL
);
1043 new_left
= left
->right
;
1044 new_right
= binop_expression(right
, '-', left
->left
);
1045 handle_comparison(new_left
, expr
->op
, new_right
, NULL
, NULL
);
1049 static void add_comparison_var_sym(const char *left_name
,
1050 struct var_sym_list
*left_vsl
,
1052 const char *right_name
, struct var_sym_list
*right_vsl
)
1054 struct smatch_state
*state
;
1056 char state_name
[256];
1058 if (strcmp(left_name
, right_name
) > 0) {
1059 const char *tmp_name
= left_name
;
1060 struct var_sym_list
*tmp_vsl
= left_vsl
;
1062 left_name
= right_name
;
1063 left_vsl
= right_vsl
;
1064 right_name
= tmp_name
;
1065 right_vsl
= tmp_vsl
;
1066 comparison
= flip_comparison(comparison
);
1068 snprintf(state_name
, sizeof(state_name
), "%s vs %s", left_name
, right_name
);
1069 state
= alloc_compare_state(left_name
, left_vsl
, comparison
, right_name
, right_vsl
);
1071 set_state(compare_id
, state_name
, NULL
, state
);
1073 FOR_EACH_PTR(left_vsl
, vs
) {
1074 save_link_var_sym(vs
->var
, vs
->sym
, state_name
);
1075 } END_FOR_EACH_PTR(vs
);
1076 FOR_EACH_PTR(right_vsl
, vs
) {
1077 save_link_var_sym(vs
->var
, vs
->sym
, state_name
);
1078 } END_FOR_EACH_PTR(vs
);
1081 static void add_comparison(struct expression
*left
, int comparison
, struct expression
*right
)
1083 char *left_name
= NULL
;
1084 char *right_name
= NULL
;
1085 struct symbol
*left_sym
, *right_sym
;
1086 struct var_sym_list
*left_vsl
, *right_vsl
;
1087 struct smatch_state
*state
;
1088 char state_name
[256];
1090 left_name
= chunk_to_var_sym(left
, &left_sym
);
1093 left_vsl
= expr_to_vsl(left
);
1094 right_name
= chunk_to_var_sym(right
, &right_sym
);
1097 right_vsl
= expr_to_vsl(right
);
1099 if (strcmp(left_name
, right_name
) > 0) {
1100 struct symbol
*tmp_sym
= left_sym
;
1101 char *tmp_name
= left_name
;
1102 struct var_sym_list
*tmp_vsl
= left_vsl
;
1104 left_name
= right_name
;
1105 left_sym
= right_sym
;
1106 left_vsl
= right_vsl
;
1107 right_name
= tmp_name
;
1108 right_sym
= tmp_sym
;
1109 right_vsl
= tmp_vsl
;
1110 comparison
= flip_comparison(comparison
);
1112 snprintf(state_name
, sizeof(state_name
), "%s vs %s", left_name
, right_name
);
1113 state
= alloc_compare_state(left_name
, left_vsl
, comparison
, right_name
, right_vsl
);
1115 set_state(compare_id
, state_name
, NULL
, state
);
1116 save_link(left
, state_name
);
1117 save_link(right
, state_name
);
1120 free_string(left_name
);
1121 free_string(right_name
);
1124 static void match_assign_add(struct expression
*expr
)
1126 struct expression
*right
;
1127 struct expression
*r_left
, *r_right
;
1128 sval_t left_tmp
, right_tmp
;
1130 right
= strip_expr(expr
->right
);
1131 r_left
= strip_expr(right
->left
);
1132 r_right
= strip_expr(right
->right
);
1134 get_absolute_min(r_left
, &left_tmp
);
1135 get_absolute_min(r_right
, &right_tmp
);
1137 if (left_tmp
.value
> 0)
1138 add_comparison(expr
->left
, '>', r_right
);
1139 else if (left_tmp
.value
== 0)
1140 add_comparison(expr
->left
, SPECIAL_GTE
, r_right
);
1142 if (right_tmp
.value
> 0)
1143 add_comparison(expr
->left
, '>', r_left
);
1144 else if (right_tmp
.value
== 0)
1145 add_comparison(expr
->left
, SPECIAL_GTE
, r_left
);
1148 static void match_assign_sub(struct expression
*expr
)
1150 struct expression
*right
;
1151 struct expression
*r_left
, *r_right
;
1155 right
= strip_expr(expr
->right
);
1156 r_left
= strip_expr(right
->left
);
1157 r_right
= strip_expr(right
->right
);
1159 if (get_absolute_min(r_right
, &min
) && sval_is_negative(min
))
1162 comparison
= get_comparison(r_left
, r_right
);
1164 switch (comparison
) {
1167 if (implied_not_equal(r_right
, 0))
1168 add_comparison(expr
->left
, '>', r_left
);
1170 add_comparison(expr
->left
, SPECIAL_GTE
, r_left
);
1175 static void match_assign_divide(struct expression
*expr
)
1177 struct expression
*right
;
1178 struct expression
*r_left
, *r_right
;
1181 right
= strip_expr(expr
->right
);
1182 r_left
= strip_expr(right
->left
);
1183 r_right
= strip_expr(right
->right
);
1184 if (!get_implied_min(r_right
, &min
) || min
.value
<= 1)
1187 add_comparison(expr
->left
, '<', r_left
);
1190 static void match_binop_assign(struct expression
*expr
)
1192 struct expression
*right
;
1194 right
= strip_expr(expr
->right
);
1195 if (right
->op
== '+')
1196 match_assign_add(expr
);
1197 if (right
->op
== '-')
1198 match_assign_sub(expr
);
1199 if (right
->op
== '/')
1200 match_assign_divide(expr
);
1203 static void copy_comparisons(struct expression
*left
, struct expression
*right
)
1205 struct string_list
*links
;
1206 struct smatch_state
*state
;
1207 struct compare_data
*data
;
1208 struct symbol
*left_sym
, *right_sym
;
1209 char *left_var
= NULL
;
1210 char *right_var
= NULL
;
1211 struct var_sym_list
*left_vsl
;
1213 struct var_sym_list
*vsl
;
1217 left_var
= chunk_to_var_sym(left
, &left_sym
);
1220 left_vsl
= expr_to_vsl(left
);
1221 right_var
= chunk_to_var_sym(right
, &right_sym
);
1225 state
= get_state(link_id
, right_var
, right_sym
);
1228 links
= state
->data
;
1230 FOR_EACH_PTR(links
, tmp
) {
1231 state
= get_state(compare_id
, tmp
, NULL
);
1232 if (!state
|| !state
->data
)
1235 comparison
= data
->comparison
;
1238 if (strcmp(var
, right_var
) == 0) {
1241 comparison
= flip_comparison(comparison
);
1243 add_comparison_var_sym(left_var
, left_vsl
, comparison
, var
, vsl
);
1244 } END_FOR_EACH_PTR(tmp
);
1247 free_string(right_var
);
1250 static void match_assign(struct expression
*expr
)
1252 struct expression
*right
;
1254 if (expr
->op
!= '=')
1256 if (__in_fake_assign
|| outside_of_function())
1259 if (is_struct(expr
->left
))
1262 copy_comparisons(expr
->left
, expr
->right
);
1263 add_comparison(expr
->left
, SPECIAL_EQUAL
, expr
->right
);
1265 right
= strip_expr(expr
->right
);
1266 if (right
->type
== EXPR_BINOP
)
1267 match_binop_assign(expr
);
1270 int get_comparison_strings(const char *one
, const char *two
)
1273 struct smatch_state
*state
;
1277 if (strcmp(one
, two
) == 0)
1278 return SPECIAL_EQUAL
;
1280 if (strcmp(one
, two
) > 0) {
1281 const char *tmp
= one
;
1288 snprintf(buf
, sizeof(buf
), "%s vs %s", one
, two
);
1289 state
= get_state(compare_id
, buf
, NULL
);
1291 ret
= state_to_comparison(state
);
1294 ret
= flip_comparison(ret
);
1299 int get_comparison(struct expression
*a
, struct expression
*b
)
1305 one
= chunk_to_var(a
);
1308 two
= chunk_to_var(b
);
1312 ret
= get_comparison_strings(one
, two
);
1319 int possible_comparison(struct expression
*a
, int comparison
, struct expression
*b
)
1325 struct sm_state
*sm
;
1328 one
= chunk_to_var(a
);
1331 two
= chunk_to_var(b
);
1336 if (strcmp(one
, two
) == 0 && comparison
== SPECIAL_EQUAL
) {
1341 if (strcmp(one
, two
) > 0) {
1346 comparison
= flip_comparison(comparison
);
1349 snprintf(buf
, sizeof(buf
), "%s vs %s", one
, two
);
1350 sm
= get_sm_state(compare_id
, buf
, NULL
);
1354 FOR_EACH_PTR(sm
->possible
, sm
) {
1355 if (!sm
->state
->data
)
1357 saved
= ((struct compare_data
*)sm
->state
->data
)->comparison
;
1358 if (saved
== comparison
)
1360 if (comparison
== SPECIAL_EQUAL
&&
1361 (saved
== SPECIAL_LTE
||
1362 saved
== SPECIAL_GTE
||
1363 saved
== SPECIAL_UNSIGNED_LTE
||
1364 saved
== SPECIAL_UNSIGNED_GTE
))
1368 } END_FOR_EACH_PTR(sm
);
1377 struct state_list
*get_all_comparisons(struct expression
*expr
)
1379 struct smatch_state
*state
;
1380 struct string_list
*links
;
1381 struct state_list
*ret
= NULL
;
1382 struct sm_state
*sm
;
1385 state
= get_state_expr(link_id
, expr
);
1388 links
= state
->data
;
1390 FOR_EACH_PTR(links
, tmp
) {
1391 sm
= get_sm_state(compare_id
, tmp
, NULL
);
1394 // FIXME have to compare name with vsl
1395 add_ptr_list(&ret
, sm
);
1396 } END_FOR_EACH_PTR(tmp
);
1401 struct state_list
*get_all_possible_equal_comparisons(struct expression
*expr
)
1403 struct smatch_state
*state
;
1404 struct string_list
*links
;
1405 struct state_list
*ret
= NULL
;
1406 struct sm_state
*sm
;
1409 state
= get_state_expr(link_id
, expr
);
1412 links
= state
->data
;
1414 FOR_EACH_PTR(links
, tmp
) {
1415 sm
= get_sm_state(compare_id
, tmp
, NULL
);
1418 if (!strchr(sm
->state
->name
, '='))
1420 if (strcmp(sm
->state
->name
, "!=") == 0)
1422 add_ptr_list(&ret
, sm
);
1423 } END_FOR_EACH_PTR(tmp
);
1428 static void update_links_from_call(struct expression
*left
,
1430 struct expression
*right
)
1432 struct string_list
*links
;
1433 struct smatch_state
*state
;
1434 struct compare_data
*data
;
1435 struct symbol
*left_sym
, *right_sym
;
1436 char *left_var
= NULL
;
1437 char *right_var
= NULL
;
1438 struct var_sym_list
*left_vsl
;
1440 struct var_sym_list
*vsl
;
1444 left_var
= chunk_to_var_sym(left
, &left_sym
);
1447 left_vsl
= expr_to_vsl(left
);
1448 right_var
= chunk_to_var_sym(right
, &right_sym
);
1452 state
= get_state(link_id
, right_var
, right_sym
);
1455 links
= state
->data
;
1457 FOR_EACH_PTR(links
, tmp
) {
1458 state
= get_state(compare_id
, tmp
, NULL
);
1459 if (!state
|| !state
->data
)
1462 comparison
= data
->comparison
;
1465 if (strcmp(var
, right_var
) == 0) {
1468 comparison
= flip_comparison(comparison
);
1470 comparison
= combine_comparisons(left_compare
, comparison
);
1473 add_comparison_var_sym(left_var
, left_vsl
, comparison
, var
, vsl
);
1474 } END_FOR_EACH_PTR(tmp
);
1477 free_string(right_var
);
1480 void __add_comparison_info(struct expression
*expr
, struct expression
*call
, const char *range
)
1482 struct expression
*arg
;
1484 const char *c
= range
;
1486 if (!str_to_comparison_arg(c
, call
, &comparison
, &arg
))
1488 update_links_from_call(expr
, comparison
, arg
);
1489 add_comparison(expr
, comparison
, arg
);
1492 static char *range_comparison_to_param_helper(struct expression
*expr
, char starts_with
, int ignore
)
1494 struct symbol
*param
;
1497 char *ret_str
= NULL
;
1501 var
= chunk_to_var(expr
);
1506 FOR_EACH_PTR(cur_func_sym
->ctype
.base_type
->arguments
, param
) {
1512 snprintf(buf
, sizeof(buf
), "%s orig", param
->ident
->name
);
1513 compare
= get_comparison_strings(var
, buf
);
1516 if (show_special(compare
)[0] != starts_with
)
1518 snprintf(buf
, sizeof(buf
), "[%s$%d]", show_special(compare
), i
);
1519 ret_str
= alloc_sname(buf
);
1521 } END_FOR_EACH_PTR(param
);
1528 char *name_sym_to_param_comparison(const char *name
, struct symbol
*sym
)
1530 struct symbol
*param
;
1536 FOR_EACH_PTR(cur_func_sym
->ctype
.base_type
->arguments
, param
) {
1540 snprintf(buf
, sizeof(buf
), "%s orig", param
->ident
->name
);
1541 compare
= get_comparison_strings(name
, buf
);
1544 snprintf(buf
, sizeof(buf
), "[%s$%d]", show_special(compare
), i
);
1545 return alloc_sname(buf
);
1546 } END_FOR_EACH_PTR(param
);
1551 char *expr_equal_to_param(struct expression
*expr
, int ignore
)
1553 return range_comparison_to_param_helper(expr
, '=', ignore
);
1556 char *expr_lte_to_param(struct expression
*expr
, int ignore
)
1558 return range_comparison_to_param_helper(expr
, '<', ignore
);
1561 char *expr_param_comparison(struct expression
*expr
, int ignore
)
1563 struct symbol
*param
;
1566 char *ret_str
= NULL
;
1570 var
= chunk_to_var(expr
);
1575 FOR_EACH_PTR(cur_func_sym
->ctype
.base_type
->arguments
, param
) {
1581 snprintf(buf
, sizeof(buf
), "%s orig", param
->ident
->name
);
1582 compare
= get_comparison_strings(var
, buf
);
1585 snprintf(buf
, sizeof(buf
), "[%s$%d]", show_special(compare
), i
);
1586 ret_str
= alloc_sname(buf
);
1588 } END_FOR_EACH_PTR(param
);
1595 char *get_printed_param_name(struct expression
*call
, const char *param_name
, struct symbol
*param_sym
)
1597 struct expression
*arg
;
1600 static char buf
[256];
1605 FOR_EACH_PTR(call
->args
, arg
) {
1608 name
= expr_to_var_sym(arg
, &sym
);
1611 if (sym
!= param_sym
)
1615 if (strncmp(name
, param_name
, len
) != 0)
1617 if (param_name
[len
] == '\0') {
1618 snprintf(buf
, sizeof(buf
), "$%d", i
);
1621 if (param_name
[len
] != '-')
1623 snprintf(buf
, sizeof(buf
), "$%d%s", i
, param_name
+ len
);
1625 } END_FOR_EACH_PTR(arg
);
1630 static void match_call_info(struct expression
*expr
)
1632 struct expression
*arg
;
1633 struct smatch_state
*state
;
1634 struct sm_state
*sm
;
1635 struct compare_data
*data
;
1637 struct string_list
*links
;
1639 const char *right_name
;
1645 FOR_EACH_PTR(expr
->args
, arg
) {
1648 state
= get_state_expr(link_id
, arg
);
1652 links
= state
->data
;
1653 FOR_EACH_PTR(links
, link
) {
1654 struct var_sym_list
*right_vsl
;
1655 struct var_sym
*right_vs
;
1658 if (strstr(link
, " orig"))
1660 sm
= get_sm_state(compare_id
, link
, NULL
);
1663 data
= sm
->state
->data
;
1664 if (!data
|| !data
->comparison
)
1666 arg_name
= expr_to_var(arg
);
1671 if (strcmp(data
->var1
, arg_name
) == 0) {
1672 comparison
= data
->comparison
;
1673 right_name
= data
->var2
;
1674 right_vsl
= data
->vsl2
;
1676 } else if (strcmp(data
->var2
, arg_name
) == 0) {
1677 comparison
= flip_comparison(data
->comparison
);
1678 right_name
= data
->var1
;
1679 right_vsl
= data
->vsl1
;
1681 if (!right_vsl
|| ptr_list_size((struct ptr_list
*)right_vsl
) != 1)
1683 right_vs
= first_ptr_list((struct ptr_list
*)right_vsl
);
1684 if (strcmp(right_vs
->var
, right_name
) != 0)
1686 right_name
= get_printed_param_name(expr
, right_vs
->var
, right_vs
->sym
);
1689 snprintf(info_buf
, sizeof(info_buf
), "%s %s", show_special(comparison
), right_name
);
1690 sql_insert_caller_info(expr
, PARAM_COMPARE
, i
, "$", info_buf
);
1693 free_string(arg_name
);
1694 } END_FOR_EACH_PTR(link
);
1695 } END_FOR_EACH_PTR(arg
);
1698 static void struct_member_callback(struct expression
*call
, int param
, char *printed_name
, struct sm_state
*link_sm
)
1700 struct sm_state
*compare_sm
;
1701 struct string_list
*links
;
1703 struct compare_data
*data
;
1704 struct var_sym
*left
, *right
;
1705 static char info_buf
[256];
1706 const char *right_name
;
1708 if (strstr(printed_name
, " orig"))
1711 links
= link_sm
->state
->data
;
1712 FOR_EACH_PTR(links
, link
) {
1713 compare_sm
= get_sm_state(compare_id
, link
, NULL
);
1716 data
= compare_sm
->state
->data
;
1717 if (!data
|| !data
->comparison
)
1720 if (ptr_list_size((struct ptr_list
*)data
->vsl1
) != 1 ||
1721 ptr_list_size((struct ptr_list
*)data
->vsl2
) != 1)
1723 left
= first_ptr_list((struct ptr_list
*)data
->vsl1
);
1724 right
= first_ptr_list((struct ptr_list
*)data
->vsl2
);
1725 if (left
->sym
== right
->sym
&&
1726 strcmp(left
->var
, right
->var
) == 0)
1729 * Both parameters link to this comparison so only
1730 * record the first one.
1732 if (left
->sym
!= link_sm
->sym
||
1733 strcmp(left
->var
, link_sm
->name
) != 0)
1736 right_name
= get_printed_param_name(call
, right
->var
, right
->sym
);
1739 snprintf(info_buf
, sizeof(info_buf
), "%s %s", show_special(data
->comparison
), right_name
);
1740 sql_insert_caller_info(call
, PARAM_COMPARE
, param
, printed_name
, info_buf
);
1741 } END_FOR_EACH_PTR(link
);
1744 static void free_data(struct symbol
*sym
)
1748 clear_compare_data_alloc();
1751 void register_comparison(int id
)
1754 add_hook(&save_start_states
, AFTER_DEF_HOOK
);
1755 add_unmatched_state_hook(compare_id
, unmatched_comparison
);
1756 add_merge_hook(compare_id
, &merge_compare_states
);
1757 add_hook(&free_data
, AFTER_FUNC_HOOK
);
1758 add_hook(&match_call_info
, FUNCTION_CALL_HOOK
);
1761 void register_comparison_late(int id
)
1763 add_hook(&match_assign
, ASSIGNMENT_HOOK
);
1766 void register_comparison_links(int id
)
1769 add_merge_hook(link_id
, &merge_links
);
1770 add_modification_hook_late(link_id
, &match_modify
);
1772 add_member_info_callback(link_id
, struct_member_callback
);
1775 void register_comparison_inc_dec(int id
)
1778 add_modification_hook_late(inc_dec_id
, &iter_modify
);
1781 void register_comparison_inc_dec_links(int id
)
1783 inc_dec_link_id
= id
;
1784 set_up_link_functions(inc_dec_id
, inc_dec_link_id
);
1787 static void filter_by_sm(struct sm_state
*sm
, int op
,
1788 struct state_list
**true_stack
,
1789 struct state_list
**false_stack
)
1791 struct compare_data
*data
;
1797 data
= sm
->state
->data
;
1800 filter_by_sm(sm
->left
, op
, true_stack
, false_stack
);
1801 filter_by_sm(sm
->right
, op
, true_stack
, false_stack
);
1806 if (data
->comparison
&&
1807 data
->comparison
== filter_comparison(data
->comparison
, op
))
1810 if (data
->comparison
&&
1811 data
->comparison
== filter_comparison(data
->comparison
, negate_comparison(op
)))
1815 add_ptr_list(true_stack
, sm
);
1817 add_ptr_list(false_stack
, sm
);
1820 filter_by_sm(sm
->left
, op
, true_stack
, false_stack
);
1821 filter_by_sm(sm
->right
, op
, true_stack
, false_stack
);
1825 struct sm_state
*comparison_implication_hook(struct expression
*expr
,
1826 struct state_list
**true_stack
,
1827 struct state_list
**false_stack
)
1829 struct sm_state
*sm
;
1832 static char buf
[256];
1834 if (expr
->type
!= EXPR_COMPARE
)
1839 left
= expr_to_var(expr
->left
);
1840 right
= expr_to_var(expr
->right
);
1841 if (!left
|| !right
) {
1847 if (strcmp(left
, right
) > 0) {
1852 op
= flip_comparison(op
);
1855 snprintf(buf
, sizeof(buf
), "%s vs %s", left
, right
);
1856 sm
= get_sm_state(compare_id
, buf
, NULL
);
1862 filter_by_sm(sm
, op
, true_stack
, false_stack
);
1863 if (!*true_stack
&& !*false_stack
)