2 * Simplify - do instruction simplification before CSE
4 * Copyright (C) 2004 Linus Torvalds
10 #include "expression.h"
11 #include "linearize.h"
15 /* Find the trivial parent for a phi-source */
16 static struct basic_block
*phi_parent(struct basic_block
*source
, pseudo_t pseudo
)
18 /* Can't go upwards if the pseudo is defined in the bb it came from.. */
19 if (pseudo
->type
== PSEUDO_REG
) {
20 struct instruction
*def
= pseudo
->def
;
21 if (def
->bb
== source
)
24 if (bb_list_size(source
->children
) != 1 || bb_list_size(source
->parents
) != 1)
26 return first_basic_block(source
->parents
);
29 static int if_convert_phi(struct instruction
*insn
)
32 struct basic_block
*parents
[3];
33 struct basic_block
*bb
, *bb1
, *bb2
, *source
;
34 struct instruction
*br
;
38 if (linearize_ptr_list((struct ptr_list
*)insn
->phi_list
, (void **)array
, 3) != 2)
40 if (linearize_ptr_list((struct ptr_list
*)bb
->parents
, (void **)parents
, 3) != 2)
42 p1
= array
[0]->def
->src1
;
43 bb1
= array
[0]->def
->bb
;
44 p2
= array
[1]->def
->src1
;
45 bb2
= array
[1]->def
->bb
;
47 /* Only try the simple "direct parents" case */
48 if ((bb1
!= parents
[0] || bb2
!= parents
[1]) &&
49 (bb1
!= parents
[1] || bb2
!= parents
[0]))
53 * See if we can find a common source for this..
55 source
= phi_parent(bb1
, p1
);
56 if (source
!= phi_parent(bb2
, p2
))
60 * Cool. We now know that 'source' is the exclusive
61 * parent of both phi-nodes, so the exit at the
62 * end of it fully determines which one it is, and
63 * we can turn it into a select.
65 * HOWEVER, right now we only handle regular
66 * conditional branches. No multijumps or computed
67 * stuff. Verify that here.
69 br
= last_instruction(source
->insns
);
70 if (!br
|| br
->opcode
!= OP_BR
)
77 * We're in business. Match up true/false with p1/p2.
79 if (br
->bb_true
== bb2
|| br
->bb_false
== bb1
) {
86 * OK, we can now replace that last
93 * select pseudo, p1, p2
96 * and remove the phi-node. If it then
97 * turns out that 'a' or 'b' is entirely
98 * empty (common case), and now no longer
99 * a phi-source, we'll be able to simplify
100 * the conditional branch too.
102 insert_select(source
, br
, insn
, p1
, p2
);
103 kill_instruction(insn
);
107 static int clean_up_phi(struct instruction
*insn
)
110 struct instruction
*last
;
115 FOR_EACH_PTR(insn
->phi_list
, phi
) {
116 struct instruction
*def
;
120 if (def
->src1
== VOID
|| !def
->bb
)
123 if (last
->src1
!= def
->src1
)
128 } END_FOR_EACH_PTR(phi
);
131 pseudo_t pseudo
= last
? last
->src1
: VOID
;
132 convert_instruction_target(insn
, pseudo
);
133 kill_instruction(insn
);
137 return if_convert_phi(insn
);
140 static int delete_pseudo_user_list_entry(struct pseudo_user_list
**list
, pseudo_t
*entry
, int count
)
142 struct pseudo_user
*pu
;
144 FOR_EACH_PTR(*list
, pu
) {
145 if (pu
->userp
== entry
) {
146 DELETE_CURRENT_PTR(pu
);
150 } END_FOR_EACH_PTR(pu
);
153 pack_ptr_list((struct ptr_list
**)list
);
157 static inline void remove_usage(pseudo_t p
, pseudo_t
*usep
)
159 if (has_use_list(p
)) {
160 delete_pseudo_user_list_entry(&p
->users
, usep
, 1);
162 kill_instruction(p
->def
);
166 void kill_use(pseudo_t
*usep
)
171 remove_usage(p
, usep
);
175 static void kill_use_list(struct pseudo_list
*list
)
178 FOR_EACH_PTR(list
, p
) {
181 kill_use(THIS_ADDRESS(p
));
182 } END_FOR_EACH_PTR(p
);
185 void kill_instruction(struct instruction
*insn
)
187 if (!insn
|| !insn
->bb
)
190 switch (insn
->opcode
) {
193 kill_use(&insn
->src3
);
196 case OP_BINARY
... OP_BINCMP_END
:
197 kill_use(&insn
->src2
);
205 case OP_NOT
: case OP_NEG
:
207 kill_use(&insn
->src1
);
211 kill_use_list(insn
->phi_list
);
214 kill_use(&insn
->phi_src
);
218 repeat_phase
|= REPEAT_SYMBOL_CLEANUP
;
222 if (!insn
->bb_true
|| !insn
->bb_false
)
226 case OP_COMPUTEDGOTO
:
227 kill_use(&insn
->cond
);
239 repeat_phase
|= REPEAT_CSE
;
244 * Kill trivially dead instructions
246 static int dead_insn(struct instruction
*insn
, pseudo_t
*src1
, pseudo_t
*src2
, pseudo_t
*src3
)
248 struct pseudo_user
*pu
;
249 FOR_EACH_PTR(insn
->target
->users
, pu
) {
250 if (*pu
->userp
!= VOID
)
252 } END_FOR_EACH_PTR(pu
);
261 static inline int constant(pseudo_t pseudo
)
263 return pseudo
->type
== PSEUDO_VAL
;
266 static int replace_with_pseudo(struct instruction
*insn
, pseudo_t pseudo
)
268 convert_instruction_target(insn
, pseudo
);
270 switch (insn
->opcode
) {
273 kill_use(&insn
->src3
);
274 case OP_BINARY
... OP_BINCMP_END
:
275 kill_use(&insn
->src2
);
283 kill_use(&insn
->src1
);
293 static unsigned int value_size(long long value
)
308 * Try to determine the maximum size of bits in a pseudo.
310 * Right now this only follow casts and constant values, but we
311 * could look at things like logical 'and' instructions etc.
313 static unsigned int operand_size(struct instruction
*insn
, pseudo_t pseudo
)
315 unsigned int size
= insn
->size
;
317 if (pseudo
->type
== PSEUDO_REG
) {
318 struct instruction
*src
= pseudo
->def
;
319 if (src
&& src
->opcode
== OP_CAST
&& src
->orig_type
) {
320 unsigned int orig_size
= src
->orig_type
->bit_size
;
321 if (orig_size
< size
)
325 if (pseudo
->type
== PSEUDO_VAL
) {
326 unsigned int orig_size
= value_size(pseudo
->value
);
327 if (orig_size
< size
)
333 static int simplify_asr(struct instruction
*insn
, pseudo_t pseudo
, long long value
)
335 unsigned int size
= operand_size(insn
, pseudo
);
338 warning(insn
->pos
, "right shift by bigger than source value");
339 return replace_with_pseudo(insn
, value_pseudo(0));
342 return replace_with_pseudo(insn
, pseudo
);
346 static int simplify_mul_div(struct instruction
*insn
, long long value
)
348 unsigned long long sbit
= 1ULL << (insn
->size
- 1);
349 unsigned long long bits
= sbit
| (sbit
- 1);
352 return replace_with_pseudo(insn
, insn
->src1
);
354 switch (insn
->opcode
) {
358 return replace_with_pseudo(insn
, insn
->src2
);
361 if (!(value
& sbit
)) // positive
366 insn
->opcode
= OP_NEG
;
374 static int compare_opcode(int opcode
, int inverse
)
380 case OP_SET_EQ
: return OP_SET_NE
;
381 case OP_SET_NE
: return OP_SET_EQ
;
383 case OP_SET_LT
: return OP_SET_GE
;
384 case OP_SET_LE
: return OP_SET_GT
;
385 case OP_SET_GT
: return OP_SET_LE
;
386 case OP_SET_GE
: return OP_SET_LT
;
388 case OP_SET_A
: return OP_SET_BE
;
389 case OP_SET_AE
: return OP_SET_B
;
390 case OP_SET_B
: return OP_SET_AE
;
391 case OP_SET_BE
: return OP_SET_A
;
398 static int simplify_seteq_setne(struct instruction
*insn
, long long value
)
400 struct instruction
*def
= insn
->src1
->def
;
405 if (value
!= 0 && value
!= 1)
411 inverse
= (insn
->opcode
== OP_SET_NE
) == value
;
412 opcode
= def
->opcode
;
414 case OP_BINCMP
... OP_BINCMP_END
:
416 // setcc.n %t <- %a, %b
417 // setne.m %r <- %t, $0
419 // setcc.n %t <- %a, %b
420 // setcc.m %r <- %a, $b
421 // and similar for setne/eq ... 0/1
424 remove_usage(insn
->src1
, &insn
->src1
);
425 insn
->opcode
= compare_opcode(opcode
, inverse
);
426 use_pseudo(insn
, src1
, &insn
->src1
);
427 use_pseudo(insn
, src2
, &insn
->src2
);
435 static int simplify_constant_rightside(struct instruction
*insn
)
437 long long value
= insn
->src2
->value
;
439 switch (insn
->opcode
) {
442 return replace_with_pseudo(insn
, insn
->src2
);
443 goto case_neutral_zero
;
447 insn
->opcode
= OP_ADD
;
448 insn
->src2
= value_pseudo(-value
);
453 case OP_OR
: case OP_XOR
:
458 return replace_with_pseudo(insn
, insn
->src1
);
461 return simplify_asr(insn
, insn
->src1
, value
);
463 case OP_MODU
: case OP_MODS
:
465 return replace_with_pseudo(insn
, value_pseudo(0));
468 case OP_DIVU
: case OP_DIVS
:
469 case OP_MULU
: case OP_MULS
:
470 return simplify_mul_div(insn
, value
);
474 return replace_with_pseudo(insn
, insn
->src1
);
478 return replace_with_pseudo(insn
, insn
->src2
);
483 return simplify_seteq_setne(insn
, value
);
488 static int simplify_constant_leftside(struct instruction
*insn
)
490 long long value
= insn
->src1
->value
;
492 switch (insn
->opcode
) {
493 case OP_ADD
: case OP_OR
: case OP_XOR
:
495 return replace_with_pseudo(insn
, insn
->src2
);
499 case OP_LSR
: case OP_ASR
:
501 case OP_MULU
: case OP_MULS
:
503 return replace_with_pseudo(insn
, insn
->src1
);
509 static int simplify_constant_binop(struct instruction
*insn
)
511 /* FIXME! Verify signs and sizes!! */
512 long long left
= insn
->src1
->value
;
513 long long right
= insn
->src2
->value
;
514 unsigned long long ul
, ur
;
515 long long res
, mask
, bits
;
517 mask
= 1ULL << (insn
->size
-1);
518 bits
= mask
| (mask
-1);
527 switch (insn
->opcode
) {
548 if (left
== mask
&& right
== -1)
560 if (left
== mask
&& right
== -1)
590 /* Binary comparison */
626 replace_with_pseudo(insn
, value_pseudo(res
));
630 static int simplify_binop_same_args(struct instruction
*insn
, pseudo_t arg
)
632 switch (insn
->opcode
) {
634 case OP_SET_LT
: case OP_SET_GT
:
635 case OP_SET_B
: case OP_SET_A
:
636 if (Wtautological_compare
)
637 warning(insn
->pos
, "self-comparison always evaluates to false");
640 return replace_with_pseudo(insn
, value_pseudo(0));
643 case OP_SET_LE
: case OP_SET_GE
:
644 case OP_SET_BE
: case OP_SET_AE
:
645 if (Wtautological_compare
)
646 warning(insn
->pos
, "self-comparison always evaluates to true");
647 return replace_with_pseudo(insn
, value_pseudo(1));
651 return replace_with_pseudo(insn
, arg
);
655 remove_usage(arg
, &insn
->src2
);
656 insn
->src2
= value_pseudo(0);
657 insn
->opcode
= OP_SET_NE
;
667 static int simplify_binop(struct instruction
*insn
)
669 if (dead_insn(insn
, &insn
->src1
, &insn
->src2
, NULL
))
671 if (constant(insn
->src1
)) {
672 if (constant(insn
->src2
))
673 return simplify_constant_binop(insn
);
674 return simplify_constant_leftside(insn
);
676 if (constant(insn
->src2
))
677 return simplify_constant_rightside(insn
);
678 if (insn
->src1
== insn
->src2
)
679 return simplify_binop_same_args(insn
, insn
->src1
);
683 static void switch_pseudo(struct instruction
*insn1
, pseudo_t
*pp1
, struct instruction
*insn2
, pseudo_t
*pp2
)
685 pseudo_t p1
= *pp1
, p2
= *pp2
;
687 use_pseudo(insn1
, p2
, pp1
);
688 use_pseudo(insn2
, p1
, pp2
);
689 remove_usage(p1
, pp1
);
690 remove_usage(p2
, pp2
);
693 static int canonical_order(pseudo_t p1
, pseudo_t p2
)
695 /* symbol/constants on the right */
696 if (p1
->type
== PSEUDO_VAL
)
697 return p2
->type
== PSEUDO_VAL
;
699 if (p1
->type
== PSEUDO_SYM
)
700 return p2
->type
== PSEUDO_SYM
|| p2
->type
== PSEUDO_VAL
;
705 static int simplify_commutative_binop(struct instruction
*insn
)
707 if (!canonical_order(insn
->src1
, insn
->src2
)) {
708 switch_pseudo(insn
, &insn
->src1
, insn
, &insn
->src2
);
714 static inline int simple_pseudo(pseudo_t pseudo
)
716 return pseudo
->type
== PSEUDO_VAL
|| pseudo
->type
== PSEUDO_SYM
;
719 static int simplify_associative_binop(struct instruction
*insn
)
721 struct instruction
*def
;
722 pseudo_t pseudo
= insn
->src1
;
724 if (!simple_pseudo(insn
->src2
))
726 if (pseudo
->type
!= PSEUDO_REG
)
731 if (def
->opcode
!= insn
->opcode
)
733 if (!simple_pseudo(def
->src2
))
735 if (ptr_list_size((struct ptr_list
*)def
->target
->users
) != 1)
737 switch_pseudo(def
, &def
->src1
, insn
, &insn
->src2
);
741 static int simplify_constant_unop(struct instruction
*insn
)
743 long long val
= insn
->src1
->value
;
746 switch (insn
->opcode
) {
756 mask
= 1ULL << (insn
->size
-1);
757 res
&= mask
| (mask
-1);
759 replace_with_pseudo(insn
, value_pseudo(res
));
763 static int simplify_unop(struct instruction
*insn
)
765 if (dead_insn(insn
, &insn
->src1
, NULL
, NULL
))
767 if (constant(insn
->src1
))
768 return simplify_constant_unop(insn
);
770 switch (insn
->opcode
) {
771 struct instruction
*def
;
774 def
= insn
->src
->def
;
775 if (def
&& def
->opcode
== OP_NOT
)
776 return replace_with_pseudo(insn
, def
->src
);
779 def
= insn
->src
->def
;
780 if (def
&& def
->opcode
== OP_NEG
)
781 return replace_with_pseudo(insn
, def
->src
);
789 static int simplify_one_memop(struct instruction
*insn
, pseudo_t orig
)
791 pseudo_t addr
= insn
->src
;
794 if (addr
->type
== PSEUDO_REG
) {
795 struct instruction
*def
= addr
->def
;
796 if (def
->opcode
== OP_SYMADDR
&& def
->src
) {
797 kill_use(&insn
->src
);
798 use_pseudo(insn
, def
->src
, &insn
->src
);
799 return REPEAT_CSE
| REPEAT_SYMBOL_CLEANUP
;
801 if (def
->opcode
== OP_ADD
) {
821 warning(insn
->pos
, "crazy programmer");
823 insn
->offset
+= off
->value
;
824 use_pseudo(insn
, new, &insn
->src
);
825 remove_usage(addr
, &insn
->src
);
826 return REPEAT_CSE
| REPEAT_SYMBOL_CLEANUP
;
830 * We walk the whole chain of adds/subs backwards. That's not
831 * only more efficient, but it allows us to find loops.
833 static int simplify_memop(struct instruction
*insn
)
836 pseudo_t orig
= insn
->src
;
839 one
= simplify_one_memop(insn
, orig
);
845 static long long get_cast_value(long long val
, int old_size
, int new_size
, int sign
)
849 if (sign
&& new_size
> old_size
) {
850 mask
= 1 << (old_size
-1);
852 val
|= ~(mask
| (mask
-1));
854 mask
= 1 << (new_size
-1);
855 return val
& (mask
| (mask
-1));
858 static int simplify_cast(struct instruction
*insn
)
860 struct symbol
*orig_type
;
864 if (dead_insn(insn
, &insn
->src
, NULL
, NULL
))
867 orig_type
= insn
->orig_type
;
871 /* Keep casts with pointer on either side (not only case of OP_PTRCAST) */
872 if (is_ptr_type(orig_type
) || is_ptr_type(insn
->type
))
875 orig_size
= orig_type
->bit_size
;
879 /* A cast of a constant? */
881 int sign
= orig_type
->ctype
.modifiers
& MOD_SIGNED
;
882 long long val
= get_cast_value(src
->value
, orig_size
, size
, sign
);
883 src
= value_pseudo(val
);
887 /* A cast of a "and" might be a no-op.. */
888 if (src
->type
== PSEUDO_REG
) {
889 struct instruction
*def
= src
->def
;
890 if (def
->opcode
== OP_AND
&& def
->size
>= size
) {
891 pseudo_t val
= def
->src2
;
892 if (val
->type
== PSEUDO_VAL
) {
893 unsigned long long value
= val
->value
;
894 if (!(value
>> (size
-1)))
900 if (size
== orig_size
) {
901 int op
= (orig_type
->ctype
.modifiers
& MOD_SIGNED
) ? OP_SCAST
: OP_CAST
;
902 if (insn
->opcode
== op
)
909 return replace_with_pseudo(insn
, src
);
912 static int simplify_select(struct instruction
*insn
)
914 pseudo_t cond
, src1
, src2
;
916 if (dead_insn(insn
, &insn
->src1
, &insn
->src2
, &insn
->src3
))
922 if (constant(cond
) || src1
== src2
) {
923 pseudo_t
*kill
, take
;
924 kill_use(&insn
->src1
);
925 take
= cond
->value
? src1
: src2
;
926 kill
= cond
->value
? &insn
->src3
: &insn
->src2
;
928 replace_with_pseudo(insn
, take
);
931 if (constant(src1
) && constant(src2
)) {
932 long long val1
= src1
->value
;
933 long long val2
= src2
->value
;
935 /* The pair 0/1 is special - replace with SETNE/SETEQ */
936 if ((val1
| val2
) == 1) {
937 int opcode
= OP_SET_EQ
;
942 insn
->opcode
= opcode
;
943 /* insn->src1 is already cond */
944 insn
->src2
= src1
; /* Zero */
951 static int is_in_range(pseudo_t src
, long long low
, long long high
)
958 return value
>= low
&& value
<= high
;
964 static int simplify_range(struct instruction
*insn
)
966 pseudo_t src1
, src2
, src3
;
971 if (src2
->type
!= PSEUDO_VAL
|| src3
->type
!= PSEUDO_VAL
)
973 if (is_in_range(src1
, src2
->value
, src3
->value
)) {
974 kill_instruction(insn
);
981 * Simplify "set_ne/eq $0 + br"
983 static int simplify_cond_branch(struct instruction
*br
, pseudo_t cond
, struct instruction
*def
, pseudo_t
*pp
)
985 use_pseudo(br
, *pp
, &br
->cond
);
986 remove_usage(cond
, &br
->cond
);
987 if (def
->opcode
== OP_SET_EQ
) {
988 struct basic_block
*true = br
->bb_true
;
989 struct basic_block
*false = br
->bb_false
;
996 static int simplify_branch(struct instruction
*insn
)
998 pseudo_t cond
= insn
->cond
;
1003 /* Constant conditional */
1004 if (constant(cond
)) {
1005 insert_branch(insn
->bb
, insn
, cond
->value
? insn
->bb_true
: insn
->bb_false
);
1010 if (insn
->bb_true
== insn
->bb_false
) {
1011 struct basic_block
*bb
= insn
->bb
;
1012 struct basic_block
*target
= insn
->bb_false
;
1013 remove_bb_from_list(&target
->parents
, bb
, 1);
1014 remove_bb_from_list(&bb
->children
, target
, 1);
1015 insn
->bb_false
= NULL
;
1016 kill_use(&insn
->cond
);
1021 /* Conditional on a SETNE $0 or SETEQ $0 */
1022 if (cond
->type
== PSEUDO_REG
) {
1023 struct instruction
*def
= cond
->def
;
1025 if (def
->opcode
== OP_SET_NE
|| def
->opcode
== OP_SET_EQ
) {
1026 if (constant(def
->src1
) && !def
->src1
->value
)
1027 return simplify_cond_branch(insn
, cond
, def
, &def
->src2
);
1028 if (constant(def
->src2
) && !def
->src2
->value
)
1029 return simplify_cond_branch(insn
, cond
, def
, &def
->src1
);
1031 if (def
->opcode
== OP_SEL
) {
1032 if (constant(def
->src2
) && constant(def
->src3
)) {
1033 long long val1
= def
->src2
->value
;
1034 long long val2
= def
->src3
->value
;
1035 if (!val1
&& !val2
) {
1036 insert_branch(insn
->bb
, insn
, insn
->bb_false
);
1040 insert_branch(insn
->bb
, insn
, insn
->bb_true
);
1044 struct basic_block
*true = insn
->bb_true
;
1045 struct basic_block
*false = insn
->bb_false
;
1046 insn
->bb_false
= true;
1047 insn
->bb_true
= false;
1049 use_pseudo(insn
, def
->src1
, &insn
->cond
);
1050 remove_usage(cond
, &insn
->cond
);
1054 if (def
->opcode
== OP_CAST
|| def
->opcode
== OP_SCAST
) {
1055 int orig_size
= def
->orig_type
? def
->orig_type
->bit_size
: 0;
1056 if (def
->size
> orig_size
) {
1057 use_pseudo(insn
, def
->src
, &insn
->cond
);
1058 remove_usage(cond
, &insn
->cond
);
1066 static int simplify_switch(struct instruction
*insn
)
1068 pseudo_t cond
= insn
->cond
;
1070 struct multijmp
*jmp
;
1072 if (!constant(cond
))
1074 val
= insn
->cond
->value
;
1076 FOR_EACH_PTR(insn
->multijmp_list
, jmp
) {
1078 if (jmp
->begin
> jmp
->end
)
1080 if (val
>= jmp
->begin
&& val
<= jmp
->end
)
1082 } END_FOR_EACH_PTR(jmp
);
1083 warning(insn
->pos
, "Impossible case statement");
1087 insert_branch(insn
->bb
, insn
, jmp
->target
);
1091 int simplify_instruction(struct instruction
*insn
)
1095 switch (insn
->opcode
) {
1096 case OP_ADD
: case OP_MULS
:
1097 case OP_AND
: case OP_OR
: case OP_XOR
:
1098 case OP_AND_BOOL
: case OP_OR_BOOL
:
1099 if (simplify_binop(insn
))
1101 if (simplify_commutative_binop(insn
))
1103 return simplify_associative_binop(insn
);
1106 case OP_SET_EQ
: case OP_SET_NE
:
1107 if (simplify_binop(insn
))
1109 return simplify_commutative_binop(insn
);
1112 case OP_DIVU
: case OP_DIVS
:
1113 case OP_MODU
: case OP_MODS
:
1115 case OP_LSR
: case OP_ASR
:
1116 case OP_SET_LE
: case OP_SET_GE
:
1117 case OP_SET_LT
: case OP_SET_GT
:
1118 case OP_SET_B
: case OP_SET_A
:
1119 case OP_SET_BE
: case OP_SET_AE
:
1120 return simplify_binop(insn
);
1122 case OP_NOT
: case OP_NEG
:
1123 return simplify_unop(insn
);
1124 case OP_LOAD
: case OP_STORE
:
1125 return simplify_memop(insn
);
1127 if (dead_insn(insn
, NULL
, NULL
, NULL
))
1128 return REPEAT_CSE
| REPEAT_SYMBOL_CLEANUP
;
1129 return replace_with_pseudo(insn
, insn
->symbol
);
1134 return simplify_cast(insn
);
1136 if (dead_insn(insn
, NULL
, NULL
, NULL
)) {
1137 kill_use_list(insn
->phi_list
);
1140 return clean_up_phi(insn
);
1142 if (dead_insn(insn
, &insn
->phi_src
, NULL
, NULL
))
1146 return simplify_select(insn
);
1148 return simplify_branch(insn
);
1150 return simplify_switch(insn
);
1152 return simplify_range(insn
);