check_logical_instead_of_bitwise.c

   1 /*
   2  * sparse/check_logical_instead_of_bitwise.c
   3  *
   4  * Copyright (C) 2012 Oracle.
   5  *
   6  * Licensed under the Open Software License version 1.1
   7  *
   8  */
   9
  10 #include "smatch.h"
  11
  12 static int my_id;
  13
  14 static void match_logic(struct expression *expr)
  15 {
  16         long long val;
  17
  18         if (expr->type != EXPR_LOGICAL)
  19                 return;
  20
  21         if (get_macro_name(&expr->pos))
  22                 return;
  23
  24         if (!get_value(expr->right, &val)) {
  25                 if (!get_value(expr->left, &val))
  26                         return;
  27         }
  28
  29         if (val == 0 || val == 1)
  30                 return;
  31
  32         sm_msg("warn: should this be a bitwise op?");
  33 }
  34
  35 void check_logical_instead_of_bitwise(int id)
  36 {
  37         my_id = id;
  38
  39         add_hook(&match_logic, LOGIC_HOOK);
  40 }