signed: allow checks like: if (foo < 0 || foo > x) { for unsigned "foo"
[smatch.git] / check_deref_check.c
blob5db8ba0314c0df9f2dd2bac15cb1e7dd83e74e3d
1 /*
2 * sparse/check_deref_check.c
4 * Copyright (C) 2009 Dan Carpenter.
6 * Licensed under the Open Software License version 1.1
8 */
10 #include "smatch.h"
11 #include "smatch_extra.h"
13 static int my_id;
15 STATE(derefed);
16 STATE(oktocheck);
18 static void underef(const char *name, struct symbol *sym, struct expression *expr, void *unused)
20 set_state(my_id, name, sym, &oktocheck);
23 static void match_dereference(struct expression *expr)
25 char *name;
27 if (expr->type != EXPR_PREOP)
28 return;
29 if (getting_address())
30 return;
32 expr = strip_expr(expr->unop);
33 if (implied_not_equal(expr, 0))
34 return;
35 set_state_expr(my_id, expr, &derefed);
36 name = get_variable_from_expr(expr, NULL);
37 if (!name)
38 return;
39 add_modification_hook(my_id, name, &underef, NULL);
40 free_string(name);
43 static void match_condition(struct expression *expr)
45 struct sm_state *sm;
47 if (__in_pre_condition)
48 return;
50 if (get_macro_name(&expr->pos))
51 return;
53 sm = get_sm_state_expr(my_id, expr);
54 if (!sm || sm->state != &derefed)
55 return;
56 if (implied_not_equal(expr, 0))
57 return;
59 sm_msg("warn: variable dereferenced before check '%s' (see line %d)", sm->name, sm->line);
60 set_state_expr(my_id, expr, &oktocheck);
63 void check_deref_check(int id)
65 my_id = id;
66 add_hook(&match_dereference, DEREF_HOOK);
67 add_hook(&match_condition, CONDITION_HOOK);