| commit | a7c4d9c7ca5178d32236fa5b31fa7fed4e4a7a9c | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Wed, 9 Mar 2016 12:44:19 +0000 (9 13:44 +0100) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Tue, 22 Mar 2016 21:20:16 +0000 (22 22:20 +0100) | ||
| tree | f900455530666957f1512eb29982486f8a849eaf | treesnapshot (tar.gz zip) |
| parent | 0137fdc0941cfe214e91c5c1444f3fcf6a5548b8 | commitdiff |
hw/pci/pci.h: Don't include qemu-common.h
qemu-common.h should only be included by .c files. Its file comment
explains why: "No header file should depend on qemu-common.h, as this
would easily lead to circular header dependencies."
hw/pci/pci.h includes qemu-common.h, but its users only need pcibus_t
and PCIHostDeviceAddress from it. Move them to hw/pci/pci.h and drop
the ill-advised include. Include hw/pci/pci.h where the moved stuff
is now missing. Except we can't in target-i386/kvm_i386.h, because
that would break the i386-linux-user compile. Add
PCIHostDeviceAddress to qemu/typedefs.h instead.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
qemu-common.h should only be included by .c files. Its file comment
explains why: "No header file should depend on qemu-common.h, as this
would easily lead to circular header dependencies."
hw/pci/pci.h includes qemu-common.h, but its users only need pcibus_t
and PCIHostDeviceAddress from it. Move them to hw/pci/pci.h and drop
the ill-advised include. Include hw/pci/pci.h where the moved stuff
is now missing. Except we can't in target-i386/kvm_i386.h, because
that would break the i386-linux-user compile. Add
PCIHostDeviceAddress to qemu/typedefs.h instead.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| hw/core/qdev-properties.c | diffblobblamehistory | |
| include/hw/pci/pci.h | diffblobblamehistory | |
| include/qemu-common.h | diffblobblamehistory | |
| include/qemu/typedefs.h | diffblobblamehistory |