| commit | 0137fdc0941cfe214e91c5c1444f3fcf6a5548b8 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Wed, 9 Mar 2016 11:19:37 +0000 (9 12:19 +0100) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Tue, 22 Mar 2016 21:20:16 +0000 (22 22:20 +0100) | ||
| tree | 61f27c71cf084015b3c0f54de6321dba697e2b8c | treesnapshot (tar.gz zip) |
| parent | daf015ef5ab7b67f4676fcbe74c57b1709f6cb70 | commitdiff |
include/hw/hw.h: Don't include qemu-common.h
qemu-common.h should only be included by .c files. Its file comment
explains why: "No header file should depend on qemu-common.h, as this
would easily lead to circular header dependencies."
hw/hw.h includes qemu-common.h, but its users generally need only
hw_error() and qemu/module.h from it. Move the former to hw/hw.h,
include the latter there, and drop the ill-advised include.
hw/misc/cbus.c now misses hw_error(), so include hw/hw.h there.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
qemu-common.h should only be included by .c files. Its file comment
explains why: "No header file should depend on qemu-common.h, as this
would easily lead to circular header dependencies."
hw/hw.h includes qemu-common.h, but its users generally need only
hw_error() and qemu/module.h from it. Move the former to hw/hw.h,
include the latter there, and drop the ill-advised include.
hw/misc/cbus.c now misses hw_error(), so include hw/hw.h there.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| hw/misc/cbus.c | diffblobblamehistory | |
| include/hw/hw.h | diffblobblamehistory | |
| include/qemu-common.h | diffblobblamehistory |