| commit | 9b4cf91b4f24fa35489c52bfd46eeed0a35e3d91 | |
| author | Catherine Gasnier <catg@fb.com> | |
| Wed, 28 Aug 2019 13:34:52 +0000 (28 06:34 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Wed, 28 Aug 2019 13:38:53 +0000 (28 06:38 -0700) | ||
| tree | 07d8b15c9c8c61e959272fd7d813f12cc45d4d86 | treesnapshot (tar.gz zip) |
| parent | f971d5806daa5f7e5be33658ab718aad98dfd781 | commitdiff |
separate typing_env_types and typing_env
Summary:
This diff will allow constructors in Typing_make_type to actually call things like `union` and `intersect`.
It separates Typing_env and Typing_env_types in two different modules to make it easier to deal with circular dependencies. (Typing_env used to *include* Typing_env_types, now it opens it). Now Typing_make_type can depend on Typing_env_types only, avoiding a circular dependency with Typing_env (see D16964381).
Most modules referring to type `env` or other types and record fields now simply open Typing_env_types, the same way they open Typing_defs.
Reviewed By: Wilfred
Differential Revision: D16964286
fbshipit-source-id: 14e0ef9352f8ab7a3ddfbbb80a1fcadace9f9a17
Summary:
This diff will allow constructors in Typing_make_type to actually call things like `union` and `intersect`.
It separates Typing_env and Typing_env_types in two different modules to make it easier to deal with circular dependencies. (Typing_env used to *include* Typing_env_types, now it opens it). Now Typing_make_type can depend on Typing_env_types only, avoiding a circular dependency with Typing_env (see D16964381).
Most modules referring to type `env` or other types and record fields now simply open Typing_env_types, the same way they open Typing_defs.
Reviewed By: Wilfred
Differential Revision: D16964286
fbshipit-source-id: 14e0ef9352f8ab7a3ddfbbb80a1fcadace9f9a17
49 files changed: