| commit | e548510b30a5b74f9be9c501d955ca90c7d1a8d0 | |
| author | Michael Buesch <mb@bu3sch.de> | |
| Fri, 19 Mar 2010 15:38:33 +0000 (19 10:38 -0500) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Thu, 1 Apr 2010 22:58:55 +0000 (1 15:58 -0700) | ||
| tree | ce31ad373e269c63ca5a1f1456de37de907c3386 | treesnapshot (tar.gz zip) |
| parent | f15a9d8a07f97af708304414910e7daeb5e5936d | commitdiff |
b43: Workaround circular locking in hw-tkip key update callback
commit 96869a39399269a776a94812e9fff3d38b47d838 upstream
The TKIP key update callback is called from the RX path, where the driver
mutex is already locked. This results in a circular locking bug.
Avoid this by removing the lock.
Johannes noted that there is a separate bug: The callback still breaks on SDIO
hardware, because SDIO hardware access needs to sleep, but we are not allowed
to sleep in the callback due to mac80211's RCU locking.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Reported-by: kecsa@kutfo.hit.bme.hu
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 96869a39399269a776a94812e9fff3d38b47d838 upstream
The TKIP key update callback is called from the RX path, where the driver
mutex is already locked. This results in a circular locking bug.
Avoid this by removing the lock.
Johannes noted that there is a separate bug: The callback still breaks on SDIO
hardware, because SDIO hardware access needs to sleep, but we are not allowed
to sleep in the callback due to mac80211's RCU locking.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Reported-by: kecsa@kutfo.hit.bme.hu
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/net/wireless/b43/main.c | diffblobblamehistory |