Get comparison sizes right.
[smatch.git] / simplify.c
blob83922414f10663901e4f69f633ca9710f30b6f97
1 /*
2 * Simplify - do instruction simplification before CSE
4 * Copyright (C) 2004 Linus Torvalds
5 */
7 #include <assert.h>
9 #include "parse.h"
10 #include "expression.h"
11 #include "linearize.h"
12 #include "flow.h"
14 /* Find the trivial parent for a phi-source */
15 static struct basic_block *phi_parent(struct basic_block *source, pseudo_t pseudo)
17 /* Can't go upwards if the pseudo is defined in the bb it came from.. */
18 if (pseudo->type == PSEUDO_REG) {
19 struct instruction *def = pseudo->def;
20 if (def->bb == source)
21 return source;
23 if (bb_list_size(source->children) != 1 || bb_list_size(source->parents) != 1)
24 return source;
25 return first_basic_block(source->parents);
28 static void clear_phi(struct instruction *insn)
30 pseudo_t phi;
32 insn->bb = NULL;
33 FOR_EACH_PTR(insn->phi_list, phi) {
34 *THIS_ADDRESS(phi) = VOID;
35 } END_FOR_EACH_PTR(phi);
38 static int if_convert_phi(struct instruction *insn)
40 pseudo_t array[3];
41 struct basic_block *parents[3];
42 struct basic_block *bb, *bb1, *bb2, *source;
43 struct instruction *br;
44 pseudo_t p1, p2;
46 bb = insn->bb;
47 if (linearize_ptr_list((struct ptr_list *)insn->phi_list, (void **)array, 3) != 2)
48 return 0;
49 if (linearize_ptr_list((struct ptr_list *)bb->parents, (void **)parents, 3) != 2)
50 return 0;
51 p1 = array[0]->def->src1;
52 bb1 = array[0]->def->bb;
53 p2 = array[1]->def->src1;
54 bb2 = array[1]->def->bb;
56 /* Only try the simple "direct parents" case */
57 if ((bb1 != parents[0] || bb2 != parents[1]) &&
58 (bb1 != parents[1] || bb2 != parents[0]))
59 return 0;
62 * See if we can find a common source for this..
64 source = phi_parent(bb1, p1);
65 if (source != phi_parent(bb2, p2))
66 return 0;
69 * Cool. We now know that 'source' is the exclusive
70 * parent of both phi-nodes, so the exit at the
71 * end of it fully determines which one it is, and
72 * we can turn it into a select.
74 * HOWEVER, right now we only handle regular
75 * conditional branches. No multijumps or computed
76 * stuff. Verify that here.
78 br = last_instruction(source->insns);
79 if (!br || br->opcode != OP_BR)
80 return 0;
82 assert(br->cond);
83 assert(br->bb_false);
86 * We're in business. Match up true/false with p1/p2.
88 if (br->bb_true == bb2 || br->bb_false == bb1) {
89 pseudo_t p = p1;
90 p1 = p2;
91 p2 = p;
95 * Ok, we can now replace that last
97 * br cond, a, b
99 * with the sequence
101 * setcc cond
102 * select pseudo, p1, p2
103 * br cond, a, b
105 * and remove the phi-node. If it then
106 * turns out that 'a' or 'b' is entirely
107 * empty (common case), and now no longer
108 * a phi-source, we'll be able to simplify
109 * the conditional branch too.
111 insert_select(source, br, insn, p1, p2);
112 clear_phi(insn);
113 return REPEAT_CSE;
116 static int clean_up_phi(struct instruction *insn)
118 pseudo_t phi;
119 struct instruction *last;
120 int same;
122 last = NULL;
123 same = 1;
124 FOR_EACH_PTR(insn->phi_list, phi) {
125 struct instruction *def;
126 if (phi == VOID)
127 continue;
128 def = phi->def;
129 if (def->src1 == VOID || !def->bb)
130 continue;
131 if (last) {
132 if (last->src1 != def->src1)
133 same = 0;
134 continue;
136 last = def;
137 } END_FOR_EACH_PTR(phi);
139 if (same) {
140 pseudo_t pseudo = last ? last->src1 : VOID;
141 convert_instruction_target(insn, pseudo);
142 clear_phi(insn);
143 return REPEAT_CSE;
146 return if_convert_phi(insn);
149 static inline void remove_usage(pseudo_t p, pseudo_t *usep)
151 if (has_use_list(p)) {
152 delete_ptr_list_entry((struct ptr_list **)&p->users, usep, 1);
153 if (!p->users)
154 kill_instruction(p->def);
158 void kill_use(pseudo_t *usep)
160 if (usep) {
161 pseudo_t p = *usep;
162 *usep = VOID;
163 remove_usage(p, usep);
167 void kill_instruction(struct instruction *insn)
169 if (!insn || !insn->bb)
170 return;
172 switch (insn->opcode) {
173 case OP_BINARY ... OP_BINCMP_END:
174 insn->bb = NULL;
175 kill_use(&insn->src1);
176 kill_use(&insn->src2);
177 repeat_phase |= REPEAT_CSE;
178 return;
180 case OP_NOT: case OP_NEG:
181 insn->bb = NULL;
182 kill_use(&insn->src1);
183 repeat_phase |= REPEAT_CSE;
184 return;
186 case OP_PHI:
187 insn->bb = NULL;
188 repeat_phase |= REPEAT_CSE;
189 return;
191 case OP_SYMADDR:
192 insn->bb = NULL;
193 repeat_phase |= REPEAT_CSE | REPEAT_SYMBOL_CLEANUP;
194 return;
199 * Kill trivially dead instructions
201 static int dead_insn(struct instruction *insn, pseudo_t *src1, pseudo_t *src2, pseudo_t *src3)
203 pseudo_t *usep;
204 FOR_EACH_PTR(insn->target->users, usep) {
205 if (*usep != VOID)
206 return 0;
207 } END_FOR_EACH_PTR(usep);
209 insn->bb = NULL;
210 kill_use(src1);
211 kill_use(src2);
212 kill_use(src3);
213 return REPEAT_CSE;
216 static inline int constant(pseudo_t pseudo)
218 return pseudo->type == PSEUDO_VAL;
221 static int replace_with_pseudo(struct instruction *insn, pseudo_t pseudo)
223 convert_instruction_target(insn, pseudo);
224 insn->bb = NULL;
225 return REPEAT_CSE;
228 static int simplify_constant_rightside(struct instruction *insn)
230 long long value = insn->src2->value;
232 switch (insn->opcode) {
233 case OP_SUB:
234 if (value) {
235 insn->opcode = OP_ADD;
236 insn->src2 = value_pseudo(-value);
237 return REPEAT_CSE;
239 /* Fallthrough */
240 case OP_ADD:
241 case OP_OR: case OP_XOR:
242 case OP_SHL: case OP_SHR:
243 if (!value)
244 return replace_with_pseudo(insn, insn->src1);
245 return 0;
247 case OP_AND: case OP_MUL:
248 if (!value)
249 return replace_with_pseudo(insn, insn->src2);
250 return 0;
252 return 0;
255 static int simplify_constant_leftside(struct instruction *insn)
257 long long value = insn->src1->value;
259 switch (insn->opcode) {
260 case OP_ADD: case OP_OR: case OP_XOR:
261 if (!value)
262 return replace_with_pseudo(insn, insn->src2);
263 return 0;
265 case OP_SHL: case OP_SHR:
266 case OP_AND: case OP_MUL:
267 if (!value)
268 return replace_with_pseudo(insn, insn->src1);
269 return 0;
271 return 0;
274 static int simplify_constant_binop(struct instruction *insn)
276 /* FIXME! Verify signs and sizes!! */
277 long long left = insn->src1->value;
278 long long right = insn->src2->value;
279 long long res, mask;
281 switch (insn->opcode) {
282 case OP_ADD:
283 res = left + right;
284 break;
285 case OP_SUB:
286 res = left - right;
287 break;
288 case OP_MUL:
289 /* FIXME! Check sign! */
290 res = left * right;
291 break;
292 case OP_DIV:
293 if (!right)
294 return 0;
295 /* FIXME! Check sign! */
296 res = left / right;
297 break;
298 case OP_MOD:
299 if (!right)
300 return 0;
301 /* FIXME! Check sign! */
302 res = left % right;
303 break;
304 case OP_SHL:
305 res = left << right;
306 break;
307 case OP_SHR:
308 /* FIXME! Check sign! */
309 res = left >> right;
310 break;
311 /* Logical */
312 case OP_AND:
313 res = left & right;
314 break;
315 case OP_OR:
316 res = left | right;
317 break;
318 case OP_XOR:
319 res = left ^ right;
320 break;
321 case OP_AND_BOOL:
322 res = left && right;
323 break;
324 case OP_OR_BOOL:
325 res = left || right;
326 break;
328 /* Binary comparison */
329 case OP_SET_EQ:
330 res = left == right;
331 break;
332 case OP_SET_NE:
333 res = left != right;
334 break;
335 case OP_SET_LE:
336 /* FIXME! Check sign! */
337 res = left <= right;
338 break;
339 case OP_SET_GE:
340 /* FIXME! Check sign! */
341 res = left >= right;
342 break;
343 case OP_SET_LT:
344 /* FIXME! Check sign! */
345 res = left < right;
346 break;
347 case OP_SET_GT:
348 /* FIXME! Check sign! */
349 res = left > right;
350 break;
351 case OP_SET_B:
352 /* FIXME! Check sign! */
353 res = (unsigned long long) left < (unsigned long long) right;
354 break;
355 case OP_SET_A:
356 /* FIXME! Check sign! */
357 res = (unsigned long long) left > (unsigned long long) right;
358 break;
359 case OP_SET_BE:
360 /* FIXME! Check sign! */
361 res = (unsigned long long) left <= (unsigned long long) right;
362 break;
363 case OP_SET_AE:
364 /* FIXME! Check sign! */
365 res = (unsigned long long) left >= (unsigned long long) right;
366 break;
367 default:
368 return 0;
370 mask = 1ULL << (insn->size-1);
371 res &= mask | (mask-1);
373 /* FIXME!! Sign??? */
374 replace_with_pseudo(insn, value_pseudo(res));
375 return REPEAT_CSE;
378 static int simplify_binop(struct instruction *insn)
380 if (dead_insn(insn, &insn->src1, &insn->src2, NULL))
381 return REPEAT_CSE;
382 if (constant(insn->src1)) {
383 if (constant(insn->src2))
384 return simplify_constant_binop(insn);
385 return simplify_constant_leftside(insn);
387 if (constant(insn->src2))
388 return simplify_constant_rightside(insn);
389 return 0;
392 static void switch_pseudo(pseudo_t *pp1, pseudo_t *pp2)
394 pseudo_t p1 = *pp1, p2 = *pp2;
396 use_pseudo(p2, pp1);
397 use_pseudo(p1, pp2);
398 remove_usage(p1, pp1);
399 remove_usage(p2, pp2);
402 static int canonical_order(pseudo_t p1, pseudo_t p2)
404 /* symbol/constants on the right */
405 if (p1->type == PSEUDO_VAL)
406 return p2->type == PSEUDO_VAL;
408 if (p1->type == PSEUDO_SYM)
409 return p2->type == PSEUDO_SYM || p2->type == PSEUDO_VAL;
411 return 1;
414 static int simplify_commutative_binop(struct instruction *insn)
416 if (!canonical_order(insn->src1, insn->src2)) {
417 switch_pseudo(&insn->src1, &insn->src2);
418 return REPEAT_CSE;
420 return 0;
423 static inline int simple_pseudo(pseudo_t pseudo)
425 return pseudo->type == PSEUDO_VAL || pseudo->type == PSEUDO_SYM;
428 static int simplify_associative_binop(struct instruction *insn)
430 struct instruction *def;
431 pseudo_t pseudo = insn->src1;
433 if (!simple_pseudo(insn->src2))
434 return 0;
435 if (pseudo->type != PSEUDO_REG)
436 return 0;
437 def = pseudo->def;
438 if (def->opcode != insn->opcode)
439 return 0;
440 if (!simple_pseudo(def->src2))
441 return 0;
442 if (ptr_list_size((struct ptr_list *)def->target->users) != 1)
443 return 0;
444 switch_pseudo(&def->src1, &insn->src2);
445 return REPEAT_CSE;
448 static int simplify_constant_unop(struct instruction *insn)
450 long long val = insn->src1->value;
451 long long res, mask;
453 switch (insn->opcode) {
454 case OP_NOT:
455 res = ~val;
456 break;
457 case OP_NEG:
458 res = -val;
459 break;
460 default:
461 return 0;
463 mask = 1ULL << (insn->size-1);
464 res &= mask | (mask-1);
466 replace_with_pseudo(insn, value_pseudo(res));
467 return REPEAT_CSE;
470 static int simplify_unop(struct instruction *insn)
472 if (dead_insn(insn, &insn->src1, NULL, NULL))
473 return REPEAT_CSE;
474 if (constant(insn->src1))
475 return simplify_constant_unop(insn);
476 return 0;
479 static int simplify_one_memop(struct instruction *insn, pseudo_t orig)
481 pseudo_t addr = insn->src;
482 pseudo_t new, off;
484 if (addr->type == PSEUDO_REG) {
485 struct instruction *def = addr->def;
486 if (def->opcode == OP_SYMADDR && def->src) {
487 kill_use(&insn->src);
488 use_pseudo(def->src, &insn->src);
489 return REPEAT_CSE | REPEAT_SYMBOL_CLEANUP;
491 if (def->opcode == OP_ADD) {
492 new = def->src1;
493 off = def->src2;
494 if (constant(off))
495 goto offset;
496 new = off;
497 off = def->src1;
498 if (constant(off))
499 goto offset;
500 return 0;
503 return 0;
505 offset:
506 /* Invalid code */
507 if (new == orig) {
508 if (new == VOID)
509 return 0;
510 new = VOID;
511 warning(insn->bb->pos, "crazy programmer");
513 insn->offset += off->value;
514 use_pseudo(new, &insn->src);
515 remove_usage(addr, &insn->src);
516 return REPEAT_CSE | REPEAT_SYMBOL_CLEANUP;
520 * We walk the whole chain of adds/subs backwards. That's not
521 * only more efficient, but it allows us to find looops.
523 static int simplify_memop(struct instruction *insn)
525 int one, ret = 0;
526 pseudo_t orig = insn->src;
528 do {
529 one = simplify_one_memop(insn, orig);
530 ret |= one;
531 } while (one);
532 return ret;
535 static int simplify_cast(struct instruction *insn)
537 int orig_size;
539 if (dead_insn(insn, &insn->src, NULL, NULL))
540 return REPEAT_CSE;
541 if (insn->opcode == OP_PTRCAST)
542 return 0;
543 orig_size = insn->orig_type ? insn->orig_type->bit_size : 0;
544 if (orig_size < 0)
545 orig_size = 0;
546 if (insn->size != orig_size)
547 return 0;
548 return replace_with_pseudo(insn, insn->src);
551 static int simplify_select(struct instruction *insn)
553 pseudo_t cond, src1, src2;
555 if (dead_insn(insn, &insn->src1, &insn->src2, &insn->src3))
556 return REPEAT_CSE;
558 cond = insn->src1;
559 src1 = insn->src2;
560 src2 = insn->src3;
561 if (constant(cond) || src1 == src2) {
562 pseudo_t *kill, take;
563 kill_use(&insn->src1);
564 take = cond->value ? src1 : src2;
565 kill = cond->value ? &insn->src3 : &insn->src2;
566 kill_use(kill);
567 replace_with_pseudo(insn, take);
568 return REPEAT_CSE;
570 if (constant(src1) && constant(src2)) {
571 long long val1 = src1->value;
572 long long val2 = src2->value;
574 /* The pair 0/1 is special - replace with SETNE/SETEQ */
575 if ((val1 | val2) == 1) {
576 int opcode = OP_SET_EQ;
577 if (val1) {
578 src1 = src2;
579 opcode = OP_SET_NE;
581 insn->opcode = opcode;
582 /* insn->src1 is already cond */
583 insn->src2 = src1; /* Zero */
584 return REPEAT_CSE;
587 return 0;
591 * Simplify "set_ne/eq $0 + br"
593 static int simplify_cond_branch(struct instruction *br, pseudo_t cond, struct instruction *def, pseudo_t *pp)
595 use_pseudo(*pp, &br->cond);
596 remove_usage(cond, &br->cond);
597 if (def->opcode == OP_SET_EQ) {
598 struct basic_block *true = br->bb_true;
599 struct basic_block *false = br->bb_false;
600 br->bb_false = true;
601 br->bb_true = false;
603 return REPEAT_CSE;
606 static int simplify_branch(struct instruction *insn)
608 pseudo_t cond = insn->cond;
610 if (!cond)
611 return 0;
613 /* Constant conditional */
614 if (constant(cond)) {
615 insert_branch(insn->bb, insn, cond->value ? insn->bb_true : insn->bb_false);
616 return REPEAT_CSE;
619 /* Same target? */
620 if (insn->bb_true == insn->bb_false) {
621 struct basic_block *bb = insn->bb;
622 struct basic_block *target = insn->bb_false;
623 remove_bb_from_list(&target->parents, bb, 1);
624 remove_bb_from_list(&bb->children, target, 1);
625 insn->bb_false = NULL;
626 kill_use(&insn->cond);
627 insn->cond = NULL;
628 return REPEAT_CSE;
631 /* Conditional on a SETNE $0 or SETEQ $0 */
632 if (cond->type == PSEUDO_REG) {
633 struct instruction *def = cond->def;
635 if (def->opcode == OP_SET_NE || def->opcode == OP_SET_EQ) {
636 if (constant(def->src1) && !def->src1->value)
637 return simplify_cond_branch(insn, cond, def, &def->src2);
638 if (constant(def->src2) && !def->src2->value)
639 return simplify_cond_branch(insn, cond, def, &def->src1);
641 if (def->opcode == OP_SEL) {
642 if (constant(def->src2) && constant(def->src3)) {
643 long long val1 = def->src2->value;
644 long long val2 = def->src3->value;
645 if (!val1 && !val2) {
646 insert_branch(insn->bb, insn, insn->bb_false);
647 return REPEAT_CSE;
649 if (val1 && val2) {
650 insert_branch(insn->bb, insn, insn->bb_true);
651 return REPEAT_CSE;
653 if (val2) {
654 struct basic_block *true = insn->bb_true;
655 struct basic_block *false = insn->bb_false;
656 insn->bb_false = true;
657 insn->bb_true = false;
659 use_pseudo(def->src1, &insn->cond);
660 remove_usage(cond, &insn->cond);
661 return REPEAT_CSE;
664 if (def->opcode == OP_CAST) {
665 int orig_size = def->orig_type ? def->orig_type->bit_size : 0;
666 if (def->size > orig_size) {
667 use_pseudo(def->src, &insn->cond);
668 remove_usage(cond, &insn->cond);
669 return REPEAT_CSE;
673 return 0;
676 static int simplify_switch(struct instruction *insn)
678 pseudo_t cond = insn->cond;
679 long long val;
680 struct multijmp *jmp;
682 if (!constant(cond))
683 return 0;
684 val = insn->cond->value;
686 FOR_EACH_PTR(insn->multijmp_list, jmp) {
687 /* Default case */
688 if (jmp->begin > jmp->end)
689 goto found;
690 if (val >= jmp->begin && val <= jmp->end)
691 goto found;
692 } END_FOR_EACH_PTR(jmp);
693 warning(insn->bb->pos, "Impossible case statement");
694 return 0;
696 found:
697 insert_branch(insn->bb, insn, jmp->target);
698 return REPEAT_CSE;
701 int simplify_instruction(struct instruction *insn)
703 if (!insn->bb)
704 return 0;
705 switch (insn->opcode) {
706 case OP_ADD:
707 case OP_AND: case OP_OR: case OP_XOR:
708 case OP_AND_BOOL: case OP_OR_BOOL:
709 if (simplify_binop(insn))
710 return REPEAT_CSE;
711 if (simplify_commutative_binop(insn))
712 return REPEAT_CSE;
713 return simplify_associative_binop(insn);
716 * Multiplication isn't associative in 2's complement,
717 * but we could do it if signed.
719 case OP_MUL:
720 case OP_SET_EQ: case OP_SET_NE:
721 if (simplify_binop(insn))
722 return REPEAT_CSE;
723 return simplify_commutative_binop(insn);
725 case OP_SUB: case OP_DIV: case OP_MOD:
726 case OP_SHL: case OP_SHR:
727 case OP_SET_LE: case OP_SET_GE:
728 case OP_SET_LT: case OP_SET_GT:
729 case OP_SET_B: case OP_SET_A:
730 case OP_SET_BE: case OP_SET_AE:
731 return simplify_binop(insn);
733 case OP_NOT: case OP_NEG:
734 return simplify_unop(insn);
735 case OP_LOAD: case OP_STORE:
736 return simplify_memop(insn);
737 case OP_SYMADDR:
738 if (dead_insn(insn, NULL, NULL, NULL))
739 return REPEAT_CSE | REPEAT_SYMBOL_CLEANUP;
740 return replace_with_pseudo(insn, insn->symbol);
741 case OP_PTRCAST:
742 case OP_CAST:
743 return simplify_cast(insn);
744 case OP_PHI:
745 if (dead_insn(insn, NULL, NULL, NULL)) {
746 clear_phi(insn);
747 return REPEAT_CSE;
749 return clean_up_phi(insn);
750 case OP_PHISOURCE:
751 if (dead_insn(insn, &insn->phi_src, NULL, NULL))
752 return REPEAT_CSE;
753 break;
754 case OP_SEL:
755 return simplify_select(insn);
756 case OP_BR:
757 return simplify_branch(insn);
758 case OP_SWITCH:
759 return simplify_switch(insn);
761 return 0;