smatch_implied.c

   1 /*
   2  * sparse/smatch_implied.c
   3  *
   4  * Copyright (C) 2008 Dan Carpenter.
   5  *
   6  *  Licensed under the Open Software License version 1.1
   7  *
   8  */
   9
  10 /*
  11  * Imagine we have this code:
  12  * foo = 0;
  13  * if (bar)
  14  *         foo = 1;
  15  *                   //  <-- point #1
  16  * else
  17  *         frob();
  18  *                   //  <-- point #2
  19  * if (foo == 1)     //  <-- point #3
  20  *         bar->baz; //  <-- point #4
  21  *
  22  * Currently (Oct 2008) in smatch when we merge bar states
  23  * null and nonnull, at point #2, the state becomes undefined.
  24  * As a result we get an error at point #3.
  25  *
  26  * The idea behind "implied state pools" is to fix that.
  27  *
  28  * The implied pools get created in merge_slist().  Whatever
  29  * is unique to one slist being merged gets put into a pool.
  30  *
  31  * If we set a state that removes it from all pools.
  32  *
  33  * When we come to an if statement where "foo" has some pools
  34  * associated we take all the pools where "foo == 1" and keep
  35  * all the states that are consistent across those pools.
  36  *
  37  * The point of doing this is to turn an undefined state into
  38  * a defined state.  This hopefully gets rid of some false positives.
  39  * What it doesn't do is find new errors that were
  40  * missed before.
  41  *
  42  * There are quite a few implementation details I haven't figured
  43  * out.  How do you create implied state pools inside a
  44  * complex condition?  How do you determine what is implied
  45  * from a complex condition?  The initial patch is extremely rudimentary...
  46  */
  47
  48 #include "smatch.h"
  49 #include "smatch_slist.h"
  50
  51 #define EQUALS 0
  52 #define NOTEQUALS 1
  53
  54 /*
  55  * What are the implications if (foo == num) ...
  56  */
  57
  58 static struct state_list *get_eq_neq_filtered(struct sm_state *sm_state,
  59                                         int eq_neq, int num)
  60 {
  61         struct state_list *list;
  62         struct smatch_state *s;
  63         struct state_list *ret = NULL;
  64
  65         FOR_EACH_PTR(sm_state->pools, list) {
  66                 s = get_state_slist(list, sm_state->name, sm_state->owner,
  67                                     sm_state->sym);
  68                 if (s == &undefined) {
  69                         del_slist(&ret);
  70                         return NULL;
  71                 }
  72                 if (s->data && ((eq_neq == EQUALS && *(int *)s->data == num) ||
  73                                 (eq_neq == NOTEQUALS && *(int *)s->data != num))) {
  74                         if (!ret)
  75                                 ret = clone_states_in_pool(list, __get_cur_slist());
  76                         else
  77                                 filter(&ret, list, __get_cur_slist());
  78                 }
  79         } END_FOR_EACH_PTR(list);
  80         return ret;
  81 }
  82
  83
  84 /*
  85  * This condition hook is very connected to smatch_extra.c.
  86  * It's registered there.
  87  */
  88
  89 void __implied_states_hook(struct expression *expr)
  90 {
  91         struct symbol *sym;
  92         char *name;
  93         struct sm_state *state;
  94         struct state_list *implied_true;
  95         struct state_list *implied_false;
  96
  97         name = get_variable_from_expr(expr, &sym);
  98         if (!name || !sym)
  99                 return;
 100         state = __get_sm_state(name, SMATCH_EXTRA, sym);
 101         if (!state)
 102                 return;
 103         if (!state->pools)
 104                 return;
 105         implied_true = get_eq_neq_filtered(state, NOTEQUALS, 0);
 106         implied_false = get_eq_neq_filtered(state, EQUALS, 0);
 107         if (debug_states) {
 108                 printf("Setting the following implied states for the true path.\n");
 109                 __print_slist(implied_true);
 110         }
 111
 112         /* FIXME.  We lose the ->pools by doing this. */
 113         FOR_EACH_PTR(implied_true, state) {
 114                 set_true_false_states(state->name, state->owner, state->sym,
 115                                 state->state, NULL);
 116         } END_FOR_EACH_PTR(state);
 117
 118         if (debug_states) {
 119                 printf("Setting the following implied states for the false path.\n");
 120                 __print_slist(implied_false);
 121         }
 122
 123         FOR_EACH_PTR(implied_false, state) {
 124                 set_true_false_states(state->name, state->owner, state->sym,
 125                                 NULL, state->state);
 126         } END_FOR_EACH_PTR(state);
 127
 128         free_string(name);
 129 }