2008-06-04 Xinliang David Li <davidxl@google.com>
[official-gcc.git] / gcc / tree-ssa-alias-warnings.c
blobaacaa0ac0ee8647aedbc594d8cfed36bd0e7858a
1 /* Strict aliasing checks.
2 Copyright (C) 2007 Free Software Foundation, Inc.
3 Contributed by Silvius Rus <rus@google.com>.
5 This file is part of GCC.
7 GCC is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 3, or (at your option)
10 any later version.
12 GCC is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details.
17 You should have received a copy of the GNU General Public License
18 along with GCC; see the file COPYING3. If not see
19 <http://www.gnu.org/licenses/>. */
21 #include "config.h"
22 #include "system.h"
23 #include "coretypes.h"
24 #include "tm.h"
25 #include "alloc-pool.h"
26 #include "tree.h"
27 #include "tree-dump.h"
28 #include "tree-flow.h"
29 #include "params.h"
30 #include "function.h"
31 #include "expr.h"
32 #include "toplev.h"
33 #include "diagnostic.h"
34 #include "tree-ssa-structalias.h"
35 #include "tree-ssa-propagate.h"
36 #include "langhooks.h"
38 /* Module to issue a warning when a program uses data through a type
39 different from the type through which the data were defined.
40 Implements -Wstrict-aliasing and -Wstrict-aliasing=n.
41 These checks only happen when -fstrict-aliasing is present.
43 The idea is to use the compiler to identify occurrences of nonstandard
44 aliasing, and report them to programmers. Programs free of such aliasing
45 are more portable, maintainable, and can usually be optimized better.
47 The current, as of April 2007, C and C++ language standards forbid
48 accessing data of type A through an lvalue of another type B,
49 with certain exceptions. See the C Standard ISO/IEC 9899:1999,
50 section 6.5, paragraph 7, and the C++ Standard ISO/IEC 14882:1998,
51 section 3.10, paragraph 15.
53 Example 1:*a is used as int but was defined as a float, *b.
54 int* a = ...;
55 float* b = reinterpret_cast<float*> (a);
56 *b = 2.0;
57 return *a
59 Unfortunately, the problem is in general undecidable if we take into
60 account arithmetic expressions such as array indices or pointer arithmetic.
61 (It is at least as hard as Peano arithmetic decidability.)
62 Even ignoring arithmetic, the problem is still NP-hard, because it is
63 at least as hard as flow-insensitive may-alias analysis, which was proved
64 NP-hard by Horwitz et al, TOPLAS 1997.
66 It is clear that we need to choose some heuristics.
67 Unfortunately, various users have different goals which correspond to
68 different time budgets so a common approach will not suit all.
69 We present the user with three effort/accuracy levels. By accuracy, we mean
70 a common-sense mix of low count of false positives with a
71 reasonably low number of false negatives. We are heavily biased
72 towards a low count of false positives.
73 The effort (compilation time) is likely to increase with the level.
75 -Wstrict-aliasing=1
76 ===================
77 Most aggressive, least accurate. Possibly useful when higher levels
78 do not warn but -fstrict-aliasing still breaks the code, as
79 it has very few false negatives.
80 Warn for all bad pointer conversions, even if never dereferenced.
81 Implemented in the front end (c-common.c).
82 Uses alias_sets_might_conflict to compare types.
84 -Wstrict-aliasing=2
85 ===================
86 Aggressive, not too precise.
87 May still have many false positives (not as many as level 1 though),
88 and few false negatives (but possibly more than level 1).
89 Runs only in the front end. Uses alias_sets_might_conflict to
90 compare types. Does not check for pointer dereferences.
91 Only warns when an address is taken. Warns about incomplete type punning.
93 -Wstrict-aliasing=3 (default)
94 ===================
95 Should have very few false positives and few false negatives.
96 Takes care of the common punn+dereference pattern in the front end:
97 *(int*)&some_float.
98 Takes care of multiple statement cases in the back end,
99 using flow-sensitive points-to information (-O required).
100 Uses alias_sets_conflict_p to compare types and only warns
101 when the converted pointer is dereferenced.
102 Does not warn about incomplete type punning.
104 Future improvements can be included by adding higher levels.
106 In summary, expression level analysis is performed in the front-end,
107 and multiple-statement analysis is performed in the backend.
108 The remainder of this discussion is only about the backend analysis.
110 This implementation uses flow-sensitive points-to information.
111 Flow-sensitivity refers to accesses to the pointer, and not the object
112 pointed. For instance, we do not warn about the following case.
114 Example 2.
115 int* a = (int*)malloc (...);
116 float* b = reinterpret_cast<float*> (a);
117 *b = 2.0;
118 a = (int*)malloc (...);
119 return *a;
121 In SSA, it becomes clear that the INT value *A_2 referenced in the
122 return statement is not aliased to the FLOAT defined through *B_1.
123 int* a_1 = (int*)malloc (...);
124 float* b_1 = reinterpret_cast<float*> (a_1);
125 *b_1 = 2.0;
126 a_2 = (int*)malloc (...);
127 return *a_2;
130 Algorithm Outline
131 =================
133 ForEach (ptr, object) in the points-to table
134 If (incompatible_types (*ptr, object))
135 If (referenced (ptr, current function)
136 and referenced (object, current function))
137 Issue warning (ptr, object, reference locations)
139 The complexity is:
140 O (sizeof (points-to table)
141 + sizeof (function body) * lookup_time (points-to table))
143 Pointer dereference locations are looked up on demand. The search is
144 a single scan of the function body, in which all references to pointers
145 and objects in the points-to table are recorded. However, this dominant
146 time factor occurs rarely, only when cross-type aliasing was detected.
149 Limitations of the Proposed Implementation
150 ==========================================
152 1. We do not catch the following case, because -fstrict-aliasing will
153 associate different tags with MEM while building points-to information,
154 thus before we get to analyze it.
155 XXX: this could be solved by either running with -fno-strict-aliasing
156 or by recording the points-to information before splitting the original
157 tag based on type.
159 Example 3.
160 void* mem = malloc (...);
161 int* pi = reinterpret_cast<int*> (mem);
162 float* b = reinterpret_cast<float*> (mem);
163 *b = 2.0;
164 return *pi+1;
166 2. We do not check whether the two conflicting (de)references can
167 reach each other in the control flow sense. If we fixed limitation
168 1, we would wrongly issue a warning in the following case.
170 Example 4.
171 void* raw = malloc (...);
172 if (...) {
173 float* b = reinterpret_cast<float*> (raw);
174 *b = 2.0;
175 return (int)*b;
176 } else {
177 int* a = reinterpret_cast<int*> (raw);
178 *a = 1;
179 return *a;
181 3. Only simple types are compared, thus no structures, unions or classes
182 are analyzed. A first attempt to deal with structures introduced much
183 complication and has not showed much improvement in preliminary tests,
184 so it was left out.
186 4. All analysis is intraprocedural. */
189 /* Local declarations. */
190 static void find_references_in_function (void);
194 /* Get main type of tree TYPE, stripping array dimensions and qualifiers. */
196 static tree
197 get_main_type (tree type)
199 while (TREE_CODE (type) == ARRAY_TYPE)
200 type = TREE_TYPE (type);
201 return TYPE_MAIN_VARIANT (type);
205 /* Get the type of the given object. If IS_PTR is true, get the type of the
206 object pointed to or referenced by OBJECT instead.
207 For arrays, return the element type. Ignore all qualifiers. */
209 static tree
210 get_otype (tree object, bool is_ptr)
212 tree otype = TREE_TYPE (object);
214 if (is_ptr)
216 gcc_assert (POINTER_TYPE_P (otype));
217 otype = TREE_TYPE (otype);
219 return get_main_type (otype);
223 /* Return true if tree TYPE is struct, class or union. */
225 static bool
226 struct_class_union_p (tree type)
228 return (TREE_CODE (type) == RECORD_TYPE
229 || TREE_CODE (type) == UNION_TYPE
230 || TREE_CODE (type) == QUAL_UNION_TYPE);
235 /* Keep data during a search for an aliasing site.
236 RHS = object or pointer aliased. No LHS is specified because we are only
237 looking in the UseDef paths of a given variable, so LHS will always be
238 an SSA name of the same variable.
239 When IS_RHS_POINTER = true, we are looking for ... = RHS. Otherwise,
240 we are looking for ... = &RHS.
241 SITE is the output of a search, non-NULL if the search succeeded. */
243 struct alias_match
245 tree rhs;
246 bool is_rhs_pointer;
247 tree site;
251 /* Callback for find_alias_site. Return true if the right hand site
252 of STMT matches DATA. */
254 static bool
255 find_alias_site_helper (tree var ATTRIBUTE_UNUSED, tree stmt, void *data)
257 struct alias_match *match = (struct alias_match *) data;
258 tree rhs_pointer = get_rhs (stmt);
259 tree to_match = NULL_TREE;
261 while (CONVERT_EXPR_P (rhs_pointer)
262 || TREE_CODE (rhs_pointer) == VIEW_CONVERT_EXPR)
263 rhs_pointer = TREE_OPERAND (rhs_pointer, 0);
265 if (!rhs_pointer)
266 /* Not a type conversion. */
267 return false;
269 if (TREE_CODE (rhs_pointer) == ADDR_EXPR && !match->is_rhs_pointer)
270 to_match = TREE_OPERAND (rhs_pointer, 0);
271 else if (POINTER_TYPE_P (rhs_pointer) && match->is_rhs_pointer)
272 to_match = rhs_pointer;
274 if (to_match != match->rhs)
275 /* Type conversion, but not a name match. */
276 return false;
278 /* Found it. */
279 match->site = stmt;
280 return true;
284 /* Find the statement where OBJECT1 gets aliased to OBJECT2.
285 If IS_PTR2 is true, consider OBJECT2 to be the name of a pointer or
286 reference rather than the actual aliased object.
287 For now, just implement the case where OBJECT1 is an SSA name defined
288 by a PHI statement. */
290 static tree
291 find_alias_site (tree object1, bool is_ptr1 ATTRIBUTE_UNUSED,
292 tree object2, bool is_ptr2)
294 struct alias_match match;
296 match.rhs = object2;
297 match.is_rhs_pointer = is_ptr2;
298 match.site = NULL_TREE;
300 if (TREE_CODE (object1) != SSA_NAME)
301 return NULL_TREE;
303 walk_use_def_chains (object1, find_alias_site_helper, &match, false);
304 return match.site;
308 /* Structure to store temporary results when trying to figure out whether
309 an object is referenced. Just its presence in the text is not enough,
310 as we may just be taking its address. */
312 struct match_info
314 tree object;
315 bool is_ptr;
316 /* The difference between the number of references to OBJECT
317 and the number of occurrences of &OBJECT. */
318 int found;
322 /* Return the base if EXPR is an SSA name. Return EXPR otherwise. */
324 static tree
325 get_ssa_base (tree expr)
327 if (TREE_CODE (expr) == SSA_NAME)
328 return SSA_NAME_VAR (expr);
329 else
330 return expr;
334 /* Record references to objects and pointer dereferences across some piece of
335 code. The number of references is recorded for each item.
336 References to an object just to take its address are not counted.
337 For instance, if PTR is a pointer and OBJ is an object:
338 1. Expression &obj + *ptr will have the following reference match structure:
339 ptrs: <ptr, 1>
340 objs: <ptr, 1>
341 OBJ does not appear as referenced because we just take its address.
342 2. Expression ptr + *ptr will have the following reference match structure:
343 ptrs: <ptr, 1>
344 objs: <ptr, 2>
345 PTR shows up twice as an object, but is dereferenced only once.
347 The elements of the hash tables are tree_map objects. */
348 struct reference_matches
350 htab_t ptrs;
351 htab_t objs;
355 /* Return the match, if any. Otherwise, return NULL_TREE. It will
356 return NULL_TREE even when a match was found, if the value associated
357 to KEY is NULL_TREE. */
359 static inline tree
360 match (htab_t ref_map, tree key)
362 struct tree_map *found;
363 void **slot = NULL;
364 slot = htab_find_slot (ref_map, &key, NO_INSERT);
366 if (!slot)
367 return NULL_TREE;
369 found = (struct tree_map *) *slot;
370 return found->to;
374 /* Set the entry corresponding to KEY, but only if the entry
375 already exists and its value is NULL_TREE. Otherwise, do nothing. */
377 static inline void
378 maybe_add_match (htab_t ref_map, struct tree_map *key)
380 struct tree_map *found = (struct tree_map *) htab_find (ref_map, key);
382 if (found && !found->to)
383 found->to = key->to;
387 /* Add an entry to HT, with key T and value NULL_TREE. */
389 static void
390 add_key (htab_t ht, tree t, alloc_pool references_pool)
392 void **slot;
393 struct tree_map *tp = (struct tree_map *) pool_alloc (references_pool);
395 tp->base.from = t;
396 tp->to = NULL_TREE;
397 slot = htab_find_slot (ht, &t, INSERT);
398 *slot = (void *) tp;
402 /* Some memory to keep the objects in the reference table. */
404 static alloc_pool ref_table_alloc_pool = NULL;
407 /* Get some memory to keep the objects in the reference table. */
409 static inline alloc_pool
410 reference_table_alloc_pool (bool build)
412 if (ref_table_alloc_pool || !build)
413 return ref_table_alloc_pool;
415 ref_table_alloc_pool =
416 create_alloc_pool ("ref_table_alloc_pool", sizeof (struct tree_map), 20);
418 return ref_table_alloc_pool;
422 /* Initialize the reference table by adding all pointers in the points-to
423 table as keys, and NULL_TREE as associated values. */
425 static struct reference_matches *
426 build_reference_table (void)
428 unsigned int i;
429 struct reference_matches *ref_table = NULL;
430 alloc_pool references_pool = reference_table_alloc_pool (true);
432 ref_table = XNEW (struct reference_matches);
433 ref_table->objs = htab_create (10, tree_map_base_hash, tree_map_eq, NULL);
434 ref_table->ptrs = htab_create (10, tree_map_base_hash, tree_map_eq, NULL);
436 for (i = 1; i < num_ssa_names; i++)
438 tree ptr = ssa_name (i);
439 struct ptr_info_def *pi;
441 if (ptr == NULL_TREE)
442 continue;
444 pi = SSA_NAME_PTR_INFO (ptr);
446 if (!SSA_NAME_IN_FREE_LIST (ptr) && pi && pi->name_mem_tag)
448 /* Add pointer to the interesting dereference list. */
449 add_key (ref_table->ptrs, ptr, references_pool);
451 /* Add all aliased names to the interesting reference list. */
452 if (pi->pt_vars)
454 unsigned ix;
455 bitmap_iterator bi;
457 EXECUTE_IF_SET_IN_BITMAP (pi->pt_vars, 0, ix, bi)
459 tree alias = referenced_var (ix);
460 add_key (ref_table->objs, alias, references_pool);
466 return ref_table;
470 /* Reference table. */
472 static struct reference_matches *ref_table = NULL;
475 /* Clean up the reference table if allocated. */
477 static void
478 maybe_free_reference_table (void)
480 if (ref_table)
482 htab_delete (ref_table->ptrs);
483 htab_delete (ref_table->objs);
484 free (ref_table);
485 ref_table = NULL;
488 if (ref_table_alloc_pool)
490 free_alloc_pool (ref_table_alloc_pool);
491 ref_table_alloc_pool = NULL;
496 /* Get the reference table. Initialize it if needed. */
498 static inline struct reference_matches *
499 reference_table (bool build)
501 if (ref_table || !build)
502 return ref_table;
504 ref_table = build_reference_table ();
505 find_references_in_function ();
506 return ref_table;
510 /* Callback for find_references_in_function.
511 Check whether *TP is an object reference or pointer dereference for the
512 variables given in ((struct match_info*)DATA)->OBJS or
513 ((struct match_info*)DATA)->PTRS. The total number of references
514 is stored in the same structures. */
516 static tree
517 find_references_in_tree_helper (tree *tp,
518 int *walk_subtrees ATTRIBUTE_UNUSED,
519 void *data)
521 struct tree_map match;
522 static int parent_tree_code = ERROR_MARK;
524 /* Do not report references just for the purpose of taking an address.
525 XXX: we rely on the fact that the tree walk is in preorder
526 and that ADDR_EXPR is not a leaf, thus cannot be carried over across
527 walks. */
528 if (parent_tree_code == ADDR_EXPR)
529 goto finish;
531 match.to = (tree) data;
533 if (TREE_CODE (*tp) == INDIRECT_REF)
535 match.base.from = TREE_OPERAND (*tp, 0);
536 maybe_add_match (reference_table (true)->ptrs, &match);
538 else
540 match.base.from = *tp;
541 maybe_add_match (reference_table (true)->objs, &match);
544 finish:
545 parent_tree_code = TREE_CODE (*tp);
546 return NULL_TREE;
550 /* Find all the references to aliased variables in the current function. */
552 static void
553 find_references_in_function (void)
555 basic_block bb;
556 block_stmt_iterator i;
558 FOR_EACH_BB (bb)
559 for (i = bsi_start (bb); !bsi_end_p (i); bsi_next (&i))
560 walk_tree (bsi_stmt_ptr (i), find_references_in_tree_helper,
561 (void *) *bsi_stmt_ptr (i), NULL);
565 /* Find the reference site for OBJECT.
566 If IS_PTR is true, look for dereferences of OBJECT instead.
567 XXX: only the first site is returned in the current
568 implementation. If there are no matching sites, return NULL_TREE. */
570 static tree
571 reference_site (tree object, bool is_ptr)
573 if (is_ptr)
574 return match (reference_table (true)->ptrs, object);
575 else
576 return match (reference_table (true)->objs, object);
580 /* Try to get more location info when something is missing.
581 OBJECT1 and OBJECT2 are aliased names. If IS_PTR1 or IS_PTR2, the alias
582 is on the memory referenced or pointed to by OBJECT1 and OBJECT2.
583 ALIAS_SITE, DEREF_SITE1 and DEREF_SITE2 are the statements where the
584 alias takes place (some pointer assignment usually) and where the
585 alias is referenced through OBJECT1 and OBJECT2 respectively.
586 REF_TYPE1 and REF_TYPE2 will return the type of the reference at the
587 respective sites. Only the first matching reference is returned for
588 each name. If no statement is found, the function header is returned. */
590 static void
591 maybe_find_missing_stmts (tree object1, bool is_ptr1,
592 tree object2, bool is_ptr2,
593 tree *alias_site,
594 tree *deref_site1,
595 tree *deref_site2)
597 if (object1 && object2)
599 if (!*alias_site || !EXPR_HAS_LOCATION (*alias_site))
600 *alias_site = find_alias_site (object1, is_ptr1, object2, is_ptr2);
602 if (!*deref_site1 || !EXPR_HAS_LOCATION (*deref_site1))
603 *deref_site1 = reference_site (object1, is_ptr1);
605 if (!*deref_site2 || !EXPR_HAS_LOCATION (*deref_site2))
606 *deref_site2 = reference_site (object2, is_ptr2);
609 /* If we could not find the alias site, set it to one of the dereference
610 sites, if available. */
611 if (!*alias_site)
613 if (*deref_site1)
614 *alias_site = *deref_site1;
615 else if (*deref_site2)
616 *alias_site = *deref_site2;
619 /* If we could not find the dereference sites, set them to the alias site,
620 if known. */
621 if (!*deref_site1 && *alias_site)
622 *deref_site1 = *alias_site;
623 if (!*deref_site2 && *alias_site)
624 *deref_site2 = *alias_site;
628 /* Callback for find_first_artificial_name.
629 Find out if there are no artificial names at tree node *T. */
631 static tree
632 ffan_walker (tree *t,
633 int *go_below ATTRIBUTE_UNUSED,
634 void *data ATTRIBUTE_UNUSED)
636 if (DECL_P (*t) && !MTAG_P (*t) && DECL_ARTIFICIAL (*t))
637 return *t;
638 else
639 return NULL_TREE;
642 /* Return the first artificial name within EXPR, or NULL_TREE if
643 none exists. */
645 static tree
646 find_first_artificial_name (tree expr)
648 return walk_tree_without_duplicates (&expr, ffan_walker, NULL);
652 /* Get a name from the original program for VAR. */
654 static const char *
655 get_var_name (tree var)
657 if (TREE_CODE (var) == SSA_NAME)
658 return get_var_name (get_ssa_base (var));
660 if (find_first_artificial_name (var))
661 return "{unknown}";
663 if (TREE_CODE (var) == VAR_DECL || TREE_CODE (var) == PARM_DECL)
664 if (DECL_NAME (var))
665 return IDENTIFIER_POINTER (DECL_NAME (var));
667 return "{unknown}";
671 /* Return "*" if OBJECT is not the actual alias but a pointer to it, or
672 "" otherwise.
673 IS_PTR is true when OBJECT is not the actual alias.
674 In addition to checking IS_PTR, we also make sure that OBJECT is a pointer
675 since IS_PTR would also be true for C++ references, but we should only
676 print a * before a pointer and not before a reference. */
678 static const char *
679 get_maybe_star_prefix (tree object, bool is_ptr)
681 gcc_assert (object);
682 return (is_ptr
683 && TREE_CODE (TREE_TYPE (object)) == POINTER_TYPE) ? "*" : "";
687 /* Callback for contains_node_type_p.
688 Returns true if *T has tree code *(int*)DATA. */
690 static tree
691 contains_node_type_p_callback (tree *t,
692 int *go_below ATTRIBUTE_UNUSED,
693 void *data)
695 return ((int) TREE_CODE (*t) == *((int *) data)) ? *t : NULL_TREE;
699 /* Return true if T contains a node with tree code TYPE. */
701 static bool
702 contains_node_type_p (tree t, int type)
704 return (walk_tree_without_duplicates (&t, contains_node_type_p_callback,
705 (void *) &type)
706 != NULL_TREE);
710 /* Return true if a warning was issued in the front end at STMT. */
712 static bool
713 already_warned_in_frontend_p (tree stmt)
715 tree rhs_pointer;
717 if (stmt == NULL_TREE)
718 return false;
720 rhs_pointer = get_rhs (stmt);
722 if ((CONVERT_EXPR_P (rhs_pointer)
723 || TREE_CODE (rhs_pointer) == VIEW_CONVERT_EXPR)
724 && TREE_NO_WARNING (rhs_pointer))
725 return true;
726 else
727 return false;
731 /* Return true if and only if TYPE is a function or method pointer type,
732 or pointer to a pointer to ... to a function or method. */
734 static bool
735 is_method_pointer (tree type)
737 while (TREE_CODE (type) == POINTER_TYPE)
738 type = TREE_TYPE (type);
739 return TREE_CODE (type) == METHOD_TYPE || TREE_CODE (type) == FUNCTION_TYPE;
743 /* Issue a -Wstrict-aliasing warning.
744 OBJECT1 and OBJECT2 are aliased names.
745 If IS_PTR1 and/or IS_PTR2 is true, then the corresponding name
746 OBJECT1/OBJECT2 is a pointer or reference to the aliased memory,
747 rather than actual storage.
748 ALIAS_SITE is a statement where the alias took place. In the most common
749 case, that is where a pointer was assigned to the address of an object. */
751 static bool
752 strict_aliasing_warn (tree alias_site,
753 tree object1, bool is_ptr1,
754 tree object2, bool is_ptr2,
755 bool filter_artificials)
757 tree ref_site1 = NULL_TREE;
758 tree ref_site2 = NULL_TREE;
759 const char *name1;
760 const char *name2;
761 location_t alias_loc;
762 location_t ref1_loc;
763 location_t ref2_loc;
764 gcc_assert (object1);
765 gcc_assert (object2);
766 name1 = get_var_name (object1);
767 name2 = get_var_name (object2);
770 if (is_method_pointer (get_main_type (TREE_TYPE (object2))))
771 return false;
773 maybe_find_missing_stmts (object1, is_ptr1, object2, is_ptr2, &alias_site,
774 &ref_site1, &ref_site2);
776 if (EXPR_HAS_LOCATION (alias_site))
777 alias_loc = EXPR_LOCATION (alias_site);
778 else
779 return false;
781 if (EXPR_HAS_LOCATION (ref_site1))
782 ref1_loc = EXPR_LOCATION (ref_site1);
783 else
784 ref1_loc = alias_loc;
786 if (EXPR_HAS_LOCATION (ref_site2))
787 ref2_loc = EXPR_LOCATION (ref_site2);
788 else
789 ref2_loc = alias_loc;
791 if (already_warned_in_frontend_p (alias_site))
792 return false;
794 /* If they are not SSA names, but contain SSA names, drop the warning
795 because it cannot be displayed well.
796 Also drop it if they both contain artificials.
797 XXX: this is a hack, must figure out a better way to display them. */
798 if (filter_artificials)
799 if ((find_first_artificial_name (get_ssa_base (object1))
800 && find_first_artificial_name (get_ssa_base (object2)))
801 || (TREE_CODE (object1) != SSA_NAME
802 && contains_node_type_p (object1, SSA_NAME))
803 || (TREE_CODE (object2) != SSA_NAME
804 && contains_node_type_p (object2, SSA_NAME)))
805 return false;
808 /* XXX: In the following format string, %s:%d should be replaced by %H.
809 However, in my tests only the first %H printed ok, while the
810 second and third were printed as blanks. */
811 warning (OPT_Wstrict_aliasing,
812 "%Hlikely type-punning may break strict-aliasing rules: "
813 "object %<%s%s%> of main type %qT is referenced at or around "
814 "%s:%d and may be "
815 "aliased to object %<%s%s%> of main type %qT which is referenced "
816 "at or around %s:%d.",
817 &alias_loc,
818 get_maybe_star_prefix (object1, is_ptr1),
819 name1, get_otype (object1, is_ptr1),
820 LOCATION_FILE (ref1_loc), LOCATION_LINE (ref1_loc),
821 get_maybe_star_prefix (object2, is_ptr2),
822 name2, get_otype (object2, is_ptr2),
823 LOCATION_FILE (ref2_loc), LOCATION_LINE (ref2_loc));
825 return true;
830 /* Return true when any objects of TYPE1 and TYPE2 respectively
831 may not be aliased according to the language standard. */
833 static bool
834 nonstandard_alias_types_p (tree type1, tree type2)
836 alias_set_type set1;
837 alias_set_type set2;
839 if (VOID_TYPE_P (type1) || VOID_TYPE_P (type2))
840 return false;
842 set1 = get_alias_set (type1);
843 set2 = get_alias_set (type2);
844 return !alias_sets_conflict_p (set1, set2);
849 /* Returns true when *PTR may not be aliased to ALIAS.
850 See C standard 6.5p7 and C++ standard 3.10p15.
851 If PTR_PTR is true, ALIAS represents a pointer or reference to the
852 aliased storage rather than its actual name. */
854 static bool
855 nonstandard_alias_p (tree ptr, tree alias, bool ptr_ptr)
857 /* Find the types to compare. */
858 tree ptr_type = get_otype (ptr, true);
859 tree alias_type = get_otype (alias, ptr_ptr);
861 /* XXX: for now, say it's OK if the alias escapes.
862 Not sure this is needed in general, but otherwise GCC will not
863 bootstrap. */
864 if (var_ann (get_ssa_base (alias))->escape_mask != NO_ESCAPE)
865 return false;
867 /* XXX: don't get into structures for now. It brings much complication
868 and little benefit. */
869 if (struct_class_union_p (ptr_type) || struct_class_union_p (alias_type))
870 return false;
872 /* If they are both SSA names of artificials, let it go, the warning
873 is too confusing. */
874 if (find_first_artificial_name (ptr) && find_first_artificial_name (alias))
875 return false;
877 /* Compare the types. */
878 return nonstandard_alias_types_p (ptr_type, alias_type);
882 /* Return true when we should skip analysis for pointer PTR based on the
883 fact that their alias information *PI is not considered relevant. */
885 static bool
886 skip_this_pointer (tree ptr ATTRIBUTE_UNUSED, struct ptr_info_def *pi)
888 /* If it is not dereferenced, it is not a problem (locally). */
889 if (!pi->is_dereferenced)
890 return true;
892 /* This would probably cause too many false positives. */
893 if (pi->value_escapes_p || pi->pt_anything)
894 return true;
896 return false;
900 /* Find aliasing to named objects for pointer PTR. */
902 static void
903 dsa_named_for (tree ptr)
905 struct ptr_info_def *pi = SSA_NAME_PTR_INFO (ptr);
907 if (pi)
909 if (skip_this_pointer (ptr, pi))
910 return;
912 /* For all the variables it could be aliased to. */
913 if (pi->pt_vars)
915 unsigned ix;
916 bitmap_iterator bi;
918 EXECUTE_IF_SET_IN_BITMAP (pi->pt_vars, 0, ix, bi)
920 tree alias = referenced_var (ix);
922 if (nonstandard_alias_p (ptr, alias, false))
923 strict_aliasing_warn (SSA_NAME_DEF_STMT (ptr),
924 ptr, true, alias, false, true);
931 /* Detect and report strict aliasing violation of named objects. */
933 static void
934 detect_strict_aliasing_named (void)
936 unsigned int i;
938 for (i = 1; i < num_ssa_names; i++)
940 tree ptr = ssa_name (i);
941 struct ptr_info_def *pi;
943 if (ptr == NULL_TREE)
944 continue;
946 pi = SSA_NAME_PTR_INFO (ptr);
948 if (!SSA_NAME_IN_FREE_LIST (ptr) && pi && pi->name_mem_tag)
949 dsa_named_for (ptr);
954 /* Return false only the first time I see each instance of FUNC. */
956 static bool
957 processed_func_p (tree func)
959 static htab_t seen = NULL;
960 void **slot = NULL;
962 if (!seen)
963 seen = htab_create (10, tree_map_base_hash, tree_map_eq, NULL);
965 slot = htab_find_slot (seen, &func, INSERT);
966 gcc_assert (slot);
968 if (*slot)
969 return true;
971 gcc_assert (slot);
972 *slot = &func;
973 return false;
977 /* Detect and warn about type-punning using points-to information. */
979 void
980 strict_aliasing_warning_backend (void)
982 if (flag_strict_aliasing && warn_strict_aliasing == 3
983 && !processed_func_p (current_function_decl))
985 detect_strict_aliasing_named ();
986 maybe_free_reference_table ();