1 /* This plugin contains an analysis pass that detects and warns about
2 self-assignment statements. */
3 /* { dg-options "-O" } */
5 #include "gcc-plugin.h"
11 #include "basic-block.h"
14 #include "tree-pass.h"
16 #include "plugin-version.h"
18 int plugin_is_GPL_compatible
;
20 /* Indicate whether to check overloaded operator '=', which is performed by
21 default. To disable it, use -fplugin-arg-NAME-no-check-operator-eq. */
22 bool check_operator_eq
= true;
24 /* Given a rhs EXPR of a gimple assign statement, if it is
25 - SSA_NAME : returns its var decl, or, if it is a temp variable,
26 returns the rhs of its SSA def statement.
27 - VAR_DECL, PARM_DECL, FIELD_DECL, or a reference expression :
29 - any other expression : returns NULL_TREE. */
32 get_real_ref_rhs (tree expr
)
34 switch (TREE_CODE (expr
))
38 /* Given a self-assign statement, say foo.x = foo.x,
39 the IR (after SSA) looks like:
44 So if the rhs EXPR is an SSA_NAME of a temp variable,
45 e.g. D.1797_14, we need to grab the rhs of its SSA def
46 statement (i.e. foo.x). */
47 tree vdecl
= SSA_NAME_VAR (expr
);
48 if (DECL_ARTIFICIAL (vdecl
)
49 && !gimple_nop_p (SSA_NAME_DEF_STMT (expr
)))
51 gimple def_stmt
= SSA_NAME_DEF_STMT (expr
);
52 /* We are only interested in an assignment with a single
53 rhs operand because if it is not, the original assignment
54 will not possibly be a self-assignment. */
55 if (gimple_assign_single_p (def_stmt
))
56 return get_real_ref_rhs (gimple_assign_rhs1 (def_stmt
));
75 /* Given an expression tree, EXPR, that may contains SSA names, returns an
76 equivalent tree with the SSA names converted to var/parm/field decls
77 so that it can be used with '%E' format modifier when emitting warning
80 This function currently only supports VAR/PARM/FIELD_DECL, reference
81 expressions (COMPONENT_REF, INDIRECT_REF, ARRAY_REF), integer constant,
82 and SSA_NAME. If EXPR contains any other tree nodes (e.g. an arithmetic
83 expression appears in array index), NULL_TREE is returned. */
86 get_non_ssa_expr (tree expr
)
88 switch (TREE_CODE (expr
))
101 tree base
, orig_base
= TREE_OPERAND (expr
, 0);
102 tree component
, orig_component
= TREE_OPERAND (expr
, 1);
103 base
= get_non_ssa_expr (orig_base
);
106 component
= get_non_ssa_expr (orig_component
);
109 /* If either BASE or COMPONENT is converted, build a new
110 component reference tree. */
111 if (base
!= orig_base
|| component
!= orig_component
)
112 return build3 (COMPONENT_REF
, TREE_TYPE (component
),
113 base
, component
, NULL_TREE
);
119 tree orig_base
= TREE_OPERAND (expr
, 0);
120 if (TREE_CODE (orig_base
) == SSA_NAME
)
122 tree base
= get_non_ssa_expr (orig_base
);
125 return fold_build2 (MEM_REF
, TREE_TYPE (expr
),
126 base
, TREE_OPERAND (expr
, 1));
132 tree array
, orig_array
= TREE_OPERAND (expr
, 0);
133 tree index
, orig_index
= TREE_OPERAND (expr
, 1);
134 array
= get_non_ssa_expr (orig_array
);
137 index
= get_non_ssa_expr (orig_index
);
140 /* If either ARRAY or INDEX is converted, build a new array
142 if (array
!= orig_array
|| index
!= orig_index
)
143 return build4 (ARRAY_REF
, TREE_TYPE (expr
), array
, index
,
144 TREE_OPERAND (expr
, 2), TREE_OPERAND (expr
, 3));
150 tree vdecl
= SSA_NAME_VAR (expr
);
151 if (DECL_ARTIFICIAL (vdecl
)
152 && !gimple_nop_p (SSA_NAME_DEF_STMT (expr
)))
154 gimple def_stmt
= SSA_NAME_DEF_STMT (expr
);
155 if (gimple_assign_single_p (def_stmt
))
156 vdecl
= gimple_assign_rhs1 (def_stmt
);
158 return get_non_ssa_expr (vdecl
);
163 /* Return NULL_TREE for any other kind of tree nodes. */
168 /* Given the LHS and (real) RHS of a gimple assign statement, STMT, check if
169 they are the same. If so, print a warning message about self-assignment. */
172 compare_and_warn (gimple stmt
, tree lhs
, tree rhs
)
174 if (operand_equal_p (lhs
, rhs
, OEP_PURE_SAME
))
177 location
= (gimple_has_location (stmt
)
178 ? gimple_location (stmt
)
180 ? DECL_SOURCE_LOCATION (lhs
)
182 /* If LHS contains any tree node not currently supported by
183 get_non_ssa_expr, simply emit a generic warning without
184 specifying LHS in the message. */
185 lhs
= get_non_ssa_expr (lhs
);
187 warning_at (location
, 0, G_("%qE is assigned to itself"), lhs
);
189 warning_at (location
, 0, G_("self-assignment detected"));
193 /* Check and warn if STMT is a self-assign statement. */
196 warn_self_assign (gimple stmt
)
200 /* Check assigment statement. */
201 if (gimple_assign_single_p (stmt
))
203 rhs
= get_real_ref_rhs (gimple_assign_rhs1 (stmt
));
207 lhs
= gimple_assign_lhs (stmt
);
208 if (TREE_CODE (lhs
) == SSA_NAME
)
210 lhs
= SSA_NAME_VAR (lhs
);
211 if (DECL_ARTIFICIAL (lhs
))
215 compare_and_warn (stmt
, lhs
, rhs
);
217 /* Check overloaded operator '=' (if enabled). */
218 else if (check_operator_eq
&& is_gimple_call (stmt
))
220 tree fdecl
= gimple_call_fndecl (stmt
);
221 if (fdecl
&& (DECL_NAME (fdecl
) == maybe_get_identifier ("operator=")))
223 /* If 'operator=' takes reference operands, the arguments will be
224 ADDR_EXPR trees. In this case, just remove the address-taken
225 operator before we compare the lhs and rhs. */
226 lhs
= gimple_call_arg (stmt
, 0);
227 if (TREE_CODE (lhs
) == ADDR_EXPR
)
228 lhs
= TREE_OPERAND (lhs
, 0);
229 rhs
= gimple_call_arg (stmt
, 1);
230 if (TREE_CODE (rhs
) == ADDR_EXPR
)
231 rhs
= TREE_OPERAND (rhs
, 0);
233 compare_and_warn (stmt
, lhs
, rhs
);
238 /* Entry point for the self-assignment detection pass. */
241 execute_warn_self_assign (void)
243 gimple_stmt_iterator gsi
;
248 for (gsi
= gsi_start_bb (bb
); !gsi_end_p (gsi
); gsi_next (&gsi
))
249 warn_self_assign (gsi_stmt (gsi
));
255 /* Pass gate function. Currently always returns true. */
258 gate_warn_self_assign (void)
263 static struct gimple_opt_pass pass_warn_self_assign
=
267 "warn_self_assign", /* name */
268 gate_warn_self_assign
, /* gate */
269 execute_warn_self_assign
, /* execute */
272 0, /* static_pass_number */
274 PROP_ssa
, /* properties_required */
275 0, /* properties_provided */
276 0, /* properties_destroyed */
277 0, /* todo_flags_start */
278 TODO_dump_func
/* todo_flags_finish */
282 /* The initialization routine exposed to and called by GCC. The spec of this
283 function is defined in gcc/gcc-plugin.h.
285 PLUGIN_NAME - name of the plugin (useful for error reporting)
286 ARGC - the size of the ARGV array
287 ARGV - an array of key-value argument pair
289 Returns 0 if initialization finishes successfully.
291 Note that this function needs to be named exactly "plugin_init". */
294 plugin_init (struct plugin_name_args
*plugin_info
,
295 struct plugin_gcc_version
*version
)
297 struct register_pass_info pass_info
;
298 const char *plugin_name
= plugin_info
->base_name
;
299 int argc
= plugin_info
->argc
;
300 struct plugin_argument
*argv
= plugin_info
->argv
;
304 if (!plugin_default_version_check (version
, &gcc_version
))
307 /* Self-assign detection should happen after SSA is constructed. */
308 pass_info
.pass
= &pass_warn_self_assign
.pass
;
309 pass_info
.reference_pass_name
= "ssa";
310 pass_info
.ref_pass_instance_number
= 1;
311 pass_info
.pos_op
= PASS_POS_INSERT_AFTER
;
313 /* Process the plugin arguments. This plugin takes the following arguments:
314 check-operator-eq, no-check-operator-eq, enable, and disable.
315 By default, the analysis is enabled with 'operator=' checked. */
316 for (i
= 0; i
< argc
; ++i
)
318 if (!strcmp (argv
[i
].key
, "check-operator-eq"))
321 warning (0, G_("option '-fplugin-arg-%s-check-operator-eq=%s'"
322 " ignored (superfluous '=%s')"),
323 plugin_name
, argv
[i
].value
, argv
[i
].value
);
325 check_operator_eq
= true;
327 else if (!strcmp (argv
[i
].key
, "no-check-operator-eq"))
330 warning (0, G_("option '-fplugin-arg-%s-no-check-operator-eq=%s'"
331 " ignored (superfluous '=%s')"),
332 plugin_name
, argv
[i
].value
, argv
[i
].value
);
334 check_operator_eq
= false;
336 else if (!strcmp (argv
[i
].key
, "enable"))
339 warning (0, G_("option '-fplugin-arg-%s-enable=%s' ignored"
340 " (superfluous '=%s')"),
341 plugin_name
, argv
[i
].value
, argv
[i
].value
);
345 else if (!strcmp (argv
[i
].key
, "disable"))
348 warning (0, G_("option '-fplugin-arg-%s-disable=%s' ignored"
349 " (superfluous '=%s')"),
350 plugin_name
, argv
[i
].value
, argv
[i
].value
);
355 warning (0, G_("plugin %qs: unrecognized argument %qs ignored"),
356 plugin_name
, argv
[i
].key
);
359 /* Register this new pass with GCC if the analysis is enabled. */
361 register_callback (plugin_name
, PLUGIN_PASS_MANAGER_SETUP
, NULL
,