| blob | 86155bdb4c56cb0bcfd24d381f93960d884aac7d |
1 #!/usr/bin/perl -w
2 # (c) 2001, Dave Jones. (the file handling bit)
3 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
4 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
5 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
6 # Licensed under the terms of the GNU GPL License version 2
51 Options:
54 --emacs emacs compile window format
55 --terse one line per report
68 is all off)
70 literally
73 "<inputfile>.EXPERIMENTAL-checkpatch-fixes"
74 with potential errors corrected to the preferred
75 checkpatch style
80 runtime errors.
84 EOM
87 }
109 }
110 }
113 }
115 GetOptions(
150 }
151 }
156 }
172 }
173 }
182 }
184 }
185 }
195 ## no critic
198 }
205 }
215 __user|
216 __kernel|
217 __force|
218 __iomem|
219 __must_check|
220 __init_refok|
221 __kprobes|
222 __ref|
223 __rcu
231 # Notes to $Attribute:
232 # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
234 const|
235 __percpu|
236 __nocast|
237 __safe|
238 __bitwise__|
239 __packed__|
240 __packed2__|
241 __naked|
242 __maybe_unused|
243 __always_unused|
244 __noreturn|
245 __used|
246 __cold|
247 __noclone|
248 __deprecated|
249 __read_mostly|
250 __kprobes|
252 ____cacheline_aligned|
253 ____cacheline_aligned_in_smp|
254 ____cacheline_internodealigned_in_smp|
255 __weak
276 <=|>=|==|!=|
277 =>|->|<<|>>|<|>|!|~|
305 atomic_t
306 )};
310 (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
312 panic|
315 )};
324 To:|
325 Cc:
326 )};
347 );
352 );
356 );
362 ["debugfs_create_(?:file|u8|u16|u32|u64|x8|x16|x32|x64|size_t|atomic_t|bool|blob|regset32|u32_array)", 2],
365 );
367 #Create a search pattern for all these functions to speed up a loop below
372 }
375 irq|
376 memory
377 )};
378 # memory.h: ARM has a custom one
391 )
400 )
404 $NonptrType
409 }
410 build_types();
414 # Using $balanced_parens, $LvalOrFunc, or $FuncArg
415 # requires at least perl version v5.10.0
416 # Any use must be runtime checked with $^V
429 }
434 }
458 }
459 }
460 }
484 }
486 }
494 }
498 }
503 }
507 }
515 }
517 }
518 }
534 }
539 }
543 }
547 }
551 }
576 # If there's a name left after stripping spaces and
577 # leading quotes, and the address doesn't have both
578 # leading and trailing angle brackets, the address
579 # is invalid. ie:
580 # "joe smith joe@smith.com" bad
581 # "joe smith <joe@smith.com" bad
586 }
587 }
597 }
600 }
614 }
620 }
623 }
631 }
632 }
635 }
648 }
650 }
653 }
656 }
660 }
665 # Drop the diff line leader and expand tabs
669 # Pick the indent from the front of the line.
673 }
684 }
685 }
696 # Always copy over the diff marker.
702 # Comments we are wacking completly including the begin
703 # and end, all to $;.
710 }
716 }
723 }
725 # A \ in a string means ignore the next character.
731 }
732 # Regular quotes.
741 }
742 }
744 #print "c<$c> SQ<$sanitise_quote>\n";
753 }
754 }
758 }
760 # The pathname on a #include may be surrounded by '<' and '>'.
765 # The whole of a #error is a string.
769 }
772 }
779 }
802 #warn "CSB: blk<$blk> remain<$remain>\n";
803 # If we are about to drop off the end, pull in more
804 # context.
815 }
816 # Bail if there is no further context.
817 #warn "CSB: blk<$blk> off<$off> len<$len>\n";
820 }
824 }
825 }
830 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
832 # Handle nested #if/#else.
839 }
841 # Statement ends at the ';' or a close '}' at the
842 # outermost level.
845 }
847 # An else is really a conditional as long as its not else if
854 #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
855 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
856 }
861 }
869 #warn "CSB: mark coff<$coff>\n";
870 }
871 }
875 }
883 }
885 }
886 }
887 # Preprocessor commands end at the newline unless escaped.
893 }
895 }
896 # We are truly at the end, so shuffle to the next line.
901 }
906 #warn "STATEMENT<$statement>\n";
907 #warn "CONDITION<$condition>\n";
909 #print "coff<$coff> soff<$off> loff<$loff>\n";
913 }
918 # Strip the diff line prefixes and rip blank lines at start and end.
926 }
934 }
955 }
956 }
964 # Grab the first conditional/block pair.
967 #print "F: c<$condition> s<$statement> remain<$remain>\n";
971 }
973 # Pull in the following conditional/block pairs and see if they
974 # could continue the statement.
978 #print "C: c<$condition> s<$statement> remain<$remain>\n";
980 #print "C: push\n";
982 }
985 }
1004 # Handle nested #if/#else.
1011 }
1014 ##print "C<$c>L<$level><$open$close>O<$off>\n";
1018 }
1025 }
1026 }
1030 }
1033 }
1036 }
1042 }
1048 }
1054 }
1059 }
1064 }
1069 # Catch a comment on the end of the line itself.
1073 # Look through the context and try and figure out if there is a
1074 # comment.
1079 #warn " $line\n";
1082 }
1085 }
1088 }
1092 }
1093 }
1097 }
1102 ##print "LINE: $rawlines[$end_line - 1 ]\n";
1103 ##print "CMMT: $cmt\n";
1106 }
1119 }
1122 }
1134 }
1135 }
1139 }
1151 }
1171 }
1192 }
1221 # Assume all arms of the conditional end as this
1222 # one does, and continue as if the #endif was not here.
1239 }
1270 }
1282 }
1315 }
1330 }
1339 }
1343 }
1347 }
1348 }
1351 }
1360 DEFINE_\S+
1361 )$|
1365 case|
1369 \#|
1370 \#\#|
1376 # Check for modifiers.
1387 }
1388 }
1393 }
1394 build_types();
1397 }
1398 }
1408 }
1416 }
1422 }
1428 }
1432 }
1441 }
1443 }
1451 }
1453 }
1461 }
1463 }
1471 }
1479 }
1487 }
1495 }
1504 #convert leading spaces to tabs
1506 #Remove spaces before a tab
1510 }
1524 }
1536 }
1537 }
1540 }
1571 # Trace the real file/line as we go.
1583 # suppression flags
1591 # Pre-scan the patch sanitizing the lines.
1592 # Pre-scan the patch looking for any __setup documentation.
1593 #
1599 sanitise_line_reset();
1611 }
1612 #next;
1613 }
1620 }
1623 # Guestimate if this is a continuing comment. Run
1624 # the context looking for a comment "edge". If this
1625 # edge is a close comment then we must be in a comment
1626 # at context start.
1633 #print "RAW<$rawlines[$ln - 1]>\n";
1639 }
1640 }
1643 }
1645 # Guestimate if this is a continuing comment. If this
1646 # is the start of a diff block and this line starts
1647 # ' *' then it is very likely a comment.
1650 {
1652 }
1654 ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
1658 # Standardise the strings and chars within the input to
1659 # simplify matching -- only bother with positive lines.
1661 }
1668 }
1670 #print "==>$rawline\n";
1671 #print "-->$line\n";
1675 }
1676 }
1689 #extract the line range in the file after the patch is applied
1698 }
1699 annotate_reset();
1708 # track the line number as we move through the hunk, note that
1709 # new versions of GNU diff omit the leading space on completely
1710 # blank context lines so we need to count that too.
1715 # Measure the line length and indent.
1718 # Track the previous line.
1723 #warn "line<$line>\n";
1727 }
1731 #make up the handle for any error we report on this line
1738 # extract the filename as it passes
1749 }
1759 # Check for incorrect file permissions
1766 }
1767 }
1769 # Check the patch for a signoff:
1773 }
1775 # Check for wrappage within a valid hunk of the file
1780 }
1782 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
1793 }
1795 # Check if it's the start of a commit log
1796 # (not a header line and we haven't seen the patch filename)
1801 }
1803 # Check if there is UTF-8 in a commit log when a mail header has explicitly
1804 # declined it, i.e defined some charset where it is missing.
1809 }
1815 }
1817 # ignore non-hunk lines and lines being removed
1820 #trailing whitespace
1827 }
1834 }
1837 }
1839 # Check for FSF mailing addresses.
1847 "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)
1848 }
1850 # check we are in a valid source file if not then ignore this hunk
1853 #line length limit
1856 !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:|,|\)\s*;)\s*$/ ||
1859 {
1862 }
1864 # Check for user-visible strings broken across lines, which breaks the ability
1865 # to grep for the string. Make exceptions when the previous string ends in a
1866 # newline (multiple lines in one string constant) or '\t', '\r', ';', or '{'
1867 # (common in inline assembly) or is a octal \123 or hexadecimal \xaf value
1873 }
1875 # check for spaces before a quoted newline
1881 }
1883 }
1885 # check for adding lines without a newline.
1886 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
1889 }
1891 # check we are in a valid source file C or perl if not then ignore this hunk
1894 # at the beginning of a line any tabs must come first and anything
1895 # more than 8 must use tabs.
1904 }
1905 }
1907 # check for space before tabs.
1917 }
1918 }
1920 # check for && or || at the start of a line
1924 }
1926 # check multi-line statement indentation matches previous line
1928 $prevline =~ /^\+([ \t]*)((?:$c90_Keywords(?:\s+if)\s*)|(?:$Declare\s*)?(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*|$Ident\s*=\s*$Ident\s*)\(.*(\&\&|\|\||,)\s*$/) {
1951 }
1952 }
1953 }
1954 }
1962 }
1963 }
1965 # check for spaces at the beginning of a line.
1966 # Exceptions:
1967 # 1) within comments
1968 # 2) indented preprocessor commands
1969 # 3) hanging labels
1976 }
1977 }
1979 # check we are in a valid C source file if not then ignore this hunk
1982 # check for RCS/CVS revision markers
1986 }
1988 # Check for potential 'bare' types
1991 #print "LINE<$line>\n";
1999 #print "linenr<$linenr> <$stat>\n";
2000 # If this statement has no statement boundaries within
2001 # it there is no point in retrying a statement scan
2002 # until we hit end of it.
2005 #print "skip<$line_nr_next>\n";
2007 }
2009 # Find the real next line.
2015 }
2020 # Ignore goto labels.
2023 # Ignore functions being called
2028 # declarations always start with types
2029 } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
2034 # definitions in global scope can only start with types
2037 }
2039 # any (foo ... *) is a pointer cast, and foo is a type
2042 }
2044 # Check for any sort of function declaration.
2045 # int foo(something bar, other baz);
2046 # void (*store_gdt)(x86_descr_ptr *);
2047 if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
2055 if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
2058 }
2059 }
2060 }
2062 }
2064 #
2065 # Checks which may be anchored in the context.
2066 #
2068 # Check for switch () and associated case and default
2069 # statements should be at the same indent.
2083 }
2084 }
2088 }
2089 }
2091 # if/while/etc brace do not go on next line, unless defining a do while loop,
2092 # or if that brace on the next line is for something else
2101 }
2112 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
2115 }
2117 #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
2118 #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
2124 }
2128 {
2134 }
2135 }
2136 }
2138 # Check relative indent for conditionals and blocks.
2139 if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
2147 # Make sure we remove the line prefixes as we have
2148 # none on the first line, and are going to readd them
2149 # where necessary.
2152 # Find out how long the conditional actually is.
2156 # We want to check the first line inside the block
2157 # starting at the end of the conditional, so remove:
2158 # 1) any blank line termination
2159 # 2) any opening brace { on end of the line
2160 # 3) any do (...) {
2167 }
2171 }
2173 # Also ignore a loop construct at the end of a
2174 # preprocessor statement.
2178 }
2185 # If we see an #else/#elif then the code
2186 # is not linear.
2189 }
2191 # Ignore:
2192 # 1) blank lines, they should be at 0,
2193 # 2) preprocessor lines, and
2194 # 3) labels.
2202 }
2203 }
2204 }
2209 # Check if either of these lines are modified, else
2210 # this is not this patch's fault.
2214 }
2217 }
2219 #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
2224 "suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
2225 }
2226 }
2228 # Track the 'values' across context and added lines.
2238 }
2241 #ignore lines not being added
2244 # TEST: allow direct testing of the type matcher.
2252 }
2254 }
2255 # TEST: allow direct testing of the attribute matcher.
2263 }
2265 }
2267 # check for initialisation to aggregates open brace on the next line
2272 }
2274 #
2275 # Checks which are anchored on the added line.
2276 #
2278 # check for malformed paths in #include statements (uses RAW line)
2284 }
2285 }
2287 # no C99 // comments
2296 }
2297 }
2298 }
2299 # Remove C99 comments.
2303 # check for global initialisers.
2310 }
2311 }
2312 # check for static initialisers.
2319 }
2320 }
2322 # check for static const char * arrays.
2327 }
2329 # check for static char foo[] = "bar" declarations.
2334 }
2336 # check for non-global char *foo[] = {"bar", ...} declarations.
2341 }
2343 # check for function declarations without arguments like "int foo()"
2349 }
2350 }
2352 # check for new typedefs, only function parameters and sparse annotations
2353 # make sense.
2361 }
2363 # * goes on variable not on type
2364 # (char*[ const])
2366 #print "AA<$1>\n";
2369 # Should start with a space.
2371 # Should not end with a space.
2373 # '*'s should not have spaces between.
2375 }
2377 ## print "1: from<$from> to<$to> ident<$ident>\n";
2387 }
2388 }
2389 }
2391 #print "BB<$1>\n";
2394 # Should start with a space.
2396 # Should not end with a space.
2398 # '*'s should not have spaces between.
2400 }
2401 # Modifiers should have spaces.
2404 ## print "2: from<$from> to<$to> ident<$ident>\n";
2415 }
2416 }
2417 }
2420 # function brace can't be on same line, except for #defines of do while,
2421 # or if closed on same line
2426 }
2428 # open braces for enum, union and struct go on the same line.
2433 }
2435 # missing space after union, struct or enum definition
2442 }
2443 }
2445 # Function pointer declarations
2446 # check spacing between type, funcptr, and args
2447 # canonical declaration is "type (*funcptr)(args...)"
2456 # the $Declare variable will capture all spaces after the type
2457 # so check it for a missing trailing missing space but pointer return types
2458 # don't need a space so don't warn for those.
2463 }
2468 }
2470 # unnecessary space "type (*funcptr)(args...)"
2471 # This test is not currently implemented because these declarations are
2472 # equivalent to
2473 # int foo(int bar, ...)
2474 # and this is form shouldn't/doesn't generate a checkpatch warning.
2475 #
2476 # elsif ($declare =~ /\s{2,}$/) {
2477 # WARN("SPACING",
2478 # "Multiple spaces after return type\n" . $herecurr);
2479 # }
2481 # unnecessary space "type ( *funcptr)(args...)"
2486 }
2488 # unnecessary space "type (* funcptr)(args...)"
2493 }
2495 # unnecessary space "type (*funcptr )(args...)"
2500 }
2502 # unnecessary space "type (*funcptr) (args...)"
2507 }
2511 s/^(.\s*)$Declare\s*\(\s*\*\s*$Ident\s*\)\s*\(/$1 . $declare . $post_declare_space . '(*' . $funcname . ')('/ex;
2512 }
2513 }
2515 # check for spacing round square brackets; allowed:
2516 # 1. with a type on the left -- int [] a;
2517 # 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
2518 # 3. inside a curly brace -- = { [0...10] = 5 }
2529 }
2530 }
2531 }
2533 # check for spaces between functions and their parentheses.
2539 # Ignore those directives where spaces _are_ permitted.
2545 {
2546 # cpp #define statements have non-optional spaces, ie
2547 # if there is a space between the name and the open
2548 # parenthesis it is simply not a parameter group.
2551 # cpp #elif statement condition may start with a (
2554 # If this whole things ends with a type its most
2555 # likely a typedef for a function.
2564 }
2565 }
2566 }
2568 # Check operator spacing.
2574 <<=|>>=|<=|>=|==|!=|
2576 =>|->|<<|>>|<|>|=|!|~|
2588 }
2599 ## print("n: <$n> good: <$good>\n");
2603 # Pick up the preceding and succeeding characters.
2608 }
2631 }
2640 # Pull out the value of this operator.
2643 # Get the full operator variant.
2646 # Ignore operators passed as parameters.
2650 # # Ignore comments
2651 # } elsif ($op =~ /^$;+$/) {
2653 # ; should have either the end of line or a space or \ after it
2661 }
2662 }
2664 # // is a comment
2667 # : when part of a bitfield
2669 # skip the bitfield test for now
2671 # No spaces for:
2672 # ->
2680 }
2682 }
2683 }
2685 # , must have a space on the right.
2693 }
2694 }
2696 # '*' as part of a type definition -- reported already.
2698 #warn "'*' is part of type\n";
2700 # unary operators should have a space before and
2701 # none after. May be left adjacent to another
2702 # unary operator, or a cast
2712 }
2713 }
2714 }
2716 # A unary '*' may be const
2724 }
2726 }
2727 }
2729 # unary ++ and unary -- are allowed no space on one side.
2736 }
2737 }
2744 }
2745 }
2752 }
2754 }
2755 }
2757 # << and >> may either have or not have spaces both sides
2763 {
2770 }
2772 }
2773 }
2775 # A colon needs no spaces before when it is
2776 # terminating a case value or a label.
2783 }
2784 }
2786 # All the others need spaces both sides.
2790 # Ignore email addresses <foo@bar>
2795 {
2797 }
2799 # messages are ERROR, but ?: are CHK
2809 }
2811 }
2812 }
2813 }
2816 ## print("n: <$n> GOOD: <$good>\n");
2819 }
2823 }
2827 }
2830 }
2832 # check for whitespace before a non-naked semicolon
2839 }
2840 }
2842 # check for multiple assignments
2846 }
2849 #need space before brace following if, while, etc
2856 }
2857 }
2859 # closing brace should have a space following it when it has anything
2860 # on the line
2867 }
2868 }
2870 # check spacing on square brackets
2877 }
2878 }
2885 }
2886 }
2888 # check spacing on parentheses
2896 }
2897 }
2906 }
2907 }
2909 #goto labels aren't indented, allow a single space however
2917 }
2918 }
2920 # return is not a function
2930 }
2934 }
2935 }
2937 # if statements using unnecessary parentheses - ie: if ((foo == bar))
2943 if ($line =~ /\bif\s*(?:\(\s*){$count,$count}$LvalOrFunc\s*($Compare)\s*$LvalOrFunc(?:\s*\)){$count,$count}/) {
2948 }
2949 }
2951 # Return of what appears to be an errno should normally be -'ve
2957 }
2958 }
2960 # Need a space before open parenthesis after if, while etc
2967 }
2968 }
2970 # Check for illegal assignment in if conditional -- and check for trailing
2971 # statements after the conditional.
2979 ##print "stat<$stat> stat_next<$stat_next>\n";
2982 # If the statement carries leading newlines,
2983 # then count those as offsets.
2991 }
2992 }
3001 }
3003 # Find out what is on the end of the line after the
3004 # conditional.
3010 {
3011 # Find out how long the conditional actually is.
3020 }
3024 }
3025 }
3027 # Check for bitwise tests written as boolean
3033 |
3038 {
3041 }
3043 # if and else should not have general statements after it
3050 }
3051 }
3052 # if should not continue a brace
3057 }
3058 # case and default should not have general statements after them
3064 {
3067 }
3069 # Check for }<nl>else {, these must be at the same
3070 # indent level to be relevant to each other.
3075 }
3081 # Find out what is on the end of the line after the
3082 # conditional.
3089 }
3090 }
3092 #Specific variable tests
3096 #gcc binary extension
3104 }
3105 }
3107 #CamelCase
3110 #Ignore Page<foo> variants
3112 #Ignore SI style variants like nS, mV and dB (ie: max_uV, regulator_min_uA_show)
3118 seed_camelcase_includes();
3122 }
3123 }
3128 }
3129 }
3130 }
3131 }
3133 #no spaces allowed after \ in define
3139 }
3140 }
3142 # multi-statement macros should be enclosed in a do while loop, grab the
3143 # first statement and ensure its the whole macro if its not enclosed
3144 # in a known good container
3154 #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
3155 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
3163 # Flatten any parentheses and braces
3167 {
3168 }
3170 # Flatten any obvious string concatentation.
3173 {
3174 }
3178 module_param_named|
3179 MODULE_PARM_DESC|
3180 DECLARE_PER_CPU|
3181 DEFINE_PER_CPU|
3182 __typeof__\(|
3183 union|
3184 struct|
3188 #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n";
3192 $dstat !~ /^[!~-]?(?:$Lval|$Constant)$/ && # 10 // foo() // !foo // ~foo // -foo // foo->bar // foo.bar->baz
3197 $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ && # do {...} while (...); // do {...} while (...)
3203 {
3210 }
3218 }
3219 }
3221 # check for line continuations outside of #defines, preprocessor #, and asm
3230 }
3231 }
3233 # do {} while (0) macro tests:
3234 # single-statement macros do not need to be enclosed in do while (0) loop,
3235 # macro should not end with a semicolon
3249 if ($dstat =~ /^\+\s*#\s*define\s+$Ident\s*${balanced_parens}\s*do\s*{(.*)\s*}\s*while\s*\(\s*0\s*\)\s*([;\s]*)\s*$/) {
3259 }
3265 }
3269 }
3270 }
3271 }
3273 # check for redundant bracing round if etc
3277 #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
3278 #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
3288 # If the condition carries leading newlines, then count those as offsets.
3293 #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
3295 # We have looked at and allowed this specific line.
3305 #print "cond<$cond> block<$block> allowed<$allowed[$allow]>\n";
3307 #print "APW: ALLOWED: cond<$cond>\n";
3309 }
3311 #print "APW: ALLOWED: block<$block>\n";
3313 }
3315 #print "APW: ALLOWED: lines block<$block>\n";
3317 }
3319 }
3324 }
3332 }
3333 }
3334 }
3335 }
3340 # Check the pre-context.
3342 #print "APW: ALLOWED: pre<$1>\n";
3344 }
3349 # Check the condition.
3351 #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
3354 }
3356 #print "APW: ALLOWED: cond<$cond>\n";
3358 }
3360 #print "APW: ALLOWED: block<$block>\n";
3362 }
3364 #print "APW: ALLOWED: lines block<$block>\n";
3366 }
3367 # Check the post-context.
3372 }
3374 #print "APW: ALLOWED: chunk-1 block<$block>\n";
3376 }
3377 }
3384 }
3388 }
3389 }
3391 # check for unnecessary blank lines around braces
3395 }
3399 }
3401 # warn about #if 0
3406 }
3408 # check for needless "if (<foo>) fn(<foo>)" uses
3414 }
3415 }
3417 # check for bad placement of section $InitAttribute (e.g.: __initdata)
3420 if ($line =~ /^\+\s*static\s+(?:const\s+)?(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*[=;]/) {
3430 $fixed[$linenr - 1] =~ s/(\bstatic\s+(?:const\s+)?)(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*([=;])\s*/"$1" . trim(string_find_replace($2, "\\s*$attr\\s*", " ")) . " " . trim(string_find_replace($3, "\\s*$attr\\s*", "")) . " $attr" . ("$4" eq ";" ? ";" : " = ")/e;
3431 }
3432 }
3433 }
3435 # check for $InitAttributeData (ie: __initdata) with const
3446 }
3447 }
3449 # check for $InitAttributeConst (ie: __initconst) without const
3461 }
3462 }
3464 # warn about #ifdefs in C files
3465 # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
3466 # print "#ifdef in C files should be avoided\n";
3467 # print "$herecurr";
3468 # $clean = 0;
3469 # }
3471 # warn about spacing in #ifdefs
3478 }
3480 }
3482 # Check that the storage class is at the beginning of a declaration
3486 }
3488 # check the location of the inline attribute, that it is between
3489 # storage class and type.
3494 }
3496 # Check for __inline__ and __inline, prefer inline
3504 }
3505 }
3507 # Check for __attribute__ packed, prefer __packed
3512 }
3514 # Check for __attribute__ aligned, prefer __aligned
3519 }
3521 # Check for __attribute__ format(printf, prefer __printf
3525 "__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))\n" . $herecurr) &&
3527 $fixed[$linenr - 1] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf\s*,\s*(.*)\)\s*\)\s*\)/"__printf(" . trim($1) . ")"/ex;
3529 }
3530 }
3532 # Check for __attribute__ format(scanf, prefer __scanf
3536 "__scanf(string-index, first-to-check) is preferred over __attribute__((format(scanf, string-index, first-to-check)))\n" . $herecurr) &&
3538 $fixed[$linenr - 1] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*scanf\s*,\s*(.*)\)\s*\)\s*\)/"__scanf(" . trim($1) . ")"/ex;
3539 }
3540 }
3542 # check for sizeof(&)
3546 }
3548 # check for sizeof without parenthesis
3553 $fixed[$linenr - 1] =~ s/\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/"sizeof(" . trim($1) . ")"/ex;
3554 }
3555 }
3557 # check for line continuations in quoted strings with odd counts of "
3561 }
3563 # Check for misused memsets
3578 }
3579 }
3581 # typecasts on min/max could be min_t/max_t
3599 }
3602 }
3603 }
3605 # check for naked sscanf
3617 }
3620 }
3622 # check for new externs in .h files.
3629 }
3630 }
3632 # check for new externs in .c files.
3635 {
3642 }
3645 {
3648 }
3653 }
3657 {
3660 }
3663 # check for multiple semicolons
3669 }
3670 }
3672 # check for case / default statements not preceeded by break/fallthrough/switch
3690 }
3694 }
3695 }
3697 # check for switch/default statements without a break;
3706 }
3709 }
3711 # check for gcc specific __FUNCTION__
3717 }
3718 }
3720 # check for comparisons against true and false
3736 }
3741 ## maybe suggesting a correct construct would better
3742 ## "Using comparison to $otype is error prone. Perhaps use '${lead}${op}${arg}${trail}'\n" . $herecurr);
3744 }
3745 }
3747 # check for %L{u,d,i} in strings
3756 }
3757 }
3759 # Mode permission misuses where it seems decimal should be octal
3760 # This uses a shortcut match to avoid unnecessary uses of a slow foreach loop
3771 }
3782 }
3783 }
3784 }
3785 }
3786 }
3788 # If we have no input at all, then there is nothing to report on
3789 # so just keep quiet.
3792 }
3794 # In mailback mode only produce a report in the negative, for
3795 # things that appear to be patches.
3798 }
3800 # This is not a patch, and we are are in 'no-patch' mode so
3801 # just keep quiet.
3804 }
3809 }
3818 }
3825 }
3827 # If there were whitespace errors which cleanpatch can fix
3828 # then suggest that.
3833 }
3834 }
3853 }
3856 }
3857 }
3864 Do _NOT_ trust the results written to this file.
3867 This EXPERIMENTAL file is simply a convenience to help rewrite patches.
3870 EOM
3871 }
3872 }
3876 }
3881 EOM
3882 }
3885 }