winejack.drv: Fix missing unlock. Found by Smatch.
[wine/dibdrv.git] / dlls / d3d8 / surface.c
blob6ecd7af8c8fedbe4f0276d78e0bcf361082c76eb
1 /*
2 * IDirect3DSurface8 implementation
4 * Copyright 2005 Oliver Stieber
6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Lesser General Public
8 * License as published by the Free Software Foundation; either
9 * version 2.1 of the License, or (at your option) any later version.
11 * This library is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 * Lesser General Public License for more details.
16 * You should have received a copy of the GNU Lesser General Public
17 * License along with this library; if not, write to the Free Software
18 * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
21 #include "config.h"
22 #include "d3d8_private.h"
24 WINE_DEFAULT_DEBUG_CHANNEL(d3d8);
26 /* IDirect3DSurface8 IUnknown parts follow: */
27 static HRESULT WINAPI IDirect3DSurface8Impl_QueryInterface(LPDIRECT3DSURFACE8 iface, REFIID riid, LPVOID *ppobj) {
28 IDirect3DSurface8Impl *This = (IDirect3DSurface8Impl *)iface;
30 if (IsEqualGUID(riid, &IID_IUnknown)
31 || IsEqualGUID(riid, &IID_IDirect3DResource8)
32 || IsEqualGUID(riid, &IID_IDirect3DSurface8)) {
33 IUnknown_AddRef(iface);
34 *ppobj = This;
35 return S_OK;
38 WARN("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppobj);
39 *ppobj = NULL;
40 return E_NOINTERFACE;
43 static ULONG WINAPI IDirect3DSurface8Impl_AddRef(LPDIRECT3DSURFACE8 iface) {
44 IDirect3DSurface8Impl *This = (IDirect3DSurface8Impl *)iface;
46 TRACE("(%p)\n", This);
48 if (This->forwardReference) {
49 /* Forward refcounting */
50 TRACE("(%p) : Forwarding to %p\n", This, This->forwardReference);
51 return IUnknown_AddRef(This->forwardReference);
52 } else {
53 /* No container, handle our own refcounting */
54 ULONG ref = InterlockedIncrement(&This->ref);
55 if(ref == 1 && This->parentDevice) IUnknown_AddRef(This->parentDevice);
56 TRACE("(%p) : AddRef from %d\n", This, ref - 1);
57 return ref;
61 static ULONG WINAPI IDirect3DSurface8Impl_Release(LPDIRECT3DSURFACE8 iface) {
62 IDirect3DSurface8Impl *This = (IDirect3DSurface8Impl *)iface;
64 TRACE("(%p)\n", This);
66 if (This->forwardReference) {
67 /* Forward refcounting */
68 TRACE("(%p) : Forwarding to %p\n", This, This->forwardReference);
69 return IUnknown_Release(This->forwardReference);
70 } else {
71 /* No container, handle our own refcounting */
72 ULONG ref = InterlockedDecrement(&This->ref);
73 TRACE("(%p) : ReleaseRef to %d\n", This, ref);
75 if (ref == 0) {
76 if (This->parentDevice) IUnknown_Release(This->parentDevice);
77 /* Implicit surfaces are destroyed with the device, not if refcount reaches 0. */
78 if (!This->isImplicit) {
79 EnterCriticalSection(&d3d8_cs);
80 IWineD3DSurface_Release(This->wineD3DSurface);
81 LeaveCriticalSection(&d3d8_cs);
82 HeapFree(GetProcessHeap(), 0, This);
86 return ref;
90 /* IDirect3DSurface8 IDirect3DResource8 Interface follow: */
91 static HRESULT WINAPI IDirect3DSurface8Impl_GetDevice(LPDIRECT3DSURFACE8 iface, IDirect3DDevice8 **ppDevice) {
92 IDirect3DSurface8Impl *This = (IDirect3DSurface8Impl *)iface;
93 HRESULT hr;
94 TRACE("(%p)->(%p)\n", This, ppDevice);
96 EnterCriticalSection(&d3d8_cs);
97 hr = IDirect3DResource8Impl_GetDevice((LPDIRECT3DRESOURCE8) This, ppDevice);
98 LeaveCriticalSection(&d3d8_cs);
99 return hr;
102 static HRESULT WINAPI IDirect3DSurface8Impl_SetPrivateData(LPDIRECT3DSURFACE8 iface, REFGUID refguid, CONST void *pData, DWORD SizeOfData, DWORD Flags) {
103 IDirect3DSurface8Impl *This = (IDirect3DSurface8Impl *)iface;
104 HRESULT hr;
105 TRACE("(%p) Relay\n", This);
107 EnterCriticalSection(&d3d8_cs);
108 hr = IWineD3DSurface_SetPrivateData(This->wineD3DSurface, refguid, pData, SizeOfData, Flags);
109 LeaveCriticalSection(&d3d8_cs);
110 return hr;
113 static HRESULT WINAPI IDirect3DSurface8Impl_GetPrivateData(LPDIRECT3DSURFACE8 iface, REFGUID refguid, void *pData, DWORD *pSizeOfData) {
114 IDirect3DSurface8Impl *This = (IDirect3DSurface8Impl *)iface;
115 HRESULT hr;
116 TRACE("(%p) Relay\n", This);
118 EnterCriticalSection(&d3d8_cs);
119 hr = IWineD3DSurface_GetPrivateData(This->wineD3DSurface, refguid, pData, pSizeOfData);
120 LeaveCriticalSection(&d3d8_cs);
121 return hr;
124 static HRESULT WINAPI IDirect3DSurface8Impl_FreePrivateData(LPDIRECT3DSURFACE8 iface, REFGUID refguid) {
125 IDirect3DSurface8Impl *This = (IDirect3DSurface8Impl *)iface;
126 HRESULT hr;
127 TRACE("(%p) Relay\n", This);
129 EnterCriticalSection(&d3d8_cs);
130 hr = IWineD3DSurface_FreePrivateData(This->wineD3DSurface, refguid);
131 LeaveCriticalSection(&d3d8_cs);
132 return hr;
135 /* IDirect3DSurface8 Interface follow: */
136 static HRESULT WINAPI IDirect3DSurface8Impl_GetContainer(LPDIRECT3DSURFACE8 iface, REFIID riid, void **ppContainer) {
137 IDirect3DSurface8Impl *This = (IDirect3DSurface8Impl *)iface;
138 HRESULT res;
140 TRACE("(%p) Relay\n", This);
142 if (!This->container) return E_NOINTERFACE;
144 res = IUnknown_QueryInterface(This->container, riid, ppContainer);
146 TRACE("(%p) : returning %p\n", This, *ppContainer);
147 return res;
150 static HRESULT WINAPI IDirect3DSurface8Impl_GetDesc(LPDIRECT3DSURFACE8 iface, D3DSURFACE_DESC *pDesc) {
151 IDirect3DSurface8Impl *This = (IDirect3DSurface8Impl *)iface;
152 WINED3DSURFACE_DESC wined3ddesc;
153 HRESULT hr;
154 TRACE("(%p) Relay\n", This);
156 /* As d3d8 and d3d9 structures differ, pass in ptrs to where data needs to go */
157 memset(&wined3ddesc, 0, sizeof(wined3ddesc));
158 wined3ddesc.Format = (WINED3DFORMAT *)&pDesc->Format;
159 wined3ddesc.Type = (WINED3DRESOURCETYPE *)&pDesc->Type;
160 wined3ddesc.Usage = &pDesc->Usage;
161 wined3ddesc.Pool = (WINED3DPOOL *) &pDesc->Pool;
162 wined3ddesc.Size = &pDesc->Size;
163 wined3ddesc.MultiSampleType = (WINED3DMULTISAMPLE_TYPE *) &pDesc->MultiSampleType;
164 wined3ddesc.Width = &pDesc->Width;
165 wined3ddesc.Height = &pDesc->Height;
167 EnterCriticalSection(&d3d8_cs);
168 hr = IWineD3DSurface_GetDesc(This->wineD3DSurface, &wined3ddesc);
169 LeaveCriticalSection(&d3d8_cs);
170 return hr;
173 static HRESULT WINAPI IDirect3DSurface8Impl_LockRect(LPDIRECT3DSURFACE8 iface, D3DLOCKED_RECT *pLockedRect, CONST RECT *pRect, DWORD Flags) {
174 IDirect3DSurface8Impl *This = (IDirect3DSurface8Impl *)iface;
175 HRESULT hr;
176 TRACE("(%p) Relay\n", This);
177 TRACE("(%p) calling IWineD3DSurface_LockRect %p %p %p %d\n", This, This->wineD3DSurface, pLockedRect, pRect, Flags);
179 EnterCriticalSection(&d3d8_cs);
180 if (pRect) {
181 D3DSURFACE_DESC desc;
182 IDirect3DSurface8_GetDesc(iface, &desc);
184 if ((pRect->left < 0)
185 || (pRect->top < 0)
186 || (pRect->left >= pRect->right)
187 || (pRect->top >= pRect->bottom)
188 || (pRect->right > desc.Width)
189 || (pRect->bottom > desc.Height)) {
190 WARN("Trying to lock an invalid rectangle, returning D3DERR_INVALIDCALL\n");
191 LeaveCriticalSection(&d3d8_cs);
192 return D3DERR_INVALIDCALL;
196 hr = IWineD3DSurface_LockRect(This->wineD3DSurface, (WINED3DLOCKED_RECT *) pLockedRect, pRect, Flags);
197 LeaveCriticalSection(&d3d8_cs);
198 return hr;
201 static HRESULT WINAPI IDirect3DSurface8Impl_UnlockRect(LPDIRECT3DSURFACE8 iface) {
202 IDirect3DSurface8Impl *This = (IDirect3DSurface8Impl *)iface;
203 HRESULT hr;
204 TRACE("(%p) Relay\n", This);
206 EnterCriticalSection(&d3d8_cs);
207 hr = IWineD3DSurface_UnlockRect(This->wineD3DSurface);
208 LeaveCriticalSection(&d3d8_cs);
209 return hr;
212 const IDirect3DSurface8Vtbl Direct3DSurface8_Vtbl =
214 /* IUnknown */
215 IDirect3DSurface8Impl_QueryInterface,
216 IDirect3DSurface8Impl_AddRef,
217 IDirect3DSurface8Impl_Release,
218 /* IDirect3DResource8 */
219 IDirect3DSurface8Impl_GetDevice,
220 IDirect3DSurface8Impl_SetPrivateData,
221 IDirect3DSurface8Impl_GetPrivateData,
222 IDirect3DSurface8Impl_FreePrivateData,
223 /* IDirect3DSurface8 */
224 IDirect3DSurface8Impl_GetContainer,
225 IDirect3DSurface8Impl_GetDesc,
226 IDirect3DSurface8Impl_LockRect,
227 IDirect3DSurface8Impl_UnlockRect