WebKitSite/coding/commit-review-policy.html

   1 <?php
   2     $title="Policy on Committers and Reviewers";
   3     include("../header.inc");
   4 ?>
   5 <h2>WebKit Committers and Reviewer Policy</h2>
   6
   7 <p>The WebKit project has two kinds of special status beyond being a
   8 contributor. WebKit Committers have direct read-write access to the
   9 Subversion repository, enabling them to commit changes by themselves
  10 or others once reviewed. WebKit Reviewers are permitted to review
  11 patches and may grant or deny approval for committing. Details of the
  12 review and commit process are available
  13 on the <a href="http://webkit.org/coding/contributing.html">contribution page</a>.</p>
  14
  15 <p>New WebKit Committers and WebKit Reviewers will be selected by the
  16 set of existing WebKit Reviewers. We will create a mailing list,
  17 &lt;<a href="mailto:webkit-reviewers@lists.webkit.org">webkit-reviewers@lists.webkit.org</a>&gt;,
  18 for this purpose.</p>
  19
  20 <p>An up to date list of current WebKit Committers and WebKit
  21 Reviewers will be maintained at webkit.org.</p>
  22
  23 <h3>Choosing Committers and Reviewers</h3>
  24
  25 <p>A candidate for WebKit Committer or WebKit Reviewer should
  26 initially be nominated by a reviewer on the reviewers mailing list, in
  27 accordance with the criteria below. If at least two more reviewers
  28 second the nomination, then it carries within 5 business days unless
  29 someone objects. If an objection is raised, the reviewers should
  30 discuss the matter and try to come to consensus; failing this, the
  31 matter will be decided by majority vote of the reviewers.</p>
  32
  33 <p>Once someone is successfully nominated for WebKit
  34 Committer status, Apple will take care of sending the committer
  35 agreement and setting up a Subversion account once signed and
  36 received.</p>
  37
  38 <p>Once someone is successfully nominated for WebKit Reviewer status,
  39 the nominating Reviewer or another responsible party should inform the
  40 candidate and ask for indication of acceptance from the potential new
  41 reviewer. If the candidate accepts, a notice will be posted on the
  42 WebKit blog.</p>
  43
  44 <h3>Criteria for Committers</h3>
  45
  46 <p>A WebKit Committer should be a person we can trust to follow and
  47 understand the project policies about checkins and other matters.</p>
  48
  49 <p>Normally a potential Committer would be nominated once they have
  50 submitted around 10-20 good patches, shown good judgment and
  51 understanding of project policies, and demonstrated good collaboration
  52 skills. To be nominated and seconded, they will have to interact
  53 with more than one project reviewer. If someone submits many patches
  54 but does not show good judgment or effective collaboration, that
  55 contributor might not be nominated right away. If someone submits fewer patches than
  56 this but has experience working in another WebKit-based or
  57 khtml-based engine and has a track record of good collaboration with
  58 the WebKit project, they may be nominated sooner.</p>
  59
  60 <p>Significant contributors to testing, bug management, web site
  61 content, documentation, project infrastructure and other non-code
  62 areas may also be nominated, even without the normal threshold of
  63 patches.</p>
  64
  65 <p>A person who will be working under the supervision of a WebKit
  66 reviewer on WebKit-related projects can be nominated if the reviewer
  67 is willing to vouch for them and supervise them to ensure they follow
  68 project policies on checkins. Supervision does not necessarily imply a
  69 manager/employee relationship, just that you work with the potential
  70 committer closely enough to make sure they follow policy and work well
  71 with others.</p>
  72
  73 <h3>Criteria for Reviewers</h3>
  74
  75 <p>A WebKit Reviewer should be a person who has shown particularly
  76 good judgment, understanding of project policies, collaboration
  77 skills, and understanding of the code. Reviewers are expected to
  78 ensure that patches they review follow project policies, and to do
  79 their best to check for bugs or other problems with the patch. They
  80 are also expected to show good judgment in whether or not they review
  81 a patch at all, or defer to another reviewer.</p>
  82
  83 <p>Typically a potential Reviewer would be nominated once they have
  84 submitted around 80-120 good patches. They should also be in touch
  85 with other reviewers and aware of who are the experts in various
  86 areas. If someone submits fewer patches than this, but has experience
  87 working in another WebKit-based or khtml-based engine and has a track
  88 record of excellent collaboration with the WebKit project, they may be
  89 nominated sooner.</p>
  90
  91 <p>A person who submits many patches but does not show good
  92 collaboration skills, code understanding or understanding of project
  93 policies may never be nominated.</p>
  94
  95 <p>For Reviewer status, there is no supervision exception.</p>
  96
  97 <h3>Suspension and Revocation of Committer or Reviewer Status</h3>
  98
  99 <p>WebKit Committer or WebKit Reviewer status can be revoked by 2/3
 100 vote of the reviewers, not including the person under consideration
 101 for revocation.</p>
 102
 103 <p>Someone actively damaging the repository or intentionally abusing
 104 their review privilege may have it temporarily suspended on the
 105 request of any two Reviewers. In such a case, the requesting Reviewers
 106 should notify the webkit-reviewers list with a description of the
 107 offense. At this point, Reviewer or Committer status will be
 108 temporarily suspended for one week, pending outcome of the vote for
 109 permanent revocation.</p>
 110 <?php
 111     include("../footer.inc");
 112 ?>