1 2022-03-22 Per Arne Vollan <pvollan@apple.com>
3 REGRESSION(r291587): Unintentionally removed contributors change
4 https://bugs.webkit.org/show_bug.cgi?id=238204
6 Unreviewed, partial revert of r291587.
8 * metadata/contributors.json:
10 2022-03-22 Carlos Garcia Campos <cgarcia@igalia.com>
12 [GTK][WPE] Remove the ATK implementation
13 https://bugs.webkit.org/show_bug.cgi?id=238198
15 Reviewed by Adrian Perez de Castro.
17 * Source/cmake/OptionsGTK.cmake:
18 * Source/cmake/OptionsWPE.cmake:
20 2022-03-21 Commit Queue <commit-queue@webkit.org>
22 Unreviewed, reverting r291055.
23 https://bugs.webkit.org/show_bug.cgi?id=238145
25 Invalid test expectations
29 "[iOS] Hard link AVPictureInPictureController"
30 https://bugs.webkit.org/show_bug.cgi?id=237227
31 https://commits.webkit.org/r291055
33 2022-03-18 Philippe Normand <pnormand@igalia.com>
35 [GStreamer] Migrate gst-full support to 1.20
36 https://bugs.webkit.org/show_bug.cgi?id=237772
38 Reviewed by Xabier Rodriguez-Calvar.
40 * Source/cmake/GStreamerChecks.cmake:
42 2022-03-18 Philippe Normand <pnormand@igalia.com>
44 [GStreamer] Initial import of the GstWebRTC backend
45 https://bugs.webkit.org/show_bug.cgi?id=236540
47 Reviewed by Carlos Garcia Campos and Xabier Rodriguez-Calvar.
49 Enable GstWebRTC by default if a recent-enough (>= 1.20) version is available.
51 * Source/cmake/FindGStreamer.cmake:
52 * Source/cmake/GStreamerChecks.cmake:
53 * Source/cmake/GStreamerDefinitions.cmake:
54 * Source/cmake/GStreamerDependencies.cmake:
56 2022-03-18 Carlos Garcia Campos <cgarcia@igalia.com>
58 Add a public build option for PDF.js
59 https://bugs.webkit.org/show_bug.cgi?id=238023
61 Reviewed by Michael Catanzaro.
63 PDF.js increases the binary size of the library quite a bit, so embedders might want to disable it if they know
64 they don't need PDF support at all.
66 * Source/cmake/OptionsGTK.cmake:
67 * Source/cmake/OptionsWPE.cmake:
68 * Source/cmake/WebKitFeatures.cmake:
70 2022-03-17 Zan Dobersek <zdobersek@igalia.com>
72 [GTK][WPE] Also enable USE_TEXTURE_MAPPER_DMABUF alongside other DMABuf-related defines
73 https://bugs.webkit.org/show_bug.cgi?id=238017
75 Reviewed by Alejandro G. Castro.
77 For the GTK port, define USE_TEXTURE_MAPPER_DMABUF alongside the
78 dependencies and defines for DMABuf-backed ANGLE integration. This will
79 enable usage of the DMABuf-based video sink in any GStreamer pipeline
80 and subsequently display of the provided DMABuf objects. A comment is
81 added to explain this should be covered by a separate configuration
82 option on which USE_ANGLE_WEBGL should then depend.
84 For the WPE port the define is also added but without conditions, just
85 like it's done for the dependencies and the USE_LIBGBM define.
87 * Source/cmake/OptionsGTK.cmake:
88 * Source/cmake/OptionsWPE.cmake:
90 2022-03-17 Zan Dobersek <zdobersek@igalia.com>
92 [GTK][WPE] Guard libgbm and libdrm code, make them conditional dependencies for GTK
93 https://bugs.webkit.org/show_bug.cgi?id=237974
95 Reviewed by Alejandro G. Castro.
97 Guard usage of libgbm and libdrm dependencies with the USE_LIBGBM
98 define. This should be required until we can switch to a possibly more
99 dynamic implementation that doesn't require build-time dependencies.
101 For the GTK port, the desire is to keep these dependencies fully
102 optional. At the moment they are required when enabling ANGLE-backed
103 WebGL, with the USE_LIBGBM also defined in that case. This is needed
104 because ANGLE integration for Linux ports already depends on these
107 For the WPE port only USE_LIBGBM is defined and the two dependencies
110 * Source/cmake/OptionsGTK.cmake:
111 * Source/cmake/OptionsWPE.cmake:
113 2022-03-14 Gabriel Nava Marino <gnavamarino@apple.com>
115 Add myself (Gabriel Nava Marino) to contributors.json
116 https://bugs.webkit.org/show_bug.cgi?id=237634
120 * metadata/contributors.json:
122 2022-03-11 Elliott Williams <emw@apple.com>
124 Makefile.shared: Rename WORKSPACE to WORKSPACE_PATH and allow overrides
125 https://bugs.webkit.org/show_bug.cgi?id=237746
127 Reviewed by Alexey Proskuryakov.
129 This permits Make-based workflows which build out of a different workspace, e.g. a workspace
130 that includes WebKitAdditions.
132 WORKSPACE_PATH was chosen as a new name for parity with SCRIPTS_PATH and to avoid confusion
135 Refactors Makefile.shared a bit to prevent SCHEME or WORKSPACE_PATH being set without
136 USE_WORKSPACE from breaking the build.
140 2022-03-08 Jonathan Bedard <jbedard@apple.com>
142 [git-webkit] Support multiple metadata locations
143 https://bugs.webkit.org/show_bug.cgi?id=237395
144 <rdar://problem/89715863>
146 Reviewed by Dewei Zhu.
148 * metadata/git_config_extension: Renamed from metadata/project_config.
149 * metadata/project_config: Renamed to metadata/git_config_extension.
151 2022-03-10 Elliott Williams <emw@apple.com>
153 [XCBuild] Fix GeneratedSources dependency validation errors
154 https://bugs.webkit.org/show_bug.cgi?id=237490
156 Reviewed by Alexey Proskuryakov.
158 Fixes miscellanous targets which were not specifying their task outputs correctly.
160 For easier dependency validation testing, Make builds now recognize a VALIDATE_DEPENDENCIES
161 setting. Building with VALIDATE_DEPENDENCIES=YES or VALIDATE_DEPENDENCIES=YES_ERROR passes
162 the setting to xcodebuild and sets a magic xattr on the build directory so that product
163 files in it are validated.
167 2022-03-07 Basuke Suzuki <basuke.suzuki@sony.com>
169 Update Basuke Suzuki's status to reviewer
170 https://bugs.webkit.org/show_bug.cgi?id=237545
174 * metadata/contributors.json:
176 2022-03-07 Jonathan Bedard <jbedard@apple.com>
178 [webkitbugspy] Allow creation of new issues
179 https://bugs.webkit.org/show_bug.cgi?id=237123
180 <rdar://problem/89388181>
182 Reviewed by Dewei Zhu.
184 * metadata/trackers.json: Define project.
186 2022-03-03 Dan Glastonbury <djg@apple.com>
188 Add Dan Glastonbury's name to contributors.json
189 https://bugs.webkit.org/show_bug.cgi?id=237453
191 Reviewed by Alan Bujtas.
193 * metadata/contributors.json:
195 2022-03-03 Anjali Kumar <anjalik_22@apple.com>
197 Add myself (Anjali Kumar) to contributors.json
198 https://bugs.webkit.org/show_bug.cgi?id=237449
200 Reviewed by Patrick Angle.
202 * metadata/contributors.json: Added myself.
204 2022-03-01 Jonathan Bedard <jbedard@apple.com>
206 [git-webkit] Sync personal fork by default
207 https://bugs.webkit.org/show_bug.cgi?id=237324
208 <rdar://problem/89618617>
210 Reviewed by Dewei Zhu.
212 * metadata/project_config: Add webkitscmpy.update-fork option.
214 2022-03-02 Adrian Perez de Castro <aperez@igalia.com>
216 [CMake] Build failure with libstdc++ (>= 6) when cross-compiling (fatal error: stdlib.h: No such file or directory)
217 https://bugs.webkit.org/show_bug.cgi?id=161697
218 <rdar://problem/89613152>
220 Reviewed by Carlos Garcia Campos.
222 * Source/cmake/WebKitCompilerFlags.cmake: Go through CMake instead of the plain "env"
223 program for the sake of portability.
225 2022-03-01 Adrian Perez de Castro <aperez@igalia.com>
227 [CMake] Build failure with libstdc++ (>= 6) when cross-compiling (fatal error: stdlib.h: No such file or directory)
228 https://bugs.webkit.org/show_bug.cgi?id=161697
230 Reviewed by Carlos Garcia Campos.
232 * Source/cmake/WebKitCompilerFlags.cmake: Set LANG=C in compiler invocation to ensure its
233 output is consistent and the checks are independent from the system locale configuration.
235 2022-03-01 Basuke Suzuki <basuke.suzuki@sony.com>
237 [CMake] Disabling ENABLE_WEBCORE is ignored when cmake configuration runs again.
238 https://bugs.webkit.org/show_bug.cgi?id=237170
240 Reviewed by Fujii Hironori.
242 CMake variables which has chance to set from outside should be cached in CMake configuration cache.
243 Unless cacheing, the result of building the generated project is not consisitent because the other
244 configuration may run while building.
246 To make it complete, I've changed ENABLE_JAVASCRIPTCORE, ENABLE_WEBCORE and ENABLE_WEBKIT to `option()`
247 which is stored in cached and reused while building even if the confuguration runs again.
249 * Source/cmake/OptionsPlayStation.cmake:
250 * Source/cmake/WebKitCommon.cmake:
252 2022-02-28 Brandon Stewart <brandonstewart@apple.com>
254 Add Brandon Stewart's name to contributors.json
255 https://bugs.webkit.org/show_bug.cgi?id=237288
257 Reviewed by Saam Barati.
259 Add Brandon Stewart's name to contributors.json
261 * metadata/contributors.json:
263 2022-02-28 Michael Catanzaro <mcatanzaro@gnome.org>
265 -Wodr warning spam caused by ENABLE(BINDING_INTEGRITY)
266 https://bugs.webkit.org/show_bug.cgi?id=229867
267 <rdar://problem/82975115>
269 Reviewed by Carlos Garcia Campos.
271 Build WebKit with -Wno-odr. This warning is not salvagable, and it's impossible to suppress
274 * Source/cmake/WebKitCompilerFlags.cmake:
276 2022-02-24 Matt Woodrow <mattwoodrow@apple.com>
278 Unreviewed, update my (Matt Woodrow) status to committer.
280 * metadata/contributors.json:
282 2022-02-25 Zan Dobersek <zdobersek@igalia.com>
284 [GTK][WPE] Uncouple libgbm, libdrm dependencies from ANGLE functionality
285 https://bugs.webkit.org/show_bug.cgi?id=237199
287 Reviewed by Chris Lord.
289 For both GTK and WPE, unconditionally search for the libgbm and libdrm
290 dependencies as they will also be needed outside of ANGLE functionality.
291 USE_ANGLE is defined along with USE_NICOSIA, but still only if the
292 relevant option was enabled.
294 * Source/cmake/OptionsGTK.cmake:
295 * Source/cmake/OptionsWPE.cmake:
297 2022-02-25 Carlos Garcia Campos <cgarcia@igalia.com>
299 Unreviewed. [GTK] Bump version numbers
301 * Source/cmake/OptionsGTK.cmake:
303 2022-02-24 Ryosuke Niwa <rniwa@webkit.org>
305 Explain visit children and opaque roots in Introduction.md
306 https://bugs.webkit.org/show_bug.cgi?id=236894
308 Reviewed by Saam Barati.
310 Added the descriptions of visit children and opaque roots
311 as well as how to add IDL files.
315 2022-02-23 Elliott Williams <emw@apple.com>
317 [XCBuild] Don't automatically use the ../Internal/WebKit workspace
318 https://bugs.webkit.org/show_bug.cgi?id=237115
320 Reviewed by Alexey Proskuryakov.
322 When the USE_WORKSPACE=YES Make flag was added in https://commits.webkit.org/246232@main, we
323 configured Make to automatically use the workspace at ../Internal/WebKit/WebKit.xcworkspace,
324 if it was available. The idea was to make it easier for workspace builds to automatically
325 detect dependencies needed by folks at Apple, like WebKitAdditions.
327 In practice, this has made workspace builds silently rely on code from outside of the WebKit
328 repo, and it's unintuitive since non-workspace Make builds do not do this.
332 2022-02-23 W.D. Xiong <wdx@apple.com>
334 Add wdx's Github username to contributors.json
335 https://bugs.webkit.org/show_bug.cgi?id=237106
339 * metadata/contributors.json:
341 2022-02-23 Zan Dobersek <zdobersek@igalia.com>
343 [GStreamer] Add WebKitDMABufVideoSink
344 https://bugs.webkit.org/show_bug.cgi?id=236883
346 Reviewed by Philippe Normand.
348 * Source/cmake/FindGStreamer.cmake:
349 Also search for gstreamer-allocators-1.0, produce the relevant variables
350 containing include directories and cflags.
352 2022-02-22 Philippe Normand <pnormand@igalia.com>
354 [GStreamer] Initial MediaRecorder implementation
355 https://bugs.webkit.org/show_bug.cgi?id=236558
357 Reviewed by Xabier Rodriguez-Calvar.
359 Enable MediaRecorder support if GStreamer >= 1.20 is available.
361 * Source/cmake/FindGStreamer.cmake:
362 * Source/cmake/GStreamerChecks.cmake:
363 * Source/cmake/GStreamerDefinitions.cmake:
364 * Source/cmake/GStreamerDependencies.cmake:
366 2022-02-21 Carlos Garcia Campos <cgarcia@igalia.com>
368 [GTK][WPE] ANGLE: make USE_ANGLE_WEBGL build option public
369 https://bugs.webkit.org/show_bug.cgi?id=236962
371 Reviewed by Chris Lord.
373 Since it introduces new dependencies, the build option should be public and a fatal error message should be
374 shown when the option is enabled and any for the dependencies is missing.
376 * Source/cmake/OptionsGTK.cmake:
377 * Source/cmake/OptionsWPE.cmake:
379 2022-02-20 Brandon Stewart <brandonstewart@apple.com>
381 Generate compile_commands.json on macOS Builds
382 https://bugs.webkit.org/show_bug.cgi?id=235686
384 Reviewed by Saam Barati.
386 Add support for generating compile_commands.json file to WebKit.
388 compile_commands.json can be used by tools like clangd to provide code complete,
389 refactoring, formatting, and cross references.
391 Steps to generate the compile commands file:
392 make d EXPORT_COMPILE_COMMANDS=YES
393 generate-compile-commands WebKitBuild/Debug
397 2022-02-19 Philippe Normand <pnormand@igalia.com>
399 [WPE][GTK] Enable Thunder and remove old Clearkey CDM/Decryptor
400 https://bugs.webkit.org/show_bug.cgi?id=235492
402 Reviewed by Xabier Rodriguez-Calvar.
404 Enable Thunder in developer builds, this is now needed for the clearkey EME layout tests.
406 * Source/cmake/OptionsGTK.cmake:
407 * Source/cmake/OptionsWPE.cmake:
409 2022-02-18 Robert Jenner <Jenner@apple.com>
411 Unreviewed, reverting r290149.
417 "Generate compile_commands.json on macOS Builds"
418 https://bugs.webkit.org/show_bug.cgi?id=235686
419 https://commits.webkit.org/r290149
421 2022-02-18 Ryosuke Niwa <rniwa@webkit.org>
423 Replace trac URLs in Introduction.md by equivalent GitHub URLs
424 https://bugs.webkit.org/show_bug.cgi?id=236826
426 Reviewed by Sihui Liu.
428 Replaced track links by equivalent Github links in Introduction.md.
430 Also replaced an example of a reference test since the previously referenced test
431 had been converted to a manual test, and updated documentations around preferences
432 as they had been refactored since this was originally written.
436 2022-02-18 Brandon Stewart <brandonstewart@apple.com>
438 Generate compile_commands.json on macOS Builds
439 https://bugs.webkit.org/show_bug.cgi?id=235686
441 Reviewed by Saam Barati.
443 Add support for generating compile_commands.json file to WebKit.
445 compile_commands.json can be used by tools like clangd to provide code complete,
446 refactoring, formatting, and cross references.
448 Steps to generate the compile commands file:
449 make r EXPORT_COMPILE_COMMANDS=YES
450 generate-compile-commands WebKitBuild/Release
454 2022-02-18 Adrian Perez de Castro <aperez@igalia.com>
456 [CMake] Cannot find OpenGL when system provides opengl.pc instead of gl.pc
457 https://bugs.webkit.org/show_bug.cgi?id=236592
459 Reviewed by Michael Catanzaro.
461 * Source/cmake/FindOpenGL.cmake: Rewrite to use imported targets, try the "opengl" and "glx"
462 pkg-config modules first, otherwise keep the existing logic that tried the "gl" pkg-config
463 module with fallbacks to find_path/find_library.
464 * Source/cmake/OptionsGTK.cmake: Check for the presence of the OpenGL::GLX target instead of
465 te GLX_FOUND variable.
467 2022-02-17 Commit Queue <commit-queue@webkit.org>
469 Unreviewed, reverting r289949.
470 https://bugs.webkit.org/show_bug.cgi?id=236757
472 Breaks WPE builds with -DUSE_ANGLE_WEBGL=ON
476 "[CMake] Cannot find OpenGL when system provides opengl.pc
478 https://bugs.webkit.org/show_bug.cgi?id=236592
479 https://commits.webkit.org/r289949
481 2022-02-16 Don Olmstead <don.olmstead@sony.com>
483 [CMake][PlayStation] Add find module for WPE Backend for PlayStation
484 https://bugs.webkit.org/show_bug.cgi?id=236721
486 Reviewed by Michael Catanzaro.
488 Add the find module to detect the presence of the WPE Backend for PlayStation platforms.
489 Currently its not required to have the WPE Backend so its presence is conditional. When
490 there USE(WPE_BACKEND_PLAYSTATION) will be true.
492 * Source/cmake/FindWPEBackendPlayStation.cmake: Added.
493 * Source/cmake/OptionsPlayStation.cmake:
495 2022-02-16 Adrian Perez de Castro <aperez@igalia.com>
497 [CMake] Cannot find OpenGL when system provides opengl.pc instead of gl.pc
498 https://bugs.webkit.org/show_bug.cgi?id=236592
500 Reviewed by Don Olmstead.
502 * Source/cmake/FindOpenGL.cmake: Rewrite to use imported targets, try the "opengl" and "glx"
503 pkg-config modules first, otherwise keep the existing logic that tried the "gl" pkg-config
504 module with fallbacks to find_path/find_library.
505 * Source/cmake/OptionsGTK.cmake: Check for the presence of the OpenGL::GLX target instead of
506 te GLX_FOUND variable.
508 2022-02-15 Adrian Perez de Castro <aperez@igalia.com>
510 [CMake] Checks uses of execute_process() for correct command splitting
511 https://bugs.webkit.org/show_bug.cgi?id=236366
513 Reviewed by Don Olmstead.
515 * Source/cmake/FindGObjectIntrospection.cmake: Remove macro _GIR_GET_PKGCONFIG_VAR, which used
516 execute_process(), in favor of pkg_get_variable(), which has been supported since CMake 3.4
518 2022-02-11 Don Olmstead <don.olmstead@sony.com>
520 [CMake] Check for MAP_ALIGNED support
521 https://bugs.webkit.org/show_bug.cgi?id=236522
523 Reviewed by Keith Miller.
525 Add a symbol check for MAP_ALIGNED in the CMake.
527 * Source/cmake/OptionsCommon.cmake:
529 2022-02-11 Adrian Perez de Castro <aperez@igalia.com>
531 [CMake] Use ld.lld by default for development builds where available
532 https://bugs.webkit.org/show_bug.cgi?id=235979
534 Reviewed by Michael Catanzaro.
536 * Source/cmake/OptionsCommon.cmake: Enable USE_LD_LLD by default for developers builds
537 when ld.lld is available. While at it, improve the match on LD_VERSION to be more robust.
539 2022-02-10 Filip Pizlo <fpizlo@apple.com>
541 Unreviewed, add an alternate email address.
543 * metadata/contributors.json:
545 2022-02-10 Elliott Williams <emw@apple.com>
547 [Xcode] Perform a full build when analyzing
548 https://bugs.webkit.org/show_bug.cgi?id=236421
550 Reviewed by Alexey Proskuryakov.
552 `xcodebuild analyze` does just enough work to run the analyzer on each target, and doesn't
553 appear to run build phases that only impact consumers of the target. In particular, it
554 doesn't copy framework headers.
556 Fix by telling xcodebuild to build _and_ analyze at once. AFAICT, this is exactly what
557 Xcode's Product > Analyze command does.
559 * Makefile.shared: s/analyze/build analyze
561 2022-02-10 Alejandro G. Castro <alex@igalia.com>
563 [GTK][WPE] Improve device detection in the GbmDevice
564 https://bugs.webkit.org/show_bug.cgi?id=236436
566 Reviewed by Chris Lord.
568 * Source/cmake/OptionsGTK.cmake: Search for drm and gbm libraries
569 when compiling WebGL ANGLE support.
570 * Source/cmake/OptionsWPE.cmake: Ditto.
572 2022-02-10 Tim Nguyen <ntim@apple.com>
574 Unreviewed, update my (Tim Nguyen) status to reviewer
576 * metadata/contributors.json:
578 2022-02-09 Ross Kirsling <ross.kirsling@sony.com>
580 SharedMemoryUnix should use SHM_ANON when available
581 https://bugs.webkit.org/show_bug.cgi?id=236416
583 Reviewed by Don Olmstead.
585 * Source/cmake/OptionsCommon.cmake: Check for SHM_ANON.
587 2022-02-09 Adrian Perez de Castro <aperez@igalia.com>
589 [CMake] REGRESSION(r288994): Setting multiple values in LDFLAGS causes incorrect linker detection
590 https://bugs.webkit.org/show_bug.cgi?id=236365
592 Reviewed by Martin Robinson.
594 * Source/cmake/OptionsCommon.cmake: Use separate_arguments() to turn plain command strings
595 into lists of strings, which can then be passed down to execute_process() as it knows how
596 to handle lists properly.
598 2022-02-09 Carlos Garcia Campos <cgarcia@igalia.com>
600 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.3 release
602 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
604 2022-02-08 Jonathan Bedard <jbedard@apple.com>
606 [git-webkit] Allow repositories to declare their bug trackers
607 https://bugs.webkit.org/show_bug.cgi?id=236306
608 <rdar://problem/88633018>
610 Reviewed by Dewei Zhu.
612 * metadata/trackers.json: Added.
614 2022-02-08 Adrian Perez de Castro <aperez@igalia.com>
616 [WPE] Running distcheck with USE_SOUP2=OFF fails to install documentation
617 https://bugs.webkit.org/show_bug.cgi?id=236235
619 Reviewed by Carlos Garcia Campos.
621 * Source/PlatformWPE.cmake: Use WPE_API_DOC_VERSION instead of WPE_API_VERSION for the documentation.
623 2022-02-07 Adrian Perez de Castro <aperez@igalia.com>
625 [CMake] REGRESSION(r288994): Linker does not get passed --disable-new-dtags
626 https://bugs.webkit.org/show_bug.cgi?id=236205
628 Reviewed by Darin Adler.
630 * Source/cmake/OptionsCommon.cmake: Arrange passing --disable-new-dtags to linkers that
631 are known to support the option. While at it, reorganize a bit how detected linker/archiver
632 features are printed out for better readability.
634 2022-02-03 Myles C. Maxfield <mmaxfield@apple.com>
636 Two bopomofo tone marks are not moved to the correct place in vertical text with a particular bopomofo font
637 https://bugs.webkit.org/show_bug.cgi?id=235257
638 <rdar://problem/87625596>
640 Reviewed by Darin Adler.
642 Thank you so much to Bobby Tung and But Ko for reporting this bug and providing a test font for it!!!
644 * metadata/contributors.json:
646 2022-02-03 Elliott Williams <emw@apple.com>
648 Add Elliott Williams to contributors.json
652 * metadata/contributors.json:
654 2022-01-24 Jonathan Bedard <jbedard@apple.com>
656 [git-webkit] Configure default branch management
657 https://bugs.webkit.org/show_bug.cgi?id=235378
658 <rdar://problem/87989533>
660 Reviewed by Dewei Zhu.
662 * metadata/project_config: Added.
664 2022-02-03 Carlos Garcia Campos <cgarcia@igalia.com>
666 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.2 release
668 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
670 2022-02-02 Carlos Garcia Campos <cgarcia@igalia.com>
672 Unreviewed. [GTK] Apply the same cmake changes of r289029 to GTK port
674 * Source/cmake/OptionsGTK.cmake:
676 2022-02-02 Pablo Saavedra <psaavedra@igalia.com>
678 [WPE] Fix for non-unified builds with ACCESSIBILITY=OFF
679 https://bugs.webkit.org/show_bug.cgi?id=236024
681 Reviewed by Darin Adler.
683 * Source/cmake/OptionsWPE.cmake:
685 2022-02-02 Adrian Perez de Castro <aperez@igalia.com>
687 [CMake] Stop defaulting to ld.gold
688 https://bugs.webkit.org/show_bug.cgi?id=235476
690 Reviewed by Michael Catanzaro.
692 Remove the USE_LD_GOLD option, and let the build use by default the system linker.
694 The output from running the linker with -Wl,--version is matched to determine which linker
695 is currently in use, and set variables LD_SUPPORTS_<feature> accordingly. This is needed
696 because not all of them support certain features and after a few attempts at doing feature
697 checks it was becoming clear that on one hand the checks were getting gnarly, and on the
698 other hand vetting certain linkers provides a stronger guarantee of sucessful builds.
700 Similarly, extend the check used to determine whether the static library archiver supports
701 thin archivers to cover the one included with LLVM (llvm-ar), and enable usage of think
702 archivers if they can be both created by the archiver and consumed by the linker. Previously
703 the build system was enabling thin archives without knowing whether the linker would succeed
706 * Source/cmake/OptionsCommon.cmake:
708 2022-02-01 Carlos Garcia Campos <cgarcia@igalia.com>
710 [GTK][WPE] Switch to use ATSPI instead of ATK
711 https://bugs.webkit.org/show_bug.cgi?id=235942
713 Reviewed by Adrian Perez de Castro.
715 Use ATSPI by default.
717 * Source/cmake/OptionsGTK.cmake:
718 * Source/cmake/OptionsWPE.cmake:
720 2022-02-01 Tim Nguyen <ntim@apple.com>
722 Entirely remove support for -apple-trailing-word
723 https://bugs.webkit.org/show_bug.cgi?id=234672
725 Reviewed by Simon Fraser.
727 * Source/cmake/OptionsMac.cmake:
728 * Source/cmake/WebKitFeatures.cmake:
730 2022-01-28 Elliott Williams <emw@apple.com>
732 [XCBuild] Small corrections to build-webkit and Makefile for workspace builds
733 https://bugs.webkit.org/show_bug.cgi?id=235747
735 Reviewed by Alexey Proskuryakov.
737 * Makefile: Set SCRIPTS_PATH correctly from the root of the repo
739 2022-01-28 Pablo Saavedra <psaavedra@igalia.com>
741 [WPE] Build error with ACCESSIBILITY=OFF after r288731
742 https://bugs.webkit.org/show_bug.cgi?id=235764
744 Reviewed by Adrian Perez de Castro.
746 * Source/cmake/OptionsWPE.cmake:
748 2022-01-27 Carlos Garcia Campos <cgarcia@igalia.com>
750 [WPE][a11y] Add option to build with ATSPI
751 https://bugs.webkit.org/show_bug.cgi?id=235701
753 Reviewed by Adrian Perez de Castro.
755 * Source/cmake/OptionsWPE.cmake:
757 2022-01-27 Adrian Perez de Castro <aperez@igalia.com>
759 [CMake] Do not require GNU Gold usage to enable DEBUG_FISSION
760 https://bugs.webkit.org/show_bug.cgi?id=235737
762 Reviewed by Michael Catanzaro.
764 * Source/cmake/OptionsCommon.cmake: Allow enabling DEBUG_FISSION with any linker.
766 2022-01-27 Yusuke Suzuki <ysuzuki@apple.com>
768 Add .clangd similar to .ccls
769 https://bugs.webkit.org/show_bug.cgi?id=235743
771 Reviewed by Saam Barati.
773 This patch adds .clangd local configuration, which is similar to .ccls.
777 2022-01-26 Adrian Perez de Castro <aperez@igalia.com>
779 [CMake] Pass -pipe to compilers that support it
780 https://bugs.webkit.org/show_bug.cgi?id=235641
782 Reviewed by Darin Adler.
784 * Source/cmake/WebKitCompilerFlags.cmake: Add -pipe to compiler options where supported.
786 2022-01-25 Myles C. Maxfield <mmaxfield@apple.com>
788 Add another test for locale-specific shaping
789 https://bugs.webkit.org/show_bug.cgi?id=235558
791 Reviewed by Darin Adler.
793 Thanks so much to Just van Rossum for contributing the test font!!!
795 * metadata/contributors.json:
797 2022-01-20 Elliott Williams <emw@apple.com>
799 [XCBuild] Build via the workspace with USE_WORKSPACE=YES
800 https://bugs.webkit.org/show_bug.cgi?id=235385
803 Reviewed by Alexey Proskuryakov.
805 Experimental XCBuild support is available by passing USE_WORKSPACE=YES to Make. This is
806 roughly equivalent to opening WebKit.xcworkspace and building a scheme in the IDE.
808 A workspace build is only one `xcodebuild` invocation, in contrast with the traditional
809 recursive-Make build that iterates through each project directory. As a result, workspace
810 builds are faster: the build system can schedule targets from different projects to build
811 simultaneously, and there's lower xcodebuild overhead.
813 Workspaces build _schemes_, which are a collection of targets. By default, Make looks for a
814 scheme whose name matches the source directory (Source/WebCore => build scheme "WebCore").
815 Makefiles can customize this by setting SCHEME.
817 At this time, there is no guarantee of correctness when building with USE_WORKSPACE=YES, and
818 workspace builds are not checked by builders.
820 * Makefile: Use workspace logic when USE_WORKSPACE=YES
821 * Makefile.shared: xcodebuild invocation logic for workspace builds
822 * Source/Makefile: Use workspace logic and set custom SCHEME name
823 * WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings: Use XCBuild for workspace
825 * WebKit.xcworkspace/xcshareddata/xcschemes/All Modules.xcscheme: Added, to correspond with
826 the top-level Makefile
827 * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Let XCBuild determine build
829 * WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Let XCBuild determine build
832 2022-01-20 Don Olmstead <don.olmstead@sony.com>
834 [WinCairo] Make USE_CF conditional on ENABLE_WEBKIT_LEGACY
835 https://bugs.webkit.org/show_bug.cgi?id=235393
837 Reviewed by Fujii Hironori.
839 CoreFoundation is used heavily in WebKitLegacy on Windows and won't compile without it.
840 Modern WebKit doesn't have this requirement so tie CoreFoundation usage to whether
841 WebKitLegacy is being used.
843 * Source/cmake/OptionsWinCairo.cmake:
845 2022-01-19 Michael Catanzaro <mcatanzaro@gnome.org>
847 [WPE][GTK] ENABLE_JOURNALD_LOG has weird value
848 https://bugs.webkit.org/show_bug.cgi?id=235339
850 Reviewed by Philippe Normand.
852 Clean up the code that checks for journald.
854 * Source/cmake/OptionsGTK.cmake:
855 * Source/cmake/OptionsWPE.cmake:
857 2022-01-18 Brandon Stewart <brandonstewart@apple.com>
859 Fix typos in Introduction.md
860 https://bugs.webkit.org/show_bug.cgi?id=235321
862 Reviewed by Michael Saboff.
864 Fix several typos in Introduction file.
868 2022-01-17 Brandon Stewart <brandonstewart@apple.com>
871 https://bugs.webkit.org/show_bug.cgi?id=235309
873 Reviewed by Michael Saboff.
875 Fix typo in ReadMe. Updated 'embededded' to 'embedded'.
879 2022-01-17 Carlos Garcia Campos <cgarcia@igalia.com>
881 [GTK][a11y] Stop using isolated tree for the ATSPI implementation
882 https://bugs.webkit.org/show_bug.cgi?id=235229
884 Reviewed by Adrian Perez de Castro.
886 Do not enable isolated tree for ATSPI.
888 * Source/cmake/OptionsGTK.cmake:
890 2022-01-14 Yusuke Suzuki <ysuzuki@apple.com> and Mikhail R. Gadelha <mikhail@igalia.com>
892 [JSC] Fix Linux 64bit compilation
893 https://bugs.webkit.org/show_bug.cgi?id=235232
895 Reviewed by Saam Barati.
897 * Source/cmake/OptionsCommon.cmake:
899 2022-01-13 Alejandro G. Castro <alex@igalia.com>
901 [GTK][WPE][WebGL2] compilation fixes
902 https://bugs.webkit.org/show_bug.cgi?id=225563
904 Reviewed by Chris Lord.
906 Fix the compilation and add the ANGLE dependency, the architecture
907 is still not the final one but it is handy to use WebGL2 demos for
910 * Source/cmake/OptionsGTK.cmake: Added dependency with ANGLE.
911 * Source/cmake/OptionsWPE.cmake: Added dependency with
912 ANGLE. Remove the default ENABLE_WEBGL2 because it is the same
913 default value in WebKitFeatures.cmake.
915 2022-01-12 Chris Lord <clord@igalia.com>
917 [WPE] Fix building WebXR with ANGLE enabled
918 https://bugs.webkit.org/show_bug.cgi?id=235108
920 Reviewed by Alejandro G. Castro.
922 Remove conflict between WebXR and ANGLE WebGL for WPE.
924 * Source/cmake/OptionsWPE.cmake:
926 2022-01-12 Chris Lord <clord@igalia.com>
928 [WPE] Enable WebGL ANGLE support
929 https://bugs.webkit.org/show_bug.cgi?id=235064
931 Reviewed by Alejandro G. Castro.
933 Add the USE_ANGLE_WEBGL option for WPE. This is currently incompatible
934 with WebXR as there isn't an ANGLE GL context code-path there.
936 * Source/cmake/OptionsWPE.cmake:
938 2022-01-11 Fujii Hironori <Hironori.Fujii@sony.com>
940 Remove Direct2D code (part 2)
941 https://bugs.webkit.org/show_bug.cgi?id=235097
943 Reviewed by Yusuke Suzuki.
945 * Source/cmake/OptionsAppleWin.cmake:
947 2022-01-10 Alex Christensen <achristensen@webkit.org>
950 https://bugs.webkit.org/show_bug.cgi?id=233963
952 Reviewed by Yusuke Suzuki.
954 * Source/cmake/OptionsCommon.cmake:
955 * Source/cmake/WebKitCompilerFlags.cmake:
957 2022-01-09 Sam Weinig <weinig@apple.com>
959 Remove support for Direct2D
960 https://bugs.webkit.org/show_bug.cgi?id=234999
962 Reviewed by Darin Adler.
964 * Source/cmake/OptionsFTW.cmake: Removed.
966 2022-01-07 Alex Christensen <achristensen@webkit.org>
968 Unreviewed, reverting r287698.
970 Broke an internal build
975 https://bugs.webkit.org/show_bug.cgi?id=233963
976 https://commits.webkit.org/r287698
978 2022-01-07 Alex Christensen <achristensen@webkit.org>
980 Unreviewed, reverting r287718.
982 Broke an internal build
986 "[PlayStation] Fix build break after r287698"
987 https://bugs.webkit.org/show_bug.cgi?id=234931
988 https://commits.webkit.org/r287718
990 2022-01-06 Stephan Szabo <stephan.szabo@sony.com>
992 [PlayStation] Fix build break after r287698
993 https://bugs.webkit.org/show_bug.cgi?id=234931
997 * Source/cmake/OptionsPlayStation.cmake: Workaround for not having u8string for gtest.
999 2022-01-06 Fujii Hironori <Hironori.Fujii@sony.com>
1001 [MSVC] Suppress new warnings C5054 and C5055 introduced by /permissive-
1002 https://bugs.webkit.org/show_bug.cgi?id=234929
1004 Reviewed by Ross Kirsling.
1006 After 245790@main enabled C++20 which implicitly enabled
1007 /permissive- switch, WinCairo builds emit a lot of new compilation
1010 * Source/cmake/OptionsMSVC.cmake: Suppress the warnings.
1012 2022-01-06 Alex Christensen <achristensen@webkit.org>
1015 https://bugs.webkit.org/show_bug.cgi?id=233963
1017 Reviewed by Yusuke Suzuki.
1019 * Source/cmake/OptionsCommon.cmake:
1020 * Source/cmake/WebKitCompilerFlags.cmake:
1022 2022-01-05 Jonathan Bedard <JonWBedard@gmail.com>
1024 [EWS] Add Commit Queue and EWS GitHub usernames
1025 https://bugs.webkit.org/show_bug.cgi?id=234905
1026 <rdar://problem/87169628>
1028 Reviewed by Ryan Haddad.
1030 * metadata/contributors.json:
1032 2022-01-04 Fujii Hironori <Hironori.Fujii@sony.com>
1034 clang-format: Change SpaceAfterTemplateKeyword to false
1035 https://bugs.webkit.org/show_bug.cgi?id=234655
1037 Reviewed by Don Olmstead.
1039 Bug 183302 added the initial .clang-format file which were
1040 including SpaceAfterTemplateKeyword:true. However, even though it
1041 is undocumented, typical WebKit code is using a style having no
1042 space ater the `template` keyword.
1046 2022-01-01 Jeff Miller <jeffm@apple.com>
1048 Update user-visible copyright strings to include 2022
1049 https://bugs.webkit.org/show_bug.cgi?id=234263
1051 Reviewed by Anders Carlsson.
1053 * Source/cmake/tools/scripts/COPYRIGHT-END-YEAR:
1055 2021-12-25 Sergey Rubanov <chi187@gmail.com>
1057 Add my github username to contributors.json
1058 https://bugs.webkit.org/show_bug.cgi?id=231666
1060 Reviewed by Alexey Proskuryakov.
1062 * metadata/contributors.json:
1064 2021-12-24 Simon Fraser <simon.fraser@apple.com>
1066 Add __pycache__ and DerivedData to the .gitignore file
1067 https://bugs.webkit.org/show_bug.cgi?id=234656
1069 Reviewed by Daniel Bates.
1073 2021-12-23 Fujii Hironori <Hironori.Fujii@sony.com>
1075 REGRESSION(r287412)[WinCairo] error C2338: You've instantiated std::aligned_storage<Len, Align> with an extended alignment (in other words, Align > alignof(max_align_t)).
1076 https://bugs.webkit.org/show_bug.cgi?id=234658
1078 Unreviewed build fix.
1080 After r287412, WinCairo Debug can't compile due to the following error.
1082 > C:\MSVS\VC\Tools\MSVC\14.28.29910\include\type_traits(1066):
1083 > error C2338: You've instantiated std::aligned_storage<Len, Align> with an extended alignment (in other words, Align > alignof(max_align_t)).
1084 > Before VS 2017 15.8, the member "type" would non-conformingly have an alignment of only alignof(max_align_t).
1085 > VS 2017 15.8 was fixed to handle this correctly, but the fix inherently changes layout and breaks binary compatibility
1086 > (*only* for uses of aligned_storage with extended alignments).
1087 > Please define either (1) _ENABLE_EXTENDED_ALIGNED_STORAGE to acknowledge that you understand this message and that you actually want a type with an extended alignment,
1088 > or (2) _DISABLE_EXTENDED_ALIGNED_STORAGE to silence this message and get the old non-conforming behavior.
1090 * Source/cmake/OptionsMSVC.cmake: Added _ENABLE_EXTENDED_ALIGNED_STORAGE macro.
1092 2021-12-23 ChangSeok Oh <changseok@webkit.org>
1094 Add changseok's github username.
1098 * metadata/contributors.json:
1100 2021-12-15 Chris Lord <clord@igalia.com>
1102 [GTK] Use libgbm and the ANGLE gbm backend to fix initialisation
1103 https://bugs.webkit.org/show_bug.cgi?id=234293
1105 Reviewed by Don Olmstead.
1107 Add cmake files to find gbm and libdrm.
1109 * Source/cmake/FindGBM.cmake: Added.
1110 * Source/cmake/FindLibDRM.cmake: Added.
1112 2021-12-11 Aakash Jain <aakash_jain@apple.com>
1114 Update my github username.
1118 * metadata/contributors.json:
1120 2021-12-10 Mikhail R. Gadelha <mikhail@igalia.com>
1122 Mark myself (Mikhail R. Gadelha) as committer
1123 https://bugs.webkit.org/show_bug.cgi?id=234157
1127 * metadata/contributors.json:
1129 2021-12-10 Chris Lord <clord@igalia.com>
1131 Change contributor status of Chris Lord from committer to reviewer
1132 https://bugs.webkit.org/show_bug.cgi?id=234136
1136 * metadata/contributors.json:
1138 2021-12-09 Lauro Moura <lmoura@igalia.com>
1140 Adds Lauro Moura's GitHub username to constributors.json
1144 * metadata/contributors.json:
1146 2021-11-30 Tyler Wilcock <tyler_w@apple.com>
1148 Move tyler_w@apple.com to first entry in "emails" key
1152 In order to cq+, your committer e-mail address must be the
1153 first entry in the "emails" key.
1155 * metadata/contributors.json:
1157 2021-11-29 Tyler Wilcock <tyler_w@apple.com>
1159 Mark myself (Tyler Wilcock) as committer
1163 * metadata/contributors.json:
1165 2021-11-29 Angelos Oikonomopoulos <angelos@igalia.com>
1167 Fix ATOMICS_REQUIRE_LIBATOMIC testcase on 32-bits
1168 https://bugs.webkit.org/show_bug.cgi?id=233551
1170 Unreviewed build fix.
1172 There's a syntax error when compiling the test program
1173 on 32-bits. This was not an issue on ARM as atomics are
1174 built in on that platform, but broke the MIPS build.
1176 * Source/cmake/WebKitCompilerFlags.cmake:
1178 2021-11-29 Nikolas Zimmermann <nzimmermann@igalia.com>
1180 [LBSE] Add runtime flag for Layer-based SVG engine (LBSE)
1181 https://bugs.webkit.org/show_bug.cgi?id=233211
1182 <rdar://problem/85711597>
1184 Reviewed by Sam Weinig.
1186 Add build option ('build-webkit --(no-)layer-based-svg-engine') and
1187 runtime flag ('LayerBasedSVGEngineEnabled' in LBSE enabled builds) to
1188 switch between the SVG engines.
1190 The actual SVG code changes will follow in subsequent patches,
1191 this just adds the infrastructure for LBSE.
1193 * Source/cmake/OptionsFTW.cmake:
1194 * Source/cmake/OptionsGTK.cmake:
1195 * Source/cmake/OptionsMac.cmake:
1196 * Source/cmake/OptionsPlayStation.cmake:
1197 * Source/cmake/OptionsWPE.cmake:
1198 * Source/cmake/OptionsWin.cmake:
1199 * Source/cmake/WebKitFeatures.cmake:
1201 2021-11-28 Matt Woodrow <matt.woodrow@gmail.com>
1203 Add mattwoodrow to contributors.json
1204 https://bugs.webkit.org/show_bug.cgi?id=233301
1206 Reviewed by Cameron McCormack.
1208 * metadata/contributors.json:
1210 2021-11-28 Myles C. Maxfield <mmaxfield@apple.com>
1212 [WebGPU] Add WebGPU to the "All Source" scheme in WebKit.xcworkspace
1213 https://bugs.webkit.org/show_bug.cgi?id=233542
1215 Reviewed by Dean Jackson.
1217 This scheme should build WebGPU.
1219 * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
1221 2021-11-27 Yusuke Suzuki <ysuzuki@apple.com>
1223 Unreviewed, update atomics detection to make libpas built on Linux
1225 * Source/cmake/WebKitCompilerFlags.cmake:
1227 2021-11-26 Adrian Perez de Castro <aperez@igalia.com>
1229 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.35.1 release
1231 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
1233 2021-11-25 Carlos Garcia Campos <cgarcia@igalia.com>
1235 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.1 release
1237 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
1239 2021-11-23 Adrian Perez de Castro <aperez@igalia.com>
1241 [WPE][GTK] Allow enabling JPEG-XL support at build time
1242 https://bugs.webkit.org/show_bug.cgi?id=233325
1244 Reviewed by Michael Catanzaro.
1246 Adds a new USE_JPEGXL build option, disabled by default for release builds and
1247 enabled for developer builds.
1249 * Source/cmake/OptionsGTK.cmake: Add USE_JPEGXL build option.
1250 * Source/cmake/OptionsWPE.cmake: Ditto.
1252 2021-11-22 Alejandro G. Castro <alex@igalia.com>
1254 Add alexg's GitHub username to contributors.json
1255 https://bugs.webkit.org/show_bug.cgi?id=233425
1259 * metadata/contributors.json:
1261 2021-11-19 Angelos Oikonomopoulos <angelos@igalia.com>
1263 [JSC] Workaround for failing mips tests
1264 https://bugs.webkit.org/show_bug.cgi?id=233359
1266 Reviewed by Adrian Perez de Castro.
1268 Add a compiler flag on GCC+mips to work around a code generation bug
1269 resulting in SIGBUS. This only manifests when running 32-bit mips code
1270 on mips64 hardware (which the buildbots do).
1272 * Source/cmake/WebKitCompilerFlags.cmake:
1274 2021-11-18 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com>
1276 Implement JPEG XL image decoder using libjxl
1277 https://bugs.webkit.org/show_bug.cgi?id=233113
1279 Reviewed by Michael Catanzaro.
1281 This patch introduces the initial version of JPEG XL image decoder.
1282 JPEG XL is a royalty-free raster-graphics file format that supports
1283 both lossy and lossless compression and is experimentally supported by
1284 Chrome, FireFox, and Edge.
1285 The image decoder implemented by this patch uses libjxl, a reference
1286 implementation of JPEG XL decoder (and encoder). JPEG XL animations
1287 will be supported later.
1289 * Source/cmake/FindJPEGXL.cmake: Added.
1290 * Source/cmake/OptionsWinCairo.cmake: Enable JPEG XL support if
1291 libjxl is available.
1293 2021-11-17 Patrick Angle <pangle@apple.com>
1295 Update my (Patrick Angle's) status to reviewer
1296 https://bugs.webkit.org/show_bug.cgi?id=233270
1300 Update my status to reviewer, as well as drive-by updates to set my github name and update the area of
1303 * metadata/contributors.json:
1305 2021-11-17 Chris Lord <clord@igalia.com>
1307 Add Chris Lord's GitHub username to contributors.json
1308 https://bugs.webkit.org/show_bug.cgi?id=233254
1312 * metadata/contributors.json:
1314 2021-11-16 Alex Atwater <alexandera_22@apple.com>
1316 Add my GitHub username to contributors.json
1318 Reviewed by Jonathan Bedard
1320 * metadata/contributors.json:
1322 2021-11-15 Nikolas Zimmermann <nzimmermann@igalia.com>
1324 Add my GitHub username to contributors.json
1325 https://bugs.webkit.org/show_bug.cgi?id=233122
1329 * metadata/contributors.json:
1331 2021-11-13 Myles C. Maxfield <mmaxfield@apple.com>
1333 [WebGPU] Add WebGPU.xcodeproj to WebKit.xcworkspace
1334 https://bugs.webkit.org/show_bug.cgi?id=233078
1336 Reviewed by Dean Jackson.
1338 Mechanical change. When building WebGPU becomes required,
1339 people using this workspace will need it.
1341 * WebKit.xcworkspace/contents.xcworkspacedata:
1343 2021-11-12 Don Olmstead <don.olmstead@sony.com>
1345 [WinCairo] Add Little-CMS support
1346 https://bugs.webkit.org/show_bug.cgi?id=233024
1348 Reviewed by Michael Catanzaro.
1350 Search for LCMS2 and if its present turn it on for WinCairo.
1352 * Source/cmake/OptionsWinCairo.cmake:
1354 2021-11-11 Michael Catanzaro <mcatanzaro@gnome.org>
1356 -Warray-bounds, -Wstringop-truncation, -Wstringop-overread warnings in Packed.h
1357 https://bugs.webkit.org/show_bug.cgi?id=226557
1358 <rdar://problem/79103658>
1360 Reviewed by Darin Adler.
1362 Suppress -Wstringop-overread for all of WebKit when building with GCC 11 or newer. This is
1363 an unfortunate way to deal with false positives that we ought to be able to silence in just
1364 a few places, but when warnings do not respect pragmas we have few alternatives, and trying
1365 to remove derived sources from the unified build in order to build them with special flags
1366 is just not worth the effort.
1368 This is part of a larger trend of oversensitive warnings from GCC 11.
1370 * Source/cmake/WebKitCompilerFlags.cmake:
1372 2021-11-10 Kimmo Kinnunen <kkinnunen@apple.com>
1374 Coding style for inner namespaces is should be simplified to not indented
1375 https://bugs.webkit.org/show_bug.cgi?id=232073
1377 Reviewed by Antti Koivisto.
1380 Do not indent contents of inner namespaces, match current code.
1382 2021-11-09 J Pascoe <j_pascoe@apple.com>
1384 Add j_pascoe to contributors.json
1385 https://bugs.webkit.org/show_bug.cgi?id=232904
1386 <rdar://problem/85222703>
1390 * metadata/contributors.json:
1392 2021-11-08 Myles C. Maxfield <mmaxfield@apple.com>
1394 Make WebGPU.xcodeproj and WebGPU.framework
1395 https://bugs.webkit.org/show_bug.cgi?id=231661
1397 Reviewed by Dean Jackson and Robin Morisset.
1401 2021-11-08 Peng Liu <peng.liu6@apple.com>
1403 Update Peng Liu's contributor status to reviewer
1404 https://bugs.webkit.org/show_bug.cgi?id=232859
1408 * metadata/contributors.json:
1410 2021-11-08 Cameron McCormack <heycam@apple.com>
1412 Update my status to reviewer
1413 https://bugs.webkit.org/show_bug.cgi?id=232854
1417 * metadata/contributors.json:
1419 2021-11-04 Roy Reapor <rreapor@apple.com>
1421 Update rreapor's status in contributors.json.
1422 https://bugs.webkit.org/show_bug.cgi?id=232685
1424 Reviewed by Aakash Jain.
1426 * metadata/contributors.json:
1428 2021-11-04 Diego Pino Garcia <dpino@igalia.com>
1430 Disable MEDIA_SESSION_PLAYLIST in WebKitGTK and WPE
1431 https://bugs.webkit.org/show_bug.cgi?id=232694
1433 Reviewed by Žan Doberšek.
1435 Since the feature depends on MEDIA_SESSION_COORDINATOR, whichs is
1436 disabled, this feature should also be disabled and not experimental.
1438 * Source/cmake/OptionsGTK.cmake:
1439 * Source/cmake/OptionsWPE.cmake:
1441 2021-11-03 Pablo Saavedra <psaavedra@igalia.com>
1443 [cmake] Check "cortex" string in the CMAKE_SYSTEM_PROCESSOR for defining WTF_CPU_* vars
1444 https://bugs.webkit.org/show_bug.cgi?id=232623
1446 Reviewed by Carlos Alberto Lopez Perez.
1448 * Source/cmake/WebKitCommon.cmake:
1450 2021-11-01 Don Olmstead <don.olmstead@sony.com>
1452 [Curl] Explicitly disable libcurl's internal cookie support
1453 https://bugs.webkit.org/show_bug.cgi?id=232586
1455 Reviewed by Ross Kirsling.
1457 Setting CURLOPT_COOKIEFILE to NULL to disable the cookie engine was not added till 7.77.0
1458 so require that version or later.
1460 * Source/cmake/OptionsPlayStation.cmake:
1461 * Source/cmake/OptionsWinCairo.cmake:
1463 2021-11-01 David Kilzer <ddkilzer@apple.com>
1465 Add ddkilzer's GitHub name to contributors.json
1466 <https://webkit.org/b/232587>
1468 Reviewed by Jonathan Bedard.
1470 * metadata/contributors.json:
1472 2021-11-01 Robert Jenner <Jenner@apple.com>
1474 Add my GitHub name (robert-jenner) to contributors.json
1475 https://bugs.webkit.org/show_bug.cgi?id=232581
1477 Reviewed by Jonathan Bedard.
1479 * metadata/contributors.json:
1481 2021-11-01 Beth Dakin <bdakin@apple.com>
1483 Add my GitHub name to contributors.json
1484 https://bugs.webkit.org/show_bug.cgi?id=232495
1486 Reviewed by Alexey Proskuryakov.
1488 * metadata/contributors.json:
1490 2021-11-01 BJ Burg <bburg@apple.com>
1492 Add bburg's GitHub username to contributors.json.
1496 * metadata/contributors.json:
1497 Also, canonicalize a recent change.
1499 2021-10-31 Fujii Hironori <Hironori.Fujii@sony.com>
1501 [WinCairo] New GraphicsLayer for GPU process mode
1502 https://bugs.webkit.org/show_bug.cgi?id=228308
1504 Reviewed by Don Olmstead.
1506 * Source/cmake/OptionsWinCairo.cmake:
1508 2021-10-29 Oriol Brufau <obrufau@igalia.com>
1510 Add Aakash's GitHub username to contributors.json
1514 * metadata/contributors.json:
1516 2021-10-29 Oriol Brufau <obrufau@igalia.com>
1518 Add obrufau's GitHub username to contributors.json
1522 * metadata/contributors.json:
1524 2021-10-28 Myles C. Maxfield <mmaxfield@apple.com>
1526 The space glyph in the Filicudi font is not substituted by shaping in the complex text codepath, thereby breaking the visual effect of the font
1527 https://bugs.webkit.org/show_bug.cgi?id=232293
1529 Reviewed by Darin Adler.
1531 Big thanks to Ulrike Rausch and Frank Grießhammer for contributing the test font!!!
1533 * metadata/contributors.json:
1535 2021-10-28 Aditya Keerthi <akeerthi@apple.com>
1537 Add Aditya Keerthi as a reviewer
1538 https://bugs.webkit.org/show_bug.cgi?id=232450
1542 * metadata/contributors.json:
1544 Add myself as a reviewer, and add GitHub username.
1546 2021-10-27 Roy Reapor <rreapor@apple.com>
1548 Add rreapor's GitHub username to contributors.json.
1549 https://bugs.webkit.org/show_bug.cgi?id=232385
1551 Reviewed by Aakash Jain.
1553 * metadata/contributors.json:
1555 2021-10-26 Adrian Perez de Castro <aperez@igalia.com>
1557 Unreviewed. [WPE] Bump version numbers
1559 * Source/cmake/OptionsWPE.cmake:
1561 2021-10-26 Adrian Perez de Castro <aperez@igalia.com>
1563 Multiple build issues with ENABLE_VIDEO=OFF
1564 https://bugs.webkit.org/show_bug.cgi?id=232264
1566 Reviewed by Carlos Garcia Campos.
1568 * Source/cmake/WebKitFeatures.cmake: Make ENABLE_MEDIA_SESSION depend on ENABLE_VIDEO.
1570 2021-10-25 Jonathan Bedard <jbedard@apple.com>
1572 Add GitHub usernames for bedison and darinadler
1576 * metadata/contributors.json: Add beidson and darinadler.
1578 2021-10-25 Zan Dobersek <zdobersek@igalia.com>
1580 Add zdobersek's GitHub name to contributors.json
1581 https://bugs.webkit.org/show_bug.cgi?id=232234
1585 * metadata/contributors.json:
1587 2021-10-25 Martin Robinson <mrobinson@webkit.org>
1589 Add mrobinson's GitHub name to contributors.json
1590 https://bugs.webkit.org/show_bug.cgi?id=232232
1594 * metadata/contributors.json:
1596 2021-10-24 Alexey Shvayka <ashvayka@apple.com>
1598 Add my GitHub username to contributors.json and update credentials
1602 * metadata/contributors.json:
1604 2021-10-22 Guillaume Emont <guijemont@igalia.com>
1606 Add Guillaume Emont's github username to contributors.json
1607 https://bugs.webkit.org/show_bug.cgi?id=232144
1611 * metadata/contributors.json:
1613 2021-10-22 Pablo Correa Gómez <ablocorrea@hotmail.com>
1615 Enable logging under non-systemd linux distros
1616 https://bugs.webkit.org/show_bug.cgi?id=232080
1618 Reviewed by Michael Catanzaro.
1620 * Source/cmake/FindJournald.cmake: Renamed from Source/cmake/FindSystemd.cmake.
1621 * Source/cmake/OptionsGTK.cmake: Replace USE_SYSTEMD for
1623 * Source/cmake/OptionsWPE.cmake: Replace USE_SYSTEMD for
1626 2021-10-21 Eric Carlson <eric.carlson@apple.com>
1628 Add GitHub name to contributors.json
1629 https://bugs.webkit.org/show_bug.cgi?id=232131
1631 Add my github username to contributors.json
1635 * metadata/contributors.json:
1637 2021-10-21 Chris Lord <clord@igalia.com>
1639 [WPE][GTK] Enable smooth scrolling by default
1640 https://bugs.webkit.org/show_bug.cgi?id=220512
1642 Reviewed by Carlos Garcia Campos.
1644 Build smooth scrolling by default on WPE to match other platforms.
1646 * Source/cmake/OptionsWPE.cmake:
1648 2021-10-20 Kimmo Kinnunen <kkinnunen@apple.com>
1650 Add ObjC as supported .clang-format language
1651 https://bugs.webkit.org/show_bug.cgi?id=230401
1653 Reviewed by Jonathan Bedard.
1655 Add ObjC and change few properties useful
1656 for ObjC formatting.
1660 2021-10-20 Carlos Garcia Campos <cgarcia@igalia.com>
1662 [WPE] Reenable -fvisibility=hidden and -fvisibility-inlines-hidden
1663 https://bugs.webkit.org/show_bug.cgi?id=222860
1665 Reviewed by Don Olmstead.
1667 * Source/cmake/OptionsWPE.cmake:
1669 2021-10-19 Ross Kirsling <ross.kirsling@sony.com>
1671 [CMake] Align OptionsMac with Xcode build
1672 https://bugs.webkit.org/show_bug.cgi?id=231982
1674 Reviewed by Don Olmstead.
1676 * Source/cmake/OptionsMac.cmake:
1677 Ensure that the listed options (1) are not redundant with the defaults in WebKitFeatures.cmake and
1678 (2) match the options for the Xcode build as closely as possible.
1680 * Source/cmake/WebKitFeatures.cmake:
1681 Remove an outdated feature, ENABLE_APPLE_PAY_SESSION_V9,
1682 and let ENABLE_MAC_GESTURE_EVENTS be handled by PlatformEnable, since it depends on USE_APPLE_INTERNAL_SDK.
1684 2021-10-19 Tyler Wilcock <tyler_w@apple.com>
1686 Add AX team GitHub usernames to contributors.json
1687 https://bugs.webkit.org/show_bug.cgi?id=231966
1689 Reviewed by Chris Fleizach.
1691 * metadata/contributors.json:
1692 Add Chris Fleizach's and Andres Gonzalez's GitHub usernames. Add Tyler
1693 Wilcock as a contributor. Run validate-committer-lists --canonicalize
1694 to fix some style issues.
1696 2021-10-19 Sergio Villar Senin <svillar@igalia.com>
1698 Add my github username to contributors.json
1702 * metadata/contributors.json:
1704 2021-10-18 Ms2ger <Ms2ger@igalia.com>
1706 Add my github username to contributors.json
1707 https://bugs.webkit.org/show_bug.cgi?id=231893
1711 * metadata/contributors.json:
1713 2021-10-18 Rob Buis <rbuis@igalia.com>
1715 Add my github username to contributors.json
1716 https://bugs.webkit.org/show_bug.cgi?id=231889
1718 Reviewed by Manuel Rego Casasnovas.
1720 * metadata/contributors.json:
1722 2021-10-18 Xan Lopez <xan@igalia.com>
1724 Add my github username to contributors.json
1725 https://bugs.webkit.org/show_bug.cgi?id=231887
1729 * metadata/contributors.json: add my github username.
1731 2021-10-18 Miguel Gomez <magomez@igalia.com>
1733 Add my github username to contributors.json
1737 * metadata/contributors.json:
1739 2021-10-16 Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com>
1741 Add github username for tetsuharuohzeki to contributors.json
1742 https://bugs.webkit.org/show_bug.cgi?id=231864
1744 Reviewed by Fujii Hironori.
1746 * metadata/contributors.json:
1748 2021-10-16 Angelos Oikonomopoulos <angelos@igalia.com>
1750 Add my github username to contributors.json
1751 https://bugs.webkit.org/show_bug.cgi?id=231861
1755 * metadata/contributors.json:
1757 2021-10-16 Caitlin Potter <caitp@igalia.com>
1759 Add github username for myself
1760 https://bugs.webkit.org/show_bug.cgi?id=231857
1762 Reviewed by Yusuke Suzuki.
1764 * metadata/contributors.json:
1766 2021-10-15 Basuke Suzuki <basuke.suzuki@sony.com>
1768 Add flag to turn off Iso heap
1769 https://bugs.webkit.org/show_bug.cgi?id=231823
1771 Reviewed by Yusuke Suzuki.
1773 Added USE_ISO_MALLOC feature flags which is on by default for most platforms.
1775 * Source/cmake/OptionsPlayStation.cmake:
1776 * Source/cmake/WebKitFeatures.cmake:
1778 2021-10-15 Ross Kirsling <ross.kirsling@sony.com>
1780 Realize Mac CMake build of WebCore and WebKit
1781 https://bugs.webkit.org/show_bug.cgi?id=231749
1783 Reviewed by Alex Christensen.
1785 * Source/cmake/OptionsMac.cmake:
1786 * Source/cmake/WebKitMacros.cmake:
1788 2021-10-15 Jonathan Bedard <jbedard@apple.com>
1790 Add github username for Dewei Zhu
1794 * metadata/contributors.json:
1796 2021-10-15 Andres Gonzalez <andresg_22@apple.com>
1798 Change Andres Gonzalez status to reviewer.
1799 https://bugs.webkit.org/show_bug.cgi?id=231738
1801 Reviewed by Chris Fleizach.
1803 * metadata/contributors.json:
1805 2021-10-15 Carlos Garcia Campos <cgarcia@igalia.com>
1807 Unreviewed. Fix GTK build with ubuntu 18.04
1809 GLib version bump in r284152 was too high for ubuntu 18.04 even though it followed our dependencies policy.
1811 * Source/cmake/OptionsGTK.cmake:
1812 * Source/cmake/OptionsWPE.cmake:
1814 2021-10-14 Ali Juma <ajuma@chromium.org>
1816 Add my GitHub username to contributors.json
1820 * metadata/contributors.json:
1822 2021-10-14 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
1824 Add my GitHub username to contributors.json
1828 * metadata/contributors.json:
1830 2021-10-14 Commit Queue <commit-queue@webkit.org>
1832 Unreviewed, reverting r283878.
1833 https://bugs.webkit.org/show_bug.cgi?id=231735
1839 "[WPE] Reenable -fvisibility=hidden and -fvisibility-inlines-
1841 https://bugs.webkit.org/show_bug.cgi?id=222860
1842 https://commits.webkit.org/r283878
1844 2021-10-14 Carlos Garcia Campos <cgarcia@igalia.com>
1846 [GTK][WPE] Bump GLib version to 2.58.3
1847 https://bugs.webkit.org/show_bug.cgi?id=231726
1849 Reviewed by Philippe Normand.
1851 * Source/cmake/OptionsGTK.cmake:
1852 * Source/cmake/OptionsWPE.cmake:
1854 2021-10-14 Enrique Ocaña González <eocanha@igalia.com>
1856 [contributors.json] Add eocanha github account and canonicalize
1857 https://bugs.webkit.org/show_bug.cgi?id=231729
1861 Added eocanha github user to contributors.json and canonicalize the file to make the style checker happy.
1863 * metadata/contributors.json:
1865 2021-10-13 Tim Horton <timothy_horton@apple.com>
1867 Add my GitHub username to contributors.json
1871 * metadata/contributors.json:
1873 2021-10-13 Carlos Garcia Campos <cgarcia@igalia.com>
1875 Add my github username to contributors.json
1879 * metadata/contributors.json:
1881 2021-10-12 Alex Christensen <achristensen@webkit.org>
1883 Add webpushd executable
1884 https://bugs.webkit.org/show_bug.cgi?id=231650
1886 Reviewed by Brady Eidson.
1888 * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
1890 2021-10-12 Basuke Suzuki <basuke.suzuki@sony.com>
1892 [PlayStation] Enable RemoteInspector by default
1893 https://bugs.webkit.org/show_bug.cgi?id=231599
1895 Reviewed by Fujii Hironori.
1897 It was treated as experimental feature but we've depended on this feature in various situation.
1899 * Source/cmake/OptionsPlayStation.cmake:
1901 2021-10-12 Philippe Normand <pnormand@igalia.com>
1903 Add my github username to contributors.json
1907 * metadata/contributors.json:
1909 2021-10-11 Patrick Griffis <pgriffis@igalia.com>
1911 Add my github username to contributors.json
1915 * metadata/contributors.json:
1917 2021-10-11 Sam Weinig <weinig@apple.com>
1919 Add my github username and keep my expertise where it is because, while not up to date, it is fun
1923 * metadata/contributors.json:
1925 2021-10-11 Theresa O'Connor <hober@apple.com>
1927 Various updates to my contributors.json entry.
1931 * metadata/contributors.json:
1933 2021-10-11 Devin Rousso <drousso@apple.com>
1935 Add my github and update my expertise
1939 * metadata/contributors.json:
1941 2021-10-10 Noam Rosenthal <noam@webkit.org>
1943 Add my github username to contributors.json
1947 * metadata/contributors.json:
1949 2021-10-11 Emilio Cobos Álvarez <emilio@crisal.io>
1951 Add my GitHub username to contributors.json.
1952 https://bugs.webkit.org/show_bug.cgi?id=231507
1956 * metadata/contributors.json:
1958 2021-10-11 Claudio Saavedra <csaavedra@igalia.com>
1960 Add my github username to contributors.json
1964 * metadata/contributors.json:
1966 2021-10-11 Diego Pino Garcia <dpino@igalia.com>
1968 Add GitHub username for Diego Pino Garcia
1972 * metadata/contributors.json:
1974 2021-10-10 Pablo Saavedra <psaavedra@igalia.com>
1976 Add GitHub username for Pablo Saavedra
1980 * metadata/contributors.json:
1982 2021-10-10 Xabier Rodriguez Calvar <calvaris@igalia.com>
1984 Unreviewed. Add GitHub username for Xabier Rodriguez Calvar
1986 * metadata/contributors.json:
1988 2021-10-10 Cameron McCormack <heycam@apple.com>
1990 Add GitHub account to contributors.json
1991 https://bugs.webkit.org/show_bug.cgi?id=231497
1995 * metadata/contributors.json:
1997 2021-10-10 Michael Catanzaro <mcatanzaro@gnome.org>
1999 [WPE] Reenable -fvisibility=hidden and -fvisibility-inlines-hidden
2000 https://bugs.webkit.org/show_bug.cgi?id=222860
2002 Reviewed by Philippe Normand.
2004 * Source/cmake/OptionsWPE.cmake:
2006 2021-10-10 Adrian Perez de Castro <aperez@igalia.com>
2008 Unreviewed. Add GitHub username for Adrian Perez de Castro
2010 While at it, run "validate-committer-lists --canonicalize".
2012 * metadata/contributors.json:
2014 2021-10-09 Alberto Garcia <berto@igalia.com>
2016 Add GitHub account to contributors.json
2020 * metadata/contributors.json:
2022 2021-10-09 Jean-Yves Avenard <jya@apple.com>
2024 Unreviewed, add my GitHub username
2026 * metadata/contributors.json:
2028 2021-10-09 Manuel Rego Casasnovas <rego@igalia.com>
2030 Add GitHub account to contributors.json and update expertise field
2031 https://bugs.webkit.org/show_bug.cgi?id=231476
2035 * metadata/contributors.json:
2037 2021-10-08 Joonghun Park <jh718.park@samsung.com>
2039 Unreviewed. Add github username for Joonghun Park.
2041 * metadata/contributors.json:
2043 2021-10-08 Jonathan Bedard <jbedard@apple.com>
2045 Add github username for Michael Catanzaro
2049 * metadata/contributors.json:
2051 2021-10-08 Kenneth Russell <kbr@chromium.org>
2053 Add github username for kbr
2054 https://bugs.webkit.org/show_bug.cgi?id=231462
2056 Reviewed by Dean Jackson.
2058 * metadata/contributors.json:
2060 2021-10-08 Ross Kirsling <ross.kirsling@sony.com>
2062 Unreviewed, add GitHub usernames for Sony contributors.
2064 * metadata/contributors.json:
2066 2021-10-08 Yusuke Suzuki <ysuzuki@apple.com>
2068 Unreviewed, add my GitHub username
2070 * metadata/contributors.json:
2072 2021-10-08 Tim Nguyen <ntim@apple.com>
2074 [contributors.json] Add more Github usernames
2075 https://bugs.webkit.org/show_bug.cgi?id=231453
2077 Reviewed by Jonathan Bedard.
2079 * metadata/contributors.json:
2081 2021-10-08 Jonathan Bedard <jbedard@apple.com>
2083 [contributors.json] Support GitHub usernames
2084 https://bugs.webkit.org/show_bug.cgi?id=231400
2085 <rdar://problem/84005266>
2087 Reviewed by Dewei Zhu.
2089 * metadata/contributors.json: Add some GitHub usernames.
2091 2021-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
2093 [GTK] Reenable -fvisibility=hidden
2094 https://bugs.webkit.org/show_bug.cgi?id=181916
2096 Reviewed by Michael Catanzaro.
2098 * Source/cmake/OptionsGTK.cmake:
2100 2021-10-06 Chris Dumez <cdumez@apple.com>
2102 Unreviewed, mark Kimmo Kinnunen as reviewer in the right contributors.json file this time.
2104 * metadata/contributors.json:
2106 2021-10-03 Basuke Suzuki <basuke.suzuki@sony.com>
2108 Enable release log to stderr
2109 https://bugs.webkit.org/show_bug.cgi?id=230725
2110 <rdar://problem/83740529>
2112 Reviewed by Michael Catanzaro.
2114 Introduced new flags, USE_LOG_STDERR for release logging to stderr.
2116 * Source/cmake/WebKitFeatures.cmake:
2118 2021-10-02 Philippe Normand <pnormand@igalia.com>
2120 [GTK][WPE] Enable bwrap launcher build on bots
2121 https://bugs.webkit.org/show_bug.cgi?id=230969
2123 Reviewed by Michael Catanzaro.
2125 * Source/cmake/OptionsGTK.cmake:
2126 * Source/cmake/OptionsWPE.cmake:
2128 2021-09-30 Yusuke Suzuki <ysuzuki@apple.com>
2130 Upgrade GCC requirement to 8.3.0
2131 https://bugs.webkit.org/show_bug.cgi?id=231042
2133 Reviewed by Darin Adler.
2135 Based on the roadmap[1], we upgrade GCC requirement to 8.3.0, which is default GCC in Debian one-old-stable (buster) right now.
2136 This paves the way to enabling some of useful C++20 features, e.g. default initializer for bitfields.
2138 [1]: https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement
2140 * Source/cmake/WebKitCommon.cmake:
2142 2021-09-29 Kimmo Kinnunen <kkinnunen@apple.com>
2144 MediaStream canvas.captureStream() fails for WebGL
2145 https://bugs.webkit.org/show_bug.cgi?id=230613
2148 Reviewed by Youenn Fablet.
2150 Add a manual test to interact with media stream
2151 captureStream() behavior until the implementation is
2154 * ManualTests/mediastream/mediastream-canvas-to-video.html: Added.
2156 2021-09-28 Carlos Garcia Campos <cgarcia@igalia.com>
2158 [GTK][WPE] Bump libsoup3 version to 3.0.0
2159 https://bugs.webkit.org/show_bug.cgi?id=230601
2161 Reviewed by Philippe Normand.
2163 * Source/cmake/OptionsGTK.cmake:
2164 * Source/cmake/OptionsWPE.cmake:
2166 2021-09-23 Fujii Hironori <Hironori.Fujii@sony.com>
2168 [MSVC] The "/Zc:lambda" switch is recommended to use the new lambda processor.
2169 https://bugs.webkit.org/show_bug.cgi?id=226070
2171 Reviewed by Ross Kirsling.
2173 Visual Studio 16.5 added the "/Zc:lambda" switch for the better
2174 C++ conformance, but it had a compiler crashing bug. Visual Studio
2177 * Source/cmake/OptionsMSVC.cmake: Added /Zc:lambda for Visual
2178 Studio 16.9 or later. I will remove the MSVC_VERSION check after
2179 AppleWin bots will upgrade MSVC.
2181 2021-09-17 Angelos Oikonomopoulos <angelos@igalia.com>
2183 Unbreak GCC_OFFLINEASM_SOURCE_MAP when LTO is in use
2184 https://bugs.webkit.org/show_bug.cgi?id=230061
2185 <rdar://problem/83166173>
2187 Reviewed by Michael Catanzaro.
2189 * Source/cmake/OptionsCommon.cmake:
2191 Re-enable GCC_OFFLINEASM_SOURCE_MAP.
2193 2021-09-17 Carlos Garcia Campos <cgarcia@igalia.com>
2195 Unreviewed. [GTK] Bump version numbers
2197 * Source/cmake/OptionsGTK.cmake:
2199 2021-09-17 Martin Robinson <mrobinson@webkit.org>
2201 Add Martin Robinson as a reviewer
2202 https://bugs.webkit.org/show_bug.cgi?id=230392
2206 * metadata/contributors.json: Add myself as a reviewer and update my specializations.
2208 2021-09-17 Carlos Garcia Campos <cgarcia@igalia.com>
2210 [GTK][a11y] Add a build option to enable ATSPI
2211 https://bugs.webkit.org/show_bug.cgi?id=230254
2213 Reviewed by Adrian Perez de Castro.
2215 Add USE_ATSPI build option that disables ATK and enables isolated tree.
2217 * Source/cmake/OptionsGTK.cmake:
2219 2021-09-16 Philip Chimento <pchimento@igalia.com>
2221 Fixes for build-webkit --minimal
2222 https://bugs.webkit.org/show_bug.cgi?id=229780
2224 Reviewed by Fujii Hironori.
2226 Remove ENABLE_RESIZE_OBSERVER build-time option. This option is
2227 quite broken if you try to disable it.
2229 * Source/cmake/OptionsFTW.cmake:
2230 * Source/cmake/OptionsMac.cmake:
2231 * Source/cmake/WebKitFeatures.cmake:
2233 2021-09-15 Philip Chimento <pchimento@igalia.com>
2235 Fixes for build-webkit --minimal
2236 https://bugs.webkit.org/show_bug.cgi?id=229780
2238 Reviewed by Fujii Hironori.
2240 Remove ENABLE_INTERSECTION_OBSERVER build-time option. This option is
2241 quite broken if you try to disable it.
2243 * Source/cmake/OptionsFTW.cmake:
2244 * Source/cmake/OptionsMac.cmake:
2245 * Source/cmake/WebKitFeatures.cmake:
2247 2021-09-14 John Wilander <wilander@apple.com>
2249 Rename RESOURCE_LOAD_STATISTICS to INTELLIGENT_TRACKING_PREVENTION
2250 https://bugs.webkit.org/show_bug.cgi?id=230279
2251 <rdar://problem/83118683>
2253 Reviewed by Darin Adler.
2255 * Source/cmake/OptionsFTW.cmake:
2256 * Source/cmake/OptionsGTK.cmake:
2257 * Source/cmake/OptionsMac.cmake:
2258 * Source/cmake/OptionsPlayStation.cmake:
2259 * Source/cmake/OptionsWPE.cmake:
2260 * Source/cmake/OptionsWin.cmake:
2261 * Source/cmake/WebKitFeatures.cmake:
2263 2021-09-14 Hoa Dinh <dvh@apple.com>
2265 Add dvh@apple.com to the list of contributors.
2266 https://bugs.webkit.org/show_bug.cgi?id=230276
2268 Reviewed by Jonathan Bedard.
2270 * metadata/contributors.json:
2272 2021-09-13 Sam Sneddon <gsnedders@apple.com>
2274 Move ENABLE_RESOLUTION_MEDIA_QUERY to a runtime flag, start running tests again
2275 https://bugs.webkit.org/show_bug.cgi?id=229776
2277 Reviewed by Simon Fraser.
2279 * Source/cmake/OptionsFTW.cmake:
2280 * Source/cmake/WebKitFeatures.cmake:
2282 2021-09-11 Philippe Normand <pnormand@igalia.com>
2284 [GLIB] MediaSession is not enabled
2285 https://bugs.webkit.org/show_bug.cgi?id=217991
2286 <rdar://problem/70740119>
2288 Reviewed by Michael Catanzaro.
2290 Enable MediaSession as an experimental build feature in CMake ports. The spec status is
2293 * Source/cmake/OptionsGTK.cmake:
2294 * Source/cmake/OptionsWPE.cmake:
2295 * Source/cmake/WebKitFeatures.cmake:
2297 2021-09-08 Justin Michaud <justin_michaud@apple.com>
2299 Change Justin Michaud's primary email to apple.com
2300 https://bugs.webkit.org/show_bug.cgi?id=230069
2302 Reviewed by Robin Morisset.
2304 * metadata/contributors.json:
2306 2021-09-07 Fujii Hironori <Hironori.Fujii@sony.com>
2308 [WinCairo] Support prefers-color-scheme media query
2309 https://bugs.webkit.org/show_bug.cgi?id=229976
2311 Reviewed by Don Olmstead.
2313 Just turned on ENABLE_DARK_MODE_CSS and HAVE_OS_DARK_MODE_SUPPORT.
2314 It's always the light mode.
2316 * Source/cmake/OptionsWin.cmake:
2317 * Source/cmake/OptionsWinCairo.cmake:
2319 2021-09-06 Carlos Alberto Lopez Perez <clopez@igalia.com>
2321 [CMake] Prefer python3 over python2
2322 https://bugs.webkit.org/show_bug.cgi?id=229969
2324 Reviewed by Michael Catanzaro.
2326 Use the CMake module FindPython instead of FindPythonInterp.
2327 FindPython looks preferably for version 3 of Python. If not found, then it looks for version 2.
2329 * Source/cmake/WebKitCommon.cmake:
2331 2021-09-03 Michael Catanzaro <mcatanzaro@gnome.org>
2333 Disable GCC_OFFLINEASM_SOURCE_MAP
2334 https://bugs.webkit.org/show_bug.cgi?id=229893
2336 Unreviewed, this fixes build failures caused by invalid assembler sources.
2338 * Source/cmake/OptionsCommon.cmake:
2340 2021-09-01 Jonathan Bedard <jbedard@apple.com>
2342 [contributors.json] Relocation (Part 2)
2343 https://bugs.webkit.org/show_bug.cgi?id=229690
2344 <rdar://problem/82552403>
2346 Reviewed by Dewei Zhu.
2348 * metadata/contributors.json: Convert from dictionary to list.
2350 2021-09-01 Jonathan Bedard <jbedard@apple.com>
2352 [contributors.json] Relocation (Part 1)
2353 https://bugs.webkit.org/show_bug.cgi?id=229690
2354 <rdar://problem/82552403>
2356 Reviewed by Aakash Jain.
2358 * metadata/contributors.json: Copied from Tools/Scripts/webkitpy/common/config/contributors.json.
2360 2021-08-30 Zan Dobersek <zdobersek@igalia.com>
2362 RISCV64 support in LLInt
2363 https://bugs.webkit.org/show_bug.cgi?id=229035
2364 <rdar://problem/82120908>
2366 Reviewed by Yusuke Suzuki.
2368 * Source/cmake/WebKitFeatures.cmake:
2369 Don't force CLoop to be default for RISCV64 anymore.
2371 2021-08-27 Stephan Szabo <stephan.szabo@sony.com>
2373 [PlayStation][CMake] Add control over whether JavaScriptCore should be shared
2374 https://bugs.webkit.org/show_bug.cgi?id=229591
2376 Add option for controlling whether to build a shared JavaScriptCore and
2377 set build type for that appropriately.
2379 Reviewed by Don Olmstead.
2381 * Source/cmake/OptionsPlayStation.cmake:
2383 2021-08-27 Russell Epstein <repstein@apple.com>
2385 Land Windows build fixes from safari-612.1.29.14-branch.
2386 https://bugs.webkit.org/show_bug.cgi?id=229627
2388 Reviewed by Per Arne Vollan.
2391 * Source/cmake/WinTools.make:
2393 2021-08-27 Carlos Alberto Lopez Perez <clopez@igalia.com>
2395 [CMake] ICU 61.2 is required to build WebKit since r281375
2396 https://bugs.webkit.org/show_bug.cgi?id=229608
2398 Reviewed by Yusuke Suzuki.
2400 Raise the minimum version required for ICU.
2402 * Source/cmake/OptionsAppleWin.cmake:
2403 * Source/cmake/OptionsFTW.cmake:
2404 * Source/cmake/OptionsGTK.cmake:
2405 * Source/cmake/OptionsJSCOnly.cmake:
2406 * Source/cmake/OptionsMac.cmake:
2407 * Source/cmake/OptionsPlayStation.cmake:
2408 * Source/cmake/OptionsWPE.cmake:
2409 * Source/cmake/OptionsWinCairo.cmake:
2411 2021-08-25 Myles C. Maxfield <mmaxfield@apple.com>
2413 Add command to enable logging in the docs
2414 https://bugs.webkit.org/show_bug.cgi?id=229419
2416 Reviewed by Dean Jackson.
2420 2021-08-20 Carlos Alberto Lopez Perez <clopez@igalia.com>
2422 REGRESSION(r274166): [GTK] It broke run-javascriptcore-tests causing all tests to use lot of memory
2423 https://bugs.webkit.org/show_bug.cgi?id=229321
2425 Unreviewed, reverting r274166 because it caused JSC tests to use too much memory.
2428 "[GTK] Reenable -fvisibility=hidden"
2429 https://bugs.webkit.org/show_bug.cgi?id=181916
2430 https://commits.webkit.org/r274166
2432 * Source/cmake/OptionsGTK.cmake:
2434 2021-08-16 David Kilzer <ddkilzer@apple.com>
2436 "make analyze" should run clang static analyzer in deep mode
2437 <https://webkit.org/b/229127>
2438 <rdar://problem/81960587>
2440 Reviewed by Alexey Proskuryakov.
2443 - Add "analyze" argument to xcodebuild command when invoking
2444 "make analyze" to run clang static analyzer in deep mode.
2445 Simplify "make analyze" since $(PATH_TO_SCAN_BUILD) does not
2448 2021-08-16 Carlos Garcia Campos <cgarcia@igalia.com>
2450 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.33.3 release
2452 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
2454 2021-08-09 Myles C. Maxfield <mmaxfield@apple.com>
2456 Update logging docs after r280758
2457 https://bugs.webkit.org/show_bug.cgi?id=228899
2459 Reviewed by Fujii Hironori.
2461 Add more information about logging.
2465 2021-08-05 Michael Catanzaro <mcatanzaro@gnome.org>
2467 GCC 11 builds should use -Wno-array-bounds, -Wno-nonnull
2468 https://bugs.webkit.org/show_bug.cgi?id=228601
2470 Reviewed by Carlos Garcia Campos.
2472 Prior to GCC 11, these were good warnings that could catch serious errors. But GCC 11 has
2473 just become too sensitive and it's flagging what appear to be harmless cases, and not
2474 providing enough feedback to know why. This has resulted in me littering our code with
2475 pragmas to suppress GCC's false positives, and I think it's reached the point where it's
2476 nicer to just turn off the warnings until such time that GCC gets this under control, and
2477 rely on Clang instead in the meantime.
2479 The GCC developers have indicated that these warnings will *always* produce false positives
2480 in some circumstances, but with GCC 11 it's just too become too much IMO.
2482 * Source/cmake/WebKitCompilerFlags.cmake:
2484 2021-07-30 Adrian Perez de Castro <aperez@igalia.com>
2486 [CMake] Fix fallback methods in the libgcrypt find module
2487 https://bugs.webkit.org/show_bug.cgi?id=228581
2489 Reviewed by Carlos Alberto Lopez Perez.
2491 * Source/cmake/FindLibGcrypt.cmake: Make sure to use the libgcrypt-config script as
2492 first fallback if libgcrypt.pc is not present, and fix the regexp used as last fallback
2493 that checks the version from the gcrypt.h header as last fallback to only include digits
2496 2021-07-29 Myles C. Maxfield <mmaxfield@apple.com>
2498 Stop building WebGPU and the WHLSL compiler to decrease binary size
2499 https://bugs.webkit.org/show_bug.cgi?id=228179
2501 Reviewed by Dean Jackson, Robin Morisset, and Devin Rousso.
2503 * Source/cmake/OptionsFTW.cmake:
2504 * Source/cmake/OptionsMac.cmake:
2505 * Source/cmake/OptionsWinCairo.cmake:
2506 * Source/cmake/WebKitFeatures.cmake:
2507 * Source/cmake/tools/vsprops/FeatureDefines.props:
2508 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2510 2021-07-29 Adrian Perez de Castro <aperez@igalia.com>
2512 [CMake] Fix missing libgpg-error not added to link commands as libgcrypt dep after r280423
2513 https://bugs.webkit.org/show_bug.cgi?id=228581
2515 Reviewed by Carlos Alberto Lopez Perez.
2517 * Source/cmake/FindLibGcrypt.cmake: Manually search for libgpg-error, which is not listed
2518 in libgcrypt.pc as a dependency, add an imported target for it, and add it as a dependency
2519 of LibGcrypt::LibGcrypt to avoid missing symbols at link time.
2521 2021-07-29 Adrian Perez de Castro <aperez@igalia.com>
2523 [CMake] Use an imported target for the libgcrypt library
2524 https://bugs.webkit.org/show_bug.cgi?id=228581
2526 Reviewed by Michael Catanzaro.
2528 * Source/cmake/FindLibGcrypt.cmake: Replaced find module by a new one which defines a
2529 LibGcrypt::LibGcrypt imported target, using more modern CMake constructs.
2530 * Source/cmake/OptionsGTK.cmake: Use the LibGcrypt::LibGcrypt imported target.
2531 * Source/cmake/OptionsWPE.cmake: Ditto.
2533 2021-07-28 Philippe Normand <pnormand@igalia.com>
2535 [WPE][GTK] SVN_REVISION drifting away if bots don't re-run cmake
2536 https://bugs.webkit.org/show_bug.cgi?id=228290
2538 Reviewed by Michael Catanzaro.
2540 The CMake configure_file() is now used only tarball builds for files requiring information
2541 about the build revision. For developer builds a custom target now takes care of keeping
2542 those files up-to-date.
2544 * Source/cmake/OptionsGTK.cmake:
2545 * Source/cmake/OptionsWPE.cmake:
2547 2021-07-27 Zan Dobersek <zdobersek@igalia.com>
2549 [CMake] Add WTF_CPU_RISCV64
2550 https://bugs.webkit.org/show_bug.cgi?id=228322
2552 Reviewed by Adrian Perez de Castro.
2554 Define the WTF_CPU_RISCV64 CMake macro when the specified system
2555 processor name begins with 'riscv64'. This should also cover potential
2556 RISC-V processor names ingrained with specific ISA extensions that are
2557 then detectable at compile-time through specified C macros.
2559 For WTF_CPU_RISCV64, default to disabling JIT and FTL features at the
2560 CMake level until they are properly supported. Defaulting to system
2561 malloc can already be avoided, but CLoop is necessary for now.
2563 * Source/cmake/WebKitCommon.cmake:
2564 * Source/cmake/WebKitFeatures.cmake:
2566 2021-07-25 Michael Catanzaro <mcatanzaro@gnome.org>
2568 [GTK] USE_OPENGL_OR_ES should not be an automagic feature
2569 https://bugs.webkit.org/show_bug.cgi?id=228266
2571 Reviewed by Fujii Hironori.
2573 The USE_OPENGL_OR_ES feature flag added in r271220 is currently automagic: that is, if
2574 neither OpenGL nor OpenGL ES is available at build time, it gets silently disabled. This is
2575 not OK because it makes it easy for distributors to accidentally fail to enable OpenGL
2576 support. We should require manually disabling the feature with -DUSE_OPENGL_OR_ES=OFF in
2577 order to build with OpenGL disabled.
2579 * Source/cmake/OptionsGTK.cmake:
2581 2021-07-23 Philippe Normand <pnormand@igalia.com>
2583 [GLib] Remove libportal dependency
2584 https://bugs.webkit.org/show_bug.cgi?id=228056
2586 Reviewed by Carlos Garcia Campos.
2588 * Source/cmake/FindLIBPORTAL.cmake: Removed.
2589 * Source/cmake/GStreamerChecks.cmake:
2591 2021-07-16 Alexander Mikhaylenko <alexm@gnome.org>
2593 [GTK][WPE] Support color-schemes CSS property
2594 https://bugs.webkit.org/show_bug.cgi?id=208204
2596 Reviewed by Adrian Perez de Castro.
2598 * Source/cmake/OptionsGTK.cmake:
2599 Enable HAVE_OS_DARK_MODE_SUPPORT.
2600 * Source/cmake/OptionsWPE.cmake:
2601 Enable ENABLE_DARK_MODE_CSS and HAVE_OS_DARK_MODE_SUPPORT.
2603 2021-07-15 Philippe Normand <pnormand@igalia.com>
2605 Unreviewed, CMake fix-up after r279940
2607 * Source/cmake/FindLIBPORTAL.cmake: Fix libportal detection.
2609 2021-07-15 Philippe Normand <pnormand@igalia.com>
2611 [GStreamer][Pipewire] Implement getDisplayMedia() backend
2612 https://bugs.webkit.org/show_bug.cgi?id=210926
2614 Reviewed by Xabier Rodriguez-Calvar.
2616 * Source/cmake/FindLIBPORTAL.cmake: Added.
2617 * Source/cmake/GStreamerChecks.cmake: Enable Pipewire support if libportal was found.
2619 2021-07-13 Michael Catanzaro <mcatanzaro@gnome.org>
2621 Remove USE_64KB_PAGE_BLOCK
2622 https://bugs.webkit.org/show_bug.cgi?id=227905
2624 Reviewed by Yusuke Suzuki.
2626 I added the USE_64KB_PAGE_BLOCK build option in bug #217989 for use by RHEL. But going
2627 forward, I don't need it anymore, and can maintain it downstream where it is needed. (This
2628 option might also be useful to SUSE, but they already don't use it, so won't miss it.)
2630 I've seen users who don't understand the consequences of this option enabling it on x86_64,
2631 even though there are serious negative consequences and zero benefits to using it. So let's
2634 * Source/cmake/WebKitFeatures.cmake:
2636 2021-07-13 Carlos Garcia Campos <cgarcia@igalia.com>
2638 [GTK][WPE] Expose support for client certificate auth
2639 https://bugs.webkit.org/show_bug.cgi?id=200805
2641 Reviewed by Michael Catanzaro.
2643 Bump libsoup3 required version.
2645 * Source/cmake/OptionsGTK.cmake:
2646 * Source/cmake/OptionsWPE.cmake:
2648 2021-06-24 Zan Dobersek <zdobersek@igalia.com>
2650 REGRESSION(r236846): WPE shouldn't depend on OpenGL ES 3
2651 https://bugs.webkit.org/show_bug.cgi?id=227289
2653 Reviewed by Adrian Perez de Castro.
2655 * Source/cmake/OptionsWPE.cmake: Drop the OpenGLES2 package search.
2656 None of the possible versions are meaningful because libepoxy is used
2657 as the underlying GL relay.
2659 2021-06-24 Martin Robinson <mrobinson@webkit.org>
2661 [css-scroll-snap] Remove ENABLE_SCROLL_SNAP compile-time option
2662 https://bugs.webkit.org/show_bug.cgi?id=227067
2664 Reviewed by Simon Fraser.
2666 Remove compile-time ENABLE_SCROLL_SNAP configuration option.
2668 * Source/cmake/WebKitFeatures.cmake: Remove the flag from the CMake configuration.
2670 2021-06-21 Fujii Hironori <Hironori.Fujii@sony.com>
2672 [WinCairo] Turn ENABLE_SHAREABLE_RESOURCE on
2673 https://bugs.webkit.org/show_bug.cgi?id=227011
2675 Reviewed by Don Olmstead.
2677 * Source/cmake/OptionsWin.cmake: Turned ENABLE_SHAREABLE_RESOURCE on for WinCairo port.
2679 2021-06-18 Sergio Villar Senin <svillar@igalia.com>
2681 Ignore clangd's directory with index files
2682 https://bugs.webkit.org/show_bug.cgi?id=227162
2684 Reviewed by Žan Doberšek.
2686 clangd stores its indexes in a .cache directory. Let git ignore it.
2690 2021-06-11 Adrian Perez de Castro <aperez@igalia.com>
2692 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.33.2 release
2694 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
2696 2021-06-10 Carlos Alberto Lopez Perez <clopez@igalia.com>
2698 [CMake][GTK][WPE] Improve error message when libsoup3 is not found
2699 https://bugs.webkit.org/show_bug.cgi?id=226905
2701 Reviewed by Adrian Perez de Castro.
2703 When libsoup 3 is not found be more clear about the problem and
2704 offer possible workaround to continue the build.
2706 * Source/cmake/FindLibSoup.cmake:
2707 * Source/cmake/OptionsGTK.cmake:
2708 * Source/cmake/OptionsWPE.cmake:
2710 2021-06-10 Philippe Normand <pnormand@igalia.com>
2712 [WPE] Enable Cog for developer builds
2713 https://bugs.webkit.org/show_bug.cgi?id=224360
2715 Reviewed by Adrian Perez de Castro.
2717 Cog would be preferred over MiniBrowser for WPE developer builds because it provides a nicer
2718 user experience, while keeping the same spirit as MiniBrowser. Pass `-DENABLE_COG=NO` to
2719 CMake to disable it and fall back to MiniBrowser.
2721 * Source/cmake/OptionsWPE.cmake:
2723 2021-06-08 Carlos Garcia Campos <cgarcia@igalia.com>
2725 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.33.2 release
2727 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
2729 2021-06-07 Carlos Garcia Campos <cgarcia@igalia.com>
2731 [GTK][WPE] Bump libsoup3 version to 2.99.8
2732 https://bugs.webkit.org/show_bug.cgi?id=226713
2734 Reviewed by Philippe Normand.
2736 * Source/cmake/OptionsGTK.cmake:
2737 * Source/cmake/OptionsWPE.cmake:
2739 2021-06-04 Per Arne Vollan <pvollan@apple.com>
2741 [AppleWin] JSC build failure
2742 https://bugs.webkit.org/show_bug.cgi?id=226659
2745 Reviewed by Brent Fulgham.
2747 WTF scripts location is not being correctly identified.
2749 * Source/cmake/OptionsAppleWin.cmake:
2751 2021-06-04 Martin Robinson <mrobinson@webkit.org>
2753 [Win] Implement scroll-snap-points on Windows
2754 https://bugs.webkit.org/show_bug.cgi?id=142503
2755 <rdar://problem/20093603>
2757 Reviewed by Simon Fraser.
2759 * Source/cmake/OptionsWin.cmake: Stop disabling scroll-snap for Apple Win port.
2761 2021-05-27 Don Olmstead <don.olmstead@sony.com>
2763 [CMake] Add check for timingsafe_bcmp
2764 https://bugs.webkit.org/show_bug.cgi?id=226347
2766 Reviewed by Chris Dumez.
2768 Adds a symbol check for timingsafe_bcmp and sets HAVE_TIMINGSAFE_BCMP accordingly in the
2771 * Source/cmake/OptionsCommon.cmake:
2773 2021-05-27 Adrian Perez de Castro <aperez@igalia.com>
2775 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.33.1 release
2777 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
2779 2021-05-27 Adrian Perez de Castro <aperez@igalia.com>
2781 Unreviewed. [WPE] Bump version numbers
2783 * Source/cmake/OptionsWPE.cmake:
2785 2021-05-26 Don Olmstead <don.olmstead@sony.com>
2787 [CMake] Support USE_ANGLE_EGL on additional platforms
2788 https://bugs.webkit.org/show_bug.cgi?id=224888
2789 <rdar://problem/77280211>
2791 Reviewed by Ken Russell.
2793 USE_ANGLE_EGL is for platforms that want to use ANGLE as the sole OpenGL ES implementation
2794 within WebKit. This setting is applicable to Mac and Windows platforms. USE_ANGLE_WEBGL is
2795 just for platforms that want to use ANGLE for WebGL 2.0 support only. Any other uses of
2796 OpenGL should go through the system OpenGL (desktop or embedded). This setting applies to
2799 The platform options were modified to match this.
2801 * Source/cmake/OptionsGTK.cmake:
2802 * Source/cmake/OptionsMac.cmake:
2804 2021-05-25 Don Olmstead <don.olmstead@sony.com>
2806 [PlayStation] Implement FileSystem without std::filesystem
2807 https://bugs.webkit.org/show_bug.cgi?id=226197
2809 Reviewed by Chris Dumez.
2811 Expose the result of the check for <filesystem> support as HAVE_STD_FILESYSTEM.
2813 * Source/cmake/OptionsCommon.cmake:
2815 2021-05-18 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com>
2817 [PlayStation] Fix PlayStation port
2818 https://bugs.webkit.org/show_bug.cgi?id=225913
2820 Reviewed by Don Olmstead.
2822 Fix PlayStation port
2824 * Source/cmake/OptionsPlayStation.cmake: Rename
2825 PLAYSTATION_COPY_SHARED_LIBRARIES to PLAYSTATION_COPY_REQUIREMENTS and
2826 let it copy more general files.
2827 Touch ebootparam.ini by the playstation_tools_copy custom_target.
2829 2021-05-15 Sam Weinig <weinig@apple.com>
2831 Allow conditionally enabling OffscreenCanvas only for non-worker contexts
2832 https://bugs.webkit.org/show_bug.cgi?id=225845
2834 Reviewed by Darin Adler.
2836 * Source/cmake/OptionsGTK.cmake:
2837 * Source/cmake/OptionsWPE.cmake:
2838 * Source/cmake/WebKitFeatures.cmake:
2839 Match current behavior of ENABLE_OFFSCREEN_CANVAS for ENABLE_OFFSCREEN_CANVAS_IN_WORKERS.
2841 2021-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
2843 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.33.1 release
2845 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
2847 2021-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
2849 Unreviewed. [GTK] Fix make distcheck
2851 Use WEBKITGTK_API_DOC_VERSION instead of WEBKITGTK_API_VERSION or the documentation install rules.
2853 * Source/PlatformGTK.cmake:
2855 2021-05-07 Carlos Garcia Campos <cgarcia@igalia.com>
2857 [GTK][WPE] Bump libsoup3 version to 2.99.5
2858 https://bugs.webkit.org/show_bug.cgi?id=225506
2860 Reviewed by Philippe Normand.
2862 * Source/cmake/OptionsGTK.cmake:
2863 * Source/cmake/OptionsWPE.cmake:
2865 2021-05-06 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com>
2867 [OpenSSL] Implement CryptoAlgorithmRSA*
2868 https://bugs.webkit.org/show_bug.cgi?id=225294
2870 Reviewed by Don Olmstead.
2872 Implement RSA for OpenSSL.
2874 Implement CryptoAlgorithmRSA_OAEP, CryptoAlgorithmRSA_PSS,
2875 CryptoAlgorithmRSAES_PKCS1_v1_5, CryptoAlgorithmRSASA_PKCS1_v1_5,
2876 and CryptoKeyRSA for OpenSSL.
2878 Note that if such OpenSSL version that does not support RSA_OAEP or
2879 RSA_PSS, the WebCrypto API for those algorithm will return a
2882 * Source/cmake/OptionsPlayStation.cmake:
2883 * Source/cmake/OptionsWinCairo.cmake:
2885 2021-05-05 Michael Catanzaro <mcatanzaro@gnome.org>
2887 USE_64KB_PAGE_BLOCK build option is broken
2888 https://bugs.webkit.org/show_bug.cgi?id=225393
2890 Reviewed by Adrian Perez de Castro.
2892 Call SET_AND_EXPOSE_TO_BUILD().
2894 * Source/cmake/WebKitFeatures.cmake:
2896 2021-05-05 Michael Catanzaro <mcatanzaro@gnome.org>
2898 Fix typo in comment in WebKitFeatures.cmake
2899 https://bugs.webkit.org/show_bug.cgi?id=225392
2903 * Source/cmake/WebKitFeatures.cmake:
2905 2021-04-27 Don Olmstead <don.olmstead@sony.com>
2907 [CMake] Don't use FORWARDING_HEADERS_DIR for GTK WebKit headers
2908 https://bugs.webkit.org/show_bug.cgi?id=225006
2910 Reviewed by Michael Catanzaro.
2912 Create CMake variables WebKit2Gtk_FRAMEWORK_HEADERS_DIR and WebKit2Gtk_DERIVED_SOURCES_DIR
2913 to represent where the WebKit2 GTK headers and derived sources will reside. The names and
2914 locations set then follow along with the conventions used for the other frameworks.
2916 * Source/cmake/OptionsGTK.cmake:
2918 2021-04-26 Alex Christensen <achristensen@webkit.org>
2920 Update Mac-specific CMake files
2921 https://bugs.webkit.org/show_bug.cgi?id=225064
2923 Rubber-stamped by Tim Horton.
2925 * Source/cmake/OptionsMac.cmake:
2926 * Source/cmake/WebKitCommon.cmake:
2928 2021-04-26 Don Olmstead <don.olmstead@sony.com>
2930 [PlayStation] Fix build break after r276368
2931 https://bugs.webkit.org/show_bug.cgi?id=225056
2933 Reviewed by Ross Kirsling.
2935 Ensure that the OpenGL::GLES target is created.
2937 * Source/cmake/OptionsPlayStation.cmake:
2939 2021-04-22 Martin Robinson <mrobinson@webkit.org>
2941 [GTK] Turn on editable <input type=date> and <input type=time> fields
2942 https://bugs.webkit.org/show_bug.cgi?id=224921
2944 Reviewed by Carlos Garcia Campos.
2946 Turn on editable date and time inputs for GTK
2948 * Source/cmake/OptionsGTK.cmake: Add new source file to the list.
2950 2021-04-22 Imanol Fernandez <ifernandez@igalia.com>
2952 Implement WebXR Input Sources
2953 https://bugs.webkit.org/show_bug.cgi?id=223257
2955 Reviewed by Youenn Fablet.
2957 Enable WPE Gamepad when WebXR is enabled.
2959 * Source/cmake/OptionsWPE.cmake:
2961 2021-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
2963 [SOUP] Add support for preconnect
2964 https://bugs.webkit.org/show_bug.cgi?id=177934
2966 Reviewed by Sergio Villar Senin.
2968 Enable server preconnect support when building with libsoup3.
2970 * Source/cmake/OptionsGTK.cmake:
2971 * Source/cmake/OptionsWPE.cmake:
2973 2021-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
2975 [GTK][WPE] Bump libsoup3 version to 2.99.4
2976 https://bugs.webkit.org/show_bug.cgi?id=224925
2978 Reviewed by Philippe Normand.
2980 * Source/cmake/OptionsGTK.cmake:
2981 * Source/cmake/OptionsWPE.cmake:
2983 2021-04-21 Martin Robinson <mrobinson@igalia.com>
2985 Enable CSS Scroll Snap by default
2986 https://bugs.webkit.org/show_bug.cgi?id=224867
2988 Reviewed by Don Olmstead.
2990 * Source/cmake/OptionsFTW.cmake: Remove redundant line enabling scroll snap.
2991 * Source/cmake/OptionsGTK.cmake: Ditto.
2992 * Source/cmake/OptionsMac.cmake: Ditto.
2993 * Source/cmake/OptionsWPE.cmake: Ditto.
2994 * Source/cmake/OptionsWin.cmake: Explicitly disable scroll snap for AppleWin port
2995 until it can be approved by maintainers.
2996 * Source/cmake/WebKitFeatures.cmake: Enable scroll snap by default.
2998 2021-04-21 Don Olmstead <don.olmstead@sony.com>
3000 [CMake] Add OpenGLES2 targets
3001 https://bugs.webkit.org/show_bug.cgi?id=224786
3003 Reviewed by Adrian Perez de Castro.
3005 Modernize the FindOpenGLES2.cmake module. Add an OpenGL::GLES target. Also add an
3006 OpenGLES2_API_VERSION value so HAVE_OPENGL_ES_3 can be determined.
3008 For WPE add a find_package for OpenGL ES so the target is present.
3010 For GTK set HAVE_OPENGL_ES_3 if OpenGLES2_API_VERSION supports it.
3012 * Source/cmake/FindOpenGLES2.cmake:
3013 * Source/cmake/OptionsGTK.cmake:
3014 * Source/cmake/OptionsWPE.cmake:
3016 2021-04-20 Don Olmstead <don.olmstead@sony.com>
3018 [CMake] Don't use FORWARDING_HEADERS_DIR for JSC GLib headers
3019 https://bugs.webkit.org/show_bug.cgi?id=224821
3021 Reviewed by Michael Catanzaro.
3023 Create CMake variables JavaScriptCoreGLib_FRAMEWORK_HEADERS_DIR and
3024 JavaScriptCoreGLib_DERIVED_SOURCES_DIR to represent where the JavaScriptCore GLib headers
3025 and derived sources will reside. The names and locations set then follow along with the
3026 conventions used for the other frameworks.
3028 * Source/cmake/OptionsGTK.cmake:
3029 * Source/cmake/OptionsWPE.cmake:
3031 2021-04-20 Carlos Garcia Campos <cgarcia@igalia.com>
3033 [WPE] Switch to libsoup3 by default
3034 https://bugs.webkit.org/show_bug.cgi?id=224802
3036 Reviewed by Žan Doberšek.
3038 * Source/cmake/OptionsWPE.cmake:
3040 2021-04-19 Carlos Garcia Campos <cgarcia@igalia.com>
3042 [GTK] Switch to libsoup3 by default
3043 https://bugs.webkit.org/show_bug.cgi?id=224741
3045 Reviewed by Sergio Villar Senin.
3047 * Source/cmake/OptionsGTK.cmake:
3049 2021-04-19 Philippe Normand <pnormand@igalia.com>
3051 [WPE][GTK] Enable AVIF decoder as experimental feature and unskip tests
3052 https://bugs.webkit.org/show_bug.cgi?id=224663
3054 Reviewed by Xabier Rodriguez-Calvar.
3056 Make the USE_AVIF option public and enable it as experimental feature.
3058 * Source/cmake/OptionsGTK.cmake:
3059 * Source/cmake/OptionsWPE.cmake:
3061 2021-04-16 Philippe Normand <pnormand@igalia.com>
3063 [CMake] UBSan build fixes
3064 https://bugs.webkit.org/show_bug.cgi?id=224536
3066 Reviewed by Adrian Perez de Castro.
3068 Synchronize UBSan compiler flags with the ones defined in ubsan.xcconfig.
3070 * Source/cmake/WebKitCompilerFlags.cmake:
3072 2021-04-15 Don Olmstead <don.olmstead@sony.com>
3074 ANGLE is only being built when WebGL is enabled
3075 https://bugs.webkit.org/show_bug.cgi?id=224555
3077 Reviewed by Fujii Hironori.
3079 ANGLE should be built if either USE_ANGLE_EGL or ENABLE_WEBGL is ON.
3081 * Source/CMakeLists.txt:
3083 2021-04-15 Basuke Suzuki <basuke.suzuki@sony.com>
3085 Remove warnings caused by export g_config extern definition in WTFConfig.h
3086 https://bugs.webkit.org/show_bug.cgi?id=224462
3088 Reviewed by Don Olmstead.
3090 While building PlayStation port, lots of warnings are displayed:
3092 > WTF/Headers\wtf/WTFConfig.h:49:36: warning: redeclaration of 'WebConfig::g_config'
3093 > should not add 'dllimport' attribute [-Wdll-attribute-on-redeclaration]
3094 > extern "C" WTF_EXPORT_PRIVATE Slot g_config[];
3096 > bmalloc/Headers\bmalloc/GigacageConfig.h:38:17: note: previous declaration is here
3097 > extern "C" Slot g_config[];
3099 This is because the two definitions are not same.
3100 Becasue we can't solve the situation completely, we just ignore these warnings at
3103 * Source/cmake/OptionsPlayStation.cmake:
3105 2021-04-15 Philippe Normand <pnormand@igalia.com>
3107 [WebRTC][GStreamer] Build and use the openh264 based encoder if present on the system
3108 https://bugs.webkit.org/show_bug.cgi?id=202538
3109 <rdar://problem/76047172>
3111 Reviewed by Xabier Rodriguez-Calvar.
3113 * Source/CMakeLists.txt:
3114 * Source/cmake/GStreamerChecks.cmake:
3116 2021-04-14 Don Olmstead <don.olmstead@sony.com>
3118 [PlayStation] Disable WebGL
3119 https://bugs.webkit.org/show_bug.cgi?id=224562
3121 Reviewed by Alex Christensen.
3123 WebGL support on PlayStation platforms is deprecated.
3125 * Source/cmake/OptionsPlayStation.cmake:
3127 2021-04-13 Philippe Normand <pnormand@igalia.com>
3129 [GTK][WPE] Avif decoder build broken
3130 https://bugs.webkit.org/show_bug.cgi?id=224232
3132 Reviewed by Carlos Garcia Campos.
3134 * Source/cmake/OptionsGTK.cmake: Require 0.9.0 due to avifIO usage in the decoder.
3136 2021-04-09 Carlos Garcia Campos <cgarcia@igalia.com>
3138 [GTK][WPE] Bump libsoup3 version to 2.99.3
3139 https://bugs.webkit.org/show_bug.cgi?id=224362
3141 Reviewed by Žan Doberšek.
3143 * Source/cmake/OptionsGTK.cmake:
3144 * Source/cmake/OptionsWPE.cmake:
3146 2021-04-07 Michael Catanzaro <mcatanzaro@gnome.org>
3148 [GTK] webkit://gpu should print runtime libwpe and wpebackend-fdo versions
3149 https://bugs.webkit.org/show_bug.cgi?id=224298
3151 Reviewed by Adrian Perez de Castro.
3153 * Source/cmake/OptionsGTK.cmake:
3155 2021-04-07 Don Olmstead <don.olmstead@sony.com>
3157 [CMake] Mark _LIBRARY not _LIBRARIES in find modules
3158 https://bugs.webkit.org/show_bug.cgi?id=224283
3160 Reviewed by Michael Catanzaro.
3162 A few find modules are erroniously sending _LIBRARIES to mark_as_advanced rather than
3163 _LIBRARY. The former is created from the _LIBRARY value so it isn't valid at that point.
3165 * Source/cmake/FindCairo.cmake:
3166 * Source/cmake/FindFontconfig.cmake:
3167 * Source/cmake/FindSQLite3.cmake:
3169 2021-04-07 Kimmo Kinnunen <kkinnunen@apple.com>
3171 .gitignore contains 'build/' which causes all directories named 'build/' to be ignored
3172 https://bugs.webkit.org/show_bug.cgi?id=224227
3174 Reviewed by Ryosuke Niwa.
3176 Remove 'build/' from .gitignore, it was causing errors by hiding files.
3177 WebGL conformance test suite files have directiories with 'build/' in its path.
3179 Most likely '/build/' is not a common build directory, since the scripts
3180 seem to default to '/WebKitBuild/'.
3184 2021-04-06 Philippe Normand <pnormand@igalia.com>
3186 REGRESSION(r275275): Broke some build configs lacking openh264
3187 https://bugs.webkit.org/show_bug.cgi?id=224244
3189 Unreviewed, manual revert of r275275 and r275409.
3191 * Source/CMakeLists.txt:
3192 * Source/cmake/GStreamerChecks.cmake:
3194 2021-04-06 Mark Lam <mark.lam@apple.com>
3196 Speculative build fix for Windows port.
3197 https://bugs.webkit.org/show_bug.cgi?id=224243
3200 Reviewed by Saam Barati.
3202 Source/cmake/tools/scripts/auto-version.pl was limiting our `minor` and `micro`
3203 version to only 2 decimal digits only. In practice, we can use up to 3 digits.
3205 * Source/cmake/tools/scripts/auto-version.pl:
3208 2021-04-05 Alex Christensen <achristensen@webkit.org>
3210 Resurrect Mac CMake build
3211 https://bugs.webkit.org/show_bug.cgi?id=224084
3213 Reviewed by Tim Horton.
3215 * Source/cmake/OptionsMac.cmake:
3217 2021-04-05 Tyler Wilcock <twilco.o@protonmail.com>
3219 Document how to use logging in WebKit
3220 https://bugs.webkit.org/show_bug.cgi?id=224152
3222 Reviewed by Simon Fraser.
3224 Add documentation about how to use logging in WebKit.
3228 2021-03-28 David Kilzer <ddkilzer@apple.com>
3230 Compile WebKit with UBSan
3231 <https://webkit.org/b/176131>
3232 <rdar://problem/34174018>
3234 Reviewed by Alexey Proskuryakov.
3237 - Add support for "UBSAN=YES" argument to make.
3239 2021-03-27 Philippe Normand <pnormand@igalia.com>
3241 REGRESSION(r275111) [GLIB] Fix build with new derived sources and forwarding headers scheme
3242 https://bugs.webkit.org/show_bug.cgi?id=223834
3244 Unreviewed build fix.
3246 * Source/cmake/OptionsGTK.cmake:
3247 * Source/cmake/OptionsWPE.cmake:
3249 2021-03-26 Lauro Moura <lmoura@igalia.com>
3251 REGRESSION(r275111) [GLIB] Fix build with new derived sources and forwarding headers scheme
3252 https://bugs.webkit.org/show_bug.cgi?id=223834
3254 Unreviewed build fix.
3256 Buildfix for now. Actual removal of older scheme will come in the
3259 * Source/cmake/OptionsWPE.cmake: Add some missing variables with the
3260 per framework source and header dirs.
3262 2021-03-26 Don Olmstead <don.olmstead@sony.com>
3264 [CMake] Deprecate using DERIVED_SOURCES_DIR/FOWARDING_HEADERS_DIR directly
3265 https://bugs.webkit.org/show_bug.cgi?id=223763
3267 Reviewed by Michael Catanzaro.
3269 Remove any usages of DERIVED_SOURCES_DIR and FOWARDING_HEADERS_DIR. There are still some
3270 uses in GTK/WPE but those should be phased out.
3272 Sets the directory structure to look like an Apple build in terms of where headers and
3273 derived sources are held. Rather than having one root derived sources and one root
3274 header directory those directories are now per project. This helps catch any errors with
3277 Deletes some old Mac CMake code that is no longer relevant around creating forwarding
3280 For AppleWin the old structure is used because of its internal build which assumes the
3283 * Source/cmake/OptionsAppleWin.cmake:
3284 * Source/cmake/OptionsFTW.cmake:
3285 * Source/cmake/OptionsGTK.cmake:
3286 * Source/cmake/OptionsPlayStation.cmake:
3287 * Source/cmake/OptionsWPE.cmake:
3288 * Source/cmake/OptionsWinCairo.cmake:
3289 * Source/cmake/WebKitCommon.cmake:
3290 * Source/cmake/WebKitFS.cmake:
3291 * Source/cmake/WebKitMacros.cmake:
3293 2021-03-23 Adrian Perez de Castro <aperez@igalia.com>
3295 [CMake] Use an imported target for the LCMS2 library
3296 https://bugs.webkit.org/show_bug.cgi?id=223442
3298 Reviewed by Carlos Garcia Campos.
3300 * Source/cmake/FindLCMS2.cmake: Replaced find module by a new one which
3301 defines a LCMS2::LCMS2 imported target and in general uses more modern CMake
3304 2021-03-23 Cameron McCormack <heycam@apple.com>
3306 Update .clang-format to reflect WebKit style better.
3307 https://bugs.webkit.org/show_bug.cgi?id=223229
3309 First, SpaceBeforeCpp11BracedList is set to true so that a space
3310 is introduced after a variable name and before a braced initializer.
3312 Second, AlwaysBreakTemplateDeclarations is changed from false (an
3313 invalid value) to No, which should result in no line breaks being
3314 introduced in template declarations. Although there is a mix of
3315 template declaration line breaking styles in the codebase, changing
3316 this option to No will prevent clang-format from introducing one
3317 where the patch author decides to write the declaration all on one
3320 Reviewed by Alex Christensen.
3324 2021-03-22 Adrian Perez de Castro <aperez@igalia.com>
3326 [CMake] Wrong variable used in FindFontconfig used to pick version from pkg-config
3327 https://bugs.webkit.org/show_bug.cgi?id=223557
3329 Reviewed by Michael Catanzaro.
3331 * Source/cmake/FindFontconfig.cmake: Fix to use ${PC_FONTCONFIG_VERSION}.
3333 2021-03-18 Carlos Garcia Campos <cgarcia@igalia.com>
3335 [WPE] Bump API version when building with libsoup3
3336 https://bugs.webkit.org/show_bug.cgi?id=223437
3338 Reviewed by Adrian Perez de Castro.
3340 Use 1.1 as the API version when building with soup3.
3342 * Source/PlatformWPE.cmake:
3343 * Source/cmake/OptionsWPE.cmake:
3345 2021-03-17 Martin Robinson <mrobinson@igalia.com>
3347 [GTK][WPE] Enable CSS scroll snap support by default
3348 https://bugs.webkit.org/show_bug.cgi?id=222641
3350 Reviewed by Carlos Garcia Campos.
3352 * Source/cmake/OptionsGTK.cmake: Enable CSS scroll snap by default.
3353 * Source/cmake/OptionsWPE.cmake: Ditto.
3355 2021-03-16 Khem Raj <raj.khem@gmail.com>
3357 [CMake] Build fails on RISC-V with GCC 11
3358 https://bugs.webkit.org/show_bug.cgi?id=222959
3360 Reviewed by Carlos Alberto Lopez Perez.
3362 Check for 1 byte atomic operations along with 64bit ones, some
3363 architevtures (e.g. RISCV) operations on less than 4 bytes are not lock-free
3365 * Source/cmake/WebKitCompilerFlags.cmake:
3367 2021-03-14 Lauro Moura <lmoura@igalia.com>
3369 [GLIB] Keep GPUProcess disabled when using experimental features
3370 https://bugs.webkit.org/show_bug.cgi?id=223155
3372 Reviewed by Philippe Normand.
3374 At least two recent GPUProcess-related revisions caused issues in
3375 GLIB, causing serious regressions in the bots. Disabling it for now
3376 until we improve its support.
3380 r274327 - 2D Canvas enabled by default in GPUProcess
3381 r272842 - Media enabled by default in GPUProcess
3383 * Source/cmake/OptionsGTK.cmake:
3384 * Source/cmake/OptionsWPE.cmake:
3386 2021-03-12 Carlos Garcia Campos <cgarcia@igalia.com>
3388 [GTK] Bump API version when building with libsoup3
3389 https://bugs.webkit.org/show_bug.cgi?id=223067
3391 Reviewed by Adrian Perez de Castro.
3393 Use 4.1 as the API version when building with soup3 and keep using 5.0 for GTK4. Also make it impossible to
3394 build with GTK4 and soup2.
3396 * Source/PlatformGTK.cmake:
3397 * Source/cmake/OptionsGTK.cmake:
3399 2021-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
3401 Unreviewed. [GTK][WPE] Bump libsoup3 version to 2.99.3
3403 * Source/cmake/OptionsGTK.cmake:
3404 * Source/cmake/OptionsWPE.cmake:
3406 2021-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
3408 [WPE][GTK] Add support for ICC color management
3409 https://bugs.webkit.org/show_bug.cgi?id=177185
3411 Reviewed by Adrian Perez de Castro.
3413 Add optional lcms2 dependency.
3415 * Source/cmake/FindLCMS2.cmake: Added.
3416 * Source/cmake/OptionsGTK.cmake:
3417 * Source/cmake/OptionsWPE.cmake:
3419 2021-03-10 Michael Catanzaro <mcatanzaro@gnome.org>
3421 [GTK] Reenable -fvisibility=hidden
3422 https://bugs.webkit.org/show_bug.cgi?id=181916
3424 Reviewed by Don Olmstead.
3426 In non-DEVELOPER_MODE builds, we rely on a linker version script to hide symbols that we
3427 don't want to export. Building with hidden visibility might seem redundant with this, but
3428 actually building with hidden visibility has advantages anyway. See
3429 https://gcc.gnu.org/wiki/Visibility.
3431 Note that I'm not confident GTK port can safely use -fvisibility-inlines-hidden, since it's
3432 split between two shared objects. Also, because GTK is split into two shared objects, GTK
3433 needs to build bmalloc and WTF as CMake OBJECT libraries, which is effectively the same as
3434 using -Wl,--whole-archive to prevent symbols from being prematurely stripped away.
3436 P.S. Major credit to Don Olmstead, who did most of the work to make this possible, which has
3437 already landed in previous patches.
3439 * Source/cmake/OptionsGTK.cmake:
3441 2021-03-10 Commit Queue <commit-queue@webkit.org>
3443 Unreviewed, reverting r274166.
3444 https://bugs.webkit.org/show_bug.cgi?id=223024
3446 Broke GTK Debug builds
3450 "[GTK] Reenable -fvisibility=hidden"
3451 https://bugs.webkit.org/show_bug.cgi?id=181916
3452 https://trac.webkit.org/changeset/274166
3454 2021-03-09 Don Olmstead <don.olmstead@sony.com>
3456 GLib JSC API headers should only include other GLib JSC API headers
3457 https://bugs.webkit.org/show_bug.cgi?id=222803
3459 Reviewed by Michael Catanzaro.
3461 GTK and WPE both build the JavaScriptCore GLib API. However they diverged with their CMake
3462 variable names for the directory containing jsc. Declare a single variable for that
3463 directory, DERIVED_SOURCES_JAVASCRIPTCORE_GLIB_DIR, that is shared between GLib ports.
3465 Remove the GLIB_API_DIR variant which will just be replaced with
3466 ${DERIVED_SOURCES_JAVASCRIPTCORE_GLIB_DIR}/jsc in the CMake code.
3468 * Source/cmake/OptionsGTK.cmake:
3469 * Source/cmake/OptionsWPE.cmake:
3471 2021-03-09 Michael Catanzaro <mcatanzaro@gnome.org>
3473 [GTK] Reenable -fvisibility=hidden
3474 https://bugs.webkit.org/show_bug.cgi?id=181916
3476 Reviewed by Don Olmstead.
3478 In non-DEVELOPER_MODE builds, we rely on a linker version script to hide symbols that we
3479 don't want to export. Building with hidden visibility might seem redundant with this, but
3480 actually building with hidden visibility has advantages anyway. See
3481 https://gcc.gnu.org/wiki/Visibility.
3483 Note that I'm not confident GTK port can safely use -fvisibility-inlines-hidden, since it's
3484 split between two shared objects. Also, because GTK is split into two shared objects, GTK
3485 needs to build bmalloc and WTF as CMake OBJECT libraries, which is effectively the same as
3486 using -Wl,--whole-archive to prevent symbols from being prematurely stripped away.
3488 P.S. Major credit to Don Olmstead, who did most of the work to make this possible, which has
3489 already landed in previous patches.
3491 * Source/cmake/OptionsGTK.cmake:
3493 2021-03-05 Michael Catanzaro <mcatanzaro@gnome.org>
3495 [GTK] Remove ADD_WHOLE_ARCHIVE_TO_LIBRARIES
3496 https://bugs.webkit.org/show_bug.cgi?id=222826
3498 Reviewed by Don Olmstead.
3500 I don't know why it's no longer needed, but GTK links without it, so it can go away.
3502 * Source/cmake/OptionsGTK.cmake:
3504 2021-03-05 Don Olmstead <don.olmstead@sony.com>
3506 [CMake] Bump cmake_minimum_required version to 3.12 or later
3507 https://bugs.webkit.org/show_bug.cgi?id=221727
3508 <rdar://problem/74454980>
3510 Reviewed by Konstantin Tokarev.
3512 Updates the minimum version to 3.12. In CMake 3.12 OBJECT library functionality was
3513 expanded to the point where they can successfully be used as a replacement for
3514 --whole-archive within WebKit. The check in JSCOnly for the minimum version before
3515 using hidden visibility was removed accordingly.
3518 * Source/cmake/OptionsJSCOnly.cmake:
3520 2021-03-05 ChangSeok Oh <changseok@webkit.org>
3522 AVIF decoding support
3523 https://bugs.webkit.org/show_bug.cgi?id=207750
3525 Reviewed by Philippe Normand.
3527 This patch brings an initial support of AVIF image format to the gtk port.
3528 AVIF is a new royalty-free image format derived from the keyframes of AV1 video.
3529 FireFox and Chromium-variant browsers already support it. Its specification can be found
3530 at https://rawcdn.githack.com/AOMediaCodec/av1-avif/67a92add6cd642a8863e386fa4db87954a6735d1/index.html
3531 This patch aims to land a build option for AVIF and a basic decoding ability
3532 for still images by using libavif. Animated AVIF images will be covered later.
3534 * Source/cmake/FindAVIF.cmake: Added to find libavif.
3535 * Source/cmake/OptionsGTK.cmake: A build option, USE_AVIF is added.
3537 2021-03-03 Commit Queue <commit-queue@webkit.org>
3539 Unreviewed, reverting r273814.
3540 https://bugs.webkit.org/show_bug.cgi?id=222676
3542 Unresolved types in JavaScriptCore-4.0.gir
3546 "[CMake] JavaScriptCore GLib headers should be copies"
3547 https://bugs.webkit.org/show_bug.cgi?id=222625
3548 https://trac.webkit.org/changeset/273814
3550 2021-03-03 Don Olmstead <don.olmstead@sony.com>
3552 [CMake] JavaScriptCore GLib headers should be copies
3553 https://bugs.webkit.org/show_bug.cgi?id=222625
3555 Reviewed by Michael Catanzaro.
3557 Specify the directories for JavaScriptCore GLib headers and derived sources.
3559 * Source/cmake/OptionsGTK.cmake:
3560 * Source/cmake/OptionsWPE.cmake:
3562 2021-03-01 Per Arne <pvollan@apple.com>
3564 [Win] Fix build failure
3565 https://bugs.webkit.org/show_bug.cgi?id=222576
3566 <rdar://problem/74590803>
3567 Reviewed by Brent Fulgham.
3569 It appears a recent change has unintentionally enabled WebInspectorUI on Apple Win. Address this by explicitly disabling it.
3571 * Source/cmake/OptionsAppleWin.cmake:
3573 2021-02-26 Carlos Garcia Campos <cgarcia@igalia.com>
3575 Unreviewed. [GTK] Bump version numbers
3577 * Source/cmake/OptionsGTK.cmake:
3579 2021-02-26 Imanol Fernandez <ifernandez@igalia.com>
3581 Implement OpenXR port graphics binding
3582 https://bugs.webkit.org/show_bug.cgi?id=222173
3584 Reviewed by Sergio Villar Senin.
3586 Enable OpenXR defines required for EGL graphics binding.
3588 * Source/cmake/OptionsWPE.cmake:
3590 2021-02-26 Carlos Garcia Campos <cgarcia@igalia.com>
3592 [GTK][WPE] Bump libsoup3 version to 2.99.1
3593 https://bugs.webkit.org/show_bug.cgi?id=222413
3595 Reviewed by Adrian Perez de Castro.
3597 * Source/cmake/OptionsGTK.cmake:
3598 * Source/cmake/OptionsWPE.cmake:
3600 2021-02-24 Cameron McCormack <heycam@apple.com>
3602 Fix typo in Introduction.md.
3603 https://bugs.webkit.org/show_bug.cgi?id=222387
3605 Reviewed by Ryosuke Niwa.
3609 2021-02-23 Don Olmstead <don.olmstead@sony.com>
3611 [CMake] Fix JSCOnly build on Windows
3612 https://bugs.webkit.org/show_bug.cgi?id=222316
3614 Reviewed by Michael Catanzaro.
3616 Turn off ENABLE_WEBASSEMBLY for Windows on JSCOnly now that its possible to build it
3619 * Source/cmake/OptionsJSCOnly.cmake:
3621 2021-02-22 Carlos Garcia Campos <cgarcia@igalia.com>
3623 [SOUP] Add support for libsoup3
3624 https://bugs.webkit.org/show_bug.cgi?id=222093
3626 Reviewed by Adrian Perez de Castro.
3628 * Source/cmake/FindLibSoup.cmake:
3629 * Source/cmake/OptionsGTK.cmake:
3630 * Source/cmake/OptionsWPE.cmake:
3632 2021-02-18 Martin Robinson <mrobinson@igalia.com>
3634 [GTK][WPE] Implement support for CSS Scroll Snap
3635 https://bugs.webkit.org/show_bug.cgi?id=203684
3637 Reviewed by Carlos Garcia Campos.
3639 Add initial support for css-scroll-snap on WebKitGTK+ and WebKitWPE. This
3640 adds support for all types of scroll snapping that WebKit supports apart
3641 from mouse wheel snapping. Support for that will be added in a followup
3644 * Source/cmake/OptionsGTK.cmake: Enable scroll snapping when experimental features
3646 * Source/cmake/OptionsWPE.cmake: Ditto.
3648 2021-02-16 Tim Horton <timothy_horton@apple.com>
3650 Local macCatalyst builds should not build WebInspectorUI
3651 https://bugs.webkit.org/show_bug.cgi?id=221992
3653 Reviewed by Wenson Hsieh.
3656 This project is not used in macCatalyst, and is not even built in production builds.
3657 We should stop building it in local release/debug builds as well.
3659 2021-02-11 Don Olmstead <don.olmstead@sony.com>
3661 [CMake] WEBKIT_EXECUTABLE can incorrectly link framework
3662 https://bugs.webkit.org/show_bug.cgi?id=221703
3664 Reviewed by Michael Catanzaro.
3666 After r272484 which added an additional test for TestJavaScriptCore the PlayStation build
3667 began failing with an unresolved symbol in bmalloc. On PlayStation both WTF and bmalloc
3668 are linked into JavaScriptCore. That library was building successfully which implied that
3669 WTF was being erroniously linked into TestJavaScriptCore.
3671 Inside _WEBKIT_EXECUTABLE_LINK_FRAMEWORK there was an invalid conditional which was causing
3672 WTF to be linked. Fixed the logic to ensure that if the requested framework is linked into
3673 another framework that is being linked then it is not added to the linker.
3675 * Source/cmake/WebKitMacros.cmake:
3677 2021-02-10 Don Olmstead <don.olmstead@sony.com>
3679 [CMake] Enable hidden visibility on JSCOnly
3680 https://bugs.webkit.org/show_bug.cgi?id=221726
3682 Reviewed by Yusuke Suzuki.
3684 Turn on hidden visibility for all *NIX ports of JSCOnly. To properly export the symbols
3685 from WTF/bmalloc OBJECT libraries are used. This requires CMake 3.12 or later to
3688 * Source/cmake/OptionsJSCOnly.cmake:
3690 2021-02-10 Christopher Reid <chris.reid@sony.com>
3692 [PlayStation] Add initial RESOURCE_USAGE implementation
3693 https://bugs.webkit.org/show_bug.cgi?id=221706
3695 Reviewed by Ross Kirsling.
3697 * Source/cmake/OptionsPlayStation.cmake:
3699 2021-02-10 Philippe Normand <pnormand@igalia.com>
3701 [WPE] Optionally build Cog as external project and replacement for MiniBrowser
3702 https://bugs.webkit.org/show_bug.cgi?id=221518
3704 Reviewed by Adrian Perez de Castro.
3706 * Source/cmake/OptionsWPE.cmake: New variable for JSC forwarded headers path, useful
3707 uninstalled builds of projects depending on JSC.
3709 2021-02-09 Jonathan Bedard <jbedard@apple.com>
3711 AX: introduction.md broken architecture.png link
3712 https://bugs.webkit.org/show_bug.cgi?id=221607
3713 <rdar://problem/74140397>
3715 Reviewed by Sam Weinig.
3717 * Introduction.md: webkit2-process-architecture.png Moved to resources.
3719 2021-02-08 Alicia Boya García <aboya@igalia.com>
3721 ConsoleMessage: Don't encode string JSONLogValue's as JSON
3722 https://bugs.webkit.org/show_bug.cgi?id=221421
3724 Reviewed by Eric Carlson.
3726 Enable JavaScriptCore API tests.
3728 * Source/cmake/WebKitCommon.cmake:
3730 2021-02-05 Don Olmstead <don.olmstead@sony.com>
3732 [MSVC] Catalog warnings
3733 https://bugs.webkit.org/show_bug.cgi?id=199248
3735 Unreviewed build fix.
3737 Missed a warning generated when building AppleWin.
3739 * Source/cmake/OptionsMSVC.cmake:
3741 2021-02-05 Don Olmstead <don.olmstead@sony.com>
3743 [MSVC] Catalog warnings
3744 https://bugs.webkit.org/show_bug.cgi?id=199248
3746 Reviewed by Fujii Hironori.
3748 Catalog all the MSVC warnings providing the message and a link to documentation
3749 for the warning. Some warnings are noted as being against the style guide so they
3750 won't be addressed. All other warnings could potentially be fixed in the codebase.
3752 * Source/cmake/OptionsMSVC.cmake:
3754 2021-02-04 Adrian Perez de Castro <aperez@igalia.com>
3756 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.31.1 release
3758 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
3760 2021-02-04 Philippe Normand <pnormand@igalia.com>
3762 [GStreamer] Misc Thunder nitpicks
3763 https://bugs.webkit.org/show_bug.cgi?id=221398
3765 Reviewed by Xabier Rodriguez-Calvar.
3767 * Source/cmake/FindThunder.cmake: Look-up Thunder through pkg-config before attempting a
3768 direct libocdm lookup.
3770 2021-02-01 Saam Barati <sbarati@apple.com>
3772 Lazily create m_windowCloseWatchpoints so we don't mistakenly think we have a frame when re-associating a document to a given cached frame
3773 https://bugs.webkit.org/show_bug.cgi?id=221098
3776 Reviewed by Ryosuke Niwa and Mark Lam.
3778 * ManualTests/dont-create-invalid-watchpoint-when-going-back.html: Added.
3779 * ManualTests/resources/empty-text.txt: Added.
3780 * ManualTests/resources/full_results.json: Added.
3781 * ManualTests/resources/test-results-page.html: Added.
3783 2021-02-01 Don Olmstead <don.olmstead@sony.com>
3785 [Curl] Enable FTP protocol only when ENABLE_FTPDIR is on
3786 https://bugs.webkit.org/show_bug.cgi?id=220941
3788 Reviewed by Fujii Hironori.
3790 Turn off ENABLE_FTPDIR for WinCairo. The version of cURL used has FTP support explicitly
3793 * Source/cmake/OptionsWin.cmake:
3795 2021-01-27 Yusuke Suzuki <ysuzuki@apple.com>
3797 WebAssembly: add support for stream APIs
3798 https://bugs.webkit.org/show_bug.cgi?id=173105
3800 Reviewed by Keith Miller.
3802 * Source/cmake/OptionsFTW.cmake:
3803 * Source/cmake/WebKitFeatures.cmake:
3805 2021-01-27 Angelos Oikonomopoulos <angelos@igalia.com>
3807 Set ruby-indent-level to 4
3808 https://bugs.webkit.org/show_bug.cgi?id=220982
3810 Reviewed by Fujii Hironori.
3812 All the ruby source files seem to default to 4 as the indent
3813 level; make it official.
3818 2021-01-23 Xan Lopez <xan@igalia.com>
3820 [JSC] Allow to build WebAssembly without B3
3821 https://bugs.webkit.org/show_bug.cgi?id=220365
3823 Reviewed by Yusuke Suzuki.
3825 Make the WebAssembly feature depend on Baseline JIT, not B3
3826 JIT. Also add a WEBASSEMBLY_B3JIT feature to enable or disable the
3827 B3 tier in WebAssembly.
3829 * Source/cmake/WebKitFeatures.cmake: disable on 32bit.
3831 2021-01-21 Fujii Hironori <Hironori.Fujii@sony.com>
3833 Remove ENABLE_USERSELECT_ALL macro which is enabled for all ports
3834 https://bugs.webkit.org/show_bug.cgi?id=100424
3836 Reviewed by Don Olmstead.
3838 * Source/cmake/OptionsMac.cmake:
3839 * Source/cmake/WebKitFeatures.cmake:
3841 2021-01-20 Yusuke Suzuki <ysuzuki@apple.com>
3843 Unreviewed, ANGLE should not be built in JSCOnly port
3845 ANGLE is not a part of JSC. Do not build it.
3847 * Source/cmake/OptionsJSCOnly.cmake:
3849 2021-01-19 Lauro Moura <lmoura@igalia.com>
3851 REGRESSION(r271580) [GTK] LTS/Debian build failure due to unsupported g-ir-scanner parameter
3852 https://bugs.webkit.org/show_bug.cgi?id=220730
3854 Reviewed by Philippe Normand.
3856 * Source/cmake/FindGObjectIntrospection.cmake: Expose variable about the
3857 presence of --sources-top-dirs.
3859 2021-01-14 Jonathan Bedard <jbedard@apple.com>
3861 [GitHub] Reference GitHub repository in readme
3862 https://bugs.webkit.org/show_bug.cgi?id=220611
3863 <rdar://problem/73173367>
3865 Reviewed by Aakash Jain.
3867 * ReadMe.md: Reference GitHub repository.
3869 2021-01-12 Fujii Hironori <Hironori.Fujii@sony.com>
3871 [PlayStation] Enable ENABLE_USERSELECT_ALL for -webkit-user-select:all support
3872 https://bugs.webkit.org/show_bug.cgi?id=220533
3874 Reviewed by Don Olmstead.
3876 * Source/cmake/OptionsPlayStation.cmake: Removed the line disabling ENABLE_USERSELECT_ALL.
3878 2021-01-12 Philippe Normand <pnormand@igalia.com>
3880 [GStreamer] Bump version requirement
3881 https://bugs.webkit.org/show_bug.cgi?id=220356
3883 Reviewed by Xabier Rodriguez-Calvar.
3885 * Source/cmake/GStreamerChecks.cmake: Bump required version to 1.14.
3887 2021-01-12 Xabier Rodriguez Calvar <calvaris@igalia.com>
3889 [GStreamer] Switch from ENABLE_ to USE_ in native audio/video and text sink options
3890 https://bugs.webkit.org/show_bug.cgi?id=220515
3892 Reviewed by Philippe Normand.
3894 * Source/cmake/GStreamerDefinitions.cmake: Add USE_ definitions.
3895 * Source/cmake/WebKitFeatures.cmake: Remove global ENABLE_
3898 2021-01-12 Carlos Garcia Campos <cgarcia@igalia.com>
3900 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.31.1 release
3902 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
3904 2021-01-11 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com>
3906 [PlayStation] Add MiniBrowser
3907 https://bugs.webkit.org/show_bug.cgi?id=220359
3909 Reviewed by Don Olmstead.
3911 Enable Fullscreen API.
3913 * Source/cmake/OptionsPlayStation.cmake:
3915 2021-01-11 Xabier Rodriguez Calvar <calvaris@igalia.com>
3917 [GStreamer] Add support to build with native audio and video
3918 https://bugs.webkit.org/show_bug.cgi?id=220087
3920 Reviewed by Philippe Normand.
3922 * Source/cmake/GStreamerDefinitions.cmake: Enable TEXT_SINK.
3923 * Source/cmake/WebKitFeatures.cmake: Declare TEXT_SINK, NATIVE_VIDEO and NATIVE_AUDIO.
3925 2021-01-08 Ryan Hostetler <rhost@apple.com>
3927 Add support for source caching between platforms
3928 https://bugs.webkit.org/show_bug.cgi?id=220439
3931 Reviewed by Andy Estes.
3933 Include WebInspectorUI Source during any installsrc phase.
3937 2021-01-08 Fujii Hironori <Hironori.Fujii@sony.com>
3939 [Win] Enable ENABLE_USERSELECT_ALL for -webkit-user-select:all support
3940 https://bugs.webkit.org/show_bug.cgi?id=118740
3942 Reviewed by Don Olmstead.
3944 This change also fixes the assertion failure of
3945 editing/inserting/insert-list-user-select-none-crash.html
3948 * Source/cmake/OptionsFTW.cmake: Removed the line disabling ENABLE_USERSELECT_ALL.
3949 * Source/cmake/OptionsWin.cmake: Ditto.
3951 2021-01-07 Ryan Hostetler <rhost@apple.com>
3953 make clean/installsrc fail: You cannot specify -alltargets and also specify individual targets.
3954 https://bugs.webkit.org/show_bug.cgi?id=220370
3957 Reviewed by Andy Estes.
3959 Update hardcoded '-alltargets' to use new XCODE_TARGET variable.
3963 2021-01-07 Monson Shao <holymonson@gmail.com>
3965 [CMake] Add USE_APPLE_ICU option
3966 https://bugs.webkit.org/show_bug.cgi?id=220081
3968 Reviewed by Yusuke Suzuki.
3970 Add USE_APPLE_ICU option to allow non-Mac ports (GTK or JSCOnly) on Darwin could build with
3973 * Source/cmake/OptionsCommon.cmake:
3974 * Source/cmake/WebKitFindPackage.cmake:
3976 2021-01-06 Alexey Proskuryakov <ap@apple.com>
3978 Make svn status ignore Python 3 __pycache__ directories.
3982 Python 2 *.pyc files are still inconsistently handled via svn:ignore on each
3983 directory, but it is not worth cleaning up before GitHub move.
3985 * Tools: Added property svn:global-ignores.
3987 2021-01-06 Fujii Hironori <Hironori.Fujii@sony.com>
3989 [GTK][CMake] Add a build switch USE_OPENGL_OR_ES to be able to disable OpenGL and ES
3990 https://bugs.webkit.org/show_bug.cgi?id=220183
3992 Reviewed by Kenneth Russell.
3994 r270477 removed ENABLE_GRAPHICS_CONTEXT_GL macro and build switch,
3995 but GTK port still needs the build switch. Revert r270477
3996 partially to restore the build switch and rename it to
3999 * Source/cmake/OptionsGTK.cmake:
4001 2021-01-05 Fujii Hironori <Hironori.Fujii@sony.com>
4003 [WinCairo][curl] Enable CURLSSLOPT_NATIVE_CA flag to use system's CA certs instead of cacert.pem
4004 https://bugs.webkit.org/show_bug.cgi?id=220258
4006 Reviewed by Don Olmstead.
4008 Libcurl 7.71 added a new flag CURLSSLOPT_NATIVE_CA to use the
4009 operating system's native CA store only for Windows. Use the flag
4012 * Source/cmake/OptionsWinCairo.cmake: Bumped the minimum Curl version.
4014 2021-01-04 Lauro Moura <lmoura@igalia.com>
4016 [WebXR][WPE] Build fails without openxr installed
4017 https://bugs.webkit.org/show_bug.cgi?id=220250
4019 Reviewed by Carlos Alberto Lopez Perez.
4021 * Source/cmake/FindOpenXR.cmake: Fix some names and export
4023 * Source/cmake/OptionsWPE.cmake: Fail config is WebXR is enabled but
4024 couldn't find OpenXR.
4026 2021-01-04 Jeff Miller <jeffm@apple.com>
4028 Update user-visible copyright strings to include 2021
4029 https://bugs.webkit.org/show_bug.cgi?id=219901
4031 Reviewed by Anders Carlsson.
4033 * Source/cmake/tools/scripts/COPYRIGHT-END-YEAR:
4035 2020-12-23 Fujii Hironori <Hironori.Fujii@sony.com>
4037 [WinCairo] Enable WebGL 2
4038 https://bugs.webkit.org/show_bug.cgi?id=192314
4040 Reviewed by Kenneth Russell.
4042 * Source/cmake/OptionsWin.cmake: Turned ENABLE_WEBGL2 on.
4044 2020-12-23 Monson Shao <holymonson@gmail.com>
4046 [CMake] Fix seperated include dir of harfbuzz and harfbuzz-icu
4047 https://bugs.webkit.org/show_bug.cgi?id=220082
4049 Reviewed by Alex Christensen.
4051 In some distros (NixOS) harfbuzz and harfbuzz-icu may have different include dir.
4053 * Source/cmake/FindHarfBuzz.cmake:
4055 2020-12-21 Ryan Hostetler <rhost@apple.com>
4057 $(findstring iphone,$(SDKROOT)) fails when SDKROOT is not lowercase
4058 https://bugs.webkit.org/show_bug.cgi?id=219993
4061 Reviewed by Darin Adler.
4063 Update SDKROOT evaluation to be lowercase and SDK filename only.
4067 2020-12-16 Fujii Hironori <Hironori.Fujii@sony.com>
4069 [WinCairo] Enable USE_ANGLE
4070 https://bugs.webkit.org/show_bug.cgi?id=219421
4072 Reviewed by Don Olmstead.
4074 * Source/cmake/OptionsWinCairo.cmake:
4076 2020-12-13 Don Olmstead <don.olmstead@sony.com>
4078 [CMake] Version of LibPSL not reported
4079 https://bugs.webkit.org/show_bug.cgi?id=219837
4081 Reviewed by Adrian Perez de Castro.
4083 When determining the version of LibPSL from the header file LIBPSL_VERSION was set
4084 but the VERSION_VAR reported was LibPSL_VERSION. Consistently use LibPSL_VERSION
4085 within the file to prevent this.
4087 Additionally LibPSL_LIBRARY not LibPSL_LIBRARIES should be marked_as_advanced.
4089 * Source/cmake/FindLibPSL.cmake:
4091 2020-12-11 Don Olmstead <don.olmstead@sony.com>
4093 [CMake] Determine correct visibility for linked frameworks
4094 https://bugs.webkit.org/show_bug.cgi?id=210366
4096 Reviewed by Michael Catanzaro.
4098 WebKit has some frameworks that are compiled statically into a larger shared library. For
4099 example Apple compiles bmalloc and WTF into JavaScriptCore. This means the JavaScriptCore
4100 framework also exposes the symbols for those two libraries and that targets depending
4101 on WTF or bmalloc should link to JavaScriptCore and never to WTF or bmalloc directly.
4103 The CMake code allows each port to decide the type of library for a WEBKIT_FRAMEWORK.
4104 This means there are many different combinations that it needs to support. To ensure that
4105 everything links properly some bookkeeping is required.
4107 WEBKIT_FRAMEWORK now uses ${target}_FRAMEWORKS to determine how to link the frameworks
4108 it depends on. First the macro determines if the framework is a SHARED library or is linked
4109 into a shared library, and if so it is linked as PUBLIC. If the framework itself is not a
4110 SHARED library, then it links other STATIC/OBJECT framework as PUBLIC. If the framework
4111 itself is SHARED then any framework that is a STATIC/OBJECT library is linked as PRIVATE
4112 to stop propagation. The linked framework's header directories are added to the
4113 WebKit::${framework} target to allow the framework to present as that framework. A global
4114 property is set to inform consumers that they should link to this different framework
4115 to get the requested framework.
4117 This ensures that all ports can ship with hidden visibility turned on which is a precursor
4118 to a port turning on link time optimization (LTO).
4120 * Source/cmake/WebKitMacros.cmake:
4122 2020-12-10 Don Olmstead <don.olmstead@sony.com>
4124 [CMake] Determine when to use $<TARGET_OBJECTS> for executables
4125 https://bugs.webkit.org/show_bug.cgi?id=219648
4127 Reviewed by Michael Catanzaro.
4129 When a WebKit framework is declared as an OBJECT library the WebKit::${framework} ALIAS
4130 does not propagate the objects to the executable being built. As a workaround ports will
4131 explicitly add $<TARGET_OBJECTS> to the list of libraries being linked. There is already
4132 enough information to determine when $<TARGET_OBJECTS> is needed so this decision is moved
4133 into the WEBKIT_EXECUTABLE macros.
4135 An additional ${taget_name}_FRAMEWORKS variable is added which specifies the WebKit
4136 frameworks being used. This will link the WebKit::${framework} alias and if necessary the
4137 associated $<TARGET_OBJECTS>.
4139 This functionality will be expanded upon when support for ${target_name}_FRAMEWORKS is
4140 added to WebKit frameworks to support hidden visibility across ports.
4142 * Source/cmake/WebKitMacros.cmake:
4144 2020-12-07 Don Olmstead <don.olmstead@sony.com>
4146 [CMake] Remove WEBKIT_WRAP_SOURCELIST
4147 https://bugs.webkit.org/show_bug.cgi?id=196916
4149 Reviewed by Michael Catanzaro.
4151 WEBKIT_WRAP_SOURCELIST macro is used only to adjust source groups in Visual Studio
4152 projects without any impact on build process. Its references variable specific to
4153 particular targets (WebCore) which contradicts our goal of having target-oriented
4154 CMake project. It can be reintroduced later in a more clean way, in case anyone needs
4155 to have such grouping.
4157 * Source/cmake/WebKitMacros.cmake:
4159 2020-12-05 Fujii Hironori <Hironori.Fujii@sony.com>
4161 Remove ENABLE_GRAPHICS_CONTEXT_GL by replacing it with ENABLE(WEBGL)
4162 https://bugs.webkit.org/show_bug.cgi?id=219551
4164 Reviewed by Kenneth Russell.
4166 * Source/CMakeLists.txt:
4167 * Source/cmake/GStreamerDependencies.cmake:
4168 * Source/cmake/OptionsFTW.cmake:
4169 * Source/cmake/OptionsGTK.cmake:
4170 * Source/cmake/OptionsMac.cmake:
4171 * Source/cmake/OptionsPlayStation.cmake:
4172 * Source/cmake/OptionsWPE.cmake:
4173 * Source/cmake/OptionsWinCairo.cmake:
4175 2020-11-26 Lauro Moura <lmoura@igalia.com>
4177 [GTK][GTK4] Building with GObject-Introspection support does not work
4178 https://bugs.webkit.org/show_bug.cgi?id=219221
4180 Reviewed by Carlos Garcia Campos.
4182 * Source/cmake/OptionsGTK.cmake: Allow introspection with GTK4.
4184 2020-11-26 Fujii Hironori <Hironori.Fujii@sony.com>
4186 [WinCairo] Enable GPU process
4187 https://bugs.webkit.org/show_bug.cgi?id=219294
4189 Reviewed by Don Olmstead.
4191 * Source/cmake/OptionsWin.cmake: Turned ENABLE_GPU_PROCESS on for WinCairo.
4193 2020-11-26 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com>
4195 [PlayStation] Enable ResourceLoadStatistics
4196 https://bugs.webkit.org/show_bug.cgi?id=219292
4198 Reviewed by Fujii Hironori.
4200 * Source/cmake/OptionsPlayStation.cmake:
4202 2020-11-20 Don Olmstead <don.olmstead@sony.com>
4205 https://bugs.webkit.org/show_bug.cgi?id=219206
4207 Reviewed by Anders Carlsson.
4209 Remove the ability to set ENABLE_QUOTA. The Storage Quota API is deprecated and no
4210 WebKit port is enabling it.
4212 * Source/cmake/OptionsFTW.cmake:
4213 * Source/cmake/OptionsWin.cmake:
4214 * Source/cmake/WebKitFeatures.cmake:
4215 * Source/cmake/tools/vsprops/FeatureDefines.props:
4216 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
4218 2020-11-09 Michael Catanzaro <mcatanzaro@gnome.org>
4220 Enable llint asm on aarch64 when USE(64KB_PAGE_BLOCK) is enabled
4221 https://bugs.webkit.org/show_bug.cgi?id=218613
4223 Reviewed by Carlos Alberto Lopez Perez.
4225 Normally we fall back to cloop when JIT is not supported. But on aarch64, llint asm is well-
4226 supported, so it is safe to use that here. This will only happen on aarch64, and only when
4227 USE(64KB_PAGE_BLOCK) is enabled, which should probably only be used by RHEL and SUSE.
4228 Everyone else should get the JIT.
4230 * Source/cmake/WebKitFeatures.cmake:
4232 2020-11-04 Sergey Rubanov <chi187@gmail.com>
4234 Fix JSC build on macOS Big Sur
4235 https://bugs.webkit.org/show_bug.cgi?id=218566
4237 Reviewed by David Kilzer.
4239 * Source/cmake/WebKitFindPackage.cmake:
4241 2020-11-04 Michael Catanzaro <mcatanzaro@gnome.org>
4243 Add new build option USE(64KB_PAGE_BLOCK)
4244 https://bugs.webkit.org/show_bug.cgi?id=217989
4246 Reviewed by Yusuke Suzuki.
4248 Why do we need this option? Because JSC and bmalloc both want to know the userspace page
4249 size at compile time, which is impossible on Linux because it's a runtime setting. We
4250 cannot test the system page size at build time in hopes that it will be the same on the
4251 target system, because (a) cross compiling wouldn't work, and (b) the build system could
4252 use a different page size than the target system (which will be true for Fedora aarch64,
4253 because Fedora is built using RHEL), so the best we can do is guess based on the target CPU
4254 architecture. In practice, guessing works for all architectures except aarch64 (unless
4255 unusual page sizes are used), but it fails for aarch64 because distros are split between
4256 using 4 KB and 64 KB pages there. Most distros (including Fedora) use 4 KB, but RHEL uses
4257 64 KB. SUSE actually supports both. Since there is no way to guess correctly, the best we
4258 can do is provide an option for it. You should probably only use this if building for
4259 aarch64. Otherwise, known CPUs except PowerPC will use 4 KB, while PowerPC and unknown CPUs
4260 will use 64 KB (see wtf/PageBlock.h). aarch64 will continue to default to 4 KB because this
4261 is a much better default on systems where it doesn't crash.
4263 Having one flag will help avoid mistakes. E.g. both RHEL and SUSE were manually passing
4264 -DENABLE_JIT=OFF and -DUSE_SYSTEM_MALLOC=ON, but we missed -DENABLE_C_LOOP=ON and
4265 -DENABLE_SAMPLING_PROFILER=OFF, so wound up running with both JIT and cloop disabled, a
4266 configuration not otherwise used on Linux (and not supported by GTK or WPE ports). It will
4267 be easier to not mess up if we only have to pass one special build option. This will also
4268 allow us to stop patching PageBlock.h downstream, because I don't like downstream patches
4269 that we have to keep forever.
4271 * Source/cmake/WebKitFeatures.cmake:
4273 2020-10-30 Ryosuke Niwa <rniwa@webkit.org>
4275 Add Introduction to WebKit
4276 https://bugs.webkit.org/show_bug.cgi?id=217017
4278 Rubber-stamped by Simon Fraser.
4280 Added the basic introductory documentation for WebKit.
4282 * Introduction.md: Added.
4283 * resources/js-wrapper.png: Added.
4284 * resources/webkit2-process-architecture.png: Added.
4285 * resources/xcode-add-file.png: Added.
4286 * resources/xcode-build-settings-for-run.png: Added.
4287 * resources/xcode-export-header.png: Added.
4288 * resources/xcode-scheme-dumprendertree.png: Added.
4289 * resources/xcode-scheme-layout-test.png: Added.
4290 * resources/xcode-workspace-build-location.png: Added.
4291 * resources/xcode-workspace-settings.png: Added.
4293 2020-10-30 Jonathan Bedard <jbedard@apple.com>
4295 Github mirror ReadMe need to update
4296 https://bugs.webkit.org/show_bug.cgi?id=218120
4297 <rdar://problem/70861595>
4299 Reviewed by Aakash Jain.
4303 2020-10-27 Keith Rollin <krollin@apple.com>
4305 Fix "usage" message when invoking `ar -V`
4306 https://bugs.webkit.org/show_bug.cgi?id=218255
4307 <rdar://problem/70735674>
4309 Reviewed by Fujii Hironori.
4311 The Mac/BSD version of `ar` does not support the -V flag. This flag is
4312 used unconditionally in OptionsCommon.cmake when trying to determine
4313 if the installed `ar` supports the thinning of archives, leading to a
4314 "usage" message being emitted on macOS.
4316 Avoid this message by capturing the error-output. Examine the output
4317 to see if it's a "usage" message. If so, then treat the `ar` as one
4318 that does not support thinning. Any other error-output is printed as a
4319 warning. If there is no error-output, continue processing as normal.
4321 * Source/cmake/OptionsCommon.cmake:
4323 2020-10-27 Brian Burg <bburg@apple.com>
4325 Web Inspector: add ENABLE(INSPECTOR_EXTENSIONS) to feature defines
4326 https://bugs.webkit.org/show_bug.cgi?id=218237
4327 <rdar://problem/69968787>
4329 Reviewed by Antti Koivisto.
4331 * Source/cmake/OptionsMac.cmake:
4332 * Source/cmake/WebKitFeatures.cmake:
4333 Add ENABLE(INSPECTOR_EXTENSIONS), which is only on for the Cocoa macOS port.
4335 2020-10-26 Keith Rollin <krollin@apple.com>
4337 Move some initialization code from top-level CMakeLists.txt to WebKitCommon.cmake
4338 https://bugs.webkit.org/show_bug.cgi?id=218069
4339 <rdar://problem/70556952>
4341 Reviewed by Fujii Hironori.
4343 Moving this initialization code into a central location allows other
4344 top-level CMakeLists.txt files to include WebKitCommon.cmake and get
4345 that same initialization.
4348 * Source/cmake/WebKitCommon.cmake:
4350 2020-10-23 Philippe Normand <pnormand@igalia.com>
4352 [GStreamer] Replace USE(WEBAUDIO_GSTREAMER) with USE(GSTREAMER)
4353 https://bugs.webkit.org/show_bug.cgi?id=218083
4355 Reviewed by Xabier Rodriguez-Calvar.
4357 A separate define was introduced back when we thought enabling WebAudio without enabling
4358 <audio> would be a highly relevant scenario. I don't think it is very relevant, let's clean
4361 * Source/cmake/GStreamerChecks.cmake: Wrap the WebAudio platform bits in the USE(GSTREAMER) umbrella.
4363 2020-10-21 Carlos Garcia Campos <cgarcia@igalia.com>
4365 WebDriver: add support for wheel actions
4366 https://bugs.webkit.org/show_bug.cgi?id=217174
4368 Reviewed by Brian Burg.
4370 Enable WEBDRIVER_WHEEL_INTERACTIONS for GTK and WPE ports.
4372 * Source/cmake/OptionsGTK.cmake:
4373 * Source/cmake/OptionsWPE.cmake:
4374 * Source/cmake/WebKitFeatures.cmake:
4376 2020-10-20 Michael Catanzaro <mcatanzaro@gnome.org>
4378 [GTK] Move ENABLE_ASYNC_SCROLLING build option to right place in OptionsGTK.cmake
4379 https://bugs.webkit.org/show_bug.cgi?id=217977
4381 Unreviewed. No functional changes.
4383 * Source/cmake/OptionsGTK.cmake:
4385 2020-10-20 Adrian Perez de Castro <aperez@igalia.com>
4387 [GTK] Implement HTML5 Gamepad API
4388 https://bugs.webkit.org/show_bug.cgi?id=133847
4390 Reviewed by Michael Catanzaro.
4392 Enable the gamepad support by default for the GTK port. The option is marked PUBLIC
4393 because libmanette is not available in the current Debian "old stable" (Buster), which
4394 we need to support until September 2021.
4396 * Source/cmake/OptionsGTK.cmake: Set ENABLE_GAMEPAD to PUBLIC and ON by default.
4398 2020-10-19 Lauro Moura <lmoura@igalia.com>
4400 REGRESSION(r268115) [GTK] Build failures with GCC 7 (Ubuntu 18.04) and GCC 8 (Debian Buster)
4401 https://bugs.webkit.org/show_bug.cgi?id=217425
4403 Reviewed by Carlos Alberto Lopez Perez.
4405 The root cause is lack of proper <filesystem> support in gcc7/8 (and
4406 incompatibility with llvm's header that was included). As such, we
4407 need to check whether to use <filesystem>, <experimental/filesystem>,
4408 or fallback to the included header.
4410 Note: In some systems like Ubuntu 20.04, gcc-8 can use gcc-9's
4411 libstdc++ and link successfully, but running will fail as it should
4412 actually link with its libstc++fs to provide the correct symbols. As
4413 this is some corner case (Ubuntu's 20 default gcc is 9), LDFLAGS
4414 can be used to overcome this.
4416 * Source/cmake/OptionsCommon.cmake: Add a HAVE directive to
4417 check whether <experimental/filesystem> is the filesystem impl
4419 * Source/cmake/WebKitCompilerFlags.cmake: Test first whether
4420 <filesystem> can be used, with <experimental/filestystem> as fallback.
4422 2020-10-14 Zan Dobersek <zdobersek@igalia.com>
4424 Remove ACCELERATED_2D_CANVAS build flags and guarded code
4425 https://bugs.webkit.org/show_bug.cgi?id=217603
4427 Reviewed by Carlos Garcia Campos.
4429 Yank the CMake ENABLE_ACCELERATED_2D_CANVAS option now that it won't
4430 have any effect. FindCairoGL.cmake can also be removed.
4432 * Source/cmake/FindCairoGL.cmake: Removed.
4433 * Source/cmake/OptionsFTW.cmake:
4434 * Source/cmake/OptionsGTK.cmake:
4435 * Source/cmake/OptionsWPE.cmake:
4436 * Source/cmake/OptionsWin.cmake:
4437 * Source/cmake/WebKitFeatures.cmake:
4438 * Source/cmake/tools/vsprops/FeatureDefines.props:
4439 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
4441 2020-10-13 Adrian Perez de Castro <aperez@igalia.com>
4443 [GTK] Set ENABLE_GAMEPAD=ON for developer builds
4444 https://bugs.webkit.org/show_bug.cgi?id=217493
4446 Reviewed by Carlos Garcia Campos.
4448 * Source/cmake/OptionsGTK.cmake: Make the default value of ENABLE_GAMEPAD
4449 depend on ENABLE_EXPERIMENTAL_FEATURES.
4451 2020-10-13 Michael Catanzaro <mcatanzaro@gnome.org>
4453 [WPE][GTK] ENABLE_SHAREABLE_RESOURCE should be PRIVATE build option
4454 https://bugs.webkit.org/show_bug.cgi?id=217592
4456 Reviewed by Carlos Garcia Campos.
4458 * Source/cmake/OptionsGTK.cmake:
4459 * Source/cmake/OptionsWPE.cmake:
4461 2020-10-09 Fujii Hironori <Hironori.Fujii@sony.com>
4463 [WinCairo][GraphicsLayerTextureMapper] backdrop-filter support
4464 https://bugs.webkit.org/show_bug.cgi?id=217081
4466 Reviewed by Don Olmstead.
4468 * Source/cmake/OptionsWin.cmake: Turn ENABLE_FILTERS_LEVEL_2 on for WinCairo.
4470 2020-10-08 Keith Rollin <krollin@apple.com>
4472 Remove copy-webkitlibraries-to-product-directory
4473 https://bugs.webkit.org/show_bug.cgi?id=217465
4474 <rdar://problem/70082193>
4476 Reviewed by Darin Adler.
4478 This script no longer does anything, so remove it along with the
4479 scaffolding around it that invokes it during the build.
4483 2020-10-04 Ryan Hostetler <rhost@apple.com>
4485 Submission failure with "make: *** No rule to make target `installsrc'. Stop"
4486 https://bugs.webkit.org/show_bug.cgi?id=214696
4487 <rdar://problem/62268104>
4489 Reviewed by Darin Adler.
4491 Add installsrc phase to support xbs submitproject for WebKit repository.
4492 This change allows internal tools to submit and build in a single step.
4498 2020-10-02 Keith Rollin <krollin@apple.com>
4500 Seeing "usage: basename string [suffix]" spam when using make to build
4501 https://bugs.webkit.org/show_bug.cgi?id=217231
4502 <rdar://problem/69889138>
4504 Reviewed by Darin Adler.
4506 The name of the project being built is no longer displayed when using
4507 XCBuild. Therefore, https://bugs.webkit.org/show_bug.cgi?id=216865
4508 taught the Makefile to perform this logging. The approach took
4509 advantage of a `make` variable (PATH_FROM_ROOT) that tracks the
4510 relative path from the root of the build hierarchy to the current
4511 project. However, that variable may not be initialized if the build is
4512 not initiated from the root. Therefore, don't count on that variable,
4513 and get the name of the current project by invoking `pwd`.
4517 2020-10-02 Sam Weinig <weinig@apple.com>
4519 Remove code behind ENABLE(MEDIA_SESSION), no ports enable it
4520 https://bugs.webkit.org/show_bug.cgi?id=216831
4522 Reviewed by Alex Christensen.
4524 * Source/cmake/OptionsFTW.cmake:
4525 * Source/cmake/WebKitFeatures.cmake:
4526 Remove option to build with MEDIA_SESSION, no one was doing it.
4528 2020-10-02 Karl Rackler <rackler@apple.com>
4530 Unreviewed, reverting r267796.
4532 This change is breaking the build on AzulE debug bots.
4536 "Remove code behind ENABLE(MEDIA_SESSION), no ports enable it"
4537 https://bugs.webkit.org/show_bug.cgi?id=216831
4538 https://trac.webkit.org/changeset/267796
4540 2020-10-02 Adrian Perez de Castro <aperez@igalia.com>
4542 [GTK] Build broken with ENABLE_MEDIA_STREAM enabled and ENABLE_WEB_RTC_DISABLED
4543 https://bugs.webkit.org/show_bug.cgi?id=217128
4545 Reviewed by Philippe Normand.
4547 * Source/cmake/GStreamerChecks.cmake: Only enable USE_LIBWEBRTC when both
4548 ENABLE_MEDIA_STREAM and ENABLE_WEB_RTC is defined. This prevents trying to
4549 build code that uses libwebrtc types when ENABLE_WEB_RTC is disabled but
4550 ENABLE_MEDIA_STREAM is enabled.
4552 2020-09-30 Sam Weinig <weinig@apple.com>
4554 Remove code behind ENABLE(MEDIA_SESSION), no ports enable it
4555 https://bugs.webkit.org/show_bug.cgi?id=216831
4557 Reviewed by Alex Christensen.
4559 * Source/cmake/OptionsFTW.cmake:
4560 * Source/cmake/WebKitFeatures.cmake:
4561 Remove option to build with MEDIA_SESSION, no one was doing it.
4563 2020-09-30 Philippe Normand <pnormand@igalia.com>
4565 [GStreamer] Internal audio rendering support
4566 https://bugs.webkit.org/show_bug.cgi?id=207634
4568 Reviewed by Xabier Rodriguez-Calvar.
4570 * Source/cmake/FindWPEBackend_fdo.cmake: Check for the audio extension header initially
4571 shipped in the 1.8.0 release.
4572 * Source/cmake/GStreamerChecks.cmake: Check and enable external audio rendering support if
4573 the WPEBackend-FDO audio extension was found.
4575 2020-09-29 Don Olmstead <don.olmstead@sony.com>
4577 [CMake][WebGPU] Add FindDawn module
4578 https://bugs.webkit.org/show_bug.cgi?id=217097
4580 Reviewed by Darin Adler.
4582 Add a FindDawn CMake module to use for a WebGPU implementation on non-Cocoa platforms.
4583 If ENABLE_WEBGPU is on for WinCairo it will attempt to detect Dawn.
4585 * Source/cmake/FindDawn.cmake: Added.
4586 * Source/cmake/OptionsWinCairo.cmake:
4588 2020-09-28 Keith Rollin <krollin@apple.com>
4590 Print message saying what project is being built
4591 https://bugs.webkit.org/show_bug.cgi?id=216865
4592 <rdar://problem/69408135>
4594 Reviewed by Andy Estes.
4596 XCBuild removes the progress messages saying which project/target is
4597 being built. We can't show the target, but update the Makefiles to at
4598 least show which project is being built.
4602 2020-09-27 Philippe Normand <pnormand@igalia.com>
4604 Add .ccls config file
4605 https://bugs.webkit.org/show_bug.cgi?id=216877
4607 Reviewed by Darin Adler.
4609 ccls is a stand-alone server implementing the Language Server Protocol for C, C++, and
4610 Objective-C languages. It can be used with any editor which provides an LSP client
4611 implementation. It originates from cquery.
4613 https://github.com/MaskRay/ccls/wiki
4615 It's basically used to provide semantic highlighting and code navigation. Many IDEs support
4621 2020-09-25 Fujii Hironori <Hironori.Fujii@sony.com>
4623 make_names.pl no longer needs C preprocessor
4624 https://bugs.webkit.org/show_bug.cgi?id=216953
4626 Reviewed by Sam Weinig.
4628 * Source/cmake/WebKitCompilerFlags.cmake: Removed CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS which was used only for make_names.pl.
4630 2020-09-25 Antti Koivisto <antti@apple.com>
4632 [LFC][Integration] Enable on Apple Windows port
4633 https://bugs.webkit.org/show_bug.cgi?id=216928
4634 <rdar://problem/69505961>
4636 Reviewed by Zalan Bujtas.
4638 * Source/cmake/OptionsWin.cmake:
4640 2020-09-23 Fujii Hironori <Hironori.Fujii@sony.com>
4642 Remove ENABLE_SVG_FONTS macro
4643 https://bugs.webkit.org/show_bug.cgi?id=216850
4645 Reviewed by Don Olmstead.
4647 No ports have this disabled, so remove it.
4649 * Source/cmake/OptionsFTW.cmake:
4650 * Source/cmake/OptionsMac.cmake:
4651 * Source/cmake/OptionsWin.cmake:
4652 * Source/cmake/WebKitFeatures.cmake:
4653 * Source/cmake/tools/vsprops/FeatureDefines.props:
4654 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
4656 2020-09-22 Keith Rollin <krollin@apple.com>
4658 Unify debug and release target aliases
4659 https://bugs.webkit.org/show_bug.cgi?id=216863
4660 <rdar://problem/69407746>
4662 Reviewed by Tim Horton.
4664 All Makefiles have "debug", "d", "release", and "r" for build
4665 targets. Others -- but not all -- also include "dev", "develop",
4666 "development", "dep", "deploy", and "deployment". Because of this
4667 inconsistency, trying to use those additional targets didn't work. It
4668 looks like all Makefiles used to support all of those targets, but
4669 some got dropped along the way. For instance, the top-level Makefile
4670 and Source/Makefile dropped them in 2013 as part of Bug 107863. And it
4671 looks like WebKitLibraries/Makefile never had them. Given that those
4672 additional targets don't work, it seems like no one uses them, so
4673 let's remove them completely.
4677 2020-09-22 Keith Rollin <krollin@apple.com>
4679 Refactor build rules in Makefiles and Makefile.shared
4680 https://bugs.webkit.org/show_bug.cgi?id=216806
4681 <rdar://problem/69332316>
4683 Reviewed by David Kilzer.
4685 Build fix: Previous change for this bug broke the ability to perform a
4686 build with just `make`, due to that code path invoking
4687 `set-webkit-configuration` with no parameters, which causes that
4688 script to error-out.
4692 2020-09-22 Keith Rollin <krollin@apple.com>
4694 Refactor build rules in Makefiles and Makefile.shared
4695 https://bugs.webkit.org/show_bug.cgi?id=216806
4696 <rdar://problem/69332316>
4698 Reviewed by David Kilzer.
4700 Factor out the common aspects of the build rules in Makefile.shared
4701 and the various Makefiles. This allows us to more easily see what's
4702 different between the various build targets, and to apply uniform
4703 changes across all of the targets.
4709 2020-09-22 Jonathan Bedard <jbedard@apple.com>
4711 Correct instructions for building iOS in ReadMe
4712 https://bugs.webkit.org/show_bug.cgi?id=216825
4713 <rdar://problem/69372654>
4715 Reviewed by David Kilzer.
4717 * ReadMe.md: Update iOS build instructions to apply to all embedded platforms.
4719 2020-09-21 Adrian Perez de Castro <aperez@igalia.com>
4721 [CMake] Use imported targets in find module for the ATK SPI2 bridge dependency
4722 https://bugs.webkit.org/show_bug.cgi?id=216773
4724 Reviewed by Don Olmstead.
4726 * Source/cmake/FindATKBridge.cmake: Rewrite to define an ATK::Bridge imported target.
4727 * Source/cmake/OptionsWPE.cmake: Use the ATK::Bridge imported target.
4729 2020-09-16 Fujii Hironori <Hironori.Fujii@sony.com>
4731 [CMake] Add a new library target TestRunnerShared
4732 https://bugs.webkit.org/show_bug.cgi?id=216465
4734 WinCairo port is using both DRT and WTR. However, it has a problem
4735 for precompiled header builds to compile the source of
4736 TestRunnerShared twice for DRT and WTR.
4738 Add a new library target TestRunnerShared. Re-enable precompiled
4739 header for DRT and WTR for WinCairo.
4741 Reviewed by Don Olmstead.
4743 * Source/cmake/OptionsWinCairo.cmake:
4744 * Source/cmake/WebKitFS.cmake:
4746 2020-09-16 Stephan Szabo <stephan.szabo@sony.com>
4748 Remove ENABLE_METER_ELEMENT
4749 https://bugs.webkit.org/show_bug.cgi?id=216582
4751 Reviewed by Fujii Hironori.
4753 With PlayStation finally planning to turn this on,
4754 no ports had this disabled, so remove the enable flag.
4756 * Source/cmake/OptionsFTW.cmake:
4757 * Source/cmake/OptionsMac.cmake:
4758 * Source/cmake/OptionsPlayStation.cmake:
4759 * Source/cmake/OptionsWin.cmake:
4760 * Source/cmake/WebKitFeatures.cmake:
4761 * Source/cmake/tools/vsprops/FeatureDefines.props:
4762 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
4764 2020-09-15 David Kilzer <ddkilzer@apple.com>
4766 WebKit should support building with clang ThreadSanitizer enabled
4767 <https://webkit.org/b/216318>
4768 <rdar://problem/31615729>
4770 Reviewed by Darin Adler.
4772 This patch doesn't attempt to resolve every potential false
4773 positive, but makes it easy to build WebKit with TSan enabled.
4776 - Update to work with `make [args] TSAN=YES`.
4778 2020-09-14 Fujii Hironori <Hironori.Fujii@sony.com>
4780 [PlayStation] Enable ENABLE_SVG_FONTS
4781 https://bugs.webkit.org/show_bug.cgi?id=216522
4783 Reviewed by Don Olmstead.
4785 * Source/cmake/OptionsPlayStation.cmake:
4787 2020-09-12 Myles C. Maxfield <mmaxfield@apple.com>
4789 [Apple Win] Add a CTFont member to FontPlatformData
4790 https://bugs.webkit.org/show_bug.cgi?id=216432
4792 Reviewed by Darin Adler.
4794 Include ***CoreText.cpp files on the Apple Win port.
4796 * Source/cmake/OptionsAppleWin.cmake:
4798 2020-09-10 Adrian Perez de Castro <aperez@igalia.com>
4800 [CMake] Use imported targets in find module for libseccomp
4801 https://bugs.webkit.org/show_bug.cgi?id=216329
4803 Reviewed by Don Olmstead.
4805 * Source/cmake/BubblewrapSandboxChecks.cmake: Use Libseccomp_FOUND.
4806 * Source/cmake/FindLibseccomp.cmake: Rewrite to define the
4807 Libseccomp::Libseccomp target, fall-back to read version from the main
4808 header, and define variables with Libseccomp_ as prefix.
4810 2020-09-04 Adrian Perez de Castro <aperez@igalia.com>
4812 Unreviewed. [WPE] Bump version numbers
4814 * Source/cmake/OptionsWPE.cmake:
4816 2020-09-04 Carlos Garcia Campos <cgarcia@igalia.com>
4818 Unreviewed. [GTK] Bump version numbers
4820 * Source/cmake/OptionsGTK.cmake:
4822 2020-09-02 Philippe Normand <pnormand@igalia.com>
4824 [Flatpak SDK] Update to FDO 20.08
4825 https://bugs.webkit.org/show_bug.cgi?id=215763
4827 Reviewed by Žan Doberšek.
4829 * .gitignore: Ignore buildstream local Flatpak repository. This is created only when
4830 manually building the SDK.
4832 2020-08-31 Stephan Szabo <stephan.szabo@sony.com>
4834 [PlayStation] Build fix for intermittent copy errors
4835 https://bugs.webkit.org/show_bug.cgi?id=215951
4837 Reviewed by Ross Kirsling.
4839 * Source/cmake/OptionsPlayStation.cmake:
4840 When copying platform specific files into the binary
4841 directory post build on executable targets, we'd
4842 intermittently get copy errors in parallel builds.
4844 2020-08-28 Adrian Perez de Castro <aperez@igalia.com>
4846 [WPE] Enable Notifications support
4847 https://bugs.webkit.org/show_bug.cgi?id=215924
4849 Reviewed by Philippe Normand.
4851 Enable web notifications support for the WPE port. The code is shared with the GTK
4852 port, but as we do not try to find and enable libnotify the default implementation
4853 is a stub: embedders can customize how to display notifications by connecting to
4854 the WebKitWebView:show-notification signal. This way we do not add any additional
4857 * Source/cmake/OptionsWPE.cmake: Flip ENABLE_NOTIFICATIONS to ON.
4859 2020-08-27 Stephan Szabo <stephan.szabo@sony.com>
4861 [PlayStation] Build fix due to memmem not always being available.
4862 https://bugs.webkit.org/show_bug.cgi?id=215893
4864 Unreviewed build fix
4866 * Source/cmake/OptionsPlayStation.cmake: Check for memmem
4868 2020-08-22 Philippe Normand <pnormand@igalia.com>
4870 [GTK][WPE] Compilation warnings with clang/gcc 10
4871 https://bugs.webkit.org/show_bug.cgi?id=215699
4873 Reviewed by Darin Adler.
4875 * Source/cmake/WebKitCompilerFlags.cmake: Disable tautological-compare and
4876 misleading-indentation warnings triggering false-positive when building JSC.
4878 2020-08-17 Carlos Garcia Campos <cgarcia@igalia.com>
4880 [GTK][WPE] Remove support for NPAPI plugins
4881 https://bugs.webkit.org/show_bug.cgi?id=215503
4883 Reviewed by Darin Adler.
4885 * Source/cmake/OptionsGTK.cmake:
4887 2020-08-12 Keith Rollin <krollin@apple.com>
4889 Remove the need for defining USE_NEW_BUILD_SYSTEM
4890 https://bugs.webkit.org/show_bug.cgi?id=215439
4892 Reviewed by Darin Adler.
4894 When building WebKit for XCBuild, we currently require that the
4895 external build system (such as the Makefile, build-webkit, etc.)
4896 defines the USE_NEW_BUILD_SYSTEM=YES build setting. This build setting
4897 controls parts of our build instructions that are sensitive to when
4898 XCBuild or the Legacy build system are being used. Notably, we need to
4899 know when to use our custom “copy and modify” scripts with copying
4900 certain header files (used with the Legacy build system) vs. using the
4901 enhanced Copy Headers build phase that’s enabled with
4902 APPLY_RULES_IN_COPY_HEADERS=YES (introduced with and used by XCBuild).
4903 The choice of which method to copy headers is used is controlled by
4904 USE_NEW_BUILD_SYSTEM.
4906 There is no built-in build setting that we can probe to help us
4907 determine which approach to take when copying and modifying headers,
4908 which is why we need to define USE_NEW_BUILD_SYSTEM ourselves. But it
4909 turns out that we can *detect* which build system is being used by
4910 taking advantage of a subtle difference between the two systems. As
4913 https://developer.apple.com/documentation/xcode-release-notes/build-system-release-notes-for-xcode-10
4915 “When an .xcconfig file contains multiple assignments of the same
4916 build setting, later assignments using $(inherited) or
4917 $(<setting_name>) will inherit from earlier assignments in the
4918 .xcconfig. The legacy build system caused every use of
4919 $(inherited) or $(<setting_name>) skip any other values defined
4920 within the .xcconfig.”
4922 This difference can be exploited as follows:
4924 WK_WHICH_BUILD_SYSTEM = not_
4925 WK_WHICH_BUILD_SYSTEM = $(inherited)legacy
4926 WK_USE_NEW_BUILD_SYSTEM = $(WK_USE_NEW_BUILD_SYSTEM_$(WK_WHICH_BUILD_SYSTEM))
4927 WK_USE_NEW_BUILD_SYSTEM_legacy = NO
4928 WK_USE_NEW_BUILD_SYSTEM_not_legacy = YES
4930 We can then use WK_USE_NEW_BUILD_SYSTEM where we used to use the
4931 externally-defined USE_NEW_BUILD_SYSTEM.
4935 2020-08-11 Philippe Normand <pnormand@igalia.com>
4937 [GStreamer] gst-full standalone library support
4938 https://bugs.webkit.org/show_bug.cgi?id=215262
4940 Reviewed by Xabier Rodriguez-Calvar.
4942 * Source/cmake/FindGStreamer.cmake:
4943 * Source/cmake/GStreamerChecks.cmake:
4944 * Source/cmake/GStreamerDefinitions.cmake:
4946 2020-08-03 Wenson Hsieh <wenson_hsieh@apple.com>
4948 Remove the ENABLE_DATA_INTERACTION feature flag
4949 https://bugs.webkit.org/show_bug.cgi?id=215091
4951 Reviewed by Megan Gardner.
4953 * Source/cmake/OptionsFTW.cmake:
4954 * Source/cmake/WebKitFeatures.cmake:
4956 2020-07-15 Carlos Garcia Campos <cgarcia@igalia.com>
4958 [GTK4] Enable API tests
4959 https://bugs.webkit.org/show_bug.cgi?id=214344
4961 Reviewed by Adrian Perez de Castro.
4963 Build API tests for GTK4 too.
4965 * Source/cmake/OptionsGTK.cmake:
4967 2020-07-29 Adrian Perez de Castro <aperez@igalia.com>
4969 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.29.2 release
4971 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
4973 2020-07-29 Carlos Garcia Campos <cgarcia@igalia.com>
4975 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.29.4 release
4977 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
4979 2020-07-27 Carlos Garcia Campos <cgarcia@igalia.com>
4981 [GTK][WPE] Support for backdrop-filter
4982 https://bugs.webkit.org/show_bug.cgi?id=169988
4984 Reviewed by Adrian Perez de Castro.
4986 Enable FILTERS_LEVEL_2 by default for WPE and GTK.
4988 * Source/cmake/OptionsGTK.cmake:
4989 * Source/cmake/OptionsWPE.cmake:
4991 2020-07-27 Alberto Garcia <berto@igalia.com>
4993 [GTK] Default to OpenGL ES in arm
4994 https://bugs.webkit.org/show_bug.cgi?id=214828
4996 Reviewed by Carlos Garcia Campos.
4998 * Source/cmake/OptionsGTK.cmake:
5000 2020-07-24 Yusuke Suzuki <ysuzuki@apple.com>
5002 Add project.pbxproj editorconfig entry
5003 https://bugs.webkit.org/show_bug.cgi?id=214778
5005 Reviewed by Mark Lam.
5007 We should use tab for project.pbxproj file.
5011 2020-07-21 Adrian Perez de Castro <aperez@igalia.com>
5013 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.29.1 release
5015 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
5017 2020-07-20 Adrian Perez de Castro <aperez@igalia.com>
5019 [CMake] Do not use ${DEVELOPER_MODE} directly, as it may be undefined
5021 Unreviewed build fix.
5023 Instead of using ${DEVELOPER_MODE} directly, which might be undefined an cause errors, set
5024 first ENABLE_DEVELOPER_MODE based on its value with SET_AND_EXPOSE_TO_BUILD(), and then use
5025 the ${ENABLE_DEVELOPER_MODE} expansion in the rest of the file.
5027 * Source/cmake/OptionsWPE.cmake:
5029 2020-07-13 Xabier Rodriguez Calvar <calvaris@igalia.com>
5031 Unreviewed. Fixed copy&paste typos of gcrypt -> Thunder
5033 * Source/cmake/FindThunder.cmake:
5035 2020-07-11 Fujii Hironori <Hironori.Fujii@sony.com>
5037 [WinCairo] Conic gradients support
5038 https://bugs.webkit.org/show_bug.cgi?id=214216
5040 Reviewed by Sam Weinig.
5042 * Source/cmake/OptionsWin.cmake: Turn ENABLE_CSS_CONIC_GRADIENTS on.
5044 2020-07-10 Don Olmstead <don.olmstead@sony.com> and Fujii Hironori <Hironori.Fujii@sony.com>
5046 [WinCairo] WOFF2 font support
5047 https://bugs.webkit.org/show_bug.cgi?id=214174
5049 Reviewed by Per Arne Vollan.
5051 * Source/cmake/OptionsWinCairo.cmake: Unmarked fast/text/woff2-totalsfntsize.html and fast/text/woff2.html.
5053 2020-07-10 Xabier Rodriguez Calvar <calvaris@igalia.com>
5055 [GStreamer][EME][OpenCDM] Implement OpenCDM support
5056 https://bugs.webkit.org/show_bug.cgi?id=213550
5058 Reviewed by Philippe Normand.
5060 Added support to enable OpenCDM and find it it needed.
5062 * Source/cmake/FindOpenCDM.cmake: Added.
5063 * Source/cmake/OptionsGTK.cmake:
5064 * Source/cmake/OptionsWPE.cmake:
5065 * Source/cmake/WebKitFeatures.cmake:
5067 2020-07-08 Carlos Garcia Campos <cgarcia@igalia.com>
5069 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.29.3 release
5071 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
5073 2020-07-07 Adrian Perez de Castro <aperez@igalia.com>
5075 [CMake] Fix typo in version variable assingment in FindWOFF2.cmake
5076 https://bugs.webkit.org/show_bug.cgi?id=214012
5078 Reviewed by Carlos Garcia Campos.
5080 * Source/cmake/FindWOFF2.cmake: Properly use PC_WOFF2_VERSION as the version
5081 detected from pkg-config.
5083 2020-07-04 Sergio Villar Senin <svillar@igalia.com>
5085 [Flatpak SDK] Require OpenXR 1.0.9
5086 https://bugs.webkit.org/show_bug.cgi?id=213930
5088 Reviewed by Philippe Normand.
5090 Require version 1.0.9 because is the first one that include EGL support for Monado.
5092 * Source/cmake/OptionsWPE.cmake:
5094 2020-07-03 Darin Adler <darin@apple.com>
5096 Make generate-unified-sources.sh not depend on features being listed in FEATURE_DEFINES environment variable
5097 https://bugs.webkit.org/show_bug.cgi?id=212420
5099 Reviewed by Don Olmstead.
5101 * Source/cmake/WebKitCommon.cmake: Removed call to SET_CONFIGURATION_FOR_UNIFIED_SOURCE_LISTS.
5102 * Source/cmake/WebKitFeatures.cmake: Removed SET_CONFIGURATION_FOR_UNIFIED_SOURCE_LISTS.
5103 * Source/cmake/WebKitMacros.cmake: Removed use of "--feature-flags" when invoking the
5104 generate-unified-source-bundles.rb, which also means no longer depending on the
5105 UNIFIED_SOURCE_LIST_ENABLED_FEATURES variable, which was set by the
5106 SET_CONFIGURATION_FOR_UNIFIED_SOURCE_LISTS function.
5108 2020-07-03 Sam Weinig <weinig@apple.com>
5110 Remove support for ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE
5111 https://bugs.webkit.org/show_bug.cgi?id=213932
5113 Reviewed by Darin Adler.
5115 Removes support for non-standard <input type="datetime">, currently being
5116 guarded by the macro ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE. This macro, was
5117 added back in 2013 as a temporary measure to support some engines who shipped
5118 support for <input type="datetime">. It is currently not enabled for any
5119 ports so now seems like as good a time as any to remove it.
5121 * Source/cmake/OptionsWin.cmake:
5122 * Source/cmake/WebKitFeatures.cmake:
5123 * Source/cmake/tools/vsprops/FeatureDefines.props:
5124 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
5126 2020-07-02 Alex Christensen <achristensen@webkit.org>
5128 Update Mac CMake build
5130 * Source/cmake/OptionsMac.cmake:
5132 2020-07-01 Don Olmstead <don.olmstead@sony.com>
5134 [CMake] Add WOFF2 targets
5135 https://bugs.webkit.org/show_bug.cgi?id=213865
5137 Reviewed by Fujii Hironori.
5139 Rework the Find module for WOFF2 to provide targets for libwoff2common and
5140 libwoff2dec. Previously only libwoff2dec was specified in the find module. This
5141 is because pkg-config works on that platform and because shared libraries are
5142 supported. Neither is true for Windows so the module was expanded in anticipation
5143 of support for WinCairo.
5145 * Source/cmake/FindWOFF2.cmake: Added.
5146 * Source/cmake/FindWOFF2Dec.cmake: Removed.
5147 * Source/cmake/OptionsGTK.cmake:
5148 * Source/cmake/OptionsWPE.cmake:
5150 2020-06-30 Andres Gonzalez <andresg_22@apple.com>
5152 Code cleanup in AccessibilityMenuList.cpp and AXIsolatedTree.h.
5153 https://bugs.webkit.org/show_bug.cgi?id=213806
5155 Reviewed by Darin Adler.
5157 * WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings:
5159 2020-06-29 Guowei Yang <guowei_yang@apple.com>
5161 Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters
5162 https://bugs.webkit.org/show_bug.cgi?id=213578
5164 Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
5166 Preparing to implement CoreImage backed filter rendering
5167 Needs Compiler guards and experimental feature guard.
5169 * Source/cmake/WebKitFeatures.cmake: added definition of
5170 CoreImage-accelerated filter rendering feature flag,
5171 ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER
5173 2020-06-29 Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com>
5175 Remove ENABLE_STREAMS_API compilation flag
5176 https://bugs.webkit.org/show_bug.cgi?id=213728
5178 Reviewed by Sam Weinig.
5180 * Source/cmake/OptionsFTW.cmake:
5181 * Source/cmake/OptionsMac.cmake:
5182 * Source/cmake/OptionsWin.cmake:
5183 * Source/cmake/WebKitFeatures.cmake:
5184 * Source/cmake/tools/vsprops/FeatureDefines.props:
5186 2020-06-25 Diego Pino Garcia <dpino@igalia.com>
5188 [GTK] Enable WEB_API_STATISTICS
5189 https://bugs.webkit.org/show_bug.cgi?id=213592
5191 Reviewed by Carlos Garcia Campos.
5193 * Source/cmake/OptionsGTK.cmake:
5195 2020-06-24 Carlos Garcia Campos <cgarcia@igalia.com>
5197 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.29.2 release
5199 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
5201 2020-06-22 Saam Barati <sbarati@apple.com>
5203 Allow building JavaScriptCore Mac+arm64 in public SDK build
5204 https://bugs.webkit.org/show_bug.cgi?id=213472
5206 Reviewed by Sam Weinig.
5208 * Source/cmake/OptionsFTW.cmake:
5209 * Source/cmake/WebKitFeatures.cmake:
5211 2020-06-18 Tim Horton <timothy_horton@apple.com>
5213 Remove some vestiges of the 32-bit Plugin Process
5214 https://bugs.webkit.org/show_bug.cgi?id=213361
5216 Reviewed by Dan Bernstein.
5219 This hack from r203348 is no longer needed, because WebKit cannot be built for 32-bit anymore.
5221 2020-06-17 Michael Catanzaro <mcatanzaro@gnome.org>
5223 REGRESSION(r260760): ENABLE_GRAPHICS_CONTEXT_GL should be ON, not TRUE
5224 https://bugs.webkit.org/show_bug.cgi?id=212057
5226 Reviewed by Carlos Garcia Campos.
5228 This is already set by feature policy. Don't clobber it.
5230 * Source/cmake/OptionsGTK.cmake:
5232 2020-06-10 Dean Jackson <dino@apple.com>
5234 Add a dynamic library target for ANGLE
5235 https://bugs.webkit.org/show_bug.cgi?id=207591
5237 Reviewed by Tim Horton.
5239 In preparation for moving to a dynamic library, start
5240 by compiling and linking it. It isn't used anywhere
5241 but getting it into the build will help Apple's
5242 build system remain happy as we migrate, as well
5243 as have the system know it exists for building
5244 the shared system cache.
5246 * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
5248 2020-06-12 Adrian Perez de Castro <aperez@igalia.com>
5250 Build is broken with EVENT_LOOP_TYPE=GLib
5251 https://bugs.webkit.org/show_bug.cgi?id=212987
5253 Reviewed by Konstantin Tokarev.
5255 * Source/cmake/OptionsJSCOnly.cmake: Add gio-unix as a required component of the GLib
5256 package, as it is needed for the remote inspector support with EVENT_LOOP_TYPE=GLib.
5258 2020-06-12 Carlos Garcia Campos <cgarcia@igalia.com>
5260 [GTK4] Get MiniBrowser ready for GTK4
5261 https://bugs.webkit.org/show_bug.cgi?id=210276
5263 Reviewed by Adrian Perez de Castro.
5265 Bump GTK4 required version.
5267 * Source/cmake/OptionsGTK.cmake:
5269 2020-06-07 Philippe Normand <pnormand@igalia.com>
5271 Remove ENABLE_VIDEO_TRACK ifdef guards
5272 https://bugs.webkit.org/show_bug.cgi?id=212568
5274 Reviewed by Youenn Fablet.
5276 VIDEO_TRACK has been enabled by default on all ports for a long time. As the spec is stable,
5277 the feature can unconditionally be enabled and is now guarded under ENABLE(VIDEO).
5279 * Source/cmake/OptionsFTW.cmake:
5280 * Source/cmake/OptionsMac.cmake:
5281 * Source/cmake/OptionsWin.cmake:
5282 * Source/cmake/WebKitFeatures.cmake:
5283 * Source/cmake/tools/vsprops/FeatureDefines.props:
5284 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
5286 2020-06-05 Andy Estes <aestes@apple.com>
5288 [Apple Pay] Remove conditionals for ENABLE_APPLE_PAY_SESSION_V(3|4)
5289 https://bugs.webkit.org/show_bug.cgi?id=212541
5290 <rdar://problem/63781452>
5292 Reviewed by Darin Adler.
5294 APPLE_PAY_SESSION_V(3|4) is now enabled whenever APPLE_PAY itself is enabled.
5296 * Source/cmake/OptionsFTW.cmake:
5297 * Source/cmake/OptionsMac.cmake:
5298 * Source/cmake/WebKitFeatures.cmake:
5300 2020-06-04 Mark Lam <mark.lam@apple.com>
5302 Editors should not automatically trim trailing whitespace.
5303 https://bugs.webkit.org/show_bug.cgi?id=212763
5305 Reviewed by Yusuke Suzuki.
5307 Doing so would force a lot of unnecessary code changes and make patches hard to
5308 review. It is common WebKit practice to not make unrelated changes in patches.
5312 2020-06-02 Keith Rollin <krollin@apple.com>
5314 Revert FEATURES_DEFINES related changes
5315 https://bugs.webkit.org/show_bug.cgi?id=212664
5316 <rdar://problem/63893033>
5318 Reviewed by Andy Estes.
5320 Bug 262310, Bug 262311, Bug 262318, and Bug 262331 involve changes to
5321 FEATURE_DEFINES and how the values there relate to those found in the
5322 Platform*.h files. Those changes break XCBuild (by removing the
5323 .xcfilelist related to UnifiedSources and the process for generating
5324 them), and so are being reverted.
5326 * Source/cmake/OptionsFTW.cmake:
5327 * Source/cmake/OptionsMac.cmake:
5328 * Source/cmake/WebKitFeatures.cmake:
5330 2020-06-02 Yoshiaki JITSUKAWA <yoshiaki.jitsukawa@sony.com>
5333 https://bugs.webkit.org/show_bug.cgi?id=212463
5335 Add .editorconfig for Visual Studio.
5337 Initally following file types are supported:
5339 - CMakeFilelist.txt/.cmake
5340 - .editorconfig itself
5342 Reviewed by Fujii Hironori.
5344 * .editorconfig: Added.
5346 2020-05-29 Andy Estes <aestes@apple.com>
5348 [Apple Pay] Remove conditionals for ENABLE_APPLE_PAY_SESSION_V(3|4)
5349 https://bugs.webkit.org/show_bug.cgi?id=212541
5351 Reviewed by Darin Adler.
5353 APPLE_PAY_SESSION_V(3|4) is now enabled whenever APPLE_PAY itself is enabled.
5355 * Source/cmake/OptionsFTW.cmake:
5356 * Source/cmake/OptionsMac.cmake:
5357 * Source/cmake/WebKitFeatures.cmake:
5359 2020-05-29 Keith Rollin <krollin@apple.com>
5361 Revert switch to XCBuild
5362 https://bugs.webkit.org/show_bug.cgi?id=212530
5363 <rdar://problem/63764632>
5365 Unreviewed build fix.
5367 Bug 209890 enabled the use of XCBuild by default. Since then, some
5368 build issues have shown up. While addressing them, temporarily turn
5369 off the use of XCBuild by default.
5372 * WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings:
5374 2020-05-27 Kenneth Russell <kbr@chromium.org>
5376 Update MobileMiniBrowser project settings to current Xcode
5377 https://bugs.webkit.org/show_bug.cgi?id=212428
5379 Reviewed by Dean Jackson.
5381 Accept Xcode's suggested upgrade to use the new build system.
5383 * WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings:
5385 2020-05-27 ChangSeok Oh <changseok@webkit.org>
5387 [GTK] Manette_INCLUDE_DIR and Manette_LIBRARY are undefined.
5388 https://bugs.webkit.org/show_bug.cgi?id=212236
5390 Reviewed by Michael Catanzaro.
5392 The cmake complains Manette_INCLUDE_DIR and Manette_LIBRARY are missing
5393 in finding the manette package where GAMEPAD is enabled for the gtk port.
5394 In r261965, we thought they would be automatically defined with IMPORTED_TARGET
5395 but they seem not. We explicitly find the header and library paths, following FindOpenJPEG.cmake.
5397 * Source/cmake/FindManette.cmake:
5398 * Source/cmake/OptionsGTK.cmake: REQUIRED removed.
5400 2020-05-26 Fujii Hironori <Hironori.Fujii@sony.com>
5402 [WinCairo][WK2] Use GraphicsLayerTextureMapper for Accelerated Compositing mode
5403 https://bugs.webkit.org/show_bug.cgi?id=211883
5405 Reviewed by Don Olmstead.
5407 * Source/cmake/OptionsWinCairo.cmake: Added a new build option
5408 USE_GRAPHICS_LAYER_TEXTURE_MAPPER, and set ON as the default.
5410 2020-05-26 Don Olmstead <don.olmstead@sony.com>
5412 [CMake] Add static analyzers
5413 https://bugs.webkit.org/show_bug.cgi?id=212280
5415 Reviewed by David Kilzer.
5417 Add support for static analyzers within CMake builds. Supported analyzers are
5418 clang-tidy, iwyu (include-what-you-use) and lwyu (link-what-you-use). They can
5419 be enabled by passing a semicolon separated list to CMake through the ANALYZERS
5422 * Source/cmake/WebKitCommon.cmake:
5423 * Source/cmake/WebKitFeatures.cmake:
5424 * Source/cmake/WebKitMacros.cmake:
5425 * Source/cmake/WebKitStaticAnalysis.cmake: Added.
5427 2020-05-26 Keith Rollin <krollin@apple.com>
5429 Enable the use of XCBuild by default in Apple builds
5430 https://bugs.webkit.org/show_bug.cgi?id=209890
5431 <rdar://problem/44182078>
5433 Reviewed by Darin Adler.
5435 Switch from the "legacy" Xcode build system to the "new" build system
5436 (also known as "XCBuild"). Switching to the new system speeds up
5437 builds by a small percentage, better validates projects for
5438 build-related issues (such as dependency cycles), lets WebKit benefit
5439 from future improvements in XCBuild such as those coming from the
5440 underlying llbuild open source project, and prepares us for any other
5441 tools built for this new ecosystem.
5445 - Remove Xcode project and workspace settings that selected the Build
5446 system, allowing the default to take hold (which is currently the
5448 - Updated webkitdirs.pm with a terser check for Xcode version.
5449 - Update build-webkit and Makefile.shared to be explicit when using
5450 the old build system (no longer treat it as a default or fall-back
5452 - Update various xcconfig files similarly to treat the default as
5453 using the new build system.
5454 - Update various post-processing build steps to check for Xcode 11.4
5455 and to no longer treat the default as using the old build system.
5458 * WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings:
5460 2020-05-22 Yoshiaki JITSUKAWA <yoshiaki.jitsukawa@sony.com>
5462 [PlayStation] Enable JSC shell to run
5463 https://bugs.webkit.org/show_bug.cgi?id=212294
5465 Reviewed by Ross Kirsling.
5467 * Source/cmake/OptionsPlayStation.cmake:
5469 2020-05-21 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com>
5471 [PlayStation] Add minimal WKView API to enable TestWebKitAPI
5472 https://bugs.webkit.org/show_bug.cgi?id=211868
5474 Reviewed by Alex Christensen.
5476 Enable TestWebKitAPI
5478 * Source/cmake/OptionsPlayStation.cmake:
5479 Disable FullScreen API and ContextMenus.
5481 2020-05-20 ChangSeok Oh <changseok@webkit.org>
5483 [GTK] Implement connected and disconnected events of GAMEPAD API with libmanette
5484 https://bugs.webkit.org/show_bug.cgi?id=133854
5486 Reviewed by Carlos Garcia Campos.
5488 This patch brings initial GAMEPAD API support to the gtk port. We use libmanette,
5489 a simple GObject game controller library to handle gamepad connection and input.
5491 * Source/cmake/FindManette.cmake: Added to detect libmanette headers and libs installed in host system.
5492 * Source/cmake/OptionsGTK.cmake: Added a private flag, ENABLE_GAMEPAD.
5493 Once libmanette is found, we expose another build flag, USE_MANETTE for other ports.
5495 2020-05-20 Carlos Garcia Campos <cgarcia@igalia.com>
5497 Unreviewed. Fix GTK4 build with GTK 3.98.4
5499 * Source/cmake/OptionsGTK.cmake:
5501 2020-05-18 Michael Catanzaro <mcatanzaro@gnome.org>
5503 [GTK] Allow gtk-doc and introspection in cross builds
5504 https://bugs.webkit.org/show_bug.cgi?id=212026
5506 Reviewed by Adrian Perez de Castro.
5508 Stop disabling these options in cross builds.
5510 * Source/cmake/OptionsGTK.cmake:
5512 2020-05-18 Carlos Garcia Campos <cgarcia@igalia.com>
5514 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.29.1 release
5516 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
5518 2020-05-10 Basuke Suzuki <basuke.suzuki@sony.com>
5520 Add ENABLE_PERIODIC_MEMORY_MONITOR flag.
5521 https://bugs.webkit.org/show_bug.cgi?id=211704
5523 Reviewed by Yusuke Suzuki.
5525 Define ENABLE_PERIODIC_MEMORY_MONITOR flags in specific platform's options.
5526 Enable it for PlayStation port.
5528 * Source/cmake/OptionsGTK.cmake:
5529 * Source/cmake/OptionsMac.cmake:
5530 * Source/cmake/OptionsPlayStation.cmake:
5531 * Source/cmake/OptionsWPE.cmake:
5532 * Source/cmake/WebKitFeatures.cmake:
5534 2020-05-09 Don Olmstead <don.olmstead@sony.com>
5536 [CMake] Use WEBKIT_EXECUTABLE in MallocBench
5537 https://bugs.webkit.org/show_bug.cgi?id=211665
5539 Reviewed by Yusuke Suzuki.
5541 Add the PerformanceTest subdirectory for all ports when in DEVELOPER_MODE.
5545 2020-05-07 Philippe Normand <pnormand@igalia.com>
5547 [WPE][Qt] Enable by default
5548 https://bugs.webkit.org/show_bug.cgi?id=211517
5550 Reviewed by Adrian Perez de Castro.
5552 * Source/cmake/OptionsWPE.cmake: Now that the EWS and bots use the
5553 Flatpak SDK, Qt5 libs are available so we can enable the module
5554 and have bots run its tests.
5556 2020-05-05 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
5558 Compile GPUProcess in WPE port as experimental feature
5559 https://bugs.webkit.org/show_bug.cgi?id=211442
5561 Reviewed by Don Olmstead.
5563 Enable GPUProcess in WPE.
5565 * Source/cmake/OptionsWPE.cmake: enable GPU Process as
5566 experimental feature
5568 2020-05-05 Rob Buis <rbuis@igalia.com>
5570 [GTK][WPE][Fetch API] Stale-while-revalidate is not enabled
5571 https://bugs.webkit.org/show_bug.cgi?id=206416
5573 Reviewed by Carlos Alberto Lopez Perez.
5575 Enable s-w-r for GTK/WPE.
5577 * Source/cmake/OptionsGTK.cmake:
5578 * Source/cmake/OptionsWPE.cmake:
5580 2020-05-04 Darin Adler <darin@apple.com>
5582 Remove unused HAVE(STRINGS_H)
5583 https://bugs.webkit.org/show_bug.cgi?id=211377
5585 Reviewed by Alex Christensen.
5587 * Source/cmake/OptionsCommon.cmake: Remove code to set HAVE_STRINGS_H.
5589 2020-05-01 Per Arne Vollan <pvollan@apple.com>
5591 [Win] Fix AppleWin build
5592 https://bugs.webkit.org/show_bug.cgi?id=211324
5594 Reviewed by Don Olmstead.
5596 Use correct target namespace.
5598 * Source/cmake/target/WebCore.cmake:
5600 2020-05-01 Don Olmstead <don.olmstead@sony.com>
5602 Use export macros on all platforms
5603 https://bugs.webkit.org/show_bug.cgi?id=211293
5605 Reviewed by Michael Catanzaro.
5607 Remove explicit setting of USE_EXPORT_MACROS from all ports.
5609 Ports that use declspec require no changes. Ports with visibility attributes
5610 need to set that as the default in the CMake. This is already done on the
5613 The export macros can also be overridden for different build variants if
5614 required. For example production builds may want to override them.
5616 * Source/cmake/OptionsFTW.cmake:
5617 * Source/cmake/OptionsPlayStation.cmake:
5619 2020-04-29 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
5621 [GPUP][GTK] compile GPUProcess in GTK port
5622 https://bugs.webkit.org/show_bug.cgi?id=208814
5624 Reviewed by Don Olmstead.
5626 Enable GPUProcess compilation in WebKitGTK as an experimental
5629 * Source/cmake/OptionsGTK.cmake: sort alphabetically WebKit
5630 options for GTK port and enable GPU_PROCESS if experimental
5631 features option is enabled.
5633 2020-04-29 Sergio Villar Senin <svillar@igalia.com>
5635 Add ccls config file to the list of ignored files
5636 https://bugs.webkit.org/show_bug.cgi?id=210426
5638 Reviewed by Tim Horton.
5640 * .gitignore: ccls can read configuration options from a .ccls file in
5641 the project root directory. Let's just ignore it.
5643 2020-04-28 Christopher Reid <chris.reid@sony.com>
5645 [Win] Bundle Inspector Resources in Release builds
5646 https://bugs.webkit.org/show_bug.cgi?id=210942
5648 Reviewed by Fujii Hironori.
5650 Add ENABLE_WEBINSPECTORUI so the resource copy can be disabled
5651 on platforms without inspector frontends.
5654 * Source/CMakeLists.txt:
5655 * Source/PlatformWin.cmake:
5656 * Source/cmake/OptionsJSCOnly.cmake:
5657 * Source/cmake/OptionsPlayStation.cmake:
5659 2020-04-28 Philippe Normand <pnormand@igalia.com>
5661 [GStreamer][MediaStream] Doesn't build with GStreamer 1.10
5662 https://bugs.webkit.org/show_bug.cgi?id=210271
5664 Reviewed by Xabier Rodriguez-Calvar.
5666 * Source/cmake/GStreamerChecks.cmake: Require at least GStreamer
5667 1.12 when building with WebRTC/MediaStream enabled.
5669 2020-04-27 Philippe Normand <pnormand@igalia.com>
5671 [GTK] ENABLE(OPENGL) remmants...
5672 https://bugs.webkit.org/show_bug.cgi?id=211077
5674 Reviewed by Adrian Perez de Castro.
5676 ENABLE(OPENGL) was renamed to ENABLE(GRAPHICS_CONTEXT_GL) in
5677 r254064 but not in all the code base...
5679 * Source/cmake/GStreamerDependencies.cmake:
5680 * Source/cmake/OptionsGTK.cmake:
5682 2020-04-27 Carlos Garcia Campos <cgarcia@igalia.com>
5684 [GTK4] Make it possible to build with GTK4 without errors
5685 https://bugs.webkit.org/show_bug.cgi?id=210967
5687 Reviewed by Adrian Perez de Castro.
5689 Disable API tests and GObject introspection when building with GTK4.
5691 * Source/cmake/OptionsGTK.cmake:
5693 2020-04-27 Diego Pino Garcia <dpino@igalia.com>
5695 Unreviewed, reverting r260672.
5697 [GTK] WebInspector tests are timing out after r260672
5701 "[Win] Bundle Inspector Resources in Release builds"
5702 https://bugs.webkit.org/show_bug.cgi?id=210942
5703 https://trac.webkit.org/changeset/260672
5705 2020-04-26 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com>
5707 [PlayStation] Enable TestWTF and TestWebCore
5708 https://bugs.webkit.org/show_bug.cgi?id=208849
5710 Reviewed by Don Olmstead.
5712 * Source/cmake/OptionsPlayStation.cmake:
5713 - Add PLAYSTATION_COPY_SHARED_LIBRARIES() to install dependencies.
5714 - Add -g option for "Release" configuration.
5715 - Drop "RelWithDebInfo" and "MinSizeRel" configuration.
5717 2020-04-24 Michael Catanzaro <mcatanzaro@gnome.org>
5719 [GTK][WPE][JSCOnly] compile error when -DWTF_CPU_ARM64_CORTEXA53=ON set for arm64
5720 https://bugs.webkit.org/show_bug.cgi?id=197192
5722 Reviewed by Yusuke Suzuki.
5724 * Source/cmake/OptionsCommon.cmake:
5726 2020-04-24 Christopher Reid <chris.reid@sony.com>
5728 [Win] Bundle Inspector Resources in Release builds
5729 https://bugs.webkit.org/show_bug.cgi?id=210942
5731 Reviewed by Fujii Hironori.
5733 Add ENABLE_WEBINSPECTORUI so the resource copy can be disabled
5734 on platforms without inspector frontends.
5737 * Source/CMakeLists.txt:
5738 * Source/PlatformWin.cmake:
5739 * Source/cmake/OptionsJSCOnly.cmake:
5740 * Source/cmake/OptionsPlayStation.cmake:
5742 2020-04-24 Per Arne Vollan <pvollan@apple.com>
5744 [Win] Fix AppleWin build
5745 https://bugs.webkit.org/show_bug.cgi?id=210971
5747 Reviewed by Brent Fulgham.
5749 PAL is built as a static library.
5751 * Source/cmake/target/PAL.cmake:
5753 2020-04-23 Yusuke Suzuki <ysuzuki@apple.com>
5755 Make JSCOnly work on macOS
5756 https://bugs.webkit.org/show_bug.cgi?id=210953
5758 Reviewed by Ross Kirsling.
5760 In JSCOnly port on macOS, we should disable ICU API renaming because OS shipped ICU does not have version suffix.
5762 * Source/cmake/OptionsJSCOnly.cmake:
5764 2020-04-22 Darin Adler <darin@apple.com>
5766 [Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK
5767 https://bugs.webkit.org/show_bug.cgi?id=210845
5769 Reviewed by Anders Carlsson.
5771 * Source/cmake/OptionsCommon.cmake: Move ICU-configuring macros to Platform.h.
5772 * Source/cmake/OptionsJSCOnly.cmake: Ditto.
5773 * Source/cmake/OptionsMac.cmake: Ditto.
5775 2020-04-22 Don Olmstead <don.olmstead@sony.com>
5777 [CMake] Use WEBKIT_EXECUTABLE in WebKitTestRunner
5778 https://bugs.webkit.org/show_bug.cgi?id=210132
5780 Reviewed by Adrian Perez de Castro.
5782 Add a WebKitTestRunner derived sources directory.
5784 * Source/cmake/WebKitFS.cmake:
5786 2020-04-21 Adrian Perez de Castro <aperez@igalia.com>
5788 [GTK][CMake] Make gtk-unix-print a component of FindGTK.cmake
5789 https://bugs.webkit.org/show_bug.cgi?id=210792
5791 Reviewed by Carlos Garcia Campos.
5793 * Source/cmake/FindGTK.cmake: Support an "unix-print" component.
5794 * Source/cmake/FindGTKUnixPrint.cmake: Removed.
5795 * Source/cmake/OptionsGTK.cmake: Use the "unix-print" component of the GTK find module.
5797 2020-04-20 Carlos Garcia Campos <cgarcia@igalia.com>
5799 [GTK][WPE] Enable resource load statistics
5800 https://bugs.webkit.org/show_bug.cgi?id=210184
5802 Reviewed by Žan Doberšek.
5804 Enable resource load statistics.
5806 * Source/cmake/OptionsGTK.cmake:
5807 * Source/cmake/OptionsWPE.cmake:
5809 2020-04-17 Don Olmstead <don.olmstead@sony.com>
5811 [CMake] Add WebKit::WebCore target
5812 https://bugs.webkit.org/show_bug.cgi?id=210445
5814 Reviewed by Michael Catanzaro.
5816 Add a target file for internal Apple Windows builds.
5818 * Source/cmake/target/WebCore.cmake: Added.
5820 2020-04-16 Carlos Garcia Campos <cgarcia@igalia.com>
5822 [GTK4] Disable netscape plugins API
5823 https://bugs.webkit.org/show_bug.cgi?id=210552
5825 Reviewed by Adrian Perez de Castro.
5827 Because GTK4 is the future and NPAPI plugins the past.
5829 * Source/cmake/OptionsGTK.cmake:
5831 2020-04-15 Carlos Garcia Campos <cgarcia@igalia.com>
5833 Unreviewed. Do not run gtk-doc when building with GTK4
5835 It's not supported yet.
5837 * Source/PlatformGTK.cmake:
5839 2020-04-13 Adrian Perez de Castro <aperez@igalia.com>
5841 [GTK][CMake] Introduce an USE_GTK4 build option
5842 https://bugs.webkit.org/show_bug.cgi?id=210154
5844 Reviewed by Carlos Garcia Campos.
5846 Do the bare minimum changes to build against GTK4 and produce a WebKit port library with a
5847 different name than GTK3 builds. Note that this does not attempt to make the built artifacts
5848 parallel-installable yet, though at least the main library, headers, and the pkg-config .pc
5849 file should be safe to install. The final names for built artifacts for GTK4 builds may
5852 * Source/cmake/OptionsGTK.cmake: Add a new USE_GTK4 public build option, which defaults
5853 to FALSE for now, and depending on its value choose the required version of GTK and set
5854 a different API version versions. This is enough to build a library with a different
5855 name (libwebkit2gtk-5.0 vs. libwebkit2gtk-4.0) when GTK4 is in use.
5857 2020-04-10 Philippe Normand <pnormand@igalia.com>
5859 [Flatpak SDK] Improved sccache support
5860 https://bugs.webkit.org/show_bug.cgi?id=210027
5862 Reviewed by Žan Doberšek.
5864 * Source/cmake/WebKitCCache.cmake: Check for sccache if one of its
5865 environment variables has been set as well, otherwise the local
5866 disk cache would be used, if WEBKIT_USE_SCCACHE is set to 1.
5868 2020-04-08 Ross Kirsling <ross.kirsling@sony.com>
5870 Remove ENABLE_INTL define
5871 https://bugs.webkit.org/show_bug.cgi?id=210164
5873 Reviewed by Darin Adler.
5875 * Source/cmake/OptionsFTW.cmake:
5876 * Source/cmake/OptionsMac.cmake:
5877 * Source/cmake/OptionsWin.cmake:
5878 * Source/cmake/WebKitFeatures.cmake:
5879 * Source/cmake/tools/vsprops/FeatureDefines.props:
5880 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
5882 2020-04-08 Stephan Szabo <stephan.szabo@sony.com>
5884 [PlayStation] Update import of libdl stubs for new Angle dladdr use
5885 https://bugs.webkit.org/show_bug.cgi?id=210200
5887 Reviewed by Don Olmstead.
5889 * Source/cmake/OptionsPlayStation.cmake:
5890 Use find_package to get libdl wrappers on playstation, include
5891 them in both executables and shared libraries.
5893 2020-04-08 Truitt Savell <tsavell@apple.com>
5895 Unreviewed, reverting r259708.
5897 Broke the iOS device Build
5901 "Enable the use of XCBuild by default in Apple builds"
5902 https://bugs.webkit.org/show_bug.cgi?id=209890
5903 https://trac.webkit.org/changeset/259708
5905 2020-04-08 Keith Rollin <krollin@apple.com>
5907 Enable the use of XCBuild by default in Apple builds
5908 https://bugs.webkit.org/show_bug.cgi?id=209890
5909 <rdar://problem/44182078>
5911 Reviewed by Darin Adler.
5913 Switch from the "legacy" Xcode build system to the "new" build system
5914 (also known as "XCBuild"). Switching to the new system speeds up
5915 builds by a small percentage, better validates projects for
5916 build-related issues (such as dependency cycles), lets WebKit benefit
5917 from future improvements in XCBuild such as those coming from the
5918 underlying llbuild open source project, and prepares us for any other
5919 tools built for this new ecosystem.
5923 - Remove Xcode project and workspace settings that selected the Build
5924 system, allowing the default to take hold (which is currently the
5926 - Updated webkitdirs.pm with a terser check for Xcode version.
5927 - Update build-webkit and Makefile.shared to be explicit when using
5928 the old build system (no longer treat it as a default or fall-back
5930 - Update various xcconfig files similarly to treat the default as
5931 using the new build system.
5932 - Update various post-processing build steps to check for Xcode 11.4
5933 and to no longer treat the default as using the old build system.
5936 * WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings:
5938 2020-04-08 Philippe Normand <pnormand@igalia.com>
5940 [GTK][WPE] Release logs are unconditionally filling the journal
5941 https://bugs.webkit.org/show_bug.cgi?id=209421
5943 Reviewed by Carlos Alberto Lopez Perez.
5945 Re-enable Systemd logging and make it opt-in via the WEBKIT_DEBUG environment variable.
5947 * Source/cmake/OptionsGTK.cmake:
5948 * Source/cmake/OptionsWPE.cmake:
5950 2020-04-07 Adrian Perez de Castro <aperez@igalia.com>
5952 [GTK] CMake find module for GTK4
5953 https://bugs.webkit.org/show_bug.cgi?id=210110
5955 Reviewed by Don Olmstead.
5957 Rename FindGTK3.cmake as FindGTK.cmake, make it provide a GTK::GTK imported target,
5958 and rewrite the logic to detect which targets (backends) have been built into GTK
5959 to use the "targets" pkg-config variable instead of checking for multiple pkg-config
5962 * Source/cmake/FindGDK3.cmake: Removed.
5963 * Source/cmake/FindGTK.cmake: Added.
5964 * Source/cmake/FindGTK3.cmake: Removed. This is now unused because the GTK::GTK target
5965 will transitively depend on GDK3 when using GTK3 and bring in the compiler and linker
5966 options automatically without needing to use a separate find module for GDK.
5967 * Source/cmake/OptionsGTK.cmake: Use the GTK::GTK imported target, change variables
5968 prefixed with GTK3_ to use the GTK_ prefix, and remove variables which are not needed
5969 anymore when using the target (GTK_LIBRARIES, GTK_INCLUDE_DIRS, GDK_LIBRARIES and
5972 2020-04-06 Don Olmstead <don.olmstead@sony.com>
5974 [CMake] Use WEBKIT_EXECUTABLE in DumpRenderTree
5975 https://bugs.webkit.org/show_bug.cgi?id=210059
5977 Reviewed by Fujii Hironori.
5979 Add a DumpRenderTree derived sources directory.
5981 * Source/cmake/WebKitFS.cmake:
5983 2020-04-06 Ross Kirsling <ross.kirsling@sony.com>
5985 Update minimum ICU version to 60.2
5986 https://bugs.webkit.org/show_bug.cgi?id=209694
5988 Reviewed by Darin Adler.
5990 * Source/cmake/OptionsAppleWin.cmake:
5991 * Source/cmake/OptionsCommon.cmake:
5992 * Source/cmake/OptionsFTW.cmake:
5993 * Source/cmake/OptionsGTK.cmake:
5994 * Source/cmake/OptionsJSCOnly.cmake:
5995 * Source/cmake/OptionsMac.cmake:
5996 * Source/cmake/OptionsPlayStation.cmake:
5997 * Source/cmake/OptionsWPE.cmake:
5998 * Source/cmake/OptionsWinCairo.cmake:
5999 Indicate 60.2 as minimum version (as required by GTK for supporting Ubuntu 18.04 LTS).
6000 Also ensure that the C++ API is hidden for all platforms.
6002 2020-04-05 Don Olmstead <don.olmstead@sony.com>
6004 [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
6005 https://bugs.webkit.org/show_bug.cgi?id=206894
6007 Reviewed by Adrian Perez de Castro.
6009 Add a MiniBrowser derived sources directory.
6011 * Source/cmake/WebKitFS.cmake:
6013 2020-04-05 Don Olmstead <don.olmstead@sony.com>
6015 [CMake] Add WebKit::WebKit target
6016 https://bugs.webkit.org/show_bug.cgi?id=210033
6018 Reviewed by Fujii Hironori.
6020 Use SET_AND_EXPOSE_TO_BUILD for the Plugin process since ENABLE(PLUGIN_PROCESS)
6021 is used in the source code.
6023 * Source/cmake/OptionsGTK.cmake:
6025 2020-04-02 Commit Queue <commit-queue@webkit.org>
6027 Unreviewed, reverting r259390.
6028 https://bugs.webkit.org/show_bug.cgi?id=209944
6030 It broke WinCairo builds (Requested by fujihiro on #webkit).
6034 "Enable offlineasm debug annotations for GCC"
6035 https://bugs.webkit.org/show_bug.cgi?id=207119
6036 https://trac.webkit.org/changeset/259390
6038 2020-04-01 Don Olmstead <don.olmstead@sony.com>
6040 [GPUP][PlayStation] Enable GPU Process
6041 https://bugs.webkit.org/show_bug.cgi?id=209865
6043 Reviewed by Eric Carlson.
6045 Enable GPU Process for development builds as an experimental feature.
6047 * Source/cmake/OptionsPlayStation.cmake:
6049 2020-04-01 Don Olmstead <don.olmstead@sony.com>
6051 [PlayStation] Use OBJECT libraries for WebCore and PAL
6052 https://bugs.webkit.org/show_bug.cgi?id=209835
6054 Reviewed by Ross Kirsling.
6056 When compiling WebCore in debug mode ranlib was having issues with the size of
6057 libWebCore.a. This is similar to what happened with Visual Studio and WinCairo.
6059 Additionally hidden visibility defaults are added for the port.
6061 * Source/cmake/OptionsPlayStation.cmake:
6063 2020-03-30 Zan Dobersek <zdobersek@igalia.com>
6065 [WPE] Can't create WebGL context after r259139
6066 https://bugs.webkit.org/show_bug.cgi?id=209722
6068 Reviewed by Carlos Garcia Campos.
6070 * Source/cmake/OptionsWPE.cmake: Disable WebGL2 for WPE until
6071 the ANGLE-backed implementation can be used for it.
6073 2020-03-26 Don Olmstead <don.olmstead@sony.com>
6075 [MSVC] Remove experimental lambda processor usage
6076 https://bugs.webkit.org/show_bug.cgi?id=209358
6078 Reviewed by Fujii Hironori.
6080 Remove /experimental:newLambdaProcessor since WebKit is no longer able to build
6081 with this setting as of Visual Studio 16.5.0.
6083 * Source/cmake/OptionsMSVC.cmake:
6085 2020-03-26 Fujii Hironori <Hironori.Fujii@sony.com>
6087 [Win] lld-link: error: /manifestdependency: is not allowed in .drectve
6088 https://bugs.webkit.org/show_bug.cgi?id=204831
6090 Reviewed by Ross Kirsling.
6092 * Source/cmake/WebKitMacros.cmake (WEBKIT_EXECUTABLE): Added /manifestdependency linkder option if WIN32.
6094 2020-03-26 Commit Queue <commit-queue@webkit.org>
6096 Unreviewed, reverting r259035.
6097 https://bugs.webkit.org/show_bug.cgi?id=209597
6099 broke windows layout-tests (Requested by aakashjain on
6104 "[Win] lld-link: error: /manifestdependency: is not allowed in
6106 https://bugs.webkit.org/show_bug.cgi?id=204831
6107 https://trac.webkit.org/changeset/259035
6109 2020-03-25 Fujii Hironori <Hironori.Fujii@sony.com>
6111 [Win] lld-link: error: /manifestdependency: is not allowed in .drectve
6112 https://bugs.webkit.org/show_bug.cgi?id=204831
6114 Reviewed by Ross Kirsling.
6116 clang-cl doesn't support #pragma comment(linker, "/manifestdependency ..").
6117 Use an linker option instead.
6119 * Source/cmake/WebKitMacros.cmake (WEBKIT_EXECUTABLE): Added -manifestdependency linkder option if WIN32.
6121 2020-03-23 Michael Catanzaro <mcatanzaro@gnome.org>
6123 [GTK] Allow distributors to brand user agent
6124 https://bugs.webkit.org/show_bug.cgi?id=162611
6126 Reviewed by Adrian Perez de Castro.
6128 Add build option for inserting distributor branding into the user agent string.
6130 * Source/cmake/OptionsGTK.cmake:
6131 * Source/cmake/OptionsWPE.cmake:
6133 2020-03-23 Philippe Normand <pnormand@igalia.com>
6135 [GTK][WPE] Disable systemd logging by default
6137 Rubber-stamped by Žan Doberšek.
6139 The logAlways logs are filling the journal way too fast currently,
6140 specially on EWS running tests and buildbots. For the time being
6141 disable logging until we figure out a better way to handle this.
6143 * Source/cmake/OptionsGTK.cmake:
6144 * Source/cmake/OptionsWPE.cmake:
6146 2020-03-21 Michael Catanzaro <mcatanzaro@gnome.org>
6148 [GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc
6149 https://bugs.webkit.org/show_bug.cgi?id=208970
6151 Reviewed by Konstantin Tokarev.
6153 There's no need to rely on shebangs when executing python scripts from CMake. This should
6154 ensure the script always works even if the shebang does not.
6156 * Source/cmake/GtkDoc.cmake:
6158 2020-03-20 Justin Michaud <justin@justinmichaud.com>
6160 Fix JSCOnly build without unified sources
6161 https://bugs.webkit.org/show_bug.cgi?id=209343
6163 Reviewed by Keith Miller.
6167 2020-03-17 Philippe Normand <pnormand@igalia.com>
6169 RELEASE_LOG should not be Cocoa specific
6170 https://bugs.webkit.org/show_bug.cgi?id=195182
6172 Reviewed by Konstantin Tokarev.
6174 Add a Systemd Journald Logger implementation, enabled by default
6175 in the GTK and WPE ports. When this is enabled, release logs will
6176 be sent to the Systemd Journal. To retrieve media logs for
6177 instance, this command can be used:
6179 $ journalctl WEBKIT_SUBSYSTEM=WebKitGTK WEBKIT_CHANNEL=Media
6181 * Source/cmake/FindSystemd.cmake: Added.
6182 * Source/cmake/OptionsGTK.cmake:
6183 * Source/cmake/OptionsWPE.cmake:
6185 2020-03-16 Keith Rollin <krollin@apple.com>
6187 Remove support for WebKitSystemInterface
6188 https://bugs.webkit.org/show_bug.cgi?id=208894
6189 <rdar://problem/60297590>
6191 Reviewed by Brent Fulgham.
6193 This project provided support for facilities that are now handled
6194 elsewhere and is no longer needed.
6197 * Source/PlatformWin.cmake:
6198 * Source/cmake/OptionsAppleWin.cmake:
6200 2020-03-13 Sergio Villar Senin <svillar@igalia.com>
6202 [WebXR] IDLs, stubs and build configuration for WPE
6203 https://bugs.webkit.org/show_bug.cgi?id=208702
6205 Reviewed by Dean Jackson.
6207 Added a new compile flag for WEBXR which depends on WEBGL.
6209 For the WPE port, added OpenXR detection and USE_OPENXR define to be
6210 used in the sources. It also adds a dependency between USE_OPENXR and
6213 Largely based on previous work by Žan Doberšek.
6215 * Source/cmake/FindOpenXR.cmake: Added.
6216 * Source/cmake/OptionsWPE.cmake: Added mandatory OpenXR dependency if
6217 WEBXR is enabled exposing USE_OPENXR to the build.
6218 * Source/cmake/WebKitFeatures.cmake: Added ENABLE_WEBXR.
6219 * Source/cmake/tools/vsprops/FeatureDefines.props: Ditto.
6220 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props: Ditto.
6222 2020-03-14 Michael Catanzaro <mcatanzaro@gnome.org>
6224 [CMake] Warning when ccache is not installed
6225 https://bugs.webkit.org/show_bug.cgi?id=208952
6227 Reviewed by Daniel Bates.
6229 Change the warning when ccache is not installed to a status message. We shouldn't be
6230 printing warnings except when there is an actual problem.
6232 * Source/cmake/WebKitCCache.cmake:
6234 2020-03-13 Konstantin Tokarev <annulen@yandex.ru>
6236 [CMake] Eleminate mismatches between Find* module names and variables they set
6237 https://bugs.webkit.org/show_bug.cgi?id=208948
6239 Reviewed by Michael Catanzaro.
6241 * Source/cmake/FindLibseccomp.cmake:
6242 * Source/cmake/FindWPEBackend_fdo.cmake: Renamed from Source/cmake/FindWPEBackend-fdo.cmake.
6243 * Source/cmake/OptionsGTK.cmake:
6244 * Source/cmake/OptionsWPE.cmake:
6246 2020-03-12 Konstantin Tokarev <annulen@yandex.ru>
6248 [CMake] Find modules should find pkg-config with find_package(PkgConfig QUIET)
6249 https://bugs.webkit.org/show_bug.cgi?id=208948
6251 Reviewed by Michael Catanzaro.
6253 * Source/cmake/FindATK.cmake:
6254 * Source/cmake/FindATKBridge.cmake:
6255 * Source/cmake/FindATSPI.cmake:
6256 * Source/cmake/FindCairo.cmake:
6257 * Source/cmake/FindCairoGL.cmake:
6258 * Source/cmake/FindEGL.cmake:
6259 * Source/cmake/FindEnchant.cmake:
6260 * Source/cmake/FindFontconfig.cmake:
6261 * Source/cmake/FindGDK3.cmake:
6262 * Source/cmake/FindGLIB.cmake:
6263 * Source/cmake/FindGObjectIntrospection.cmake:
6264 * Source/cmake/FindGStreamer.cmake:
6265 * Source/cmake/FindGTK3.cmake:
6266 * Source/cmake/FindGTKUnixPrint.cmake:
6267 * Source/cmake/FindHarfBuzz.cmake:
6268 * Source/cmake/FindLibEpoxy.cmake:
6269 * Source/cmake/FindLibNotify.cmake:
6270 * Source/cmake/FindLibPSL.cmake:
6271 * Source/cmake/FindLibSoup.cmake:
6272 * Source/cmake/FindLibseccomp.cmake:
6273 * Source/cmake/FindLibsecret.cmake:
6274 * Source/cmake/FindLibtasn1.cmake:
6275 * Source/cmake/FindLibxkbcommon.cmake:
6276 * Source/cmake/FindNghttp2.cmake:
6277 * Source/cmake/FindOpenGL.cmake:
6278 * Source/cmake/FindOpenGLES2.cmake:
6279 * Source/cmake/FindOpenJPEG.cmake:
6280 * Source/cmake/FindSQLite3.cmake:
6281 * Source/cmake/FindWOFF2Dec.cmake:
6282 * Source/cmake/FindWPE.cmake:
6283 * Source/cmake/FindWPEBackend-fdo.cmake:
6284 * Source/cmake/FindWayland.cmake:
6285 * Source/cmake/FindWaylandProtocols.cmake:
6286 * Source/cmake/FindWebP.cmake:
6288 2020-03-12 Konstantin Tokarev <annulen@yandex.ru>
6290 [CMake] Avoid calling FPHSA multiple time in FindPerlModules.cmake
6291 https://bugs.webkit.org/show_bug.cgi?id=208948
6293 Reviewed by Michael Catanzaro.
6295 * Source/cmake/FindPerlModules.cmake:
6297 2020-03-09 Don Olmstead <don.olmstead@sony.com>
6299 Add script to search for feature defines
6300 https://bugs.webkit.org/show_bug.cgi?id=208726
6302 Reviewed by Konstantin Tokarev.
6304 Sync feature defines with the FeatureDefines.xcconfig files present in the
6307 * Source/cmake/WebKitFeatures.cmake:
6309 2020-03-09 Don Olmstead <don.olmstead@sony.com>
6311 Remove obsolete feature flags
6312 https://bugs.webkit.org/show_bug.cgi?id=208830
6314 Reviewed by Alex Christensen.
6316 Remove ENABLE_CSS_IMAGE_ORIENTATION, ENABLE_CUSTOM_SCHEME_HANDLER, ENABLE_FETCH_API,
6317 and ENABLE_WEB_PROCESS_SANDBOX from list of feature definitions since they're unused.
6318 Rename ENABLE_ACCESSIBILITY_STATIC_TREE to ENABLE_ACCESSIBILITY_ISOLATED_TREE.
6319 Sort the declarations within the block and always use Toggle instead of Enable within
6322 * Source/cmake/OptionsFTW.cmake:
6323 * Source/cmake/OptionsMac.cmake:
6324 * Source/cmake/OptionsWin.cmake:
6325 * Source/cmake/WebKitFeatures.cmake:
6327 2020-03-09 Antoine Quint <graouts@apple.com>
6329 Remove the compile-time flag for Pointer Events
6330 https://bugs.webkit.org/show_bug.cgi?id=208821
6331 <rdar://problem/60223471>
6333 Reviewed by Dean Jackson.
6335 * Source/cmake/OptionsGTK.cmake:
6336 * Source/cmake/OptionsMac.cmake:
6337 * Source/cmake/OptionsWPE.cmake:
6338 * Source/cmake/WebKitFeatures.cmake:
6340 2020-03-03 Fujii Hironori <fujii.hironori@gmail.com>
6342 [Curl] Add TLS debugging feature to log encryption keys
6343 https://bugs.webkit.org/show_bug.cgi?id=208192
6344 <rdar://problem/59900616>
6346 Reviewed by Don Olmstead.
6348 * Source/cmake/OptionsPlayStation.cmake:
6349 * Source/cmake/OptionsWin.cmake:
6350 Changed the default ENABLE_TLS_DEBUG to OFF.
6352 2020-02-28 Fujii Hironori <Hironori.Fujii@sony.com>
6354 Unreviewed, rolling out r257565.
6356 It broke WinCairo MiniBrowser
6360 "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
6361 https://bugs.webkit.org/show_bug.cgi?id=206894
6362 https://trac.webkit.org/changeset/257565
6364 2020-02-28 Takashi Komori <Takashi.Komori@sony.com>
6366 [Curl] Add TLS debugging feature to log encryption keys
6367 https://bugs.webkit.org/show_bug.cgi?id=208192
6369 Reviewed by Fujii Hironori.
6371 This patch enables recording encryption keys on curl port.
6372 When you set key log file path to environment variable SSLKEYLOGFILE on curl port, network process writes encryption keys into the path.
6373 The key log file follows the NSS key log format and this feature is as same as Chrome and Firefox have.
6375 See also: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/Key_Log_Format
6377 Test: No tests for this debugging feature. We have to check manually if the log file is generate.
6379 * Source/cmake/OptionsPlayStation.cmake:
6380 * Source/cmake/OptionsWin.cmake:
6382 2020-02-28 Keith Miller <keith_miller@apple.com>
6384 Fix issue in cmake build for checking ccache
6385 https://bugs.webkit.org/show_bug.cgi?id=208377
6387 Reviewed by Carlos Alberto Lopez Perez.
6389 If either of the "readlink" or "which" commands fail when looking for the ccache prefix
6390 the output variables will be empty and an invalid expression will be provided to CMake.
6391 e.g. we will get something like:
6392 if ("0" "EQUAL" "0" "AND" "1" "EQUAL" "0" "AND" "STREQUAL" "/usr/local/bin/ccache")
6394 The fix is to wrap the output variables in the quotes when unboxing them in the if.
6396 * Source/cmake/WebKitCCache.cmake:
6398 2020-02-27 Per Arne Vollan <pvollan@apple.com>
6400 [Win] Fix AppleWin build
6401 https://bugs.webkit.org/show_bug.cgi?id=208330
6403 Reviewed by Don Olmstead.
6405 Set framework headers directory for AppleWin build.
6407 * Source/cmake/target/TargetJavaScriptCore.cmake:
6408 * Source/cmake/target/TargetWTF.cmake:
6410 2020-02-27 Don Olmstead <don.olmstead@sony.com>
6412 [CMake] Add WebKit::PAL target
6413 https://bugs.webkit.org/show_bug.cgi?id=198493
6415 Reviewed by Michael Catanzaro.
6417 Define WebKit::PAL target for Apple internal Windows builds.
6419 * Source/cmake/target/PAL.cmake: Added.
6421 2020-02-27 Don Olmstead <don.olmstead@sony.com>
6423 [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
6424 https://bugs.webkit.org/show_bug.cgi?id=206894
6426 Reviewed by Adrian Perez de Castro.
6428 Add a MiniBrowser derived sources directory.
6430 * Source/cmake/WebKitFS.cmake:
6432 2020-02-27 Adrian Perez de Castro <aperez@igalia.com>
6434 [LFC][Integration] Build and enable for the WPE and GTK ports
6435 https://bugs.webkit.org/show_bug.cgi?id=208289
6437 Reviewed by Carlos Garcia Campos.
6439 Enable LFC for the WPE and GTK ports.
6441 * Source/cmake/OptionsGTK.cmake: LFC enabled as experimental feature.
6442 * Source/cmake/OptionsWPE.cmake: Ditto.
6444 2020-02-26 Carlos Garcia Campos <cgarcia@igalia.com>
6446 Unreviewed. Bump GTK version numbers
6448 * Source/cmake/OptionsGTK.cmake:
6450 2020-02-25 Carlos Garcia Campos <cgarcia@igalia.com>
6452 [GTK] Add support for rendering slider ticks
6453 https://bugs.webkit.org/show_bug.cgi?id=208132
6455 Reviewed by Adrian Perez de Castro.
6457 Add a test case for sliders with ticks.
6459 * ManualTests/gtk/theme.html:
6461 2020-02-25 Carlos Garcia Campos <cgarcia@igalia.com>
6463 [GTK] Stop using gtk foreign drawing API to style form controls
6464 https://bugs.webkit.org/show_bug.cgi?id=208129
6466 Reviewed by Adrian Perez de Castro.
6468 Add a test case for datalist element.
6470 * ManualTests/gtk/theme.html:
6472 2020-02-24 Yusuke Suzuki <ysuzuki@apple.com>
6474 Do not use target/icu.cmake
6475 https://bugs.webkit.org/show_bug.cgi?id=208173
6477 Reviewed by Don Olmstead.
6479 icu.cmake is removed in r256731. Use find_package + ICU since WebKit offers find_package implementation
6480 which can find appropriate system-installed ICU.
6482 * Source/cmake/OptionsFTW.cmake:
6483 * Source/cmake/OptionsJSCOnly.cmake:
6484 * Source/cmake/OptionsMac.cmake:
6486 2020-02-24 Per Arne Vollan <pvollan@apple.com>
6488 [Win] Fix AppleWin build.
6489 https://bugs.webkit.org/show_bug.cgi?id=208164
6491 Unreviewed build fix.
6493 Allow a warning which happens when building with older SDKs.
6495 * Source/cmake/OptionsMSVC.cmake:
6497 2020-02-20 Carlos Alberto Lopez Perez <clopez@igalia.com>
6499 [GTK][WPE] Not set ccache compiler prefix if ccache its already the compiler binary in path.
6500 https://bugs.webkit.org/show_bug.cgi?id=208007
6502 Reviewed by Tim Horton.
6504 Detect if the compiler binary already points to the ccache binary and in that case don't
6505 set the ccache compiler prefix. Also export CCACHE_SLOPPINESS=time_macros if its not
6506 defined to other thing on the environment and add a some logging of related messages.
6508 * Source/cmake/WebKitCCache.cmake:
6510 2020-02-20 Don Olmstead <don.olmstead@sony.com>
6512 [CMake] Add WebP targets
6513 https://bugs.webkit.org/show_bug.cgi?id=207982
6515 Reviewed by Adrian Perez de Castro.
6517 Modernize the FindWebP.cmake module so it creates targets that can be
6518 referenced rather than using WEBP_LIBRARIES and WEBP_INCLUDE_DIRS.
6519 Also making demux a component within the module, and allowing alternate names
6520 for the library to be set by the platform.
6522 * Source/cmake/FindWebP.cmake:
6523 * Source/cmake/OptionsFTW.cmake:
6524 * Source/cmake/OptionsGTK.cmake:
6525 * Source/cmake/OptionsPlayStation.cmake:
6526 * Source/cmake/OptionsWPE.cmake:
6527 * Source/cmake/OptionsWinCairo.cmake:
6529 2020-02-20 Don Olmstead <don.olmstead@sony.com>
6531 [CMake] Add WPE::libwpe target
6532 https://bugs.webkit.org/show_bug.cgi?id=207970
6534 Reviewed by Adrian Perez de Castro.
6536 Redo the WPE find module to export a target.
6538 * Source/cmake/FindWPE.cmake:
6540 2020-02-19 Philippe Normand <pnormand@igalia.com>
6542 [GTK][WPE] Set ccache as compiler launcher, add opt-in sccache support
6543 https://bugs.webkit.org/show_bug.cgi?id=207838
6545 Reviewed by Carlos Alberto Lopez Perez.
6547 This change allows for more granular control over the compiler
6548 launcher configuration. The build host should no longer need to
6549 set ccache symbolic links. Additionally optional support for
6550 sccache is added, enabled when the WEBKIT_USE_SCCACHE environment
6551 variable is set to YES.
6553 * Source/cmake/WebKitCCache.cmake:
6555 2020-02-17 Don Olmstead <don.olmstead@sony.com>
6557 [CMake] Use builtin targets
6558 https://bugs.webkit.org/show_bug.cgi?id=205166
6560 Reviewed by Darin Adler.
6562 Add WebKitFindPackage.cmake which wraps CMake's find_package to provide targets
6563 for common libraries.
6566 1. There are a number of libraries which are found using CMake's internal Find modules
6567 that contain targets but not all of them are available in the minimum version of
6568 CMake we support, 3.10.
6569 2. Updating to CMake 3.12 or higher is not possible due to the WebKit GTK's support
6570 policy. It looks like the next time we can bump the version is spring 2021.
6571 3. Apple builds, both Mac and Windows, have libraries that won't be found using the
6572 stock CMake modules. AppleWin also has internal builds where all libraries have
6573 a DEBUG_SUFFIX of _debug that would not be picked up.
6575 In the implementation of find_package any Apple specific requirements are dealt with
6576 and the expected CMake values are populated. For all other cases CMake's original
6577 find_package is called so there's no behavior change. Afterwards if there is a library
6578 that has a target but the target was not created it is created from the definitions
6579 that are present from the find module at CMake 3.10.
6581 This makes it so all ports consistently have targets across all versions of CMake
6582 above the current minimum.
6584 * Source/cmake/OptionsAppleWin.cmake:
6585 * Source/cmake/OptionsPlayStation.cmake:
6586 * Source/cmake/WebKitCommon.cmake:
6587 * Source/cmake/WebKitFindPackage.cmake: Added.
6588 * Source/cmake/target/icu.cmake: Removed.
6590 2020-02-14 Don Olmstead <don.olmstead@sony.com>
6592 [CMake] Add Fontconfig::Fontconfig target
6593 https://bugs.webkit.org/show_bug.cgi?id=207730
6595 Reviewed by Adrian Perez de Castro.
6597 Redo the Fontconfig find module to export a target.
6599 * Source/cmake/FindFontconfig.cmake:
6601 2020-02-10 Michael Catanzaro <mcatanzaro@gnome.org>
6603 [CMake] Prepend -Wno-noexcept-type only to global CXX flags
6604 https://bugs.webkit.org/show_bug.cgi?id=207468
6606 Reviewed by Adrian Perez de Castro.
6608 -Wno-noexcept-type is a C++-specific flag that should not be passed to the C compiler. This
6609 causes a warning spam in GCC 10.
6611 * Source/cmake/WebKitCompilerFlags.cmake:
6613 2020-02-10 Enrique Ocaña González <eocanha@igalia.com>
6615 [GTK] Mouse pointer no longer hidden during fullscreen video playback
6616 https://bugs.webkit.org/show_bug.cgi?id=197346
6618 Reviewed by Adrian Perez de Castro.
6620 Enabled the CURSOR_VISIBILITY feature on the GTK port.
6622 * Source/cmake/OptionsGTK.cmake:
6624 2020-02-06 Carlos Garcia Campos <cgarcia@igalia.com>
6626 Unreviewed. [GTK] Use radio buttons instead of a combo for text direction in theme test
6628 * ManualTests/gtk/theme.html:
6630 2020-02-05 Don Olmstead <don.olmstead@sony.com>
6632 [PlayStation] Build a shared JavaScriptCore
6633 https://bugs.webkit.org/show_bug.cgi?id=198446
6635 Reviewed by Fujii Hironori.
6637 Compile bmalloc and WTF as OBJECT libraries that are then linked into a shared
6638 JavaScriptCore. Using OBJECT libraries is a modern CMake way to have the behavior
6641 * Source/cmake/OptionsPlayStation.cmake:
6643 2020-02-04 Don Olmstead <don.olmstead@sony.com>
6645 [PlayStation] Enable TestWebKit
6646 https://bugs.webkit.org/show_bug.cgi?id=207211
6648 Reviewed by Ross Kirsling.
6650 Turn back on API tests.
6652 * Source/cmake/OptionsPlayStation.cmake:
6654 2020-02-04 Ross Kirsling <ross.kirsling@sony.com>
6656 [CMake] Add Cairo::Cairo target
6657 https://bugs.webkit.org/show_bug.cgi?id=207159
6659 Reviewed by Konstantin Tokarev.
6661 * Source/cmake/FindCairo.cmake:
6662 * Source/cmake/OptionsPlayStation.cmake:
6664 2020-02-02 Ting-Wei Lan <lantw44@gmail.com>
6666 [CMake] Use opj_config.h to find OpenJPEG include directory
6667 https://bugs.webkit.org/show_bug.cgi?id=207100
6669 Reviewed by Konstantin Tokarev.
6671 WebKit needs OpenJPEG 2.2.0 or later versions, but it is possible for a
6672 system to have both OpenJPEG 1 and OpenJPEG 2 installed. However, some
6673 distributions do not put OpenJPEG 1 under a versioned directory and
6674 put its header file directly under /usr/include or /usr/local/include.
6675 Since CMake prefers its prefixes to paths given in HINTS, it is possible
6676 that openjpeg.h from OpenJPEG 1 is found before the one from OpenJPEG 2,
6677 causing WebKit to fail to build because of using the wrong header file.
6679 Resolve the problem by checking opj_config.h instead of openjpeg.h.
6680 OpenJPEG 1.5 does not have opj_config.h, so only OpenJPEG 2 can be
6681 found. This also makes it consistent with the code below which already
6684 * Source/cmake/FindOpenJPEG.cmake:
6686 2020-01-31 Don Olmstead <don.olmstead@sony.com>
6688 [CMake] Add _PRIVATE_LIBRARIES to framework
6689 https://bugs.webkit.org/show_bug.cgi?id=207004
6691 Reviewed by Konstantin Tokarev.
6693 Use _PRIVATE_LIBRARIES to when creating a WebKit target to specify privately linked
6694 libraries. This fits with the current conventions in WebKit for CMake libraries and
6695 prevents appending to _LIBRARIES with a visibility modifier which likely has
6696 unintended consequences.
6698 * Source/cmake/WebKitMacros.cmake:
6700 2020-01-30 Ross Kirsling <ross.kirsling@sony.com>
6702 [CMake] Add SQLite::SQLite3 target
6703 https://bugs.webkit.org/show_bug.cgi?id=207005
6705 Reviewed by Don Olmstead.
6707 * Source/cmake/FindSQLite3.cmake: Added.
6708 * Source/cmake/FindSqlite.cmake: Removed.
6709 * Source/cmake/OptionsAppleWin.cmake: Actually use find_package.
6710 * Source/cmake/OptionsFTW.cmake: Sqlite -> SQLite3
6711 * Source/cmake/OptionsGTK.cmake: Sqlite -> SQLite3
6712 * Source/cmake/OptionsPlayStation.cmake: Sqlite -> SQLite3
6713 * Source/cmake/OptionsWPE.cmake: Sqlite -> SQLite3
6714 * Source/cmake/OptionsWinCairo.cmake: Sqlite -> SQLite3
6716 2020-01-29 Fujii Hironori <Hironori.Fujii@sony.com>
6718 [MSVC] Add /experimental:newLambdaProcessor switch for better C++ conformance
6719 https://bugs.webkit.org/show_bug.cgi?id=204443
6721 Reviewed by Alex Christensen.
6723 MSVC has a bug of 'this' in lambda captures. It has caused
6724 compilation errors repeatedly.
6726 * Source/cmake/OptionsMSVC.cmake: Added /experimental:newLambdaProcessor switch.
6728 2020-01-29 Stephan Szabo <stephan.szabo@sony.com>
6730 [PlayStation] Allow setting CMAKE_IGNORE_PATH from environment for bots
6731 https://bugs.webkit.org/show_bug.cgi?id=206964
6733 Reviewed by Don Olmstead.
6735 * Source/cmake/OptionsPlayStation.cmake:
6737 2020-01-28 Carlos Garcia Campos <cgarcia@igalia.com>
6739 [GTK] Should use light theme unless website declares support for dark themes in color-schemes property
6740 https://bugs.webkit.org/show_bug.cgi?id=197947
6742 Reviewed by Michael Catanzaro.
6744 Do not define HAVE_OS_DARK_MODE_SUPPORT.
6746 * Source/cmake/OptionsGTK.cmake:
6748 2020-01-28 Don Olmstead <don.olmstead@sony.com>
6750 [LFC][Integration] Build and enable on Windows
6751 https://bugs.webkit.org/show_bug.cgi?id=206165
6753 Reviewed by Darin Adler.
6755 Enable LFC for Windows.
6757 * Source/cmake/OptionsWin.cmake:
6759 2020-01-24 Sergio Villar Senin <svillar@igalia.com>
6761 Remove WebVR from the tree
6762 https://bugs.webkit.org/show_bug.cgi?id=206739
6764 Reviewed by Darin Adler.
6766 Removed WebVR and OpenVR build options for GTK and WPE ports.
6768 * Source/CMakeLists.txt:
6769 * Source/cmake/OptionsGTK.cmake:
6770 * Source/cmake/OptionsWPE.cmake:
6772 2020-01-22 Don Olmstead <don.olmstead@sony.com>
6774 [OpenSSL] Add stubs and build for Web Crypto
6775 https://bugs.webkit.org/show_bug.cgi?id=206449
6777 Reviewed by Jiewen Tan.
6779 Enable Web Crypto as an experiment for WinCairo and PlayStation. Add the USE_OPENSSL
6780 definition to platforms using OpenSSL.
6782 * Source/cmake/OptionsFTW.cmake:
6783 * Source/cmake/OptionsPlayStation.cmake:
6784 * Source/cmake/OptionsWin.cmake:
6785 * Source/cmake/OptionsWinCairo.cmake:
6787 2020-01-21 Rob Buis <rbuis@igalia.com>
6789 Add build flag for stale-while-revalidate
6790 https://bugs.webkit.org/show_bug.cgi?id=204169
6792 Reviewed by Youenn Fablet.
6794 Add build flag for stale-while-revalidate to make it
6795 independent from the NETWORK_CACHE_SPECULATIVE_REVALIDATION build flag.
6797 * Source/cmake/OptionsFTW.cmake:
6798 * Source/cmake/OptionsMac.cmake:
6799 * Source/cmake/WebKitFeatures.cmake:
6801 2020-01-20 Adrian Perez de Castro <aperez@igalia.com>
6803 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.27.4 release
6805 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
6807 2020-01-16 Don Olmstead <don.olmstead@sony.com>
6809 [PlayStation] Enable WebKit
6810 https://bugs.webkit.org/show_bug.cgi?id=205965
6812 Reviewed by Ross Kirsling.
6814 Turn on build WebKit for the PlayStation port. Temporarily turn off API tests
6815 until the WebKit tests are added.
6817 * Source/cmake/OptionsPlayStation.cmake:
6819 2020-01-16 Philippe Normand <philn@igalia.com>
6821 [GStreamer][WPE] Client-side video rendering support
6822 https://bugs.webkit.org/show_bug.cgi?id=206289
6824 Reviewed by Xabier Rodriguez-Calvar.
6826 Add a new compile-time option to enable client-side video
6827 rendering support. With this feature enabled the UIProcess will be
6828 in charge of positioning and rendering video surfaces, thanks to
6829 the WPEBackend-FDO video-plane-display-dmabuf protocol.
6831 * Source/cmake/GStreamerDefinitions.cmake: Add
6832 USE_WPE_VIDEO_PLANE_DISPLAY_DMABUF CMake option, disabled by
6834 * Source/cmake/GStreamerDependencies.cmake: This new option
6835 depends on GStreamer-GL.
6836 * Source/cmake/OptionsWPE.cmake: It depends also on the presence
6837 of the WPEBackend-FDO library.
6839 2020-01-16 Per Arne Vollan <pvollan@apple.com>
6841 [Win] Fix AppleWin build
6842 https://bugs.webkit.org/show_bug.cgi?id=206299
6844 Reviewed by Brent Fulgham.
6846 This patch has been created by don.olmstead@sony.com and pvollan@apple.com. Add target files for WTF and
6847 JavaScriptCore. Also, to make sure headers are copied to the forwarding headers directory, add the CMake
6848 keywork ALL when adding custom target for copying files.
6850 * Source/cmake/TargetJavaScriptCore.cmake: Added.
6851 * Source/cmake/TargetWTF.cmake: Added.
6852 * Source/cmake/WebKitMacros.cmake:
6854 2020-01-10 Dean Jackson <dino@apple.com>
6856 [WebGL] Clarify USE_OPENGL_ES_3
6857 https://bugs.webkit.org/show_bug.cgi?id=206081
6858 <rdar://problem/58486798>
6860 Reviewed by Simon Fraser.
6862 Make it clear that USE_ANGLE | USE_OPENGL | USE_OPENGL_ES are exclusive,
6863 and that the availability of OpenGL ES 3 is a separate query.
6865 * Source/cmake/OptionsFTW.cmake:
6866 * Source/cmake/OptionsWPE.cmake:
6867 * Source/cmake/OptionsWinCairo.cmake:
6869 2020-01-10 Carlos Garcia Campos <cgarcia@igalia.com>
6871 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.27.4 release
6873 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
6875 2020-01-09 Commit Queue <commit-queue@webkit.org>
6877 Unreviewed, rolling out r254234.
6878 https://bugs.webkit.org/show_bug.cgi?id=206011
6880 Broke production builds (Requested by ap on #webkit).
6884 "build-jsc should invoke make instead of calling xcodebuild
6886 https://bugs.webkit.org/show_bug.cgi?id=205960
6887 https://trac.webkit.org/changeset/254234
6889 2020-01-08 Saam Barati <sbarati@apple.com>
6891 build-jsc should invoke make instead of calling xcodebuild directly
6892 https://bugs.webkit.org/show_bug.cgi?id=205960
6894 Reviewed by Keith Miller.
6898 2020-01-08 Saam Barati <sbarati@apple.com>
6900 build-jsc should invoke make instead of calling xcodebuild directly
6901 https://bugs.webkit.org/show_bug.cgi?id=205960
6903 Reviewed by Keith Miller.
6907 2020-01-08 Mark Lam <mark.lam@apple.com>
6909 Rename testing build configuration to release+assert, and add new testing build configuration.
6910 https://bugs.webkit.org/show_bug.cgi?id=205954
6912 Reviewed by Yusuke Suzuki.
6914 "make release-assert" builds a release build with ASSERT_ENABLED=1.
6915 "make testing" builds a debug build with clang optimization level forced to -O3.
6921 2020-01-08 Keith Miller <keith_miller@apple.com>
6923 Fix testing Makefile to inherit preprocessor definitions
6924 https://bugs.webkit.org/show_bug.cgi?id=205940
6926 Reviewed by Mark Lam.
6930 2020-01-07 Keith Miller <keith_miller@apple.com>
6932 Add a testing target to make that is release + assertions
6933 https://bugs.webkit.org/show_bug.cgi?id=205895
6935 Reviewed by Mark Lam.
6941 2020-01-07 Carlos Garcia Campos <cgarcia@igalia.com>
6943 [GTK][WPE] Add API to set purpose and hints of active editable element to input methods
6944 https://bugs.webkit.org/show_bug.cgi?id=205605
6946 Reviewed by Žan Doberšek.
6948 Add ENABLE_AUTOCAPITALIZE build flag. It's private and disabled by default, enabled in GTK and WPE ports.
6950 * Source/cmake/OptionsGTK.cmake:
6951 * Source/cmake/OptionsWPE.cmake:
6952 * Source/cmake/WebKitFeatures.cmake:
6954 2020-01-06 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com>
6956 [PlayStation] Update port cmake
6957 https://bugs.webkit.org/show_bug.cgi?id=205846
6959 Reviewed by Don Olmstead.
6961 Define C/CXX macro BPLATFORM_PLAYSTATION.
6963 Find HarfBuzz::ICU component to fix cmake errors.
6965 Make the WebCore and WebKit builds optional.
6967 * Source/cmake/OptionsPlayStation.cmake:
6969 2020-01-06 Don Olmstead <don.olmstead@sony.com>
6971 Rename GraphicsContext3D to GraphicsContextGL
6972 https://bugs.webkit.org/show_bug.cgi?id=205778
6973 <rdar://problem/58327597>
6975 Reviewed by Ross Kirsling.
6977 Fix the build after r254064 on Windows and PlayStation.
6979 Add USE_OPENGL_ES_3 to Windows and WPE builds to simplify the Platform checks
6980 for GL functions available in OpenGL ES 3.0+. Expose additional USE macros for
6981 Windows builds to remove Platform.h entries around ENABLE(WEBGL).
6983 * Source/cmake/OptionsFTW.cmake:
6984 * Source/cmake/OptionsWPE.cmake:
6985 * Source/cmake/OptionsWinCairo.cmake:
6987 2020-01-05 Dean Jackson <dino@apple.com>
6989 Rename GraphicsContext3D to GraphicsContextGL
6990 https://bugs.webkit.org/show_bug.cgi?id=205778
6991 <rdar://problem/58327597>
6993 Reviewed by Sam Weinig.
6995 Rename all the GraphicsContext3D things to GraphicsContextGL
6996 (includes Extensions3D and GRAPHICS_CONTEXT_3D).
6998 GraphicsContext3DBase now becomes GraphicsContextGL.
6999 GraphicsContext3D is now GraphicsContextGLOpenGL (since it represents
7000 the OpenGL implementation of the API).
7002 * Source/CMakeLists.txt:
7003 * Source/cmake/OptionsFTW.cmake:
7004 * Source/cmake/OptionsGTK.cmake:
7005 * Source/cmake/OptionsMac.cmake:
7006 * Source/cmake/OptionsPlayStation.cmake:
7007 * Source/cmake/OptionsWPE.cmake:
7008 * Source/cmake/OptionsWinCairo.cmake:
7010 2020-01-03 Simon Fraser <simon.fraser@apple.com>
7012 Add some shared schemes to the WebKit.xcworkspace
7013 https://bugs.webkit.org/show_bug.cgi?id=205698
7015 Reviewed by Tim Horton.
7017 Make WebKit.xcworkspace show the following schemes by default:
7031 Also remove the MobileMiniBrowserUITests scheme.
7033 * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
7035 2019-12-22 Jeff Miller <jeffm@apple.com>
7037 Update user-visible copyright strings to include 2020
7038 https://bugs.webkit.org/show_bug.cgi?id=205552
7040 Reviewed by Darin Adler.
7042 * Source/cmake/tools/scripts/COPYRIGHT-END-YEAR:
7044 2019-12-18 Diego Pino Garcia <dpino@igalia.com>
7046 [GTK][WPE] Renderization of Conic gradients
7047 https://bugs.webkit.org/show_bug.cgi?id=202739
7049 Reviewed by Carlos Alberto Lopez Perez.
7051 * Source/cmake/OptionsGTK.cmake: Enable CSS Conic Gradients.
7053 2019-12-17 ChangSeok Oh <changseok@webkit.org>
7055 [GTK] Suppress undefined USE_OPENGL warnings when USE_ANGLE_WEBGL and USE_OPENGL_ES are enabled.
7056 https://bugs.webkit.org/show_bug.cgi?id=204634
7058 Reviewed by Žan Doberšek.
7060 When USE_ANGLE_WEBGL and USE_OPENGL_ES are enabled, many compiler warnings occur.
7061 This is because USE_OPENGL is defined nowhere if they are enabled.
7062 To fix this, USE_OPENGL is explicitly defined when USE_OPENGL_ES is enabled.
7064 * Source/cmake/OptionsGTK.cmake:
7066 2019-12-16 Simon Fraser <simon.fraser@apple.com>
7068 Let the DrawingArea decide whether scrolling is delegated
7069 https://bugs.webkit.org/show_bug.cgi?id=205258
7071 Reviewed by Anders Carlsson.
7073 Let Xcode have its way with the workspace file, after the libANGLE rename.
7075 * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
7077 2019-12-12 Don Olmstead <don.olmstead@sony.com>
7079 [CMake] Add LibPSL::LibPSL target
7080 https://bugs.webkit.org/show_bug.cgi?id=205149
7082 Reviewed by Michael Catanzaro.
7084 Add a LibPSL target into the FindLibPSL module.
7086 * Source/cmake/FindLibPSL.cmake:
7088 2019-12-11 Don Olmstead <don.olmstead@sony.com>
7090 [CMake] Add OpenJPEG find module
7091 https://bugs.webkit.org/show_bug.cgi?id=204657
7093 Reviewed by Michael Catanzaro.
7095 Add a FindOpenJPEG CMake module. Update GTK and WPE ports to use this and
7096 require v2.2.0 or later. Add support for OpenJPEG in WinCairo port.
7098 * Source/cmake/FindOpenJPEG.cmake: Added.
7099 * Source/cmake/OptionsGTK.cmake:
7100 * Source/cmake/OptionsWPE.cmake:
7101 * Source/cmake/OptionsWinCairo.cmake:
7103 2019-12-11 Don Olmstead <don.olmstead@sony.com>
7105 [CMake] Add HarfBuzz targets
7106 https://bugs.webkit.org/show_bug.cgi?id=205042
7108 Reviewed by Konstantin Tokarev.
7110 Modernize the FindHarfBuzz.cmake module so it creates targets that can be
7111 referenced rather than using HARFBUZZ_LIBRARIES and HARFBUZZ_INCLUDE_DIRS.
7112 Also making ICU a component within the module, and allowing alternate names
7113 for the library to be set by the platform.
7115 * Source/cmake/FindHarfBuzz.cmake:
7116 * Source/cmake/OptionsGTK.cmake:
7117 * Source/cmake/OptionsWPE.cmake:
7119 2019-12-03 Fujii Hironori <Hironori.Fujii@sony.com>
7121 Unreviewed, rolling out r253020.
7123 It breaks WinCairo bots.
7127 "[MSVC] Add /experimental:newLambdaProcessor switch for better
7129 https://bugs.webkit.org/show_bug.cgi?id=204443
7130 https://trac.webkit.org/changeset/253020
7132 2019-12-02 Fujii Hironori <Hironori.Fujii@sony.com>
7134 [MSVC] Add /experimental:newLambdaProcessor switch for better C++ conformance
7135 https://bugs.webkit.org/show_bug.cgi?id=204443
7137 Reviewed by Alex Christensen.
7139 MSVC has a bug of lambda capture of 'this'. It has caused
7140 compilation errors repeatedly.
7142 * Source/cmake/OptionsMSVC.cmake: Added /experimental:newLambdaProcessor switch.
7144 2019-11-28 Fujii Hironori <Hironori.Fujii@sony.com>
7146 Remove ENABLE_KEYBOARD_CODE_ATTRIBUTE and ENABLE_KEYBOARD_KEY_ATTRIBUTE macros
7147 https://bugs.webkit.org/show_bug.cgi?id=204666
7149 Reviewed by Ross Kirsling and Don Olmstead.
7151 * Source/cmake/OptionsFTW.cmake:
7152 * Source/cmake/OptionsMac.cmake:
7153 * Source/cmake/WebKitFeatures.cmake:
7155 2019-11-27 Alejandro G. Castro <alex@igalia.com>
7157 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.27.3 release
7159 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
7161 2019-11-26 Carlos Garcia Campos <cgarcia@igalia.com>
7163 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.27.3 release
7165 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
7167 2019-11-20 ChangSeok Oh <changseok@webkit.org>
7169 [GTK] Add ANGLE backend to GTK port
7170 https://bugs.webkit.org/show_bug.cgi?id=199060
7172 Reviewed by Žan Doberšek.
7174 This change brings ANGLE support for WebGL to GTK port. USE_ANGLE_WEBGL
7175 is newly defined in OptionGTK.cmake, and turns on the USE_ANGLE_EGL flag.
7177 * Source/cmake/OptionsGTK.cmake: USE_ANGLE_WEBGL added.
7179 2019-11-19 Devin Rousso <drousso@apple.com>
7181 Web Inspector: DOM.highlightSelector should work for "div, div::before"
7182 https://bugs.webkit.org/show_bug.cgi?id=204306
7184 Reviewed by Brian Burg.
7186 * ManualTests/inspector/overlay-selectors.html: Added.
7188 2019-11-12 Carlos Alberto Lopez Perez <clopez@igalia.com>
7190 [GTK][WPE] Support Pointer Events
7191 https://bugs.webkit.org/show_bug.cgi?id=202789
7193 Reviewed by Carlos Garcia Campos.
7195 Build support for PointerEvents when EXPERIMENTAL_FEATURES is enabled.
7196 Currently support for PointerEvents of pointerType==mouse works fine,
7197 but support for other type of PointerEvents is missing.
7199 * Source/cmake/OptionsGTK.cmake:
7200 * Source/cmake/OptionsWPE.cmake:
7202 2019-11-12 Carlos Alberto Lopez Perez <clopez@igalia.com>
7204 [GTK][WPE] Enable CSS Painting API
7205 https://bugs.webkit.org/show_bug.cgi?id=190710
7207 Reviewed by Don Olmstead.
7209 This enables the feature when building with experimental features enabled.
7211 * Source/cmake/OptionsGTK.cmake:
7212 * Source/cmake/OptionsWPE.cmake:
7214 2019-11-06 Carlos Garcia Campos <cgarcia@igalia.com>
7216 [GTK] Implement support for Pointer Lock API
7217 https://bugs.webkit.org/show_bug.cgi?id=202956
7219 Reviewed by Carlos Alberto Lopez Perez.
7221 Enable Pointer Lock for GTK port.
7223 * Source/cmake/OptionsGTK.cmake:
7225 2019-11-05 Fujii Hironori <Hironori.Fujii@sony.com>
7227 [Win][CMake] Build WebCore as an OBJECT library for WinCairo port
7228 https://bugs.webkit.org/show_bug.cgi?id=203663
7230 Reviewed by Ross Kirsling.
7232 WebCore is using __declspec(dllexport) to export symbols, but it
7233 is built as a static library rather than a DLL. If any symbols in
7234 an object file aren't referenced from WebKit.dll, they won't be
7235 included in WebKit.dll.
7237 This issue can be solved either by using OBJECT library for
7238 WebCore or using /WHOLEARCHIVE:WebCore.lib for WebKit.
7240 This change takes OBJECT library approach becuase it doesn't
7241 generate unnecessary static libs (WebCore.lib) and it's already
7242 used for non-unified source builds for the library size issue (Bug
7245 However, AppleWin can't use it because the Apple internal builds
7246 need to generate the static libs and OBJECT library doesn't work
7247 well with makesafeseh.obj.
7249 * Source/cmake/OptionsWin.cmake: Removed code overriding library types.
7250 * Source/cmake/OptionsWinCairo.cmake: Use OBJECT library types for WebCore and WebCoreTestSupport.
7252 2019-11-02 Devin Rousso <drousso@apple.com>
7254 Web Inspector: Add diagnostic logging for frontend feature usage
7255 https://bugs.webkit.org/show_bug.cgi?id=203579
7256 <rdar://problem/56717410>
7258 Reviewed by Brian Burg.
7260 Original patch by Matt Baker <mattbaker@apple.com>.
7262 * Source/cmake/OptionsMac.cmake:
7263 * Source/cmake/WebKitFeatures.cmake:
7264 Add `ENABLE_INSPECTOR_TELEMETRY`, which is only enabled for macOS.
7266 2019-11-01 Tim Horton <timothy_horton@apple.com>
7268 macCatalyst: Get TestWebKitAPI building
7269 https://bugs.webkit.org/show_bug.cgi?id=203728
7271 Reviewed by Alexey Proskuryakov.
7274 Descend into Tools/.
7276 2019-10-31 Alex Christensen <achristensen@apple.com>
7278 Enable more features in Mac CMake build
7279 https://bugs.webkit.org/show_bug.cgi?id=203699
7281 Rubber-stamped by Tim Horton.
7283 * Source/cmake/OptionsMac.cmake:
7284 * Source/cmake/WebKitFeatures.cmake:
7286 2019-10-31 Alex Christensen <achristensen@webkit.org>
7288 CMake build should make WebKit framework able to be used by Safari
7289 https://bugs.webkit.org/show_bug.cgi?id=203685
7291 Rubber-stamped by Tim Horton.
7293 * Source/cmake/OptionsMac.cmake:
7295 2019-10-29 Adrian Perez de Castro <aperez@igalia.com>
7297 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.27.2 release
7299 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
7301 2019-10-28 Carlos Alberto Lopez Perez <clopez@igalia.com>
7303 [GTK][WPE] Enable CSS typed OM
7304 https://bugs.webkit.org/show_bug.cgi?id=192875
7306 Reviewed by Carlos Garcia Campos.
7308 This enables the feature when building with experimental features enabled.
7310 * Source/cmake/OptionsGTK.cmake:
7311 * Source/cmake/OptionsWPE.cmake:
7313 2019-10-26 Chris Lord <clord@igalia.com>
7315 Put OffscreenCanvas behind a build flag
7316 https://bugs.webkit.org/show_bug.cgi?id=203146
7318 Reviewed by Ryosuke Niwa.
7320 Put OffscreenCanvas behind a build flag and enable building with
7321 experimental features on GTK and WPE.
7323 * Source/cmake/OptionsGTK.cmake:
7324 * Source/cmake/OptionsWPE.cmake:
7325 * Source/cmake/WebKitFeatures.cmake:
7327 2019-10-22 Carlos Garcia Campos <cgarcia@igalia.com>
7329 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.27.2 release
7331 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
7333 2019-10-22 Carlos Alberto Lopez Perez <clopez@igalia.com>
7335 [GTK][WPE] Enable service workers by default
7336 https://bugs.webkit.org/show_bug.cgi?id=200815
7338 Reviewed by Carlos Garcia Campos.
7340 Flip the build-time switch to be enabled by default and not only
7341 when building with experimental features enabled.
7343 * Source/cmake/OptionsGTK.cmake:
7344 * Source/cmake/OptionsWPE.cmake:
7346 2019-10-21 Alicia Boya García <aboya@igalia.com>
7348 [MSE][GStreamer] Revert WebKitMediaSrc rework temporarily
7349 https://bugs.webkit.org/show_bug.cgi?id=203078
7351 Reviewed by Carlos Garcia Campos.
7353 * Source/cmake/GStreamerChecks.cmake:
7355 2019-10-11 Konstantin Tokarev <annulen@yandex.ru>
7357 [cmake] Use HINTS instead of PATHS when searching in paths from pkg-config
7358 https://bugs.webkit.org/show_bug.cgi?id=202831
7360 Reviewed by Carlos Garcia Campos.
7362 HINTS and PATHS sections are similar, however HINTS is processed before
7363 default system locations, while PATHS - after. If target file can be found
7364 in the system, pkg-config results are ignored in case of PATHS, making it
7365 impossible to override system version of library with PKG_CONFIG_PATH.
7367 Note that CMake documentation recommends using PATHS for hard-coded guesses.
7369 * Source/cmake/FindEnchant.cmake:
7370 * Source/cmake/FindFontconfig.cmake:
7371 * Source/cmake/FindLibEpoxy.cmake:
7372 * Source/cmake/FindLibtasn1.cmake:
7373 * Source/cmake/FindSqlite.cmake:
7375 2019-10-08 Adrian Perez de Castro <aperez@igalia.com>
7377 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.27.1 release
7379 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
7381 2019-10-04 Carlos Garcia Campos <cgarcia@igalia.com>
7383 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.27.1 release
7385 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
7387 2019-10-02 Alex Christensen <achristensen@webkit.org>
7389 CMake-built WebKit.framework should launch XPC services successfully
7390 https://bugs.webkit.org/show_bug.cgi?id=202490
7392 Rubber-stamped by Tim Horton.
7394 * Source/cmake/OptionsMac.cmake:
7396 2019-10-02 Carlos Garcia Campos <cgarcia@igalia.com>
7398 [GTK][WPE] Stop using legacy custom protocol implementation
7399 https://bugs.webkit.org/show_bug.cgi?id=202407
7401 Reviewed by Žan Doberšek.
7403 Make LEGACY_CUSTOM_PROTOCOL_MANAGER disabled by default.
7405 * Source/cmake/OptionsFTW.cmake:
7406 * Source/cmake/OptionsPlayStation.cmake:
7407 * Source/cmake/OptionsWin.cmake:
7408 * Source/cmake/WebKitFeatures.cmake:
7410 2019-10-02 Zan Dobersek <zdobersek@igalia.com>
7412 [Nicosia] Enable async scrolling at build-time for Nicosia-using ports
7413 https://bugs.webkit.org/show_bug.cgi?id=202397
7415 Reviewed by Carlos Garcia Campos.
7417 Enable ASYNC_SCROLLING code for ports leveraging the Nicosia layering
7418 system. This still has to be runtime-enabled in the DrawingArea
7421 * Source/cmake/OptionsGTK.cmake:
7422 * Source/cmake/OptionsPlayStation.cmake:
7423 * Source/cmake/OptionsWPE.cmake:
7425 2019-09-30 Alex Christensen <achristensen@webkit.org>
7427 Resurrect Mac CMake build
7428 https://bugs.webkit.org/show_bug.cgi?id=202384
7430 Rubber-stamped by Tim Horton.
7432 * Source/cmake/OptionsMac.cmake:
7434 2019-09-30 Carlos Garcia Campos <cgarcia@igalia.com>
7436 [GTK][WPE] Add about:gpu
7437 https://bugs.webkit.org/show_bug.cgi?id=202305
7439 Reviewed by Žan Doberšek.
7441 Add SVN_REVISION definition to the build.
7443 * Source/cmake/OptionsGTK.cmake:
7444 * Source/cmake/OptionsWPE.cmake:
7446 2019-09-23 Zan Dobersek <zdobersek@igalia.com>
7448 run-web-platform-tests: remove support for in-repository manifest, expectation management
7449 https://bugs.webkit.org/show_bug.cgi?id=202037
7451 Reviewed by Carlos Alberto Lopez Perez.
7453 Remove the test expecations JSON and test manifest file that were used
7454 for managing and generating the necessary wptrunner metadata.
7456 * WebPlatformTests/gtk/TestExpectations.json: Removed.
7457 * WebPlatformTests/gtk/TestManifest.ini: Removed.
7459 2019-09-20 Adrian Perez de Castro <aperez@igalia.com>
7461 Unreviewed. Bump WPE version numbers.
7463 * Source/cmake/OptionsWPE.cmake:
7465 2019-09-17 Fujii Hironori <Hironori.Fujii@sony.com>
7467 [WinCairo][curl] Define NOCRYPT to suppress libressl "Warning, overriding WinCrypt defines"
7468 https://bugs.webkit.org/show_bug.cgi?id=201858
7470 Reviewed by Alex Christensen.
7472 LibreSSL headers are reporing a compilation warning for overriding
7473 WinCrypt defines. Define NOCRYPT to let windows.h not to include
7474 WinCrypt for WinCairo port.
7476 * Source/cmake/OptionsWinCairo.cmake: Added -DNOCRYPT.
7478 2019-09-15 Adrian Perez de Castro <aperez@igalia.com>
7480 [GTK][WPE] Do not run the Bubblewrap executable when configuring for cross-compilation
7481 https://bugs.webkit.org/show_bug.cgi?id=201340
7483 Reviewed by Konstantin Tokarev.
7485 * Source/cmake/BubblewrapSandboxChecks.cmake: Do not run the
7486 Bubblewrap executable when cross-compiling to guess its version.
7487 Emit a warning instead and trust that valid run-time paths will
7488 be set using the BWRAP_EXECUTABLE and DBUS_PROXY_EXECUTABLE
7489 variables. While at it, fix the regular expression used to match
7490 the version string in the Bubblewrap output when not cross-compiling.
7492 2019-09-09 Carlos Garcia Campos <cgarcia@igalia.com>
7494 Unreviewed. Bump GTK version numbers
7496 * Source/cmake/OptionsGTK.cmake:
7498 2019-08-23 Alex Christensen <achristensen@webkit.org>
7500 Remove NPAPI Examples
7501 https://bugs.webkit.org/show_bug.cgi?id=201089
7503 Reviewed by Alexey Proskuryakov.
7505 We are only supporting NPAPI for flash until its upcoming end of life.
7506 We don't need to encourage the creation of new NPAPI plugins by having examples.
7508 * Examples: Removed.
7510 2019-08-21 Adrian Perez de Castro <aperez@igalia.com>
7512 [GTK][WPE] Gtk-Doc fails with build options which need cooperation between CFLAGS and LDFLAGS
7513 https://bugs.webkit.org/show_bug.cgi?id=200987
7515 Reviewed by Philippe Normand.
7517 Only CFLAGS was being set before trying to generate the documentation
7518 but not LDFLAGS, which could cause errors when gtk-doc tries to link
7519 a generated program when the compiler flags would also require usage
7520 of certain linker flags later on.
7522 * Source/cmake/GtkDoc.cmake: Also set LDFLAGS in the environment when
7523 invoking Tools/gtkdoc/generate-gtkdoc.
7525 2019-08-16 Ross Kirsling <ross.kirsling@sony.com>
7527 [Win] WebCoreTestSupport is too big to link
7528 https://bugs.webkit.org/show_bug.cgi?id=200820
7530 Reviewed by Don Olmstead.
7532 * Source/cmake/OptionsWin.cmake:
7533 As with WebCore itself, build WebCoreTestSupport as an object library when unified builds are disabled
7534 (and we haven't explicitly asked to build it as a shared library).
7536 2019-08-08 Brent Fulgham <bfulgham@apple.com>
7538 [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
7539 https://bugs.webkit.org/show_bug.cgi?id=200539
7540 <rdar://problem/54082550>
7542 Reviewed by Dean Jackson.
7544 * Source/cmake/OptionsFTW.cmake:
7546 2019-08-02 Carlos Garcia Campos <cgarcia@igalia.com>
7548 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.25.4 release
7550 * Source/cmake/OptionsGTK.cmake: Bump version numbers
7552 2019-07-31 Carlos Garcia Campos <cgarcia@igalia.com>
7554 [GTK] Datalist element support for TextFieldInputType
7555 https://bugs.webkit.org/show_bug.cgi?id=98934
7557 Reviewed by Michael Catanzaro.
7559 Enable DATALIST_ELEMENT.
7561 * Source/cmake/OptionsGTK.cmake:
7563 2019-07-24 Fujii Hironori <fujii.hironori@gmail.com>
7565 [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
7566 https://bugs.webkit.org/show_bug.cgi?id=200074
7568 Reviewed by Michael Catanzaro.
7570 Although WebKitCompilerFlags.cmake adds "-Wl,--no-undefined" to
7571 CMAKE_SHARED_LINKER_FLAGS, it wasn't effective because
7572 OptionsCommon.cmake inadvertently override the value with
7573 CMAKE_EXE_LINKER_FLAGS as:
7575 > set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ...")
7577 * Source/cmake/OptionsCommon.cmake: Use string(APPEND) to modify
7578 CMAKE_*_LINKER_FLAGS variables to avoid typos.
7580 2019-07-23 Carlos Garcia Campos <cgarcia@igalia.com>
7582 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.25.3 release
7584 * Source/cmake/OptionsGTK.cmake: Bump version numbers
7586 2019-07-18 Carlos Garcia Campos <cgarcia@igalia.com>
7588 [GTK] MOUSE_CURSOR_SCALE is not implemented
7589 https://bugs.webkit.org/show_bug.cgi?id=109469
7591 Reviewed by Darin Adler.
7593 Enable MOUSE_CURSOR_SCALE for the GTK port.
7595 * Source/cmake/OptionsGTK.cmake:
7597 2019-07-11 Pablo Saavedra <psaavedra@igalia.com>
7599 [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
7600 https://bugs.webkit.org/show_bug.cgi?id=199625
7602 Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
7603 with ENABLE(ACCESSIBILITY) in the code.
7605 Additionally, the TestRunner code generator now honors the
7606 Conditional IDL format.
7608 Reviewed by Konstantin Tokarev.
7610 * Source/cmake/OptionsWPE.cmake:
7611 * Source/cmake/WebKitFeatures.cmake:
7613 2019-07-10 Carlos Alberto Lopez Perez <clopez@igalia.com>
7615 [GTK][WPE] Enable support for CSS_COMPOSITING
7616 https://bugs.webkit.org/show_bug.cgi?id=199513
7618 Reviewed by Michael Catanzaro.
7620 This feature is needed to support the CSS properties "mix-blend-mode" and "isolation".
7621 Enable it for all ports except for AppleWin (doesn't build).
7623 It has been tested that it builds on the EWS bots of all the ports enabled (for those that have an EWS).
7624 Also, for the GTK and WPE ports it also has been tested that the feature works fine on most of the cases and that doesn't cause regressions.
7626 * Source/cmake/OptionsFTW.cmake: Enable the feature.
7627 * Source/cmake/OptionsMac.cmake: Use the new default.
7628 * Source/cmake/OptionsWin.cmake: Enable for WinCairo only.
7629 * Source/cmake/WebKitFeatures.cmake: Enable it Globally
7631 2019-06-28 Brent Fulgham <bfulgham@apple.com>
7634 https://bugs.webkit.org/show_bug.cgi?id=199199
7636 Reviewed by Don Olmstead.
7638 Establish a set of build options for the FTW port, based on the current WinCairo
7639 feature set. I also note which features should be turned on, but aren't yet, as
7640 well as which features are disabled due to lack of WebGL and Media support in
7643 * Source/cmake/OptionsFTW.cmake:
7645 2019-06-28 Konstantin Tokarev <annulen@yandex.ru>
7647 Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
7648 https://bugs.webkit.org/show_bug.cgi?id=199317
7650 Reviewed by Michael Catanzaro.
7652 While IconDatabase and all code using it was removed,
7653 ENABLE_ICONDATABASE still exists as build option and C++ macro.
7655 * Source/cmake/OptionsGTK.cmake:
7656 * Source/cmake/OptionsPlayStation.cmake:
7657 * Source/cmake/OptionsWin.cmake:
7658 * Source/cmake/WebKitFeatures.cmake:
7659 * Source/cmake/tools/vsprops/FeatureDefines.props:
7660 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
7662 2019-06-27 Don Olmstead <don.olmstead@sony.com>
7664 [FTW] Build JavaScriptCore
7665 https://bugs.webkit.org/show_bug.cgi?id=199254
7667 Reviewed by Brent Fulgham.
7669 Add the FTW [For the Win(dows)] port. FTW is OS(WINDOWS) + USE(DIRECT2D) +
7670 USE(CURL). Its eventual goal is to be the one true Windows port but to avoid
7671 breaking AppleWin and WinCairo its being split into its own port for the interim.
7674 * Source/cmake/OptionsFTW.cmake: Added.
7676 2019-06-27 Fujii Hironori <Hironori.Fujii@sony.com>
7678 [CMake] Bump cmake_minimum_required version to 3.10
7679 https://bugs.webkit.org/show_bug.cgi?id=199181
7681 Reviewed by Don Olmstead.
7685 2019-06-21 Konstantin Tokarev <annulen@yandex.ru>
7687 [cmake] Switch to built-in handling of C++ standard instead of hardcoding -std=c++17
7688 https://bugs.webkit.org/show_bug.cgi?id=199108
7690 Reviewed by Don Olmstead.
7694 1. It provides an abstraction over exact flags of particular compilers -
7695 we just specify required version of C++ standard
7696 2. External libraries (like Qt used in WPEQt) may require particular C++
7697 standard or even particular C++ features to be availabe (e.g. Qt
7698 requires INTERFACE_COMPILE_FEATURES cxx_decltype, which causes cmake
7699 to add -std=gnu++11 unless proper CXX_STANDARD is defined)
7701 * Source/cmake/OptionsCommon.cmake:
7702 * Source/cmake/OptionsMSVC.cmake:
7703 * Source/cmake/WebKitCompilerFlags.cmake:
7705 2019-06-25 Michael Catanzaro <mcatanzaro@igalia.com>
7707 Fully rename WebKitGTK+ -> WebKitGTK everywhere
7708 https://bugs.webkit.org/show_bug.cgi?id=199159
7710 Reviewed by Carlos Garcia Campos.
7712 * Source/cmake/FindGLIB.cmake:
7714 2019-06-25 Michael Catanzaro <mcatanzaro@igalia.com>
7717 https://bugs.webkit.org/show_bug.cgi?id=198914
7719 Reviewed by Darin Adler.
7723 2019-06-21 Michael Catanzaro <mcatanzaro@igalia.com>
7725 [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
7726 https://bugs.webkit.org/show_bug.cgi?id=199094
7728 Reviewed by Carlos Garcia Campos.
7730 We can remove a lot of preprocessor guards in our code if we bump the minimum required
7731 versions of certain dependencies:
7733 GStreamer 1.8 -> 1.10
7736 libsoup 2.42 -> 2.54
7740 I'm being extremely conservative with all these dependency bumps. All of these versions are
7741 already available in Debian Stretch, which we will soon no longer support building on anyway
7742 due to the impending GCC 7 requirement. Dependencies are also bumped no further than we
7743 actually have guards for. For example, ATK 2.22 is available in Stretch, but the highest
7744 ATK_CHECK_VERSION guards we use below 2.22 are for 2.16, so I set the min version to 2.16.
7746 We still have a few preprocessor guards remaining for everything here except glib and cairo,
7747 but this removes the vast majority of them. Deleting code is fun!
7749 * Source/cmake/FindGTK3.cmake:
7750 * Source/cmake/GStreamerChecks.cmake:
7751 * Source/cmake/OptionsGTK.cmake:
7752 * Source/cmake/OptionsWPE.cmake:
7754 2019-06-20 Carlos Garcia Campos <cgarcia@igalia.com>
7756 [GTK] Remove support for GTK2 plugins
7757 https://bugs.webkit.org/show_bug.cgi?id=199065
7759 Reviewed by Sergio Villar Senin.
7761 * Source/cmake/FindGDK2.cmake: Removed.
7762 * Source/cmake/FindGTK2.cmake: Removed.
7763 * Source/cmake/OptionsGTK.cmake:
7765 2019-06-18 Adrian Perez de Castro <aperez@igalia.com>
7767 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.25.1 release
7769 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
7771 2019-06-17 Carlos Garcia Campos <cgarcia@igalia.com>
7773 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.25.2 release
7775 * Source/cmake/OptionsGTK.cmake: Bump version numbers
7777 2019-06-17 Carlos Garcia Campos <cgarcia@igalia.com>
7779 Unreviewed. [GTK] Bump WPEBackend-fdo requirement to 1.3.1
7781 * Source/cmake/OptionsGTK.cmake:
7783 2019-06-13 Tim Horton <timothy_horton@apple.com>
7785 Make it possible for validate-committer-lists to dump a mailmap file
7786 https://bugs.webkit.org/show_bug.cgi?id=198517
7788 Reviewed by Simon Fraser.
7791 Ignore .mailmap files.
7793 2019-06-11 Carlos Garcia Campos <cgarcia@igalia.com>
7795 [GTK] Remove option REDIRECTED_XCOMPOSITE_WINDOW
7796 https://bugs.webkit.org/show_bug.cgi?id=198748
7798 Reviewed by Žan Doberšek.
7800 * Source/cmake/OptionsGTK.cmake: Remove USE_REDIRECTED_XCOMPOSITE_WINDOW build option.
7802 2019-06-10 Sam Weinig <weinig@apple.com>
7804 Remove Dashboard support
7805 https://bugs.webkit.org/show_bug.cgi?id=198615
7807 Reviewed by Ryosuke Niwa.
7809 * Source/cmake/OptionsMac.cmake:
7810 * Source/cmake/WebKitFeatures.cmake:
7812 2019-06-10 Philippe Normand <pnormand@igalia.com>
7814 [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
7815 https://bugs.webkit.org/show_bug.cgi?id=198713
7817 Reviewed by Carlos Garcia Campos.
7819 * Source/cmake/OptionsWPE.cmake:
7821 2019-06-04 Takashi Komori <Takashi.Komori@sony.com>
7823 [WinCairo] Implement cpu and memory measuring functions.
7824 https://bugs.webkit.org/show_bug.cgi?id=198466
7826 Reviewed by Don Olmstead.
7828 * Source/cmake/OptionsWin.cmake:
7830 2019-06-03 Zan Dobersek <zdobersek@igalia.com>
7832 [Nicosia] Disable async scrolling until implemented
7833 https://bugs.webkit.org/show_bug.cgi?id=198476
7835 Reviewed by Antti Koivisto.
7837 Disable async scrolling on Nicosia-using ports until the underlying
7838 implementation is complete, allowing easier refactorings of the general
7839 async scrolling system.
7841 * Source/cmake/OptionsGTK.cmake:
7842 * Source/cmake/OptionsPlayStation.cmake:
7843 * Source/cmake/OptionsWPE.cmake:
7845 2019-05-30 Don Olmstead <don.olmstead@sony.com>
7847 [CMake] Add WEBKIT_FRAMEWORK_TARGET macro
7848 https://bugs.webkit.org/show_bug.cgi?id=198396
7850 Reviewed by Konstantin Tokarev.
7852 Add a macro to help create the WebKit::targets in CMake.
7855 * Source/cmake/WebKitMacros.cmake:
7857 2019-05-29 Don Olmstead <don.olmstead@sony.com>
7859 Remove ENABLE definitions from WebKit config files
7860 https://bugs.webkit.org/show_bug.cgi?id=197858
7862 Reviewed by Simon Fraser.
7864 Add ENABLE flags into WebKitFeatures.cmake and set the values for GTK and WPE according
7865 to what was present in the config files.
7867 * Source/cmake/OptionsGTK.cmake:
7868 * Source/cmake/OptionsWPE.cmake:
7869 * Source/cmake/WebKitFeatures.cmake:
7871 2019-05-27 Carlos Garcia Campos <cgarcia@igalia.com>
7873 [GTK] Use WPEBackend-fdo for accelerating compositing in Wayland instead of the nested compositor
7874 https://bugs.webkit.org/show_bug.cgi?id=197944
7876 Reviewed by Michael Catanzaro.
7878 Add USE_WPE_RENDERER option to use WPEBackend-fdo.
7880 * Source/cmake/OptionsGTK.cmake:
7881 * Source/cmake/OptionsPlayStation.cmake:
7882 * Source/cmake/OptionsWPE.cmake:
7884 2019-05-27 Carlos Garcia Campos <cgarcia@igalia.com>
7886 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.25.1 release
7888 * Source/cmake/OptionsGTK.cmake: Bump version numbers
7890 2019-05-23 Don Olmstead <don.olmstead@sony.com>
7892 [CMake] Use target oriented design for bmalloc
7893 https://bugs.webkit.org/show_bug.cgi?id=198046
7895 Reviewed by Konstantin Tokarev.
7897 Add WEBKIT_COPY_FILES to WebKitMacros so it is available to all CMake code. Add
7898 bmalloc_FRAMEWORK_HEADERS_DIR for specifying the location to copy bmalloc headers to.
7900 * Source/cmake/WebKitFS.cmake:
7901 * Source/cmake/WebKitMacros.cmake:
7903 2019-05-21 Don Olmstead <don.olmstead@sony.com>
7905 [WinCairo] Build WebDriver
7906 https://bugs.webkit.org/show_bug.cgi?id=198056
7908 Reviewed by Carlos Garcia Campos.
7910 Add ENABLE_WEBDRIVER as an experimental feature for WinCairo.
7912 * Source/cmake/OptionsWin.cmake:
7914 2019-05-21 Carlos Garcia Campos <cgarcia@igalia.com>
7916 [WPE] Add initial accessibility support using ATK
7917 https://bugs.webkit.org/show_bug.cgi?id=197413
7919 Reviewed by Michael Catanzaro.
7921 Add ENABLE_ACCESSIBILITY public option to WPE.
7923 * Source/cmake/OptionsGTK.cmake:
7924 * Source/cmake/OptionsWPE.cmake:
7926 2019-05-20 Ross Kirsling <ross.kirsling@sony.com>
7928 [WinCairo] Implement Remote Web Inspector Client.
7929 https://bugs.webkit.org/show_bug.cgi?id=197434
7931 Reviewed by Don Olmstead.
7933 * Source/cmake/OptionsWin.cmake:
7934 * Source/cmake/OptionsWinCairo.cmake:
7936 2019-05-17 Don Olmstead <don.olmstead@sony.com>
7938 [CMake] Use builtin FindICU
7939 https://bugs.webkit.org/show_bug.cgi?id=197934
7941 Reviewed by Michael Catanzaro.
7943 Update CMake minimum required to 3.7. 3.7 has a FindICU module so the WebKit one
7944 is removed. For non-Apple ports this just requires adding individual components of
7945 ICU to find_package(ICU). For Apple ports the module does not work so the targets
7946 created in FindICU are mirrored in target/icu.cmake.
7949 * Source/cmake/FindICU.cmake: Removed.
7950 * Source/cmake/OptionsAppleWin.cmake:
7951 * Source/cmake/OptionsGTK.cmake:
7952 * Source/cmake/OptionsJSCOnly.cmake:
7953 * Source/cmake/OptionsMac.cmake:
7954 * Source/cmake/OptionsPlayStation.cmake:
7955 * Source/cmake/OptionsWPE.cmake:
7956 * Source/cmake/OptionsWin.cmake:
7957 * Source/cmake/OptionsWinCairo.cmake:
7958 * Source/cmake/target/icu.cmake: Added.
7960 2019-05-09 Xan López <xan@igalia.com>
7962 [CMake] Detect SSE2 at compile time
7963 https://bugs.webkit.org/show_bug.cgi?id=196488
7965 Reviewed by Carlos Garcia Campos.
7967 * Source/cmake/DetectSSE2.cmake: Added.
7968 * Source/cmake/WebKitCompilerFlags.cmake: Detect SSE2 support and
7969 add SSE2 to the global compiler flags.
7971 2019-05-08 Don Olmstead <don.olmstead@sony.com>
7973 [PlayStation] Update port options
7974 https://bugs.webkit.org/show_bug.cgi?id=197723
7976 Reviewed by Ross Kirsling.
7978 Update the options used.
7980 * Source/cmake/OptionsPlayStation.cmake:
7982 2019-05-08 Ross Kirsling <ross.kirsling@sony.com>
7984 Add .vs and .vscode directories to .gitignore.
7985 https://bugs.webkit.org/show_bug.cgi?id=197727
7987 Reviewed by Don Olmstead.
7991 2019-05-07 Keith Rollin <krollin@apple.com>
7993 Add option to build-webkit to control whether or not XCBuild is used
7994 https://bugs.webkit.org/show_bug.cgi?id=197668
7995 <rdar://problem/50549728>
7997 Reviewed by Tim Horton.
7999 Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
8000 Also update build-webkit and the makefiles with the foundation for
8001 automatically using XCBuild when the conditions allow it. This latter
8002 facility is currently turned off until Xcode fully supports building
8003 WebKit with XCBuild.
8007 2019-05-06 Christopher Reid <chris.reid@sony.com>
8009 [CMake] fuse-ld should also be set in module linker flags
8010 https://bugs.webkit.org/show_bug.cgi?id=197583
8012 Reviewed by Michael Catanzaro.
8014 Add fuse-ld to CMAKE_MODULE_LINKER_FLAGS.
8016 * Source/cmake/OptionsCommon.cmake:
8018 2019-05-03 Basuke Suzuki <Basuke.Suzuki@sony.com>
8020 [WinCairo] Implement and enable RemoteInspector Server.
8021 https://bugs.webkit.org/show_bug.cgi?id=197432
8023 Reviewed by Ross Kirsling.
8025 Add new build flag USE_INSPECTOR_SOCKET_SERVER to indicate using Socket implementation for RemoteInspector
8026 protocol. Currently PlayStation is the only platform which uses this. WinCairo is the second one.
8028 * Source/cmake/OptionsPlayStation.cmake:
8029 * Source/cmake/OptionsWin.cmake:
8030 * Source/cmake/OptionsWinCairo.cmake:
8032 2019-05-03 Commit Queue <commit-queue@webkit.org>
8034 Unreviewed, rolling out r244881.
8035 https://bugs.webkit.org/show_bug.cgi?id=197559
8037 Breaks compilation of jsconly on linux, breaking compilation
8038 for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
8039 guijemont on #webkit).
8043 "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
8045 https://bugs.webkit.org/show_bug.cgi?id=197174
8046 https://trac.webkit.org/changeset/244881
8048 2019-05-02 Christopher Reid <chris.reid@sony.com>
8050 [CMake] Add support for LTO builds
8051 https://bugs.webkit.org/show_bug.cgi?id=188986
8053 Reviewed by Don Olmstead.
8055 Add LTO_MODE cmake variable to enable flto in clang builds.
8056 Add support to use ld.lld to build with LTO.
8058 * Source/cmake/OptionsCommon.cmake:
8059 * Source/cmake/WebKitCompilerFlags.cmake:
8061 2019-05-02 Don Olmstead <don.olmstead@sony.com>
8063 [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
8064 https://bugs.webkit.org/show_bug.cgi?id=197174
8066 Reviewed by Alex Christensen.
8068 Replace WEBKIT_MAKE_FORWARDING_HEADERS with WEBKIT_COPY_FILES which is a general
8069 purpose macro that copies files to a destination. WEBKIT_COPY_FILES removes the
8070 requirement of a target being passed in so there is no longer any implicit dependency
8071 between the target and the copying. Instead the dependencies need to be explicit.
8073 This opens the macro up for use by third party libraries and for copying other files
8076 * Source/cmake/WebKitMacros.cmake:
8078 2019-05-01 Stephan Szabo <stephan.szabo@sony.com>
8080 [PlayStation] Update port for WEBKIT_EXECUTABLE changes
8081 https://bugs.webkit.org/show_bug.cgi?id=197483
8083 Reviewed by Don Olmstead.
8085 * Source/cmake/OptionsPlayStation.cmake:
8086 Update wrapping for configuring executables' playstation
8087 specific data to new WEBKIT_EXECUTABLE macro.
8089 2019-04-30 Carlos Garcia Campos <cgarcia@igalia.com>
8091 [GTK] Support prefers-color-scheme media query
8092 https://bugs.webkit.org/show_bug.cgi?id=196685
8094 Reviewed by Michael Catanzaro.
8096 Enable DARK_MODE_CSS. Supported color schemes feature is not supported for now. I'm not sure we will be able to
8097 suport it, because it requires to change the theme too many times, which is very slow in GTK.
8099 * Source/cmake/OptionsGTK.cmake:
8101 2019-04-29 Don Olmstead <don.olmstead@sony.com>
8103 [CMake] Add WEBKIT_EXECUTABLE macro
8104 https://bugs.webkit.org/show_bug.cgi?id=197206
8106 Unreviewed build fix.
8108 Calls to add_dependencies were not happening.
8110 * Source/cmake/WebKitMacros.cmake:
8112 2019-04-29 Basuke Suzuki <Basuke.Suzuki@sony.com>
8114 [Win] Add flag to enable version information stamping and disable by default.
8115 https://bugs.webkit.org/show_bug.cgi?id=197249
8116 <rdar://problem/50224412>
8118 Reviewed by Ross Kirsling.
8120 This feature is only used in AppleWin port. Add flag for this task and make it OFF by default.
8121 Then enable it by default on AppleWin.
8123 * Source/cmake/OptionsWin.cmake:
8125 2019-04-28 Andy Estes <aestes@apple.com>
8127 Fix the watchOS engineering build.
8129 * Source/Makefile: Moved libwebrtc logic into Source/ThirdParty/Makefile.
8131 2019-04-26 Don Olmstead <don.olmstead@sony.com>
8133 [CMake] Add WEBKIT_EXECUTABLE macro
8134 https://bugs.webkit.org/show_bug.cgi?id=197206
8136 Reviewed by Konstantin Tokarev.
8138 Add WEBKIT_EXECUTABLE macro for creating executable targets. This wraps the creation of
8139 executable targets using the same conventions of WEBKIT_FRAMEWORK.
8141 Common code from the two macros were moved to WEBKIT_TARGET which is meant as an internal
8144 Add WEBKIT_WRAP_EXECUTABLE macro to support Windows targets which use a DLLLauncherMain to
8145 launch the executable.
8147 * Source/cmake/WebKitMacros.cmake:
8149 2019-04-25 Fujii Hironori <Hironori.Fujii@sony.com>
8151 Unreviewed, rolling out r244669.
8153 Windows ports can't clean build.
8157 "[Win] Add flag to enable version information stamping and
8158 disable by default."
8159 https://bugs.webkit.org/show_bug.cgi?id=197249
8160 https://trac.webkit.org/changeset/244669
8162 2019-04-25 Basuke Suzuki <Basuke.Suzuki@sony.com>
8164 [Win] Add flag to enable version information stamping and disable by default.
8165 https://bugs.webkit.org/show_bug.cgi?id=197249
8167 Reviewed by Ross Kirsling.
8169 This feature is only used in AppleWin port. Add flag for this task and make it OFF by default.
8170 Then enable it by default on AppleWin.
8172 * Source/cmake/OptionsWin.cmake:
8174 2019-04-25 Alex Christensen <achristensen@webkit.org>
8177 https://bugs.webkit.org/show_bug.cgi?id=197131
8179 Reviewed by Darin Adler.
8181 * Source/cmake/OptionsMSVC.cmake:
8182 * Source/cmake/WebKitCompilerFlags.cmake:
8184 2019-04-24 Carlos Garcia Campos <cgarcia@igalia.com>
8186 [GTK] Hardcoded text color in input fields
8187 https://bugs.webkit.org/show_bug.cgi?id=126907
8189 Reviewed by Michael Catanzaro.
8191 Set and expose to build HAVE_OS_DARK_MODE_SUPPORT=1.
8193 * Source/cmake/OptionsGTK.cmake:
8195 2019-04-23 Don Olmstead <don.olmstead@sony.com>
8197 [CMake][Win] Use target oriented design for WebKit
8198 https://bugs.webkit.org/show_bug.cgi?id=197173
8200 Reviewed by Alex Christensen.
8202 Override WebKit_DERIVED_SOUCES_DIR within WinCairo in support of a target
8205 * Source/cmake/OptionsWinCairo.cmake:
8207 2019-04-20 Don Olmstead <don.olmstead@sony.com>
8209 [CMake][Win] Use target oriented design for WebKitLegacy
8210 https://bugs.webkit.org/show_bug.cgi?id=197112
8212 Reviewed by Konstantin Tokarev.
8214 Override WebKitLegacy_DERIVED_SOURCES_DIR within WinCairo in support of a target
8217 * Source/cmake/OptionsWinCairo.cmake:
8219 2019-04-18 Ross Kirsling <ross.kirsling@sony.com>
8221 [WinCairo] Non-unified build fails to link Tools
8222 https://bugs.webkit.org/show_bug.cgi?id=196866
8224 Reviewed by Fujii Hironori.
8226 * Source/cmake/OptionsWin.cmake:
8227 Build WebCore as an object library when unified builds are disabled
8228 (and we haven't explicitly asked to build it as a shared library).
8229 This is necessary for two reasons:
8230 - Non-unified WebCore.lib is too large for the MSVC linker to create (>4GB).
8231 - Some WebCore object files are not actually used, but DumpRenderTree and TestRunnerInjectedBundle
8232 still expect that their symbols will be re-exported via WebKit[Legacy].
8234 2019-04-17 Jer Noble <jer.noble@apple.com>
8236 Automatically use ccache when available for Makefile builds
8237 https://bugs.webkit.org/show_bug.cgi?id=197020
8239 Reviewed by Alex Christensen.
8243 2019-04-16 Don Olmstead <don.olmstead@sony.com>
8245 [CMake] Set WTF_SCRIPTS_DIR
8246 https://bugs.webkit.org/show_bug.cgi?id=196917
8248 Reviewed by Konstantin Tokarev.
8250 Define WTF_SCRIPTS_DIR in WebKitFS.cmake and use that within the WEBKIT_COMPUTE_SOURCES
8251 macro. This allows it to be overridden by a port such as the AppleWin internal build.
8253 * Source/cmake/OptionsAppleWin.cmake:
8254 * Source/cmake/OptionsWinCairo.cmake:
8255 * Source/cmake/WebKitFS.cmake:
8256 * Source/cmake/WebKitMacros.cmake:
8258 2019-04-15 Don Olmstead <don.olmstead@sony.com>
8260 [CMake] WebCore derived sources should only be referenced inside WebCore
8261 https://bugs.webkit.org/show_bug.cgi?id=196904
8263 Reviewed by Konstantin Tokarev.
8265 Override WebCore_DERIVED_SOURCES_DIR for WinCairo.
8267 * Source/cmake/OptionsWinCairo.cmake:
8269 2019-04-14 Don Olmstead <don.olmstead@sony.com>
8271 [CMake] JavaScriptCore derived sources should only be referenced inside JavaScriptCore
8272 https://bugs.webkit.org/show_bug.cgi?id=196742
8274 Reviewed by Konstantin Tokarev.
8276 Migrate to using JavaScriptCore_DERIVED_SOURCES_DIR instead of DERIVED_SOURCES_JAVASCRIPTCORE_DIR
8277 to support moving the JavaScriptCore derived sources outside of a shared directory.
8278 This is in support of the target oriented design refactoring.
8280 WinCairo is explicitly overriding the value as a canary for this setup.
8282 Also move JavaScriptCore_SCRIPTS_DIR to WebKitFS to remove logic setting it in other projects.
8284 * Source/PlatformWin.cmake:
8285 * Source/cmake/OptionsAppleWin.cmake:
8286 * Source/cmake/OptionsWinCairo.cmake:
8287 * Source/cmake/WebKitFS.cmake:
8289 2019-04-10 Michael Catanzaro <mcatanzaro@igalia.com>
8291 Unreviewed, rolling out r243989.
8297 "[CMake] Detect SSE2 at compile time"
8298 https://bugs.webkit.org/show_bug.cgi?id=196488
8299 https://trac.webkit.org/changeset/243989
8301 2019-04-09 Don Olmstead <don.olmstead@sony.com>
8303 [CMake] WEBKIT_COMPUTE_SOURCES should use the target's derived sources directory
8304 https://bugs.webkit.org/show_bug.cgi?id=196741
8306 Reviewed by Michael Catanzaro.
8308 WEBKIT_COMPUTE_SOURCES is using ${DERIVED_SOURCES_DIR} directly. Instead it should
8309 rely on the directory specified by the target.
8311 * Source/cmake/WebKitFS.cmake:
8312 Add variables that can be expanded within CMake to the derived sources directory for
8315 * Source/cmake/WebKitMacros.cmake:
8316 Use variable expansion rather than ${DERIVED_SOURCES_DIR} to determine the target's
8317 derived sources directory.
8319 2019-04-09 Don Olmstead <don.olmstead@sony.com>
8321 [CMake] WTF derived sources should only be referenced inside WTF
8322 https://bugs.webkit.org/show_bug.cgi?id=196706
8324 Reviewed by Konstantin Tokarev.
8326 * Source/cmake/OptionsWinCairo.cmake:
8327 * Source/cmake/WebKitFS.cmake:
8329 2019-04-09 Don Olmstead <don.olmstead@sony.com>
8331 [CMake] Apple builds should use ICU_INCLUDE_DIRS
8332 https://bugs.webkit.org/show_bug.cgi?id=196720
8334 Reviewed by Konstantin Tokarev.
8336 The Apple platform is using ${DERIVED_SOURCES_WTF_DIR} for hosting the ICU headers.
8337 Instead it should stage the headers into ${ICU_INCLUDE_DIRS} so no special handling
8340 * Source/cmake/OptionsJSCOnly.cmake:
8341 * Source/cmake/OptionsMac.cmake:
8343 2019-04-08 Don Olmstead <don.olmstead@sony.com>
8345 [CMake][WinCairo] Separate copied headers into different directories
8346 https://bugs.webkit.org/show_bug.cgi?id=196655
8348 Reviewed by Michael Catanzaro.
8350 Add variables for the paths to copied framework headers. This is done to be
8351 explicit rather than relying on ${FORWARDING_HEADERS_DIR}.
8353 Currently all ports but WinCairo will default to ${FORWARDING_HEADERS_DIR}.
8354 WinCairo overrides them to provide a directory structure that looks more
8355 like what happens in an XCode build. This is meant as an intermediate step
8356 towards making all CMake ports behave like this.
8358 * Source/cmake/OptionsWinCairo.cmake:
8359 * Source/cmake/WebKitFS.cmake:
8360 * Source/cmake/WebKitMacros.cmake:
8362 2019-04-08 Xan Lopez <xan@igalia.com>
8364 [CMake] Detect SSE2 at compile time
8365 https://bugs.webkit.org/show_bug.cgi?id=196488
8367 Reviewed by Carlos Garcia Campos.
8369 * CMakeLists.txt: Use FindSSE2.cmake to detect SSE2 support.
8370 * Source/cmake/FindSSE2.cmake: Added.
8372 2019-04-05 Commit Queue <commit-queue@webkit.org>
8374 Unreviewed, rolling out r243833.
8375 https://bugs.webkit.org/show_bug.cgi?id=196645
8377 This change breaks build of WPE and GTK ports (Requested by
8378 annulen on #webkit).
8382 "[CMake][WTF] Mirror XCode header directories"
8383 https://bugs.webkit.org/show_bug.cgi?id=191662
8384 https://trac.webkit.org/changeset/243833
8386 2019-04-03 Don Olmstead <don.olmstead@sony.com>
8388 [CMake][WTF] Mirror XCode header directories
8389 https://bugs.webkit.org/show_bug.cgi?id=191662
8391 Reviewed by Konstantin Tokarev.
8393 Add WTF_FRAMEWORK_HEADERS_DIR to place WTF headers into. Add frameworks/WTF.cmake
8394 which creates an interface target which will populate dependencies for consumers.
8395 This file is added here to support AppleWin internal builds which invoke CMake on
8398 * Source/cmake/WebKitFS.cmake:
8399 * Source/cmake/frameworks/WTF.cmake: Added.
8401 2019-04-03 Myles C. Maxfield <mmaxfield@apple.com>
8403 Remove support for -apple-trailing-word
8404 https://bugs.webkit.org/show_bug.cgi?id=196525
8406 Reviewed by Zalan Bujtas.
8408 This CSS property is nonstandard and not used.
8410 * Source/cmake/WebKitFeatures.cmake:
8412 2019-04-02 Fujii Hironori <Hironori.Fujii@sony.com>
8414 [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
8415 https://bugs.webkit.org/show_bug.cgi?id=182757
8417 Reviewed by Don Olmstead.
8419 Some generated headers need to be exported to its client modules.
8420 Before this change, WEBKIT_MAKE_FORWARDING_HEADERS copies all *.h
8421 files in the directory specified by DERIVED_SOURCE_DIRECTORIES
8422 parameter. The copy operation was triggered by POST_BUILD event.
8424 This caused build dependency issues for Ninja builds. This change
8425 remove the DERIVED_SOURCE_DIRECTORIES parameter. And list all
8426 generated headers explicitly which need to be copied.
8428 * Source/cmake/WebKitMacros.cmake: Removed
8429 DERIVED_SOURCE_DIRECTORIES parameter of
8430 WEBKIT_MAKE_FORWARDING_HEADERS. Accept absolute paths for FILES
8433 2019-04-01 Fujii Hironori <Hironori.Fujii@sony.com>
8435 [CMake] Remove EXTRA_DIRECTORIES parameter of WEBKIT_MAKE_FORWARDING_HEADERS
8436 https://bugs.webkit.org/show_bug.cgi?id=196436
8438 Reviewed by Darin Adler.
8440 The parameter was only for WebCore/ForwardingHeaders which was
8441 removed in Bug 182347.
8443 * Source/cmake/WebKitMacros.cmake: Remove unused EXTRA_DIRECTORIES parameter.
8445 2019-04-01 Stephan Szabo <stephan.szabo@sony.com>
8447 [PlayStation] Add initialization for JSC shell for PlayStation port
8448 https://bugs.webkit.org/show_bug.cgi?id=195411
8450 Reviewed by Ross Kirsling.
8452 Add functions for doing the automatic libc, floating point
8453 initializations, signing of binaries and libraries and
8454 wrapping of libc functions on PlayStation port.
8456 * Source/cmake/OptionsPlayStation.cmake:
8458 2019-03-29 Myles C. Maxfield <mmaxfield@apple.com>
8460 Delete WebMetal implementation in favor of WebGPU
8461 https://bugs.webkit.org/show_bug.cgi?id=195418
8463 Reviewed by Dean Jackson.
8465 * Source/cmake/OptionsMac.cmake:
8466 * Source/cmake/WebKitFeatures.cmake:
8467 * Source/cmake/tools/vsprops/FeatureDefines.props:
8468 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
8470 2019-03-29 Cathie Chen <cathiechen@igalia.com>
8472 Implement ResizeObserver.
8473 https://bugs.webkit.org/show_bug.cgi?id=157743
8475 Reviewed by Simon Fraser.
8477 Add ENABLE_RESIZE_OBSERVER.
8479 * Source/cmake/WebKitFeatures.cmake:
8481 2019-03-25 Adrian Perez de Castro <aperez@igalia.com>
8483 [WPE][GTK] Make building WebVR (w/OpenVR) not depend on ENABLE_EXPERIMENTAL_FEATURES
8484 https://bugs.webkit.org/show_bug.cgi?id=196223
8486 Reviewed by Michael Catanzaro.
8488 Disentangle USE_OPENVR from ENABLE_EXPERIMENTAL_FEATURES, making it
8489 unneeded to include ThirdParty/openvr/ in release tarballs.
8491 * Source/cmake/OptionsGTK.cmake: Set USE_OPENVR to OFF by default,
8492 instead of making it use the value of ENABLE_EXPERIMENTAL_FEATURES.
8493 * Source/cmake/OptionsWPE.cmake: Ditto.
8495 2019-03-25 Xan López <xan@igalia.com>
8497 [WTF] Fix typo when forcing WTF_CPU_X86
8498 https://bugs.webkit.org/show_bug.cgi?id=196204
8500 Reviewed by Michael Catanzaro.
8502 Fix a typo when setting the WTF_CPU variable for X86.
8506 2019-03-23 Carlos Garcia Campos <cgarcia@igalia.com>
8508 [GTK] Remove build time dependency on Geoclue2
8509 https://bugs.webkit.org/show_bug.cgi?id=195994
8511 Reviewed by Michael Catanzaro.
8513 Remove USE_GEOCLUE build option.
8515 * Source/cmake/FindGeoClue2.cmake: Removed.
8516 * Source/cmake/OptionsGTK.cmake:
8518 2019-03-21 Carlos Garcia Campos <cgarcia@igalia.com>
8520 [GTK][WPE] Add API to provide geolocation information
8521 https://bugs.webkit.org/show_bug.cgi?id=195940
8523 Reviewed by Michael Catanzaro.
8525 Build with geolocation enabled by default in both GTK and WPE. In GTK add a specific USE_GEOCLUE build option
8526 instead of using ENABLE_GEOLOCATION.
8528 * Source/cmake/OptionsGTK.cmake:
8529 * Source/cmake/OptionsWPE.cmake:
8531 2019-03-20 Simon Fraser <simon.fraser@apple.com>
8533 Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
8534 https://bugs.webkit.org/show_bug.cgi?id=196049
8536 Reviewed by Tim Horton.
8538 This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
8539 overflow scrolling in general, so rename it.
8541 * Source/cmake/OptionsMac.cmake:
8542 * Source/cmake/OptionsWin.cmake:
8543 * Source/cmake/WebKitFeatures.cmake:
8544 * Source/cmake/tools/vsprops/FeatureDefines.props:
8545 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
8547 2019-03-19 Christopher Reid <chris.reid@sony.com>
8549 [CMake] Support more clang and gcc sanitizers
8550 https://bugs.webkit.org/show_bug.cgi?id=195956
8552 Reviewed by Michael Catanzaro.
8554 Add support to compile with undefined, thread, memory, and leak sanitizers in cmake.
8555 Also add ubsan and asan support when compiling with clang-cl on WinCairo.
8556 This changes ENABLE_ADDRESS_SANITIZER flag to a generic ENABLE_SANITIZERS
8557 which takes a semicolon separated list of sanitizers to enable.
8558 e.g. `-DENABLE_SANITIZERS=address;undefined`
8560 Building WinCairo with sanitizers enabled also needs CLANG_LIB_PATH set to the clang compiler runtime library folder.
8561 e.g. pass `--cmakeargs="-DCLANG_LIB_PATH=\"C:\Program Files\LLVM\lib\clang\7.0.1\lib\windows\""` to build-webkit
8563 * Source/cmake/WebKitCompilerFlags.cmake:
8565 2019-03-18 Adrian Perez de Castro <aperez@igalia.com>
8567 [WPE] Bump public API to wpe-1.0
8568 https://bugs.webkit.org/show_bug.cgi?id=195887
8570 Reviewed by Philippe Normand.
8572 * Source/cmake/OptionsWPE.cmake: Bump public API version to 1.0
8574 2019-03-18 Adrian Perez de Castro <aperez@igalia.com>
8576 [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
8577 https://bugs.webkit.org/show_bug.cgi?id=195786
8579 Reviewed by Philippe Normand.
8581 * Source/cmake/FindWPE.cmake: Check for the wpe-1.0 pkg-config package.
8583 2019-03-11 Xan Lopez <xan@igalia.com>
8585 [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
8586 https://bugs.webkit.org/show_bug.cgi?id=194147
8588 Reviewed by Michael Saboff.
8590 * CMakeLists.txt: set WTF_CPU properly if FORCE_32BIT is set in
8593 2019-03-11 Michael Catanzaro <mcatanzaro@igalia.com>
8595 [WPE] Enable web process sandbox
8596 https://bugs.webkit.org/show_bug.cgi?id=195169
8598 Reviewed by Daniel Bates.
8600 * Source/cmake/BubblewrapSandboxChecks.cmake: Added.
8601 * Source/cmake/OptionsGTK.cmake:
8602 * Source/cmake/OptionsWPE.cmake:
8604 2019-03-07 Commit Queue <commit-queue@webkit.org>
8606 Unreviewed, rolling out r242354.
8607 https://bugs.webkit.org/show_bug.cgi?id=195402
8609 breaks layout tests in all configurations (Requested by
8610 zdobersek on #webkit).
8614 "[WPE] Enable web process sandbox"
8615 https://bugs.webkit.org/show_bug.cgi?id=195169
8616 https://trac.webkit.org/changeset/242354
8618 2019-03-06 Ross Kirsling <ross.kirsling@sony.com>
8620 [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
8621 https://bugs.webkit.org/show_bug.cgi?id=195346
8623 Reviewed by Fujii Hironori.
8625 * Source/cmake/OptionsJSCOnly.cmake:
8626 * Source/cmake/OptionsWin.cmake:
8627 Stop compiling with -DUCHAR_TYPE=wchar_t.
8629 2019-03-06 Don Olmstead <don.olmstead@sony.com>
8631 [WinCairo] Enable additional experimental features
8632 https://bugs.webkit.org/show_bug.cgi?id=195363
8634 Reviewed by Ross Kirsling.
8636 Turn on ENABLE_APPLICATION_MANIFEST, ENABLE_FILTERS_LEVEL_2, ENABLE_CSS_PAINTING_API,
8637 and ENABLE_VARIATION_FONTS. This will allow testing and development of these features
8640 * Source/cmake/OptionsWin.cmake:
8642 2019-03-05 Don Olmstead <don.olmstead@sony.com>
8644 [WinCairo] Enable CSS Typed OM
8645 https://bugs.webkit.org/show_bug.cgi?id=195340
8647 Reviewed by Myles C. Maxfield.
8649 * Source/cmake/OptionsWin.cmake:
8651 2019-03-04 Michael Catanzaro <mcatanzaro@igalia.com>
8653 [WPE] Enable web process sandbox
8654 https://bugs.webkit.org/show_bug.cgi?id=195169
8656 Reviewed by Daniel Bates.
8658 * Source/cmake/BubblewrapSandboxChecks.cmake: Added.
8659 * Source/cmake/OptionsGTK.cmake:
8660 * Source/cmake/OptionsWPE.cmake:
8662 2019-03-01 Don Olmstead <don.olmstead@sony.com>
8664 [WinCairo] Enable service worker
8665 https://bugs.webkit.org/show_bug.cgi?id=188318
8667 Reviewed by Youenn Fablet.
8669 * Source/cmake/OptionsWin.cmake:
8671 2019-02-28 Don Olmstead <don.olmstead@sony.com>
8673 [WinCairo] Turn ENABLE_RESOURCE_LOAD_STATISTICS on
8674 https://bugs.webkit.org/show_bug.cgi?id=194267
8676 Reviewed by Brent Fulgham.
8678 * Source/cmake/OptionsWin.cmake:
8680 2019-02-28 Carlos Garcia Campos <cgarcia@igalia.com>
8682 [CoordinatedGraphics] Remove COORDINATED_GRAPHICS_THREADED option
8683 https://bugs.webkit.org/show_bug.cgi?id=195159
8685 Reviewed by Don Olmstead.
8687 * Source/cmake/OptionsGTK.cmake:
8688 * Source/cmake/OptionsPlayStation.cmake:
8689 * Source/cmake/OptionsWPE.cmake:
8691 2019-02-26 Gabe Giosia <giosia@google.com>
8693 Incorrect formatting around command in Readme.md
8694 https://bugs.webkit.org/show_bug.cgi?id=195061
8696 Reviewed by Fujii Hironori.
8698 * ReadMe.md: removed stray period
8700 2019-02-26 Dominik Infuehr <dinfuehr@igalia.com>
8702 Fix warnings on ARM and MIPS
8703 https://bugs.webkit.org/show_bug.cgi?id=195049
8705 Reviewed by Mark Lam.
8707 Disable warnings for changes to the ABI with GCC 7.1.
8709 * Source/cmake/WebKitCompilerFlags.cmake:
8711 2019-02-25 Adrian Perez de Castro <aperez@igalia.com>
8713 [WPE] Bump WPEBackend-fdo requirement to API version 1.0
8714 https://bugs.webkit.org/show_bug.cgi?id=195001
8716 Reviewed by Carlos Garcia Campos.
8718 * Source/cmake/FindWPEBackend-fdo.cmake: Use WPEBackend-fdo-1.0.
8719 * Source/cmake/OptionsWPE.cmake: Ditto.
8721 2019-02-25 Miguel Gomez <magomez@igalia.com>
8723 [WPE] Add support for holepunch using an external video player
8724 https://bugs.webkit.org/show_bug.cgi?id=194899
8726 Reviewed by Xabier Rodriguez-Calvar.
8728 Add EXTERNAL_HOLEPUNCH option to the WPE port. Add a manual test to check the
8729 feature. Rename and update the test for GStreamer holepunch to avoid confusion.
8731 * ManualTests/wpe/video-player-holepunch-external.html: Added.
8732 * ManualTests/wpe/video-player-holepunch-gstreamer.html: Renamed from ManualTests/wpe/video-player-holepunch.html.
8733 * Source/cmake/OptionsWPE.cmake:
8735 2019-02-24 Devin Rousso <drousso@apple.com>
8737 Web Inspector: Change the InspectorOverlay to use native rather than canvas
8738 https://bugs.webkit.org/show_bug.cgi?id=105023
8739 <rdar://problem/13443692>
8741 Reviewed by Brian Burg.
8743 * ManualTests/inspector/overlay-nodes.html: Added.
8744 * ManualTests/inspector/overlay-rulers.html: Added.
8746 2019-02-22 Adrian Perez de Castro <aperez@igalia.com>
8748 Unreviewed. Bump version numbers
8750 * Source/cmake/OptionsWPE.cmake:
8752 2019-02-21 Carlos Garcia Campos <cgarcia@igalia.com>
8754 Unreviewed. Bump version numbers
8756 * Source/cmake/OptionsGTK.cmake:
8758 2019-02-21 Adrian Perez de Castro <aperez@igalia.com>
8760 [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
8761 https://bugs.webkit.org/show_bug.cgi?id=194901
8763 Unreviewed build fix.
8765 * Source/cmake/FindWPEBackend-fdo.cmake: Use WPEBACKEND_FDO as prefix
8766 for the output variables instead of WPEBackend-fdo, for consistency
8767 with other usages of of find_package_handle_standard_args().
8769 2019-02-11 Adrian Perez de Castro <aperez@igalia.com>
8771 [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
8772 https://bugs.webkit.org/show_bug.cgi?id=193622
8774 Reviewed by Michael Catanzaro.
8776 * Source/cmake/OptionsGTK.cmake: Enable CONTENT_EXTENSIONS by default.
8777 * Source/cmake/OptionsWPE.cmake: Ditto.
8778 * Source/cmake/WebKitFeatures.cmake: Add a private CONTENT_EXTENSIONS option.
8780 2019-02-07 Miguel Gomez <magomez@igalia.com>
8782 [WPE] Implement GStreamer based holepunch
8783 https://bugs.webkit.org/show_bug.cgi?id=193715
8785 Reviewed by Xabier Rodriguez-Calvar.
8787 Add GSTREAMER_HOLEPUNCH option to the WPE port with a manual test to
8790 * ManualTests/wpe/video-player-holepunch.html: Added.
8791 * Source/cmake/OptionsWPE.cmake:
8793 2019-02-01 Carlos Garcia Campos <cgarcia@igalia.com>
8795 [WPE] Enable font variations
8796 https://bugs.webkit.org/show_bug.cgi?id=194148
8798 Reviewed by Žan Doberšek.
8800 Enable variation fonts when required dependencies are available.
8802 * Source/cmake/OptionsWPE.cmake:
8804 2019-01-24 Guillaume Emont <guijemont@igalia.com>
8806 [JSC] Reenable baseline JIT on mips
8807 https://bugs.webkit.org/show_bug.cgi?id=192983
8809 Reviewed by Mark Lam.
8811 Use baseline JIT by default on MIPS.
8813 * Source/cmake/WebKitFeatures.cmake:
8815 2019-01-24 Carlos Garcia Campos <cgarcia@igalia.com>
8817 [GTK][WPE] Support JPEG 2000 images
8818 https://bugs.webkit.org/show_bug.cgi?id=186272
8820 Reviewed by Žan Doberšek.
8822 Add USE_OPENJPEG build option.
8824 * Source/cmake/OptionsGTK.cmake:
8825 * Source/cmake/OptionsWPE.cmake:
8827 2019-01-18 Jer Noble <jer.noble@apple.com>
8829 SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
8830 https://bugs.webkit.org/show_bug.cgi?id=189553
8832 Reviewed by Tim Horton.
8836 2019-01-18 Philippe Normand <pnormand@igalia.com>
8838 [WPE] Add Qt extension
8839 https://bugs.webkit.org/show_bug.cgi?id=191464
8841 Reviewed by Carlos Garcia Campos.
8843 * Source/cmake/OptionsWPE.cmake: Add ENABLE_WPE_QT_API CMake option. Disabled by default.
8845 2019-01-17 Truitt Savell <tsavell@apple.com>
8847 Unreviewed, rolling out r240124.
8849 This commit broke an internal build.
8853 "SDK_VARIANT build destinations should be separate from non-
8855 https://bugs.webkit.org/show_bug.cgi?id=189553
8856 https://trac.webkit.org/changeset/240124
8858 2019-01-17 Jer Noble <jer.noble@apple.com>
8860 SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
8861 https://bugs.webkit.org/show_bug.cgi?id=189553
8863 Reviewed by Tim Horton.
8867 2019-01-17 Per Arne Vollan <pvollan@apple.com>
8869 [Win] gperf command not found
8870 https://bugs.webkit.org/show_bug.cgi?id=193538
8871 <rdar://problem/47250549>
8873 Reviewed by Brent Fulgham.
8875 CMake only searches for gperf if ENABLE_WEBCORE is on. ENABLE_WEBCORE needs to be set to ON.
8877 * Source/cmake/OptionsAppleWin.cmake:
8879 2019-01-14 Carlos Garcia Campos <cgarcia@igalia.com>
8881 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.23.3 release
8883 * Source/cmake/OptionsGTK.cmake: Bump version numbers
8885 2019-01-08 Carlos Garcia Campos <cgarcia@igalia.com>
8887 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.23.2 release
8889 * Source/cmake/OptionsGTK.cmake: Bump version numbers
8891 2019-01-07 Don Olmstead <don.olmstead@sony.com>
8893 [CMake] Add ENABLE_CSS_TYPED_OM option
8894 https://bugs.webkit.org/show_bug.cgi?id=193216
8896 Reviewed by Michael Catanzaro.
8898 * Source/cmake/WebKitFeatures.cmake:
8900 2018-12-30 Yusuke Suzuki <yusukesuzuki@slowstart.org>
8902 gperf is only used in WebCore
8903 https://bugs.webkit.org/show_bug.cgi?id=193061
8905 Reviewed by Don Olmstead.
8907 gperf is only used in WebCore. So if the port does not have WebCore,
8908 it is not necessary. For example, JSCOnly port does not require it.
8909 This patch removes gperf dependency in these ports by checking
8912 * Source/cmake/WebKitCommon.cmake:
8914 2018-12-28 Yusuke Suzuki <yusukesuzuki@slowstart.org>
8916 Add ENABLE_UNIFIED_BUILDS option to cmake ports
8917 https://bugs.webkit.org/show_bug.cgi?id=193045
8919 Reviewed by Don Olmstead.
8921 This patch adds ENABLE_UNIFIED_BUILDS option to cmake ports, which allows us to disable Unified Builds in WebKit.
8922 This makes `compile_commands.json` sane when the unified builds is disabled, and various tools can use this
8923 compilation database. For example, YouCompleteMe completion server can use it.
8925 * Source/cmake/WebKitFeatures.cmake:
8926 * Source/cmake/WebKitMacros.cmake:
8928 2018-12-27 Alex Christensen <achristensen@webkit.org>
8930 Resurrect Mac CMake build
8931 https://bugs.webkit.org/show_bug.cgi?id=192658
8933 Reviewed by Yusuke Suzuki.
8935 * Source/cmake/OptionsMac.cmake:
8937 2018-12-19 Adrian Perez de Castro <aperez@igalia.com>
8939 [GTK] Cannot build with CMake <3.7
8940 https://bugs.webkit.org/show_bug.cgi?id=192865
8942 Reviewed by Michael Catanzaro.
8944 * Source/cmake/OptionsGTK.cmake: Convert usage of VERSION_GREATER_EQUAL to a
8945 combination of VERSION_GREATER + STREQUAL.
8947 2018-12-19 Lucas Stach <l.stach@pengutronix.de>
8949 Fix build on 64bit ARM with arm64 SYSTEM_PROCESSOR
8950 https://bugs.webkit.org/show_bug.cgi?id=192497
8952 Reviewed by Philippe Normand.
8954 Android and some embedded Linux build systems use arm64 instead of
8955 aarch64 as the CMAKE_HOST_PROCESSOR. Fix the JIT build for this scenario.
8959 2018-12-12 Carlos Garcia Campos <cgarcia@igalia.com>
8961 [FreeType] Add initial implementation of variation fonts
8962 https://bugs.webkit.org/show_bug.cgi?id=192151
8964 Reviewed by Michael Catanzaro.
8966 Enable variation fonts in GTK+ port when required dependencies are available.
8968 * Source/cmake/OptionsGTK.cmake:
8970 2018-12-12 Michael Catanzaro <mcatanzaro@igalia.com>
8972 Unreviewed manual rollout of r239100-r239102 and r239116
8973 https://bugs.webkit.org/show_bug.cgi?id=192151
8974 <rdar://problem/46655586>
8976 * Source/cmake/OptionsGTK.cmake:
8978 2018-12-12 Carlos Garcia Campos <cgarcia@igalia.com>
8980 [FreeType] Add initial implementation of variation fonts
8981 https://bugs.webkit.org/show_bug.cgi?id=192151
8983 Reviewed by Michael Catanzaro.
8985 Enable variation fonts in GTK+ port when required dependencies are available.
8987 * Source/cmake/OptionsGTK.cmake:
8989 2018-12-10 Don Olmstead <don.olmstead@sony.com>
8991 [CMake] Add ENABLE_RESOURCE_LOAD_STATISTICS to WebKitFeatures.cmake
8992 https://bugs.webkit.org/show_bug.cgi?id=192574
8994 Reviewed by Michael Catanzaro.
8996 * Source/cmake/WebKitFeatures.cmake:
8998 2018-12-10 Ross Kirsling <ross.kirsling@sony.com>
9000 Add test262-results directory to .gitignore.
9001 https://bugs.webkit.org/show_bug.cgi?id=192547
9003 Reviewed by Dean Jackson.
9007 2018-12-06 Carlos Eduardo Ramalho <cadubentzen@gmail.com>
9009 [GStreamer] -DENABLE_VIDEO=ON -DENABLE_OPENGL=OFF still tries to build GstreamerGL
9010 https://bugs.webkit.org/show_bug.cgi?id=191998
9012 Reviewed by Philippe Normand.
9014 Fix compilation with -DENABLE_VIDEO=ON and -DENABLE_OPENGL=OFF due to GStreamerGL.
9016 * Source/cmake/GStreamerDependencies.cmake: "DEFINED ENABLE_OPENGL" is always false because ENABLE_OPENGL
9017 is not a CMake variable (WEBKIT_OPTION_DEFINE macro does not define ENABLE_OPENGL variable per se, but other
9018 variables and appends it to a list).
9019 * Source/cmake/OptionsGTK.cmake: GStreamerDefinitions.cmake was included twice by mistake. Second should be GStreamerDependencies.cmake.
9021 2018-12-06 Carlos Eduardo Ramalho <cadubentzen@gmail.com>
9023 REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds
9024 https://bugs.webkit.org/show_bug.cgi?id=191997
9026 Reviewed by Philippe Normand.
9028 Fix build with -DENABLE_OPENGL=OFF and -DENABLE_VIDEO=OFF
9030 * Source/cmake/OptionsGTK.cmake: make ENABLE_ASYNC_SCROLLING depend on ENABLE_OPENGL
9032 2018-12-05 Don Olmstead <don.olmstead@sony.com>
9034 [PlayStation] Enable WebCore
9035 https://bugs.webkit.org/show_bug.cgi?id=192384
9037 Reviewed by Brent Fulgham.
9039 Adds CMake options for building WebCore on PlayStation.
9041 * Source/cmake/FindLibPSL.cmake:
9042 * Source/cmake/FindNghttp2.cmake: Copied from Source/cmake/FindWPE.cmake.
9043 * Source/cmake/FindPixman.cmake: Added.
9044 * Source/cmake/FindWPE.cmake:
9045 * Source/cmake/OptionsPlayStation.cmake:
9047 2018-12-04 Carlos Eduardo Ramalho <cadubentzen@gmail.com>
9050 https://bugs.webkit.org/show_bug.cgi?id=178900
9052 Reviewed by Michael Catanzaro.
9054 Add gtk-doc to WPE port. This patch tries to reuse as much code from
9055 WebKitGTK+ as possible.
9057 * Source/PlatformGTK.cmake: include GtkDoc.cmake instead of defining macro.
9058 * Source/PlatformWPE.cmake: Added documentation generation.
9059 * Source/cmake/GtkDoc.cmake: Added.
9060 * Source/cmake/OptionsWPE.cmake: Added ENABLE_GTKDOC build option and added pkg-config path variables.
9062 2018-12-03 Don Olmstead <don.olmstead@sony.com>
9064 [CMake] Sync feature defines
9065 https://bugs.webkit.org/show_bug.cgi?id=191167
9067 Reviewed by Michael Catanzaro.
9069 * Source/cmake/WebKitFeatures.cmake:
9071 2018-12-01 Don Olmstead <don.olmstead@sony.com>
9073 Cleanup WebKit Features
9074 https://bugs.webkit.org/show_bug.cgi?id=192262
9076 Reviewed by Michael Catanzaro.
9078 Removes unused ENABLE flags from the listing in WebKitFeatures.cmake
9079 and any other associated code. Synced the options in FeatureList.pm to
9080 the feature listing. Sorts the ENABLE flags.
9082 * Source/cmake/OptionsMac.cmake:
9083 * Source/cmake/OptionsWin.cmake:
9084 * Source/cmake/WebKitFeatures.cmake:
9085 * Source/cmake/tools/vsprops/FeatureDefines.props:
9086 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
9088 2018-11-30 Don Olmstead <don.olmstead@sony.com>
9090 Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
9091 https://bugs.webkit.org/show_bug.cgi?id=192197
9093 Reviewed by Jiewen Tan.
9095 * Source/cmake/OptionsGTK.cmake:
9096 * Source/cmake/OptionsWPE.cmake:
9097 * Source/cmake/OptionsWin.cmake:
9098 * Source/cmake/WebKitFeatures.cmake:
9100 2018-11-28 Michael Catanzaro <mcatanzaro@igalia.com>
9102 [CMake] Automatically disable JIT and enable USE_SYSTEM_MALLOC on unfamiliar architectures
9103 https://bugs.webkit.org/show_bug.cgi?id=186722
9105 Reviewed by Žan Doberšek.
9107 Time for part #2! This change was defeated for GTK and WPE by the code that makes the
9108 options public. We have three options: (a) duplicate the architecture check currently in
9109 WebKitFeatures.cmake in both OptionsGTK.cmake and OptionsWPE.cmake, (b) rely on the result
9110 of that check in OptionsGTK.cmake and OptionsWPE.cmake by using ENABLE_JIT_DEFAULT and
9111 USE_SYSTEM_MALLOC_DEFAULT, a fragile encapsulation violation, or (c) just make the options
9112 private. They have been public up until now because they needed to be turned off on
9113 unsupported architectures. But now they are off by default and enabled only for particular
9114 whitelisted architectures, so they shouldn't be needed anymore.
9116 Note we have to hide ENABLE_SAMPLING_PROFILER as well, since it needs to match the value of
9117 ENABLE_JIT. Again, this is handled properly in WebKitFeatures.cmake, and defeated here in
9118 OptionsGTK.cmake. (This is not a problem for WPE.)
9120 * Source/cmake/OptionsGTK.cmake:
9121 * Source/cmake/OptionsWPE.cmake:
9123 2018-11-26 Fujii Hironori <Hironori.Fujii@sony.com>
9125 [CMake] Remove ENABLE_ACCESSIBILITY CMake variable
9126 https://bugs.webkit.org/show_bug.cgi?id=191831
9128 Reviewed by Michael Catanzaro.
9130 ENABLE_ACCESSIBILITY is a bit confusing name because there is no
9131 such ENABLE_ACCESSIBILITY macros in C++ source files.
9133 * Source/cmake/OptionsGTK.cmake: Removed ENABLE_ACCESSIBILITY.
9134 * Source/cmake/OptionsWPE.cmake: Ditto.
9135 * Source/cmake/OptionsWin.cmake: Ditto.
9136 * Source/cmake/WebKitFeatures.cmake: Ditto.
9138 2018-11-26 Alberto Garcia <berto@igalia.com>
9140 [GTK] [2.22.0] Fails to build in armel
9141 https://bugs.webkit.org/show_bug.cgi?id=188862
9143 Disable the JIT and enable C_LOOP on ARM CPUs without Thumb2
9146 Reviewed by Michael Catanzaro.
9148 * Source/cmake/WebKitFeatures.cmake:
9150 2018-11-22 Carlos Garcia Campos <cgarcia@igalia.com>
9152 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.23.1 release.
9154 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
9156 2018-11-21 Dominik Infuehr <dinfuehr@igalia.com>
9158 Enable JIT on ARM/Linux
9159 https://bugs.webkit.org/show_bug.cgi?id=191548
9161 Reviewed by Yusuke Suzuki.
9163 Enable JIT by default on ARMv7/Linux after it was disabled with
9164 recent bytcode format change.
9166 * Source/cmake/WebKitFeatures.cmake:
9168 2018-11-16 Don Olmstead <don.olmstead@sony.com>
9170 Add USE(LIBWPE) to WebCore
9171 https://bugs.webkit.org/show_bug.cgi?id=191401
9173 Reviewed by Michael Catanzaro.
9175 Exposes USE_LIBWPE to the build.
9177 * Source/cmake/OptionsWPE.cmake:
9179 2018-11-12 Ryosuke Niwa <rniwa@webkit.org>
9181 Add HTTPS git remote to ReadMe.md
9182 https://bugs.webkit.org/show_bug.cgi?id=191561
9184 Reviewed by Zalan Bujtas.
9188 2018-11-12 Takashi Komori <Takashi.Komori@sony.com>
9190 Resurrect WebKitTestRunner for Windows port
9191 https://bugs.webkit.org/show_bug.cgi?id=189257
9193 Reviewed by Fujii Hironori.
9195 * Source/cmake/OptionsWin.cmake:
9197 2018-11-07 Carlos Garcia Campos <cgarcia@igalia.com>
9199 [Linux] Use memfd_create when available in SharedMemory implementation
9200 https://bugs.webkit.org/show_bug.cgi?id=189741
9202 Reviewed by Michael Catanzaro.
9204 Add include check for linux/memfd.h header.
9206 * Source/cmake/OptionsCommon.cmake:
9208 2018-11-05 Dominik Infuehr <dinfuehr@igalia.com>
9210 Enable LLInt on ARMv7/Linux
9211 https://bugs.webkit.org/show_bug.cgi?id=191190
9213 Reviewed by Yusuke Suzuki.
9215 After enabling the new bytecode format in r237547, C_LOOP was
9216 forced on all 32-bit platforms. Now enable LLInt again on
9217 ARMv7-Thumb2/Linux by default.
9219 * Source/cmake/WebKitFeatures.cmake:
9221 2018-11-05 Michael Catanzaro <mcatanzaro@igalia.com>
9223 [WPE][GTK] Expose ENABLE_MEDIA_SOURCE as public option
9224 https://bugs.webkit.org/show_bug.cgi?id=191223
9226 Reviewed by Xabier Rodriguez-Calvar.
9228 This option should be public because it needs to be disabled to build with GStreamer older
9231 * Source/cmake/GStreamerDefinitions.cmake:
9233 2018-11-04 Fujii Hironori <Hironori.Fujii@sony.com>
9235 [Win] Use C++14, not C++17
9236 https://bugs.webkit.org/show_bug.cgi?id=191101
9238 Reviewed by Alex Christensen.
9240 Based on the webkit-dev discussion, this change switches Windows
9241 port from C++17 to C++14.
9242 <https://lists.webkit.org/pipermail/webkit-dev/2018-September/030186.html>
9244 * Source/cmake/OptionsMSVC.cmake: Replaced /std:c++17 with /std:c++14 switch.
9246 2018-10-30 Don Olmstead <don.olmstead@sony.com>
9248 [PlayStation] Enable JavaScriptCore
9249 https://bugs.webkit.org/show_bug.cgi?id=191072
9251 Reviewed by Brent Fulgham.
9253 Add support for building the PlayStation port through JavaScriptCore.
9256 * Source/cmake/OptionsPlayStation.cmake: Added.
9258 2018-10-29 Tadeu Zagallo <tzagallo@apple.com>
9260 New bytecode format for JSC
9261 https://bugs.webkit.org/show_bug.cgi?id=187373
9262 <rdar://problem/44186758>
9264 Reviewed by Filip Pizlo.
9266 Disable JIT by default on 32-bit platforms
9268 * Source/cmake/WebKitFeatures.cmake:
9270 2018-10-27 Charlie Turner <cturner@igalia.com>
9272 Make VIDEO enabled if ENCRYPTED_MEDIA is enabled.
9273 https://bugs.webkit.org/show_bug.cgi?id=190983
9275 Unreviewed build update.
9277 * Source/cmake/WebKitFeatures.cmake:
9279 2018-10-27 Charlie Turner <cturner@igalia.com>
9281 [GTK] Enable experimental encrypted media support
9282 https://bugs.webkit.org/show_bug.cgi?id=190829
9284 Reviewed by Michael Catanzaro.
9286 * Source/cmake/OptionsGTK.cmake:
9288 2018-10-26 Commit Queue <commit-queue@webkit.org>
9290 Unreviewed, rolling out r237479 and r237484.
9291 https://bugs.webkit.org/show_bug.cgi?id=190978
9293 broke JSC on iOS (Requested by tadeuzagallo on #webkit).
9295 Reverted changesets:
9297 "New bytecode format for JSC"
9298 https://bugs.webkit.org/show_bug.cgi?id=187373
9299 https://trac.webkit.org/changeset/237479
9301 "Gardening: Build fix after r237479."
9302 https://bugs.webkit.org/show_bug.cgi?id=187373
9303 https://trac.webkit.org/changeset/237484
9305 2018-10-26 Tadeu Zagallo <tzagallo@apple.com>
9307 New bytecode format for JSC
9308 https://bugs.webkit.org/show_bug.cgi?id=187373
9309 <rdar://problem/44186758>
9311 Reviewed by Filip Pizlo.
9313 Disable JIT by default on 32-bit platforms
9315 * Source/cmake/WebKitFeatures.cmake:
9317 2018-10-25 Michael Catanzaro <mcatanzaro@igalia.com>
9319 [GTK] Reenable the sandbox
9321 Previously reviewed by, er, myself. This just reverts the sabotague as our bots should have
9322 the required deps now. Hopefully.
9324 * Source/cmake/OptionsGTK.cmake:
9326 2018-10-18 Fujii Hironori <Hironori.Fujii@sony.com>
9328 [Win][Clang] Do not give -Wall to clang-cl because it is treated as -Weverything
9329 https://bugs.webkit.org/show_bug.cgi?id=190514
9331 Reviewed by Michael Catanzaro.
9333 clang-cl maps /Wall and -Wall to -Weverything which reports tons
9334 of compilation warnings. Do not give -Wall option to clang-cl.
9336 Clang processes -Wall and -Wextra options differently than GCC.
9337 Clang processes all warning options in left-to-right order, while
9338 GCC processes -Wall and -Wextra options first. In order to get the
9339 same effect in both compilers, -Wall and -Wextra should be
9340 speficied before all -Wno-* options.
9342 * Source/cmake/WebKitCompilerFlags.cmake: Put -Wall and -Wextra
9343 options before all -Wno-* options.
9344 * Source/cmake/OptionsMSVC.cmake: Prepend /W4 option, instead of
9345 just replacing /W3 option.
9347 2018-10-16 Philippe Normand <pnormand@igalia.com>
9349 Unreviewed, GTK bots build fix
9351 * Source/cmake/OptionsGTK.cmake: Disable Sandbox support until the
9352 bots have all the needed dependencies installed.
9354 2018-10-15 Justin Fan <justin_fan@apple.com>
9356 Add WebGPU 2018 feature flag and experimental feature flag
9357 https://bugs.webkit.org/show_bug.cgi?id=190509
9359 Reviewed by Dean Jackson.
9361 Update FeatureDefines for WebGPU -> WebMetal renaming, while preserving WebGPU
9362 references for 2018 WebGPU Sketch implementation.
9364 * Source/cmake/OptionsMac.cmake:
9365 * Source/cmake/tools/vsprops/FeatureDefines.props:
9366 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
9368 2018-10-15 Christopher Reid <chris.reid@sony.com>
9370 [Curl][WinCairo] Add Public Suffix support to WinCairo
9371 https://bugs.webkit.org/show_bug.cgi?id=183060
9373 Reviewed by Alex Christensen.
9375 * Source/cmake/FindLibPSL.cmake: Added.
9376 * Source/cmake/OptionsWin.cmake:
9377 * Source/cmake/OptionsWinCairo.cmake:
9379 2018-10-15 Michael Catanzaro <mcatanzaro@igalia.com>
9381 Add new files missing from previous commit.
9383 * Source/cmake/FindLibseccomp.cmake: Added.
9385 2018-10-15 Patrick Griffis <pgriffis@igalia.com>
9387 [GTK][WPE] Implement subprocess sandboxing
9388 https://bugs.webkit.org/show_bug.cgi?id=188568
9390 Reviewed by Michael Catanzaro.
9392 Add ENABLE_BUBBLEWRAP_SANDBOX option for sandboxing.
9394 * Source/cmake/FindLibseccomp.cmake: Added.
9395 * Source/cmake/OptionsGTK.cmake:
9396 * Source/cmake/WebKitFeatures.cmake:
9398 2018-10-14 Yusuke Suzuki <yusukesuzuki@slowstart.org>
9400 [JSC] Remove Option::useAsyncIterator
9401 https://bugs.webkit.org/show_bug.cgi?id=190567
9403 Reviewed by Saam Barati.
9405 * Source/cmake/WebKitFeatures.cmake:
9407 2018-10-08 Justin Fan <justin_fan@apple.com>
9409 WebGPU: Rename old WebGPU prototype to WebMetal
9410 https://bugs.webkit.org/show_bug.cgi?id=190325
9412 Reviewed by Dean Jackson.
9414 * Source/cmake/WebKitFeatures.cmake:
9416 2018-10-02 Philippe Normand <pnormand@igalia.com>
9418 [GStreamer][MSE] Ubuntu LTS build broken since r236409
9419 https://bugs.webkit.org/show_bug.cgi?id=190036
9421 Reviewed by Michael Catanzaro.
9423 Interrupt the build if MSE is enabled but no supported (1.14)
9424 GStreamer version was found.
9426 * Source/cmake/GStreamerChecks.cmake:
9428 2018-10-01 Caio Lima <ticaiolima@gmail.com>
9430 'HAVE_PTHREAD_MAIN_NP' macro redefined warning when building --jsc-only on macOS
9431 https://bugs.webkit.org/show_bug.cgi?id=190118
9433 Reviewed by Yusuke Suzuki.
9435 We define HAVE_PTHREAD_MAIN_NP in WTF/wtf/Platform.h when the OS is
9436 Darwin. In such case, we don't need to check symbols for
9437 pthread_main_np when generating build for this system.
9439 * Source/cmake/OptionsCommon.cmake:
9441 2018-09-28 Mike Gorse <mgorse@alum.wpi.edu>
9443 cmake cannot run if python 2 isn't available
9444 https://bugs.webkit.org/show_bug.cgi?id=190075
9446 Reviewed by Michael Catanzaro.
9448 * Source/cmake/WebKitCommon.cmake: Set Python_ADDITIONAL_VERSIONS
9449 to 3, so that a python3 binary will be found.
9451 2018-09-28 Yusuke Suzuki <yusukesuzuki@slowstart.org>
9453 [WTF] Make isMainThread more reliable
9454 https://bugs.webkit.org/show_bug.cgi?id=189880
9456 Reviewed by Mark Lam.
9458 * Source/cmake/OptionsCommon.cmake:
9460 2018-09-21 Yusuke Suzuki <yusukesuzuki@slowstart.org>
9462 [JSC] Enable LLInt ASM interpreter on X64 and ARM64 in non JIT configuration
9463 https://bugs.webkit.org/show_bug.cgi?id=189778
9465 Reviewed by Keith Miller.
9467 ENABLE_SAMPLING_PROFILER does not depend on ENABLE_JIT now since it can be
9468 used with LLInt ASM interpreter.
9470 * Source/cmake/WebKitFeatures.cmake:
9472 2018-09-21 Mike Gorse <mgorse@suse.com>
9474 Build tools should work when the /usr/bin/python is python3
9475 https://bugs.webkit.org/show_bug.cgi?id=156674
9477 Reviewed by Michael Catanzaro.
9479 * Source/cmake/WebKitCommon.cmake: Allow python 3.
9481 2018-09-20 Carlos Garcia Campos <cgarcia@igalia.com>
9483 Unreviewed. Update GTK+ library versions after r235362.
9485 Project version number was updated without bumping the library versions too.
9487 * Source/cmake/OptionsGTK.cmake:
9489 2018-09-12 Dan Bernstein <mitz@apple.com>
9491 Updated svn:ignore after r235381.
9493 * .: Added LocalOverrides.xcconfig to svn:ignore.
9495 2018-09-12 Dan Bernstein <mitz@apple.com>
9497 Removed a couple of empty directories left behind after r235892.
9499 * WPEWebCore: Removed.
9500 * downstream-WebCore: Removed.
9502 2018-09-10 Tim Horton <timothy_horton@apple.com>
9504 Make it easier to build for SDK_VARIANT=iosmac
9505 https://bugs.webkit.org/show_bug.cgi?id=189488
9506 <rdar://problem/38254840>
9508 Reviewed by Wenson Hsieh.
9513 Set a variety of build flags (disable libwebrtc, tools, and set
9514 SDK_VARIANT and WK_ALTERNATE_FRAMEWORKS_DIR).
9516 2018-08-30 Don Olmstead <don.olmstead@sony.com>
9518 [CMake] Replace AVFoundationSupport.py using CMake
9519 https://bugs.webkit.org/show_bug.cgi?id=182891
9521 Reviewed by Per Arne Vollan.
9523 Adds CMake checks for AVFoundation support replacing the functionality
9524 of AVFoundationSupport.py.
9526 CMake is used to detect the symbols expected with the HAVE_* checks for
9527 AVFoundation support. This involves creating source files that will be
9528 built which verifies the presence of symbols. For Apple frameworks it
9529 is customary to include the main framework file which includes the
9530 other associated headers.
9532 The check for HAVE_AVCFPLAYERITEM_CALLBACK_VERSION_2 involves looking
9533 for an enumeration which a symbol check cannot detect. Instead a small
9534 program is used which will compile and link when the version 2
9535 enumeration is present.
9537 * Source/cmake/OptionsAppleWin.cmake:
9538 * Source/cmake/OptionsWin.cmake:
9539 * Source/cmake/WebKitCommon.cmake:
9540 * Source/cmake/WebKitFeatures.cmake:
9542 2018-08-28 Don Olmstead <don.olmstead@sony.com>
9544 [CMake] Use CMake's FindFreetype
9545 https://bugs.webkit.org/show_bug.cgi?id=189071
9547 Reviewed by Michael Catanzaro.
9549 Use the builtin CMake functionality for finding Freetype.
9551 * Source/cmake/FindFreetype2.cmake: Removed.
9552 * Source/cmake/OptionsGTK.cmake:
9553 * Source/cmake/OptionsWPE.cmake:
9555 2018-08-27 Aditya Keerthi <akeerthi@apple.com>
9557 Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
9558 https://bugs.webkit.org/show_bug.cgi?id=188931
9560 Reviewed by Wenson Hsieh.
9562 * Source/cmake/OptionsMac.cmake: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
9563 * Source/cmake/WebKitFeatures.cmake: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
9565 2018-08-27 Keith Rollin <krollin@apple.com>
9567 Build system support for LTO
9568 https://bugs.webkit.org/show_bug.cgi?id=187785
9569 <rdar://problem/42353132>
9571 Reviewed by Dan Bernstein.
9573 Add support for building WebKit with LTO (Link Time Optimization) on
9574 macOS and iOS. Both variations are supported: "full" (which performs
9575 all the optimizations it can regardless of the cost) and "thin" (which
9576 sacrifices some optimizations in order to recover build time and
9579 By default, LTO is disabled for Debug and Release builds, but is
9580 enabled for Production builds. For Debug and Release builds, LTO is
9581 controlled as follows:
9583 - When using `make` from the command line, include
9584 WK_LTO_MODE={none,thin,full}. For example, `make WK_LTO_MODE=full
9585 release`. As when specifying debug/release, the LTO configuration
9586 information is written to the WebKitBuild directory and is used as
9587 the default on the next build if a new setting is not specified.
9589 - When using `build-webkit`, include --lto-mode={none,thin,full} on
9590 the command line. For example, `build-webkit --lto-mode=full ...`.
9592 - When using Xcode, create a configuration file called
9593 LocalOverrides.xcconfig at the root level of your WebKit checkout
9594 directory. Include within it a line that says:
9596 WK_LTO_MODE={none,thin,full}
9602 Note that LocalOverrides.xcconfig is included in the .gitignore file,
9603 so you won't accidentally check your changes into source control.
9605 Enabling LTO can greatly increase build times, especially when using
9606 "full" LTO with 32GB or RAM or less. Following is a table of full
9607 build times for a Release build on a fully decked-out 2017 iMac Pro:
9610 ----- ------- -------
9611 None: 9m 11s 14m 11s
9612 Thin: 11m 44s 17m 30s
9613 Full: 21m 39s 28m 56s
9615 Incremental times are affected even more greatly. The actual
9616 optimization and compilation of LLVM bitcode is moved to the link
9617 phase, meaning that the link phase, which previously took only
9618 seconds, can now take many minutes. It's for this reason that LTO is
9619 not enabled in Debug and Release builds, since incremental builds are
9620 an integral part of those configurations. However, using the
9621 mechanisms described above, developers can perform optional LTO builds
9622 if needed to track down build or runtime issues in that configuration.
9624 * .gitignore: Include LocalOverrides.xcconfig.
9625 * Makefile.shared: Add support for WK_LTO_MODE on the command line.
9627 2018-08-27 Michael Catanzaro <mcatanzaro@igalia.com>
9629 Unreviewed, bump WPE/GTK version numbers
9631 We have a pkg-config dependency on 2.21.92 but trunk is stuck on 2.21.5. So bump the version
9632 number to 2.23.0. It seems like a good version number to use until the next real release
9635 * Source/cmake/OptionsGTK.cmake:
9636 * Source/cmake/OptionsWPE.cmake:
9638 2018-08-26 Michael Catanzaro <mcatanzaro@igalia.com>
9640 [CMake] Remove stale comment from WebKitFeatures.cmake
9641 https://bugs.webkit.org/show_bug.cgi?id=188918
9643 Reviewed by Fujii Hironori.
9645 This comment at the top of WebKitFeatures.cmake is no longer accurate because feature defaults are no longer defined in FeatureList.pm (thank goodness!)
9647 * Source/cmake/WebKitFeatures.cmake:
9649 2018-08-23 Don Olmstead <don.olmstead@sony.com>
9651 [CMake] Have checks are not getting set inside CMake properly
9652 https://bugs.webkit.org/show_bug.cgi?id=188901
9654 Reviewed by Michael Catanzaro.
9656 Make sure the variable's value is sent to SET_AND_EXPOSE_TO_BUILD
9657 within the WEBKIT_CHECK_HAVE_* macros.
9659 * Source/cmake/WebKitFeatures.cmake:
9661 2018-08-23 Don Olmstead <don.olmstead@sony.com>
9663 [CMake] Add HAVE_MALLOC_TRIM definition
9664 https://bugs.webkit.org/show_bug.cgi?id=188897
9666 Reviewed by Konstantin Tokarev.
9668 Add CMake check for malloc_trim.
9670 * Source/cmake/OptionsCommon.cmake:
9672 2018-08-22 Ross Kirsling <ross.kirsling@sony.com>
9674 [MSVC] Stop disabling /O2 features.
9675 https://bugs.webkit.org/show_bug.cgi?id=188811
9677 Reviewed by Per Arne Vollan.
9679 * Source/cmake/OptionsMSVC.cmake:
9680 Don't disable /GF (string pooling) or /Gy (function-level linking).
9682 2018-08-22 Alberto Garcia <berto@igalia.com>
9684 Don't use WTF_CPU_MIPS when building for mips64
9685 https://bugs.webkit.org/show_bug.cgi?id=188858
9687 Reviewed by Michael Catanzaro.
9689 * CMakeLists.txt: Use WTF_CPU_MIPS64 for this architecture.
9691 2018-08-22 Zan Dobersek <zdobersek@igalia.com>
9693 [CoordGraphics] Switch to Nicosia::CompositionLayer state tracking
9694 https://bugs.webkit.org/show_bug.cgi?id=188693
9696 Reviewed by Carlos Garcia Campos.
9698 * Source/cmake/OptionsGTK.cmake: Enable USE_NICOSIA alongside
9699 USE_COORDINATED_GRAPHICS and USE_COORDINATED_GRAPHICS_THREADED.
9700 * Source/cmake/OptionsWPE.cmake: Ditto.
9702 2018-08-21 Adrian Perez de Castro <aperez@igalia.com>
9704 Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.91 release.
9706 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
9708 2018-08-21 Adrian Perez de Castro <aperez@igalia.com>
9710 [WPE] Update to use libwpe-1.0.0 and WPEBackend-fdo-1.0.0
9711 https://bugs.webkit.org/show_bug.cgi?id=188782
9713 Reviewed by Michael Catanzaro.
9715 Make the build depend on wpe-0.2, and change the Flatpak and JHBuild development
9716 environments to use version 1.0.0 of libwpe and WPEBackend-fdo.
9718 * Source/cmake/FindWPE.cmake: Renamed from Source/cmake/FindWPEBackend.cmake and changed
9719 to check for libwpe-0.2.
9720 * Source/cmake/OptionsWPE.cmake: Adapt to the rename to FindWPE.cmake.
9722 2018-08-18 Michael Catanzaro <mcatanzaro@igalia.com>
9724 Adjust CMAKE_MODULE_LINKER_FLAGS for asan
9725 https://bugs.webkit.org/show_bug.cgi?id=188699
9727 Reviewed by Konstantin Tokarev.
9729 * Source/cmake/WebKitCompilerFlags.cmake:
9731 2018-07-30 Thibault Saunier <tsaunier@igalia.com>
9733 [GStreamer] Make codecparsers optionnal
9734 https://bugs.webkit.org/show_bug.cgi?id=188010
9736 And avoid building libWebRTC if it won't be used. While there is no other
9737 WebRTC backend, it makes no sense to expose an option.
9739 Error out when WEBRTC or MEDIA_STREAM is enabled but GStreamer < 1.10
9741 Reviewed by Alejandro G. Castro.
9743 * Source/cmake/GStreamerChecks.cmake:
9744 * Source/cmake/OptionsGTK.cmake:
9745 * Source/cmake/OptionsWPE.cmake:
9747 2018-07-26 Andy VanWagoner <andy@vanwagoner.family>
9749 [INTL] Remove INTL sub-feature compile flags
9750 https://bugs.webkit.org/show_bug.cgi?id=188081
9752 Reviewed by Michael Catanzaro.
9754 * Source/cmake/OptionsJSCOnly.cmake:
9755 * Source/cmake/WebKitFeatures.cmake:
9757 2018-07-24 Thibault Saunier <tsaunier@igalia.com>
9759 [WPE][GTK] Implement PeerConnection API on top of libwebrtc
9760 https://bugs.webkit.org/show_bug.cgi?id=186932
9762 Reviewed by Philippe Normand.
9764 * Source/cmake/FindGStreamer.cmake: Look for gstreamer-codecparser as it needed for GStreamerVideoDecoder
9766 2018-07-20 Carlos Garcia Campos <cgarcia@igalia.com>
9768 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.5 release.
9770 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
9772 2018-07-19 Stephan Szabo <stephan.szabo@sony.com>
9774 [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector
9775 https://bugs.webkit.org/show_bug.cgi?id=187786
9777 Reviewed by Fujii Hironori.
9779 * Source/cmake/OptionsWinCairo.cmake: Add ENABLE_DEVELOPER_MODE
9780 to build when DEVELOPER_MODE is turned on at cmake time.
9782 2018-07-18 Michael Catanzaro <mcatanzaro@igalia.com>
9784 Switch CMake ports back to C++ 14
9785 https://bugs.webkit.org/show_bug.cgi?id=187744
9787 Reviewed by Ryosuke Niwa.
9789 The XCode build is still not using C++ 17, it's been several months since CMake ports
9790 switched, everything builds fine without changes if we switch back, and there have been some
9791 unfixed problems. Let's go back to C++ 14 for now. We can switch back to C++ 17 whenever we
9792 are ready to switch over XCode at the same time, to ensure we don't wind up with divergent
9793 behavior for std::optional.
9795 * Source/cmake/WebKitCompilerFlags.cmake:
9797 2018-07-16 Ryosuke Niwa <rniwa@webkit.org>
9799 Update ReadMe.md line 68
9800 https://bugs.webkit.org/show_bug.cgi?id=187533
9802 Reviewed by Wenson Hsieh.
9806 2018-07-02 Adrian Perez de Castro <aperez@igalia.com>
9808 [CMake] Use JOB_POOLS to avoid memory-hungry linker processes running at the same time
9809 https://bugs.webkit.org/show_bug.cgi?id=187254
9811 Reviewed by Michael Catanzaro.
9813 * Source/cmake/WebKitCommon.cmake: Set the maximum number of
9814 concurrent link processes using job pools (four for release builds,
9815 two otherwise) to avoid running out of memory during builds.
9817 2018-07-02 Ryosuke Niwa <rniwa@webkit.org>
9819 Repository fix after r233427 and r233443.
9823 2018-06-30 Adam Barth <abarth@webkit.org>
9825 Port JavaScriptCore to OS(FUCHSIA)
9826 https://bugs.webkit.org/show_bug.cgi?id=187223
9828 Reviewed by Daniel Bates.
9830 * Source/cmake/OptionsJSCOnly.cmake: Add back ICU.
9832 2018-06-29 Ross Kirsling <ross.kirsling@sony.com>
9834 [JSCOnly] Restore Windows build.
9835 https://bugs.webkit.org/show_bug.cgi?id=187127
9837 Reviewed by Michael Catanzaro.
9839 * Source/cmake/OptionsJSCOnly.cmake:
9840 Don't forget to set -DUCHAR_TYPE=wchar_t for ICU on Windows.
9841 Use bin64/lib64 on Windows (for consistency with full WebKit build).
9843 2018-06-28 Adam Barth <abarth@webkit.org>
9845 Switch OS(FUCHSIA) to using JSCOnly
9846 https://bugs.webkit.org/show_bug.cgi?id=187133
9848 Reviewed by Yusuke Suzuki.
9850 Rather than creating a Fuchsia port, OS(FUCHSIA) now uses the JSCOnly
9853 * CMakeLists.txt: Set the WTF_OS_FUCHSIA flag
9854 * Source/cmake/OptionsFuchsia.cmake: Removed.
9855 * Source/cmake/OptionsJSCOnly.cmake: Temporarily disable ICU for
9856 OS(FUCHSIA). We'll get ICU wired in, but I'd like to work through the
9857 other compile errors first.
9859 2018-06-27 Adam Barth <abarth@webkit.org>
9861 Add Fuchsia support to build-jsc
9862 https://bugs.webkit.org/show_bug.cgi?id=187086
9864 Reviewed by Yusuke Suzuki.
9866 Add Fuchsia port to cmake build system. After this patch, the build
9867 errors out due to a missing sysroot.
9870 * Source/cmake/OptionsFuchsia.cmake: Added.
9872 2018-06-18 Zan Dobersek <zdobersek@igalia.com>
9874 Unreviewed GTK+ gardening. Updating the WPT expectations by removing
9875 failure expectations for 2dcontext tests covering CSS HSL/HSLA color
9876 parsing and createImageBitmap() API that are nowadays passing.
9878 * WebPlatformTests/gtk/TestExpectations.json:
9880 2018-06-17 Michael Catanzaro <mcatanzaro@igalia.com>
9882 [CMake] Automatically disable JIT and enable USE_SYSTEM_MALLOC on unfamiliar architectures
9883 https://bugs.webkit.org/show_bug.cgi?id=186722
9885 Reviewed by Darin Adler.
9887 We know that the JSC JIT and bmalloc both work on only a limited set of architectures. In
9888 Fedora, we have to manually disable these when building for s390x, ppc64, and ppc64le. But
9889 it's really easy to do the right thing automatically, so we might as well.
9891 * Source/cmake/WebKitFeatures.cmake:
9893 2018-06-13 Thibault Saunier <tsaunier@igalia.com>
9895 [WPE] Build getUserMedia support
9896 https://bugs.webkit.org/show_bug.cgi?id=186547
9898 Reviewed by Alejandro G. Castro.
9900 * Source/cmake/OptionsWPE.cmake: Build MediaStream support
9902 2018-06-12 Philippe Normand <pnormand@igalia.com>
9904 [GStreamer] Bump required version to 1.8.3
9905 https://bugs.webkit.org/show_bug.cgi?id=186558
9907 Reviewed by Xabier Rodriguez-Calvar.
9909 * Source/cmake/GStreamerChecks.cmake: Bump to 1.8.3 which is the
9910 version shipped in the current Ubuntu LTS we support (16.04).
9912 2018-06-12 Zan Dobersek <zdobersek@igalia.com>
9914 Add run-web-platform-tests script
9915 https://bugs.webkit.org/show_bug.cgi?id=183356
9917 Reviewed by Carlos Alberto Lopez Perez.
9919 Store port-specific test expectations and test manifest files for the
9920 web-platform-tests test runs under the top-level WebPlatformTests
9923 TestExpectations.json file lists all the failing or disabled tests
9924 or subtests that are to be expected in the test run. This information is
9925 parsed in the run-web-platform-tests script and used to build
9926 test-specific metadata files (ending with .ini) inside a temporary
9927 directory that is then used during the test run. JSON format is used to
9928 follow the WebDriver test suite in how it manages expectations, and to
9929 avoid having to manually manage .ini files for every deviant test case.
9931 TestManifest.ini file is used to fine-tune which tests are to be enabled
9932 by default. For the GTK+ port, we currently disable all tests by default
9933 but then specifically enable tests under the 2dcontext and WebCryptoAPI
9934 directories. This will allow for gradual enabling of further tests.
9936 * WebPlatformTests/gtk/TestExpectations.json: Added.
9937 * WebPlatformTests/gtk/TestManifest.ini: Added.
9939 2018-06-11 Carlos Garcia Campos <cgarcia@igalia.com>
9941 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.4 release.
9943 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
9945 2018-06-11 Michael Saboff <msaboff@apple.com>
9947 JavaScriptCore: Disable 32-bit JIT on Windows
9948 https://bugs.webkit.org/show_bug.cgi?id=185989
9950 Reviewed by Mark Lam.
9952 * Source/cmake/OptionsWin.cmake:
9954 2018-06-10 Carlos Garcia Campos <cgarcia@igalia.com>
9956 [WPE] Add a MiniBrowser and use it to run WebDriver tests
9957 https://bugs.webkit.org/show_bug.cgi?id=186345
9959 Reviewed by Žan Doberšek.
9961 Add an option to enable building the MiniBrowser.
9963 * Source/cmake/FindWaylandProtocols.cmake: Added.
9964 * Source/cmake/OptionsWPE.cmake:
9966 2018-06-06 Dan Bernstein <mitz@apple.com>
9968 [Xcode] Opt out of the New Build System
9969 https://bugs.webkit.org/show_bug.cgi?id=186380
9971 Reviewed by Alexey Proskuryakov.
9973 * WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings: Use the Legacy Build System.
9975 2018-06-06 Dan Bernstein <mitz@apple.com>
9977 Check in a file created by the Xcode 10 beta.
9979 * WebKit.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist: Added.
9981 2018-05-28 Carlos Garcia Campos <cgarcia@igalia.com>
9983 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.3 release.
9985 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
9987 2018-05-25 Adrian Perez de Castro <aperez@igalia.com>
9989 Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.2 release.
9991 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
9993 2018-05-22 Alberto Garcia <berto@igalia.com>
9995 [CMake] Properly detect compiler flags, needed libs, and fallbacks for usage of 64-bit atomic operations
9996 https://bugs.webkit.org/show_bug.cgi?id=182622
9997 <rdar://problem/40292317>
9999 Reviewed by Michael Catanzaro.
10001 * Source/cmake/WebKitCompilerFlags.cmake:
10002 Move the test to detect whether we need to link against libatomic
10003 to a common CMake file so it can be used from both JavaScriptCore
10006 2018-05-22 Michael Catanzaro <mcatanzaro@igalia.com>
10008 Unreviewed, rolling out r231843.
10012 Reverted changeset:
10014 "[CMake] Properly detect compiler flags, needed libs, and
10015 fallbacks for usage of 64-bit atomic operations"
10016 https://bugs.webkit.org/show_bug.cgi?id=182622
10017 https://trac.webkit.org/changeset/231843
10019 2018-05-21 Fujii Hironori <Hironori.Fujii@sony.com>
10021 [WinCairo] Enable WebKit build by default
10022 https://bugs.webkit.org/show_bug.cgi?id=185141
10024 Reviewed by Per Arne Vollan.
10026 * Source/cmake/OptionsWin.cmake: Disable
10027 ENABLE_NETSCAPE_PLUGIN_API unconditionally for WinCairo port
10028 because it builds both WK1 and WK2.
10029 * Source/cmake/OptionsWinCairo.cmake: Turn ENABLE_WEBKIT on by default.
10030 Remove BUILDING_WIN_CAIRO_WEBKIT macro.
10032 2018-05-21 Carlos Garcia Campos <cgarcia@igalia.com>
10034 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.2 release.
10036 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
10038 2018-05-17 Carlos Alberto Lopez Perez <clopez@igalia.com>
10040 [WPE] Implement and enable FULLSCREEN_API
10041 https://bugs.webkit.org/show_bug.cgi?id=185676
10043 Reviewed by Žan Doberšek.
10045 Remove the CMake option to disable this option for WPE.
10046 This feature gets enabled now via Source/cmake/WebKitFeatures.cmake
10048 * Source/cmake/OptionsWPE.cmake:
10050 2018-05-16 Don Olmstead <don.olmstead@sony.com>
10052 [WinCairo] Update WinCairoRequirements
10053 https://bugs.webkit.org/show_bug.cgi?id=185700
10055 Reviewed by Per Arne Vollan.
10057 * Source/cmake/OptionsWinCairo.cmake:
10059 2018-05-16 Andy VanWagoner <andy@vanwagoner.family>
10061 Add support for Intl NumberFormat formatToParts
10062 https://bugs.webkit.org/show_bug.cgi?id=185375
10064 Reviewed by Yusuke Suzuki.
10066 Add flag for NumberFormat formatToParts.
10068 * Source/cmake/OptionsJSCOnly.cmake:
10069 * Source/cmake/WebKitFeatures.cmake:
10071 2018-05-14 Yusuke Suzuki <utatane.tea@gmail.com>
10073 [Win] Use C++17 in MSVC
10074 https://bugs.webkit.org/show_bug.cgi?id=185232
10076 Reviewed by Alex Christensen.
10078 Use /std:c++17 option.
10080 * Source/cmake/OptionsMSVC.cmake:
10082 2018-05-16 Alberto Garcia <berto@igalia.com>
10084 [CMake] Properly detect compiler flags, needed libs, and fallbacks for usage of 64-bit atomic operations
10085 https://bugs.webkit.org/show_bug.cgi?id=182622
10087 Reviewed by Michael Catanzaro.
10089 * Source/cmake/OptionsGTK.cmake:
10090 * Source/cmake/OptionsJSCOnly.cmake:
10091 * Source/cmake/OptionsWPE.cmake:
10092 Enable THREADS_PREFER_PTHREAD_FLAG. This uses -pthread instead of
10093 -lpthread, fixing the 64-bit RISC-V build of the GTK+ port due to
10094 missing atomic primitives.
10096 * Source/cmake/WebKitCompilerFlags.cmake:
10097 Move the test to detect whether we need to link against libatomic
10098 to a common CMake file so it can be used from both JavaScriptCore
10101 2018-05-14 Zan Dobersek <zdobersek@igalia.com>
10103 [GTK] REGRESSION(r231170) Build broken with Clang 5.0
10104 https://bugs.webkit.org/show_bug.cgi?id=185198
10106 Reviewed by Michael Catanzaro.
10108 * Source/cmake/WebKitCompilerFlags.cmake: Fall back to the -std=c++1z
10109 compiler flag if -std=c++17 is not supported. If that flag is not
10110 supported either, bail with an error message.
10112 2018-05-09 Jan Alexander Steffens <jan.steffens@gmail.com>
10114 [GTK] gtk-doc installation subdir duplicated
10115 https://bugs.webkit.org/show_bug.cgi?id=185468
10117 Reviewed by Carlos Garcia Campos.
10119 The GTK docs are installed into a duplicated subdir,
10120 e.g. /usr/share/doc/gtk-doc/html/webkit2gtk-4.0/webkit2gtk-4.0.
10122 * Source/PlatformGTK.cmake:
10124 2018-05-09 Michael Catanzaro <mcatanzaro@igalia.com>
10126 Unreviewed. Bump WPE soname for good measure.
10128 * Source/cmake/OptionsWPE.cmake:
10130 2018-05-09 Michael Catanzaro <mcatanzaro@igalia.com>
10132 Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
10134 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
10136 2018-05-06 Yusuke Suzuki <utatane.tea@gmail.com>
10138 [JSC][GTK][JSCONLY] Use capstone disassembler
10139 https://bugs.webkit.org/show_bug.cgi?id=185283
10141 Reviewed by Michael Catanzaro.
10143 * Source/CMakeLists.txt:
10144 * Source/cmake/FindLLVM.cmake: Removed.
10145 * Source/cmake/OptionsCommon.cmake:
10146 * Source/cmake/OptionsGTK.cmake:
10147 * Source/cmake/OptionsJSCOnly.cmake:
10148 * Source/cmake/OptionsWPE.cmake:
10150 2018-05-08 Valerie R Young <valerie@bocoup.com>
10152 test262/Runner.pm: create results dir for results of test262 run
10153 https://bugs.webkit.org/show_bug.cgi?id=185392
10155 Reviewed by Michael Saboff.
10157 Remove reference to no longer existing files.
10161 2018-05-07 Yusuke Suzuki <utatane.tea@gmail.com>
10163 [JSCOnly] Enable Intl.PluralRules
10164 https://bugs.webkit.org/show_bug.cgi?id=185359
10166 Reviewed by Daniel Bates.
10168 Enable Intl.PluralRules because JSCOnly port enables features aggressively.
10170 * Source/cmake/OptionsJSCOnly.cmake:
10172 2018-05-07 Don Olmstead <don.olmstead@sony.com>
10174 [WinCairo] Disable plugin api when building modern WebKit
10175 https://bugs.webkit.org/show_bug.cgi?id=185312
10177 Reviewed by Michael Catanzaro.
10179 * Source/cmake/OptionsWin.cmake:
10181 2018-05-02 Valerie R Young <valerie@bocoup.com>
10183 test262/Runner.pm: save summary to file
10184 https://bugs.webkit.org/show_bug.cgi?id=185200
10186 Reviewed by Michael Saboff.
10190 2018-05-01 Leo Balter <leonardo.balter@gmail.com>
10192 Auto save the results for Test262
10193 https://bugs.webkit.org/show_bug.cgi?id=184926
10195 Reviewed by Michael Saboff.
10197 2018-05-01 Oleksandr Skachkov <gskachkov@gmail.com>
10199 WebAssembly: add support for stream APIs - JavaScript API
10200 https://bugs.webkit.org/show_bug.cgi?id=183442
10202 Reviewed by Yusuke Suzuki and JF Bastien.
10204 * Source/cmake/WebKitFeatures.cmake:
10206 2018-04-30 JF Bastien <jfbastien@apple.com>
10208 Use some C++17 features
10209 https://bugs.webkit.org/show_bug.cgi?id=185135
10211 Reviewed by Alex Christensen.
10213 As discussed here [0] let's move WebKit to a subset of C++17. We
10214 now require GCC 6 [1] which means that, according to [2] we can
10215 use the following C++17 language features (I removed some
10216 uninteresting ones):
10218 - New auto rules for direct-list-initialization
10219 - static_assert with no message
10220 - typename in a template template parameter
10221 - Nested namespace definition
10222 - Attributes for namespaces and enumerators
10223 - u8 character literals
10224 - Allow constant evaluation for all non-type template arguments
10226 - Unary fold expressions and empty parameter packs
10227 - __has_include in preprocessor conditional
10228 - Differing begin and end types in range-based for
10229 - Improving std::pair and std::tuple
10231 Consult the Tony Tables [3] to see before / after examples.
10233 Of course we can use any library feature if we're willing to
10234 import them to WTF (and they don't require language support).
10237 [0]: https://lists.webkit.org/pipermail/webkit-dev/2018-March/029922.html
10238 [1]: https://trac.webkit.org/changeset/231152/webkit
10239 [2]: https://en.cppreference.com/w/cpp/compiler_support
10240 [3]: https://github.com/tvaneerd/cpp17_in_TTs/blob/master/ALL_IN_ONE.md
10242 * Source/cmake/WebKitCompilerFlags.cmake:
10244 2018-04-29 Michael Catanzaro <mcatanzaro@igalia.com>
10246 [CMake] Require GCC 6
10247 https://bugs.webkit.org/show_bug.cgi?id=184985
10249 Reviewed by Alex Christensen.
10255 2018-04-26 Daniel Bates <dabates@apple.com>
10257 ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
10258 https://bugs.webkit.org/show_bug.cgi?id=184161
10259 <rdar://problem/39051645>
10261 Reviewed by Dan Bernstein.
10263 * ManualTests/DragInlinePDFImageDocument.html: Added.
10264 * ManualTests/resources/simple.pdf: Added.
10266 2018-04-26 Andy VanWagoner <thetalecrafter@gmail.com>
10268 [INTL] Implement Intl.PluralRules
10269 https://bugs.webkit.org/show_bug.cgi?id=184312
10271 Reviewed by JF Bastien.
10273 Added Intl.PluralRules feature flag.
10275 * Source/cmake/WebKitFeatures.cmake:
10277 2018-04-26 Zan Dobersek <zdobersek@igalia.com>
10279 [GTK][WPE] Initial ASYNC_SCROLLING support
10280 https://bugs.webkit.org/show_bug.cgi?id=184961
10282 Reviewed by Carlos Garcia Campos.
10284 * Source/cmake/OptionsGTK.cmake: Enable ASYNC_SCROLLING as a private option.
10285 * Source/cmake/OptionsWPE.cmake: Ditto.
10287 2018-04-25 Michael Catanzaro <mcatanzaro@igalia.com>
10289 [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
10290 https://bugs.webkit.org/show_bug.cgi?id=184643
10292 Reviewed by Žan Doberšek.
10294 Update find modules to include the API versions.
10296 * Source/cmake/FindWPEBackend-fdo.cmake:
10297 * Source/cmake/FindWPEBackend.cmake:
10299 2018-04-25 Michael Catanzaro <mcatanzaro@igalia.com>
10301 [CMake] Some options should be marked as advanced
10302 https://bugs.webkit.org/show_bug.cgi?id=184972
10304 Reviewed by Konstantin Tokarev.
10306 * Source/cmake/FindLibGcrypt.cmake:
10307 * Source/cmake/FindWebP.cmake:
10309 2018-04-25 Michael Catanzaro <mcatanzaro@igalia.com>
10311 [GTK] Miscellaneous build cleanups
10312 https://bugs.webkit.org/show_bug.cgi?id=184399
10314 Reviewed by Žan Doberšek.
10316 * Source/cmake/OptionsGTK.cmake:
10318 2018-04-24 Leo Balter <leonardo.balter@gmail.com>
10320 Land test262 test results associated with Test262 runner
10321 https://bugs.webkit.org/show_bug.cgi?id=184667
10323 Reviewed by Michael Saboff.
10325 * .gitignore: Ignore test262 results file.
10327 2018-04-24 Zan Dobersek <zdobersek@igalia.com>
10329 [WPE] Remove libgbm dependency
10330 https://bugs.webkit.org/show_bug.cgi?id=184906
10332 Reviewed by Carlos Garcia Campos.
10334 Remove the libgbm CMake search module. It's not necessary anymore
10337 * Source/cmake/FindLibGBM.cmake: Removed.
10339 2018-04-23 Michael Catanzaro <mcatanzaro@igalia.com>
10341 [GTK] check target looks broken
10342 https://bugs.webkit.org/show_bug.cgi?id=184407
10344 Reviewed by Carlos Garcia Campos.
10346 It's pretty clear that nobody has been using check for a long time.
10348 We got rid of check-for-webkitdom-api-breaks a long time ago, when we stopped autogenerating
10349 the DOM API, but it's still used in the check target. Fix this.
10351 Also, the check target for some reason runs itself from the Source subdirectory of the
10352 builddir, but the test script expects to be run from the toplevel build directory. Fix this
10355 Add VERBATIM for good measure.
10357 * Source/PlatformGTK.cmake:
10359 2018-04-20 Daniel Bates <dabates@apple.com>
10361 Unreviewed, rolling out r230117.
10363 Broke find-in-page for PDFs
10365 Reverted changeset:
10367 "ASSERTION FAILED: ASSERT(!containsImage ||
10368 MIMETypeRegistry::isSupportedImageResourceMIMEType([resource
10369 MIMEType])) in -[NSPasteboard(WebExtras)
10370 _web_writePromisedRTFDFromArchive:containsImage:]"
10371 https://bugs.webkit.org/show_bug.cgi?id=184161
10372 https://trac.webkit.org/changeset/230117
10374 2018-04-20 Carlos Garcia Campos <cgarcia@igalia.com>
10376 [GTK] Local cross references are broken in API documentation
10377 https://bugs.webkit.org/show_bug.cgi?id=184771
10379 Reviewed by Michael Catanzaro.
10381 Update the documentation html paths and install the JSC GLib API too.
10383 * Source/PlatformGTK.cmake:
10385 2018-04-18 Carlos Garcia Campos <cgarcia@igalia.com>
10387 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.1 release.
10389 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
10391 2018-04-17 Zan Dobersek <zdobersek@igalia.com>
10393 [CMake] Add and enable the ENABLE_CSS_ANIMATIONS_LEVEL_2 feature define
10394 https://bugs.webkit.org/show_bug.cgi?id=184681
10396 Reviewed by Carlos Garcia Campos.
10398 * Source/cmake/WebKitFeatures.cmake: Add the ENABLE_CSS_ANIMATIONS_LEVEL_2
10399 feature define. Follow Cocoa ports and enable it by default.
10401 2018-04-15 Michael Catanzaro <mcatanzaro@igalia.com>
10403 [WPE] Install files needed for WebKitWebExtensions
10404 https://bugs.webkit.org/show_bug.cgi?id=179915
10406 Reviewed by Žan Doberšek.
10408 * Source/cmake/OptionsWPE.cmake:
10410 2018-04-12 Ryan Haddad <ryanhaddad@apple.com>
10412 Unreviewed, rolling out r230554.
10414 The non-ASCII character in the filename causes issues with SVN
10416 Reverted changeset:
10418 "input.webkitEntries does not work as expected when folder
10419 contains accented chars"
10420 https://bugs.webkit.org/show_bug.cgi?id=184517
10421 https://trac.webkit.org/changeset/230554
10423 2018-04-12 Zan Dobersek <zdobersek@igalia.com>
10425 [WPE] Switch testing process to using WPEBackend-fdo
10426 https://bugs.webkit.org/show_bug.cgi?id=184357
10428 Reviewed by Carlos Alberto Lopez Perez.
10430 * Source/cmake/FindWPEBackend-fdo.cmake: Renamed from Source/cmake/FindWPEBackend-mesa.cmake.
10432 2018-04-11 Thibault Saunier <tsaunier@igalia.com>
10434 [GStreamer] Use of playbin3 when USE_PLAYBIN3 environment variable is set
10435 https://bugs.webkit.org/show_bug.cgi?id=184498
10437 Reviewed by Philippe Normand.
10439 This is the same behaviour as with playbin itself.
10441 Make sure to keep using "playbin" for MediaSource.
10443 * Source/cmake/GStreamerDefinitions.cmake:
10445 2018-04-09 Michael Catanzaro <mcatanzaro@igalia.com>
10447 [WPE] Use GNU install directories
10448 https://bugs.webkit.org/show_bug.cgi?id=184377
10450 Reviewed by Carlos Garcia Campos.
10452 Notably, this means all the CMake arguments that distributors use to customize install
10453 directories (-DCMAKE_INSTALL_*DIR) will no longer be ignored.
10455 * Source/cmake/OptionsCommon.cmake:
10456 * Source/cmake/OptionsWPE.cmake:
10458 2018-04-08 Fujii Hironori <Hironori.Fujii@sony.com>
10460 [CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library
10461 https://bugs.webkit.org/show_bug.cgi?id=184127
10463 Reviewed by Konstantin Tokarev.
10465 Building TestWebKitLib on Windows causes a linkage error of
10466 multiply defined symbols because TestWebKitLib links to
10467 both WebCore and WebKit. TestWebKitLib explicitly links only with
10468 WebKit, But, WebCore is propagated because WebKit links WebCore as
10471 * Source/cmake/OptionsGTK.cmake (ADD_WHOLE_ARCHIVE_TO_LIBRARIES):
10472 Do not wrap PRIVATE and PUBLIC keywords with -Wl,--whole-archive.
10474 2018-04-08 Michael Catanzaro <mcatanzaro@igalia.com>
10476 [WPE][GTK] Remove applicationDirectoryPath() and sharedResourcePath()
10477 https://bugs.webkit.org/show_bug.cgi?id=184381
10479 Reviewed by Carlos Garcia Campos.
10481 * Source/cmake/OptionsGTK.cmake:
10482 * Source/cmake/OptionsWPE.cmake:
10484 2018-04-02 Per Arne Vollan <pvollan@apple.com>
10486 Remove references to internal version of WebKitQuartzCoreAdditions in CMake files.
10487 https://bugs.webkit.org/show_bug.cgi?id=184246
10488 <rdar://problem/39116563>
10490 Unreviewed build fix.
10492 * Source/PlatformWin.cmake:
10494 2018-04-02 Alejandro G. Castro <alex@igalia.com>
10496 [GTK] Make libwebrtc backend buildable for GTK port
10497 https://bugs.webkit.org/show_bug.cgi?id=178860
10499 Reviewed by Youenn Fablet.
10501 * Source/CMakeLists.txt: Add the libwebrtc directory to the compilation.
10502 * Source/cmake/OptionsGTK.cmake: Add the USE_LIBWEBRTC option to
10503 allow compilation of the specific code.
10505 2018-03-30 Daniel Bates <dabates@apple.com>
10507 ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
10508 https://bugs.webkit.org/show_bug.cgi?id=184161
10510 Reviewed by Per Arne Vollan.
10512 * ManualTests/DragInlinePDFImageDocument.html: Added.
10513 * ManualTests/resources/simple.pdf: Added.
10515 2018-03-28 Tim Horton <timothy_horton@apple.com>
10517 Make it possible to disable building the tools with Make
10518 https://bugs.webkit.org/show_bug.cgi?id=184109
10520 Reviewed by Simon Fraser.
10524 2018-03-25 Carlos Garcia Campos <cgarcia@igalia.com>
10526 [GTK][WPE] Add API to convert between DOM and JSCValue
10527 https://bugs.webkit.org/show_bug.cgi?id=183448
10529 Reviewed by Michael Catanzaro.
10531 Define FORWARDING_HEADERS_WPE_DOM_DIR.
10533 * Source/cmake/OptionsWPE.cmake:
10535 2018-03-22 Adrian Perez de Castro <aperez@igalia.com>
10537 [WPE] Enable WOFF2 support
10538 https://bugs.webkit.org/show_bug.cgi?id=178158
10540 Reviewed by Frédéric Wang.
10542 * Source/cmake/OptionsWPE.cmake: Add needed logic to detect the Brotli and WOFF2 libraries.
10544 2018-03-21 Carlos Garcia Campos <cgarcia@igalia.com>
10546 [GTK][WPE] Initial implementation of JavaScriptCore glib bindings
10547 https://bugs.webkit.org/show_bug.cgi?id=164061
10549 Reviewed by Michael Catanzaro.
10551 Set global variables used by the makefiles.
10553 * Source/cmake/OptionsGTK.cmake:
10554 * Source/cmake/OptionsWPE.cmake:
10556 2018-03-15 Ms2ger <Ms2ger@igalia.com>
10558 [GTK][WPE] Enable service workers
10559 https://bugs.webkit.org/show_bug.cgi?id=178576
10561 Reviewed by Žan Doberšek.
10563 * Source/cmake/OptionsGTK.cmake:
10564 * Source/cmake/OptionsWPE.cmake:
10566 2018-03-12 Yoav Weiss <yoav@yoav.ws>
10568 Runtime flag for link prefetch and remove link subresource.
10569 https://bugs.webkit.org/show_bug.cgi?id=183540
10571 Reviewed by Chris Dumez.
10573 Remove the LINK_PREFETCH build time flag.
10575 * Source/cmake/OptionsWin.cmake:
10576 * Source/cmake/WebKitFeatures.cmake:
10577 * Source/cmake/tools/vsprops/FeatureDefines.props:
10578 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
10580 2018-03-12 Zan Dobersek <zdobersek@igalia.com>
10582 Unreviewed. Unbreak the WPE layout testing that's been broken since
10583 r229470. Due to disassociation between ENABLE(ACCESSIBILITY) and
10584 HAVE(ACCESSIBILITY), the injected bundle for the WPE port was left with
10585 undefined symbols. This is fixed with ENABLE_ACCESSIBILITY being enabled
10586 for the WPE port as well.
10588 * Source/cmake/OptionsWPE.cmake:
10590 2018-03-12 Carlos Garcia Campos <cgarcia@igalia.com>
10592 Unreviewed. Fix library version of JavaScriptCoreGTK.
10594 * Source/cmake/OptionsGTK.cmake:
10596 2018-03-09 Carlos Garcia Campos <cgarcia@igalia.com>
10598 Unreviewed. Bump WebKitGTK+ version to 2.21.0.
10600 * Source/cmake/OptionsGTK.cmake:
10602 2018-03-08 Tim Horton <timothy_horton@apple.com>
10604 Add a way to not build libwebrtc when building WebKit via Makefiles
10605 https://bugs.webkit.org/show_bug.cgi?id=183437
10606 <rdar://problem/38254840>
10608 Reviewed by Dan Bernstein.
10612 2018-03-05 Don Olmstead <don.olmstead@sony.com>
10614 [CMake] Split JSC header copying into public and private targets
10615 https://bugs.webkit.org/show_bug.cgi?id=183251
10617 Reviewed by Konstantin Tokarev.
10619 * Source/cmake/WebKitMacros.cmake:
10621 2018-03-02 Don Olmstead <don.olmstead@sony.com>
10623 Add clang-format configuration
10624 https://bugs.webkit.org/show_bug.cgi?id=183302
10626 Reviewed by Ryosuke Niwa.
10628 * .clang-format: Added.
10630 2018-03-01 Michael Catanzaro <mcatanzaro@igalia.com>
10632 [CMake] configure failure for aarch64
10633 https://bugs.webkit.org/show_bug.cgi?id=183268
10635 Unreviewed build fix. This failure is caused by a simple typo.
10637 * Source/cmake/OptionsCommon.cmake:
10639 2018-02-26 Yousuke Kimoto <yousuke.kimoto@sony.com>
10641 [WinCairo] WebKit2_C.h should be included for TestWebKit
10642 https://bugs.webkit.org/show_bug.cgi?id=182682
10644 Reviewed by Yusuke Suzuki.
10646 Added a new definition "BUILDING_WIN_CAIRO_WEBKIT" to specify
10647 the wincairo webkit build.
10649 * Source/cmake/OptionsWinCairo.cmake:
10651 2018-02-26 Fujii Hironori <Hironori.Fujii@sony.com>
10653 [CMake][OpenVR] Linkage errors happen because only OpenVR is compiled with -stdlib=libc++ if Clang is used
10654 https://bugs.webkit.org/show_bug.cgi?id=183116
10656 Reviewed by Žan Doberšek.
10658 OpenVR has a option USE_LIBCXX to enable/disable that behavior. Let's disable it.
10660 * Source/CMakeLists.txt: Added a option command for USE_LIBCXX to set OFF as default.
10662 2018-02-21 Don Olmstead <don.olmstead@sony.com>
10664 [CMake] Expose HAVE macros globally
10665 https://bugs.webkit.org/show_bug.cgi?id=183011
10667 Reviewed by Michael Catanzaro.
10669 * Source/cmake/OptionsCommon.cmake:
10670 * Source/cmake/WebKitFeatures.cmake:
10672 2018-02-21 Don Olmstead <don.olmstead@sony.com>
10674 [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
10675 https://bugs.webkit.org/show_bug.cgi?id=182883
10677 Reviewed by Per Arne Vollan.
10679 * Source/cmake/OptionsAppleWin.cmake:
10680 * Source/cmake/OptionsWin.cmake:
10681 * Source/cmake/OptionsWinCairo.cmake:
10683 2018-02-21 Michael Catanzaro <mcatanzaro@igalia.com>
10685 [GTK] USE_UPOWER causes crashes inside a chroot or on systems with broken dbus/upower
10686 https://bugs.webkit.org/show_bug.cgi?id=181825
10688 Reviewed by Carlos Garcia Campos.
10690 Get rid of the upower-glib dependency. We will use upower's D-Bus API instead.
10692 * Source/cmake/FindUPowerGLib.cmake: Removed.
10693 * Source/cmake/OptionsGTK.cmake:
10695 2018-02-20 Adrian Perez de Castro <aperez@igalia.com>
10697 [GTK][CMake] Support building with Enchant 2.x
10698 https://bugs.webkit.org/show_bug.cgi?id=182933
10700 Reviewed by Michael Catanzaro.
10702 * Source/cmake/FindEnchant.cmake: Check for both the "enchant" and "enchant-2"
10703 pkg-config components, picking the first available for which the headers and
10704 library are usable.
10706 2018-02-19 Philippe Normand <pnormand@igalia.com>
10708 [GStreamer] Playbin3 support
10709 https://bugs.webkit.org/show_bug.cgi?id=182530
10711 Reviewed by Xabier Rodriguez-Calvar.
10713 * Source/cmake/GStreamerDefinitions.cmake: New
10714 USE(GSTREAMER_PLAYBIN3) feature. This should be enabled only for
10715 very recent versions of GStreamer (1.14 at least) and is optional, for now.
10717 2018-02-18 Philippe Normand <pnormand@igalia.com>
10719 [GTK][WPE] Fullscreen video is broken
10720 https://bugs.webkit.org/show_bug.cgi?id=182740
10722 Reviewed by Michael Catanzaro.
10724 * Source/cmake/WebKitFeatures.cmake: Enable the
10725 VIDEO_USES_ELEMENT_FULLSCREEN feature on CMake ports.
10727 2018-02-16 Dean Jackson <dino@apple.com>
10729 Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
10730 https://bugs.webkit.org/show_bug.cgi?id=182894
10732 Reviewed by Tim Horton.
10734 Rename OPENGL_ES_2 to OPENGL_ES.
10736 * Source/cmake/OptionsGTK.cmake:
10737 * Source/cmake/OptionsWPE.cmake:
10739 2018-02-09 Ross Kirsling <ross.kirsling@sony.com>
10741 Simplify .gitignore's WebKitLibraries/win section.
10742 https://bugs.webkit.org/show_bug.cgi?id=182618
10744 Reviewed by Per Arne Vollan.
10746 We need to update this section for WinCairoRequirements regardless, but
10747 it never needed to be this longwinded in the first place.
10751 2018-02-08 Fujii Hironori <Hironori.Fujii@sony.com>
10753 [Meta][Win] Support ICU 59.1+
10754 https://bugs.webkit.org/show_bug.cgi?id=181004
10756 Reviewed by Alex Christensen.
10758 ICU 59 changed the type of UChar from wchar_t to char16_t on
10759 Windows. We need a lot of conversions between UChar* and wchar_t*
10760 to call Windows API because it takes string as wchar_t*.
10762 Fortunately, ICU is configurable to define UChar as wchar_t as
10763 well as the prior ICU.
10764 <http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac>
10766 * Source/cmake/OptionsWin.cmake: Add a compile option -DUCHAR_TYPE=wchar_t.
10768 2018-02-08 Michael Catanzaro <mcatanzaro@igalia.com>
10770 Unreviewed, switch -pthread to -lpthread per recommendation from Adrian
10771 https://bugs.webkit.org/show_bug.cgi?id=182400
10772 <rdar://problem/37252242>
10774 This is tested and works fine.
10776 * Source/cmake/WebKitCompilerFlags.cmake:
10778 2018-02-05 Yousuke Kimoto <yousuke.kimoto@sony.com>
10780 [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
10781 https://bugs.webkit.org/show_bug.cgi?id=182478
10783 Reviewed by Alex Christensen.
10785 * Source/cmake/OptionsWinCairo.cmake: Added a ENABLE_WIN_CAIRO_WEBKIT option to build webkit for wincairo.
10787 2018-02-05 Michael Catanzaro <mcatanzaro@igalia.com>
10789 Unreviewed, fix build using the new ENABLE_ADDRESS_SANITIZER option
10790 https://bugs.webkit.org/show_bug.cgi?id=182400
10791 <rdar://problem/37252242>
10793 I failed to properly test a last-minute change.
10795 * Source/cmake/WebKitCompilerFlags.cmake:
10797 2018-02-05 Michael Catanzaro <mcatanzaro@igalia.com>
10799 [CMake] Add ENABLE_ADDRESS_SANITIZER to make it easier to build with asan support
10800 https://bugs.webkit.org/show_bug.cgi?id=182400
10802 Reviewed by Konstantin Tokarev.
10804 * Source/cmake/OptionsGTK.cmake:
10805 * Source/cmake/WebKitCompilerFlags.cmake:
10807 2018-01-31 Michael Catanzaro <mcatanzaro@igalia.com>
10810 https://bugs.webkit.org/show_bug.cgi?id=182314
10812 Reviewed by Alex Christensen.
10814 Add download link for Epiphany Technology Preview. Improve build instructions for GTK. Add
10815 build instructions for WPE. Add instructions to run MiniBrowser on Linux. Miscellaneous
10816 typographical adjustments.
10820 2018-01-30 Sergio Villar Senin <svillar@igalia.com>
10822 [WebVR][GTK][WPE] Exclude OpenVR from tarballs
10823 https://bugs.webkit.org/show_bug.cgi?id=182284
10825 Reviewed by Michael Catanzaro.
10827 Added private build options for USE_OPENVR.
10829 * Source/cmake/OptionsGTK.cmake:
10830 * Source/cmake/OptionsWPE.cmake:
10832 2018-01-30 Basuke Suzuki <Basuke.Suzuki@sony.com>
10834 [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
10835 https://bugs.webkit.org/show_bug.cgi?id=177202
10837 Reviewed by Alex Christensen.
10839 * Source/cmake/WebKitMacros.cmake:
10841 2018-01-29 Jiewen Tan <jiewen_tan@apple.com>
10843 [WebAuthN] Add a compile-time feature flag
10844 https://bugs.webkit.org/show_bug.cgi?id=182211
10845 <rdar://problem/36936365>
10847 Reviewed by Brent Fulgham.
10849 * Source/cmake/WebKitFeatures.cmake:
10850 * Source/cmake/tools/vsprops/FeatureDefines.props:
10851 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
10853 2018-01-18 Sergio Villar Senin <svillar@igalia.com>
10855 [WebVR] Add OpenVR to the tree and to the build
10856 https://bugs.webkit.org/show_bug.cgi?id=177298
10858 Reviewed by Žan Doberšek.
10860 * Source/CMakeLists.txt:
10861 * Source/cmake/OptionsGTK.cmake: Enable USE_OPENVR.
10862 * Source/cmake/OptionsWPE.cmake: Ditto.
10864 2018-01-18 Dan Bernstein <mitz@apple.com>
10866 [Xcode] Shared schemes in the WebKit workspace still have build pre-actions that invoke copy-webkitlibraries-to-product-directory
10867 https://bugs.webkit.org/show_bug.cgi?id=181784
10869 Reviewed by Anders Carlsson.
10871 * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Remove the build pre-action.
10872 * WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Ditto.
10874 2018-01-17 Michael Catanzaro <mcatanzaro@igalia.com>
10876 WEBKIT_FRAMEWORK should not modify file-global include directories
10877 https://bugs.webkit.org/show_bug.cgi?id=181656
10879 Reviewed by Konstantin Tokarev.
10881 Only modify the system include directories of the target passed to WEBKIT_FRAMEWORK.
10883 * Source/cmake/WebKitMacros.cmake:
10885 2018-01-17 Carlos Garcia Campos <cgarcia@igalia.com>
10887 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.6 release.
10889 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
10891 2018-01-15 Michael Catanzaro <mcatanzaro@igalia.com>
10893 REGRESSION(r226266): [GTK] RELEASE_ASSERT(reservedZoneSize >= minimumReservedZoneSize) in JSC::VM::updateStackLimits
10894 https://bugs.webkit.org/show_bug.cgi?id=181438
10895 <rdar://problem/36376724>
10897 Reviewed by Carlos Garcia Campos.
10899 Build JSC as a shared library.
10901 Stop using -fvisibility=hidden. This is a shame, but it is causing problems that I don't
10904 * Source/cmake/OptionsGTK.cmake:
10905 * Source/cmake/WebKitCompilerFlags.cmake:
10907 2018-01-11 Keith Miller <keith_miller@apple.com>
10909 Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
10910 https://bugs.webkit.org/show_bug.cgi?id=181573
10912 Reviewed by Simon Fraser.
10914 * Source/cmake/WebKitFeatures.cmake:
10916 2018-01-10 Per Arne Vollan <pvollan@apple.com>
10918 [Win] WebKitLegacy should be a dll, not a static library.
10919 https://bugs.webkit.org/show_bug.cgi?id=181500
10921 Reviewed by Alex Christensen.
10923 Set WebKitLegacy library type to shared.
10925 * Source/cmake/OptionsWin.cmake:
10927 2018-01-09 Carlos Garcia Campos <cgarcia@igalia.com>
10929 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.5 release.
10931 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
10933 2018-01-09 Carlos Garcia Campos <cgarcia@igalia.com>
10935 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.4 release.
10937 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
10939 2018-01-05 Fujii Hironori <Hironori.Fujii@sony.com>
10941 REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by unconditionally copied header files of DerivedSources
10942 https://bugs.webkit.org/show_bug.cgi?id=181324
10944 Reviewed by Konstantin Tokarev.
10946 r226306 changed to use cmake -E copy to copy header files of
10947 DerivedSources. This command copies files unconditionally, then
10948 introduced unnecessary recompilations.
10950 * Source/cmake/WebKitMacros.cmake: Use copy_if_different instead of copy.
10952 2018-01-03 Ting-Wei Lan <lantw44@gmail.com>
10954 Replace hard-coded paths in shebangs with #!/usr/bin/env
10955 https://bugs.webkit.org/show_bug.cgi?id=181040
10957 Reviewed by Alex Christensen.
10959 * Source/cmake/tools/scripts/auto-version.pl:
10960 * Source/cmake/tools/scripts/feature-defines.pl:
10961 * Source/cmake/tools/scripts/version-stamp.pl:
10963 == Rolled over to ChangeLog-2018-01-01 ==