1 2019-06-05 Wenson Hsieh <wenson_hsieh@apple.com>
3 Upstream content mode support into open source from WebKitAdditions
4 https://bugs.webkit.org/show_bug.cgi?id=198484
5 <rdar://problem/51355671>
7 Reviewed by Andy Estes.
9 Change the "useModernCompatibilityMode" layout test option to instead be "contentMode", with values of either
10 "mobile" or "desktop".
12 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13 * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Removed.
14 * TestWebKitAPI/ios/PreferredContentMode.mm: Added.
15 (-[ContentModeNavigationDelegate setDecidePolicyForNavigationActionWithPreferences:]):
16 (-[ContentModeNavigationDelegate decidePolicyForNavigationActionWithPreferences]):
17 (-[ContentModeNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
18 (+[WKWebpagePreferences preferencesWithContentMode:]):
19 (-[WKWebView navigatorUserAgent]):
20 (-[WKWebView navigatorPlatform]):
21 (-[WKWebView loadTestPageNamed:withPolicyDecisionHandler:]):
22 (-[WKWebView loadHTMLString:withPolicyDecisionHandler:]):
23 (-[WKWebView loadTestPageNamed:andExpectEffectiveContentMode:withPolicyDecisionHandler:]):
24 (-[NSString shouldContainStrings:]):
25 (IPhoneUserInterfaceSwizzler::IPhoneUserInterfaceSwizzler):
26 (IPhoneUserInterfaceSwizzler::phoneUserInterfaceIdiom):
27 (TestWebKitAPI::setUpWebViewForPreferredContentModeTestingWithoutNavigationDelegate):
28 (TestWebKitAPI::setUpWebViewForPreferredContentModeTesting):
29 (TestWebKitAPI::makeContentModeDecisionHandler):
30 (TestWebKitAPI::TEST):
31 * WebKitTestRunner/TestController.cpp:
32 (WTR::updateTestOptionsFromTestHeader):
33 * WebKitTestRunner/TestController.h:
34 * WebKitTestRunner/TestOptions.h:
35 (WTR::TestOptions::hasSameInitializationOptions const):
36 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
37 (WTR::TestController::platformCreateWebView):
38 (WTR::TestController::configureContentMode):
39 (WTR::TestController::enableModernCompatibilityMode): Deleted.
41 2019-06-01 Antoine Quint <graouts@apple.com>
43 [Pointer Events] Add support for chorded button interactions
44 https://bugs.webkit.org/show_bug.cgi?id=198462
46 Reviewed by Dean Jackson.
48 Until now, MouseEvent.buttons would always return 0 when used within DRT and WKTR as [NSEvent pressedMouseButtons], used
49 by PlatformMouseEventBuilder to set the m_buttons value eventually used to set MouseEvent.buttons, not account for the
50 NSEvent created through the eventSender JS object in tests. To fix this, we now track the pressed mouse buttons within
51 DRT and WKTR as mouseDown() and mouseUp() are called, and swizzle [NSEvent pressedMouseButtons] to return that value.
53 In the case of DRT, one test would fail when swizzling this method in the case where the target view for the event would
54 be the DRTMockScroller, a subclass of NSScroller. So we only swizzle when the target view is *not* an NSScroller or a
57 Finally, we change the NoMouseButton enum value from -1 to -2 to adjust to MouseEvent.button now being a "short".
59 * DumpRenderTree/mac/EventSendingController.mm:
60 (swizzledEventPressedMouseButtons):
61 (-[EventSendingController mouseDown:withModifiers:]):
62 (-[EventSendingController mouseUp:withModifiers:]):
63 (-[EventSendingController mouseMoveToX:Y:]):
64 * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
65 * WebKitTestRunner/EventSenderProxy.h:
66 (WTR::EventSenderProxy::mouseButtonsCurrentlyDown const):
67 * WebKitTestRunner/mac/EventSenderProxy.mm:
68 (WTR::swizzledEventPressedMouseButtons):
69 (WTR::EventSenderProxy::mouseDown):
70 (WTR::EventSenderProxy::mouseUp):
71 (WTR::EventSenderProxy::mouseMoveTo):
73 2019-06-04 Chris Dumez <cdumez@apple.com>
75 Cookies set via [WKHTTPCookieStore setCookie:] on store right after constructing WKWebView get lost
76 https://bugs.webkit.org/show_bug.cgi?id=198553
77 <rdar://problem/51317144>
79 Reviewed by Geoffrey Garen.
81 Add API test coverage.
83 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
84 (-[CheckSessionCookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
87 2019-06-04 Michael Catanzaro <mcatanzaro@igalia.com>
89 Fix miscellaneous build warnings
90 https://bugs.webkit.org/show_bug.cgi?id=198544
92 Reviewed by Don Olmstead.
94 When converting to PRIVATE include directories, we accidentally dropped SYSTEM here. The
95 naming convention used here is a bit confusing: the *_SYSTEM_INCLUDE_DIRECTORIES actually
96 uses both SYSTEM and PRIVATE. We should probably clarify this.
98 * TestWebKitAPI/PlatformGTK.cmake:
100 2019-06-04 Youenn Fablet <youenn@apple.com>
102 getUserMedia requests should be processed sequentially in UIProcess
103 https://bugs.webkit.org/show_bug.cgi?id=198430
104 <rdar://problem/51311420>
106 Reviewed by Eric Carlson.
108 * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
109 (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
110 (TestWebKitAPI::TEST):
111 * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
113 2019-06-04 David Kilzer <ddkilzer@apple.com>
115 REGRESSION (r244557): Leak of WKNSString in WTR::runOpenPanel() while running WebKit layout tests
116 <https://webkit.org/b/198538>
117 <rdar://problem/51407719>
119 Reviewed by Darin Adler.
121 * WebKitTestRunner/TestController.cpp:
122 (WTR::runOpenPanel): Use adoptWK() to fix the leak.
124 2019-06-04 Aakash Jain <aakash_jain@apple.com>
126 [ews-app] Add authentication while fetching bugs
127 https://bugs.webkit.org/show_bug.cgi?id=198415
128 <rdar://problem/51298710>
130 Reviewed by Jonathan Bedard.
132 * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
133 (Bugzilla._fetch_attachment_json): Use api_key if configured in environment variable.
134 (BugzillaBeautifulSoup.authenticate): Method to authenticate, logic copied from webkitpy/common/net/bugzilla/bugzilla.py
135 (BugzillaBeautifulSoup._load_query):
137 2019-06-04 Aakash Jain <aakash_jain@apple.com>
139 [ews-build] Do not display unnecessary steps in the Buildbot build page UI
140 https://bugs.webkit.org/show_bug.cgi?id=198218
141 <rdar://problem/51104544>
143 Reviewed by Jonathan Bedard.
145 * BuildSlaveSupport/ews-build/steps.py:
147 2019-06-04 Sihui Liu <sihui_liu@apple.com>
149 WKWebsiteDataStore API fails to fetch web storage data for non-persistent data store
150 https://bugs.webkit.org/show_bug.cgi?id=198317
152 Reviewed by Alex Christensen.
154 * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
155 (TestWebKitAPI::TEST):
157 2019-06-04 Takashi Komori <Takashi.Komori@sony.com>
159 [WinCairo] Implement cpu and memory measuring functions.
160 https://bugs.webkit.org/show_bug.cgi?id=198466
162 Reviewed by Don Olmstead.
164 * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
165 (WTR::TestRunner::inspectorTestStubURL):
167 2019-06-04 Zan Dobersek <zdobersek@igalia.com>
169 [misc] Remove JSCOnly ARMv7 Traditional bot
170 https://bugs.webkit.org/show_bug.cgi?id=198524
172 Reviewed by Carlos Garcia Campos.
174 This is not a supported configuration anymore, so the buildbot slave can
175 be removed from configuration.
177 * BuildSlaveSupport/build.webkit.org-config/config.json:
178 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
180 * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
182 2019-06-03 Andy Estes <aestes@apple.com>
184 [Apple Pay] Disable script injection when canMakePayment APIs are called and return true
185 https://bugs.webkit.org/show_bug.cgi?id=198448
186 <rdar://problem/51323694>
188 Reviewed by Alex Christensen.
190 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
191 * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
192 (-[TestApplePayAvailableScriptMessageHandler userContentController:didReceiveScriptMessage:]):
193 (-[TestApplePayActiveSessionScriptMessageHandler userContentController:didReceiveScriptMessage:]):
194 (TestWebKitAPI::TEST):
195 (TestWebKitAPI::runActiveSessionTest):
196 (-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]): Deleted.
197 (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
198 * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html:
199 * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-existing-object.html: Added.
200 * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html:
201 * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
202 * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-can-make-payment.html: Added.
203 * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-can-make-payments-with-active-card.html: Added.
204 * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-can-make-payments.html: Added.
205 * TestWebKitAPI/Tests/WebKitCocoa/apple-pay.js: Added.
206 (applePayRequestBase):
207 (applePayPaymentRequest):
209 * TestWebKitAPI/cocoa/TestProtocol.mm:
210 (-[TestProtocol startLoading]):
212 2019-06-03 Sihui Liu <sihui_liu@apple.com>
214 [ Mac WK2 ] TestWebKitAPI.WKWebView.LocalStorageProcessCrashes is a flaky timeout when run locally.
215 https://bugs.webkit.org/show_bug.cgi?id=198423
216 <rdar://problem/51305247>
218 Reviewed by Youenn Fablet.
220 IDBDatabase receives error event on network process crash, so we don't need to check it periodically.
222 * TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html:
224 2019-06-03 Rob Buis <rbuis@igalia.com>
226 Implement imagesrcset and imagesizes attributes on link rel=preload
227 https://bugs.webkit.org/show_bug.cgi?id=192950
229 Reviewed by Youenn Fablet.
231 Add a runtime flag for link preload responsive images.
233 * DumpRenderTree/mac/DumpRenderTree.mm:
234 (enableExperimentalFeatures):
236 2019-06-03 Don Olmstead <don.olmstead@sony.com>
238 [CMake] Use WEBKIT_EXECUTABLE in ImageDiff
239 https://bugs.webkit.org/show_bug.cgi?id=198490
241 Reviewed by Konstantin Tokarev.
243 Use WEBKIT_EXECUTABLE in ImageDiff. Change CMake variables to use the proper
244 convention. Add a shared CoreGraphics.cmake instead of just including PlatformMac
247 * ImageDiff/CMakeLists.txt:
248 * ImageDiff/Cairo.cmake:
249 * ImageDiff/CoreGraphics.cmake: Added.
250 * ImageDiff/PlatformGTK.cmake:
251 * ImageDiff/PlatformMac.cmake:
252 * ImageDiff/PlatformWin.cmake:
254 2019-06-02 Andy Estes <aestes@apple.com>
256 Memory-cached main resources continue to load after the client decides a content policy of PolicyAction::Download
257 https://bugs.webkit.org/show_bug.cgi?id=198469
258 <rdar://problem/50512713>
260 Reviewed by Youenn Fablet.
262 * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
263 (-[TestDownloadNavigationResponseFromMemoryCacheDelegate webView:didStartProvisionalNavigation:]):
264 (-[TestDownloadNavigationResponseFromMemoryCacheDelegate webView:didFailProvisionalNavigation:withError:]):
265 (-[TestDownloadNavigationResponseFromMemoryCacheDelegate webView:didFinishNavigation:]):
266 (-[TestDownloadNavigationResponseFromMemoryCacheDelegate _downloadDidStart:]):
267 (-[TestDownloadNavigationResponseFromMemoryCacheDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
269 * TestWebKitAPI/cocoa/TestProtocol.h:
270 * TestWebKitAPI/cocoa/TestProtocol.mm:
271 (+[TestProtocol additionalResponseHeaders]):
272 (+[TestProtocol setAdditionalResponseHeaders:]):
273 (-[TestProtocol startLoading]):
275 2019-06-03 Timothy Hatcher <timothy@apple.com>
277 Tweak the text and underline color for data detected text.
278 https://bugs.webkit.org/show_bug.cgi?id=198487
279 rdar://problem/50667125
281 Reviewed by Devin Rousso.
283 * TestWebKitAPI/Tests/WebCore/Color.cpp:
284 (TestWebKitAPI::TEST): Added Color.RGBToHSL tests.
286 2019-06-03 Don Olmstead <don.olmstead@sony.com>
288 [CMake] Add WebKit::JavaScriptCore target
289 https://bugs.webkit.org/show_bug.cgi?id=198403
291 Reviewed by Konstantin Tokarev.
293 Use the WebKit::JavaScriptCore target.
295 * DumpRenderTree/CMakeLists.txt:
296 * MiniBrowser/win/CMakeLists.txt:
297 * TestWebKitAPI/CMakeLists.txt:
298 * TestWebKitAPI/PlatformGTK.cmake:
299 * TestWebKitAPI/PlatformWPE.cmake:
300 * TestWebKitAPI/glib/CMakeLists.txt:
301 * WebKitTestRunner/CMakeLists.txt:
303 2019-06-03 Darin Adler <darin@apple.com>
305 Finish cleanup of String::number for floating point
306 https://bugs.webkit.org/show_bug.cgi?id=198471
308 Reviewed by Yusuke Suzuki.
310 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
311 (TestWebKitAPI::testStringNumber): Go back to calling String::number instead of
312 String::numberToStringECMAScript.
314 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
315 (WTR::dumpFrameScrollPosition): Use appendNumber instead of appendECMAScriptNumber
316 since that is now the default.
318 2019-06-02 Fujii Hironori <Hironori.Fujii@sony.com>
320 [WinCairo][MiniBrowser] WKViewSetIsInWindow should be called
321 https://bugs.webkit.org/show_bug.cgi?id=198474
323 Reviewed by Darin Adler.
325 WinCairo WK2 MiniBrowser can't play back videos because
326 Page::canStartMedia() always returns false. WKViewSetIsInWindow
329 The original MiniBrowser did it in Bug 55364.
331 * MiniBrowser/win/WebKitBrowserWindow.cpp:
332 (WebKitBrowserWindow::WebKitBrowserWindow): Call WKViewSetIsInWindow.
334 2019-05-31 Sihui Liu <sihui_liu@apple.com>
336 TestWebKitAPI.WKWebView.LocalStorageProcessSuspends is flaky
337 https://bugs.webkit.org/show_bug.cgi?id=198450
339 Reviewed by Ryosuke Niwa.
341 In local-storage-process-suspends-2.html, we periodically checked local storage item and sent a message when the
342 item value was changed or times of check reached limit. We expected the message to be sent after network process
343 resumed from suspension, because that's when the item value should get updated. However, the limit we set seemed
344 to be not high enough, so that the message could be sent eariler than expected, when limit of check number was
347 We can solve this in different ways. To make the test robust, we can send the message on a storage event, which
348 notifies about changes in local storage.
350 * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
352 * TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-suspends-2.html:
354 2019-05-31 Ryosuke Niwa <rniwa@webkit.org>
356 DragAndDropTests.DragImageLocationForLinkInSubframe fails on some iPad
357 https://bugs.webkit.org/show_bug.cgi?id=198447
359 Reviewed by Wenson Hsieh.
361 Give the elements an explicit 400px width to make the test always work.
363 * TestWebKitAPI/Tests/WebKitCocoa/link-in-iframe-and-input.html:
365 2019-05-31 Wenson Hsieh <wenson_hsieh@apple.com>
367 Make tests that use UIHelper more robust under certain configurations
368 https://bugs.webkit.org/show_bug.cgi?id=198442
369 <rdar://problem/51301737>
371 Reviewed by Megan Gardner.
373 For a certain device class, many tests that attempt to use UIHelper.isIOS are currently failing. We can fix this
374 by making the `isIOS` check more robust; this patch also renames `isIOS` to `isIOSFamily`, which is more
375 accurate (and consistent with the corresponding PLATFORM macro name).
377 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
378 * WebKitTestRunner/InjectedBundle/TestRunner.h:
379 (WTR::TestRunner::isIOSFamily const):
381 2019-05-31 Wenson Hsieh <wenson_hsieh@apple.com>
383 [iOS] Autocorrection menu font is Times New Roman when using font-family: UICTFontTextStyle*
384 https://bugs.webkit.org/show_bug.cgi?id=198427
385 <rdar://problem/50031825>
387 Reviewed by Tim Horton.
389 Add a new API test to verify that -fontForCaretSelection returns the system font when using UICTFontTextStyle
390 in an editable web view.
392 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
393 * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm: Added.
394 (-[TestWKWebView autocorrectionRectsForString:]):
395 (checkCGRectIsEqualToCGRectWithLogging):
396 * TestWebKitAPI/cocoa/TestWKWebView.h:
397 * TestWebKitAPI/ios/UIKitSPI.h:
399 2019-05-31 Tim Horton <timothy_horton@apple.com>
401 REGRESSION: WebKit.InteractionDeadlockAfterCrash and SynchronousTimeoutTests.UnresponsivePageDoesNotCausePositionInformationToHangUI API tests are failing
402 https://bugs.webkit.org/show_bug.cgi?id=198432
403 <rdar://problem/51266033>
405 Reviewed by Wenson Hsieh.
407 * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
409 (recursiveFindHighlightLongPressRecognizer): Deleted.
410 * TestWebKitAPI/Tests/ios/SynchronousTimeoutTests.mm:
411 (TestWebKitAPI::TEST):
412 (TestWebKitAPI::recursiveFindHighlightLongPressRecognizer): Deleted.
414 2019-05-31 Alex Christensen <achristensen@webkit.org>
416 URLParser::parseIPv6Host should properly parse 0's around compression
417 https://bugs.webkit.org/show_bug.cgi?id=198424
419 Reviewed by Tim Horton.
421 * TestWebKitAPI/Tests/WTF/URLParser.cpp:
422 (TestWebKitAPI::TEST_F):
424 2019-05-31 Alex Christensen <achristensen@webkit.org>
426 URLParser::parseHostAndPort should not allow non-port characters after an ipv6 host
427 https://bugs.webkit.org/show_bug.cgi?id=198428
428 <rdar://problem/51209196>
430 Reviewed by Tim Horton.
432 * TestWebKitAPI/Tests/WTF/URLParser.cpp:
433 (TestWebKitAPI::TEST_F):
435 2019-05-28 Dewei Zhu <dewei_zhu@apple.com>
437 run-benchmark should report an error if the argument to --build-directory is bogus
438 https://bugs.webkit.org/show_bug.cgi?id=198316
440 Reviewed by Ryosuke Niwa.
442 'run-benchmark' should not fallback to system safari when browser or browser build path is
443 specified but not valid.
444 Add a run-time check to ensure at least one of the resource from build directory is opened by
445 Safari when build directory is specified.
447 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
448 (OSXSafariDriver.launch_url): Raise an exception when browser or browser build path is
449 specified but not valid.
451 2019-05-31 Tim Horton <timothy_horton@apple.com>
453 Optionally respect device management restrictions when loading from the network
454 https://bugs.webkit.org/show_bug.cgi?id=198318
455 <rdar://problem/44263806>
457 Reviewed by Alex Christensen.
459 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
460 * TestWebKitAPI/Tests/WebKitCocoa/DeviceManagementRestrictions.mm: Added.
462 * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
463 (TestWebKitAPI::TEST):
464 * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
466 Clone a test that tests non-persistent data stores and ensure
467 that it works if the data store is created via a configuration as well.
469 Add a test that ensures that you can't create a data store configuration
470 with an invalid set of options.
472 Add a test that device management restrictions (when mocked) correctly
473 fail the load with a new, appropriate error.
475 2019-05-31 Ryan Haddad <ryanhaddad@apple.com>
477 Unreviewed, rolling out r245943.
479 Caused API test WKWebView.LocalStorageProcessSuspends to fail
484 "WKWebsiteDataStore API fails to fetch web storage data for
485 non-persistent data store"
486 https://bugs.webkit.org/show_bug.cgi?id=198317
487 https://trac.webkit.org/changeset/245943
489 2019-05-31 Alexey Proskuryakov <ap@apple.com>
491 WebKitTestRunner sometimes freezes under -[NSWindow release]
492 https://bugs.webkit.org/show_bug.cgi?id=198422
494 Reviewed by Tim Horton.
496 The window remains key until it's out of the allWindows vector, and AppKit is not
497 happy about deallocating key windows. Fixed by updating allWindows in -close
500 Added isMainFrame assertions in code that manipulates allWindows for a good measure.
502 * WebKitTestRunner/mac/WebKitTestRunnerWindow.mm:
503 (+[WebKitTestRunnerWindow _WTR_keyWindow]):
504 (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
505 (-[WebKitTestRunnerWindow close]):
506 (-[WebKitTestRunnerWindow dealloc]):
508 2019-05-31 Geoffrey Garen <ggaren@apple.com>
511 https://bugs.webkit.org/show_bug.cgi?id=198390
513 Reviewed by Chris Dumez.
515 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Updated for rename.
517 2019-05-31 Don Olmstead <don.olmstead@sony.com>
519 [CMake] Add WebKit::WTF target
520 https://bugs.webkit.org/show_bug.cgi?id=198400
522 Reviewed by Konstantin Tokarev.
524 Use the WebKit::WTF target.
526 * DumpRenderTree/CMakeLists.txt:
527 * DumpRenderTree/PlatformWin.cmake:
528 * MiniBrowser/win/CMakeLists.txt:
529 * TestWebKitAPI/CMakeLists.txt:
530 * TestWebKitAPI/PlatformGTK.cmake:
531 * TestWebKitAPI/PlatformWPE.cmake:
532 * TestWebKitAPI/PlatformWin.cmake:
533 * WebKitTestRunner/PlatformGTK.cmake:
534 * WebKitTestRunner/PlatformWin.cmake:
536 2019-05-31 Alex Christensen <achristensen@webkit.org>
538 REGRESSION (Safari 12): SafariForWebkitDevelopment won't load any pages on Mojave, nightly builds broken
539 https://bugs.webkit.org/show_bug.cgi?id=194808
540 <rdar://problem/48278497>
542 Reviewed by Darin Adler.
544 I verified that a daily build downloaded an run on Mojave does not work without this and works with this.
546 * WebKitArchiveSupport/run-webkit-archive:
547 (set_dyld_framework_path):
548 Also set XPC variants of needed environment variables.
550 2019-05-31 Carlos Garcia Campos <cgarcia@igalia.com>
552 [WPE] Build at-spi2-core without x11 support in jhbuild
553 https://bugs.webkit.org/show_bug.cgi?id=198411
555 Reviewed by Philippe Normand.
557 * wpe/jhbuild.modules:
559 2019-05-30 Sihui Liu <sihui_liu@apple.com>
561 WKWebsiteDataStore API fails to fetch web storage data for non-persistent data store
562 https://bugs.webkit.org/show_bug.cgi?id=198317
564 Reviewed by Alex Christensen.
566 * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
567 (TestWebKitAPI::TEST):
569 2019-05-30 Andres Gonzalez <andresg_22@apple.com>
571 Inserting a newline in contenteditable causes two characters to be added instead of one
572 https://bugs.webkit.org/show_bug.cgi?id=197894
573 <rdar://problem/49700998>
575 Reviewed by Wenson Hsieh and Chris Fleizach.
577 iOS implementation of several AccessibilityUIElement methods to execute
580 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
581 (WTR::AccessibilityUIElement::selectedTextRange):
582 (WTR::AccessibilityUIElement::setSelectedTextRange):
583 (WTR::AccessibilityUIElement::replaceTextInRange):
585 2019-05-30 Keith Miller <keith_miller@apple.com>
587 IsoHeaps don't notice uncommitted VA becoming the first eligible.
588 https://bugs.webkit.org/show_bug.cgi?id=198301
590 Reviewed by Yusuke Suzuki.
592 Move testbmalloc.cpp to TestWTF so it runs in automation.
594 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
595 * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp: Renamed from Source/bmalloc/test/testbmalloc.cpp.
598 2019-05-30 Wenson Hsieh <wenson_hsieh@apple.com>
600 DragAndDropTests.DataTransferExposePlainTextWithFileURLAsFile API test is failing
601 https://bugs.webkit.org/show_bug.cgi?id=198389
602 <rdar://problem/51266096>
604 Reviewed by Tim Horton.
606 This test started failing, since the fallback name for a dropped text file changed from "text.txt" to
607 "Document.txt" on newer iOS SDK versions. We simply fix this test by checking that the name of the file ends
608 with ".txt", and that the MIME type of the file is "text/plain".
610 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
611 (TestWebKitAPI::TEST):
613 2019-05-30 Sihui Liu <sihui_liu@apple.com>
615 Stop StorageManager when network process is ready to suspend
616 https://bugs.webkit.org/show_bug.cgi?id=198201
617 <rdar://problem/49683172>
619 Reviewed by Youenn Fablet.
621 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
622 * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
624 * TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-suspends-1.html: Added.
625 * TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-suspends-2.html: Added.
627 2019-05-30 David Quesada <david_quesada@apple.com>
629 REGRESSION (r245756) [Mac] 2 TestWebKitAPI.DownloadProgress* and TestWebKitAPI._WKDownload.DownloadMonitorCancel are flaky timeouts
630 https://bugs.webkit.org/show_bug.cgi?id=198298
631 rdar://problem/51182393
633 Reviewed by Alexey Proskuryakov.
635 Re-enable _WKDownload.DownloadMonitorCancel, which should no longer time out with this fix.
637 * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
638 (TestWebKitAPI::TEST):
640 2019-05-30 Truitt Savell <tsavell@apple.com>
642 Unreviewed, rolling out r245881.
644 Broke 13 Layout tests on WK2
648 "WKWebsiteDataStore API fails to fetch web storage data for
649 non-persistent data store"
650 https://bugs.webkit.org/show_bug.cgi?id=198317
651 https://trac.webkit.org/changeset/245881
653 2019-05-30 Aakash Jain <aakash_jain@apple.com>
655 [ews-build] Update configuration to share bots across queues
656 https://bugs.webkit.org/show_bug.cgi?id=198370
658 Reviewed by Jonathan Bedard.
660 * BuildSlaveSupport/ews-build/config.json: Share bots across builder and API tester queues.
661 Also use ews119 instead of ews120 for mac API tests, as ews120 seems to have some issues as
662 noted in https://bugs.webkit.org/show_bug.cgi?id=197571#c1
664 2019-05-30 Jonathan Bedard <jbedard@apple.com>
666 webkitpy: Switch run-webkit-tests to tailspin (Follow-up fix)
667 https://bugs.webkit.org/show_bug.cgi?id=198144
668 <rdar://problem/32463212>
670 Unreviewed infrastructure fix.
672 * Scripts/webkitpy/port/darwin.py:
673 (DarwinPort.look_for_new_samples): Use tailspin_file_path instead of spindump_file_path.
675 2019-05-29 Wenson Hsieh <wenson_hsieh@apple.com>
677 Remove some logic to suppress the text selection assistant during drop
678 https://bugs.webkit.org/show_bug.cgi?id=198354
680 Reviewed by Tim Horton.
682 Adjust some API tests that currently check whether or not the selection assistant was suppressed during drop.
684 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
685 (TestWebKitAPI::TEST):
686 * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
687 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
688 (-[DragAndDropSimulator _resetSimulatedState]):
689 (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
691 2019-05-29 Sihui Liu <sihui_liu@apple.com>
693 WKWebsiteDataStore API fails to fetch web storage data for non-persistent data store
694 https://bugs.webkit.org/show_bug.cgi?id=198317
696 Reviewed by Alex Christensen.
698 * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
699 (TestWebKitAPI::TEST):
701 2019-05-29 Alex Christensen <achristensen@webkit.org>
703 Build fix for branch.
704 <rdar://problem/50625279>
706 * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
708 2019-05-29 Justin Michaud <justin_michaud@apple.com>
710 Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
711 https://bugs.webkit.org/show_bug.cgi?id=198322
713 Rubber-stamped by Michael Saboff. Disable running the new collectContinuously tests on debug builds.
714 This matches what we do for other jsc tests.
716 * Scripts/run-jsc-stress-tests:
718 2019-05-29 Don Olmstead <don.olmstead@sony.com>
720 Remove ENABLE definitions from WebKit config files
721 https://bugs.webkit.org/show_bug.cgi?id=197858
723 Reviewed by Simon Fraser.
725 Sync FeatureDefines.xcconfig.
727 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
729 2019-05-29 Said Abou-Hallawa <sabouhallawa@apple.com>
731 [iOS] WebPage::positionInformation() may set InteractionInformationAtPosition.isImage to true but leave image unset
732 https://bugs.webkit.org/show_bug.cgi?id=198202
734 Reviewed by Tim Horton.
736 The new test ensures InteractionInformationAtPosition::isImage will not
737 be to true for a broken image.
739 * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
740 (TestWebKitAPI::TEST):
742 2019-05-29 David Kilzer <ddkilzer@apple.com>
744 check-webkit-style reports false-positive build/include_order warning in WTF C++ source files
745 <https://webkit.org/b/198349>
747 Reviewed by Alex Christensen.
749 * Scripts/webkitpy/style/checkers/cpp.py:
750 (_classify_include): Don't return early for <wtf/Header.h>
752 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
753 (OrderOfIncludesTest.test_primary_header): Add tests for
754 <wtf/Header.h> includes.
756 2019-05-29 Geoffrey Garen <ggaren@apple.com>
758 WeakPtr breaks vtables when upcasting to base classes
759 https://bugs.webkit.org/show_bug.cgi?id=188799
761 Reviewed by Youenn Fablet.
763 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Adopt the new macro API instead
764 of template specialization for observing weak references.
766 (TestWebKitAPI::Int::Int):
767 (TestWebKitAPI::Int::operator int const):
768 (TestWebKitAPI::Int::operator== const): Use a class for integer tests
769 because WeakPtr doesn't naturally support pointing to non-class objects
772 (TestWebKitAPI::Base::foo):
773 (TestWebKitAPI::Derived::foo): Inherit from CanMakeWeakPtr to enable
774 deduction of the weak pointer type.
776 (TestWebKitAPI::TEST): Updated to use Int.
778 (TestWebKitAPI::Base::weakPtrFactory const): Deleted.
779 (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference): Deleted.
780 (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference): Deleted.
782 2019-05-29 Ryan Haddad <ryanhaddad@apple.com>
784 Unreviewed, rolling out r245857.
786 Breaks internal builds.
790 "WeakPtr breaks vtables when upcasting to base classes"
791 https://bugs.webkit.org/show_bug.cgi?id=188799
792 https://trac.webkit.org/changeset/245857
794 2019-05-28 Geoffrey Garen <ggaren@apple.com>
796 WeakPtr breaks vtables when upcasting to base classes
797 https://bugs.webkit.org/show_bug.cgi?id=188799
799 Reviewed by Youenn Fablet.
801 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Adopt the new macro API instead
802 of template specialization for observing weak references.
804 (TestWebKitAPI::Int::Int):
805 (TestWebKitAPI::Int::operator int const):
806 (TestWebKitAPI::Int::operator== const): Use a class for integer tests
807 because WeakPtr doesn't naturally support pointing to non-class objects
810 (TestWebKitAPI::Base::foo):
811 (TestWebKitAPI::Derived::foo): Inherit from CanMakeWeakPtr to enable
812 deduction of the weak pointer type.
814 (TestWebKitAPI::TEST): Updated to use Int.
816 (TestWebKitAPI::Base::weakPtrFactory const): Deleted.
817 (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference): Deleted.
818 (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference): Deleted.
820 2019-05-29 Aakash Jain <aakash_jain@apple.com>
822 Disable Flaky API Test TestWebKitAPI._WKDownload.DownloadMonitorCancel
823 https://bugs.webkit.org/show_bug.cgi?id=198328
825 Reviewed by Alexey Proskuryakov.
827 * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
829 2019-05-28 Justin Michaud <justin_michaud@apple.com>
831 Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
832 https://bugs.webkit.org/show_bug.cgi?id=198322
834 Reviewed by Saam Barati.
836 Increases the collection period from 1 to slightly higher to try to speed up the tests. Any higher and
837 the test runner does not detect the bug that required the memset in Wasm::Instance::Instance().
839 * Scripts/run-jsc-stress-tests:
841 2019-05-28 Wenson Hsieh <wenson_hsieh@apple.com>
843 [iOS] Respect NSItemProvider's registered types when dropping files that are loaded in-place
844 https://bugs.webkit.org/show_bug.cgi?id=198315
845 <rdar://problem/51183762>
847 Reviewed by Tim Horton.
849 Adds a new API test to verify that when dropping a file that is loaded in-place with a file extension that is
850 not a .png (but was registered to the item provider as "public.png"), the resulting attachment is contained in
851 an image element, and the resulting attachment info indicates that the dropped attachment is a png file.
853 Additionally, rebaseline some existing tests.
855 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
856 (runTestWithTemporaryImageFile):
857 (TestWebKitAPI::TEST):
859 2019-05-28 Yusuke Suzuki <ysuzuki@apple.com>
861 GCHeapInspector should accept weird filename
862 https://bugs.webkit.org/show_bug.cgi?id=198314
864 Reviewed by Simon Fraser.
866 GCHeapInspector filenameForPath should have a fallback path if regexp does not match against the given path.
868 * GCHeapInspector/script/interface.js:
871 2019-05-28 Eric Carlson <eric.carlson@apple.com>
873 [MacOS] Filter GVA warning logged to stdout
874 https://bugs.webkit.org/show_bug.cgi?id=198303
875 <rdar://problem/50098041>
877 Reviewed by Jer Noble.
879 * Scripts/webkitpy/port/mac.py:
880 (MacPort.logging_patterns_to_strip): Filter GVA warnings.
882 2019-05-28 Nikita Vasilyev <nvasilyev@apple.com>
884 Web Inspector: Provide UIString descriptions to improve localizations
885 https://bugs.webkit.org/show_bug.cgi?id=195132
886 <rdar://problem/48457817>
888 Reviewed by Devin Rousso.
890 Allow WI.UIString to take:
891 - WI.UIString(string, key, comment)
892 - WI.UIString(string, comment)
893 - WI.UIString(string)
895 * Scripts/extract-localizable-js-strings:
897 2019-05-25 Dewei Zhu <dewei_zhu@apple.com>
899 Limit run-benchmark http server to specific interface.
900 https://bugs.webkit.org/show_bug.cgi?id=198247
902 Reviewed by Ryosuke Niwa.
904 Add '--interface' option to 'twisted_http_server.py'.
905 'SimpleHTTPServerDriver' should specify interface for http server.
906 Update regex that determines http server port from 'lsof' output to support ipv6 address.
908 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
909 Added '--interface' argument.
910 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
911 Limited http server to a specific interfce.
912 Added '-P' option to 'lsof' invocation to inhibits the conversion of port numbers to port name so script won't
913 fail if it's listening on a 'well-known' port.
914 Abstracted '_check_http_server_is_running' to allow potential child class to have its own implementation.
915 (SimpleHTTPServerDriver.serve): Updated regex that determines http server port from 'lsof' output to support ipv6 address.
916 (SimpleHTTPServerDriver.kill_server): Added null check for 'self._server_process'.
918 2019-05-28 David Xiong <w_xiong@apple.com>
920 webkitpy: Switch run-webkit-tests to tailspin
921 https://bugs.webkit.org/show_bug.cgi?id=198144
922 <rdar://problem/32463212>
924 Reviewed by Jonathan Bedard.
926 Changes run-webkit-tests to run tailspin on test time out
927 rather than spindump, and edited tests to look for tailspin logs
930 * Scripts/webkitpy/port/darwin.py:
931 (DarwinPort.sample_process): Replaced spindump with tailspin (+ symbolication)
933 (DarwinPort.tailspin_file_path):
934 (DarwinTest.spindump_file_path): Deleted.
935 * Scripts/webkitpy/port/darwin_testcase.py:
936 (DarwinTest.test_tailspin): Changed spindump test (below) to test for tailspin instead
937 (DarwinTest.test_spindump): Deleted.
938 (DarwinTest.test_spindump.logging_run_command): Deleted.
939 * Scripts/webkitpy/port/ios_device_unittest.py:
940 (IOSDeviceTest.test_tailspin): Changed spindump tests (inc. below) to test for tailspin instead
941 (IOSDeviceTest.test_sample_process.logging_run_command):
942 (IOSDeviceTest.test_sample_process_exception.throwing_run_command):
943 (IOSDeviceTest.test_spindump): Deleted.
944 (IOSDeviceTest.test_spindump.logging_run_command): Deleted.
946 2019-05-28 David Xiong <w_xiong@apple.com>
948 webkitpy: Using sudo on iOS device during timeout spindumps
949 https://bugs.webkit.org/show_bug.cgi?id=198142
951 Reviewed by Jonathan Bedard.
953 * Scripts/webkitpy/port/darwin.py:
954 (DarwinPort.sample_process): Check target host instead of source host for sudo command.
956 2019-05-28 Aakash Jain <aakash_jain@apple.com>
958 [ews-build] Remove unused buildbot tabs
959 https://bugs.webkit.org/show_bug.cgi?id=198108
961 Reviewed by Jonathan Bedard.
963 * BuildSlaveSupport/ews-build/templates/build.jade: Removed unused 'Changes' and 'Responsible Users' tabs.
965 2019-05-27 Carlos Garcia Campos <cgarcia@igalia.com>
967 [GTK] Use WPEBackend-fdo for accelerating compositing in Wayland instead of the nested compositor
968 https://bugs.webkit.org/show_bug.cgi?id=197944
970 Reviewed by Michael Catanzaro.
972 Add WPEBackend-fdo to jhbuild moduleset.
974 * gtk/jhbuild.modules:
976 2019-05-27 Wenson Hsieh <wenson_hsieh@apple.com>
978 [iOS] Dropping in an editable element should result in a ranged selection
979 https://bugs.webkit.org/show_bug.cgi?id=198267
980 <rdar://problem/51145977>
982 Reviewed by Tim Horton.
984 Adjust some existing API tests that currently check for selection rects after a drop. Instead of checking for
985 visible selection rects, simply check for the start caret rect, as determined by WKContentView's
988 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
989 (TestWebKitAPI::TEST):
990 (makeCGRectValue): Deleted.
991 (checkSelectionRectsWithLogging): Deleted.
992 * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
994 Replace finalSelectionRects with finalSelectionStartRect.
996 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
997 (-[DragAndDropSimulator _resetSimulatedState]):
998 (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
999 (-[DragAndDropSimulator finalSelectionRects]): Deleted.
1001 2019-05-27 Oriol Brufau <obrufau@igalia.com>
1003 [css-grid] Preserve repeat() notation when serializing declared values
1004 https://bugs.webkit.org/show_bug.cgi?id=197840
1006 Reviewed by Manuel Rego Casasnovas.
1008 Adapt CSSPropertyParserTest to CSSGridIntegerRepeatValue.
1010 * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
1011 (TestWebKitAPI::computeNumberOfTracks):
1013 2019-05-26 Wenson Hsieh <wenson_hsieh@apple.com>
1015 [iOS] Dropped text, attachments, and images should animate into place
1016 https://bugs.webkit.org/show_bug.cgi?id=198243
1017 <rdar://problem/35205373>
1019 Reviewed by Tim Horton.
1021 Adjusts the iOS dragging simulator, and adds a new API test. See below for more detail.
1023 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1024 (TestWebKitAPI::isCompletelyWhite):
1025 (TestWebKitAPI::TEST):
1027 Add a test that drags and drops an image into a contenteditable element, and then observes the resulting
1028 UITargetedDragPreviews upon drop.
1030 * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1031 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1032 (-[DragAndDropSimulator _resetSimulatedState]):
1033 (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1034 (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
1036 Teach the iOS version of DragAndDropSimulator to invoke -dropInteraction:concludeDrop: on the drop interaction
1037 delegate when the drop finishes. This additionally uses _doAfterReceivingEditDragSnapshotForTesting: to defer
1038 the end of the simulated drag and drop until after drag previews have been received during an edit drag.
1040 (-[DragAndDropSimulator dropPreviews]):
1041 (-[DragAndDropSimulator delayedDropPreviews]):
1043 Have the drag and drop simulator remember which previews were returned by the delegate on drop, as well as which
1044 previews were provided asynchronously.
1046 (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
1047 * TestWebKitAPI/ios/UIKitSPI.h:
1049 Stage the new private drop interacton delegate method.
1051 2019-05-25 Simon Fraser <simon.fraser@apple.com>
1053 MobileMiniBrowser: Add iPad support, and allow insecure loads
1054 https://bugs.webkit.org/show_bug.cgi?id=198249
1056 Reviewed by Tim Horton.
1058 Add iPad support to MobileMiniBrowser, and allow insecure loads.
1060 * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1061 * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
1063 2019-05-25 Wenson Hsieh <wenson_hsieh@apple.com>
1065 [iOS] Respect -[NSItemProvider preferredPresentationSize] when dropping images
1066 https://bugs.webkit.org/show_bug.cgi?id=198242
1068 Reviewed by Beth Dakin.
1070 Add a new test that simulates dropping an image with a preferred presentation size into an editable element
1071 with attachment elements enabled.
1073 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1074 (TestWebKitAPI::TEST):
1076 2019-05-24 Yusuke Suzuki <ysuzuki@apple.com>
1078 Make display-profiler-output work with newer HighLine
1079 https://bugs.webkit.org/show_bug.cgi?id=198205
1081 Reviewed by Saam Barati.
1083 Newer HighLine does not have SystemExtensions. Access @terminal member in default instance of HighLine.
1085 * Scripts/display-profiler-output:
1087 2019-05-23 Fujii Hironori <Hironori.Fujii@sony.com>
1089 run-webkit-tests: Remove feature detection support
1090 https://bugs.webkit.org/show_bug.cgi?id=198105
1092 Reviewed by Jonathan Bedard.
1094 Feature detection support was added to DRT for Windows and old
1095 run-webkit-tests in Bug 35610. It was added for NRWT in Bug 41842.
1096 But, it doesn't work for DRT for Windows because of feature name
1097 mismatches. Since USE(ACCELERATED_COMPOSITING) flag has been
1098 removed in Bug 127833, it is not needed anymore.
1100 * DumpRenderTree/win/DumpRenderTree.cpp:
1102 * Scripts/webkitpy/port/base.py:
1103 (Port._tests_for_other_platforms):
1104 (Port._skipped_tests_for_unsupported_features):
1105 (Port._runtime_feature_list): Deleted.
1106 (Port.nm_command): Deleted.
1107 (Port._modules_to_search_for_symbols): Deleted.
1108 (Port._symbols_string): Deleted.
1109 (Port._missing_feature_to_skipped_tests): Deleted.
1110 (Port._has_test_in_directories): Deleted.
1111 * Scripts/webkitpy/port/darwin.py:
1112 (DarwinPort.make_command):
1113 (DarwinPort.nm_command): Deleted.
1114 * Scripts/webkitpy/port/ios_simulator.py:
1115 (IOSSimulatorPort.reset_preferences):
1116 (IOSSimulatorPort.nm_command): Deleted.
1117 * Scripts/webkitpy/port/port_testcase.py:
1118 (TestWebKitPort.__init__):
1119 (TestWebKitPort.all_test_configurations):
1120 (PortTestCase.test_path_to_test_expectations_file):
1121 (TestWebKitPort._symbols_string): Deleted.
1122 (PortTestCase.test_skipped_directories_for_features): Deleted.
1123 (PortTestCase.test_skipped_directories_for_features_no_matching_tests_in_test_list): Deleted.
1124 (PortTestCase.test_skipped_tests_for_unsupported_features_empty_test_list): Deleted.
1125 * Scripts/webkitpy/port/watch_simulator.py:
1126 (WatchSimulatorPort.reset_preferences):
1127 (WatchSimulatorPort.nm_command): Deleted.
1128 * Scripts/webkitpy/port/win.py:
1129 (WinPort.show_results_html_file):
1130 (WinPort._runtime_feature_list): Deleted.
1131 * Scripts/webkitpy/port/win_unittest.py:
1132 (WinPortTest.test_operating_system):
1133 (WinPortTest.test_runtime_feature_list): Deleted.
1134 * WebKitTestRunner/Options.cpp:
1135 (WTR::OptionsHandler::OptionsHandler):
1136 (WTR::handleOptionPrintSupportedFeatures): Deleted.
1137 * WebKitTestRunner/Options.h:
1138 * WebKitTestRunner/TestController.cpp:
1139 (WTR::TestController::initialize):
1141 2019-05-23 Commit Queue <commit-queue@webkit.org>
1143 Unreviewed, rolling out r245665.
1144 https://bugs.webkit.org/show_bug.cgi?id=198203
1146 Inspector appears blank, again. (Requested by NVI on #webkit).
1150 "Web Inspector: Provide UIString descriptions to improve
1152 https://bugs.webkit.org/show_bug.cgi?id=195132
1153 https://trac.webkit.org/changeset/245665
1155 2019-05-23 Stephan Szabo <stephan.szabo@sony.com>
1157 [Win][CMake] Pass architecture to cmake via -A for both x64 and Win32
1158 https://bugs.webkit.org/show_bug.cgi?id=198098
1160 Reviewed by Don Olmstead.
1162 With current CMake and Visual Studio 2019, the default
1163 architecture will match the host, so we should make sure
1164 to explicitly mention the architecture we want for 32-bit
1165 builds as well for cases where we are on x64 and not in an
1166 x64_x32 cross-build vcvars environment.
1168 * Scripts/webkitdirs.pm:
1169 (getVisualStudioToolset): Get toolset name for cmake/msbuild
1170 (getMSBuildPlatformArgument): Update to use getVisualStudioToolset
1171 (getCMakeWindowsToolsetArgument): Get -A argument for cmake
1173 (generateBuildSystemFromCMakeProject): Remove explicit -A x64
1174 in 64-bit mode in favor of new getCMakeWindowsToolsetArgument.
1176 2019-05-23 Youenn Fablet <youenn@apple.com>
1178 Set default WebsiteDataStore storage quota based on StorageQuotaManager
1179 https://bugs.webkit.org/show_bug.cgi?id=198133
1180 <rdar://problem/51031436>
1182 Reviewed by Geoffrey Garen.
1184 * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
1187 2019-05-23 Keith Rollin <krollin@apple.com>
1189 generate-xcfilelists should not store temporary build files in /tmp
1190 https://bugs.webkit.org/show_bug.cgi?id=198136
1192 Reviewed by Jonathan Bedard.
1194 Provide the build infrastructure control of the location of
1195 generate-xcfilelists' temporary files by creating them in the build
1196 directory when possible.
1198 * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
1199 (get_xcode_project_temp_dir):
1200 * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1201 (BaseGenerator._generate_derived):
1202 (BaseGenerator._generate_unified):
1204 (BaseGenerator._get_temp_dir):
1206 2019-05-23 Philippe Normand <philn@igalia.com>
1208 [JHBuild][GStreamer] Enable libsrtp
1209 https://bugs.webkit.org/show_bug.cgi?id=198041
1211 Reviewed by Xabier Rodriguez-Calvar.
1213 * gstreamer/jhbuild.modules: Enable libsrtp. The system version
1214 can't be used from Stretch because it's too old.
1216 2019-05-22 Ryan Haddad <ryanhaddad@apple.com>
1218 Move win-ews queue bubble to Win10 section of dashboard
1219 https://bugs.webkit.org/show_bug.cgi?id=198159
1221 Reviewed by Alexey Proskuryakov.
1223 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1224 (BubbleQueueServer): Change platform to Windows10 to match the OS version of the bots.
1226 2019-05-22 Myles C. Maxfield <mmaxfield@apple.com>
1228 [Mac] Add API test to make sure the system font is drawn just like in native code
1229 https://bugs.webkit.org/show_bug.cgi?id=198010
1231 Reviewed by Daniel Bates.
1233 We can compare the width of using font-family:system-ui to a CTLine.
1235 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1236 * TestWebKitAPI/Tests/WebKitCocoa/TextWidth.html: Added.
1237 * TestWebKitAPI/Tests/WebKitCocoa/TextWidth.mm: Added.
1240 2019-05-22 Nikita Vasilyev <nvasilyev@apple.com>
1242 Web Inspector: Provide UIString descriptions to improve localizations
1243 https://bugs.webkit.org/show_bug.cgi?id=195132
1244 <rdar://problem/48457817>
1246 Reviewed by Devin Rousso.
1248 Allow WI.UIString to take:
1249 - WI.UIString(string, key, comment)
1250 - WI.UIString(string, comment)
1251 - WI.UIString(string)
1253 * Scripts/extract-localizable-js-strings:
1255 2019-05-22 Wenson Hsieh <wenson_hsieh@apple.com>
1257 [iOS] The shouldIgnoreMetaViewport test option incorrectly persists across layout tests
1258 https://bugs.webkit.org/show_bug.cgi?id=198135
1259 <rdar://problem/51001306>
1261 Reviewed by Alexey Proskuryakov.
1263 When shouldIgnoreMetaViewport=true is specified on a test, if the following test does not use a flexible
1264 viewport, we will continue ignoring the meta viewport, since we'll bail before we attempt to reset
1265 WKPreferences' _shouldIgnoreMetaViewport property to NO.
1267 We fix this by simply allowing shouldIgnoreMetaViewport to take precedence over useFlexibleViewport, such that
1268 -[WKPreferences _shouldIgnoreMetaViewport] will always be updated to its intended value between tests.
1270 * WebKitTestRunner/ios/TestControllerIOS.mm:
1271 (WTR::TestController::platformConfigureViewForTest):
1273 2019-05-22 Sihui Liu <sihui_liu@apple.com>
1275 API Test landed in r245540 [Mac WK2] TestWebKitAPI.WKWebView.LocalStorageProcessCrashes is a flaky failure
1276 https://bugs.webkit.org/show_bug.cgi?id=198090
1277 <rdar://problem/51003644>
1279 Reviewed by Youenn Fablet.
1281 WebView was wrongly loaded multiple times.
1283 * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
1286 2019-05-22 Jiewen Tan <jiewen_tan@apple.com>
1288 [WebAuthN] Support Attestation Conveyance Preference
1289 https://bugs.webkit.org/show_bug.cgi?id=192722
1290 <rdar://problem/49939647>
1292 Reviewed by Brent Fulgham.
1294 * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1295 (TestWebKitAPI::TEST):
1296 Updates the test with AttestationConveyancePreference.
1298 2019-05-22 Zalan Bujtas <zalan@apple.com>
1300 [Paste] Add support for preferred presentation size when pasting an image
1301 https://bugs.webkit.org/show_bug.cgi?id=198132
1302 <rdar://problem/50886917>
1304 Reviewed by Wenson Hsieh.
1306 * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1307 (TestWebKitAPI::TEST):
1309 2019-05-22 Keith Rollin <krollin@apple.com>
1311 Use a different variable when testing for Xcode context in generate-xcfilelists
1312 https://bugs.webkit.org/show_bug.cgi?id=198130
1313 <rdar://problem/51032752>
1315 Reviewed by Jonathan Bedard.
1317 The generate-xcfilelists script can run stand-alone or in the context
1318 of Xcode. There are a couple of places where it helps to know which
1319 context is current. To determine the context, genreate-xfilelists
1320 checks an environment variable that should be defined only when Xcode
1321 is running. The variable chosen was XCODE_INSTALL_PATH. It turns out
1322 that this variable is not always defined. Therefore, switch to
1323 checking XCODE_PRODUCT_BUILD_VERSION.
1325 * Scripts/webkitpy/generate_xcfilelists_lib/util.py:
1327 (is_running_under_xcode):
1329 2019-05-22 Carlos Garcia Campos <cgarcia@igalia.com>
1331 Unreviewed. Fix WPE unit tests after r245565
1333 Backend creation is failing when the a11y bus is not running because atk produces warning messages. We should
1334 not make warnings fatal during backend creation.
1336 * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1337 (testAutomationSessionRequestSession):
1338 * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1339 (testWebViewGeolocationPermissionRequests):
1340 * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1341 (Test::createWebViewBackend):
1342 (Test::addLogFatalFlag):
1343 (Test::removeLogFatalFlag):
1345 2019-05-21 Aakash Jain <aakash_jain@apple.com>
1347 [ews-build] Use custom templates for Buildbot (follow-up fix)
1348 https://bugs.webkit.org/show_bug.cgi?id=198076
1350 Unreviewed minor follow-up fix.
1352 * BuildSlaveSupport/ews-build/templates/build.jade:
1354 2019-05-21 Alex Christensen <achristensen@webkit.org>
1357 <rdar://problem/50625279>
1359 * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1360 We need to explicitly include WebKit.h on the branch.
1362 2019-05-21 Aakash Jain <aakash_jain@apple.com>
1364 [ews-build] Use custom templates for Buildbot
1365 https://bugs.webkit.org/show_bug.cgi?id=198076
1367 Rubber-stamped by Jonathan Bedard.
1369 * BuildSlaveSupport/ews-build/master.cfg:
1370 * BuildSlaveSupport/ews-build/templates: Added.
1371 * BuildSlaveSupport/ews-build/templates/build.jade: Copied from https://github.com/buildbot/buildbot/blob/v1.7.0/www/base/src/app/builders/builds/build.tpl.jade
1373 2019-05-21 Chris Dumez <cdumez@apple.com>
1375 [PSON] Assertion hit when navigating back after a process swap forced by the client
1376 https://bugs.webkit.org/show_bug.cgi?id=198006
1378 Reviewed by Alex Christensen.
1380 Add API test coverage.
1382 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1384 2019-05-21 Carlos Garcia Campos <cgarcia@igalia.com>
1386 Unreviewed. Fix the build with HAVE(ACCESSIBILITY) disabled
1388 * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1389 (WTR::AccessibilityController::elementAtPoint):
1390 * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1391 (WTR::AccessibilityController::rootElement):
1392 (WTR::AccessibilityController::focusedElement):
1394 2019-05-21 Carlos Garcia Campos <cgarcia@igalia.com>
1396 [WPE] Add initial accessibility support using ATK
1397 https://bugs.webkit.org/show_bug.cgi?id=197413
1399 Reviewed by Michael Catanzaro.
1401 Add accessibility support in MiniBrowser and backends used by MiniBrowser and tests.
1403 * MiniBrowser/wpe/CMakeLists.txt:
1404 * MiniBrowser/wpe/main.cpp:
1406 * TestWebKitAPI/PlatformWPE.cmake:
1407 * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1408 * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1409 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1410 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1411 (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
1412 (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
1413 * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Removed.
1414 * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Removed.
1415 * WebKitTestRunner/PlatformWPE.cmake:
1416 * wpe/backends/CMakeLists.txt:
1417 * wpe/backends/HeadlessViewBackend.cpp:
1418 (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
1419 * wpe/backends/ViewBackend.cpp:
1420 (WPEToolingBackends::addKeyEventListener):
1421 (WPEToolingBackends::removeKeyEventListener):
1422 (WPEToolingBackends::notifyAccessibilityKeyEventListeners):
1423 (WPEToolingBackends::ViewBackend::initialize):
1424 (WPEToolingBackends::ViewBackend::initializeAccessibility):
1425 (WPEToolingBackends::ViewBackend::updateAccessibilityState):
1426 (WPEToolingBackends::ViewBackend::setAccessibleChild):
1427 (WPEToolingBackends::ViewBackend::addActivityState):
1428 (WPEToolingBackends::ViewBackend::removeActivityState):
1429 (WPEToolingBackends::ViewBackend::dispatchInputKeyboardEvent):
1430 * wpe/backends/ViewBackend.h:
1431 * wpe/backends/WebKitAccessibleApplication.cpp: Added.
1432 (webkitAccessibleApplicationWindowInterfaceInit):
1433 (webkitAccessibleApplicationFinalize):
1434 (webkitAccessibleApplicationInitialize):
1435 (webkitAccessibleApplicationGetNChildren):
1436 (webkitAccessibleApplicationRefChild):
1437 (webkitAccessibleApplicationGetName):
1438 (webkit_accessible_application_class_init):
1439 (webkit_accessible_application_init):
1440 (webkitAccessibleApplicationNew):
1441 (webkitAccessibleApplicationSetChild):
1442 * wpe/backends/WebKitAccessibleApplication.h: Added.
1443 * wpe/backends/WindowViewBackend.cpp:
1444 (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
1445 * wpe/jhbuild.modules:
1447 2019-05-20 Fujii Hironori <Hironori.Fujii@sony.com>
1449 run-webkit-tests not gathering crash logs on Cygwin Python and Windows Python
1450 https://bugs.webkit.org/show_bug.cgi?id=179828
1452 Reviewed by Jonathan Bedard.
1454 ServerProcess should store its Windows PID for Cygwin before
1455 process crashing because the Windows PID is required to get a
1458 CrashLog format has been changed. CrashLogs.GLOBAL_PID_REGEX
1459 should accept the new format.
1461 * Scripts/webkitpy/common/system/crashlogs.py:
1462 (CrashLogs.GLOBAL_PID_REGEX): Accept any words between 'Global' and 'PID:'.
1464 * Scripts/webkitpy/port/driver.py:
1465 (Driver.has_crashed):
1466 (Driver._check_for_driver_crash_or_unresponsiveness):
1467 (Driver._read_block):
1468 Store server_process.system_pid() to self._crashed_pid instead of server_process.pid().
1470 * Scripts/webkitpy/port/server_process.py:
1471 (ServerProcess.__init__):
1472 (ServerProcess.system_pid): Added.
1473 (ServerProcess._find_system_pid): Added.
1474 (ServerProcess._start): Set self._system_pid.
1475 * Scripts/webkitpy/port/win.py:
1476 (WinPort._get_crash_log): Removed broken old code converting Cygwin pid to Windows pid.
1478 2019-05-20 Aakash Jain <aakash_jain@apple.com>
1480 Windows 10 test results missing on flakiness dashboard
1481 https://bugs.webkit.org/show_bug.cgi?id=198058
1483 Rubber-stamped by Alexey Proskuryakov.
1485 * TestResultServer/static-dashboards/flakiness_dashboard.js:
1487 2019-05-20 Sihui Liu <sihui_liu@apple.com>
1489 Move Web Storage to Network Process
1490 https://bugs.webkit.org/show_bug.cgi?id=197636
1492 Reviewed by Youenn Fablet.
1494 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1495 * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Remove the wait for database file update.
1497 * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Add a test for network process crash recovery.
1499 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Fix a typo and add a test case to cover it.
1500 * TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html: Added.
1502 2019-05-20 Keith Rollin <krollin@apple.com>
1504 generate-xcfilelists is stranding temporary files
1505 https://bugs.webkit.org/show_bug.cgi?id=198008
1506 <rdar://problem/50893659>
1508 Reviewed by Jonathan Bedard.
1510 generate-xcfilelists makes use of temporary files on disk. These files
1511 are opened with the OS's "temporary" bit set, causing them to get
1512 deleted when closed or the process exists. However, these temporary
1513 files actually end up persisting after the script exists. This is
1514 because `sed` is used to process the files, and is done so in a way
1515 that causes the "temporary" bit to get cleared.
1517 Address this issue by no longer using `sed` and instead performing the
1518 equivalent processing the file content in-memory.
1520 * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1521 (BaseGenerator._generate_derived):
1522 (BaseGenerator._generate_unified):
1523 (BaseGenerator._replace):
1524 (BaseGenerator._unexpand):
1525 (BaseGenerator._find_added_lines.get_lines):
1526 (BaseGenerator._find_added_lines):
1528 2019-05-20 Ludovico de Nittis <ludovico.denittis@collabora.com>
1530 [WPE][Qt] Use C++17 instead of C++14
1531 https://bugs.webkit.org/show_bug.cgi?id=197415
1533 Reviewed by Philippe Normand.
1535 There was a regression introduced with the commit https://bugs.webkit.org/show_bug.cgi?id=197131
1536 The WPE Qt port was not updated to C++17 and this leaded to a compilation error.
1538 * TestWebKitAPI/glib/CMakeLists.txt:
1540 2019-05-20 Ludovico de Nittis <ludovico.denittis@collabora.com>
1542 [Flatpak][Qt] Meson: Unknown type feature for gstreamer
1543 https://bugs.webkit.org/show_bug.cgi?id=197408
1545 Reviewed by Philippe Normand.
1547 This is a regression that has been introduced when
1548 GStreamer was updated to version 1.16.0
1549 https://bugs.webkit.org/show_bug.cgi?id=197157
1551 Now GStreamer requires meson >= 0.47.0
1552 Updating the Kde runtime to version 5.12 we fulfill
1555 * flatpak/org.webkit.WPEQT.yaml:
1557 2019-05-20 Carlos Garcia Campos <cgarcia@igalia.com>
1559 [GLIB] Crash when instantiating a js object registered with jsc_context_register_class on window object cleared
1560 https://bugs.webkit.org/show_bug.cgi?id=198037
1562 Reviewed by Michael Catanzaro.
1564 Add a test case to check the crash is fixed.
1566 * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1567 (testWebExtensionWindowObjectCleared):
1568 * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1569 (windowObjectCleared):
1571 2019-05-20 Carlos Garcia Campos <cgarcia@igalia.com>
1573 [GLIB] Repeating timer is not stopped when stop is called from the callback
1574 https://bugs.webkit.org/show_bug.cgi?id=197986
1576 Reviewed by Michael Catanzaro.
1578 Check the timer is no longer active after it has been stopped.
1580 * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1581 (TestWebKitAPI::TEST):
1583 2019-05-19 Darin Adler <darin@apple.com>
1585 Change String::number to use "shortest" instead of "fixed precision 6 digits"
1586 https://bugs.webkit.org/show_bug.cgi?id=178319
1588 Reviewed by Sam Weinig.
1590 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1591 (TestWebKitAPI::testStringNumberFixedPrecision): Use String::numberToStringFixedPrecision.
1593 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1594 (attributesOfElement): Use appendFixedPrecisionNumber.
1596 2019-05-18 Jiewen Tan <jiewen_tan@apple.com>
1598 [WebAuthN] Allow authenticators that support both CTAP and U2F to try U2F if CTAP fails in authenticatorGetAssertion
1599 https://bugs.webkit.org/show_bug.cgi?id=197974
1600 <rdar://problem/50879746>
1602 Reviewed by Brent Fulgham.
1604 Add a canDowngrade option for mock hid devices to simulate the situation.
1606 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1607 (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1609 2019-05-18 Tadeu Zagallo <tzagallo@apple.com>
1611 Add extra information to dumpJITMemory
1612 https://bugs.webkit.org/show_bug.cgi?id=197998
1614 Reviewed by Saam Barati.
1616 Add description for the new dumpJITMemory trace point code.
1618 * Tracing/SystemTracePoints.plist:
1620 2019-05-17 Justin Michaud <justin_michaud@apple.com>
1622 [WASM-References] Add support for Anyref in parameters and return types, Ref.null and Ref.is_null for Anyref values.
1623 https://bugs.webkit.org/show_bug.cgi?id=197969
1625 Run wasm tests additionally with wasmBBQUsesAir=0.
1627 Reviewed by Keith Miller.
1629 * Scripts/run-jsc-stress-tests:
1631 2019-05-17 Don Olmstead <don.olmstead@sony.com>
1633 [CMake] Use builtin FindICU
1634 https://bugs.webkit.org/show_bug.cgi?id=197934
1636 Reviewed by Michael Catanzaro.
1638 Remove uses of ICU_INCLUDE_DIRS and ICU_LIBRARIES.
1640 * TestWebKitAPI/PlatformMac.cmake:
1641 * TestWebKitAPI/PlatformPlayStation.cmake:
1642 * TestWebKitAPI/PlatformWin.cmake:
1643 * WebKitTestRunner/CMakeLists.txt:
1645 2019-05-17 Alex Christensen <achristensen@webkit.org>
1647 Enable legacy EME for iOS WKWebView
1648 https://bugs.webkit.org/show_bug.cgi?id=197964
1649 <rdar://problem/50625666>
1651 Reviewed by Wenson Hsieh.
1653 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1656 2019-05-17 Aakash Jain <aakash_jain@apple.com>
1658 [ews-build] Add clickable url in UI for uploaded S3 archive
1659 https://bugs.webkit.org/show_bug.cgi?id=197996
1661 Reviewed by Jonathan Bedard.
1663 * BuildSlaveSupport/ews-build/steps.py:
1665 2019-05-17 Aakash Jain <aakash_jain@apple.com>
1667 [ews-app] Status bubble should not turn orange when any build step has warnings
1668 https://bugs.webkit.org/show_bug.cgi?id=198000
1670 Reviewed by Jonathan Bedard.
1672 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1673 (StatusBubble._does_build_contains_any_failed_step):
1675 2019-05-17 Alex Christensen <achristensen@webkit.org>
1677 Add SPI to set a list of hosts to which to send custom header fields cross-origin
1678 https://bugs.webkit.org/show_bug.cgi?id=197397
1680 Reviewed by Geoff Garen.
1682 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1684 (expectLegacyHeaders):
1686 (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1687 (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
1688 (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1690 2019-05-17 Keith Rollin <krollin@apple.com>
1692 Unreviewed build fix.
1694 Teach generate-xcfilelists about iphonesimulator.
1696 * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1697 (JavaScriptCoreGenerator):
1701 2019-05-17 Keith Rollin <krollin@apple.com>
1703 Re-enable generate-xcfilelists
1704 https://bugs.webkit.org/show_bug.cgi?id=197933
1705 <rdar://problem/50831677>
1707 Reviewed by Jonathan Bedard.
1709 The following two tasks have been completed, and we can re-enable
1710 generate-xcfilelists:
1712 Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619)
1713 Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622)
1715 * DumpRenderTree/Scripts/check-xcfilelists.sh:
1716 * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1718 2019-05-17 Commit Queue <commit-queue@webkit.org>
1720 Unreviewed, rolling out r245401.
1721 https://bugs.webkit.org/show_bug.cgi?id=197990
1723 Causing internal build failures (Requested by ShawnRoberts on
1728 "Add SPI to set a list of hosts to which to send custom header
1729 fields cross-origin"
1730 https://bugs.webkit.org/show_bug.cgi?id=197397
1731 https://trac.webkit.org/changeset/245401
1733 2019-05-17 Commit Queue <commit-queue@webkit.org>
1735 Unreviewed, rolling out r245418.
1736 https://bugs.webkit.org/show_bug.cgi?id=197989
1738 New API test causing crashes on Mojave testers (Requested by
1739 ShawnRoberts on #webkit).
1743 "Add a unit test for client certificate authentication"
1744 https://bugs.webkit.org/show_bug.cgi?id=197800
1745 https://trac.webkit.org/changeset/245418
1747 2019-05-17 Aakash Jain <aakash_jain@apple.com>
1749 [ews-build] Add build step to Transfer archive to S3
1750 https://bugs.webkit.org/show_bug.cgi?id=197922
1752 Reviewed by Jonathan Bedard.
1754 * BuildSlaveSupport/ews-build/steps.py:
1756 (TransferToS3.finished): Invoke triggers after transfer is successful.
1757 (TransferToS3.getResultSummary): Create more readable failure string.
1758 (UploadBuiltProduct.finished): Deleted. Moved the trigger invocation after TransferToS3.
1759 * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1761 2019-05-16 Carlos Garcia Campos <cgarcia@igalia.com>
1763 [GTK] Need WebKitContextMenuItemType to open emoji picker
1764 https://bugs.webkit.org/show_bug.cgi?id=176760
1766 Reviewed by Michael Catanzaro.
1768 Update context menu test to check insert emoji action is included in default context menu for editable content.
1770 * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1772 2019-05-16 Aakash Jain <aakash_jain@apple.com>
1774 [ews-build] Download archives from S3
1775 https://bugs.webkit.org/show_bug.cgi?id=197949
1777 Reviewed by Jonathan Bedard.
1779 * BuildSlaveSupport/ews-build/steps.py:
1780 (DownloadBuiltProduct): Updated to use S3 URL.
1781 (DownloadBuiltProduct.getResultSummary): Method to display custom failure string.
1782 * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1784 2019-05-16 David Kilzer <ddkilzer@apple.com>
1786 REGRESSION (r15133): Fix leak of JSStringRef in minidom
1787 <https://webkit.org/b/197968>
1788 <rdar://problem/50872430>
1790 Reviewed by Joseph Pecoraro.
1792 * TestWebKitAPI/Tests/WebKitObjC/UserContentTest.mm:
1793 (expectScriptValueIsString): Drive-by fix to use adopt() instead
1794 of JSRetainPtr<JSStringRef> string(Adopt, JSValueToStringCopy(...)).
1796 2019-05-16 David Kilzer <ddkilzer@apple.com>
1798 REGRESSION (r84160): Leak of OpaqueJSString under WTR::JSTestRunner::pathToLocalResource (32 bytes) in com.apple.WebKit.WebContent running layout tests
1799 <https://webkit.org/b/197965>
1801 Reviewed by Joseph Pecoraro.
1803 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1804 (WTR::TestRunner::pathToLocalResource): Don't call
1805 JSStringRetain() here because the JSRetainPtr<JSStringRef>
1806 return type will increment the retain count for us.
1808 2019-05-16 Alex Christensen <achristensen@webkit.org>
1810 Add a unit test for client certificate authentication
1811 https://bugs.webkit.org/show_bug.cgi?id=197800
1813 Reviewed by Youenn Fablet.
1815 Make better abstractions for reading and writing from/to TCPServer.
1816 Add a unit test that causes a client certificate authentication challenge to happen.
1818 * TestWebKitAPI/TCPServer.cpp:
1819 (TestWebKitAPI::TCPServer::TCPServer):
1820 (TestWebKitAPI::TCPServer::read):
1821 (TestWebKitAPI::TCPServer::write):
1822 (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
1823 (TestWebKitAPI::TCPServer::respondWithOK):
1824 * TestWebKitAPI/TCPServer.h:
1825 * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1826 (credentialWithIdentity):
1827 (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1829 (-[ClientCertificateDelegate webView:didFinishNavigation:]):
1830 (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1831 (-[ClientCertificateDelegate challengeCount]):
1832 (TestWebKitAPI::TEST):
1833 (respondWithChallengeThenOK): Deleted.
1834 (credentialWithIdentityAndKeychainPath): Deleted.
1835 * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1837 * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1838 (TestWebKitAPI::TEST):
1839 * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1841 (readRequest): Deleted.
1842 (writeResponse): Deleted.
1843 * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1844 (TestWebKitAPI::TEST):
1845 (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
1847 2019-05-16 Alex Christensen <achristensen@webkit.org>
1849 Add SPI to set a list of hosts to which to send custom header fields cross-origin
1850 https://bugs.webkit.org/show_bug.cgi?id=197397
1852 Reviewed by Geoff Garen.
1854 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1856 (expectLegacyHeaders):
1858 (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1859 (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
1860 (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1862 2019-05-15 Aakash Jain <aakash_jain@apple.com>
1864 Replace double-quotes with single quotes in steps.py
1865 https://bugs.webkit.org/show_bug.cgi?id=197921
1867 Reviewed by Jonathan Bedard.
1869 * BuildSlaveSupport/ews-build/steps.py:
1871 2019-05-15 Keith Rollin <krollin@apple.com>
1873 Rewrite generate-xcfilelists in Python
1874 https://bugs.webkit.org/show_bug.cgi?id=197622
1875 <rdar://problem/50508222>
1877 Reviewed by Jonathan Bedard, Alex Christensen.
1879 For a number of reasons, rewrite generate-xcfilelists in Python:
1881 - The previous bash script was large and unmaintainable.
1882 - We have more internal expertise with Python than with bash.
1883 - The bash script used temporary files in /tmp that got stranded and
1884 were owned by root, making them awkward to clear out.
1885 <rdar://problem/49490262>
1886 - We needed to complete support for engineers that built with Xcode
1887 rather than the command line.
1888 - There are some bugs leading to mildly corrupted .xcfilelist files.
1889 It's not apparent the source of the bugs, but one general reason
1890 might be due to approaches born of using bash. Rewriting in Python
1893 * Scripts/generate-xcfilelists:
1894 * Scripts/webkitpy/common/attribute_saver.py: Added.
1896 (AttributeSaver.__init__):
1897 (AttributeSaver.__enter__):
1898 (AttributeSaver.__exit__):
1899 * Scripts/webkitpy/common/attribute_saver_unittest.py: Added.
1900 (AttributeSaverTest):
1901 (AttributeSaverTest.SimpleTestClass):
1902 (AttributeSaverTest.SimpleTestClass.__init__):
1903 (AttributeSaverTest.test_class):
1904 (AttributeSaverTest.test_normal_default):
1905 (AttributeSaverTest.test_normal_value):
1906 (AttributeSaverTest.test_normal_value_on_exception):
1907 (AttributeSaverTest.test_normal_value_on_normal_exit):
1908 (AttributeSaverTest.test_normal_value_with_finally_on_exception):
1909 (AttributeSaverTest.test_normal_value_with_finally_on_normal_exit):
1910 (AttributeSaverTest.test_normal_value_with_else_on_exception):
1911 (AttributeSaverTest.test_normal_value_with_else_on_normal_exit):
1912 * Scripts/webkitpy/generate_xcfilelists_lib/__init__.py: Added.
1913 * Scripts/webkitpy/generate_xcfilelists_lib/application.py: Added.
1915 (Application.__init__):
1917 (Application._initialize):
1918 (Application._initialize.collect_attributes):
1919 (Application._create_parser):
1928 (_report_merge_results):
1929 (_report_remediation_steps):
1930 (_report_remediation_steps.add_to_message):
1932 (_any_have_actions):
1935 (get_generate_xcfilelists_script_path):
1937 (get_opensource_dir):
1938 (get_build_scripts_dir):
1939 (get_extract_dependencies_from_makefile_script):
1940 (get_xcode_built_products_dir):
1942 * Scripts/webkitpy/generate_xcfilelists_lib/generators.py: Added.
1944 (BaseGenerator.__init__):
1945 (BaseGenerator.__str__):
1946 (BaseGenerator.generate):
1947 (BaseGenerator._sublaunch_under_xcode):
1948 (BaseGenerator.subgenerate):
1949 (BaseGenerator.merge):
1950 (BaseGenerator.pickle_to_file):
1951 (BaseGenerator.has_action):
1952 (BaseGenerator.has_error):
1953 (BaseGenerator.is_valid):
1954 (BaseGenerator.report_error):
1955 (BaseGenerator._generate_derived):
1956 (BaseGenerator._merge_derived):
1957 (BaseGenerator._generate_unified):
1958 (BaseGenerator._merge_unified):
1959 (BaseGenerator._replace):
1960 (BaseGenerator._unexpand):
1961 (BaseGenerator._find_added_lines):
1962 (BaseGenerator._merge_added_lines):
1963 (BaseGenerator._get_file_lines):
1964 (BaseGenerator._getenv):
1965 (BaseGenerator._get_project_file_path):
1966 (BaseGenerator._get_project_dir):
1967 (BaseGenerator._get_project_file_name):
1968 (BaseGenerator._get_project_name):
1969 (BaseGenerator._get_sym_root):
1970 (BaseGenerator._get_obj_root):
1971 (BaseGenerator._get_shared_precomps_dir):
1972 (BaseGenerator._get_build_dirs):
1973 (BaseGenerator._get_build_dirs.define_xcode_build_dirs):
1974 (BaseGenerator._get_build_dirs.define_xcode_build_dirs.read_xcode_user_default):
1975 (BaseGenerator._get_build_dirs.define_command_line_build_dirs):
1976 (BaseGenerator._get_derived_sources_dir):
1977 (BaseGenerator._get_xcfilelist_dir):
1978 (BaseGenerator._get_input_derived_xcfilelist_project_path):
1979 (BaseGenerator._get_output_derived_xcfilelist_project_path):
1980 (BaseGenerator._get_input_unified_xcfilelist_project_path):
1981 (BaseGenerator._get_output_unified_xcfilelist_project_path):
1982 (BaseGenerator._get_generate_derived_sources_script):
1983 (BaseGenerator._get_generate_unified_sources_script):
1984 (JavaScriptCoreGenerator):
1985 (JavaScriptCoreGenerator._get_project_file_path):
1986 (JavaScriptCoreGenerator._get_generate_derived_sources_script):
1987 (JavaScriptCoreGenerator._get_generate_unified_sources_script):
1989 (WebCoreGenerator._get_project_file_path):
1990 (WebCoreGenerator._get_generate_derived_sources_script):
1991 (WebCoreGenerator._get_generate_unified_sources_script):
1993 (WebKitGenerator._get_project_file_path):
1994 (WebKitGenerator._get_derived_sources_dir):
1995 (WebKitGenerator._get_generate_derived_sources_script):
1996 (WebKitGenerator._get_generate_unified_sources_script):
1997 (DumpRenderTreeGenerator):
1998 (DumpRenderTreeGenerator._get_project_file_path):
1999 (DumpRenderTreeGenerator._get_generate_derived_sources_script):
2000 (WebKitTestRunnerGenerator):
2001 (WebKitTestRunnerGenerator._get_project_file_path):
2002 (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
2003 * Scripts/webkitpy/generate_xcfilelists_lib/util.py: Added.
2006 (LogEntryHelper.__init__):
2007 (LogEntryHelper.log_entry):
2008 (LogEntryHelper.log_result):
2009 (LogEntryHelper.log_exception):
2010 (LogEntryHelper._print):
2012 (LogEntryExit._show_debug_logging):
2013 (LogEntryExitClass):
2014 (LogEntryExitClass._show_debug_logging):
2015 (LogEntryExitGlobal):
2016 (LogEntryExitGlobal._show_debug_logging):
2018 (is_running_under_xcode):
2019 (CheckValidItemAction):
2020 (CheckValidItemAction.__init__):
2021 (CheckValidItemAction.__call__):
2022 (CheckValidItemAction.validate_item):
2023 (CheckCommandAction):
2024 (CheckCommandAction.__call__):
2025 (InvalidCommandError):
2026 (InvalidArgumentError):
2027 (InvalidConfigurationError):
2028 (CalledProcessError):
2029 (CalledProcessError.__str__):
2030 * Scripts/webkitpy/xcode/__init__.py:
2031 (xcode_hash_for_path):
2032 (xcode_hash_for_path.convert_to_string):
2033 * Scripts/webkitpy/xcode/sdk.py: Added.
2037 (SDK.as_xcode_specification):
2038 (SDK.get_preferred_sdk_for_platform):
2040 * Scripts/webkitpy/xcode/sdk_unittest.py: Added.
2043 2019-05-15 Aakash Jain <aakash_jain@apple.com>
2045 [ews-build] Enabling uploading EWS archives to S3
2046 https://bugs.webkit.org/show_bug.cgi?id=197914
2048 Reviewed by Jonathan Bedard.
2050 * BuildSlaveSupport/Shared: Added.
2051 * BuildSlaveSupport/Shared/transfer-archive-to-s3: Moved from Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3.
2052 (archiveExists): Replace tab with space.
2053 (main): Added main method.
2054 * BuildSlaveSupport/build.webkit.org-config/steps.py:
2055 (TransferToS3): Updated path to the script.
2056 * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Moved to Shared folder.
2058 2019-05-15 Wenson Hsieh <wenson_hsieh@apple.com>
2060 inputmode="numeric" should show a number pad with digits 0-9, instead of the numeric keyplane
2061 https://bugs.webkit.org/show_bug.cgi?id=197916
2062 <rdar://problem/50815427>
2064 Reviewed by Timothy Hatcher.
2066 Re-enable this previously flaky test, and rebaseline the result to to expect UIKeyboardTypeNumberPad for
2067 inputmode="numeric".
2069 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2070 (TestWebKitAPI::TEST):
2072 2019-05-15 Youenn Fablet <youenn@apple.com>
2074 Reuse existing WebPageProxy quota handler for NetworkProcessProxy quota requests
2075 https://bugs.webkit.org/show_bug.cgi?id=197463
2076 <rdar://problem/47403621>
2078 Reviewed by Alex Christensen.
2080 * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm: Added.
2081 (-[QuotaDelegate init]):
2082 (-[QuotaDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
2083 (-[QuotaDelegate quotaDelegateCalled]):
2084 (-[QuotaDelegate grantQuota]):
2085 (-[StorageSchemes webView:startURLSchemeTask:]):
2086 (-[StorageSchemes webView:stopURLSchemeTask:]):
2087 (-[QuotaMessageHandler userContentController:didReceiveScriptMessage:]):
2090 2019-05-15 Youenn Fablet <youenn@apple.com>
2092 Constant crashes under WebPage::isThrottleable() after r245299
2093 https://bugs.webkit.org/show_bug.cgi?id=197902
2094 <rdar://problem/50793796>
2096 Reviewed by Alex Christensen.
2098 * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2100 2019-05-15 Philippe Normand <pnormand@igalia.com>
2102 [GTK][jhbuild] misc cleanups and bumps
2103 https://bugs.webkit.org/show_bug.cgi?id=197913
2105 Reviewed by Xabier Rodriguez-Calvar.
2107 * gstreamer/jhbuild.modules: Bump to libva 2.4.1 and switch to Meson.
2108 * gtk/jhbuild.modules: Bump to Brotli 1.0.5 and Wayland 1.16.
2110 2019-05-15 Chris Dumez <cdumez@apple.com>
2112 Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
2113 https://bugs.webkit.org/show_bug.cgi?id=195102
2114 <rdar://problem/48456786>
2116 Reviewed by Alex Christensen.
2118 Try to wait longer for the number of processes to reach the expected number
2121 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2123 2019-05-15 Alex Christensen <achristensen@webkit.org>
2125 Allow NSFileCoordinator to be called from WebContent process
2126 https://bugs.webkit.org/show_bug.cgi?id=197895
2127 <rdar://problem/50107679>
2129 Reviewed by Brent Fulgham.
2131 Add a unit test that verifies calling the block succeeds.
2133 * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
2134 (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2136 2019-05-14 Andy Estes <aestes@apple.com>
2138 [Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
2139 https://bugs.webkit.org/show_bug.cgi?id=197751
2140 <rdar://problem/50631563>
2142 Reviewed by Alex Christensen.
2144 Added new API tests.
2146 * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
2147 (-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]):
2148 (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2149 (TestWebKitAPI::TEST):
2150 (-[TestApplePayScriptMessageHandler initWithExpectation:]): Deleted.
2151 * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
2153 2019-05-14 Youenn Fablet <youenn@apple.com>
2155 A service worker process should app nap when all its clients app nap
2156 https://bugs.webkit.org/show_bug.cgi?id=185626
2157 <rdar://problem/46785908>
2159 Reviewed by Alex Christensen.
2161 Allow to enable app nap through test header.
2163 * WebKitTestRunner/TestController.cpp:
2164 (WTR::TestController::resetPreferencesToConsistentValues):
2165 (WTR::updateTestOptionsFromTestHeader):
2166 * WebKitTestRunner/TestOptions.h:
2167 (WTR::TestOptions::hasSameInitializationOptions const):
2169 2019-05-14 Commit Queue <commit-queue@webkit.org>
2171 Unreviewed, rolling out r245281.
2172 https://bugs.webkit.org/show_bug.cgi?id=197887
2174 Broke API Test TestWebKitAPI.Challenge.ClientCertificate
2175 (Requested by aakashjain on #webkit).
2179 "Add a unit test for client certificate authentication"
2180 https://bugs.webkit.org/show_bug.cgi?id=197800
2181 https://trac.webkit.org/changeset/245281
2183 2019-05-14 Youenn Fablet <youenn@apple.com>
2185 Add support for webkit-test-runner options to WPT importer
2186 https://bugs.webkit.org/show_bug.cgi?id=197826
2188 Reviewed by Alex Christensen.
2190 In case of overwriting an existing test, check if the existing test
2191 contains a <!-- webkit-test-runner --> comment and insert it back if
2192 needed in the new test.
2194 For exporter, forbid creating a WPT PR if there are changes containing
2195 the webkit-test-runner string.
2197 * Scripts/webkitpy/w3c/test_converter.py:
2198 (convert_for_webkit):
2199 (_W3CTestConverter.__init__):
2200 (_W3CTestConverter.add_webkit_test_runner_options_if_needed):
2201 (_W3CTestConverter.handle_starttag):
2202 (_W3CTestConverter.handle_comment):
2203 (_W3CTestConverter.handle_decl):
2204 (_W3CTestConverter.handle_pi):
2205 * Scripts/webkitpy/w3c/test_exporter.py:
2206 (WebPlatformTestExporter.write_git_patch_file):
2207 (WebPlatformTestExporter.make_pull_request):
2208 * Scripts/webkitpy/w3c/test_importer.py:
2209 (TestImporter.webkit_test_runner_options):
2211 (TestImporter.add_webkit_test_runner_options_to_content):
2212 (TestImporter.copy_html_file):
2213 (TestImporter.write_html_template):
2214 (TestImporter.write_html_files_for_templated_js_tests):
2215 (TestImporter.import_tests):
2216 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2217 (test_manual_slow_test):
2218 (test_webkit_test_runner_options):
2220 2019-05-14 Aakash Jain <aakash_jain@apple.com>
2222 [ews-app] Status bubble should turn orange when any build step fails
2223 https://bugs.webkit.org/show_bug.cgi?id=197812
2225 Reviewed by Jonathan Bedard.
2227 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2228 (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
2229 (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
2231 2019-05-14 Alex Christensen <achristensen@webkit.org>
2233 Add a unit test for client certificate authentication
2234 https://bugs.webkit.org/show_bug.cgi?id=197800
2236 Reviewed by Youenn Fablet.
2238 Make better abstractions for reading and writing from/to TCPServer.
2239 Add a unit test that causes a client certificate authentication challenge to happen.
2241 * TestWebKitAPI/TCPServer.cpp:
2242 (TestWebKitAPI::TCPServer::TCPServer):
2243 (TestWebKitAPI::TCPServer::read):
2244 (TestWebKitAPI::TCPServer::write):
2245 (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
2246 (TestWebKitAPI::TCPServer::respondWithOK):
2247 * TestWebKitAPI/TCPServer.h:
2248 * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2249 (credentialWithIdentity):
2250 (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2252 (-[ClientCertificateDelegate webView:didFinishNavigation:]):
2253 (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2254 (-[ClientCertificateDelegate challengeCount]):
2255 (TestWebKitAPI::TEST):
2256 (respondWithChallengeThenOK): Deleted.
2257 (credentialWithIdentityAndKeychainPath): Deleted.
2258 * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
2260 * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
2261 (TestWebKitAPI::TEST):
2262 * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2264 (readRequest): Deleted.
2265 (writeResponse): Deleted.
2266 * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2267 (TestWebKitAPI::TEST):
2268 (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
2270 2019-05-14 Said Abou-Hallawa <sabouhallawa@apple.com>
2272 [CG] Adding support for HEIF-sequence ('public.heics') images
2273 https://bugs.webkit.org/show_bug.cgi?id=197384
2275 Reviewed by Simon Fraser.
2277 * DumpRenderTree/TestOptions.cpp:
2278 (TestOptions::TestOptions):
2279 * DumpRenderTree/TestOptions.h:
2280 * DumpRenderTree/mac/DumpRenderTree.mm:
2281 (resetWebViewToConsistentStateBeforeTesting):
2282 Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
2283 Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
2286 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2287 (WTR::InjectedBundle::stringForKey):
2288 (WTR::InjectedBundle::beginTesting):
2289 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2290 * WebKitTestRunner/TestController.cpp:
2291 (WTR::TestController::resetStateToConsistentValues):
2292 (WTR::updateTestOptionsFromTestHeader):
2293 * WebKitTestRunner/TestInvocation.cpp:
2294 (WTR::TestInvocation::createTestSettingsDictionary):
2295 * WebKitTestRunner/TestOptions.h:
2296 (WTR::TestOptions::hasSameInitializationOptions const):
2297 Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
2298 Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
2301 2019-05-12 Yusuke Suzuki <ysuzuki@apple.com>
2303 [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
2304 https://bugs.webkit.org/show_bug.cgi?id=197730
2306 Reviewed by Filip Pizlo.
2308 * TestWebKitAPI/CMakeLists.txt:
2309 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2310 * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2311 (TestWebKitAPI::TEST):
2312 * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
2313 (TestWebKitAPI::TEST):
2315 2019-05-10 Chris Dumez <cdumez@apple.com>
2317 Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
2319 It became flaky after r245198.
2321 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2323 2019-05-10 Youenn Fablet <youenn@apple.com>
2325 A service worker instance should be terminated when its SWServer is destroyed
2326 https://bugs.webkit.org/show_bug.cgi?id=197801
2327 <rdar://problem/50587270>
2329 Reviewed by Chris Dumez.
2331 * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2333 2019-05-10 Chris Dumez <cdumez@apple.com>
2335 Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
2336 https://bugs.webkit.org/show_bug.cgi?id=197750
2338 Reviewed by Geoffrey Garen.
2340 Add API test coverage.
2342 * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2345 2019-05-10 Keith Miller <keith_miller@apple.com>
2347 Remove legacy test262 import script
2348 https://bugs.webkit.org/show_bug.cgi?id=197788
2350 Reviewed by Yusuke Suzuki.
2352 import-test262-tests doesn't work anymore. We should be using test262-import instead.
2354 * Scripts/import-test262-tests: Removed.
2356 2019-05-10 Charlie Turner <cturner@igalia.com>
2358 [WPE] Forward libepoxy cflags
2359 https://bugs.webkit.org/show_bug.cgi?id=197784
2361 Reviewed by Žan Doberšek.
2363 Patch by Zan Dobersek.
2365 * wpe/backends/CMakeLists.txt: This is required to keep
2366 -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
2367 up trying to include X11 headers even when they're not present in the
2370 2019-05-10 Michael Catanzaro <mcatanzaro@igalia.com>
2372 Fix a bunch of compiler warnings
2373 https://bugs.webkit.org/show_bug.cgi?id=197785
2375 Reviewed by Don Olmstead.
2377 Add preprocessor guards to avoid -Wunused-function warnings.
2379 * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
2380 * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
2381 * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
2383 2019-05-10 Michael Catanzaro <mcatanzaro@igalia.com>
2385 [WPE][GTK] Add webkit_frame_get_id() API
2386 https://bugs.webkit.org/show_bug.cgi?id=197270
2388 Reviewed by Carlos Garcia Campos.
2390 This was hard, but I added a test to verify that two different WebKitFrames of the same
2391 WebKitWebPage return two different frame IDs.
2393 * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2394 (WebKitFrameTest::willSubmitFormCallback):
2395 (WebKitFrameTest::testSubframe):
2397 * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2398 (testWebKitFrameSubframe):
2400 * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2401 (willSubmitFormCallback):
2402 * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
2403 * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
2405 2019-05-10 Michael Catanzaro <mcatanzaro@igalia.com>
2407 [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
2408 https://bugs.webkit.org/show_bug.cgi?id=197271
2410 Reviewed by Youenn Fablet.
2412 * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2413 (formControlsAssociatedForFrameCallback):
2414 (pageCreatedCallback):
2415 (formControlsAssociatedCallback): Deleted.
2417 2019-05-10 Adrian Perez de Castro <aperez@igalia.com>
2419 [Flatpak] Use the safe PyYAML loader if available
2420 https://bugs.webkit.org/show_bug.cgi?id=197771
2422 Reviewed by Philippe Normand.
2424 * flatpak/flatpakutils.py:
2425 (load_manifest): Use yaml.safe_load() if available, with yaml.load()
2426 still used as fallback when the former is not provided by the module.
2428 2019-05-09 Fujii Hironori <Hironori.Fujii@sony.com>
2430 WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
2431 https://bugs.webkit.org/show_bug.cgi?id=197734
2433 Reviewed by Don Olmstead.
2435 * Scripts/webkitpy/port/win.py:
2436 (WinCairoPort._search_paths): Add 'wk2' and
2437 additional_platform_directory to paths as well as other ports do.
2439 2019-05-09 Daniel Bates <dabates@apple.com>
2441 [iOS] Numpad comma key has incorrect keyIdentifier property
2442 https://bugs.webkit.org/show_bug.cgi?id=197753
2443 <rdar://problem/50636274>
2445 Reviewed by Brent Fulgham.
2447 Recognize "numpadComma" and return the appropriate HID usage code.
2449 * WebKitTestRunner/ios/HIDEventGenerator.mm:
2450 (hidUsageCodeForCharacter):
2452 2019-05-09 Eric Carlson <eric.carlson@apple.com>
2454 Refine AudioSession route sharing policy
2455 https://bugs.webkit.org/show_bug.cgi?id=197742
2456 <rdar://problem/50590818>
2458 Reviewed by Darin Adler.
2460 * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2461 (TestWebKitAPI::TEST):
2463 2019-05-09 Alex Christensen <achristensen@webkit.org>
2465 Remove unnecessary test SPI after r244883
2466 https://bugs.webkit.org/show_bug.cgi?id=197575
2468 Reviewed by Tim Horton.
2470 * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2472 * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2473 (TestWebKitAPI::TEST):
2475 2019-05-09 Aakash Jain <aakash_jain@apple.com>
2477 [ews-app] Add migrations file to repository
2478 https://bugs.webkit.org/show_bug.cgi?id=197729
2480 Reviewed by Jonathan Bedard.
2482 * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
2484 2019-05-09 Aakash Jain <aakash_jain@apple.com>
2486 [ews-build] Fix formatting issues and typos
2487 https://bugs.webkit.org/show_bug.cgi?id=197737
2489 Reviewed by Jonathan Bedard.
2491 * BuildSlaveSupport/ews-build/steps.py:
2492 (CompileWebKit.evaluateCommand): Removed extra empty line.
2493 * BuildSlaveSupport/ews-build/steps_unittest.py:
2494 (TestRunWebKitPerlTests): Fixed typo.
2495 * BuildSlaveSupport/ews-app/ews/models/step.py:
2496 (Step.save_step): Changed log level to info so that it is logged in production.
2498 2019-05-09 Aakash Jain <aakash_jain@apple.com>
2500 [ews-app] Production and Development env should configure DEBUG appropriately
2501 https://bugs.webkit.org/show_bug.cgi?id=197700
2503 Reviewed by Jonathan Bedard.
2505 * BuildSlaveSupport/ews-app/ews-app/settings.py:
2507 2019-05-09 Xan López <xan@igalia.com>
2509 [CMake] Detect SSE2 at compile time
2510 https://bugs.webkit.org/show_bug.cgi?id=196488
2512 Reviewed by Carlos Garcia Campos.
2514 * Scripts/webkitdirs.pm:
2515 (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
2516 for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
2518 2019-05-08 Adrian Perez de Castro <aperez@igalia.com>
2520 [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
2521 https://bugs.webkit.org/show_bug.cgi?id=197697
2523 Reviewed by Žan Doberšek.
2525 * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
2526 * wpe/jhbuild.modules: Ditto.
2528 2019-05-08 Don Olmstead <don.olmstead@sony.com>
2531 https://bugs.webkit.org/show_bug.cgi?id=197676
2533 Reviewed by Alex Christensen.
2535 * TestWebKitAPI/PlatformWin.cmake:
2536 Remove unnecessary library linkage.
2538 2019-05-08 Stephan Szabo <stephan.szabo@sony.com> and Fujii Hironori <Hironori.Fujii@sony.com>
2540 [Win] build-webkit should be ready for Visual Studio 2019
2541 https://bugs.webkit.org/show_bug.cgi?id=196622
2543 Reviewed by Ross Kirsling.
2545 1. Accommodated to the new msbuild.exe location of VS 2019.
2546 2. Removed the hard coded "Visual Studio 15" generator.
2548 build-webkit is going to choose a Visual Studio generator version
2549 matching with the latest installed VS. If you invoke vcvars.bat
2550 before build-webkit, it chooses the corresponding Visual Studio
2551 generator version by cheking 'VisualStudioVersion' env var which
2552 is set by vcvars.bat.
2554 * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
2555 (msBuildPath): When looking for MSBuild, look in
2556 "MSBuild\Current\bin" (the new expected location) and fallback
2557 to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
2559 (msBuildInstallDir): Renamed to msBuildPath.
2560 (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
2561 Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
2563 2019-05-08 Don Olmstead <don.olmstead@sony.com>
2565 [PlayStation] Update port options
2566 https://bugs.webkit.org/show_bug.cgi?id=197723
2568 Reviewed by Ross Kirsling.
2570 ICU headers were missing from TestWTF.
2572 * TestWebKitAPI/PlatformPlayStation.cmake:
2574 2019-05-08 Alex Christensen <achristensen@webkit.org>
2576 Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
2577 https://bugs.webkit.org/show_bug.cgi?id=197712
2578 <rdar://problem/50429770>
2580 Reviewed by Tim Horton.
2582 * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
2583 (TestWebKitAPI::TEST):
2585 2019-05-08 Jonathan Bedard <jbedard@apple.com>
2587 Change my status to be a WebKit reviewer.
2589 * Scripts/webkitpy/common/config/contributors.json:
2591 2019-05-08 Ryan Haddad <ryanhaddad@apple.com>
2593 Unreviewed, rolling out r244952.
2595 Caused inspector to appear blank.
2599 "Web Inspector: Provide UIString descriptions to improve
2601 https://bugs.webkit.org/show_bug.cgi?id=195132
2602 https://trac.webkit.org/changeset/244952
2604 2019-05-08 Wenson Hsieh <wenson_hsieh@apple.com>
2606 TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
2607 https://bugs.webkit.org/show_bug.cgi?id=197685
2609 Reviewed by Alex Christensen.
2611 Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
2612 completion. See LayoutTests/ChangeLog for more details.
2614 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2615 (WTR::UIScriptController::platformClearAllCallbacks):
2617 2019-05-07 Oriol Brufau <obrufau@igalia.com>
2619 Unreviewed. Add myself as a committer.
2621 * Scripts/webkitpy/common/config/contributors.json:
2623 2019-05-07 Ryan Haddad <ryanhaddad@apple.com>
2625 Unreviewed, rolling out r245038.
2627 Breaks internal builds.
2631 "Add SPI to set a list of hosts to which to send custom header
2632 fields cross-origin"
2633 https://bugs.webkit.org/show_bug.cgi?id=197397
2634 https://trac.webkit.org/changeset/245038
2636 2019-05-07 Joonghun Park <pjh0718@gmail.com>
2638 Unreviewed. Add myself as a committer.
2640 * Scripts/webkitpy/common/config/contributors.json:
2642 2019-05-07 Eric Carlson <eric.carlson@apple.com>
2644 Define media buffering policy
2645 https://bugs.webkit.org/show_bug.cgi?id=196979
2646 <rdar://problem/28383861>
2648 Reviewed by Jer Noble.
2650 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2651 * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
2652 (waitUntilBufferingPolicyIsEqualTo):
2655 2019-05-07 Alex Christensen <achristensen@webkit.org>
2657 Add SPI to set a list of hosts to which to send custom header fields cross-origin
2658 https://bugs.webkit.org/show_bug.cgi?id=197397
2660 Reviewed by Geoff Garen.
2662 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2664 (expectLegacyHeaders):
2666 (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
2667 (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
2668 (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2670 2019-05-07 Keith Rollin <krollin@apple.com>
2672 Add option to build-webkit to control whether or not XCBuild is used
2673 https://bugs.webkit.org/show_bug.cgi?id=197668
2674 <rdar://problem/50549728>
2676 Reviewed by Tim Horton.
2678 Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
2679 Also update build-webkit and the makefiles with the foundation for
2680 automatically using XCBuild when the conditions allow it. This latter
2681 facility is currently turned off until Xcode fully supports building
2682 WebKit with XCBuild.
2684 * Scripts/build-webkit:
2685 * Scripts/webkitdirs.pm:
2689 2019-05-07 Andy Estes <aestes@apple.com>
2691 run-bindings-tests should test global scope constructor generation
2692 https://bugs.webkit.org/show_bug.cgi?id=197669
2694 Reviewed by Alex Christensen.
2696 * Scripts/webkitpy/bindings/main.py:
2697 Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
2698 invoking preprocess-idls.pl.
2700 2019-05-07 Youenn Fablet <youenn@apple.com>
2702 Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
2703 https://bugs.webkit.org/show_bug.cgi?id=195997
2704 <rdar://problem/50509884>
2706 Reviewed by Chris Dumez.
2708 Spin test until successful.
2710 * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2712 2019-05-07 Adrian Perez de Castro <aperez@igalia.com>
2714 [Flatpak] webkit-build fails due to missing GTK2 in build environment
2715 https://bugs.webkit.org/show_bug.cgi?id=197352
2717 Reviewed by Philippe Normand.
2719 The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
2720 to build it ourselves on top in order to be able to build the GTK 2.x plugin
2723 * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
2725 2019-05-07 Wenson Hsieh <wenson_hsieh@apple.com>
2727 [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
2728 https://bugs.webkit.org/show_bug.cgi?id=197644
2729 <rdar://problem/50526364>
2731 Reviewed by Tim Horton.
2733 Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
2735 * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
2736 * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
2737 (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2738 (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
2740 2019-05-07 Carlos Garcia Campos <cgarcia@igalia.com>
2742 [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
2743 https://bugs.webkit.org/show_bug.cgi?id=197651
2745 Reviewed by Žan Doberšek.
2747 This is required since the process creation was delayed until something is loaded in the view.
2749 * MiniBrowser/gtk/BrowserWindow.c:
2750 (browser_window_get_or_create_web_view_for_automation):
2751 * MiniBrowser/wpe/main.cpp:
2754 2019-05-06 Tim Horton <timothy_horton@apple.com>
2756 _overrideViewportWithArguments does not work when called before loading
2757 https://bugs.webkit.org/show_bug.cgi?id=197638
2758 <rdar://problem/50505111>
2760 Reviewed by Wenson Hsieh.
2762 * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2765 2019-05-04 Per Arne Vollan <pvollan@apple.com>
2767 -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
2768 https://bugs.webkit.org/show_bug.cgi?id=197510
2770 Reviewed by Alex Christensen.
2772 * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2773 (TestWebKitAPI::TEST):
2775 2019-05-06 Keith Rollin <krollin@apple.com>
2777 Temporarily disable generate-xcfilelists
2778 https://bugs.webkit.org/show_bug.cgi?id=197619
2779 <rdar://problem/50507392>
2781 Reviewed by Alex Christensen.
2783 We need to perform a significant update to the generate-xcfilelist
2784 scripts. This work involves coordinated work with another facility. If
2785 the work does not occur in tandem, the build will be broken. To avoid
2786 this, disable the invoking of the scripts during the transition. The
2787 checking will be restored once the new scripts are in place.
2789 * DumpRenderTree/Scripts/check-xcfilelists.sh:
2790 * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2792 2019-05-04 Alex Christensen <achristensen@webkit.org>
2794 Revert r244953 and r244954 because they broke internal builds.
2795 https://bugs.webkit.org/show_bug.cgi?id=197534
2797 * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
2798 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2799 * DumpRenderTree/mac/DumpRenderTree.mm:
2800 * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2801 * DumpRenderTree/mac/TestRunnerMac.mm:
2802 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2803 * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
2804 * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2805 * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2806 * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
2807 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2808 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
2809 * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2810 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2811 * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2812 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2813 * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2814 * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2815 * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2816 * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2817 * TestWebKitAPI/cocoa/TestWKWebView.mm:
2818 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2819 * TestWebKitAPI/ios/UIKitSPI.h: Added.
2820 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2821 * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
2822 * WebKitTestRunner/ios/HIDEventGenerator.h:
2823 * WebKitTestRunner/ios/HIDEventGenerator.mm:
2824 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2825 * WebKitTestRunner/ios/TestControllerIOS.mm:
2826 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2827 * WebKitTestRunner/ios/mainIOS.mm:
2829 2019-05-04 Alex Christensen <achristensen@webkit.org>
2831 Merge the three UIKitSPI.h files into a single one in PAL
2832 https://bugs.webkit.org/show_bug.cgi?id=197534
2834 Reviewed by Darin Adler.
2836 * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
2837 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2838 * DumpRenderTree/mac/DumpRenderTree.mm:
2839 * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2840 * DumpRenderTree/mac/TestRunnerMac.mm:
2841 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2842 * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
2843 * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2844 * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2845 * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
2846 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2847 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
2848 * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2849 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2850 * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2851 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2852 * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2853 * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2854 * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2855 * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2856 * TestWebKitAPI/cocoa/TestWKWebView.mm:
2857 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2858 * TestWebKitAPI/ios/UIKitSPI.h: Removed.
2859 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2860 * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
2861 * WebKitTestRunner/ios/HIDEventGenerator.h:
2862 * WebKitTestRunner/ios/HIDEventGenerator.mm:
2863 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2864 * WebKitTestRunner/ios/TestControllerIOS.mm:
2865 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2866 * WebKitTestRunner/ios/mainIOS.mm:
2868 2019-05-04 Nikita Vasilyev <nvasilyev@apple.com>
2870 Web Inspector: Provide UIString descriptions to improve localizations
2871 https://bugs.webkit.org/show_bug.cgi?id=195132
2872 <rdar://problem/48457817>
2874 Reviewed by Devin Rousso.
2876 Allow WI.UIString to take:
2877 - WI.UIString(string, key, comment)
2878 - WI.UIString(string, comment)
2879 - WI.UIString(string)
2881 * Scripts/extract-localizable-js-strings:
2883 2019-05-03 Wenson Hsieh <wenson_hsieh@apple.com>
2885 REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
2886 https://bugs.webkit.org/show_bug.cgi?id=197579
2888 Reviewed by Tim Horton.
2890 Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
2891 OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
2892 input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
2893 ensure that the the focused element has been blurred.
2895 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2897 2019-05-02 Alexey Proskuryakov <ap@apple.com>
2899 Add a tool to block spammer accounts
2900 https://bugs.webkit.org/show_bug.cgi?id=197537
2902 Reviewed by Darin Adler.
2904 Usage: block-spammers email1 email2 ...
2906 The tool finds and hides all bugs and comments from this account. Before any work
2907 is done, these bugs and comments are displayed for confirmation.
2909 * Scripts/block-spammers: Added.
2910 (get_bugzilla_token):
2911 (invalidate_bugzilla_token):
2913 (get_user_info_self):
2914 (can_use_this_tool):
2916 (get_bugs_created_by_user):
2917 (get_bugs_commented_on_by_user):
2925 2019-05-03 Jonathan Bedard <jbedard@apple.com>
2927 run-apit-tests: Add --iterations and --repeat-each
2928 https://bugs.webkit.org/show_bug.cgi?id=197563
2930 Reviewed by Aakash Jain.
2932 * Scripts/webkitpy/api_tests/manager.py:
2933 (Manager.run): Add --iterations and --repeat-each/
2934 * Scripts/webkitpy/api_tests/run_api_tests.py:
2935 (parse_args): Duplicate the test list based on --iterations and --repeat-each.
2937 2019-05-03 Aakash Jain <aakash_jain@apple.com>
2939 New EWS: Clicking on white bubble navigates to page with only bubbles
2940 https://bugs.webkit.org/show_bug.cgi?id=197520
2942 Reviewed by Lucas Forschler.
2944 * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
2946 2019-05-03 Daniel Bates <dabates@apple.com>
2948 [lldb-webkit] Support adding pretty-printing for qualified types
2949 https://bugs.webkit.org/show_bug.cgi?id=197518
2951 Reviewed by Darin Adler.
2953 Remove all "::"s from the name of the specified type when computing the name for the Python classes
2954 that will provide summary and synthetic details as LLDB is not happy about registering such classes
2955 when they contain :: in their name.
2957 * lldb/lldb_webkit.py:
2958 (addSummaryAndSyntheticFormattersForRawBitmaskType):
2960 2019-05-03 Aakash Jain <aakash_jain@apple.com>
2962 New EWS: patches on recently added queues listed as #1 for older bugs
2963 https://bugs.webkit.org/show_bug.cgi?id=197496
2965 Reviewed by Lucas Forschler.
2967 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2968 (StatusBubble._build_bubble):
2969 (StatusBubble._queue_position):
2971 2019-05-03 Aakash Jain <aakash_jain@apple.com>
2973 webkit-patch --no-review upload does not submit patch to New EWS
2974 https://bugs.webkit.org/show_bug.cgi?id=197519
2975 <rdar://problem/50424887>
2977 Reviewed by Lucas Forschler.
2979 * Scripts/webkitpy/tool/steps/submittoews.py:
2980 (SubmitToEWS.run): Submit to both old and new EWS.
2981 * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
2982 * Scripts/webkitpy/common/net/ewsserver.py: Added.
2983 (EWSServer._server_url): Method to return server url.
2984 (EWSServer._post_patch_to_ews): Method to post patch to ews.
2985 (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
2986 * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
2987 * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
2988 * Scripts/webkitpy/common/net/statusserver_mock.py:
2989 (MockStatusServer.submit_to_ews): Updated the log text.
2990 * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
2991 * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
2992 * Scripts/webkitpy/tool/main.py:
2993 (WebKitPatch.__init__): Initialize ews_server.
2994 * Scripts/webkitpy/tool/mocktool.py:
2995 (MockTool.__init__): Ditto.
2997 2019-05-03 Chris Dumez <cdumez@apple.com>
2999 ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
3000 https://bugs.webkit.org/show_bug.cgi?id=197574
3001 <rdar://problem/50453181>
3003 Reviewed by Tim Horton.
3005 Add API test coverage.
3007 * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
3010 2019-05-03 Yusuke Suzuki <ysuzuki@apple.com>
3012 [JSC] Generator CodeBlock generation should be idempotent
3013 https://bugs.webkit.org/show_bug.cgi?id=197552
3015 Reviewed by Keith Miller.
3017 * Scripts/run-javascriptcore-tests:
3018 (runJSCStressTests):
3019 * Scripts/run-jsc-stress-tests:
3021 2019-05-03 Commit Queue <commit-queue@webkit.org>
3023 Unreviewed, rolling out r244881.
3024 https://bugs.webkit.org/show_bug.cgi?id=197559
3026 Breaks compilation of jsconly on linux, breaking compilation
3027 for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
3028 guijemont on #webkit).
3032 "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
3034 https://bugs.webkit.org/show_bug.cgi?id=197174
3035 https://trac.webkit.org/changeset/244881
3037 2019-05-03 Zan Dobersek <zdobersek@igalia.com>
3039 Unreviewed WPE build fix after r244898.
3041 * WebKitTestRunner/wpe/TestControllerWPE.cpp:
3042 (WTR::TestController::abortModal): Add the missing (no-op) definition.
3044 2019-05-02 Alex Christensen <achristensen@webkit.org>
3046 Mark U+01C0 as a homograph of U+006C
3047 https://bugs.webkit.org/show_bug.cgi?id=197526
3048 <rdar://problem/50301904>
3050 Reviewed by Tim Horton.
3052 * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3053 (TestWebKitAPI::TEST):
3055 2019-05-02 Chris Dumez <cdumez@apple.com>
3057 Add test coverage for <rdar://problem/49731231>
3058 https://bugs.webkit.org/show_bug.cgi?id=196730
3059 <rdar://problem/49731231>
3061 Reviewed by Ryosuke Niwa.
3063 Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
3064 to match DumpRenderTree.
3066 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3067 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3068 (WTR::TestRunner::abortModal):
3069 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3070 * WebKitTestRunner/TestController.cpp:
3071 (WTR::TestController::runModal):
3072 * WebKitTestRunner/TestController.h:
3073 * WebKitTestRunner/TestInvocation.cpp:
3074 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3075 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3076 (WTR::TestController::abortModal):
3077 * WebKitTestRunner/ios/TestControllerIOS.mm:
3078 (WTR::TestController::abortModal):
3079 * WebKitTestRunner/mac/TestControllerMac.mm:
3080 (WTR::TestController::abortModal):
3081 * WebKitTestRunner/win/TestControllerWin.cpp:
3082 (WTR::TestController::abortModal):
3084 2019-05-02 Christopher Reid <chris.reid@sony.com>
3086 [CMake] Add support for LTO builds
3087 https://bugs.webkit.org/show_bug.cgi?id=188986
3089 Reviewed by Don Olmstead.
3091 Add support to configure --lto-mode with cmake builds.
3093 * Scripts/build-webkit:
3094 * Scripts/webkitdirs.pm:
3095 (generateBuildSystemFromCMakeProject):
3097 2019-05-02 John Wilander <wilander@apple.com>
3099 Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
3100 https://bugs.webkit.org/show_bug.cgi?id=197521
3101 <rdar://problem/49651503>
3103 Reviewed by Brent Fulgham.
3105 * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3106 (TestWebKitAPI::TEST):
3107 Added a test for host strings with leading dots since they are
3108 often used for the domain attribute in cookies.
3110 2019-05-02 Per Arne Vollan <pvollan@apple.com>
3112 -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
3113 https://bugs.webkit.org/show_bug.cgi?id=197510
3115 Reviewed by Alex Christensen.
3117 * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3118 (TestWebKitAPI::TEST):
3120 2019-05-02 Don Olmstead <don.olmstead@sony.com>
3122 [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
3123 https://bugs.webkit.org/show_bug.cgi?id=197174
3125 Reviewed by Alex Christensen.
3127 Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
3129 * TestWebKitAPI/PlatformGTK.cmake:
3130 * TestWebKitAPI/PlatformWPE.cmake:
3132 2019-05-02 Alex Christensen <achristensen@webkit.org>
3134 Build fix for internal branch.
3136 * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3137 RetainPtr.h was not explicitly included.
3139 2019-05-02 Jonathan Bedard <jbedard@apple.com>
3141 webkitpy: Ignore errors when shutting down an already shutdown simulator
3142 <https://bugs.webkit.org/show_bug.cgi?id=197514>
3143 <rdar://problem/50390247>
3145 Reviewed by Lucas Forschler.
3147 * Scripts/webkitpy/xcode/simulated_device.py:
3148 (SimulatedDevice._shut_down):
3150 2019-05-02 Frederic Wang <fwang@igalia.com>
3152 [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
3153 https://bugs.webkit.org/show_bug.cgi?id=196142
3155 This patch introduces some experimental runtime flag to let users
3156 disable MathML features that are removed from MathML Core [1]. For now,
3157 these features are only disabled on GTK and WPE ports.
3159 [1] https://mathml-refresh.github.io/mathml-core/
3161 Reviewed by Rob Buis.
3163 * DumpRenderTree/TestOptions.cpp:
3164 (TestOptions::TestOptions):
3165 * DumpRenderTree/TestOptions.h:
3166 * DumpRenderTree/mac/DumpRenderTree.mm:
3167 (setWebPreferencesForTestOptions):
3169 2019-05-01 Don Olmstead <don.olmstead@sony.com>
3171 TestWebKitAPI config.h should be aware of what suite is being built
3172 https://bugs.webkit.org/show_bug.cgi?id=196583
3174 Reviewed by Konstantin Tokarev.
3176 Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
3177 benefit the macro defines BUILDING_* for the executable which allows the includes
3178 of the config.h to be tailored to the test suite being built. Because of that the
3179 dependencies of the Test* executable are specific to the test suite which may
3182 Some source files were including "PlatformUtilities.h" which includes WebKit headers
3183 when "Utilities.h" is what was needed.
3185 * TestWebKitAPI/CMakeLists.txt:
3186 * TestWebKitAPI/PlatformGTK.cmake:
3187 * TestWebKitAPI/PlatformJSCOnly.cmake:
3188 * TestWebKitAPI/PlatformMac.cmake:
3189 * TestWebKitAPI/PlatformPlayStation.cmake:
3190 * TestWebKitAPI/PlatformUtilities.h:
3191 * TestWebKitAPI/PlatformWPE.cmake:
3192 * TestWebKitAPI/PlatformWin.cmake:
3193 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3194 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3195 * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3196 * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
3197 * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
3198 * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
3199 * TestWebKitAPI/config.h:
3201 2019-05-01 Jiewen Tan <jiewen_tan@apple.com>
3203 Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
3204 https://bugs.webkit.org/show_bug.cgi?id=181950
3205 <rdar://problem/43357371>
3207 Reviewed by Brent Fulgham.
3209 * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3210 (TestWebKitAPI::TEST_F):
3212 2019-05-01 Aakash Jain <aakash_jain@apple.com>
3214 Remove webkitpy and bindings EWS queues from dashboard
3215 https://bugs.webkit.org/show_bug.cgi?id=197475
3217 Reviewed by Alexey Proskuryakov.
3219 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3221 2019-05-01 Aakash Jain <aakash_jain@apple.com>
3223 Remove webkitpy and bindings test queues from old EWS
3224 https://bugs.webkit.org/show_bug.cgi?id=197468
3226 Reviewed by Alexey Proskuryakov.
3228 * QueueStatusServer/config/queues.py:
3230 2019-04-30 Tim Horton <timothy_horton@apple.com>
3232 Fix the WebKitTestRunner build
3233 https://bugs.webkit.org/show_bug.cgi?id=197449
3234 <rdar://problem/50334169>
3236 Reviewed by Alexey Proskuryakov.
3238 * WebKitTestRunner/mac/EventSenderProxy.mm:
3239 (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
3240 (WTR::EventSenderProxy::mouseForceChanged):
3241 Use some SPI instead of IPI.
3243 2019-04-30 Chris Dumez <cdumez@apple.com>
3245 Regression(PSON) URL scheme handlers can no longer respond asynchronously
3246 https://bugs.webkit.org/show_bug.cgi?id=197426
3247 <rdar://problem/50256169>
3249 Reviewed by Brady Eidson.
3251 Add API test coverage.
3253 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3254 (-[PSONScheme setShouldRespondAsynchronously:]):
3255 (-[PSONScheme webView:startURLSchemeTask:]):
3256 (-[PSONScheme webView:stopURLSchemeTask:]):
3258 2019-04-30 Chris Dumez <cdumez@apple.com>
3260 Unreviewed, rolling out r244802.
3262 Caused an API test failure
3266 "Regression(PSON) URL scheme handlers can no longer respond
3268 https://bugs.webkit.org/show_bug.cgi?id=197426
3269 https://trac.webkit.org/changeset/244802
3271 2019-04-30 Chris Dumez <cdumez@apple.com>
3273 Regression(PSON) URL scheme handlers can no longer respond asynchronously
3274 https://bugs.webkit.org/show_bug.cgi?id=197426
3275 <rdar://problem/50256169>
3277 Reviewed by Brady Eidson.
3279 Add API test coverage.
3281 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3282 (-[PSONScheme setShouldRespondAsynchronously:]):
3283 (-[PSONScheme webView:startURLSchemeTask:]):
3284 (-[PSONScheme webView:stopURLSchemeTask:]):
3286 2019-04-30 Chris Dumez <cdumez@apple.com>
3288 Only use a related page's process if that page has not been closed yet
3289 https://bugs.webkit.org/show_bug.cgi?id=197393
3290 <rdar://problem/50302423>
3292 Reviewed by Tim Horton.
3294 Add API test coverage.
3296 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3298 2019-04-30 Aakash Jain <aakash_jain@apple.com>
3300 [ews-build] Enable Bindings tests queue on new EWS
3301 https://bugs.webkit.org/show_bug.cgi?id=197424
3303 Reviewed by Lucas Forschler.
3305 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3307 * BuildSlaveSupport/ews-build/config.json:
3309 2019-04-30 Aakash Jain <aakash_jain@apple.com>
3311 [ews-build] Configure ews151 for running various tests
3312 https://bugs.webkit.org/show_bug.cgi?id=197419
3314 Reviewed by Lucas Forschler.
3316 * BuildSlaveSupport/ews-build/config.json:
3318 2019-04-30 Aakash Jain <aakash_jain@apple.com>
3320 [ews-build] Parse and display bindings test failures
3321 https://bugs.webkit.org/show_bug.cgi?id=197423
3323 Reviewed by Lucas Forschler.
3325 * BuildSlaveSupport/ews-build/steps.py:
3326 (RunBindingsTests.__init__): Set timeout of 5 minutes.
3327 (RunBindingsTests.start): Initialize log_observer for json output.
3328 (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
3329 (RunBindingsTests._addToLog): Method to add message to log.
3330 * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
3332 2019-04-30 Pablo Saavedra <psaavedra@igalia.com>
3334 Unreviewed. Add myself as a committer.
3336 * Scripts/webkitpy/common/config/contributors.json:
3338 2019-04-30 Aakash Jain <aakash_jain@apple.com>
3340 [ews-build] Enable webkitpy queue on new EWS
3341 https://bugs.webkit.org/show_bug.cgi?id=197396
3343 Reviewed by Lucas Forschler.
3345 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3347 * BuildSlaveSupport/ews-build/config.json:
3349 2019-04-30 Aakash Jain <aakash_jain@apple.com>
3351 [ews-build] Parse and display webkitpy failures
3352 https://bugs.webkit.org/show_bug.cgi?id=197395
3354 Reviewed by Lucas Forschler.
3356 * BuildSlaveSupport/ews-build/steps.py:
3357 (RunWebKitPyTests.start): Initialize log_observer for json output.
3358 (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
3359 (RunWebKitPyTests._addToLog): Method to add message to log.
3360 * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
3362 2019-04-29 Alex Christensen <achristensen@webkit.org>
3364 <rdar://problem/50299396> Fix internal High Sierra build
3365 https://bugs.webkit.org/show_bug.cgi?id=197388
3367 * DumpRenderTree/mac/Configurations/Base.xcconfig:
3368 * MiniBrowser/Configurations/Base.xcconfig:
3369 * MobileMiniBrowser/Configurations/Base.xcconfig:
3370 * TestWebKitAPI/Configurations/Base.xcconfig:
3371 * WebKitTestRunner/Configurations/Base.xcconfig:
3373 2019-04-29 Youenn Fablet <youenn@apple.com>
3375 Remove spurious GVA printf logging
3376 https://bugs.webkit.org/show_bug.cgi?id=197368
3377 <rdar://problem/35975256>
3379 Reviewed by Alexey Proskuryakov.
3381 * Scripts/webkitpy/port/mac.py:
3382 (MacPort.logging_patterns_to_strip):
3384 2019-04-29 Youenn Fablet <youenn@apple.com>
3386 getDisplayMedia should be called on user gesture
3387 https://bugs.webkit.org/show_bug.cgi?id=197356
3388 <rdar://problem/50296074>
3390 Reviewed by Eric Carlson.
3392 Update test configuration to inject internals
3393 so that we can use it to simulate a user click to call getDisplayMedia.
3395 * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
3396 * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
3397 (TestWebKitAPI::GetDisplayMediaTest::SetUp):
3399 2019-04-26 Stephanie Lewis <slewis@apple.com>
3401 run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
3402 https://bugs.webkit.org/show_bug.cgi?id=197339
3404 Reviewed by Dewei Zhu.
3406 Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
3407 test run for setup steps that are too expensive to do every iteration.
3409 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3410 (BenchmarkRunner._run_benchmark):
3411 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3413 (BrowserDriver.prepare_initial_env):
3414 (BrowserDriver.restore_env_after_all_testing):
3415 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
3416 (LinuxBrowserDriver.prepare_initial_env):
3417 (LinuxBrowserDriver.restore_env_after_all_testing):
3418 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3419 (OSXBrowserDriver.prepare_initial_env):
3420 (OSXBrowserDriver.restore_env_after_all_testing):
3422 2019-04-28 Andy Estes <aestes@apple.com>
3424 Fix the watchOS engineering build.
3426 * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
3427 (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
3429 2019-04-27 Chris Dumez <cdumez@apple.com>
3431 [WKTR] Move test timeout handling to the UIProcess
3432 https://bugs.webkit.org/show_bug.cgi?id=197333
3434 Reviewed by Darin Adler.
3436 Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
3437 we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
3438 every WebContent process in the case of swapping.
3440 Also, because of process caching, the timeout timer would sometime fire in a cached process and it
3441 would lead to crashes when firing the timer.
3443 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3444 (WTR::InjectedBundle::didReceiveMessageToPage):
3445 (WTR::InjectedBundle::done):
3446 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3447 (WTR::InjectedBundle::shouldDumpPixels const):
3448 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3449 (WTR::TestRunner::TestRunner):
3450 (WTR::TestRunner::waitUntilDone):
3451 (WTR::TestRunner::setWaitUntilDone):
3452 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3453 * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3454 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3455 * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
3456 * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
3457 * WebKitTestRunner/TestInvocation.cpp:
3458 (WTR::TestInvocation::TestInvocation):
3459 (WTR::TestInvocation::createTestSettingsDictionary):
3460 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3461 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3462 (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
3463 (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
3464 (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
3465 (WTR::TestInvocation::setWaitUntilDone):
3466 (WTR::TestInvocation::done):
3467 * WebKitTestRunner/TestInvocation.h:
3469 2019-04-25 Yusuke Suzuki <ysuzuki@apple.com>
3471 [JSC] linkPolymorphicCall now does GC
3472 https://bugs.webkit.org/show_bug.cgi?id=197306
3474 Reviewed by Saam Barati.
3476 The test is sensitive to allocations and even adding $vm makes it non-reproducible.
3477 To add this test, we add `runWithoutBaseOption`.
3479 * Scripts/run-jsc-stress-tests:
3481 2019-04-26 Alexey Proskuryakov <ap@apple.com>
3483 Update inactive reviewers' status to 'contributor'.
3485 Accidentally skipped one at first.
3487 * Scripts/webkitpy/common/config/contributors.json:
3489 2019-04-26 Alexey Proskuryakov <ap@apple.com>
3491 Update inactive reviewers' status to 'contributor'.
3493 * Scripts/webkitpy/common/config/contributors.json: The change.
3495 * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3496 * Scripts/webkitpy/common/checkout/checkout_mock.py:
3497 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3498 * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3499 * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3500 * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3501 * Scripts/webkitpy/tool/commands/queries_unittest.py:
3502 * Scripts/webkitpy/tool/commands/upload_unittest.py:
3503 Sadly, regression tests operate on a crazy mix of mock and live data for
3504 contributors.json. It would be a substantial project to mock all code paths,
3505 so changing the tests instead.
3507 2019-04-26 Eric Carlson <eric.carlson@apple.com>
3509 Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
3510 https://bugs.webkit.org/show_bug.cgi?id=197171
3511 <rdar://problem/47454979>
3513 Reviewed by Youenn Fablet.
3515 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3516 * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
3517 (TestWebKitAPI::TEST):
3519 2019-04-26 David Kilzer <ddkilzer@apple.com>
3521 WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
3522 <https://webkit.org/b/197314>
3523 <rdar://problem/50245252>
3525 Reviewed by Simon Fraser.
3527 * WebKitTestRunner/UIScriptControllerCocoa.mm:
3528 (WTR::UIScriptController::lastUndoLabel const):
3529 (WTR::UIScriptController::firstRedoLabel const):
3530 - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
3532 * WebKitTestRunner/ios/HIDEventGenerator.mm:
3533 (-[HIDEventGenerator sendEventStream:completionBlock:]):
3534 - Call -autorelease to fix leak of NSDictionary.
3536 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3537 (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
3538 (WTR::UIScriptController::selectFormPopoverTitle const):
3539 (WTR::UIScriptController::textContentType const):
3540 (WTR::UIScriptController::formInputLabel const):
3541 (WTR::UIScriptController::scrollingTreeAsText const):
3542 - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
3544 2019-04-26 Jonathan Bedard <jbedard@apple.com>
3546 webkitpy: Running a single test will always use the default device
3547 https://bugs.webkit.org/show_bug.cgi?id=195472
3548 <rdar://problem/48724825>
3550 Reviewed by Lucas Forschler.
3552 It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
3553 skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
3554 requested will be run regardless of what shard they are in.
3556 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3557 (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
3558 * Scripts/webkitpy/layout_tests/controllers/manager.py:
3559 (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
3560 on the default device type.
3561 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3562 (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
3563 (RunTest.test_run_part): Ditto.
3565 2019-04-26 Alex Christensen <achristensen@webkit.org>
3567 Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
3568 https://bugs.webkit.org/show_bug.cgi?id=197165
3570 Reviewed by Youenn Fablet.
3572 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3574 2019-04-26 Ryan Haddad <ryanhaddad@apple.com>
3576 Replace iOS build queue hardware
3577 https://bugs.webkit.org/show_bug.cgi?id=197312
3579 Reviewed by Aakash Jain.
3581 * BuildSlaveSupport/build.webkit.org-config/config.json:
3582 Use newer hardware that supports macOS Mojave.
3584 2019-04-26 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com>
3586 check-webkit-style complains the first block in while loop.
3587 https://bugs.webkit.org/show_bug.cgi?id=197307
3589 The style checker shouldn't complain about an open brace on
3590 its own line if the last non-whitespace character on the previous
3591 non-blank line is another open brace, because it's likely to
3592 indicate the begining of a nested code block.
3594 Reviewed by Alex Christensen.
3596 * Scripts/webkitpy/style/checkers/cpp.py:
3598 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3599 (WebKitStyleTest.test_braces):
3601 2019-04-26 Sihui Liu <sihui_liu@apple.com>
3603 Stop IDB transactions to release locked database files when network process is ready to suspend
3604 https://bugs.webkit.org/show_bug.cgi?id=196372
3605 <rdar://problem/48930116>
3607 Reviewed by Brady Eidson.
3609 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3610 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
3611 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
3612 (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
3613 (runTestAndCheckResult):
3614 (keepNetworkProcessActive):
3617 2019-04-25 Simon Fraser <simon.fraser@apple.com>
3619 REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
3620 https://bugs.webkit.org/show_bug.cgi?id=188357
3621 <rdar://problem/42986633>
3623 Reviewed by Dean Jackson.
3625 DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
3626 tests would fall into low memory mode and have different behavior.
3628 Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
3629 to Internals, so it's shared by DRT and WTR.
3631 We no longer need the WK2 C SPI glue.
3633 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3634 (WTR::InjectedBundlePage::prepare):
3636 2019-04-25 Jonathan Bedard <jbedard@apple.com>
3638 webkitpy: Including skipped tests in the final count
3639 https://bugs.webkit.org/show_bug.cgi?id=197298
3640 <rdar://problem/49705424>
3642 Reviewed by Lucas Forschler.
3644 * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3645 (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
3647 2019-04-25 Timothy Hatcher <timothy@apple.com>
3649 Disable date and time inputs on iOSMac.
3650 https://bugs.webkit.org/show_bug.cgi?id=197287
3651 rdar://problem/46794376
3653 Reviewed by Wenson Hsieh.
3655 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3657 2019-04-25 Alex Christensen <achristensen@webkit.org>
3659 Fix test-webkitpy after r244653
3660 https://bugs.webkit.org/show_bug.cgi?id=197131
3662 * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3665 2019-04-25 Per Arne Vollan <pvollan@apple.com>
3667 -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
3668 https://bugs.webkit.org/show_bug.cgi?id=196991
3669 <rdar://problem/45507423>
3671 Reviewed by Alex Christensen.
3673 * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3674 (-[NavigationTestDelegate init]):
3675 (-[NavigationTestDelegate waitForDidFinishNavigation]):
3676 (-[NavigationTestDelegate webView:didFinishNavigation:]):
3677 (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3678 (TestWebKitAPI::TEST):
3681 2019-04-25 Alex Christensen <achristensen@webkit.org>
3683 Revert some code accidentally committed with r244653
3684 https://bugs.webkit.org/show_bug.cgi?id=197131
3686 * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
3687 (TestWebKitAPI::TEST):
3689 2019-04-25 Alex Christensen <achristensen@webkit.org>
3692 https://bugs.webkit.org/show_bug.cgi?id=197131
3694 Reviewed by Darin Adler.
3696 * DumpRenderTree/mac/Configurations/Base.xcconfig:
3697 * MiniBrowser/Configurations/Base.xcconfig:
3698 * MobileMiniBrowser/Configurations/Base.xcconfig:
3699 * TestWebKitAPI/Configurations/Base.xcconfig:
3700 * WebKitTestRunner/Configurations/Base.xcconfig:
3702 2019-04-25 Commit Queue <commit-queue@webkit.org>
3704 Unreviewed, rolling out r244627.
3705 https://bugs.webkit.org/show_bug.cgi?id=197282
3707 Causing internal build failures (Requested by ShawnRoberts on
3712 "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
3713 https://bugs.webkit.org/show_bug.cgi?id=197171
3714 https://trac.webkit.org/changeset/244627
3716 2019-04-24 Carlos Garcia Campos <cgarcia@igalia.com>
3718 [GTK] Hardcoded text color in input fields
3719 https://bugs.webkit.org/show_bug.cgi?id=126907
3721 Reviewed by Michael Catanzaro.
3723 Add dark-mode command line option to MiniBrowser.
3725 * MiniBrowser/gtk/main.c:
3728 2019-04-24 Zalan Bujtas <zalan@apple.com>
3730 Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
3731 https://bugs.webkit.org/show_bug.cgi?id=196948
3732 <rdar://problem/49927131>
3734 Reviewed by Tim Horton.
3736 * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3738 The expected order of incoming events is
3739 1. didInvalidateIntrinsicContentSize
3741 At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
3742 However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
3743 (and remember, all we care about is ordering).
3745 2019-04-24 Eric Carlson <eric.carlson@apple.com>
3747 Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
3748 https://bugs.webkit.org/show_bug.cgi?id=197171
3749 <rdar://problem/47454979>
3751 Reviewed by Youenn Fablet.
3753 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3754 * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
3755 (TestWebKitAPI::TEST):
3757 2019-04-24 Brady Eidson <beidson@apple.com>
3759 XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
3760 https://bugs.webkit.org/show_bug.cgi?id=191362
3762 Reviewed by Alex Christensen.
3764 * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
3765 from an XHR to a custom protocol.
3767 2019-04-25 Simon Fraser <simon.fraser@apple.com>
3769 DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
3770 https://bugs.webkit.org/show_bug.cgi?id=197273
3772 Reviewed by Dean Jackson.
3774 Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
3775 so that WebCoreTestSupport::resetInternalsObject() is always run.
3777 * DumpRenderTree/mac/DumpRenderTree.mm:
3778 (resetWebViewToConsistentStateBeforeTesting):
3781 2019-04-24 John Wilander <wilander@apple.com>
3783 Age out unconverted Ad Click Attributions after one week.
3784 https://bugs.webkit.org/show_bug.cgi?id=197238
3785 <rdar://problem/50177349>
3787 Reviewed by Chris Dumez.
3789 This patch adds infrastructure to allow tests to expire all unconverted
3792 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3793 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3794 (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
3795 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3796 * WebKitTestRunner/TestController.cpp:
3797 (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
3798 * WebKitTestRunner/TestController.h:
3799 * WebKitTestRunner/TestInvocation.cpp:
3800 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3802 2019-04-24 Chris Dumez <cdumez@apple.com>
3804 Fix flaky crashes in a couple of PSON API tests
3805 https://bugs.webkit.org/show_bug.cgi?id=197239
3807 Reviewed by Tim Horton.
3809 Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
3811 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3813 2019-04-24 Simon Fraser <simon.fraser@apple.com>
3815 Make it possible to control the renderTreeAsText output by setting options on testRunner
3816 https://bugs.webkit.org/show_bug.cgi?id=197133
3818 Reviewed by Sam Weinig.
3820 Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
3821 that make sense in testing (those that don't dump unstable data like addresses), and plumb
3822 these flags through the various framework layers.
3824 Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
3826 Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
3827 and hand-code DumpRenderTree bindings.
3829 Some cleanup of the TestRunners, using member initializers.
3831 * DumpRenderTree/TestRunner.cpp:
3832 (TestRunner::TestRunner):
3833 (setRenderTreeDumpOptionsCallback):
3834 (TestRunner::staticFunctions):
3835 (TestRunner::setRenderTreeDumpOptions):
3836 * DumpRenderTree/TestRunner.h:
3837 (TestRunner::renderTreeDumpOptions const):
3838 * DumpRenderTree/mac/DumpRenderTree.mm:
3840 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3841 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3842 (WTR::InjectedBundlePage::dump):
3843 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3844 (WTR::TestRunner::TestRunner):
3845 (WTR::TestRunner::setRenderTreeDumpOptions):
3846 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3847 (WTR::TestRunner::renderTreeDumpOptions const):
3849 2019-04-24 Alex Christensen <achristensen@webkit.org>
3851 WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
3852 https://bugs.webkit.org/show_bug.cgi?id=197078
3853 <rdar://problem/49564348>
3855 Reviewed by Geoff Garen.
3857 * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3859 (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
3860 (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
3861 Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
3863 2019-04-24 Alex Christensen <achristensen@webkit.org>
3865 Add unit test for r239322
3866 https://bugs.webkit.org/show_bug.cgi?id=197236
3868 Reviewed by Chris Dumez.
3870 I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
3871 May as well add the test infrastructure which was needed before and will be needed in the future.
3873 * TestWebKitAPI/TCPServer.cpp:
3874 (TestWebKitAPI::TCPServer::TCPServer):
3875 * TestWebKitAPI/TCPServer.h:
3876 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3877 * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3878 (TestWebKitAPI::TEST):
3879 * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3880 (TestWebKitAPI::downloadAtRate):
3881 * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
3883 * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
3884 (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3885 (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3886 (TestWebKitAPI::TEST):
3887 * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3890 2019-04-24 Chris Dumez <cdumez@apple.com>
3892 URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
3893 https://bugs.webkit.org/show_bug.cgi?id=197214
3894 <rdar://problem/49237544>
3896 Reviewed by Alex Christensen.
3898 Extend API test coverage.
3900 * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3903 2019-04-24 Philippe Normand <pnormand@igalia.com>
3905 [Build][GStreamer] Update to 1.16.0
3906 https://bugs.webkit.org/show_bug.cgi?id=197157
3908 Reviewed by Xabier Rodriguez-Calvar.
3910 The upstreamed patches were removed and a new one was added for a
3911 regression detected in the scaletempo GStreamer element. The GNOME
3912 Flatpak was migrated to 3.32 and I switched a few modules to Meson
3913 on the way, as it is the preferred build system now in GStreamer
3916 * flatpak/files/httpd-autogen.sh:
3917 * flatpak/flatpakutils.py:
3918 (FlatpakPackage.install):
3919 (WebkitFlatpak.run_in_sandbox):
3920 * flatpak/org.webkit.CommonModules.yaml:
3921 * flatpak/org.webkit.WebKit.yaml:
3922 * gstreamer/jhbuild.modules:
3923 * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
3924 * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
3925 * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
3926 * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
3927 * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
3928 * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
3929 * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
3930 * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
3931 * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
3932 * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
3933 * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
3934 * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
3935 * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
3936 * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
3937 * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
3938 * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
3939 * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
3940 * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
3941 * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
3942 * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
3943 * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
3944 * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
3946 2019-04-24 Carlos Garcia Campos <cgarcia@igalia.com>
3948 [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
3949 https://bugs.webkit.org/show_bug.cgi?id=197156
3951 Reviewed by Michael Catanzaro.
3953 The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
3956 * MiniBrowser/gtk/BrowserTab.c:
3957 (browser_tab_set_background_color): Set the passed in color as web view background color.
3958 * MiniBrowser/gtk/BrowserTab.h:
3959 * MiniBrowser/gtk/BrowserWindow.c:
3960 (browser_window_init): Initialize backgroundColor.
3961 (browser_window_append_view): Call browser_tab_set_background_color().
3962 (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
3964 * MiniBrowser/gtk/main.c:
3965 (main): Call browser_window_set_background_color() before creating the tabs.
3967 2019-04-23 John Wilander <wilander@apple.com>
3969 Move Ad Click Attribution from internal feature to experimental feature
3970 https://bugs.webkit.org/show_bug.cgi?id=197218
3971 <rdar://problem/47651691>
3973 Reviewed by Brent Fulgham.
3975 * DumpRenderTree/TestOptions.cpp:
3976 (TestOptions::TestOptions):
3978 2019-04-23 Andy Estes <aestes@apple.com>
3980 [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
3981 https://bugs.webkit.org/show_bug.cgi?id=196749
3982 <rdar://problem/35773454>
3984 Reviewed by Daniel Bates.
3986 Added a new QuickLook API test and added new expectations to existing QuickLook tests.
3988 * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3989 (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
3990 (-[QuickLookDelegate webView:didFinishNavigation:]):
3991 (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
3992 (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3994 (runTestDecideBeforeLoading):
3995 (runTestDecideAfterLoading):
3998 2019-04-23 John Wilander <wilander@apple.com>
4000 Remove Ad Click Attribution data when removing website data
4001 https://bugs.webkit.org/show_bug.cgi?id=197215
4002 <rdar://problem/47668988>
4004 Reviewed by Chris Dumez.
4006 This patch adds test infrastructure to delete Ad Click Attribution data
4007 through WebsiteDataStore::removeData().
4009 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4010 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4011 (WTR::TestRunner::clearAdClickAttribution):
4012 (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
4013 * WebKitTestRunner/InjectedBundle/TestRunner.h:
4014 * WebKitTestRunner/TestController.cpp:
4015 (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
4016 * WebKitTestRunner/TestController.h:
4017 * WebKitTestRunner/TestInvocation.cpp:
4018 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4020 2019-04-23 Jonathan Bedard <jbedard@apple.com>
4022 webkitpy: Kill unresponsive worker processes
4023 https://bugs.webkit.org/show_bug.cgi?id=197205
4024 <rdar://problem/50104388>
4026 Reviewed by Lucas Forschler.
4028 * Scripts/webkitpy/common/message_pool.py:
4029 (_MessagePool.__init__): Add close timeout.
4030 (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
4032 2019-04-23 Alex Christensen <achristensen@webkit.org>
4034 Add unit tests for WKWebView.serverTrust
4035 https://bugs.webkit.org/show_bug.cgi?id=197202
4037 Reviewed by Youenn Fablet
4039 * TestWebKitAPI/TCPServer.cpp:
4040 (TestWebKitAPI::deleter<BIO>::operator()):
4041 (TestWebKitAPI::deleter<SSL>::operator()):
4042 (TestWebKitAPI::deleter<X509>::operator()):
4043 (TestWebKitAPI::deleter<SSL_CTX>::operator()):
4044 (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
4045 (TestWebKitAPI::TCPServer::TCPServer):
4046 (TestWebKitAPI::TCPServer::listenForConnections):
4047 * TestWebKitAPI/TCPServer.h:
4048 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4049 * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
4050 (TestWebKitAPI::TEST):
4051 (verifyCertificateAndPublicKey):
4052 (-[ServerTrustDelegate webView:didFinishNavigation:]):
4053 (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4054 * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4055 (TestWebKitAPI::downloadAtRate):
4056 * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
4058 * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
4061 2019-04-23 Commit Queue <commit-queue@webkit.org>
4063 Unreviewed, rolling out r244556.
4064 https://bugs.webkit.org/show_bug.cgi?id=197212
4066 Causing build failures on multiple builders (Requested by
4067 ShawnRoberts on #webkit).
4071 "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
4072 https://bugs.webkit.org/show_bug.cgi?id=197171
4073 https://trac.webkit.org/changeset/244556
4075 2019-04-23 Alex Christensen <achristensen@webkit.org>
4078 https://bugs.webkit.org/show_bug.cgi?id=195537
4080 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4081 (WTR::TestRunner::setOpenPanelFilesMediaIcon):
4082 AdoptWK constructor is private now. Use adoptWK instead.
4084 2019-04-23 Andres Gonzalez <andresg_22@apple.com>
4086 Accessibility text search and selection API enhancements.
4087 https://bugs.webkit.org/show_bug.cgi?id=197095
4088 <rdar://problem/48181791>
4090 Reviewed by Chris Fleizach.
4092 Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
4094 * DumpRenderTree/AccessibilityTextMarker.h:
4095 * DumpRenderTree/AccessibilityUIElement.cpp:
4096 (searchTextWithCriteriaCallback):
4097 (AccessibilityUIElement::getJSClass):
4098 * DumpRenderTree/AccessibilityUIElement.h:
4099 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4100 (convertVectorToObjectArray):
4101 (convertNSArrayToVector):
4102 (searchTextParameterizedAttributeForCriteria):
4103 (AccessibilityUIElement::getLinkedUIElements):
4104 (AccessibilityUIElement::getDocumentLinks):
4105 (AccessibilityUIElement::getChildren):
4106 (AccessibilityUIElement::getChildrenWithRange):
4107 (AccessibilityUIElement::rowHeaders const):
4108 (AccessibilityUIElement::columnHeaders const):
4109 (AccessibilityUIElement::uiElementArrayAttributeValue const):
4110 (AccessibilityUIElement::searchTextWithCriteria):
4111 (AccessibilityUIElement::attributesOfColumnHeaders):
4112 (AccessibilityUIElement::attributesOfRowHeaders):
4113 (AccessibilityUIElement::attributesOfColumns):
4114 (AccessibilityUIElement::attributesOfRows):
4115 (AccessibilityUIElement::attributesOfVisibleCells):
4116 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4117 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4118 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4119 (WTR::convertVectorToObjectArray):
4120 (WTR::convertNSArrayToVector):
4121 (WTR::searchTextParameterizedAttributeForCriteria):
4122 (WTR::AccessibilityUIElement::getLinkedUIElements):
4123 (WTR::AccessibilityUIElement::getDocumentLinks):
4124 (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
4125 (WTR::AccessibilityUIElement::getChildren):
4126 (WTR::AccessibilityUIElement::getChildrenWithRange):
4127 (WTR::AccessibilityUIElement::rowHeaders const):
4128 (WTR::AccessibilityUIElement::columnHeaders const):
4129 (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
4130 (WTR::AccessibilityUIElement::searchTextWithCriteria):
4131 (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
4132 (WTR::AccessibilityUIElement::attributesOfRowHeaders):
4133 (WTR::AccessibilityUIElement::attributesOfColumns):
4134 (WTR::AccessibilityUIElement::attributesOfRows):
4135 (WTR::AccessibilityUIElement::attributesOfVisibleCells):
4136 (WTR::convertElementsToObjectArray): Deleted.
4138 2019-04-23 Guy Lewin <guy@lewin.co.il>
4140 Multiple File Input Icon Set Regardless of File List
4141 https://bugs.webkit.org/show_bug.cgi?id=195537
4143 Reviewed by Alexey Proskuryakov.
4145 Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
4146 display string in iOS file inputs
4148 * DumpRenderTree/TestRunner.cpp:
4149 (SetOpenPanelFilesMediaIconCallback):
4150 (TestRunner::staticFunctions):
4151 (TestRunner::setOpenPanelFilesMediaIcon):
4152 * DumpRenderTree/TestRunner.h:
4153 (TestRunner::openPanelFilesMediaIcon const):
4154 * DumpRenderTree/mac/UIDelegate.mm:
4155 (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
4156 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4157 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4158 (WTR::TestRunner::setOpenPanelFilesMediaIcon):
4159 * WebKitTestRunner/InjectedBundle/TestRunner.h:
4160 * WebKitTestRunner/TestController.cpp:
4161 (WTR::runOpenPanel):
4162 (WTR::TestController::resetStateToConsistentValues):
4163 * WebKitTestRunner/TestController.h:
4164 (WTR::TestController::openPanelFileURLsMediaIcon const):
4165 (WTR::TestController::setOpenPanelFileURLsMediaIcon):
4166 * WebKitTestRunner/TestInvocation.cpp:
4167 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4169 2019-04-23 Eric Carlson <eric.carlson@apple.com>
4171 Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
4172 https://bugs.webkit.org/show_bug.cgi?id=197171
4173 <rdar://problem/47454979>
4175 Reviewed by Youenn Fablet.
4177 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4178 * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
4179 (TestWebKitAPI::TEST):
4181 2019-04-23 Aakash Jain <aakash_jain@apple.com>
4183 [ews-build] Add unit tests for UnApplyPatchIfRequired
4184 https://bugs.webkit.org/show_bug.cgi?id=197197
4186 Reviewed by Lucas Forschler.
4188 * BuildSlaveSupport/ews-build/steps_unittest.py:
4189 (TestUnApplyPatchIfRequired):
4190 (TestUnApplyPatchIfRequired.test_success):
4191 (TestUnApplyPatchIfRequired.test_failure):
4192 (TestUnApplyPatchIfRequired.test_skip):
4194 2019-04-23 Aakash Jain <aakash_jain@apple.com>
4196 [ews-build] Add unit tests for CleanWorkingDirectory
4197 https://bugs.webkit.org/show_bug.cgi?id=197195
4199 Reviewed by Lucas Forschler.
4201 * BuildSlaveSupport/ews-build/steps_unittest.py:
4202 (TestCleanWorkingDirectory):
4203 (TestCleanWorkingDirectory.test_success):
4204 (TestCleanWorkingDirectory.test_failure):
4206 2019-04-23 Aakash Jain <aakash_jain@apple.com>
4208 [ews-build] Use explicit imports instead of wildcard imports
4209 https://bugs.webkit.org/show_bug.cgi?id=197194
4211 Reviewed by Lucas Forschler.
4213 * BuildSlaveSupport/ews-build/factories.py:
4214 * BuildSlaveSupport/ews-build/loadConfig.py:
4215 * BuildSlaveSupport/ews-build/steps_unittest.py:
4217 2019-04-23 Aakash Jain <aakash_jain@apple.com>
4219 [ews-build] Add unit tests for DownloadBuiltProduct
4220 https://bugs.webkit.org/show_bug.cgi?id=197193
4222 Reviewed by Lucas Forschler.
4224 * BuildSlaveSupport/ews-build/steps_unittest.py:
4225 (TestDownloadBuiltProduct):
4226 (TestDownloadBuiltProduct.setUp):
4227 (TestDownloadBuiltProduct.tearDown):
4228 (TestDownloadBuiltProduct.test_success):
4229 (TestDownloadBuiltProduct.test_failure):
4231 2019-04-23 Aakash Jain <aakash_jain@apple.com>
4233 [ews-app] Exception while loading status-bubble when no build step has started
4234 https://bugs.webkit.org/show_bug.cgi?id=196676
4236 Reviewed by Lucas Forschler.
4238 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4239 (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
4241 2019-04-23 Stephan Szabo <stephan.szabo@sony.com>
4243 [PlayStation] Support running of JSC tests on remote playstation devices
4244 https://bugs.webkit.org/show_bug.cgi?id=197170
4246 Reviewed by Ross Kirsling.
4250 * Scripts/run-javascriptcore-tests:
4251 (runJSCStressTests): Pass arguments for playstation to
4252 run-jsc-stress-tests
4253 * Scripts/run-jsc-stress-tests:
4254 Handle $hostOS=="playstation" for determineArchitecture, turning
4255 off $isFTLPlatform and runProfiler and defaulting test writer.
4256 * Scripts/webkitdirs.pm:
4257 (jscPath): PlayStation WebKit executables have .elf extension
4258 (executableProductDir): PlayStation builds on Windows hosts but
4259 uses bin directory rather than bin64/bin32 for executable output
4261 * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
4263 2019-04-23 Don Olmstead <don.olmstead@sony.com>
4265 [CMake][Win] Use target oriented design for WebKit
4266 https://bugs.webkit.org/show_bug.cgi?id=197173
4268 Reviewed by Alex Christensen.
4270 * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
4271 * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
4273 2019-04-23 Chris Dumez <cdumez@apple.com>
4275 [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
4276 https://bugs.webkit.org/show_bug.cgi?id=197097
4277 <rdar://problem/50048318>
4279 Reviewed by Alex Christensen.
4281 Add API test coverage.
4283 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4284 (-[PSONScheme webView:startURLSchemeTask:]):
4286 2019-04-23 Carlos Garcia Campos <cgarcia@igalia.com>
4288 [ATK] Implement AtkComponentIface scroll_to methods
4289 https://bugs.webkit.org/show_bug.cgi?id=196856
4291 Reviewed by Michael Catanzaro.
4293 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4294 (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
4295 (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
4296 * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
4298 2019-04-22 Aakash Jain <aakash_jain@apple.com>
4300 [ews-build] Improve summary for UploadBuiltProduct step
4301 https://bugs.webkit.org/show_bug.cgi?id=197182
4303 Reviewed by Lucas Forschler.
4305 * BuildSlaveSupport/ews-build/steps.py:
4306 (UploadBuiltProduct): Added descriptionDone.
4307 (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
4308 * BuildSlaveSupport/ews-build/steps_unittest.py:
4309 (TestUploadBuiltProduct.test_success): Updated unit-test.
4310 (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
4312 2019-04-22 Aakash Jain <aakash_jain@apple.com>
4314 [ews-build] Trigger queues only after uploading the archive
4315 https://bugs.webkit.org/show_bug.cgi?id=197180
4317 Reviewed by Lucas Forschler.
4319 * BuildSlaveSupport/ews-build/factories.py:
4321 (BuildFactory.__init__): Remove trigger step from factories.
4322 (BuildFactory.propertiesToPassToTriggers): Deleted.
4323 * BuildSlaveSupport/ews-build/steps.py:
4324 (ConfigureBuild.__init__): Confiure triggers property.
4325 (Trigger): Step to trigger other queues.
4326 (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
4327 (UploadBuiltProduct.finished): Trigger builds after upload is successful.
4329 2019-04-22 Alex Christensen <achristensen@webkit.org>
4331 Deprecate WKContextCreateWithInjectedBundlePath
4332 https://bugs.webkit.org/show_bug.cgi?id=197169
4334 Reviewed by Youenn Fablet.
4336 * TestWebKitAPI/PlatformUtilities.cpp:
4337 (TestWebKitAPI::Util::createContextWithInjectedBundle):
4338 Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
4340 2019-04-22 Alex Christensen <achristensen@webkit.org>
4342 REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
4343 https://bugs.webkit.org/show_bug.cgi?id=197093
4344 <rdar://problem/49708268>
4346 Reviewed by Chris Dumez.
4348 Add a test that does two loads. The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
4349 The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
4350 We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
4351 and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
4352 and one for loads without credentials, so there are two TCP connections to the same server in this test.
4354 * TestWebKitAPI/TCPServer.cpp:
4355 (TestWebKitAPI::TCPServer::TCPServer):
4356 (TestWebKitAPI::TCPServer::~TCPServer):
4357 (TestWebKitAPI::TCPServer::socketBindListen):
4358 (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
4359 * TestWebKitAPI/TCPServer.h:
4360 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4361 * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
4362 (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4363 * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
4364 (respondWithChallengeThenOK):
4365 (TestWebKitAPI::TEST):
4366 (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
4367 (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4370 2019-04-22 Chris Dumez <cdumez@apple.com>
4372 Delayed WebProcessLaunch may break the _relatedWebView SPI
4373 https://bugs.webkit.org/show_bug.cgi?id=197160
4375 Reviewed by Alex Christensen.
4377 Add API test coverage.
4379 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4381 2019-04-22 Dean Johnson <dean_johnson@apple.com>
4383 Use curl to download packages for webkitpy autoinstaller
4384 https://bugs.webkit.org/show_bug.cgi?id=197164
4386 Reviewed by Darin Adler.
4388 * Scripts/webkitpy/common/system/autoinstall.py:
4389 (AutoInstaller._download): Use curl(1) to download packages necessary for
4390 webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
4391 errors which are not present when using curl(1).
4393 2019-04-22 Chris Dumez <cdumez@apple.com>
4395 Unreviewed, rolling out r244502.
4397 Caused crashes on the bots
4401 "Delayed WebProcessLaunch may break the _relatedWebView SPI"
4402 https://bugs.webkit.org/show_bug.cgi?id=197160
4403 https://trac.webkit.org/changeset/244502
4405 2019-04-22 Ryan Haddad <ryanhaddad@apple.com>
4407 Unreviewed, rolling out r244437.
4409 Still breaks internal tests.
4413 "InjectedBundle parameters often need initialization function
4414 called before unarchiving"
4415 https://bugs.webkit.org/show_bug.cgi?id=189709
4416 https://trac.webkit.org/changeset/244437
4418 2019-04-22 Aakash Jain <aakash_jain@apple.com>
4420 [ews-build] Use singular verb in failure description in case of single api test failure
4421 https://bugs.webkit.org/show_bug.cgi?id=197013
4423 Reviewed by Lucas Forschler.
4425 * BuildSlaveSupport/ews-build/steps.py:
4426 (AnalyzeAPITestsResults.analyzeResults):
4428 2019-04-22 Chris Dumez <cdumez@apple.com>
4430 Delayed WebProcessLaunch may break the _relatedWebView SPI
4431 https://bugs.webkit.org/show_bug.cgi?id=197160
4433 Reviewed by Alex Christensen.
4435 Add API test coverage.
4437 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4439 2019-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
4441 REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
4442 https://bugs.webkit.org/show_bug.cgi?id=194630
4444 Reviewed by Michael Catanzaro.
4446 Return early from getAttributeSet() is passed in accessible is nullptr.
4448 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4450 2019-04-21 Wenson Hsieh <wenson_hsieh@apple.com>
4452 Defer EditorState updates until the next layer tree flush in a few additional circumstances
4453 https://bugs.webkit.org/show_bug.cgi?id=197145
4454 <rdar://problem/50078170>
4456 Reviewed by Darin Adler.
4458 Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
4459 focus, or showing the font manager.
4461 * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
4462 (TestWebKitAPI::TEST):
4463 * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
4465 * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
4466 (TestWebKitAPI::TEST):
4468 2019-04-21 Brian Burg <bburg@apple.com>
4470 WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
4471 https://bugs.webkit.org/show_bug.cgi?id=197125
4472 <rdar://problem/50061468>
4474 Reviewed by Darin Adler.
4476 Sometimes I want to run wptserve independently of tests. Make it easier to script that
4477 using this class rather than making our own ./wpt serve invocation.
4479 * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
4480 (WebDriverW3CWebServer):
4481 (WebDriverW3CWebServer.document_root): Expose this to clients.
4482 (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
4484 (WebDriverW3CWebServer.__enter__):
4485 (WebDriverW3CWebServer.__exit__):
4486 Make it possible to use the web server with a 'with' statement.
4488 2019-04-20 Don Olmstead <don.olmstead@sony.com>
4490 [CMake][Win] Use target oriented design for WebKitLegacy
4491 https://bugs.webkit.org/show_bug.cgi?id=197112
4493 Reviewed by Konstantin Tokarev.
4495 Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
4497 * DumpRenderTree/CMakeLists.txt:
4498 * DumpRenderTree/PlatformWin.cmake:
4499 * DumpRenderTree/win/EventSender.cpp:
4501 2019-04-20 Aakash Jain <aakash_jain@apple.com>
4503 Update text for old EWS submit button
4504 https://bugs.webkit.org/show_bug.cgi?id=197140
4506 Reviewed by Alexey Proskuryakov.
4508 * QueueStatusServer/templates/statusbubble.html:
4510 2019-04-20 Aakash Jain <aakash_jain@apple.com>
4512 [ews-app] New EWS should poll bugzilla more frequently
4513 https://bugs.webkit.org/show_bug.cgi?id=197138
4515 Reviewed by Alexey Proskuryakov.
4517 * BuildSlaveSupport/ews-app/ews/fetcher.py:
4518 (FetchLoop.__init__):
4520 2019-04-20 Aakash Jain <aakash_jain@apple.com>
4522 [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
4523 https://bugs.webkit.org/show_bug.cgi?id=197139
4525 Reviewed by Alexey Proskuryakov.
4527 * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
4528 * QueueStatusServer/templates/statusbubble.html:
4530 2019-04-20 Chris Dumez <cdumez@apple.com>
4532 Unreviewed, fix iOS build with recent SDKs.
4534 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4536 2019-04-19 Keith Miller <keith_miller@apple.com>
4538 Add script to merge run_benchmark jsons
4539 https://bugs.webkit.org/show_bug.cgi?id=197107
4541 Reviewed by Michael Saboff.
4543 The script basically recursively decends through all json objects until it gets
4544 to an array or JSON primitive and concats or takes the first value, respectively.
4546 This patch also adds +x bits to the compare-results script so it
4547 can be run directly from the command line. I had to add a new line so that svn
4548 will accept the change... yay svn!
4550 * Scripts/compare-results:
4551 * Scripts/merge-result-jsons: Added.
4557 2019-04-18 Ryosuke Niwa <rniwa@webkit.org>
4559 Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
4560 https://bugs.webkit.org/show_bug.cgi?id=197079
4562 Reviewed by Darin Adler.
4564 Added a regression test. It hits a slightly different backtrace but of the same class of issues.
4566 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4567 * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
4569 2019-04-18 Commit Queue <commit-queue@webkit.org>
4571 Unreviewed, rolling out r244434.
4572 https://bugs.webkit.org/show_bug.cgi?id=197089
4574 caused 1 API test failure (Requested by zalan on #webkit).
4578 "Regression (r244291): Broken API Test
4579 AutoLayoutRenderingProgressRelativeOrdering"
4580 https://bugs.webkit.org/show_bug.cgi?id=196948
4581 https://trac.webkit.org/changeset/244434
4583 2019-04-18 Wenson Hsieh <wenson_hsieh@apple.com>
4585 Add new compatibility mode API on WKNavigation
4586 https://bugs.webkit.org/show_bug.cgi?id=197069
4587 <rdar://problem/50025800>
4589 Reviewed by Tim Horton.
4591 Add a block property for -didCommitNavigation to TestNavigationDelegate.
4593 * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4594 * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4595 (-[TestNavigationDelegate webView:didCommitNavigation:]):
4597 2019-04-18 Don Olmstead <don.olmstead@sony.com>
4599 [CMake] Make WebCore headers copies
4600 https://bugs.webkit.org/show_bug.cgi?id=182512
4601 <rdar://problem/37510435>
4603 Reviewed by Alex Christensen.
4605 Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
4608 WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
4609 of WebCore headers using "*.h" were modified to <WebCore/*.h>
4611 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
4612 * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
4613 * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
4614 * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
4615 * TestWebKitAPI/CMakeLists.txt:
4616 * TestWebKitAPI/PlatformWin.cmake:
4617 * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
4618 * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
4619 * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4621 2019-04-18 Jer Noble <jer.noble@apple.com>
4623 Add support for parsing FairPlayStreaming PSSH boxes.
4624 https://bugs.webkit.org/show_bug.cgi?id=197064
4626 Reviewed by Eric Carlson.
4628 * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
4629 (TestWebKitAPI::TEST):
4631 2019-04-18 Brent Fulgham <bfulgham@apple.com>
4633 InjectedBundle parameters often need initialization function called before unarchiving
4634 https://bugs.webkit.org/show_bug.cgi?id=189709
4635 <rdar://problem/44573653>
4637 Reviewed by Ryosuke Niwa.
4639 * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
4640 (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
4642 2019-04-18 Zalan Bujtas <zalan@apple.com>
4644 Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
4645 https://bugs.webkit.org/show_bug.cgi?id=196948
4646 <rdar://problem/49927131>
4648 Reviewed by Tim Horton.
4650 * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
4652 The expected order of incoming events is
4653 1. didInvalidateIntrinsicContentSize
4655 At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
4656 However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
4657 (and remember, all we care about is ordering).
4659 2019-04-18 Ryan Haddad <ryanhaddad@apple.com>
4661 Unreviewed, rolling out r244299.
4663 Breaks internal tests.
4667 "InjectedBundle parameters often need initialization function
4668 called before unarchiving"
4669 https://bugs.webkit.org/show_bug.cgi?id=189709
4670 https://trac.webkit.org/changeset/244299
4672 2019-04-18 Yusuke Suzuki <ysuzuki@apple.com>
4674 [WTF] StringBuilder should set correct m_is8Bit flag when merging
4675 https://bugs.webkit.org/show_bug.cgi?id=197053
4677 Reviewed by Saam Barati.
4679 * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
4680 (TestWebKitAPI::TEST):
4682 2019-04-17 Tim Horton <timothy_horton@apple.com>
4684 [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
4685 https://bugs.webkit.org/show_bug.cgi?id=197028
4686 <rdar://problem/49985290>
4688 Reviewed by Wenson Hsieh.
4690 * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
4692 Liberal application of waitForNextPresentationUpdate works around a race
4693 where if the page rapidly changes its viewport arguments (or an API client
4694 rapidly changes its viewport arguments), we'd get stuck thinking that the
4695 user had intentionally zoomed the page, and stop resetting the initial scale.
4696 This deserves a separate bug, but no need to keep the test failing while
4699 2019-04-17 Tim Horton <timothy_horton@apple.com>
4701 REGRESSION (r241988): Switching tabs is slow
4702 https://bugs.webkit.org/show_bug.cgi?id=197037
4703 <rdar://problem/49951473>
4705 Reviewed by Simon Fraser.
4707 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4708 * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
4710 * TestWebKitAPI/cocoa/TestWKWebView.h:
4711 * TestWebKitAPI/cocoa/TestWKWebView.mm:
4712 (-[TestWKWebView addToTestWindow]):
4713 Add a test that hangs without this fix.
4715 2019-04-17 Truitt Savell <tsavell@apple.com>
4717 Unreviewed, rolling out r244400.
4719 Caused testing to exit early with assertionon Debug WK2
4723 "UI↔Web deadlock when printing with a JavaScript alert
4725 https://bugs.webkit.org/show_bug.cgi?id=196839
4726 https://trac.webkit.org/changeset/244400
4728 2019-04-17 Brady Eidson <beidson@apple.com>
4730 Link clicks in PDFs shouldn't send referrer headers.
4731 <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
4733 Reviewed by Tim Horton.
4735 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4736 * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
4737 (putPDFBytesCallback):
4738 (emptyReleaseInfoCallback):
4739 (createPDFWithLinkToURL):
4742 2019-04-17 Tim Horton <timothy_horton@apple.com>
4744 UI↔Web deadlock when printing with a JavaScript alert visible
4745 https://bugs.webkit.org/show_bug.cgi?id=196839
4746 <rdar://problem/49157642>
4748 Reviewed by Andy Estes.
4750 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4751 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
4752 (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4755 2019-04-17 Alex Christensen <achristensen@webkit.org>
4757 WKRetainPtr's adoption constructor should be private
4758 https://bugs.webkit.org/show_bug.cgi?id=197019
4760 Reviewed by Tim Horton.
4762 * DumpRenderTree/mac/DumpRenderTree.mm:
4764 * TestWebKitAPI/InjectedBundleController.cpp:
4765 (TestWebKitAPI::InjectedBundleController::initialize):
4766 * TestWebKitAPI/PlatformUtilities.cpp:
4767 (TestWebKitAPI::Util::createContextWithInjectedBundle):
4768 (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
4769 (TestWebKitAPI::Util::createContextForInjectedBundleTest):
4770 (TestWebKitAPI::Util::toWK):
4771 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
4772 (TestWebKitAPI::TEST):
4773 * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
4774 (TestWebKitAPI::TEST):
4775 * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
4776 (TestWebKitAPI::TEST):
4777 * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
4778 (TestWebKitAPI::TEST):
4779 * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
4780 (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
4781 * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
4782 (TestWebKitAPI::TEST):
4783 * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
4784 (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
4785 * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
4786 (TestWebKitAPI::TEST):
4787 * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
4788 (TestWebKitAPI::TEST):
4789 * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
4790 (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
4791 * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
4792 (TestWebKitAPI::TEST):
4793 * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
4794 (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
4795 * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
4796 (TestWebKitAPI::TEST):
4797 * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
4798 (TestWebKitAPI::TEST):
4799 * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
4800 (TestWebKitAPI::TEST):
4801 * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
4802 (TestWebKitAPI::TEST):
4803 * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
4804 (TestWebKitAPI::TEST):
4805 * TestWebKitAPI/Tests/WebKit/Find.cpp:
4806 (TestWebKitAPI::TEST):
4807 * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
4808 (TestWebKitAPI::TEST):
4809 * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
4810 (TestWebKitAPI::TEST):
4811 * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
4812 (TestWebKitAPI::TEST):
4813 * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
4814 (TestWebKitAPI::TEST):
4815 * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
4816 (TestWebKitAPI::TEST):
4817 * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
4818 (TestWebKitAPI::TEST):
4819 * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
4820 (TestWebKitAPI::TEST):
4821 * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
4822 (TestWebKitAPI::TEST):
4823 * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
4824 (TestWebKitAPI::TEST):
4825 * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
4826 (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
4827 * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
4828 (TestWebKitAPI::TEST):
4829 * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
4830 (TestWebKitAPI::TEST):
4831 * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
4832 (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
4833 (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
4834 * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
4835 (TestWebKitAPI::TEST):
4836 * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
4837 (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
4838 * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
4839 (TestWebKitAPI::TEST):
4840 * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
4841 (TestWebKitAPI::TEST):
4842 * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
4843 (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
4844 * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
4845 (TestWebKitAPI::TEST):
4846 * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
4847 (TestWebKitAPI::loadAlternateHTMLString):
4848 (TestWebKitAPI::TEST):
4849 * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
4850 (TestWebKitAPI::TEST):
4851 * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
4852 (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
4853 * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
4854 (TestWebKitAPI::buildAndPerformTest):
4855 * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
4856 (TestWebKitAPI::TEST):
4857 * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
4858 (TestWebKitAPI::TEST):
4859 * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
4860 (TestWebKitAPI::TEST):
4861 * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
4862 (TestWebKitAPI::TEST):
4863 * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
4864 (TestWebKitAPI::TEST):
4865 * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
4866 (TestWebKitAPI::TEST):
4867 * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
4868 (TestWebKitAPI::TEST):
4869 * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
4870 (TestWebKitAPI::TEST):
4871 * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
4872 (TestWebKitAPI::TEST):
4873 * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
4874 (TestWebKitAPI::TEST):
4875 * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
4876 (TestWebKitAPI::TEST):
4877 * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
4878 (TestWebKitAPI::TEST):
4879 * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
4880 (TestWebKitAPI::TEST):
4881 * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4882 (TestWebKitAPI::TEST):
4883 * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
4884 (TestWebKitAPI::TEST):
4885 * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
4886 (TestWebKitAPI::TEST):
4887 * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
4888 (TestWebKitAPI::TEST):
4889 * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
4890 (TestWebKitAPI::TEST):
4891 * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
4892 (TestWebKitAPI::TEST):
4893 * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
4894 (TestWebKitAPI::TEST):
4895 * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
4896 (TestWebKitAPI::TEST):
4897 * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
4898 (TestWebKitAPI::TEST):
4899 * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
4900 (TestWebKitAPI::TEST):
4901 * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4902 (TestWebKitAPI::TEST):
4903 * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
4904 (TestWebKitAPI::TEST):
4905 * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
4906 (TestWebKitAPI::TEST):
4907 * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
4908 (TestWebKitAPI::TEST):
4909 * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
4910 (TestWebKitAPI::TEST):
4911 * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
4912 (TestWebKitAPI::TEST):
4913 * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
4914 (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
4915 * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
4916 (TestWebKitAPI::TEST):
4917 * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
4918 (TestWebKitAPI::TEST):
4919 * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
4920 (TestWebKitAPI::TEST):
4921 * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
4922 (TestWebKitAPI::TEST):
4923 * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
4924 (TestWebKitAPI::TEST):
4925 * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
4926 (TestWebKitAPI::TEST):
4927 * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
4928 (TestWebKitAPI::TEST):
4929 * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
4930 (TestWebKitAPI::TEST):
4931 * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
4932 (TestWebKitAPI::TEST):
4933 * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
4934 (TestWebKitAPI::TEST):
4935 * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
4936 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
4938 * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
4940 * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4941 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4943 * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
4944 (TestWebKitAPI::TEST):
4945 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
4946 (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
4947 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4948 (WTR::getMenuItemTitleCallback):
4949 (WTR::createMouseMessageBody):
4950 (WTR::EventSendingController::mouseDown):
4951 (WTR::EventSendingController::mouseUp):
4952 (WTR::EventSendingController::mouseMoveTo):
4953 (WTR::EventSendingController::mouseForceClick):
4954 (WTR::EventSendingController::startAndCancelMouseForceClick):
4955 (WTR::EventSendingController::mouseForceDown):
4956 (WTR::EventSendingController::mouseForceUp):
4957 (WTR::EventSendingController::mouseForceChanged):
4958 (WTR::EventSendingController::leapForward):
4959 (WTR::EventSendingController::scheduleAsynchronousClick):
4960 (WTR::createKeyDownMessageBody):
4961 (WTR::EventSendingController::keyDown):
4962 (WTR::EventSendingController::scheduleAsynchronousKeyDown):
4963 (WTR::EventSendingController::mouseScrollBy):
4964 (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
4965 (WTR::EventSendingController::continuousMouseScrollBy):
4966 (WTR::EventSendingController::addTouchPoint):
4967 (WTR::EventSendingController::updateTouchPoint):
4968 (WTR::EventSendingController::setTouchModifier):
4969 (WTR::EventSendingController::setTouchPointRadius):
4970 (WTR::EventSendingController::touchStart):
4971 (WTR::EventSendingController::touchMove):
4972 (WTR::EventSendingController::touchEnd):
4973 (WTR::EventSendingController::touchCancel):
4974 (WTR::EventSendingController::clearTouchPoints):
4975 (WTR::EventSendingController::releaseTouchPoint):
4976 (WTR::EventSendingController::cancelTouchPoint):
4977 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4978 (WTR::InjectedBundle::didCreatePage):
4979 (WTR::InjectedBundle::didReceiveMessage):
4980 (WTR::InjectedBundle::didReceiveMessageToPage):
4981 (WTR::InjectedBundle::booleanForKey):
4982 (WTR::InjectedBundle::done):
4983 (WTR::InjectedBundle::dumpToStdErr):
4984 (WTR::InjectedBundle::outputText):
4985 (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
4986 (WTR::InjectedBundle::postAddChromeInputField):
4987 (WTR::InjectedBundle::postRemoveChromeInputField):
4988 (WTR::InjectedBundle::postFocusWebView):
4989 (WTR::InjectedBundle::postSetBackingScaleFactor):
4990 (WTR::InjectedBundle::postSetWindowIsKey):
4991 (WTR::InjectedBundle::postSetViewSize):
4992 (WTR::InjectedBundle::postSimulateWebNotificationClick):
4993 (WTR::InjectedBundle::postSetAddsVisitedLinks):
4994 (WTR::InjectedBundle::setGeolocationPermission):
4995 (WTR::InjectedBundle::setMockGeolocationPosition):
4996 (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
4997 (WTR::InjectedBundle::isGeolocationProviderActive const):
4998 (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
4999 (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
5000 (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
5001 (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
5002 (WTR::InjectedBundle::setCustomPolicyDelegate):
5003 (WTR::InjectedBundle::setHidden):
5004 (WTR::InjectedBundle::setCacheModel):
5005 (WTR::InjectedBundle::shouldProcessWorkQueue const):
5006 (WTR::InjectedBundle::processWorkQueue):
5007 (WTR::InjectedBundle::queueBackNavigation):
5008 (WTR::InjectedBundle::queueForwardNavigation):
5009 (WTR::InjectedBundle::queueLoad):
5010 (WTR::InjectedBundle::queueLoadHTMLString):
5011 (WTR::InjectedBundle::queueReload):
5012 (WTR::InjectedBundle::queueLoadingScript):
5013 (WTR::InjectedBundle::queueNonLoadingScript):
5014 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
5016 (WTR::InjectedBundlePage::InjectedBundlePage):
5017 (WTR::dumpFrameDescriptionSuitableForTestResult):
5018 (WTR::dumpFrameScrollPosition):
5019 (WTR::dumpDescendantFrameScrollPositions):
5020 (WTR::dumpFrameText):
5021 (WTR::dumpDescendantFramesText):
5022 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
5023 (WTR::TestRunner::shouldDumpPixels const):
5024 (WTR::TestRunner::setDumpPixels):
5025 (WTR::TestRunner::whatToDump const):
5026 (WTR::TestRunner::setWhatToDump):
5027 (WTR::TestRunner::setWaitUntilDone):
5028 (WTR::TestRunner::shouldWaitUntilDone const):
5029 (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
5030 (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
5031 (WTR::TestRunner::clearAllDatabases):
5032 (WTR::TestRunner::setIDBPerOriginQuota):
5033 (WTR::TestRunner::originsWithApplicationCache):
5034 (WTR::TestRunner::setCanOpenWindows):
5035 (WTR::TestRunner::setXSSAuditorEnabled):
5036 (WTR::TestRunner::setMediaDevicesEnabled):
5037 (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
5038 (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
5039 (WTR::TestRunner::setCustomUserAgent):
5040 (WTR::TestRunner::setWebAPIStatisticsEnabled):
5041 (WTR::TestRunner::setModernMediaControlsEnabled):
5042 (WTR::TestRunner::setWebGL2Enabled):
5043 (WTR::TestRunner::setWritableStreamAPIEnabled):
5044 (WTR::TestRunner::setReadableByteStreamAPIEnabled):
5045 (WTR::TestRunner::setEncryptedMediaAPIEnabled):
5046 (WTR::TestRunner::setAllowsAnySSLCertificate):
5047 (WTR::TestRunner::setPluginsEnabled):
5048 (WTR::TestRunner::setValueForUser):
5049 (WTR::TestRunner::setAudioResult):
5050 (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
5051 (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
5052 (WTR::TestRunner::setAlwaysAcceptCookies):
5053 (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
5054 (WTR::TestRunner::isDoingMediaCapture const):
5055 (WTR::TestRunner::queueLoad):
5056 (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
5057 (WTR::TestRunner::setHandlesAuthenticationChallenges):
5058 (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
5059 (WTR::TestRunner::setShouldLogDownloadCallbacks):
5060 (WTR::TestRunner::setAuthenticationUsername):
5061 (WTR::TestRunner::setAuthenticationPassword):
5062 (WTR::TestRunner::secureEventInputIsEnabled const):
5063 (WTR::TestRunner::setBlockAllPlugins):
5064 (WTR::TestRunner::setPluginSupportedMode):
5065 (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
5066 (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
5067 (WTR::TestRunner::setNavigationGesturesEnabled):
5068 (WTR::TestRunner::setIgnoresViewportScaleLimits):
5069 (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
5070 (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
5071 (WTR::TestRunner::terminateNetworkProcess):
5072 (WTR::TestRunner::terminateServiceWorkerProcess):
5073 (WTR::TestRunner::runUIScript):
5074 (WTR::TestRunner::setStatisticsDebugMode):
5075 (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
5076 (WTR::TestRunner::setStatisticsLastSeen):
5077 (WTR::TestRunner::setStatisticsPrevalentResource):
5078 (WTR::TestRunner::setStatisticsVeryPrevalentResource):
5079 (WTR::TestRunner::dumpResourceLoadStatistics):
5080 (WTR::TestRunner::isStatisticsPrevalentResource):
5081 (WTR::TestRunner::isStatisticsVeryPrevalentResource):
5082 (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
5083 (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
5084 (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
5085 (WTR::TestRunner::setStatisticsHasHadUserInteraction):
5086 (WTR::TestRunner::isStatisticsHasHadUserInteraction):
5087 (WTR::TestRunner::setStatisticsGrandfathered):
5088 (WTR::TestRunner::isStatisticsGrandfathered):
5089 (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
5090 (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
5091 (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
5092 (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
5093 (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
5094 (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
5095 (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
5096 (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
5097 (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
5098 (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
5099 (WTR::TestRunner::statisticsUpdateCookieBlocking):
5100 (WTR::TestRunner::statisticsSubmitTelemetry):
5101 (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
5102 (WTR::TestRunner::setStatisticsIsRunningTest):
5103 (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
5104 (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
5105 (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
5106 (WTR::TestRunner::setStatisticsGrandfatheringTime):
5107 (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
5108 (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
5109 (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
5110 (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
5111 (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
5112 (WTR::TestRunner::statisticsDeleteCookiesForHost):
5113 (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
5114 (WTR::TestRunner::statisticsResetToConsistentState):
5115 (WTR::TestRunner::setStorageAccessAPIEnabled):
5116 (WTR::TestRunner::getAllStorageAccessEntries):
5117 (WTR::TestRunner::addMockMediaDevice):
5118 (WTR::TestRunner::clearMockMediaDevices):
5119 (WTR::TestRunner::removeMockMediaDevice):
5120 (WTR::TestRunner::resetMockMediaDevices):
5121 (WTR::TestRunner::connectMockGamepad):
5122 (WTR::TestRunner::disconnectMockGamepad):
5123 (WTR::TestRunner::setMockGamepadDetails):
5124 (WTR::TestRunner::setMockGamepadAxisValue):
5125 (WTR::TestRunner::setMockGamepadButtonValue):
5126 (WTR::TestRunner::removeAllSessionCredentials):
5127 (WTR::TestRunner::clearDOMCache):
5128 (WTR::TestRunner::clearDOMCaches):
5129 (WTR::TestRunner::hasDOMCache):
5130 (WTR::TestRunner::domCacheSize):
5131 (WTR::TestRunner::setAllowStorageQuotaIncrease):
5132 (WTR::TestRunner::getApplicationManifestThen):
5133 (WTR::TestRunner::injectUserScript):
5134 (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
5135 (WTR::TestRunner::setWebAuthenticationMockConfiguration):
5136 (WTR::TestRunner::addTestKeyToKeychain):
5137 (WTR::TestRunner::cleanUpKeychain):
5138 (WTR::TestRunner::keyExistsInKeychain):
5139 (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
5140 (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
5141 (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
5142 (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
5143 (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
5144 (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
5145 * WebKitTestRunner/TestController.cpp:
5146 (WTR::TestController::initialize):
5147 (WTR::parseStringTestHeaderValueAsRelativePath):
5148 (WTR::updateTestOptionsFromTestHeader):
5149 (WTR::TestController::runTest):
5150 (WTR::TestController::didReceiveLiveDocumentsList):
5151 (WTR::TestController::didReceiveMessageFromInjectedBundle):
5152 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
5153 (WTR::TestController::didFinishNavigation):
5154 (WTR::TestController::didReceiveAuthenticationChallenge):
5155 * WebKitTestRunner/TestInvocation.cpp:
5156 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
5157 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
5158 (WTR::TestInvocation::uiScriptDidComplete):
5159 (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
5160 * WebKitTestRunner/WebNotificationProvider.cpp:
5161 (WTR::WebNotificationProvider::closeWebNotification):
5162 * WebKitTestRunner/WorkQueueManager.cpp:
5163 (WTR::ScriptItem::ScriptItem):
5164 (WTR::WorkQueueManager::queueLoad):
5165 (WTR::WorkQueueManager::queueLoadHTMLString):
5167 2019-04-17 Alex Christensen <achristensen@webkit.org>
5169 Add a comment to make my test from r244139 less mysterious.
5170 https://bugs.webkit.org/show_bug.cgi?id=196744
5172 As suggested by Darin Adler.
5174 * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
5175 (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
5177 2019-04-17 Chris Dumez <cdumez@apple.com>
5179 Remember device orientation permission for the duration of the browsing session
5180 https://bugs.webkit.org/show_bug.cgi?id=196992
5181 <rdar://problem/49946067>
5183 Reviewed by Alex Christensen.
5185 Add API test coverage.
5187 * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
5188 (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
5191 2019-04-17 Aakash Jain <aakash_jain@apple.com>
5193 [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
5194 https://bugs.webkit.org/show_bug.cgi?id=196675
5196 Reviewed by Lucas Forschler.
5198 * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
5199 (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
5201 2019-04-16 Wenson Hsieh <wenson_hsieh@apple.com>
5203 [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
5204 https://bugs.webkit.org/show_bug.cgi?id=196919
5205 <rdar://problem/41630459>
5207 Reviewed by Tim Horton.
5209 Add iOS support for several new testing hooks. See below for more detail.
5211 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
5212 (WTR::UIScriptController::isDismissingMenu const):
5214 Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
5215 dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
5216 by UIKit when dismissing the callout bar (i.e. UIMenuController).
5218 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
5219 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
5220 (WTR::UIScriptController::isDismissingMenu const):
5221 * TestRunnerShared/UIScriptContext/UIScriptController.h:
5222 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
5223 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
5224 (WTR::InjectedBundle::didReceiveMessageToPage):
5225 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
5226 (WTR::TestRunner::setAllowedMenuActions):
5228 Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
5229 actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
5230 "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
5231 against the name of the custom action.
5233 (WTR::TestRunner::installCustomMenuAction):
5235 Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
5236 takes the name of the action (which appears in a button in the callout bar), whether the action should cause
5237 the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
5240 (WTR::TestRunner::performCustomMenuAction):
5242 Invoked when the custom menu action is triggered.
5244 * WebKitTestRunner/InjectedBundle/TestRunner.h:
5245 * WebKitTestRunner/TestController.cpp:
5246 (WTR::TestController::installCustomMenuAction):
5247 (WTR::TestController::setAllowedMenuActions):
5248 * WebKitTestRunner/TestController.h:
5249 * WebKitTestRunner/TestInvocation.cpp:
5250 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
5251 (WTR::TestInvocation::performCustomMenuAction):
5253 Add plumbing to call back into the injected bundle when performing the custom action.
5255 * WebKitTestRunner/TestInvocation.h:
5256 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
5257 (WTR::TestController::installCustomMenuAction):
5258 (WTR::TestController::setAllowedMenuActions):
5259 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
5260 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
5261 (-[TestRunnerWKWebView initWithFrame:configuration:]):
5262 (-[TestRunnerWKWebView becomeFirstResponder]):
5263 (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
5265 Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
5266 shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
5267 in the Mail app on iOS.
5269 (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
5270 (-[TestRunnerWKWebView setAllowedMenuActions:]):
5271 (-[TestRunnerWKWebView resetCustomMenuAction]):
5272 (-[TestRunnerWKWebView performCustomAction:]):
5273 (-[TestRunnerWKWebView canPerformAction:withSender:]):
5274 (-[TestRunnerWKWebView _willHideMenu]):
5275 (-[TestRunnerWKWebView _didHideMenu]):
5276 * WebKitTestRunner/ios/TestControllerIOS.mm:
5277 (WTR::TestController::platformResetStateToConsistentValues):
5279 Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
5282 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
5283 (WTR::UIScriptController::isDismissingMenu const):
5285 2019-04-16 Megan Gardner <megan_gardner@apple.com>
5287 Allow sharing from imageSheet on an image document
5288 https://bugs.webkit.org/show_bug.cgi?id=196891
5289 <rdar://problem/25377386>
5291 Reviewed by Tim Horton.
5293 Test to make sure that the correct imageURL is extracted from an image element.
5295 * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
5296 (TestWebKitAPI::TEST):
5298 2019-04-16 Alex Christensen <achristensen@webkit.org>
5300 REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
5301 https://bugs.webkit.org/show_bug.cgi?id=196995
5303 Reviewed by Brady Eidson.
5305 * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
5308 2019-04-16 Chris Dumez <cdumez@apple.com>
5310 URL set by document.open() is not communicated to the UIProcess
5311 https://bugs.webkit.org/show_bug.cgi?id=196941
5312 <rdar://problem/49237544>
5314 Reviewed by Geoff Garen.
5316 Add API test coverage.
5318 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
5319 * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
5320 * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
5321 (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
5324 2019-04-16 Commit Queue <commit-queue@webkit.org>
5326 Unreviewed, rolling out r244321.
5327 https://bugs.webkit.org/show_bug.cgi?id=196968
5329 Causing all WK2 Debug builds to exit early after Assertion
5330 failures. (Requested by ShawnRoberts on #webkit).
5334 "URL set by document.open() is not communicated to the
5336 https://bugs.webkit.org/show_bug.cgi?id=196941
5337 https://trac.webkit.org/changeset/244321
5339 2019-04-15 Aakash Jain <aakash_jain@apple.com>
5341 Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
5342 https://bugs.webkit.org/show_bug.cgi?id=196948
5344 Reviewed by Zalan Bujtas.
5346 * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
5347 (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
5349 2019-04-15 Chris Dumez <cdumez@apple.com>
5351 URL set by document.open() is not communicated to the UIProcess
5352 https://bugs.webkit.org/show_bug.cgi?id=196941
5353 <rdar://problem/49237544>
5355 Reviewed by Geoffrey Garen.
5357 Add API test coverage.
5359 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
5360 * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
5361 * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
5362 (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
5365 2019-04-15 Dean Johnson <dean_johnson@apple.com>
5367 Using Tools/Scripts/clean-webkit should not install requests
5368 https://bugs.webkit.org/show_bug.cgi?id=196940
5370 Reviewed by Lucas Forschler.
5372 * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
5373 existing, depending on the path autoinstalled is run through.
5374 * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
5376 (Port.configuration_for_upload):
5377 (Port.commits_for_upload):
5379 2019-04-15 Alex Christensen <achristensen@webkit.org>
5381 Add a DiagnosticLogging method taking an arbitrary dictionary of values.
5382 https://bugs.webkit.org/show_bug.cgi?id=196773
5384 Reviewed by Jer Noble.
5386 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
5387 (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
5390 2019-04-15 Aakash Jain <aakash_jain@apple.com>
5392 ews-build should clearly indicate flaky test failures
5393 https://bugs.webkit.org/show_bug.cgi?id=196947
5395 Reviewed by Lucas Forschler.
5397 * BuildSlaveSupport/ews-build/steps.py:
5398 (AnalyzeAPITestsResults.analyzeResults):
5400 2019-04-15 Brent Fulgham <bfulgham@apple.com>
5402 InjectedBundle parameters often need initialization function called before unarchiving
5403 https://bugs.webkit.org/show_bug.cgi?id=189709
5404 <rdar://problem/44573653>
5406 Reviewed by Ryosuke Niwa.
5408 * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
5409 (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
5411 2019-04-12 Ryosuke Niwa <rniwa@webkit.org>
5413 HashTable::removeIf always shrinks the hash table by half even if there is nothing left
5414 https://bugs.webkit.org/show_bug.cgi?id=196681
5416 Reviewed by Darin Adler.
5420 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
5421 (WTF_HashSet.RemoveIf):
5422 (WTF_HashSet.RemoveIfShrinkToBestSize):
5424 2019-04-15 John Wilander <wilander@apple.com>
5426 Send delayed Ad Click Attribution conversion requests to the click source
5427 https://bugs.webkit.org/show_bug.cgi?id=196838
5428 <rdar://problem/47650157>
5430 Reviewed by Chris Dumez and Youenn Fablet.
5432 This patch adds test infrastructure to override the default behavior in
5433 WebKit::NetworkAdClickAttribution.
5435 * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
5436 (TestWebKitAPI::TEST):
5437 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
5438 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
5439 (WTR::TestRunner::dumpAdClickAttribution):
5440 (WTR::TestRunner::clearAdClickAttribution):
5441 (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
5442 (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
5443 * WebKitTestRunner/InjectedBundle/TestRunner.h:
5444 * WebKitTestRunner/TestController.cpp:
5445 (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
5446 (WTR::TestController::setAdClickAttributionConversionURLForTesting):
5447 * WebKitTestRunner/TestController.h:
5448 * WebKitTestRunner/TestInvocation.cpp:
5449 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
5451 2019-04-15 Aakash Jain <aakash_jain@apple.com>
5453 [ews-app] status-bubble should display position in queue
5454 https://bugs.webkit.org/show_bug.cgi?id=196607
5456 Reviewed by Lucas Forschler.
5458 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
5459 (StatusBubble._build_bubble):
5460 (StatusBubble._queue_position): Method to calculate patch's position in queue.
5462 2019-04-15 Aakash Jain <aakash_jain@apple.com>
5464 [ews-build] Do not run clean build by default on EWS builders
5465 https://bugs.webkit.org/show_bug.cgi?id=196897
5467 Reviewed by Lucas Forschler.
5469 * BuildSlaveSupport/ews-build/steps.py:
5470 (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
5471 file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing
5472 untracked directories like WebKitBuild).
5473 (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
5474 untracked files/directories (like WebKitBuild).
5476 2019-04-15 Per Arne Vollan <pvollan@apple.com>
5478 TestRunner::notifyDone() should be safely reentrant
5479 https://bugs.webkit.org/show_bug.cgi?id=196898
5481 Reviewed by Darin Adler.
5483 It is currently possible that TestRunner::notifyDone() will call itself, since
5484 notifyDone() will force a repaint, which can start executing JavaScript, which
5485 may call notifyDone() again. This can lead to test failures and flakiness.
5486 Fix this by setting the m_waitToDump flag before calling the dump() method.
5488 * DumpRenderTree/mac/TestRunnerMac.mm:
5489 (TestRunner::notifyDone):
5490 (TestRunner::forceImmediateCompletion):
5491 * DumpRenderTree/win/TestRunnerWin.cpp:
5492 (TestRunner::notifyDone):
5493 (TestRunner::forceImmediateCompletion):
5495 2019-04-15 Philippe Normand <pnormand@igalia.com>
5497 [GTK][WPE] Add enable-media websetting
5498 https://bugs.webkit.org/show_bug.cgi?id=196863
5500 Reviewed by Michael Catanzaro.
5502 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
5503 (testWebKitSettings): Add test for the enable-media web-setting.
5505 2019-04-14 Wenson Hsieh <wenson_hsieh@apple.com>
5507 API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
5508 https://bugs.webkit.org/show_bug.cgi?id=196905
5509 <rdar://problem/49886096>
5511 Reviewed by Tim Horton.
5513 This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
5514 process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
5515 Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
5516 delay timer, we end up with this sequence of events in the problematic (failure) case:
5518 (a) [UI] Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
5519 ...IPC from UI to web process...
5520 (b) [Web] Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
5521 ...IPC from web to UI process...
5522 (c) [UI] Invoke completion handler for script #1
5523 (d) [UI] Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
5524 ...IPC from UI to web process...
5525 (e) [Web] Evaluate script #2 in the web process
5526 (f) [Web] Zero-delay timer fires and dispatches attachment updates to the UI process
5528 ...which means that script #2 will complete before the UI process has received the attachment updates sent in
5529 step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
5530 #2 is run in step (e).
5532 This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
5533 the UI process by waiting on a script message posted by the web process, after attachment updates are
5536 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
5537 (TestWebKitAPI::TEST):
5539 2019-04-14 Aakash Jain <aakash_jain@apple.com>
5541 Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
5542 https://bugs.webkit.org/show_bug.cgi?id=196909
5544 Reviewed by Wenson Hsieh.
5546 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
5547 (TestWebKitAPI::TEST):
5549 2019-04-13 Tadeu Zagallo <tzagallo@apple.com>
5551 CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
5552 https://bugs.webkit.org/show_bug.cgi?id=196880
5554 Reviewed by Yusuke Suzuki.
5556 Add a new function for bytecode cache tests that does not forceDiskCache
5557 for the second run: runBytecodeCacheNoAssetion. This is necessary for the
5558 test added in this patch, since the code is invalid and therefore won't be
5559 cached. It should also be useful for tests that evaluate dynamically
5562 * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
5563 * Scripts/run-jsc-stress-tests:
5565 2019-04-12 Eric Carlson <eric.carlson@apple.com>
5567 Update AudioSession route sharing policy
5568 https://bugs.webkit.org/show_bug.cgi?id=196776
5569 <rdar://problem/46501611>
5571 Reviewed by Jer Noble.
5573 * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
5574 (TestWebKitAPI::routeSharingPolicyLongFormVideo):
5575 (TestWebKitAPI::routeSharingPolicyLongFormAudio):
5576 (TestWebKitAPI::TEST):
5578 2019-04-12 Wenson Hsieh <wenson_hsieh@apple.com>
5580 [iOS] Software keyboard is shown too frequently on some websites
5581 https://bugs.webkit.org/show_bug.cgi?id=195856
5582 <rdar://problem/49191395>
5584 Reviewed by Darin Adler.
5586 Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
5588 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
5589 (WTR::UIScriptController::setHardwareKeyboardAttached):
5590 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
5591 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
5592 (WTR::UIScriptController::setHardwareKeyboardAttached):
5593 * TestRunnerShared/UIScriptContext/UIScriptController.h:
5594 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
5596 Additionally link against GraphicsServices in WebKitTestRunner.
5598 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
5599 (WTR::TestController::platformResetStateToConsistentValues):
5600 (WTR::UIScriptController::setHardwareKeyboardAttached):
5602 2019-04-12 Ludovico de Nittis <ludovico.denittis@collabora.com>
5604 [GTK][WPE] Fix pacman install-dependencies packages
5605 https://bugs.webkit.org/show_bug.cgi?id=196817
5607 Reviewed by Žan Doberšek.
5609 python3-setuptools is called python-setuptools
5610 ruby-highline is only available on AUR
5611 libv4l-devel is incorporated in v4l-utils
5613 * gtk/install-dependencies:
5614 * wpe/install-dependencies:
5616 2019-04-11 Carlos Garcia Campos <cgarcia@igalia.com>
5618 [GTK] REGRESSION(r243860): Many tests failing
5619 https://bugs.webkit.org/show_bug.cgi?id=196791
5621 Reviewed by Joanmarie Diggs.
5623 Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
5624 multiple documents and check that accessibility hierarchy is updated after a navigation.
5626 * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
5627 (loadChangedCallback):
5628 * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
5629 (AccessibilityTest::AccessibilityTest):
5630 (AccessibilityTest::~AccessibilityTest):
5631 (AccessibilityTest::loadHTMLAndWaitUntilFinished):
5632 (AccessibilityTest::findTestServerApplication):
5633 (AccessibilityTest::findDocumentWeb):
5634 (AccessibilityTest::findRootObject):
5635 (AccessibilityTest::waitUntilChildrenRemoved):
5636 (AccessibilityTest::ensureProxy):
5637 (testAtspiBasicHierarchy):
5641 2019-04-11 Aakash Jain <aakash_jain@apple.com>
5643 [ews-build] Handle bug titles with unicode characters
5644 https://bugs.webkit.org/show_bug.cgi?id=196802
5646 Reviewed by Dewei Zhu.
5648 * BuildSlaveSupport/ews-build/steps.py:
5649 (ValidatePatch._is_bug_closed):
5651 2019-04-11 Michael Saboff <msaboff@apple.com>
5653 Improve the Inline Cache Stats code
5654 https://bugs.webkit.org/show_bug.cgi?id=196836
5656 Reviewed by Saam Barati.
5658 Added a new script to consolidate and arrange the output of --useICStats option.
5660 This script merges the output from every group into one large table and sorts it from most common to
5661 least common. It also counts the slow path GetById and PutById variants and then calculates the
5662 percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
5663 Put together, this is useful to see what property accesses are not getting cached.
5665 * Scripts/ic-stats.py: Added.
5669 (ICStats.dumpStats):
5672 2019-04-10 Alex Christensen <achristensen@webkit.org>
5674 WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
5675 https://bugs.webkit.org/show_bug.cgi?id=196809
5678 Reviewed by Brady Eidson.
5680 * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
5683 2019-04-10 Said Abou-Hallawa <sabouhallawa@apple.com>
5685 requestAnimationFrame should execute before the next frame
5686 https://bugs.webkit.org/show_bug.cgi?id=177484
5688 Reviewed by Simon Fraser.
5690 Add trace points for the page RenderingUpdate.
5692 * Tracing/SystemTracePoints.plist:
5694 2019-04-10 Fujii Hironori <Hironori.Fujii@sony.com>
5696 [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
5697 https://bugs.webkit.org/show_bug.cgi?id=196760
5699 Reviewed by Don Olmstead.
5701 vswhere.exe has been bundled since Visual Studio 2017 version
5702 15.2. We shouldn't download vswhere.exe.
5704 * Scripts/build-jsc: Do not call update-vswhere.py.
5705 * Scripts/build-webkit: Ditto.
5706 * Scripts/update-vswhere.py: Removed.
5707 * Scripts/webkitdirs.pm:
5708 (requireModulesForVSWhere): Deleted.
5709 (pickCurrentVisualStudioInstallation): Deleted.
5710 (visualStudioInstallDirVSWhere): Return the latest installed VS
5711 installation path by using the bundled vswhere.exe.
5712 (setupCygwinEnv): Removed a unused variable $visualStudioPath.
5713 (visualStudioInstallDirFallback): Removed.
5715 2019-04-10 Aakash Jain <aakash_jain@apple.com>
5717 [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
5718 https://bugs.webkit.org/show_bug.cgi?id=196780
5720 Reviewed by Alexey Proskuryakov.
5722 * BuildSlaveSupport/ews-build/steps.py:
5723 * BuildSlaveSupport/ews-build/steps_unittest.py:
5725 2019-04-10 Alex Christensen <achristensen@webkit.org>
5727 Add SPI WKNavigationResponse._downloadAttribute
5728 https://bugs.webkit.org/show_bug.cgi?id=196755
5731 Reviewed by Brady Eidson.
5733 * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
5734 (-[NavigationResponseTestDelegate navigationResponse]):
5735 (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
5736 (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
5737 (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
5738 (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
5739 (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
5744 2019-04-10 Tim Horton <timothy_horton@apple.com>
5746 Add modern API for overriding the page's specified viewport configuration
5747 https://bugs.webkit.org/show_bug.cgi?id=167734
5748 <rdar://problem/30331795>
5750 Reviewed by Simon Fraser.
5752 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
5753 * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
5755 2019-04-10 Tadeu Zagallo <tzagallo@apple.com>
5757 Add support for incremental bytecode cache updates
5758 https://bugs.webkit.org/show_bug.cgi?id=195000
5760 Reviewed by Filip Pizlo.
5762 Exit when the initial run to generate bytecode fails.
5764 * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
5766 2019-04-10 Alex Christensen <achristensen@webkit.org>
5768 RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
5769 https://bugs.webkit.org/show_bug.cgi?id=196744
5772 Reviewed by Chris Dumez.
5774 * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
5775 (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
5777 2019-04-10 Wenson Hsieh <wenson_hsieh@apple.com>
5779 Add a way to opt into modern compatibility mode in layout tests
5780 https://bugs.webkit.org/show_bug.cgi?id=196770
5781 <rdar://problem/49777550>
5783 Reviewed by Antoine Quint.
5785 Add a new test option to enable modern compatibility mode in layout tests.
5787 * WebKitTestRunner/TestController.cpp:
5788 (WTR::updateTestOptionsFromTestHeader):
5789 * WebKitTestRunner/TestController.h:
5790 * WebKitTestRunner/TestOptions.h:
5791 (WTR::TestOptions::hasSameInitializationOptions const):
5792 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
5793 (WTR::TestController::platformCreateWebView):
5794 (WTR::TestController::enableModernCompatibilityMode):
5796 2019-04-10 Andy Estes <aestes@apple.com>
5798 Try to fix the 32-bit watchOS build.
5800 * TestWebKitAPI/cocoa/TestWKWebView.mm:
5801 (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
5803 2019-04-10 Antoine Quint <graouts@apple.com>
5805 Enable Pointer Events on watchOS
5806 https://bugs.webkit.org/show_bug.cgi?id=196771
5807 <rdar://problem/49040909>
5809 Reviewed by Dean Jackson.
5811 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
5813 2019-04-10 Philippe Normand <pnormand@igalia.com>
5815 Unreviewed. Fix WPE accessibility tests after r244059.
5817 We are failing to load the injected bundle due to undefined symbol
5818 AccessibilityUIElement::replaceTextInRange().
5820 * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
5821 (WTR::AccessibilityUIElement::replaceTextInRange):
5823 2019-04-10 Takashi Komori <Takashi.Komori@sony.com>
5825 [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
5826 https://bugs.webkit.org/show_bug.cgi?id=196727
5828 Reviewed by Fujii Hironori.
5830 * MiniBrowser/win/WebKitBrowserWindow.cpp:
5831 (WebKitBrowserWindow::create):
5833 2019-04-09 Aakash Jain <aakash_jain@apple.com>
5835 [ews-build] Add unit tests for PrintConfiguration
5836 https://bugs.webkit.org/show_bug.cgi?id=196752
5838 Reviewed by Dewei Zhu.
5840 * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
5842 2019-04-09 Keith Rollin <krollin@apple.com>
5844 Unreviewed build maintenance -- update .xcfilelists.
5846 * DumpRenderTree/DerivedSources-input.xcfilelist:
5847 * DumpRenderTree/DerivedSources-output.xcfilelist:
5849 2019-04-09 Zalan Bujtas <zalan@apple.com>
5851 [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
5852 https://bugs.webkit.org/show_bug.cgi?id=196743
5853 <rdar://problem/43897551>
5855 Reviewed by Tim Horton.
5857 * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
5860 2019-04-09 Youenn Fablet <youenn@apple.com>
5862 Close service worker database on network process suspension
5863 https://bugs.webkit.org/show_bug.cgi?id=196623
5864 <rdar://problem/48930869>
5866 Reviewed by Alex Christensen.
5868 * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
5870 2019-04-09 Daniel Bates <dabates@apple.com>
5872 [iPad] Should open popover when the spacebar is pressed
5873 https://bugs.webkit.org/show_bug.cgi?id=196360
5874 <rdar://problem/49389129>
5876 Reviewed by Brent Fulgham.
5878 Add testing infrastructure to support waiting for a popover to be presented or dismissed.
5880 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
5881 (WTR::UIScriptController::isShowingPopover const): Added.
5882 (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
5883 (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
5884 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
5885 * TestRunnerShared/UIScriptContext/UIScriptContext.h:
5886 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
5887 (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
5888 (WTR::UIScriptController::willPresentPopoverCallback const): Added.
5889 (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
5890 (WTR::UIScriptController::didDismissPopoverCallback const): Added.
5891 (WTR::UIScriptController::isShowingPopover const): Added.
5892 (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
5893 (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
5894 * TestRunnerShared/UIScriptContext/UIScriptController.h:
5895 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
5896 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
5897 (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
5898 (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
5899 (-[TestRunnerWKWebView _willPresentPopover]): Added.
5900 (-[TestRunnerWKWebView _didDismissPopover]): Added.
5901 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
5902 (WTR::UIScriptController::isShowingPopover const): Added.
5903 (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
5904 (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
5906 2019-04-09 Alex Christensen <achristensen@webkit.org>
5908 Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
5909 https://bugs.webkit.org/show_bug.cgi?id=196665
5912 Reviewed by Geoff Garen.
5914 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
5916 (+[SimpleLookupContext sharedLookupContext]):
5917 (-[SimpleLookupContext lookUpURL:completionHandler:]):
5919 (+[Simple3LookupContext sharedLookupContext]): Deleted.
5920 (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
5922 2019-04-09 John Wilander <wilander@apple.com>
5924 Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
5925 https://bugs.webkit.org/show_bug.cgi?id=196558
5926 <rdar://problem/47650245>
5928 Reviewed by Youenn Fablet.
5930 * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
5931 (TestWebKitAPI::TEST):
5932 Added tests of WebCore::AdClickAttribution::parseConversionRequest().
5934 2019-04-09 Don Olmstead <don.olmstead@sony.com>
5936 [CMake] Apple builds should use ICU_INCLUDE_DIRS
5937 https://bugs.webkit.org/show_bug.cgi?id=196720
5939 Reviewed by Konstantin Tokarev.
5941 * TestWebKitAPI/PlatformMac.cmake:
5943 2019-04-09 Jonathan Bedard <jbedard@apple.com>
5945 iOS 12 Simulator Release WK2 frequently timing out while running layout tests
5946 https://bugs.webkit.org/show_bug.cgi?id=196694
5947 <rdar://problem/48388734>
5949 Rubber-stamped by Aakash Jain.
5951 * Scripts/webkitpy/port/image_diff.py:
5952 (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
5953 * Scripts/webkitpy/port/server_process.py:
5954 (ServerProcess.has_available_stdout): Check if stdout has data in it.
5955 (ServerProcess._wait_for_data_and_update_buffers_using_select):
5956 (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
5957 * Scripts/webkitpy/port/server_process_mock.py:
5958 (MockServerProcess.has_available_stdout):
5959 * Scripts/webkitpy/port/server_process_unittest.py:
5960 (TestServerProcess.serial_test_basic):
5962 2019-04-09 Jer Noble <jer.noble@apple.com>
5964 Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
5965 https://bugs.webkit.org/show_bug.cgi?id=196097
5967 Reviewed by Eric Carlson.
5969 Drive-by bug fix: allow tests to play audio without a user gesture by default.
5971 * DumpRenderTree/mac/DumpRenderTree.mm:
5972 (resetWebPreferencesToConsistentValues):
5973 * WebKitTestRunner/TestController.cpp:
5974 (WTR::TestController::resetPreferencesToConsistentValues):
5976 2019-04-09 Pablo Saavedra <psaavedra@igalia.com>
5978 [JSCOnly] Add an i386 JSCOnly EWS that runs tests
5979 https://bugs.webkit.org/show_bug.cgi?id=196690
5981 Reviewed by Michael Catanzaro.
5983 * QueueStatusServer/config/queues.py:
5984 * Scripts/webkitpy/common/config/ews.json:
5985 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
5988 2019-04-09 Chris Dumez <cdumez@apple.com>
5990 Loads using loadHTMLString() cause flashing when process-swapping
5991 https://bugs.webkit.org/show_bug.cgi?id=196714
5992 <rdar://problem/49637354>
5994 Reviewed by Antti Koivisto.
5996 Add API test coverage.
5998 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
6000 2019-04-09 Carlos Garcia Campos <cgarcia@igalia.com>
6002 Unreviewed. Fix ATK accessibility tests after r244059.
6004 We are failing to load the injected bundle due to undefined symbol
6005 AccessibilityUIElement::replaceTextInRange().
6007 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
6008 (WTR::AccessibilityUIElement::replaceTextInRange):
6010 2019-04-08 Fujii Hironori <Hironori.Fujii@sony.com>
6012 AX: Support API: accessibilityReplaceRange:withText
6013 https://bugs.webkit.org/show_bug.cgi?id=196636
6015 Unreviewed build fix for Windows port.
6017 * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
6018 (WTR::AccessibilityUIElement::replaceTextInRange): Added.
6020 2019-04-08 Don Olmstead <don.olmstead@sony.com>
6022 [CMake][WinCairo] Separate copied headers into different directories
6023 https://bugs.webkit.org/show_bug.cgi?id=196655
6025 Reviewed by Michael Catanzaro.
6027 * DumpRenderTree/CMakeLists.txt:
6028 * MiniBrowser/win/CMakeLists.txt:
6029 * TestWebKitAPI/CMakeLists.txt:
6030 * TestWebKitAPI/PlatformWin.cmake:
6032 2019-04-08 Jonathan Bedard <jbedard@apple.com>
6034 Log stack-trace for run-webkit-tests when interrupted
6035 https://bugs.webkit.org/show_bug.cgi?id=176393
6036 <rdar://problem/34262310>
6038 Reviewed by Lucas Forschler.
6040 * Scripts/webkitpy/common/interrupt_debugging.py: Added.
6041 (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
6042 (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file.
6043 (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
6044 (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced.
6045 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
6046 (main): Set handlers to log stack trace on interruption.
6048 2019-04-08 Fujii Hironori <Hironori.Fujii@sony.com>
6050 AX: Support API: accessibilityReplaceRange:withText
6051 https://bugs.webkit.org/show_bug.cgi?id=196636
6053 Unreviewed build fix for Windows port.
6055 * DumpRenderTree/AccessibilityUIElement.cpp:
6056 (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
6058 2019-04-08 Aakash Jain <aakash_jain@apple.com>
6060 [ews-build] Scripts using Buildbot API have CORS error
6061 https://bugs.webkit.org/show_bug.cgi?id=196709
6063 Reviewed by Alexey Proskuryakov.
6065 * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
6067 2019-04-08 Chris Fleizach <cfleizach@apple.com>
6069 AX: Support API: accessibilityReplaceRange:withText
6070 https://bugs.webkit.org/show_bug.cgi?id=196636
6072 Reviewed by Daniel Bates.
6074 * DumpRenderTree/AccessibilityUIElement.cpp:
6075 (replaceTextInRangeCallback):
6076 (AccessibilityUIElement::replaceTextInRange):
6077 (AccessibilityUIElement::getJSClass):
6078 * DumpRenderTree/AccessibilityUIElement.h:
6079 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
6080 (AccessibilityUIElement::replaceTextInRange):
6081 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
6082 (AccessibilityUIElement::replaceTextInRange):
6083 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
6084 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
6085 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
6086 (WTR::AccessibilityUIElement::replaceTextInRange):
6087 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
6088 (WTR::AccessibilityUIElement::replaceTextInRange):
6090 2019-04-08 Wenson Hsieh <wenson_hsieh@apple.com>
6092 [iOS] Do not allow starting selection drags when selection views are not visible
6093 https://bugs.webkit.org/show_bug.cgi?id=196686
6094 <rdar://problem/49399192>
6096 Reviewed by Tim Horton.
6098 Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
6099 also add some new API tests to cover scenarios where the web view is not first responder.
6101 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
6102 (TestWebKitAPI::TEST):
6103 * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
6105 Add a switch to optionally make the web view first responder when starting the simulated drag.
6107 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
6108 (-[DragAndDropSimulator initWithWebView:]):
6109 (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
6111 2019-04-08 Justin Fan <justin_fan@apple.com>
6113 [Web GPU] Fix Web GPU experimental feature on iOS
6114 https://bugs.webkit.org/show_bug.cgi?id=196632
6116 Reviewed by Myles C. Maxfield.
6118 Properly make Web GPU available on iOS 11+.
6120 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
6122 2019-04-08 Aakash Jain <aakash_jain@apple.com>
6124 [ews-build] Do not upload archive when Compile Fails
6125 https://bugs.webkit.org/show_bug.cgi?id=196674
6127 Reviewed by Alexey Proskuryakov.
6129 * BuildSlaveSupport/ews-build/factories.py:
6130 (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
6131 * BuildSlaveSupport/ews-build/steps.py:
6132 (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
6133 (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it
6134 doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
6136 2019-04-08 Guillaume Emont <guijemont@igalia.com>
6139 https://bugs.webkit.org/show_bug.cgi?id=196689
6141 Reviewed by Žan Doberšek.
6143 Since the bytecode change, we enabled the baseline JIT on mips in
6144 r240432, but DFG is still missing. With this change, all tests are
6145 passing on a ci20 board.
6147 * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
6149 2019-04-08 Philippe Normand <pnormand@igalia.com>
6151 [Flatpak] Second run update-webkitwpe-flatpak fails
6152 https://bugs.webkit.org/show_bug.cgi?id=192702
6154 Reviewed by Carlos Garcia Campos.
6156 * flatpak/flatpakutils.py:
6157 (FlatpakObject.flatpak): Fix typo.
6158 (FlatpakPackage.install): When installing, also update to the configured remote commit.
6159 * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
6161 2019-04-05 Sergio Villar Senin <svillar@igalia.com>
6163 [GTK][WPE] outlook.live.com displays old-fashioned UI
6164 https://bugs.webkit.org/show_bug.cgi?id=196642
6166 Reviewed by Carlos Garcia Campos.
6168 * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
6169 (TestWebKitAPI::TEST): New Mac platform quirk test.
6171 2019-04-07 Commit Queue <commit-queue@webkit.org>
6173 Unreviewed, rolling out r243956.
6174 https://bugs.webkit.org/show_bug.cgi?id=196688
6176 Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
6177 by aakashjain on #webkit).
6181 "Clicking "Go Back" from a safe browsing warning from an
6182 iframe should navigate the WKWebView back to the previous
6184 https://bugs.webkit.org/show_bug.cgi?id=196665
6185 https://trac.webkit.org/changeset/243956
6187 2019-04-06 Ryosuke Niwa <rniwa@webkit.org>
6189 Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
6190 https://bugs.webkit.org/show_bug.cgi?id=196669
6192 Reviewed by Geoffrey Garen.
6194 Added three new unit tests for WeakHashSet.
6196 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
6197 (WTF_WeakPtr.WeakHashSetConstObjects):
6198 (WTF_WeakPtr.WeakHashSetComputesEmpty):
6199 (WTF_WeakPtr.WeakHashSetComputeSize):
6201 2019-04-06 Wenson Hsieh <wenson_hsieh@apple.com>
6203 Hide next and previous form control buttons when WKWebView is editable
6204 https://bugs.webkit.org/show_bug.cgi?id=196672
6205 <rdar://problem/35625321>
6207 Reviewed by Tim Horton.
6211 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
6212 (-[TestWKWebView lastTrailingBarButtonGroup]):
6213 (TestWebKitAPI::TEST):
6214 * TestWebKitAPI/ios/UIKitSPI.h:
6216 2019-04-05 Yongjun Zhang <yongjun_zhang@apple.com>
6218 We should pass minimumEffectiveDeviceWidth to web process on new page creation.
6219 https://bugs.webkit.org/show_bug.cgi?id=196077
6220 <rdar://problem/49108202>
6222 Reviewed by Chris Dumez.
6224 Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
6227 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
6229 2019-04-05 Saam Barati <sbarati@apple.com>
6231 Make compare-results understand MotionMark
6232 https://bugs.webkit.org/show_bug.cgi?id=196666
6234 Reviewed by Yusuke Suzuki.
6236 * Scripts/compare-results:
6239 (detectMotionMark1_1):
6240 (motionMarkResults):
6241 (motionMark1_1Results):
6246 2019-04-05 Alex Christensen <achristensen@webkit.org>
6248 Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
6249 https://bugs.webkit.org/show_bug.cgi?id=196665
6252 Reviewed by Geoff Garen.
6254 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
6256 (+[SimpleLookupContext sharedLookupContext]):
6257 (-[SimpleLookupContext lookUpURL:completionHandler:]):
6259 (+[Simple3LookupContext sharedLookupContext]): Deleted.
6260 (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
6262 2019-04-05 Aakash Jain <aakash_jain@apple.com>
6264 [ews-build] Add configuration and architecture for windows builders
6265 https://bugs.webkit.org/show_bug.cgi?id=196660
6267 Reviewed by Lucas Forschler.
6269 * BuildSlaveSupport/ews-build/config.json:
6271 2019-04-05 Jonathan Bedard <jbedard@apple.com>
6273 webkitpy: Don't run subsequent rounds if interrupted
6274 https://bugs.webkit.org/show_bug.cgi?id=196646
6276 Reviewed by Aakash Jain.
6278 * Scripts/webkitpy/layout_tests/controllers/manager.py:
6279 (Manager.run): Bail out if interrupted.
6281 2019-04-05 Sihui Liu <sihui_liu@apple.com>
6283 Test sessionStorage in PSON private browsing mode
6284 https://bugs.webkit.org/show_bug.cgi?id=196561
6286 Reviewed by Alex Christensen.
6288 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
6290 2019-04-05 Commit Queue <commit-queue@webkit.org>
6292 Unreviewed, rolling out r243833.
6293 https://bugs.webkit.org/show_bug.cgi?id=196645
6295 This change breaks build of WPE and GTK ports (Requested by
6296 annulen on #webkit).
6300 "[CMake][WTF] Mirror XCode header directories"
6301 https://bugs.webkit.org/show_bug.cgi?id=191662
6302 https://trac.webkit.org/changeset/243833
6304 2019-04-04 Simon Fraser <simon.fraser@apple.com>
6306 Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
6307 https://bugs.webkit.org/show_bug.cgi?id=196635
6309 Reviewed by Antti Koivisto.
6311 InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
6312 for a test to enable async frame scrolling via:
6313 <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
6314 so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
6316 Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
6318 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
6319 (WTR::InjectedBundle::beginTesting):
6320 * WebKitTestRunner/TestController.cpp:
6321 (WTR::TestController::resetPreferencesToConsistentValues):
6323 2019-04-04 Alexey Proskuryakov <ap@apple.com>
6325 Use a correct LC_RPATH when building with ASan
6326 https://bugs.webkit.org/show_bug.cgi?id=196576
6328 Reviewed by David Kilzer.
6330 * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
6331 so that ../Frameworks is checked. This is simpler and more reliable than updating
6332 each SPC service xcconfig.
6334 2019-04-04 Aakash Jain <aakash_jain@apple.com>
6336 Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
6337 https://bugs.webkit.org/show_bug.cgi?id=196629
6339 Reviewed by Lucas Forschler.
6341 * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
6343 2019-04-04 Aakash Jain <aakash_jain@apple.com>
6345 [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
6346 https://bugs.webkit.org/show_bug.cgi?id=196618
6348 Reviewed by Lucas Forschler.
6350 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
6351 (StatusBubble): Added QUEUE_TRIGGERS.
6352 (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
6353 (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
6354 (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
6355 its parent(builder).
6357 2019-04-04 Aakash Jain <aakash_jain@apple.com>
6359 [ews-app] Status-bubble steps are sometimes displayed in reverse order
6360 https://bugs.webkit.org/show_bug.cgi?id=196625
6362 Reviewed by Lucas Forschler.
6364 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
6365 (StatusBubble._steps_messages): Explicitly specify order_by('uid').
6367 2019-04-04 Aakash Jain <aakash_jain@apple.com>
6369 Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
6370 https://bugs.webkit.org/show_bug.cgi?id=196630
6372 Reviewed by Wenson Hsieh.
6374 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
6376 2019-04-04 Youenn Fablet <youenn@apple.com>
6378 Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
6379 https://bugs.webkit.org/show_bug.cgi?id=196543
6381 Reviewed by Alex Christensen.
6383 * WebKitTestRunner/TestController.cpp:
6384 (WTR::TestController::generatePageConfiguration):
6386 2019-04-04 Aakash Jain <aakash_jain@apple.com>
6388 [ews-app] Status bubble should not display skipped buildbot steps
6389 https://bugs.webkit.org/show_bug.cgi?id=196584
6391 Reviewed by Lucas Forschler.
6393 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
6395 2019-04-04 Aakash Jain <aakash_jain@apple.com>
6397 [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
6398 https://bugs.webkit.org/show_bug.cgi?id=196620
6400 Reviewed by Lucas Forschler.
6402 * BuildSlaveSupport/ews-app/ews/config.py:
6404 2019-04-04 Per Arne Vollan <pvollan@apple.com>
6406 [Win] DumpRenderTreeWatchDog.py is not checked into source
6407 https://bugs.webkit.org/show_bug.cgi?id=196567
6408 <rdar://problem/49525901>
6410 Reviewed by Lucas Forschler.
6412 This script is used on Win EWS bots to terminate hanging DRT processes.
6414 * EWSTools/dumprendertreewatchdog.py: Added.
6416 2019-04-04 Chris Dumez <cdumez@apple.com>
6418 Unreviewed, roll out r243858 which made tests time out.
6420 Disable new API tests on Windows instead.
6422 * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
6423 (TestWebKitAPI::TEST):
6425 2019-04-03 Carlos Garcia Campos <cgarcia@igalia.com>
6427 [ATK] Cleanup WebPageAccessibilityObjectAtk
6428 https://bugs.webkit.org/show_bug.cgi?id=196537
6430 Reviewed by Michael Catanzaro.
6432 Also consider files under atk directories as exceptions for GObject conventions.
6434 * Scripts/webkitpy/style/checkers/cpp.py:
6435 (check_identifier_name_in_declaration):
6437 2019-04-03 Fujii Hironori <Hironori.Fujii@sony.com>
6439 The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
6440 https://bugs.webkit.org/show_bug.cgi?id=196588
6441 <rdar://problem/49365787>
6443 Unreviewed build fix for Windows port.
6445 error C3861: 'kill': identifier not found
6447 * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
6448 (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
6450 2019-04-03 Aakash Jain <aakash_jain@apple.com>
6452 [ews-build] Cancel build and similar operations should have authentication
6453 https://bugs.webkit.org/show_bug.cgi?id=196520
6455 Reviewed by Dewei Zhu.
6457 * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
6458 environment variables.
6460 2019-04-03 Aakash Jain <aakash_jain@apple.com>
6462 [ews-build] Do not trigger queues which are not in production yet
6463 https://bugs.webkit.org/show_bug.cgi?id=196581
6465 Reviewed by Dewei Zhu.
6467 * BuildSlaveSupport/ews-build/config.json:
6469 2019-04-03 Chris Dumez <cdumez@apple.com>
6471 Unreviewed, fix typo in the name of API test added in r243848.
6473 * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
6474 (TestWebKitAPI::TEST):
6476 2019-04-03 Chris Dumez <cdumez@apple.com>
6478 The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
6479 https://bugs.webkit.org/show_bug.cgi?id=196588
6480 <rdar://problem/49365787>
6482 Reviewed by Ryosuke Niwa.
6484 Add API test coverage.
6486 * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
6487 (TestWebKitAPI::nullJavaScriptCallback):
6488 (TestWebKitAPI::didCrashCheckFrames):
6489 (TestWebKitAPI::TEST):
6491 2019-04-03 Jonathan Bedard <jbedard@apple.com>
6493 run-webkit-tests: Upload test results (new results database)
6494 https://bugs.webkit.org/show_bug.cgi?id=196577
6495 <rdar://problem/34841155>
6497 Reviewed by Lucas Forschler.
6499 * Scripts/webkitpy/layout_tests/controllers/manager.py:
6500 (Manager.run): Upload results after each device shard, since the configuration will be
6501 different for each device.
6502 (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
6503 uploaded to a results database.
6504 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
6505 (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
6507 2019-04-03 Myles C. Maxfield <mmaxfield@apple.com>
6509 -apple-trailing-word is needed for browser detection
6510 https://bugs.webkit.org/show_bug.cgi?id=196575
6514 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
6516 2019-04-03 Don Olmstead <don.olmstead@sony.com>
6518 [CMake][WTF] Mirror XCode header directories
6519 https://bugs.webkit.org/show_bug.cgi?id=191662
6521 Reviewed by Konstantin Tokarev.
6523 Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
6527 * DumpRenderTree/CMakeLists.txt:
6528 * DumpRenderTree/PlatformWin.cmake:
6529 * MiniBrowser/win/CMakeLists.txt:
6530 * TestWebKitAPI/CMakeLists.txt:
6531 * TestWebKitAPI/PlatformWin.cmake:
6532 * WebKitTestRunner/PlatformGTK.cmake:
6533 * WebKitTestRunner/PlatformWin.cmake:
6535 2019-04-03 Aakash Jain <aakash_jain@apple.com>
6537 [ews-app] Status bubble should not display certain infrastructure status messages
6538 https://bugs.webkit.org/show_bug.cgi?id=196550
6540 Reviewed by Lucas Forschler.
6542 Do not display the steps which are un-needed for end-user. This information is still avaiable
6543 if the user click on the bubble and look at the Buildbot build.
6544 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
6545 (StatusBubble._steps_messages):
6546 (StatusBubble._should_display_step): Method to decide whether to display the step or not.
6548 2019-04-03 Aakash Jain <aakash_jain@apple.com>
6550 [ews-build] Use https for sending data to ews-app
6551 https://bugs.webkit.org/show_bug.cgi?id=196492
6553 Reviewed by Lucas Forschler.
6555 * BuildSlaveSupport/ews-build/events.py:
6557 2019-04-03 Myles C. Maxfield <mmaxfield@apple.com>
6559 Remove support for -apple-trailing-word
6560 https://bugs.webkit.org/show_bug.cgi?id=196525
6562 Reviewed by Zalan Bujtas.
6564 This CSS property is nonstandard and not used.
6566 * Scripts/webkitperl/FeatureList.pm:
6567 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
6569 2019-04-03 Youenn Fablet <youenn@apple.com>
6571 Add a test for DOMCache on multiple browsing in case of private browsing
6572 https://bugs.webkit.org/show_bug.cgi?id=196524
6574 Reviewed by Alex Christensen.
6576 * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
6577 (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
6579 2019-04-03 Jonathan Bedard <jbedard@apple.com>
6581 [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
6582 https://bugs.webkit.org/show_bug.cgi?id=196540
6584 Reviewed by Aakash Jain.
6586 * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
6588 2019-04-03 Wenson Hsieh <wenson_hsieh@apple.com>
6590 Add plumbing for a compatibility mode preference in WebKit
6591 https://bugs.webkit.org/show_bug.cgi?id=196005
6593 Reviewed by Tim Horton.
6597 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
6598 * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
6600 2019-04-03 Claudio Saavedra <csaavedra@igalia.com>
6602 [WPE][GTK] Update libsrtp dependency package for Debian
6603 https://bugs.webkit.org/show_bug.cgi?id=196528
6605 Reviewed by Frédéric Wang.
6607 * gtk/install-dependencies:
6608 * wpe/install-dependencies:
6610 2019-04-02 Fujii Hironori <Hironori.Fujii@sony.com>
6612 [WK2] Add support for Window's beforeprint / afterprint events
6613 https://bugs.webkit.org/show_bug.cgi?id=196478
6614 <rdar://problem/49535124>
6616 Unreviewed build fix for MSVC.
6618 > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
6620 And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
6622 * WebKitTestRunner/TestController.cpp:
6623 (WTR::printFrame): Use int and float literals.
6625 2019-04-02 Aakash Jain <aakash_jain@apple.com>
6627 [ews-build] Reassign bots to queues
6629 * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
6631 2019-04-02 Chris Dumez <cdumez@apple.com>
6633 [WK2] Add support for Window's beforeprint / afterprint events
6634 https://bugs.webkit.org/show_bug.cgi?id=196478
6636 Reviewed by Alex Christensen.
6638 Add minimal implementation for printFrame in WebKitTestRunner.
6640 * WebKitTestRunner/TestController.cpp:
6642 (WTR::TestController::createOtherPage):
6643 (WTR::TestController::createWebViewWithOptions):
6645 2019-04-02 Aakash Jain <aakash_jain@apple.com>
6647 [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
6648 https://bugs.webkit.org/show_bug.cgi?id=196491
6650 Reviewed by Lucas Forschler.
6652 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
6654 2019-04-02 Aakash Jain <aakash_jain@apple.com>
6656 [ews-build] Configure buildbot try credentials in environment variables
6657 https://bugs.webkit.org/show_bug.cgi?id=196501
6659 Reviewed by Lucas Forschler.
6661 * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
6662 * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
6663 * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
6665 2019-04-02 Wenson Hsieh <wenson_hsieh@apple.com>
6667 REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
6668 https://bugs.webkit.org/show_bug.cgi?id=196496
6669 <rdar://problem/49521634>
6671 Reviewed by Chris Dumez.
6673 Add new API tests (see WebKit ChangeLog for more detail).
6675 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
6676 (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
6679 2019-04-02 David Kilzer <ddkilzer@apple.com>
6681 Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
6682 <https://webkit.org/b/196499>
6684 Reviewed by Alexey Proskuryakov.
6686 * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
6687 ENABLE_ADDRESS_SANITIZER.
6689 2019-04-02 Fujii Hironori <Hironori.Fujii@sony.com>
6691 [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
6692 https://bugs.webkit.org/show_bug.cgi?id=182757
6694 Reviewed by Don Olmstead.
6696 * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
6697 * TestWebKitAPI/PlatformWPE.cmake: Ditto.
6699 2019-04-01 Jonathan Bedard <jbedard@apple.com>
6701 run-api-tests: Upload test results
6702 https://bugs.webkit.org/show_bug.cgi?id=196323
6703 <rdar://problem/49356714>
6705 Reviewed by Lucas Forschler.
6707 * Scripts/webkitpy/api_tests/manager.py:
6709 (Manager.run): Upload results to a results database.
6710 * Scripts/webkitpy/api_tests/run_api_tests.py:
6711 (parse_args): Add upload arguments.
6712 * Scripts/webkitpy/port/base.py:
6714 (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
6715 (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
6716 with commits from any other associated repositories.
6717 * Scripts/webkitpy/port/device.py:
6719 (Device.build_version): Access build_versoin of underlying platform device.
6720 * Scripts/webkitpy/port/ios_simulator_unittest.py:
6722 (IOSSimulatorTest.test_configuration_for_upload):
6723 * Scripts/webkitpy/port/device_port.py:
6725 (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
6726 the same as the machine uploading results.
6727 * Scripts/webkitpy/port/mac.py:
6729 (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
6730 * Scripts/webkitpy/port/mac_unittest.py:
6732 (MacTest.test_configuration_for_upload):
6733 * Scripts/webkitpy/xcode/simulated_device.py:
6734 (SimulatedDeviceManager._create_device_with_runtime):
6735 (SimulatedDevice.__init__): Create simulated device with a build_version.
6736 * Scripts/webkitpy/xcode/simulated_device_unittest.py:
6737 (test_existing_simulator):
6739 2019-04-01 Aakash Jain <aakash_jain@apple.com>
6741 Remove extra newline characters (Follow-up fix to r243707)
6743 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
6745 2019-04-01 Aakash Jain <aakash_jain@apple.com>
6747 [ews-app] Use API_KEY to accept results data
6748 https://bugs.webkit.org/show_bug.cgi?id=196461
6750 Reviewed by Dewei Zhu.
6752 * BuildSlaveSupport/ews-app/ews/views/results.py:
6753 (Results.post): Validate EWS_API_KEY before accepting any data.
6754 * BuildSlaveSupport/ews-build/events.py:
6755 (Events.sendData): Send EWS_API_KEY if available along with event data.
6757 2019-04-01 Wenson Hsieh <wenson_hsieh@apple.com>
6759 Unable to copy and paste a PDF from Notes into Mail compose body
6760 https://bugs.webkit.org/show_bug.cgi?id=196442
6761 <rdar://problem/48573098>
6763 Reviewed by Tim Horton.
6765 Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
6766 existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
6767 to be specified on the item providers.
6769 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
6770 (TestWebKitAPI::mapItemForTesting):
6771 (TestWebKitAPI::contactItemForTesting):
6773 2019-04-01 Tim Horton <timothy_horton@apple.com>
6775 Make UIWKDocumentContext rects per-character instead of per-word
6776 https://bugs.webkit.org/show_bug.cgi?id=196459
6778 Reviewed by Wenson Hsieh.
6780 * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
6782 Adjust test results due to switching to per-character rects.
6784 2019-04-01 Chris Dumez <cdumez@apple.com>
6786 UIProcess crash when a prewarmed process is terminated
6787 https://bugs.webkit.org/show_bug.cgi?id=196451
6788 <rdar://problem/49245471>
6790 Reviewed by Geoffrey Garen.
6792 Add API test coverage.
6794 * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
6797 2019-04-01 Aakash Jain <aakash_jain@apple.com>
6799 [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
6800 https://bugs.webkit.org/show_bug.cgi?id=196449
6802 Reviewed by Lucas Forschler.
6804 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
6805 (StatusBubble.get_os_details): Method to get OS and Xcode details.
6806 (StatusBubble._build_bubble): Moved the timestamp logic to common method.
6807 (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
6809 2019-04-01 Aakash Jain <aakash_jain@apple.com>
6811 [ews-build] Remove force schedulers from OpenSource EWS Buildbot
6812 https://bugs.webkit.org/show_bug.cgi?id=196444
6814 Reviewed by Lucas Forschler.
6816 * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
6818 2019-04-01 Alex Christensen <achristensen@webkit.org>
6820 Add SPI to canonicalize NSURLs with WTF::URL
6821 https://bugs.webkit.org/show_bug.cgi?id=196415
6822 <rdar://problem/44980271>
6824 Reviewed by Darin Adler.
6826 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
6827 * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
6828 (TestWebKitAPI::TEST):
6830 2019-04-01 Zan Dobersek <zdobersek@igalia.com>
6832 [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
6833 https://bugs.webkit.org/show_bug.cgi?id=196441
6835 Reviewed by Carlos Garcia Campos.
6837 Don't cache the wpe_view_backend object that might not exist yet at the
6838 time of EventSenderProxy constructor invocation, but instead retrieve
6839 that object whenever it's required for event dispatching. This should
6840 avoid crashes in this constructor now that it's invoked before any
6841 PlatformWindow has been set up (as changed in r243496).
6843 * WebKitTestRunner/EventSenderProxy.h:
6844 * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
6846 (WTR::EventSenderProxy::EventSenderProxy):
6847 (WTR::EventSenderProxy::mouseDown):
6848 (WTR::EventSenderProxy::mouseUp):
6849 (WTR::EventSenderProxy::mouseMoveTo):
6850 (WTR::EventSenderProxy::mouseScrollBy):
6851 (WTR::EventSenderProxy::keyDown):
6852 (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
6854 2019-03-31 Fujii Hironori <Hironori.Fujii@sony.com>
6856 [Win][WebKit] MiniBrowser should support high DPI display
6857 https://bugs.webkit.org/show_bug.cgi?id=196391
6859 Reviewed by Alex Christensen.
6861 * MiniBrowser/win/WebKitBrowserWindow.cpp:
6862 (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
6863 (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
6864 * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
6866 2019-03-31 Sam Weinig <weinig@apple.com>
6868 Remove more i386 specific configurations
6869 https://bugs.webkit.org/show_bug.cgi?id=196430
6871 Reviewed by Alexey Proskuryakov.
6873 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
6874 ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
6876 2019-03-31 Andy Estes <aestes@apple.com>
6878 [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
6879 https://bugs.webkit.org/show_bug.cgi?id=196433
6880 <rdar://problem/49293305>
6882 Reviewed by Tim Horton.
6884 Enhanced API test coverage to include all navigation response policy decisions in both
6885 linked-before and linked-on-or-after modes. Also added new expectations for all tests.
6887 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
6888 * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
6889 (TestWebKitAPI::TEST):
6890 * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
6892 (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
6893 (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
6894 (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
6895 (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
6896 (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
6897 (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
6898 (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
6899 (-[QuickLookDelegate _downloadDidStart:]):
6900 (-[QuickLookDelegate _download:didReceiveResponse:]):
6901 (-[QuickLookDelegate _download:didReceiveData:]):
6902 (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
6903 (-[QuickLookDelegate _downloadDidFinish:]):
6904 (-[QuickLookDelegate _download:didFailWithError:]):
6905 (-[QuickLookDelegate _downloadDidCancel:]):
6906 (-[QuickLookDelegate verifyDownload]):
6908 (runTestDecideBeforeLoading):
6909 (runTestDecideAfterLoading):
6911 (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
6912 (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
6913 (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
6914 (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
6915 (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
6916 (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
6917 (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
6918 (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
6919 (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
6920 (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
6921 (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
6922 (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
6923 (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
6924 (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
6926 2019-03-30 Dominik Infuehr <dinfuehr@igalia.com>
6928 [CMake] add testdfg as target with build-jsc
6929 https://bugs.webkit.org/show_bug.cgi?id=196393
6931 Reviewed by Saam Barati.
6933 Added testdfg as one of the targets to build when
6936 * Scripts/build-jsc:
6938 2019-03-29 Myles C. Maxfield <mmaxfield@apple.com>
6940 Delete WebMetal implementation in favor of WebGPU
6941 https://bugs.webkit.org/show_bug.cgi?id=195418
6943 Reviewed by Dean Jackson.
6945 * DumpRenderTree/mac/DumpRenderTree.mm:
6946 (enableExperimentalFeatures):
6947 (resetWebPreferencesToConsistentValues):
6948 * Scripts/webkitperl/FeatureList.pm:
6949 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
6950 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
6951 * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
6952 * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
6953 * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
6954 * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
6955 * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
6956 * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
6957 * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
6958 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
6959 (WTR::InjectedBundle::beginTesting):
6960 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
6961 (WTR::TestRunner::setWebMetalEnabled): Deleted.
6962 * WebKitTestRunner/InjectedBundle/TestRunner.h:
6964 2019-03-29 Chris Dumez <cdumez@apple.com>
6966 REGRESSION (r243523): Six form-related watchOS layout tests are timing out
6967 https://bugs.webkit.org/show_bug.cgi?id=196405
6968 <rdar://problem/49428130>
6970 Reviewed by Wenson Hsieh.
6972 Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
6973 the popover presentation methods to be no-ops. Use this in the new test added in
6974 r243523 so that we do not swizzle those methods for all tests. This is needed because
6975 those WatchOS tests rely on the popover getting presented and interactive.
6977 * WebKitTestRunner/TestController.cpp:
6978 (WTR::updateTestOptionsFromTestHeader):
6979 * WebKitTestRunner/TestController.h:
6980 * WebKitTestRunner/TestOptions.h:
6981 (WTR::TestOptions::hasSameInitializationOptions const):
6982 * WebKitTestRunner/ios/TestControllerIOS.mm:
6983 (WTR::TestController::platformInitialize):
6984 (WTR::TestController::platformResetStateToConsistentValues):
6986 2019-03-29 Takashi Komori <Takashi.Komori@sony.com>
6988 [Curl] Add Server Trust Evaluation Support.
6989 https://bugs.webkit.org/show_bug.cgi?id=191646
6991 Reviewed by Fujii Hironori.
6993 Implemented MiniBrowser UI for asking if user trusts the server.
6995 * MiniBrowser/win/Common.cpp:
6996 (askServerTrustEvaluation):
6998 * MiniBrowser/win/Common.h:
6999 * MiniBrowser/win/MiniBrowserLib.rc:
7000 * MiniBrowser/win/MiniBrowserLibResource.h:
7001 * MiniBrowser/win/WebKitBrowserWindow.cpp:
7003 (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
7004 (WebKitBrowserWindow::canTrustServerCertificate):
7005 * MiniBrowser/win/WebKitBrowserWindow.h:
7007 2019-03-29 Cathie Chen <cathiechen@igalia.com>
7009 Implement ResizeObserver.
7010 https://bugs.webkit.org/show_bug.cgi?id=157743
7012 Reviewed by Simon Fraser.
7014 Support resizeObserverEnabled webPreferences.
7016 * DumpRenderTree/TestOptions.cpp:
7017 (TestOptions::TestOptions):
7018 * DumpRenderTree/TestOptions.h:
7019 * DumpRenderTree/mac/DumpRenderTree.mm:
7020 (setWebPreferencesForTestOptions):
7021 * DumpRenderTree/win/DumpRenderTree.cpp:
7022 (enableExperimentalFeatures):
7023 * Scripts/webkitperl/FeatureList.pm:
7024 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
7026 2019-03-28 John Wilander <wilander@apple.com>
7028 Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
7029 https://bugs.webkit.org/show_bug.cgi?id=196281
7030 <rdar://problem/48938748>
7032 Reviewed by Alex Christensen.
7034 This patch adds the function isStatisticsHasLocalStorage() to the
7035 TestRunner. With it, the page can query the WebsiteDataStore in the
7036 UI process to make sure that it sees LocalStorage.
7038 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
7039 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
7040 (WTR::TestRunner::isStatisticsHasLocalStorage):
7041 * WebKitTestRunner/InjectedBundle/TestRunner.h:
7042 * WebKitTestRunner/TestController.cpp:
7043 (WTR::TestController::isStatisticsHasLocalStorage):
7044 * WebKitTestRunner/TestController.h:
7045 * WebKitTestRunner/TestInvocation.cpp:
7046 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
7048 2019-03-28 Jiewen Tan <jiewen_tan@apple.com>
7050 API::Data::createWithoutCopying should do a null check before calling CFRelease
7051 https://bugs.webkit.org/show_bug.cgi?id=196276
7052 <rdar://problem/48059859>
7054 Reviewed by Alex Christensen.
7056 Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
7058 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
7059 * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
7060 * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
7061 (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
7062 (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
7063 (TestWebKitAPI::TEST):
7065 2019-03-28 Michael Catanzaro <mcatanzaro@igalia.com>
7067 [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
7068 https://bugs.webkit.org/show_bug.cgi?id=186276
7070 Reviewed by Carlos Garcia Campos.
7072 * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
7073 (webViewLoadChanged):
7074 (testWebResourceGetDataError):
7075 (testWebResourceGetDataEmpty):
7077 (webViewloadChanged): Deleted.
7079 2019-03-27 Andy Estes <aestes@apple.com>
7081 REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
7082 https://bugs.webkit.org/show_bug.cgi?id=196317
7084 Reviewed by Dan Bernstein.
7086 package-root copies built products into a staging directory using ditto(1), which does not
7087 follow symbolic links as it traverses a directory. Now that the files in
7088 WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
7089 itself, these become broken links when ditto'd into the staging directory.
7091 To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
7093 * Scripts/package-root:
7095 2019-03-27 Aakash Jain <aakash_jain@apple.com>
7097 [ews-app] Update display text of Submit for ews analysis
7098 https://bugs.webkit.org/show_bug.cgi?id=196309
7100 Reviewed by Dewei Zhu.
7102 * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
7104 2019-03-27 David Kilzer <ddkilzer@apple.com>
7106 run-webkit-tests should check for leaks in WebKit processes
7107 <https://webkit.org/b/193772>
7108 <rdar://problem/46526680>
7110 Reviewed by Ryosuke Niwa.
7112 This works by doing the following:
7113 - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
7114 The list of child processes are returned one per line:
7116 - Run the "#LIST CHILD PROCESSES" command just before the
7117 "#CHECK FOR WORLD LEAKS" command, and store the list of child
7118 processes on the ServerProcess object.
7119 - When the `--leaks` switch is handled, run check_for_leaks() on
7120 each child process after the main test harness.
7122 * DumpRenderTree/mac/DumpRenderTree.mm:
7123 (handleControlCommand):
7124 - Use strncmp() instead of strcmp().
7125 - Add support for handling "#LIST CHILD PROCESSES" command.
7127 * Scripts/webkitpy/port/base.py:
7128 (Port.check_for_leaks):
7129 * Scripts/webkitpy/port/darwin.py:
7130 (DarwinPort.check_for_leaks):
7131 - Rename redundant 'process_pid' argument to 'process_id'.
7133 * Scripts/webkitpy/port/driver.py:
7134 (Driver.do_post_tests_work):
7135 - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
7136 longer the only command this sends to WebKitTestRunner.
7137 - If the `--leaks` switch is present, send the
7138 "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
7139 result using Port.set_webkit_processes().
7140 (Driver._parse_child_processes_output):
7141 - Add helper method to parse list of child process names and
7142 process IDs returned from WebKitTestRunner.
7144 * Scripts/webkitpy/port/ios_device.py:
7145 (IOSDevicePort.check_for_leaks):
7146 - Rename redundant 'process_pid' argument to 'process_id'.
7148 * Scripts/webkitpy/port/leakdetector.py:
7149 (LeakDetector._parse_leaks_output):
7150 - Return early if there is no leaks_output.
7151 (LeakDetector.check_for_leaks):
7152 - Rename redundant 'process_pid' argument to 'process_id'.
7154 * Scripts/webkitpy/port/server_process.py:
7155 (ServerProcess.__init__):
7156 (ServerProcess.child_processes):
7157 (ServerProcess.set_child_processes):
7158 - Add instance variable to Port to store list of child process
7159 names and process IDs returned from WebKitTestRunner.
7160 (ServerProcess._start):
7161 - Clear self._child_processes.
7162 (ServerProcess.stop):
7163 - If self._child_processes is set, call
7164 self._port.check_for_leaks() for each child process.
7166 * Scripts/webkitpy/port/server_process_unittest.py:
7167 (TrivialMockPort.check_for_leaks):
7168 - Rename redundant 'process_pid' argument to 'process_id'.
7170 * Scripts/webkitpy/port/simulator_process.py:
7171 (SimulatorProcess.stop):
7172 - If self._child_processes is set, call
7173 self._port.check_for_leaks() for each child process.
7175 * Scripts/webkitpy/port/watch_device.py:
7176 (WatchDevicePort.check_for_leaks):
7177 - Rename redundant 'process_pid' argument to 'process_id'.
7179 * WebKitTestRunner/TestController.cpp:
7180 (WTR::TestController::dumpResponse):
7181 - Extract method from findAndDumpWorldLeaks() so that it may be
7182 reused by findAndDumpWebKitProcessIdentifiers().
7183 (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
7184 - Add method to output process name and process ID of both the
7185 WebContent and Networking processes.
7186 (WTR::TestController::findAndDumpWorldLeaks):
7187 - Fix missing newline in output when there were no abandoned
7189 - Call dumpResponse() for extracted code.
7190 (WTR::TestController::handleControlCommand):
7191 - Restructure the logic for "#CHECK FOR WORLD LEAKS".
7192 - Use strncmp() instead of strcmp().
7193 - Call findAndDumpWebKitProcessIdentifiers() when
7194 "#LIST CHILD PROCESSES" command is sent.
7195 * WebKitTestRunner/TestController.h:
7196 (WTR::TestController::dumpResponse):
7197 (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
7200 2019-03-27 Carlos Garcia Campos <cgarcia@igalia.com>
7202 Unreviewed. Add GLib API test cases after r243434.
7204 * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
7205 (testWebViewActiveURI):
7207 * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
7208 (sendRequestCallback):
7210 2019-03-27 Carlos Garcia Campos <cgarcia@igalia.com>
7212 Geolocation request not complete when watch request was started in a different web process
7213 https://bugs.webkit.org/show_bug.cgi?id=195996
7215 Reviewed by Alex Christensen.
7219 * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
7220 (TestWebKitAPI::runJavaScriptAlert):
7221 (TestWebKitAPI::TEST):
7223 2019-03-26 Keith Rollin <krollin@apple.com>
7225 Update the way generate-xcfilelists returns strings from functions
7226 https://bugs.webkit.org/show_bug.cgi?id=195975
7227 <rdar://problem/49040807>
7229 Reviewed by Dean Jackson.
7231 There are places where generate-xcfilelists executes assignments with
7234 FOO=$(some_function)
7236 where "some_function" return a string by echoing it. E.g.
7243 This is a common idiom, but it has a problem if "some_function" needs
7244 to call "exit" in an attempt to halt the entire script right then and
7245 there. Since "some_function" is called inside of $(), it's being
7246 executed in a sub-shell. Calling exit in that sub-shell simply exits
7247 that shell; it doesn't not exit the outer shell in which the main part
7248 of the script is still running. As such, the main script keeps
7249 executing when the intent was for the script to halt.
7251 The solution to this is to use a different idiom for returning
7252 strings. The one we now is to pass in the name of the variable to
7253 receive the string result:
7258 eval $variable_name ="Hello, World"
7261 The call site now looks like
7265 Because there's no invocation of a sub-shell, some_function can now
7266 call "exit" if it wants to, and the entire script will exit at that
7269 * Scripts/generate-xcfilelists:
7271 2019-03-26 Chris Dumez <cdumez@apple.com>
7273 Add basic layout test coverage for File Picker on iOS
7274 https://bugs.webkit.org/show_bug.cgi?id=196265
7276 Reviewed by Wenson Hsieh.
7278 Add layout test infrastructure to test the file picker on iOS.
7280 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
7281 (WTR::UIScriptController::dismissFilePicker):
7282 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
7283 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
7284 (WTR::UIScriptController::dismissFilePicker):
7285 * TestRunnerShared/UIScriptContext/UIScriptController.h:
7286 * WebKitTestRunner/TestController.cpp:
7287 (WTR::TestController::createWebViewWithOptions):
7288 (WTR::updateTestOptionsFromTestHeader):
7289 * WebKitTestRunner/TestOptions.h:
7290 (WTR::TestOptions::hasSameInitializationOptions const):
7291 * WebKitTestRunner/ios/TestControllerIOS.mm:
7292 (overridePresentViewController):
7293 (WTR::TestController::platformInitialize):
7294 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
7295 (WTR::UIScriptController::dismissFilePicker):
7297 2019-03-26 Wenson Hsieh <wenson_hsieh@apple.com>
7299 Implement async paste method on UIWKInteractionViewProtocol
7300 https://bugs.webkit.org/show_bug.cgi?id=196267
7301 <rdar://problem/49236346>
7303 Reviewed by Tim Horton.
7305 Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
7306 -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
7307 are now a part of all iOS 12 internal SDKs.
7309 * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
7311 While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
7312 prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
7314 * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
7315 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
7316 (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
7317 * TestWebKitAPI/ios/UIKitSPI.h:
7319 2019-03-26 Aakash Jain <aakash_jain@apple.com>
7321 [ews-build] Use PostgreSQL for ews.webkit.org database
7322 https://bugs.webkit.org/show_bug.cgi?id=196270
7324 Reviewed by Lucas Forschler.
7326 * BuildSlaveSupport/ews-app/ews-app/settings.py:
7328 2019-03-26 Jonathan Bedard <jbedard@apple.com>
7330 [ews] Reset simctl states on reboot
7331 https://bugs.webkit.org/show_bug.cgi?id=196260
7333 Rubber-stamped by Aakash Jain.
7335 * EWSTools/start-queue-mac.sh:
7337 2019-03-26 Aakash Jain <aakash_jain@apple.com>
7339 [ews-build] Use PostgreSQL for ews-build database
7340 https://bugs.webkit.org/show_bug.cgi?id=196229
7342 Reviewed by Lucas Forschler.
7344 * BuildSlaveSupport/ews-build/master.cfg:
7346 2019-03-26 Aakash Jain <aakash_jain@apple.com>
7348 [ews-build] Get master_hostname dynamically in master.cfg
7349 https://bugs.webkit.org/show_bug.cgi?id=196255
7351 Reviewed by Lucas Forschler.
7353 * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
7354 send events data in test mode.
7356 2019-03-26 Aakash Jain <aakash_jain@apple.com>
7358 [ews-app] Set db_constraint to False for Foreign Keys
7359 https://bugs.webkit.org/show_bug.cgi?id=196252
7361 Reviewed by Lucas Forschler.
7363 * BuildSlaveSupport/ews-app/ews/models/build.py:
7364 * BuildSlaveSupport/ews-app/ews/models/step.py:
7366 2019-03-26 Aakash Jain <aakash_jain@apple.com>
7368 [ews-build] is_test_mode_enabled should default to True
7369 https://bugs.webkit.org/show_bug.cgi?id=196248
7371 Reviewed by Lucas Forschler.
7373 * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
7375 2019-03-26 Aakash Jain <aakash_jain@apple.com>
7377 [ews-app] Add webkitperl to ENABLED_QUEUES
7378 https://bugs.webkit.org/show_bug.cgi?id=196253
7380 Reviewed by Lucas Forschler.
7382 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
7384 2019-03-25 Alexey Proskuryakov <ap@apple.com>
7386 Address NSWindow sometimes using WebKitTestRunnerEvent too early
7387 https://bugs.webkit.org/show_bug.cgi?id=196211
7388 rdar://problem/49110552
7390 Reviewed by Tim Horton.
7392 * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
7393 Make sure that EventSenderProxy always exists when running tests. We used to create
7394 it when resetting before the first test, which is a bit too late.
7396 * WebKitTestRunner/TestController.h:
7397 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
7398 (WTR::TestController::platformCreateWebView):
7399 (WTR::TestController::platformCreateOtherPage):
7400 (WTR::TestController::finishCreatingPlatformWebView):
7401 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
7402 (WTR::PlatformWebView::PlatformWebView):
7403 Moved some code that made NSWindow use NSEvent during web view creation. We may
7404 need to move more if some other case us found, but this is enough for now.
7406 2019-03-26 Carlos Garcia Campos <cgarcia@igalia.com>
7408 Unreviewed. Fix typo in GLib geolocation API after r243285.
7410 gelocation -> geolocation.
7412 * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
7413 (testGeolocationManagerWatchPosition):
7415 2019-03-25 Alex Christensen <achristensen@webkit.org>
7417 Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
7418 https://bugs.webkit.org/show_bug.cgi?id=196213
7420 Reviewed by Geoff Garen.
7422 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
7423 * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
7424 (credentialWithIdentityAndKeychainPath):
7425 (-[ChallengeDelegate webView:didFinishNavigation:]):
7426 (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
7427 (TestWebKitAPI::TEST):
7429 2019-03-25 Alex Christensen <achristensen@webkit.org>
7431 Expected shouldn't assume its contained types are copyable
7432 https://bugs.webkit.org/show_bug.cgi?id=195986
7434 Reviewed by JF Bastien.
7436 * TestWebKitAPI/Tests/WTF/Expected.cpp:
7437 (TestWebKitAPI::NonCopyable::operator== const):
7438 (TestWebKitAPI::NonCopyable::operator!= const):
7439 (TestWebKitAPI::TEST):
7441 2019-03-25 Tim Horton <timothy_horton@apple.com>
7443 Remove some now-unnecessary dynamic class lookup
7444 https://bugs.webkit.org/show_bug.cgi?id=196237
7446 Reviewed by Simon Fraser.
7448 * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
7452 2019-03-25 Fujii Hironori <Hironori.Fujii@sony.com>
7454 Unreviewed, rolling out r243450.
7456 AppleWin and WinCairo port builds get broken.
7460 "Add test for fix of #196095"
7461 https://bugs.webkit.org/show_bug.cgi?id=196097
7462 https://trac.webkit.org/changeset/243450
7464 2019-03-25 Commit Queue <commit-queue@webkit.org>
7466 Unreviewed, rolling out r243465.
7467 https://bugs.webkit.org/show_bug.cgi?id=196226
7469 the test doesn't build (Requested by thorton on #webkit).
7473 "Do not terminate the NetworkProcess if a third party
7474 application sends a NSCredential with a SecIdentityRef"
7475 https://bugs.webkit.org/show_bug.cgi?id=196213
7476 https://trac.webkit.org/changeset/243465
7478 2019-03-25 Alex Christensen <achristensen@webkit.org>
7480 Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
7481 https://bugs.webkit.org/show_bug.cgi?id=196213
7483 Reviewed by Geoff Garen.
7485 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
7486 * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
7487 (credentialWithIdentityAndKeychainPath):
7488 (-[ChallengeDelegate webView:didFinishNavigation:]):
7489 (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
7490 (TestWebKitAPI::TEST):
7492 2019-03-25 Aakash Jain <aakash_jain@apple.com>
7494 [ews-build] Gracefully handle missing patch_id in events
7495 https://bugs.webkit.org/show_bug.cgi?id=196216
7497 Reviewed by Lucas Forschler.
7499 * BuildSlaveSupport/ews-build/events.py:
7501 2019-03-25 Aakash Jain <aakash_jain@apple.com>
7503 [ews-build] use lz4 compression for improving buildbot performance
7504 https://bugs.webkit.org/show_bug.cgi?id=196155
7506 Reviewed by Lucas Forschler.
7508 * BuildSlaveSupport/ews-build/master.cfg:
7510 2019-03-25 Wenson Hsieh <wenson_hsieh@apple.com>
7512 Pull some API testing helper methods out of TestWKWebView
7513 https://bugs.webkit.org/show_bug.cgi?id=196212
7515 Reviewed by Tim Horton.
7517 Refactor some more API testing utility methods, so that they can be used in
7518 tests that do not use TestWKWebView.
7520 * TestWebKitAPI/cocoa/TestWKWebView.h:
7521 * TestWebKitAPI/cocoa/TestWKWebView.mm:
7522 (-[WKWebView loadTestPageNamed:]):
7523 (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
7524 (-[WKWebView synchronouslyLoadHTMLString:]):
7525 (-[WKWebView synchronouslyLoadTestPageNamed:]):
7526 (-[TestWKWebView loadTestPageNamed:]): Deleted.
7527 (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
7528 (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
7529 (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
7531 2019-03-25 Jer Noble <jer.noble@apple.com>
7533 Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
7534 https://bugs.webkit.org/show_bug.cgi?id=196097
7536 Reviewed by Eric Carlson.
7538 Drive-by bug fix: allow tests to play audio without a user gesture by default.
7540 * DumpRenderTree/mac/DumpRenderTree.mm:
7541 (resetWebPreferencesToConsistentValues):
7542 * WebKitTestRunner/TestController.cpp:
7543 (WTR::TestController::resetPreferencesToConsistentValues):
7545 2019-03-25 Wenson Hsieh <wenson_hsieh@apple.com>
7547 Pull IPadUserInterfaceSwizzler out into a separate header file
7548 https://bugs.webkit.org/show_bug.cgi?id=196193
7550 Reviewed by Anders Carlsson.
7552 Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
7553 be used in other API tests.
7555 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
7556 * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
7557 (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
7558 (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
7559 * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
7560 (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
7561 (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
7563 2019-03-25 Gyuyoung Kim <gyuyoung.kim@webkit.org>
7565 Remove NavigatorContentUtils in WebCore/Modules
7566 https://bugs.webkit.org/show_bug.cgi?id=196070
7568 Reviewed by Alex Christensen.
7570 NavigatorContentUtils was to support the custom scheme spec [1].
7571 However, in WebKit side, no port has supported the feature in
7572 WebKit layer after EFL port was removed. So there has been the
7573 only IDL implementation of the NavigatorContentUtils in WebCore.
7574 So we don't need to keep the implementation in WebCore anymore.
7576 [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
7578 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
7580 2019-03-24 Andy Estes <aestes@apple.com>
7582 [watchOS] Remove unused Proximity Networking code
7583 https://bugs.webkit.org/show_bug.cgi?id=196188
7585 Reviewed by Tim Horton.
7587 * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
7590 2019-03-23 Keith Miller <keith_miller@apple.com>
7592 Refactor clz/ctz and fix getLSBSet.
7593 https://bugs.webkit.org/show_bug.cgi?id=196162
7595 Reviewed by Saam Barati.
7597 Add tests for clz, ctz, getLSBSet, and getMSBSet.
7599 * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
7600 (TestWebKitAPI::TEST):
7602 2019-03-23 Carlos Garcia Campos <cgarcia@igalia.com>
7604 [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
7605 https://bugs.webkit.org/show_bug.cgi?id=196143
7607 Reviewed by Michael Catanzaro.
7609 Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
7612 * Scripts/webkitpy/style/checkers/cpp.py:
7613 (check_identifier_name_in_declaration):
7614 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
7615 (WebKitStyleTest.test_names):
7617 2019-03-22 Philippe Normand <pnormand@igalia.com>
7619 [Flatpak] Manifest expanding fails for qt WPE extension
7620 https://bugs.webkit.org/show_bug.cgi?id=196148
7622 Reviewed by Alex Christensen.
7624 * flatpak/flatpakutils.py:
7625 (expand_submodules_recurse): The last recurse manifest expand
7626 iteration might lead to a single module so take it into account
7627 and don't try to recurse further.
7629 2019-03-22 Chris Dumez <cdumez@apple.com>
7631 [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
7632 https://bugs.webkit.org/show_bug.cgi?id=195348
7633 <rdar://problem/48622090>
7635 Reviewed by Alex Christensen.
7637 Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
7638 to NO when test.options().shouldIgnoreMetaViewport is false.
7640 * WebKitTestRunner/ios/TestControllerIOS.mm:
7641 (WTR::TestController::platformConfigureViewForTest):
7643 2019-03-22 Chris Dumez <cdumez@apple.com>
7645 Prewarmed processes should be usable with any website data store
7646 https://bugs.webkit.org/show_bug.cgi?id=196104
7648 Reviewed by Alex Christensen.
7650 Add API test coverage.
7652 * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
7653 (runInitialWarmedProcessUsedTest):
7656 2019-03-22 David Kilzer <ddkilzer@apple.com>
7658 Back out local changes to Alex's Subversion working directory
7660 They were accidentally committed.
7662 * Scripts/webkitpy/common/system/abstractexecutive.py:
7663 (AbstractExecutive.wait_newest):
7664 * Scripts/webkitpy/common/system/executive.py:
7665 (Executive.running_pids):
7666 * Scripts/webkitpy/common/system/executive_mock.py:
7667 (MockExecutive.running_pids):
7668 * Scripts/webkitpy/common/system/executive_unittest.py:
7669 (ExecutiveTest.serial_test_running_pids):
7670 * Scripts/webkitpy/port/darwin.py:
7671 (DarwinPort.check_for_leaks):
7672 * Scripts/webkitpy/port/leakdetector.py:
7673 (LeakDetector.check_for_leaks):
7674 - This was the hack attached to Bug 193772.
7676 * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
7677 (+[WebKitTestRunnerEvent mouseLocation]):
7678 - This works around a crash on an internal build.
7680 2019-03-22 Tim Horton <timothy_horton@apple.com>
7682 Fix the build after r243354
7683 https://bugs.webkit.org/show_bug.cgi?id=196138
7684 <rdar://problem/49145951>
7686 * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
7688 * TestWebKitAPI/ios/UIKitSPI.h:
7690 2019-03-21 Tim Horton <timothy_horton@apple.com>
7692 Adopt UIWKDocumentContext
7693 https://bugs.webkit.org/show_bug.cgi?id=196040
7694 <rdar://problem/48642440>
7696 Reviewed by Ryosuke Niwa.
7698 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
7699 * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
7701 (-[TestWKWebView synchronouslyRequestDocumentContext:]):
7702 (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
7705 Add tests for UIWKDocumentContext.
7707 * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
7709 (recursiveFindWKContentView): Deleted.
7710 * TestWebKitAPI/cocoa/TestWKWebView.h:
7711 * TestWebKitAPI/cocoa/TestWKWebView.mm:
7712 (recursiveFindWKContentView):
7713 (-[TestWKWebView wkContentView]):
7714 * TestWebKitAPI/ios/UIKitSPI.h:
7715 Share the WKContentView finding code between tests.
7717 2019-03-21 Simon Fraser <simon.fraser@apple.com>
7719 [iOS WK2] Turn on async overflow scrolling by default
7720 https://bugs.webkit.org/show_bug.cgi?id=196011
7721 rdar://problem/48453859
7723 Reviewed by Antti Koivisto.
7725 Explicitly turn off the async overflow scrolling internal feature for tests by default,
7726 since so many basic layout tests have different results when compositing is triggered for
7729 Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
7731 * WebKitTestRunner/TestController.cpp:
7732 (WTR::TestController::resetPreferencesToConsistentValues):
7734 2019-03-21 Aakash Jain <aakash_jain@apple.com>
7736 [ews-build] Retry API test in case of failures
7737 https://bugs.webkit.org/show_bug.cgi?id=196004
7739 Reviewed by Lucas Forschler.
7741 * BuildSlaveSupport/ews-build/steps.py:
7742 (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
7743 (CompileWebKitToT.doStepIf): Ditto.
7744 (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
7745 (ReRunAPITests): Re-run API tests.
7746 (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
7747 (RunAPITestsWithoutPatch): Run API tests without patch.
7748 (RunAPITestsWithoutPatch.doStepIf):
7749 (RunAPITestsWithoutPatch.hideStepIf):
7750 (RunAPITestsWithoutPatch.evaluateCommand):
7751 (AnalyzeAPITestsResults): Analyze API test results from previous runs.
7752 (AnalyzeAPITestsResults.start):
7753 (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
7754 (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
7755 (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
7756 * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
7758 2019-03-21 Aakash Jain <aakash_jain@apple.com>
7760 [ews-build] Update queues configurations
7761 https://bugs.webkit.org/show_bug.cgi?id=196074
7763 Reviewed by Dewei Zhu.
7765 * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
7766 added new bots, reassigned bots for various builders, moved few builders to another scheduler.
7768 2019-03-21 Aakash Jain <aakash_jain@apple.com>
7770 [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
7771 https://bugs.webkit.org/show_bug.cgi?id=195680
7772 <rdar://problem/48903534>
7774 Unreviewed infrastructure fix.
7776 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
7777 (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
7779 2019-03-21 Andy Estes <aestes@apple.com>
7781 [iOS] Apple Pay should be available in documents with no user agent scripts
7782 https://bugs.webkit.org/show_bug.cgi?id=196061
7783 <rdar://problem/48649391>
7785 Reviewed by Brady Eidson.
7787 Added API tests and related infrastructure.
7789 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
7790 * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
7791 (-[TestApplePayScriptMessageHandler initWithExpectation:]):
7792 (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
7793 (TestWebKitAPI::TEST):
7794 * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
7795 * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
7796 * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
7797 * TestWebKitAPI/cocoa/TestProtocol.mm:
7798 (-[TestProtocol startLoading]):
7799 * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
7800 * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
7801 (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
7802 (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
7804 2019-03-21 Jonathan Bedard <jbedard@apple.com>
7806 REGRESSSION (r243297): webkitpy tests broken
7807 https://bugs.webkit.org/show_bug.cgi?id=196108
7809 Reviewed by Aakash Jain.
7811 r243297 updated contributors.json, which broke a few unit tests.
7813 * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
7814 (IRCCommandTest.test_whois):
7815 * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
7817 2019-03-21 Chris Dumez <cdumez@apple.com>
7819 WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
7820 https://bugs.webkit.org/show_bug.cgi?id=196041
7821 <rdar://problem/49083230>
7823 Reviewed by Alex Christensen.
7825 Add API test coverage.
7827 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
7830 2019-03-21 Alex Christensen <achristensen@webkit.org>
7832 Add SPI to inform applications of WKContentRuleList actions
7833 https://bugs.webkit.org/show_bug.cgi?id=195965
7834 <rdar://problem/42664365>
7836 Reviewed by Geoff Garen.
7838 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
7839 (TestWebKitAPI::allActionsForResourceLoad):
7840 (TestWebKitAPI::testRequest):
7841 (TestWebKitAPI::TEST_F):
7842 * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
7843 (Notification::description):
7844 (Notification::operator== const):
7846 (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
7847 (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
7848 (makeContentRuleList):
7850 (makeWarnContentRuleList): Deleted.
7852 2019-03-21 Timothy Hatcher <timothy@apple.com>
7854 Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
7855 https://bugs.webkit.org/show_bug.cgi?id=196088
7857 Reviewed by Brian Burg.
7859 Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
7860 Support checks when only one platform is specified. Also deprecate macosx() and
7861 force the use of macos() instead.
7863 * Scripts/webkitpy/style/checkers/cpp.py:
7864 (check_min_versions_of_wk_api_available):
7865 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
7866 (WebKitStyleTest.test_min_versions_of_wk_api_available):
7868 2019-03-21 Alexey Proskuryakov <ap@apple.com>
7870 Update status inactive committers' status to 'contributor'.
7872 * Scripts/webkitpy/common/config/contributors.json:
7874 2019-03-21 Xan Lopez <xan@igalia.com>
7876 [JSC][x86] Drop support for x87 floating point
7877 https://bugs.webkit.org/show_bug.cgi?id=194853
7879 Reviewed by Don Olmstead.
7881 Force SSE2 on x86/32bit builds.
7883 * Scripts/webkitdirs.pm:
7884 (generateBuildSystemFromCMakeProject):
7886 2019-03-21 Carlos Garcia Campos <cgarcia@igalia.com>
7888 [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
7889 https://bugs.webkit.org/show_bug.cgi?id=196073
7891 Reviewed by Michael Catanzaro.
7893 Add test cases to check functions and constructors with no arguments but receiving user data.
7895 * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
7898 (fooCreateWithUserData):
7901 2019-03-21 Carlos Garcia Campos <cgarcia@igalia.com>
7903 Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
7905 Add g_assert_cmpfloat_with_epsilon macro if not defined.
7907 * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
7909 2019-03-21 Carlos Garcia Campos <cgarcia@igalia.com>
7911 [GTK][WPE] Add API to provide geolocation information
7912 https://bugs.webkit.org/show_bug.cgi?id=195940
7914 Reviewed by Michael Catanzaro.
7916 Add a new test to check the new API.
7918 * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
7919 (testGeolocationManagerCurrentPosition):
7920 (testGeolocationManagerWatchPosition):
7923 * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
7924 (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
7926 * TestWebKitAPI/glib/CMakeLists.txt:
7928 2019-03-21 Carlos Garcia Campos <cgarcia@igalia.com>
7930 [GLib] Returning G_TYPE_OBJECT from a method does not work
7931 https://bugs.webkit.org/show_bug.cgi?id=195574
7933 Reviewed by Michael Catanzaro.
7935 Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
7937 * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
7942 (getGStringCopyWillRaise):
7949 2019-03-20 Saam Barati <sbarati@apple.com>
7951 DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
7952 https://bugs.webkit.org/show_bug.cgi?id=195721
7954 Reviewed by Filip Pizlo.
7956 * Scripts/run-javascriptcore-tests:
7958 2019-03-20 Simon Fraser <simon.fraser@apple.com>
7960 Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
7961 https://bugs.webkit.org/show_bug.cgi?id=196049
7963 Reviewed by Tim Horton.
7965 This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
7966 overflow scrolling in general, so rename it.
7968 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
7970 2019-03-20 Daniel Bates <dabates@apple.com>
7972 REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
7973 https://bugs.webkit.org/show_bug.cgi?id=196031
7974 <rdar://problem/49078172>
7976 Reviewed by Tim Horton.
7978 The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
7979 <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
7980 same code path used when the Done button is pressed to dismiss the <select> picker.
7982 * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
7983 (TestWebKitAPI::TEST):
7985 2019-03-20 Chris Dumez <cdumez@apple.com>
7987 Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
7988 https://bugs.webkit.org/show_bug.cgi?id=196029
7989 <rdar://problem/48954651>
7991 Reviewed by Tim Horton.
7993 Add API test coverage.
7995 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
7997 2019-03-20 Aakash Jain <aakash_jain@apple.com>
7999 [ews-build] Improve failure summary string for ApplyPatch step
8000 https://bugs.webkit.org/show_bug.cgi?id=195995
8002 Reviewed by Alexey Proskuryakov.
8004 * BuildSlaveSupport/ews-build/steps.py:
8005 (ApplyPatch.getResultSummary): Override getResultSummary.
8007 2019-03-20 Joanmarie Diggs <jdiggs@igalia.com>
8009 AX: Implement support for new meter ARIA role
8010 https://bugs.webkit.org/show_bug.cgi?id=195966
8012 Reviewed by Chris Fleizach.
8014 Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
8015 to AXLevelIndicator.
8017 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
8019 2019-03-19 Jiewen Tan <jiewen_tan@apple.com>
8021 [WebAuthN] Implement FIDO AppID extension
8022 https://bugs.webkit.org/show_bug.cgi?id=143491
8023 <rdar://problem/48298273>
8025 Reviewed by Brent Fulgham.
8027 Add a test that covers the new flag of convertToU2fSignCommand.
8029 * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
8030 (TestWebKitAPI::TEST):
8031 * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
8032 * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
8033 (TestWebKitAPI::TEST):
8035 2019-03-19 Keith Rollin <krollin@apple.com>
8037 Add support for more platforms to generate-xcfilelists
8038 https://bugs.webkit.org/show_bug.cgi?id=195977
8040 Reviewed by Alexey Proskuryakov.
8042 generate-xcfilelists incorrectly complains when involved with building
8043 WebKit for iphonesimulator:
8045 $ make debug SDKROOT=iphonesimulator.internal -C Internal/
8047 ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
8049 Address this by teaching generate-xcfilelists about more platforms.
8051 * Scripts/generate-xcfilelists:
8053 2019-03-19 John Wilander <wilander@apple.com>
8055 Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
8056 https://bugs.webkit.org/show_bug.cgi?id=195923
8057 <rdar://problem/49001272>
8059 Reviewed by Alex Christensen.
8061 This patch does the following to the TestRunner:
8062 - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
8063 - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
8064 - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
8066 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
8067 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
8068 (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
8069 * WebKitTestRunner/InjectedBundle/TestRunner.h:
8070 * WebKitTestRunner/TestController.cpp:
8071 (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
8072 (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
8073 (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
8074 * WebKitTestRunner/TestController.h:
8075 * WebKitTestRunner/TestInvocation.cpp:
8076 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
8078 2019-03-19 Christopher Reid <chris.reid@sony.com>
8080 [CMake] Support more clang and gcc sanitizers
8081 https://bugs.webkit.org/show_bug.cgi?id=195956
8083 Reviewed by Michael Catanzaro.
8085 * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
8087 2019-03-19 Aakash Jain <aakash_jain@apple.com>
8089 [ews-build] Improve summary for PrintConfiguration step
8090 https://bugs.webkit.org/show_bug.cgi?id=195945
8092 Reviewed by Lucas Forschler.
8094 * BuildSlaveSupport/ews-build/steps.py:
8095 (PrintConfiguration.getResultSummary): Override getResultSummary.
8097 2019-03-19 Aakash Jain <aakash_jain@apple.com>
8099 [ews-build] Improve summary for CheckOutSource step
8100 https://bugs.webkit.org/show_bug.cgi?id=195963
8102 Reviewed by Lucas Forschler.
8104 * BuildSlaveSupport/ews-build/steps.py:
8105 (CheckOutSource.getResultSummary):
8107 2019-03-19 Daniel Bates <dabates@apple.com>
8109 [iOS] Focus not preserved when switching between tabs
8110 https://bugs.webkit.org/show_bug.cgi?id=195820
8111 <rdar://problem/43614450>
8113 Reviewed by Brent Fulgham.
8115 Add tests to ensure that we restore focus when resigning and becoming first responder.
8117 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
8118 (TestWebKitAPI::TEST):
8120 2019-03-19 Alex Christensen <achristensen@webkit.org>
8122 Make WTFLogChannelState and WTFLogLevel enum classes
8123 https://bugs.webkit.org/show_bug.cgi?id=195904
8125 Reviewed by Eric Carlson.
8127 * TestWebKitAPI/Tests/WebCore/Logging.cpp:
8128 (TestWebKitAPI::TEST_F):
8130 2019-03-19 Xabier Rodriguez Calvar <calvaris@igalia.com>
8132 [GStreamer][EME] Backported mssdemux protection data crash fix
8133 https://bugs.webkit.org/show_bug.cgi?id=195918
8135 Reviewed by Philippe Normand.
8137 * gstreamer/jhbuild.modules:
8138 * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
8140 2019-03-19 Michael Catanzaro <mcatanzaro@igalia.com>
8142 Unreviewed, rolling out r243132.
8148 "Make WTFLogChannelState and WTFLogLevel enum classes"
8149 https://bugs.webkit.org/show_bug.cgi?id=195904
8150 https://trac.webkit.org/changeset/243132
8152 2019-03-19 Zan Dobersek <zdobersek@igalia.com>
8154 Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
8156 * Scripts/webkitdirs.pm:
8157 (builtDylibPathForName): Adjust the shared library name that's changed
8158 with the API version bump in r243073.
8160 2019-03-18 Alex Christensen <achristensen@webkit.org>
8162 Make WTFLogChannelState and WTFLogLevel enum classes
8163 https://bugs.webkit.org/show_bug.cgi?id=195904
8165 Reviewed by Eric Carlson.
8167 * TestWebKitAPI/Tests/WebCore/Logging.cpp:
8168 (TestWebKitAPI::TEST_F):
8170 2019-03-18 Alex Christensen <achristensen@webkit.org>
8172 Disable flaky test added in r2431100
8173 https://webkit.org/b/195785
8175 * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
8176 (TestWebKitAPI::TEST):
8177 Apparently bots don't hit 150kb/s as reliably as I do locally. Can't say I'm too surprised.
8179 2019-03-18 Timothy Hatcher <timothy@apple.com>
8181 WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
8182 https://bugs.webkit.org/show_bug.cgi?id=195916
8184 Reviewed by Tim Horton.
8186 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
8187 (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
8189 2019-03-18 Alexey Proskuryakov <ap@apple.com>
8191 Add a secondary e-mail address for Fujii Hironori to make tools happier.
8193 * Scripts/webkitpy/common/config/contributors.json:
8195 2019-03-18 Alex Christensen <achristensen@webkit.org>
8197 Implement DownloadMonitor to prevent long-running slow downloads from background apps
8198 https://bugs.webkit.org/show_bug.cgi?id=195785
8200 Reviewed by Geoffrey Garen.
8202 * TestWebKitAPI/TCPServer.cpp: Added.
8203 (TestWebKitAPI::TCPServer::TCPServer):
8204 (TestWebKitAPI::TCPServer::~TCPServer):
8205 (TestWebKitAPI::TCPServer::socketBindListen):
8206 (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
8207 * TestWebKitAPI/TCPServer.h: Added.
8208 (TestWebKitAPI::TCPServer::port const):
8209 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
8210 * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
8211 (-[DownloadMonitorTestDelegate _downloadDidStart:]):
8212 (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
8213 (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
8214 (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
8215 (TestWebKitAPI::respondSlowly):
8216 (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
8217 (TestWebKitAPI::downloadAtRate):
8218 (TestWebKitAPI::TEST):
8220 2019-03-18 Saam Barati <sbarati@apple.com>
8222 Add a plan file for JetStream 2
8223 https://bugs.webkit.org/show_bug.cgi?id=190734
8225 Reviewed by Mark Lam.
8227 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
8229 2019-03-18 Chris Dumez <cdumez@apple.com>
8231 Delay WebProcess launch until a load is triggered in a Web view
8232 https://bugs.webkit.org/show_bug.cgi?id=195758
8233 <rdar://problem/48126013>
8235 Reviewed by Geoff Garen.
8237 Add API test coverage. Also update some existing API tests to not expect
8238 constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
8240 * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
8241 (TestWebKitAPI::TEST):
8242 * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
8243 (TestWebKitAPI::TEST):
8244 * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
8246 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
8247 * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
8249 * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
8251 (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
8253 2019-03-18 Xan Lopez <xan@igalia.com>
8255 [CMake] Prevent potential warning when determining $architecture
8256 https://bugs.webkit.org/show_bug.cgi?id=195891
8258 Reviewed by Michael Catanzaro.
8260 It's possible for generateBuildSystemForCMakeProject to be called
8261 before determineArchitecture() is ever called. This will make the
8262 first eq check with $architecture to be bogus (and print a
8263 warning). Change that to an eq check with architecture(), which
8264 implicitly calls determineArchitecture() if needed, and change all
8265 the other similar cases in the method in the same way to prevent
8266 future bugs like this one.
8268 * Scripts/webkitdirs.pm:
8269 (generateBuildSystemFromCMakeProject):
8271 2019-03-18 Adrian Perez de Castro <aperez@igalia.com>
8273 [WPE] Tarballs generated with “make dist” cannot build documentation
8274 https://bugs.webkit.org/show_bug.cgi?id=195885
8276 Reviewed by Carlos Garcia Campos.
8278 * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
8280 2019-03-18 Adrian Perez de Castro <aperez@igalia.com>
8282 [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
8283 https://bugs.webkit.org/show_bug.cgi?id=195883
8285 Reviewed by Carlos Garcia Campos.
8288 (GTKDoc._run_command): When commands fail to run, include the full command line for
8289 the program invocation and the output it has generated on the standard error stream.
8291 2019-03-18 Adrian Perez de Castro <aperez@igalia.com>
8293 [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
8294 https://bugs.webkit.org/show_bug.cgi?id=195786
8296 Reviewed by Philippe Normand.
8298 * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
8299 * wpe/jhbuild.modules: Ditto.
8301 2019-03-16 Aakash Jain <aakash_jain@apple.com>
8303 [ews-build] Don't run clean builds on EWS builders
8304 https://bugs.webkit.org/show_bug.cgi?id=195851
8306 Reviewed by Geoffrey Garen.
8308 * BuildSlaveSupport/ews-build/factories.py:
8310 2019-03-16 Sihui Liu <sihui_liu@apple.com>
8312 REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
8313 https://bugs.webkit.org/show_bug.cgi?id=195849
8315 Reviewed by Chris Dumez.
8317 We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
8319 * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
8320 (runWebsiteDataStoreCustomPaths):
8322 2019-03-15 Jonathan Bedard <jbedard@apple.com>
8324 webkitpy: Upload test results
8325 https://bugs.webkit.org/show_bug.cgi?id=195755
8326 <rdar://problem/48896182>
8328 Reviewed by Aakash Jain.
8330 Establish a new format for uploading results that is not tied to layout tests, apply
8331 that format to webkitpy tests.
8333 * Scripts/webkitpy/common/checkout/scm/git.py:
8334 (Git.native_branch): Return what branch the current checkout is on.
8335 * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
8336 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
8337 * Scripts/webkitpy/common/checkout/scm/svn.py:
8338 (SVN.native_branch): Ditto.
8339 * Scripts/webkitpy/common/system/platforminfo.py:
8340 (PlatformInfo.build_version): Return a build version for Mac.
8341 * Scripts/webkitpy/common/system/platforminfo_mock.py:
8342 (MockPlatformInfo.__init__):
8343 (MockPlatformInfo.build_version):
8344 * Scripts/webkitpy/results: Added.
8345 * Scripts/webkitpy/results/__init__.py: Added.
8346 * Scripts/webkitpy/results/options.py: Added.
8347 (upload_options): OptParse list for upload options.
8348 * Scripts/webkitpy/results/upload.py: Added.
8349 (Upload): Class which enforces the upload format expected by the results server.
8350 (Upload.Expectations):
8351 (Upload.create_configuration):
8352 (Upload.create_commit):
8353 (Upload.create_details):
8354 (Upload.create_run_stats):
8355 (Upload.create_test_result):
8357 (Upload.Encoder): Encode Upload object as json.
8358 (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
8359 * Scripts/webkitpy/results/upload_unittest.py: Added.
8360 * Scripts/webkitpy/test/main.py:
8361 (Tester._parse_args): Add upload arguments.
8362 (Tester._run_tests): Allow results to be uploaded.
8363 * Scripts/webkitpy/test/runner.py:
8364 (Runner.__init__): Record which tests were run, rather than just counting them.
8366 * Scripts/webkitpy/test/runner_unittest.py:
8367 (RunnerTest.test_run):
8368 * Scripts/webkitpy/thirdparty/__init__.py:
8369 (AutoinstallImportHook.find_module): Add requests auto-install.
8370 (AutoinstallImportHook._install_requests):
8371 * Scripts/webkitpy/tool/commands/queues_unittest.py:
8372 (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
8374 2019-03-15 Wenson Hsieh <wenson_hsieh@apple.com>
8376 [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
8377 https://bugs.webkit.org/show_bug.cgi?id=195810
8379 Reviewed by Tim Horton.
8381 Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
8382 registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
8383 ending certain layout tests.
8385 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
8386 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
8387 (-[TestRunnerWKWebView dealloc]):
8388 (-[TestRunnerWKWebView resetInteractionCallbacks]):
8390 Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
8391 helper method when destroying the web view, and when resetting state between tests.
8393 * WebKitTestRunner/ios/TestControllerIOS.mm:
8394 (WTR::TestController::platformResetStateToConsistentValues):
8396 Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
8398 2019-03-15 Sihui Liu <sihui_liu@apple.com>
8400 [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
8401 https://bugs.webkit.org/show_bug.cgi?id=190350
8402 <rdar://problem/45089503>
8404 Reviewed by Geoffrey Garen.
8406 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
8407 * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
8409 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
8410 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
8411 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
8412 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
8413 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
8414 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
8415 (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
8417 (createDirectories):
8419 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
8421 * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
8424 2019-03-15 Timothy Hatcher <timothy@apple.com>
8426 Add support to WebPage for getting the contents as an attributed string.
8427 https://bugs.webkit.org/show_bug.cgi?id=195636
8428 rdar://problem/45055697
8430 Reviewed by Tim Horton.
8432 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
8433 (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
8435 2019-03-15 Chris Dumez <cdumez@apple.com>
8437 [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
8438 https://bugs.webkit.org/show_bug.cgi?id=195747
8440 Reviewed by Geoff Garen.
8442 Add API test coverage.
8444 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
8446 2019-03-15 Shawn Roberts <sroberts@apple.com>
8448 Unreviewed, rolling out r242952.
8450 Causing API failures on iOS Simulator
8454 "[PSON] Make sure the WebProcessCache is leverage when
8455 relaunching a process after termination"
8456 https://bugs.webkit.org/show_bug.cgi?id=195747
8457 https://trac.webkit.org/changeset/242952
8459 2019-03-14 Fujii Hironori <Hironori.Fujii@sony.com>
8461 [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
8462 https://bugs.webkit.org/show_bug.cgi?id=195740
8464 Reviewed by Ross Kirsling.
8466 window.open doesn't work for WebKitBrowserWindow because it is not
8469 1. Implemented createNewPage callback of WKPageUIClient.
8470 2. Changed MainWindow to take a BrowserWindow factory function
8471 instead of BrowserWindowType to be flexible to create
8472 BrowserWindow with extra settings.
8473 3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
8474 because it is not relevant with MainWindow anymore.
8476 * MiniBrowser/win/Common.cpp:
8478 * MiniBrowser/win/Common.h:
8479 (CommandLineOptions::CommandLineOptions):
8480 * MiniBrowser/win/MainWindow.cpp:
8481 (MainWindow::MainWindow):
8482 (MainWindow::create):
8484 (MainWindow::WndProc):
8485 * MiniBrowser/win/MainWindow.h:
8486 * MiniBrowser/win/PrintWebUIDelegate.cpp:
8487 (PrintWebUIDelegate::createWebViewWithRequest):
8488 * MiniBrowser/win/WebKitBrowserWindow.cpp:
8489 (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
8490 (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
8491 (WebKitBrowserWindow::updateProxySettings):
8492 (WebKitBrowserWindow::createNewPage):
8493 * MiniBrowser/win/WebKitBrowserWindow.h:
8494 * MiniBrowser/win/WinMain.cpp:
8497 2019-03-14 Simon Fraser <simon.fraser@apple.com>
8499 Make it possible to test scrolling tree layer manipulation more easily
8500 https://bugs.webkit.org/show_bug.cgi?id=195780
8502 Reviewed by Tim Horton.
8504 Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
8505 cuts off communication of scrolling tree scrolls back to the web process
8506 (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
8507 allows tests to trigger scrolls which run the scrolling tree layer positioning
8508 logic, but never get another commit from the web process that might mask
8509 scrolling tree bugs.
8511 WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
8512 whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
8513 via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
8515 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
8516 (WTR::UIScriptController::scrollUpdatesDisabled const):
8517 (WTR::UIScriptController::setScrollUpdatesDisabled):
8518 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
8519 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
8520 (WTR::UIScriptController::scrollUpdatesDisabled const):
8521 (WTR::UIScriptController::setScrollUpdatesDisabled):
8522 * TestRunnerShared/UIScriptContext/UIScriptController.h:
8523 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
8524 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
8525 (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
8526 (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
8527 * WebKitTestRunner/ios/TestControllerIOS.mm:
8528 (WTR::TestController::platformResetStateToConsistentValues):
8529 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
8530 (WTR::UIScriptController::scrollUpdatesDisabled const):
8531 (WTR::UIScriptController::setScrollUpdatesDisabled):
8533 2019-03-14 Youenn Fablet <youenn@apple.com>
8535 Move IDB storage in private browsing mode to NetworkProcess
8536 https://bugs.webkit.org/show_bug.cgi?id=195602
8538 Reviewed by Brady Eidson.
8540 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
8543 2019-03-14 Aakash Jain <aakash_jain@apple.com>
8545 [ews-build] Make descriptionDone messages more readable
8546 https://bugs.webkit.org/show_bug.cgi?id=195760
8548 Reviewed by Lucas Forschler.
8550 * BuildSlaveSupport/ews-build/steps.py:
8551 * BuildSlaveSupport/ews-build/steps_unittest.py:
8553 2019-03-14 Aakash Jain <aakash_jain@apple.com>
8555 [ews-build] Generate status-bubble hover-over messages
8556 https://bugs.webkit.org/show_bug.cgi?id=195680
8558 Reviewed by Lucas Forschler.
8560 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
8562 (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
8564 (StatusBubble._iso_time):
8565 (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
8567 (StatusBubble._most_recent_step_message): Returns status message from most recent step.
8569 2019-03-14 Aakash Jain <aakash_jain@apple.com>
8571 [ews-app] Gracefully handle the case when state_string is None
8572 https://bugs.webkit.org/show_bug.cgi?id=195753
8574 Reviewed by Lucas Forschler.
8576 * BuildSlaveSupport/ews-app/ews/models/build.py:
8577 * BuildSlaveSupport/ews-app/ews/models/step.py:
8579 2019-03-14 Aakash Jain <aakash_jain@apple.com>
8581 [ews-app] Status bubble display pending for currently running build step
8582 https://bugs.webkit.org/show_bug.cgi?id=195744
8584 Reviewed by Lucas Forschler.
8586 * BuildSlaveSupport/ews-build/events.py:
8587 (Events.stepStarted): If state_string is pending, replace it with step name.
8589 2019-03-14 Chris Dumez <cdumez@apple.com>
8591 Add WebsitePolicy for the client to specify the device orientation & motion access policy
8592 https://bugs.webkit.org/show_bug.cgi?id=195750
8594 Reviewed by Geoffrey Garen.
8596 Add API test coverage.
8598 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
8599 (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
8600 (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
8601 (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
8603 2019-03-14 Chris Dumez <cdumez@apple.com>
8605 [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
8606 https://bugs.webkit.org/show_bug.cgi?id=195747
8608 Reviewed by Geoff Garen.
8610 Add API test coverage.
8612 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
8614 2019-03-13 Wenson Hsieh <wenson_hsieh@apple.com>
8616 Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
8617 https://bugs.webkit.org/show_bug.cgi?id=195725
8618 <rdar://problem/48545062>
8620 Reviewed by Tim Horton.
8622 Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
8625 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
8626 (TestWebKitAPI::TEST):
8628 2019-03-13 Sam Weinig <sam@webkit.org>
8630 Add utility function to allow easy reverse range-based iteration of a container
8631 https://bugs.webkit.org/show_bug.cgi?id=195542
8633 Reviewed by Antti Koivisto.
8635 * TestWebKitAPI/CMakeLists.txt:
8636 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
8637 * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
8638 (TestWebKitAPI::TEST):
8639 Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
8641 2019-03-13 Chris Dumez <cdumez@apple.com>
8643 Use a ServiceWorker process per registrable domain
8644 https://bugs.webkit.org/show_bug.cgi?id=195649
8646 Reviewed by Youenn Fablet.
8648 Update API test coverage.
8650 * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
8652 2019-03-13 Chris Dumez <cdumez@apple.com>
8654 REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
8655 https://bugs.webkit.org/show_bug.cgi?id=195684
8656 <rdar://problem/48294714>
8658 Reviewed by Antti Koivisto.
8660 Add API test coverage.
8662 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
8664 2019-03-13 Aakash Jain <aakash_jain@apple.com>
8666 [ews-app] Remove unused patch view
8667 https://bugs.webkit.org/show_bug.cgi?id=195669
8669 Reviewed by Lucas Forschler.
8671 * BuildSlaveSupport/ews-app/ews/urls.py:
8672 * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
8674 2019-03-13 Aakash Jain <aakash_jain@apple.com>
8676 [ews-app] Use Buildbot result code variables
8677 https://bugs.webkit.org/show_bug.cgi?id=195668
8679 Reviewed by Alexey Proskuryakov.
8681 * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
8682 (Buildbot): Added Buildbot result code variables.
8683 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
8684 (StatusBubble._build_bubble): Used Buildbot result code variables.
8686 2019-03-13 Thibault Saunier <tsaunier@igalia.com>
8688 [Flatpak] Expand submodule recursively
8689 https://bugs.webkit.org/show_bug.cgi?id=195672
8691 Building WPE with flatpak was impossible without that as it was raising an exception.
8692 Also update wpebackend-fdo to match what is built in jhbuild
8694 Reviewed by Philippe Normand.
8696 * flatpak/flatpakutils.py:
8697 (expand_submodules_recurse):
8699 * flatpak/org.webkit.WPEModules.yaml:
8701 2019-03-13 Aakash Jain <aakash_jain@apple.com>
8703 [ews-app] status bubble should be hidden for certain builds
8704 https://bugs.webkit.org/show_bug.cgi?id=194597
8706 Reviewed by Dewei Zhu.
8708 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
8709 (StatusBubble._build_bubble):
8710 (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
8711 because the patch didn't have relevant changes.
8712 (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
8715 2019-03-12 Ross Kirsling <ross.kirsling@sony.com>
8717 [Win] Fix a slew of simple clang-cl warnings.
8718 https://bugs.webkit.org/show_bug.cgi?id=195652
8720 Reviewed by Don Olmstead.
8722 * WebKitTestRunner/win/PlatformWebViewWin.cpp:
8723 (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
8725 2019-03-12 Justin Fan <justin_fan@apple.com>
8727 [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
8728 https://bugs.webkit.org/show_bug.cgi?id=195518
8729 <rdar://problem/46322356>
8731 Reviewed by Myles C. Maxfield.
8733 * DumpRenderTree/DerivedSources-input.xcfilelist:
8734 * DumpRenderTree/DerivedSources-output.xcfilelist:
8736 2019-03-12 Commit Queue <commit-queue@webkit.org>
8738 Unreviewed, rolling out r242825.
8739 https://bugs.webkit.org/show_bug.cgi?id=195648
8741 "Broke webkitpy tests with my change to
8742 lldb_dump_class_layout.py" (Requested by rmorisset on
8747 "Alter Tools/Scripts/dump-class-layout to be able to dump all
8748 classes with suspicious padding"
8749 https://bugs.webkit.org/show_bug.cgi?id=195573
8750 https://trac.webkit.org/changeset/242825
8752 2019-03-12 Aakash Jain <aakash_jain@apple.com>
8754 [ews-build] Show status bubbles while the patch is waiting in queue
8755 https://bugs.webkit.org/show_bug.cgi?id=195618
8757 Reviewed by Lucas Forschler.
8759 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
8760 (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are
8761 enabled in initial deployment.
8762 (StatusBubble._build_bubble): Display bubble even when build hasn't started.
8763 (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
8764 (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
8765 (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
8766 (StatusBubble._build_bubbles_for_patch):
8768 2019-03-12 Robin Morisset <rmorisset@apple.com>
8770 Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
8771 https://bugs.webkit.org/show_bug.cgi?id=195573
8773 Reviewed by Simon Fraser.
8775 Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
8777 * Scripts/dump-class-layout:
8779 * lldb/lldb_dump_class_layout.py:
8780 (ClassLayout.__init__):
8781 (ClassLayout._compute_padding_recursive):
8782 (LLDBDebuggerInstance.dump_layout_for_classname):
8783 (LLDBDebuggerInstance):
8784 (LLDBDebuggerInstance.dump_all_wasteful_layouts):
8785 (LLDBDebuggerInstance.layout_for_classname): Deleted.
8787 2019-03-12 Chris Dumez <cdumez@apple.com>
8789 Device Orientation access permission should be denied unless explicitly granted by the client
8790 https://bugs.webkit.org/show_bug.cgi?id=195625
8792 Reviewed by Youenn Fablet.
8794 add API test coverage.
8796 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
8797 * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
8798 (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
8799 (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
8800 (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
8801 (runDeviceOrientationTest):
8803 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
8804 (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
8806 2019-03-12 Jer Noble <jer.noble@apple.com>
8808 Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
8809 https://bugs.webkit.org/show_bug.cgi?id=195137
8810 <rdar://problem/48810307>
8812 Reviewed by Eric Carlson.
8814 * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
8815 (TestWebKitAPI::TEST):
8817 2019-03-12 Aakash Jain <aakash_jain@apple.com>
8819 [ews-build] Change urls from uat to production
8820 https://bugs.webkit.org/show_bug.cgi?id=195566
8822 Reviewed by Lucas Forschler.
8824 * BuildSlaveSupport/ews-app/ews/config.py:
8825 * BuildSlaveSupport/ews-build/events.py:
8826 * BuildSlaveSupport/ews-build/steps.py:
8828 2019-03-12 Aakash Jain <aakash_jain@apple.com>
8830 [ews-build] change max_builds for local-worker to 1
8831 https://bugs.webkit.org/show_bug.cgi?id=195568
8833 Reviewed by Lucas Forschler.
8835 * BuildSlaveSupport/ews-build/loadConfig.py:
8837 2019-03-12 Tim Horton <timothy_horton@apple.com>
8841 * TestRunnerShared/spi/PencilKitTestSPI.h:
8842 * TestWebKitAPI/ios/PencilKitTestSPI.h:
8844 2019-03-12 Michael Catanzaro <mcatanzaro@igalia.com>
8846 [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
8847 https://bugs.webkit.org/show_bug.cgi?id=194131
8849 Reviewed by Michael Catanzaro.
8851 * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
8853 (testUnfinishedSubresourceLoad):
8857 2019-03-11 Alex Christensen <achristensen@webkit.org>
8859 WTF::Expected should use std::addressof instead of operator&
8860 https://bugs.webkit.org/show_bug.cgi?id=195604
8862 Reviewed by Myles Maxfield.
8864 * TestWebKitAPI/Tests/WTF/Expected.cpp:
8865 (TestWebKitAPI::Unique::Unique):
8866 (TestWebKitAPI::Unique::operator&):
8867 (TestWebKitAPI::TEST):
8869 2019-03-11 Ross Kirsling <ross.kirsling@sony.com>
8871 Add Optional to Forward.h.
8872 https://bugs.webkit.org/show_bug.cgi?id=195586
8874 Reviewed by Darin Adler.
8876 * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
8877 * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
8878 Remove unnecessary includes from headers.
8880 2019-03-11 Simon Fraser <simon.fraser@apple.com>
8882 Add testing API to hit-test and scroll overflow scrollers
8883 https://bugs.webkit.org/show_bug.cgi?id=195278
8885 Reviewed by Antti Koivisto.
8887 Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
8888 testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
8890 Tests: scrollingcoordinator/ios/scroll-element-at-point.html
8892 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
8893 (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
8894 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
8895 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
8896 (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
8897 * TestRunnerShared/UIScriptContext/UIScriptController.h:
8898 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
8899 (WTR::enclosingScrollViewIncludingSelf):
8900 (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
8902 2019-03-11 Tim Horton <timothy_horton@apple.com>
8904 API test WebKit.RequestTextInputContext fails on iOS
8905 https://bugs.webkit.org/show_bug.cgi?id=195585
8907 Reviewed by Wenson Hsieh and Simon Fraser.
8909 * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
8912 Add a viewport, so that the coordinates match up on iOS.
8913 Scroll by moving the UIScrollView's contentOffset.
8915 2019-03-11 Chris Dumez <cdumez@apple.com>
8917 Assert in WebPageProxy::suspendCurrentPageIfPossible()
8918 https://bugs.webkit.org/show_bug.cgi?id=195506
8919 <rdar://problem/48733477>
8921 Reviewed by Alex Christensen.
8923 Add API test coverage.
8925 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
8927 2019-03-11 Shawn Roberts <sroberts@apple.com>
8929 Adding myself to contributors.json
8931 Unreviewed, addming myself to contributors.json .
8933 * Scripts/webkitpy/common/config/contributors.json:
8935 2019-03-11 Alex Christensen <achristensen@webkit.org>
8937 Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
8938 https://bugs.webkit.org/show_bug.cgi?id=195511
8939 <rdar://problem/44873269>
8941 Reviewed by Darin Adler.
8943 * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
8944 (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
8945 (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
8948 2019-03-11 Chris Dumez <cdumez@apple.com>
8950 Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
8951 https://bugs.webkit.org/show_bug.cgi?id=195561
8953 Reviewed by Youenn Fablet.
8955 Make sure the JS in the test requests for permission to receive device orientation events.
8957 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
8959 2019-03-11 Youenn Fablet <youenn@apple.com>
8961 Allow storage quota increase by default in WTR
8962 https://bugs.webkit.org/show_bug.cgi?id=195541
8964 Reviewed by Geoffrey Garen.
8966 Allow storage quota increase by default in WTR.
8967 Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
8968 Use this for tests that explicitly need cache increase.
8970 Instead of increasing quota by 2, make sure the next request is
8971 granted by adding all given parameters.
8973 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
8974 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
8975 (WTR::TestRunner::setAllowStorageQuotaIncrease):
8976 (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
8977 * WebKitTestRunner/InjectedBundle/TestRunner.h:
8978 * WebKitTestRunner/TestController.cpp:
8979 (WTR::TestController::setAllowStorageQuotaIncrease):
8980 (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
8981 * WebKitTestRunner/TestController.h:
8982 * WebKitTestRunner/TestInvocation.cpp:
8983 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
8984 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
8985 (WTR::TestController::cocoaResetStateToConsistentValues):
8986 (WTR::TestController::setAllowStorageQuotaIncrease):
8987 (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
8988 * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
8989 (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
8991 2019-03-11 Xan Lopez <xan@igalia.com>
8993 [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
8994 https://bugs.webkit.org/show_bug.cgi?id=194147
8996 Reviewed by Michael Saboff.
8998 To make --32-bit work correctly on Linux/64bit we need to:
9000 - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
9001 correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
9002 unfortunately CMake only allows us to do this during
9003 crosscompilation, which is overkill here.
9004 - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
9005 pkg-config detection module uses the x86 .pc files instead of the
9007 - Set the -m32 flags for the compiler.
9009 * Scripts/webkitdirs.pm:
9010 (generateBuildSystemFromCMakeProject):
9012 2019-03-08 Dewei Zhu <dewei_zhu@apple.com>
9014 Add MotionMark-1.1 plan file for run-benchmark script.
9015 https://bugs.webkit.org/show_bug.cgi?id=195481
9017 Rubber-stamped by Darin Adler.
9019 Run-benchmark script should support MontionMark-1.1.
9021 * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
9023 2019-03-11 Aakash Jain <aakash_jain@apple.com>
9025 [ews-app] Add support for submit-to-ews url
9026 https://bugs.webkit.org/show_bug.cgi?id=195477
9028 Reviewed by Lucas Forschler.
9030 * BuildSlaveSupport/ews-app/ews/fetcher.py:
9031 * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
9032 * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
9033 * BuildSlaveSupport/ews-app/ews/urls.py:
9034 * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
9036 2019-03-11 Ryan Haddad <ryanhaddad@apple.com>
9038 Unreviewed, rolling out r242688, r242643, r242624.
9040 Caused multiple layout test failures and crashes on iOS and macOS.
9044 "requestAnimationFrame should execute before the next frame"
9045 https://bugs.webkit.org/show_bug.cgi?id=177484
9046 https://trac.webkit.org/changeset/242624/webkit
9048 * Tracing/SystemTracePoints.plist:
9050 2019-03-11 John Wilander <wilander@apple.com>
9052 Resource Load Statistics: Make it possible exclude localhost from classification
9053 https://bugs.webkit.org/show_bug.cgi?id=195474
9054 <rdar://problem/47520577>
9056 Reviewed by Brent Fulgham.
9058 This patch allows for localhost to be excluded from classification and
9059 treatment as a prevalent resource.
9061 The WebKit Tools change adds a new function called
9062 testRunner.setStatisticsIsRunningTest() which can be used to control this
9065 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
9066 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
9067 (WTR::TestRunner::setStatisticsIsRunningTest):
9068 * WebKitTestRunner/InjectedBundle/TestRunner.h:
9069 * WebKitTestRunner/TestController.cpp:
9070 (WTR::TestController::setStatisticsIsRunningTest):
9071 * WebKitTestRunner/TestController.h:
9072 * WebKitTestRunner/TestInvocation.cpp:
9073 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
9075 2019-03-11 Aakash Jain <aakash_jain@apple.com>
9077 [ews-build] Disable waterfall and console view for ews-build.webkit.org
9078 https://bugs.webkit.org/show_bug.cgi?id=195560
9080 Reviewed by Lucas Forschler.
9082 * BuildSlaveSupport/ews-build/master.cfg:
9084 2019-03-11 Alex Christensen <achristensen@webkit.org>
9086 Unreviewed, rolling out r242698.
9088 API test crashes on bots.
9092 "Add a WKContentRuleList variant that uses copied memory
9093 instead of mmap'd shared memory for class A containerized
9095 https://bugs.webkit.org/show_bug.cgi?id=195511
9096 https://trac.webkit.org/changeset/242698
9098 2019-03-11 Michael Catanzaro <mcatanzaro@igalia.com>
9100 [WPE] Enable web process sandbox
9101 https://bugs.webkit.org/show_bug.cgi?id=195169
9103 Reviewed by Daniel Bates.
9105 * wpe/install-dependencies:
9106 * wpe/jhbuild.modules:
9108 2019-03-11 Aakash Jain <aakash_jain@apple.com>
9110 [ews-app] Use port 17000 for worker communication
9111 https://bugs.webkit.org/show_bug.cgi?id=195558
9113 Reviewed by Lucas Forschler.
9115 * BuildSlaveSupport/ews-build/master.cfg:
9117 2019-03-11 Aakash Jain <aakash_jain@apple.com>
9119 [ews-build] unit-tests fail when passwords.json is missing
9120 https://bugs.webkit.org/show_bug.cgi?id=195557
9122 Reviewed by Lucas Forschler.
9124 * BuildSlaveSupport/ews-build/loadConfig.py:
9125 (loadBuilderConfig):
9126 * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
9127 (ConfigDotJSONTest.test_configuration):
9128 * BuildSlaveSupport/ews-build/master.cfg:
9130 2019-03-11 Truitt Savell <tsavell@apple.com>
9132 Unreviewed, rolling out r242702.
9134 Broke High Sierra builders.
9138 "Add utility function to allow easy reverse range-based
9139 iteration of a container"
9140 https://bugs.webkit.org/show_bug.cgi?id=195542
9141 https://trac.webkit.org/changeset/242702
9143 2019-03-11 Sam Weinig <sam@webkit.org>
9145 Add utility function to allow easy reverse range-based iteration of a container
9146 https://bugs.webkit.org/show_bug.cgi?id=195542
9148 Reviewed by Antti Koivisto.
9150 * TestWebKitAPI/CMakeLists.txt:
9151 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9152 * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
9153 (TestWebKitAPI::TEST):
9154 Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
9156 2019-03-10 Alex Christensen <achristensen@webkit.org>
9158 Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
9159 https://bugs.webkit.org/show_bug.cgi?id=195511
9160 <rdar://problem/44873269>
9162 Reviewed by Darin Adler.
9164 * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
9165 (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
9166 (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
9169 2019-03-10 Tim Horton <timothy_horton@apple.com>
9171 Add SPI to retrieve the set of text inputs in a given rect, and later focus one
9172 https://bugs.webkit.org/show_bug.cgi?id=195499
9174 Reviewed by Darin Adler.
9176 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9177 * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
9178 (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
9179 (-[WKWebView synchronouslyFocusTextInputContext:]):
9183 Add some tests for this SPI.
9185 2019-03-10 Yusuke Suzuki <utatane.tea@gmail.com>
9187 [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
9188 https://bugs.webkit.org/show_bug.cgi?id=181151
9190 Reviewed by Don Olmstead.
9192 * TestWebKitAPI/CMakeLists.txt:
9193 * TestWebKitAPI/PlatformWin.cmake:
9194 Enable TestWTF RunLoop tests in all platforms.
9196 * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
9197 (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
9198 (TestWebKitAPI::DerivedOneShotTimer::fired):
9199 (TestWebKitAPI::TEST):
9200 Only a few platforms support nested RunLoop.
9202 (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
9203 (TestWebKitAPI::DerivedRepeatingTimer::fired):
9205 2019-03-10 David Quesada <david_quesada@apple.com>
9207 ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
9208 https://bugs.webkit.org/show_bug.cgi?id=152480
9210 Reviewed by Chris Dumez.
9212 Add a unit test based on Daniel Bates's test case that starts a download, ensures
9213 there are no additional references to the process pool besides the one held by
9214 the download, waits for the download to finish (in the sense that the
9215 DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
9216 measure, also check that the process pool has been deallocated at the end of the
9217 test. The test wouldn't be meaningful if the process pool were still alive.
9219 * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
9220 (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
9221 (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
9222 The download will be canceled because the delegate does not implement the
9223 method to decide the download's destination, so this is where we know the
9224 DownloadProxyMap is done with the DownloadProxy.
9227 2019-03-08 Chris Dumez <cdumez@apple.com>
9229 Add support for Device Orientation / Motion permission API
9230 https://bugs.webkit.org/show_bug.cgi?id=195329
9231 <rdar://problem/47645367>
9233 Reviewed by Geoffrey Garen.
9235 Add test infrastructure to help test the Device Orientation / Motion permission API.
9237 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
9238 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
9239 (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
9240 * WebKitTestRunner/InjectedBundle/TestRunner.h:
9241 * WebKitTestRunner/TestController.cpp:
9242 (WTR::shouldAllowDeviceOrientationAndMotionAccess):
9243 (WTR::TestController::createWebViewWithOptions):
9244 (WTR::TestController::resetStateToConsistentValues):
9245 (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
9246 * WebKitTestRunner/TestController.h:
9247 (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
9248 * WebKitTestRunner/TestInvocation.cpp:
9249 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
9251 2019-03-08 Saam barati <sbarati@apple.com>
9253 Add a compare-results script to compare benchmark results
9254 https://bugs.webkit.org/show_bug.cgi?id=195486
9255 <rdar://problem/48723397>
9257 Reviewed by Geoffrey Garen.
9259 This patch adds a script to compare benchmark results using Welch's two-tailed t test.
9260 Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
9261 to extend it to learn about our other benchmarks.
9263 * Scripts/compare-results: Added.
9266 (JetStream2Results):
9267 (detectSpeedometer2):
9268 (Speedometer2Results):
9277 2019-03-08 Stephanie Lewis <slewis@apple.com>
9279 Ensure old tab state is cleared between iterations of run-benchmark
9280 https://bugs.webkit.org/show_bug.cgi?id=195393
9281 <rdar://problem/46885583>
9283 Reviewed by Dewei Zhu.
9285 a) ensure the default to restore state is not set
9286 b) terminate Safari correctly
9287 c) Set the system default to ignore Persistent State in Safari
9289 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
9290 (OSXBrowserDriver): fix terminate processes to call terminate before killing.
9291 (OSXBrowserDriver.prepare_env):
9292 (OSXBrowserDriver.restore_env):
9293 (OSXBrowserDriver.close_browsers):
9294 (OSXBrowserDriver._terminate_processes):
9295 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
9297 (OSXChromeCanaryDriver):
9298 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
9300 (OSXFirefoxNightlyDriver):
9301 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
9303 (OSXSafariDriver.prepare_env):
9305 2019-03-08 Diego Pino Garcia <dpino@igalia.com>
9307 [GTK] Several InputMethodFilter tests are failing
9308 https://bugs.webkit.org/show_bug.cgi?id=195408
9310 Reviewed by Carlos Garcia Campos.
9312 * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
9313 Regressed in r241751.
9314 Hexadecimal values of keycodes are expressed now in upper letters.
9315 Composited characters should be cast to UTF8 strings.
9317 (TestWebKitAPI::TEST):
9319 2019-03-07 Tomas Popela <tpopela@redhat.com>
9321 [GTK] Make Tools/gtkdoc python3 compatible
9322 https://bugs.webkit.org/show_bug.cgi?id=195359
9324 Reviewed by Carlos Garcia Campos.
9326 * gtkdoc/generate-gtkdoc:
9327 ConfigParser was reworked in Python 3.2 so we have adapt the code to
9328 work with Python 2 and 3.
9329 (get_gtkdoc_module_paths):
9330 The iteritems() was removed in Python 3, so let's use items() that's
9331 available in Python 2 and 3.
9332 (get_generator_for_config):
9334 (GTKDoc._run_command):
9335 The sys.stdout.write() is expecting str in Python 3 and not bytes
9336 (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
9337 for passing the bytes there.
9339 2019-03-07 Fujii Hironori <Hironori.Fujii@sony.com>
9341 [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
9342 https://bugs.webkit.org/show_bug.cgi?id=195346
9343 <rdar://problem/48667048>
9345 Unreviewed build fix for clang-cl.
9347 * DumpRenderTree/win/DumpRenderTree.cpp:
9348 (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
9350 2019-03-07 Said Abou-Hallawa <sabouhallawa@apple.com>
9352 requestAnimationFrame should execute before the next frame
9353 https://bugs.webkit.org/show_bug.cgi?id=177484
9355 Reviewed by Simon Fraser.
9357 Add trace points for the page RenderingUpdate.
9359 * Tracing/SystemTracePoints.plist:
9361 2019-03-07 Zalan Bujtas <zalan@apple.com>
9363 [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
9364 https://bugs.webkit.org/show_bug.cgi?id=195353
9365 <rdar://problem/48626394>
9367 Reviewed by Simon Fraser.
9369 * WebKitTestRunner/ios/TestControllerIOS.mm:
9370 (WTR::TestController::platformResetPreferencesToConsistentValues):
9372 2019-03-07 John Wilander <wilander@apple.com>
9374 Resource Load Statistics: Make it possible to purge only script-accessible cookies
9375 https://bugs.webkit.org/show_bug.cgi?id=195383
9376 <rdar://problem/48570136>
9378 Reviewed by Brent Fulgham.
9380 This patch adds test infrastructure to purge only script-accessible cookies,
9381 including a new testRunner function called statisticsDeleteCookiesForHost().git a
9383 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
9384 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
9385 (WTR::TestRunner::statisticsDeleteCookiesForHost):
9386 * WebKitTestRunner/InjectedBundle/TestRunner.h:
9387 * WebKitTestRunner/TestController.cpp:
9388 (WTR::TestController::statisticsDeleteCookiesForHost):
9389 * WebKitTestRunner/TestController.h:
9390 * WebKitTestRunner/TestInvocation.cpp:
9391 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
9393 2019-03-07 Commit Queue <commit-queue@webkit.org>
9395 Unreviewed, rolling out r242354.
9396 https://bugs.webkit.org/show_bug.cgi?id=195402
9398 breaks layout tests in all configurations (Requested by
9399 zdobersek on #webkit).
9403 "[WPE] Enable web process sandbox"
9404 https://bugs.webkit.org/show_bug.cgi?id=195169
9405 https://trac.webkit.org/changeset/242354
9407 2019-03-06 Ross Kirsling <ross.kirsling@sony.com>
9409 [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
9410 https://bugs.webkit.org/show_bug.cgi?id=195346
9412 Reviewed by Fujii Hironori.
9414 * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
9415 (TestWebKitAPI::TEST):
9416 Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
9418 * DumpRenderTree/win/DumpRenderTree.cpp:
9420 (addFontFallbackIfPresent):
9421 (removeFontFallbackIfPresent):
9423 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
9424 (TestWebKitAPI::Util::moduleDirectory):
9425 (TestWebKitAPI::Util::createInjectedBundlePath):
9426 Use wchar helpers as needed.
9428 2019-03-06 Rob Buis <rbuis@igalia.com>
9430 Consider supporting the `referrerpolicy` attribute.
9431 https://bugs.webkit.org/show_bug.cgi?id=179053
9433 Reviewed by Darin Adler.
9435 Add a runtime flag for referrerpolicy attribute.
9437 * DumpRenderTree/mac/DumpRenderTree.mm:
9438 (enableExperimentalFeatures):
9440 2019-03-05 Daniel Bates <dabates@apple.com>
9442 Update expected API test result following r242379
9443 (https://bugs.webkit.org/show_bug.cgi?id=195125)
9445 Update expected x-coordinate of selection rect now that the left padding of
9446 a textarea is sized in ems (so dependent on the font size) just like the left
9447 padding of a text field.
9449 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
9450 (TestWebKitAPI::TEST):
9452 2019-03-05 David Quesada <david_quesada@apple.com>
9454 [WK2] It should be possible to follow links with 'download' attributes
9455 https://bugs.webkit.org/show_bug.cgi?id=195145
9456 rdar://problem/48462642
9458 Reviewed by Alex Christensen.
9460 Add a unit test to verify that activating links with 'download' attributes now
9461 navigates to the linked resource, rather than starts downloading it. Add another
9462 to verify that it is still possible to explicitly download the link via the
9463 'Download' navigation action policy.
9465 * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
9466 (-[DownloadAttributeTestDelegate init]):
9467 (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
9468 (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
9469 (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
9470 (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
9471 (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
9472 (-[DownloadAttributeTestDelegate _downloadDidStart:]):
9474 * WebKitTestRunner/TestController.cpp:
9475 (WTR::TestController::decidePolicyForNavigationAction):
9476 * WebKitTestRunner/TestController.h:
9478 2019-03-05 Takashi Komori <Takashi.Komori@sony.com>
9480 [Curl] Implement Cookie Accept Policy.
9481 https://bugs.webkit.org/show_bug.cgi?id=191645
9483 Reviewed by Fujii Hironori.
9485 * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
9486 (TestWebKitAPI::Curl::TEST_F):
9488 2019-03-05 Youenn Fablet <youenn@apple.com>
9490 Rename requestCacheStorageSpace to requestStorageSpace
9491 https://bugs.webkit.org/show_bug.cgi?id=195282
9493 Reviewed by Chris Dumez.
9495 * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
9496 (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
9497 (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
9499 2019-03-05 Brady Eidson <beidson@apple.com>
9501 Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
9502 <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
9504 Reviewed by Tim Horton.
9506 Loading a file: URL into a WKWebView and then loading another file: url from a completely
9507 different directory into that same WKWebView should work.
9509 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9510 * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
9512 2019-02-28 Ryosuke Niwa <rniwa@webkit.org>
9515 https://bugs.webkit.org/show_bug.cgi?id=195152
9517 Reviewed by Antti Koivisto.
9519 Added tests for WeakHashSet.
9521 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
9522 (TestWebKitAPI::Base::Base): Moved.
9523 (TestWebKitAPI::Derived::foo): Moved.
9524 (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
9525 (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
9526 (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
9527 (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
9529 2019-03-04 Chris Dumez <cdumez@apple.com>
9531 Do not share WebProcesses between private and regular sessions
9532 https://bugs.webkit.org/show_bug.cgi?id=195189
9533 <rdar://problem/48421064>
9535 Reviewed by Alex Christensen.
9537 Add API test coverage.
9539 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
9540 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
9542 2019-03-04 Michael Catanzaro <mcatanzaro@igalia.com>
9544 [WPE] Enable web process sandbox
9545 https://bugs.webkit.org/show_bug.cgi?id=195169
9547 Reviewed by Daniel Bates.
9549 * wpe/install-dependencies:
9550 * wpe/jhbuild.modules:
9552 2019-03-04 Carlos Garcia Campos <cgarcia@igalia.com>
9554 [GLib] Returning G_TYPE_OBJECT from a constructor does not work
9555 https://bugs.webkit.org/show_bug.cgi?id=195206
9557 Reviewed by Žan Doberšek.
9559 Add a new test case.
9561 * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
9564 2019-03-04 Charlie Turner <cturner@igalia.com>
9566 [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
9567 https://bugs.webkit.org/show_bug.cgi?id=194898
9569 Reviewed by Žan Doberšek.
9571 * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
9572 a GCC extension that permits arithmetic on void* pointer. Inline
9573 the macro until this issue is fixed upstream.
9575 2019-03-03 Tim Horton <timothy_horton@apple.com>
9577 Rid the world of WK_API_ENABLED
9578 https://bugs.webkit.org/show_bug.cgi?id=195263
9580 Reviewed by Dan Bernstein.
9582 List of changed files elided because it's useless.
9584 2019-03-03 Ross Kirsling <ross.kirsling@sony.com>
9586 Unreviewed follow-up to r242292.
9588 By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
9590 * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
9591 (TestWebKitAPI::testStrip): Renamed from strip.
9592 (TestWebKitAPI::TEST):
9594 2019-03-03 Michael Catanzaro <mcatanzaro@igalia.com>
9596 Unreviewed, remove accidentally-committed URLHelpers.cpp test
9598 This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
9599 and bug #194272 for details.
9601 * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
9603 2019-03-03 Tim Horton <timothy_horton@apple.com>
9605 Remove some more unused 32-bit code
9606 https://bugs.webkit.org/show_bug.cgi?id=195255
9608 Reviewed by Darin Adler.
9610 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9611 * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
9612 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
9615 (handleEventCarbon): Deleted.
9617 2019-03-02 Ross Kirsling <ross.kirsling@sony.com>
9619 Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
9621 * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
9622 (TestWebKitAPI::TEST):
9624 2019-03-01 Darin Adler <darin@apple.com>
9626 Finish removing String::format
9627 https://bugs.webkit.org/show_bug.cgi?id=194893
9629 Reviewed by Daniel Bates.
9631 * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
9633 2019-03-01 Alex Christensen <achristensen@webkit.org>
9635 Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
9636 https://bugs.webkit.org/show_bug.cgi?id=195229
9637 <rdar://problem/48520362>
9639 Reviewed by Chris Dumez.
9641 * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
9644 2019-03-01 Simon Fraser <simon.fraser@apple.com>
9646 Add a system trace scope for event region building
9647 https://bugs.webkit.org/show_bug.cgi?id=195226
9649 Reviewed by Jon Lee.
9651 This trace scope measures the time spend converting element rects into Region objects,
9652 which can be large on some pages.
9654 The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
9656 * Tracing/SystemTracePoints.plist:
9658 2019-03-01 Ross Kirsling <ross.kirsling@sony.com>
9660 EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
9661 https://bugs.webkit.org/show_bug.cgi?id=194612
9663 Reviewed by Alex Christensen.
9665 * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
9666 Just test the new string-processing function and don't touch the actual environment.
9667 (Test cases are all as before, but based on operator== instead of strcmp.)
9669 2019-03-01 Aakash Jain <aakash_jain@apple.com>
9671 [ews-app] Update primary keys for handling multiple Buildbot instances
9672 https://bugs.webkit.org/show_bug.cgi?id=195120
9674 Reviewed by Stephanie Lewis.
9676 Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
9677 were not enough to handle multiple buildbot instances. This new primary key uid would be generated
9678 by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
9680 * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
9681 * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
9682 * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
9683 * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
9684 * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
9685 * BuildSlaveSupport/ews-build/master.cfg: Ditto.
9687 2019-03-01 Don Olmstead <don.olmstead@sony.com>
9689 [WinCairo] Enable service worker
9690 https://bugs.webkit.org/show_bug.cgi?id=188318
9692 Reviewed by Youenn Fablet.
9694 * DumpRenderTree/DumpRenderTreePrefix.h:
9695 * TestWebKitAPI/PlatformWin.cmake:
9696 * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
9697 * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
9698 * WebKitTestRunner/WebKitTestRunnerPrefix.h:
9700 2019-03-01 Justin Fan <justin_fan@apple.com>
9702 [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
9703 https://bugs.webkit.org/show_bug.cgi?id=195191
9705 Rubber-stamped by Dean Jackson.
9707 Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
9709 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
9711 2019-03-01 Yusuke Suzuki <ysuzuki@apple.com>
9713 Unreviewed, fix lldb webkitpy tests
9714 https://bugs.webkit.org/show_bug.cgi?id=194375
9716 Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
9718 * lldb/lldb_webkit.py:
9719 (WTFStringImplProvider.is_8bit):
9721 2019-02-28 David Quesada <david_quesada@apple.com>
9723 Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
9724 https://bugs.webkit.org/show_bug.cgi?id=195121
9725 rdar://problem/48450302
9727 Reviewed by Alex Christensen.
9729 Add API tests for -WKNavigationAction._shouldPerformDownload in various
9730 configurations where the 'download' attribute is absent, blank, or populated
9731 with a filename, and where the anchor element is same-origin or cross-origin
9732 (meaning the 'download' attribute shouldn't be honored).
9734 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9735 * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
9736 (-[NavigationActionTestDelegate init]):
9737 (-[NavigationActionTestDelegate navigationAction]):
9738 (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
9739 (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
9740 (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
9741 (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
9744 2019-02-28 Antoine Quint <graouts@apple.com>
9746 Enable the Pointer Events runtime flag by default
9747 https://bugs.webkit.org/show_bug.cgi?id=195156
9749 Reviewed by Dean Jackson.
9751 * DumpRenderTree/mac/DumpRenderTree.mm:
9752 (enableExperimentalFeatures):
9754 2019-02-28 Wenson Hsieh <wenson_hsieh@apple.com>
9756 Several PasteImage API tests are flaky
9757 https://bugs.webkit.org/show_bug.cgi?id=195160
9759 Reviewed by Tim Horton.
9761 Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
9762 querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
9763 listening for a "load" event after image load is already complete.
9765 To address this, make these tests first register a "load" event handler, then run script to insert an image
9766 element into the document, and finally wait until the load event is observed before checking image size.
9768 * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
9770 2019-02-28 Chris Dumez <cdumez@apple.com>
9772 Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
9773 https://bugs.webkit.org/show_bug.cgi?id=195107
9775 Reviewed by Alex Christensen.
9777 Give some time for the zoom level to get restored.
9779 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
9781 2019-02-28 Sihui Liu <sihui_liu@apple.com>
9783 Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
9784 https://bugs.webkit.org/show_bug.cgi?id=194958
9786 Reviewed by Geoffrey Garen.
9788 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
9791 2019-02-28 Aakash Jain <aakash_jain@apple.com>
9793 [ews-app] Update method to save build to handle builder_display_name
9794 https://bugs.webkit.org/show_bug.cgi?id=195047
9796 Reviewed by Dewei Zhu.
9798 * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
9799 * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
9801 2019-02-28 Justin Fan <justin_fan@apple.com>
9803 [Web GPU] Enable Web GPU only on 64-bit
9804 https://bugs.webkit.org/show_bug.cgi?id=195139
9806 Because Metal is only supported on 64 bit apps.
9808 Unreviewed build fix.
9810 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
9812 2019-02-27 Youenn Fablet <youenn@apple.com>
9814 Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
9815 https://bugs.webkit.org/show_bug.cgi?id=194959
9817 Reviewed by Chris Dumez.
9819 Spin loop until getting the condition to remove flakiness.
9821 * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
9823 2019-02-27 Aakash Jain <aakash_jain@apple.com>
9825 [ews-build] Buildbot should include builder_display_name in the build events
9826 https://bugs.webkit.org/show_bug.cgi?id=195045
9828 Reviewed by Dewei Zhu.
9830 * BuildSlaveSupport/ews-build/events.py:
9831 (Events.buildStarted): Included builder_display_name in event data. Also renamed
9832 buildername to builder_name to be consistent in naming style.
9833 (Events.buildFinished): Ditto.
9835 2019-02-27 Chris Dumez <cdumez@apple.com>
9837 Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
9838 https://bugs.webkit.org/show_bug.cgi?id=194480
9840 Reviewed by Brady Eidson.
9842 Update existing API test to make it more likely to reproduce the issue.
9844 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
9846 2019-02-27 Brady Eidson <beidson@apple.com>
9848 Universal links from Google search results pages don't open the app.
9849 <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
9851 Reviewed by Geoffrey Garen.
9853 * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
9854 * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
9855 * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
9856 (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
9858 2019-02-27 Chris Dumez <cdumez@apple.com>
9860 Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
9861 https://bugs.webkit.org/show_bug.cgi?id=195102
9863 Reviewed by Geoffrey Garen.
9865 If the number of processes is not yet what we expect, wait a bit and check again to give
9866 processes some time to exit.
9868 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
9870 2019-02-27 Chris Dumez <cdumez@apple.com>
9872 Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
9873 https://bugs.webkit.org/show_bug.cgi?id=194545
9875 Reviewed by Brady Eidson.
9877 Make sure the test navigates forward and then back only once. Previously, navigating
9878 back would trigger a navigation again in a timer.
9880 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
9882 2019-02-13 Ryan Haddad <ryanhaddad@apple.com>
9884 High Sierra Debug JSC test queue should use faster hardware
9885 https://bugs.webkit.org/show_bug.cgi?id=194603
9887 Rubber-stamped by Alexey Proskuryakov.
9889 Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
9891 * BuildSlaveSupport/build.webkit.org-config/config.json:
9892 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
9893 (BubbleQueueServer):
9894 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
9896 * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
9897 * QueueStatusServer/config/queues.py:
9898 * Scripts/webkitpy/common/config/ews.json:
9899 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
9902 2019-02-27 John Wilander <wilander@apple.com>
9904 Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
9905 https://bugs.webkit.org/show_bug.cgi?id=195071
9906 <rdar://problem/48417690>
9908 Reviewed by Alex Christensen and Brent Fulgham.
9910 * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
9911 (TestWebKitAPI::createURL):
9912 Convenience function.
9913 (TestWebKitAPI::TEST):
9914 WebCore::AdClickAttribution now takes a URL when creating Source and
9916 * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
9917 (TestWebKitAPI::TEST):
9918 WebCore::AdClickAttribution now takes a URL when creating Source and
9921 2019-02-27 Antoine Quint <graouts@apple.com>
9923 Support Pointer Events on macOS
9924 https://bugs.webkit.org/show_bug.cgi?id=195008
9925 <rdar://problem/47454419>
9927 Reviewed by Dean Jackson.
9929 * DumpRenderTree/mac/DumpRenderTree.mm:
9930 (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
9931 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
9933 2019-02-26 Mark Lam <mark.lam@apple.com>
9935 Remove remaining poisoning code.
9936 https://bugs.webkit.org/show_bug.cgi?id=194138
9938 Reviewed by Saam Barati.
9940 * TestWebKitAPI/CMakeLists.txt:
9941 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9942 * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
9943 * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
9944 * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
9945 * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
9946 * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
9947 * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
9949 2019-02-26 Alex Christensen <achristensen@webkit.org>
9951 Move ephemeral local storage from WebProcess to UIProcess
9952 https://bugs.webkit.org/show_bug.cgi?id=195074
9953 <rdar://problem/47937975>
9955 Reviewed by Geoff Garen.
9957 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
9959 2019-02-20 Jer Noble <jer.noble@apple.com>
9961 [Cocoa] Media elements will restart network buffering just before suspending
9962 https://bugs.webkit.org/show_bug.cgi?id=193691
9964 Reviewed by Eric Carlson.
9966 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9967 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
9970 2019-02-26 Takashi Komori <Takashi.Komori@sony.com>
9972 [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
9973 https://bugs.webkit.org/show_bug.cgi?id=191652
9975 Reviewed by Alex Christensen.
9977 Fix WinCairo MiniBrowser behavior of authentication dialog.
9979 * MiniBrowser/win/WebKitBrowserWindow.cpp:
9980 (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
9982 2019-02-26 Youenn Fablet <youenn@apple.com>
9984 WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
9985 https://bugs.webkit.org/show_bug.cgi?id=195028
9986 <rdar://problem/48243733>
9988 Reviewed by Eric Carlson.
9990 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
9992 2019-02-26 Philippe Normand <pnormand@igalia.com>
9994 [WPE] Add API for webview background color configuration
9995 https://bugs.webkit.org/show_bug.cgi?id=192305
9997 Reviewed by Michael Catanzaro.
9999 * MiniBrowser/wpe/main.cpp:
10000 (main): Add a new option to configure the webview background
10001 color. Example: --bg-color=transparent.
10002 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
10003 (testWebViewBackgroundColor): Enable background color API tests for WPE.
10004 (beforeAll): Ditto.
10006 2019-02-25 Yongjun Zhang <yongjun_zhang@apple.com>
10008 scalableNativeWebpageParameters() is not preserved on new page navigation.
10009 https://bugs.webkit.org/show_bug.cgi?id=194892
10010 <rdar://problem/47538280>
10012 Reviewed by Wenson Hsieh.
10014 Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
10016 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
10017 (WTR::UIScriptController::setAllowsViewportShrinkToFit):
10018 * DumpRenderTree/mac/UIScriptControllerMac.mm:
10019 (WTR::UIScriptController::allowsViewportShrinkToFit):
10020 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
10021 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
10022 (WTR::UIScriptController::setAllowsViewportShrinkToFit):
10023 * TestRunnerShared/UIScriptContext/UIScriptController.h:
10024 * WebKitTestRunner/UIScriptControllerCocoa.mm:
10025 (WTR::UIScriptController::setAllowsViewportShrinkToFit):
10027 2019-02-25 Aakash Jain <aakash_jain@apple.com>
10029 [ews-app] Add model for handling multiple Buildbot instances
10030 https://bugs.webkit.org/show_bug.cgi?id=194863
10032 Reviewed by Stephanie Lewis.
10034 * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
10036 2019-02-25 Aakash Jain <aakash_jain@apple.com>
10038 [ews-app] Remove BuilderMapping table
10039 https://bugs.webkit.org/show_bug.cgi?id=194961
10041 Reviewed by Stephanie Lewis.
10043 Store builder name directly in build table, instead of having a separate
10046 * BuildSlaveSupport/ews-app/ews/models/__init__.py:
10047 * BuildSlaveSupport/ews-app/ews/models/build.py:
10048 * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
10049 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
10051 2019-02-25 John Wilander <wilander@apple.com>
10053 Introduce and adopt new class RegistrableDomain for eTLD+1
10054 https://bugs.webkit.org/show_bug.cgi?id=194791
10055 <rdar://problem/48179240>
10057 Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
10059 This patch adds an API test and replaces two instances of
10060 "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
10062 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10063 * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
10064 (TestWebKitAPI::TEST):
10065 Changed two strings to make sure the registrable domains are still considered
10066 invalid and pass the test.
10067 * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
10068 (TestWebKitAPI::TEST):
10069 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
10070 (WTR::InjectedBundle::didReceiveMessageToPage):
10072 2019-02-25 Adrian Perez de Castro <aperez@igalia.com>
10074 [WPE] Bump WPEBackend-fdo requirement to API version 1.0
10075 https://bugs.webkit.org/show_bug.cgi?id=195001
10077 Reviewed by Carlos Garcia Campos.
10079 API version 1.0 always includes the functionality previously guarded with
10080 WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
10083 * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
10084 (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
10085 * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
10086 (WebViewTest::showInWindow): Ditto.
10087 (WebViewTest::hideView): Ditto.
10088 * wpe/backends/HeadlessViewBackend.cpp:
10089 (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
10090 * wpe/backends/ViewBackend.cpp:
10091 (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
10092 * wpe/backends/WindowViewBackend.cpp:
10093 (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
10094 WPE_BACKEND_CHECK_VERSION().
10095 * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
10097 2019-02-25 Thibault Saunier <tsaunier@igalia.com>
10099 [Flatpak] Add support for flatpak > 1.1.2
10100 https://bugs.webkit.org/show_bug.cgi?id=194088
10102 Flatpak 1.2 is now out so we need to support that
10105 Reviewed by Michael Catanzaro.
10107 * flatpak/flatpakutils.py:
10109 (FlatpakPackages.__init__):
10110 (FlatpakPackages.__detect_packages):
10111 (FlatpakPackages.__detect_packages.in):
10112 (FlatpakRepos.update):
10114 2019-02-25 Zan Dobersek <zdobersek@igalia.com>
10116 [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
10117 https://bugs.webkit.org/show_bug.cgi?id=194998
10119 Reviewed by Carlos Garcia Campos.
10121 * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
10122 to a Git checkout and using the latest commit containing various fixes
10125 2019-02-24 Michael Catanzaro <mcatanzaro@igalia.com>
10127 [WPE][GTK] Remove user agent quirk for washingtonpost.com
10128 https://bugs.webkit.org/show_bug.cgi?id=194981
10130 Reviewed by Žan Doberšek.
10132 * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
10133 (TestWebKitAPI::TEST):
10135 2019-02-23 Keith Miller <keith_miller@apple.com>
10137 Add new mac target numbers
10138 https://bugs.webkit.org/show_bug.cgi?id=194955
10140 Reviewed by Tim Horton.
10142 * DumpRenderTree/mac/Configurations/Base.xcconfig:
10143 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
10144 * MiniBrowser/Configurations/Base.xcconfig:
10145 * TestWebKitAPI/Configurations/Base.xcconfig:
10146 * WebKitTestRunner/Configurations/Base.xcconfig:
10148 2019-02-22 Basuke Suzuki <basuke.suzuki@sony.com>
10150 [WinCairo] Enable wk1/wk2 suffix for platform search path.
10151 https://bugs.webkit.org/show_bug.cgi?id=194846
10153 Reviewed by Don Olmstead.
10155 Added _search_paths() and _port_specific_expectations_files() for
10158 * Scripts/webkitpy/port/win.py:
10159 (WinCairoPort.default_baseline_search_path):
10161 (WinCairoPort._port_specific_expectations_files):
10162 (WinCairoPort._search_paths):
10164 2019-02-22 Tim Horton <timothy_horton@apple.com>
10166 ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
10167 https://bugs.webkit.org/show_bug.cgi?id=194963
10169 Reviewed by Dean Jackson.
10171 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10172 Do a `contains` check instead of `equals`, because in debug builds we
10173 put the GraphicsLayer pointer in a prefix.
10175 2019-02-22 Wenson Hsieh <wenson_hsieh@apple.com>
10177 [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
10178 https://bugs.webkit.org/show_bug.cgi?id=194873
10179 <rdar://problem/46701974>
10181 Reviewed by Tim Horton.
10183 Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
10185 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
10186 (WTR::UIScriptController::menuRect const):
10187 (WTR::UIScriptController::isShowingMenu const):
10188 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
10189 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
10190 (WTR::UIScriptController::menuRect const):
10192 Add a function to query the bounds of the callout menu in content coordinates.
10194 (WTR::UIScriptController::isShowingMenu const):
10196 Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
10198 * TestRunnerShared/UIScriptContext/UIScriptController.h:
10199 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
10200 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
10201 (WTR::UIScriptController::rectForMenuAction const):
10202 (WTR::UIScriptController::menuRect const):
10203 (WTR::UIScriptController::isShowingMenu const):
10204 (WTR::findViewInHierarchyOfType): Deleted.
10206 2019-02-22 Chris Dumez <cdumez@apple.com>
10208 Regression(PSON) Unable to preview password-protected documents on iCloud.com
10209 https://bugs.webkit.org/show_bug.cgi?id=194954
10210 <rdar://problem/48127957>
10212 Reviewed by Alex Christensen.
10214 Add API test coverage.
10216 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10217 (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
10218 (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
10219 (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
10221 2019-02-22 Chris Dumez <cdumez@apple.com>
10223 REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
10224 https://bugs.webkit.org/show_bug.cgi?id=194924
10225 <rdar://problem/48216125>
10227 Reviewed by Geoffrey Garen.
10229 Add API test coverage.
10231 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10233 2019-02-22 Chris Dumez <cdumez@apple.com>
10235 Unreviewed, disable API test added in r241928 on iOS.
10237 The cache is not enabled on devices with less than 3GB of RAM.
10239 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10241 2019-02-21 Simon Fraser <simon.fraser@apple.com>
10243 Hardcode Visual Viewports on everywhere except iOS WK1
10244 https://bugs.webkit.org/show_bug.cgi?id=194928
10246 Reviewed by Zalan Bujtas.
10248 Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
10249 change the default value of the Setting to 'true', and hardcode WebView on iOS to
10250 set it to false. The setting has shipped for several years and there's no need to turn
10253 Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
10254 Visual Viewports are not enabled.
10256 Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
10257 that only runs in WK2
10259 * MiniBrowser/mac/SettingsController.h:
10260 * MiniBrowser/mac/SettingsController.m:
10261 (-[SettingsController init]):
10262 (-[SettingsController _populateMenu]):
10263 (-[SettingsController validateMenuItem:]):
10264 (-[SettingsController visualViewportEnabled]): Deleted.
10265 (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
10266 * MiniBrowser/mac/WK1BrowserWindowController.m:
10267 (-[WK1BrowserWindowController didChangeSettings]):
10268 * MiniBrowser/mac/WK2BrowserWindowController.m:
10269 (-[WK2BrowserWindowController didChangeSettings]):
10271 2019-02-21 Ryosuke Niwa <rniwa@webkit.org>
10273 Discard cached processes when clearing website data store
10274 https://bugs.webkit.org/show_bug.cgi?id=194894
10276 Reviewed by Chris Dumez.
10280 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10281 (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
10283 2019-02-21 Alex Christensen <achristensen@webkit.org>
10285 Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
10286 https://bugs.webkit.org/show_bug.cgi?id=194914
10287 <rdar://problem/47586889>
10289 Reviewed by Geoffrey Garen.
10291 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
10292 (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
10294 (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
10296 2019-02-21 David Kilzer <ddkilzer@apple.com>
10298 Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
10299 <https://webkit.org/b/194761>
10301 Reviewed by Myles Maxfield.
10303 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
10304 (WTR::activateSystemCoreWebFonts): Log `error` to console if
10305 CTFontManagerRegisterFontsForURL() fails (macOS only). Update
10306 to use ARC-compliant cast.
10307 (WTR::activateFonts): Change `0` to `nullptr`. Update to use
10308 ARC-compliant cast.
10309 (WTR::installFakeHelvetica): Log `error` to console if
10310 CTFontManagerRegisterFontsForURL() fails, but only on supported
10311 platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
10312 Call CFRelease() on `error` to fix the leak. Update to use
10313 ARC-compliant cast.
10314 (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
10317 2019-02-21 Chris Dumez <cdumez@apple.com>
10319 Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
10320 https://bugs.webkit.org/show_bug.cgi?id=194481
10322 Reviewed by Alex Christensen.
10324 Give the processes a chance to shutdown and wait until we reached the expected number
10327 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10329 2019-02-21 Tim Horton <timothy_horton@apple.com>
10331 Fix the macOS build
10333 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10335 2019-02-21 Tim Horton <timothy_horton@apple.com>
10337 Fix ProcessSwap.PageOverlayLayerPersistence on macOS
10339 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10342 2019-02-21 Tim Horton <timothy_horton@apple.com>
10344 Fix ProcessSwap.PageOverlayLayerPersistence on macOS
10346 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10347 We can't find the UI-side layer on macOS because we don't use UI-side compositing.
10348 We could force on UI-side compositing, but I feel like the test might be more
10349 valuable exercising the normal path on each platform (though the original
10350 bug was also UI-side specific). Though we can't validate that the overlay
10351 layer was installed successfully, there are layout tests that do that.
10353 2019-02-21 Tim Horton <timothy_horton@apple.com>
10355 Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
10356 https://bugs.webkit.org/show_bug.cgi?id=194845
10357 <rdar://problem/47944579>
10359 Reviewed by Antti Koivisto.
10361 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10362 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10364 2019-02-21 Zalan Bujtas <zalan@apple.com>
10366 [LFC][Floats] Add support for placing formatting roots in-between floats.
10367 https://bugs.webkit.org/show_bug.cgi?id=194902
10369 Reviewed by Antti Koivisto.
10371 * LayoutReloaded/misc/LFC-passing-tests.txt:
10373 2019-02-21 Adrian Perez de Castro <aperez@igalia.com>
10375 [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
10376 https://bugs.webkit.org/show_bug.cgi?id=194901
10378 Unreviewed build fix.
10380 * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
10381 against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
10382 WPEBackend-fdo-0.1 as library name.
10384 2019-02-21 Rob Buis <rbuis@igalia.com>
10386 Update MIME type parser
10387 https://bugs.webkit.org/show_bug.cgi?id=180526
10389 Reviewed by Darin Adler.
10391 Add tests involving leading and trailing whitespace, non-token
10392 characters and quoted strings.
10394 * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
10395 (TestWebKitAPI::TEST):
10397 2019-02-20 Don Olmstead <don.olmstead@sony.com>
10399 [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
10400 https://bugs.webkit.org/show_bug.cgi?id=194884
10402 Reviewed by Michael Catanzaro.
10404 * PlatformWin.cmake:
10406 2019-02-20 Chris Dumez <cdumez@apple.com>
10408 Add API test for <rdar://problem/47471222>
10409 https://bugs.webkit.org/show_bug.cgi?id=194847
10411 Reviewed by Alex Christensen.
10413 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10415 2019-02-20 Chris Dumez <cdumez@apple.com>
10417 Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
10418 https://bugs.webkit.org/show_bug.cgi?id=194872
10419 <rdar://problem/47924500>
10421 Reviewed by Alex Christensen.
10423 Add API test coverage.
10425 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10427 2019-02-20 Jer Noble <jer.noble@apple.com>
10429 Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
10430 https://bugs.webkit.org/show_bug.cgi?id=191332
10432 Reviewed by Dean Jackson.
10434 * Scripts/git-is-in-range: Added.
10436 2019-02-20 Andy Estes <aestes@apple.com>
10438 [Xcode] Add SDKVariant.xcconfig to various Xcode projects
10439 https://bugs.webkit.org/show_bug.cgi?id=194869
10441 Rubber-stamped by Jer Noble.
10443 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
10444 * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
10445 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
10446 * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
10447 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10448 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
10450 2019-02-20 Chris Dumez <cdumez@apple.com>
10452 Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
10453 https://bugs.webkit.org/show_bug.cgi?id=194857
10454 <rdar://problem/47759323>
10456 Reviewed by Alex Christensen.
10458 Add API test coverage.
10460 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10462 2019-02-20 Chris Dumez <cdumez@apple.com>
10464 [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
10465 https://bugs.webkit.org/show_bug.cgi?id=194829
10466 <rdar://problem/47889906>
10468 Reviewed by Alexey Proskuryakov.
10470 Every time the TestOptions were changing we were creating both a new Web view and
10471 a new WKContext, which would start a new Network process. In most cases, we only
10472 need to contruct a new Web view and we do can keep reusing the same WKContext.
10473 This patch implements this optimization and thus avoids spinning a lot of new
10474 Network processes while running the layout tests.
10476 * WebKitTestRunner/TestController.cpp:
10477 (WTR::TestController::generateContextConfiguration const):
10478 (WTR::TestController::generatePageConfiguration):
10479 (WTR::TestController::createWebViewWithOptions):
10480 (WTR::TestController::resetPreferencesToConsistentValues):
10481 (WTR::updateTestOptionsFromTestHeader):
10482 * WebKitTestRunner/TestController.h:
10483 * WebKitTestRunner/TestOptions.h:
10484 (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
10485 (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
10486 (WTR::TestOptions::hasSameInitializationOptions const):
10487 (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
10488 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
10489 (WTR::TestController::platformAddTestOptions const):
10491 2019-02-20 Adrian Perez de Castro <aperez@igalia.com>
10493 [WPE][GTK] Enable support for CONTENT_EXTENSIONS
10494 https://bugs.webkit.org/show_bug.cgi?id=167941
10496 Reviewed by Carlos Garcia Campos.
10498 * MiniBrowser/gtk/main.c:
10499 (filterSavedCallback): Added.
10500 (main): Support loading a JSON rule set file for content filtering.
10501 * MiniBrowser/wpe/main.cpp:
10502 (filterSavedCallback): Added.
10503 (main): Support loading a JSON rule set file for content filtering.
10504 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
10505 (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
10506 (WTF::derefGPtr): Ditto.
10508 (testSaveInvalidFilter):
10509 (testSaveLoadFilter):
10510 (testSavedFilterIdentifierMatch):
10511 (testRemoveFilter):
10512 (testSaveMultipleFilters):
10513 (testSaveFilterFromFile):
10514 (testFilterPersistence):
10517 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
10518 (removeOldInjectedContentAndResetLists): Also reset content filters.
10519 (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
10520 CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
10521 the element affected by the style sheet.
10522 (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
10523 and returns it to be used by tests.
10524 (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
10525 from the WebKitUserContentManager results in the a CSS style sheet being blocked.
10526 (serverCallback): Add support for serving a CSS style sheet for testing.
10527 (beforeAll): Add call to testUserContentManagerContentFilter().
10528 * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
10530 2019-02-19 Keith Rollin <krollin@apple.com>
10532 Add timing information to build output
10533 https://bugs.webkit.org/show_bug.cgi?id=194839
10534 <rdar://problem/48219609>
10536 Reviewed by Alexey Proskuryakov.
10538 Configure xcodebuild with -ShowBuildOperationDuration, causing it to
10539 emit each project's build time to its output. E.g.,
10541 ** BUILD SUCCEEDED ** [0.132 sec]
10543 * Scripts/webkitdirs.pm:
10546 2019-02-19 Truitt Savell <tsavell@apple.com>
10548 Unreviewed, rolling out r241784.
10550 Broke all OpenSource builds.
10552 Reverted changeset:
10554 "Web Inspector: Improve ES6 Class instances in Heap Snapshot
10556 https://bugs.webkit.org/show_bug.cgi?id=172848
10557 https://trac.webkit.org/changeset/241784
10559 2019-02-19 Zalan Bujtas <zalan@apple.com>
10561 [LFC][Floats] Remove redundant intersecting logic
10562 https://bugs.webkit.org/show_bug.cgi?id=194804
10564 Reviewed by Antti Koivisto.
10566 * LayoutReloaded/misc/LFC-passing-tests.txt:
10568 2019-02-19 Dean Jackson <dino@apple.com>
10570 Clean-up output from generate-xcfilelists so it can be filtered
10571 https://bugs.webkit.org/show_bug.cgi?id=194795
10573 Reviewed by Joseph Pecoraro (and Keith Rollin).
10575 Replace the "..." with "GXCF:" in generate-xcfilelists output, and
10576 make a slight tweak to filter-build-webkit so such lines are marked
10579 * Scripts/filter-build-webkit:
10580 * Scripts/generate-xcfilelists:
10582 2019-02-19 Pablo Saavedra <psaavedra@igalia.com>
10584 pytest is not correctly auto-installed
10585 https://bugs.webkit.org/show_bug.cgi?id=194707
10587 Reviewed by Carlos Garcia Campos.
10589 * Scripts/webkitpy/thirdparty/__init__.py:
10590 (AutoinstallImportHook._install_pytest):
10592 2019-02-18 Chris Dumez <cdumez@apple.com>
10594 REGRESSION (PSON): Can't access optumbank.com from myuhc.com
10595 https://bugs.webkit.org/show_bug.cgi?id=194797
10596 <rdar://problem/48055151>
10598 Reviewed by Geoffrey Garen.
10600 Add API test coverage.
10602 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10604 2019-02-18 Wenson Hsieh <wenson_hsieh@apple.com>
10606 [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
10607 https://bugs.webkit.org/show_bug.cgi?id=194670
10608 <rdar://problem/39066529>
10610 Reviewed by Tim Horton.
10612 Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
10613 pasted in an editable area as attachment elements.
10615 * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
10616 (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
10617 (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
10618 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
10619 (TestWebKitAPI::TEST):
10620 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
10621 (WTR::InjectedBundlePage::InjectedBundlePage):
10623 2019-02-18 Alex Christensen <achristensen@webkit.org>
10625 Fix API test after r241728
10626 https://bugs.webkit.org/show_bug.cgi?id=194723
10628 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
10630 The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
10632 2019-02-18 Daniel Bates <dabates@apple.com>
10634 [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
10635 https://bugs.webkit.org/show_bug.cgi?id=192824
10636 <rdar://problem/47100332>
10638 Reviewed by Wenson Hsieh.
10640 Fix a bug where the wrong usage code was used for F13 thru F24.
10642 * WebKitTestRunner/ios/HIDEventGenerator.mm:
10643 (keyCodeForDOMFunctionKey):
10645 2019-02-18 Tadeu Zagallo <tzagallo@apple.com>
10647 Bytecode cache should a have a boot-specific validation
10648 https://bugs.webkit.org/show_bug.cgi?id=194769
10649 <rdar://problem/48149509>
10651 Reviewed by Keith Miller.
10653 Add test for WTF::bootSessionUUIDString()
10655 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10656 * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
10659 2019-02-18 Alex Christensen <achristensen@webkit.org>
10661 Disable safe browsing in WKWebView and remove its WKPreferences API
10662 https://bugs.webkit.org/show_bug.cgi?id=194723
10663 <rdar://problem/48122993>
10665 Reviewed by Geoffrey Garen.
10667 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10668 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
10670 (safeBrowsingView):
10671 Make tests use SPI instead of API.
10673 2019-02-17 Fujii Hironori <Hironori.Fujii@sony.com>
10675 Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
10676 https://bugs.webkit.org/show_bug.cgi?id=194586
10678 Reviewed by Ross Kirsling.
10680 * DumpRenderTree/win/DumpRenderTree.cpp:
10681 (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
10682 * Scripts/webkitpy/port/driver.py:
10683 (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
10685 2019-02-17 David Kilzer <ddkilzer@apple.com>
10687 Unreviewed, rolling out r241620.
10689 "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
10690 (Requested by ddkilzer on #webkit.)
10692 Reverted changeset:
10694 "[WTF] Add environment variable helpers"
10695 https://bugs.webkit.org/show_bug.cgi?id=192405
10696 https://trac.webkit.org/changeset/241620
10698 2019-02-16 Zalan Bujtas <zalan@apple.com>
10700 [LFC] RenderImage's default intrinsic size is 0.
10701 https://bugs.webkit.org/show_bug.cgi?id=194745
10703 Reviewed by Antti Koivisto.
10705 * LayoutReloaded/misc/LFC-passing-tests.txt:
10707 2019-02-16 Zalan Bujtas <zalan@apple.com>
10709 [LFC][BFC] Add support for block replaced intrinsic width.
10710 https://bugs.webkit.org/show_bug.cgi?id=194705
10712 Reviewed by Simon Fraser.
10714 * LayoutReloaded/misc/LFC-passing-tests.txt:
10716 2019-02-16 Zalan Bujtas <zalan@apple.com>
10718 [LFC] Apply min/max width constraints to preferred width computation
10719 https://bugs.webkit.org/show_bug.cgi?id=194739
10721 Reviewed by Simon Fraser.
10723 * LayoutReloaded/misc/LFC-passing-tests.txt:
10725 2019-02-15 Ross Kirsling <ross.kirsling@sony.com>
10727 [WTF] Add environment variable helpers
10728 https://bugs.webkit.org/show_bug.cgi?id=192405
10730 Reviewed by Michael Catanzaro.
10732 * DumpRenderTree/mac/DumpRenderTree.mm:
10733 (libraryPathForDumpRenderTree):
10734 * DumpRenderTree/win/DumpRenderTree.cpp:
10735 (libraryPathForDumpRenderTree):
10736 * TestRunnerShared/IOSLayoutTestCommunication.cpp:
10737 (setUpIOSLayoutTestCommunication):
10738 * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
10740 * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
10742 * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
10743 (WebKitTestBus::run):
10744 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
10745 (WTR::getOutputDir):
10746 (WTR::initializeFontConfigSetting):
10747 * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
10748 (WTR::InjectedBundle::platformInitialize):
10749 * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
10750 (WTR::topLevelPath):
10751 * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
10752 (WTR::topLevelPath):
10753 (WTR::getOutputDir):
10754 (WTR::activateFonts):
10755 * WebKitTestRunner/TestController.cpp:
10756 (WTR::TestController::libraryPathForTesting):
10757 (WTR::TestController::generateContextConfiguration const):
10758 (WTR::TestController::generatePageConfiguration):
10759 (WTR::TestController::decideDestinationWithSuggestedFilename):
10760 (WTR::TestController::platformAdjustContext):
10761 * WebKitTestRunner/TestController.h:
10762 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
10763 (WTR::TestController::cocoaPlatformInitialize):
10764 (WTR::TestController::platformAdjustContext):
10765 * WebKitTestRunner/gtk/main.cpp:
10767 * WebKitTestRunner/mac/TestControllerMac.mm:
10768 (WTR::TestController::configureContentExtensionForTest):
10769 * WebKitTestRunner/wpe/main.cpp:
10771 Utilize WTF::Environment where possible.
10773 2019-02-15 Wenson Hsieh <wenson_hsieh@apple.com>
10775 [iOS] WKWebView callout bar is missing Change Writing Direction item
10776 https://bugs.webkit.org/show_bug.cgi?id=190015
10777 <rdar://problem/44810366>
10779 Reviewed by Tim Horton.
10781 Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
10782 macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
10784 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
10785 (TestWebKitAPI::TEST):
10787 2019-02-15 Chris Dumez <cdumez@apple.com>
10789 Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
10790 https://bugs.webkit.org/show_bug.cgi?id=194717
10791 <rdar://problem/47884404>
10793 Reviewed by Brady Eidson.
10795 Add API test coverage.
10797 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10799 2019-02-15 Youenn Fablet <youenn@apple.com>
10801 Make navigator.mediaDevices SecureContext
10802 https://bugs.webkit.org/show_bug.cgi?id=194666
10804 Reviewed by Eric Carlson.
10806 * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
10807 (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
10810 2019-02-15 Brian Burg <bburg@apple.com>
10812 [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
10813 https://bugs.webkit.org/show_bug.cgi?id=194411
10814 <rdar://problem/47787614>
10816 Reviewed by Joseph Pecoraro.
10818 Remove unnecessary soft linking macro usage.
10820 * DumpRenderTree/mac/TestRunnerMac.mm:
10821 (TestRunner::inspectorTestStubURL):
10822 (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
10823 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
10824 (WTR::TestRunner::inspectorTestStubURL):
10826 2019-02-15 Commit Queue <commit-queue@webkit.org>
10828 Unreviewed, rolling out r241559 and r241566.
10829 https://bugs.webkit.org/show_bug.cgi?id=194710
10831 Causes layout test crashes under GuardMalloc (Requested by
10832 ryanhaddad on #webkit).
10834 Reverted changesets:
10836 "[WTF] Add environment variable helpers"
10837 https://bugs.webkit.org/show_bug.cgi?id=192405
10838 https://trac.webkit.org/changeset/241559
10840 "Unreviewed build fix for WinCairo Debug after r241559."
10841 https://trac.webkit.org/changeset/241566
10843 2019-02-15 Zalan Bujtas <zalan@apple.com>
10845 [LFC] Out-of-flow box is never a float box
10846 https://bugs.webkit.org/show_bug.cgi?id=194704
10848 Reviewed by Antti Koivisto.
10850 * LayoutReloaded/misc/LFC-passing-tests.txt:
10852 2019-02-10 Darin Adler <darin@apple.com>
10854 Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
10855 https://bugs.webkit.org/show_bug.cgi?id=194487
10857 Reviewed by Daniel Bates.
10859 * DumpRenderTree/win/DumpRenderTree.cpp:
10860 (applicationId): Use makeString instead of String::format.
10862 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
10863 (TestWebKitAPI::Util::createURLForResource): Ditto.
10864 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
10865 (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
10867 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
10868 (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
10869 (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
10870 (WTR::createStringWithAttributes): Use appendLiteral.
10871 (WTR::AccessibilityUIElement::helpText const): Ditto.
10872 (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
10873 directly instead of using String::format.
10874 (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
10875 (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
10877 2019-02-15 Truitt Savell <tsavell@apple.com>
10879 Unreviewed, rolling out r241564.
10881 Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
10883 Reverted changeset:
10885 "[Mac] WebInspectorUI.framework does not need to be soft-
10887 https://bugs.webkit.org/show_bug.cgi?id=194411
10888 https://trac.webkit.org/changeset/241564
10890 2019-02-15 Saam barati <sbarati@apple.com>
10892 [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
10893 https://bugs.webkit.org/show_bug.cgi?id=194036
10895 Reviewed by Yusuke Suzuki.
10897 * Scripts/run-jsc-stress-tests:
10899 2019-02-14 Tim Horton <timothy_horton@apple.com>
10903 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
10904 (WTR::UIScriptController::drawSquareInEditableImage):
10905 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
10906 (TestWebKitAPI::drawSquareInEditableImage):
10908 2019-02-14 Tim Horton <timothy_horton@apple.com>
10912 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
10913 (WTR::UIScriptController::drawSquareInEditableImage):
10914 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
10915 (TestWebKitAPI::drawSquareInEditableImage):
10917 2019-02-14 Brian Burg <bburg@apple.com>
10919 [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
10920 https://bugs.webkit.org/show_bug.cgi?id=194411
10921 <rdar://problem/47787614>
10923 Reviewed by Joseph Pecoraro.
10925 Remove unnecessary soft linking macro usage.
10927 * DumpRenderTree/mac/TestRunnerMac.mm:
10928 (TestRunner::inspectorTestStubURL):
10929 (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
10930 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
10931 (WTR::TestRunner::inspectorTestStubURL):
10933 2019-02-14 Aakash Jain <aakash_jain@apple.com>
10935 [ews-app] status bubble should fetch builder name info from BuilderMapping table
10936 https://bugs.webkit.org/show_bug.cgi?id=194599
10938 Reviewed by Lucas Forschler.
10940 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
10941 (StatusBubble._build_bubble):
10943 2019-02-14 Aakash Jain <aakash_jain@apple.com>
10945 [ews-app] Set Foreign Key in Django build model
10946 https://bugs.webkit.org/show_bug.cgi?id=194667
10948 Reviewed by Lucas Forschler.
10950 * BuildSlaveSupport/ews-app/ews/models/build.py:
10953 2019-02-14 Ross Kirsling <ross.kirsling@sony.com>
10955 [WTF] Add environment variable helpers
10956 https://bugs.webkit.org/show_bug.cgi?id=192405
10958 Reviewed by Michael Catanzaro.
10960 * DumpRenderTree/mac/DumpRenderTree.mm:
10961 (libraryPathForDumpRenderTree):
10962 * DumpRenderTree/win/DumpRenderTree.cpp:
10963 (libraryPathForDumpRenderTree):
10964 * TestRunnerShared/IOSLayoutTestCommunication.cpp:
10965 (setUpIOSLayoutTestCommunication):
10966 * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
10967 (TestWebKitAPI::strip):
10968 * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
10970 * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
10972 * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
10973 (WebKitTestBus::run):
10974 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
10975 (WTR::getOutputDir):
10976 (WTR::initializeFontConfigSetting):
10977 * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
10978 (WTR::InjectedBundle::platformInitialize):
10979 * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
10980 (WTR::topLevelPath):
10981 * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
10982 (WTR::topLevelPath):
10983 (WTR::getOutputDir):
10984 (WTR::activateFonts):
10985 * WebKitTestRunner/TestController.cpp:
10986 (WTR::TestController::libraryPathForTesting):
10987 (WTR::TestController::generateContextConfiguration const):
10988 (WTR::TestController::generatePageConfiguration):
10989 (WTR::TestController::decideDestinationWithSuggestedFilename):
10990 (WTR::TestController::platformAdjustContext):
10991 * WebKitTestRunner/TestController.h:
10992 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
10993 (WTR::TestController::cocoaPlatformInitialize):
10994 (WTR::TestController::platformAdjustContext):
10995 * WebKitTestRunner/gtk/main.cpp:
10997 * WebKitTestRunner/mac/TestControllerMac.mm:
10998 (WTR::TestController::configureContentExtensionForTest):
10999 * WebKitTestRunner/wpe/main.cpp:
11001 Utilize WTF::Environment where possible.
11003 2019-02-14 Chris Dumez <cdumez@apple.com>
11005 [PSON] Introduce a WebContent Process cache
11006 https://bugs.webkit.org/show_bug.cgi?id=194594
11007 <rdar://problem/46793397>
11009 Reviewed by Geoff Garen.
11011 Update API tests to turn on the WebContent Process cache.
11013 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
11015 2019-02-14 Jiewen Tan <jiewen_tan@apple.com>
11017 Unreviewed, build fix after r241480
11019 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
11020 (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
11021 (-[DragAndDropSimulator initWithWebView:]):
11023 2019-02-14 Chris Fleizach <cfleizach@apple.com>
11025 AX: ARIA Reflection was disabled in error
11026 https://bugs.webkit.org/show_bug.cgi?id=194647
11027 <rdar://problem/48068336>
11029 Reviewed by Ryosuke Niwa.
11031 Remove test override now that this feature should be enabled by default.
11033 * WebKitTestRunner/TestController.cpp:
11034 (WTR::TestController::resetPreferencesToConsistentValues):
11036 2019-02-14 Commit Queue <commit-queue@webkit.org>
11038 Unreviewed, rolling out r241486.
11039 https://bugs.webkit.org/show_bug.cgi?id=194655
11041 causing API failures in builds (Requested by ShawnRoberts on
11044 Reverted changeset:
11046 "[Cocoa] Media elements will restart network buffering just
11048 https://bugs.webkit.org/show_bug.cgi?id=193691
11049 https://trac.webkit.org/changeset/241486
11051 2019-02-14 Zalan Bujtas <zalan@apple.com>
11053 [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
11054 https://bugs.webkit.org/show_bug.cgi?id=194622
11056 Reviewed by Antti Koivisto.
11058 * LayoutReloaded/misc/LFC-passing-tests.txt:
11060 2019-02-14 Zalan Bujtas <zalan@apple.com>
11062 [LFC] Shrink-to-fit-width should be constrained by min/max width
11063 https://bugs.webkit.org/show_bug.cgi?id=194653
11065 Reviewed by Antti Koivisto.
11067 * LayoutReloaded/misc/LFC-passing-tests.txt:
11069 2019-02-13 Ryosuke Niwa <rniwa@webkit.org>
11071 Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
11072 https://bugs.webkit.org/show_bug.cgi?id=194641
11074 Reviewed by Geoffrey Garen.
11076 Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
11077 so that the test would fail without this fix.
11079 * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
11080 (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
11082 2019-02-13 Aakash Jain <aakash_jain@apple.com>
11084 [ews-app] Change log level for a log statement
11086 Unreviewed minor fix.
11088 * BuildSlaveSupport/ews-app/ews/models/patch.py:
11089 (Patch.save_patch):
11091 2019-02-13 Jer Noble <jer.noble@apple.com>
11093 [Cocoa] Media elements will restart network buffering just before suspending
11094 https://bugs.webkit.org/show_bug.cgi?id=193691
11096 Reviewed by Eric Carlson.
11098 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11099 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
11102 2019-02-13 Aakash Jain <aakash_jain@apple.com>
11104 [ews-app] Fetch builder id to name mapping
11105 https://bugs.webkit.org/show_bug.cgi?id=194355
11107 Reviewed by Lucas Forschler.
11109 * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
11110 (Buildbot.get_builder_id_to_name_mapping):
11111 (Buildbot._get_display_name_from_builder_name):
11113 2019-02-12 Jiewen Tan <jiewen_tan@apple.com>
11115 Further restricting webarchive loads
11116 https://bugs.webkit.org/show_bug.cgi?id=194567
11117 <rdar://problem/47610130>
11119 Reviewed by Youenn Fablet.
11121 Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
11122 navigations on drop.
11124 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11125 * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
11126 (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
11127 (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
11128 (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
11129 (TestWebKitAPI::TEST):
11130 * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
11131 * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
11132 * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
11133 * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
11134 * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
11135 (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
11136 (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
11138 2019-02-13 John Wilander <wilander@apple.com>
11140 Store Ad Click Attribution requests in the network process
11141 https://bugs.webkit.org/show_bug.cgi?id=194510
11142 <rdar://problem/47650118>
11144 Reviewed by Alex Christensen and Daniel Bates.
11146 This patch adds two TestRunner functions:
11147 - dumpAdClickAttribution()
11148 - clearAdClickAttribution()
11150 They call into the network process to dump and clear Ad Click
11151 Attribution state, respectively.
11153 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
11154 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
11155 (WTR::TestRunner::dumpAdClickAttribution):
11156 (WTR::TestRunner::clearAdClickAttribution):
11157 * WebKitTestRunner/InjectedBundle/TestRunner.h:
11158 * WebKitTestRunner/TestController.cpp:
11159 (WTR::TestController::resetStateToConsistentValues):
11160 (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
11161 (WTR::adClickAttributionStringResultCallback):
11162 (WTR::TestController::dumpAdClickAttribution):
11163 (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
11164 (WTR::adClickAttributionVoidCallback):
11165 (WTR::TestController::clearAdClickAttribution):
11166 * WebKitTestRunner/TestController.h:
11167 * WebKitTestRunner/TestInvocation.cpp:
11168 (WTR::TestInvocation::dumpResults):
11169 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
11170 (WTR::TestInvocation::dumpAdClickAttribution):
11171 * WebKitTestRunner/TestInvocation.h:
11173 2019-02-13 Aakash Jain <aakash_jain@apple.com>
11175 [ews-app] Generate status-bubble
11176 https://bugs.webkit.org/show_bug.cgi?id=194572
11178 Reviewed by Lucas Forschler.
11180 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
11181 (StatusBubble._build_bubble):
11182 (StatusBubble._should_show_bubble_for):
11183 (StatusBubble._build_bubbles_for_patch):
11185 2019-02-13 Aakash Jain <aakash_jain@apple.com>
11187 [ews-app] Add status bubble html template
11188 https://bugs.webkit.org/show_bug.cgi?id=194571
11190 Reviewed by Lucas Forschler.
11192 * BuildSlaveSupport/ews-app/ews/templates: Added.
11193 * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
11195 2019-02-12 Chris Dumez <cdumez@apple.com>
11197 Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
11198 https://bugs.webkit.org/show_bug.cgi?id=194568
11199 <rdar://problem/47944490>
11201 Reviewed by Ryosuke Niwa.
11203 Add API test coverage.
11205 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
11206 (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
11208 2019-02-12 Jonathan Bedard <jbedard@apple.com>
11210 webkitpy: Remove bug_dummy from parsed test expectations
11211 https://bugs.webkit.org/show_bug.cgi?id=194562
11212 <rdar://problem/47853999>
11214 Reviewed by Lucas Forschler.
11216 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
11217 (TestExpectationParser):
11218 (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
11220 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
11222 2019-02-12 Aakash Jain <aakash_jain@apple.com>
11224 [ews-app] Add method to fetch patch
11225 https://bugs.webkit.org/show_bug.cgi?id=194518
11227 Reviewed by Lucas Forschler.
11229 * BuildSlaveSupport/ews-app/ews/models/patch.py:
11232 2019-02-12 Zalan Bujtas <zalan@apple.com>
11234 [LFC] Expand tests coverage (60 new tests -> 860)
11236 Unreviewed test gardening (run-singly, --child-processes=1).
11238 * LayoutReloaded/misc/LFC-passing-tests.txt:
11240 2019-02-12 Wenson Hsieh <wenson_hsieh@apple.com>
11242 Allow pages to trigger programmatic paste from script on iOS
11243 https://bugs.webkit.org/show_bug.cgi?id=194271
11244 <rdar://problem/47808810>
11246 Reviewed by Tim Horton.
11248 Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
11250 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
11251 (WTR::UIScriptController::platformSetDidShowMenuCallback):
11252 (WTR::UIScriptController::platformSetDidHideMenuCallback):
11253 (WTR::UIScriptController::rectForMenuAction const):
11255 Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
11256 includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
11257 for when the menu is shown or hidden.
11259 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
11260 * TestRunnerShared/UIScriptContext/UIScriptContext.h:
11261 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
11262 (WTR::UIScriptController::setDidShowMenuCallback):
11263 (WTR::UIScriptController::didShowMenuCallback const):
11264 (WTR::UIScriptController::setDidHideMenuCallback):
11265 (WTR::UIScriptController::didHideMenuCallback const):
11266 (WTR::UIScriptController::platformSetDidShowMenuCallback):
11267 (WTR::UIScriptController::platformSetDidHideMenuCallback):
11268 (WTR::UIScriptController::rectForMenuAction const):
11269 * TestRunnerShared/UIScriptContext/UIScriptController.h:
11270 * WebKitTestRunner/TestController.cpp:
11271 (WTR::TestController::resetPreferencesToConsistentValues):
11272 (WTR::updateTestOptionsFromTestHeader):
11273 * WebKitTestRunner/TestOptions.h:
11275 Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
11276 default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
11278 (WTR::TestOptions::hasSameInitializationOptions const):
11279 * WebKitTestRunner/UIScriptControllerCocoa.mm:
11280 (WTR::UIScriptController::calendarType const):
11281 (WTR::UIScriptController::platformUndoManager const):
11282 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
11283 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
11284 (-[TestRunnerWKWebView initWithFrame:configuration:]):
11285 (-[TestRunnerWKWebView dealloc]):
11286 (-[TestRunnerWKWebView _didShowMenu]):
11287 (-[TestRunnerWKWebView _didHideMenu]):
11289 Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
11291 * WebKitTestRunner/ios/TestControllerIOS.mm:
11292 (WTR::handleMenuWillHideNotification):
11293 (WTR::handleMenuDidHideNotification):
11294 (WTR::TestController::platformInitialize):
11295 (WTR::TestController::platformDestroy):
11296 (WTR::TestController::platformResetStateToConsistentValues):
11298 Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
11299 next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
11301 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
11302 (WTR::forEachViewInHierarchy):
11303 (WTR::findViewInHierarchyOfType):
11305 Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
11306 functions that dig through a given view's hierarchy in search of a view of a given class.
11308 (WTR::UIScriptController::selectionStartGrabberViewRect const):
11309 (WTR::UIScriptController::selectionEndGrabberViewRect const):
11310 (WTR::UIScriptController::selectionCaretViewRect const):
11311 (WTR::UIScriptController::selectionRangeViewRects const):
11312 (WTR::UIScriptController::platformSetDidShowMenuCallback):
11313 (WTR::UIScriptController::platformSetDidHideMenuCallback):
11315 Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
11317 (WTR::UIScriptController::rectForMenuAction const):
11319 Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
11320 callout bar) whose label matches the given string.
11322 (WTR::UIScriptController::platformContentView const):
11324 Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
11325 "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
11326 of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
11328 (WTR::UIScriptController::platformUndoManager const): Deleted.
11329 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
11330 (WTR::UIScriptController::platformContentView const):
11331 (WTR::UIScriptController::platformUndoManager const): Deleted.
11333 2019-02-12 Jonathan Bedard <jbedard@apple.com>
11335 webkitpy: No option to only show unexpected failures in results.html for iPad
11336 https://bugs.webkit.org/show_bug.cgi?id=194554
11337 <rdar://problem/47922442>
11339 Rubber-stamped by Aakash Jain.
11341 Just because a TestExpecations file does not exist for a specific platform does not mean that
11342 TestExpecations are not being used, given that platforms inherit test expectations.
11344 * Scripts/webkitpy/port/base.py:
11345 (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
11346 * Scripts/webkitpy/port/base_unittest.py:
11347 (PortTest.test_uses_test_expectations_file):
11349 2019-02-12 Alex Christensen <achristensen@webkit.org>
11351 Remove setDefersLoading infrastructure from WebKit2
11352 https://bugs.webkit.org/show_bug.cgi?id=194506
11354 Reviewed by Brady Eidson.
11356 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
11357 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
11358 (WTR::TestRunner::setDefersLoading): Deleted.
11359 * WebKitTestRunner/InjectedBundle/TestRunner.h:
11361 2019-02-12 Alex Christensen <achristensen@webkit.org>
11363 WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
11364 https://bugs.webkit.org/show_bug.cgi?id=194522
11365 <rdar://problem/47789393>
11367 Reviewed by Chris Dumez.
11369 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11370 * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
11371 (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
11372 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
11374 2019-02-12 Andy Estes <aestes@apple.com>
11376 [iOSMac] Enable Parental Controls Content Filtering
11377 https://bugs.webkit.org/show_bug.cgi?id=194521
11380 Reviewed by Tim Horton.
11382 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
11384 2019-02-12 Zalan Bujtas <zalan@apple.com>
11386 [LFC][IFC] Add intrinsic width support for float boxes.
11387 https://bugs.webkit.org/show_bug.cgi?id=194528
11389 Reviewed by Antti Koivisto.
11391 Expand tests coverage (2 new tests -> 800).
11392 (This is the correct test ordering --runs-singly --child-processes=1)
11394 * LayoutReloaded/misc/LFC-passing-tests.txt:
11396 2019-02-12 Rob Buis <rbuis@igalia.com>
11398 Implement serializing in MIME type parser
11399 https://bugs.webkit.org/show_bug.cgi?id=193909
11401 Reviewed by Darin Adler.
11403 Add various tests involving upper case, non-ASCII, control/null characters,
11404 various HTTP whitespace, single quotes and an unpaired surrogate.
11406 * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
11407 (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
11408 (TestWebKitAPI::serializeIfValid):
11409 (TestWebKitAPI::TEST):
11411 2019-02-11 Myles C. Maxfield <mmaxfield@apple.com>
11413 [Cocoa] Ask platform for generic font family mappings
11414 https://bugs.webkit.org/show_bug.cgi?id=187723
11415 <rdar://problem/41892438>
11417 Reviewed by Brent Fulgham.
11419 Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
11421 * DumpRenderTree/mac/DumpRenderTree.mm:
11422 (allowedFontFamilySet):
11423 * WebKitTestRunner/mac/TestControllerMac.mm:
11424 (WTR::allowedFontFamilySet):
11426 2019-02-11 Adrian Perez de Castro <aperez@igalia.com>
11428 [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
11429 https://bugs.webkit.org/show_bug.cgi?id=193622
11431 Reviewed by Michael Catanzaro.
11433 This adds support for loading content extension rule sets from the JSON files which
11434 accompany the corresponding layout test, using the C API. The Cocoa specific parts
11435 of WKTR for this could be removed, but that is left for a follow-up patch with
11438 * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
11439 * WebKitTestRunner/TestController.cpp:
11440 (WTR::testPath): Subtract one from the length when constructing the result std::string to
11441 avoid having the null-terminator copied into the result.
11442 (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
11443 part of the preparations to run a test.
11444 (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
11445 (WTR::contentExtensionStoreCallback): Added.
11446 (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
11447 used for content extensions test.
11448 (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
11449 extensions and compiling the JSON rule set for tests involving content extensions.
11450 (WTR::TestController::resetContentExtensions): Removes the content extension built for
11451 testing and disables content extensions.
11452 (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
11453 resetContentExtensions().
11454 (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
11455 * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
11456 configureContentExtensionForTest(), and userContentController().
11458 2019-02-11 Daniel Bates <dabates@apple.com>
11460 [iOS] Mouse/Touch/Pointer events are missing modifier keys
11461 https://bugs.webkit.org/show_bug.cgi?id=191446
11462 <rdar://problem/45929460>
11464 Reviewed by Tim Horton.
11466 Add support infrastructure for testing touch and stylus taps when holding modifier keys.
11468 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
11469 (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
11470 (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
11471 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
11472 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
11473 (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
11474 (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
11475 * TestRunnerShared/UIScriptContext/UIScriptController.h:
11476 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
11477 (WTR::arrayLength):
11478 (WTR::parseModifierArray):
11479 (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
11480 (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
11481 (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
11482 (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
11484 2019-02-11 Commit Queue <commit-queue@webkit.org>
11486 Unreviewed, rolling out r241272 and r241276.
11487 https://bugs.webkit.org/show_bug.cgi?id=194514
11489 Broke the Apple Internal build and the fix requires human
11490 intervention :( (Requested by dydz on #webkit).
11492 Reverted changesets:
11494 "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
11495 https://bugs.webkit.org/show_bug.cgi?id=191446
11496 https://trac.webkit.org/changeset/241272
11498 "Fix internal iOS build after r241272"
11499 https://bugs.webkit.org/show_bug.cgi?id=191446
11500 https://trac.webkit.org/changeset/241276
11502 2019-02-11 Truitt Savell <tsavell@apple.com>
11504 Unreviewed, rolling out r241269.
11506 Caused 5 layout tests crashes on Mac WK1
11508 Reverted changeset:
11510 "DumpRenderTree should report unknown options"
11511 https://bugs.webkit.org/show_bug.cgi?id=191303
11512 https://trac.webkit.org/changeset/241269
11514 2019-02-11 Wenson Hsieh <wenson_hsieh@apple.com>
11516 fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
11517 https://bugs.webkit.org/show_bug.cgi?id=194313
11519 Reviewed by Tim Horton.
11521 Add a helper to determine whether the web view is presenting modal UI.
11523 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
11524 (WTR::UIScriptController::isPresentingModally const):
11525 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
11526 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
11527 (WTR::UIScriptController::isPresentingModally const):
11528 * TestRunnerShared/UIScriptContext/UIScriptController.h:
11529 * WebKitTestRunner/UIScriptControllerCocoa.mm:
11530 (WTR::UIScriptController::calendarType const): Deleted.
11531 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
11532 (WTR::UIScriptController::isPresentingModally const):
11533 (WTR::UIScriptController::calendarType const):
11534 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
11535 (WTR::UIScriptController::calendarType const):
11537 2019-02-11 Joseph Pecoraro <pecoraro@apple.com>
11539 GCHeapInspector: Show the retained sizes in more places
11540 https://bugs.webkit.org/show_bug.cgi?id=194464
11542 Reviewed by Simon Fraser.
11544 * GCHeapInspector/gc-heap-inspector.html:
11545 * GCHeapInspector/script/interface.js:
11546 (HeapInspectorUtils.humanReadableSize):
11547 (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
11548 (HeapInspectorUtils.spanForNode.span.span):
11549 (HeapSnapshotInspector.prototype.buildAllObjectsByType):
11550 (HeapSnapshotInspector.prototype.buildRoots):
11552 2019-02-11 Daniel Bates <dabates@apple.com>
11554 [iOS] Mouse/Touch/Pointer events are missing modifier keys
11555 https://bugs.webkit.org/show_bug.cgi?id=191446
11556 <rdar://problem/45929460>
11558 Reviewed by Tim Horton.
11560 Add support infrastructure for testing touch and stylus taps when holding modifier keys.
11562 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
11563 (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
11564 (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
11565 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
11566 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
11567 (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
11568 (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
11569 * TestRunnerShared/UIScriptContext/UIScriptController.h:
11570 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
11571 (WTR::arrayLength):
11572 (WTR::parseModifierArray):
11573 (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
11574 (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
11575 (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
11576 (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
11578 2019-02-11 Darshan Kadu <dkadu@igalia.com>
11580 DumpRenderTree should report unknown options
11581 https://bugs.webkit.org/show_bug.cgi?id=191303
11583 Reviewed by Frédéric Wang.
11585 Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
11586 to report unknown options.
11587 Added and assigned test options which are currently used in tests.
11589 * DumpRenderTree/TestOptions.cpp:
11590 (TestOptions::TestOptions):
11592 2019-02-11 Truitt Savell <tsavell@apple.com>
11594 Unreviewed, rolling out r241229.
11596 Revision broke internal builds for watchOS.
11598 Reverted changeset:
11600 "[Cocoa] Ask platform for generic font family mappings"
11601 https://bugs.webkit.org/show_bug.cgi?id=187723
11602 https://trac.webkit.org/changeset/241229
11604 2019-02-11 Takashi Komori <Takashi.Komori@sony.com>
11606 [WinCairo][MiniBrowser] Basic authentication always fails.
11607 https://bugs.webkit.org/show_bug.cgi?id=194496
11609 Reviewed by Don Olmstead.
11611 * MiniBrowser/win/DialogHelper.h:
11614 2019-02-11 Philippe Normand <pnormand@igalia.com>
11616 [GStreamer] GstMappedBuffer testsuite build fails
11617 https://bugs.webkit.org/show_bug.cgi?id=194495
11619 Reviewed by Carlos Garcia Campos.
11621 Fix the build by explicitely adding the gstreamer1.0-audio include
11622 directories to the include path.
11624 * TestWebKitAPI/PlatformGTK.cmake:
11625 * TestWebKitAPI/PlatformWPE.cmake:
11627 2019-02-04 Carlos Garcia Campos <cgarcia@igalia.com>
11629 [GTK][WPE] Add enable-javascript-markup setting
11630 https://bugs.webkit.org/show_bug.cgi?id=193439
11632 Reviewed by Michael Catanzaro.
11634 Add test cases to check the new setting.
11636 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
11637 (testWebKitSettings):
11638 (testWebKitSettingsJavaScriptMarkup):
11641 2019-02-10 Darin Adler <darin@apple.com>
11643 Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
11644 https://bugs.webkit.org/show_bug.cgi?id=194485
11646 Reviewed by Daniel Bates.
11648 * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
11650 2019-02-09 Benjamin Poulain <benjamin@webkit.org>
11652 Add more tests for clampTo<>()
11653 https://bugs.webkit.org/show_bug.cgi?id=194462
11655 Reviewed by Geoffrey Garen.
11657 Darin suggested to test the very last floating point number
11658 at the boundaries when truncating to integer.
11659 I added test for max/min and max-1/min-1.
11661 * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
11662 (TestWebKitAPI::TEST):
11664 2019-02-09 Darin Adler <darin@apple.com>
11666 Eliminate unnecessary String temporaries by using StringConcatenateNumbers
11667 https://bugs.webkit.org/show_bug.cgi?id=194021
11669 Reviewed by Geoffrey Garen.
11671 * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
11672 (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
11673 to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
11675 2019-02-09 Zalan Bujtas <zalan@apple.com>
11677 [LFC][IFC] Add intrinsic width support for basic inline containers
11678 https://bugs.webkit.org/show_bug.cgi?id=194473
11680 Reviewed by Antti Koivisto.
11682 Expand tests coverage (11 new tests -> 798)
11684 * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
11686 2019-02-09 Benjamin Poulain <benjamin@webkit.org>
11688 Fix MiniBrowser's entitlements
11689 https://bugs.webkit.org/show_bug.cgi?id=192431
11691 Reviewed by Joseph Pecoraro.
11693 MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
11694 files, making it impossible to load any extension.
11696 * MiniBrowser/MiniBrowser.entitlements:
11698 2019-02-08 Myles C. Maxfield <mmaxfield@apple.com>
11700 [Cocoa] Ask platform for generic font family mappings
11701 https://bugs.webkit.org/show_bug.cgi?id=187723
11702 <rdar://problem/41892438>
11704 Reviewed by Brent Fulgham.
11706 Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
11708 * DumpRenderTree/mac/DumpRenderTree.mm:
11709 (allowedFontFamilySet):
11710 * WebKitTestRunner/mac/TestControllerMac.mm:
11711 (WTR::allowedFontFamilySet):
11713 2019-02-08 Alexander Mikhaylenko <exalm7659@gmail.com>
11715 [GTK] Implement back/forward touchpad gesture
11716 https://bugs.webkit.org/show_bug.cgi?id=193919
11718 Reviewed by Michael Catanzaro.
11720 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
11721 (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
11723 2019-02-08 Alex Christensen <achristensen@webkit.org>
11725 Add SPI to use networking daemon instead of XPC service
11726 https://bugs.webkit.org/show_bug.cgi?id=194427
11728 Reviewed by Geoffrey Garen
11730 * MiniBrowser/MiniBrowser.entitlements:
11732 2019-02-08 Aakash Jain <aakash_jain@apple.com>
11734 [ews-build] Ensure that every builder in config.json has short name
11735 https://bugs.webkit.org/show_bug.cgi?id=194461
11737 Reviewed by Lucas Forschler.
11739 * BuildSlaveSupport/ews-build/loadConfig.py:
11740 * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
11742 2019-02-08 Aakash Jain <aakash_jain@apple.com>
11744 [ews-build] Add short name to config.json
11745 https://bugs.webkit.org/show_bug.cgi?id=194456
11747 Reviewed by Lucas Forschler.
11749 * BuildSlaveSupport/ews-build/config.json: Added short name.
11750 * BuildSlaveSupport/ews-build/loadConfig.py:
11751 (loadBuilderConfig): Set the short name as the builder description.
11753 2019-02-08 Jonathan Bedard <jbedard@apple.com>
11755 webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
11756 https://bugs.webkit.org/show_bug.cgi?id=194418
11758 Reviewed by Lucas Forschler.
11760 Do not include errors trying when finding crashlogs at the end of
11761 a run-webkit-tests run since we don't process those errors.
11763 * Scripts/webkitpy/port/darwin.py:
11764 (DarwinPort._look_for_all_crash_logs_in_log_dir):
11765 * Scripts/webkitpy/port/ios_device.py:
11766 (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
11767 * Scripts/webkitpy/port/watch_device.py:
11768 (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
11770 2019-02-08 Beth Dakin <bdakin@apple.com>
11772 Add afterScreenUpdates to WKSnapshotConfiguration
11773 https://bugs.webkit.org/show_bug.cgi?id=194362
11774 -and corresponding-
11775 <rdar://problem/40655528> Please add an "after screen updates" property to
11776 WKSnapshotConfiguration (to solve blank snapshots)
11778 Reviewed by Tim Horton.
11780 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
11783 2019-02-08 Benjamin Poulain <benjamin@webkit.org>
11785 clampTo(): do not convert the input to double when dealing with integers
11786 https://bugs.webkit.org/show_bug.cgi?id=194263
11787 <rdar://problem/47692312>
11789 Reviewed by Darin Adler.
11791 * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
11792 (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
11793 (TestWebKitAPI::testClampFloatingPointToInteger):
11794 (TestWebKitAPI::testClampSameSignIntegers):
11795 (TestWebKitAPI::testClampUnsignedToSigned):
11796 (TestWebKitAPI::testClampSignedToUnsigned):
11798 2019-02-07 Jonathan Bedard <jbedard@apple.com>
11800 webkitpy: Respect --dedicated-simulators flag
11801 https://bugs.webkit.org/show_bug.cgi?id=194416
11802 <rdar://problem/47894722>
11804 Reviewed by Lucas Forschler.
11806 * Scripts/webkitpy/port/device_port.py:
11807 (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
11808 available devices can be safely ignored.
11810 2019-02-07 Keith Rollin <krollin@apple.com>
11812 Remove extra copy of 100x100-red.tga
11813 https://bugs.webkit.org/show_bug.cgi?id=194371
11814 <rdar://problem/47873465>
11816 Reviewed by Said Abou-Hallawa.
11818 In order to help it pass its tests, Bug 194190 added a second copy of
11819 the file 100x100-red.tga. However, it turns out that this additional
11820 file wasn't actually needed, and that that sole previous copy was
11821 sufficient. At the same time, this second copy -- which was copied to
11822 the same location in the build output as the first copy -- now caused
11823 XCBuild to complain because there were two production rules for the
11824 same output file. Address this by removing the newly-added extra copy.
11826 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11827 * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
11829 2019-02-07 Alex Christensen <achristensen@webkit.org>
11831 Deprecate WKBundlePageSetDefersLoading
11832 https://bugs.webkit.org/show_bug.cgi?id=191394
11834 Reviewed by Dean Jackson.
11836 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
11837 (WTR::TestRunner::setDefersLoading):
11839 2019-02-07 Zalan Bujtas <zalan@apple.com>
11841 [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
11842 https://bugs.webkit.org/show_bug.cgi?id=194391
11844 Reviewed by Antti Koivisto.
11846 * LayoutReloaded/misc/LFC-passing-tests.txt:
11848 2019-02-06 Keith Rollin <krollin@apple.com>
11850 Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
11851 https://bugs.webkit.org/show_bug.cgi?id=193975
11852 <rdar://problem/47643306>
11854 Reviewed by Tim Horton.
11856 The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
11857 the Info.plist file into the bundle. This step is not necessary as the
11858 implicit "bundle up all the build products into a framework" build
11859 phase does this already. Having the Copy Bundle Resources phase do
11860 this causes a conflict under XCBuild, which objects to two build
11861 phases producing the same file (Info.plist). Address this by removing
11862 Info.plist from the Copy Bundle Resources phase.
11864 * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
11866 2019-02-06 Keith Rollin <krollin@apple.com>
11868 Really enable the automatic checking and regenerations of .xcfilelists during builds
11869 https://bugs.webkit.org/show_bug.cgi?id=194357
11870 <rdar://problem/47861231>
11872 Reviewed by Chris Dumez.
11874 Bug 194124 was supposed to enable the automatic checking and
11875 regenerating of .xcfilelist files during the build. While related
11876 changes were included in that patch, the change to actually enable the
11877 operation somehow was omitted. This patch actually enables the
11878 operation. The check-xcfilelist.sh scripts now check
11879 WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
11882 * DumpRenderTree/Scripts/check-xcfilelists.sh:
11883 * WebKitTestRunner/Scripts/check-xcfilelists.sh:
11885 2019-02-06 David Kilzer <ddkilzer@apple.com>
11887 WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
11888 <https://webkit.org/b/194286>
11889 <rdar://problem/47815558>
11891 Reviewed by Alexey Proskuryakov.
11893 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
11894 (WTR::InjectedBundlePage::willSendRequestForFrame): Use
11895 WKRetainPtr<> to avoid leaking the WKDataRef.
11897 2019-02-06 Michael Catanzaro <mcatanzaro@igalia.com>
11899 Unreviewed, fix a typo
11901 * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
11903 2019-02-06 Olivier Blin <olivier.blin@softathome.com>
11905 [GTK][WPE] force libpsl build to use ICU in jhbuild
11906 https://bugs.webkit.org/show_bug.cgi?id=194288
11908 Reviewed by Carlos Garcia Campos.
11910 * gtk/jhbuild.modules:
11911 Require ICU for libpsl build in jhbuild, like done in WPE.
11913 2019-02-06 Michael Catanzaro <mcatanzaro@igalia.com>
11915 REGRESSION(r240785): [SOUP] Broke cookie persistent storage
11916 https://bugs.webkit.org/show_bug.cgi?id=194209
11918 Reviewed by Carlos Garcia Campos.
11920 Enhance TestCookieManager to ensure this doesn't happen again.
11922 * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
11923 (testCookieManagerPersistentStorage):
11926 2019-02-05 Wenson Hsieh <wenson_hsieh@apple.com>
11928 Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
11929 https://bugs.webkit.org/show_bug.cgi?id=194324
11931 Reviewed by Andy Estes.
11933 Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
11934 part of the name is already implicit, since this is in testing code in TestOptions.
11936 * WebKitTestRunner/TestController.cpp:
11937 (WTR::TestController::generateContextConfiguration const):
11938 (WTR::updateTestOptionsFromTestHeader):
11939 * WebKitTestRunner/TestOptions.h:
11940 (WTR::TestOptions::hasSameInitializationOptions const):
11942 2019-02-05 Aakash Jain <aakash_jain@apple.com>
11944 [ews-build] Allow * as platform for builders and workers
11945 https://bugs.webkit.org/show_bug.cgi?id=188533
11947 Reviewed by Lucas Forschler.
11949 * BuildSlaveSupport/ews-build/loadConfig.py:
11950 (checkWorkersAndBuildersForConsistency):
11952 2019-02-05 Aakash Jain <aakash_jain@apple.com>
11954 [ews-build] Add few bots to config.json
11955 https://bugs.webkit.org/show_bug.cgi?id=194304
11957 Reviewed by Lucas Forschler.
11959 * BuildSlaveSupport/ews-build/config.json:
11961 2019-02-05 Keith Rollin <krollin@apple.com>
11963 Enable the automatic checking and regenerations of .xcfilelists during builds
11964 https://bugs.webkit.org/show_bug.cgi?id=194124
11965 <rdar://problem/47721277>
11967 Reviewed by Tim Horton.
11969 Bug 193790 add a facility for checking -- during build time -- that
11970 any needed .xcfilelist files are up-to-date and for updating them if
11971 they are not. This facility was initially opt-in by setting
11972 WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
11973 the process seemed robust. Its now time to enable this facility and
11974 make it opt-out. If there is a need to disable this facility, set and
11975 export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
11976 running `make` or `build-webkit`, or before running Xcode from the
11979 Additionally, remove the step that generates a list of source files
11980 going into the UnifiedSources build step. It's only necessarily to
11981 specify Sources.txt and SourcesCocoa.txt as inputs.
11983 * Scripts/generate-xcfilelists:
11985 2019-02-05 Olivier Blin <olivier.blin@softathome.com>
11987 [GTK][WPE] force libpsl build to use ICU in jhbuild
11988 https://bugs.webkit.org/show_bug.cgi?id=194288
11990 Reviewed by Philippe Normand.
11992 In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
11993 This can cause build failures if libidn is detected but libunistring is not available.
11995 Make sure that ICU is used for runtime and builtin PSL data.
11997 * gtk/jhbuild.modules:
11998 * wpe/jhbuild.modules:
12000 2019-02-05 Aakash Jain <aakash_jain@apple.com>
12002 [ews-app] Modified timestamp should be updated on updating data
12003 https://bugs.webkit.org/show_bug.cgi?id=194295
12005 Reviewed by Lucas Forschler.
12007 * BuildSlaveSupport/ews-app/ews/models/build.py:
12008 * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
12009 * BuildSlaveSupport/ews-app/ews/models/step.py:
12011 2019-02-05 Ryan Haddad <ryanhaddad@apple.com>
12013 Unreviewed, rolling out r240742.
12015 Causes crashes on iOS simulator.
12017 Reverted changeset:
12019 "[iOS] Keyups for non-modifier keys identified as "Dead" when
12020 not focused in a content-editable element"
12021 https://bugs.webkit.org/show_bug.cgi?id=192824
12022 https://trac.webkit.org/changeset/240742
12024 2019-02-05 Jonathan Bedard <jbedard@apple.com>
12026 run-webkit-tests emits message "...running None" when running tests
12027 https://bugs.webkit.org/show_bug.cgi?id=194133
12028 <rdar://problem/47724738>
12030 Reviewed by Lucas Forschler.
12032 * Scripts/webkitpy/xcode/device_type.py:
12033 (DeviceType.__str__): Use both version mapping tables and use just the variant
12034 name if no version name is available.
12035 * Scripts/webkitpy/xcode/device_type_unittest.py:
12037 (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
12038 an associated named.
12040 2019-02-05 Olivier Blin <olivier.blin@softathome.com>
12042 [WPE] require python3-setuptools for meson build in jhbuild
12043 https://bugs.webkit.org/show_bug.cgi?id=194287
12045 Reviewed by Philippe Normand.
12047 python3-setuptools is needed to build meson in jhbuild.
12048 It is already required by the GTK port.
12050 * wpe/install-dependencies:
12052 2019-02-05 Aakash Jain <aakash_jain@apple.com>
12054 [ews-app] Add method to save BuilderMapping to database
12055 https://bugs.webkit.org/show_bug.cgi?id=194264
12057 Reviewed by Lucas Forschler.
12059 * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
12060 (BuilderMapping.__str__):
12062 (BuilderMapping.save_mapping):
12063 (BuilderMapping.update_mapping):
12064 (BuilderMapping.get_existing_mapping):
12065 (BuilderMapping.is_valid_mapping):
12067 2019-02-05 Aakash Jain <aakash_jain@apple.com>
12069 [ews-app] Add timestamp fields for BuilderMappings
12070 https://bugs.webkit.org/show_bug.cgi?id=194266
12072 Reviewed by Lucas Forschler.
12074 * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
12077 2019-02-04 Ms2ger <Ms2ger@igalia.com>
12079 [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
12080 https://bugs.webkit.org/show_bug.cgi?id=174816
12082 Reviewed by Michael Catanzaro.
12084 Add tests for webkit_uri_for_display().
12086 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
12087 (testURIForDisplayUnaffected):
12088 (testURIForDisplayAffected):
12091 * TestWebKitAPI/glib/CMakeLists.txt:
12093 2019-02-04 Jonathan Bedard <jbedard@apple.com>
12095 webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
12096 https://bugs.webkit.org/show_bug.cgi?id=194158
12097 <rdar://problem/47737268>
12099 Rubber-stamped by Aakash Jain.
12101 * Scripts/webkitpy/port/device_port.py:
12102 (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
12104 2019-02-04 Said Abou-Hallawa <said@apple.com>
12106 [CG] Enable setAdditionalSupportedImageTypes for WK1
12107 https://bugs.webkit.org/show_bug.cgi?id=194190
12109 Reviewed by Tim Horton.
12111 Add a test similar to the one under WebKit Cocoa but make it create a
12112 WebView instead of a WKWebView.
12114 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12115 * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
12116 * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
12117 * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
12118 (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
12119 (TestWebKitAPI::runTest):
12120 (TestWebKitAPI::TEST):
12122 2019-02-04 Zalan Bujtas <zalan@apple.com>
12124 [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
12125 https://bugs.webkit.org/show_bug.cgi?id=194168
12127 Reviewed by Simon Fraser.
12129 Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message.
12131 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12132 * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
12133 (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
12134 (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
12136 * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
12137 * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
12139 2019-02-04 Dean Johnson <dean_johnson@apple.com>
12141 REGRESSION (r237269): webkit-patch what-broke is broken
12142 https://bugs.webkit.org/show_bug.cgi?id=193025
12144 Reviewed by Aakash Jain.
12146 * Scripts/webkitpy/common/host.py:
12148 (Host.bugzilla): Renamed to 'buildbot'.
12150 2019-02-04 Wenson Hsieh <wenson_hsieh@apple.com>
12152 [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
12153 https://bugs.webkit.org/show_bug.cgi?id=194207
12155 Reviewed by Tim Horton.
12157 Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
12158 element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
12159 paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
12160 attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
12161 start and delete forwards to remove the original attachment.
12163 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
12164 (TestWebKitAPI::TEST):
12166 2019-02-04 Youenn Fablet <youenn@apple.com>
12168 Capture state should be managed consistently when doing process swapping
12169 https://bugs.webkit.org/show_bug.cgi?id=194122
12170 <rdar://problem/47609293>
12172 Reviewed by Eric Carlson.
12174 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12175 (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
12176 (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
12177 (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
12178 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
12179 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
12180 (WTR::TestRunner::isDoingMediaCapture const):
12181 * WebKitTestRunner/InjectedBundle/TestRunner.h:
12182 * WebKitTestRunner/TestController.cpp:
12183 (WTR::TestController::isDoingMediaCapture const):
12184 * WebKitTestRunner/TestController.h:
12185 * WebKitTestRunner/TestInvocation.cpp:
12186 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
12187 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
12188 (WTR::TestController::isDoingMediaCapture const):
12190 2019-02-03 Fujii Hironori <Hironori.Fujii@sony.com>
12192 [Win] WebKitTestRunners is failing to create the IndexedDB directory.
12193 https://bugs.webkit.org/show_bug.cgi?id=194142
12195 Reviewed by Ross Kirsling.
12197 There three 'separator' variables in TestController.cpp. Renamed
12198 it 'pathSeparator', and unified them.
12200 * WebKitTestRunner/TestController.cpp:
12201 (WTR::TestController::generateContextConfiguration const):
12202 (WTR::createTestURL):
12203 (WTR::TestController::platformAdjustContext):
12205 2019-02-03 Simon Fraser <simon.fraser@apple.com>
12207 Make setNeedsLayout on the root more explicitly about triggering its side-effects
12208 https://bugs.webkit.org/show_bug.cgi?id=194198
12210 Reviewed by Antti Koivisto.
12212 No need to set the banner heights on navigation now, since Page stores them.
12214 * MiniBrowser/mac/WK2BrowserWindowController.m:
12215 (-[WK2BrowserWindowController webView:didFinishNavigation:]):
12217 2019-02-03 John Wilander <wilander@apple.com>
12219 Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
12220 https://bugs.webkit.org/show_bug.cgi?id=194104
12221 <rdar://problem/47649991>
12223 Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
12225 * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
12226 (TestWebKitAPI::TEST):
12227 Changed numeric types from unsigned short to uint32_t.
12229 2019-02-02 David Kilzer <ddkilzer@apple.com>
12231 Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
12232 <https://webkit.org/b/194178>
12233 <rdar://problem/47753473>
12235 Reviewed by Alexey Proskuryakov.
12237 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
12238 (WTR::uninstallFakeHelvetica): Pass nullptr into
12239 CTFontManagerUnregisterFontsForURLs() to ignore any errors.
12241 2019-02-02 Zalan Bujtas <zalan@apple.com>
12243 [LFC] Initialize ICB's style with fixed width/height.
12244 https://bugs.webkit.org/show_bug.cgi?id=194188
12246 Reviewed by Antti Koivisto.
12248 * LayoutReloaded/misc/LFC-passing-tests.txt:
12250 2019-02-02 Zalan Bujtas <zalan@apple.com>
12252 [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
12253 https://bugs.webkit.org/show_bug.cgi?id=194185
12255 Reviewed by Antti Koivisto.
12257 * LayoutReloaded/misc/LFC-passing-tests.txt:
12259 2018-12-16 Darin Adler <darin@apple.com>
12261 Convert additional String::format clients to alternative approaches
12262 https://bugs.webkit.org/show_bug.cgi?id=192746
12264 Reviewed by Alexey Proskuryakov.
12266 * WebKitTestRunner/TestController.cpp:
12267 (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
12268 as an intermediate in code that ultimately constructs a WTF::String.
12269 (WTR::userMediaOriginHash): Use makeString.
12270 (WTR::TestController::didNavigateWithNavigationData): More of the same.
12271 (WTR::TestController::didPerformClientRedirect): Ditto.
12272 (WTR::TestController::didPerformServerRedirect): Ditto.
12273 (WTR::TestController::didUpdateHistoryTitle): Ditto.
12275 2019-02-01 Aakash Jain <aakash_jain@apple.com>
12277 [ews-build] Add unit test to verify builder keys
12278 https://bugs.webkit.org/show_bug.cgi?id=194152
12280 Reviewed by Lucas Forschler.
12282 * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
12283 (ConfigDotJSONTest.test_builder_keys): Added unit-test.
12285 2019-02-01 Zalan Bujtas <zalan@apple.com>
12287 [LFC] Expand tests coverage (12 new tests -> 787)
12289 Unreviewed test gardening.
12291 * LayoutReloaded/misc/LFC-passing-tests.txt:
12293 2019-02-01 Zalan Bujtas <zalan@apple.com>
12295 [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
12296 https://bugs.webkit.org/show_bug.cgi?id=194163
12298 Reviewed by Simon Fraser.
12302 * LayoutReloaded/misc/LFC-passing-tests.txt:
12304 2019-02-01 Wenson Hsieh <wenson_hsieh@apple.com>
12306 [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
12307 https://bugs.webkit.org/show_bug.cgi?id=194140
12308 <rdar://problem/47728098>
12310 Reviewed by Tim Horton.
12312 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
12313 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
12314 (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
12316 Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
12317 test to induce an IPC deadlock when presenting a modal alert during touch start.
12319 * WebKitTestRunner/InjectedBundle/TestRunner.h:
12320 * WebKitTestRunner/TestController.cpp:
12321 (WTR::runJavaScriptAlert):
12323 Add a client callback function for running JavaScript alerts.
12325 (WTR::TestController::createOtherPage):
12326 (WTR::TestController::generateContextConfiguration const):
12328 Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
12329 the fix in this patch.
12331 (WTR::TestController::createWebViewWithOptions):
12333 Plumb TestOptions to generateContextConfiguration.
12335 (WTR::TestController::resetPreferencesToConsistentValues):
12336 (WTR::TestController::resetStateToConsistentValues):
12337 (WTR::updateTestOptionsFromTestHeader):
12338 (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
12339 (WTR::TestController::handleJavaScriptAlert):
12340 * WebKitTestRunner/TestController.h:
12341 * WebKitTestRunner/TestInvocation.cpp:
12342 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
12343 * WebKitTestRunner/TestOptions.h:
12344 (WTR::TestOptions::hasSameInitializationOptions const):
12346 2019-02-01 Chris Dumez <cdumez@apple.com>
12348 REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
12349 https://bugs.webkit.org/show_bug.cgi?id=193740
12350 <rdar://problem/47527267>
12352 Reviewed by Alex Christensen.
12354 Add API test coverage.
12356 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12358 2019-02-01 Aakash Jain <aakash_jain@apple.com>
12360 [ews-app] Add display name field to BuilderMapping model
12361 https://bugs.webkit.org/show_bug.cgi?id=194153
12363 Reviewed by Lucas Forschler.
12365 * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
12368 2019-02-01 Youenn Fablet <youenn@apple.com>
12370 API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
12371 https://bugs.webkit.org/show_bug.cgi?id=194155
12373 Reviewed by Eric Carlson.
12375 * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
12376 Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
12377 Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
12379 2019-02-01 Zalan Bujtas <zalan@apple.com>
12381 [LFC] Adjust replaced element's intrinsic ratio
12382 https://bugs.webkit.org/show_bug.cgi?id=194154
12384 Reviewed by Antti Koivisto.
12388 * LayoutReloaded/misc/LFC-passing-tests.txt:
12390 2019-02-01 Carlos Garcia Campos <cgarcia@igalia.com>
12392 [WPE] Show test results in minibrowser
12393 https://bugs.webkit.org/show_bug.cgi?id=194150
12395 Reviewed by Žan Doberšek.
12397 * Scripts/webkitpy/port/wpe.py:
12398 (WPEPort.show_results_html_file):
12400 2019-02-01 Carlos Garcia Campos <cgarcia@igalia.com>
12402 [WPE] MiniBrowser: add ky bindings for back/forward navigation
12403 https://bugs.webkit.org/show_bug.cgi?id=194151
12405 Reviewed by Žan Doberšek.
12408 ALT + -> go forward
12410 * MiniBrowser/wpe/main.cpp:
12413 2019-02-01 Zalan Bujtas <zalan@apple.com>
12415 [LFC] Set intrinsic size on Layout::Replaced
12416 https://bugs.webkit.org/show_bug.cgi?id=194139
12418 Reviewed by Antti Koivisto.
12422 * LayoutReloaded/misc/LFC-passing-tests.txt:
12424 2019-02-01 Carlos Garcia Campos <cgarcia@igalia.com>
12426 [WPE] MiniBrowser: use g_file_new_for_commandline_arg
12427 https://bugs.webkit.org/show_bug.cgi?id=194146
12429 Reviewed by Xabier Rodriguez-Calvar.
12431 It allows to open relative paths.
12433 * MiniBrowser/wpe/main.cpp:
12436 2019-01-31 Ryan Haddad <ryanhaddad@apple.com>
12438 Update flakiness dashboard configuration after recent queue changes
12439 https://bugs.webkit.org/show_bug.cgi?id=194127
12441 Rubber-stamped by Aakash Jain.
12443 Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
12445 * TestResultServer/static-dashboards/builders.jsonp:
12447 2019-01-31 Youenn Fablet <youenn@apple.com>
12449 Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
12450 https://bugs.webkit.org/show_bug.cgi?id=194106
12451 <rdar://problem/47676333>
12453 Reviewed by Ryosuke Niwa.
12455 * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
12456 (TestWebKitAPI::didFinishNavigation):
12457 (TestWebKitAPI::TEST):
12458 * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
12460 2019-01-31 Chris Dumez <cdumez@apple.com>
12462 Page zoom level is lost after a process swap or a crash
12463 https://bugs.webkit.org/show_bug.cgi?id=194105
12464 <rdar://problem/47610781>
12466 Reviewed by Alex Christensen.
12468 Add API test coverage.
12470 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12471 (-[PSONNavigationDelegate webView:didCommitNavigation:]):
12473 2019-01-31 Alex Christensen <achristensen@webkit.org>
12475 Revert r238819 which is unneeded and caused a performance regression.
12476 https://bugs.webkit.org/show_bug.cgi?id=192272
12477 <rdar://problem/46664625>
12479 * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
12480 (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
12481 (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
12483 2019-01-31 Jiewen Tan <jiewen_tan@apple.com>
12485 Formalize WebKitAdditions mechanism of LoadOptimizer
12486 https://bugs.webkit.org/show_bug.cgi?id=193886
12487 <rdar://problem/47696809>
12489 Reviewed by Brent Fulgham.
12491 * MiniBrowser/MiniBrowser.entitlements:
12492 Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
12494 2019-01-31 Zalan Bujtas <zalan@apple.com>
12496 [LFC] Margin before/after/start/end initial value is 0 and not auto.
12497 https://bugs.webkit.org/show_bug.cgi?id=194090
12499 Reviewed by Antti Koivisto.
12501 * LayoutReloaded/misc/LFC-passing-tests.txt:
12503 2019-01-31 Zalan Bujtas <zalan@apple.com>
12505 [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
12506 https://bugs.webkit.org/show_bug.cgi?id=194074
12508 Reviewed by Antti Koivisto.
12510 * LayoutReloaded/misc/LFC-passing-tests.txt:
12512 2019-01-31 Zalan Bujtas <zalan@apple.com>
12514 [LFC][BFC] Add support for block level replaced box.
12515 https://bugs.webkit.org/show_bug.cgi?id=194071
12517 Reviewed by Antti Koivisto.
12519 * LayoutReloaded/misc/LFC-passing-tests.txt:
12521 2019-01-31 Fujii Hironori <Hironori.Fujii@sony.com>
12523 Fix WebKitTestRunner's testPath with Windows full paths
12524 https://bugs.webkit.org/show_bug.cgi?id=194012
12526 Reviewed by Alex Christensen.
12528 updateTestOptionsFromTestHeader failed to open test files because
12529 testPath returned wrong file paths. It returned a path "/C:/..."
12530 if a URL "file:///C:/..." was given.
12532 * WebKitTestRunner/TestController.cpp:
12533 (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
12535 2019-01-31 Carlos Garcia Campos <cgarcia@igalia.com>
12537 [WPE] Bump font related dependencies to match the GTK+ port
12538 https://bugs.webkit.org/show_bug.cgi?id=194017
12540 Reviewed by Žan Doberšek.
12542 * wpe/jhbuild.modules:
12543 * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
12544 * wpe/patches/icudata-stdlibs.patch: Added.
12546 2019-01-30 Ryosuke Niwa <rniwa@webkit.org>
12548 Enable swipe tests on iOS
12549 https://bugs.webkit.org/show_bug.cgi?id=194076
12551 Reviewed by Geoffrey Garen.
12553 Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
12554 it causes a debug assertion failure in runUIScript.
12556 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
12557 (WTR::UIScriptController::beginBackSwipe):
12558 (WTR::UIScriptController::completeBackSwipe):
12560 2019-01-30 Keith Rollin <krollin@apple.com>
12562 Use correct printf format specifier
12563 https://bugs.webkit.org/show_bug.cgi?id=194062
12564 <rdar://problem/47686167>
12566 Reviewed by Alexey Proskuryakov.
12568 LayoutTestSpellChecker.mm is trying to format a variable of type
12569 NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
12570 actually an unsigned long long. Fix this by formatting with %llu.
12572 * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
12573 (-[LayoutTestTextCheckingResult description]):
12575 2019-01-30 Ryosuke Niwa <rniwa@webkit.org>
12577 REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
12578 https://bugs.webkit.org/show_bug.cgi?id=193979
12580 Reviewed by Wenson Hsieh.
12582 Fix the test for iOS. Make the test work with iOS UA string.
12584 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
12586 2019-01-30 Ryan Haddad <ryanhaddad@apple.com>
12588 Replace High Sierra LLINT CLoop bot due to hardware failure
12589 https://bugs.webkit.org/show_bug.cgi?id=194066
12591 Reviewed by Aakash Jain.
12593 * BuildSlaveSupport/build.webkit.org-config/config.json:
12595 2019-01-30 Keith Rollin <krollin@apple.com>
12597 [NSDragItem init] is unavailable
12598 https://bugs.webkit.org/show_bug.cgi?id=194059
12599 <rdar://problem/47685715>
12601 Reviewed by Wenson Hsieh.
12603 [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
12604 DumpRenderTree and TestWebKitAPI, which both try to create an
12605 NSDragItem in a manner that invokes this method. Address this by using
12606 -initWithPasteboardWriter instead.
12608 Note that the parameter passed to initWithPasteboardWriter is likely
12609 incorrect. In both cases, the object passed does not conform to
12610 NSPasteboardWriting. However, with this fix, we're no worse off than
12611 before, and can now perform builds with newer compilers and SDKs until
12612 a real fix can be crafted. That work is tracked in
12613 https://bugs.webkit.org/show_bug.cgi?id=194060
12615 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
12616 (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
12617 * TestWebKitAPI/mac/TestDraggingInfo.mm:
12618 (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
12620 2019-01-30 Daniel Bates <dabates@apple.com>
12622 [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
12623 https://bugs.webkit.org/show_bug.cgi?id=192824
12624 <rdar://problem/47100332>
12626 Reviewed by Wenson Hsieh.
12628 Fix a bug where the wrong usage code was used for F13 thru F24.
12630 * WebKitTestRunner/ios/HIDEventGenerator.mm:
12631 (keyCodeForDOMFunctionKey):
12633 2019-01-30 Chris Dumez <cdumez@apple.com>
12635 Regression(PSON) Load hang can occur on history navigation
12636 https://bugs.webkit.org/show_bug.cgi?id=194030
12637 <rdar://problem/47656939>
12639 Reviewed by Antti Koivisto.
12641 Add API test coverage.
12643 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12645 2019-01-30 Zalan Bujtas <zalan@apple.com>
12647 [LFC] Expand tests coverage.
12649 Unreviewed test gardening.
12651 * LayoutReloaded/misc/LFC-passing-tests.txt:
12653 2019-01-30 Thibault Saunier <tsaunier@igalia.com>
12655 [Flatpak] Add openjpeg support
12656 https://bugs.webkit.org/show_bug.cgi?id=194019
12658 Reviewed by Michael Catanzaro.
12660 * flatpak/org.webkit.CommonModules.yaml:
12662 2019-01-30 Commit Queue <commit-queue@webkit.org>
12664 Unreviewed, rolling out r240708.
12665 https://bugs.webkit.org/show_bug.cgi?id=194022
12667 It broke WPE build (Requested by KaL on #webkit).
12669 Reverted changeset:
12671 "[WPE] Bump font related dependencies to match the GTK+ port"
12672 https://bugs.webkit.org/show_bug.cgi?id=194017
12673 https://trac.webkit.org/changeset/240708
12675 2019-01-30 Zalan Bujtas <zalan@apple.com>
12677 [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
12678 https://bugs.webkit.org/show_bug.cgi?id=194001
12680 Reviewed by Antti Koivisto.
12682 * LayoutReloaded/misc/LFC-passing-tests.txt:
12684 2019-01-30 Zalan Bujtas <zalan@apple.com>
12686 [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
12687 https://bugs.webkit.org/show_bug.cgi?id=194020
12689 Reviewed by Antti Koivisto.
12691 * LayoutReloaded/misc/LFC-passing-tests.txt:
12693 2019-01-30 Chris Fleizach <cfleizach@apple.com>
12695 AX: Support color well on iOS
12696 https://bugs.webkit.org/show_bug.cgi?id=194010
12698 Reviewed by Joanmarie Diggs.
12700 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
12701 (WTR::AccessibilityUIElement::stringAttributeValue):
12703 2019-01-30 Carlos Garcia Campos <cgarcia@igalia.com>
12705 [WPE] Bump font related dependencies to match the GTK+ port
12706 https://bugs.webkit.org/show_bug.cgi?id=194017
12708 Reviewed by Žan Doberšek.
12710 * wpe/jhbuild.modules:
12711 * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
12712 * wpe/patches/icudata-stdlibs.patch: Added.
12714 2019-01-29 Alexey Proskuryakov <ap@apple.com>
12716 [Mac] Update window scale API usage
12717 https://bugs.webkit.org/show_bug.cgi?id=193991
12718 rdar://problem/47614795
12720 Reviewed by Tim Horton.
12722 * DumpRenderTree/mac/DumpRenderTree.mm:
12723 (changeWindowScaleIfNeeded):
12724 * DumpRenderTree/mac/DumpRenderTreeWindow.h:
12725 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
12726 (WTR::PlatformWebView::changeWindowScaleIfNeeded):
12728 2019-01-29 Chris Dumez <cdumez@apple.com>
12730 REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
12731 https://bugs.webkit.org/show_bug.cgi?id=193977
12732 <rdar://problem/47643716>
12734 Reviewed by Geoff Garen.
12736 Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
12737 didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
12738 to the previous provisional committing *before* we make the last load.
12740 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12742 2019-01-29 Youenn Fablet <youenn@apple.com>
12744 Adopt new SPI to evaluate server certificate trust
12745 https://bugs.webkit.org/show_bug.cgi?id=193355
12747 Reviewed by Alex Christensen.
12749 Add infrastructure to handle HTTPS server trust evaluation testing.
12751 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
12752 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
12753 (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
12754 (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
12755 (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
12756 * WebKitTestRunner/InjectedBundle/TestRunner.h:
12757 * WebKitTestRunner/TestController.cpp:
12758 (WTR::TestController::resetPreferencesToConsistentValues):
12759 (WTR::TestController::didReceiveAuthenticationChallenge):
12760 (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
12761 * WebKitTestRunner/TestController.h:
12762 (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
12763 * WebKitTestRunner/TestInvocation.cpp:
12764 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
12765 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
12766 (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
12768 2019-01-29 Aakash Jain <aakash_jain@apple.com>
12770 [ews-build] Add build step to print bot Configuration
12771 https://bugs.webkit.org/show_bug.cgi?id=193887
12773 Reviewed by Lucas Forschler.
12775 * BuildSlaveSupport/ews-build/steps.py:
12776 (PrintConfiguration): Build step to print configuration.
12777 * BuildSlaveSupport/ews-build/factories.py:
12779 2019-01-29 Chris Dumez <cdumez@apple.com>
12781 Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
12782 https://bugs.webkit.org/show_bug.cgi?id=193967
12783 <rdar://problem/47635348>
12785 Reviewed by Alex Christensen.
12787 Add API test coverage.
12789 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12790 (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
12792 2019-01-29 Aakash Jain <aakash_jain@apple.com>
12794 [ews-app] Handle incoming results data
12795 https://bugs.webkit.org/show_bug.cgi?id=193973
12797 Reviewed by Lucas Forschler.
12799 * BuildSlaveSupport/ews-app/ews/views/results.py:
12801 2019-01-29 Aakash Jain <aakash_jain@apple.com>
12803 [ews-app] Make the results url generic
12804 https://bugs.webkit.org/show_bug.cgi?id=193928
12806 Reviewed by Lucas Forschler.
12808 * BuildSlaveSupport/ews-app/ews/urls.py:
12810 2019-01-29 Aakash Jain <aakash_jain@apple.com>
12812 [ews-build] Configure buildbot to send events to ews-app
12813 https://bugs.webkit.org/show_bug.cgi?id=193968
12815 Reviewed by Lucas Forschler.
12817 * BuildSlaveSupport/ews-build/events.py: Added.
12818 * BuildSlaveSupport/ews-build/master.cfg:
12820 2019-01-29 Keith Rollin <krollin@apple.com>
12822 Add .xcfilelists to Run Script build phases
12823 https://bugs.webkit.org/show_bug.cgi?id=193792
12824 <rdar://problem/47201785>
12826 Reviewed by Alex Christensen.
12828 As part of supporting XCBuild, update the necessary Run Script build
12829 phases in their Xcode projects to refer to their associated
12832 Note that the addition of these files bumps the Xcode project version
12833 number to something that's Xcode 10 compatible. This change means that
12834 older versions of the Xcode IDE can't read these projects. Nor can it
12835 fully load workspaces that refer to these projects (the updated
12836 projects are shown as non-expandable placeholders). `xcodebuild` can
12837 still build these projects; it's just that the IDE can't open them.
12839 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
12840 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
12842 2019-01-29 John Wilander <wilander@apple.com>
12844 Add data abstraction and validation for Ad Click Attribution
12845 https://bugs.webkit.org/show_bug.cgi?id=193916
12846 <rdar://problem/47603481>
12848 Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
12850 Ad click attribution has two steps. First, the storage of an ad
12851 campaign ID for a click that takes the user to a destination
12852 site. Second, a conversion on the destination site that can be
12853 attributed to the ad click.
12855 This patch adds a class that represents a request for ad click
12856 attribution. Validation makes sure that the bits of entropy
12857 reported through this mechanism is limited.
12859 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12860 * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
12861 (TestWebKitAPI::TEST):
12863 2019-01-29 Chris Dumez <cdumez@apple.com>
12865 REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
12866 https://bugs.webkit.org/show_bug.cgi?id=193932
12867 <rdar://problem/47598947>
12869 Reviewed by Brady Eidson.
12871 Add API test coverage.
12873 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12875 2019-01-29 Zalan Bujtas <zalan@apple.com>
12877 Adding new passing LFC tests.
12879 Unreviewed test gardening.
12881 * LayoutReloaded/misc/LFC-passing-tests.txt:
12883 2019-01-29 Zalan Bujtas <zalan@apple.com>
12885 [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
12886 https://bugs.webkit.org/show_bug.cgi?id=193964
12888 Reviewed by Antti Koivisto.
12890 * LayoutReloaded/misc/LFC-passing-tests.txt:
12892 2019-01-29 Zalan Bujtas <zalan@apple.com>
12894 [LFC][BFC] Do not ignore next sibling box while laying out BFC.
12895 https://bugs.webkit.org/show_bug.cgi?id=193954
12897 Reviewed by Antti Koivisto.
12899 * LayoutReloaded/misc/LFC-passing-tests.txt:
12901 2019-01-29 Carlos Garcia Campos <cgarcia@igalia.com>
12903 WebDriver: add support for running subtests
12904 https://bugs.webkit.org/show_bug.cgi?id=193904
12906 Reviewed by Michael Catanzaro.
12908 pytest already supports it by passing test.py::subtest, so we can do the same.
12910 * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
12911 (get_item_name): Made this global.
12912 (CollectRecorder.__init__): Receive the parameter to ignore.
12913 (CollectRecorder.pytest_collectreport): Collect also the subtests.
12914 (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
12915 (collect): Add parameter to ignore.
12916 * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
12917 (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
12918 * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
12919 (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
12920 (WebDriverTestRunnerSelenium.run): Ditto.
12921 * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
12922 (WebDriverTestRunnerW3C.collect_tests): Ditto.
12923 (WebDriverTestRunnerW3C.run): Ditto.
12925 2019-01-28 Ryosuke Niwa <rniwa@webkit.org>
12927 User agent string override for navigator.userAgent should be site specific quirks
12928 https://bugs.webkit.org/show_bug.cgi?id=193950
12930 Reviewed by Brent Fulgham.
12932 Updated per the _WKWebsitePolicies rename.
12934 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
12935 (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
12937 2019-01-28 Ross Kirsling <ross.kirsling@sony.com>
12939 Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
12940 https://bugs.webkit.org/show_bug.cgi?id=193941
12942 Reviewed by Alex Christensen.
12944 * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
12945 * TestWebKitAPI/Tests/WTF/Condition.cpp:
12946 * TestWebKitAPI/Tests/WTF/Lock.cpp:
12947 * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
12948 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
12949 * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
12950 * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
12951 * TestWebKitAPI/Tests/WTF/Time.cpp:
12952 * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
12953 * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
12954 * TestWebKitAPI/Tests/WebCore/Logging.cpp:
12955 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
12957 2019-01-28 Yusuke Suzuki <ysuzuki@apple.com>
12959 Unreviewed, reorder my emails to fix autocomplete in bugzilla
12961 * Scripts/webkitpy/common/config/contributors.json:
12963 2019-01-28 Andy Estes <aestes@apple.com>
12965 [watchOS] Enable Parental Controls content filtering
12966 https://bugs.webkit.org/show_bug.cgi?id=193939
12967 <rdar://problem/46641912>
12969 Reviewed by Ryosuke Niwa.
12971 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
12973 2019-01-28 David Kilzer <ddkilzer@apple.com>
12975 REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
12976 <https://webkit.org/b/193884>
12978 Reviewed by Jiewen Tan.
12980 * Scripts/webkitpy/style/checkers/cpp.py:
12981 (check_language): Add LocalAuthentication to
12982 `frameworks_with_soft_links`.
12984 2019-01-28 Fujii Hironori <Hironori.Fujii@sony.com>
12986 [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
12987 https://bugs.webkit.org/show_bug.cgi?id=193891
12989 Reviewed by Ross Kirsling.
12991 There were three problems in window sizes of WebView and the host window.
12992 1. The sizes of pixel image output were incorrect.
12993 2. The host window is going to appear after window.resize was invoked.
12994 3. window.resize resized only the host window, not WebView.
12996 This change solves them with a following approach.
12997 a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
12998 b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
12999 as well as DumpRenderTree in order to match the client area and the window area.
13000 c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
13001 d. PlatformWebView::setWindowFrame changes both window sizes.
13002 e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
13004 * WebKitTestRunner/win/PlatformWebViewWin.cpp:
13005 (WTR::PlatformWebView::PlatformWebView): Create the host window
13006 and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
13007 (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
13008 (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
13010 2019-01-28 Aakash Jain <aakash_jain@apple.com>
13012 [ews-app] Add method to save Step data to database
13013 https://bugs.webkit.org/show_bug.cgi?id=193890
13015 Reviewed by Lucas Forschler.
13017 * BuildSlaveSupport/ews-app/ews/models/step.py:
13018 (Step.save_step): Method to save step data.
13019 (Step.update_step): Method to update step data.
13020 (Step.get_existing_step): Method to fetch existing step from database.
13021 (Step.is_valid_result): Method to validate valid step result.
13023 2019-01-28 Aakash Jain <aakash_jain@apple.com>
13025 [ews-app] Add method to save Build data to database
13026 https://bugs.webkit.org/show_bug.cgi?id=193735
13028 Reviewed by Lucas Forschler.
13030 * BuildSlaveSupport/ews-app/ews/models/build.py:
13031 (Build.save_build): Method to save build information to database.
13032 (Build.get_existing_build): Method to fetch existing build from database.
13033 (Build.is_valid_result): Method to validate build result.
13034 * BuildSlaveSupport/ews-app/ews/common/util.py:
13035 (is_valid_int_id): Method to validate valid id.
13037 2019-01-28 Chris Dumez <cdumez@apple.com>
13039 Regression(PSON) Crash under WebPageProxy::didStartProgress()
13040 https://bugs.webkit.org/show_bug.cgi?id=193915
13041 <rdar://problem/47560907>
13043 Reviewed by Alex Christensen.
13045 Add API test coverage.
13047 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
13049 2019-01-28 Aakash Jain <aakash_jain@apple.com>
13051 [ews-app] Rename id variables
13052 https://bugs.webkit.org/show_bug.cgi?id=193883
13054 Reviewed by Lucas Forschler.
13056 * BuildSlaveSupport/ews-app/ews/models/build.py:
13057 * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
13058 * BuildSlaveSupport/ews-app/ews/models/step.py:
13059 * BuildSlaveSupport/ews-app/ews/urls.py:
13060 * BuildSlaveSupport/ews-app/ews/views/patch.py:
13061 * BuildSlaveSupport/ews-app/ews/views/results.py:
13062 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
13064 2019-01-28 Aakash Jain <aakash_jain@apple.com>
13066 [ews-app] Allow certain fields to be empty
13067 https://bugs.webkit.org/show_bug.cgi?id=193892
13069 Reviewed by Lucas Forschler.
13071 * BuildSlaveSupport/ews-app/ews/models/build.py:
13072 * BuildSlaveSupport/ews-app/ews/models/step.py:
13074 2019-01-28 Rob Buis <rbuis@igalia.com>
13076 Update MIME type parser
13077 https://bugs.webkit.org/show_bug.cgi?id=180526
13079 Reviewed by Frédéric Wang.
13081 * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
13082 (TestWebKitAPI::TEST):
13084 2019-01-28 Zalan Bujtas <zalan@apple.com>
13086 [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
13087 https://bugs.webkit.org/show_bug.cgi?id=193896
13089 Reviewed by Antti Koivisto.
13091 * LayoutReloaded/misc/LFC-passing-tests.txt:
13093 2018-12-15 Darin Adler <darin@apple.com>
13095 Replace many uses of String::format with more type-safe alternatives
13096 https://bugs.webkit.org/show_bug.cgi?id=192742
13098 Reviewed by Mark Lam.
13100 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
13101 (WTR::cacheTestRunnerCallback): Use makeString.
13102 * WebKitTestRunner/TestController.cpp:
13103 (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
13104 (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
13106 2019-01-27 Jiewen Tan <jiewen_tan@apple.com>
13108 Use a load optimizer for some sites
13109 https://bugs.webkit.org/show_bug.cgi?id=193881
13110 <rdar://problem/46325455>
13112 Reviewed by Brent Fulgham.
13114 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13115 * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
13117 2019-01-27 Chris Fleizach <cfleizach@apple.com>
13119 AX: Introduce a static accessibility tree
13120 https://bugs.webkit.org/show_bug.cgi?id=193348
13121 <rdar://problem/47203295>
13123 Reviewed by Ryosuke Niwa.
13125 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
13127 2019-01-26 Zalan Bujtas <zalan@apple.com>
13129 [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
13130 https://bugs.webkit.org/show_bug.cgi?id=193867
13132 Reviewed by Antti Koivisto.
13134 * LayoutReloaded/misc/LFC-passing-tests.txt:
13136 2019-01-26 Zalan Bujtas <zalan@apple.com>
13138 [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
13139 https://bugs.webkit.org/show_bug.cgi?id=193865
13141 Reviewed by Antti Koivisto.
13143 * LayoutReloaded/misc/LFC-passing-tests.txt:
13145 2019-01-25 Ryosuke Niwa <rniwa@webkit.org>
13147 Need a mechanism to override navigator.userAgent
13148 https://bugs.webkit.org/show_bug.cgi?id=193762
13149 <rdar://problem/47504939>
13151 Reviewed by Brent Fulgham.
13153 Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
13155 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
13156 (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
13157 (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
13159 2019-01-25 Dean Jackson <dino@apple.com>
13161 REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
13162 https://bugs.webkit.org/show_bug.cgi?id=193831
13163 <rdar://problem/47399263>
13165 Reviewed by Chris Dumez.
13167 Two new tests that exercise cross-origin and same-origin System
13170 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
13172 2019-01-25 Keith Rollin <krollin@apple.com>
13174 Update Xcode projects with "Check .xcfilelists" build phase
13175 https://bugs.webkit.org/show_bug.cgi?id=193790
13176 <rdar://problem/47201374>
13178 Reviewed by Alex Christensen.
13180 Support for XCBuild includes specifying inputs and outputs to various
13181 Run Script build phases. These inputs and outputs are specified as
13182 .xcfilelist files. Once created, these .xcfilelist files need to be
13183 kept up-to-date. In order to check that they are up-to-date or not,
13184 add an Xcode build step that invokes an external script that performs
13185 the checking. If the .xcfilelists are found to be out-of-date, update
13186 them, halt the build, and instruct the developer to restart the build
13187 with up-to-date files.
13189 At this time, the checking and regenerating is performed only if the
13190 WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
13191 who want to use this facility can set this variable and test out the
13192 checking/regenerating. Once it seems like there are no egregious
13193 issues that upset a developer's workflow, we'll unconditionally enable
13196 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
13197 * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
13198 * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
13199 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
13201 2019-01-25 Keith Rollin <krollin@apple.com>
13203 Update Xcode projects with "Apply Configuration to XCFileLists" build target
13204 https://bugs.webkit.org/show_bug.cgi?id=193781
13205 <rdar://problem/47201153>
13207 Reviewed by Alex Christensen.
13209 Part of generating the .xcfilelists used as part of adopting XCBuild
13210 includes running `make DerivedSources.make` from a standalone script.
13211 It’s important for this invocation to have the same environment as
13212 when the actual build invokes `make DerivedSources.make`. If the
13213 environments are different, then the two invocations will provide
13214 different results. In order to get the same environment in the
13215 standalone script, have the script launch xcodebuild targeting the
13216 "Apply Configuration to XCFileLists" build target, which will then
13217 re-invoke our standalone script. The script is now running again, this
13218 time in an environment with all workspace, project, target, xcconfig
13219 and other environment variables established.
13221 The "Apply Configuration to XCFileLists" build target accomplishes
13222 this task via a small embedded shell script that consists only of:
13224 eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
13226 The process that invokes "Apply Configuration to XCFileLists" first
13227 sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
13228 evaluated and exports it into the shell environment. When xcodebuild
13229 is invoked, it inherits the value of this variable and can `eval` the
13230 contents of that variable. Our external standalone script can then set
13231 WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
13232 of command-line parameters needed to restart itself in the appropriate
13235 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
13236 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
13238 2019-01-25 Alex Christensen <achristensen@webkit.org>
13240 Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
13241 https://bugs.webkit.org/show_bug.cgi?id=193802
13242 <rdar://problem/46010580>
13244 Reviewed by Andy Estes.
13246 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
13247 (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
13250 2019-01-25 Daniel Bates <dabates@apple.com>
13252 [iOS] uiController.keyDown() does not translate Control modified key
13253 https://bugs.webkit.org/show_bug.cgi?id=192898
13255 Reviewed by Wenson Hsieh.
13257 Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
13258 key translation, as applicable. Among other cases, key translation occurs when performing
13259 a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
13260 also makes the behavior of uiController.keyDown() more closely match the behavior of a
13261 human pressing down and releasing key(s) using a hardware keyboard.
13263 * WebKitTestRunner/ios/HIDEventGenerator.h:
13264 * WebKitTestRunner/ios/HIDEventGenerator.mm:
13265 (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
13267 (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
13268 (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
13269 (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
13270 (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
13271 (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
13272 (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
13273 (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
13274 (-[HIDEventGenerator longPress:completionBlock:]):
13275 (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
13276 Update code for above renaming.
13278 (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
13279 DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
13281 (-[HIDEventGenerator keyDown:]): Added.
13282 (-[HIDEventGenerator keyUp:]): Added.
13283 (-[HIDEventGenerator keyPress:completionBlock:]):
13284 (-[HIDEventGenerator eventDispatchThreadEntry:]):
13285 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
13286 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
13287 (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
13288 (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
13289 (WTR::parseModifier): Deleted.
13291 2019-01-25 Keith Rollin <krollin@apple.com>
13293 Complete the implementation of generate-xcfilelists
13294 https://bugs.webkit.org/show_bug.cgi?id=193782
13296 Reviewed by Alex Christensen.
13298 A preliminary version of generate-xcfilelists was added in r238008.
13299 This patch updates that script in order to:
13301 - Support checking of .xcfilelists
13302 - Perform better execution of `make DerivedSources.make` by
13303 relaunching generate-xcfilelists under xcodebuild
13304 - Support incremental generation and checking of .xcfilelists
13305 - Support supplementary .xcfilelists files from WebKitAdditions
13306 - Support being wrapped by parallel version of generate-xcfilelists in
13307 Internal that adds support for (re)generating WebKit projects in
13309 - Support builds that have been performed in WebKitBuild as well as
13310 ~/Library/Developer/code/DerivedData
13311 - Increase robustness and debugging facilities.
13313 * Scripts/generate-xcfilelists:
13315 2019-01-25 Brent Fulgham <bfulgham@apple.com>
13317 Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
13318 https://bugs.webkit.org/show_bug.cgi?id=193297
13319 <rdar://problem/47158841>
13321 Unreviewed test case fix.
13323 These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
13324 Previously, the default data store turned the feature on automatically, allowing these tests to pass.
13326 * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
13329 2019-01-25 Keith Rollin <krollin@apple.com>
13331 Update existing .xcfilelists
13332 https://bugs.webkit.org/show_bug.cgi?id=193791
13333 <rdar://problem/47201706>
13335 Reviewed by Alex Christensen.
13337 Many .xcfilelist files were added in r238824 in order to support
13338 XCBuild. Update these with recent changes to the set of build files
13339 and with the current generate-xcfilelist script.
13341 * DumpRenderTree/DerivedSources-input.xcfilelist:
13342 * DumpRenderTree/DerivedSources-output.xcfilelist:
13343 * WebKitTestRunner/DerivedSources-input.xcfilelist:
13344 * WebKitTestRunner/DerivedSources-output.xcfilelist:
13346 2019-01-25 Keith Rollin <krollin@apple.com>
13348 Fix missing dependencies in extract-dependencies-from-makefile
13349 https://bugs.webkit.org/show_bug.cgi?id=193783
13350 <rdar://problem/47201571>
13352 Reviewed by Alex Christensen.
13354 The extract-dependencies-from-makefile script generates .xcfilelists
13355 for XCBuild by invoking a makefile in --debug mode, parsing the
13356 dependency information in the output, and extracting information
13357 regarding targets and dependents. However, the way `make` emits this
13358 dependency information is not rigorous, and so we need to determine
13359 what lines to look for and parse by trial and error. This approach
13360 didn't coriginally atch all the information we needed to collect, so
13361 update the script to look for the additional lines we now know to look
13364 * Scripts/extract-dependencies-from-makefile:
13366 (Parser.addTarget):
13367 (Parser.addPrereq):
13370 2019-01-25 Brent Fulgham <bfulgham@apple.com>
13372 Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
13373 https://bugs.webkit.org/show_bug.cgi?id=193297
13374 <rdar://problem/47158841>
13376 Reviewed by Alex Christensen.
13378 * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
13379 Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
13380 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
13381 (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
13382 activating the message used to trigger the callback when it is set.
13384 2019-01-25 Alex Christensen <achristensen@webkit.org>
13386 WKWebView.goBack should reload if there is a safe browsing warning
13387 https://bugs.webkit.org/show_bug.cgi?id=193805
13388 <rdar://problem/46908216>
13390 Reviewed by Geoff Garen.
13392 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
13393 (+[Simple3LookupContext sharedLookupContext]):
13394 (-[Simple3LookupContext lookUpURL:completionHandler:]):
13395 (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
13398 2019-01-25 Chris Dumez <cdumez@apple.com>
13400 Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
13401 https://bugs.webkit.org/show_bug.cgi?id=193788
13402 <rdar://problem/47531231>
13404 Reviewed by Alex Christensen.
13406 Add API test coverage.
13408 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
13409 (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
13411 2019-01-25 Jonathan Bedard <jbedard@apple.com>
13413 webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
13414 https://bugs.webkit.org/show_bug.cgi?id=193771
13416 Unreviewed infrastructure fix.
13418 * Scripts/webkitpy/port/darwin.py:
13419 (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
13421 2019-01-25 Alexey Proskuryakov <ap@apple.com>
13423 * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
13425 2019-01-25 Alexey Proskuryakov <ap@apple.com>
13427 Add contributors.json entries for Ling Ho and for a new bot watchers group.
13429 * Scripts/webkitpy/common/config/contributors.json:
13431 2019-01-25 Chris Dumez <cdumez@apple.com>
13433 Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
13434 https://bugs.webkit.org/show_bug.cgi?id=193779
13435 <rdar://problem/46170903>
13437 Reviewed by Antti Koivisto.
13439 Add API test that quickly navigates forward to a previous process without waiting for it to
13440 suspend. I suspect the crash could have been happening due to receiving leftover IPC from
13441 the process' previous page when reconnecting the it for the forward navigation.
13443 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
13445 2019-01-25 Wenson Hsieh <wenson_hsieh@apple.com>
13447 Need a way for JavaScript (or bundle) code to participate in undo
13448 https://bugs.webkit.org/show_bug.cgi?id=190009
13449 <rdar://problem/44807048>
13451 Reviewed by Ryosuke Niwa.
13453 Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
13454 Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
13456 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
13457 (WTR::UIScriptController::lastUndoLabel const):
13458 (WTR::UIScriptController::firstRedoLabel const):
13459 (WTR::UIScriptController::platformUndoManager const):
13460 * DumpRenderTree/mac/UIScriptControllerMac.mm:
13461 (WTR::UIScriptController::lastUndoLabel const):
13462 (WTR::UIScriptController::firstRedoLabel const):
13463 (WTR::UIScriptController::platformUndoManager const):
13464 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
13465 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
13466 (WTR::UIScriptController::lastUndoLabel const):
13467 (WTR::UIScriptController::firstRedoLabel const):
13468 * TestRunnerShared/UIScriptContext/UIScriptController.h:
13469 * WebKitTestRunner/UIScriptControllerCocoa.mm:
13470 (WTR::UIScriptController::lastUndoLabel const):
13471 (WTR::UIScriptController::firstRedoLabel const):
13472 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
13473 (WTR::UIScriptController::platformUndoManager const):
13474 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
13475 (WTR::UIScriptController::platformUndoManager const):
13477 2019-01-25 Zalan Bujtas <zalan@apple.com>
13479 [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
13480 https://bugs.webkit.org/show_bug.cgi?id=193824
13482 Reviewed by Antti Koivisto.
13484 * LayoutReloaded/misc/LFC-passing-tests.txt:
13486 2019-01-24 Ryan Haddad <ryanhaddad@apple.com>
13488 Update macOS JSC bot configurations
13489 https://bugs.webkit.org/show_bug.cgi?id=193739
13491 Reviewed by Alexey Proskuryakov.
13493 * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
13494 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
13495 (BubbleQueueServer): Move JSC EWS to Mojave section.
13496 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
13497 (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
13498 * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
13500 2019-01-24 Fujii Hironori <Hironori.Fujii@sony.com>
13502 [Win][WebKitTestRunner] Implement EventSenderProxy
13503 https://bugs.webkit.org/show_bug.cgi?id=193755
13505 Reviewed by Don Olmstead.
13507 * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
13508 * WebKitTestRunner/win/EventSenderProxyWin.cpp:
13509 (WTR::EventSenderProxy::dispatchMessage):
13510 (WTR::EventSenderProxy::EventSenderProxy):
13511 (WTR::EventSenderProxy::mouseDown):
13512 (WTR::EventSenderProxy::mouseUp):
13513 (WTR::EventSenderProxy::mouseMoveTo):
13514 (WTR::EventSenderProxy::mouseScrollBy):
13515 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
13517 2019-01-24 Ross Kirsling <ross.kirsling@sony.com>
13519 Unreviewed fix for API test failure after r240437.
13521 TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
13523 * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
13525 2019-01-24 Jonathan Bedard <jbedard@apple.com>
13527 [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
13528 https://bugs.webkit.org/show_bug.cgi?id=193787
13529 <rdar://problem/47497634>
13531 Reviewed by Alexey Proskuryakov.
13533 * Scripts/webkitdirs.pm:
13534 (iosSimulatorApplicationsPath): Pick from available runtime directories.
13536 2019-01-24 Truitt Savell <tsavell@apple.com>
13538 Unreviewed, rolling out r240446.
13540 Casued 5 API failures
13542 Reverted changeset:
13544 "Activate the WebResourceLoadStatisticsStore in the
13545 NetworkProcess and deactivate it in the UIProcess."
13546 https://bugs.webkit.org/show_bug.cgi?id=193297
13547 https://trac.webkit.org/changeset/240446
13549 2019-01-24 Zalan Bujtas <zalan@apple.com>
13551 DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
13552 https://bugs.webkit.org/show_bug.cgi?id=193741
13553 <rdar://problem/47135030>
13555 Reviewed by Antti Koivisto and Simon Fraser.
13557 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13558 * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
13559 (TestWebKitAPI::TEST):
13561 2019-01-24 Brent Fulgham <bfulgham@apple.com>
13563 Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
13564 https://bugs.webkit.org/show_bug.cgi?id=193297
13565 <rdar://problem/47158841>
13567 Reviewed by Alex Christensen.
13569 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
13570 (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
13571 activating the message used to trigger the callback when it is set.
13573 2019-01-24 John Wilander <wilander@apple.com>
13575 Add Ad Click Attribution as an internal/experimental feature
13576 https://bugs.webkit.org/show_bug.cgi?id=193685
13577 <rdar://problem/47450399>
13579 Reviewed by Brent Fulgham.
13581 Added test option adClickAttributionEnabled.
13583 * DumpRenderTree/TestOptions.cpp:
13584 (TestOptions::TestOptions):
13585 * DumpRenderTree/TestOptions.h:
13586 * DumpRenderTree/mac/DumpRenderTree.mm:
13587 (setWebPreferencesForTestOptions):
13589 2019-01-24 Antti Koivisto <antti@apple.com>
13591 [PSON] Flash on back navigation on Mac
13592 https://bugs.webkit.org/show_bug.cgi?id=193716
13593 <rdar://problem/47148458>
13595 Reviewed by Chris Dumez.
13597 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
13599 Closing of the previous page is delayed so waiting for didFinishNavigation is
13600 not sufficient to guarantee we have received all the messages. Wait for them.
13602 2019-01-24 Chris Dumez <cdumez@apple.com>
13604 Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
13605 https://bugs.webkit.org/show_bug.cgi?id=193761
13606 <rdar://problem/47456405>
13608 Reviewed by Alex Christensen.
13610 Add API test coverage.
13612 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
13614 2019-01-24 Jonathan Bedard <jbedard@apple.com>
13616 webkitpy: Missing PID in crashlog name should not be fatal
13617 https://bugs.webkit.org/show_bug.cgi?id=193771
13619 If we can't determine the PID of a crashlog, just ignore the crashlog instead
13620 of raising an exception.
13622 Reviewed by Lucas Forschler.
13624 * Scripts/webkitpy/port/darwin.py:
13625 (DarwinPort._merge_crash_logs):
13627 2019-01-24 Michael Catanzaro <mcatanzaro@igalia.com>
13629 test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
13630 https://bugs.webkit.org/show_bug.cgi?id=193746
13632 Reviewed by Youenn Fablet.
13634 It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
13635 so we'd best just not call it.
13637 * Scripts/webkitpy/w3c/test_exporter.py:
13638 (WebPlatformTestExporter.create_branch_with_patch):
13640 2019-01-24 Ross Kirsling <ross.kirsling@sony.com>
13642 Move FileSystem to WTF
13643 https://bugs.webkit.org/show_bug.cgi?id=193602
13645 Reviewed by Yusuke Suzuki.
13647 * DumpRenderTree/win/DumpRenderTree.cpp:
13648 * TestWebKitAPI/CMakeLists.txt:
13649 * TestWebKitAPI/PlatformGTK.cmake:
13650 * TestWebKitAPI/PlatformJSCOnly.cmake:
13651 * TestWebKitAPI/PlatformPlayStation.cmake:
13652 * TestWebKitAPI/PlatformWPE.cmake:
13653 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13654 * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
13655 * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
13656 * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
13657 * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
13658 * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
13659 * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
13660 * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
13661 * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
13662 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
13664 2019-01-24 Philippe Normand <pnormand@igalia.com>
13666 [WPE] Remove hard dependency on subprocess32 for the API tests
13668 Rubber-stamped by Carlos Garcia Campos.
13670 * glib/api_test_runner.py:
13671 (TestRunner._run_test_qt): Lazily import subprocess32 and check
13672 its presence only when running WPEQt tests.
13674 2019-01-24 Carlos Garcia Campos <cgarcia@igalia.com>
13676 [GLIB] Expose JavaScriptCore options in GLib public API
13677 https://bugs.webkit.org/show_bug.cgi?id=188742
13679 Reviewed by Michael Catanzaro.
13681 Add a test for the new API.
13683 * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
13687 2019-01-24 Carlos Garcia Campos <cgarcia@igalia.com>
13689 [GTK][WPE] Support JPEG 2000 images
13690 https://bugs.webkit.org/show_bug.cgi?id=186272
13692 Reviewed by Žan Doberšek.
13694 Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
13696 * gtk/jhbuild.modules:
13697 * wpe/jhbuild.modules:
13699 2019-01-23 David Kilzer <ddkilzer@apple.com>
13701 check-webkit-style should warn when using soft-linking macros in a header
13702 <https://webkit.org/b/193750>
13704 Reviewed by Darin Adler.
13706 * Scripts/webkitpy/style/checkers/cpp.py:
13707 (check_language): Add softlink/header check by refactoring the
13708 softlink/framework check.
13709 (CppChecker): Enable softlink/header check by default.
13710 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
13711 (CppStyleTest.test_softlink_framework): Rename from
13712 CppStyleTest.test_softlink() and change test framework name in
13713 case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
13714 files. Set file_name for macros that only appear in headers.
13715 (CppStyleTest.test_softlink_header): Add tests for using
13716 soft-link macros in headers.
13718 2019-01-23 Chris Dumez <cdumez@apple.com>
13720 Deprecate API to limit the maximum number of WebProcesses
13721 https://bugs.webkit.org/show_bug.cgi?id=193725
13722 <rdar://problem/47464879>
13724 Reviewed by Geoff Garen.
13726 Update existing API tests to stop using deprecated API.
13728 * MiniBrowser/mac/AppDelegate.m:
13729 (defaultConfiguration):
13730 * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
13731 (TestWebKitAPI::TEST):
13732 * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
13733 (TestWebKitAPI::TEST):
13734 * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
13735 * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
13737 * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
13740 2019-01-23 Aakash Jain <aakash_jain@apple.com>
13742 [ews-app] Rename ews model buildermappings to buildermapping
13743 https://bugs.webkit.org/show_bug.cgi?id=193729
13745 Reviewed by Lucas Forschler.
13747 * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
13748 (BuilderMapping): Renamed BuildMappings to BuilderMapping.
13749 * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
13751 2019-01-23 Aakash Jain <aakash_jain@apple.com>
13753 [ews-app] Rename ews model steps to step
13754 https://bugs.webkit.org/show_bug.cgi?id=193697
13756 Reviewed by Lucas Forschler.
13758 * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
13759 (Step): Renamed Steps to Step.
13761 2019-01-23 Sihui Liu <sihui_liu@apple.com>
13763 Clean up IndexedDB files between tests
13764 https://bugs.webkit.org/show_bug.cgi?id=192796
13765 <rdar://problem/46824999>
13767 Reviewed by Geoffrey Garen.
13769 * DumpRenderTree/mac/DumpRenderTree.mm:
13771 * WebKitTestRunner/TestController.cpp:
13772 (WTR::TestController::resetStateToConsistentValues):
13773 (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
13774 (WTR::RemoveAllIndexedDatabasesCallback):
13775 (WTR::TestController::ClearIndexedDatabases):
13776 * WebKitTestRunner/TestController.h:
13777 * WebKitTestRunner/TestInvocation.cpp:
13778 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
13780 2019-01-23 Aakash Jain <aakash_jain@apple.com>
13782 [ews-app] Rename ews model Builds to Build
13783 https://bugs.webkit.org/show_bug.cgi?id=193695
13785 Reviewed by Lucas Forschler.
13787 * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
13788 (Build): Renamed Builds to Build.
13790 2019-01-23 Jonathan Bedard <jbedard@apple.com>
13792 webkitpy: Wait longer when launching WebKitTestRunner
13793 https://bugs.webkit.org/show_bug.cgi?id=193734
13795 Reviewed by Aakash Jain.
13797 * Scripts/webkitpy/port/simulator_process.py:
13798 (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
13800 2019-01-23 Wenson Hsieh <wenson_hsieh@apple.com>
13802 [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
13803 https://bugs.webkit.org/show_bug.cgi?id=193182
13804 <rdar://problem/47452154>
13806 Reviewed by Tim Horton.
13808 This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
13809 long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
13810 recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
13812 To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
13813 preventing later tests from recognizing gestures.
13815 * WebKitTestRunner/ios/TestControllerIOS.mm:
13816 (WTR::TestController::platformResetStateToConsistentValues):
13818 Cancel all touches in the UIApplication when resetting to a consistent state between tests.
13820 2019-01-23 Jonathan Bedard <jbedard@apple.com>
13822 webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
13823 https://bugs.webkit.org/show_bug.cgi?id=193722
13824 <rdar://problem/47481475>
13826 Reviewed by Lucas Forschler.
13828 iPhone and iPad ports should both use the iOS config.
13830 * Scripts/webkitpy/port/ios_simulator.py:
13831 (IPhoneSimulatorPort.__init__):
13832 (IPadSimulatorPort.__init__):
13834 2019-01-23 Rob Buis <rbuis@igalia.com>
13836 Update MIME type parser
13837 https://bugs.webkit.org/show_bug.cgi?id=180526
13839 Reviewed by Frédéric Wang.
13841 Add unit tests for both parse modes of ParsedContentType.
13843 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13844 * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
13845 (TestWebKitAPI::TEST):
13847 2019-01-22 Aakash Jain <aakash_jain@apple.com>
13849 [ews-app] fetch loop should not stop on network issues
13850 https://bugs.webkit.org/show_bug.cgi?id=193666
13852 Reviewed by Lucas Forschler.
13854 * BuildSlaveSupport/ews-app/ews/fetcher.py:
13855 (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
13857 2019-01-22 Wenson Hsieh <wenson_hsieh@apple.com>
13859 [iOS] Multiple WKWebViewAutofillTests are flaky failures
13860 https://bugs.webkit.org/show_bug.cgi?id=189165
13861 <rdar://problem/47433765>
13863 Reviewed by Tim Horton.
13865 These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
13866 immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
13867 the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
13868 process in sufficient to ensure that any previous action that blurred the focused element in the web process
13869 would make its way to the UI process by the time the layer tree commit is finished.
13871 However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
13872 This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
13873 the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
13874 will fail because it asks for -_autofillContext too early.
13876 To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
13877 is handled in the UI process.
13879 * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
13881 Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
13882 context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
13883 by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
13886 (-[AutofillTestView textInputHasAutofillContext]):
13888 Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
13890 * TestWebKitAPI/cocoa/TestWKWebView.h:
13891 * TestWebKitAPI/cocoa/TestWKWebView.mm:
13892 (nextInputSessionChangeCount):
13894 Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
13895 This includes changing the focused element from one to another.
13897 (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
13898 (-[TestWKWebView didStartFormControlInteraction]):
13899 (-[TestWKWebView didEndFormControlInteraction]):
13900 (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
13902 Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
13903 handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
13904 (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
13905 that doesn't require an input session to one that doesn't.
13907 2019-01-22 David Kilzer <ddkilzer@apple.com>
13909 check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
13910 <https://webkit.org/b/193676>
13912 Reviewed by Alexey Proskuryakov.
13914 * Scripts/webkitpy/style/checkers/cpp.py:
13915 (check_member_initialization_list):
13916 - Don't report missing whitespace around colon if the colon at
13917 the start of the line is formatted correctly.
13918 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
13919 (WebKitStyleTest.test_member_initialization_list):
13920 - Add a test for a missing permutation of existing tests.
13921 - Add a test this false-positive.
13922 - Add blank lines between subtests to make them easier to read.
13924 2019-01-22 Aakash Jain <aakash_jain@apple.com>
13926 [build.webkit.org] Unit-test failure after r237113
13927 https://bugs.webkit.org/show_bug.cgi?id=193669
13929 Reviewed by Michael Catanzaro.
13931 * BuildSlaveSupport/build.webkit.org-config/factories.py:
13932 (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has
13933 multiple or zero flags.
13935 2019-01-22 Tadeu Zagallo <tzagallo@apple.com>
13937 Cache bytecode to disk
13938 https://bugs.webkit.org/show_bug.cgi?id=192782
13939 <rdar://problem/46084932>
13941 Reviewed by Keith Miller.
13943 Add test helper to execute bytecode-cache tests: it executes each test
13944 twice, the first with JSC_diskCachePath set to a temporary directory
13945 and second with JSC_forceDiskCache=true (in addition to the cache path)
13946 to guarantee that only the disk cache is being used and no new
13947 UnlinkedCodeBlocks are being created.
13949 * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
13950 * Scripts/run-jsc-stress-tests:
13952 2019-01-22 Oriol Brufau <obrufau@igalia.com>
13954 [css-logical] Implement flow-relative margin, padding and border shorthands
13955 https://bugs.webkit.org/show_bug.cgi?id=188697
13957 Reviewed by Simon Fraser and Antti Koivisto.
13959 * DumpRenderTree/TestOptions.cpp:
13960 (TestOptions::TestOptions):
13961 * DumpRenderTree/TestOptions.h:
13962 * DumpRenderTree/mac/DumpRenderTree.mm:
13963 (setWebPreferencesForTestOptions):
13964 Allow tests to enable the CSSLogicalEnabled flag in WK1.
13966 * Scripts/webkitpy/style/checkers/jsonchecker.py:
13967 (JSONCSSPropertiesChecker.check_codegen_properties):
13968 Allow CSS property definitions to have a 'runtime-flag' parameter which
13969 disables the property when the specified runtime flag is disabled.
13971 2019-01-21 Fujii Hironori <Hironori.Fujii@sony.com>
13973 [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
13974 https://bugs.webkit.org/show_bug.cgi?id=193643
13976 Reviewed by Michael Catanzaro.
13978 * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
13979 * wpe/jhbuild.modules: Ditto.
13981 2019-01-21 Zalan Bujtas <zalan@apple.com>
13983 [LFC][Floats] Take float top position into account when computing containing block height.
13984 https://bugs.webkit.org/show_bug.cgi?id=193655
13986 Reviewed by Antti Koivisto.
13988 * LayoutReloaded/misc/LFC-passing-tests.txt:
13990 2019-01-21 David Kilzer <ddkilzer@apple.com>
13992 Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
13993 <https://webkit.org/b/193645>
13994 <rdar://problem/47421574>
13996 Reviewed by Alex Christensen.
13998 - Now checks for local soft-linking of all frameworks that have
13999 their own *SoftLinking.{cpp,h,mm} files.
14000 - Changes softlink/uikit warning to softlink/framework.
14002 * Scripts/webkitpy/style/checkers/cpp.py:
14005 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
14008 2019-01-20 Saam Barati <sbarati@apple.com>
14010 Rollout r240210: It broke tests on iOS
14011 https://bugs.webkit.org/show_bug.cgi?id=193640
14015 * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
14016 * Scripts/run-jsc-stress-tests:
14018 2019-01-20 chris fleizach <cfleizach@apple.com>
14020 AX: Support returning relative frames for accessibility
14021 https://bugs.webkit.org/show_bug.cgi?id=193414
14022 <rdar://problem/47268501>
14024 Reviewed by Zalan Bujtas.
14026 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
14027 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
14028 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
14029 (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
14030 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
14031 (WTR::attributesOfElement):
14032 (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
14034 2019-01-20 Yusuke Suzuki <ysuzuki@apple.com>
14036 Unreviewed, add my new email address
14038 * Scripts/webkitpy/common/config/contributors.json:
14040 2019-01-19 Zalan Bujtas <zalan@apple.com>
14042 [LFC][BFC] <body>'s overflow property value is propagated to viewport
14043 https://bugs.webkit.org/show_bug.cgi?id=193617
14045 Reviewed by Antti Koivisto.
14047 * LayoutReloaded/misc/LFC-passing-tests.txt:
14049 2019-01-20 Michael Catanzaro <mcatanzaro@igalia.com>
14051 Unreviewed, rolling out r240209.
14053 Broke GTK/WPE injected bundle
14055 Reverted changeset:
14057 "AX: Support returning relative frames for accessibility"
14058 https://bugs.webkit.org/show_bug.cgi?id=193414
14059 https://trac.webkit.org/changeset/240209
14061 2019-01-12 Dan Bernstein <mitz@apple.com>
14063 [Cocoa] Avoid importing directly from subumbrella frameworks
14064 https://bugs.webkit.org/show_bug.cgi?id=186016
14065 <rdar://problem/40591038>
14067 Reviewed by Sam Weinig.
14069 * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
14070 LaunchServices header.
14071 * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
14072 OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
14073 * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
14074 when using SDKs earlier than 10.13.
14075 * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
14076 and OTHER_CPLUSPLUSFLAGS.
14077 * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
14078 OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
14079 * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
14080 LaunchServices header.
14082 2019-01-20 Tadeu Zagallo <tzagallo@apple.com>
14084 Cache bytecode to disk
14085 https://bugs.webkit.org/show_bug.cgi?id=192782
14086 <rdar://problem/46084932>
14088 Reviewed by Keith Miller.
14090 Add test helper to execute bytecode-cache tests: it executes each test
14091 twice, the first with JSC_diskCachePath set to a temporary directory
14092 and second with JSC_forceDiskCache=true (in addition to the cache path)
14093 to guarantee that only the disk cache is being used and no new
14094 UnlinkedCodeBlocks are being created.
14096 * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
14097 * Scripts/run-jsc-stress-tests:
14099 2019-01-20 chris fleizach <cfleizach@apple.com>
14101 AX: Support returning relative frames for accessibility
14102 https://bugs.webkit.org/show_bug.cgi?id=193414
14103 <rdar://problem/47268501>
14105 Reviewed by Zalan Bujtas.
14107 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
14108 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
14109 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
14110 (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
14111 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
14112 (WTR::attributesOfElement):
14113 (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
14115 2019-01-20 Antoine Quint <graouts@apple.com>
14117 Add a POINTER_EVENTS feature flag
14118 https://bugs.webkit.org/show_bug.cgi?id=193577
14119 <rdar://problem/47408511>
14121 Unreviewed. Also enable Pointer Events for iosmac.
14123 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
14125 2019-01-19 Zalan Bujtas <zalan@apple.com>
14127 [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
14128 https://bugs.webkit.org/show_bug.cgi?id=193613
14130 Reviewed by Antti Koivisto.
14132 * LayoutReloaded/misc/LFC-passing-tests.txt:
14134 2019-01-19 Antoine Quint <graouts@apple.com>
14136 Add a POINTER_EVENTS feature flag
14137 https://bugs.webkit.org/show_bug.cgi?id=193577
14139 Reviewed by Dean Jackson.
14141 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
14143 2019-01-18 Zhifei FANG <zhifei_fang@apple.com>
14145 Disable the run-jsc-stress-test remote host key check [second round].
14146 https://bugs.webkit.org/show_bug.cgi?id=192988
14148 Reviewed by Dewei Zhu.
14150 * Scripts/run-jsc-stress-tests:
14152 2019-01-18 Aakash Jain <aakash_jain@apple.com>
14154 [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
14155 https://bugs.webkit.org/show_bug.cgi?id=193597
14157 Reviewed by Lucas Forschler.
14159 * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
14161 2019-01-18 Aakash Jain <aakash_jain@apple.com>
14163 [build.webkit.org] api tests failures are incorrectly named as unit test failures
14164 https://bugs.webkit.org/show_bug.cgi?id=193595
14166 Reviewed by Lucas Forschler.
14168 * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
14169 * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
14170 * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
14172 2019-01-18 Chris Dumez <cdumez@apple.com>
14174 Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
14175 https://bugs.webkit.org/show_bug.cgi?id=193588
14176 <rdar://problem/47131566>
14178 Reviewed by Alex Christensen.
14180 Add layout test coverage.
14182 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
14184 2019-01-18 Jer Noble <jer.noble@apple.com>
14186 SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
14187 https://bugs.webkit.org/show_bug.cgi?id=189553
14189 Reviewed by Tim Horton.
14191 Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
14193 * ContentExtensionTester/Configurations/Base.xcconfig:
14194 * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
14195 * DumpRenderTree/mac/Configurations/Base.xcconfig:
14196 * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
14197 * ImageDiff/cg/Configurations/Base.xcconfig:
14198 * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
14199 * MiniBrowser/Configurations/Base.xcconfig:
14200 * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
14201 * MobileMiniBrowser/Configurations/Base.xcconfig:
14202 * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
14203 * Scripts/webkitpy/style/checker.py:
14206 (CheckerDispatcher._file_type):
14207 (CheckerDispatcher._create_checker):
14208 * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
14209 (SDKVariantChecker):
14210 (SDKVariantChecker.__init__):
14211 (SDKVariantChecker.check):
14212 * TestWebKitAPI/Configurations/Base.xcconfig:
14213 * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
14214 * WebEditingTester/Configurations/Base.xcconfig:
14215 * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
14216 * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
14217 * WebKitTestRunner/Configurations/Base.xcconfig:
14218 * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
14219 * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
14220 * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
14222 2019-01-18 David Kilzer <ddkilzer@apple.com>
14224 Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
14225 <https://webkit.org/b/193568>
14226 <rdar://problem/47381130>
14228 Reviewed by Alex Christensen.
14230 Make sure no one re-introduces UIKit soft-linking by adding a
14233 * Scripts/webkitpy/style/checkers/cpp.py:
14234 (check_language): Add softlink/uikit check.
14235 (CppChecker): Enable softlink/uikit check.
14236 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
14237 (CppStyleTest): Add test for softlink/uikit.
14239 2019-01-18 Joanmarie Diggs <jdiggs@igalia.com>
14241 [GTK] install-dependencies tool looks for libunistring-dev for dnf
14242 https://bugs.webkit.org/show_bug.cgi?id=193584
14244 Change "-dev" to "-devel".
14246 Reviewed by Michael Catanzaro.
14248 * gtk/install-dependencies:
14250 2019-01-18 Jonathan Bedard <jbedard@apple.com>
14252 webkitpy: Add iPhone and iPad ports
14253 https://bugs.webkit.org/show_bug.cgi?id=193537
14254 <rdar://problem/47353390>
14256 Reviewed by Lucas Forschler.
14258 Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
14259 ports. Note that this separation is optional, the --ios-simulator command remains.
14261 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
14262 (RunTest.test_device_type_test_division): Drive-by fix.
14263 (RunTest.test_device_type_specific_listing): Ditto.
14264 (RunTest.test_ipad_test_division):
14266 (RunTest.test_ipad_listing):
14267 * Scripts/webkitpy/port/factory.py:
14268 (platform_options): Add --iphone-simulator and --ipad-simulator flags.
14270 * Scripts/webkitpy/port/ios_simulator.py:
14271 (IPhoneSimulatorPort):
14272 (IPadSimulatorPort):
14274 2019-01-18 Chris Dumez <cdumez@apple.com>
14276 Regression(PSON) Scroll position is not always restored properly when navigating back
14277 https://bugs.webkit.org/show_bug.cgi?id=193578
14278 <rdar://problem/47386331>
14280 Reviewed by Tim Horton.
14282 Add API test coverage.
14284 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
14286 2019-01-18 Youenn Fablet <youenn@apple.com>
14288 Add a new SPI to request for cache storage quota increase
14289 https://bugs.webkit.org/show_bug.cgi?id=193323
14291 Reviewed by Alex Christensen.
14293 Implement WebsiteDataStore quota delegate to handle quota requests.
14294 By default, do not update quota.
14295 Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
14297 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
14298 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
14299 (WTR::TestRunner::allowCacheStorageQuotaIncrease):
14300 * WebKitTestRunner/InjectedBundle/TestRunner.h:
14301 * WebKitTestRunner/TestController.cpp:
14302 (WTR::TestController::allowCacheStorageQuotaIncrease):
14303 * WebKitTestRunner/TestController.h:
14304 * WebKitTestRunner/TestInvocation.cpp:
14305 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
14306 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
14307 (-[CacheStorageQuotaManager init]):
14308 (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
14309 (WTR::initializeWebViewConfiguration):
14310 (WTR::TestController::cocoaResetStateToConsistentValues):
14311 (WTR::TestController::allowCacheStorageQuotaIncrease):
14313 2019-01-18 Aakash Jain <aakash_jain@apple.com>
14315 [ews-build] Pass owner to the triggered builds
14316 https://bugs.webkit.org/show_bug.cgi?id=193574
14318 Reviewed by Lucas Forschler.
14320 * BuildSlaveSupport/ews-build/factories.py:
14321 (BuildFactory.propertiesToPassToTriggers):
14323 2019-01-18 Aakash Jain <aakash_jain@apple.com>
14325 [ews-app] Send patch author as a build property
14326 https://bugs.webkit.org/show_bug.cgi?id=193560
14328 Reviewed by Lucas Forschler.
14330 * BuildSlaveSupport/ews-app/ews/fetcher.py:
14331 (BugzillaPatchFetcher.fetch):
14333 2019-01-18 Jonathan Bedard <jbedard@apple.com>
14335 webkitpy: Implement device type specific expected results (Follow-up fix)
14336 https://bugs.webkit.org/show_bug.cgi?id=192162
14337 <rdar://problem/46345449>
14339 Unreviewed infrastructure fix.
14341 * Scripts/webkitpy/layout_tests/controllers/manager.py:
14342 (Manager.run): Don't boot a device if no tests are available to run on it.
14344 2019-01-18 Jonathan Bedard <jbedard@apple.com>
14346 webkitpy: Implement device type specific expected results (Follow-up fix)
14347 https://bugs.webkit.org/show_bug.cgi?id=192162
14348 <rdar://problem/46345449>
14350 Unreviewed infrastructure fix.
14352 * Scripts/webkitpy/api_tests/manager.py:
14353 (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
14355 2019-01-18 Jonathan Bedard <jbedard@apple.com>
14357 webkitpy: Implement device type specific expected results (Part 2)
14358 https://bugs.webkit.org/show_bug.cgi?id=192162
14359 <rdar://problem/46345449>
14361 Rubber-stamped by Aakash Jain.
14363 This change uses device_type to select a different set of TestExpectation files based on the type of device running
14364 tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
14365 that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
14367 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
14368 (LayoutTestFinder.find_tests): Pass device_type through.
14369 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
14370 (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
14371 * Scripts/webkitpy/layout_tests/controllers/manager.py:
14372 (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
14373 (Manager._collect_tests): Pass device type to test finder.
14374 (Manager._needs_web_platform_test):
14375 (Manager._prepare_lists): Index _expectations by device type.
14376 (Manager._test_input_for_file):
14377 (Manager._test_is_slow): Ditto.
14378 (Manager._test_should_dump_jsconsolelog_in_stderr):
14379 (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
14380 (Manager._get_test_inputs):
14381 (Manager._update_worker_count):
14382 (Manager._set_up_run): Use current_device_type instead of passing device_type in.
14383 (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
14384 that a test can be run on multiple device types, the first device in the device type list which is eligible will be
14385 the one which runs the test.
14386 (Manager._run_test_subset):
14387 (Manager._run_tests): Index _expectations by current_device_type.
14388 (Manager._print_expectation_line_for_test): Ditto.
14389 (Manager._print_expectations_for_subset): Ditto.
14390 (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
14391 Unlike run, this function will behave the same regardless of what devices are available.
14392 (Manager._custom_device_for_test): Deleted.
14393 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
14394 (ManagerTest.test_uses_custom_device): Deleted.
14395 (ManagerTest.test_uses_custom_device.get_manager): Deleted.
14396 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
14397 (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
14398 (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
14399 all of the expectations.
14400 * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
14401 (FakePort.skipped_layout_tests): Allow device_type to be passed in.
14402 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
14403 (TestExpectations.__init__): Allow device_type to be passed through.
14404 (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
14405 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
14406 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
14407 (summarize_results):
14408 * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
14409 (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
14410 a test ran with, one must check all expectations to find the first non-skip expectation.
14411 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
14412 (RunTest.test_device_type_test_division):
14414 (RunTest.test_device_type_specific_listing):
14415 * Scripts/webkitpy/port/base.py:
14416 (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
14417 (Port.supported_device_types): The result of this function will change based on what devices are available.
14418 * Scripts/webkitpy/port/device_port.py:
14419 (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
14420 (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
14422 (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
14423 any, or the DEFAULT_DEVICE_TYPES of the port.
14424 * Scripts/webkitpy/port/ios.py:
14425 (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
14426 * Scripts/webkitpy/port/ios_simulator.py:
14427 (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
14428 * Scripts/webkitpy/port/watch.py:
14429 (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
14430 * Scripts/webkitpy/port/watch_simulator.py:
14431 (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
14432 * Scripts/webkitpy/xcode/device_type.py:
14434 (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
14436 2019-01-18 Philippe Normand <pnormand@igalia.com>
14438 [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
14439 https://bugs.webkit.org/show_bug.cgi?id=193575
14441 Reviewed by Michael Catanzaro.
14443 Allow the script to run without explicit port argument because
14444 it's specific to the WPE port anyway.
14446 * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
14447 and simplify the rest of the code accordingly.
14449 2019-01-18 Charlie Turner <cturner@igalia.com>
14451 [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
14452 https://bugs.webkit.org/show_bug.cgi?id=192229
14454 Reviewed by Xabier Rodriguez-Calvar.
14456 * MiniBrowser/wpe/main.cpp:
14457 (main): Enable encrypted-media by default.
14459 2019-01-18 Philippe Normand <pnormand@igalia.com>
14461 [Flatpak] Missing KeyboardInterrupt exception handler
14462 https://bugs.webkit.org/show_bug.cgi?id=193570
14464 Reviewed by Michael Catanzaro.
14466 * flatpak/flatpakutils.py:
14467 (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
14469 2019-01-18 Zalan Bujtas <zalan@apple.com>
14471 [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
14472 https://bugs.webkit.org/show_bug.cgi?id=193564
14474 Reviewed by Antti Koivisto.
14476 * LayoutReloaded/misc/LFC-passing-tests.txt:
14478 2019-01-18 Zalan Bujtas <zalan@apple.com>
14480 [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
14481 https://bugs.webkit.org/show_bug.cgi?id=193562
14483 Reviewed by Antti Koivisto.
14485 * LayoutReloaded/misc/LFC-passing-tests.txt:
14487 2019-01-18 Zalan Bujtas <zalan@apple.com>
14489 [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
14490 https://bugs.webkit.org/show_bug.cgi?id=193555
14492 Reviewed by Antti Koivisto.
14494 * LayoutReloaded/misc/LFC-passing-tests.txt:
14496 2019-01-18 Philippe Normand <pnormand@igalia.com>
14498 [WPE] Add Qt extension
14499 https://bugs.webkit.org/show_bug.cgi?id=191464
14501 Reviewed by Carlos Garcia Campos.
14503 MiniBrowser and API tests for the WPE Qt API. To run the
14504 MiniBrowser a new script is introduced. Example invocation:
14506 $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
14508 Also note-worthy is the introduction of the python2-subprocess32
14509 dependency to run the GLib API tests.
14511 * MiniBrowser/wpe/CMakeLists.txt:
14512 * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
14513 * MiniBrowser/wpe/qt/main.cpp: Added.
14515 * MiniBrowser/wpe/qt/main.qml: Added.
14516 * MiniBrowser/wpe/qt/qml.qrc: Added.
14517 * Scripts/run-gtk-tests:
14518 (GtkTestRunner.is_google_test):
14520 (GtkTestRunner.is_qt_test):
14521 * Scripts/run-qt-wpe-minibrowser: Added.
14522 * Scripts/run-wpe-tests:
14524 (WPETestRunner.is_google_test):
14525 (WPETestRunner.is_qt_test):
14526 * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
14528 * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
14529 (TestLoadHtml::main):
14530 * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
14531 (TestLoadRequest::main):
14532 * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
14533 (TestRunJavaScript::main):
14534 * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
14536 * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
14537 (LoadSpy::LoadSpy):
14538 (LoadSpy::~LoadSpy):
14539 (LoadSpy::onLoadingChanged):
14540 (LoadStartedCatcher::LoadStartedCatcher):
14541 (LoadStartedCatcher::~LoadStartedCatcher):
14542 (LoadStartedCatcher::onLoadingChanged):
14543 (waitForLoadSucceeded):
14544 (waitForLoadFailed):
14545 * TestWebKitAPI/glib/CMakeLists.txt:
14546 * flatpak/flatpakutils.py:
14547 (WebkitFlatpak.load_from_args):
14548 (WebkitFlatpak.__init__):
14549 (WebkitFlatpak.clean_args):
14550 (WebkitFlatpak.run_in_sandbox):
14551 * flatpak/org.webkit.CommonModules.yaml:
14552 * flatpak/org.webkit.WPE.yaml:
14553 * flatpak/org.webkit.WPEModules.yaml:
14554 * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
14555 * flatpak/org.webkit.WebKit.yaml:
14556 * glib/api_test_runner.py:
14557 (TestRunner._run_test_qt):
14558 (TestRunner.is_qt_test):
14559 (TestRunner._run_test):
14561 2019-01-17 Wenson Hsieh <wenson_hsieh@apple.com>
14563 [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
14564 https://bugs.webkit.org/show_bug.cgi?id=193494
14565 <rdar://problem/46859627>
14567 Reviewed by Simon Fraser and Tim Horton.
14569 Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
14570 scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
14572 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
14573 (WTR::UIScriptController::contentOffsetX const):
14574 (WTR::UIScriptController::contentOffsetY const):
14575 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
14576 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
14577 (WTR::UIScriptController::contentOffsetX const):
14578 (WTR::UIScriptController::contentOffsetY const):
14579 * TestRunnerShared/UIScriptContext/UIScriptController.h:
14581 Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
14583 * WebKitTestRunner/TestController.cpp:
14584 (WTR::updateTestOptionsFromTestHeader):
14585 * WebKitTestRunner/TestOptions.h:
14586 (WTR::TestOptions::hasSameInitializationOptions const):
14587 * WebKitTestRunner/ios/TestControllerIOS.mm:
14588 (WTR::TestController::platformResetStateToConsistentValues):
14589 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
14590 (WTR::UIScriptController::contentOffsetX const):
14591 (WTR::UIScriptController::contentOffsetY const):
14593 2019-01-17 Truitt Savell <tsavell@apple.com>
14595 Unreviewed, rolling out r240124.
14597 This commit broke an internal build.
14599 Reverted changeset:
14601 "SDK_VARIANT build destinations should be separate from non-
14602 SDK_VARIANT builds"
14603 https://bugs.webkit.org/show_bug.cgi?id=189553
14604 https://trac.webkit.org/changeset/240124
14606 2019-01-17 Alex Christensen <achristensen@webkit.org>
14608 Fix string concatenation API test after r239920
14609 https://bugs.webkit.org/show_bug.cgi?id=193551
14610 <rdar://problem/47359304>
14612 Reviewed by Youenn Fablet.
14614 * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
14615 (TestWebKitAPI::TEST):
14616 Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
14617 in WebKit's build configuration like it apparently is on Linux.
14619 2019-01-17 Aakash Jain <aakash_jain@apple.com>
14621 [ews-build] validate-patch should handle the case when bug_id is None
14622 https://bugs.webkit.org/show_bug.cgi?id=193547
14624 Reviewed by Lucas Forschler.
14626 * BuildSlaveSupport/ews-build/steps.py:
14627 (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
14628 (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
14630 2019-01-17 Aakash Jain <aakash_jain@apple.com>
14632 [ews-build] Add patch author information in build
14633 https://bugs.webkit.org/show_bug.cgi?id=193465
14635 Reviewed by Lucas Forschler.
14637 * BuildSlaveSupport/ews-build/steps.py:
14638 (ValidatePatch._is_patch_obsolete):
14640 2019-01-17 Aakash Jain <aakash_jain@apple.com>
14642 [ews-build] Pass bug_id to the triggered builds
14643 https://bugs.webkit.org/show_bug.cgi?id=193548
14645 Reviewed by Lucas Forschler.
14647 * BuildSlaveSupport/ews-build/factories.py:
14648 (BuildFactory.propertiesToPassToTriggers):
14650 2019-01-17 Jer Noble <jer.noble@apple.com>
14652 SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
14653 https://bugs.webkit.org/show_bug.cgi?id=189553
14655 Reviewed by Tim Horton.
14657 Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
14659 * ContentExtensionTester/Configurations/Base.xcconfig:
14660 * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
14661 * DumpRenderTree/mac/Configurations/Base.xcconfig:
14662 * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
14663 * ImageDiff/cg/Configurations/Base.xcconfig:
14664 * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
14665 * MiniBrowser/Configurations/Base.xcconfig:
14666 * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
14667 * MobileMiniBrowser/Configurations/Base.xcconfig:
14668 * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
14669 * Scripts/webkitpy/style/checker.py:
14672 (CheckerDispatcher._file_type):
14673 (CheckerDispatcher._create_checker):
14674 * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
14675 (SDKVariantChecker):
14676 (SDKVariantChecker.__init__):
14677 (SDKVariantChecker.check):
14678 * TestWebKitAPI/Configurations/Base.xcconfig:
14679 * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
14680 * WebEditingTester/Configurations/Base.xcconfig:
14681 * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
14682 * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
14683 * WebKitTestRunner/Configurations/Base.xcconfig:
14684 * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
14685 * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
14686 * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
14688 2019-01-17 Zalan Bujtas <zalan@apple.com>
14690 [LFC][BFC] An element with transform is a containing block for positioned descendants.
14691 https://bugs.webkit.org/show_bug.cgi?id=193534
14693 Reviewed by Antti Koivisto.
14695 * LayoutReloaded/misc/LFC-passing-tests.txt:
14697 2019-01-17 Zalan Bujtas <zalan@apple.com>
14699 [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
14700 https://bugs.webkit.org/show_bug.cgi?id=193528
14702 Reviewed by Antti Koivisto.
14704 * LayoutReloaded/misc/LFC-passing-tests.txt:
14706 2019-01-17 Zalan Bujtas <zalan@apple.com>
14708 [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
14709 https://bugs.webkit.org/show_bug.cgi?id=193520
14711 Reviewed by Antti Koivisto.
14713 * LayoutReloaded/misc/LFC-passing-tests.txt:
14715 2019-01-17 Aakash Jain <aakash_jain@apple.com>
14717 [ews-build] unapply-patch step should not update source
14718 https://bugs.webkit.org/show_bug.cgi?id=193234
14720 Reviewed by Lucas Forschler.
14722 * BuildSlaveSupport/ews-build/steps.py:
14723 (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
14724 (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
14726 2019-01-16 Youenn Fablet <youenn@apple.com>
14728 Add a new SPI for controlling getUserMedia
14729 https://bugs.webkit.org/show_bug.cgi?id=192793
14731 Reviewed by Eric Carlson.
14733 * MiniBrowser/mac/WK2BrowserWindowController.m:
14734 (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
14735 (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
14736 * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
14737 (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
14738 * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
14739 (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
14740 * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
14741 (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
14742 * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
14743 (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
14744 (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
14745 * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
14746 (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
14747 (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
14749 2019-01-16 Zalan Bujtas <zalan@apple.com>
14751 [LFC][BFC] Inflow non-replaced used width should not be negative.
14752 https://bugs.webkit.org/show_bug.cgi?id=193495
14754 Reviewed by Antti Koivisto.
14756 * LayoutReloaded/misc/LFC-passing-tests.txt:
14758 2019-01-16 Chris Dumez <cdumez@apple.com>
14760 Regression(PSON) View becomes blank after click a cross-site download link
14761 https://bugs.webkit.org/show_bug.cgi?id=193361
14762 <rdar://problem/47099573>
14764 Reviewed by Geoffrey Garen.
14766 Add API test coverage.
14768 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
14769 (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
14771 2019-01-16 Zalan Bujtas <zalan@apple.com>
14773 [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
14774 https://bugs.webkit.org/show_bug.cgi?id=193470
14776 Reviewed by Antti Koivisto.
14778 * LayoutReloaded/misc/LFC-passing-tests.txt:
14780 2019-01-16 Zalan Bujtas <zalan@apple.com>
14782 [LFC] Adjust margin box verification.
14783 https://bugs.webkit.org/show_bug.cgi?id=193482
14785 Reviewed by Antti Koivisto.
14787 * LayoutReloaded/misc/LFC-passing-tests.txt:
14789 2019-01-15 Sihui Liu <sihui_liu@apple.com>
14791 Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
14792 https://bugs.webkit.org/show_bug.cgi?id=193451
14794 Reviewed by Geoffrey Garen.
14796 * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
14798 * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
14799 (runWebsiteDataStoreCustomPaths):
14801 2019-01-15 Jonathan Bedard <jbedard@apple.com>
14803 webkitpy: Support boolean simctl isAvailable
14804 https://bugs.webkit.org/show_bug.cgi?id=193472
14805 <rdar://problem/47296150>
14807 Reviewed by Ryosuke Niwa.
14809 * Scripts/webkitpy/xcode/simulated_device.py:
14810 (SimulatedDeviceManager._create_runtimes):
14811 (SimulatedDeviceManager._create_device_with_runtime):
14813 2019-01-15 Chris Dumez <cdumez@apple.com>
14815 Unreviewed, rolling out r239993, r239995, r239997, and
14818 Caused assertions under
14819 ViewGestureController::disconnectFromProcess()
14821 Reverted changesets:
14823 "Regression(PSON) View becomes blank after click a cross-site
14825 https://bugs.webkit.org/show_bug.cgi?id=193361
14826 https://trac.webkit.org/changeset/239993
14828 "Unreviewed iOS build fix after r239993."
14829 https://trac.webkit.org/changeset/239995
14831 "Fix iOS build after r239993"
14832 https://bugs.webkit.org/show_bug.cgi?id=193361
14833 https://trac.webkit.org/changeset/239997
14835 "Unreviewed, revert part of r239997 as it is not needed to fix
14837 https://trac.webkit.org/changeset/239999
14839 2019-01-15 Tim Horton <timothy_horton@apple.com>
14841 Cannot tab out of WKWebView on macOS
14842 https://bugs.webkit.org/show_bug.cgi?id=161448
14843 <rdar://problem/28100085>
14845 Reviewed by Dean Jackson.
14847 Add a test that tabbing into and out of WKWebView works correctly.
14849 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
14850 * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
14851 (WebKit2_CommandBackForwardTest::SetUp):
14852 (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
14853 (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
14854 * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
14855 (-[FocusableView canBecomeKeyView]):
14857 * TestWebKitAPI/mac/OffscreenWindow.h: Added.
14858 * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
14859 (-[OffscreenWindow initWithSize:]):
14860 (-[OffscreenWindow isKeyWindow]):
14861 (-[OffscreenWindow isVisible]):
14862 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
14863 (TestWebKitAPI::PlatformWebView::initialize):
14864 (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
14865 (-[ActiveOffscreenWindow isVisible]): Deleted.
14866 Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
14868 2019-01-15 Ryan Haddad <ryanhaddad@apple.com>
14870 Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
14871 https://bugs.webkit.org/show_bug.cgi?id=193459
14873 Reviewed by Mark Lam.
14875 * BuildSlaveSupport/build.webkit.org-config/steps.py:
14876 (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
14878 2019-01-15 Chris Dumez <cdumez@apple.com>
14880 Regression(PSON) View becomes blank after click a cross-site download link
14881 https://bugs.webkit.org/show_bug.cgi?id=193361
14882 <rdar://problem/47099573>
14884 Reviewed by Geoff Garen.
14886 Add API test coverage.
14888 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
14889 (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
14891 2019-01-15 Zalan Bujtas <zalan@apple.com>
14893 [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
14894 https://bugs.webkit.org/show_bug.cgi?id=193448
14896 Reviewed by Antti Koivisto.
14898 * LayoutReloaded/misc/LFC-passing-tests.txt:
14900 2019-01-15 Jonathan Bedard <jbedard@apple.com>
14902 webkitpy: Implement device type specific expected results (Part 1)
14903 https://bugs.webkit.org/show_bug.cgi?id=192162
14905 Reviewed by Lucas Forschler.
14907 Device type specific expected results covers two related ideas. The first (covered by this change)
14908 is where to search for -expected.* files. The second is which tests to run based on the
14909 TestExpectations.txt file.
14911 After this change, the baseline search path will be determined by the type of device running a
14912 test. Device type will be passed into any function which picks a file based on the baseline search
14915 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
14916 (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
14917 * Scripts/webkitpy/layout_tests/controllers/manager.py:
14918 (Manager.run): Print baseline search path for each round of devices.
14919 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
14920 (SingleTestRunner.__init__): Pass device_type into expected_*(...).
14921 (SingleTestRunner._expected_driver_output): Ditto.
14922 (SingleTestRunner._driver_input): Ditto.
14923 * Scripts/webkitpy/layout_tests/views/printing.py:
14924 (Printer.print_config): Move printing of baseline search path to a separate function.
14925 (Printer.print_baseline_search_path): Moved from Printer.print_config.
14926 * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
14927 (Testprinter.test_print_config):
14928 (Testprinter.test_print_baseline_search_path):
14929 * Scripts/webkitpy/port/base.py:
14930 (Port.baseline_search_path): Pass device_type through.
14931 (Port._expected_baselines_for_suffixes): Ditto.
14932 (Port.expected_baselines): Ditto.
14933 (Port.expected_filename): Ditto.
14934 (Port.expected_checksum): Ditto.
14935 (Port.expected_image): Ditto.
14936 (Port.expected_audio): Ditto.
14937 (Port.expected_text): Ditto.
14938 (Port.reference_files): Ditto.
14939 (Port.tests): Ditto.
14940 (Port._expanded_paths): Ditto.
14941 (Port.skipped_layout_tests): Ditto.
14942 (Port.expectations_dict): Ditto.
14943 (Port._port_specific_expectations_files): Ditto.
14944 (Port.expectations_files): Ditto.
14945 (Port.test_search_path): Ditto.
14946 (Port._tests_for_other_platforms): Ditto.
14947 * Scripts/webkitpy/port/base_unittest.py:
14948 (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
14949 (PortTest.test_nonexistant_expectations): Ditto.
14950 (test_ref_tests_platform_directory): Ditto.
14951 * Scripts/webkitpy/port/darwin.py:
14952 (DarwinPort._port_specific_expectations_files): Accept device_type.
14953 * Scripts/webkitpy/port/driver.py:
14955 (DriverProxy.host): Expose _target_host for device_type information.
14956 * Scripts/webkitpy/port/gtk.py:
14957 (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
14958 * Scripts/webkitpy/port/ios.py:
14959 (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
14960 * Scripts/webkitpy/port/mac.py:
14961 (MacPort. default_baseline_search_path): Ditto.
14962 * Scripts/webkitpy/port/port_testcase.py:
14963 (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
14964 * Scripts/webkitpy/port/test.py:
14965 * Scripts/webkitpy/port/watch.py:
14966 (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
14967 * Scripts/webkitpy/port/win.py:
14968 (WinPort.test_search_path): Accept, but do not use, device_type.
14969 * Scripts/webkitpy/port/wpe.py:
14970 (WPEPort._port_specific_expectations_files): Ditto.
14971 * Scripts/webkitpy/tool/servers/rebaselineserver.py:
14972 (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
14974 2019-01-15 Zalan Bujtas <zalan@apple.com>
14976 [LFC] Use the containing block's padding box to position out-of-flow elements.
14977 https://bugs.webkit.org/show_bug.cgi?id=193431
14979 Reviewed by Antti Koivisto.
14981 * LayoutReloaded/misc/LFC-passing-tests.txt:
14983 2019-01-14 Tim Horton <timothy_horton@apple.com>
14985 Move a test implementation file that got misplaced in the Xcode project
14987 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
14989 2019-01-14 Commit Queue <commit-queue@webkit.org>
14991 Unreviewed, rolling out r239901, r239909, r239910, r239912,
14992 r239913, and r239914.
14993 https://bugs.webkit.org/show_bug.cgi?id=193407
14995 These revisions caused an internal failure (Requested by
14996 Truitt on #webkit).
14998 Reverted changesets:
15000 "[Cocoa] Avoid importing directly from subumbrella frameworks"
15001 https://bugs.webkit.org/show_bug.cgi?id=186016
15002 https://trac.webkit.org/changeset/239901
15004 "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
15005 https://trac.webkit.org/changeset/239909
15007 "Tried to fix the build."
15008 https://trac.webkit.org/changeset/239910
15010 "Fixed iOS builds after r239910."
15011 https://trac.webkit.org/changeset/239912
15013 "More build fixing."
15014 https://trac.webkit.org/changeset/239913
15016 "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
15017 https://trac.webkit.org/changeset/239914
15019 2019-01-14 Mark Lam <mark.lam@apple.com>
15021 Re-enable ability to build --cloop builds.
15022 https://bugs.webkit.org/show_bug.cgi?id=192955
15023 <rdar://problem/46882363>
15025 Reviewed by Saam barati and Keith Miller.
15027 The --cloop build option was being ignored this whole time since r236381.
15028 This patch makes it possible to build CLoop builds again.
15030 * Scripts/build-jsc:
15031 * Scripts/webkitperl/FeatureList.pm:
15032 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
15034 2019-01-14 Jonathan Bedard <jbedard@apple.com>
15036 webkitpy: Expose device_type from host-like objects
15037 https://bugs.webkit.org/show_bug.cgi?id=193406
15038 <rdar://problem/47262305>
15040 Reviewed by Lucas Forschler.
15042 Devices should expose device_type. As a result, all host objects should
15043 provide a device_type property, even if they do not yet define a device_type.
15045 * Scripts/webkitpy/common/system/systemhost.py:
15047 (SystemHost.device_type):
15048 * Scripts/webkitpy/common/system/systemhost_mock.py:
15050 (MockSystemHost.device_type):
15051 * Scripts/webkitpy/port/device.py:
15053 (Device.device_type):
15054 * Scripts/webkitpy/xcode/simulated_device.py:
15055 (SimulatedDeviceManager._find_exisiting_device_for_request):
15056 (SimulatedDeviceManager._disambiguate_device_type):
15057 (SimulatedDeviceManager._does_fulfill_request):
15058 (SimulatedDeviceManager.device_count_for_type):
15059 (SimulatedDeviceManager.initialize_devices):
15060 * Scripts/webkitpy/xcode/simulated_device_unittest.py:
15061 (test_available_devices):
15062 (test_swapping_devices):
15064 2019-01-14 Jonathan Bedard <jbedard@apple.com>
15066 webkitpy: Support alternate simctl device list output (Follow-up fix)
15067 https://bugs.webkit.org/show_bug.cgi?id=193362
15068 <rdar://problem/47122965>
15070 Rubber-stamped by Lucas Forschler.
15072 * Scripts/webkitpy/xcode/simulated_device.py:
15073 (SimulatedDeviceManager.populate_available_devices):
15075 2019-01-14 Wenson Hsieh <wenson_hsieh@apple.com>
15077 [iOS] Expose SPI to access the current sentence boundary and selection state
15078 https://bugs.webkit.org/show_bug.cgi?id=193398
15079 <rdar://problem/45893108>
15081 Reviewed by Dean Jackson.
15083 Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
15084 WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
15087 * TestWebKitAPI/EditingTestHarness.h:
15088 * TestWebKitAPI/EditingTestHarness.mm:
15089 (-[EditingTestHarness moveBackward]):
15090 (-[EditingTestHarness moveForward]):
15091 (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
15093 Add a couple of new helper methods on EditingTestHarness.
15095 * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
15096 (-[SelectionChangeObserver initWithWebView:]):
15097 (-[SelectionChangeObserver webView]):
15098 (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
15099 (-[SelectionChangeObserver currentSelectionAttributes]):
15101 2019-01-14 Zalan Bujtas <zalan@apple.com>
15103 [LFC][BFC] Add basic box-sizing support.
15104 https://bugs.webkit.org/show_bug.cgi?id=193392
15106 Reviewed by Antti Koivisto.
15108 * LayoutReloaded/misc/LFC-passing-tests.txt:
15110 2019-01-14 Charlie Turner <cturner@igalia.com>
15112 [WPE] API test gardening
15113 https://bugs.webkit.org/show_bug.cgi?id=193319
15115 Reviewed by Michael Catanzaro.
15117 * TestWebKitAPI/glib/TestExpectations.json: Remove some now
15120 2019-01-14 Charlie Turner <cturner@igalia.com>
15122 [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
15123 https://bugs.webkit.org/show_bug.cgi?id=192977
15125 Reviewed by Carlos Garcia Campos.
15127 * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
15128 * TestWebKitAPI/PlatformWPE.cmake: Ditto.
15129 * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
15130 (TestWebKitAPI::GStreamerTest::SetUp):
15131 (TestWebKitAPI::GStreamerTest::TearDown):
15132 * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
15133 * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
15134 (TestWebKitAPI::TEST_F):
15136 2019-01-14 Charlie Turner <cturner@igalia.com>
15138 [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
15139 https://bugs.webkit.org/show_bug.cgi?id=193332
15141 Reviewed by Michael Catanzaro.
15143 * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
15144 defined as a char16_t, which changed in ICU 59, the
15145 StringTypeAdapter<UnsignedInt, ...> overload catches casts to
15146 unsigned short. This test is relying on the behaviour that
15147 UChar=unsigned short, which doesn't hold across platforms and ICU
15148 library versions. The full fix would be a special syntax for
15149 literal characters so that these ambiguities do not arise. That
15150 work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
15151 (TestWebKitAPI::TEST):
15153 2019-01-14 Carlos Garcia Campos <cgarcia@igalia.com>
15155 Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
15157 * Scripts/make-dist:
15158 (Distcheck.configure):
15160 2019-01-13 Aakash Jain <aakash_jain@apple.com>
15162 [ews-build] Update macOS queue configurations
15163 https://bugs.webkit.org/show_bug.cgi?id=193365
15164 <rdar://problem/47221073>
15166 Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
15168 * BuildSlaveSupport/ews-build/config.json:
15170 2019-01-13 Zalan Bujtas <zalan@apple.com>
15172 [LFC] Adjust assert for statically positioned fixed elements
15173 https://bugs.webkit.org/show_bug.cgi?id=193385
15175 Reviewed by Antti Koivisto.
15177 * LayoutReloaded/misc/LFC-passing-tests.txt:
15179 2019-01-13 Philippe Normand <pnormand@igalia.com>
15181 [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
15182 https://bugs.webkit.org/show_bug.cgi?id=193387
15184 Reviewed by Carlos Garcia Campos.
15186 * MiniBrowser/wpe/main.cpp:
15189 2019-01-12 Timothy Hatcher <timothy@apple.com>
15191 Have prefers-color-scheme: light always match on macOS versions before Mojave.
15192 https://bugs.webkit.org/show_bug.cgi?id=191655
15193 rdar://problem/46074680
15195 Reviewed by Megan Gardner.
15197 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
15198 * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
15200 2019-01-12 Dan Bernstein <mitz@apple.com>
15202 [Cocoa] Avoid importing directly from subumbrella frameworks
15203 https://bugs.webkit.org/show_bug.cgi?id=186016
15204 <rdar://problem/40591038>
15206 Reviewed by Sam Weinig.
15208 * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
15209 LaunchServices header.
15210 * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
15211 OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
15212 * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
15213 when using SDKs earlier than 10.13.
15214 * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
15215 and OTHER_CPLUSPLUSFLAGS.
15216 * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
15217 OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
15218 * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
15219 LaunchServices header.
15221 2019-01-11 John Wilander <wilander@apple.com>
15223 Compile out Web API Statistics Collection
15224 https://bugs.webkit.org/show_bug.cgi?id=193370
15225 <rdar://problem/45388584>
15227 Reviewed by Brent Fulgham.
15229 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
15230 Defined ENABLE_WEB_API_STATISTICS, off by default.
15232 2019-01-11 Carlos Eduardo Ramalho <cadubentzen@gmail.com>
15235 https://bugs.webkit.org/show_bug.cgi?id=178900
15237 Reviewed by Michael Catanzaro.
15239 Add Tools/gtkdoc to manifest.txt.in files.
15240 This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
15242 * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
15243 * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
15245 2019-01-11 Wenson Hsieh <wenson_hsieh@apple.com>
15247 [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
15248 https://bugs.webkit.org/show_bug.cgi?id=193364
15249 <rdar://problem/47214117>
15251 Reviewed by Tim Horton.
15253 Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
15254 precise, whereas dragging near the middle of the textarea does.
15256 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
15257 (TestWebKitAPI::TEST):
15259 2019-01-11 Jonathan Bedard <jbedard@apple.com>
15261 webkitpy: Support alternate simctl device list output
15262 https://bugs.webkit.org/show_bug.cgi?id=193362
15263 <rdar://problem/47122965>
15265 Reviewed by Lucas Forschler.
15267 * Scripts/webkitpy/xcode/simulated_device.py:
15268 (SimulatedDeviceManager.populate_available_devices):
15270 2019-01-11 Aakash Jain <aakash_jain@apple.com>
15272 [ews-build] Update macOS queue configurations
15273 https://bugs.webkit.org/show_bug.cgi?id=193365
15275 Reviewed by Lucas Forschler.
15277 * BuildSlaveSupport/ews-build/config.json:
15279 2019-01-11 Jonathan Bedard <jbedard@apple.com>
15281 webkitpy: Incorporate device type into baseline search path
15282 https://bugs.webkit.org/show_bug.cgi?id=193356
15283 <rdar://problem/47215515>
15285 Reviewed by Lucas Forschler.
15287 We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
15289 * Scripts/webkitpy/port/base.py:
15290 (Port.default_baseline_search_path): Allow device type to be passed in.
15291 * Scripts/webkitpy/port/gtk.py:
15292 (GtkPort.default_baseline_search_path): Ignore device type.
15293 * Scripts/webkitpy/port/ios.py:
15294 (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
15295 (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
15296 * Scripts/webkitpy/port/ios_device_unittest.py:
15298 * Scripts/webkitpy/port/ios_simulator_unittest.py:
15299 (IOSSimulatorTest):
15300 * Scripts/webkitpy/port/mac.py:
15301 (MacPort.default_baseline_search_path): Ignore device type.
15302 * Scripts/webkitpy/port/watch.py:
15303 (WatchPort.default_baseline_search_path): Ditto.
15304 * Scripts/webkitpy/port/win.py:
15305 (WinPort.default_baseline_search_path): Ditto.
15306 (WinCairoPort.default_baseline_search_path): Ditto.
15307 * Scripts/webkitpy/port/wpe.py:
15308 (WPEPort.default_baseline_search_path): Ditto.
15310 2019-01-11 Jonathan Bedard <jbedard@apple.com>
15312 webkitpy: Print abbreviated baseline search path that includes only folders that exist
15313 https://bugs.webkit.org/show_bug.cgi?id=193352
15314 <rdar://problem/47210736>
15316 Reviewed by Lucas Forschler.
15318 * Scripts/webkitpy/layout_tests/views/printing.py:
15319 (Printer.print_config): Print list on only baseline search paths which exist.
15320 * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
15321 (Testprinter.test_print_config):
15323 2019-01-11 Joseph Pecoraro <pecoraro@apple.com>
15325 Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
15326 https://bugs.webkit.org/show_bug.cgi?id=193340
15328 Reviewed by David Kilzer.
15330 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
15331 (WTR::InjectedBundle::didReceiveMessageToPage):
15332 Pull the strings out into a WKRetainPtr.
15334 * WebKitTestRunner/WebNotificationProvider.cpp:
15335 (WTR::WebNotificationProvider::closeWebNotification):
15336 Adopt the created value into the WKRetainPtr.
15338 * WebKitTestRunner/mac/TestControllerMac.mm:
15339 (WTR::generateWhitelist):
15340 Immediately adopt a created value to avoid potential mistakes.
15342 2019-01-11 Dominik Infuehr <dinfuehr@igalia.com>
15344 Enable DFG on ARM/Linux again
15345 https://bugs.webkit.org/show_bug.cgi?id=192496
15347 Reviewed by Yusuke Suzuki.
15349 After changing the bytecode format DFG was disabled on all 32-bit
15350 architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
15353 * Scripts/run-jsc-stress-tests:
15355 2019-01-11 Timothy Hatcher <timothy@apple.com>
15357 Unreviewed, fix #ifdef in API test added in r239851.
15358 https://bugs.webkit.org/show_bug.cgi?id=193327
15359 rdar://problem/47093222
15361 * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
15363 2019-01-11 Wenson Hsieh <wenson_hsieh@apple.com>
15365 Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
15366 https://bugs.webkit.org/show_bug.cgi?id=193109
15367 <rdar://problem/44807048>
15369 Reviewed by Ryosuke Niwa.
15371 Introduce and respect a test option to enable the UndoManager API.
15373 * WebKitTestRunner/TestController.cpp:
15374 (WTR::updateTestOptionsFromTestHeader):
15375 * WebKitTestRunner/TestOptions.h:
15376 (WTR::TestOptions::hasSameInitializationOptions const):
15377 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
15378 (WTR::TestController::platformCreateWebView):
15380 2019-01-11 Zalan Bujtas <zalan@apple.com>
15382 [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
15383 https://bugs.webkit.org/show_bug.cgi?id=193346
15385 Reviewed by Antti Koivisto.
15387 * LayoutReloaded/misc/LFC-passing-tests.txt:
15389 2019-01-10 Ryan Haddad <ryanhaddad@apple.com>
15391 Unreviewed, fix typo that breaks dashboard link.
15393 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
15396 2019-01-10 Ryan Haddad <ryanhaddad@apple.com>
15398 Update macOS queue configurations
15399 https://bugs.webkit.org/show_bug.cgi?id=193329
15401 Reviewed by Alexey Proskuryakov.
15403 * BuildSlaveSupport/build.webkit.org-config/config.json:
15404 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
15405 (BubbleQueueServer):
15406 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
15407 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
15409 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
15410 (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
15411 * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
15413 2019-01-10 Joseph Pecoraro <pecoraro@apple.com>
15415 MiniBrowser should be able to navigate to about:blank
15416 https://bugs.webkit.org/show_bug.cgi?id=193345
15418 Reviewed by Simon Fraser.
15420 * MiniBrowser/mac/BrowserWindowController.m:
15421 (-[BrowserWindowController addProtocolIfNecessary:]):
15422 Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
15424 * MiniBrowser/mac/WK1BrowserWindowController.m:
15425 (-[WK1BrowserWindowController fetch:]):
15426 * MiniBrowser/mac/WK2BrowserWindowController.m:
15427 (-[WK2BrowserWindowController fetch:]):
15428 Clean up the code that uses this to match style.
15430 2019-01-10 Joseph Pecoraro <pecoraro@apple.com>
15432 Remove MiniBrowser custom "Process Swap" menu item which does not work
15433 https://bugs.webkit.org/show_bug.cgi?id=193344
15435 Reviewed by Simon Fraser.
15437 There is a menu item under the Experimental menu that does work.
15439 * MiniBrowser/mac/AppDelegate.m:
15440 (defaultConfiguration):
15441 * MiniBrowser/mac/SettingsController.h:
15442 * MiniBrowser/mac/SettingsController.m:
15443 (-[SettingsController _populateMenu]):
15444 (-[SettingsController validateMenuItem:]):
15445 (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
15446 (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
15448 2019-01-10 Timothy Hatcher <timothy@apple.com>
15450 Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
15451 https://bugs.webkit.org/show_bug.cgi?id=193327
15452 rdar://problem/47093222
15454 Reviewed by Tim Horton.
15456 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
15457 * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
15458 (TestWebKitAPI::didFinishNavigation):
15459 (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
15460 (TestWebKitAPI::TEST):
15461 * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
15462 (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
15463 (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
15464 (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
15465 * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
15467 2019-01-10 Joseph Pecoraro <pecoraro@apple.com>
15469 Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
15470 https://bugs.webkit.org/show_bug.cgi?id=193338
15471 <rdar://problem/46664774>
15473 Reviewed by David Kilzer.
15475 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
15476 (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
15478 2019-01-10 Commit Queue <commit-queue@webkit.org>
15480 Unreviewed, rolling out r239825.
15481 https://bugs.webkit.org/show_bug.cgi?id=193330
15483 Broke tests on armv7/linux bots (Requested by guijemont on
15486 Reverted changeset:
15488 "Enable DFG on ARM/Linux again"
15489 https://bugs.webkit.org/show_bug.cgi?id=192496
15490 https://trac.webkit.org/changeset/239825
15492 2019-01-10 Zhifei Fang <zhifei_fang@apple.com>
15494 Disable the run-jsc-stress-test remote host key check.
15495 https://bugs.webkit.org/show_bug.cgi?id=192988
15497 Reviewed by Alexey Proskuryakov.
15499 * Scripts/run-jsc-stress-tests:
15501 2019-01-10 John Wilander <wilander@apple.com>
15503 Override the session configuration for cookieAcceptPolicy
15504 https://bugs.webkit.org/show_bug.cgi?id=190925
15505 <rdar://problem/45497382>
15507 Reviewed by Alexey Proskuryakov and Alex Christensen.
15509 Test infrastructure for setting a first-party-only cookie policy.
15511 * DumpRenderTree/TestRunner.cpp:
15512 (setOnlyAcceptFirstPartyCookiesCallback):
15513 (TestRunner::staticFunctions):
15514 * DumpRenderTree/TestRunner.h:
15515 * DumpRenderTree/mac/TestRunnerMac.mm:
15516 (TestRunner::setOnlyAcceptFirstPartyCookies):
15517 * DumpRenderTree/win/TestRunnerWin.cpp:
15518 (TestRunner::setOnlyAcceptFirstPartyCookies):
15519 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
15520 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
15521 (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
15522 * WebKitTestRunner/InjectedBundle/TestRunner.h:
15523 * WebKitTestRunner/TestInvocation.cpp:
15524 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
15526 2019-01-09 Matt Rajca <mrajca@apple.com>
15528 Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
15529 https://bugs.webkit.org/show_bug.cgi?id=193301
15531 Reviewed by Jer Noble.
15535 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
15536 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
15538 * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
15540 2019-01-10 Zalan Bujtas <zalan@apple.com>
15542 [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
15543 https://bugs.webkit.org/show_bug.cgi?id=193310
15545 Reviewed by Antti Koivisto.
15547 * LayoutReloaded/misc/LFC-passing-tests.txt:
15549 2019-01-10 Dominik Infuehr <dinfuehr@igalia.com>
15551 Enable DFG on ARM/Linux again
15552 https://bugs.webkit.org/show_bug.cgi?id=192496
15554 Reviewed by Yusuke Suzuki.
15556 After changing the bytecode format DFG was disabled on all 32-bit
15557 architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
15560 * Scripts/run-jsc-stress-tests:
15562 2019-01-09 Fujii Hironori <Hironori.Fujii@sony.com>
15564 [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
15565 https://bugs.webkit.org/show_bug.cgi?id=193271
15567 Reviewed by Brent Fulgham.
15569 BSTR is a special data structure created by SysAllocString, not a
15570 wchar_t null-terminated string.
15572 * DumpRenderTree/win/TestRunnerWin.cpp:
15573 (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
15574 * MiniBrowser/win/MiniBrowserWebHost.cpp:
15575 (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
15576 BSTR from wide string literals.
15578 2019-01-09 Alexey Proskuryakov <ap@apple.com>
15580 Tweak wording for build/version_check style checker error
15581 https://bugs.webkit.org/show_bug.cgi?id=193256
15583 Reviewed by Tim Horton.
15585 * Scripts/webkitpy/style/checkers/cpp.py:
15586 (check_os_version_checks):
15587 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
15588 (WebKitStyleTest.test_os_version_checks):
15590 2019-01-09 Aakash Jain <aakash_jain@apple.com>
15592 [ews-build] Add link to bug along with bug title
15593 https://bugs.webkit.org/show_bug.cgi?id=193293
15595 Reviewed by Lucas Forschler.
15597 * BuildSlaveSupport/ews-build/steps.py:
15598 (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
15599 (ConfigureBuild.add_bug_id_url): Deleted.
15600 (ConfigureBuild.getBugURL): Deleted.
15602 2019-01-09 Aakash Jain <aakash_jain@apple.com>
15604 [ews-build] Use https for ews-build server
15605 https://bugs.webkit.org/show_bug.cgi?id=193193
15607 Reviewed by Lucas Forschler.
15609 * BuildSlaveSupport/ews-build/steps.py:
15611 2019-01-09 Aakash Jain <aakash_jain@apple.com>
15613 [ews-build] Parse and display number of style failures
15614 https://bugs.webkit.org/show_bug.cgi?id=193280
15616 Reviewed by Lucas Forschler.
15618 * BuildSlaveSupport/ews-build/steps.py:
15619 (CheckStyle): Use TestWithFailureCount as base class.
15620 (CheckStyle.countFailures): Count the number of style failures.
15622 2019-01-09 Aakash Jain <aakash_jain@apple.com>
15624 [ews-build] use patch_id instead of ewspatchid
15625 https://bugs.webkit.org/show_bug.cgi?id=193235
15627 Reviewed by Lucas Forschler.
15629 * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
15630 * BuildSlaveSupport/ews-build/steps.py: Ditto.
15631 * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
15633 2019-01-09 Zalan Bujtas <zalan@apple.com>
15635 [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
15636 https://bugs.webkit.org/show_bug.cgi?id=192625
15638 Reviewed by Antti Koivisto.
15640 * LayoutReloaded/misc/LFC-passing-tests.txt:
15642 2019-01-09 Michael Catanzaro <mcatanzaro@igalia.com>
15644 [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
15645 https://bugs.webkit.org/show_bug.cgi?id=192841
15647 Reviewed by Carlos Garcia Campos.
15649 There are separate g_assert_*() macros for use in tests, which we use inconsistently
15650 currently. Use them always. We'll get nicer error messages now when tests fail, and the
15651 assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
15653 Note that the documentation of g_assert() says that it is not to be used when writing tests.
15655 * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
15656 * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
15657 (WebKitWebEditorTest::testSelectionChanged):
15658 * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
15659 (WebKitFrameTest::testMainFrame):
15660 (WebKitFrameTest::testURI):
15661 (WebKitFrameTest::testJavaScriptContext):
15662 (WebKitFrameTest::testJavaScriptValues):
15663 * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
15664 (testWebViewAuthenticationRequest):
15665 (testWebViewAuthenticationLoadCancelled):
15666 (testWebViewAuthenticationFailure):
15667 (testWebViewAuthenticationStorage):
15668 (ProxyAuthenticationTest::ProxyAuthenticationTest):
15669 (testWebViewAuthenticationProxy):
15670 (testWebViewAuthenticationProxyHTTPS):
15671 * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
15672 (testAutomationSessionRequestSession):
15673 * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
15674 (testBackForwardListNavigation):
15675 (testWebKitWebViewSessionState):
15676 (testWebKitWebViewSessionStateWithFormData):
15677 * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
15678 (ConsoleMessageTest::consoleMessageReceivedCallback):
15679 (testWebKitConsoleMessageConsoleAPI):
15680 (testWebKitConsoleMessageJavaScriptException):
15681 (testWebKitConsoleMessageNetworkError):
15682 (testWebKitConsoleMessageSecurityError):
15683 * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
15684 (testCookieManagerAcceptPolicy):
15685 (testCookieManagerCookiesChanged):
15686 (testCookieManagerPersistentStorage):
15687 (testCookieManagerPersistentStorageDeleteAll):
15688 (testCookieManagerEphemeral):
15689 * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
15690 (testWebKitDOMElementAutoFill):
15691 * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
15692 (downloadLocalFileSuccessfully):
15693 (createFileAtDestination):
15694 (testDownloadOverwriteDestinationDisallowed):
15695 (testDownloadLocalFileError):
15696 (testDownloadRemoteFile):
15697 (testDownloadRemoteFileError):
15698 (testWebViewDownloadURI):
15699 (testPolicyResponseDownload):
15700 (testPolicyResponseDownloadCancel):
15701 (testDownloadMIMEType):
15702 (contextMenuCallback):
15703 (testContextMenuDownloadActions):
15704 (testBlobDownload):
15705 * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
15706 (testWebKitWebEditorSelectionChanged):
15707 * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
15708 (testWebKitFrameMainFrame):
15709 (testWebKitFrameURI):
15710 (testWebKitFrameJavaScriptContext):
15711 (testWebKitFrameJavaScriptValues):
15712 * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
15713 (LoadStopTrackingTest::loadFailed):
15714 (testWebViewTitle):
15715 (testURIRequestHTTPHeaders):
15716 (testURIRequestHTTPMethod):
15717 (testURIResponseHTTPHeaders):
15718 (testRedirectToDataURI):
15719 * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
15720 (testProcessPerWebView):
15721 (testWebProcessLimit):
15722 * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
15723 (testWebViewResources):
15724 (testWebResourceLoading):
15725 (testWebResourceSuggestedFilename):
15726 (testWebResourceGetData):
15727 (testWebResourceGetDataError):
15728 (testWebViewResourcesHistoryCache):
15729 (testWebResourceSendRequest):
15730 * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
15732 (testInsecureContent):
15733 (testTLSErrorsPolicy):
15734 (testTLSErrorsRedirect):
15735 (testTLSErrorsHTTPAuth):
15736 (testLoadFailedWithTLSErrors):
15737 (testSubresourceLoadFailedWithTLSErrors):
15738 (httpsServerCallback):
15739 * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
15740 (testWebViewCreateNavigationData):
15741 (testWebViewJavaScriptDialogs):
15742 (testWebViewWindowProperties):
15743 (testWebViewMouseTarget):
15744 (testWebViewFileChooserRequest):
15745 (testWebViewColorChooserRequest):
15746 * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
15747 (testWebExtensionGetTitle):
15748 (testDocumentLoadedSignal):
15749 (testWebKitWebViewProcessCrashed):
15750 (testWebExtensionWindowObjectCleared):
15751 (testWebExtensionIsolatedWorld):
15752 (permissionRequestCallback):
15753 (didAssociateFormControlsCallback):
15754 (testWebExtensionFormControlsAssociated):
15755 (FormSubmissionTest::FormSubmissionTest):
15756 (FormSubmissionTest::testFormSubmissionResult):
15757 (testWebExtensionFormSubmissionSteps):
15758 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
15759 (testNotInitialized):
15760 (testClearDatabase):
15761 (testPrivateBrowsing):
15763 (testWebViewFavicon):
15764 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
15765 (testFindControllerTextFound):
15766 (testFindControllerTextNotFound):
15767 (testFindControllerMatchCount):
15768 (testFindControllerMaxMatchCount):
15769 (testFindControllerNext):
15770 (testFindControllerPrevious):
15771 (testFindControllerCountedMatches):
15772 (testFindControllerOptions):
15773 (testFindControllerHide):
15774 (testFindControllerInstance):
15775 (testFindControllerGetters):
15776 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
15777 (testNavigationPolicy):
15778 (testResponsePolicy):
15779 (testNewWindowPolicy):
15780 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
15781 (testSecurityOriginBasicConstructor):
15782 (testSecurityOriginURIConstructor):
15783 (testSecurityOriginDefaultPort):
15784 (testSecurityOriginFileURI):
15785 (testOpaqueSecurityOrigin):
15786 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
15787 (testWebKitSettings):
15788 (testWebKitSettingsNewWithSettings):
15789 (testWebKitSettingsUserAgent):
15790 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
15791 (testWebViewNewWithUserContentManager):
15792 (isStyleSheetInjectedForURLAtPath):
15793 (isScriptInjectedForURLAtPath):
15794 (testUserContentManagerInjectedStyleSheet):
15795 (testUserContentManagerInjectedScript):
15796 (UserScriptMessageTest::scriptMessageReceived):
15797 (UserScriptMessageTest::waitUntilMessageReceived):
15798 (UserScriptMessageTest::runJavaScriptFinished):
15799 (testUserContentManagerScriptMessageReceived):
15800 (testUserContentManagerScriptMessageInWorldReceived):
15801 (testUserContentManagerScriptMessageFromDOMBindings):
15802 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
15803 (testWebContextDefault):
15804 (testWebContextEphemeral):
15805 (testWebContextGetPlugins):
15806 (testWebContextURIScheme):
15807 (testWebContextSpellChecker):
15808 (testWebContextLanguages):
15809 (consoleMessageReceivedCallback):
15810 (testWebContextSecurityFileXHR):
15811 (ProxyTest::ProxyTest):
15812 (testWebContextProxySettings):
15813 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
15814 (testWebViewWebContext):
15815 (testWebViewWebBackend):
15816 (testWebViewEphemeral):
15817 (testWebViewCustomCharset):
15818 (testWebViewSettings):
15819 (testWebViewRunJavaScript):
15820 (testWebViewCanShowMIMEType):
15821 (testWebViewSubmitForm):
15823 (testWebViewPageVisibility):
15824 (testWebViewSnapshot):
15825 (testWebViewNotification):
15826 (testWebViewNotificationInitialPermissionAllowed):
15827 (testWebViewNotificationInitialPermissionDisallowed):
15828 (testWebViewIsPlayingAudio):
15829 * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
15830 (WebsiteDataTest::WebsiteDataTest):
15831 (WebsiteDataTest::remove):
15832 (WebsiteDataTest::clear):
15833 (testWebsiteDataConfiguration):
15834 (testWebsiteDataEphemeral):
15835 (testWebsiteDataCache):
15836 (testWebsiteDataStorage):
15837 (testWebsiteDataDatabases):
15838 (testWebsiteDataAppcache):
15839 (testWebsiteDataCookies):
15840 (testWebsiteDataDeviceIdHashSalt):
15841 * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
15842 (emitDocumentLoaded):
15844 (sendRequestCallback):
15845 (contextMenuCallback):
15846 (consoleMessageSentCallback):
15847 (emitFormControlsAssociated):
15848 (formControlsAssociatedCallback):
15849 (emitFormSubmissionEvent):
15850 (willSubmitFormCallback):
15851 (windowObjectCleared):
15852 (methodCallCallback):
15853 (registerGResource):
15854 (webkit_web_extension_initialize_with_user_data):
15855 * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
15857 (WebProcessTest::create):
15859 * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
15860 (AutocleanupsTest::testWebProcessAutocleanups):
15861 * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
15862 (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
15863 (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
15864 * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
15865 (WebKitDOMDOMWindowTest::testSignals):
15866 (WebKitDOMDOMWindowTest::testDispatchEvent):
15867 (WebKitDOMDOMWindowTest::testGetComputedStyle):
15868 * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
15869 (WebKitDOMNodeFilterTest::testTreeWalker):
15870 (WebKitDOMNodeFilterTest::testNodeIterator):
15871 * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
15872 (WebKitDOMNodeTest::testHierarchyNavigation):
15873 (WebKitDOMNodeTest::testInsertion):
15874 (WebKitDOMNodeTest::testTagNamesNodeList):
15875 (WebKitDOMNodeTest::testTagNamesHTMLCollection):
15876 (WebKitDOMNodeTest::testDOMCache):
15877 * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
15878 (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
15879 (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
15880 (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
15881 * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
15882 (testUIProcessAutocleanups):
15883 (testWebProcessAutocleanups):
15884 * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
15885 (testContextMenuPopulateMenu):
15886 (testContextMenuDismissed):
15887 * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
15888 (testWebKitDOMClientRectDivBoundingClientRectPosition):
15889 (testWebKitDOMClientRectDivClientRectsPositionAndLength):
15890 * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
15891 (testWebKitDOMDOMWindowSignals):
15892 (testWebKitDOMDOMWindowDispatchEvent):
15893 (testWebKitDOMDOMWindowGetComputedStyle):
15894 * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
15895 (testWebKitDOMNodeHierarchyNavigation):
15896 (testWebKitDOMNodeInsertion):
15897 (testWebKitDOMNodeTagNamesNodeList):
15898 (testWebKitDOMNodeTagNamesHTMLCollection):
15899 (testWebKitDOMObjectCache):
15900 * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
15901 (testWebKitDOMNodeFilterTreeWalker):
15902 (testWebKitDOMNodeFilterNodeIterator):
15903 * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
15904 (testWebKitDOMXPathNSResolverNative):
15905 (testWebKitDOMXPathNSResolverCustom):
15906 * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
15907 (testInspectorDefault):
15908 (testInspectorManualAttachDetach):
15909 (testInspectorCustomContainerDestroyed):
15910 * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
15912 (testInspectorServerPageList):
15913 * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
15914 (OptionMenuTest::showOptionMenuCallback):
15915 (OptionMenuTest::menuCloseCallback):
15916 (OptionMenuTest::close):
15917 (OptionMenuTest::activateItem):
15918 (OptionMenuTest::selectItem):
15919 (testOptionMenuSimple):
15920 (testOptionMenuGroups):
15921 (testOptionMenuActivate):
15922 (testOptionMenuSelect):
15923 * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
15924 (testPrintOperationPrintSettings):
15925 (webViewPrintCallback):
15926 (testPrintOperationPrint):
15927 (testPrintCustomWidget):
15928 * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
15929 (checkAtspiAccessible):
15930 (testAtspiBasicHierarchy):
15931 * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
15932 (testWebKitCheckVersion):
15933 * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
15934 (testWebViewEditorCutCopyPasteNonEditable):
15935 (testWebViewEditorCutCopyPasteEditable):
15936 (testWebViewEditorSelectAllNonEditable):
15937 (testWebViewEditorSelectAllEditable):
15938 (loadContentsAndTryToCutSelection):
15939 (testWebViewEditorNonEditable):
15940 (testWebViewEditorEditable):
15941 (testWebViewEditorEditorStateTypingAttributes):
15942 (testWebViewEditorInsertImage):
15943 (testWebViewEditorCreateLink):
15944 * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
15945 (loadChangedCallback):
15946 (loadFailedCallback):
15947 (loadFailedWithTLSErrorsCallback):
15948 (LoadTrackingTest::LoadTrackingTest):
15949 * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
15950 (registerGResource):
15951 (removeNonEmptyDirectory):
15952 * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
15955 * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
15956 (WebKitTestBus::getOrCreateConnection):
15957 (WebKitTestBus::createProxy):
15958 * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
15959 (WebKitTestServer::getWebSocketURIForPath const):
15960 * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
15961 (WebViewTest::initializeWebView):
15962 (WebViewTest::loadURI):
15963 (WebViewTest::loadHtml):
15964 (WebViewTest::loadPlainText):
15965 (WebViewTest::loadBytes):
15966 (WebViewTest::loadRequest):
15967 (WebViewTest::loadAlternateHTML):
15968 (WebViewTest::goBack):
15969 (WebViewTest::goForward):
15970 (WebViewTest::goToBackForwardListItem):
15971 (resourceGetDataCallback):
15972 (WebViewTest::mainResourceData):
15973 (WebViewTest::javascriptResultToCString):
15974 (WebViewTest::javascriptResultToNumber):
15975 (WebViewTest::javascriptResultToBoolean):
15976 (WebViewTest::javascriptResultIsNull):
15977 (WebViewTest::javascriptResultIsUndefined):
15979 (WebViewTest::runWebProcessTest):
15980 * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
15981 (WebViewTest::platformInitializeWebView):
15982 (WebViewTest::showInWindow):
15983 (WebViewTest::showInWindowAndWaitUntilMapped):
15984 (WebViewTest::mouseMoveTo):
15985 (WebViewTest::emitPopupMenuSignal):
15986 (WebViewTest::keyStroke):
15987 (WebViewTest::doMouseButtonEvent):
15989 2019-01-09 Philippe Normand <pnormand@igalia.com>
15991 [WPE] API tests can't run in flatpak environment
15992 https://bugs.webkit.org/show_bug.cgi?id=193242
15994 Reviewed by Michael Catanzaro.
15996 * Scripts/run-wpe-tests: Add --wpe to arguments passed to
15997 flatpakutils so that it knows which port it's dealing with.
15998 * glib/common.py: Remove build_dir globals so that subsequent
15999 calls actually take args into account.
16000 (library_build_path):
16001 (binary_build_path):
16003 2019-01-08 Dean Jackson <dino@apple.com>
16005 Blob references for System Previews don't get a correct file extension
16006 https://bugs.webkit.org/show_bug.cgi?id=193268
16007 <rdar://problem/47133037>
16009 Reviewed by Tim Horton.
16011 New test that a Blob download of a USDZ file gets named correctly.
16013 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16014 * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
16015 (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
16016 (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
16018 * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
16020 2019-01-08 Jiewen Tan <jiewen_tan@apple.com>
16022 [WebAuthN] Support U2F HID Authenticators on macOS
16023 https://bugs.webkit.org/show_bug.cgi?id=191535
16024 <rdar://problem/47102027>
16026 Reviewed by Brent Fulgham.
16029 1) adds support for U2F mocking mechanism;
16030 2) updates tests to reflect U2fCommandConstructor changes.
16032 * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
16033 (TestWebKitAPI::TEST):
16034 * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
16035 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
16036 (WTR::TestRunner::setWebAuthenticationMockConfiguration):
16038 2019-01-08 Wenson Hsieh <wenson_hsieh@apple.com>
16040 [iOS] Dispatch a synthetic mousedown event prior to starting drags
16041 https://bugs.webkit.org/show_bug.cgi?id=193229
16042 <rdar://problem/46717097>
16044 Reviewed by Tim Horton.
16046 Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
16047 prevents a drag from starting.
16049 * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
16050 * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
16052 Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
16054 2019-01-08 Zhifei Fang <zhifei_fang@apple.com>
16056 Layout test will generate a perf metric file to results dir.
16057 https://bugs.webkit.org/show_bug.cgi?id=192030
16058 <rdar://problem/32779516>
16060 Reviewed by Aakash Jain.
16062 Layout test running time will be collected to a perf metric file.
16063 For now, instead of outputing running time of all tests (which is huge),
16064 we aggregate them by test directories which are at most two level deep.
16066 * Scripts/webkitpy/layout_tests/controllers/manager.py:
16067 (Manager._end_test_run):
16068 (Manager._output_perf_metrics):
16069 (Manager._print_expectation_line_for_test):
16070 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
16071 (add_test_perf_metric):
16072 (test_perf_metrics):
16073 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
16074 (JSONGeneratorTest.test_test_timings_trie):
16075 (JSONGeneratorTest):
16076 (JSONGeneratorTest.test_test_perf_metrics):
16077 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
16078 (RebaselineTest.test_reset_results):
16079 (RebaselineTest.test_missing_results):
16080 (RebaselineTest.test_new_baseline):
16082 2019-01-08 Patrick Griffis <pgriffis@igalia.com>
16084 [WPE][GTK] Add php-json to install-dependencies
16085 https://bugs.webkit.org/show_bug.cgi?id=193233
16087 Reviewed by Michael Catanzaro.
16089 * gtk/install-dependencies:
16090 * wpe/install-dependencies:
16092 2019-01-08 Chris Dumez <cdumez@apple.com>
16094 Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
16095 https://bugs.webkit.org/show_bug.cgi?id=193224
16096 <rdar://problem/47097726>
16098 Reviewed by Alex Christensen.
16100 Add API test coverage.
16102 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
16104 2019-01-07 David Kilzer <ddkilzer@apple.com>
16106 Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
16107 <https://webkit.org/b/193222>
16108 <rdar://problem/46862309>
16110 Reviewed by Joseph Pecoraro.
16112 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
16113 (WTR::executeCallback): Fix camel case of variable name.
16114 (WTR::EventSendingController::callAfterScrollingCompletes): If
16115 WKBundlePageRegisterScrollOperationCompletionCallback() returns
16116 false, make sure to release the ScrollCompletionCallbackData
16117 object. This fixes the leak.
16119 2019-01-07 Fujii Hironori <Hironori.Fujii@sony.com>
16121 [Win] EWS: wincairo-ews cannot apply a patch with *.png
16122 https://bugs.webkit.org/show_bug.cgi?id=193044
16124 Reviewed by Daniel Bates.
16126 WinCairo EWS bots are using Windows Perl. Binary files should be
16127 opened as binary mode.
16129 * Scripts/svn-apply:
16130 (handleGitBinaryChange): Use 'binmode' for binary file handles.
16132 2019-01-07 Don Olmstead <don.olmstead@sony.com>
16134 [CMake] Add ENABLE_CSS_TYPED_OM option
16135 https://bugs.webkit.org/show_bug.cgi?id=193216
16137 Reviewed by Michael Catanzaro.
16139 * Scripts/webkitperl/FeatureList.pm:
16141 2019-01-07 David Kilzer <ddkilzer@apple.com>
16143 Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
16144 <https://webkit.org/b/193056>
16146 Reviewed by Alex Christensen.
16148 * Scripts/webkitpy/style/checker.py:
16149 - Ignore use of new runtime/retainptr check in
16150 Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
16151 contains tests to ensure RetainPtr<NSObject *> is compatible
16152 with RetainPtr<NSObject>.
16154 * Scripts/webkitpy/style/checkers/cpp.py:
16157 - Add checker for use of '*' in RetainPtr<> type. A for loop
16158 was used instead of a single regex so that angle brackets
16159 could be matched up when checking the type contained within
16160 the RetainPtr<> type.
16162 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
16164 - Add unit test for new runtime/retainptr check.
16166 * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
16167 * TestWebKitAPI/EditingTestHarness.h:
16168 - Remove '*' from RetainPtr<> type.
16170 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16171 - Add cf/RetainPtr.cpp back to TestWTFLibrary target! This
16172 regressed in r201938.
16174 * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
16175 (TestWebKitAPI::TEST):
16176 - Update tests to match RetainPtr.mm tests (except for the
16177 `*SimilarNSType` tests since there is no CF equivalent of
16178 RetainPtr<NSString> and RetainPtr<NSString *>).
16180 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
16181 (TestWebKitAPI::TEST):
16183 - Not conflict by name with equivalent CF tests in
16185 - Add test cases for RetainPtr<NSObject>,
16186 RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
16187 - Add `*SimilarNSType` tests for converting between
16188 RetainPtr<NSObject> and RetainPtr<NSObject *>.
16189 - Change `0` to `nil` as appropriate.
16190 - Re-alphabetize the tests by name.
16191 - Add Optional<RetainPtr<>> tests.
16192 - Add retainPtr() tests.
16194 * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
16195 (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
16196 * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
16198 - Remove '*' from RetainPtr<> type.
16200 * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
16201 (TEST(WebKit, JITEnabled)):
16202 - Add missing WTFMove(). Apparently a temporary was being
16203 created before in the argument list due to mismatched
16206 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
16207 * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
16208 (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
16209 (TestWebKitAPI::TEST):
16210 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
16211 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
16212 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
16213 (WTR::resourcesDirectoryURL):
16214 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
16215 (WTR::InjectedBundle::platformInitialize):
16216 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
16217 - Remove '*' from RetainPtr<> type.
16219 2019-01-07 Eric Carlson <eric.carlson@apple.com>
16221 A MediaTime timescale must never be zero
16222 https://bugs.webkit.org/show_bug.cgi?id=193156
16223 <rdar://problem/32504501>
16225 Reviewed by Jer Noble.
16227 * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
16228 (TestWebKitAPI::TEST): Add tests for zero timescale.
16230 2019-01-07 Youenn Fablet <youenn@apple.com>
16232 API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
16233 https://bugs.webkit.org/show_bug.cgi?id=193175
16235 Reviewed by Chris Dumez.
16237 Updated API test as we bumped the SW schema to version 4.
16239 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16240 * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
16241 * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
16244 2019-01-06 Fujii Hironori <Hironori.Fujii@sony.com>
16246 [Win][Clang] Fix compilation warnings of MiniBrowser
16247 https://bugs.webkit.org/show_bug.cgi?id=193029
16249 Reviewed by Ross Kirsling.
16251 * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
16252 and m_URLBarFont. Reorder member variables to fix -Wreorder
16254 * MiniBrowser/win/PageLoadTestClient.cpp:
16255 (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
16256 * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
16257 pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
16259 * MiniBrowser/win/WebKitBrowserWindow.cpp:
16260 (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
16261 navigationClient with '{ }' to fix the missing field warning.
16262 * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
16263 (initDocStruct): Changed the argument type docname to const.
16265 2019-01-06 Jiewen Tan <jiewen_tan@apple.com>
16267 [WebAuthN] Import U2F command/response converters from Chromium
16268 https://bugs.webkit.org/show_bug.cgi?id=193150
16269 <rdar://problem/47054028>
16271 Reviewed by Brent Fulgham.
16275 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16276 * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
16277 (TestWebKitAPI::getTestAttestedCredentialDataBytes):
16278 (TestWebKitAPI::getTestAuthenticatorDataBytes):
16279 (TestWebKitAPI::getTestAttestationObjectBytes):
16280 (TestWebKitAPI::getTestSignResponse):
16281 (TestWebKitAPI::getTestU2fRegisterResponse):
16282 (TestWebKitAPI::TEST):
16283 (TestWebKitAPI::convertToVector): Deleted.
16284 * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
16285 * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
16286 (TestWebKitAPI::constructMakeCredentialRequest):
16287 (TestWebKitAPI::constructGetAssertionRequest):
16288 (TestWebKitAPI::TEST):
16290 2019-01-05 Oriol Brufau <obrufau@igalia.com>
16292 [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
16293 https://bugs.webkit.org/show_bug.cgi?id=193136
16295 Reviewed by Michael Catanzaro.
16297 * gtk/install-dependencies:
16298 Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
16299 they are needed by update-webkitgtk-libs.
16301 2019-01-05 Aakash Jain <aakash_jain@apple.com>
16303 Unreviewed follow-up fix to r239650
16304 https://bugs.webkit.org/show_bug.cgi?id=193140
16305 <rdar://problem/47063037>
16307 Typecast patch_id to string.
16309 * BuildSlaveSupport/ews-build/steps.py:
16310 (ValidatePatch._is_patch_obsolete):
16312 2019-01-04 Daniel Bates <dabates@apple.com>
16314 [lldb-webkit]: Add support for pretty-printing raw bitmask types
16315 https://bugs.webkit.org/show_bug.cgi?id=193024
16317 Reviewed by Jer Noble.
16319 Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
16320 for the bitmask type WebEventFlags as an example.
16322 Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
16323 that can be used to register summary and synthetic child formatters for a bitmask type.
16324 For example, consider the following enum and bitmask typedefs:
16330 } SpecialFlagValues;
16331 typedef unsigned SpecialFlags;
16333 To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
16334 __lldb_init_module():
16336 addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
16342 * lldb/lldb_webkit.py:
16343 (addSummaryAndSyntheticFormattersForRawBitmaskType):
16344 (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
16345 (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
16346 (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
16347 A convenience function to dynamically creaste a synthetic formatter class and summary
16348 string function for the specified bitmask type and enumerator value to name map. This
16349 function register the dynamically created class and function with LLDB.
16351 (__lldb_init_module):
16352 (FlagEnumerationProvider):
16353 (FlagEnumerationProvider._enumerator_value_to_name_map):
16354 (FlagEnumerationProvider._bitmask):
16355 (FlagEnumerationProvider._update):
16356 (FlagEnumerationProvider.has_children):
16357 (FlagEnumerationProvider.num_children):
16358 (FlagEnumerationProvider.get_child_index):
16359 (FlagEnumerationProvider.get_child_at_index):
16360 (FlagEnumerationProvider.update):
16361 Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
16363 (WTFOptionSetProvider):
16364 (WTFOptionSetProvider._enumerator_value_to_name_map):
16365 (WTFOptionSetProvider._bitmask):
16366 (WTFOptionSetProvider._update):
16367 Write in terms of the base class.
16369 (RawBitmaskProviderBase):
16370 (RawBitmaskProviderBase._enumerator_value_to_name_map):
16371 (RawBitmaskProviderBase._bitmask):
16372 Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
16373 override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
16379 It is not necessary to instantiate such a derived class directory. Instead use the convenience
16380 function addSummaryAndSyntheticFormattersForRawBitmaskType.
16382 (WTFOptionSetProvider.has_children): Deleted.
16383 (WTFOptionSetProvider.num_children): Deleted.
16384 (WTFOptionSetProvider.get_child_index): Deleted.
16385 (WTFOptionSetProvider.get_child_at_index): Deleted.
16386 (WTFOptionSetProvider.update): Deleted.
16388 2019-01-04 Aakash Jain <aakash_jain@apple.com>
16390 [ews-build] Add build step to validate the patch before processing it
16391 https://bugs.webkit.org/show_bug.cgi?id=193140
16393 Reviewed by Lucas Forschler.
16395 * BuildSlaveSupport/ews-build/factories.py:
16396 (Factory.__init__): Added ValidatePatch step.
16397 * BuildSlaveSupport/ews-build/steps.py:
16399 (ValidatePatch.fetch_data_from_url): Fetch data from a url.
16400 (ValidatePatch.get_patch_json): Get patch json data.
16401 (ValidatePatch.get_bug_json): Get bug json data.
16402 (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
16403 (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
16404 (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
16405 (ValidatePatch._is_bug_closed): Check if the bug is already closed.
16406 (ValidatePatch.skip_build): Skip the build.
16407 (ValidatePatch.start):
16409 2019-01-04 Alex Christensen <achristensen@webkit.org>
16411 Progress towards fixing Mac CMake build
16412 https://bugs.webkit.org/show_bug.cgi?id=193105
16414 Reviewed by Don Olmstead.
16416 * TestWebKitAPI/PlatformMac.cmake:
16418 2019-01-04 Alex Christensen <achristensen@webkit.org>
16420 Fix API test after r239631
16421 https://bugs.webkit.org/show_bug.cgi?id=193118
16423 * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
16424 (TestWebKitAPI::TEST):
16425 This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
16426 Do the same thing via the API to fix the test.
16428 2019-01-04 Jer Noble <jer.noble@apple.com>
16430 [WebKitLegacy] Media playback pauses on scroll
16431 https://bugs.webkit.org/show_bug.cgi?id=192829
16433 Reviewed by Eric Carlson.
16435 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16436 * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
16437 (TestWebKitAPI::TEST):
16438 * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
16439 (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
16440 (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
16441 (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
16442 (TestWebKitAPI::TEST):
16444 2019-01-04 Chris Dumez <cdumez@apple.com>
16446 Add support for toggling device orientation API support per site
16447 https://bugs.webkit.org/show_bug.cgi?id=193143
16448 <rdar://problem/46605724>
16450 Reviewed by Alex Christensen.
16452 Add API test coverage.
16454 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
16455 (-[DataMappingSchemeHandler setTaskHandler:]):
16456 (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
16457 (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
16458 (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
16459 (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
16461 2019-01-04 Aakash Jain <aakash_jain@apple.com>
16463 [ews-build] use svn-apply script to apply the patches
16464 https://bugs.webkit.org/show_bug.cgi?id=193138
16466 Reviewed by Lucas Forschler.
16468 * BuildSlaveSupport/ews-build/factories.py:
16469 (Factory.__init__): Add the ApplyPatch step.
16470 * BuildSlaveSupport/ews-build/steps.py:
16471 (CheckOutSource): Added step name.
16472 (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
16473 (ApplyPatch): Build step to apply patch using svn-apply script.
16474 (UnApplyPatchIfRequired):
16475 (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
16477 2019-01-04 Alex Christensen <achristensen@webkit.org>
16479 Deprecate WKContextCreate
16480 https://bugs.webkit.org/show_bug.cgi?id=193118
16482 Reviewed by Brady Eidson.
16484 * MiniBrowser/win/WebKitBrowserWindow.cpp:
16485 (WebKitBrowserWindow::WebKitBrowserWindow):
16486 * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
16487 (TestWebKitAPI::TEST):
16488 * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
16489 (TestWebKitAPI::TEST):
16490 * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
16491 (TestWebKitAPI::TEST):
16492 * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
16493 (TestWebKitAPI::TEST):
16494 * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
16495 (TestWebKitAPI::TEST):
16496 * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
16497 (TestWebKitAPI::TEST):
16498 * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
16499 (TestWebKitAPI::TEST):
16500 * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
16501 (TestWebKitAPI::TEST):
16502 * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
16503 (TestWebKitAPI::TEST):
16504 * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
16505 (TestWebKitAPI::TEST):
16506 * TestWebKitAPI/Tests/WebKit/Find.cpp:
16507 (TestWebKitAPI::TEST):
16508 * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
16509 (TestWebKitAPI::TEST):
16510 * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
16511 (TestWebKitAPI::TEST):
16512 * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
16513 (TestWebKitAPI::TEST):
16514 * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
16515 (TestWebKitAPI::TEST):
16516 * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
16517 (TestWebKitAPI::TEST):
16518 * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
16519 (TestWebKitAPI::TEST):
16520 * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
16521 (TestWebKitAPI::TEST):
16522 * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
16523 (TestWebKitAPI::loadAlternateHTMLString):
16524 * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
16525 (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
16526 * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
16527 (TestWebKitAPI::buildAndPerformTest):
16528 * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
16529 (TestWebKitAPI::TEST):
16530 * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
16531 (TestWebKitAPI::TEST):
16532 * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
16533 (TestWebKitAPI::TEST):
16534 * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
16535 (TestWebKitAPI::TEST):
16536 * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
16537 (TestWebKitAPI::TEST):
16538 * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
16539 (TestWebKitAPI::TEST):
16540 * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
16541 (TestWebKitAPI::TEST):
16542 * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
16543 (TestWebKitAPI::TEST):
16544 * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
16545 (TestWebKitAPI::TEST):
16546 * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
16547 (TestWebKitAPI::TEST):
16548 * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
16549 (TestWebKitAPI::TEST):
16550 * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
16551 (TestWebKitAPI::TEST):
16552 * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
16553 (TestWebKitAPI::TEST):
16554 * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
16555 (TestWebKitAPI::TEST):
16556 * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
16557 (TestWebKitAPI::TEST):
16558 * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
16559 (TestWebKitAPI::TEST):
16560 * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
16561 (TestWebKitAPI::TEST):
16562 * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
16563 (TestWebKitAPI::TEST):
16564 * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
16565 (TestWebKitAPI::TEST):
16566 * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
16567 (TestWebKitAPI::TEST):
16568 * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
16569 (TestWebKitAPI::TEST):
16570 * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
16571 (TestWebKitAPI::TEST):
16572 * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
16573 (TestWebKitAPI::TEST):
16574 * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
16575 (TestWebKitAPI::TEST):
16576 * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
16577 (TestWebKitAPI::TEST):
16578 * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
16579 (TestWebKitAPI::TEST):
16580 * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
16581 (WebKit2_CommandBackForwardTestWKView::SetUp):
16582 * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
16583 (TestWebKitAPI::TEST):
16584 * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
16585 (TestWebKitAPI::TEST):
16586 * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
16587 (TestWebKitAPI::TEST):
16588 * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
16589 (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
16591 2019-01-03 Matt Rajca <mrajca@apple.com>
16593 Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
16594 https://bugs.webkit.org/show_bug.cgi?id=193128
16597 Reviewed by Jer Noble.
16599 Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
16600 media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
16601 event along with a flag that indicates whether or not autoplay was actually prevented.
16603 Tests: existing API tests were updated to reflect the new names. New API tests
16604 were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
16606 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16607 * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
16608 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
16610 * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
16611 * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
16613 2019-01-04 Chris Dumez <cdumez@apple.com>
16615 [PSON] Calling history.back() from inside the load event handler prevents process-swapping
16616 https://bugs.webkit.org/show_bug.cgi?id=193120
16618 Reviewed by Alex Christensen.
16620 Add API test coverage.
16622 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
16624 2019-01-04 Chris Dumez <cdumez@apple.com>
16626 Crash under WebProcessPool::addSuspendedPage()
16627 https://bugs.webkit.org/show_bug.cgi?id=193110
16629 Reviewed by Youenn Fablet.
16631 Add API test coverage.
16633 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
16635 2019-01-04 Aakash Jain <aakash_jain@apple.com>
16637 [ews-build] Check patch relevance before applying the patch
16638 https://bugs.webkit.org/show_bug.cgi?id=193102
16640 Reviewed by Lucas Forschler.
16642 * BuildSlaveSupport/ews-build/factories.py:
16643 (Factory.__init__): Moved CheckPatchRelevance step to base class.
16645 2019-01-04 Aakash Jain <aakash_jain@apple.com>
16647 [ews-build] Check patch relevance step should print patch id
16648 https://bugs.webkit.org/show_bug.cgi?id=193137
16650 Reviewed by Lucas Forschler.
16652 * BuildSlaveSupport/ews-build/steps.py:
16653 (CheckPatchRelevance.start): Update the status to include patch id.
16655 2019-01-04 Jonathan Bedard <jbedard@apple.com>
16657 webkitpy: Increase simulator teardown timeout
16658 https://bugs.webkit.org/show_bug.cgi?id=193141
16659 <rdar://problem/46174217>
16661 Rubber-stamped by Aakash Jain.
16663 * Scripts/webkitpy/xcode/simulated_device.py:
16664 (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
16666 2019-01-03 Ross Kirsling <ross.kirsling@sony.com>
16668 test262-runner misbehaves when test file YAML has a trailing space
16669 https://bugs.webkit.org/show_bug.cgi?id=193053
16671 Reviewed by Yusuke Suzuki.
16673 * Scripts/test262/Runner.pm:
16675 Accept trailing space when parsing a test file's YAML block.
16677 2019-01-03 Michael Catanzaro <mcatanzaro@igalia.com>
16679 UserMedia test should use WKPageNavigationClient
16680 https://bugs.webkit.org/show_bug.cgi?id=192913
16682 Reviewed by Youenn Fablet.
16684 The test currently uses the deprecated WKPageLoaderClient. It should use
16685 WKPageNavigationClient instead, which provides the same callback under a similar name.
16687 * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
16688 (TestWebKitAPI::TEST):
16690 2019-01-02 Alex Christensen <achristensen@webkit.org>
16692 Homograph with LATIN SMALL LETTER R WITH FISHHOOK
16693 https://bugs.webkit.org/show_bug.cgi?id=192944
16695 Reviewed by Tim Horton.
16697 * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
16698 (TestWebKitAPI::TEST):
16700 2019-01-02 Wenson Hsieh <wenson_hsieh@apple.com>
16702 Add support for using the current text selection as the find string on iOS
16703 https://bugs.webkit.org/show_bug.cgi?id=193034
16704 <rdar://problem/45138739>
16706 Reviewed by Tim Horton.
16708 Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
16709 _setStringForFind) works as expected.
16711 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16712 * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
16714 2019-01-02 Aakash Jain <aakash_jain@apple.com>
16716 [ews-build] Use git on OpenSource EWS bots
16717 https://bugs.webkit.org/show_bug.cgi?id=193092
16719 Reviewed by Lucas Forschler.
16721 * BuildSlaveSupport/ews-build/steps.py:
16722 (CheckOutSource): Use git instead of svn.
16723 (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
16725 2019-01-02 Daniel Bates <dabates@apple.com>
16727 [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
16728 https://bugs.webkit.org/show_bug.cgi?id=193023
16730 Reviewed by Simon Fraser.
16732 The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
16733 not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
16734 enumerator values. We should just remove this code.
16736 * lldb/lldb_webkit.py:
16737 (WTFOptionSetProvider.has_children):
16738 (WTFOptionSetProvider.num_children):
16739 (WTFOptionSetProvider.get_child_index):
16740 (WTFOptionSetProvider.get_child_at_index):
16742 2018-12-29 Yusuke Suzuki <yusukesuzuki@slowstart.org>
16744 .ycm_extra_conf.py should handle XXXInlines.h
16745 https://bugs.webkit.org/show_bug.cgi?id=193055
16747 Reviewed by Carlos Garcia Campos.
16749 compile_commands.json database only records flags and options for cpp source files.
16750 So, when we open headers, this database does not have any information for that.
16751 Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
16752 But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
16753 This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
16754 we attempt to find XXX.cpp and use the configuration if it exists.
16756 * gtk/ycm_extra_conf.py:
16757 (getImplementationFilename):
16760 2018-12-31 Carlos Garcia Campos <cgarcia@igalia.com>
16762 Unreviewed. Support PHP 7.3 in Debian.
16764 Add 7.3 to the list of php versions supported in Debian.
16766 * Scripts/webkitpy/port/base.py:
16767 (Port._debian_php_version):
16769 2018-12-27 Alex Christensen <achristensen@webkit.org>
16771 Resurrect Mac CMake build
16772 https://bugs.webkit.org/show_bug.cgi?id=192658
16774 Reviewed by Yusuke Suzuki.
16776 * DumpRenderTree/PlatformMac.cmake:
16777 * MiniBrowser/mac/CMakeLists.txt:
16778 * TestWebKitAPI/PlatformMac.cmake:
16780 2018-12-26 Adrian Perez de Castro <aperez@igalia.com>
16782 [Tools] Remove references to Bison and Flex
16783 https://bugs.webkit.org/show_bug.cgi?id=193033
16785 Reviewed by Michael Catanzaro.
16787 The Bison and Flex tools are not needed anymore since r209883.
16789 * CygwinDownloader/cygwin-downloader.py:
16790 * EWSTools/ubuntu-ews-packages:
16791 * Scripts/filter-build-webkit:
16792 (shouldIgnoreLine):
16793 * gtk/install-dependencies:
16794 * wpe/install-dependencies:
16796 2018-12-22 Carlos Garcia Campos <cgarcia@igalia.com>
16798 WebDriver: warn about non existing tests when parsing expectations
16799 https://bugs.webkit.org/show_bug.cgi?id=192979
16801 Reviewed by Michael Catanzaro.
16803 It's common to update web driver tests and forget updating the test expectations in case of tests removed or
16806 * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
16807 (WebDriverTestRunner.__init__):
16809 2018-12-21 Chris Dumez <cdumez@apple.com>
16811 navigator.userAgent in service workers does not reflect customUserAgent set by client
16812 https://bugs.webkit.org/show_bug.cgi?id=192951
16814 Reviewed by Youenn Fablet.
16816 Extend API test coverage.
16818 * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
16819 (-[SWCustomUserAgentDelegate initWithUserAgent:]):
16820 (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
16821 (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
16822 (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
16824 2018-12-21 Jiewen Tan <jiewen_tan@apple.com>
16826 [WebAuthN] userPresence should always be true
16827 https://bugs.webkit.org/show_bug.cgi?id=192835
16828 <rdar://problem/46538788>
16830 Reviewed by Brent Fulgham.
16832 * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
16833 (TestWebKitAPI::TEST):
16835 2018-12-19 Simon Fraser <simon.fraser@apple.com>
16837 Add support to run-benchmark to use non-default copies of the browser apps
16838 https://bugs.webkit.org/show_bug.cgi?id=192905
16839 rdar://problem/46845840
16841 Reviewed by Dewei Zhu.
16843 Add support for a --browser-path argument to run-benchmark, which allows you to use
16844 a custom app bundle for a given browser (only implemented for Safari at present).
16846 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
16847 (BenchmarkRunner.__init__):
16848 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
16849 (BrowserDriver.__init__):
16850 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
16851 (BrowserDriverFactory.create):
16852 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
16853 (OSXBrowserDriver._launch_process):
16854 (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
16855 (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
16856 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
16857 (OSXChromeCanaryDriver.launch_url):
16858 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
16859 (OSXFirefoxNightlyDriver.launch_url):
16860 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
16861 (OSXSafariDriver.__init__):
16862 (OSXSafariDriver.launch_url):
16863 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
16865 (run_benchmark_plan):
16866 * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
16867 (WebServerBenchmarkRunner.__init__):
16868 * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
16869 (FakeBenchmarkRunner.__init__):
16871 2018-12-21 Jiewen Tan <jiewen_tan@apple.com>
16873 [WebAuthN] Import an APDU coder from Chromium
16874 https://bugs.webkit.org/show_bug.cgi?id=192949
16875 <rdar://problem/46879933>
16877 Reviewed by Brent Fulgham.
16879 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16880 * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
16881 (TestWebKitAPI::TEST):
16883 2018-12-21 Wenson Hsieh <wenson_hsieh@apple.com>
16885 Setting the file wrapper and content type of an attachment to a PDF should update its image
16886 https://bugs.webkit.org/show_bug.cgi?id=192984
16887 <rdar://problem/46798028>
16889 Reviewed by Tim Horton.
16891 Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
16892 PDF data correctly updates the image element.
16894 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
16896 2018-12-21 Michael Catanzaro <mcatanzaro@igalia.com>
16898 Add JSCOnly to bot dashboard
16899 https://bugs.webkit.org/show_bug.cgi?id=192964
16901 Reviewed by Alexey Proskuryakov.
16903 Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
16904 good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
16905 useful if they were not so secret, so add them.
16907 There appear to be no build-only bots, so the first column is blank. And of course there are
16908 no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
16909 blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
16910 and there's plenty of room in the final column for all the bots.
16912 I had a hard time picking a logo to use, because the JavaScript language does not have an
16913 official logo. But I believe I've found one that will be satisfactory.
16915 I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
16917 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
16918 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
16919 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
16920 (BubbleQueueServer):
16921 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
16922 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
16924 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
16925 (table.queue-grid tr.platform.linux-jsconly img.logo):
16927 2018-12-21 Benjamin Poulain <benjamin@webkit.org>
16929 <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
16930 https://bugs.webkit.org/show_bug.cgi?id=192821
16932 Reviewed by Chris Dumez.
16934 * DumpRenderTree/mac/DumpRenderTree.mm:
16935 (createWebViewAndOffscreenWindow):
16936 * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
16938 2018-12-20 Fujii Hironori <Hironori.Fujii@sony.com>
16940 [Win][Clang] Fix compilation warnings of DumpRenderTree
16941 https://bugs.webkit.org/show_bug.cgi?id=192924
16943 Reviewed by Alex Christensen.
16945 * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
16946 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
16947 (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
16948 * DumpRenderTree/win/DumpRenderTree.cpp:
16949 (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
16950 (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
16951 object to the argument of setDefaultTextEncodingName instead of a
16952 const string literal.
16953 (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
16954 (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
16955 (setCacheFolder): Deleted.
16956 * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
16957 * DumpRenderTree/win/EditingDelegate.cpp:
16958 (dump): Use %d for int.
16959 * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
16960 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
16961 (BSTRFromString): Deleted unused function.
16962 * DumpRenderTree/win/TestRunnerWin.cpp:
16963 (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
16964 the arguemnt of setQuota instead of const string literal.
16965 * DumpRenderTree/win/WorkQueueItemWin.cpp:
16966 (jsStringRefToWString): Deleted unused function.
16968 2018-12-20 Chris Dumez <cdumez@apple.com>
16970 Add API test coverage for customUserAgent client setting and service workers
16971 https://bugs.webkit.org/show_bug.cgi?id=192952
16973 Reviewed by Alex Christensen.
16975 * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
16976 (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
16977 (-[SWSchemes webView:startURLSchemeTask:]):
16978 (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
16979 (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
16981 2018-12-20 Chris Dumez <cdumez@apple.com>
16983 Use Optional::hasValue() instead of Optional::has_value()
16984 https://bugs.webkit.org/show_bug.cgi?id=192948
16986 Reviewed by Tim Horton.
16988 * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
16989 (TestWebKitAPI::TEST):
16990 * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
16991 (TestWebKitAPI::TEST):
16992 * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
16993 (TestWebKitAPI::TEST_F):
16995 2018-12-20 Chris Dumez <cdumez@apple.com>
16997 Add style script rule to check for uses of std::optional<>
16998 https://bugs.webkit.org/show_bug.cgi?id=192931
17000 Reviewed by Tim Horton.
17002 * Scripts/webkitpy/style/checkers/cpp.py:
17003 (check_wtf_optional):
17006 2018-12-20 Jiewen Tan <jiewen_tan@apple.com>
17008 [WebAuthN] Add a runtime flag for local authenticator
17009 https://bugs.webkit.org/show_bug.cgi?id=192792
17010 <rdar://problem/46798738>
17012 Reviewed by Brent Fulgham.
17014 * DumpRenderTree/TestOptions.cpp:
17015 (TestOptions::TestOptions):
17016 * DumpRenderTree/TestOptions.h:
17017 * DumpRenderTree/mac/DumpRenderTree.mm:
17018 (enableExperimentalFeatures):
17019 (setWebPreferencesForTestOptions):
17020 * WebKitTestRunner/TestController.cpp:
17021 (WTR::TestController::resetPreferencesToConsistentValues):
17022 (WTR::updateTestOptionsFromTestHeader):
17023 * WebKitTestRunner/TestOptions.h:
17024 (WTR::TestOptions::hasSameInitializationOptions const):
17026 2018-12-20 Jonathan Bedard <jbedard@apple.com>
17028 webkitpy: Autoinstall package URLs have changed
17029 https://bugs.webkit.org/show_bug.cgi?id=192909
17030 <rdar://problem/46860359>
17032 Rubber-stamped by Alexey Proskuryakov.
17034 PyPi urls have been moved around, we need to update our auto-installed packages.
17036 We should check for Selenium before asking PyPi for the latest version.
17038 * Scripts/webkitpy/thirdparty/__init__.py:
17039 (AutoinstallImportHook._install_mechanize): Update with new pypi url.
17040 (AutoinstallImportHook._install_keyring): Ditto.
17041 (AutoinstallImportHook._install_pep8): Ditto.
17042 (AutoinstallImportHook._install_mozlog): Ditto.
17043 (AutoinstallImportHook._install_mozprocess): Ditto.
17044 (AutoinstallImportHook._install_pytest_timeout): Ditto.
17045 (AutoinstallImportHook._install_pytest): Ditto.
17046 (AutoinstallImportHook._install_pylint): Ditto.
17047 (AutoinstallImportHook._install_buildbot): Ditto.
17048 (AutoinstallImportHook._install_coverage): Ditto.
17049 (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
17050 (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
17051 for new Selenium if the installed version isn't sufficient.
17052 (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
17054 2018-12-20 Chris Dumez <cdumez@apple.com>
17056 Use Optional::valueOr() instead of Optional::value_or()
17057 https://bugs.webkit.org/show_bug.cgi?id=192933
17059 Reviewed by Geoffrey Garen.
17061 * TestWebKitAPI/Tests/WTF/URLParser.cpp:
17062 (TestWebKitAPI::checkURL):
17063 (TestWebKitAPI::checkRelativeURL):
17064 (TestWebKitAPI::checkURLDifferences):
17065 (TestWebKitAPI::checkRelativeURLDifferences):
17066 * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
17067 (TestWebKitAPI::checkURL):
17069 2018-12-20 Ryan Haddad <ryanhaddad@apple.com>
17071 Unreviewed, rolling out r239417.
17073 Introduced two API test failures on macOS.
17075 Reverted changeset:
17077 "<rdar://problem/46194315> macOS: WebKit1 does not handle
17079 https://bugs.webkit.org/show_bug.cgi?id=192821
17080 https://trac.webkit.org/changeset/239417
17082 2018-12-20 Devin Rousso <drousso@apple.com>
17084 Web Inspector: UIString should take an optional key and description to aid localization
17085 https://bugs.webkit.org/show_bug.cgi?id=153962
17086 <rdar://problem/24542505>
17088 Reviewed by Brian Burg.
17090 * Scripts/extract-localizable-js-strings:
17092 2018-12-20 Tim Horton <timothy_horton@apple.com>
17094 Unparented WKWebView can't retrieve main resource data for a main frame plugin
17095 https://bugs.webkit.org/show_bug.cgi?id=192923
17096 <rdar://problem/46859068>
17098 Reviewed by Wenson Hsieh.
17100 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17101 * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
17102 Add a test ensuring that both parented and unparented WKWebViews can
17103 retrieve main resource data when loading a PDF.
17105 2018-12-20 Carlos Garcia Campos <cgarcia@igalia.com>
17107 [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
17108 https://bugs.webkit.org/show_bug.cgi?id=192852
17110 Reviewed by Michael Catanzaro.
17112 EmojiOne font was replaced by Noto Color Emoji.
17114 * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
17115 * gtk/jhbuild.modules:
17116 * wpe/jhbuild.modules:
17118 2018-12-19 Chris Dumez <cdumez@apple.com>
17120 wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
17121 https://bugs.webkit.org/show_bug.cgi?id=192728
17122 <rdar://problem/46746779>
17124 Reviewed by Geoff Garen.
17126 * DumpRenderTree/*:
17128 * TestRunnerShared/*:
17130 * WebGPUAPIStructure/*:
17131 * WebKitTestRunner/*:
17133 2018-12-19 Benjamin Poulain <benjamin@webkit.org>
17135 <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
17136 https://bugs.webkit.org/show_bug.cgi?id=192821
17138 Reviewed by Chris Dumez.
17140 * DumpRenderTree/mac/DumpRenderTree.mm:
17141 (createWebViewAndOffscreenWindow):
17143 2018-12-19 Alex Christensen <achristensen@webkit.org>
17145 Navigations away from the SafeBrowsing interstitial show a flash of old content
17146 https://bugs.webkit.org/show_bug.cgi?id=192676
17148 Reviewed by Chris Dumez.
17150 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
17151 (safeBrowsingView):
17153 (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
17155 2018-12-19 Adrian Perez de Castro <aperez@igalia.com>
17157 [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
17158 https://bugs.webkit.org/show_bug.cgi?id=192855
17160 Reviewed by Michael Catanzaro.
17162 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
17163 (WTR::TestController::notifyDone): Use the WPE implementation.
17164 (WTR::TestController::platformRunUntil): Use the WPE implementation.
17165 * WebKitTestRunner/wpe/TestControllerWPE.cpp:
17166 (WTR::TestController::platformRunUntil): Honor the condition flag.
17168 2018-12-19 Megan Gardner <megan_gardner@apple.com>
17170 Allow clients to set the navigator platform
17171 https://bugs.webkit.org/show_bug.cgi?id=192735
17173 Reviewed by Tim Horton.
17175 Add a test for setting a custom navigator platform.
17177 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
17178 (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
17179 (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
17181 2018-12-19 Truitt Savell <tsavell@apple.com>
17183 Unreviewed, rolling out r239358.
17185 Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
17186 crash on Debug bots
17188 Reverted changeset:
17190 "Clean up IndexedDB files between tests"
17191 https://bugs.webkit.org/show_bug.cgi?id=192796
17192 https://trac.webkit.org/changeset/239358
17194 2018-12-18 Wenson Hsieh <wenson_hsieh@apple.com>
17196 [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
17197 https://bugs.webkit.org/show_bug.cgi?id=192842
17198 <rdar://problem/46823586>
17200 Reviewed by Tim Horton.
17202 Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
17203 item provider when dragging a rich text selection.
17205 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
17207 2018-12-18 David Quesada <david_quesada@apple.com>
17209 REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
17210 https://bugs.webkit.org/show_bug.cgi?id=192810
17211 <rdar://problem/46812536>
17213 Reviewed by Alex Christensen.
17215 * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
17216 (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
17217 After releasing our reference to the web view, wait until the next turn of the runloop
17218 before checking that the originatingWebView has been zeroed, since the web view might
17219 still be referenced in the autorelease pool. This _WKDownload unit test isn't about
17220 testing general memory management of WKWebViews, only that _WKDownload does not retain
17221 its web view via the 'originatingWebView' property.
17223 2018-12-18 Sihui Liu <sihui_liu@apple.com>
17225 Clean up IndexedDB files between tests
17226 https://bugs.webkit.org/show_bug.cgi?id=192796
17228 Reviewed by Geoffrey Garen.
17230 * DumpRenderTree/mac/DumpRenderTree.mm:
17232 * WebKitTestRunner/TestController.cpp:
17233 (WTR::TestController::resetStateToConsistentValues):
17234 (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
17235 (WTR::RemoveAllIndexedDatabasesCallback):
17236 (WTR::TestController::ClearIndexedDatabases):
17237 * WebKitTestRunner/TestController.h:
17239 2018-12-18 Alex Christensen <achristensen@webkit.org>
17241 Fix API test introduced in r239339 on iOS.
17242 https://bugs.webkit.org/show_bug.cgi?id=192675
17244 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
17246 The iOS implementation of the safe browsing warning is a little different.
17247 It does some element creation when it is added to the window so it knows how big it is.
17248 To test these elements, we need to simulate adding it to the window.
17249 A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
17251 2018-12-18 Jonathan Bedard <jbedard@apple.com>
17253 webkitpy: Ignore device type for test when using --force
17254 https://bugs.webkit.org/show_bug.cgi?id=192786
17255 <rdar://problem/46794894>
17257 Reviewed by Daniel Bates.
17259 It is sometimes the case that a contributor will wish to run a test on a specific device,
17260 despite expectations which indicate a test should not be run on that device.
17262 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
17264 * Scripts/webkitpy/port/device_port.py:
17265 (DevicePort.default_child_processes): Strip device type information when using --force.
17266 (DevicePort.setup_test_run): Only allow incomplete match when using --force.
17268 2018-12-18 Alex Christensen <achristensen@webkit.org>
17270 WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
17271 https://bugs.webkit.org/show_bug.cgi?id=192675
17273 Reviewed by Geoffrey Garen.
17275 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
17279 (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
17280 (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
17282 2018-12-18 Chris Dumez <cdumez@apple.com>
17284 Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
17285 https://bugs.webkit.org/show_bug.cgi?id=192772
17287 Reviewed by Antti Koivisto.
17289 Add API test coverage.
17291 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
17293 2018-12-18 Philippe Normand <pnormand@igalia.com>
17295 Unreviewed, JHBuild GTK build fix attempt
17297 * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
17298 There's no ninja module either, it should be provided by the
17301 2018-12-17 Chris Dumez <cdumez@apple.com>
17303 Allow passing nil as session state to [WKWebView _restoreSessionState:]
17304 https://bugs.webkit.org/show_bug.cgi?id=192789
17305 <rdar://problem/46755277>
17307 Reviewed by Alex Christensen.
17309 Add API test coverage.
17311 * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
17314 2018-12-17 Simon Fraser <simon.fraser@apple.com>
17316 Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
17317 https://bugs.webkit.org/show_bug.cgi?id=192780
17318 rdar://problem/43394387
17320 Reviewed by Tim Horton.
17322 No need to set "AppleFontSmoothing" defaults for WK2.
17324 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
17325 (WTR::InjectedBundle::platformInitialize):
17327 2018-12-17 Jonathan Bedard <jbedard@apple.com>
17329 webkitpy: Handle case where stdout and stderr don't accept unicode
17330 https://bugs.webkit.org/show_bug.cgi?id=192775
17331 <rdar://problem/46497303>
17333 Reviewed by Stephanie Lewis.
17335 * Scripts/webkitpy/layout_tests/views/metered_stream.py:
17336 (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
17337 characters with '?'.
17338 * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
17339 (RegularTest.test_stream_with_encoding):
17341 2018-12-17 Daniel Bates <dabates@apple.com>
17343 Support concatenating StringView with other string types
17344 https://bugs.webkit.org/show_bug.cgi?id=177566
17346 Reviewed by Darin Adler.
17348 Add some tests to ensure we do not regress the number of allocations needed when performing
17349 string concatenation with string views.
17351 * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
17352 (TestWebKitAPI::TEST):
17354 2018-12-17 Commit Queue <commit-queue@webkit.org>
17356 Unreviewed, rolling out r239265 and r239274.
17357 https://bugs.webkit.org/show_bug.cgi?id=192765
17359 unorm_normalize is deprecated, and broke an internal build
17360 (Requested by Truitt on #webkit).
17362 Reverted changesets:
17364 "[GTK][WPE] Need a function to convert internal URI to display
17366 https://bugs.webkit.org/show_bug.cgi?id=174816
17367 https://trac.webkit.org/changeset/239265
17369 "Fix the Apple Internal Mac build with a newer SDK"
17370 https://trac.webkit.org/changeset/239274
17372 2018-12-17 Daniel Bates <dabates@apple.com>
17374 Implement UIScriptController::toggleCapsLock() for iOS
17375 https://bugs.webkit.org/show_bug.cgi?id=191815
17377 Reviewed by Andy Estes.
17379 Add support for toggling the caps lock state in WebKitTestRunner on iOS.
17381 * TestRunnerShared/UIScriptContext/UIScriptController.h:
17382 * WebKitTestRunner/TestController.cpp:
17383 (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
17384 before running a test. This ensures that the caps lock state does not persist between
17385 tests should a test enable caps lock and not disable it.
17386 * WebKitTestRunner/ios/HIDEventGenerator.mm:
17387 (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
17388 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
17389 (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
17390 create the event. Also substituted NSString* for const String& as the data type for the first
17391 two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
17393 (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
17394 (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
17396 2018-12-17 Daniel Bates <dabates@apple.com>
17398 [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
17399 https://bugs.webkit.org/show_bug.cgi?id=192633
17401 Reviewed by Wenson Hsieh.
17403 Update code to use the modern initializer.
17405 * DumpRenderTree/mac/EventSendingController.mm:
17406 (-[EventSendingController keyDown:withModifiers:withLocation:]):
17408 2018-12-17 Matt Lewis <jlewis3@apple.com>
17410 Unreviewed, rolling out r239254.
17412 This broke the Windows 10 Debug build
17414 Reverted changeset:
17416 "Replace many uses of String::format with more type-safe
17418 https://bugs.webkit.org/show_bug.cgi?id=192742
17419 https://trac.webkit.org/changeset/239254
17421 2018-12-17 David Kilzer <ddkilzer@apple.com>
17423 clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
17424 <https://webkit.org/b/192751>
17425 <rdar://problem/46771623>
17427 Reviewed by Daniel Bates.
17429 Change loop variables to const references to avoid unnecessary
17432 * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
17433 (-[LocalPasteboard pasteboardItems]):
17435 2018-12-17 Ms2ger <Ms2ger@igalia.com>
17437 [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
17438 https://bugs.webkit.org/show_bug.cgi?id=174816
17440 Reviewed by Michael Catanzaro.
17442 Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
17444 * TestWebKitAPI/CMakeLists.txt:
17445 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17446 * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
17447 (TestWebKitAPI::TEST):
17448 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
17449 (testURIForDisplayUnaffected):
17450 (testURIForDisplayAffected):
17453 * TestWebKitAPI/glib/CMakeLists.txt:
17455 2018-12-17 Carlos Garcia Campos <cgarcia@igalia.com>
17457 [WPE] Add API to notify about frame displayed view backend callback
17458 https://bugs.webkit.org/show_bug.cgi?id=192224
17460 Reviewed by Michael Catanzaro.
17462 Add a test case to check the new API.
17464 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
17465 (testWebViewFrameDisplayed):
17467 * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
17469 2018-12-16 Adrian Perez de Castro <aperez@igalia.com>
17471 Unreviewed build fix after r239253
17473 * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
17475 2018-12-15 Darin Adler <darin@apple.com>
17477 Use warning-ignoring macros more consistently and simply
17478 https://bugs.webkit.org/show_bug.cgi?id=192743
17480 Reviewed by Mark Lam.
17482 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
17483 (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
17484 * DumpRenderTree/mac/TextInputControllerMac.m:
17485 (-[TextInputController interpretKeyEvents:withSender:]): Use
17486 IGNORE_WARNINGS_BEGIN/END.
17487 * WebKitTestRunner/mac/EventSenderProxy.mm:
17488 (WTR::EventSenderProxy::mouseForceClick): Use
17489 IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
17490 (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
17491 (WTR::EventSenderProxy::mouseForceDown): Ditto.
17492 (WTR::EventSenderProxy::mouseForceUp): Ditto.
17493 (WTR::EventSenderProxy::mouseForceChanged): Ditto.
17495 2018-12-15 Darin Adler <darin@apple.com>
17497 Replace many uses of String::format with more type-safe alternatives
17498 https://bugs.webkit.org/show_bug.cgi?id=192742
17500 Reviewed by Mark Lam.
17502 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
17503 (WTR::cacheTestRunnerCallback): Use makeString.
17504 * WebKitTestRunner/TestController.cpp:
17505 (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
17506 (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
17508 2018-12-15 Adrian Perez de Castro <aperez@igalia.com>
17510 [WPE][GTK] Add libpsl to JHBuild module sets
17511 https://bugs.webkit.org/show_bug.cgi?id=192740
17513 Reviewed by Michael Catanzaro.
17515 * gtk/jhbuild.modules: Add libpsl module.
17516 * wpe/jhbuild.modules: Ditto.
17518 2018-12-14 Alexey Proskuryakov <ap@apple.com>
17520 Add a style checker rule for Xcode version macros use
17521 https://bugs.webkit.org/show_bug.cgi?id=192703
17523 Reviewed by Alex Christensen.
17525 * Scripts/webkitpy/style/checkers/cpp.py:
17526 (check_os_version_checks):
17529 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
17530 (WebKitStyleTest.test_os_version_checks):
17532 2018-12-14 Chris Dumez <cdumez@apple.com>
17534 [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
17535 https://bugs.webkit.org/show_bug.cgi?id=192704
17537 Reviewed by Geoffrey Garen.
17539 Extend existing API test to reproduce the problem.
17541 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
17543 2018-12-14 Chris Dumez <cdumez@apple.com>
17545 [PSON] WebsitePolicies are lost on process-swap
17546 https://bugs.webkit.org/show_bug.cgi?id=192694
17547 <rdar://problem/46715748>
17549 Reviewed by Brady Eidson.
17551 Extend existing API test to reproduce the issue.
17553 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
17555 2018-12-14 Michael Catanzaro <mcatanzaro@igalia.com>
17557 [GTK] Error writing data to TLS socket in some sites when using the jhbuild
17558 https://bugs.webkit.org/show_bug.cgi?id=192678
17560 Reviewed by Carlos Garcia Campos.
17562 Update our ancient versions of libsoup and glib-networking.
17564 * gtk/install-dependencies:
17565 * gtk/jhbuild.modules:
17566 * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
17567 * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
17568 * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
17569 * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
17570 * wpe/install-dependencies:
17571 * wpe/jhbuild.modules:
17572 * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
17574 2018-12-14 Carlos Garcia Campos <cgarcia@igalia.com>
17576 [WPE] Use new view state API from libwpe
17577 https://bugs.webkit.org/show_bug.cgi?id=191906
17579 Reviewed by Žan Doberšek.
17581 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
17582 (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
17583 * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
17584 (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
17585 * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
17586 * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
17587 (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
17588 wpe_view_activity_state_focused state flags.
17589 (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
17590 * wpe/backends/HeadlessViewBackend.cpp:
17591 (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
17592 * wpe/backends/WindowViewBackend.cpp:
17593 (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
17594 received in configure callback.
17595 * wpe/jhbuild.modules: Bump libwpe to 1.1.0
17597 2018-12-13 Fujii Hironori <Hironori.Fujii@sony.com>
17599 [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
17600 https://bugs.webkit.org/show_bug.cgi?id=192688
17602 Reviewed by Ross Kirsling.
17604 * win/DLLLauncher/DLLLauncherMain.cpp:
17605 (copyEnvironmentVariable): Moved.
17606 (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
17607 (applePathFromRegistry): Ditto.
17608 (appleApplicationSupportDirectory): Ditto.
17609 (prependPath): Ditto.
17611 2018-12-13 Don Olmstead <don.olmstead@sony.com>
17613 Unreviewed. Changed my status to a reviewer.
17615 * Scripts/webkitpy/common/config/contributors.json:
17617 2018-12-13 Wenson Hsieh <wenson_hsieh@apple.com>
17619 [iOS] Support dropping contact card data (public.vcard) in editable content
17620 https://bugs.webkit.org/show_bug.cgi?id=192570
17621 <rdar://problem/35626913>
17623 Reviewed by Tim Horton.
17625 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
17627 Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
17628 attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
17629 additionally inserts a link).
17631 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
17632 (TestWebKitAPI::createMapItemForTesting):
17633 (TestWebKitAPI::createContactItemForTesting):
17635 Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
17636 expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
17637 there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
17638 dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
17641 2018-12-13 Ross Kirsling <ross.kirsling@sony.com>
17643 Unreviewed -- update my status to "reviewer".
17645 * Scripts/webkitpy/common/config/contributors.json:
17647 2018-12-13 Youenn Fablet <youenn@apple.com>
17649 On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
17650 https://bugs.webkit.org/show_bug.cgi?id=192657
17652 Reviewed by Eric Carlson.
17654 Add a test that loads a page registering ondevicechange,
17655 load another page in the same process, closes the first page.
17656 Ensure that the process does not crash in that case.
17658 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17659 * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
17660 (TestWebKitAPI::TEST):
17661 (TestWebKitAPI::didCrashCallback):
17662 * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
17664 2018-12-13 Carlos Eduardo Ramalho <cadubentzen@gmail.com>
17666 [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
17667 https://bugs.webkit.org/show_bug.cgi?id=192643
17669 Reviewed by Philippe Normand.
17671 This problem happens with Arch Linux users which have libfdk-2.0.0
17672 installed (which is anybody with gst-plugins-bad 1.14.4 installed).
17674 The problem has already been solved upstream at
17675 https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
17677 Adding patches while this problem is not in a release yet.
17679 * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
17680 * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
17681 * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
17683 2018-12-12 Carlos Garcia Campos <cgarcia@igalia.com>
17685 [FreeType] Add initial implementation of variation fonts
17686 https://bugs.webkit.org/show_bug.cgi?id=192151
17688 Reviewed by Michael Catanzaro.
17690 Add cairo patch to avoid crashes.
17692 * gtk/jhbuild.modules:
17693 * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
17695 2018-12-12 Fujii Hironori <Hironori.Fujii@sony.com>
17697 [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
17698 https://bugs.webkit.org/show_bug.cgi?id=192618
17700 Reviewed by Alex Christensen.
17702 * DumpRenderTree/win/DRTDataObject.cpp:
17703 * DumpRenderTree/win/DRTDataObject.h:
17704 * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
17705 * DumpRenderTree/win/DRTDropSource.h:
17706 * DumpRenderTree/win/EditingDelegate.h:
17707 * DumpRenderTree/win/PolicyDelegate.h:
17708 * DumpRenderTree/win/UIDelegate.h:
17710 2018-12-12 Ryosuke Niwa <rniwa@webkit.org>
17712 Make TextInputController.legacyAttributedString take DOM nodes and offsets
17713 https://bugs.webkit.org/show_bug.cgi?id=192653
17715 Reviewed by Wenson Hsieh.
17717 Updated TextInputController.legacyAttributedString to take DOM nodes and offsets instead of
17718 a DOM Range object in preparation to add layout tests for HTMLConverter which crosses
17721 * DumpRenderTree/mac/TextInputControllerMac.m:
17722 (+[TextInputController isSelectorExcludedFromWebScript:]): Updated the selector signature.
17723 (+[TextInputController webScriptNameForSelector:]): Ditto.
17724 (-[TextInputController legacyAttributedString:offset:to:offset:]): Made this function take
17725 start node and offset then end node and offset pairs.
17727 2018-12-12 Alex Christensen <achristensen@webkit.org>
17729 Implement safe browsing in WebKit on WatchOS
17730 https://bugs.webkit.org/show_bug.cgi?id=192641
17731 <rdar://problem/46376188>
17733 Reviewed by Geoff Garen.
17735 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
17736 (-[SafeBrowsingNavigationDelegate _webViewDidShowSafeBrowsingWarning:]):
17737 (safeBrowsingView):
17738 Add a test that the new delegate callback is called.
17740 2018-12-12 Michael Catanzaro <mcatanzaro@igalia.com>
17742 Unreviewed manual rollout of r239100-r239102 and r239116
17743 https://bugs.webkit.org/show_bug.cgi?id=192151
17744 <rdar://problem/46655586>
17746 * gtk/jhbuild.modules:
17747 * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Removed.
17749 2018-12-12 Commit Queue <commit-queue@webkit.org>
17751 Unreviewed, rolling out r239103.
17752 https://bugs.webkit.org/show_bug.cgi?id=192627
17754 It broke the built because it depends on another patch that
17755 didn't land yet (Requested by KaL on #webkit).
17757 Reverted changeset:
17759 "[WPE] Add API to notify about frame displayed view backend
17761 https://bugs.webkit.org/show_bug.cgi?id=192224
17762 https://trac.webkit.org/changeset/239103
17764 2018-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
17766 [WPE] Add API to notify about frame displayed view backend callback
17767 https://bugs.webkit.org/show_bug.cgi?id=192224
17769 Reviewed by Michael Catanzaro.
17771 Add a test case to check the new API.
17773 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
17774 (testWebViewFrameDisplayed):
17777 2018-12-12 Carlos Garcia Campos <cgarcia@igalia.com>
17779 [FreeType] Add initial implementation of variation fonts
17780 https://bugs.webkit.org/show_bug.cgi?id=192151
17782 Reviewed by Michael Catanzaro.
17784 Add cairo patch to avoid crashes.
17786 * gtk/jhbuild.modules:
17787 * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
17789 2018-12-11 Justin Michaud <justin_michaud@apple.com>
17791 Implement feature flag for CSS Typed OM
17792 https://bugs.webkit.org/show_bug.cgi?id=192610
17794 Reviewed by Ryosuke Niwa.
17796 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
17798 2018-12-11 Chris Dumez <cdumez@apple.com>
17800 Unreviewed, fix bad check in API test added in r239080.
17802 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
17804 2018-12-11 Fujii Hironori <Hironori.Fujii@sony.com>
17806 [Win][Clang] Fix warning -Wmissing-field-initializers
17807 https://bugs.webkit.org/show_bug.cgi?id=192584
17809 Reviewed by Yusuke Suzuki.
17811 Initialize a struct with '{ }' instead of '= {0}'.
17813 * DumpRenderTree/win/DumpRenderTree.cpp:
17815 * DumpRenderTree/win/EventSender.cpp:
17817 (replaySavedEvents):
17818 (beginDragWithFilesCallback):
17819 * DumpRenderTree/win/PixelDumpSupportWin.cpp:
17820 (createBitmapContextFromWebView):
17821 * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
17822 (updateMenuItemForHistoryItem):
17823 * MiniBrowser/win/WinMain.cpp:
17825 * TestWebKitAPI/win/HostWindow.cpp:
17826 (TestWebKitAPI::HostWindow::clientRect const):
17827 (TestWebKitAPI::HostWindow::registerWindowClass):
17828 * TestWebKitAPI/win/PlatformWebViewWin.cpp:
17829 (TestWebKitAPI::PlatformWebView::registerWindowClass):
17830 * WebKitTestRunner/win/PlatformWebViewWin.cpp:
17831 (WTR::registerWindowClass):
17832 (WTR::PlatformWebView::windowFrame):
17833 (WTR::PlatformWebView::windowSnapshotImage):
17835 2018-12-11 Chris Dumez <cdumez@apple.com>
17837 PSON logic gets confused by concurrent decidePolicyForNavigationAction requests
17838 https://bugs.webkit.org/show_bug.cgi?id=192482
17839 <rdar://problem/46470145>
17841 Reviewed by Antti Koivisto.
17843 Add API test coverage.
17845 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
17847 2018-12-11 Andy Estes <aestes@apple.com>
17849 Introduce makeBlockPtr for lambdas
17850 https://bugs.webkit.org/show_bug.cgi?id=192594
17852 Reviewed by Alex Christensen.
17854 Adopted makeBlockPtr and added API tests.
17856 * DumpRenderTree/TestRunner.cpp:
17857 (TestRunner::callUIScriptCallback):
17858 * TestWebKitAPI/Tests/WTF/BlockPtr.mm:
17859 (TestWebKitAPI::TEST):
17860 * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
17861 (-[DownloadProgressTestRunner init]):
17862 (-[DownloadProgressTestRunner subscribeAndWaitForProgress]):
17864 2018-12-11 Chris Dumez <cdumez@apple.com>
17866 REGRESSION (r238764-238783): TestWTF.WTF.StringOperators is failing
17867 https://bugs.webkit.org/show_bug.cgi?id=192361
17868 <rdar://problem/46524903>
17870 Reviewed by Alex Christensen.
17872 Compile StringOperators.cpp with -O1 optimization level instead of -Os. This
17873 fixes the failures for me locally.
17875 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17877 2018-12-11 Philippe Normand <pnormand@igalia.com>
17879 Unreviewed, WPE build fix after r239028
17881 The FLATPAK_USER_DIR env var is not set early enough, leading to:
17883 Traceback (most recent call last):
17884 File "/home/phil/WebKit/Tools/Scripts/webkit-flatpak", line 28, in <module>
17885 sys.exit(WebkitFlatpak.load_from_args().run())
17886 File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 761, in run
17887 if not self.clean_args():
17888 File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 574, in clean_args
17889 _log.debug("Using flatpak user dir: %s" % os.environ["FLATPAK_USER_DIR"])
17890 File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__
17891 raise KeyError(key)
17892 KeyError: 'FLATPAK_USER_DIR'
17894 * flatpak/flatpakutils.py:
17895 (WebkitFlatpak.clean_args):
17897 2018-12-10 Don Olmstead <don.olmstead@sony.com>
17899 Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
17900 https://bugs.webkit.org/show_bug.cgi?id=192573
17902 Reviewed by Simon Fraser.
17904 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
17906 2018-12-10 Don Olmstead <don.olmstead@sony.com>
17908 [CMake] Add ENABLE_RESOURCE_LOAD_STATISTICS to WebKitFeatures.cmake
17909 https://bugs.webkit.org/show_bug.cgi?id=192574
17911 Reviewed by Michael Catanzaro.
17913 * Scripts/webkitperl/FeatureList.pm:
17915 2018-12-10 Don Olmstead <don.olmstead@sony.com>
17917 Sync FeatureList.pm
17918 https://bugs.webkit.org/show_bug.cgi?id=192565
17920 Reviewed by Michael Catanzaro.
17922 * Scripts/webkitperl/FeatureList.pm:
17924 2018-12-10 Wenson Hsieh <wenson_hsieh@apple.com>
17926 [iOS] Unable to upload data that conforms to "public.item" but not "public.content"
17927 https://bugs.webkit.org/show_bug.cgi?id=192555
17928 <rdar://problem/35204990>
17930 Reviewed by Tim Horton.
17932 Add a test to verify that `.p12` files may be uploaded as files via drag and drop. "com.rsa.pkcs-12" is an
17933 example of a data type that conforms to "public.item", but not "public.content"; before this patch, we would
17934 only support uploading "public.content", so files such as these would not be accepted when dropping into file
17935 inputs, or be exposed as files on DataTransfer.
17937 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
17938 (TestWebKitAPI::TEST):
17940 2018-12-10 David Kilzer <ddkilzer@apple.com>
17942 Injected bundle for WebKitTestRunner leaks WKTypeRef objects
17943 <https://webkit.org/b/192481>
17944 <rdar://problem/46539059>
17946 Follow-up to address Darin's feedback.
17948 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
17949 (WTR::TestRunner::shouldDumpPixels const):
17950 (WTR::TestRunner::whatToDump const):
17951 (WTR::TestRunner::shouldWaitUntilDone const):
17952 (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
17953 (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
17954 (WTR::TestRunner::secureEventInputIsEnabled const):
17955 (WTR::TestRunner::isStatisticsPrevalentResource):
17956 (WTR::TestRunner::isStatisticsVeryPrevalentResource):
17957 (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
17958 (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
17959 (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
17960 (WTR::TestRunner::isStatisticsHasHadUserInteraction):
17961 (WTR::TestRunner::isStatisticsGrandfathered):
17962 (WTR::TestRunner::hasDOMCache):
17963 (WTR::TestRunner::keyExistsInKeychain):
17965 2018-12-10 Jonathan Bedard <jbedard@apple.com>
17967 webkitpy: Ref tests don't respect platform specific expectations
17968 https://bugs.webkit.org/show_bug.cgi?id=192515
17969 <rdar://problem/46564839>
17971 Reviewed by Lucas Forschler.
17973 * Scripts/webkitpy/port/base.py:
17974 (Port._expected_baselines_for_suffixes): Accept multiple suffixes so ref tests can use this function.
17975 (Port.expected_baselines): Move implementation to _expected_baselines_for_suffixes.
17976 (Port.expected_filename): Remove irrelevant FIXME, code clean-up.
17977 (Port.reference_files): Instead of just searching a single directory, use _expected_baselines_for_suffixes to
17978 search all platform expectations as well.
17979 * Scripts/webkitpy/port/base_unittest.py:
17980 (test_ref_tests_platform_directory):
17982 2018-12-10 Chris Dumez <cdumez@apple.com>
17984 Add SPI to allow the client to set the user-agent at main frame level, from the UIProcess
17985 https://bugs.webkit.org/show_bug.cgi?id=192509
17986 <rdar://problem/46500832>
17988 Reviewed by Alex Christensen.
17990 Add API test coverage.
17992 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
17993 (-[DataMappingSchemeHandler addMappingFromURLString:toData:]):
17994 (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
17995 (-[DataMappingSchemeHandler webView:stopURLSchemeTask:]):
17996 (-[CustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
17997 (-[CustomUserAgentDelegate webView:didFinishNavigation:]):
17999 2018-12-10 Wenson Hsieh <wenson_hsieh@apple.com>
18001 [iOS] Caret is obscured by finger when dragging over an editable element
18002 https://bugs.webkit.org/show_bug.cgi?id=192499
18003 <rdar://problem/46570101>
18005 Reviewed by Tim Horton.
18007 Augment some existing API tests to check that the `precise` flag is either on or off on `UIDropProposal`.
18009 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
18010 * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
18011 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
18012 (-[DragAndDropSimulator _resetSimulatedState]):
18013 (-[DragAndDropSimulator lastKnownDropProposal]):
18015 Rename `currentDropProposal` to `lastKnownDropProposal`, and expose it as a readonly property.
18017 (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
18018 (-[DragAndDropSimulator _advanceProgress]):
18019 (-[DragAndDropSimulator setShowCustomActionSheetBlock:]):
18020 (-[DragAndDropSimulator showCustomActionSheetBlock]):
18021 (-[DragAndDropSimulator setConvertItemProvidersBlock:]):
18022 (-[DragAndDropSimulator convertItemProvidersBlock]):
18023 (-[DragAndDropSimulator setOverridePerformDropBlock:]):
18024 (-[DragAndDropSimulator overridePerformDropBlock]):
18025 (-[DragAndDropSimulator setOverrideDragUpdateBlock:]):
18026 (-[DragAndDropSimulator overrideDragUpdateBlock]):
18027 (-[DragAndDropSimulator setDropCompletionBlock:]):
18028 (-[DragAndDropSimulator dropCompletionBlock]):
18030 Refactor these properties to return and take normal Objective-C blocks, rather than `BlockPtr`s. However, use
18031 `BlockPtr` instance variables to manage the lifetimes of these blocks.
18033 (-[DragAndDropSimulator _webView:willUpdateDropProposalToProposal:forSession:]):
18034 (-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]): Deleted.
18036 Update this to use the new WebKit delegate hook for overriding the drop proposal.
18038 2018-12-10 Michael Catanzaro <mcatanzaro@igalia.com>
18040 [WPE][GTK] run-minibrowser improperly creates webkit-flatpak environment
18041 https://bugs.webkit.org/show_bug.cgi?id=190241
18043 Reviewed by Carlos Garcia Campos.
18045 run-minibrowser calls into webkit-flatpak to check if a flatpak environment is available.
18046 Currently this actually creates the directories needed for the flatpak environment. Fix it.
18048 * flatpak/flatpakutils.py:
18049 (WebkitFlatpak.clean_args):
18050 (WebkitFlatpak.run):
18052 2018-12-10 Michael Catanzaro <mcatanzaro@igalia.com>
18054 [GTK] Don't use the slice allocator
18055 https://bugs.webkit.org/show_bug.cgi?id=192360
18057 Reviewed by Carlos Garcia Campos.
18059 * MiniBrowser/gtk/main.c:
18060 (aboutDataRequestFree):
18061 (aboutDataRequestNew):
18063 2018-12-10 Tim Horton <timothy_horton@apple.com>
18065 WKWebView should support custom tintColor
18066 https://bugs.webkit.org/show_bug.cgi?id=192518
18067 <rdar://problem/37243261>
18069 Reviewed by Wenson Hsieh.
18071 * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
18072 (TestWebKitAPI::TEST):
18073 Add a test that tintColor affects UITextInputTraits' interaction colors.
18075 2018-12-09 Wenson Hsieh <wenson_hsieh@apple.com>
18077 [iOS] DragAndDropTests.RespectsExternalSourceFidelityRankings is flaky
18078 https://bugs.webkit.org/show_bug.cgi?id=192524
18080 Reviewed by Ryosuke Niwa.
18082 This test started failing on certain builds of iOS where UIKit now attempts to reveal the selection by scrolling
18083 (see <rdar://problem/28300343>). This API test simulates two drops from external sources, both from the point
18084 (300, 400) to (100, 300) in window coordinates. On these aforementioned builds of iOS, what happens is that the
18085 first drop inserts text that overflows the editable region by an enormous amount, which creates an extremely
18086 wide selection rect and increases the width of the document; revealing this selection causes the web view to
18087 scroll horizontally, such that the second attempt to simulate a drag from (300, 400) to (100, 300) fails, since
18088 these window coordinates no longer correspond to the drop destination element in the document.
18090 To fix this test, we simply mark the drop destination as `overflow: hidden` to ensure that we don't try and
18091 scroll horizontally after the first drop.
18093 * TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html:
18095 2018-12-08 Daniel Bates <dabates@apple.com>
18097 Fix lldb_webkit.py following r238771
18098 (https://bugs.webkit.org/show_bug.cgi?id=190234)
18100 Substitute WTFURLProvider for WebCoreURLProvider in one call site that was inadvertently
18103 * lldb/lldb_webkit.py:
18104 (WebCoreDocumentProvider.url):
18106 2018-12-07 Aakash Jain <aakash_jain@apple.com>
18108 [ews-build] check-patch-relevance failure should not mark the overall build as failure
18109 https://bugs.webkit.org/show_bug.cgi?id=192510
18111 Reviewed by Lucas Forschler.
18113 * BuildSlaveSupport/ews-build/steps.py:
18114 (CheckPatchRelevance.start):
18116 2018-12-07 Chris Dumez <cdumez@apple.com>
18118 ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
18119 https://bugs.webkit.org/show_bug.cgi?id=192362
18120 <rdar://problem/46460360>
18122 Reviewed by Ryosuke Niwa.
18124 Move the call to _setCookieAcceptPolicy *after* we've constructed a WKWebView and thus
18125 *after* we know for sure we have a network process to communicate the policy to.
18126 This should address the failures on iOS.
18128 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
18130 2018-12-07 Jiewen Tan <jiewen_tan@apple.com>
18132 Add keychain access entitlement to WebKitTestRunnerApp
18133 https://bugs.webkit.org/show_bug.cgi?id=192489
18134 <rdar://problem/45057952>
18136 Reviewed by Alexey Proskuryakov.
18138 * WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
18140 2018-12-07 Saam Barati <sbarati@apple.com>
18142 WKWebProcessPlugInLoadDelegate should have API for saying which rendering events it wants to listen for
18143 https://bugs.webkit.org/show_bug.cgi?id=192473
18145 Reviewed by Andy Estes.
18147 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
18148 * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgress.mm: Added.
18149 (-[DidFirstMeaningfulPaintRemoteObject didFirstMeaningfulPaint]):
18151 * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressPlugIn.mm: Added.
18152 (-[RenderingProgressPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
18153 (-[RenderingProgressPlugIn webProcessPlugInBrowserContextControllerRenderingProgressEvents:]):
18154 (-[RenderingProgressPlugIn webProcessPlugInBrowserContextController:renderingProgressDidChange:]):
18155 * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressProtocol.h: Added.
18157 2018-12-07 Jonathan Bedard <jbedard@apple.com>
18159 REGRESSION: run-webkit-tests may fail when using booted simulators (Follow-up fix)
18160 https://bugs.webkit.org/show_bug.cgi?id=192470
18161 <rdar://problem/46532001>
18163 Unreviewed infrastructure fix.
18165 * Scripts/webkitpy/port/device_port.py:
18166 (DevicePort.setup_test_run): Check that the number of initialized devices matches the
18167 number of child processes.
18169 2018-12-07 Aakash Jain <aakash_jain@apple.com>
18171 [ews-app] Send bug id as a build property
18172 https://bugs.webkit.org/show_bug.cgi?id=192494
18174 Reviewed by Lucas Forschler.
18176 * BuildSlaveSupport/ews-app/ews/fetcher.py:
18177 (BugzillaPatchFetcher.fetch):
18179 2018-12-07 Aakash Jain <aakash_jain@apple.com>
18181 [ews-build] Builds should have a link to patch and bug
18182 https://bugs.webkit.org/show_bug.cgi?id=192492
18184 Reviewed by Lucas Forschler.
18186 * BuildSlaveSupport/ews-build/steps.py:
18187 (ConfigureBuild.add_patch_id_url): Method to add Patch URL.
18188 (ConfigureBuild.add_bug_id_url): Method to add Bug URL.
18189 (ConfigureBuild.getPatchURL): Method to get Patch URL.
18190 (ConfigureBuild.getBugURL): Method to get Bug URL.
18192 2018-12-07 Aakash Jain <aakash_jain@apple.com>
18194 [ews-app] Configure logfile for ews-app logs
18195 https://bugs.webkit.org/show_bug.cgi?id=192493
18197 Reviewed by Lucas Forschler.
18199 * BuildSlaveSupport/ews-app/ews/__init__.py:
18201 2018-12-07 Aakash Jain <aakash_jain@apple.com>
18203 Style queue exception on some security bugs
18204 https://bugs.webkit.org/show_bug.cgi?id=190793
18206 Reviewed by Lucas Forschler.
18208 * Scripts/webkitpy/tool/steps/applywatchlist.py:
18209 (ApplyWatchList.run):
18211 2018-12-07 Wenson Hsieh <wenson_hsieh@apple.com>
18213 [Attachment Support] Cloned attachment elements lose their unique identifiers
18214 https://bugs.webkit.org/show_bug.cgi?id=192483
18216 Reviewed by Tim Horton.
18218 Introduce a new API test.
18220 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
18221 (TestWebKitAPI::TEST):
18223 2018-12-06 Jonathan Bedard <jbedard@apple.com>
18225 Consecutive DumpRenderTree crashes are happening again on WinCairo BuildBots since r238903
18226 https://bugs.webkit.org/show_bug.cgi?id=192486
18228 Unreviewed infrastructure fix.
18230 WinCairo bots define WEBKIT_TEST_CHILD_PROCESSES to run less processes due to RAM restrictions.
18232 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
18233 (_set_up_derived_options):
18235 2018-12-06 David Kilzer <ddkilzer@apple.com>
18237 Injected bundle for WebKitTestRunner leaks WKTypeRef objects
18238 <https://webkit.org/b/192481>
18239 <rdar://problem/46539059>
18241 Reviewed by Simon Fraser.
18244 - Fixes leaks in various injected bundle methods that return +1
18245 retained WKTypeRef objects via pointer.
18246 - Asserts the returned object is the expected WKTypeRef.
18247 - Replaces 0 with nullptr in many places.
18249 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
18250 (WTR::InjectedBundle::didCreatePage):
18251 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
18252 (WTR::TestRunner::shouldDumpPixels const):
18253 (WTR::TestRunner::whatToDump const):
18254 (WTR::TestRunner::shouldWaitUntilDone const):
18255 (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
18256 (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
18257 (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
18258 (WTR::TestRunner::secureEventInputIsEnabled const):
18259 (WTR::TestRunner::isStatisticsPrevalentResource):
18260 (WTR::TestRunner::isStatisticsVeryPrevalentResource):
18261 (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
18262 (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
18263 (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
18264 (WTR::TestRunner::isStatisticsHasHadUserInteraction):
18265 (WTR::TestRunner::isStatisticsGrandfathered):
18266 (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
18267 (WTR::TestRunner::statisticsUpdateCookieBlocking):
18268 (WTR::TestRunner::statisticsSubmitTelemetry):
18269 (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
18270 (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
18271 (WTR::TestRunner::statisticsResetToConsistentState):
18272 (WTR::TestRunner::getAllStorageAccessEntries):
18273 (WTR::TestRunner::hasDOMCache):
18274 (WTR::TestRunner::domCacheSize):
18275 (WTR::TestRunner::injectUserScript):
18276 (WTR::TestRunner::keyExistsInKeychain):
18278 2018-12-06 Jonathan Bedard <jbedard@apple.com>
18280 REGRESSION: run-webkit-tests may fail when using booted simulators
18281 https://bugs.webkit.org/show_bug.cgi?id=192470
18282 <rdar://problem/46532001>
18284 Reviewed by Lucas Forschler.
18286 * Scripts/webkitpy/layout_tests/controllers/manager.py:
18287 (Manager.run): Logging uses the number of child processes to print out information about how efficiently tests
18288 were sharded after the fact. This number is the most meaningful if it is the maximum number of child processes used.
18289 * Scripts/webkitpy/port/base.py:
18290 (Port.max_child_processes): By default, Ports do not support running on any specific kind of device.
18291 * Scripts/webkitpy/port/device_port.py:
18292 (DevicePort.default_child_processes): Rather than using the currently initialized devices as a proxy for how many
18293 child processes are being used, check the device manager every time. Regardless of which devices are attached or
18294 available, iOS cannot boot watchOS devices and vice-versa. dedicated_simulators is not a known argument to
18295 device_count_for_type, use use_booted_simulator instead.
18296 (DevicePort.max_child_processes): Simulators can boot more devices than what is specified by device_count_for_type,
18297 but, if no devices are available, then max_child_processes should return 0 even for simulators.
18298 * Scripts/webkitpy/port/ios_device_unittest.py:
18300 (IOSDeviceTest.test_max_child_processes):
18301 * Scripts/webkitpy/port/ios_simulator_unittest.py:
18302 (IOSSimulatorTest):
18303 (IOSSimulatorTest.test_max_child_processes):
18304 * Scripts/webkitpy/port/port_testcase.py:
18306 (PortTestCase.test_max_child_processes):
18307 * Scripts/webkitpy/port/watch_simulator_unittest.py:
18308 (WatchSimulatorTest):
18309 (WatchSimulatorTest.test_max_child_processes):
18311 2018-12-06 Jonathan Bedard <jbedard@apple.com>
18313 webkitpy: Ignore case when comparing device types (Follow-up fix)
18314 https://bugs.webkit.org/show_bug.cgi?id=192409
18315 <rdar://problem/46491558>
18317 Unreviewed typo fix.
18319 * Scripts/webkitpy/xcode/device_type_unittest.py:
18320 (DeviceTypeTest.test_comparison_lower_case):
18321 (DeviceTypeTest.test_comparsion_lower_case): Deleted.
18323 2018-12-06 Jonathan Bedard <jbedard@apple.com>
18325 webkitpy: Create device given lower-case DeviceType
18326 <https://bugs.webkit.org/show_bug.cgi?id=192472>
18327 <rdar://problem/46532650>
18329 Reviewed by Lucas Forschler.
18331 * Scripts/webkitpy/xcode/simulated_device.py:
18332 (SimulatedDeviceManager._get_device_identifier_for_type): Comparing simctl device identifiers with DeviceTypes
18333 should be letter-case agnostic.
18334 * Scripts/webkitpy/xcode/simulated_device_unittest.py:
18335 (test_lower_case_device_type):
18337 2018-12-06 Wenson Hsieh <wenson_hsieh@apple.com>
18339 [iOS] WKWebView should match UITextView behavior when editing text with an RTL keyboard
18340 https://bugs.webkit.org/show_bug.cgi?id=187554
18341 <rdar://problem/42075638>
18343 Reviewed by Tim Horton.
18345 Add support for simulating the keyboard input mode in layout tests using UIScriptController, as well as a new
18346 `TestOption` to make the web view editable.
18348 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
18349 (WTR::UIScriptController::setKeyboardInputModeIdentifier):
18350 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
18351 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
18352 (WTR::UIScriptController::setKeyboardInputModeIdentifier):
18353 * TestRunnerShared/UIScriptContext/UIScriptController.h:
18354 * WebKitTestRunner/PlatformWebView.h:
18355 * WebKitTestRunner/TestController.cpp:
18356 (WTR::updateTestOptionsFromTestHeader):
18357 * WebKitTestRunner/TestController.h:
18358 (WTR::TestController::overriddenKeyboardInputMode const):
18359 * WebKitTestRunner/TestOptions.h:
18360 (WTR::TestOptions::hasSameInitializationOptions const):
18361 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
18362 (WTR::TestController::platformCreateWebView):
18363 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
18364 (WTR::PlatformWebView::setEditable):
18365 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
18366 (WTR::PlatformWebView::setEditable):
18367 * WebKitTestRunner/ios/TestControllerIOS.mm:
18368 (WTR::TestController::platformResetStateToConsistentValues):
18369 (WTR::swizzleCurrentInputMode):
18370 (WTR::TestController::setKeyboardInputModeIdentifier):
18372 Swizzle out several `UIKeyboardInputModeController` methods in order to convince UIKit that the user has
18373 selected a `UIKeyboardInputMode` corresponding to the given identifier. The call to
18374 `-prepareKeyboardInputModeFromPreferences:` is also necessary on iOS 12 in order to update cached writing
18375 direction state in UIKit.
18377 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
18378 (WTR::UIScriptController::setKeyboardInputModeIdentifier):
18379 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
18380 (WTR::PlatformWebView::setEditable):
18381 * WebKitTestRunner/win/PlatformWebViewWin.cpp:
18382 (WTR::PlatformWebView::setEditable):
18383 * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
18384 (WTR::PlatformWebView::setEditable):
18386 2018-12-05 Wenson Hsieh <wenson_hsieh@apple.com>
18388 [Cocoa] Share ClassMethodSwizzler and InstanceMethodSwizzler between TestWebKitAPI and WebKitTestRunner
18389 https://bugs.webkit.org/show_bug.cgi?id=192437
18391 Reviewed by Tim Horton.
18393 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
18394 * TestRunnerShared/cocoa/ClassMethodSwizzler.h: Renamed from Tools/TestWebKitAPI/ClassMethodSwizzler.h.
18395 * TestRunnerShared/cocoa/ClassMethodSwizzler.mm: Renamed from Tools/TestWebKitAPI/ClassMethodSwizzler.mm.
18396 (ClassMethodSwizzler::ClassMethodSwizzler):
18397 (ClassMethodSwizzler::~ClassMethodSwizzler):
18398 * TestRunnerShared/cocoa/InstanceMethodSwizzler.h: Renamed from Tools/TestWebKitAPI/cocoa/InstanceMethodSwizzler.h.
18399 * TestRunnerShared/cocoa/InstanceMethodSwizzler.mm: Renamed from Tools/TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm.
18400 (InstanceMethodSwizzler::InstanceMethodSwizzler):
18401 (InstanceMethodSwizzler::~InstanceMethodSwizzler):
18403 Move these swizzling helper classes into TestRunnerShared.
18405 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
18406 * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
18407 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
18408 (safeBrowsingView):
18409 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDefaultNavigationDelegate.mm:
18410 * TestWebKitAPI/cocoa/TestWKWebView.mm:
18411 (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
18413 Remove namespacing around ClassMethodSwizzler and InstanceMethodSwizzler in a few API tests.
18415 * TestWebKitAPI/mac/TestFontOptions.mm:
18416 * WebKitTestRunner/TestController.h:
18417 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
18418 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
18419 (WTR::ClassMethodSwizzler::ClassMethodSwizzler): Deleted.
18420 (WTR::ClassMethodSwizzler::~ClassMethodSwizzler): Deleted.
18422 Remove this duplicate implementation of ClassMethodSwizzler in WebKitTestRunner.
18424 2018-12-05 Jonathan Bedard <jbedard@apple.com>
18426 webkitpy: Clean-up apple_additions
18427 https://bugs.webkit.org/show_bug.cgi?id=192413
18428 <rdar://problem/46493491>
18430 Reviewed by Lucas Forschler.
18432 After the addition of watchOS, some functions which were originally iOS specific were
18433 generalized to include all devices.
18435 * Scripts/webkitpy/port/ios_device.py:
18436 (IOSDevicePort._driver_class): Replace iOS specific call with generalized device call.
18437 (IOSDevicePort.path_to_crash_logs): Ditto.
18438 (IOSDevicePort.clean_up_test_run): Ditto.
18440 2018-12-05 Jonathan Bedard <jbedard@apple.com>
18442 webkitpy: Ignore case when comparing device types
18443 https://bugs.webkit.org/show_bug.cgi?id=192409
18444 <rdar://problem/46491558>
18446 Reviewed by Lucas Forschler.
18448 This allows DeviceTypes constructed with lowercase strings to correctly compare
18449 against DeviceTypes coming from the simulator runtime.
18451 * Scripts/webkitpy/xcode/device_type.py:
18452 (DeviceType.__eq__):
18453 (DeviceType.__contains__):
18454 * Scripts/webkitpy/xcode/device_type_unittest.py:
18456 (DeviceTypeTest.test_comparsion_lower_case):
18458 2018-12-05 Jonathan Bedard <jbedard@apple.com>
18460 webkitpy: Sort tests by associated device type
18461 https://bugs.webkit.org/show_bug.cgi?id=192161
18462 <rdar://problem/46345392>
18464 Reviewed by Lucas Forschler.
18466 Sort tests by device type and make an effort to run each specified device type.
18467 Do not run tests if their specified device is not available.
18469 * Scripts/webkitpy/common/system/platforminfo.py:
18470 (PlatformInfo.is_watchos): Add watchos bits to platform info.
18471 (PlatformInfo._determine_os_name): Ditto.
18472 * Scripts/webkitpy/layout_tests/controllers/manager.py:
18473 (Manager.run): Assign each test a device type. Then, generate a list of
18474 device types to sequentially iterate through. Note that a test will run
18475 on the first device which matches.
18476 (Manager._end_test_run): Handle the case where no devices are available and no
18478 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
18479 (_set_up_derived_options): Manage child processes in manager.
18480 * Scripts/webkitpy/port/base.py:
18482 (Port.default_child_processes): Accept additional arguments.
18483 (Port.max_child_processes): Add upper limit for number of child processes.
18484 * Scripts/webkitpy/port/device_port.py:
18486 (DevicePort._device_type_with_version): Adds version to the DeviceType.
18487 (DevicePort.default_child_processes): Allows default_child_processes to be
18488 attached to a device type.
18489 (DevicePort.max_child_processes): Add upper limit to the maximum number of child processes.
18490 (DevicePort.setup_test_run): Use _device_type_with_version.
18491 * Scripts/webkitpy/port/ios_device.py:
18493 (IOSDevicePort.default_child_processes): Deleted.
18494 * Scripts/webkitpy/port/ios_simulator.py:
18495 (IOSSimulatorPort.default_child_processes): Deleted.
18496 (IOSSimulatorPort.check_sys_deps): Deleted.
18497 * Scripts/webkitpy/port/mac.py:
18498 (MacPort.default_child_processes): Accept additional arguments.
18499 * Scripts/webkitpy/port/test.py:
18500 * Scripts/webkitpy/port/watch_device.py:
18502 (WatchDevicePort.default_child_processes): Deleted.
18503 * Scripts/webkitpy/port/watch_simulator.py:
18504 (WatchSimulatorPort.default_child_processes): Deleted.
18505 (WatchSimulatorPort.check_sys_deps): Deleted.
18506 * Scripts/webkitpy/xcode/simulated_device.py:
18507 (SimulatedDeviceManager):
18508 (SimulatedDeviceManager.device_count_for_type): Count the number of devices
18509 available for a specific device type.
18511 2018-12-05 Devin Rousso <drousso@apple.com>
18513 Unreviewed, add myself to some watch lists.
18515 * Scripts/webkitpy/common/config/watchlist:
18517 2018-12-05 Alicia Boya García <aboya@igalia.com>
18519 [MSE][GStreamer] Remove the AppendPipeline state machine
18520 https://bugs.webkit.org/show_bug.cgi?id=192204
18522 Reviewed by Xabier Rodriguez-Calvar.
18524 Updated AbortableTaskQueue tests:
18526 Added test: AbortedBySyncTaskHandler.
18528 Renamed test: AbortDuringSyncTask -> AbortBeforeSyncTaskRun (in
18529 order to avoid confusion with the new test).
18531 Added checks for the correct destruction of response objects.
18533 * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
18534 (TestWebKitAPI::FancyResponse::FancyResponse):
18535 (TestWebKitAPI::FancyResponse::~FancyResponse):
18536 (TestWebKitAPI::TEST):
18538 2018-12-04 Chris Dumez <cdumez@apple.com>
18540 ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
18541 https://bugs.webkit.org/show_bug.cgi?id=192362
18543 Reviewed by Alex Christensen.
18545 Set the cookie policy to Accept to make sure the cookies are saved.
18547 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
18549 2018-12-04 Michael Catanzaro <mcatanzaro@igalia.com>
18551 [WPE][GTK] Update GLib
18552 https://bugs.webkit.org/show_bug.cgi?id=191222
18554 Reviewed by Žan Doberšek.
18556 When I try running API tests locally, they crash with:
18558 GLib-GIO-WARNING **: unknown schema extension 'd'
18560 We need to update our old glib to support the 'd' value type, otherwise schemas that may
18561 exist on the host using this type will cause instant crashes.
18563 Also, switch the GLib build to use meson. This requires updating meson as well.
18565 * gtk/jhbuild.modules:
18566 * gtk/patches/glib-cast-function-type.patch: Removed.
18567 * gtk/patches/glib-gtester-do-not-consider-skipped-tests-as-failures.patch: Removed.
18568 * wpe/jhbuild.modules:
18569 * wpe/patches/glib-cast-function-type.patch: Removed.
18570 * wpe/patches/glib-revert-wakeup-changes.patch: Removed.
18572 2018-12-04 Aakash Jain <aakash_jain@apple.com>
18574 [ews-app] Run BugzillaPatchFetcher periodically
18575 https://bugs.webkit.org/show_bug.cgi?id=192241
18577 Reviewed by Lucas Forschler.
18579 * BuildSlaveSupport/ews-app/ews/__init__.py:
18580 * BuildSlaveSupport/ews-app/ews/apps.py:
18581 (EwsConfig.ready): This method is called by Django on startup.
18582 * BuildSlaveSupport/ews-app/ews/fetcher.py:
18583 (FetchLoop): Class which invokes BugzillaPatchFetcher every 60s.
18585 2018-12-04 Jonathan Bedard <jbedard@apple.com>
18587 webkitpy: Support unicode in MeteredStream
18588 https://bugs.webkit.org/show_bug.cgi?id=192260
18590 Reviewed by Aakash Jain.
18592 It's possible that the test runner returns unicode characters to be logged when
18593 running layout tests.
18595 * Scripts/webkitpy/layout_tests/views/metered_stream.py:
18596 (MeteredStream.write): Print message without attempting to encode/decode it.
18597 * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
18598 (RegularTest.test_unicode):
18600 2018-12-04 Keith Rollin <krollin@apple.com>
18602 Update scripts for generating .xcfilelist files
18603 https://bugs.webkit.org/show_bug.cgi?id=192081
18604 <rdar://problem/46312290>
18606 Reviewed by Brent Fulgham.
18608 The initial pass at generate-xcfilelists (a script for
18609 creating/updating the .xcfilelist files needed for various Generate
18610 Foo Source build phases in Xcode) only generated the .xcfilelist files
18611 that held the output files; it did not generate the list of input
18612 files. As well, for the sources generated by DerivedSources.make
18613 makefiles, the script accomplished this via the implementation of a
18614 convention in the makefile that allowed the printing of these output
18615 files when invoked with the 'print_all_generated_files' target. Use of
18616 this convention is inconvenient and error-prone.
18618 The script is now updated to address both of these issues. First, it
18619 generates for the input and output sets of files. Second, it does away
18620 with the convention in the DerivedSources.make makefiles and instead
18621 works from the dependency output information printed when `make` is
18622 invoked with --debug. This second part is implemented in the new
18623 script extract-dependencies-from-makefile.
18625 * Scripts/extract-dependencies-from-makefile: Added.
18629 (Parser.addTarget):
18630 (Parser.addPrereq):
18632 (Parser.printInputs):
18633 (Parser.printOutputs):
18636 * Scripts/generate-xcfilelists:
18638 2018-12-04 Carlos Eduardo Ramalho <cadubentzen@gmail.com>
18641 https://bugs.webkit.org/show_bug.cgi?id=178900
18643 Reviewed by Michael Catanzaro.
18645 Add gtk-doc to WPE port. This patch tries to reuse as much code from
18646 WebKitGTK+ as possible.
18648 * gtkdoc/generate-gtkdoc: Renamed from Tools/gtk/generate-gtkdoc.
18649 (get_gtkdoc_module_paths): Add GDK and GTK only if building for GTK.
18650 (prepare_environment_for_gtkdoc_generation):
18651 (build_gtkdoc_for_wpe): Code to generate doc for WPE.
18652 (build_gtkdoc_for_wkgtk): Code to generate doc for WebKitGTK+. Moved from main.
18653 * gtkdoc/gtkdoc.py: Renamed from Tools/gtk/gtkdoc.py.
18654 (GTKDoc.__init__): Initialized required variables according to pylint.
18655 (GTKDoc.api_missing_documentation):
18656 * wpe/install-dependencies: Add gtkdoc dependency.
18658 2018-12-04 Carlos Garcia Campos <cgarcia@igalia.com>
18660 [SOUP] Move URLSoup back to WebCore after r238771
18661 https://bugs.webkit.org/show_bug.cgi?id=192306
18663 Reviewed by Michael Catanzaro.
18665 Include GUniquePtrSoup from WebCore again.
18667 * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
18669 2018-12-03 Carlos Garcia Campos <cgarcia@igalia.com>
18671 [GTK] Bump freetype, fontconfig, harfbuzz, cairo and icu in jhbuild
18672 https://bugs.webkit.org/show_bug.cgi?id=192310
18674 Reviewed by Michael Catanzaro.
18676 Update those dependencies to their latest stable versions.
18678 * gtk/jhbuild.modules:
18680 2018-12-03 Tomas Popela <tpopela@redhat.com>
18682 [GTK] Can't run MiniBrowser due to missing python2-yaml
18683 https://bugs.webkit.org/show_bug.cgi?id=192308
18685 Reviewed by Michael Catanzaro.
18687 * gtk/install-dependencies:
18689 2018-12-03 Chris Dumez <cdumez@apple.com>
18691 Regression(PSON) Google OAuth is broken in private sessions
18692 https://bugs.webkit.org/show_bug.cgi?id=192337
18693 <rdar://problem/46353558>
18695 Reviewed by Alex Christensen.
18697 Add API test coverage.
18699 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
18700 * TestWebKitAPI/Tests/WebKitCocoa/GetSessionCookie.html: Added.
18701 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
18702 * TestWebKitAPI/Tests/WebKitCocoa/SetSessionCookie.html: Added.
18704 2018-12-03 Chris Dumez <cdumez@apple.com>
18706 [PSON] Request by the client to process-swap is ignored if the window has an opener
18707 https://bugs.webkit.org/show_bug.cgi?id=192267
18708 <rdar://problem/46386886>
18710 Reviewed by Brady Eidson.
18712 Add API test coverage.
18714 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
18716 2018-12-03 Keith Rollin <krollin@apple.com>
18718 Add .xcfilelist files
18719 https://bugs.webkit.org/show_bug.cgi?id=192082
18720 <rdar://problem/46312533>
18722 Reviewed by Brent Fulgham.
18724 Add .xcfilelist files for Generate Derived Sources and Generate
18725 Unified Sources build phases in Xcode. These are just being staged for
18726 now; they'll be added to the Xcode projects later.
18728 * DumpRenderTree/DerivedSources-input.xcfilelist: Added.
18729 * DumpRenderTree/DerivedSources-output.xcfilelist: Added.
18730 * WebKitTestRunner/DerivedSources-input.xcfilelist: Added.
18731 * WebKitTestRunner/DerivedSources-output.xcfilelist: Added.
18733 2018-12-03 Alex Christensen <achristensen@webkit.org>
18735 Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
18736 https://bugs.webkit.org/show_bug.cgi?id=192272
18738 Reviewed by Brady Eidson.
18740 * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
18741 (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]):
18742 (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
18744 2018-12-03 Wenson Hsieh <wenson_hsieh@apple.com>
18746 [iOSMac] Unable to upload non-image files using drag and drop in WKWebView
18747 https://bugs.webkit.org/show_bug.cgi?id=192283
18748 <rdar://problem/46399461>
18750 Reviewed by Ryosuke Niwa.
18752 Add a new API test to check that an item provider which contains plain text data and a file URL (but is not
18753 marked as an attachment) is still treated as an attachment upon drop. Furthermore, verify that "text/uri-list"
18754 does not expose the actual file URL written to the item provider.
18756 Additionally, rebaseline an existing API test to remove an extraneous "text/uri-list" type that appears in
18757 `DataTransfer.types`, but whose data is inaccessible via `getData` anyways.
18759 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
18761 2018-12-01 Don Olmstead <don.olmstead@sony.com>
18763 Cleanup WebKit Features
18764 https://bugs.webkit.org/show_bug.cgi?id=192262
18766 Reviewed by Michael Catanzaro.
18768 Removes obsolete ENABLE options and variable names. Syncs the option's
18769 descriptions with what is present in WebKitFeatures.cmake. Sorts the
18770 options based on the associated define.
18772 * Scripts/webkitperl/FeatureList.pm:
18774 2018-12-01 Chris Dumez <cdumez@apple.com>
18776 [PSON] process-swapping may occur even though opener has handle to openee
18777 https://bugs.webkit.org/show_bug.cgi?id=192277
18779 Reviewed by Antti Koivisto.
18781 Add API test coverage.
18783 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
18785 2018-12-01 Jonathan Bedard <jbedard@apple.com>
18787 Unreviewed, rolling out r238764.
18789 Breaks existing layout tests
18791 Reverted changeset:
18793 "webkitpy: Support unicode in MeteredStream"
18794 https://bugs.webkit.org/show_bug.cgi?id=192260
18795 https://trac.webkit.org/changeset/238764
18797 2018-12-01 Yusuke Suzuki <yusukesuzuki@slowstart.org>
18799 Move URL tests from TestWebKitAPI to TestWTF
18800 https://bugs.webkit.org/show_bug.cgi?id=192275
18802 Reviewed by Keith Miller.
18804 Since URL is moved from WebCore to WTF, we also move tests for them from TestWebKitAPI (TestWebCore) to TestWTF.
18805 But we still have some tests in TestWebCore since only WebCore implements TextEncoding. That part is now decoupled
18806 from URLParser tests and new URLParserTextEncoding.cpp is created.
18808 * TestWebKitAPI/CMakeLists.txt:
18809 * TestWebKitAPI/PlatformGTK.cmake:
18810 * TestWebKitAPI/PlatformWPE.cmake:
18811 * TestWebKitAPI/PlatformWin.cmake:
18812 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
18813 * TestWebKitAPI/Tests/WTF/URL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/URL.cpp.
18814 (TestWebKitAPI::TEST_F):
18815 * TestWebKitAPI/Tests/WTF/URLParser.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp.
18816 (TestWebKitAPI::TEST_F):
18817 * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm.
18818 (TestWebKitAPI::TEST):
18819 * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp: Added.
18820 (TestWebKitAPI::ExpectedParts::isInvalid const):
18821 (TestWebKitAPI::eq):
18822 (TestWebKitAPI::insertTabAtLocation):
18823 (TestWebKitAPI::invalidParts):
18824 (TestWebKitAPI::checkURL):
18825 (TestWebKitAPI::TEST_F):
18827 2018-11-30 Zalan Bujtas <zalan@apple.com>
18829 Unreviewed LFC passing test list update.
18831 * LayoutReloaded/misc/LFC-passing-tests.txt:
18833 2018-11-30 Alex Christensen <achristensen@webkit.org>
18835 Move URL from WebCore to WTF
18836 https://bugs.webkit.org/show_bug.cgi?id=190234
18838 Reviewed by Keith Miller.
18840 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
18841 * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
18842 * TestWebKitAPI/Tests/WebCore/URL.cpp:
18843 (TestWebKitAPI::createURL):
18844 (TestWebKitAPI::TEST_F):
18845 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
18846 (TestWebKitAPI::checkURL):
18847 (TestWebKitAPI::checkRelativeURL):
18848 (TestWebKitAPI::checkURLDifferences):
18849 (TestWebKitAPI::checkRelativeURLDifferences):
18850 * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
18851 * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
18852 * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
18853 (TestWebKitAPI::originalDataAsString):
18854 (TestWebKitAPI::userVisibleString):
18855 (TestWebKitAPI::literalURL):
18856 (TestWebKitAPI::TEST):
18857 * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
18859 * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
18861 * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
18862 * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
18863 (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
18864 * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
18865 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
18866 (TestWebKitAPI::Util::createURLForResource):
18867 * lldb/lldb_webkit.py:
18868 (__lldb_init_module):
18869 (WTFURL_SummaryProvider):
18871 (WebCoreURL_SummaryProvider): Deleted.
18872 (WebCoreURLProvider): Deleted.
18873 (WebCoreURLProvider.__init__): Deleted.
18874 (WebCoreURLProvider.to_string): Deleted.
18876 2018-11-30 Jonathan Bedard <jbedard@apple.com>
18878 webkitpy: Support unicode in MeteredStream
18879 https://bugs.webkit.org/show_bug.cgi?id=192260
18881 Reviewed by Stephanie Lewis.
18883 It's possible that the test runner returns unicode characters to be logged when
18884 running layout tests.
18886 * Scripts/webkitpy/layout_tests/views/metered_stream.py:
18887 (MeteredStream.write): Message written to metered stream should be unicode.
18888 * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
18889 (RegularTest.test_unicode):
18891 2018-11-30 Jonathan Bedard <jbedard@apple.com>
18893 REGRESSION (r238749): run-api-tests dies with AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS'
18894 https://bugs.webkit.org/show_bug.cgi?id=192257
18895 <rdar://problem/46384671>
18897 Reviewed by Stephanie Lewis.
18899 Follow-up fix for r238749.
18901 * Scripts/webkitpy/api_tests/manager.py:
18902 (Manager._initialize_devices): Use DEFAULT_DEVICE_TYPE instead of DEFAULT_DEVICE_CLASS.
18904 2018-11-30 Chris Dumez <cdumez@apple.com>
18906 [PSON] We are sometimes swapping processes even though there is an opened window with an opener link to us
18907 https://bugs.webkit.org/show_bug.cgi?id=192242
18909 Reviewed by Geoffrey Garen.
18911 Add API test coverage.
18913 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
18915 2018-11-30 Don Olmstead <don.olmstead@sony.com>
18917 Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
18918 https://bugs.webkit.org/show_bug.cgi?id=192197
18920 Reviewed by Jiewen Tan.
18922 * Scripts/webkitperl/FeatureList.pm:
18923 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
18925 2018-11-30 Dean Jackson <dino@apple.com>
18927 Add first-class support for .mjs files in jsc binary
18928 https://bugs.webkit.org/show_bug.cgi?id=192190
18929 <rdar://problem/46375715>
18931 Reviewed by Keith Miller.
18933 Add .mjs files to the regexp looking for all JS files.
18935 * Scripts/run-jsc-stress-tests:
18937 2018-11-30 Jonathan Bedard <jbedard@apple.com>
18939 webkitpy: Use DeviceType instead of str to represent device class
18940 https://bugs.webkit.org/show_bug.cgi?id=192160
18941 <rdar://problem/46344845>
18943 Rubber-stamped by Aakash Jain.
18945 * Scripts/webkitpy/layout_tests/controllers/manager.py:
18946 (Manager._custom_device_for_test): Use DeviceTypes instead of strings to represent device type.
18947 (Manager._set_up_run): Do not set _options.device_class, use device_type instead of device_class.
18948 (Manager.run): Use device_type instead of device_class.
18949 (Manager._print_expectations_for_subset): Ditto.
18950 (Manager.print_expectations): Ditto.
18951 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
18952 (ManagerTest.test_uses_custom_device): Use DeviceType and actual device definition.
18953 * Scripts/webkitpy/layout_tests/views/printing.py:
18954 (Printer.print_workers_and_shards): Outputting the device suffix doesn't really help, and means
18955 device type needs to be passed around.
18956 * Scripts/webkitpy/port/apple.py:
18957 (ApplePort.setup_test_run): Use device_type instead of device_class.
18958 * Scripts/webkitpy/port/base.py:
18960 (Port.setup_test_run): Use device_type instead of device_class.
18961 * Scripts/webkitpy/port/device_port.py:
18963 (DevicePort.setup_test_run): Receive device_type as DeviceType object.
18964 (DevicePort._create_devices): Deleted.
18965 * Scripts/webkitpy/port/gtk.py:
18966 (GtkPort.setup_test_run): Use device_type instead of device_class.
18967 * Scripts/webkitpy/port/ios.py:
18969 * Scripts/webkitpy/port/ios_simulator.py:
18970 (IOSSimulatorPort):
18971 (IOSSimulatorPort.__init__): Deleted.
18972 (IOSSimulatorPort._set_device_class): Deleted.
18973 * Scripts/webkitpy/port/test.py:
18974 * Scripts/webkitpy/port/watch.py:
18976 * Scripts/webkitpy/port/watch_simulator.py:
18977 (WatchSimulatorPort):
18978 (WatchSimulatorPort.__init__): Deleted.
18979 (WatchSimulatorPort._set_device_class): Deleted.
18980 * Scripts/webkitpy/port/win.py:
18981 (WinPort.setup_test_run): Use device_type instead of device_class.
18982 * Scripts/webkitpy/xcode/simulated_device.py:
18983 (SimulatedDeviceManager._disambiguate_device_type): Using the existing devices for this is
18984 a problem if no such device exists yet. Use the _device_identifier_to_name dictionary instead
18985 since this should have hardware types in the device names.
18987 2018-11-30 David Quesada <david_quesada@apple.com>
18989 -[WKProcessPool _downloadURLRequest:] should allow specifying the initiating web view
18990 https://bugs.webkit.org/show_bug.cgi?id=192212
18991 rdar://problem/46363706
18993 Reviewed by Alex Christensen.
18995 * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
18996 (-[DownloadProgressTestRunner startDownload:expectedLength:]):
18998 2018-11-30 Zalan Bujtas <zalan@apple.com>
19000 [LFC][BFC] Compute min/maxHeight margins only when they are needed.
19001 https://bugs.webkit.org/show_bug.cgi?id=192223
19003 Reviewed by Antti Koivisto.
19005 * LayoutReloaded/misc/LFC-passing-tests.txt:
19007 2018-11-30 Zalan Bujtas <zalan@apple.com>
19009 [LFC][BFC][MarginCollapsing] Do not use computed display box values for border and padding
19010 https://bugs.webkit.org/show_bug.cgi?id=192214
19012 Reviewed by Antti Koivisto.
19014 * LayoutReloaded/misc/LFC-passing-tests.txt:
19016 2018-11-30 Thibault Saunier <tsaunier@igalia.com>
19018 [GTK][MiniBrowser] Handle Device Info permission requests
19019 https://bugs.webkit.org/show_bug.cgi?id=191585
19021 Reviewed by Carlos Garcia Campos.
19023 * MiniBrowser/gtk/BrowserTab.c:
19024 (permissionRequestDataNew):
19025 (permissionRequestDataFree):
19026 (permissionRequestDialogResponse):
19027 (decidePermissionRequest):
19028 (browserTabConstructed):
19030 2018-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
19032 Unreviewed GTK+ gardening. Stop running tests without complex text enforced
19034 We have enforced complex text in GTK+ for one release cycle without noticing any major issue nor performance
19037 * WebKitTestRunner/gtk/main.cpp:
19040 2018-11-29 Wenson Hsieh <wenson_hsieh@apple.com>
19042 REGRESSION (r238635): Dragging a text selection within WKWebView causes the selection highlight to get into a bad state
19043 https://bugs.webkit.org/show_bug.cgi?id=192165
19044 <rdar://problem/46346682>
19046 Reviewed by Daniel Bates.
19048 Fixes 11 API tests that started failing or timing out after r238635. See below for more details.
19050 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
19051 (TestWebKitAPI::webViewForEditActionTesting):
19052 (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
19054 Ensure that the web view becomes first responder before executing edit actions.
19056 * TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html:
19057 * TestWebKitAPI/Tests/WebKitCocoa/contenteditable-and-textarea.html:
19059 Tweak these tests to allow selected content to overflow the width of the web view. Without this change,
19060 ContentEditableToContentEditable and ContentEditableToTextarea will sometimes fail because the content causes
19061 the body to scroll horizontally, so we miss the drop destination.
19063 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
19064 (loadTestPageAndEnsureInputSession):
19066 Add a new helper to load a test page with a given name, become first responder, and wait until an input session
19067 starts. Use this in various drag and drop tests to reduce code duplication.
19069 * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
19070 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
19071 (-[DragAndDropSimulator initWithWebView:]):
19072 (-[DragAndDropSimulator _resetSimulatedState]):
19073 (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
19074 (-[DragAndDropSimulator _advanceProgress]):
19076 To more accurately emulate UIKit behavior, begin focus preservation when starting a drag, and attempt to clear
19077 the focus preservation token when the drag session ends. This allows us to simulate and test the scenario that
19078 regressed with r238635.
19080 (-[DragAndDropSimulator ensureInputSession]):
19081 (-[DragAndDropSimulator _webView:didStartInputSession:]):
19082 (-[DragAndDropSimulator waitForInputSession]): Deleted.
19084 Refactored into -ensureInputSession. Instead of assuming that an input session has not yet been started, simply
19085 wait for an input session to start if needed.
19087 * TestWebKitAPI/ios/UIKitSPI.h:
19089 Add a new SPI declaration.
19091 2018-11-29 Tim Horton <timothy_horton@apple.com>
19093 Inform clients when editable image attachment backing data changes
19094 https://bugs.webkit.org/show_bug.cgi?id=192206
19095 <rdar://problem/46350277>
19097 Reviewed by Wenson Hsieh.
19099 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19100 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
19101 (-[AttachmentUpdateObserver init]):
19102 (-[AttachmentUpdateObserver dataInvalidated]):
19103 (-[AttachmentUpdateObserver _webView:didInvalidateDataForAttachment:]):
19104 (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectAttachmentInvalidation):
19105 (webViewForTestingAttachments):
19106 (TestWebKitAPI::forEachViewInHierarchy):
19107 (TestWebKitAPI::findEditableImageCanvas):
19108 (TestWebKitAPI::drawSquareInEditableImage):
19109 (TestWebKitAPI::TEST):
19110 * TestWebKitAPI/ios/PencilKitTestSPI.h: Added.
19111 Add a test ensuring that we get an invalidation callback when an editable image is changed.
19113 2018-11-29 Fujii Hironori <Hironori.Fujii@sony.com>
19115 REGRESSION(r238445)[Buildbot] Unknown builder 'GTK Linux 32-bit Release' in scheduler 'trunk'
19116 https://bugs.webkit.org/show_bug.cgi?id=192143
19118 Reviewed by Philippe Normand.
19120 Buildbot can't start since r238445.
19122 > Configuration Errors:
19123 > Unknown builder 'GTK Linux 32-bit Release' in scheduler 'trunk'
19124 > Unknown builder 'GTK Linux ARM Release' in scheduler 'trunk'
19126 * BuildSlaveSupport/build.webkit.org-config/config.json: Removed deprecated builders.
19128 2018-11-29 David Quesada <david_quesada@apple.com>
19130 Add SPI to publish NSProgress on active downloads
19131 https://bugs.webkit.org/show_bug.cgi?id=192021
19132 rdar://problem/44405661
19134 Reviewed by Alex Christensen.
19136 Add API tests to exercise the progress-publishing functionality in a variety of scenarios.
19138 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19139 * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm: Added.
19140 (+[DownloadProgressTestProtocol registerProtocolForTestRunner:]):
19141 (+[DownloadProgressTestProtocol unregisterProtocol]):
19142 (+[DownloadProgressTestProtocol canInitWithRequest:]):
19143 (+[DownloadProgressTestProtocol canonicalRequestForRequest:]):
19144 (+[DownloadProgressTestProtocol requestIsCacheEquivalent:toRequest:]):
19145 (-[DownloadProgressTestProtocol startLoading]):
19146 (-[DownloadProgressTestProtocol stopLoading]):
19147 (-[DownloadProgressTestRunner init]):
19148 (-[DownloadProgressTestRunner startLoadingWithProtocol:]):
19149 (-[DownloadProgressTestRunner tearDown]):
19150 (-[DownloadProgressTestRunner _didGetProgress:]):
19151 (-[DownloadProgressTestRunner _didLoseProgress]):
19152 (-[DownloadProgressTestRunner subscribeAndWaitForProgress]):
19153 (-[DownloadProgressTestRunner waitToLoseProgress]):
19154 (-[DownloadProgressTestRunner startDownload:expectedLength:]):
19155 (-[DownloadProgressTestRunner publishProgress]):
19156 (-[DownloadProgressTestRunner receiveData:]):
19157 (-[DownloadProgressTestRunner finishDownloadTask]):
19158 (-[DownloadProgressTestRunner failDownloadTask]):
19159 (-[DownloadProgressTestRunner waitForDownloadDidCreateDestination]):
19160 (-[DownloadProgressTestRunner waitForDownloadFinished]):
19161 (-[DownloadProgressTestRunner waitForDownloadCanceled]):
19162 (-[DownloadProgressTestRunner waitForDownloadFailed]):
19163 (-[DownloadProgressTestRunner waitForUpdatedCompletedUnitCount]):
19164 (-[DownloadProgressTestRunner observeValueForKeyPath:ofObject:change:context:]):
19165 (-[DownloadProgressTestRunner webView:decidePolicyForNavigationResponse:decisionHandler:]):
19166 (-[DownloadProgressTestRunner webView:decidePolicyForNavigationAction:decisionHandler:]):
19167 (-[DownloadProgressTestRunner _downloadDidStart:]):
19168 (-[DownloadProgressTestRunner _download:didCreateDestination:]):
19169 (-[DownloadProgressTestRunner _downloadDidFinish:]):
19170 (-[DownloadProgressTestRunner _downloadDidCancel:]):
19171 (-[DownloadProgressTestRunner _download:didFailWithError:]):
19172 (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
19175 2018-11-29 Alexey Proskuryakov <ap@apple.com>
19177 Exception in bot watcher's dashboard if a hidden platform in no longer configured for display
19178 https://bugs.webkit.org/show_bug.cgi?id=185527
19180 Reviewed by Aakash Jain.
19182 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
19183 (updateHiddenPlatforms):
19185 2018-11-29 Zalan Bujtas <zalan@apple.com>
19187 [LFC][BFC][Quirk] Body and html height stretching.
19188 https://bugs.webkit.org/show_bug.cgi?id=192154
19190 Reviewed by Antti Koivisto.
19192 * LayoutReloaded/misc/LFC-passing-tests.txt:
19194 2018-11-29 Jonathan Bedard <jbedard@apple.com>
19196 webkitpy: Unify device creation
19197 https://bugs.webkit.org/show_bug.cgi?id=192158
19198 <rdar://problem/46344757>
19200 Reviewed by Lucas Forschler.
19202 * Scripts/webkitpy/port/device_port.py:
19204 (DevicePort.setup_test_run): Use DEVICE_MANAGER to create devices based on the specified device class.
19205 * Scripts/webkitpy/port/ios.py:
19206 (IOSPort): Add DEFAULT_DEVICE_CLASS.
19207 * Scripts/webkitpy/port/ios_device.py:
19209 (IOSDevicePort._create_devices): Deleted.
19210 * Scripts/webkitpy/port/ios_simulator.py:
19211 (IOSSimulatorPort._create_devices): Deleted.
19212 * Scripts/webkitpy/port/watch.py:
19213 (WatchPort): Add DEFAULT_DEVICE_CLASS.
19214 * Scripts/webkitpy/port/watch_device.py:
19216 (WatchDevicePort._create_devices): Deleted.
19217 * Scripts/webkitpy/port/watch_simulator.py:
19218 (WatchSimulatorPort._create_devices): Deleted.
19219 * Scripts/webkitpy/xcode/device_type_unittest.py:
19220 (DeviceTypeTest.test_from_string): Test that DeviceTypes without hardware types can be constructed
19223 2018-11-29 Jonathan Bedard <jbedard@apple.com>
19225 EWS iOS-sim bots sometimes fails to shutdown simulator
19226 https://bugs.webkit.org/show_bug.cgi?id=191864
19228 Reviewed by Aakash Jain.
19230 * Scripts/webkitpy/xcode/simulated_device.py:
19231 (SimulatedDevice._shut_down): Increase time to wait for simulated device to
19232 shut down, ignore exit code indicating a device is already shut down.
19234 2018-11-29 Jonathan Bedard <jbedard@apple.com>
19236 webkitpy: Unify ios_version/watchos_version code
19237 https://bugs.webkit.org/show_bug.cgi?id=192153
19238 <rdar://problem/46343642>
19240 Reviewed by Lucas Forschler.
19242 Treating watchOS and iOS versions differently makes it harder to share code between the similar ports.
19244 * Scripts/webkitpy/port/device_port.py:
19246 (DevicePort.device_version): Added.
19247 * Scripts/webkitpy/port/ios.py:
19248 (IOSPort.default_baseline_search_path): Use device_version() instead of ios_version().
19249 (IOSPort.ios_version): Deleted.
19250 * Scripts/webkitpy/port/ios_device.py:
19251 (IOSDevicePort.device_version): Renamed from ios_version().
19252 (IOSDevicePort.ios_version): Deleted.
19253 * Scripts/webkitpy/port/ios_simulator.py:
19254 (IOSSimulatorPort.device_version): Renamed from ios_version().
19255 (IOSSimulatorPort.default_child_processes.booted_ios_devices_filter): Use device_version() instead of ios_version().
19256 (IOSSimulatorPort._create_devices): Ditto.
19257 (IOSSimulatorPort.check_sys_deps): Ditto.
19258 (IOSSimulatorPort.ios_version): Deleted.
19259 * Scripts/webkitpy/port/watch.py:
19260 (WatchPort.default_baseline_search_path): Use device_version() instead of watchos_version().
19261 (WatchPort.watchos_version): Deleted.
19262 * Scripts/webkitpy/port/watch_device.py:
19263 (WatchDevicePort.device_version): Renamed from watchos_version().
19264 (WatchDevicePort.watchos_version): Deleted.
19265 * Scripts/webkitpy/port/watch_simulator.py:
19266 (WatchSimulatorPort.device_version): Renamed from watchos_version().
19267 (WatchSimulatorPort.default_child_processes.filter_booted_watchos_devices): Use device_version() instead of watchos_version().
19268 (WatchSimulatorPort._create_devices): Ditto.
19269 (WatchSimulatorPort.check_sys_deps): Ditto.
19270 (WatchSimulatorPort.watchos_version): Deleted.
19272 2018-11-28 Wenson Hsieh <wenson_hsieh@apple.com>
19274 [iOSMac] Dropping text selections from web content into editable elements crashes the web process
19275 https://bugs.webkit.org/show_bug.cgi?id=192113
19276 <rdar://problem/46323701>
19278 Reviewed by Ryosuke Niwa.
19280 Add a test to verify that, when dropping an item with both "com.apple.webarchive" and "public.utf8-plain-text"
19281 representations, the higher fidelity web archive data is used when handling the drop.
19283 * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
19285 2018-11-28 Aakash Jain <aakash_jain@apple.com>
19287 [ews-app] Fetch bugs from Bugzilla and submit to Buildbot
19288 https://bugs.webkit.org/show_bug.cgi?id=191947
19290 Reviewed by Lucas Forschler.
19292 * BuildSlaveSupport/ews-app/ews/fetcher.py: Added.
19294 2018-11-28 Alex Christensen <achristensen@webkit.org>
19296 Fix iOS API test after r238585
19297 https://bugs.webkit.org/show_bug.cgi?id=192022
19299 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
19301 On iOS, a safe browsing warning over a WKWebView with frame of {0, 0, 0, 0} has a size of {0, 0}, which is fine.
19302 The test was added to catch a bug on Mac platforms, so testing it only on Mac will catch any regression.
19304 2018-11-28 Aakash Jain <aakash_jain@apple.com>
19306 [ews-app] Configure python logging
19307 https://bugs.webkit.org/show_bug.cgi?id=192005
19309 Reviewed by Lucas Forschler.
19311 * BuildSlaveSupport/ews-app/ews/__init__.py: Configured logging.
19313 2018-11-28 Keith Rollin <krollin@apple.com>
19315 Update generate-{derived,unified}-sources scripts to support generating .xcfilelist files
19316 https://bugs.webkit.org/show_bug.cgi?id=192031
19317 <rdar://problem/46286816>
19319 Reviewed by Alex Christensen.
19321 The Generate Derived Sources and Generate Unified Sources build phases
19322 in Xcode need to have their inputs and outputs specified. This
19323 specification will come in the form of .xcfilelist files that will be
19324 attached to these build phases. There is one .xcfilelist file that
19325 lists the input file and one that lists the output files. As part of
19326 this work, the various generate-{derived,unified}-sources scripts that
19327 are executed in these Generate build phases are modified to help in
19328 the creation of these .xcfilelist files. In particular, they can now
19329 be invoked with command-line parameters. These parameters are then
19330 used to alter the normal execution of these scripts, causing them to
19331 produce the .xcfilelist files as opposed to actually generating the
19332 files that are listed in those files.
19334 * DumpRenderTree/Scripts/generate-derived-sources.sh:
19335 * WebKitTestRunner/Scripts/generate-derived-sources.sh:
19337 2018-11-28 Keith Rollin <krollin@apple.com>
19339 Revert print_all_generated_files work in r238008; tighten up target specifications
19340 https://bugs.webkit.org/show_bug.cgi?id=192025
19341 <rdar://problem/46284301>
19343 Reviewed by Alex Christensen.
19345 In r238008, I added a facility for DerivedSources.make makefiles to
19346 print out the list of files that they generate. This output was used
19347 in the generation of .xcfilelist files used to specify the output of
19348 the associated Generate Derived Sources build phases in Xcode. This
19349 approach worked, but it meant that people would need to follow a
19350 specific convention to keep this mechanism working.
19352 Instead of continuing this approach, I'm going to implement a new
19353 facility based on the output of `make` when passed the -d flag (which
19354 prints dependency information). This new mechanism is completely
19355 automatic and doesn't need maintainers to follow a convention. To that
19356 end, remove most of the work performed in r238008 that supports the
19357 print_all_generated_files target.
19359 At the same time, it's important for the sets of targets and their
19360 dependencies to be complete and correct. Therefore, also include
19361 changes to bring those up-to-date. As part of that, you'll see
19362 prevalent use of a particular technique. Here's an example:
19366 BytecodeIndices.h \
19367 BytecodeStructs.h \
19368 InitBytecodes.asm \
19370 BYTECODE_FILES_PATTERNS = $(subst .,%,$(BYTECODE_FILES))
19372 all : $(BYTECODE_FILES)
19374 $(BYTECODE_FILES_PATTERNS): $(wildcard $(JavaScriptCore)/generator/*.rb) $(JavaScriptCore)/bytecode/BytecodeList.rb
19377 These lines indicate a set of generated files (those specified in
19378 BYTECODE_FILES). These files are generated by the BytecodeList.rb
19379 tool. But, as opposed to the normal rule where a single foo.output is
19380 generated by foo.input plus some additional dependencies, this rule
19381 produces multiple output files from a tool whose connection to the
19382 output files is not immediately clear. A special approach is needed
19383 where a single rule produces multiple output files. The normal way to
19384 implement this is to use an .INTERMEDIATE target. However, we used
19385 this approach in the past and ran into a problem with it, addressing
19386 it with an alternate approach in r210507. The above example shows this
19387 approach. The .'s in the list of target files are replaced with %'s,
19388 and the result is used as the left side of the dependency rule.
19390 * DumpRenderTree/DerivedSources.make:
19391 * WebKitTestRunner/DerivedSources.make:
19393 2018-11-28 Aakash Jain <aakash_jain@apple.com>
19395 [ews-app] Add support to get list of Bugzilla patches needing review
19396 https://bugs.webkit.org/show_bug.cgi?id=191942
19398 Reviewed by Lucas Forschler.
19400 * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
19401 (Bugzilla.get_list_of_patches_needing_reviews): Get list of patches needing review.
19402 (BugzillaBeautifulSoup.fetch_attachment_ids_from_review_queue): Copied from Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py
19403 (BugzillaBeautifulSoup._load_query): Ditto.
19404 (BugzillaBeautifulSoup._parse_attachment_ids_request_query): Ditto.
19406 2018-11-28 Daniel Bates <dabates@apple.com>
19408 [iOS] Page not defocused when Find-in-page becomes first responder
19409 https://bugs.webkit.org/show_bug.cgi?id=192084
19410 <rdar://problem/46146777>
19412 Reviewed by Tim Horton.
19414 Add tests for both Mac and iOS to ensure that when finding a string on the page
19415 that we do not start an input session if a match is found in an <input> and the
19416 WKWebView is not the first responder.
19418 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19419 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm: Added.
19420 (-[WKWebViewFindStringInputDelegate _webView:didStartInputSession:]):
19421 (-[WKWebViewFindStringFindDelegate findString]):
19422 (-[WKWebViewFindStringFindDelegate _webView:didCountMatches:forString:]):
19423 (-[WKWebViewFindStringFindDelegate _webView:didFindMatches:forString:withMatchIndex:]):
19424 (-[WKWebViewFindStringFindDelegate _webView:didFailToFindString:]):
19427 (viewIsFirstResponder):
19428 (TestWebKitAPI::TEST):
19429 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
19430 (WTR::PlatformWebView::PlatformWebView): Make the view the first responder before the
19431 window key. This matches the ordering used in PlatformWebView::focus(). No behavior change.
19433 2018-11-28 Aakash Jain <aakash_jain@apple.com>
19435 [ews-app] Add BeautifulSoup
19436 https://bugs.webkit.org/show_bug.cgi?id=191994
19438 Reviewed by Lucas Forschler.
19440 * BuildSlaveSupport/ews-app/ews/thirdparty: Added.
19441 * BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py: Added.
19442 * BuildSlaveSupport/ews-app/ews/thirdparty/__init__.py: Added.
19444 2018-11-28 Aakash Jain <aakash_jain@apple.com>
19446 [ews-app] Add support to download Patch from Bugzilla
19447 https://bugs.webkit.org/show_bug.cgi?id=191943
19449 Reviewed by Lucas Forschler.
19451 * BuildSlaveSupport/ews-app/ews/common/bugzilla.py: Added.
19452 (Bugzilla.retrieve_attachment): Retreives the attachment from Bugzilla and saves to disk.
19453 (Bugzilla._fetch_attachment_json):
19454 (Bugzilla.file_path_for_patch):
19455 * BuildSlaveSupport/ews-app/ews/common/util.py: Added.
19456 (fetch_data_from_url): Method to fetch data from given url.
19457 * BuildSlaveSupport/ews-app/ews/config.py:
19459 2018-11-28 Aakash Jain <aakash_jain@apple.com>
19461 [ews-app] Add methods to update Patch fields
19462 https://bugs.webkit.org/show_bug.cgi?id=191931
19464 Reviewed by Lucas Forschler.
19466 * BuildSlaveSupport/ews-app/ews/models/patch.py:
19467 (Patch.set_sent_to_buildbot):
19468 (Patch.set_bug_id):
19469 (Patch.set_obsolete):
19471 2018-11-28 Yongjun Zhang <yongjun_zhang@apple.com>
19473 Allow WebKit clients to specify a minimum effective width for layout.
19474 https://bugs.webkit.org/show_bug.cgi?id=191499
19475 <rdar://problem/45362678>
19477 Reviewed by Wenson Hsieh.
19479 Allow UIScriptController to set WKWebView's minimum effective width with a new `setMinimumEffectiveWidth` method.
19481 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
19482 (WTR::UIScriptController::setMinimumEffectiveWidth):
19483 * DumpRenderTree/mac/UIScriptControllerMac.mm:
19484 (WTR::UIScriptController::setViewScale):
19485 (WTR::UIScriptController::setMinimumEffectiveWidth):
19486 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
19487 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
19488 (WTR::UIScriptController::setMinimumEffectiveWidth):
19489 * TestRunnerShared/UIScriptContext/UIScriptController.h:
19490 * WebKitTestRunner/UIScriptControllerCocoa.mm:
19491 (WTR::UIScriptController::setMinimumEffectiveWidth):
19492 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
19493 (WTR::TestController::cocoaResetStateToConsistentValues):
19495 2018-11-28 Lucas Forschler <lforschler@apple.com>
19497 Fix webkitbot hi command.
19498 https://bugs.webkit.org/show_bug.cgi?id=192080
19500 Reviewed by Alexey Proskuryakov.
19502 * Scripts/webkitpy/tool/bot/irc_command.py:
19505 2018-11-28 Zalan Bujtas <zalan@apple.com>
19507 [LFC][Quirk] Use non-collapsed vertical margin values when the container is stretched to the size of the ICB.
19508 https://bugs.webkit.org/show_bug.cgi?id=192078
19510 Reviewed by Antti Koivisto.
19512 * LayoutReloaded/misc/LFC-passing-tests.txt:
19514 2018-11-28 Zalan Bujtas <zalan@apple.com>
19516 [LFC] Add support for quirk container's collapsing top margin in quirks mode.
19517 https://bugs.webkit.org/show_bug.cgi?id=192070
19519 Reviewed by Antti Koivisto.
19521 * LayoutReloaded/misc/LFC-passing-tests.txt:
19523 2018-11-28 Thibault Saunier <tsaunier@igalia.com>
19525 [WebRTC][GStreamer] Make sure to have the default microphone on the top of the list
19526 https://bugs.webkit.org/show_bug.cgi?id=192026
19528 Reviewed by Philippe Normand.
19530 Otherwise we might end up picking a useless one in some applications
19531 (not sure what those application do though).
19533 GStreamer patch proposed as https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/merge_requests/34/diffs
19535 * flatpak/org.webkit.CommonModules.yaml:
19536 * gstreamer/jhbuild.modules:
19537 * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Added.
19539 2018-11-28 Tomas Popela <tpopela@redhat.com>
19541 [GTK] Silence compilation warnings in glib unittests
19542 https://bugs.webkit.org/show_bug.cgi?id=192009
19544 Reviewed by Michael Catanzaro.
19546 Mark the destructor as virtual.
19548 * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
19551 2018-11-27 Mark Lam <mark.lam@apple.com>
19553 ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
19554 https://bugs.webkit.org/show_bug.cgi?id=192055
19555 <rdar://problem/46288783>
19557 Reviewed by Saam Barati.
19559 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
19561 2018-11-27 Alex Christensen <achristensen@webkit.org>
19563 Make synchronous IPC introduced in r237267 asynchronous
19564 https://bugs.webkit.org/show_bug.cgi?id=190757
19566 Reviewed by Chris Dumez.
19568 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
19570 2018-11-27 Jonathan Bedard <jbedard@apple.com>
19572 webkitpy: Add watchOS ports
19573 https://bugs.webkit.org/show_bug.cgi?id=191974
19574 <rdar://problem/46251051>
19576 Reviewed by Aakash Jain.
19578 * Scripts/webkitpy/port/factory.py:
19579 (PortFactory): Add WatchDevice and WatchSimulator ports.
19580 * Scripts/webkitpy/port/watch.py: Added.
19581 (WatchPort): Base class for watchOS ports.
19582 * Scripts/webkitpy/port/watch_device.py: Added.
19583 (WatchDevicePort): Class for running layout tests on a watchOS device.
19584 * Scripts/webkitpy/port/watch_simulator.py: Added.
19585 (WatchSimulatorPort): Class for running layout tests on a watchOS simulator.
19586 * Scripts/webkitpy/port/watch_simulator_unittest.py: Added.
19587 (WatchSimulatorTest):
19588 * Scripts/webkitpy/port/watch_testcase.py: Added.
19591 2018-11-27 Alex Christensen <achristensen@webkit.org>
19593 Safe browsing warning text needs to be visible on High Sierra
19594 https://bugs.webkit.org/show_bug.cgi?id=192022
19596 Reviewed by Tim Horton.
19598 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
19601 2018-11-27 Wenson Hsieh <wenson_hsieh@apple.com>
19603 Unreviewed, fix the watchOS engineering build
19605 Disable a newly added API test, since DDScannerResult is unavailable on watchOS.
19607 * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
19609 2018-11-27 Chris Dumez <cdumez@apple.com>
19611 Regression(PSON) crash under WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame()
19612 https://bugs.webkit.org/show_bug.cgi?id=191983
19613 <rdar://problem/46246863>
19615 Reviewed by Geoffrey Garen.
19617 Add API test coverage.
19619 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
19621 2018-11-27 Aakash Jain <aakash_jain@apple.com>
19623 [ews-app] Add support to communicate with Buildbot (Follow-up fix)
19624 https://bugs.webkit.org/show_bug.cgi?id=191935
19625 <rdar://problem/46262314>
19627 Unreviewed infrastructure fix.
19629 * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
19630 (Buildbot.send_patch_to_buildbot):
19632 2018-11-26 Wenson Hsieh <wenson_hsieh@apple.com>
19634 [Cocoa] No way for clients to tell whether the content view is in the responder chain when the web view is
19635 https://bugs.webkit.org/show_bug.cgi?id=169212
19636 <rdar://problem/30899656>
19638 Reviewed by Tim Horton.
19640 Add an API test to exercise the behavior of `-_contentViewIsFirstResponder` when an embedded text input becomes
19641 and resigns first responder.
19643 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19644 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFirstResponderTests.mm: Added.
19645 (-[FirstResponderTestingView initWithFrame:]):
19646 (-[FirstResponderTestingView inputField]):
19647 (TestWebKitAPI::TEST):
19649 2018-11-26 Fujii Hironori <Hironori.Fujii@sony.com>
19651 [CMake] Remove ENABLE_ACCESSIBILITY CMake variable
19652 https://bugs.webkit.org/show_bug.cgi?id=191831
19654 Reviewed by Michael Catanzaro.
19656 * WebKitTestRunner/CMakeLists.txt:
19658 2018-11-26 Tim Horton <timothy_horton@apple.com>
19660 Insert <attachment> elements under editable images to make their backing data accessible
19661 https://bugs.webkit.org/show_bug.cgi?id=191844
19662 <rdar://problem/30900149>
19664 Reviewed by Simon Fraser.
19666 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
19667 (WTR::UIScriptController::attachmentInfo):
19668 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
19669 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
19670 (WTR::UIScriptController::attachmentInfo):
19671 * TestRunnerShared/UIScriptContext/UIScriptController.h:
19672 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
19673 (WTR::UIScriptController::attachmentInfo):
19674 Add a UIScriptController mechanism to retrieve information about
19675 a given attachment.
19677 2018-11-26 Aakash Jain <aakash_jain@apple.com>
19679 [ews-app] Add support to communicate with Buildbot
19680 https://bugs.webkit.org/show_bug.cgi?id=191935
19682 Reviewed by Lucas Forschler.
19684 * BuildSlaveSupport/ews-app/ews/common/__init__.py: Added.
19685 * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Added.
19687 2018-11-26 Jonathan Bedard <jbedard@apple.com>
19689 webkitpy: Race condition in ServerProcess tests
19690 https://bugs.webkit.org/show_bug.cgi?id=191989
19691 <rdar://problem/45536844>
19693 Reviewed by Lucas Forschler.
19695 Serializing these tests to prevent the race conditions.
19697 * Scripts/webkitpy/port/server_process_unittest.py:
19698 (TestServerProcess.serial_test_basic):
19699 (TestServerProcess.serial_test_read_after_process_exits):
19700 (TestServerProcess.serial_test_process_crashing):
19701 (TestServerProcess.serial_test_process_crashing_no_data):
19702 (TestServerProcess.test_basic): Deleted.
19703 (TestServerProcess.test_read_after_process_exits): Deleted.
19704 (TestServerProcess.test_process_crashing): Deleted.
19705 (TestServerProcess.test_process_crashing_no_data): Deleted.
19707 2018-11-26 Aakash Jain <aakash_jain@apple.com>
19709 [ews-app] Add field in Patch object to indicate if it has been sent to Buildbot
19710 https://bugs.webkit.org/show_bug.cgi?id=191929
19712 Reviewed by Lucas Forschler.
19714 * BuildSlaveSupport/ews-app/ews/models/patch.py:
19715 (Patch): Added sent_to_buildbot field.
19716 (Patch.is_patch_sent_to_buildbot): Checks if the patch has been sent to Buildbot.
19718 2018-11-26 Aakash Jain <aakash_jain@apple.com>
19720 [ews-app] Add a config file
19721 https://bugs.webkit.org/show_bug.cgi?id=191933
19723 Reviewed by Lucas Forschler.
19725 * BuildSlaveSupport/ews-app/ews/config.py: Added.
19727 2018-11-26 Aakash Jain <aakash_jain@apple.com>
19729 [ews-app] Add methods to save patch to database
19730 https://bugs.webkit.org/show_bug.cgi?id=191928
19732 Reviewed by Lucas Forschler.
19734 * BuildSlaveSupport/ews-app/ews/models/patch.py:
19735 (Patch.save_patch): Method to save the patch to database.
19736 (Patch.save_patches): Method to save multiple patches to database.
19737 (Patch.is_valid_patch_id): Checks if the patch id is valid.
19738 (Patch.is_existing_patch_id): Checks if the patch id already exists in database.
19740 2018-11-26 Alex Christensen <achristensen@webkit.org>
19742 Rename WKWebView._safeBrowsingWarningForTesting to _safeBrowsingWarning to use it for more than testing
19743 https://bugs.webkit.org/show_bug.cgi?id=191981
19745 Reviewed by Tim Horton.
19747 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
19749 (safeBrowsingView):
19751 2018-11-26 Daniel Bates <dabates@apple.com>
19753 REGRESSION (r237738): Command Down Arrow doesn't scroll to the end of a page anymore
19754 https://bugs.webkit.org/show_bug.cgi?id=191967
19755 <rdar://problem/45976390>
19757 Reviewed by Tim Horton.
19759 Add more test infrastructure to dispatch key up events.
19761 * WebKitTestRunner/ios/HIDEventGenerator.h:
19762 * WebKitTestRunner/ios/HIDEventGenerator.mm:
19763 (createHIDKeyEvent): Renamed from createHIDKeyDownEvent() and modified to take a boolean as
19764 to whether to create an event for a key down or key up.
19765 (createHIDKeyDownEvent): Deleted; renamed to createHIDKeyEvent().
19766 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
19767 (WTR::createUIPhysicalKeyboardEvent): Added. Convenience function to create a UIPhysicalKeyboardEvent.
19768 (WTR::UIScriptController::keyDown): Modified to dispatch a key up event in addition to dispatching
19771 2018-11-26 Aakash Jain <aakash_jain@apple.com>
19773 [ews-app] Set Foreign Keys in EWS Django app models
19774 https://bugs.webkit.org/show_bug.cgi?id=191790
19776 Reviewed by Lucas Forschler.
19778 * BuildSlaveSupport/ews-app/ews/models/builds.py: Set Foreign Key.
19779 * BuildSlaveSupport/ews-app/ews/models/steps.py: Ditto.
19781 2018-11-26 Aakash Jain <aakash_jain@apple.com>
19783 [ews-app] Do not store patch content in database
19784 https://bugs.webkit.org/show_bug.cgi?id=191788
19786 Reviewed by Lucas Forschler.
19788 * BuildSlaveSupport/ews-app/ews/models/patch.py: Removed content field.
19790 2018-11-26 Jonathan Bedard <jbedard@apple.com>
19792 webkitpy: Retry app installation on watchOS simulators (Follow-up fix)
19793 https://bugs.webkit.org/show_bug.cgi?id=191769
19794 <rdar://problem/46139850>
19796 Unreviewed infrastructure fix.
19798 * Scripts/webkitpy/xcode/simulated_device.py:
19799 (SimulatedDevice): Increase retry attempts.
19801 2018-11-26 Daniel Bates <dabates@apple.com>
19803 Move testRunner.toggleCapsLock() to uiController
19804 https://bugs.webkit.org/show_bug.cgi?id=191972
19806 Reviewed by Tim Horton.
19808 Move testRunner.toggleCapsLock() to uiController as uiController is the preferred JavaScript
19809 object for UI test functions. Having this functionality be on uiController makes it an
19810 asynchronous function naturally and complements use of onkeydown, onkeyup listeners to know
19811 when the Caps Lock key event is dispatched. It also facilitates its use directly as part of
19812 scripts with other uiController functions invocations that are passed in a single invocation
19813 of testRunner.runUIScript().
19815 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
19816 (WTR::UIScriptController::toggleCapsLock):
19817 * DumpRenderTree/mac/UIScriptControllerMac.mm:
19818 (WTR::UIScriptController::toggleCapsLock):
19819 Added stub functions that invoke the callback. We do not support toggling caps lock in Legacy
19820 WebKit at the moment. Legacy WebKit reads the caps lock key state directly from the OS. Modern
19821 WebKit caches the caps lock state in the WebProcess as a natural side effect of the fact that
19822 the UIProcess is the only process capable of querying the caps lock key state from the OS and
19823 hence the UIProcess must send over this state to the WebProcess.
19825 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Add IDL for new function.
19826 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
19827 (WTR::UIScriptController::toggleCapsLock): Added empty implementation for ports non-Cocoa ports.
19828 * TestRunnerShared/UIScriptContext/UIScriptController.h:
19830 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
19831 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
19832 (WTR::TestRunner::toggleCapsLock): Deleted.
19833 * WebKitTestRunner/InjectedBundle/TestRunner.h:
19834 * WebKitTestRunner/TestController.h:
19835 * WebKitTestRunner/TestInvocation.cpp:
19836 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
19837 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
19838 (WTR::TestController::toggleCapsLock): Deleted; moved to UIScriptController::toggleCapsLock().
19839 Removed logic to handle testRunner.toggleCapsLock().
19841 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
19842 (WTR::UIScriptController::toggleCapsLock): Add stub function that invokes the callback
19843 and a FIXME comment that explains that we will implement this function in <https://bugs.webkit.org/show_bug.cgi?id=191815>.
19844 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
19845 (WTR::UIScriptController::toggleCapsLock): Moved the implementation from TestController::toggleCapsLock().
19847 2018-11-26 Brent Fulgham <bfulgham@apple.com>
19849 [Win] Reduce the use of WKSI library calls: CoreAnimation
19850 https://bugs.webkit.org/show_bug.cgi?id=191777
19851 <rdar://problem/46140542>
19853 Reviewed by Zalan Bujtas.
19855 Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
19856 Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
19857 directives for WebKitSystemInterface.lib.
19859 * TestWebKitAPI/PlatformWin.cmake:
19861 2018-11-25 Zalan Bujtas <zalan@apple.com>
19863 [LFC][IFC] Use float box's margin box to adjust the line constraints.
19864 https://bugs.webkit.org/show_bug.cgi?id=191961
19866 Reviewed by Antti Koivisto.
19868 * LayoutReloaded/misc/LFC-passing-tests.txt:
19870 2018-11-25 Zalan Bujtas <zalan@apple.com>
19872 Unreviewed test fix after r238467.
19874 * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
19875 (TestWebKitAPI::TEST):
19877 2018-11-25 Wenson Hsieh <wenson_hsieh@apple.com>
19879 Unreviewed, fix the internal iOS 12 build after r238471
19881 * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
19884 2018-11-25 Tim Horton <timothy_horton@apple.com>
19886 Make it possible to insert editable images with a gesture
19887 https://bugs.webkit.org/show_bug.cgi?id=191937
19889 Reviewed by Wenson Hsieh.
19891 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
19892 (WTR::UIScriptController::drawSquareInEditableImage):
19893 If the canvas already has a drawing, draw a new stroke on top of it
19894 instead of removing the existing stroke.
19896 2018-11-24 Wenson Hsieh <wenson_hsieh@apple.com>
19898 [Cocoa] Add WKWebView SPI to trigger and remove data detection
19899 https://bugs.webkit.org/show_bug.cgi?id=191918
19900 <rdar://problem/36185051>
19902 Reviewed by Tim Horton.
19904 Add an API test to exercise the new WebKit SPI.
19906 * TestWebKitAPI/DataDetectorsCoreSPI.h: Added.
19907 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19908 * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
19909 (-[WKWebView synchronouslyDetectDataWithTypes:]):
19910 (-[WKWebView synchronouslyRemoveDataDetectedLinks]):
19912 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
19913 (TestWebKitAPI::TEST):
19914 (-[TestWKWebView tagsInBody]): Deleted.
19915 (-[TestWKWebView expectElementTagsInOrder:]): Deleted.
19916 (-[TestWKWebView expectElementCount:tagName:]): Deleted.
19917 (-[TestWKWebView expectElementTag:toComeBefore:]): Deleted.
19919 Rename this from `-expectElementCount:tagName:` to `-expectElementCount:querySelector:`.
19921 * TestWebKitAPI/Tests/WebKitCocoa/data-detectors.html: Added.
19923 Add a new test page containing some content that can be data detected.
19925 * TestWebKitAPI/cocoa/TestWKWebView.h:
19926 * TestWebKitAPI/cocoa/TestWKWebView.mm:
19927 (-[WKWebView tagsInBody]):
19928 (-[WKWebView expectElementTagsInOrder:]):
19929 (-[WKWebView expectElementCount:querySelector:]):
19930 (-[WKWebView expectElementTag:toComeBefore:]):
19932 Move some testing helper functions from WKAttachmentTests to a testing category on WKWebView. This allows us to
19933 use `-expectElementCount:querySelector:` in tests outside of WKAttachmentTests.
19935 (-[WKWebView objectByEvaluatingJavaScript:]):
19936 (-[WKWebView objectByEvaluatingJavaScriptWithUserGesture:]):
19937 (-[WKWebView stringByEvaluatingJavaScript:]):
19939 Move some common helper functions from TestWKWebView to a testing category on WKWebView.
19941 (-[TestWKWebView objectByEvaluatingJavaScript:]): Deleted.
19942 (-[TestWKWebView objectByEvaluatingJavaScriptWithUserGesture:]): Deleted.
19943 (-[TestWKWebView stringByEvaluatingJavaScript:]): Deleted.
19945 2018-11-23 Sam Weinig <sam@webkit.org>
19947 Add raw pointer overloads to ListHashSet via SmartPtr specialized functions
19948 https://bugs.webkit.org/show_bug.cgi?id=191936
19950 Reviewed by Zalan Bujtas.
19952 Adds tests for raw pointer overloads in ListHashSet.
19954 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
19955 * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
19957 2018-11-23 Wenson Hsieh <wenson_hsieh@apple.com>
19959 Enable drag and drop support for iOSMac
19960 https://bugs.webkit.org/show_bug.cgi?id=191818
19961 <rdar://problem/43907454>
19963 Reviewed by Dean Jackson.
19965 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
19967 2018-11-23 Zalan Bujtas <zalan@apple.com>
19969 [LFC][IFC] Add support for variable height runs.
19970 https://bugs.webkit.org/show_bug.cgi?id=191925
19972 Reviewed by Antti Koivisto.
19974 * LayoutReloaded/misc/LFC-passing-tests.txt:
19976 2018-11-23 Alberto Garcia <berto@igalia.com>
19978 [GTK] [WPE] Tools/Platform{GTK,WPE}.cmake files missing from the tarballs
19979 https://bugs.webkit.org/show_bug.cgi?id=191923
19981 Add Tools/PlatformGTK.cmake and Tools/PlatformWPE.cmake to their
19982 respective tarballs.
19984 Reviewed by Carlos Garcia Campos.
19986 * gtk/manifest.txt.in:
19987 * wpe/manifest.txt.in:
19989 2018-11-22 Chris Dumez <cdumez@apple.com>
19991 Regression(r238353) Load sometimes hangs when navigating back after a cross-site navigation
19992 https://bugs.webkit.org/show_bug.cgi?id=191914
19994 Reviewed by Ryosuke Niwa.
19996 Add API test coverage.
19998 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
20000 2018-11-22 Zalan Bujtas <zalan@apple.com>
20002 [LFC][IFC] Offset formatting context root runs with horizontal margins.
20003 https://bugs.webkit.org/show_bug.cgi?id=191900
20005 Reviewed by Antti Koivisto.
20007 * LayoutReloaded/misc/LFC-passing-tests.txt:
20009 2018-11-22 Philippe Normand <pnormand@igalia.com>
20011 [GTK] Remove unmaintained bots
20012 https://bugs.webkit.org/show_bug.cgi?id=191467
20014 Reviewed by Alex Christensen.
20016 The Linux 32-bits and ARM build-slaves are no longer maintained
20017 and have been failing for months, so get rid of them.
20019 * BuildSlaveSupport/build.webkit.org-config/config.json:
20020 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
20022 * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
20024 2018-11-22 Thibault Saunier <tsaunier@igalia.com>
20026 [Flatpak] Do not disable signals when running "usual" commands
20027 https://bugs.webkit.org/show_bug.cgi?id=190679
20029 Reviewed by Philippe Normand.
20031 Otherwise <ctr>c doesn't work while compiling. It is not the best fix
20032 as there are cases we want to let only children receive signals, but
20033 it is not clear how to determine when (when running gdb, we still
20036 * flatpak/flatpakutils.py:
20037 (WebkitFlatpak.run_in_sandbox):
20039 2018-11-21 Wenson Hsieh <wenson_hsieh@apple.com>
20041 [Cocoa] [WebKit2] Add support for replacing find-in-page text matches
20042 https://bugs.webkit.org/show_bug.cgi?id=191786
20043 <rdar://problem/45813871>
20045 Reviewed by Ryosuke Niwa.
20047 * MiniBrowser/mac/WK2BrowserWindowController.m:
20048 (-[WK2BrowserWindowController setFindBarView:]):
20050 Fix a bug in MiniBrowser that prevents AppKit from displaying the "All" button in the find bar after checking
20051 the "Replace" option.
20053 * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
20055 Add an API test to exercise find-and-replace API using WKWebView.
20059 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
20060 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
20061 (WTR::findOptionsFromArray):
20062 (WTR::TestRunner::findString):
20063 (WTR::TestRunner::findStringMatchesInPage):
20064 (WTR::TestRunner::replaceFindMatchesAtIndices):
20066 Add TestRunner hooks to simulate find-in-page and replace.
20068 * WebKitTestRunner/InjectedBundle/TestRunner.h:
20070 2018-11-21 Zalan Bujtas <zalan@apple.com>
20072 [LFC][IFC] Horizontal margins should be considered as non-breakable space
20073 https://bugs.webkit.org/show_bug.cgi?id=191894
20075 Reviewed by Antti Koivisto.
20077 * LayoutReloaded/misc/LFC-passing-tests.txt:
20079 2018-11-21 Zalan Bujtas <zalan@apple.com>
20081 [LFC][IFC] Border should be considered as non-breakable space
20082 https://bugs.webkit.org/show_bug.cgi?id=191891
20084 Reviewed by Antti Koivisto.
20086 * LayoutReloaded/misc/LFC-passing-tests.txt:
20088 2018-11-21 Zalan Bujtas <zalan@apple.com>
20090 [LFC][IFC] Take nonBreakableStart/End into use.
20091 https://bugs.webkit.org/show_bug.cgi?id=191873
20093 Reviewed by Antti Koivisto.
20095 * LayoutReloaded/misc/LFC-passing-tests.txt:
20097 2018-11-20 Jeff Miller <jeffm@apple.com>
20099 Return nullptr immediately if the key doesn't exist in the HashMap.
20100 https://bugs.webkit.org/show_bug.cgi?id=191841
20102 Reviewed by Chris Dumez.
20104 Add a test that would crash prior to the fix for this bug.
20106 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20107 * TestWebKitAPI/Tests/WebKitCocoa/WKNSDictionaryEmptyDictionaryCrash.mm: Added.
20108 (TestWebKitAPI::TEST):
20110 2018-11-19 Alex Christensen <achristensen@webkit.org>
20112 Add SPI to disable JIT in a WKWebView
20113 https://bugs.webkit.org/show_bug.cgi?id=191822
20114 <rdar://problem/28119360>
20116 Reviewed by Geoffrey Garen.
20118 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20119 * TestWebKitAPI/Tests/WebKitCocoa/DisableJIT.mm: Added.
20122 2018-11-19 Basuke Suzuki <basuke.suzuki@sony.com>
20124 [Curl] Add API for CertificateInfo.
20125 https://bugs.webkit.org/show_bug.cgi?id=191647
20127 Reviewed by Alex Christensen.
20129 Added test for new WKCertificateInfo API.
20131 * TestWebKitAPI/PlatformWin.cmake:
20132 * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Added.
20133 (TestWebKitAPI::Curl::makeCertificateInfo):
20134 (TestWebKitAPI::Curl::isSamePEM):
20135 (TestWebKitAPI::Curl::TEST):
20137 2018-11-19 Wenson Hsieh <wenson_hsieh@apple.com>
20139 Unreviewed, fix the internal iOS debug build after r238380
20141 UICalloutBar should only be declared when the public (non-internal) SDK is used to build WebKit; otherwise, we
20142 end up with duplicate declarations of UICalloutBar.
20144 * TestWebKitAPI/ios/UIKitSPI.h:
20146 2018-11-19 David Quesada <david_quesada@apple.com>
20148 EXC_BAD_ACCESS when invoking a DownloadProxy's destination decision handler after the download has been canceled
20149 https://bugs.webkit.org/show_bug.cgi?id=191762
20150 rdar://problem/46151509
20152 Reviewed by Dean Jackson.
20154 * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
20155 Enable the Download API test on iOS, since the platform supports downloads. All the
20156 tests pass already, except for one which was written using AppKit-specific code:
20157 TEST(_WKDownload, RedirectedDownload):
20158 Use a more platform-agnostic approach to starting the download in this API test.
20159 Instead of manually triggering an NSMenu item to download a file from a link, the
20160 test will simulate a user-initiated click on the link, and the navigation delegate
20161 will direct the web view to start a download based on the link's navigation action.
20162 Additionally, remove the manual creation of a new NSWindow. TestWKWebView makes its
20164 TEST(_WKDownload, DownloadCanceledWhileDecidingDestination):
20165 Add an API test _WKDownload.DownloadCanceledWhileDecidingDestination to simulate the
20166 conditions that would trigger this crash - handling a download's -decideDestination…
20167 delegate call by canceling the download, waiting for the UI process to be notified
20168 that the download has been canceled, and calling the decision handler. This should
20170 (-[CancelDownloadWhileDecidingDestinationDelegate _downloadDidFinish:]):
20171 (-[CancelDownloadWhileDecidingDestinationDelegate _download:didFailWithError:]):
20172 (-[CancelDownloadWhileDecidingDestinationDelegate _downloadDidCancel:]):
20173 (-[CancelDownloadWhileDecidingDestinationDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
20174 (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]): Deleted.
20175 * TestWebKitAPI/cocoa/TestWKWebView.h:
20176 * TestWebKitAPI/cocoa/TestWKWebView.mm:
20177 (-[TestWKWebView objectByEvaluatingJavaScriptWithUserGesture:]):
20178 Add a user-initated version of -objectByEvaluatingJavaScript:. This is needed in
20179 order to maintain the behavior of the RedirectedDownload test, which verifies the
20180 state of the _WKDownload.wasUserInitiated property.
20182 2018-11-19 Wenson Hsieh <wenson_hsieh@apple.com>
20184 [iOS Debug] Assertion failure in NSComparisonResult UIContentSizeCategoryCompareToCategory()
20185 https://bugs.webkit.org/show_bug.cgi?id=190401
20186 <rdar://problem/45195285>
20188 Reviewed by Dean Jackson.
20190 Work around sporadic UIKit assertions when running API tests that may present a UICalloutBar. Currently, UIKit
20191 asks for the `UIApp`’s `-preferredContentSizeCategory` when showing or laying out the callout bar. However,
20192 TestWebKitAPI lacks a UIApp altogether, and forcing one to be initialized via `UIApplicationInstantiateSingleton`
20193 causes numerous other UIKit and WebKit assertions to be hit.
20195 In lieu of TestWebKitAPI becoming a real UI application (see https://webkit.org/b/175204), simply don't allow
20196 the callout bar to be initialized in TestWKWebView-based API tests. This encompasses all API tests which
20197 have some chance of causing the callout bar to be shown by making a ranged text selections during the test.
20199 * TestWebKitAPI/cocoa/TestWKWebView.mm:
20200 (suppressUICalloutBar):
20201 (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
20202 * TestWebKitAPI/ios/UIKitSPI.h:
20204 2018-11-19 Fujii Hironori <Hironori.Fujii@sony.com>
20206 REGRESSION(r238016)[GTK][TestWebKitAPI][Ninja] TestJSC can't compile "Bytecodes.h: No such file or directory"
20207 https://bugs.webkit.org/show_bug.cgi?id=191692
20209 Reviewed by Michael Catanzaro.
20211 r238016 added a new #include, and requires JSC's derived headers
20212 to be copied into the forwarding header directory.
20214 WEBKIT_MAKE_FORWARDING_HEADERS is using POST_BUILD event to copy
20215 derived headers to the forwarding header directory. This is done
20216 after linking JSC library.
20218 GTK port has TestJSC which has a dependency to JSC static library.
20219 And, this dependency is a link time dependency which means
20220 compiling source files of TestJSC starts before the POST_BUILD
20221 event of JSC. Thus, required header can't be found.
20223 Add an intermediate target between TestJSC and JavaScriptCore to
20224 ensure derived headers are copied into the forwarding header
20227 * TestWebKitAPI/PlatformGTK.cmake: Added a new custom target pre-TestJSC.
20228 * TestWebKitAPI/PlatformWPE.cmake: Ditto.
20230 2018-11-19 Alejandro G. Castro <alex@igalia.com>
20232 [GTK][WPE] Solve some issues in the enumerateDevices code
20233 https://bugs.webkit.org/show_bug.cgi?id=191832
20235 Reviewed by Carlos Garcia Campos.
20237 * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
20238 (serverCallback): Make all the Strings with HTML code static.
20239 (testWebsiteDataDeviceIdHashSalt): Change the webView settings in
20241 * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
20242 (WebViewTest::initializeWebView): Remove the initialization of the
20243 webView settings, we now do it in the specific test.
20245 2018-11-18 Chris Dumez <cdumez@apple.com>
20247 [PSON] Received an invalid message "WebPageProxy.DidPerformClientRedirect" from the web process
20248 https://bugs.webkit.org/show_bug.cgi?id=191828
20250 Reviewed by Antti Koivisto.
20252 Add API test coverage.
20254 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20255 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
20256 * TestWebKitAPI/Tests/WebKitCocoa/client-side-redirect.html: Added.
20258 2018-11-17 Wenson Hsieh <wenson_hsieh@apple.com>
20260 [iOS] Remove all usages of UIItemProvider, UIItemProviderReading, and related classes
20261 https://bugs.webkit.org/show_bug.cgi?id=191819
20263 Reviewed by Dan Bernstein.
20265 Replace UIItemProvider (and related classes) with NSItemProvider.
20267 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
20269 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
20270 (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
20272 Replace usages of this deprecated method with `-registerDataRepresentationForTypeIdentifier:visibility:loadHandler:`.
20274 (checkEstimatedSize):
20275 (checkSuggestedNameAndEstimatedSize):
20276 (TestWebKitAPI::TEST):
20277 (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]): Deleted.
20278 * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
20279 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
20280 (-[MockDragDropSession canLoadObjectsOfClass:]):
20281 (-[MockDragDropSession canLoadObjectsOfClasses:]):
20282 (-[MockDropSession initWithProviders:location:window:allowMove:]):
20283 (-[MockDropSession canCreateItemsOfClass:]):
20284 (-[DragAndDropSimulator _advanceProgress]):
20285 (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
20286 (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
20287 * TestWebKitAPI/ios/UIKitSPI.h:
20289 2018-11-17 Chris Dumez <cdumez@apple.com>
20291 ASSERTION FAILED: m_messageReceivers.contains(...) under ViewGestureController removeMessageReceiver
20292 https://bugs.webkit.org/show_bug.cgi?id=191734
20293 <rdar://problem/46151497>
20295 Reviewed by Ryosuke Niwa.
20297 Add API test coverage.
20299 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
20301 2018-11-17 Zalan Bujtas <zalan@apple.com>
20303 [LFC][IFC] InlineFormattingState::addDetachingRule should accumulate rules.
20304 https://bugs.webkit.org/show_bug.cgi?id=191801
20306 Reviewed by Antti Koivisto.
20308 * LayoutReloaded/misc/LFC-passing-tests.txt:
20310 2018-11-17 Jer Noble <jer.noble@apple.com>
20312 Regression(r233865): Causes synchronous IPC in the middle of layout
20313 https://bugs.webkit.org/show_bug.cgi?id=188307
20314 <rdar://problem/42807306>
20316 Reviewed by Eric Carlson.
20318 Follow-up test fix for r238322:
20320 In ExitFullscreenOnEnterPiP.ElementFullScreen, explicitly make the video
20321 element in element fullscreen the "main content" by playing the video during
20322 a user gesture; only "main content" videos will cause fullscreen mode to exit
20323 when that element is taken into PiP.
20325 In FullscreenZoomInitialFrame.WebKit, the WebView is not visible, so the Page
20326 is considered hidden, and fullscreen is not allowed when the WebView is hidden.
20327 Make the WebView visible by ordering the test window on-screen.
20329 * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html:
20330 * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
20331 (TestWebKitAPI::TEST):
20332 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
20333 (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
20335 2018-11-16 Alex Christensen <achristensen@webkit.org>
20337 Tweak _showSafeBrowsingWarningWithTitle SPI
20338 https://bugs.webkit.org/show_bug.cgi?id=191799
20340 Reviewed by Wenson Hsieh.
20342 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
20345 2018-11-16 Ryosuke Niwa <rniwa@webkit.org>
20347 REGRESSION (r238294): TestWebKitAPI.WKNavigation.ProcessCrashDuringCallback failing on iOS
20348 https://bugs.webkit.org/show_bug.cgi?id=191783
20350 Reviewed by Chris Dumez.
20352 Allow either WKErrorWebContentProcessTerminated or WKErrorWebViewInvalidated since the test
20353 is closing WebView, thereby invalidating the view, which is racing with the process termination.
20355 * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
20358 2018-11-16 Chris Dumez <cdumez@apple.com>
20360 ProcessSwap.DisableForInspector API test is failing
20361 https://bugs.webkit.org/show_bug.cgi?id=191798
20363 Reviewed by Joseph Pecoraro.
20365 We support process swapping when Web Inspector is shown now so update the
20366 API test accordingly.
20368 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
20370 2018-11-16 Ryan Haddad <ryanhaddad@apple.com>
20372 Update buildbot dashboard after Windows 7/10 updates
20373 https://bugs.webkit.org/show_bug.cgi?id=191219
20375 Reviewed by Alexey Proskuryakov.
20377 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
20378 (BubbleQueueServer):
20379 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
20380 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
20382 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
20383 (table.queue-grid tr.platform td.logo::before):
20384 (table.queue-grid tr.platform.windows-10 td.logo::before):
20385 (table.queue-grid tr.platform.wincairo-windows-10 td.logo::before):
20386 (table.queue-grid tr.platform.windows-7 td.logo::before):
20387 (table.queue-grid tr.platform.wincairo-windows-10 img.logo):
20389 2018-11-16 Chris Dumez <cdumez@apple.com>
20391 Regression(PSON) WebKit.GeolocationTransitionToHighAccuracy API test is timing out
20392 https://bugs.webkit.org/show_bug.cgi?id=191789
20394 Reviewed by Alex Christensen.
20396 Relate the 2 test pages so they use the same process since WKContextSetMaximumNumberOfProcesses()
20397 SPI no longer works with PSON / Process prewarming.
20399 * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
20400 (TestWebKitAPI::TEST):
20402 2018-11-16 Jonathan Bedard <jbedard@apple.com>
20404 webkitpy: Retry app installation on watchOS simulators
20405 https://bugs.webkit.org/show_bug.cgi?id=191769
20406 <rdar://problem/46139850>
20408 Reviewed by Aakash Jain.
20410 * Scripts/webkitpy/xcode/simulated_device.py:
20411 (SimulatedDevice.install_app): Retry app installations.
20413 2018-11-16 Zalan Bujtas <zalan@apple.com>
20415 Add DidFirstMeaningfulPaint milestone.
20416 https://bugs.webkit.org/show_bug.cgi?id=191754
20418 Reviewed by Simon Fraser.
20420 * TestWebKitAPI/CMakeLists.txt:
20421 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20422 * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp: Added.
20423 (TestWebKitAPI::didReachMilestone):
20424 (TestWebKitAPI::setPageLoaderClient):
20425 (TestWebKitAPI::TEST):
20426 * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone_Bundle.cpp: Copied from Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h.
20427 (TestWebKitAPI::FirstMeaningfulPaintMilestoneTest::FirstMeaningfulPaintMilestoneTest):
20428 (TestWebKitAPI::FirstMeaningfulPaintMilestoneTest::didCreatePage):
20430 2018-11-16 Takashi Komori <Takashi.Komori@sony.com>
20432 [WinCairo][WebKitTestRunner] Test contents window is displayed while testing.
20433 https://bugs.webkit.org/show_bug.cgi?id=191593
20435 Reviewed by Alex Christensen.
20437 Hide TestRunner window and taskbar button.
20439 * WebKitTestRunner/win/PlatformWebViewWin.cpp:
20440 (WTR::PlatformWebView::PlatformWebView):
20441 (WTR::PlatformWebView::windowSnapshotImage):
20443 2018-11-16 Alex Christensen <achristensen@webkit.org>
20445 Add API to disable safe browsing checks
20446 https://bugs.webkit.org/show_bug.cgi?id=191610
20448 Reviewed by Dean Jackson.
20450 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
20453 (safeBrowsingView):
20454 (simpleURL): Deleted.
20456 2018-11-16 Zalan Bujtas <zalan@apple.com>
20458 [LFC][IFC] Add support for out-of-flow positioned boxes
20459 https://bugs.webkit.org/show_bug.cgi?id=191726
20461 Reviewed by Antti Koivisto.
20463 * LayoutReloaded/misc/LFC-passing-tests.txt:
20465 2018-11-15 Myles C. Maxfield <mmaxfield@apple.com>
20467 WKPreferencesSetFontSmoothingLevel doesn't actually do anything
20468 https://bugs.webkit.org/show_bug.cgi?id=191708
20470 Reviewed by Simon Fraser.
20472 Delete the symbol because no one calls it and it doesn't do anything
20474 * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
20475 (TestWebKitAPI::TEST):
20476 * WebKitTestRunner/TestController.cpp:
20477 (WTR::TestController::resetPreferencesToConsistentValues):
20479 2018-11-15 Truitt Savell <tsavell@apple.com>
20481 Unreviewed, rolling out r238244.
20483 Caused High Sierra test runs to fail early with 50 crashes and
20484 casued 25 API failures.
20486 Reverted changeset:
20488 "[css-logical] Implement flow-relative margin, padding and
20490 https://bugs.webkit.org/show_bug.cgi?id=188697
20491 https://trac.webkit.org/changeset/238244
20493 2018-11-15 Aakash Jain <aakash_jain@apple.com>
20495 Increase EWS lock timeout to 3 hours
20496 https://bugs.webkit.org/show_bug.cgi?id=191705
20498 Reviewed by Alexey Proskuryakov.
20500 * QueueStatusServer/config/queues.py: Increased EWS lock timeout to 3 hours.
20502 2018-11-15 Chris Dumez <cdumez@apple.com>
20504 IndexedDB.IndexedDBTempFileSize API test times out with process prewarming enabled
20505 https://bugs.webkit.org/show_bug.cgi?id=191671
20506 <rdar://problem/46086062>
20508 Reviewed by Alex Christensen.
20510 Add API test coverage.
20512 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
20513 * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
20516 2018-11-15 Oriol Brufau <obrufau@igalia.com>
20518 [css-logical] Implement flow-relative margin, padding and border shorthands
20519 https://bugs.webkit.org/show_bug.cgi?id=188697
20521 Reviewed by Simon Fraser and Antti Koivisto.
20523 * DumpRenderTree/TestOptions.cpp:
20524 (TestOptions::TestOptions):
20525 * DumpRenderTree/TestOptions.h:
20526 * DumpRenderTree/mac/DumpRenderTree.mm:
20527 (setWebPreferencesForTestOptions):
20528 Allow tests to enable the CSSLogicalEnabled flag in WK1.
20530 * Scripts/webkitpy/style/checkers/jsonchecker.py:
20531 (JSONCSSPropertiesChecker.check_codegen_properties):
20532 Allow CSS property definitions to have a 'runtime-flag' parameter which
20533 disables the property when the specified runtime flag is disabled.
20535 2018-11-15 Timothy Hatcher <timothy@apple.com>
20537 REGRESSION (r238212): WebKit.BackgroundColor* API test failures.
20538 https://bugs.webkit.org/show_bug.cgi?id=191697
20539 rdar://problem/46098570
20541 Reviewed by Dean Jackson.
20543 * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
20544 (TestWebKitAPI::TEST): Updated for new default background color.
20546 2018-11-15 Jonathan Bedard <jbedard@apple.com>
20548 webkitpy: Check for specific process instead of using data migrator (Follow-up fix)
20549 https://bugs.webkit.org/show_bug.cgi?id=191551
20550 <rdar://problem/45993156>
20552 Reviewed by Aakash Jain.
20554 * Scripts/webkitpy/xcode/simulated_device.py:
20555 (SimulatedDevice.is_usable): Use software_variant instead of software_version for watchOS.
20557 2018-11-15 Daniel Bates <dabates@apple.com>
20559 [iOS] Shift + Tab does not focus previous field
20560 https://bugs.webkit.org/show_bug.cgi?id=191596
20561 <rdar://problem/45892053>
20563 Reviewed by Wenson Hsieh.
20565 Add infrastructure to support testing a key down event with modifiers by creating
20566 and dispatching a UIEvent. This infrastructure replaces the previous mechanism in
20567 Tools/WebKitTestRunner/ios/HIDEventGenerator.mm to generate a IOHIDEvent for a
20568 keydown as it did not support creating an event with modifier key state that would
20569 be recognized by UIKit.
20571 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
20572 (WTR::UIScriptController::keyDown):
20573 (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
20574 (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
20575 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
20576 Add function uiController.keyDown() that takes a character that represents a keyboard key
20577 and an array of modifier keys. The behavior of this function is analogous to eventSender.keyDown().
20578 Remove functions uiController.keyDownUsingHardwareKeyboard() and uiController.keyUpUsingHardwareKeyboard()
20579 as the former is replaced by uiController.keyDown() and the latter was never used.
20581 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
20582 (WTR::UIScriptController::keyDown): Added.
20583 (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
20584 (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
20585 * TestRunnerShared/UIScriptContext/UIScriptController.h:
20586 * WebKitTestRunner/ios/HIDEventGenerator.h:
20587 * WebKitTestRunner/ios/HIDEventGenerator.mm:
20588 (createHIDKeyDownEvent): Added.
20589 (-[HIDEventGenerator keyDown:completionBlock:]): Deleted.
20590 (-[HIDEventGenerator keyUp:completionBlock:]): Deleted.
20591 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
20592 (WTR::arrayLength): Added.
20593 (WTR::parseModifier): Added.
20594 (WTR::parseModifierArray): Added.
20595 (WTR::UIScriptController::keyDown):
20596 (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
20597 (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
20599 2018-11-15 Keith Rollin <krollin@apple.com>
20601 Delete old .xcfilelist files
20602 https://bugs.webkit.org/show_bug.cgi?id=191669
20603 <rdar://problem/46081994>
20605 Reviewed by Chris Dumez.
20607 .xcfilelist files were created and added to the Xcode project files in
20608 https://trac.webkit.org/changeset/238008/webkit. However, they caused
20609 build issues and they were removed from the Xcode projects in
20610 https://trac.webkit.org/changeset/238055/webkit. This check-in removes
20611 the files from the repository altogether. They'll ultimately be
20612 replaced with new files with names that indicate whether the
20613 associated files are inputs to the Run Script phase or are files
20614 created by the Run Script phase.
20616 * DumpRenderTree/DerivedSources.xcfilelist: Removed.
20617 * WebKitTestRunner/DerivedSources.xcfilelist: Removed.
20619 2018-11-14 Zalan Butjas <zalan@apple.com>
20621 [LFC][IFC] Add support for in-flow positioned inline boxes.
20622 https://bugs.webkit.org/show_bug.cgi?id=191672
20624 Reviewed by Antti Koivisto.
20626 * LayoutReloaded/misc/LFC-passing-tests.txt:
20628 2018-11-14 Keith Rollin <krollin@apple.com>
20630 Move scripts for Derived and Unified Sources to external files
20631 https://bugs.webkit.org/show_bug.cgi?id=191670
20632 <rdar://problem/46082278>
20634 Reviewed by Keith Miller.
20636 Move the scripts in the Generate Derived Sources and Generate Unified
20637 Sources Run Script phases from the Xcode projects to external shell
20638 script files. Then invoke those scripts from the Run Script phases.
20639 This refactoring is being performed to support later work that will
20640 invoke these scripts in other contexts.
20642 The scripts were maintained as-is when making the move. I did a little
20643 reformatting and added 'set -e' to the top of each file, but that's
20646 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
20647 * DumpRenderTree/Scripts/generate-derived-sources.sh: Added.
20648 * WebKitTestRunner/Scripts/generate-derived-sources.sh: Added.
20649 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
20651 2018-11-14 Chris Dumez <cdumez@apple.com>
20653 WebKit.DecidePolicyForNavigationActionForHyperlinkThatRedirects API fails when PSON is enabled
20654 https://bugs.webkit.org/show_bug.cgi?id=191640
20656 Reviewed by Alex Christensen.
20658 Add API test coverage.
20660 * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
20661 (runDecidePolicyForNavigationActionForHyperlinkThatRedirects):
20664 2018-11-14 Chris Dumez <cdumez@apple.com>
20666 REGRESSION (r238115): [iOS] TestWebKitAPI.ProcessSwap.NavigateToInvalidURL is failing
20667 https://bugs.webkit.org/show_bug.cgi?id=191660
20669 Reviewed by Ryosuke Niwa.
20671 The test tries to navigate to an invalid URL and makes sure that we do not process swap
20672 for such load. The test was inherently racing because it was doing:
20673 <body onload="setTimeout(() => alert('DONE'), 0); location.href = 'http://A=a%B=b'">
20675 Its load event handler tries to navigate to 'http://A=a%B=b' and sets a 0 timer to
20676 log an alert, which causes the API test to keep going and check that we did not swap
20677 process. The issue is that a 0 timer may not be sufficient to trigger the load, as
20678 the policy decision is asynchronous and relies on the UIProcess responding to it.
20680 To address the issue, the test now waits for the next policy decision, spins the
20681 run loop and then makes sure we did not swap process. It no longer relies on a message
20684 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
20685 (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
20687 2018-11-14 Chris Dumez <cdumez@apple.com>
20689 WebKit.WebsiteDataStoreCustomPaths API test is failing when enabling process prewarming
20690 https://bugs.webkit.org/show_bug.cgi?id=191638
20692 Reviewed by Alex Christensen.
20694 Add API test coverage.
20696 * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
20697 (runWebsiteDataStoreCustomPaths):
20700 2018-11-14 Alex Christensen <achristensen@webkit.org>
20702 Add SPI to show a safe browsing warning
20703 https://bugs.webkit.org/show_bug.cgi?id=191604
20705 Reviewed by Andy Estes.
20707 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
20710 2018-11-14 Wenson Hsieh <wenson_hsieh@apple.com>
20712 [iOS] A few drag and drop tests are crashing after r238146
20713 https://bugs.webkit.org/show_bug.cgi?id=191617
20715 Reviewed by Dean Jackson.
20717 Augment these crashing tests to verify that selection commands are suppressed during drop over editable elements
20718 via more robust means. These tests currently hit an assertion when revealing the callout bar too early, because
20719 TestWebKitAPI is not a UI application (see <https://webkit.org/b/190401>).
20721 Instead of relying on this other bug, directly ask the text input whether it is suppressing selection commands
20722 during a drop, and remember the answer via DragAndDropSimulator.
20724 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
20725 (TestWebKitAPI::TEST):
20727 Add to the existing tests that started failing after r238146.
20729 * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
20730 * TestWebKitAPI/cocoa/TestWKWebView.h:
20731 * TestWebKitAPI/cocoa/TestWKWebView.mm:
20732 (-[TestWKWebView textInputContentView]):
20733 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
20734 (-[DragAndDropSimulator _resetSimulatedState]):
20735 (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
20736 * TestWebKitAPI/ios/UIKitSPI.h:
20738 2018-11-14 Wenson Hsieh <wenson_hsieh@apple.com>
20740 [Cocoa] [WebKit2] Hook up some more editing actions (-pasteAndMatchStyle:, -makeTextWritingDirectionNatural:)
20741 https://bugs.webkit.org/show_bug.cgi?id=191605
20742 <rdar://problem/45813991>
20744 Reviewed by Dean Jackson.
20746 Adds two new API tests to exercise -_pasteAndMatchStyle: and -makeTextWritingDirectionNatural:.
20748 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
20749 (-[TestWKWebView _synchronouslyExecuteEditCommand:argument:]): Deleted.
20750 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
20751 (TestWebKitAPI::TEST):
20752 * TestWebKitAPI/cocoa/TestWKWebView.h:
20753 * TestWebKitAPI/cocoa/TestWKWebView.mm:
20755 Pull `-_synchronouslyExecuteEditCommand:argument:` out of WKAttachmentTests and into shared code, in a new
20756 category on WKWebView declared in TestWKWebView. Also, fix an unrelated typo in a nearby category.
20758 (-[WKWebView _synchronouslyExecuteEditCommand:argument:]):
20759 * TestWebKitAPI/ios/UIKitSPI.h:
20761 2018-11-14 Chris Dumez <cdumez@apple.com>
20763 WebKit.ApplicationManifestBasic API test is failing when enabling PSON
20764 https://bugs.webkit.org/show_bug.cgi?id=191602
20766 Reviewed by Alex Christensen.
20768 Add API test coverage.
20770 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
20772 2018-11-14 Jonathan Bedard <jbedard@apple.com>
20774 webkitpy: Refactor port code for devices
20775 https://bugs.webkit.org/show_bug.cgi?id=191568
20776 <rdar://problem/46005821>
20778 Reviewed by Alex Christensen.
20780 watchOS and iOS device ports share many characteristics in testing, mostly due
20781 to the fact that both are devices.
20783 * Scripts/webkitpy/port/device_port.py: Added.
20784 (DevicePort): Add base class that all simulated/physical device ports share.
20785 (DevicePort.__init__):
20786 (DevicePort.driver_cmd_line_for_logging): Moved from iOS port.
20787 (DevicePort._generate_all_test_configurations): Ditto.
20788 (DevicePort.child_processes): Ditto.
20789 (DevicePort.driver_name): Ditto.
20790 (DevicePort.target_host): Generalize worker access to attached devices and
20791 simulated devices based on the device manager.
20792 (DevicePort.devices): Return a list of all devices associated with this port.
20793 (DevicePort._create_devices):
20794 (DevicePort._build_driver_flags): Moved from iOSSimulatorPort/iOSDevicePort.
20795 (DevicePort._install): Moved from iOS port.
20796 (DevicePort.setup_test_run): Ditto.
20797 (DevicePort.clean_up_test_run): Ditto.
20798 (DevicePort.did_spawn_worker): Ditto.
20799 (DevicePort.setup_environ_for_server): Ditto.
20800 * Scripts/webkitpy/port/ios.py:
20802 (IOSPort._device_for_worker_number_map): Replaced by DevicePort.devices().
20803 (IOSPort.driver_cmd_line_for_logging): Moved to DevicePort.
20804 (IOSPort.driver_name): Ditto.
20805 (IOSPort._generate_all_test_configurations): Ditto.
20806 (IOSPort.child_processes): Ditto.
20807 (IOSPort._testing_device): Ditto.
20808 (IOSPort.target_host): Ditto.
20809 (IOSPort._create_devices): Ditto.
20810 (IOSPort.setup_test_run): Ditto.
20811 (IOSPort.clean_up_test_run): Ditto.
20812 (IOSPort.did_spawn_worker): Ditto.
20813 * Scripts/webkitpy/port/ios_device.py:
20814 (IOSDevicePort): IOSDevicePort uses a device manager from apple_additions.
20815 (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Use DevicePort.devices().
20816 (IOSDevicePort._get_crash_log): Ditto.
20817 (IOSDevicePort.ios_version): Ditto.
20818 (IOSDevicePort._create_devices): Ditto.
20819 (IOSDevicePort._device_for_worker_number_map): Replaced by DevicePort.devices().
20820 (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
20821 * Scripts/webkitpy/port/ios_device_unittest.py:
20822 (IOSDeviceTest.test_get_crash_log):
20823 * Scripts/webkitpy/port/ios_simulator.py:
20824 (IOSSimulatorPort): IOSSimulatorPort uses the SimulatedDeviceManager.
20825 (IOSSimulatorPort._create_devices): Clean up logging statement.
20826 (IOSSimulatorPort.setup_environ_for_server): Some of environment set-up is shared
20827 across all devices.
20828 (IOSSimulatorPort._device_for_worker_number_map): Replaced by DevicePort.devices().
20829 (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
20830 * Scripts/webkitpy/port/ios_simulator_unittest.py:
20831 (IOSSimulatorTest.test_32bit):
20832 (IOSSimulatorTest.test_64bit):
20834 2018-11-14 Chris Dumez <cdumez@apple.com>
20836 WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process prewarming is enabled
20837 https://bugs.webkit.org/show_bug.cgi?id=191624
20839 Reviewed by Alex Christensen.
20841 Add API test coverage.
20843 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
20844 (runWKHTTPCookieStoreWithoutProcessPool):
20847 2018-11-13 Jiewen Tan <jiewen_tan@apple.com>
20849 [WebAuthN] Support CTAP HID authenticators on macOS
20850 https://bugs.webkit.org/show_bug.cgi?id=188623
20851 <rdar://problem/43353777>
20853 Reviewed by Brent Fulgham and Chris Dumez.
20855 This patch adds support for the mock testing and entitlements to allow minibrowser to talk
20858 * MiniBrowser/MiniBrowser.entitlements:
20859 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
20860 (WTR::TestRunner::setWebAuthenticationMockConfiguration):
20862 2018-11-13 Ryosuke Niwa <rniwa@webkit.org>
20864 WebKit.GeolocationTransitionToLowAccuracy API crashes when enabling PSON
20865 https://bugs.webkit.org/show_bug.cgi?id=191616
20867 Reviewed by Chris Dumez.
20869 The crash was caused by WKView in autorelease pool invoking stopUpdatingCallback after
20870 GeolocationTransitionToLowAccuracyStateTracker in the stack had been destroyed,
20871 resulting in the use-after-free.
20873 Made the tests more robust by clearing geolocation provider before exiting each test
20874 since we can't really prevent WKView from entering an autorelease pool.
20876 Also made WebKit.GeolocationTransitionToLowAccuracy wait for the success callback
20877 instead of simply the end of the navigation so that the test would continue to work
20878 even if a web content process was created for the second web view (lowAccuracyWebView)
20880 * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
20881 (TestWebKitAPI::setupGeolocationProvider): Moved "*" to match the WebKit coding style guideline.
20882 (TestWebKitAPI::clearGeolocationProvider): Added.
20883 (TestWebKitAPI::runJavaScriptAlert): Added.
20884 (TestWebKitAPI::didFinishNavigation): Deleted.
20885 * TestWebKitAPI/Tests/WebKit/geolocationWatchPosition.html:
20887 2018-11-13 Chris Dumez <cdumez@apple.com>
20889 WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
20890 https://bugs.webkit.org/show_bug.cgi?id=191618
20892 Reviewed by Ryosuke Niwa.
20894 Update API test to explicitly disable automatic process prewarning since it is testing
20897 * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
20900 2018-11-13 Chris Dumez <cdumez@apple.com>
20902 Several Service Worker API tests are failing when enabling PSON
20903 https://bugs.webkit.org/show_bug.cgi?id=191619
20905 Reviewed by Youenn Fablet.
20907 Update tests to use _webProcessCountIgnoringPrewarmed instead of _webProcessCount so that they are
20908 not impacted by process prewarming.
20910 * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
20912 2018-11-13 Wenson Hsieh <wenson_hsieh@apple.com>
20914 [iOS] Do not show selection UI for editable elements with opacity near zero
20915 https://bugs.webkit.org/show_bug.cgi?id=191442
20916 <rdar://problem/45958625>
20918 Reviewed by Simon Fraser.
20920 Add a couple of new testing helpers to UIScriptController.
20922 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
20923 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
20924 (WTR::UIScriptController::textSelectionRangeRects const):
20925 (WTR::UIScriptController::selectionCaretViewRect const):
20926 (WTR::UIScriptController::selectionRangeViewRects const):
20927 * TestRunnerShared/UIScriptContext/UIScriptController.h:
20928 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
20929 (WTR::UIScriptController::textSelectionRangeRects const):
20931 Rename `selectionRangeViewRects` to `textSelectionRangeRects`. This allows us to draw a distinction between
20932 `textSelectionRangeRects`/`textSelectionCaretRect`, which retrieve information about selection rects known
20933 to the text interaction assistant, and `selectionCaretViewRect`/`selectionRangeViewRects`, which retrieve the
20934 actual frames of the selection views used to draw overlaid selection UI. This difference is important in the
20935 new layout tests added in this patch, which only suppress caret rendering (i.e. selection views remain hidden).
20937 Also, drive-by fix a leaked `NSMutableArray`.
20939 (WTR::UIScriptController::selectionStartGrabberViewRect const):
20940 (WTR::UIScriptController::selectionEndGrabberViewRect const):
20941 (WTR::UIScriptController::selectionCaretViewRect const):
20942 (WTR::UIScriptController::selectionRangeViewRects const):
20944 Testing helpers to grab the frames of caret and selection views, in WKContentView's coordinate space. These
20945 rects are also clamped to WKContentView bounds.
20947 2018-11-13 Daniel Bates <dabates@apple.com>
20949 Consolidate WebKit UIKitSPI.h and UIKitTestSPI.h
20950 https://bugs.webkit.org/show_bug.cgi?id=173341
20951 <rdar://problem/32752890>
20953 Reviewed by Simon Fraser.
20955 There is little value to making a distinction between forward declarations
20956 of UIKit SPI needed in the WebKit layer and just for testing. Moreover,
20957 the contents of these two headers can conflict with each other following
20958 r218275 as DumpRenderTree includes both headers. Instead we should remove
20959 UIKitTestSPI.h and have WebKitTestRunner include the WebKit variant, UIKitSPI.h.
20961 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
20962 * DumpRenderTree/mac/DumpRenderTree.mm:
20963 * TestRunnerShared/spi/UIKitTestSPI.h: Removed.
20964 * WebKitTestRunner/Configurations/Base.xcconfig:
20965 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
20966 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
20967 * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
20968 * WebKitTestRunner/ios/HIDEventGenerator.h:
20969 * WebKitTestRunner/ios/HIDEventGenerator.mm:
20970 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
20971 * WebKitTestRunner/ios/TestControllerIOS.mm:
20972 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
20973 * WebKitTestRunner/ios/mainIOS.mm:
20975 2018-11-13 Takashi Komori <Takashi.Komori@sony.com>
20977 Remove WebKitTestRunnerLib's build warnings.
20978 https://bugs.webkit.org/show_bug.cgi?id=191580
20980 Reviewed by Fujii Hironori.
20982 Include cmakeconfig.h in precompiled header.
20984 * WebKitTestRunner/WebKitTestRunnerPrefix.h:
20986 2018-11-12 Darshan Kadu <darsh7807@gmail.com>
20988 Implement Cache API support for WPE/GTK
20989 https://bugs.webkit.org/show_bug.cgi?id=178316
20991 Reviewed by Michael Catanzaro.
20993 Called WKWebsiteDataStoreSetCacheStoragePerOriginQuota function to set the cache limit to 400 * 1200
20994 on all the platforms in TestController.cpp. Also, removed the setCacheStoragePerOriginQuota call from TestControllerCocoa.mm
20996 * WebKitTestRunner/TestController.cpp:
20997 (WTR::TestController::generatePageConfiguration):
20998 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
20999 (WTR::initializeWebViewConfiguration):
21001 2018-11-12 Christopher Reid <chris.reid@sony.com>
21003 [Curl] Reject entire cookie if the domain fails a tailmatch.
21004 https://bugs.webkit.org/show_bug.cgi?id=191406
21006 Reviewed by Youenn Fablet.
21008 Added unittests for Curl cookie implementation.
21010 * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
21011 (TestWebKitAPI::Curl::CurlCookies::RejectTailmatchFailureDomain):
21013 2018-11-12 Alex Christensen <achristensen@webkit.org>
21015 [iOS] Implement safe browsing in WebKit
21016 https://bugs.webkit.org/show_bug.cgi?id=191441
21018 Reviewed by Tim Horton.
21020 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
21021 (checkTitleAndClick):
21024 2018-11-12 Basuke Suzuki <basuke.suzuki@sony.com>
21026 [Curl] Add API Test for Curl cookie backend.
21027 https://bugs.webkit.org/show_bug.cgi?id=191493
21029 Reviewed by Youenn Fablet.
21031 Add unit test to TestWebCore.
21033 * TestWebKitAPI/PlatformWin.cmake:
21034 * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp: Added.
21036 2018-11-12 Tim Horton <timothy_horton@apple.com>
21038 Make it possible to edit images inline
21039 https://bugs.webkit.org/show_bug.cgi?id=191352
21040 <rdar://problem/30107985>
21042 Reviewed by Dean Jackson.
21044 * WebKitTestRunner/TestController.cpp:
21045 (WTR::updateTestOptionsFromTestHeader):
21046 * WebKitTestRunner/TestOptions.h:
21047 (WTR::TestOptions::hasSameInitializationOptions const):
21048 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
21049 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
21050 (WTR::TestController::platformCreateWebView):
21051 Add a test option to enable editable images.
21053 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
21054 (WTR::UIScriptController::drawSquareInEditableImage):
21055 (WTR::UIScriptController::numberOfStrokesInEditableImage):
21056 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
21057 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
21058 (WTR::UIScriptController::drawSquareInEditableImage):
21059 (WTR::UIScriptController::numberOfStrokesInEditableImage):
21060 * TestRunnerShared/UIScriptContext/UIScriptController.h:
21061 * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
21062 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
21063 (WTR::findEditableImageCanvas):
21064 (WTR::UIScriptController::drawSquareInEditableImage):
21065 (WTR::UIScriptController::numberOfStrokesInEditableImage):
21066 Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
21067 and also to retrieve the number of strokes currently on the PKCanvasView.
21068 Currently this just takes the first canvas; we might need to make it
21069 take an identifier or something in the future if we need tests with multiple
21070 canvases. The indirect testing mechanism is required because PKCanvasView
21071 can currently not actually paint its strokes in the Simulator.
21073 2018-11-12 Ryan Haddad <ryanhaddad@apple.com>
21075 [MediaStream] Screen capture should be an experimental feature on OSX only
21076 https://bugs.webkit.org/show_bug.cgi?id=191552
21078 Unreviewed test gardening.
21080 * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Only run these tests on macOS.
21082 2018-11-12 Don Olmstead <don.olmstead@sony.com>
21084 Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
21085 https://bugs.webkit.org/show_bug.cgi?id=189230
21086 <rdar://problem/44050379>
21088 Reviewed by Joseph Pecoraro.
21090 Runs all png images through zopflipng. This results in a smaller file
21091 size and takes care of this issue as a byproduct.
21093 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png:
21094 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png:
21095 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png:
21096 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png:
21097 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
21098 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png:
21099 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png:
21100 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png:
21101 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
21102 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
21103 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
21104 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png:
21105 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png:
21106 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png:
21107 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png:
21108 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png:
21109 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png:
21110 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png:
21111 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png:
21112 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png:
21113 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png:
21114 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png:
21115 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png:
21116 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png:
21117 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
21118 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
21119 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png:
21120 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png:
21121 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png:
21122 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png:
21123 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png:
21124 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png:
21125 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
21126 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
21127 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png:
21128 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png:
21129 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
21130 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
21131 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png:
21132 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png:
21133 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10.png:
21134 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10@2x.png:
21135 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png:
21136 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png:
21137 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png:
21138 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png:
21139 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png:
21140 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png:
21141 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png:
21142 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png:
21144 2018-11-12 Tim Horton <timothy_horton@apple.com>
21146 Modernize WebKit Tools Xcode projects for localization's sake
21147 https://bugs.webkit.org/show_bug.cgi?id=191495
21149 Reviewed by Alexey Proskuryakov.
21151 * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:
21152 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
21153 * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
21154 * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
21155 * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
21156 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
21157 * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
21158 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21159 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
21160 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
21161 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
21162 * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
21163 These are less important because they're not localized, but since
21164 I made the style checker complain, it now complains any time anyone
21165 touches any of these projects... so upgrade them.
21167 2018-11-12 Jonathan Bedard <jbedard@apple.com>
21169 webkitpy: Check for specific process instead of using data migrator
21170 https://bugs.webkit.org/show_bug.cgi?id=191551
21171 <rdar://problem/45993156>
21173 Rubber-stamped by Aakash Jain.
21175 It's possible for the data migrator process to be stuck, but for a simulator to be
21176 usable. Use device-specific processes to detect when a device is usable.
21178 * Scripts/webkitpy/xcode/simulated_device.py:
21179 (SimulatedDeviceManager._wait_until_device_is_usable):
21180 (SimulatedDeviceManager):
21181 (SimulatedDeviceManager.initialize_devices): Explicitly wait until a device is usable
21182 since this implies that a device is booted.
21183 (SimulatedDeviceManager.swap): Ditto.
21184 (SimulatedDevice.is_usable): Check that a device is booted and that a device-specific
21185 process indicating the device is usable can be found.
21186 (SimulatedDeviceManager.wait_until_data_migration_is_done): Deleted.
21187 * Scripts/webkitpy/xcode/simulated_device_unittest.py: Update simctl_json so that
21188 it triggers the logic in is_usable()
21190 2018-11-12 Takashi Komori <Takashi.Komori@sony.com>
21192 Resurrect WebKitTestRunner for Windows port
21193 https://bugs.webkit.org/show_bug.cgi?id=189257
21195 Reviewed by Fujii Hironori.
21197 Implement WebKitTestRunner for WinCairo.
21199 * PlatformWin.cmake:
21200 * Scripts/build-webkittestrunner:
21201 * WebKitTestRunner/CMakeLists.txt:
21202 * WebKitTestRunner/EventSenderProxy.h:
21203 * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
21204 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
21205 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
21206 * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
21207 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
21209 (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
21210 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
21211 (WTR::TestRunner::TestRunner):
21212 * WebKitTestRunner/InjectedBundle/TestRunner.h:
21213 * WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: Added.
21214 (WTR::AccessibilityController::resetToConsistentState):
21215 (WTR::AccessibilityController::accessibleElementById):
21216 (WTR::AccessibilityController::platformName):
21217 (WTR::AccessibilityController::rootElement):
21218 (WTR::AccessibilityController::focusedElement):
21219 (WTR::AccessibilityController::addNotificationListener):
21220 (WTR::AccessibilityController::removeNotificationListener):
21221 * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: Added.
21222 (WTR::AccessibilityUIElement::AccessibilityUIElement):
21223 (WTR::AccessibilityUIElement::~AccessibilityUIElement):
21224 (WTR::AccessibilityUIElement::isEqual):
21225 (WTR::AccessibilityUIElement::getChildren):
21226 (WTR::AccessibilityUIElement::getChildrenWithRange):
21227 (WTR::AccessibilityUIElement::childrenCount):
21228 (WTR::AccessibilityUIElement::elementAtPoint):
21229 (WTR::AccessibilityUIElement::indexOfChild):
21230 (WTR::AccessibilityUIElement::childAtIndex):
21231 (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
21232 (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
21233 (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
21234 (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
21235 (WTR::AccessibilityUIElement::disclosedRowAtIndex):
21236 (WTR::AccessibilityUIElement::rowAtIndex):
21237 (WTR::AccessibilityUIElement::selectedChildAtIndex const):
21238 (WTR::AccessibilityUIElement::selectedChildrenCount const):
21239 (WTR::AccessibilityUIElement::selectedRowAtIndex):
21240 (WTR::AccessibilityUIElement::titleUIElement):
21241 (WTR::AccessibilityUIElement::parentElement):
21242 (WTR::AccessibilityUIElement::disclosedByRow):
21243 (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
21244 (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
21245 (WTR::AccessibilityUIElement::attributesOfChildren):
21246 (WTR::AccessibilityUIElement::allAttributes):
21247 (WTR::AccessibilityUIElement::stringAttributeValue):
21248 (WTR::AccessibilityUIElement::numberAttributeValue):
21249 (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
21250 (WTR::AccessibilityUIElement::rowHeaders const):
21251 (WTR::AccessibilityUIElement::columnHeaders const):
21252 (WTR::AccessibilityUIElement::uiElementAttributeValue const):
21253 (WTR::AccessibilityUIElement::boolAttributeValue):
21254 (WTR::AccessibilityUIElement::isAttributeSettable):
21255 (WTR::AccessibilityUIElement::isAttributeSupported):
21256 (WTR::AccessibilityUIElement::parameterizedAttributeNames):
21257 (WTR::AccessibilityUIElement::role):
21258 (WTR::AccessibilityUIElement::subrole):
21259 (WTR::AccessibilityUIElement::roleDescription):
21260 (WTR::AccessibilityUIElement::computedRoleString):
21261 (WTR::AccessibilityUIElement::title):
21262 (WTR::AccessibilityUIElement::description):
21263 (WTR::AccessibilityUIElement::orientation const):
21264 (WTR::AccessibilityUIElement::stringValue):
21265 (WTR::AccessibilityUIElement::language):
21266 (WTR::AccessibilityUIElement::helpText const):
21267 (WTR::AccessibilityUIElement::x):
21268 (WTR::AccessibilityUIElement::y):
21269 (WTR::AccessibilityUIElement::width):
21270 (WTR::AccessibilityUIElement::height):
21271 (WTR::AccessibilityUIElement::clickPointX):
21272 (WTR::AccessibilityUIElement::clickPointY):
21273 (WTR::AccessibilityUIElement::intValue const):
21274 (WTR::AccessibilityUIElement::minValue):
21275 (WTR::AccessibilityUIElement::maxValue):
21276 (WTR::AccessibilityUIElement::valueDescription):
21277 (WTR::AccessibilityUIElement::insertionPointLineNumber):
21278 (WTR::AccessibilityUIElement::isPressActionSupported):
21279 (WTR::AccessibilityUIElement::isIncrementActionSupported):
21280 (WTR::AccessibilityUIElement::isDecrementActionSupported):
21281 (WTR::AccessibilityUIElement::isEnabled):
21282 (WTR::AccessibilityUIElement::isRequired const):
21283 (WTR::AccessibilityUIElement::isFocused const):
21284 (WTR::AccessibilityUIElement::isSelected const):
21285 (WTR::AccessibilityUIElement::isSelectedOptionActive const):
21286 (WTR::AccessibilityUIElement::isExpanded const):
21287 (WTR::AccessibilityUIElement::isChecked const):
21288 (WTR::AccessibilityUIElement::isIndeterminate const):
21289 (WTR::AccessibilityUIElement::hierarchicalLevel const):
21290 (WTR::AccessibilityUIElement::speakAs):
21291 (WTR::AccessibilityUIElement::ariaIsGrabbed const):
21292 (WTR::AccessibilityUIElement::ariaDropEffects const):
21293 (WTR::AccessibilityUIElement::lineForIndex):
21294 (WTR::AccessibilityUIElement::rangeForLine):
21295 (WTR::AccessibilityUIElement::rangeForPosition):
21296 (WTR::AccessibilityUIElement::boundsForRange):
21297 (WTR::AccessibilityUIElement::stringForRange):
21298 (WTR::AccessibilityUIElement::attributedStringForRange):
21299 (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
21300 (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
21301 (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
21302 (WTR::AccessibilityUIElement::selectTextWithCriteria):
21303 (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
21304 (WTR::AccessibilityUIElement::attributesOfRowHeaders):
21305 (WTR::AccessibilityUIElement::attributesOfColumns):
21306 (WTR::AccessibilityUIElement::attributesOfRows):
21307 (WTR::AccessibilityUIElement::attributesOfVisibleCells):
21308 (WTR::AccessibilityUIElement::attributesOfHeader):
21309 (WTR::AccessibilityUIElement::rowCount):
21310 (WTR::AccessibilityUIElement::columnCount):
21311 (WTR::AccessibilityUIElement::indexInTable):
21312 (WTR::AccessibilityUIElement::rowIndexRange):
21313 (WTR::AccessibilityUIElement::columnIndexRange):
21314 (WTR::AccessibilityUIElement::cellForColumnAndRow):
21315 (WTR::AccessibilityUIElement::horizontalScrollbar const):
21316 (WTR::AccessibilityUIElement::verticalScrollbar const):
21317 (WTR::AccessibilityUIElement::selectedTextRange):
21318 (WTR::AccessibilityUIElement::setSelectedTextRange):
21319 (WTR::AccessibilityUIElement::increment):
21320 (WTR::AccessibilityUIElement::decrement):
21321 (WTR::AccessibilityUIElement::showMenu):
21322 (WTR::AccessibilityUIElement::press):
21323 (WTR::AccessibilityUIElement::setSelectedChild const):
21324 (WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
21325 (WTR::AccessibilityUIElement::removeSelectionAtIndex const):
21326 (WTR::AccessibilityUIElement::clearSelectedChildren const):
21327 (WTR::AccessibilityUIElement::accessibilityValue const):
21328 (WTR::AccessibilityUIElement::documentEncoding):
21329 (WTR::AccessibilityUIElement::documentURI):
21330 (WTR::AccessibilityUIElement::url):
21331 (WTR::AccessibilityUIElement::addNotificationListener):
21332 (WTR::AccessibilityUIElement::removeNotificationListener):
21333 (WTR::AccessibilityUIElement::isFocusable const):
21334 (WTR::AccessibilityUIElement::isSelectable const):
21335 (WTR::AccessibilityUIElement::isMultiSelectable const):
21336 (WTR::AccessibilityUIElement::isVisible const):
21337 (WTR::AccessibilityUIElement::isOffScreen const):
21338 (WTR::AccessibilityUIElement::isCollapsed const):
21339 (WTR::AccessibilityUIElement::isIgnored const):
21340 (WTR::AccessibilityUIElement::isSingleLine const):
21341 (WTR::AccessibilityUIElement::isMultiLine const):
21342 (WTR::AccessibilityUIElement::hasPopup const):
21343 (WTR::AccessibilityUIElement::takeFocus):
21344 (WTR::AccessibilityUIElement::takeSelection):
21345 (WTR::AccessibilityUIElement::addSelection):
21346 (WTR::AccessibilityUIElement::removeSelection):
21347 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
21348 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
21349 (WTR::AccessibilityUIElement::textMarkerRangeLength):
21350 (WTR::AccessibilityUIElement::previousTextMarker):
21351 (WTR::AccessibilityUIElement::nextTextMarker):
21352 (WTR::AccessibilityUIElement::stringForTextMarkerRange):
21353 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
21354 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
21355 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
21356 (WTR::AccessibilityUIElement::endTextMarkerForBounds):
21357 (WTR::AccessibilityUIElement::startTextMarkerForBounds):
21358 (WTR::AccessibilityUIElement::textMarkerForPoint):
21359 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
21360 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
21361 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
21362 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
21363 (WTR::AccessibilityUIElement::indexForTextMarker):
21364 (WTR::AccessibilityUIElement::isTextMarkerValid):
21365 (WTR::AccessibilityUIElement::textMarkerForIndex):
21366 (WTR::AccessibilityUIElement::startTextMarker):
21367 (WTR::AccessibilityUIElement::endTextMarker):
21368 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
21369 (WTR::AccessibilityUIElement::scrollToMakeVisible):
21370 (WTR::AccessibilityUIElement::scrollToGlobalPoint):
21371 (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
21372 (WTR::AccessibilityUIElement::supportedActions const):
21373 (WTR::AccessibilityUIElement::pathDescription const):
21374 (WTR::AccessibilityUIElement::mathPostscriptsDescription const):
21375 (WTR::AccessibilityUIElement::mathPrescriptsDescription const):
21376 (WTR::AccessibilityUIElement::classList const):
21377 (WTR::AccessibilityUIElement::characterAtOffset):
21378 (WTR::AccessibilityUIElement::wordAtOffset):
21379 (WTR::AccessibilityUIElement::lineAtOffset):
21380 (WTR::AccessibilityUIElement::sentenceAtOffset):
21381 * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
21382 (WTR::activateFonts):
21383 (WTR::installFakeHelvetica):
21384 (WTR::uninstallFakeHelvetica):
21385 * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
21386 (WTR::InjectedBundle::platformInitialize):
21387 * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Added.
21388 * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
21389 * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
21390 (WTR::TestRunner::pathToLocalResource):
21391 (WTR::TestRunner::inspectorTestStubURL):
21392 (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
21393 (WTR::TestRunner::platformInitialize):
21394 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
21395 (WTR::TestRunner::installFakeHelvetica):
21396 * WebKitTestRunner/PlatformWebView.h:
21397 * WebKitTestRunner/PlatformWin.cmake: Added.
21398 * WebKitTestRunner/TestController.cpp:
21399 (WTR::TestController::resetStateToConsistentValues):
21400 (WTR::createTestURL):
21401 * WebKitTestRunner/TestInvocation.cpp:
21402 * WebKitTestRunner/WebKitTestRunnerPrefix.h:
21403 * WebKitTestRunner/win/EventSenderProxyWin.cpp: Added.
21404 (WTR::EventSenderProxy::EventSenderProxy):
21405 (WTR::EventSenderProxy::~EventSenderProxy):
21406 (WTR::EventSenderProxy::mouseDown):
21407 (WTR::EventSenderProxy::mouseUp):
21408 (WTR::EventSenderProxy::mouseMoveTo):
21409 (WTR::EventSenderProxy::mouseScrollBy):
21410 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
21411 (WTR::EventSenderProxy::continuousMouseScrollBy):
21412 (WTR::EventSenderProxy::leapForward):
21413 (WTR::EventSenderProxy::keyDown):
21414 * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
21415 (WTR::registerWindowClass):
21416 (WTR::PlatformWebView::PlatformWebView):
21417 (WTR::PlatformWebView::~PlatformWebView):
21418 (WTR::PlatformWebView::resizeTo):
21419 (WTR::PlatformWebView::page):
21420 (WTR::PlatformWebView::focus):
21421 (WTR::PlatformWebView::windowFrame):
21422 (WTR::PlatformWebView::setWindowFrame):
21423 (WTR::PlatformWebView::didInitializeClients):
21424 (WTR::PlatformWebView::addChromeInputField):
21425 (WTR::PlatformWebView::removeChromeInputField):
21426 (WTR::PlatformWebView::addToWindow):
21427 (WTR::PlatformWebView::removeFromWindow):
21428 (WTR::PlatformWebView::setWindowIsKey):
21429 (WTR::PlatformWebView::makeWebViewFirstResponder):
21430 (WTR::generateCairoSurfaceFromBitmap):
21431 (WTR::PlatformWebView::windowSnapshotImage):
21432 (WTR::PlatformWebView::changeWindowScaleIfNeeded):
21433 (WTR::PlatformWebView::setNavigationGesturesEnabled):
21434 (WTR::PlatformWebView::forceWindowFramesChanged):
21435 (WTR::PlatformWebView::drawsBackground const):
21436 (WTR::PlatformWebView::setDrawsBackground):
21437 * WebKitTestRunner/win/TestControllerWin.cpp: Added.
21438 (WTR::exceptionFilter):
21439 (WTR::runRunLoopUntil):
21440 (WTR::TestController::notifyDone):
21441 (WTR::TestController::setHidden):
21442 (WTR::TestController::platformInitialize):
21443 (WTR::TestController::platformPreferences):
21444 (WTR::TestController::platformDestroy):
21446 (WTR::TestController::platformInitializeContext):
21447 (WTR::TestController::platformRunUntil):
21448 (WTR::TestController::platformDidCommitLoadForFrame):
21449 (WTR::TestController::initializeInjectedBundlePath):
21450 (WTR::TestController::initializeTestPluginDirectory):
21451 (WTR::TestController::runModal):
21452 (WTR::TestController::platformContext):
21453 (WTR::TestController::platformLibraryPathForTesting):
21454 (WTR::TestController::platformConfigureViewForTest):
21455 (WTR::TestController::platformResetPreferencesToConsistentValues):
21456 (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
21457 * WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp: Added.
21458 * WebKitTestRunner/win/main.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
21459 (dllLauncherEntryPoint):
21461 2018-11-12 Alicia Boya García <aboya@igalia.com>
21463 [MSE][GStreamer] Introduce AbortableTaskQueue
21464 https://bugs.webkit.org/show_bug.cgi?id=190902
21466 Reviewed by Xabier Rodriguez-Calvar.
21468 Tests for AbortableTaskQueue are included.
21470 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21471 * TestWebKitAPI/PlatformGTK.cmake:
21472 * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: Added.
21473 (TestWebKitAPI::TEST):
21474 (TestWebKitAPI::FancyResponse::FancyResponse):
21475 (TestWebKitAPI::FancyResponse::operator=):
21476 (TestWebKitAPI::DeterministicScheduler::DeterministicScheduler):
21477 (TestWebKitAPI::DeterministicScheduler::ThreadContext::ThreadContext):
21478 (TestWebKitAPI::DeterministicScheduler::ThreadContext::waitMyTurn):
21479 (TestWebKitAPI::DeterministicScheduler::ThreadContext::yieldToThread):
21481 2018-11-11 Fujii Hironori <Hironori.Fujii@sony.com>
21483 run-bindings-tests is timing out in some WinCairo bots
21484 https://bugs.webkit.org/show_bug.cgi?id=191348
21486 Reviewed by Alex Christensen.
21488 BuildBot kills run-bindings-tests if it outputs nothing for 20
21489 minutes. run-bindings-tests runs very slowly in WinCairo Docker,
21490 and it takes more than 30 minutes to finish. And, Windows Python
21491 buffers the progress output.
21493 * Scripts/webkitpy/bindings/main.py:
21494 (BindingsTests.detect_changes): Call sys.stdout.flush() after the
21495 test case result is output.
21497 2018-11-11 Wenson Hsieh <wenson_hsieh@apple.com>
21499 Implement a new edit command to change the enclosing list type
21500 https://bugs.webkit.org/show_bug.cgi?id=191487
21501 <rdar://problem/45955922>
21503 Reviewed by Ryosuke Niwa.
21505 Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing
21506 command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.
21508 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21509 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
21510 (-[TestWKWebView setPosition:offset:]):
21511 (-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
21512 (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
21513 (TestWebKitAPI::TEST):
21514 * TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.
21516 2018-11-11 Dan Bernstein <mitz@apple.com>
21518 ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
21519 https://bugs.webkit.org/show_bug.cgi?id=191514
21521 Reviewed by Geoffrey Garen.
21523 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21524 * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
21527 2018-11-11 Benjamin Poulain <benjamin@webkit.org>
21529 Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
21530 https://bugs.webkit.org/show_bug.cgi?id=191492
21532 Reviewed by Alex Christensen.
21536 * DumpRenderTree/mac/DumpRenderTree.mm:
21537 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
21538 * WebKitTestRunner/mac/TestControllerMac.mm:
21540 2018-11-10 Benjamin Poulain <benjamin@webkit.org>
21542 Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
21543 https://bugs.webkit.org/show_bug.cgi?id=191492
21545 Reviewed by Alex Christensen.
21547 * DumpRenderTree/mac/DumpRenderTree.mm:
21548 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
21549 * WebKitTestRunner/mac/TestControllerMac.mm:
21551 2018-11-10 Ryan Haddad <ryanhaddad@apple.com>
21553 Unreviewed, rolling out r238065.
21555 Breaks internal builds.
21557 Reverted changeset:
21559 "Make it possible to edit images inline"
21560 https://bugs.webkit.org/show_bug.cgi?id=191352
21561 https://trac.webkit.org/changeset/238065
21563 2018-11-10 Michael Catanzaro <mcatanzaro@igalia.com>
21565 [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
21566 https://bugs.webkit.org/show_bug.cgi?id=191221
21568 Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
21569 that it is disabled, but we're testing that it is enabled, because I failed to update this
21572 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
21573 (testWebKitSettings):
21575 2018-11-10 Tim Horton <timothy_horton@apple.com>
21577 Make it possible to edit images inline
21578 https://bugs.webkit.org/show_bug.cgi?id=191352
21579 <rdar://problem/30107985>
21581 Reviewed by Dean Jackson.
21583 * WebKitTestRunner/TestController.cpp:
21584 (WTR::updateTestOptionsFromTestHeader):
21585 * WebKitTestRunner/TestOptions.h:
21586 (WTR::TestOptions::hasSameInitializationOptions const):
21587 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
21588 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
21589 (WTR::TestController::platformCreateWebView):
21590 Add a test option to enable editable images.
21592 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
21593 (WTR::UIScriptController::drawSquareInEditableImage):
21594 (WTR::UIScriptController::numberOfStrokesInEditableImage):
21595 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
21596 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
21597 (WTR::UIScriptController::drawSquareInEditableImage):
21598 (WTR::UIScriptController::numberOfStrokesInEditableImage):
21599 * TestRunnerShared/UIScriptContext/UIScriptController.h:
21600 * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
21601 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
21602 (WTR::findEditableImageCanvas):
21603 (WTR::UIScriptController::drawSquareInEditableImage):
21604 (WTR::UIScriptController::numberOfStrokesInEditableImage):
21605 Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
21606 and also to retrieve the number of strokes currently on the PKCanvasView.
21607 Currently this just takes the first canvas; we might need to make it
21608 take an identifier or something in the future if we need tests with multiple
21609 canvases. The indirect testing mechanism is required because PKCanvasView
21610 can currently not actually paint its strokes in the Simulator.
21612 2018-11-09 Chris Dumez <cdumez@apple.com>
21614 Suspended page persists even after back/forward list item is gone
21615 https://bugs.webkit.org/show_bug.cgi?id=191488
21616 <rdar://problem/45953006>
21618 Reviewed by Geoffrey Garen.
21620 Add API test coverage.
21622 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
21624 2018-11-09 Wenson Hsieh <wenson_hsieh@apple.com>
21626 [Cocoa] Implement SPI on WKWebView to increase and decrease list levels
21627 https://bugs.webkit.org/show_bug.cgi?id=191471
21628 <rdar://problem/45952472>
21630 Reviewed by Tim Horton.
21632 Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.
21634 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
21635 (TestWebKitAPI::webViewForEditActionTesting):
21636 (TestWebKitAPI::TEST):
21638 2018-11-09 Basuke Suzuki <basuke.suzuki@sony.com>
21640 [Curl][WebKit] Implement Proxy configuration API.
21641 https://bugs.webkit.org/show_bug.cgi?id=189053
21643 Reviewed by Youenn Fablet.
21645 Added Proxy Settings dialog to call newly added API.
21647 * MiniBrowser/win/BrowserWindow.h:
21648 * MiniBrowser/win/Common.cpp:
21649 (askProxySettings):
21651 (authDialogProc): Deleted.
21652 * MiniBrowser/win/Common.h:
21653 * MiniBrowser/win/DialogHelper.h: Added.
21655 (Dialog::doalogProc):
21659 (Dialog::validate):
21660 (Dialog::updateOkButton):
21667 (Dialog::setEnabled):
21670 (Dialog::getTextLength):
21671 (Dialog::RadioGroup::RadioGroup):
21672 (Dialog::RadioGroup::set):
21673 (Dialog::RadioGroup::get):
21674 (Dialog::radioGroup):
21675 * MiniBrowser/win/MainWindow.cpp:
21676 (MainWindow::WndProc):
21677 * MiniBrowser/win/MiniBrowserLib.rc:
21678 * MiniBrowser/win/MiniBrowserLibResource.h:
21679 * MiniBrowser/win/WebKitBrowserWindow.cpp:
21681 (WebKitBrowserWindow::WebKitBrowserWindow):
21682 (WebKitBrowserWindow::updateProxySettings):
21683 (WebKitBrowserWindow::loadURL):
21684 (WebKitBrowserWindow::loadHTMLString):
21685 (WebKitBrowserWindow::openProxySettings):
21686 * MiniBrowser/win/WebKitBrowserWindow.h:
21687 * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
21688 (WebKitLegacyBrowserWindow::openProxySettings):
21689 * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
21691 2018-11-09 Wenson Hsieh <wenson_hsieh@apple.com>
21693 [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
21694 https://bugs.webkit.org/show_bug.cgi?id=191410
21695 <rdar://problem/45898610>
21697 Reviewed by Dean Jackson.
21699 Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
21700 Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are
21701 hooked up to their respective editing commands.
21703 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21704 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.
21705 (-[TestWKWebView querySelectorExists:]):
21706 (-[TestWKWebView insertString:]):
21708 Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
21709 invoking the WKWebView directly on macOS and calling on the content view on iOS.
21711 (TestWebKitAPI::webViewForEditActionTesting):
21712 (TestWebKitAPI::TEST):
21714 2018-11-09 Philippe Normand <pnormand@igalia.com>
21716 [Flatpak] Refactoring and drive-by fixes
21717 https://bugs.webkit.org/show_bug.cgi?id=191421
21719 Reviewed by Michael Catanzaro.
21721 * Scripts/webkitdirs.pm:
21722 (inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
21723 the sandbox, so rely on this.
21724 * flatpak/flatpakutils.py:
21725 (expand_manifest): Pass explicit keywords to load_manifest() and
21726 remove unused local variable.
21727 (WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
21728 (WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
21729 (WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
21730 build_type handling a bit.
21731 * flatpak/org.webkit.CommonModules.yaml: Added.
21732 * flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
21733 * flatpak/org.webkit.WebKit.yaml: Move common dependencies
21734 declaration to CommonModules, so it can be reused later when we
21735 add support for building extra libraries depending on WPE.
21737 2018-11-08 Said Abou-Hallawa <sabouhallawa@apple.com>
21739 onal supported image formats
21740 https://bugs.webkit.org/show_bug.cgi?id=190454
21742 Reviewed by Simon Fraser.
21744 Test opening a TGA image in WebView which is not allowed by default. The
21745 TGA format will be allowed through WKWebViewConfiguration.
21747 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21748 * TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
21749 * TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
21750 * TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.
21754 2018-11-08 Jiewen Tan <jiewen_tan@apple.com>
21756 Unreviewed, a proper build fix for r237983
21758 Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.
21760 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21761 * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.
21762 (TestWebKitAPI::TEST):
21763 * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.
21764 (TestWebKitAPI::getTestCorruptedSignResponse):
21765 (TestWebKitAPI::getTestCredentialRawIdBytes):
21766 (TestWebKitAPI::convertToVector):
21767 (TestWebKitAPI::TEST):
21769 2018-11-08 Keith Rollin <krollin@apple.com>
21771 Create .xcfilelist files
21772 https://bugs.webkit.org/show_bug.cgi?id=191324
21773 <rdar://problem/45852819>
21775 Reviewed by Alex Christensen.
21777 As part of preparing for enabling XCBuild, create and use .xcfilelist
21778 files. These files are using during Run Script build phases in an
21779 Xcode project. If a Run Script build phase produces new files that are
21780 used later as inputs to subsequent build phases, XCBuild needs to know
21781 about these files. These files can be either specified in an "output
21782 files" section of the Run Script phase editor, or in .xcfilelist files
21783 that are associated with the Run Script build phase.
21785 This patch takes the second approach. It consists of three sets of changes:
21787 - Modify the DerivedSources.make files to have a
21788 'print_all_generated_files" target that produces a list of the files
21791 - Create a shell script that produces .xcfilelist files from the
21792 output of the previous step, as well as for the files created in the
21793 Generate Unified Sources build steps.
21795 - Add the new .xcfilelist files to the associated projects.
21797 Note that, with these changes, the Xcode workspace and projects can no
21798 longer be fully loaded into Xcode 9. Xcode will attempt to load the
21799 projects that have .xcfilelist files associated with them, but will
21800 fail and display a placeholder for those projects instead. It's
21801 expected that all developers are using Xcode 10 by now and that not
21802 being able to load into Xcode 9 is not a practical issue. Keep in mind
21803 that this is strictly an IDE issue, and that the projects can still be
21804 built with `xcodebuild`.
21806 Also note that the shell script that creates the .xcfilelist files can
21807 also be used to verify that the set of files that's currently checked
21808 in is up-to-date. This checking can be used as part of a check-in hook
21809 or part of check-webkit-style to sooner catch cases where the
21810 .xcfilelist files need to be regenerated.
21812 * DumpRenderTree/DerivedSources.make:
21813 * DumpRenderTree/DerivedSources.xcfilelist: Added.
21814 * Scripts/generate-xcfilelists: Added.
21815 * WebKitTestRunner/DerivedSources.make:
21816 * WebKitTestRunner/DerivedSources.xcfilelist: Added.
21818 2018-11-08 Jiewen Tan <jiewen_tan@apple.com>
21820 Unreviewed, a quick build fix for r237983
21822 Temporarily make CtapRequestTest.cpp/CtapResponseTest.cpp to mac only to avoid iOS build failures.
21824 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
21825 * TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp.
21826 (TestWebKitAPI::TEST):
21827 * TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp.
21828 (TestWebKitAPI::getTestCorruptedSignResponse):
21829 (TestWebKitAPI::getTestCredentialRawIdBytes):
21830 (TestWebKitAPI::convertToVector):
21831 (TestWebKitAPI::TEST):
21833 2018-11-05 Ryan Haddad <ryanhaddad@apple.com>
21835 Fix steps_unittest.py failures related to recent Win10/Win7 changes
21836 https://bugs.webkit.org/show_bug.cgi?id=191290
21838 Reviewed by Alexey Proskuryakov.
21840 * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update expected results.
21842 2018-11-08 Dean Jackson <dino@apple.com>
21844 Add a String literal that returns a String
21845 https://bugs.webkit.org/show_bug.cgi?id=191425
21846 <rdar://problem/45914556>
21848 Reviewed by Sam Weinig.
21852 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
21853 (TestWebKitAPI::TEST):
21855 2018-11-08 Jonathan Bedard <jbedard@apple.com>
21857 webkitpy: Generalize trailing SDK specifier (Part 2)
21858 https://bugs.webkit.org/show_bug.cgi?id=191275
21859 <rdar://problem/45703660>
21861 Rubber-stamped by Aakash Jain.
21863 Re-landing this change, configuration issues have been resolved.
21865 * Scripts/webkitpy/port/ios_device.py:
21866 (IOSDevicePort): Use normalized SDK.
21867 * Scripts/webkitpy/port/ios_simulator.py:
21868 (IOSSimulatorPort): Use normalized SDK.
21869 (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
21871 2018-11-08 Jiewen Tan <jiewen_tan@apple.com>
21873 [WebAuthN] Import CTAP device request/response converters from Chromium
21874 https://bugs.webkit.org/show_bug.cgi?id=190784
21875 <rdar://problem/45460333>
21877 Reviewed by Brent Fulgham.
21879 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21880 * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:
21881 (TestWebKitAPI::TEST):
21882 * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Added.
21883 (TestWebKitAPI::TEST):
21884 * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Added.
21885 (TestWebKitAPI::getTestCorruptedSignResponse):
21886 (TestWebKitAPI::getTestCredentialRawIdBytes):
21887 (TestWebKitAPI::convertToVector):
21888 (TestWebKitAPI::TEST):
21889 * TestWebKitAPI/Tests/WebCore/FidoTestData.h: Added.
21891 2018-11-07 Caio Lima <ticaiolima@gmail.com>
21893 [BigInt] Add support to BigInt into ValueAdd
21894 https://bugs.webkit.org/show_bug.cgi?id=186177
21896 Reviewed by Keith Miller.
21898 * Scripts/run-jsc-benchmarks:
21900 2018-11-07 Sihui Liu <sihui_liu@apple.com>
21902 RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
21903 https://bugs.webkit.org/show_bug.cgi?id=191326
21904 <rdar://problem/45769269>
21906 Reviewed by Geoffrey Garen.
21908 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21909 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
21910 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.
21911 (-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
21914 2018-11-07 Daniel Bates <dabates@apple.com>
21916 Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
21917 https://bugs.webkit.org/show_bug.cgi?id=190141
21919 Reviewed by Darin Adler.
21921 Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
21922 runs deterministic regardless of whether a hardware keyboard is attached.
21924 * DumpRenderTree/mac/DumpRenderTree.mm:
21925 (overrideIsInHardwareKeyboardMode): Added.
21926 (prepareConsistentTestingEnvironment):
21927 * TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
21928 * WebKitTestRunner/ios/TestControllerIOS.mm:
21929 (overrideIsInHardwareKeyboardMode): Added.
21930 (WTR::TestController::platformInitialize):
21932 2018-11-07 Jonathan Bedard <jbedard@apple.com>
21934 Unreviewed, rolling out r237913.
21936 Breaks running tests on Mac without iOS SDK installed
21938 Reverted changeset:
21940 "webkitpy: Generalize trailing SDK specifier (Part 2)"
21941 https://bugs.webkit.org/show_bug.cgi?id=191275
21942 https://trac.webkit.org/changeset/237913
21944 2018-11-07 Zamiul Haque <zhaque@apple.com>
21946 Force a gregorian calendar to show for credit card expiration date inputs
21947 (autocomplete='cc-exp'*) regardless of default system settings.
21948 https://bugs.webkit.org/show_bug.cgi?id=191096
21949 rdar://problem/42640256
21951 Reviewed by Tim Horton.
21953 Implemented simulateForeignDefaultCalendar and calendarType to be used
21954 for changing the default calendar returned by the system (ie. [NSCalendar
21955 currentCalendar]) and getting the calendar type identifier of a presented date
21958 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
21959 (WTR::UIScriptController::isShowingDataListSuggestions const):
21960 (WTR::UIScriptController::calendarType const):
21961 (WTR::UIScriptController::setDefaultCalendarType):
21962 * DumpRenderTree/mac/UIScriptControllerMac.mm:
21963 (WTR::UIScriptController::calendarType const):
21964 (WTR::UIScriptController::setDefaultCalendarType):
21965 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
21966 (WTR::UIScriptController::selectionEndGrabberViewRect const):
21967 (WTR::UIScriptController::calendarType const): Deleted.
21968 * WebKitTestRunner/TestController.cpp:
21969 * WebKitTestRunner/TestController.h:
21970 * WebKitTestRunner/UIScriptControllerCocoa.mm:
21971 (WTR::UIScriptController::calendarType const):
21972 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
21973 (WTR::swizzledCalendar):
21974 (WTR::TestController::getOverriddenCalendarIdentifier const):
21975 (WTR::TestController::setDefaultCalendarType):
21976 (WTR::TestController::cocoaResetStateToConsistentValues):
21977 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
21978 (WTR::UIScriptController::selectionEndGrabberViewRect const):
21979 (WTR::UIScriptController::calendarType const): Deleted.
21981 2018-11-06 Jonathan Bedard <jbedard@apple.com>
21983 webkitpy: Boot a single worker for custom devices
21984 https://bugs.webkit.org/show_bug.cgi?id=191312
21985 <rdar://problem/45848717>
21987 Rubber-stamped by Aakash Jain.
21989 * Scripts/webkitpy/layout_tests/controllers/manager.py:
21990 (Manager.run): Custom devices only run a hand-full of tests. Booting multiple
21991 simulators is expensive and unneeded for these tests.
21992 * Scripts/webkitpy/port/ios.py:
21993 (IOSPort. child_processes): No reason to memoize this call, and it prevents
21994 overriding the number of child processes when booting custom devices.
21996 2018-11-06 Jonathan Bedard <jbedard@apple.com>
21998 webkitpy: Generalize trailing SDK specifier (Part 2)
21999 https://bugs.webkit.org/show_bug.cgi?id=191275
22000 <rdar://problem/45703660>
22002 Reviewed by Aakash Jain.
22004 * Scripts/webkitpy/port/ios_device.py:
22005 (IOSDevicePort): Use normalized SDK.
22006 * Scripts/webkitpy/port/ios_simulator.py:
22007 (IOSSimulatorPort): Use normalized SDK.
22008 (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
22010 2018-11-06 Justin Fan <justin_fan@apple.com>
22012 [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
22013 https://bugs.webkit.org/show_bug.cgi?id=191291
22015 Reviewed by Myles Maxfield.
22017 Properly disable WEBGPU on all non-Metal platforms for now.
22019 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
22021 2018-11-06 Aakash Jain <aakash_jain@apple.com>
22023 [ews-app] Add URL configuration for OpenSource EWS Django app
22024 https://bugs.webkit.org/show_bug.cgi?id=191132
22026 Rubber-stamped by Lucas Forschler.
22028 * BuildSlaveSupport/ews-app/ews-app/urls.py: Added entry for ews.urls.
22029 * BuildSlaveSupport/ews-app/ews/urls.py: Added.
22031 2018-11-06 Youenn Fablet <youenn@apple.com>
22033 Make mDNS ICE Candidate an experimental flag again
22034 https://bugs.webkit.org/show_bug.cgi?id=191262
22036 Reviewed by Dean Jackson.
22038 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
22039 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
22040 (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
22041 (WTR::TestRunner::setMDNSICECandidatesEnabled): Deleted.
22042 * WebKitTestRunner/InjectedBundle/TestRunner.h:
22044 2018-11-06 Aakash Jain <aakash_jain@apple.com>
22046 [ews-app] Add views for OpenSource EWS Django app
22047 https://bugs.webkit.org/show_bug.cgi?id=191131
22049 Rubber-stamped by Lucas Forschler.
22051 * BuildSlaveSupport/ews-app/ews/views/index.py: Added.
22052 * BuildSlaveSupport/ews-app/ews/views/patch.py:
22053 * BuildSlaveSupport/ews-app/ews/views/results.py: Added.
22054 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added.
22056 2018-11-06 Aakash Jain <aakash_jain@apple.com>
22058 [ews-app] Add models for OpenSource EWS Django app
22059 https://bugs.webkit.org/show_bug.cgi?id=191123
22061 Reviewed by Lucas Forschler.
22063 * BuildSlaveSupport/ews-app/ews/models/__init__.py:
22064 * BuildSlaveSupport/ews-app/ews/models/buildermappings.py: Added.
22065 * BuildSlaveSupport/ews-app/ews/models/builds.py: Added.
22066 * BuildSlaveSupport/ews-app/ews/models/patch.py:
22067 * BuildSlaveSupport/ews-app/ews/models/steps.py: Added.
22069 2018-11-06 Aakash Jain <aakash_jain@apple.com>
22071 [ews-app] Fix Invalid HTTP_HOST header
22072 https://bugs.webkit.org/show_bug.cgi?id=191325
22074 Reviewed by Lucas Forschler.
22076 Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.
22078 * BuildSlaveSupport/ews-app/ews-app/settings.py:
22080 2018-11-06 Aakash Jain <aakash_jain@apple.com>
22082 [ews-app] Rename EWS_app to ews-app - part 2
22083 https://bugs.webkit.org/show_bug.cgi?id=191317
22085 Reviewed by Lucas Forschler.
22087 * BuildSlaveSupport/ews-app/EWS_app: Removed.
22088 * BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
22089 * BuildSlaveSupport/ews-app/ews-app/settings.py:
22090 * BuildSlaveSupport/ews-app/ews-app/urls.py:
22091 * BuildSlaveSupport/ews-app/ews-app/wsgi.py:
22092 * BuildSlaveSupport/ews-app/manage.py:
22094 2018-11-06 Aakash Jain <aakash_jain@apple.com>
22096 [ews-app] Rename EWS_app to ews-app - part 1
22097 https://bugs.webkit.org/show_bug.cgi?id=191317
22099 Reviewed by Lucas Forschler.
22101 * BuildSlaveSupport/EWS_app: Removed.
22102 * BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.
22104 2018-11-06 Myles C. Maxfield <mmaxfield@apple.com>
22106 Spelling dots are drawn in the wrong place
22107 https://bugs.webkit.org/show_bug.cgi?id=190764
22109 Reviewed by Dean Jackson.
22111 Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
22112 at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
22115 * WebKitTestRunner/TestController.cpp:
22116 (WTR::TestController::resetStateToConsistentValues):
22117 (WTR::updateTestOptionsFromTestHeader):
22118 (WTR::TestController::platformResetStateToConsistentValues):
22119 * WebKitTestRunner/TestController.h:
22120 * WebKitTestRunner/TestOptions.h:
22121 (WTR::TestOptions::hasSameInitializationOptions const):
22122 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
22123 (WTR::TestController::cocoaResetStateToConsistentValues):
22124 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
22125 * WebKitTestRunner/ios/TestControllerIOS.mm:
22126 (WTR::TestController::platformResetStateToConsistentValues):
22127 * WebKitTestRunner/mac/TestControllerMac.mm:
22128 (WTR::TestController::platformResetStateToConsistentValues):
22130 2018-11-06 Don Olmstead <don.olmstead@sony.com>
22132 Feature flags not present for Visual Studio when using build-webkit
22133 https://bugs.webkit.org/show_bug.cgi?id=191288
22135 Reviewed by Fujii Hironori.
22137 Passes feature flags to Visual studio builds within build-webkit.
22138 Removes cmakeBasedPortArguments as it is no longer in use.
22140 * Scripts/build-jsc:
22141 * Scripts/build-webkit:
22142 * Scripts/webkitdirs.pm:
22143 (cmakeBasedPortArguments): Deleted.
22145 2018-11-06 Per Arne Vollan <pvollan@apple.com>
22147 REGRESSION (r230523): Caps lock indicator not shown in password field
22148 https://bugs.webkit.org/show_bug.cgi?id=190056
22150 Reviewed by Ryosuke Niwa.
22152 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
22153 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
22154 (WTR::TestRunner::toggleCapsLock):
22155 * WebKitTestRunner/InjectedBundle/TestRunner.h:
22156 * WebKitTestRunner/TestController.h:
22157 * WebKitTestRunner/TestInvocation.cpp:
22158 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
22159 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
22160 (WTR::TestController::toggleCapsLock):
22162 2018-11-06 Sihui Liu <sihui_liu@apple.com>
22164 IndexedDB: WAL file keeps growing
22165 https://bugs.webkit.org/show_bug.cgi?id=191294
22166 <rdar://problem/41333493>
22168 Reviewed by Chris Dumez.
22170 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22171 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
22172 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
22173 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
22174 (-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
22177 2018-11-06 Alex Christensen <achristensen@webkit.org>
22179 Fix tests after r237863
22180 https://bugs.webkit.org/show_bug.cgi?id=191315
22182 Reviewed by Chris Dumez.
22184 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
22185 With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
22186 This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it. I updated the test
22187 to verify that main2.html eventually loads, making this test less timing dependent.
22189 2018-11-06 Ryan Haddad <ryanhaddad@apple.com>
22191 Unreviewed, rolling out r237834.
22193 Tests for this change crash on iOS Simulator
22195 Reverted changeset:
22197 "Spelling dots are drawn in the wrong place"
22198 https://bugs.webkit.org/show_bug.cgi?id=190764
22199 https://trac.webkit.org/changeset/237834
22201 2018-11-05 Alex Christensen <achristensen@webkit.org>
22203 [Mac] Implement safe browsing in WebKit
22204 https://bugs.webkit.org/show_bug.cgi?id=188871
22206 Reviewed by Tim Horton.
22208 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
22209 (-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
22210 (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
22211 (-[TestLookupContext lookUpURL:completionHandler:]):
22213 (safeBrowsingView):
22215 (-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
22216 (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
22217 (-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
22218 * TestWebKitAPI/Utilities.h:
22220 2018-11-05 Jonathan Bedard <jbedard@apple.com>
22222 webkitpy: Generalize trailing SDK specifier (Part 1)
22223 https://bugs.webkit.org/show_bug.cgi?id=191275
22224 <rdar://problem/45703660>
22226 Reviewed by Lucas Forschler.
22228 * Scripts/webkitpy/common/system/platforminfo.py:
22229 (PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
22230 * Scripts/webkitpy/common/system/platforminfo_unittest.py:
22231 (TestPlatformInfo):
22232 (TestPlatformInfo.test_available_sdks):
22234 2018-11-05 Myles C. Maxfield <mmaxfield@apple.com>
22236 Spelling dots are drawn in the wrong place
22237 https://bugs.webkit.org/show_bug.cgi?id=190764
22239 Reviewed by Dean Jackson.
22241 Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
22242 at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
22245 * WebKitTestRunner/TestController.cpp:
22246 (WTR::TestController::resetStateToConsistentValues):
22247 (WTR::updateTestOptionsFromTestHeader):
22248 (WTR::TestController::platformResetStateToConsistentValues):
22249 * WebKitTestRunner/TestController.h:
22250 * WebKitTestRunner/TestOptions.h:
22251 (WTR::TestOptions::hasSameInitializationOptions const):
22252 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
22253 (WTR::TestController::cocoaResetStateToConsistentValues):
22254 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
22255 * WebKitTestRunner/ios/TestControllerIOS.mm:
22256 (WTR::TestController::platformResetStateToConsistentValues):
22257 * WebKitTestRunner/mac/TestControllerMac.mm:
22258 (WTR::TestController::platformResetStateToConsistentValues):
22260 2018-11-05 Chris Dumez <cdumez@apple.com>
22262 Use same limit for page cache and suspended pages
22263 https://bugs.webkit.org/show_bug.cgi?id=191266
22265 Reviewed by Geoffrey Garen.
22267 Update API tests accordingly.
22269 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
22271 2018-11-05 Basuke Suzuki <Basuke.Suzuki@sony.com>
22273 [style] Exclude style check for auto generated files.
22274 https://bugs.webkit.org/show_bug.cgi?id=191118
22276 Reviewed by Eric Carlson.
22278 Some files checked in to the repository are generated by other tools. In this patch,
22279 "MiniBrowserLibResource.h" is the file generated and managed by resource editor of
22282 There's no need to check these files because it's not practical to fix the style errors
22283 or it's hard to maintain those fixes.
22285 * Scripts/webkitpy/style/checkers/cpp.py:
22286 (is_generated_file):
22287 (CppChecker.check):
22289 2018-11-05 Thibault Saunier <tsaunier@igalia.com>
22291 [Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
22292 https://bugs.webkit.org/show_bug.cgi?id=190680
22294 Reviewed by Philippe Normand.
22296 * flatpak/org.webkit.WebKit.yaml:
22298 2018-11-05 Daniel Bates <dabates@apple.com>
22300 [lldb-webkit] Fix formatting nits in Document and Frame summary strings
22301 https://bugs.webkit.org/show_bug.cgi?id=191094
22303 Reviewed by Andy Estes.
22305 Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
22306 booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
22307 Document summary and add closing brace '}' to both Frame and Document summary strings to make
22310 * lldb/lldb_webkit.py:
22311 (WebCoreFrame_SummaryProvider):
22312 (WebCoreDocument_SummaryProvider):
22314 2018-11-05 Wenson Hsieh <wenson_hsieh@apple.com>
22316 [iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
22317 https://bugs.webkit.org/show_bug.cgi?id=191240
22318 <rdar://problem/44872806>
22320 Reviewed by Tim Horton.
22322 Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
22323 responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
22324 overriding `-[WKWebView inputAssistantItem]`.
22326 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
22327 (-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
22328 (-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
22329 (+[InputAssistantItemTestingWebView barButtonIcon]):
22330 (+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
22331 (+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
22332 (-[InputAssistantItemTestingWebView inputAssistantItem]):
22333 (TestWebKitAPI::TEST):
22335 2018-11-05 Wenson Hsieh <wenson_hsieh@apple.com>
22337 [iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
22338 https://bugs.webkit.org/show_bug.cgi?id=191226
22339 <rdar://problem/45781765>
22341 Reviewed by Tim Horton.
22343 Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
22344 viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.
22346 * WebKitTestRunner/TestOptions.h:
22347 (WTR::TestOptions::hasSameInitializationOptions const):
22349 2018-11-05 Commit Queue <commit-queue@webkit.org>
22351 Unreviewed, rolling out r237784 and r237788.
22352 https://bugs.webkit.org/show_bug.cgi?id=191270
22354 Caused mediastream layout test failures (Requested by
22355 ryanhaddad on #webkit).
22357 Reverted changesets:
22359 "[MediaStream] User should not be prompted again after denying
22360 getDisplayMedia request"
22361 https://bugs.webkit.org/show_bug.cgi?id=191227
22362 https://trac.webkit.org/changeset/237784
22364 "[MediaStream] User should not be prompted again after denying
22365 getDisplayMedia request"
22366 https://bugs.webkit.org/show_bug.cgi?id=191227
22367 https://trac.webkit.org/changeset/237788
22369 2018-11-05 Lucas Forschler <lforschler@apple.com>
22371 https://bugs.webkit.org/show_bug.cgi?id=191268
22372 Remove unused bots.
22374 rubber-stamped by Alexey Proskuryakov.
22376 * BuildSlaveSupport/build.webkit.org-config/config.json:
22377 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
22380 2018-11-05 Michael Catanzaro <mcatanzaro@igalia.com>
22382 [WPE][GTK] API test runner fails to respect default build type
22383 https://bugs.webkit.org/show_bug.cgi?id=190247
22385 Reviewed by Carlos Garcia Campos.
22387 Problem is it's looking for a release build, even though I've run set-webkit-configuration
22388 --debug. It should look for a debug build unless I explicitly pass --release.
22390 * glib/api_test_runner.py:
22391 (TestRunner.__init__):
22393 2018-11-05 Thibault Saunier <tsaunier@igalia.com>
22395 [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
22396 https://bugs.webkit.org/show_bug.cgi?id=190674
22398 Reviewed by Philippe Normand.
22400 webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
22401 it can use to implement encoding for different formats exposing a trimmed down unified API.
22403 It also adds proper handling of H264 profiles.
22405 The added files follow GStreamer coding style as we aim at upstreaming the element
22408 Reviewed by Philippe Normand.
22410 * Scripts/webkitpy/style/checker.py:
22412 2018-11-05 Michael Catanzaro <mcatanzaro@igalia.com>
22414 [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
22415 https://bugs.webkit.org/show_bug.cgi?id=191221
22417 Reviewed by Carlos Garcia Campos.
22419 This test ensures that MSE is disabled by default, but we now enable it by default, so
22420 reverse the semantics of the test.
22422 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
22423 (testWebKitSettings):
22425 2018-11-05 Michael Catanzaro <mcatanzaro@igalia.com>
22427 REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
22428 https://bugs.webkit.org/show_bug.cgi?id=191225
22430 Reviewed by Alejandro G. Castro.
22432 Fix a memory leak causing this test to fail.
22434 * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
22435 (WebViewTest::initializeWebView):
22437 2018-11-04 Zan Dobersek <zdobersek@igalia.com>
22439 [webkitpy] Support WPE in the run-web-platform-tests script
22440 https://bugs.webkit.org/show_bug.cgi?id=191183
22442 Reviewed by Alex Christensen.
22444 * Scripts/webkitpy/w3c/wpt_runner.py:
22445 (parse_args): Support `--wpe` as an argument that specifies WPE as the
22446 target port. Additionally, the `--display-server` flag now accepts
22447 `headless` as a valid value, enabling the WPE WebDriver to run in
22450 2018-11-04 Fujii Hironori <Hironori.Fujii@sony.com>
22452 [Win] Use C++14, not C++17
22453 https://bugs.webkit.org/show_bug.cgi?id=191101
22455 Reviewed by Alex Christensen.
22457 std::basic_string::data() returns a read-only const buffer in
22460 * MiniBrowser/win/WebKitBrowserWindow.cpp:
22461 (createString): Use std::vector instead of std::wstring.
22462 (createUTF8String): Use std::vector instead of std::string.
22464 2018-11-04 Wenson Hsieh <wenson_hsieh@apple.com>
22466 [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
22467 https://bugs.webkit.org/show_bug.cgi?id=191231
22469 Reviewed by Simon Fraser.
22471 Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
22472 it can be shared between iOS-family and macOS platforms. See below for more details.
22474 No change in behavior.
22476 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
22477 (WTR::UIScriptController::overridePreference):
22479 Add a method stub for DumpRenderTree.
22481 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
22482 * WebKitTestRunner/UIScriptControllerCocoa.mm:
22483 (WTR::UIScriptController::doAsyncTask):
22484 (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
22486 Unify these method implementations.
22488 (WTR::UIScriptController::removeViewFromWindow):
22489 (WTR::UIScriptController::addViewToWindow):
22491 Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
22492 to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
22493 block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
22494 begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.
22496 (WTR::UIScriptController::overridePreference):
22497 (WTR::UIScriptController::findString):
22498 (WTR::UIScriptController::contentsOfUserInterfaceItem const):
22500 Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.
22502 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
22503 (WTR::UIScriptController::doAsyncTask): Deleted.
22504 (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
22505 (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
22506 (WTR::UIScriptController::findString): Deleted.
22507 (WTR::UIScriptController::removeViewFromWindow): Deleted.
22508 (WTR::UIScriptController::addViewToWindow): Deleted.
22509 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
22510 (WTR::UIScriptController::doAsyncTask): Deleted.
22511 (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
22512 (WTR::UIScriptController::overridePreference): Deleted.
22513 (WTR::UIScriptController::findString): Deleted.
22514 (WTR::UIScriptController::removeViewFromWindow): Deleted.
22515 (WTR::UIScriptController::addViewToWindow): Deleted.
22516 (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
22518 2018-11-04 Eric Carlson <eric.carlson@apple.com>
22520 [MediaStream] User should not be prompted again after denying getDisplayMedia request
22521 https://bugs.webkit.org/show_bug.cgi?id=191227
22522 <rdar://problem/45784512>
22524 Reviewed by Youenn Fablet.
22526 * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
22527 (-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
22528 (TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
22529 (TestWebKitAPI::TEST_F):
22531 2018-11-04 Zalan Bujtas <zalan@apple.com>
22533 [LFC][BFC] Add support for percentage height in quirks mode.
22534 https://bugs.webkit.org/show_bug.cgi?id=191232
22536 Reviewed by Antti Koivisto.
22538 * LayoutReloaded/misc/LFC-passing-tests.txt:
22540 2018-11-04 Zalan Bujtas <zalan@apple.com>
22542 [LFC][BCF] Add support for block level non-replaced inflow height percentage
22543 https://bugs.webkit.org/show_bug.cgi?id=191229
22545 Reviewed by Antti Koivisto.
22547 * LayoutReloaded/misc/LFC-passing-tests.txt:
22549 2018-11-02 Zalan Bujtas <zalan@apple.com>
22551 [LFC][BFC] Resolve percentage height values.
22552 https://bugs.webkit.org/show_bug.cgi?id=191224
22554 Reviewed by Antti Koivisto.
22556 * LayoutReloaded/misc/LFC-passing-tests.txt:
22558 2018-11-03 Alex Christensen <achristensen@webkit.org>
22560 Mac production builds should sign the network process xpc service with entitlements
22561 https://bugs.webkit.org/show_bug.cgi?id=191209
22562 <rdar://problem/45377609>
22564 Reviewed by Geoff Garen.
22566 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22567 * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
22570 2018-11-02 Alex Christensen <achristensen@webkit.org>
22572 Unreviewed, rolling out r237761.
22574 Makes most API tests timeout and WK2 tests crash
22576 Reverted changeset:
22578 "Mac production builds should sign the network process xpc
22579 service with entitlements"
22580 https://bugs.webkit.org/show_bug.cgi?id=191209
22581 https://trac.webkit.org/changeset/237761
22583 2018-11-02 Michael Catanzaro <mcatanzaro@igalia.com>
22585 Unreviewed API test gardening
22587 * TestWebKitAPI/glib/TestExpectations.json:
22589 2018-11-02 Justin Michaud <justin_michaud@apple.com>
22591 Add new global object and preliminary Worklets support for CSS painting api
22592 https://bugs.webkit.org/show_bug.cgi?id=190979
22594 Reviewed by Chris Dumez.
22596 * Scripts/webkitpy/bindings/main.py:
22597 (BindingsTests.generate_supplemental_dependency):
22598 (BindingsTests.main):
22600 2018-11-02 Alex Christensen <achristensen@webkit.org>
22602 Mac production builds should sign the network process xpc service with entitlements
22603 https://bugs.webkit.org/show_bug.cgi?id=191209
22604 <rdar://problem/45377609>
22606 Reviewed by Geoff Garen.
22608 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22609 * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
22612 2018-11-02 Lucas Forschler <lforschler@apple.com>
22614 Add Windows 10 archive bots
22615 https://bugs.webkit.org/show_bug.cgi?id=190964
22617 This Change updates the Apple Windows Buildbot configuration.
22618 - Add Windows 10 specific builders and testers for release and debug.
22619 - Refactor Windows -> Windows 7.
22620 - Remove Windows 7 Debug.
22622 Reviewed by Aakash Jain.
22624 * BuildSlaveSupport/build.webkit.org-config/config.json:
22626 2018-11-02 Philippe Normand <pnormand@igalia.com>
22628 [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
22630 Rubber-stamped by Michael Catanzaro.
22632 This variable is useful to get rid of shell color escapes in tests stderr files.
22634 * Scripts/webkitpy/port/gtk.py:
22635 (GtkPort.setup_environ_for_server):
22636 * Scripts/webkitpy/port/wpe.py:
22637 (WPEPort.setup_environ_for_server):
22639 2018-11-02 Aakash Jain <aakash_jain@apple.com>
22641 Add Basic Django web app for OpenSource EWS
22642 https://bugs.webkit.org/show_bug.cgi?id=191091
22644 Reviewed by Lucas Forschler.
22646 * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
22647 * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
22648 * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
22649 * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
22650 * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
22651 * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
22652 * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
22653 * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
22654 * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
22655 * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
22656 * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
22657 * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
22658 * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
22659 * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
22661 2018-11-02 Daniel Bates <dabates@apple.com>
22663 [iOS] WebKit should dispatch DOM events when a modifier key is pressed
22664 https://bugs.webkit.org/show_bug.cgi?id=190487
22666 Reviewed by Tim Horton.
22668 Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
22669 match my observations when using the simulator to simulate iOS 12 and add support for testing
22670 right-hand side modifiers.
22672 * DumpRenderTree/mac/EventSendingController.mm:
22674 (-[EventSendingController keyDown:withModifiers:withLocation:]):
22675 (-[EventSendingController setTouchModifier:value:]):
22676 * WebKitTestRunner/ios/HIDEventGenerator.mm:
22677 (hidUsageCodeForCharacter):
22679 2018-11-02 Chris Dumez <cdumez@apple.com>
22681 [PSON] Reuse SuspendedPages' process when possible, for performance
22682 https://bugs.webkit.org/show_bug.cgi?id=191166
22684 Reviewed by Geoffrey Garen.
22686 Add API test coverage.
22688 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
22690 2018-11-02 Zalan Bujtas <zalan@apple.com>
22692 [LFC][IFC] Add support for intrinsic width calculation
22693 https://bugs.webkit.org/show_bug.cgi?id=191144
22695 Reviewed by Antti Koivisto.
22697 * LayoutReloaded/misc/LFC-passing-tests.txt:
22699 2018-11-01 Philippe Normand <pnormand@igalia.com>
22701 [Apache] Self-signed SSL certificate RSA key is considered too weak
22702 https://bugs.webkit.org/show_bug.cgi?id=191156
22704 Reviewed by Michael Catanzaro.
22706 * Scripts/webkitpy/common/system/pemfile.py:
22708 2018-11-02 Zan Dobersek <zdobersek@igalia.com>
22710 Unreviewed follow-up to r237678.
22712 * wpe/jhbuild.modules: The patch element apparently has to be a child
22713 of the branch in order for Jhbuild to properly detect and apply the
22716 2018-11-01 Ross Kirsling <ross.kirsling@sony.com>
22718 build-jsc --wincairo should update WinCairo libraries
22719 https://bugs.webkit.org/show_bug.cgi?id=191170
22721 Reviewed by Fujii Hironori.
22723 * Scripts/build-jsc:
22725 2018-11-01 John Wilander <wilander@apple.com>
22727 In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
22728 https://bugs.webkit.org/show_bug.cgi?id=191119
22729 <rdar://problem/44176965>
22731 Reviewed by Chris Dumez.
22733 This is an API test for a WebKitLegacy WebView that is first closed and then
22734 JavaScript is handed a keyboard event.
22736 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22737 * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
22738 (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
22739 (-[KeyboardEventListener handleEvent:]):
22740 (TestWebKitAPI::TEST):
22742 2018-11-01 Sihui Liu <sihui_liu@apple.com>
22744 Add a storage limit for IndexedDB
22745 https://bugs.webkit.org/show_bug.cgi?id=190598
22746 <rdar://problem/44654715>
22748 Reviewed by Chris Dumez.
22750 Add API for testing.
22752 * DumpRenderTree/TestRunner.cpp:
22753 (setIDBPerOriginQuotaCallback):
22754 (TestRunner::staticFunctions):
22755 * DumpRenderTree/TestRunner.h:
22756 * DumpRenderTree/mac/TestRunnerMac.mm:
22757 (TestRunner::setIDBPerOriginQuota):
22758 * DumpRenderTree/win/TestRunnerWin.cpp:
22759 (TestRunner::setIDBPerOriginQuota):
22760 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
22761 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
22762 (WTR::TestRunner::setIDBPerOriginQuota):
22763 * WebKitTestRunner/InjectedBundle/TestRunner.h:
22764 * WebKitTestRunner/TestController.cpp:
22765 (WTR::TestController::setIDBPerOriginQuota):
22766 * WebKitTestRunner/TestController.h:
22767 * WebKitTestRunner/TestInvocation.cpp:
22768 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
22770 2018-11-01 Chris Dumez <cdumez@apple.com>
22772 [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
22773 https://bugs.webkit.org/show_bug.cgi?id=191076
22775 Reviewed by Geoffrey Garen.
22777 Add API test coverage.
22779 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
22780 (-[PSONNavigationDelegate init]):
22781 (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
22783 2018-11-01 Adrian Perez de Castro <aperez@igalia.com>
22785 Fix build with VIDEO and WEB_AUDIO disabled
22786 https://bugs.webkit.org/show_bug.cgi?id=191147
22787 <rdar://problem/45726710>
22789 Unreviewed build fix.
22791 This adds the missing compilation guards in the WPE MiniBrowser.
22793 * MiniBrowser/wpe/main.cpp:
22794 (main): Condition GST includes and calls.
22796 2018-10-31 Zalan Bujtas <zalan@apple.com>
22798 [LFC][IFC] Add support for inline-block elements.
22799 https://bugs.webkit.org/show_bug.cgi?id=191143
22801 Reviewed by Antti Koivisto.
22803 * LayoutReloaded/misc/LFC-passing-tests.txt:
22805 2018-11-01 Claudio Saavedra <csaavedra@igalia.com>
22807 [WPE] Add missing libsoup patch to jhbuild
22808 https://bugs.webkit.org/show_bug.cgi?id=191149
22810 Reviewed by Žan Doberšek.
22812 * wpe/jhbuild.modules:
22813 * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
22815 2018-11-01 Claudio Saavedra <csaavedra@igalia.com>
22817 Fix build with VIDEO and WEB_AUDIO disabled
22818 https://bugs.webkit.org/show_bug.cgi?id=191147
22820 Reviewed by Philippe Normand.
22822 * MiniBrowser/gtk/main.c:
22823 (main): Condition GST includes and calls
22825 2018-10-31 Justin Michaud <justin_michaud@apple.com>
22827 Add Justin Michaud to the list of WebKit Committers
22828 https://bugs.webkit.org/show_bug.cgi?id=191142
22830 * Scripts/webkitpy/common/config/contributors.json:
22832 2018-10-31 Guillaume Emont <guijemont@igalia.com>
22834 Don't run JIT tests on 32-bit platforms
22835 https://bugs.webkit.org/show_bug.cgi?id=191074
22837 Reviewed by Michael Catanzaro.
22839 * Scripts/run-jsc-stress-tests:
22841 2018-10-30 Wenson Hsieh <wenson_hsieh@apple.com>
22843 [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
22844 https://bugs.webkit.org/show_bug.cgi?id=190530
22845 <rdar://problem/45232149>
22847 Reviewed by Tim Horton.
22849 Add a test to verify that copying different types of attachments and pasting in a new web view inserts
22850 attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
22851 is equivalent to the original file wrappers used to insert attachments in the first web view.
22853 Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
22854 is still backed by the same NSFileWrapper instance.
22856 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
22857 (TestWebKitAPI::TEST):
22859 2018-10-30 Fujii Hironori <Hironori.Fujii@sony.com>
22861 [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
22862 https://bugs.webkit.org/show_bug.cgi?id=190949
22864 Reviewed by Alex Christensen.
22866 Visual Studio 2017 Community is the alternative.
22868 * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
22869 (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
22870 (buildVisualStudioProject): Ditto.
22871 (dieIfWindowsPlatformSDKNotInstalled): Deleted.
22872 (usingVisualStudioExpress): Deleted.
22874 2018-10-30 Fujii Hironori <Hironori.Fujii@sony.com>
22876 [Win][Direct2D] Support building DumpRenderTree for Direct2D
22877 https://bugs.webkit.org/show_bug.cgi?id=191093
22878 <rdar://problem/45685706>
22880 Unreviewed build fix.
22882 error C2065: 'renderTarget': undeclared identifier
22884 * DumpRenderTree/win/PixelDumpSupportWin.cpp:
22885 (createBitmapContextFromWebView): Restored the previous implementation.
22887 2018-10-30 Don Olmstead <don.olmstead@sony.com>
22889 [PlayStation] Enable JavaScriptCore
22890 https://bugs.webkit.org/show_bug.cgi?id=191072
22892 Reviewed by Brent Fulgham.
22894 Add platform scripts for building the PlayStation port.
22895 perl Tools/Scripts/build-webkit --playstation
22897 * Scripts/build-webkit:
22898 * Scripts/build-webkittestrunner:
22899 * Scripts/webkitdirs.pm:
22900 (argumentsForConfiguration):
22901 (determineConfigurationProductDir):
22902 (isPlayStation): Added.
22903 (getMSBuildPlatformArgument): Added.
22904 (buildVisualStudioProject):
22905 (wrapperPrefixIfNeeded):
22906 (generateBuildSystemFromCMakeProject):
22907 * TestWebKitAPI/PlatformPlayStation.cmake: Added.
22909 2018-10-30 Brent Fulgham <bfulgham@apple.com>
22911 [Win][Direct2D] Support building DumpRenderTree for Direct2D
22912 https://bugs.webkit.org/show_bug.cgi?id=191093
22913 <rdar://problem/45685706>
22915 Reviewed by Alex Christensen.
22917 * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
22918 * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
22919 * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
22920 (pixelDumpSystemFactory): Added.
22921 (printPNG): Create stub.
22922 (computeMD5HashStringForBitmapContext): Ditto.
22923 (dumpBitmap): Ditto.
22924 * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
22925 (BitmapContext::createByAdoptingBitmapAndContext):
22926 (BitmapContext::~BitmapContext):
22927 (BitmapContext::platformContext const):
22928 (BitmapContext::BitmapContext):
22929 * DumpRenderTree/win/PixelDumpSupportWin.cpp:
22930 (createBitmapContextFromWebView): Update to support Direct2D.
22931 * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
22932 logo is no longer available at this location. Switch to the new logo.
22934 2018-10-30 Jonathan Bedard <jbedard@apple.com>
22936 webkitpy: Support alternate simctl list outputs
22937 https://bugs.webkit.org/show_bug.cgi?id=191090
22938 <rdar://problem/45684255>
22940 Rubber-stamped by Aakash Jain.
22942 * Scripts/webkitpy/xcode/simulated_device.py:
22943 (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
22944 (SimulatedDeviceManager._create_device_with_runtime): Ditto.
22945 * Scripts/webkitpy/xcode/simulated_device_unittest.py:
22946 (test_available_devices): Add iOS 12 with alternative availability format.
22948 2018-10-30 Alexey Proskuryakov <ap@apple.com>
22950 Clean up some obsolete MAX_ALLOWED macros
22951 https://bugs.webkit.org/show_bug.cgi?id=190916
22953 Reviewed by Tim Horton.
22955 * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
22956 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
22957 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
22959 2018-10-30 Claudio Saavedra <csaavedra@igalia.com>
22961 [GTK][WPE] Fixes to the PublicSuffix implementation
22962 https://bugs.webkit.org/show_bug.cgi?id=191031
22964 Reviewed by Michael Catanzaro.
22966 * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
22967 (TestWebKitAPI::TEST_F): Remove a test for a domain
22968 that is not registrable and shouldn't be tested there.
22970 2018-10-29 Tim Horton <timothy_horton@apple.com>
22972 Modernize WebKit nibs and lprojs for localization's sake
22973 https://bugs.webkit.org/show_bug.cgi?id=190911
22974 <rdar://problem/45349466>
22976 Reviewed by Dan Bernstein.
22978 * Scripts/check-inspector-strings:
22979 * Scripts/update-webkit-localizable-strings:
22980 * gtk/manifest.txt.in:
22981 * wpe/manifest.txt.in:
22984 2018-10-29 Daniel Bates <dabates@apple.com>
22986 [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
22987 https://bugs.webkit.org/show_bug.cgi?id=191036
22989 Reviewed by Andy Estes.
22991 Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
22992 by an enum that contains two or more enumerators with the same value. For example, suppose
22993 you have the following enum:
23000 Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
23001 this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
23002 differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
23003 tend to be used in bounds checks as opposed to code that adds to a set.
23005 * lldb/lldbWebKitTester/main.cpp:
23006 (testSummaryProviders):
23007 * lldb/lldb_webkit.py:
23008 (WTFOptionSetProvider.update):
23009 * lldb/lldb_webkit_unittest.py:
23010 (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
23011 (TestSummaryProviders):
23012 (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
23014 2018-10-29 Daniel Bates <dabates@apple.com>
23016 [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
23017 https://bugs.webkit.org/show_bug.cgi?id=191033
23019 Reviewed by Andy Estes.
23021 For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
23022 We display the same details in the summary for a Frame because its Document tends to be the most
23023 interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
23024 and whether the origin has universal access.
23026 * lldb/lldb_webkit.py:
23027 (__lldb_init_module):
23028 Register new summary providers.
23030 (WebCoreSecurityOrigin_SummaryProvider):
23031 (WebCoreFrame_SummaryProvider):
23032 (WebCoreDocument_SummaryProvider):
23033 Add new summary providers.
23035 (StdOptionalWrapper):
23036 (StdOptionalWrapper.__init__):
23037 (StdOptionalWrapper.has_value):
23038 (StdOptionalWrapper.value):
23039 Convenience data type that provides access to the fields of a std::optional<>.
23041 (WebCoreSecurityOriginProvider):
23042 (WebCoreSecurityOriginProvider.__init__):
23043 (WebCoreSecurityOriginProvider.is_unique):
23044 (WebCoreSecurityOriginProvider.scheme):
23045 (WebCoreSecurityOriginProvider.host):
23046 (WebCoreSecurityOriginProvider.port):
23047 (WebCoreSecurityOriginProvider.domain):
23048 (WebCoreSecurityOriginProvider.has_universal_access):
23049 (WebCoreSecurityOriginProvider.to_string):
23050 (WebCoreFrameProvider):
23051 (WebCoreFrameProvider.__init__):
23052 (WebCoreFrameProvider.is_main_frame):
23053 (WebCoreFrameProvider.document):
23054 (WebCoreDocumentProvider):
23055 (WebCoreDocumentProvider.__init__):
23056 (WebCoreDocumentProvider.url):
23057 (WebCoreDocumentProvider.origin):
23058 (WebCoreDocumentProvider.page_cache_state):
23059 (WebCoreDocumentProvider.frame):
23061 2018-10-29 Chris Dumez <cdumez@apple.com>
23063 [PSON] When Safari restores session state after launching, going back and forward does not swap processes
23064 https://bugs.webkit.org/show_bug.cgi?id=190975
23065 <rdar://problem/45059256>
23067 Reviewed by Antti Koivisto.
23069 Add API test coverage.
23071 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
23073 2018-10-29 Zalan Bujtas <zalan@apple.com>
23075 [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
23076 https://bugs.webkit.org/show_bug.cgi?id=191018
23078 Reviewed by Antti Koivisto.
23080 * LayoutReloaded/misc/LFC-passing-tests.txt:
23082 2018-10-29 Zalan Bujtas <zalan@apple.com>
23084 [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
23085 https://bugs.webkit.org/show_bug.cgi?id=191011
23087 Reviewed by Antti Koivisto.
23089 * LayoutReloaded/misc/LFC-passing-tests.txt:
23091 2018-10-29 Zalan Bujtas <zalan@apple.com>
23093 Missing from r237549
23095 Reviewed by Antti Koivisto.
23097 * LayoutReloaded/misc/LFC-passing-tests.txt:
23099 2018-10-29 Zalan Bujtas <zalan@apple.com>
23101 [LFC][IFC] Add support for simple intruding floats.
23102 https://bugs.webkit.org/show_bug.cgi?id=190998
23104 Reviewed by Antti Koivisto.
23106 * LayoutReloaded/misc/LFC-passing-tests.txt:
23108 2018-10-29 Zalan Bujtas <zalan@apple.com>
23110 [LFC][IFC] Inline layout produces separate runs when float is present.
23111 https://bugs.webkit.org/show_bug.cgi?id=190980
23113 Reviewed by Antti Koivisto.
23115 * LayoutReloaded/misc/LFC-passing-tests.txt:
23117 2018-10-29 Tadeu Zagallo <tzagallo@apple.com>
23119 New bytecode format for JSC
23120 https://bugs.webkit.org/show_bug.cgi?id=187373
23121 <rdar://problem/44186758>
23123 Reviewed by Filip Pizlo.
23125 Do not force ENABLE_JIT=true when $forceCLoop is false.
23127 * Scripts/build-jsc:
23129 2018-10-29 Claudio Saavedra <csaavedra@igalia.com>
23131 [GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
23133 Unreviewed build fix
23135 The build fails because of some array-bound check related
23136 to strcmp() macro optimizations. Disabling selective Werrors
23137 when building xserver-xorg might get past this.
23139 * gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
23142 2018-10-29 Claudio Saavedra <csaavedra@igalia.com>
23144 [GTK] Update API test expectations after r237383
23145 https://bugs.webkit.org/show_bug.cgi?id=186913
23147 Unreviewed gardening.
23149 * TestWebKitAPI/glib/TestExpectations.json: Remove
23150 passing TestSSL tests.
23152 2018-10-28 Zan Dobersek <zdobersek@igalia.com>
23154 [WPE] Add the WebKitVersion.h header
23155 https://bugs.webkit.org/show_bug.cgi?id=191015
23157 Reviewed by Michael Catanzaro.
23159 * MiniBrowser/wpe/main.cpp:
23160 (automationStartedCallback): Remove the FIXME and finally enable the
23161 webkit_application_info_set_version() call.
23162 * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Remove
23163 this FIXME as well and remove the custom WEBKIT_*_VERSION macros.
23165 2018-10-28 Fujii Hironori <Hironori.Fujii@sony.com>
23167 [Win] Remove obsolete code for vcxproj builds in build-api-tests and build-jsc
23168 https://bugs.webkit.org/show_bug.cgi?id=190948
23170 Reviewed by Brent Fulgham.
23172 vcxproj files have been removed in Bug 154388.
23174 * Scripts/build-api-tests: Removed obsolete code to build vcproj.
23175 * Scripts/build-jsc:
23176 (buildMyProject): Ditto. Removed a condition of buiding bmalloc
23177 which is not used because Windows ports are using CMake.
23179 2018-10-28 Geoffrey Garen <ggaren@apple.com>
23181 HashMap should support selecting a random entry
23182 https://bugs.webkit.org/show_bug.cgi?id=190814
23184 Reviewed by Ryosuke Niwa.
23186 * TestWebKitAPI/Tests/WTF/HashMap.cpp: Renamed IsRandom to
23187 IsEvenlyDistributed to reflect the fact that we're only testing the
23188 distribution. Added a test case that covers more table densities and
23189 the remove() operation.
23191 2018-10-27 Charlie Turner <cturner@igalia.com>
23193 [GTK] Add bubblewrap feature option
23194 https://bugs.webkit.org/show_bug.cgi?id=190981
23196 Reviewed by Xabier Rodriguez-Calvar.
23198 Without this, it was not possible to disable the bubblewrap sandbox
23199 from the webkit build scripts.
23201 * Scripts/webkitperl/FeatureList.pm:
23203 2018-10-26 Commit Queue <commit-queue@webkit.org>
23205 Unreviewed, rolling out r237479 and r237484.
23206 https://bugs.webkit.org/show_bug.cgi?id=190978
23208 broke JSC on iOS (Requested by tadeuzagallo on #webkit).
23210 Reverted changesets:
23212 "New bytecode format for JSC"
23213 https://bugs.webkit.org/show_bug.cgi?id=187373
23214 https://trac.webkit.org/changeset/237479
23216 "Gardening: Build fix after r237479."
23217 https://bugs.webkit.org/show_bug.cgi?id=187373
23218 https://trac.webkit.org/changeset/237484
23220 2018-10-26 Tadeu Zagallo <tzagallo@apple.com>
23222 New bytecode format for JSC
23223 https://bugs.webkit.org/show_bug.cgi?id=187373
23224 <rdar://problem/44186758>
23226 Reviewed by Filip Pizlo.
23228 Do not force ENABLE_JIT=true when $forceCLoop is false.
23230 * Scripts/build-jsc:
23232 2018-10-26 Geoffrey Garen <ggaren@apple.com>
23234 HashMap should support selecting a random entry
23235 https://bugs.webkit.org/show_bug.cgi?id=190814
23237 Reviewed by Antti Koivisto.
23239 * TestWebKitAPI/Tests/WTF/HashMap.cpp: Updated the Random_IsRandom to
23240 more thoroughly test for randomness.
23242 2018-10-26 Antti Koivisto <antti@apple.com>
23244 hashSet.remove(hashSet.random()) doesn't build
23245 https://bugs.webkit.org/show_bug.cgi?id=190953
23247 Reviewed by Chris Dumez.
23249 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
23250 (TestWebKitAPI::TEST):
23252 2018-10-26 Zalan Bujtas <zalan@apple.com>
23254 [LFC][IFC] Layout floats as part of the inline content
23255 https://bugs.webkit.org/show_bug.cgi?id=190942
23257 Reviewed by Antti Koivisto.
23259 * LayoutReloaded/misc/LFC-passing-tests.txt:
23261 2018-10-26 Alicia Boya García <aboya@igalia.com>
23263 [MSE][WTF][Media] Invalid MediaTime should be falsy
23264 https://bugs.webkit.org/show_bug.cgi?id=190893
23266 Reviewed by Jer Noble.
23268 This patch adds additional API tests for the conversions from
23269 MediaTime to boolean.
23271 * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
23272 (TestWebKitAPI::TEST):
23274 2018-10-25 Chris Dumez <cdumez@apple.com>
23276 [PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem
23277 https://bugs.webkit.org/show_bug.cgi?id=190915
23278 <rdar://problem/45059069>
23280 Reviewed by Geoffrey Garen.
23282 Add API test coverage.
23284 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
23286 2018-10-25 Joseph Pecoraro <pecoraro@apple.com>
23288 Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
23289 https://bugs.webkit.org/show_bug.cgi?id=190896
23291 Reviewed by Matt Baker.
23293 * Scripts/webkitpy/common/config/watchlist:
23295 2018-10-25 Geoffrey Garen <ggaren@apple.com>
23297 HashMap should support selecting a random entry
23298 https://bugs.webkit.org/show_bug.cgi?id=190814
23300 Reviewed by Antti Koivisto.
23302 Unit testing is fun and easy!
23304 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
23305 (TestWebKitAPI::ZeroHash::hash):
23306 (TestWebKitAPI::TEST):
23308 2018-10-24 Tim Horton <timothy_horton@apple.com>
23310 REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
23311 https://bugs.webkit.org/show_bug.cgi?id=190897
23313 * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
23314 (TestWebKitAPI::TEST):
23315 Disable the test for now.
23317 2018-10-24 Alexey Proskuryakov <ap@apple.com>
23319 Clean up some obsolete macOS version guards
23320 https://bugs.webkit.org/show_bug.cgi?id=190887
23322 Reviewed by Dan Bernstein.
23324 * TestWebKitAPI/cocoa/TestWKWebView.mm:
23325 (__simulated_forceClickAssociatedEventsMask):
23326 (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
23327 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
23328 (WTR::initializeWebViewConfiguration):
23329 * WebKitTestRunner/mac/EventSenderProxy.mm:
23330 (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
23332 2018-10-24 Megan Gardner <megan_gardner@apple.com>
23334 Turn on Conic Gradients
23335 https://bugs.webkit.org/show_bug.cgi?id=190810
23337 Reviewed by Tim Horton.
23339 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
23341 2018-10-24 Pablo Saavedra <psaavedra@igalia.com>
23343 [WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode
23344 https://bugs.webkit.org/show_bug.cgi?id=190328
23346 Reviewed by Michael Catanzaro.
23348 * TestWebKitAPI/CMakeLists.txt:
23349 * TestWebKitAPI/PlatformWPE.cmake:
23351 2018-10-24 Chris Dumez <cdumez@apple.com>
23353 [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
23354 https://bugs.webkit.org/show_bug.cgi?id=190846
23355 <rdar://problem/45058938>
23357 Reviewed by Antti Koivisto.
23359 Add API test coverage.
23361 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
23363 2018-10-24 Claudio Saavedra <csaavedra@igalia.com>
23365 [GTK] TestSSL failing because of missing libsoup patch
23366 https://bugs.webkit.org/show_bug.cgi?id=190869
23368 Reviewed by Michael Catanzaro.
23370 * gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
23371 * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
23373 2018-10-23 Justin Fan <justin_fan@apple.com>
23375 [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
23376 https://bugs.webkit.org/show_bug.cgi?id=190817
23378 Reviewed by Dean Jackson.
23380 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23381 * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm.
23382 (TestWebKitAPI::TEST_F):
23383 * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
23384 (TestWebKitAPI::TEST_F):
23385 * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
23386 (TestWebKitAPI::TEST_F):
23387 * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
23388 (TestWebKitAPI::TEST_F):
23389 * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm.
23390 (TestWebKitAPI::TEST_F):
23391 * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUTest.h.
23393 2018-10-23 Chris Dumez <cdumez@apple.com>
23395 [PSON] Add support for cross-site client-side redirects
23396 https://bugs.webkit.org/show_bug.cgi?id=190806
23397 <rdar://problem/45047344>
23399 Reviewed by Geoffrey Garen.
23401 Add API test coverage.
23403 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
23404 (-[PSONNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
23405 (-[PSONNavigationDelegate _webView:didPerformClientRedirectFromURL:toURL:]):
23407 2018-10-23 Claudio Saavedra <csaavedra@igalia.com>
23409 [WPE][GTK] Pass full certificate chain in CertificateInfo coder
23410 https://bugs.webkit.org/show_bug.cgi?id=190789
23412 Reviewed by Michael Catanzaro.
23414 When the network process serializes certificate data to other
23415 processes through the argument coders, the certificate chain, if
23416 present, is lost. In practice this means that applications using
23417 the public API to process certificate info have no details on the
23418 certificate chain, other than the very basics included in the
23419 certificate. Serialize the entire chain if available in the
23422 * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
23423 (testSSL): Test that the self-signed certificate has no bogus
23424 issuer certificate.
23426 2018-10-22 Tim Horton <timothy_horton@apple.com>
23428 REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
23429 https://bugs.webkit.org/show_bug.cgi?id=190801
23430 <rdar://problem/43674361>
23432 * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
23434 Use a parented WKWebView for this test, otherwise none of the assertions
23435 about gesture recognizers work anymore.
23437 2018-10-22 Ryan Haddad <ryanhaddad@apple.com>
23439 REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
23440 https://bugs.webkit.org/show_bug.cgi?id=187972
23442 Unreviewed test gardening.
23444 * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
23445 (TestWebKitAPI::TEST): Disable the flaky test.
23447 2018-10-22 Wenson Hsieh <wenson_hsieh@apple.com>
23449 [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails
23450 https://bugs.webkit.org/show_bug.cgi?id=190777
23452 Reviewed by Tim Horton.
23454 Implement isShowingDataListSuggestions on iOS. See below for more details.
23456 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
23457 (WTR::UIScriptController::isShowingDataListSuggestions const):
23459 Add a stub implementation for DumpRenderTree.
23461 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
23462 (WTR::UIScriptController::isShowingDataListSuggestions const):
23464 Move this stub implementation to !PLATFORM(COCOA).
23466 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
23467 (WTR::forEachViewInHierarchy):
23469 Add a helper function to apply a given function to a UIView and each of its subviews, recursively.
23471 (WTR::UIScriptController::isShowingDataListSuggestions const):
23473 For iOS, return whether the UIRemoteKeyboardWindow contains a subview of type WKDataListSuggestionsPickerView.
23475 2018-10-19 Dan Bernstein <mitz@apple.com>
23477 [macOS] MiniBrowser has an unused injected bundle
23478 https://bugs.webkit.org/show_bug.cgi?id=190770
23480 Reviewed by Tim Horton.
23482 * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
23483 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target,
23484 the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
23485 * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
23486 * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
23487 * MiniBrowser/mac/Bundle: Removed.
23489 2018-10-19 Wenson Hsieh <wenson_hsieh@apple.com>
23491 [iOS] [Datalist] Can't pick datalist suggestions in a stock WKWebView
23492 https://bugs.webkit.org/show_bug.cgi?id=190621
23493 <rdar://problem/45310649>
23495 Reviewed by Tim Horton.
23497 Add a UIScriptController hook to resign first responder on WKWebView. See LayoutTests/ChangeLog for more detail.
23499 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
23500 (WTR::UIScriptController::resignFirstResponder):
23501 * DumpRenderTree/mac/UIScriptControllerMac.mm:
23502 (WTR::UIScriptController::resignFirstResponder):
23503 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
23504 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
23505 (WTR::UIScriptController::resignFirstResponder):
23506 * TestRunnerShared/UIScriptContext/UIScriptController.h:
23507 * WebKitTestRunner/UIScriptControllerCocoa.mm:
23508 (WTR::UIScriptController::resignFirstResponder):
23509 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
23510 (WTR::PlatformWebView::makeWebViewFirstResponder):
23512 Implement this method stub on iOS, to ensure that TestController::resetStateToConsistentValues restores first
23513 responder on the WKWebView when running iOS layout tests.
23515 * WebKitTestRunner/ios/TestControllerIOS.mm:
23516 (WTR::TestController::platformResetStateToConsistentValues):
23518 After resigning first responder to dismiss any on-screen keyboard, ensure that we restore first responder.
23520 2018-10-19 Dean Jackson <dino@apple.com>
23522 ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
23523 https://bugs.webkit.org/show_bug.cgi?id=186946
23524 <rdar://problem/41724248>
23526 Reviewed by Antoine Quint.
23528 If the incoming test has different enableWebAnimationsCSSIntegration options,
23529 then we need to create a new WebView.
23531 * DumpRenderTree/TestOptions.cpp:
23532 (TestOptions::webViewIsCompatibleWithOptions const):
23534 2018-10-19 Charlie Turner <cturner@igalia.com>
23536 [EME] Fix crash during tracing in gst_qtdemux_request_protection_context
23537 https://bugs.webkit.org/show_bug.cgi?id=190738
23539 Reviewed by Xabier Rodriguez-Calvar.
23541 Add a GStreamer patch to avoid crashing when the run-time logging
23542 level is TRACE. There was a missing null check which caused many
23545 * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Added.
23547 2018-10-18 Alicia Boya García <aboya@igalia.com>
23549 [Media] Use nanoseconds as MaximumTimeScale
23550 https://bugs.webkit.org/show_bug.cgi?id=190631
23552 Rebased MediaTime tests covering timescales over the maximum.
23554 Reviewed by Jer Noble.
23556 * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
23557 (TestWebKitAPI::TEST):
23559 2018-10-18 Dean Johnson <dean_johnson@apple.com>
23561 clean-webkit pulls in many unnecessary dependencies in webkitpy
23562 https://bugs.webkit.org/show_bug.cgi?id=190732
23564 Reviewed by Alexey Proskuryakov.
23566 * Scripts/webkitpy/common/host.py:
23567 (Host.__init__): Split out 'bugs', 'bugzilla', and 'web' to only be created when used.
23573 2018-10-18 Chris Dumez <cdumez@apple.com>
23575 [PSON] SuspendedPages do not report meaningful domains in Activity Monitor
23576 https://bugs.webkit.org/show_bug.cgi?id=190721
23577 <rdar://problem/45059699>
23579 Reviewed by Alex Christensen.
23581 Add API test coverage.
23583 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
23585 2018-10-18 Alexey Proskuryakov <ap@apple.com>
23587 Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
23588 https://bugs.webkit.org/show_bug.cgi?id=190729
23590 Reviewed by Tim Horton.
23592 * DumpRenderTree/AccessibilityController.h:
23593 * DumpRenderTree/AccessibilityTextMarker.h:
23594 * DumpRenderTree/AccessibilityUIElement.cpp:
23595 (AccessibilityUIElement::getJSClass):
23596 * DumpRenderTree/AccessibilityUIElement.h:
23597 * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
23598 * DumpRenderTree/TestRunner.cpp:
23599 (getSecureEventInputIsEnabledCallback):
23600 (TestRunner::staticFunctions):
23601 (TestRunner::callUIScriptCallback):
23602 * DumpRenderTree/TestRunner.h:
23603 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
23604 * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm:
23605 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
23606 * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
23607 * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
23608 * DumpRenderTree/ios/TextInputControllerIOS.m:
23609 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
23610 * DumpRenderTree/mac/AppleScriptController.m:
23611 * DumpRenderTree/mac/DumpRenderTree.mm:
23612 (createWebViewAndOffscreenWindow):
23613 (destroyWebViewAndOffscreenWindow):
23614 (resetWebPreferencesToConsistentValues):
23615 (setDefaultsToConsistentValuesForTesting):
23616 (allocateGlobalControllers):
23617 (releaseGlobalControllers):
23618 (addTestPluginsToPluginSearchPath):
23619 (prepareConsistentTestingEnvironment):
23621 (DumpRenderTreeMain):
23623 (dumpBackForwardListForAllWindows):
23626 (resetWebViewToConsistentStateBeforeTesting):
23629 (displayAndTrackRepaintsWebView):
23630 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
23631 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
23632 * DumpRenderTree/mac/DumpRenderTreeMac.h:
23633 * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
23634 * DumpRenderTree/mac/DumpRenderTreeWindow.h:
23635 * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
23636 (-[DumpRenderTreeWindow close]):
23637 (-[DumpRenderTreeWindow webView]):
23638 (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
23639 * DumpRenderTree/mac/EventSendingController.h:
23640 * DumpRenderTree/mac/EventSendingController.mm:
23641 (+[EventSendingController isSelectorExcludedFromWebScript:]):
23642 (+[EventSendingController webScriptNameForSelector:]):
23643 (-[EventSendingController dealloc]):
23644 (-[EventSendingController currentEventTime]):
23645 (-[EventSendingController clearKillRing]):
23647 (-[EventSendingController mouseDown:withModifiers:]):
23648 (-[EventSendingController scalePageBy:atX:andY:]):
23649 (-[EventSendingController mouseUp:withModifiers:]):
23650 (-[EventSendingController mouseMoveToX:Y:]):
23651 (-[EventSendingController mouseScrollByX:andY:continuously:]):
23652 (-[EventSendingController keyDown:withModifiers:withLocation:]):
23653 * DumpRenderTree/mac/FrameLoadDelegate.mm:
23654 (-[FrameLoadDelegate init]):
23655 (-[FrameLoadDelegate dealloc]):
23656 (-[FrameLoadDelegate processWork:]):
23657 (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
23658 (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
23659 (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
23660 * DumpRenderTree/mac/LayoutTestHelper.m:
23661 * DumpRenderTree/mac/MockGeolocationProvider.mm:
23662 (-[MockGeolocationProvider timerFired]):
23663 * DumpRenderTree/mac/TestRunnerMac.mm:
23664 (TestRunner::setMainFrameIsFirstResponder):
23665 (TestRunner::setAutomaticLinkDetectionEnabled):
23666 (TestRunner::setUseDashboardCompatibilityMode):
23667 (TestRunner::isCommandEnabled):
23668 (TestRunner::inspectorTestStubURL):
23669 (TestRunner::apiTestNewWindowDataLoadBaseURL):
23670 (TestRunner::abortModal):
23671 (TestRunner::setTextDirection):
23672 (TestRunner::addChromeInputField):
23673 (TestRunner::removeChromeInputField):
23674 (TestRunner::focusWebView):
23675 (TestRunner::setBackingScaleFactor):
23676 (TestRunner::imageCountInGeneralPasteboard const):
23677 * DumpRenderTree/mac/UIDelegate.h:
23678 * DumpRenderTree/mac/UIDelegate.mm:
23679 (-[UIDelegate modalWindowWillClose:]):
23680 (-[UIDelegate webViewRunModal:]):
23681 (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
23682 (-[UIDelegate dealloc]):
23683 * Scripts/check-for-inappropriate-objc-class-names:
23684 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
23685 * TestRunnerShared/spi/UIKitTestSPI.h:
23686 * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
23687 * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
23688 (WebCore::operator<<):
23689 * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
23690 (TestWebKitAPI::TEST):
23691 * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
23692 (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
23693 * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
23694 * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
23695 (TestWebKitAPI::TEST):
23696 * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
23697 (TestWebKitAPI::TEST):
23698 * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm:
23699 * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
23700 * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
23702 * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandle.mm:
23704 * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandlePlugIn.mm:
23705 (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
23706 * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
23708 * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
23709 * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
23710 (createWebViewWithCustomPasteboardDataEnabled):
23711 * TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
23713 * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
23714 * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
23715 * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
23716 * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
23717 * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
23718 * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
23719 * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
23720 * TestWebKitAPI/Tests/WebKitCocoa/Geolocation.mm:
23721 * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
23722 * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
23723 (defaultWebsiteCacheDirectory):
23724 (defaultApplicationCacheDirectory):
23726 * TestWebKitAPI/Tests/WebKitCocoa/NSFileManagerExtras.mm:
23727 * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
23728 * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
23729 * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
23730 * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
23731 * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
23732 (TestWebKitAPI::TEST):
23733 * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
23734 * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
23735 * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptions.mm:
23736 (runTestWithWidth):
23737 * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptionsPlugIn.mm:
23738 (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
23739 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
23740 * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
23741 * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
23742 * TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm:
23743 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
23744 (platformCopyRichTextWithMultipleAttachments):
23745 (platformCopyRichTextWithImage):
23747 * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
23748 * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
23749 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
23750 * TestWebKitAPI/Tests/WebKitCocoa/WKPDFViewStablePresentationUpdateCallback.mm:
23751 * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
23752 * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
23753 * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
23755 * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
23757 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
23759 * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
23760 * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
23761 * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
23762 * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
23763 * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
23764 * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
23765 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
23766 * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
23767 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
23768 * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
23769 * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
23770 * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
23771 * TestWebKitAPI/Tests/ios/SynchronousTimeoutTests.mm:
23772 * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
23773 * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
23774 * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
23775 * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
23776 * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm:
23777 * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
23778 * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
23779 * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm:
23780 * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
23781 * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
23782 (-[WKWebView _test_waitForDidFinishNavigation]):
23783 * TestWebKitAPI/cocoa/TestWKWebView.h:
23784 * TestWebKitAPI/cocoa/TestWKWebView.mm:
23785 * TestWebKitAPI/config.h:
23786 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
23787 * TestWebKitAPI/ios/TestWKWebViewController.h:
23788 * TestWebKitAPI/ios/TestWKWebViewController.mm:
23789 * TestWebKitAPI/ios/UIKitSPI.h:
23790 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
23791 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
23792 (WTR::InjectedBundle::beginTesting):
23793 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
23794 (WTR::TestRunner::inspectorTestStubURL):
23795 * WebKitTestRunner/TestController.cpp:
23796 (WTR::TestController::webProcessName):
23797 (WTR::TestController::networkProcessName):
23798 * WebKitTestRunner/TestInvocation.cpp:
23799 (WTR::TestInvocation::invoke):
23800 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
23801 * WebKitTestRunner/cg/TestInvocationCG.cpp:
23802 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
23803 (WTR::initializeWebViewConfiguration):
23804 (WTR::TestController::platformCreateWebView):
23805 (WTR::TestController::imageCountInGeneralPasteboard const):
23806 (WTR::TestController::addTestKeyToKeychain):
23807 (WTR::TestController::cleanUpKeychain):
23808 (WTR::TestController::keyExistsInKeychain):
23809 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
23810 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
23811 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
23813 2018-10-18 Chris Dumez <cdumez@apple.com>
23815 [PSON] Cap number of SuspendedPageProxy objects and allow a WebPageProxy to have more than one
23816 https://bugs.webkit.org/show_bug.cgi?id=190688
23817 <rdar://problem/45354095>
23819 Reviewed by Antti Koivisto.
23821 Extended API test coverage to confirm that:
23822 - We do not accumulate more than 3 suspended processes.
23823 - We can navigate back 3 times and use the page cache for each of these loads.
23825 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
23827 2018-10-17 Wenson Hsieh <wenson_hsieh@apple.com>
23829 Enable the datalist element by default on iOS and macOS
23830 https://bugs.webkit.org/show_bug.cgi?id=190594
23831 <rdar://problem/45281159>
23833 Reviewed by Ryosuke Niwa and Tim Horton.
23835 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
23837 2018-10-17 Chris Fleizach <cfleizach@apple.com>
23839 AX: Certain tags should identify their context to iOS API
23840 https://bugs.webkit.org/show_bug.cgi?id=190622
23841 <rdar://problem/45308194>
23843 Reviewed by Zalan Bujtas.
23845 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
23846 (AccessibilityUIElement::stringAttributeValue):
23847 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
23848 (WTR::AccessibilityUIElement::stringAttributeValue):
23850 2018-10-16 Sihui Liu <sihui_liu@apple.com>
23852 Add a switch for Web SQL
23853 https://bugs.webkit.org/show_bug.cgi?id=190271
23855 Reviewed by Ryosuke Niwa.
23857 * WebKitTestRunner/TestController.cpp:
23858 (WTR::TestController::resetPreferencesToConsistentValues):
23860 2018-10-16 Alex Christensen <achristensen@webkit.org>
23862 Remove InjectedBundleBackForwardList
23863 https://bugs.webkit.org/show_bug.cgi?id=190640
23865 Reviewed by Chris Dumez.
23867 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
23868 (WTR::InjectedBundle::dumpBackForwardListsForAllPages):
23869 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
23870 (WTR::InjectedBundlePage::prepare):
23871 (WTR::InjectedBundlePage::dumpHistory):
23872 (WTR::hasPrefix): Deleted.
23873 (WTR::compareByTargetName): Deleted.
23874 (WTR::dumpBackForwardListItem): Deleted.
23875 (WTR::InjectedBundlePage::dumpBackForwardList): Deleted.
23876 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
23877 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
23878 (WTR::TestRunner::clearBackForwardList):
23880 2018-10-16 Dominik Infuehr <dinfuehr@igalia.com>
23882 Unreviewed, added myself to contributors.json.
23884 * Scripts/webkitpy/common/config/contributors.json:
23886 2018-10-16 Justin Michaud <justin_michaud@apple.com>
23888 Implement feature flag and bindings for CSS Painting API
23889 https://bugs.webkit.org/show_bug.cgi?id=190237
23891 Reviewed by Ryosuke Niwa.
23893 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
23895 2018-10-16 Philippe Normand <pnormand@igalia.com>
23897 Unreviewed, GTK Ubuntu LTS Jhbuild prospective build fix
23899 * gstreamer/jhbuild.modules:
23901 2018-10-16 Philippe Normand <pnormand@igalia.com>
23903 [GTK][JHBuild] Disable libmount support in glib
23905 Rubber-stamped by Alejandro G. Castro.
23907 This feature doesn't seem required for our setup.
23909 * gtk/jhbuild.modules:
23911 2018-10-15 Justin Fan <justin_fan@apple.com>
23913 Add WebGPU 2018 feature flag and experimental feature flag
23914 https://bugs.webkit.org/show_bug.cgi?id=190509
23916 Reviewed by Dean Jackson.
23918 Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
23919 for the 2018 WebGPU prototype.
23921 * DumpRenderTree/TestOptions.cpp:
23922 (TestOptions::TestOptions):
23923 * DumpRenderTree/TestOptions.h:
23924 * DumpRenderTree/mac/DumpRenderTree.mm:
23925 (setWebPreferencesForTestOptions):
23926 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
23928 2018-10-15 Ryan Haddad <ryanhaddad@apple.com>
23930 Update bot configuration for Sierra archive queues
23931 https://bugs.webkit.org/show_bug.cgi?id=190605
23933 Reviewed by Aakash Jain.
23935 * BuildSlaveSupport/build.webkit.org-config/config.json:
23937 2018-10-15 Timothy Hatcher <timothy@apple.com>
23939 Add support for prefers-color-scheme media query
23940 https://bugs.webkit.org/show_bug.cgi?id=190499
23941 rdar://problem/45212025
23943 Reviewed by Dean Jackson.
23945 * Scripts/webkitperl/FeatureList.pm: Added ENABLE_DARK_MODE_CSS as dark-mode-css.
23946 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
23948 2018-10-15 Patrick Griffis <pgriffis@igalia.com>
23950 [JHBuild] Add xdg-dbus-proxy module
23951 https://bugs.webkit.org/show_bug.cgi?id=190589
23953 Reviewed by Michael Catanzaro.
23955 * gtk/jhbuild.modules:
23957 2018-10-15 Patrick Griffis <pgriffis@igalia.com>
23959 [GTK] Add new sandboxing dependencies to install-dependencies
23960 https://bugs.webkit.org/show_bug.cgi?id=190588
23962 Reviewed by Michael Catanzaro.
23964 * gtk/install-dependencies:
23966 2018-10-15 Chris Dumez <cdumez@apple.com>
23968 Experiment: target=_blank on anchors should imply rel=noopener
23969 https://bugs.webkit.org/show_bug.cgi?id=190481
23971 Reviewed by Alex Christensen.
23973 Add API test coverage to make sure we can now swap process when target=_blank
23974 is specified on an anchor but rel=noopener is not.
23976 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
23978 2018-10-15 Wenson Hsieh <wenson_hsieh@apple.com>
23980 [iOS] Can't select text after dismissing the keyboard when changing focus
23981 https://bugs.webkit.org/show_bug.cgi?id=190563
23982 <rdar://problem/44613559>
23984 Reviewed by Tim Horton.
23986 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
23987 (WTR::UIScriptController::isShowingKeyboard const):
23989 Add a new UIScriptController method that returns whether the keyboard is shown. See `ui-helper.js` for more
23992 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
23993 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
23994 (WTR::UIScriptController::isShowingKeyboard const):
23995 * TestRunnerShared/UIScriptContext/UIScriptController.h:
23996 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
23997 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
23999 Also rename the `isShowingKeyboard` Objective-C property to the more canonical `showingKeyboard`, with
24000 `isShowingKeyboard` as the getter method.
24002 (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
24003 (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
24004 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
24005 (WTR::UIScriptController::isShowingKeyboard const):
24007 2018-10-15 Ryan Haddad <ryanhaddad@apple.com>
24009 Unreviewed, fix JSC tests after WebGPUShadingLanguageRI directory was removed in r237115.
24011 * Scripts/run-javascriptcore-tests:
24012 (runJSCStressTests): Remove wsl-tests.yaml.
24014 2018-10-15 Christopher Reid <chris.reid@sony.com>
24016 [Curl][WinCairo] Add Public Suffix support to WinCairo
24017 https://bugs.webkit.org/show_bug.cgi?id=183060
24019 Reviewed by Alex Christensen.
24021 Share mac's PublicSuffix tests with all ports.
24023 * TestWebKitAPI/PlatformWin.cmake:
24024 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24025 * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
24026 * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Removed.
24028 2018-10-15 Myles C. Maxfield <mmaxfield@apple.com>
24030 [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
24031 https://bugs.webkit.org/show_bug.cgi?id=190555
24035 Migrated to https://github.com/gpuweb/WHLSL/tree/master/Source
24037 * WebGPUShadingLanguageRI/AddressSpace.js: Removed.
24038 * WebGPUShadingLanguageRI/All.js: Removed.
24039 * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Removed.
24040 * WebGPUShadingLanguageRI/AnonymousVariable.js: Removed.
24041 * WebGPUShadingLanguageRI/ArrayRefType.js: Removed.
24042 * WebGPUShadingLanguageRI/ArrayType.js: Removed.
24043 * WebGPUShadingLanguageRI/Assignment.js: Removed.
24044 * WebGPUShadingLanguageRI/AutoWrapper.js: Removed.
24045 * WebGPUShadingLanguageRI/Block.js: Removed.
24046 * WebGPUShadingLanguageRI/BoolLiteral.js: Removed.
24047 * WebGPUShadingLanguageRI/Break.js: Removed.
24048 * WebGPUShadingLanguageRI/BuiltInSemantic.js: Removed.
24049 * WebGPUShadingLanguageRI/BuiltinMatrixGetter.js: Removed.
24050 * WebGPUShadingLanguageRI/BuiltinMatrixSetter.js: Removed.
24051 * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Removed.
24052 * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Removed.
24053 * WebGPUShadingLanguageRI/CallExpression.js: Removed.
24054 * WebGPUShadingLanguageRI/CallFunction.js: Removed.
24055 * WebGPUShadingLanguageRI/Casts.js: Removed.
24056 * WebGPUShadingLanguageRI/Check.js: Removed.
24057 * WebGPUShadingLanguageRI/CheckLiteralTypes.js: Removed.
24058 * WebGPUShadingLanguageRI/CheckLoops.js: Removed.
24059 * WebGPUShadingLanguageRI/CheckNativeFuncStages.js: Removed.
24060 * WebGPUShadingLanguageRI/CheckRecursion.js: Removed.
24061 * WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Removed.
24062 * WebGPUShadingLanguageRI/CheckReturns.js: Removed.
24063 * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Removed.
24064 * WebGPUShadingLanguageRI/CheckUnreachableCode.js: Removed.
24065 * WebGPUShadingLanguageRI/CheckWrapped.js: Removed.
24066 * WebGPUShadingLanguageRI/Checker.js: Removed.
24067 * WebGPUShadingLanguageRI/CloneProgram.js: Removed.
24068 * WebGPUShadingLanguageRI/CommaExpression.js: Removed.
24069 * WebGPUShadingLanguageRI/ConstexprFolder.js: Removed.
24070 * WebGPUShadingLanguageRI/Continue.js: Removed.
24071 * WebGPUShadingLanguageRI/ConvertPtrToArrayRefExpression.js: Removed.
24072 * WebGPUShadingLanguageRI/CreateLiteral.js: Removed.
24073 * WebGPUShadingLanguageRI/CreateLiteralType.js: Removed.
24074 * WebGPUShadingLanguageRI/DereferenceExpression.js: Removed.
24075 * WebGPUShadingLanguageRI/DoWhileLoop.js: Removed.
24076 * WebGPUShadingLanguageRI/DotExpression.js: Removed.
24077 * WebGPUShadingLanguageRI/EArrayRef.js: Removed.
24078 * WebGPUShadingLanguageRI/EBuffer.js: Removed.
24079 * WebGPUShadingLanguageRI/EBufferBuilder.js: Removed.
24080 * WebGPUShadingLanguageRI/EPtr.js: Removed.
24081 * WebGPUShadingLanguageRI/EnumLiteral.js: Removed.
24082 * WebGPUShadingLanguageRI/EnumMember.js: Removed.
24083 * WebGPUShadingLanguageRI/EnumType.js: Removed.
24084 * WebGPUShadingLanguageRI/EvaluationCommon.js: Removed.
24085 * WebGPUShadingLanguageRI/Evaluator.js: Removed.
24086 * WebGPUShadingLanguageRI/Expression.js: Removed.
24087 * WebGPUShadingLanguageRI/ExpressionFinder.js: Removed.
24088 * WebGPUShadingLanguageRI/ExternalOrigin.js: Removed.
24089 * WebGPUShadingLanguageRI/Field.js: Removed.
24090 * WebGPUShadingLanguageRI/FindHighZombies.js: Removed.
24091 * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Removed.
24092 * WebGPUShadingLanguageRI/FloatLiteral.js: Removed.
24093 * WebGPUShadingLanguageRI/FloatLiteralType.js: Removed.
24094 * WebGPUShadingLanguageRI/FoldConstexprs.js: Removed.
24095 * WebGPUShadingLanguageRI/ForLoop.js: Removed.
24096 * WebGPUShadingLanguageRI/Func.js: Removed.
24097 * WebGPUShadingLanguageRI/FuncAttribute.js: Removed.
24098 * WebGPUShadingLanguageRI/FuncDef.js: Removed.
24099 * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Removed.
24100 * WebGPUShadingLanguageRI/FuncParameter.js: Removed.
24101 * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Removed.
24102 * WebGPUShadingLanguageRI/HighZombieFinder.js: Removed.
24103 * WebGPUShadingLanguageRI/IdentityExpression.js: Removed.
24104 * WebGPUShadingLanguageRI/IfStatement.js: Removed.
24105 * WebGPUShadingLanguageRI/IndexExpression.js: Removed.
24106 * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed.
24107 * WebGPUShadingLanguageRI/Inline.js: Removed.
24108 * WebGPUShadingLanguageRI/Inliner.js: Removed.
24109 * WebGPUShadingLanguageRI/IntLiteral.js: Removed.
24110 * WebGPUShadingLanguageRI/IntLiteralType.js: Removed.
24111 * WebGPUShadingLanguageRI/Intrinsics.js: Removed.
24112 * WebGPUShadingLanguageRI/LayoutBuffers.js: Removed.
24113 * WebGPUShadingLanguageRI/Lexer.js: Removed.
24114 * WebGPUShadingLanguageRI/LexerToken.js: Removed.
24115 * WebGPUShadingLanguageRI/LiteralTypeChecker.js: Removed.
24116 * WebGPUShadingLanguageRI/LogicalExpression.js: Removed.
24117 * WebGPUShadingLanguageRI/LogicalNot.js: Removed.
24118 * WebGPUShadingLanguageRI/LoopChecker.js: Removed.
24119 * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Removed.
24120 * WebGPUShadingLanguageRI/MakePtrExpression.js: Removed.
24121 * WebGPUShadingLanguageRI/MatrixType.js: Removed.
24122 * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Removed.
24123 * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Removed.
24124 * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Removed.
24125 * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Removed.
24126 * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Removed.
24127 * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Removed.
24128 * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Removed.
24129 * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Removed.
24130 * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Removed.
24131 * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Removed.
24132 * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Removed.
24133 * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Removed.
24134 * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Removed.
24135 * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Removed.
24136 * WebGPUShadingLanguageRI/Metal/TypeOf.js: Removed.
24137 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Removed.
24138 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Removed.
24139 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Removed.
24140 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Removed.
24141 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Removed.
24142 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Removed.
24143 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Removed.
24144 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Removed.
24145 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Removed.
24146 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Removed.
24147 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Removed.
24148 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Removed.
24149 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Removed.
24150 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Removed.
24151 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Removed.
24152 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Removed.
24153 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Removed.
24154 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Removed.
24155 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Removed.
24156 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Removed.
24157 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Removed.
24158 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Removed.
24159 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Removed.
24160 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Removed.
24161 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Removed.
24162 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Removed.
24163 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Removed.
24164 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Removed.
24165 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Removed.
24166 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Removed.
24167 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Removed.
24168 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Removed.
24169 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Removed.
24170 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Removed.
24171 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Removed.
24172 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Removed.
24173 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Removed.
24174 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Removed.
24175 * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Removed.
24176 * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Removed.
24177 * WebGPUShadingLanguageRI/NameContext.js: Removed.
24178 * WebGPUShadingLanguageRI/NameFinder.js: Removed.
24179 * WebGPUShadingLanguageRI/NameResolver.js: Removed.
24180 * WebGPUShadingLanguageRI/NativeFunc.js: Removed.
24181 * WebGPUShadingLanguageRI/NativeType.js: Removed.
24182 * WebGPUShadingLanguageRI/Node.js: Removed.
24183 * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js: Removed.
24184 * WebGPUShadingLanguageRI/NullLiteral.js: Removed.
24185 * WebGPUShadingLanguageRI/NullType.js: Removed.
24186 * WebGPUShadingLanguageRI/OperatorAnderIndexer.js: Removed.
24187 * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Removed.
24188 * WebGPUShadingLanguageRI/OriginKind.js: Removed.
24189 * WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Removed.
24190 * WebGPUShadingLanguageRI/Parse.js: Removed.
24191 * WebGPUShadingLanguageRI/Prepare.js: Removed.
24192 * WebGPUShadingLanguageRI/Program.js: Removed.
24193 * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Removed.
24194 * WebGPUShadingLanguageRI/PropertyAccessExpression.js: Removed.
24195 * WebGPUShadingLanguageRI/PropertyResolver.js: Removed.
24196 * WebGPUShadingLanguageRI/PtrType.js: Removed.
24197 * WebGPUShadingLanguageRI/ReadModifyWriteExpression.js: Removed.
24198 * WebGPUShadingLanguageRI/RecursionChecker.js: Removed.
24199 * WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Removed.
24200 * WebGPUShadingLanguageRI/ReferenceType.js: Removed.
24201 * WebGPUShadingLanguageRI/ResolveNames.js: Removed.
24202 * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Removed.
24203 * WebGPUShadingLanguageRI/ResolveProperties.js: Removed.
24204 * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Removed.
24205 * WebGPUShadingLanguageRI/ResourceSemantic.js: Removed.
24206 * WebGPUShadingLanguageRI/Return.js: Removed.
24207 * WebGPUShadingLanguageRI/ReturnChecker.js: Removed.
24208 * WebGPUShadingLanguageRI/ReturnException.js: Removed.
24209 * WebGPUShadingLanguageRI/Rewriter.js: Removed.
24210 * WebGPUShadingLanguageRI/SPIR-V.js: Removed.
24211 * WebGPUShadingLanguageRI/SPIRV.html: Removed.
24212 * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed.
24213 * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Removed.
24214 * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Removed.
24215 * WebGPUShadingLanguageRI/Sampler.js: Removed.
24216 * WebGPUShadingLanguageRI/Semantic.js: Removed.
24217 * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Removed.
24218 * WebGPUShadingLanguageRI/StageInOutSemantic.js: Removed.
24219 * WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
24220 * WebGPUShadingLanguageRI/StatementCloner.js: Removed.
24221 * WebGPUShadingLanguageRI/StructLayoutBuilder.js: Removed.
24222 * WebGPUShadingLanguageRI/StructType.js: Removed.
24223 * WebGPUShadingLanguageRI/SwitchCase.js: Removed.
24224 * WebGPUShadingLanguageRI/SwitchStatement.js: Removed.
24225 * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Removed.
24226 * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Removed.
24227 * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Removed.
24228 * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Removed.
24229 * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Removed.
24230 * WebGPUShadingLanguageRI/TernaryExpression.js: Removed.
24231 * WebGPUShadingLanguageRI/Test.html: Removed.
24232 * WebGPUShadingLanguageRI/Test.js: Removed.
24233 * WebGPUShadingLanguageRI/Texture.js: Removed.
24234 * WebGPUShadingLanguageRI/TextureOperations.js: Removed.
24235 * WebGPUShadingLanguageRI/TrapStatement.js: Removed.
24236 * WebGPUShadingLanguageRI/Type.js: Removed.
24237 * WebGPUShadingLanguageRI/TypeDef.js: Removed.
24238 * WebGPUShadingLanguageRI/TypeDefResolver.js: Removed.
24239 * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Removed.
24240 * WebGPUShadingLanguageRI/TypeRef.js: Removed.
24241 * WebGPUShadingLanguageRI/TypedValue.js: Removed.
24242 * WebGPUShadingLanguageRI/UintLiteral.js: Removed.
24243 * WebGPUShadingLanguageRI/UintLiteralType.js: Removed.
24244 * WebGPUShadingLanguageRI/UnificationContext.js: Removed.
24245 * WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Removed.
24246 * WebGPUShadingLanguageRI/Value.js: Removed.
24247 * WebGPUShadingLanguageRI/VariableDecl.js: Removed.
24248 * WebGPUShadingLanguageRI/VariableRef.js: Removed.
24249 * WebGPUShadingLanguageRI/VectorType.js: Removed.
24250 * WebGPUShadingLanguageRI/VisitingSet.js: Removed.
24251 * WebGPUShadingLanguageRI/Visitor.js: Removed.
24252 * WebGPUShadingLanguageRI/WLexicalError.js: Removed.
24253 * WebGPUShadingLanguageRI/WSyntaxError.js: Removed.
24254 * WebGPUShadingLanguageRI/WTrapError.js: Removed.
24255 * WebGPUShadingLanguageRI/WTypeError.js: Removed.
24256 * WebGPUShadingLanguageRI/WhileLoop.js: Removed.
24257 * WebGPUShadingLanguageRI/WrapChecker.js: Removed.
24258 * WebGPUShadingLanguageRI/index.html: Removed.
24259 * WebGPUShadingLanguageRI/spirv.core.grammar.json: Removed.
24260 * WebGPUShadingLanguageRI/wsl-tests.yaml: Removed.
24262 2018-10-15 Philippe Normand <pnormand@igalia.com>
24264 [GTK] Disable MSE build support on Debian and Ubuntu LTS bots
24265 https://bugs.webkit.org/show_bug.cgi?id=190581
24267 Reviewed by Michael Catanzaro.
24269 These bots don't use JHBuild and their host GStreamer version is
24270 too old for the GStreamer MSE backend. Version 1.14 is needed at least.
24272 * BuildSlaveSupport/build.webkit.org-config/config.json:
24274 2018-10-15 Alex Christensen <achristensen@webkit.org>
24276 Use pragma once in WTF
24277 https://bugs.webkit.org/show_bug.cgi?id=190527
24279 Reviewed by Chris Dumez.
24281 Put WorkQueue in namespace DRT so it does not conflict with WTF::WorkQueue.
24283 * DumpRenderTree/TestRunner.cpp:
24284 (TestRunner::queueLoadHTMLString):
24285 (TestRunner::queueLoadAlternateHTMLString):
24286 (TestRunner::queueBackNavigation):
24287 (TestRunner::queueForwardNavigation):
24288 (TestRunner::queueLoadingScript):
24289 (TestRunner::queueNonLoadingScript):
24290 (TestRunner::queueReload):
24291 * DumpRenderTree/WorkQueue.cpp:
24292 (WorkQueue::singleton): Deleted.
24293 (WorkQueue::WorkQueue): Deleted.
24294 (WorkQueue::queue): Deleted.
24295 (WorkQueue::dequeue): Deleted.
24296 (WorkQueue::count): Deleted.
24297 (WorkQueue::clear): Deleted.
24298 (WorkQueue::processWork): Deleted.
24299 * DumpRenderTree/WorkQueue.h:
24300 (WorkQueue::setFrozen): Deleted.
24301 * DumpRenderTree/WorkQueueItem.h:
24302 * DumpRenderTree/mac/DumpRenderTree.mm:
24304 * DumpRenderTree/mac/FrameLoadDelegate.mm:
24305 (-[FrameLoadDelegate processWork:]):
24306 (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
24307 * DumpRenderTree/mac/TestRunnerMac.mm:
24308 (TestRunner::notifyDone):
24309 (TestRunner::forceImmediateCompletion):
24310 (TestRunner::queueLoad):
24311 * DumpRenderTree/win/DumpRenderTree.cpp:
24313 * DumpRenderTree/win/FrameLoadDelegate.cpp:
24314 (FrameLoadDelegate::processWork):
24315 (FrameLoadDelegate::locationChangeDone):
24316 * DumpRenderTree/win/TestRunnerWin.cpp:
24317 (TestRunner::notifyDone):
24318 (TestRunner::forceImmediateCompletion):
24319 (TestRunner::queueLoad):
24321 2018-10-14 Yusuke Suzuki <yusukesuzuki@slowstart.org>
24323 [JSC] Remove Option::useAsyncIterator
24324 https://bugs.webkit.org/show_bug.cgi?id=190567
24326 Reviewed by Saam Barati.
24328 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
24330 2018-10-15 Claudio Saavedra <csaavedra@igalia.com>
24332 [WPE] Silence a unused-parameter warning
24335 * MiniBrowser/wpe/main.cpp:
24336 (decidePermissionRequest):
24338 2018-10-12 Guillaume Emont <guijemont@igalia.com>
24340 [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
24341 https://bugs.webkit.org/show_bug.cgi?id=190537
24343 Reviewed by Alexey Proskuryakov.
24345 In DeprecatedPort.run_javascriptcore_tests_command() JSCTESTS_OPTIONS
24346 needs to be split before adding it to the command since it is treated
24349 * Scripts/webkitpy/common/config/ports.py:
24350 (DeprecatedPort.run_javascriptcore_tests_command):
24352 2018-10-12 Wenson Hsieh <wenson_hsieh@apple.com>
24354 [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view
24355 https://bugs.webkit.org/show_bug.cgi?id=190504
24356 <rdar://problem/45117760>
24358 Reviewed by Tim Horton.
24360 Teach UIScriptController to set WKWebView's view scale via a new `setViewScale` method, supported in WebKit2 on
24363 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
24364 (WTR::UIScriptController::setViewScale):
24365 * DumpRenderTree/mac/UIScriptControllerMac.mm:
24366 (WTR::UIScriptController::setViewScale):
24367 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
24368 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
24369 (WTR::UIScriptController::setViewScale):
24370 * TestRunnerShared/UIScriptContext/UIScriptController.h:
24371 * WebKitTestRunner/UIScriptControllerCocoa.mm: Added.
24373 Add a new file for UIScriptController methods on Cocoa platforms.
24375 (WTR::UIScriptController::setViewScale):
24376 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
24377 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
24378 (WTR::TestController::cocoaResetStateToConsistentValues):
24380 Ensure that _viewScale is reset to 1 after running a layout test.
24382 2018-10-12 Aakash Jain <aakash_jain@apple.com>
24384 [ews-build] Rename iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS
24385 https://bugs.webkit.org/show_bug.cgi?id=190536
24387 Reviewed by Alexey Proskuryakov.
24389 * BuildSlaveSupport/ews-build/config.json: Renamed iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS.
24391 2018-10-11 Youenn Fablet <youenn@apple.com>
24393 IOS 12 - Service worker cache not shared when added to homescreen
24394 https://bugs.webkit.org/show_bug.cgi?id=190269
24395 <rdar://problem/45009961>
24397 Reviewed by Alex Christensen.
24399 * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
24400 Add test to ensure that CacheStorage use the default website data store parameters.
24402 2018-10-11 Tim Horton <timothy_horton@apple.com>
24404 Clicking on bookmarklet crashes at NavigationState::willRecordNavigationSnapshot
24405 https://bugs.webkit.org/show_bug.cgi?id=190476
24406 <rdar://problem/32757191>
24408 Reviewed by Megan Gardner.
24410 * TestWebKitAPI/Tests/WebKitCocoa/SnapshotStore.mm:
24412 Add a test that we don't crash.
24414 2018-10-11 Tim Horton <timothy_horton@apple.com>
24416 REGRESSION (r237037): Cannot use webkit-patch upload, always fails with unknown 'cc_radar'
24418 * Scripts/webkitpy/tool/steps/options.py:
24420 Fix the name of the variable that the --cc-radar option writes into.
24422 2018-10-10 Dean Jackson <dino@apple.com>
24424 Add --cc-radar option to webkit-patch bug creation
24425 https://bugs.webkit.org/show_bug.cgi?id=190451
24426 <rdar://problem/45176671>
24428 Reviewed by Antoine Quint.
24430 Add a new command line option to automatically
24431 CC radar to new or updated bugs.
24433 * Scripts/webkitpy/tool/commands/commandtest.py:
24434 (CommandsTest.assert_execute_outputs):
24435 * Scripts/webkitpy/tool/commands/upload.py:
24436 (CreateBug.__init__):
24437 (CreateBug.execute):
24438 * Scripts/webkitpy/tool/commands/upload_unittest.py:
24439 (test_prepare_with_cc):
24440 (test_prepare_with_radar):
24441 (test_prepare_with_cc_and_radar):
24442 * Scripts/webkitpy/tool/steps/createbug.py:
24443 (CreateBug.options):
24445 * Scripts/webkitpy/tool/steps/options.py:
24448 2018-10-11 Claudio Saavedra <csaavedra@igalia.com>
24450 [GStreamer] Do not build gstgtk plugins
24451 https://bugs.webkit.org/show_bug.cgi?id=190463
24453 Reviewed by Xabier Rodriguez-Calvar.
24455 These plugins pull a GTK+ dependency that, at least in WPE,
24456 is unnecessary. The GTK+ port doesn't need it either, as far
24459 * gstreamer/jhbuild.modules: Disable gstgtk plugins
24461 2018-10-11 Alejandro G. Castro <alex@igalia.com>
24463 [GTK][WPE] Add mediaDevices.enumerateDevices support
24464 https://bugs.webkit.org/show_bug.cgi?id=185761
24466 Reviewed by Youenn Fablet.
24468 Added new API test for the mediaDevices.enumerateDevices:
24469 usermedia-enumeratedevices-permission-check. And a new API test
24470 for the WebsiteDataStore: testWebsiteDataDeviceIdHashSalt.
24472 * MiniBrowser/gtk/main.c:
24473 (gotWebsiteDataCallback): Added a new section to the about:data
24474 webpage to include the information about the hash salt.
24475 * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
24476 (testWebViewUserMediaEnumerateDevicesPermissionCheck): Added the
24477 new test checking the enumerateDevices API when permission is
24478 denied and when permission is allowed for the origin.
24479 (beforeAll): Defined the new test.
24480 * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
24481 (serverCallback): Register a new URI for the enumerateDevices.
24482 (testWebsiteDataConfiguration): Remove the hash salts from the
24484 (testWebsiteDataDeviceIdHashSalt): New test cheking the
24485 enumerateDevices API.
24486 (beforeAll): Added the new test testWebsiteDataDeviceIdHashSalt to
24487 the init structure.
24488 * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
24489 (WebViewTest::initializeWebView): Make sure the media-stream is
24490 activated in the webView.
24492 2018-10-10 Fujii Hironori <Hironori.Fujii@sony.com>
24494 Add WinCairo to the flakiness dashboard
24495 https://bugs.webkit.org/show_bug.cgi?id=188345
24497 Reviewed by Lucas Forschler.
24499 * TestResultServer/static-dashboards/builders.jsonp: Regenerated by generate_builders_json.py.
24500 * TestResultServer/static-dashboards/flakiness_dashboard.js: Added a new platform 'WINCAIRO'.
24502 2018-10-10 Dean Jackson <dino@apple.com>
24504 [WHSL -> MSL] Annotate semantics correctly in generated MSL
24505 https://bugs.webkit.org/show_bug.cgi?id=190452
24506 <rdar://problem/45178272>
24508 Reviewed by Myles Maxfield.
24510 Correctly label the appropriate semantics as [[position]]
24513 * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Identify position
24514 and color attributes. Also use the semantic's index rather than
24516 * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Use a <pre> for
24517 output, and only include the actual shader code.
24519 2018-10-10 Ross Kirsling <ross.kirsling@sony.com>
24521 build-webkit --inspector-frontend shouldn't have a nonzero exit code
24522 https://bugs.webkit.org/show_bug.cgi?id=190430
24524 Reviewed by Brian Burg.
24526 * Scripts/webkitdirs.pm:
24527 (argumentsForConfiguration):
24528 --inspector-frontend should only be popped off of argv by determineIsInspectorFrontend;
24529 it shouldn't be re-inserted as a CLI option by argumentsForConfiguration.
24531 2018-10-10 Tim Horton <timothy_horton@apple.com>
24533 Share more WKShareSheet code between macOS and iOS, and fix a few bugs
24534 https://bugs.webkit.org/show_bug.cgi?id=190420
24536 Reviewed by Simon Fraser.
24538 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
24539 (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
24540 (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
24541 * DumpRenderTree/mac/UIScriptControllerMac.mm:
24542 (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
24543 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
24544 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
24545 (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
24546 (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
24547 * TestRunnerShared/UIScriptContext/UIScriptController.h:
24548 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
24549 (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
24550 (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
24551 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
24552 (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
24553 Change the testing mechanism for the share sheet such that we up-front
24554 set that it should immediately return with a particular state, instead
24555 of programmatically dismissing the sheet.
24557 Otherwise, running the tests on macOS doesn't work, because we pop
24558 a context menu, which spins the runloop and prevents dismissal from
24561 2018-10-10 Yusuke Suzuki <yusukesuzuki@slowstart.org>
24563 [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
24564 https://bugs.webkit.org/show_bug.cgi?id=190429
24566 Reviewed by Saam Barati.
24568 * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
24569 (TestWebKitAPI::TEST_F):
24571 2018-10-10 Chris Dumez <cdumez@apple.com>
24573 Regression(PSON): Assertion hit under WebPageProxy::didNavigateWithNavigationData()
24574 https://bugs.webkit.org/show_bug.cgi?id=190418
24575 <rdar://problem/45059769>
24577 Reviewed by Geoffrey Garen.
24579 Add API test coverage.
24581 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
24583 2018-10-10 Guillaume Emont <guijemont@igalia.com>
24585 [JSCOnly Add an armv7 JSCOnly EWS that runs tests
24586 https://bugs.webkit.org/show_bug.cgi?id=190191
24588 Reviewed by Michael Catanzaro.
24590 * QueueStatusServer/config/queues.py:
24591 * Scripts/webkitpy/common/config/ews.json:
24592 * Scripts/webkitpy/common/config/ports.py:
24593 (DeprecatedPort.run_javascriptcore_tests_command):
24594 Add the possibility to pass arguments to run-javascriptcore-tests with
24595 the JSCTESTS_OPTIONS environment variable
24596 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
24600 2018-10-09 Guillaume Emont <guijemont@igalia.com>
24602 Allow run-javascriptcore-tests to distribute tests between devices
24603 https://bugs.webkit.org/show_bug.cgi?id=190190
24605 Reviewed by Michael Catanzaro.
24607 * Scripts/run-jsc-stress-tests:
24608 * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
24609 * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
24611 2018-10-09 Dean Jackson <dino@apple.com>
24613 Update WHLSL to Metal tester with semantics
24614 https://bugs.webkit.org/show_bug.cgi?id=190416
24615 <rdar://problem/45145139>
24617 Reviewed by Myles Maxfield.
24619 A few small changes to the WHLSL to Metal tools:
24620 - Make it compile by adding some missing JS files :)
24621 - Add semantics to the default shader
24622 - Add FIXMEs to the other shaders
24623 - Create an in-browser test for the WHLSLToMetal codepath
24624 - Fix typos in the semantics checker
24626 * WebGPUShadingLanguageRI/Checker.js:
24627 (Checker.prototype._checkSemantics.checkSemanticTypes):
24628 (Checker.prototype._checkSemantics.checkSemanticForShaderType):
24629 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:
24630 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl:
24631 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl:
24632 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl:
24633 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
24634 * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Added.
24636 2018-10-09 Jer Noble <jer.noble@apple.com>
24638 Crash when closing WKWebView during enter fullscreen animation
24639 https://bugs.webkit.org/show_bug.cgi?id=190412
24641 Reviewed by Brian Burg.
24643 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24644 * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm: Added.
24645 (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillEnterFullscreen:]):
24646 (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillExitFullscreen:]):
24647 (TestWebKitAPI::TEST):
24649 2018-10-09 Chris Dumez <cdumez@apple.com>
24651 Anchor target should be ignored on activation when the download attribute is set
24652 https://bugs.webkit.org/show_bug.cgi?id=190408
24654 Reviewed by Geoffrey Garen.
24656 Update WebKitTestRunner to block popups by default and add support for testRunner.setCanOpenWindows()
24657 for tests that need popups. This aligns WebKitTestRunner with DumpRenderTree and allows testing
24660 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
24661 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
24662 (WTR::TestRunner::setCanOpenWindows):
24663 * WebKitTestRunner/InjectedBundle/TestRunner.h:
24664 * WebKitTestRunner/TestController.cpp:
24665 (WTR::TestController::createOtherPage):
24666 * WebKitTestRunner/TestController.h:
24667 * WebKitTestRunner/TestInvocation.cpp:
24668 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
24669 * WebKitTestRunner/TestInvocation.h:
24671 2018-10-09 Jer Noble <jer.noble@apple.com>
24673 WebDriver: thrown ObjC exception under -[WKFullScreenWindowController windowDidFailToEnterFullScreen:] when session is terminated
24674 https://bugs.webkit.org/show_bug.cgi?id=190098
24675 <rdar://problem/42822671>
24677 Reviewed by Brian Burg.
24679 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24680 * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm: Added.
24681 (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidEnterFullscreen:]):
24682 (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidExitFullscreen:]):
24683 (TestWebKitAPI::TEST):
24685 2018-10-09 Jiewen Tan <jiewen_tan@apple.com>
24687 [WebAuthN] Import CTAP HID message and packet structure from Chromium
24688 https://bugs.webkit.org/show_bug.cgi?id=189289
24689 <rdar://problem/44120310>
24691 Reviewed by Brent Fulgham.
24693 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24694 * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp: Added.
24695 (TestWebKitAPI::TEST):
24697 2018-10-09 Chris Dumez <cdumez@apple.com>
24699 PSON: Doing a cross-site navigation via the URL bar does not swap process on iOS
24700 https://bugs.webkit.org/show_bug.cgi?id=190378
24701 <rdar://problem/45059466>
24703 Reviewed by Geoffrey Garen.
24705 Add API test coverage.
24707 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
24709 2018-10-09 Jer Noble <jer.noble@apple.com>
24711 ISOTrackEncryptionBox returns incorrect defaultKeyID
24712 https://bugs.webkit.org/show_bug.cgi?id=190368
24714 Reviewed by Eric Carlson.
24716 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24717 * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
24718 (TestWebKitAPI::TEST):
24720 2018-10-09 Philippe Normand <pnormand@igalia.com>
24722 [JHBuild] Update to GStreamer 1.14.4
24723 https://bugs.webkit.org/show_bug.cgi?id=190395
24725 Reviewed by Xabier Rodriguez-Calvar.
24727 * gstreamer/jhbuild.modules: Remove patches merged in 1.14.4 and bump version of GStreamer modules.
24728 * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Removed.
24729 * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Removed.
24730 * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Removed.
24731 * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Removed.
24733 2018-10-08 Wenson Hsieh <wenson_hsieh@apple.com>
24735 [macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12
24736 https://bugs.webkit.org/show_bug.cgi?id=190386
24738 Reviewed by Ryosuke Niwa.
24740 Unlike macOS 10.13 and 10.14, -[NSColor redColor] is not equivalent to a fully red color in sRGB on macOS 10.12.
24741 Fix the test by dragging and dropping an NSColor that is equivalent to rgb(255, 0, 0) on all relevant versions
24744 * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
24747 2018-10-08 Wenson Hsieh <wenson_hsieh@apple.com>
24749 [Cocoa] [WK2] Add support for text alignment and text lists in font attributes
24750 https://bugs.webkit.org/show_bug.cgi?id=190342
24751 <rdar://problem/44767118>
24753 Reviewed by Tim Horton.
24755 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24756 * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
24758 Add a new API test to check that the font attributes dictionary contains the correct NSParagraphStyles when
24759 moving the selection around text inside nested list elements.
24761 (TestWebKitAPI::checkParagraphStyles):
24763 Add a new helper to check an NSParagraphStyle against expected results.
24765 (TestWebKitAPI::webViewForTestingFontAttributes):
24767 Allow each test to pass in the name of the test page to load.
24769 (TestWebKitAPI::TEST):
24770 * TestWebKitAPI/Tests/WebKitCocoa/nested-lists.html: Added.
24772 Add a new test page that contains text enclosed in multiple levels of unordered and ordered lists.
24774 * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html:
24776 Remove `text-align: left` from one of these elements, to test for NSTextAlignmentNatural.
24778 2018-10-08 Justin Fan <justin_fan@apple.com>
24780 WebGPU: Rename old WebGPU prototype to WebMetal
24781 https://bugs.webkit.org/show_bug.cgi?id=190325
24782 <rdar://problem/44990443>
24784 Reviewed by Dean Jackson.
24786 Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
24788 * DumpRenderTree/mac/DumpRenderTree.mm:
24789 (enableExperimentalFeatures):
24790 (resetWebPreferencesToConsistentValues):
24791 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
24792 * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
24793 * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm:
24794 * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:
24795 * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
24796 * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
24797 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
24798 (WTR::InjectedBundle::beginTesting):
24799 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
24800 (WTR::TestRunner::setWebMetalEnabled):
24801 (WTR::TestRunner::setWebGPUEnabled): Deleted.
24802 * WebKitTestRunner/InjectedBundle/TestRunner.h:
24804 2018-10-08 Commit Queue <commit-queue@webkit.org>
24806 Unreviewed, rolling out r236941.
24807 https://bugs.webkit.org/show_bug.cgi?id=190374
24809 Causing API test failures in new test (Requested by jernoble
24812 Reverted changeset:
24814 "ISOTrackEncryptionBox returns incorrect defaultKeyID"
24815 https://bugs.webkit.org/show_bug.cgi?id=190368
24816 https://trac.webkit.org/changeset/236941
24818 2018-10-08 Aditya Keerthi <akeerthi@apple.com>
24820 Make <input type=color> a runtime enabled (on-by-default) feature
24821 https://bugs.webkit.org/show_bug.cgi?id=189162
24823 Reviewed by Wenson Hsieh and Tim Horton.
24825 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
24827 2018-10-08 Jer Noble <jer.noble@apple.com>
24829 ISOTrackEncryptionBox returns incorrect defaultKeyID
24830 https://bugs.webkit.org/show_bug.cgi?id=190368
24832 Reviewed by Eric Carlson.
24834 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24835 * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
24836 (TestWebKitAPI::TEST):
24838 2018-10-08 Alex Christensen <achristensen@webkit.org>
24840 Remove WKBundleFileHandleRef
24841 https://bugs.webkit.org/show_bug.cgi?id=190360
24843 Reviewed by Tim Horton.
24845 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24846 * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp: Removed.
24847 * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp: Removed.
24849 2018-10-08 Dan Bernstein <mitz@apple.com>
24851 Tools part of [Xcode] Update some build settings as recommended by Xcode 10
24852 https://bugs.webkit.org/show_bug.cgi?id=190250
24854 Reviewed by Anders Carlsson.
24856 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
24858 * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
24859 CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
24860 CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
24862 * DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning.
24864 * DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning
24865 around deprecated methods or categories on deprecated classes.
24866 * DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto.
24867 (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
24868 * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
24869 (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
24871 * MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
24872 CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
24873 CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
24875 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
24877 * MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning.
24878 * MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to
24879 address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning.
24881 * MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
24882 CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo),
24883 CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
24885 * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update
24886 LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase.
24888 * TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
24889 CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
24890 CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
24891 Made the WebKit headers be treated as system headers to avoid dealing with the fact that
24892 many C SPI headers trigger the strict prototypes warning.
24894 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
24896 * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
24897 (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
24898 (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
24899 (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
24900 (-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
24901 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
24902 (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
24903 (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
24904 * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
24905 (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
24906 * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
24907 (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
24908 (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
24909 * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
24910 (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
24911 (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
24912 (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
24913 * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
24914 (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
24915 * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
24916 (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
24917 * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
24918 (-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]):
24919 (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted.
24920 * TestWebKitAPI/mac/TestDraggingInfo.mm:
24921 (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
24923 In all of the above, suppressed the deprecated implementations warning where needed.
24925 * WebKitTestRunner/Configurations/Base.xcconfig: Enabled ENABLE_STRICT_OBJC_MSGSEND,
24926 CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_COMMA, CLANG_WARN_CONSTANT_CONVERSION,
24927 CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
24928 CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH,
24929 GCC_WARN_UNDECLARED_SELECTOR, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
24930 CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
24931 and GCC_NO_COMMON_BLOCKS.
24933 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
24935 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
24936 (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed
24937 the deprecated implementations warning.
24939 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
24940 (WTR::UIScriptController::replaceTextAtRange): Addressed an int-conversion warning.
24942 2018-10-07 Yacine Bandou <yacine.bandou@softathome.com>
24944 [GStreamer][EME][webm] Add the WebM encrypted content support in matroskademux
24945 https://bugs.webkit.org/show_bug.cgi?id=189238
24947 Reviewed by Xabier Rodriguez-Calvar.
24949 Modifications on GStreamer, tracked in GStreamer bugzilla:
24950 https://bugzilla.gnome.org/show_bug.cgi?id=797231
24951 https://bugzilla.gnome.org/show_bug.cgi?id=765275
24953 * gstreamer/jhbuild.modules: Add new patches.
24954 * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Added.
24955 * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Added.
24956 * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Added.
24957 * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Added.
24959 2018-10-06 Dan Bernstein <mitz@apple.com>
24961 [Xcode] Never build yasm with ASAN
24962 https://bugs.webkit.org/show_bug.cgi?id=190327
24964 Reviewed by Youenn Fablet.
24966 * asan/asan.xcconfig: Allow targets to opt out of building with ASAN by setting
24967 the WK_ASAN_DISALLOWED build setting to YES (or, actually, anything other than NO or unset).
24969 2018-10-05 Chris Dumez <cdumez@apple.com>
24971 Regression(r236862): Crash under DOMWindowExtension::willDetachGlobalObjectFromFrame()
24972 https://bugs.webkit.org/show_bug.cgi?id=190320
24973 <rdar://problem/45044814>
24975 Reviewed by Geoffrey Garen.
24977 Add API test coverage.
24979 * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
24980 (TestWebKitAPI::TEST):
24981 * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
24982 (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
24984 2018-10-03 Jer Noble <jer.noble@apple.com>
24986 Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
24987 https://bugs.webkit.org/show_bug.cgi?id=190266
24989 Reviewed by Eric Carlson.
24991 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24992 * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
24993 (TestWebKitAPI::TEST):
24995 2018-10-05 Ryan Haddad <ryanhaddad@apple.com>
24997 Unreviewed, rolling out r236866.
24999 Breaks internal builds.
25001 Reverted changeset:
25003 "Add support for reporting "display composited video frames"
25004 through the VideoPlaybackQuality object."
25005 https://bugs.webkit.org/show_bug.cgi?id=190266
25006 https://trac.webkit.org/changeset/236866
25008 2018-10-05 Carlos Eduardo Ramalho <cadubentzen@gmail.com>
25010 [WPE][JSC] Use Unified Sources for Platform-specific sources
25011 https://bugs.webkit.org/show_bug.cgi?id=190300
25013 Reviewed by Yusuke Suzuki.
25015 Currently the GTK port already used Unified Sources with the same source files.
25016 As WPE has conditional code using gmodule, we need to add GLIB_GMODULE_LIBRARIES
25017 to the list of libraries to link with.
25019 * TestWebKitAPI/PlatformWPE.cmake:
25021 2018-10-05 Zach Li <zachli@apple.com>
25023 Expose whether WKWebProcessPlugInNodeHandle is a select element to clients
25024 https://bugs.webkit.org/show_bug.cgi?id=190302
25025 <rdar://problem/45031469>
25027 Reviewed by Tim Horton.
25029 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25030 * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsSelectElement.mm: Added.
25031 (-[InjectedBundleNodeHandleIsSelectElement verifySelectElementForHTMLElementTag:document:jsContext:expectedResult:failedElementTags:]):
25032 (-[InjectedBundleNodeHandleIsSelectElement webProcessPlugIn:didCreateBrowserContextController:]):
25033 * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
25034 (-[InjectedBundleNodeHandleIsSelectElementDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
25037 2018-10-04 Wenson Hsieh <wenson_hsieh@apple.com>
25039 [iOS] [WK2] Expose some more editing SPI on WKWebView
25040 https://bugs.webkit.org/show_bug.cgi?id=190232
25041 <rdar://problem/44963368>
25043 Reviewed by Tim Horton.
25045 Adds new API tests to exercise the new SPIs.
25047 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25048 * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm: Added.
25049 (-[TestWKWebView querySelectorExists:]):
25050 (TestWebKitAPI::webViewForEditActionTesting):
25051 (TestWebKitAPI::TEST):
25052 * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
25053 (-[TestWKWebView collapseToStart]): Deleted.
25054 (-[TestWKWebView collapseToEnd]): Deleted.
25055 (-[TestWKWebView stylePropertyAtSelectionStart:]): Deleted.
25056 (-[TestWKWebView stylePropertyAtSelectionEnd:]): Deleted.
25057 * TestWebKitAPI/cocoa/TestWKWebView.h:
25058 * TestWebKitAPI/cocoa/TestWKWebView.mm:
25059 (-[TestWKWebView stylePropertyAtSelectionStart:]):
25060 (-[TestWKWebView stylePropertyAtSelectionEnd:]):
25061 (-[TestWKWebView collapseToStart]):
25062 (-[TestWKWebView collapseToEnd]):
25064 Pull some common testing helpers out of NSFontManager and into TestWKWebView.
25066 2018-10-04 Jer Noble <jer.noble@apple.com>
25068 Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
25069 https://bugs.webkit.org/show_bug.cgi?id=190266
25071 Reviewed by Eric Carlson.
25073 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25074 * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
25075 (TestWebKitAPI::TEST):
25077 2018-10-04 Wenson Hsieh <wenson_hsieh@apple.com>
25079 [Cocoa] Add SPI to expose typing attributes at the current selection on WKWebView
25080 https://bugs.webkit.org/show_bug.cgi?id=190119
25081 <rdar://problem/44767062>
25083 Reviewed by Tim Horton.
25085 Add a new API test that loads a document containing various rich text styles. This test moves the selection
25086 around the document and checks the last set of font attributes received via the new UI delegate hook.
25088 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25089 * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm: Added.
25090 (-[FontAttributesListener _webView:didChangeFontAttributes:]):
25091 (-[FontAttributesListener lastFontAttributes]):
25092 (-[TestWKWebView selectElementWithIdentifier:]):
25093 (-[TestWKWebView fontAttributesAfterNextPresentationUpdate]):
25094 (ColorExpectation::ColorExpectation):
25095 (ShadowExpectation::ShadowExpectation):
25099 (webViewForTestingFontAttributes):
25100 * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html: Added.
25102 2018-10-04 Alan Coon <alancoon@apple.com>
25104 Unreviewed, add self as contributor.
25106 * Scripts/webkitpy/common/config/contributors.json:
25108 2018-10-04 Wenson Hsieh <wenson_hsieh@apple.com>
25110 [macOS] Fix some font attribute conversion bugs in preparation for "Font > Styles…" support in WebKit2
25111 https://bugs.webkit.org/show_bug.cgi?id=190289
25112 <rdar://problem/45020806>
25114 Reviewed by Ryosuke Niwa.
25116 Add new API tests to exercise two corner cases when using NSFontOptions ("Font > Styles…") to change font
25117 attributes at the current selection.
25119 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25120 * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
25121 * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
25122 (webViewForFontManagerTesting):
25123 (TestWebKitAPI::TEST):
25124 * TestWebKitAPI/mac/TestFontOptions.h: Copied from Source/WebCore/editing/cocoa/FontAttributesCocoa.mm.
25125 * TestWebKitAPI/mac/TestFontOptions.mm: Added.
25127 Introduce TestFontOptions, which wraps the shared NSFontOptions and swizzles `-sharedFontOptions` to return a
25128 global instance of itself. TestFontOptions supports several testing helpers to add or remove font shadows,
25129 foreground colors, and background colors.
25131 (sharedFontOptionsForTesting):
25132 (+[TestFontOptions sharedInstance]):
25133 (-[TestFontOptions initWithFontOptions:]):
25134 (-[TestFontOptions selectedAttributes]):
25135 (-[TestFontOptions fontOptions]):
25136 (-[TestFontOptions shadowWidth]):
25137 (-[TestFontOptions setShadowWidth:]):
25138 (-[TestFontOptions shadowHeight]):
25139 (-[TestFontOptions setShadowHeight:]):
25140 (-[TestFontOptions setShadowBlurRadius:]):
25141 (-[TestFontOptions setHasShadow:]):
25142 (-[TestFontOptions foregroundColor]):
25143 (-[TestFontOptions setForegroundColor:]):
25144 (-[TestFontOptions backgroundColor]):
25145 (-[TestFontOptions setBackgroundColor:]):
25146 (-[TestFontOptions _dispatchFontAttributeChanges]):
25147 (-[TestFontOptions convertAttributes:]):
25148 (-[TestFontOptions setSelectedAttributes:isMultiple:]):
25149 (-[TestFontOptions forwardInvocation:]):
25151 2018-10-04 Jiewen Tan <jiewen_tan@apple.com>
25153 [WebAuthN] Move time out control from WebProcess to UIProcess
25154 https://bugs.webkit.org/show_bug.cgi?id=189642
25155 <rdar://problem/44476765>
25157 Reviewed by Chris Dumez.
25159 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
25160 (WTR::TestRunner::setWebAuthenticationMockConfiguration):
25162 2018-10-04 YUHAN WU <yuhan_wu@apple.com>
25164 Runtime flag and IDL for MediaRecorder
25165 https://bugs.webkit.org/show_bug.cgi?id=190018
25167 Reviewed by Youenn Fablet and Chris Dumez.
25169 * DumpRenderTree/mac/DumpRenderTree.mm:
25170 (enableExperimentalFeatures):
25172 2018-10-04 Basuke Suzuki <Basuke.Suzuki@sony.com>
25174 [LayoutTests][Win] Stop wpt server correctly.
25175 https://bugs.webkit.org/show_bug.cgi?id=190248
25177 Reviewed by Fujii Hironori.
25179 Use signal.CTRL_C_EVENT instead of signal.SIGINT for Windows.
25180 Also refactoring the detection of Windows and cygwin environment check.
25182 * Scripts/webkitpy/common/system/executive.py:
25183 (Executive.__init__): Check environment once.
25184 (Executive._should_close_fds):
25185 (Executive.kill_process):
25186 (Executive.check_running_pid):
25187 (Executive.running_pids):
25188 (Executive.interrupt): Use signal.CTRL_C_EVENT for Windows.
25189 (Executive.kill_all):
25190 (Executive._child_process_encoding):
25191 (Executive._should_encode_child_process_arguments):
25193 (Executive.run_in_parallel):
25195 2018-10-04 Michael Catanzaro <mcatanzaro@igalia.com>
25197 Convert tests to use navigation client
25198 https://bugs.webkit.org/show_bug.cgi?id=190153
25200 Reviewed by Alex Christensen.
25202 Convert these tests from PagePolicyClient and PageLoaderClient to PageNavigationClient.
25204 * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
25205 (TestWebKitAPI::decidePolicyForNavigationAction):
25206 (TestWebKitAPI::setPagePolicyClient):
25207 * TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:
25208 (TestWebKitAPI::didCommitNavigationCallback):
25209 (TestWebKitAPI::TEST):
25210 (TestWebKitAPI::didCommitLoadForFrame): Deleted.
25212 2018-10-03 Dan Bernstein <mitz@apple.com>
25214 [Cocoa] Let clients specify an NSFileWrapper subclassed to be used for _WKAttachment
25215 https://bugs.webkit.org/show_bug.cgi?id=190270
25217 Reviewed by Wenson Hsieh.
25219 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
25220 (TestWebKitAPI::TEST):
25222 2018-10-03 Ryosuke Niwa <rniwa@webkit.org>
25224 Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
25225 https://bugs.webkit.org/show_bug.cgi?id=190238
25227 Reviewed by Antti Koivisto.
25229 * DumpRenderTree/TestOptions.h:
25230 * DumpRenderTree/mac/DumpRenderTree.mm:
25231 (resetWebPreferencesToConsistentValues):
25233 2018-10-02 Wenson Hsieh <wenson_hsieh@apple.com>
25235 [WebKit2] Format > Bold and Format > Italic don't toggle between bold and italic style
25236 https://bugs.webkit.org/show_bug.cgi?id=179787
25237 <rdar://problem/35593389>
25239 Reviewed by Tim Horton.
25241 Add a test to verify that NSFontManager's selected font is updated when applying italic and bold styles using
25244 * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
25245 (webViewForFontManagerTesting):
25246 (menuItemCellForFontAction):
25247 (TestWebKitAPI::TEST):
25249 2018-10-02 Chris Dumez <cdumez@apple.com>
25251 REGRESSION: TestWebKitAPI.WKWebView.ProvisionalURLNotChange API test is failing
25252 https://bugs.webkit.org/show_bug.cgi?id=190176
25253 <rdar://problem/44925871>
25255 Reviewed by Alex Christensen.
25257 Use a URL that is truly recognized as invalid by WebCore's URL parser.
25259 * TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm:
25262 2018-10-02 Alex Christensen <achristensen@webkit.org>
25264 Remove ParsedURLString
25265 https://bugs.webkit.org/show_bug.cgi?id=190154
25267 Reviewed by Chris Dumez.
25269 * TestWebKitAPI/Tests/WebCore/URL.cpp:
25270 (TestWebKitAPI::TEST_F):
25271 * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
25272 (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
25273 (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
25274 (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
25275 (TestWebKitAPI::TEST):
25277 2018-10-02 Daniel Bates <dabates@apple.com>
25279 Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
25280 (https://bugs.webkit.org/show_bug.cgi?id=190017)
25282 For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
25283 WKWebViewAutofillTests.AutofillRequiresInputSession
25284 DragAndDropTests.ExternalSourceJPEGOnly
25285 DragAndDropTests.ExternalSourceUTF8PlainTextOnly
25287 so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
25288 we will look to swizzle this method for all test by default.
25290 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
25291 (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
25292 (TestWebKitAPI::TEST):
25293 * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
25294 (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
25295 (TestWebKitAPI::TEST):
25296 * TestWebKitAPI/ios/UIKitSPI.h:
25298 2018-10-02 Dawei Fenton <realdawei@apple.com>
25300 Unreviewed, rolling out r236751.
25302 broke the iOS Build
25304 Reverted changeset:
25306 "Fix iOS TestWebKitAPI failures following
25307 <https://trac.webkit.org/changeset/236619>"
25308 https://bugs.webkit.org/show_bug.cgi?id=190017
25309 https://trac.webkit.org/changeset/236751
25311 2018-10-02 Daniel Bates <dabates@apple.com>
25313 Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
25314 (https://bugs.webkit.org/show_bug.cgi?id=190017)
25316 For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
25317 WKWebViewAutofillTests.AutofillRequiresInputSession
25318 DragAndDropTests.ExternalSourceJPEGOnly
25319 DragAndDropTests.ExternalSourceUTF8PlainTextOnly
25321 so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
25322 we will look to swizzle this method for all test by default.
25324 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
25325 (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
25326 (TestWebKitAPI::TEST):
25327 * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
25328 (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
25329 (TestWebKitAPI::TEST):
25330 * TestWebKitAPI/ios/UIKitSPI.h:
25332 2018-10-01 Dean Jackson <dino@apple.com>
25334 Remove CSS Animation Triggers
25335 https://bugs.webkit.org/show_bug.cgi?id=190175
25336 <rdar://problem/44925626>
25338 Reviewed by Simon Fraser.
25340 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
25342 2018-10-02 Thibault Saunier <tsaunier@igalia.com>
25344 [Flatpak] Use our own check of flatpak repos
25345 https://bugs.webkit.org/show_bug.cgi?id=190194
25347 Allowing us to not mess up with user installation
25348 and "--assumeyes" everywhere.
25350 Reviewed by Michael Catanzaro.
25352 * flatpak/flatpakutils.py:
25353 (FlatpakPackage.__init__):
25354 (FlatpakPackage.install):
25355 (FlatpakPackage.update):
25356 (WebkitFlatpak.load_from_args):
25357 (WebkitFlatpak.__init__):
25358 (WebkitFlatpak.clean_args):
25360 2018-10-02 Wenson Hsieh <wenson_hsieh@apple.com>
25362 [macOS] Implement a way for the UI process to request typing attributes at the current selection
25363 https://bugs.webkit.org/show_bug.cgi?id=189983
25364 <rdar://problem/44648705>
25366 Reviewed by Ryosuke Niwa.
25368 Adds new FontManagerTests that exercise -typingAttributesWithCompletionHandler:. See below for more detail.
25370 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25371 * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
25372 * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
25374 Add a new test that exercises font attribute modification via inspector bar. Also, add a new test that checks
25375 typing attributes when using subscript/superscript/unscript. Lastly, augment an existing NSFontPanel test to
25376 additionally check that shadowed text and strike-through are reflected in typing attributes.
25378 (-[FontManagerTestWKWebView inspectorBarItemIdentifiers]):
25379 (-[TestWKWebView typingAttributes]):
25381 Add a synchronous wrapper around `-typingAttributesWithCompletionHandler:` by spinning the runloop.
25383 (-[TestWKWebView collapseToStart]):
25384 (webViewForFontManagerTesting):
25385 (TestWebKitAPI::TEST):
25386 * TestWebKitAPI/cocoa/TestWKWebView.h:
25387 * TestWebKitAPI/mac/TestInspectorBar.h: Copied from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h.
25388 * TestWebKitAPI/mac/TestInspectorBar.mm: Added.
25390 Introduce subclasses of `__InspectorBarItemController` and `NSInspectorBar` for testing inspector bar interaction.
25392 (-[TestInspectorBarItemController initWithInspectorBar:]):
25393 (-[TestInspectorBarItemController inspectorBar]):
25394 (-[TestInspectorBarItemController updateSelectedAttributes]):
25395 (-[TestInspectorBar initWithWebView:]):
25396 (+[TestInspectorBar standardItemControllerClass]):
25397 (+[TestInspectorBar standardTextItemIdentifiers]):
25398 (-[TestInspectorBar _setStyleControlSelected:atIndex:]):
25399 (-[TestInspectorBar chooseFontSize:]):
25400 (-[TestInspectorBar chooseFontFamily:]):
25401 (-[TestInspectorBar _chooseColor:inColorWell:]):
25402 (-[TestInspectorBar chooseForegroundColor:]):
25403 (-[TestInspectorBar chooseBackgroundColor:]):
25404 (-[TestInspectorBar formatBold:]):
25405 (-[TestInspectorBar formatItalic:]):
25406 (-[TestInspectorBar formatUnderline:]):
25408 Add helper methods to TestInspectorBar to simulate interacting with various controls (e.g. color wells and font
25411 (-[TestInspectorBar itemController]):
25412 (-[TestInspectorBar setItemController:]):
25414 2018-10-02 Thibault Saunier <tsaunier@igalia.com>
25416 [Flatpak] Implement icecream and ccache support
25417 https://bugs.webkit.org/show_bug.cgi?id=190146
25419 Reviewed by Alejandro G. Castro.
25421 * flatpak/flatpakutils.py:
25422 (WebkitFlatpak.load_from_args):
25423 (WebkitFlatpak.__init__):
25424 (WebkitFlatpak.clean_args):
25425 (WebkitFlatpak.run_in_sandbox):
25426 (WebkitFlatpak.save_config):
25428 (WebkitFlatpak.setup_ccache):
25429 (WebkitFlatpak.setup_icecc):
25430 (WebkitFlatpak.setup_dev_env):
25431 * flatpak/org.webkit.WebKit.yaml:
25433 2018-10-02 Michael Catanzaro <mcatanzaro@igalia.com>
25435 Unreviewed, fix missing return value in TestController::keyExistsInKeychain
25437 * WebKitTestRunner/TestController.cpp:
25438 (WTR::TestController::keyExistsInKeychain):
25440 2018-10-02 Basuke Suzuki <Basuke.Suzuki@sony.com>
25442 [WinCairo] Enable WPT tests environment.
25443 https://bugs.webkit.org/show_bug.cgi?id=190128
25445 Reviewed by Youenn Fablet.
25447 Escaping backslash of the path not to confuse the JSON parser.
25449 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
25450 (WebPlatformTestServer._prepare_config):
25452 2018-10-01 Ross Kirsling <ross.kirsling@sony.com>
25454 [Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
25455 https://bugs.webkit.org/show_bug.cgi?id=190150
25457 Reviewed by Fujii Hironori.
25459 * DumpRenderTree/win/DumpRenderTree.cpp:
25460 (setWebPreferencesForTestOptions):
25461 DRT has been recognizing this field, but not propagating its value to WebPreferences.
25463 2018-10-01 Alex Christensen <achristensen@webkit.org>
25465 Unreviewed, rolling out r236551.
25467 Fails URL validating too aggressively
25469 Reverted changeset:
25471 "URLWithUserTypedString should return nil for URLs deemed to
25472 be invalid by WebCore::URL"
25473 https://bugs.webkit.org/show_bug.cgi?id=189979
25474 https://trac.webkit.org/changeset/236551
25476 2018-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
25478 [iOS] Add SPI to customize the input accessory view when focusing an element
25479 https://bugs.webkit.org/show_bug.cgi?id=190152
25480 <rdar://problem/42754975>
25482 Reviewed by Dan Bernstein.
25484 Add an API test to verify that setting a custom input accessory view and custom input view on the form input
25485 session when focusing an element overrides the first responder's (i.e. WKContentView's) `-inputView` and
25486 `-inputAccessoryView`.
25488 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
25489 (webViewWithAutofocusedInput):
25490 (TestWebKitAPI::TEST):
25491 * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
25492 * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
25493 (-[TestInputDelegate setWillStartInputSessionHandler:]):
25494 (-[TestInputDelegate willStartInputSessionHandler]):
25495 (-[TestInputDelegate _webView:willStartInputSession:]):
25497 2018-10-01 Sihui Liu <sihui_liu@apple.com>
25499 Remove StorageProcess
25500 https://bugs.webkit.org/show_bug.cgi?id=189975
25502 Reviewed by Geoffrey Garen.
25504 * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
25506 * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
25507 * TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:
25509 * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
25511 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
25512 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
25513 (WTR::TestRunner::terminateStorageProcess): Deleted.
25514 * WebKitTestRunner/InjectedBundle/TestRunner.h:
25515 * WebKitTestRunner/TestController.cpp:
25516 (WTR::TestController::generatePageConfiguration):
25517 (WTR::TestController::databaseProcessName): Deleted.
25518 (WTR::TestController::databaseProcessDidCrash): Deleted.
25519 (WTR::TestController::terminateStorageProcess): Deleted.
25520 * WebKitTestRunner/TestController.h:
25521 * WebKitTestRunner/TestInvocation.cpp:
25522 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
25524 2018-10-01 Jiewen Tan <jiewen_tan@apple.com>
25526 [WebAuthN] Import a JS CBOR coder
25527 https://bugs.webkit.org/show_bug.cgi?id=189877
25528 <rdar://problem/44701124>
25530 Reviewed by Chris Dumez.
25532 Add logic to only process privateKeyBase64, userCertificateBase64 and intermediateCACertificateBase64
25533 only if acceptAttestation is true.
25535 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
25536 (WTR::TestRunner::setWebAuthenticationMockConfiguration):
25538 2018-10-01 Chris Dumez <cdumez@apple.com>
25540 Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
25541 https://bugs.webkit.org/show_bug.cgi?id=190052
25543 Reviewed by Ryosuke Niwa.
25545 The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
25546 to log those events. It also uses console.log() before sending those events to indicate what the test is about
25547 to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
25548 so that it can log the message.
25549 The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
25550 sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
25551 handler to be transformed into synchronous IPC.
25552 As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
25553 Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
25554 messages may end up being out of order, leading to flakiness.
25556 To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicated
25557 that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
25558 result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
25560 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
25561 (WTR::InjectedBundle::outputText):
25563 2018-10-01 Daniel Bates <dabates@apple.com>
25565 [iOS] Special keys are misidentified in DOM keyboard events
25566 https://bugs.webkit.org/show_bug.cgi?id=189974
25568 Reviewed by Wenson Hsieh.
25570 Add support for testing keys Forward Delete and Num Lock / Clear.
25572 * WebKitTestRunner/ios/HIDEventGenerator.mm:
25573 (hidUsageCodeForCharacter):
25575 2018-10-01 Alex Christensen <achristensen@webkit.org>
25577 URL should not use TextEncoding internally
25578 https://bugs.webkit.org/show_bug.cgi?id=190111
25580 Reviewed by Andy Estes.
25582 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
25583 (TestWebKitAPI::testUserPass):
25584 (TestWebKitAPI::TEST_F):
25586 2018-10-01 Daniel Bates <dabates@apple.com>
25588 LLDB tests may use wrong configuration of lldbWebKitTester
25589 https://bugs.webkit.org/show_bug.cgi?id=189011
25591 Reviewed by Dean Jackson.
25593 Fixes an issue where the LLDB unit tests may use the wrong configuration of lldbWebKitTester.
25594 Additionally, add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
25596 Currently the unit tests pick the LLDBWebKitTester binary based on the configuration set by
25597 script set-webkit-configuration. This may not be the same configuration specified to test-webkitpy.
25598 So, the unit tests may use the wrong binary. Instead we have test-webkitpy store the path
25599 to the correct lldbWebKitTester binary that the unit tests should use in an environment variable,
25600 called LLDB_WEBKIT_TESTER_EXECUTABLE. (We use an environment variable because the test driver,
25601 test-webkitpy, and the unit tests cannot talk to each other directly due the limitations of
25602 the Python unittest module, the Python multiprocessing module, and the general principle of unit
25603 tests - to test code in isolation). The unit tests make use of the value of this environment
25604 variable to launch lldbWebKitTester binary.
25606 * Scripts/build-lldbwebkittester: We only support building lldbWebKitTester on Mac for now. Error
25607 out if this script is invoked for a non-Mac platform.
25608 * Scripts/webkitpy/test/main.py:
25609 (Tester._run_tests): Build lldbWebKitTester and store the path to it in the environment variable
25610 LLDB_WEBKIT_TESTER_EXECUTABLE.
25611 (_build_lldb_webkit_tester): Deleted.
25612 * lldb/dump_class_layout_unittest.py:
25613 (TestDumpClassLayout.shouldSkip): Use SystemHost() here and remove the _host global variable as
25614 this is the only call site that needs the Host object now.
25615 (TestDumpClassLayout.setUpClass): Take the path to the lldbWebKitTester binary from the value of
25616 the environment variable LLDB_WEBKIT_TESTER_EXECUTABLE.
25617 * lldb/lldbWebKitTester/main.cpp:
25618 (testSummaryProviders): Add back unit test support infrastructure originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
25619 * lldb/lldb_webkit_unittest.py:
25620 (LLDBDebugSession.setup): Take the path to the lldbWebKitTester binary from the value of the environment
25621 variable LLDB_WEBKIT_TESTER_EXECUTABLE.
25622 (TestSummaryProviders):
25623 (TestSummaryProviders.shouldSkip): Skip the tests on non-Mac platforms.
25624 (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
25625 (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty):
25626 (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple):
25627 (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty):
25628 (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
25629 Add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
25631 2018-10-01 Olivier Blin <olivier.blin@softathome.com>
25633 [WPE] Update install-dependencies
25634 https://bugs.webkit.org/show_bug.cgi?id=190127
25636 Reviewed by Michael Catanzaro.
25638 * wpe/install-dependencies:
25639 libxrandr-dev is needed for gstreamer-vaapi in jhbuild
25640 It is used by gstvaapidisplay_x11.c.
25641 Add it only for Apt, already ok for Pacman and DNF.
25643 Install libevent-dev for WebRTC (like GTK)
25645 Install libasound2-dev for WebRTC.
25646 Add it only for Apt, already ok for Pacam and DNF.
25648 Install libgbm-dev for HeadlessViewBackend, which uses gbm.h
25650 2018-10-01 Thibault Saunier <tsaunier@igalia.com>
25652 [Flatpak] Add libunwind in the sandbox
25653 https://bugs.webkit.org/show_bug.cgi?id=190123
25655 Allowing us to get proper traces in GStreamer trace grabing
25658 Reviewed by Philippe Normand.
25660 * flatpak/org.webkit.WebKit.yaml:
25662 2018-09-29 Commit Queue <commit-queue@webkit.org>
25664 Unreviewed, rolling out r236631.
25665 https://bugs.webkit.org/show_bug.cgi?id=190112
25667 Caused various eventSender tests, including fast/css/pseudo-
25668 active-style-sharing*, to fail (Requested by smfr on #webkit).
25670 Reverted changeset:
25672 "Regression(r236512): http/tests/navigation/keyboard-events-
25673 during-provisional-navigation.html is flaky"
25674 https://bugs.webkit.org/show_bug.cgi?id=190052
25675 https://trac.webkit.org/changeset/236631
25677 2018-09-28 Myles C. Maxfield <mmaxfield@apple.com>
25679 [WHLSL] Fix build after r236635
25680 https://bugs.webkit.org/show_bug.cgi?id=189210
25684 * WebGPUShadingLanguageRI/Intrinsics.js:
25686 * WebGPUShadingLanguageRI/Test.js:
25687 (tests.atomicsNull):
25688 (tests.numThreads):
25689 (tests.textureDimensionsNull):
25691 2018-09-28 Myles C. Maxfield <mmaxfield@apple.com>
25693 [WHLSL] Allow uniform buffers to be used in the interpreter
25694 https://bugs.webkit.org/show_bug.cgi?id=189210
25696 Reviewed by Filip Pizlo.
25698 Every lvalue is associated with an address space, and the propagation of these address spaces
25699 matches the propagation of lvalues. Luckily, there was already the infrastructure to do most
25700 of this, so this patch just goes the last few yards. It also updates the standard library to
25701 allow for writing into all writable address spaces for out-params.
25703 * WebGPUShadingLanguageRI/Checker.js:
25704 (Checker.prototype.visitAssignment):
25705 (Checker.prototype._finishVisitingPropertyAccess):
25706 * WebGPUShadingLanguageRI/Intrinsics.js:
25708 (Intrinsics.checkFalse):
25710 * WebGPUShadingLanguageRI/StandardLibrary.js:
25711 (let.standardLibrary):
25712 * WebGPUShadingLanguageRI/Test.js:
25713 (tests.threadArrayRefLoad):
25714 (tests.threadArrayRefLoadIntLiteral):
25715 (tests.deviceArrayRefLoad):
25716 (tests.threadArrayRefStore):
25717 (tests.deviceArrayRefStore):
25718 (tests.deviceArrayRefStoreIntLiteral):
25719 (tests.threadPointerLoad):
25720 (tests.threadPointerStore):
25721 (tests.devicePointerLoad):
25722 (tests.devicePointerStore):
25724 (tests.constantAddressSpace):
25725 (tests.standardLibraryDevicePointers):
25726 (tests.threadArrayLoad): Deleted.
25727 (tests.threadArrayLoadIntLiteral): Deleted.
25728 (tests.deviceArrayLoad): Deleted.
25729 (tests.threadArrayStore): Deleted.
25730 (tests.deviceArrayStore): Deleted.
25731 (tests.deviceArrayStoreIntLiteral): Deleted.
25733 2018-09-28 Wenson Hsieh <wenson_hsieh@apple.com>
25735 No DOM API to instantiate an attachment for an img element
25736 https://bugs.webkit.org/show_bug.cgi?id=189934
25737 <rdar://problem/44743222>
25739 Reviewed by Ryosuke Niwa.
25741 Adds 3 new API tests in WKAttachmentTests:
25743 `AddAttachmentToConnectedImageElement` verifies that an image element that's already in the document can gain an
25744 attachment element via `HTMLAttachmentElement.getAttachmentIdentifier`.
25746 `ChangeFileWrapperForPastedImage` verifies that an image that has been pasted produces a _WKAttachment in the UI
25747 process, and changing the file wrapper of that _WKAttachment changes the pasted image.
25749 `ConnectImageWithAttachmentToDocument` verifies that script can create an image element, ensure that it has an
25750 attachment, and set a file wrapper for the generated _WKAttachment. Connecting the image to the document should
25751 then result in an image element with the contents of the _WKAttachment's file wrapper.
25753 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
25754 (-[TestWKWebView imageElementSize]):
25755 (-[TestWKWebView waitForImageElementSizeToBecome:]):
25756 (TestWebKitAPI::TEST):
25757 (-[TestWKWebView waitForAttachmentElementSizeToBecome:]): Deleted.
25759 2018-09-28 Chris Dumez <cdumez@apple.com>
25761 Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
25762 https://bugs.webkit.org/show_bug.cgi?id=190052
25764 Reviewed by Ryosuke Niwa.
25766 The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
25767 to log those events. It also uses console.log() before sending those events to indicate what the test is about
25768 to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
25769 so that it can log the message.
25770 The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
25771 sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
25772 handler to be transformed into synchronous IPC.
25773 As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
25774 Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
25775 messages may end up being out of order, leading to flakiness.
25777 To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicating
25778 that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
25779 result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
25781 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
25782 (WTR::InjectedBundle::outputText):
25784 2018-09-28 Myles C. Maxfield <mmaxfield@apple.com>
25786 [WHLSL] Pointers should have automatically-generated equality checks
25787 https://bugs.webkit.org/show_bug.cgi?id=189986
25789 Reviewed by Filip Pizlo.
25791 C allows for pointer equality, and we need it so people can do null checks.
25792 This is generated the same way all our other NativeFuncs are generated - by Checker
25793 creating NativeFuncs inside CallExpression.resolve().
25795 This patch also does some general cleanup.
25797 * WebGPUShadingLanguageRI/All.js: Everything the late checker does is no longer necessary.
25798 The last thing it was doing was making sure that only primitive types are in resources, but
25799 it's totally reasonable to put structs and arrays in resources, so I removed this pass. We
25800 still have to add a check to make sure resources can't live within resources, but I expect
25801 that will be done in the same place that semantics are checked.
25802 * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js:
25803 (allocateAtEntryPoints.updateFunction.UpdateFunctions.prototype._addVariableDeclaration):
25804 Name the global struct for debugging purposes.
25805 * WebGPUShadingLanguageRI/CallExpression.js:
25806 (CallExpression.prototype._resolveByInstantiation): Cleanup
25807 (CallExpression.prototype._resolveWithOperatorAnderIndexer): Ditto
25808 (CallExpression.prototype._resolveWithOperatorLength): Ditto
25809 (CallExpression.prototype._resolveWithReferenceComparator): Add support to automatically
25810 generate pointer equality NativeFuncs.
25811 * WebGPUShadingLanguageRI/EPtr.js: Implement pointer equality in the interpreter.
25812 * WebGPUShadingLanguageRI/LateChecker.js: Removed.
25813 * WebGPUShadingLanguageRI/LayoutBuffers.js: Renamed from Tools/WebGPUShadingLanguageRI/LateCheckAndLayoutBuffers.js.
25815 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
25816 * WebGPUShadingLanguageRI/NativeFunc.js:
25817 * WebGPUShadingLanguageRI/OperatorArrayRefLength.js:
25818 (OperatorArrayRefLength.prototype.instantiateImplementation):
25819 (OperatorArrayRefLength):
25820 * WebGPUShadingLanguageRI/Prepare.js:
25822 * WebGPUShadingLanguageRI/SPIRV.html:
25823 * WebGPUShadingLanguageRI/Test.html:
25824 * WebGPUShadingLanguageRI/Test.js:
25825 (tests.ternaryExpression):
25826 (tests.break): Speed up testing time
25827 (tests.doWhile): Ditto
25828 (tests.forLoop): Ditto
25829 (tests.atomics): Ditto
25830 (tests.atomicsNull): Ditto
25831 (tests.pointerEquality): Test pointer equality
25832 (tests.standardLibraryDevicePointers):
25833 (tests.devicePtrPtr): Deleted.
25834 (tests.threadgroupPtrPtr): Deleted.
25835 (tests.constantPtrPtr): Deleted.
25836 * WebGPUShadingLanguageRI/index.html:
25838 2018-09-28 Jiewen Tan <jiewen_tan@apple.com>
25840 [WebAuthN] Polish WebAuthN auto-test environment
25841 https://bugs.webkit.org/show_bug.cgi?id=189283
25842 <rdar://problem/44117828>
25844 Reviewed by Chris Dumez.
25846 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
25847 (WTR::TestRunner::setWebAuthenticationMockConfiguration):
25849 2018-09-28 Chris Dumez <cdumez@apple.com>
25851 Drop support for cross-origin-window-policy header
25852 https://bugs.webkit.org/show_bug.cgi?id=190081
25854 Reviewed by Ryosuke Niwa.
25856 190081_DropCrossOriginWindowPolicy
25858 * DumpRenderTree/mac/DumpRenderTree.mm:
25859 (enableExperimentalFeatures):
25860 * DumpRenderTree/win/DumpRenderTree.cpp:
25861 (enableExperimentalFeatures):
25862 * WebKitTestRunner/TestController.cpp:
25863 (WTR::TestController::resetPreferencesToConsistentValues):
25865 2018-09-28 Koby Boyango <koby.b@mce.systems>
25867 [WTF] Add ExternalStringImpl, a StringImpl for user controlled buffers
25868 https://bugs.webkit.org/show_bug.cgi?id=189991
25870 Reviewed by Yusuke Suzuki.
25872 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
25874 2018-09-27 Ryan Haddad <ryanhaddad@apple.com>
25876 Update flakiness dashboard configuration for Mojave queues
25877 https://bugs.webkit.org/show_bug.cgi?id=190068
25879 Reviewed by Alexey Proskuryakov.
25881 * TestResultServer/static-dashboards/builders.jsonp:
25883 2018-09-27 Ryan Haddad <ryanhaddad@apple.com>
25885 Bring up queues for Mojave
25886 https://bugs.webkit.org/show_bug.cgi?id=189935
25888 Unreviewed infrastructure fix.
25890 * BuildSlaveSupport/build.webkit.org-config/config.json: Remove trigger, update bot assignment.
25892 2018-09-24 Ryan Haddad <ryanhaddad@apple.com>
25894 Bring up queues for Mojave
25895 https://bugs.webkit.org/show_bug.cgi?id=189935
25897 Reviewed by Alexey Proskuryakov.
25899 * BuildSlaveSupport/build.webkit.org-config/config.json:
25900 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
25902 * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
25904 2018-09-27 Ryan Haddad <ryanhaddad@apple.com>
25906 Increase the timeout for iOS Simulator data migration
25907 https://bugs.webkit.org/show_bug.cgi?id=190059
25909 Reviewed by Aakash Jain.
25911 3 minutes isn't always enough time for the data migrator to complete
25912 when booting up multiple iOS Simulators. Change the timeout to 10 minutes.
25914 * Scripts/webkitpy/xcode/simulated_device.py:
25915 (SimulatedDeviceManager): Create a constant for the default timeout.
25916 (SimulatedDeviceManager.initialize_devices): Use new constant.
25917 (SimulatedDeviceManager.swap): Ditto.
25918 (SimulatedDeviceManager.wait_until_data_migration_is_done): Ditto.
25920 2018-09-27 Alex Christensen <achristensen@webkit.org>
25922 URLParser should use TextEncoding through an abstract class
25923 https://bugs.webkit.org/show_bug.cgi?id=190027
25925 Reviewed by Andy Estes.
25927 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
25928 (TestWebKitAPI::checkURL):
25929 (TestWebKitAPI::TEST_F):
25931 2018-09-27 Ryan Haddad <ryanhaddad@apple.com>
25933 iOS Simulator bots should pass '--dedicated-simulators' to run-webkit-tests
25934 https://bugs.webkit.org/show_bug.cgi?id=190042
25936 Reviewed by Aakash Jain.
25938 To make iOS Simulator bots resilient to issues that can arise from reusing
25939 existing simulators, ensure that dedicated simulators are created for each test run.
25941 * Scripts/webkitpy/common/config/ports.py:
25942 (IOSSimulatorWK2Port.run_webkit_tests_command):
25944 2018-09-27 Alex Christensen <achristensen@webkit.org>
25946 URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
25947 https://bugs.webkit.org/show_bug.cgi?id=189979
25949 Reviewed by Youenn Fablet.
25951 * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
25952 (TestWebKitAPI::originalDataAsString):
25953 (TestWebKitAPI::TEST):
25955 2018-09-27 Basuke Suzuki <Basuke.Suzuki@sony.com>
25957 [Win][WebKit] Implement authentication dialog on MiniBrowser.
25958 https://bugs.webkit.org/show_bug.cgi?id=189846
25960 Reviewed by Fujii Hironori.
25962 It was implemented for WebKitLegacy, but not for WebKit.
25963 Also added text field to display Realm information.
25965 * MiniBrowser/win/Common.cpp:
25968 (displayAuthDialog): Deleted.
25969 * MiniBrowser/win/Common.h:
25970 * MiniBrowser/win/MiniBrowserLib.rc:
25971 * MiniBrowser/win/MiniBrowserLibResource.h:
25972 * MiniBrowser/win/ResourceLoadDelegate.cpp:
25973 (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
25974 * MiniBrowser/win/WebKitBrowserWindow.cpp:
25976 (createUTF8String):
25979 (WebKitBrowserWindow::WebKitBrowserWindow):
25980 (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
25981 (toNullTerminatedUTF8): Deleted.
25982 * MiniBrowser/win/WebKitBrowserWindow.h:
25984 2018-09-27 Youenn Fablet <youenn@apple.com>
25986 Enable getUserMedia in mini browser
25987 https://bugs.webkit.org/show_bug.cgi?id=190012
25989 Reviewed by Eric Carlson.
25991 Enable MediaDevices and mock capture devices.
25992 Grant mock devices access to any getUserMedia call.
25993 Covered by manual testing.
25995 * MiniBrowser/mac/AppDelegate.m:
25996 (defaultConfiguration):
25997 * MiniBrowser/mac/WK2BrowserWindowController.m:
25998 (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
25999 (-[WK2BrowserWindowController _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
26001 2018-09-27 Antoine Quint <graouts@apple.com>
26003 [Web Animations] Turn Web Animations with CSS integration on
26004 https://bugs.webkit.org/show_bug.cgi?id=184819
26005 <rdar://problem/39597337>
26007 Reviewed by Dean Jackson.
26009 * DumpRenderTree/TestOptions.h:
26011 2018-09-26 Alex Christensen <achristensen@webkit.org>
26013 Unreviewed, rolling out r236524.
26017 Reverted changeset:
26019 "URLWithUserTypedString should return nil for URLs deemed to
26020 be invalid by WebCore::URL"
26021 https://bugs.webkit.org/show_bug.cgi?id=189979
26022 https://trac.webkit.org/changeset/236524
26024 2018-09-26 James Savage <james.savage@apple.com>
26026 Allow override of viewport configuration.
26027 https://bugs.webkit.org/show_bug.cgi?id=188772.
26028 <rdar://problem/43538892>.
26030 Reviewed by Simon Fraser.
26032 * WebKitTestRunner/TestController.cpp:
26033 (WTR::updateTestOptionsFromTestHeader): Parse new test option key from comments.
26034 * WebKitTestRunner/TestOptions.h:
26035 * WebKitTestRunner/ios/TestControllerIOS.mm:
26036 (WTR::TestController::platformConfigureViewForTest): Handle new test option by
26037 modifying the web view's preferences accordingly.
26039 2018-09-26 Alex Christensen <achristensen@webkit.org>
26041 URLs with mismatched surrogate pairs in the host should fail to parse
26042 https://bugs.webkit.org/show_bug.cgi?id=190005
26044 Reviewed by Chris Dumez.
26046 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
26047 (TestWebKitAPI::TEST_F):
26049 2018-09-26 Alex Christensen <achristensen@webkit.org>
26051 URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
26052 https://bugs.webkit.org/show_bug.cgi?id=189979
26053 <rdar://problem/44119696>
26055 Reviewed by Chris Dumez.
26057 * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
26058 (TestWebKitAPI::TEST):
26060 2018-09-26 Ryosuke Niwa <rniwa@webkit.org>
26062 Selection should work across shadow boundary when initiated by a mouse drag
26063 https://bugs.webkit.org/show_bug.cgi?id=151380
26064 <rdar://problem/24363872>
26066 Reviewed by Wenson Hsieh.
26068 Added the support for internal:selectionAcrossShadowBoundariesEnabled test option.
26070 * DumpRenderTree/TestOptions.cpp:
26071 (TestOptions::TestOptions):
26072 * DumpRenderTree/TestOptions.h:
26073 * DumpRenderTree/mac/DumpRenderTree.mm:
26074 (resetWebPreferencesToConsistentValues):
26075 (setWebPreferencesForTestOptions):
26077 2018-09-26 Ryosuke Niwa <rniwa@webkit.org>
26079 MiniBrowser doesn't respect default enabled-ness of experimental and internal debug features
26080 https://bugs.webkit.org/show_bug.cgi?id=189989
26082 Reviewed by Simon Fraser.
26084 When the preference isn't found in user defaults, use the default value of each feature's enabledness.
26086 * MiniBrowser/mac/AppDelegate.m:
26087 (defaultConfiguration):
26089 2018-09-26 Philippe Normand <pnormand@igalia.com>
26091 [Flatpak] Bump to apr 1.6.5
26093 Version 1.6.3 is no longer available on Apache's website.
26095 Rubber-stamped by Michael Catanzaro.
26097 * flatpak/org.webkit.WebKit.yaml:
26099 2018-09-25 Jiewen Tan <jiewen_tan@apple.com>
26101 [WebAuthN] Make AuthenticatorManager
26102 https://bugs.webkit.org/show_bug.cgi?id=189279
26103 <rdar://problem/44116792>
26105 Reviewed by Chris Dumez.
26107 Besides the functionality to set the WebAuthenticationMockConfiguration. Three operations are
26108 added to manipulate Keychain: addTestKeyToKeychain, cleanUpKeychain and keyExistedInKeychain.
26110 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
26111 * TestWebKitAPI/Tests/ios/LocalAuthenticator.mm: Removed.
26112 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
26113 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
26114 (WTR::TestRunner::setWebAuthenticationMockConfiguration):
26115 (WTR::TestRunner::addTestKeyToKeychain):
26116 (WTR::TestRunner::cleanUpKeychain):
26117 (WTR::TestRunner::isKeyExisted):
26118 * WebKitTestRunner/InjectedBundle/TestRunner.h:
26119 * WebKitTestRunner/TestController.cpp:
26120 (WTR::TestController::addTestKeyToKeychain):
26121 (WTR::TestController::cleanUpKeychain):
26122 (WTR::TestController::isKeyExisted):
26123 (WTR::TestController::setWebAuthenticationMockConfiguration):
26124 * WebKitTestRunner/TestController.h:
26125 * WebKitTestRunner/TestInvocation.cpp:
26126 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
26127 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
26128 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
26129 (WTR::TestController::addTestKeyToKeychain):
26130 (WTR::TestController::cleanUpKeychain):
26131 (WTR::TestController::keyExistedInKeychain):
26133 2018-09-25 Sihui Liu <sihui_liu@apple.com>
26135 Move Service Worker Management from Storage Process to Network Process
26136 https://bugs.webkit.org/show_bug.cgi?id=189422
26138 Reviewed by Youenn Fablet.
26140 Change a check in ServiceWorkers.HasServiceWorkerRegistrationBit as storage process is not
26141 launched during service worker operations now.
26143 * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
26145 2018-09-25 Eric Carlson <eric.carlson@apple.com>
26147 [MediaStream] Update constraints supported by getDisplayMedia
26148 https://bugs.webkit.org/show_bug.cgi?id=189930
26149 <rdar://problem/44740305>
26151 Unreviewed, fix test broken by r236465.
26153 * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
26154 (TestWebKitAPI::TEST_F):
26156 2018-09-25 Myles C. Maxfield <mmaxfield@apple.com>
26158 [WHSL] Implement semantics
26159 https://bugs.webkit.org/show_bug.cgi?id=189134
26161 Reviewed by Filip Pizlo.
26163 This patch adds parsing support and adds the checks required to support HLSL-style semantics.
26165 There are 3 places where semantics are allowed:
26167 1. In a field in a struct. E.g.
26170 float4 position : SV_Position;
26176 2. In a parameter of a function. If the function is not an entry point, the semantic is ignored.
26178 compute void foo(device float[] data : buffer(u0)) {
26182 3. On a function. This is so you don't have to create structs for the return types of simple vertex shaders.
26184 vertex float4 foo() : SV_Position {
26188 The semantics are partitioned into 4 types:
26190 1. Built-in variables. For example, : SV_Position.
26191 2. Resources. For example, : register(u0).
26192 3. Stage-in / stage-out variables. For example, : attribute(0).
26193 4. Specialization constants. For example, : specialized.
26195 The semantics are validated according to a collection of rules:
26197 - The same entry point can't list the same semantic twice
26198 - Each built-in type has an appropriate type that is listed in the spec.
26199 - Each built-in is appropriate as either an input or an output of a particular shader stage
26200 - Resource semantics have to have the appropriate type (e.g. can't use register(s0) on a buffer)
26201 - Resources can't be output from entry points
26202 - The resource semantic mode must match the address space of the resource
26203 - Stage-in and stage-out variables have to be POD
26204 - Specialization constants can't be output from entry points, and have to be numbers
26206 * WebGPUShadingLanguageRI/All.js:
26207 * WebGPUShadingLanguageRI/BuiltInSemantic.js: Added.
26209 (BuiltInSemantic.prototype.get name):
26210 (BuiltInSemantic.prototype.get extraArguments):
26211 (BuiltInSemantic.prototype.isAcceptableType):
26212 (BuiltInSemantic.prototype.isAcceptableForShaderType):
26213 (BuiltInSemantic.prototype.toString):
26214 * WebGPUShadingLanguageRI/CallExpression.js:
26215 (CallExpression.prototype._resolveWithOperatorAnderIndexer):
26216 (CallExpression.prototype._resolveWithOperatorLength):
26217 * WebGPUShadingLanguageRI/Checker.js:
26219 (Checker.prototype.visitProgram):
26220 (Checker.prototype._checkSemantics.Item):
26221 (Checker.prototype._checkSemantics.Item.prototype.get type):
26222 (Checker.prototype._checkSemantics.Item.prototype.get semantic):
26223 (Checker.prototype._checkSemantics.Gatherer):
26224 (Checker.prototype._checkSemantics.Gatherer.prototype.reset):
26225 (Checker.prototype._checkSemantics.Gatherer.prototype.set currentSemantic):
26226 (Checker.prototype._checkSemantics.Gatherer.prototype.get currentSemantic):
26227 (Checker.prototype._checkSemantics.Gatherer.prototype.get result):
26228 (Checker.prototype._checkSemantics.Gatherer.prototype.visitEnumType):
26229 (Checker.prototype._checkSemantics.Gatherer.prototype.visitVectorType):
26230 (Checker.prototype._checkSemantics.Gatherer.prototype.visitMatrixType):
26231 (Checker.prototype._checkSemantics.Gatherer.prototype.visitNativeType):
26232 (Checker.prototype._checkSemantics.Gatherer.prototype.visitStructType):
26233 (Checker.prototype._checkSemantics.Gatherer.prototype.visitTypeRef):
26234 (Checker.prototype._checkSemantics.Gatherer.prototype.visitPtrType):
26235 (Checker.prototype._checkSemantics.Gatherer.prototype.visitArrayRefType):
26236 (Checker.prototype._checkSemantics.Gatherer.prototype.visitArrayType):
26237 (Checker.prototype._checkSemantics.Gatherer.prototype.visitFuncParameter):
26238 (Checker.prototype._checkSemantics.checkDuplicateSemantics):
26239 (Checker.prototype._checkSemantics.checkSemanticTypes):
26240 (Checker.prototype._checkSemantics.checkSemanticForShaderType):
26241 (Checker.prototype._checkSemantics.PODChecker.prototype.visitEnumType):
26242 (Checker.prototype._checkSemantics.PODChecker.prototype.visitArrayType):
26243 (Checker.prototype._checkSemantics.PODChecker.prototype.visitVectorType):
26244 (Checker.prototype._checkSemantics.PODChecker.prototype.visitMatrixType):
26245 (Checker.prototype._checkSemantics.PODChecker.prototype.visitNativeType):
26246 (Checker.prototype._checkSemantics.PODChecker.prototype.visitPtrType):
26247 (Checker.prototype._checkSemantics.PODChecker.prototype.visitArrayRefType):
26248 (Checker.prototype._checkSemantics.PODChecker.prototype.visitStructType):
26249 (Checker.prototype._checkSemantics.PODChecker.prototype.visitTypeRef):
26250 (Checker.prototype._checkSemantics.PODChecker):
26251 (Checker.prototype._checkSemantics.checkPODData):
26252 (Checker.prototype._checkSemantics):
26253 (Checker.prototype._checkShaderType):
26254 (Checker.prototype._checkOperatorOverload):
26255 (Checker.prototype.visitFuncDef):
26256 (Checker.prototype.visitEnumType):
26257 (Checker.prototype.visitArrayType):
26258 (Checker.prototype.visitMakePtrExpression):
26259 (Checker.prototype.visitMakeArrayRefExpression):
26260 (Checker.prototype._finishVisitingPropertyAccess):
26261 (Checker.prototype.visitIndexExpression):
26262 (Checker.prototype.visitReturn):
26263 (Checker.prototype.visitSwitchStatement):
26264 (Checker.prototype.visitTernaryExpression):
26265 (Checker.prototype.visitCallExpression):
26266 * WebGPUShadingLanguageRI/Field.js:
26268 (Field.prototype.get semantic):
26269 (Field.prototype.toString):
26270 * WebGPUShadingLanguageRI/Func.js:
26272 (Func.prototype.get semantic):
26273 (Func.prototype.toDeclString):
26274 * WebGPUShadingLanguageRI/FuncDef.js:
26276 * WebGPUShadingLanguageRI/FuncParameter.js:
26278 (FuncParameter.prototype.get semantic):
26279 (FuncParameter.prototype.toString):
26280 * WebGPUShadingLanguageRI/Intrinsics.js:
26281 * WebGPUShadingLanguageRI/LateChecker.js:
26282 (LateChecker.prototype.visitReferenceType):
26284 (LateChecker.prototype._checkShaderType): Deleted.
26285 (LateChecker.prototype.visitFuncDef): Deleted.
26286 * WebGPUShadingLanguageRI/NativeFunc.js:
26288 * WebGPUShadingLanguageRI/Parse.js:
26292 (parseStageInOutSemantic):
26293 (parseResourceSemantic):
26294 (parseSpecializationConstantSemantic):
26295 (parseBuiltInSemantic):
26298 * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js:
26299 (programWithUnnecessaryThingsRemoved):
26300 * WebGPUShadingLanguageRI/ResourceSemantic.js: Added.
26301 (ResourceSemantic):
26302 (ResourceSemantic.prototype.get resourceMode):
26303 (ResourceSemantic.prototype.get index):
26304 (ResourceSemantic.prototype.get space):
26305 (ResourceSemantic.prototype.isAcceptableType):
26306 (ResourceSemantic.prototype.isAcceptableForShaderType):
26307 (ResourceSemantic.prototype.toString):
26308 * WebGPUShadingLanguageRI/Rewriter.js:
26309 (Rewriter.prototype.visitFuncParameter):
26310 (Rewriter.prototype.visitField):
26311 (Rewriter.prototype.visitBuiltInSemantic):
26312 (Rewriter.prototype.visitResourceSemantic):
26313 (Rewriter.prototype.visitStageInOutSemantic):
26314 (Rewriter.prototype.visitSpecializationConstantSemantic):
26316 * WebGPUShadingLanguageRI/SPIRV.html:
26317 * WebGPUShadingLanguageRI/Semantic.js: Added.
26319 (Semantic.prototype.get origin):
26320 (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitBuiltInSemantic):
26321 (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitResourceSemantic):
26322 (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitStageInOutSemantic):
26323 (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitSpecializationConstantSemantic):
26324 (Semantic.prototype.equalToOtherSemantic.Comparer):
26325 (Semantic.prototype.equalToOtherSemantic):
26326 * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Copied from Tools/WebGPUShadingLanguageRI/Field.js.
26327 (SpecializationConstantSemantic):
26328 (SpecializationConstantSemantic.prototype.isAcceptableType):
26329 (SpecializationConstantSemantic.prototype.isAcceptableForShaderType):
26330 (SpecializationConstantSemantic.prototype.toString):
26331 * WebGPUShadingLanguageRI/StageInOutSemantic.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
26332 (StageInOutSemantic):
26333 (StageInOutSemantic.prototype.get index):
26334 (StageInOutSemantic.prototype.isAcceptableType):
26335 (StageInOutSemantic.prototype.isAcceptableForShaderType):
26336 (StageInOutSemantic.prototype.toString):
26337 * WebGPUShadingLanguageRI/StatementCloner.js:
26338 (StatementCloner.prototype.visitNativeFunc):
26339 * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js:
26340 (synthesizeArrayOperatorLength):
26341 * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js:
26342 (synthesizeCopyConstructorOperator):
26343 * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js:
26344 (synthesizeDefaultConstructorOperator):
26345 * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js:
26346 (synthesizeEnumFunctions):
26347 * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
26349 (synthesizeStructAccessorsForStructType):
26350 * WebGPUShadingLanguageRI/Test.html:
26351 * WebGPUShadingLanguageRI/Test.js:
26352 (tests.shaderTypes):
26353 * WebGPUShadingLanguageRI/Visitor.js:
26354 (Visitor.prototype.visitFunc):
26355 (Visitor.prototype.visitFuncParameter):
26356 (Visitor.prototype.visitField):
26357 (Visitor.prototype.visitBuiltInSemantic):
26358 (Visitor.prototype.visitResourceSemantic):
26359 (Visitor.prototype.visitStageInOutSemantic):
26360 (Visitor.prototype.visitSpecializationConstantSemantic):
26362 * WebGPUShadingLanguageRI/index.html:
26364 2018-09-25 Thomas Denney <tdenney@apple.com>
26366 [WHLSL] Test suite for Metal code generation
26367 https://bugs.webkit.org/show_bug.cgi?id=187738
26369 Reviewed by Myles C. Maxfield.
26371 This patch adds an Xcode project that contains a Cocoa app that can be
26372 used for running WHLSL shaders on the GPU. It also contains an Xcode
26373 test suite that runs all of the tests in Test.js on the GPU.
26375 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Added.
26376 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Added.
26377 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Added.
26378 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
26379 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Added.
26380 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Added.
26381 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Added.
26382 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Added.
26383 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Added.
26384 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Added.
26385 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Added.
26386 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Added.
26387 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Added.
26388 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Added.
26389 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Added.
26390 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Added.
26391 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Added.
26392 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Added.
26393 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Added.
26394 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Added.
26395 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Added.
26396 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Added.
26397 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Added.
26398 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Added.
26399 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Added.
26400 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Added.
26401 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Added.
26402 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Added.
26403 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Added.
26404 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Added.
26405 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Added.
26406 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Added.
26407 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Added.
26408 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Added.
26409 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Added.
26410 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Added.
26411 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Added.
26412 * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Added.
26413 * WebGPUShadingLanguageRI/Test.js:
26414 (tests.lotsOfLocalVariables):
26416 2018-09-25 Myles C. Maxfield <mmaxfield@apple.com>
26418 Unreviewed build fix after r236455
26419 https://bugs.webkit.org/show_bug.cgi?id=189121
26421 * WebGPUShadingLanguageRI/Test.js:
26422 (tests.shaderStages):
26424 2018-09-24 Myles C. Maxfield <mmaxfield@apple.com>
26426 [WHLSL] Not all functions should be able to run in all shader stages
26427 https://bugs.webkit.org/show_bug.cgi?id=189121
26429 Reviewed by Filip Pizlo.
26431 ddx() and ddy() can only run in fragment shaders, and the barrier functions can only run in compute shaders.
26432 ddx_coarse() & friends are currently implemented as just calling ddx(), so we only need to modify those functions
26433 if/when we make them native.
26435 The texture sampling functions that use implicit derivatives can run in any shader stage - they just use a LOD of
26436 0. Therefore, those functions are unchanged.
26438 * WebGPUShadingLanguageRI/All.js:
26439 * WebGPUShadingLanguageRI/Intrinsics.js:
26440 * WebGPUShadingLanguageRI/LateChecker.js:
26441 (LateChecker.prototype._checkShaderType):
26442 * WebGPUShadingLanguageRI/NativeFunc.js:
26444 (NativeFunc.prototype.get stage):
26445 (NativeFunc.prototype.toDeclString):
26446 * WebGPUShadingLanguageRI/Parse.js:
26450 * WebGPUShadingLanguageRI/Prepare.js:
26452 * WebGPUShadingLanguageRI/SPIRV.html:
26453 * WebGPUShadingLanguageRI/StandardLibrary.js:
26454 (let.standardLibrary):
26455 * WebGPUShadingLanguageRI/StatementCloner.js:
26456 (StatementCloner.prototype.visitNativeFunc):
26457 * WebGPUShadingLanguageRI/Test.html:
26458 * WebGPUShadingLanguageRI/Test.js:
26459 (tests.shaderStages):
26460 * WebGPUShadingLanguageRI/WSyntaxError.js:
26461 (WSyntaxError.prototype.toString):
26463 * WebGPUShadingLanguageRI/index.html:
26465 2018-09-24 Thomas Denney <tdenney@apple.com>
26467 [WHLSL] Implement trap statements in Metal code generation
26468 https://bugs.webkit.org/show_bug.cgi?id=189615
26470 Reviewed by Myles C. Maxfield.
26472 Each function called by an entry point now receives an additional
26473 boolean pointer parameter, which is set to false if the function traps.
26474 After each function call (to a non-native function) this trap parameter
26475 is checked. The behavior of the interpreter has also been updated so
26476 that a function entry point catches the trap and instead returns zero,
26477 matching the behavior of compiled code.
26479 * WebGPUShadingLanguageRI/Evaluator.js: Adds a new flag to allow the
26480 test suite to check for traps and also returns zero from entry points
26481 whose invocation trapped.
26482 * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Pass program to function
26484 * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Update dependencies.
26485 * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Add program
26487 * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Ditto.
26488 * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Added.
26489 * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Conforms to the
26490 new trapping behavior.
26491 * WebGPUShadingLanguageRI/Test.js: Update tests that trap.
26493 2018-09-24 Thomas Denney <tdenney@apple.com>
26495 [WHLSL] It shouldn’t be possible to use ternary expressions as l-values
26496 https://bugs.webkit.org/show_bug.cgi?id=189290
26498 Reviewed by Myles C. Maxfield.
26500 It is no longer possible for a ternary expression to be treated as an
26501 l-value. This patch adds several test cases to verify that this is the
26504 * WebGPUShadingLanguageRI/Checker.js:
26505 (Checker.prototype.visitTernaryExpression): No longer check isLValue.
26506 * WebGPUShadingLanguageRI/NormalUsePropertyResolver:
26507 (NormalUsePropertyResolver.visitTernaryExpression): Deleted.
26508 * WebGPUShadingLanguageRI/Rewriter.js:
26509 (Rewriter.prototype.visitTernaryExpression): No longer copy isLValue.
26510 * WebGPUShadingLanguageRI/TernaryExpression.js:
26511 (TernaryExpression):
26512 (TernaryExpression.prototype.get elseExpression):
26513 (TernaryExpression.prototype.get isLValue): Deleted.
26514 (TernaryExpression.prototype.set isLValue): Deleted.
26515 * WebGPUShadingLanguageRI/Test.js:
26516 (tests.ternaryExpression): Add checks for failure if a failure is used
26518 (ternaryExpressionIsLValue.node.TernaryExpressionVisitor.prototype.visitTernaryExpression): Deleted.
26519 (ternaryExpressionIsLValue.node.TernaryExpressionVisitor): Deleted.
26520 (tests.ternaryExpressionIsLValue): Deleted.
26522 2018-09-24 Jer Noble <jer.noble@apple.com>
26524 SharedBuffer should have an equality test
26525 https://bugs.webkit.org/show_bug.cgi?id=189919
26527 Reviewed by Alex Christensen.
26529 * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
26530 (TestWebKitAPI::TEST_F):
26532 2018-09-24 Alex Christensen <achristensen@webkit.org>
26534 Prepare to replace WKBundleFileHandleCreateWithPath with a version that takes a WKBundlePageRef
26535 https://bugs.webkit.org/show_bug.cgi?id=189929
26537 Reviewed by Andy Estes.
26539 * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp:
26541 2018-09-24 Thomas Denney <tdenney@apple.com>
26543 [WHLSL] Casting user-created types to themselves should always work
26544 https://bugs.webkit.org/show_bug.cgi?id=189113
26546 Reviewed by Myles C. Maxfield.
26548 Casting user-defined types to themselves worked already, but we didn't
26551 * WebGPUShadingLanguageRI/Test.js:
26554 2018-09-24 Zan Dobersek <zdobersek@igalia.com>
26556 Unreviewed build fix for Jhbuild-using ports.
26558 * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch:
26559 Adjust the patch so it applies cleanly on the 1.14.3 version of the
26560 gst-plugins-good package.
26562 2018-09-24 Ryan Haddad <ryanhaddad@apple.com>
26564 Update flakiness dashboard configuration for iOS 12 queues
26565 https://bugs.webkit.org/show_bug.cgi?id=189688
26567 Reviewed by Alexey Proskuryakov.
26569 * TestResultServer/static-dashboards/builders.jsonp:
26571 2018-09-24 Alicia Boya García <aboya@igalia.com>
26573 [GStreamer] Unreviewed build fix.
26575 A GStreamer patch was not applying cleanly on 1.14.3.
26577 * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch:
26579 2018-09-24 Alicia Boya García <aboya@igalia.com>
26581 [MSE][GStreamer] Use no-more-pads event for noticing initialization segments
26582 https://bugs.webkit.org/show_bug.cgi?id=189868
26584 Reviewed by Xabier Rodriguez-Calvar.
26586 Added patch from https://bugzilla.gnome.org/show_bug.cgi?id=797187
26588 * gstreamer/jhbuild.modules:
26589 * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Added.
26591 2018-09-24 Alicia Boya García <aboya@igalia.com>
26592 [MSE][GStreamer] Add patch to jhbuild: matroskademux: Allow Matroska headers to be read more than once
26593 https://bugs.webkit.org/show_bug.cgi?id=185731
26595 Reviewed by Xabier Rodriguez-Calvar.
26597 Upstream bug in GStreamer: https://bugzilla.gnome.org/show_bug.cgi?id=793333
26599 This fixes YTTV 35. AppendMultipleInitOpusAudio (and any other use
26600 case where two WebM initialization segments are appended on a row).
26602 * gstreamer/jhbuild.modules:
26603 * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Added.
26604 * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Added.
26605 * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Added.
26607 2018-09-22 Myles C. Maxfield <mmaxfield@apple.com>
26609 [WHSL] Need grammar to specify kernel group size
26610 https://bugs.webkit.org/show_bug.cgi?id=189108
26612 Reviewed by Dean Jackson.
26614 In HLSL, compute functions are annotated with their workgroup size.
26617 [numthreads(3, 4, 5)] compute void foo(...) { ... }
26619 * WebGPUShadingLanguageRI/All.js:
26620 * WebGPUShadingLanguageRI/Func.js:
26622 (Func.prototype.get attributeBlock):
26623 * WebGPUShadingLanguageRI/FuncAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
26625 * WebGPUShadingLanguageRI/FuncDef.js:
26627 * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
26628 (FuncNumThreadsAttribute):
26629 (FuncNumThreadsAttribute.prototype.get x):
26630 (FuncNumThreadsAttribute.prototype.get y):
26631 (FuncNumThreadsAttribute.prototype.get z):
26632 * WebGPUShadingLanguageRI/LateChecker.js:
26633 (LateChecker.prototype._checkShaderType):
26634 * WebGPUShadingLanguageRI/Parse.js:
26635 (parseAttributeBlock):
26639 * WebGPUShadingLanguageRI/SPIRV.html:
26640 * WebGPUShadingLanguageRI/StatementCloner.js:
26641 (StatementCloner.prototype.visitFuncDef):
26642 (StatementCloner.prototype.visitFuncNumThreadsAttribute):
26644 * WebGPUShadingLanguageRI/Test.html:
26645 * WebGPUShadingLanguageRI/Test.js:
26646 (tests.numThreads):
26647 * WebGPUShadingLanguageRI/Visitor.js:
26648 (Visitor.prototype.visitFunc):
26649 (Visitor.prototype.visitFuncNumThreadsAttribute):
26651 * WebGPUShadingLanguageRI/index.html:
26653 2018-09-22 Myles C. Maxfield <mmaxfield@apple.com>
26655 Native functions which accept pointers need to do null checks
26656 https://bugs.webkit.org/show_bug.cgi?id=189883
26658 Reviewed by Dean Jackson.
26660 Simply guard all the places where we write through an author-provided pointer.
26662 * WebGPUShadingLanguageRI/Intrinsics.js:
26664 * WebGPUShadingLanguageRI/Test.js:
26665 (tests.textureDimensionsNull):
26667 2018-09-22 Myles C. Maxfield <mmaxfield@apple.com>
26669 [WHLSL] Implement atomic operations and barriers
26670 https://bugs.webkit.org/show_bug.cgi?id=189025
26672 Reviewed by Dean Jackson.
26674 In the interpreter, atomic operations don't need to be atomic.
26676 * WebGPUShadingLanguageRI/Intrinsics.js:
26678 * WebGPUShadingLanguageRI/StandardLibrary.js:
26679 (let.standardLibrary):
26680 * WebGPUShadingLanguageRI/Test.js:
26683 2018-09-22 Thibault Saunier <tsaunier@igalia.com>
26685 [WPE] Be very permissive in the MiniBrowser.
26686 https://bugs.webkit.org/show_bug.cgi?id=189800
26688 This is just a test tool and we should make
26689 it just work, security and privacy is not really
26690 a primary focus here.
26692 Reviewed by Žan Doberšek.
26694 * MiniBrowser/wpe/main.cpp:
26695 (decidePermissionRequest):
26698 2018-09-21 Thomas Denney <tdenney@apple.com>
26700 [WHLSL] Local variables should be statically allocated
26701 https://bugs.webkit.org/show_bug.cgi?id=188402
26703 Reviewed by Myles C. Maxfield.
26705 An additional preparation stage is now performed so that all local
26706 variables and function parameters are allocated in a single struct at
26707 entry points. A pointer to this struct is then passed for function
26710 * WebGPUShadingLanguageRI/All.js: Update dependencies.
26711 * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Added new stage.
26712 * WebGPUShadingLanguageRI/CallExpression.js:
26713 (CallExpression.prototype.set argumentList): Add setter because
26714 allocateAtEntryPoints needs to change this.
26715 * WebGPUShadingLanguageRI/EBufferBuilder.js: Remove a redundant
26716 constructor that wasn't used anywhere.
26717 * WebGPUShadingLanguageRI/Func.js:
26718 (Func.prototype.set parameters): Add setter.
26719 * WebGPUShadingLanguageRI/FuncDef.js:
26720 (FuncDef.prototype.set body): Ditto.
26721 * WebGPUShadingLanguageRI/Prepare.js:
26722 (let.prepare): Add call to allocateAtEntryPoints. This call cannot
26723 happen any earlier because it depends on having types for call
26725 * WebGPUShadingLanguageRI/Rewriter.js:
26726 (Rewriter.prototype.visitReturn): Resolve issue where the return
26727 statement's function wasn't copied. A null check is required as the
26728 Rewriter might be used before this property is set.
26729 * WebGPUShadingLanguageRI/SPIRV.html: Update dependencies.
26730 * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Abstracted logic
26731 into a separate function so that allocateAtEntryPoints can create the
26732 accessors for the struct type it introduces.
26733 * WebGPUShadingLanguageRI/Test.html: Update dependencies.
26734 * WebGPUShadingLanguageRI/Test.js: Add new tests to verify the static
26735 allocation transform works safely.
26736 * WebGPUShadingLanguageRI/index.html: Update dependencies.
26738 2018-09-21 Jonathan Bedard <jbedard@apple.com>
26740 Bring up queues for iOS 12 (Build fix)
26741 https://bugs.webkit.org/show_bug.cgi?id=189683
26743 Unreviewed build fix.
26745 We should not build ImageDiff as x86 by default since 32 bit projects are
26746 deprecated in Xcode. ImageDiff should only be built once.
26748 * Scripts/build-webkit:
26749 * Scripts/webkitdirs.pm:
26750 (argumentsForConfiguration):
26752 2018-09-21 Adrian Perez de Castro <aperez@igalia.com>
26754 [WPE] Built RPM of WPE webkit fails to install with "nothing provides libWPEToolingBackends.so()"
26755 https://bugs.webkit.org/show_bug.cgi?id=189797
26757 Reviewed by Žan Doberšek.
26759 * wpe/backends/CMakeLists.txt: Make libWPEToolingBackends a static library to avoid
26760 the need for installing it. This works fine because the library only contains utility
26761 code intended to be reused from other various components (MiniBrowser, WebKitTestRunner).
26763 2018-09-20 Daniel Bates <dabates@apple.com>
26765 Move IOKitSPI.h from TestRunnerShared to PAL
26766 https://bugs.webkit.org/show_bug.cgi?id=189804
26768 Reviewed by Wenson Hsieh.
26770 Towards fixing <https://bugs.webkit.org/show_bug.cgi?id=189604> move the IOKit SPI forward
26771 declarations to PAL so that they can be shared by WebKit, DumpRenderTree and WebKitTestRunner.
26773 No functionality changed. So, no new tests.
26775 * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
26776 * TestRunnerShared/spi/UIKitTestSPI.h:
26777 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
26778 * WebKitTestRunner/ios/HIDEventGenerator.mm:
26780 2018-09-20 Thomas Denney <tdenney@apple.com>
26782 [WHLSL] Metal code generation
26783 https://bugs.webkit.org/show_bug.cgi?id=187735
26785 Reviewed by Myles C. Maxfield.
26787 Adds support for generating Metal Shading Language from WHLSL. Clients
26788 should include the file MetalCodegenAll.js and then call whlslToMsl
26789 with their program source code to compile to Metal.
26791 * WebGPUShadingLanguageRI/ArrayType.js:
26792 (ArrayType.prototype.get arrayRefType): Adds the arrayRefType method to
26793 all types to find the type of that expression when it is used in a
26794 MakeArrayRefExpression.
26795 * WebGPUShadingLanguageRI/MakeArrayRefExpression.js:
26796 (MakeArrayRefExpression):
26797 (MakeArrayRefExpression.prototype.get type): Uses the new arrayRefType
26798 getter on all types to find the type of the expression.
26799 * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Added.
26800 * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Added.
26801 * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Added.
26802 * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Added.
26803 * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Added.
26804 * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Added.
26805 * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Added.
26806 * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Added.
26807 * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Added.
26808 * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Added.
26809 * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Added.
26810 * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Added.
26811 * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Added.
26812 * WebGPUShadingLanguageRI/Metal/TypeOf.js: Added.
26813 * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Added.
26814 * WebGPUShadingLanguageRI/PropertyResolver.js:
26815 * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
26816 * WebGPUShadingLanguageRI/Test.js: Added awkward tests for the compiler
26817 to generate code for.
26818 (tests.incrementAndDecrement):
26819 (tests.returnIntLiteralUint):
26820 (tests.returnIntLiteralFloat):
26821 (tests.nestedSubscriptWithArraysInStructs):
26822 (tests.nestedSubscript):
26823 (tests.lotsOfLocalVariables):
26824 * WebGPUShadingLanguageRI/Type.js:
26825 (Type.prototype.get arrayRefType): See above.
26827 2018-09-20 Ryan Haddad <ryanhaddad@apple.com>
26829 Bring up queues for iOS 12
26830 https://bugs.webkit.org/show_bug.cgi?id=189683
26832 Unreviewed infrastructure fix.
26834 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/iOS12@2x.png.
26835 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
26836 (BubbleQueueServer): Move EWS bubbles to the iOS 12 section of the dashboard.
26838 2018-09-20 Ryan Haddad <ryanhaddad@apple.com>
26840 Bring up queues for iOS 12
26841 https://bugs.webkit.org/show_bug.cgi?id=189683
26843 Reviewed by Aakash Jain.
26845 * BuildSlaveSupport/build.webkit.org-config/config.json:
26846 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png: Added.
26847 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png: Added.
26848 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png: Added.
26849 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/iOS12@2x.png: Added.
26850 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
26851 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
26853 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
26854 (table.queue-grid tr.platform.ios-simulator-12 img.logo):
26855 (table.queue-grid tr.platform.ios-12 img.logo):
26856 (table.queue-grid tr.platform.ios-simulator-11 img.logo): Deleted.
26857 (table.queue-grid tr.platform.ios-11 img.logo): Deleted.
26858 * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
26859 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
26860 (_should_file_trigger_build):
26861 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
26863 (ShouldBuildTest.test_should_build):
26865 2018-09-20 Basuke Suzuki <Basuke.Suzuki@sony.com>
26867 [Win] TestRunner::queueLoad() fails to generate correct url for some urls.
26868 https://bugs.webkit.org/show_bug.cgi?id=189679
26870 Reviewed by Fujii Hironori.
26872 Replace the implementation with correct API call.
26874 * DumpRenderTree/win/TestRunnerWin.cpp:
26875 (TestRunner::queueLoad): Call UrlCombineW.
26877 2018-09-20 Michael Catanzaro <mcatanzaro@igalia.com>
26879 [WPE] fails to build on ARM arches complaining about undefined reference to `epoxy_eglMakeCurrent'
26880 https://bugs.webkit.org/show_bug.cgi?id=189556
26882 Reviewed by Konstantin Tokarev.
26884 This is only a speculative build fix as I didn't attempt to reproduce. Explicitly link to
26887 * wpe/backends/CMakeLists.txt:
26889 2018-09-20 Daniel Bates <dabates@apple.com>
26891 [iOS] Support testing more hardware special keys
26892 https://bugs.webkit.org/show_bug.cgi?id=189793
26894 Reviewed by Simon Fraser.
26896 * TestRunnerShared/spi/IOKitSPI.h: Add more SPI constants.
26897 * WebKitTestRunner/ios/HIDEventGenerator.mm:
26898 (keyCodeForDOMFunctionKey): Extracted out logic from hidUsageCodeForCharacter() to return the
26899 key code for the F1, F2, ..., F12 keys and extended the code to compute the key code for the
26900 F13, F14, ..., F24 keys.
26901 (hidUsageCodeForCharacter): Modified to call keyCodeForDOMFunctionKey().
26903 2018-09-20 Michael Catanzaro <mcatanzaro@igalia.com>
26905 Unreviewed, remove accidentally-committed debugging changes from flatpakutils script
26907 Aaaaaah maybe this is why changes are supposed to be reviewed.
26909 * flatpak/flatpakutils.py:
26910 (WebkitFlatpak.clean_args):
26912 2018-09-20 Michael Catanzaro <mcatanzaro@igalia.com>
26914 Unreviewed, manually rollout our switch to master runtime
26916 Phil wants html5-codecs, which aren't available yet here. Let's switch back to 3.28 in the
26917 meantime, where we were already building GStreamer ourselves anyway. But use an updated
26920 * flatpak/files/httpd-autogen.sh: Added.
26921 * flatpak/flatpakutils.py:
26922 (WebkitFlatpak.clean_args):
26923 * flatpak/org.webkit.GTK.yaml:
26924 * flatpak/org.webkit.WebKit.yaml:
26925 * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
26926 * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Added.
26928 2018-09-20 Thibault Saunier <tsaunier@igalia.com>
26930 [WPE][GTK] webkit-flatpak intercepts --help for other commands
26931 https://bugs.webkit.org/show_bug.cgi?id=189058
26933 The approach of run_in_sandbox_if_available is that we basically have the
26934 same set of arguments to setup the sandbox (ie. port name, build type, etc...)
26935 and we can pass those args first to setup the flatpak launcher object
26936 and then to the underlying script. That doesn't work well with the `--help` argument
26937 as once processed it 1. prints the help (which make no sense to the user of the calling script)
26938 2. exits the app - The solution is to just make sure that `--help` is not used when using
26939 flatpakutils from any script that is not `webkit-flatpak` itself.
26941 Reviewed by Michael Catanzaro.
26943 * flatpak/flatpakutils.py:
26944 (WebkitFlatpak.load_from_args):
26945 (run_in_sandbox_if_available):
26947 2018-09-20 Xabier Rodriguez Calvar <calvaris@igalia.com>
26949 Unreviewed. Add W3C imported tests to the MSEEME watchlist.
26951 * Scripts/webkitpy/common/config/watchlist:
26953 2018-09-20 Xabier Rodriguez Calvar <calvaris@igalia.com>
26955 Unreviewed. Fix the Streams API watchlist.
26957 * Scripts/webkitpy/common/config/watchlist:
26959 2018-09-19 Chris Dumez <cdumez@apple.com>
26961 Crash under WebProcessProxy::suspendedPageWasDestroyed(WebKit::SuspendedPageProxy&)
26962 https://bugs.webkit.org/show_bug.cgi?id=189721
26963 <rdar://problem/44359788>
26965 Reviewed by Geoffrey Garen.
26967 Add API test coverage.
26969 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
26971 2018-09-19 Thomas Denney <tdenney@apple.com>
26973 [WHLSL] Improve test suite type safety
26974 https://bugs.webkit.org/show_bug.cgi?id=189502
26976 Reviewed by Myles C. Maxfield.
26978 Each of the 'makeT' functions now call the relevant cast function on the
26979 value before hand. The checkNumber function has also been removed and
26980 its uses have been replaced with functions that also check the type.
26981 Some of the arithmetic checks have been updated to reflect that the
26982 casts happen outside of WHLSL evaluation. Other tests have also been
26983 updated to reflect that some values cannot be precisely expressed in
26984 32-bit floating point.
26986 * WebGPUShadingLanguageRI/Casts.js:
26987 (castToBool): Added.
26988 (castAndCheckValue): Added.
26989 (isBitwiseEquivalent): Moved from Intrinsics.js.
26990 * WebGPUShadingLanguageRI/Intrinsics.js: Ditto.
26991 * WebGPUShadingLanguageRI/SPIRV.html: Update depdencies.
26992 * WebGPUShadingLanguageRI/Test.html: Ditto.
26993 * WebGPUShadingLanguageRI/Test.js: Update makeT functions to do a cast
26994 and check the result. Some tests were also updated to reflect the change
26995 in the behavior of these functions.
26996 * WebGPUShadingLanguageRI/index.html: Update dependencies.
26998 2018-09-19 John Wilander <wilander@apple.com>
27000 Resource Load Statistics: Add optional cap on partitioned cache max age
27001 https://bugs.webkit.org/show_bug.cgi?id=189711
27002 <rdar://problem/39246837>
27004 Reviewed by Antti Koivisto and Chris Dumez.
27006 This change adds infrastructure for layout tests of capped cache max age.
27008 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
27009 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
27010 (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
27011 * WebKitTestRunner/InjectedBundle/TestRunner.h:
27012 * WebKitTestRunner/TestController.cpp:
27013 (WTR::TestController::setStatisticsCacheMaxAgeCap):
27014 * WebKitTestRunner/TestController.h:
27015 * WebKitTestRunner/TestInvocation.cpp:
27016 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
27018 2018-09-19 Dawei Fenton <realdawei@apple.com>
27020 Unreviewed. Update my email and alias in list of contributors.
27022 * Scripts/webkitpy/common/config/contributors.json:
27024 2018-09-19 Michael Catanzaro <mcatanzaro@igalia.com>
27026 [WPE][GTK] Unreviewed, try #3 to fix a typo
27028 I feel like Charlie Brown, how hard this has been for me....
27030 * Scripts/run-minibrowser:
27031 * Scripts/webkitdirs.pm:
27032 (runInFlatpakIfAvailable):
27033 (runInFlatpakIfAvailible): Deleted.
27035 2018-09-19 Michael Catanzaro <mcatanzaro@igalia.com>
27037 [WPE][GTK] Unreviewed, fix that typo in more places
27039 It got copied into webkitdirs.pm!
27041 * Scripts/webkitdirs.pm:
27042 (runInFlatpakIfAvailible):
27043 (runInFlatpakIfAvalaible): Deleted.
27045 2018-09-19 Michael Catanzaro <mcatanzaro@igalia.com>
27047 [WPE][GTK] Unreviewed, fix a pervasive typo in the webkit-flatpak script
27049 * flatpak/flatpakutils.py:
27050 (WebkitFlatpak.load_from_args):
27051 (WebkitFlatpak.__init__):
27052 (WebkitFlatpak.run):
27054 2018-09-19 Michael Catanzaro <mcatanzaro@igalia.com>
27056 [WPE][GTK] Unreviewed, update to latest GNOME SDK
27058 * flatpak/org.webkit.WebKit.yaml:
27060 2018-09-19 Michael Catanzaro <mcatanzaro@igalia.com>
27062 Unreviewed, rolling out r235500.
27064 Time to switch back to master runtime
27066 Reverted changeset:
27068 "Unreviewed, rolling out r235114."
27069 https://bugs.webkit.org/show_bug.cgi?id=188731
27070 https://trac.webkit.org/changeset/235500
27072 2018-09-19 Adrian Perez de Castro <aperez@igalia.com>
27074 Unreviewed. Add Pablo Saavedra to the list of contributors.
27076 * Scripts/webkitpy/common/config/contributors.json:
27078 2018-09-19 Philippe Normand <pnormand@igalia.com>
27080 [GStreamer] Add support for AV1 decoding
27081 https://bugs.webkit.org/show_bug.cgi?id=189647
27083 Reviewed by Žan Doberšek.
27085 Add patches required for AV1 decoding support. They're all
27086 upstream already and will be shipped in GStreamer 1.16. The aom
27087 GStreamer plugin depends on the aom library for which there's no
27088 official release yet.
27090 * gstreamer/jhbuild.modules:
27091 * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Added.
27092 * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Added.
27093 * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Added. This one is unrelated but an implicit dependency of the next one.
27094 * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Added.
27095 * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Added.
27096 * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Added.
27098 2018-09-18 Jonathan Bedard <jbedard@apple.com>
27100 webkitpy: Clobbering and building occurs multiple times for iOS Simulator ports
27101 https://bugs.webkit.org/show_bug.cgi?id=189702
27102 <rdar://problem/44541704>
27104 Reviewed by Aakash Jain.
27106 * Scripts/webkitpy/layout_tests/controllers/manager.py:
27107 (Manager._set_up_run): Move build check and clobbering to run, since set up is
27108 run multiple times for iOS simulator.
27111 2018-09-18 Chris Dumez <cdumez@apple.com>
27113 "DidFirstVisuallyNonEmptyLayout" callback does not get called when restoring a page from PageCache
27114 https://bugs.webkit.org/show_bug.cgi?id=189681
27115 <rdar://problem/44526171>
27117 Reviewed by Alex Christensen and Zalan Bujtas.
27119 Add API test coverage.
27121 * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
27122 (TestWebKitAPI::didFinishNavigation):
27123 (TestWebKitAPI::TEST):
27125 2018-09-18 Claudio Saavedra <csaavedra@igalia.com>
27127 [WPE] Implement mouse event modifiers
27128 https://bugs.webkit.org/show_bug.cgi?id=189697
27130 Reviewed by Carlos Garcia Campos.
27132 * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
27133 (WTR::wkEventModifiersToWPE):
27134 (WTR::EventSenderProxy::mouseDown):
27135 (WTR::EventSenderProxy::mouseUp):
27137 2018-09-17 Yusuke Suzuki <utatane.tea@gmail.com>
27139 [WTF] Use Semaphore and BinarySemaphore instead of dispatch_semaphore_t
27140 https://bugs.webkit.org/show_bug.cgi?id=185339
27142 Reviewed by Mark Lam.
27144 * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
27145 (TestWebKitAPI::ToUpperConverter::stopProducing):
27146 (TestWebKitAPI::ToUpperConverter::stopConsuming):
27148 2018-09-17 Simon Fraser <simon.fraser@apple.com>
27150 Many modern media control tests leak documents in testing
27151 https://bugs.webkit.org/show_bug.cgi?id=189437
27153 Reviewed by Darin Adler.
27155 In order to accurately detect leaks in media controls tests which use lots of
27156 SVGImages, we have to:
27157 - Fire a zero-delay timer after the postTask, in order for ImagesLoader's m_derefElementTimer
27158 to clear references to elements.
27159 - Have releaseCriticalMemory() call CachedResourceLoader's garbageCollectDocumentResources()
27160 to drop the last handle to the CachedResource for an SVGImage.
27161 - Call WKBundleReleaseMemory() after the GC and timer, since we need garbageCollectDocumentResources()
27162 to run again after that timer has fired.
27164 This should fix most of the spurious leak reports involving SVGImage documents.
27166 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
27167 (WTR::InjectedBundle::reportLiveDocuments):
27168 (WTR::InjectedBundle::didReceiveMessageToPage):
27170 2018-09-17 Chris Dumez <cdumez@apple.com>
27172 PSON: window.open() with 'noopener' should only process-swap cross-site, not cross-origin
27173 https://bugs.webkit.org/show_bug.cgi?id=189602
27174 <rdar://problem/44430549>
27176 Reviewed by Geoff Garen.
27178 Add API test coverage.
27180 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
27182 2018-09-17 Philippe Normand <pnormand@igalia.com>
27184 [JHBuild] Update to GStreamer 1.14.3
27185 https://bugs.webkit.org/show_bug.cgi?id=189450
27187 Reviewed by Xabier Rodriguez-Calvar.
27189 * gstreamer/jhbuild.modules: Bump GStreamer modules from 1.14.1 to 1.14.3.
27191 2018-09-17 Philippe Normand <pnormand@igalia.com>
27193 [JHBuild] Doesn't check sha256 sums
27194 https://bugs.webkit.org/show_bug.cgi?id=189646
27196 Reviewed by Michael Catanzaro.
27198 * gstreamer/jhbuild.modules: Properly set the sha256: prefix on hashes.
27200 2018-09-17 Sihui Liu <sihui_liu@apple.com>
27202 Move IndexedDB to Network Process
27203 https://bugs.webkit.org/show_bug.cgi?id=189415
27204 <rdar://problem/44396973>
27206 Reviewed by Chris Dumez.
27208 * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
27210 * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
27212 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
27214 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
27216 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
27219 2018-09-08 Darin Adler <darin@apple.com>
27221 Streamline JSRetainPtr, fix leaks of JSString and JSGlobalContext
27222 https://bugs.webkit.org/show_bug.cgi?id=189455
27224 Reviewed by Keith Miller.
27226 There is a lot of copied and pasted code for WebKit vs. Legacy WebKit
27227 testing and even for macOS vs. iOS vs. Windows platform-specific code.
27228 For now, this patch just makes corresponding changes to the copied code.
27229 Later we might get better results by merging more code instead of having
27230 all these separate copies.
27232 * DumpRenderTree/AccessibilityController.cpp:
27233 (AccessibilityController::makeWindowObject): Use the adopt function
27234 instead of the special Adopt constructor of JSRetainPtr.
27236 * DumpRenderTree/AccessibilityTextMarker.cpp: Removed unneeded include.
27238 * DumpRenderTree/AccessibilityUIElement.cpp: Ditto.
27239 (allAttributesCallback): Don't adopt at this level; changed the
27240 underlying function to return a JSRetainPtr so the adopt is right next
27241 to the call to the create or copy function.
27242 (attributesOfLinkedUIElementsCallback): Ditto.
27243 (attributesOfDocumentLinksCallback): Ditto.
27244 (attributesOfChildrenCallback): Ditto.
27245 (parameterizedAttributeNamesCallback): Ditto.
27246 (attributesOfColumnHeadersCallback): Ditto.
27247 (attributesOfRowHeadersCallback): Ditto.
27248 (attributesOfColumnsCallback): Ditto.
27249 (attributesOfRowsCallback): Ditto.
27250 (attributesOfVisibleCellsCallback): Ditto.
27251 (attributesOfHeaderCallback): Ditto.
27252 (rowIndexRangeCallback): Ditto.
27253 (columnIndexRangeCallback): Ditto.
27254 (rangeForLineCallback): Ditto.
27255 (boundsForRangeCallback): Ditto.
27256 (rangeForPositionCallback): Ditto.
27257 (stringForRangeCallback): Ditto.
27258 (attributedStringForRangeCallback): Ditto.
27259 (uiElementCountForSearchPredicateCallback): Use the free adopt
27260 function instead of the adopt member function.
27261 (uiElementForSearchPredicateCallback): Ditto.
27262 (selectTextWithCriteriaCallback): Don't adopt at this level.
27263 (attributedStringForElementCallback): Ditto.
27264 (setValueCallback): Use free adopt.
27265 (stringAttributeValueCallback): Don't adopt at this level.
27266 (uiElementArrayAttributeValueCallback): Ditto.
27267 (uiElementAttributeValueCallback): Ditto.
27268 (stringForTextMarkerRangeCallback): Ditto.
27269 (attributedStringForTextMarkerRangeCallback): Ditto.
27270 (attributedStringForTextMarkerRangeWithOptionsCallback): Ditto.
27271 (getARIADropEffectsCallback): Ditto.
27272 (getClassListCallback): Ditto.
27273 (getRoleCallback): Ditto.
27274 (getSubroleCallback): Ditto.
27275 (getRoleDescriptionCallback): Ditto.
27276 (getComputedRoleStringCallback): Ditto.
27277 (getTitleCallback): Ditto.
27278 (getDescriptionCallback): Ditto.
27279 (getStringValueCallback): Ditto.
27280 (getLanguageCallback): Ditto.
27281 (getHelpTextCallback): Ditto.
27282 (getOrientationCallback): Ditto.
27283 (getPathDescriptionCallback): Ditto.
27284 (getSelectedTextRangeCallback): Ditto.
27285 (speakAsCallback): Ditto.
27286 (getValueDescriptionCallback): Ditto.
27287 (getAccessibilityValueCallback): Ditto.
27288 (getDocumentEncodingCallback): Ditto.
27289 (getDocumentURICallback): Ditto.
27290 (getURLCallback): Ditto.
27291 (characterAtOffsetCallback): Ditto.
27292 (wordAtOffsetCallback): Ditto.
27293 (lineAtOffsetCallback): Ditto.
27294 (sentenceAtOffsetCallback): Ditto.
27295 (stringForSelectionCallback): Ditto.
27296 (getIdentifierCallback): Ditto.
27297 (getTraitsCallback): Ditto.
27298 (supportedActionsCallback): Ditto.
27299 (mathPostscriptsDescriptionCallback): Ditto.
27300 (mathPrescriptsDescriptionCallback): Ditto.
27301 (AccessibilityUIElement::rangeForLine): Updated to return JSRetainPtr.
27302 (AccessibilityUIElement::rangeForPosition): Ditto.
27303 (AccessibilityUIElement::speakAs): Ditto.
27304 (AccessibilityUIElement::pathDescription const): Ditto.
27305 (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
27306 (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
27307 (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
27309 * DumpRenderTree/AccessibilityUIElement.h: Use JSRetainPtr instead of
27310 raw pointers for the results of the functions that create strings.
27311 The old way was difficult to get right; the functions didn't even follow
27312 the create/copy naming rule.
27314 * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
27315 (_platformTypeConstructor): Use the adopt function instead of the
27316 JSRetainPtr adopt constructor. Also nullptr instead of 0.
27318 * DumpRenderTree/GCController.cpp:
27319 (GCController::makeWindowObject): Use adopt function instead of constructor.
27321 * DumpRenderTree/TestRunner.cpp:
27322 (pathToLocalResourceCallback): Use adopt function instead of constructor.
27323 (addDisallowedURLCallback): Ditto.
27324 (addURLToRedirectCallback): Ditto.
27325 (clearApplicationCacheForOriginCallback): Ditto.
27326 (applicationCacheDiskUsageForOriginCallback): Ditto.
27327 (decodeHostNameCallback): Don't adopt at this level.
27328 (encodeHostNameCallback): Ditto.
27329 (execCommandCallback): Use adopt instead of JSRetainPtr::adopt.
27330 (findStringCallback): Use adopt function instead of constructor.
27331 (isCommandEnabledCallback): Ditto.
27332 (overridePreferenceCallback): Ditto.
27333 (queueLoadCallback): Ditto.
27334 (queueLoadHTMLStringCallback): Ditto.
27335 (queueLoadingScriptCallback): Ditto.
27336 (queueNonLoadingScriptCallback): Ditto.
27337 (setAuthenticationPasswordCallback): Ditto.
27338 (setAuthenticationUsernameCallback): Ditto.
27339 (setDomainRelaxationForbiddenForURLSchemeCallback): Ditto.
27340 (setMockGeolocationPositionUnavailableErrorCallback): Ditto.
27341 (setPOSIXLocaleCallback): Ditto.
27342 (setPersistentUserStyleSheetLocationCallback): Ditto.
27343 (setUserStyleSheetLocationCallback): Ditto.
27344 (setValueForUserCallback): Ditto.
27345 (setWillSendRequestClearHeaderCallback): Ditto.
27346 (setPageVisibilityCallback): Ditto.
27347 (evaluateInWebInspectorCallback): Ditto.
27348 (evaluateScriptInIsolatedWorldCallback): Ditto.
27349 (evaluateScriptInIsolatedWorldAndReturnValueCallback): Ditto.
27350 (addOriginAccessWhitelistEntryCallback): Ditto.
27351 (removeOriginAccessWhitelistEntryCallback): Ditto.
27352 (setScrollbarPolicyCallback): Ditto.
27353 (addUserScriptCallback): Ditto.
27354 (addUserStyleSheetCallback): Ditto.
27355 (apiTestNewWindowDataLoadBaseURLCallback): Ditto.
27356 (authenticateSessionCallback): Ditto.
27357 (getTitleTextDirectionCallback): Ditto.
27358 (getInspectorTestStubURLCallback): Ditto.
27359 (simulateLegacyWebNotificationClickCallback): Ditto.
27360 (setTextDirectionCallback): Ditto.
27361 (grantWebNotificationPermissionCallback): Ditto.
27362 (denyWebNotificationPermissionCallback): Ditto.
27363 (accummulateLogsForChannel): Ditto.
27364 (runUIScriptCallback): Ditto.
27365 (TestRunner::makeWindowObject): Ditto.
27366 (TestRunner::uiScriptDidComplete): Ditto.
27367 (TestRunner::setOpenPanelFiles): Ditto.
27369 * DumpRenderTree/TestRunner.h: Use JSRetainPtr instead of
27370 raw pointers for the results of the functions that create strings.
27372 * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
27373 (AccessibilityController::platformName const): Use the adopt
27374 function instead of the adopt constructor.
27376 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
27377 (createEmptyJSString): Added. This helper function makes reduces the
27378 repetitive code to create empty strings.
27379 (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
27380 (AccessibilityUIElement::identifier): Ditto.
27381 (AccessibilityUIElement::traits): Ditto.
27382 (AccessibilityUIElement::url): Ditto.
27383 (AccessibilityUIElement::speakAs): Ditto.
27384 (AccessibilityUIElement::stringForSelection): Ditto.
27385 (AccessibilityUIElement::stringForRange): Ditto.
27386 (AccessibilityUIElement::attributedStringForRange): Ditto.
27387 (AccessibilityUIElement::attributedStringForElement): Ditto.
27388 (AccessibilityUIElement::pathDescription const): Ditto.
27389 (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
27390 (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
27391 (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
27392 (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
27393 (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
27394 (AccessibilityUIElement::attributesOfChildren): Ditto.
27395 (AccessibilityUIElement::allAttributes): Ditto.
27396 (AccessibilityUIElement::stringAttributeValue): Ditto.
27397 (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
27398 (AccessibilityUIElement::role): Ditto.
27399 (AccessibilityUIElement::subrole): Ditto.
27400 (AccessibilityUIElement::roleDescription): Ditto.
27401 (AccessibilityUIElement::computedRoleString): Ditto.
27402 (AccessibilityUIElement::title): Ditto.
27403 (AccessibilityUIElement::description): Ditto.
27404 (AccessibilityUIElement::orientation const): Ditto.
27405 (AccessibilityUIElement::stringValue): Ditto.
27406 (AccessibilityUIElement::language): Ditto.
27407 (AccessibilityUIElement::helpText const): Ditto.
27408 (AccessibilityUIElement::valueDescription): Ditto.
27409 (AccessibilityUIElement::ariaDropEffects const): Ditto.
27410 (AccessibilityUIElement::boundsForRange): Ditto.
27411 (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
27412 (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
27413 (AccessibilityUIElement::attributesOfColumns): Ditto.
27414 (AccessibilityUIElement::attributesOfRows): Ditto.
27415 (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
27416 (AccessibilityUIElement::attributesOfHeader): Ditto.
27417 (AccessibilityUIElement::rowIndexRange): Ditto.
27418 (AccessibilityUIElement::columnIndexRange): Ditto.
27419 (AccessibilityUIElement::selectedTextRange): Ditto.
27420 (AccessibilityUIElement::accessibilityValue const): Ditto.
27421 (AccessibilityUIElement::documentEncoding): Ditto.
27422 (AccessibilityUIElement::documentURI): Ditto.
27423 (AccessibilityUIElement::selectTextWithCriteria): Ditto.
27424 (AccessibilityUIElement::classList const): Ditto.
27426 * DumpRenderTree/mac/AccessibilityCommonMac.h: Changed the
27427 createJSStringRef method to return a JSRetainPtr.
27428 * DumpRenderTree/mac/AccessibilityCommonMac.mm:
27429 (-[NSString createJSStringRef]): Ditto.
27430 (searchPredicateParameterizedAttributeForSearchCriteria): Use the
27431 adopt function instead of the adopt constructor.
27432 * DumpRenderTree/mac/AccessibilityControllerMac.mm:
27433 (AccessibilityController::platformName const): Ditto.
27435 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
27436 (-[NSString createJSStringRef]): Return a JSRetainPtr.
27437 (makeValueRefForValue): Updated for the above, no adopt needed here now.
27438 (makeObjectRefForDictionary): Ditto.
27439 (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
27441 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
27442 (createEmptyJSString): Added. This helper function makes reduces the
27443 repetitive code to create empty strings.
27444 (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
27445 (descriptionOfElements): Ditto.
27446 (selectTextParameterizedAttributeForCriteria): Ditto.
27447 (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
27448 (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
27449 (AccessibilityUIElement::attributesOfChildren): Ditto.
27450 (AccessibilityUIElement::allAttributes): Ditto.
27451 (AccessibilityUIElement::stringAttributeValue): Ditto.
27452 (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
27453 (AccessibilityUIElement::role): Ditto.
27454 (AccessibilityUIElement::subrole): Ditto.
27455 (AccessibilityUIElement::roleDescription): Ditto.
27456 (AccessibilityUIElement::computedRoleString): Ditto.
27457 (AccessibilityUIElement::title): Ditto.
27458 (AccessibilityUIElement::description): Ditto.
27459 (AccessibilityUIElement::orientation const): Ditto.
27460 (AccessibilityUIElement::stringValue): Ditto.
27461 (AccessibilityUIElement::language): Ditto.
27462 (AccessibilityUIElement::helpText const): Ditto.
27463 (AccessibilityUIElement::valueDescription): Ditto.
27464 (AccessibilityUIElement::speakAs): Ditto.
27465 (AccessibilityUIElement::classList const): Ditto.
27466 (AccessibilityUIElement::ariaDropEffects const): Ditto.
27467 (AccessibilityUIElement::rangeForLine): Ditto.
27468 (AccessibilityUIElement::rangeForPosition): Ditto.
27469 (AccessibilityUIElement::boundsForRange): Ditto.
27470 (AccessibilityUIElement::stringForRange): Ditto.
27471 (AccessibilityUIElement::attributedStringForRange): Ditto.
27472 (AccessibilityUIElement::selectTextWithCriteria): Ditto.
27473 (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
27474 (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
27475 (AccessibilityUIElement::attributesOfColumns): Ditto.
27476 (AccessibilityUIElement::attributesOfRows): Ditto.
27477 (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
27478 (AccessibilityUIElement::attributesOfHeader): Ditto.
27479 (AccessibilityUIElement::rowIndexRange): Ditto.
27480 (AccessibilityUIElement::columnIndexRange): Ditto.
27481 (AccessibilityUIElement::pathDescription const): Ditto.
27482 (AccessibilityUIElement::selectedTextRange): Ditto.
27483 (AccessibilityUIElement::accessibilityValue const): Ditto.
27484 (AccessibilityUIElement::documentEncoding): Ditto.
27485 (AccessibilityUIElement::documentURI): Ditto.
27486 (AccessibilityUIElement::url): Ditto.
27487 (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
27488 (createJSStringRef): Ditto.
27489 (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
27490 (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
27491 (AccessibilityUIElement::supportedActions): Ditto.
27492 (AccessibilityUIElement::mathPostscriptsDescription const): Ditto.
27493 (AccessibilityUIElement::mathPrescriptsDescription const): Ditto.
27495 * DumpRenderTree/mac/FrameLoadDelegate.mm:
27496 (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
27497 Use the adopt function instead of the adopt constructor.
27498 * DumpRenderTree/mac/TestRunnerMac.mm:
27499 (originsArrayToJS): Ditto.
27500 (TestRunner::copyDecodedHostName): Return a JSRetainPtr.
27501 (TestRunner::copyEncodedHostName): Ditto.
27502 (TestRunner::pathToLocalResource): Ditto.
27503 (TestRunner::queueLoad): Use adopt function instead of constructor.
27504 (TestRunner::findString): Ditto.
27505 (TestRunner::inspectorTestStubURL): Return a JSRetainPtr.
27507 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
27508 (AccessibilityController::winNotificationReceived): Use adopt function
27509 instead of adopt constructor.
27510 (AccessibilityController::platformName const): Ditto.
27512 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
27513 (createEmptyJSString): Added. This helper function makes reduces the
27514 repetitive code to create empty strings.
27515 (AccessibilityUIElement::allAttributes): Changed to return a JSRetainPtr.
27516 (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
27517 (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
27518 (AccessibilityUIElement::attributesOfChildren): Ditto.
27519 (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
27520 (AccessibilityUIElement::role): Ditto.
27521 (AccessibilityUIElement::subrole): Ditto.
27522 (AccessibilityUIElement::roleDescription): Ditto.
27523 (AccessibilityUIElement::computedRoleString): Ditto.
27524 (AccessibilityUIElement::title): Ditto.
27525 (AccessibilityUIElement::description): Ditto.
27526 (AccessibilityUIElement::stringValue): Ditto.
27527 (AccessibilityUIElement::language): Ditto.
27528 (AccessibilityUIElement::helpText const): Ditto.
27529 (AccessibilityUIElement::valueDescription): Ditto.
27530 (AccessibilityUIElement::ariaDropEffects const): Ditto.
27531 (AccessibilityUIElement::orientation const): Ditto.
27532 (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
27533 (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
27534 (AccessibilityUIElement::attributesOfColumns): Ditto.
27535 (AccessibilityUIElement::attributesOfRows): Ditto.
27536 (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
27537 (AccessibilityUIElement::attributesOfHeader): Ditto.
27538 (AccessibilityUIElement::rowIndexRange): Ditto.
27539 (AccessibilityUIElement::columnIndexRange): Ditto.
27540 (AccessibilityUIElement::boundsForRange): Ditto.
27541 (AccessibilityUIElement::stringForRange): Ditto.
27542 (AccessibilityUIElement::attributedStringForRange): Ditto.
27543 (AccessibilityUIElement::selectTextWithCriteria): Ditto.
27544 (AccessibilityUIElement::selectedTextRange): Ditto.
27545 (AccessibilityUIElement::stringAttributeValue): Ditto.
27546 (AccessibilityUIElement::accessibilityValue const): Ditto.
27547 (AccessibilityUIElement::documentEncoding): Ditto.
27548 (AccessibilityUIElement::documentURI): Ditto.
27549 (AccessibilityUIElement::url): Ditto.
27550 (AccessibilityUIElement::classList const): Ditto.
27552 * DumpRenderTree/win/TestRunnerWin.cpp:
27553 (TestRunner::copyDecodedHostName): Changed to return a JSRetainPtr.
27554 (TestRunner::copyEncodedHostName): Ditto.
27555 (TestRunner::pathToLocalResource): Ditto.
27556 (TestRunner::queueLoad): Ditto.
27557 (TestRunner::findString): Ditto.
27558 (TestRunner::inspectorTestStubURL): Ditto.
27560 * TestRunnerShared/Bindings/JSWrapper.h:
27561 (WTR::setProperty): Use adopt function instead of constructor.
27562 * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
27563 (UIScriptContext::UIScriptContext): Ditto.
27564 (UIScriptContext::runUIScript): Ditto.
27565 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
27566 (WTR::toDeviceOrientation): Ditto.
27568 * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
27569 (nsTextCheckingType): Changed this function to not take an rvalue
27570 reference to a JSRetainPtr since it doesn't take ownership.
27571 (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Updated
27572 for the above change.
27574 * TestWebKitAPI/JavaScriptTest.cpp:
27575 (TestWebKitAPI::javaScriptCallback): Use adopt function instead of
27576 adopt member function.
27578 * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp: Removed unneeded include.
27579 * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm: Ditto.
27580 * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Use adopt function instead of
27582 * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm: Ditto.
27584 * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
27585 Removed unneeded includes.
27586 * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Ditto.
27587 * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Ditto.
27588 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Ditto.
27590 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
27591 (_platformTypeConstructor): Use the adopt function instead of the
27592 JSRetainPtr adopt constructor. Also nullptr instead of 0.
27594 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
27595 (WTR::arrayLength): Use adopt function instead of constructor.
27596 (WTR::parseModifierArray): Ditto.
27597 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
27598 (WTR::propertyValue): Ditto.
27599 (WTR::dumpPath): Ditto.
27600 (WTR::toJS): Ditto.
27601 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
27602 (WTR::TestRunner::findString): Ditto.
27603 (WTR::TestRunner::statisticsDidRunTelemetryCallback): Ditto.
27604 (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback): Ditto.
27605 (WTR::TestRunner::setOpenPanelFiles): Ditto.
27606 * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
27607 (WTR::AccessibilityController::platformName): Ditto.
27609 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
27610 (-[NSString createJSStringRef]): Return a JSRetainPtr.
27611 This fixes storage leaks in many functions below, which were using
27612 the create function and putting the value right into a JSRetainPtr
27614 (WTR::createEmptyJSString): Added. This helper function reduces the
27615 repetitive code to create empty strings.
27616 (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
27617 (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
27618 Use createEmptyJSString, fixing a storage leak due to missing adoption.
27619 (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
27620 (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
27621 (WTR::AccessibilityUIElement::allAttributes): Ditto.
27622 (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
27623 (WTR::AccessibilityUIElement::parameterizedAttributeNames): Ditto.
27624 (WTR::AccessibilityUIElement::role): Ditto.
27625 (WTR::AccessibilityUIElement::subrole): Ditto.
27626 (WTR::AccessibilityUIElement::roleDescription): Ditto.
27627 (WTR::AccessibilityUIElement::computedRoleString): Ditto.
27628 (WTR::AccessibilityUIElement::title): Ditto.
27629 (WTR::AccessibilityUIElement::orientation const): Ditto.
27630 (WTR::AccessibilityUIElement::language): Ditto.
27631 (WTR::AccessibilityUIElement::valueDescription): Ditto.
27632 (WTR::AccessibilityUIElement::ariaDropEffects const): Ditto.
27633 (WTR::AccessibilityUIElement::boundsForRange): Ditto.
27634 (WTR::AccessibilityUIElement::stringForRange): Removed unneeded null check.
27635 (WTR::AccessibilityUIElement::attributedStringForRange): Ditto.
27636 (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
27637 Use createEmptyJSString, fixing a storage leak due to missing adoption.
27638 (WTR::AccessibilityUIElement::attributesOfRowHeaders): Ditto.
27639 (WTR::AccessibilityUIElement::attributesOfColumns): Ditto.
27640 (WTR::AccessibilityUIElement::attributesOfRows): Ditto.
27641 (WTR::AccessibilityUIElement::attributesOfVisibleCells): Ditto.
27642 (WTR::AccessibilityUIElement::attributesOfHeader): Ditto.
27643 (WTR::AccessibilityUIElement::selectedTextRange): Ditto.
27644 (WTR::AccessibilityUIElement::accessibilityValue const): Ditto.
27645 (WTR::AccessibilityUIElement::documentEncoding): Ditto.
27646 (WTR::AccessibilityUIElement::documentURI): Ditto.
27647 (WTR::AccessibilityUIElement::stringForSelection): Removed unneeded
27649 (WTR::AccessibilityUIElement::stringForTextMarkerRange):
27650 Use createEmptyJSString, fixing a storage leak due to missing adoption.
27652 * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
27653 Use JSRetainPtr for the return value of createJSStringRef.
27654 * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
27655 (-[NSString createJSStringRef]): Ditto.
27656 (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Use the
27657 adopt function instead of the adopt constructor.
27658 * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
27659 (WTR::AccessibilityController::platformName): Ditto
27661 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
27662 (-[NSString createJSStringRef]): Return a JSRetainPtr.
27663 (makeValueRefForValue): Updated for above by removing adopt.
27664 (makeObjectRefForDictionary): Ditto.
27665 (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
27667 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
27668 (WTR::createEmptyJSString): Added. This helper function makes reduces the
27669 repetitive code to create empty strings.
27670 (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
27671 (WTR::descriptionOfElements): Ditto.
27672 (WTR::selectTextParameterizedAttributeForCriteria): Ditto.
27673 (WTR::AccessibilityUIElement::accessibilityValue const): Use createEmptyJSString,
27674 fixing a storage leak due to missing adoption.
27675 (WTR::AccessibilityUIElement::documentEncoding): Ditto.
27676 (WTR::AccessibilityUIElement::documentURI): Ditto.
27677 (WTR::createJSStringRef): Return a JSRetainPtr.
27679 * WebKitTestRunner/StringFunctions.h:
27680 (WTR::toWK): Take a const& to eliminate a little bit of reference count churn.
27681 (WTR::toJS): Use the adopt function instead of the constructor.
27683 2018-09-14 Dean Jackson <dino@grorg.org>
27685 Add Justin Michaud.
27687 * Scripts/webkitpy/common/config/contributors.json:
27689 2018-09-14 Ryan Haddad <ryanhaddad@apple.com>
27691 bots should pass --clobber-old-results to run-webkit-tests
27692 https://bugs.webkit.org/show_bug.cgi?id=189623
27694 Reviewed by Aakash Jain.
27696 In order to ensure that bots to not produce confusing results due to transient execptions,
27697 or run out of space if they continually hit an exception, old layout test results should be clobbered.
27699 * BuildSlaveSupport/build.webkit.org-config/steps.py:
27702 2018-09-13 Ryan Haddad <ryanhaddad@apple.com>
27704 Unreviewed, rolling out r235954.
27706 Breaks the watchOS build.
27708 Reverted changeset:
27710 "Move IndexedDB to Network Process"
27711 https://bugs.webkit.org/show_bug.cgi?id=189415
27712 https://trac.webkit.org/changeset/235954
27714 2018-09-13 Daniel Bates <dabates@apple.com>
27716 Add Copy WebKit Permalink plugin for Sublime Text
27717 https://bugs.webkit.org/show_bug.cgi?id=189589
27719 Rubber-stamped by Joseph Pecoraro.
27721 Port the Copy WebKit Permalink Automator service to a Sublime Text plugin. Once installed you can
27722 use the plugin to copy to the Clipboard a trac.webkit.org hyperlink to the selected line in the
27723 active document with or without blame annotations.
27725 Once installed, you can Control-click (on Mac) or right-click (on Windows and Linux) on a line and
27726 choose Copy WebKit Permalink or Copy WebKit Permalink to Blame from the context menu to copy to the
27727 Clipboard a permanent hyperlink to the selected line without or with blame annotations, respectively.
27728 On Mac you can also invoke the same functionality using the keyboard shortcuts Command + Shift + Control + C
27729 and Command + Shift + Control + Option + C, respectively.
27731 * CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-menu: Added.
27732 * CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py: Added.
27733 * CopyPermalink/Sublime Text/CopyWebKitPermalink/Default (OSX).sublime-keymap: Added.
27734 * CopyPermalink/Sublime Text/INSTALL: Added.
27735 * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/Info.plist: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist.
27736 * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/document.wflow: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow.
27737 * CopyPermalink/Xcode/INSTALL: Renamed from Tools/CopyPermalink/README.
27739 2018-09-13 Carlos Garcia Campos <cgarcia@igalia.com>
27741 Unreviewed. Fix WebDriver tests after r235225.
27743 Use wpt serve command to run the http server.
27745 * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
27746 (WebDriverW3CWebServer.__init__):
27747 (WebDriverW3CWebServer.start):
27748 (WebDriverW3CWebServer.stop):
27750 2018-09-13 Carlos Garcia Campos <cgarcia@igalia.com>
27752 [GTK][WPE] Allow to run script dialogs asynchronously in the UI process
27753 https://bugs.webkit.org/show_bug.cgi?id=189544
27755 Reviewed by Michael Catanzaro.
27757 Add test cases for the new API.
27759 * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
27760 (testWebViewJavaScriptDialogs):
27762 2018-09-12 Fujii Hironori <Hironori.Fujii@sony.com>
27764 [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
27765 https://bugs.webkit.org/show_bug.cgi?id=189496
27766 <rdar://problem/44370981>
27768 Unreviewed warning fix.
27770 r235929 has introduced a new compilation warning:
27771 > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:34:70: warning: unused parameter ‘imageSize’ [-Wunused-parameter]
27773 * ImageDiff/cairo/PlatformImageCairo.cpp:
27774 (ImageDiff::PlatformImage::createFromStdin): Removed the variable name.
27776 2018-09-12 Dan Bernstein <mitz@apple.com>
27778 [Cocoa] Complete support for Paste as Quotation
27779 https://bugs.webkit.org/show_bug.cgi?id=189504
27781 Reviewed by Wenson Hsieh.
27783 * MiniBrowser/mac/MainMenu.xib: Added a Paste as Quotation command in the Edit menu.
27785 2018-09-12 Sihui Liu <sihui_liu@apple.com>
27787 Move IndexedDB to Network Process
27788 https://bugs.webkit.org/show_bug.cgi?id=189415
27790 Reviewed by Geoffrey Garen.
27792 * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
27794 * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
27796 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
27798 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
27800 * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
27803 2018-09-12 Chris Dumez <cdumez@apple.com>
27805 PSON: No process swap on back navigation after URL bar navigation
27806 https://bugs.webkit.org/show_bug.cgi?id=189557
27807 <rdar://problem/44353108>
27809 Reviewed by Alex Christensen.
27811 Add API test coverage.
27813 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
27815 2018-09-11 Dean Jackson <dino@apple.com>
27817 Header parsing for experimental and internal debug features
27818 https://bugs.webkit.org/show_bug.cgi?id=189486
27819 <rdar://problem/44320618>
27821 Reviewed by Tim Horton.
27823 Keep track of experimental and internal debug features in TestOptions, and
27824 allow webkit-test-runner headers to toggle them by name.
27826 * DumpRenderTree/TestOptions.cpp:
27827 (TestOptions::TestOptions):
27828 * WebKitTestRunner/TestController.cpp:
27829 (WTR::TestController::resetPreferencesToConsistentValues):
27830 (WTR::updateTestOptionsFromTestHeader):
27831 * WebKitTestRunner/TestOptions.h:
27832 (WTR::TestOptions::hasSameInitializationOptions const):
27834 2018-09-12 Fujii Hironori <Hironori.Fujii@sony.com>
27836 [Win][Clang][DumpRenderTree] 0 and nullptr can't be implicitly converted to AccessibilityUIElement
27837 https://bugs.webkit.org/show_bug.cgi?id=189492
27839 Reviewed by Alex Christensen.
27841 0 and nullptr can't be implicitly converted to
27842 AccessibilityUIElement because only Windows port typedefs
27843 PlatformUIElement as COMPtr<IAccessible> not a pointer.
27845 Replaced "return 0" and "return nullptr" with "return { nullptr }".
27847 * DumpRenderTree/AccessibilityUIElement.cpp:
27848 (AccessibilityUIElement::horizontalScrollbar const):
27849 (AccessibilityUIElement::verticalScrollbar const):
27850 (AccessibilityUIElement::uiElementAttributeValue const):
27851 (AccessibilityUIElement::accessibilityElementForTextMarker):
27852 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
27853 (AccessibilityController::elementAtPoint):
27854 (AccessibilityController::accessibleElementById):
27855 (AccessibilityController::focusedElement):
27856 (AccessibilityController::rootElement):
27857 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
27858 (AccessibilityUIElement::elementAtPoint):
27859 (AccessibilityUIElement::linkedUIElementAtIndex):
27860 (AccessibilityUIElement::getChildAtIndex):
27861 (AccessibilityUIElement::titleUIElement):
27862 (AccessibilityUIElement::parentElement):
27863 (AccessibilityUIElement::uiElementForSearchPredicate):
27864 (AccessibilityUIElement::cellForColumnAndRow):
27865 (AccessibilityUIElement::disclosedRowAtIndex):
27866 (AccessibilityUIElement::ariaOwnsElementAtIndex):
27867 (AccessibilityUIElement::ariaFlowToElementAtIndex):
27868 (AccessibilityUIElement::ariaControlsElementAtIndex):
27869 (AccessibilityUIElement::selectedRowAtIndex):
27870 (AccessibilityUIElement::rowAtIndex):
27871 (AccessibilityUIElement::disclosedByRow):
27872 (AccessibilityUIElement::selectedChildAtIndex const):
27874 2018-09-11 Wenson Hsieh <wenson_hsieh@apple.com>
27876 FontManagerTests.ChangeFontColorWithColorPanel fails on macOS Sierra
27877 https://bugs.webkit.org/show_bug.cgi?id=189382
27879 Reviewed by Ryosuke Niwa.
27881 Fix the test by specifying colors in RGB colorspace.
27883 * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
27884 (TestWebKitAPI::TEST):
27886 2018-09-11 Fujii Hironori <Hironori.Fujii@sony.com>
27888 [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
27889 https://bugs.webkit.org/show_bug.cgi?id=189496
27891 Reviewed by Alex Christensen.
27893 * ImageDiff/cairo/PlatformImageCairo.cpp:
27894 (ImageDiff::PlatformImage::createFromStdin): Removed unnecessary ReadContext struct.
27895 (ImageDiff::PlatformImage::writeAsPNGToStdout): Use '%lu' format type specifier for unsigned long.
27897 2018-09-07 Dean Jackson <dino@apple.com>
27899 Add and expose Internal features from WebKit
27900 https://bugs.webkit.org/show_bug.cgi?id=189442
27901 <rdar://problem/44243404>
27903 Reviewed by Simon Fraser.
27905 Update MiniBrowser to expose an Internal feature menu.
27907 * MiniBrowser/mac/AppDelegate.m:
27908 (defaultConfiguration):
27909 * MiniBrowser/mac/SettingsController.m:
27910 (-[SettingsController _populateMenu]):
27911 (-[SettingsController validateMenuItem:]):
27912 (-[SettingsController toggleExperimentalFeature:]):
27913 (-[SettingsController toggleInternalDebugFeature:]):
27915 2018-09-11 Wenson Hsieh <wenson_hsieh@apple.com>
27917 [macOS] [WK2] Support changing foreground colors via color panel
27918 https://bugs.webkit.org/show_bug.cgi?id=189382
27919 <rdar://problem/44227311>
27921 Reviewed by Ryosuke Niwa.
27923 Add an API test that uses NSColorPanel to change the color of selected text, and also apply typing styles when
27924 the selection is collapsed. The test also exercises switching between opaque colors (alpha = 1) and transparent
27925 colors, as well as making different parts of a word different colors.
27927 * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
27928 (-[TestWKWebView collapseToEnd]):
27929 (webViewForFontManagerTesting):
27930 (TestWebKitAPI::TEST):
27931 * TestWebKitAPI/cocoa/TestWKWebView.h:
27933 == Rolled over to ChangeLog-2018-09-11 ==