1 2017-03-23 Carlos Alberto Lopez Perez <clopez@igalia.com>
3 buildbot: Fix mixing of tabs and spaces after r214172
4 https://bugs.webkit.org/show_bug.cgi?id=169793
8 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
9 (RunWebKitTests.evaluateCommand):
11 2017-03-22 Andy Estes <aestes@apple.com>
13 [Cocoa] Add an option to exclude overflow when snapshotting a WKWebProcessPlugInNodeHandle
14 https://bugs.webkit.org/show_bug.cgi?id=169991
15 <rdar://problem/30141083>
17 Reviewed by Tim Horton.
19 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20 * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm: Added.
21 (-[RenderedImageWithOptionsObject didRenderImageWithSize:]):
23 * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm: Added.
24 (-[RenderedImageWithOptionsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
25 (-[RenderedImageWithOptionsPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
26 * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h: Added.
27 * TestWebKitAPI/Tests/WebKit2Cocoa/rendered-image-excluding-overflow.html: Added.
29 2017-03-22 Matt Rajca <mrajca@apple.com>
31 Only run volume-related autoplay policy tests on Mac.
32 https://bugs.webkit.org/show_bug.cgi?id=169969
34 Reviewed by Alex Christensen.
36 iOS does not support volume changes to media elements so these tests are timing out.
38 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
41 2017-03-22 Carlos Alberto Lopez Perez <clopez@igalia.com>
43 [Linux] determineArchitecture is not cross-compile aware
44 https://bugs.webkit.org/show_bug.cgi?id=169886
46 Reviewed by Michael Catanzaro.
48 Try to detect the target architecture name from the GCC triplet
51 The aarch64 architecture is renamed to arm64 (this is coherent with
52 the rest of the perl tooling that consults the architecture determined
53 in determineArchitecture(), the check for this arch is always done
56 * Scripts/webkitdirs.pm: Remove the isARM() function: its dead code
57 and not cross-build aware.
58 (determineArchitecture): When crossbuilding, try to detect the target
59 architecture name from the GCC triplet.
60 Remove also the fallback option to run the arch command, because this
61 command doesn't print the expected on Mac/BSD, and on Linux is the
62 same than uname -m. See https://bugs.webkit.org/show_bug.cgi?id=152958#c6
63 (isCrossCompilation): Some cross-compilers (buildroot one for example)
64 don't define the --host option. Add another option to detect that
65 we are cross-building by building a dummy program and checking if
68 2017-03-22 Carlos Garcia Campos <cgarcia@igalia.com>
70 [GTK] Several WPT tests are failing since they were added in the last update in r213882
71 https://bugs.webkit.org/show_bug.cgi?id=169915
73 Reviewed by Michael Catanzaro.
75 Add libsoup patch to not fail loads when there's no empty line after the headers in responses with no body.
77 * gtk/jhbuild.modules:
78 * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Added.
80 2017-03-20 Matt Rajca <mrajca@apple.com>
82 Loosen audio playback restrictions when the volume is 0.
83 https://bugs.webkit.org/show_bug.cgi?id=169897
85 Reviewed by Eric Carlson.
87 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
88 * TestWebKitAPI/Tests/WebKit2/autoplay-zero-volume-check.html: Added.
89 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
92 2017-03-21 Aakash Jain <aakash_jain@apple.com>
94 EWS fails to parse_bug_id_from_attachment_page after bugzilla upgrade
95 https://bugs.webkit.org/show_bug.cgi?id=169937
96 <rdar://problem/31181859>
98 Reviewed by Alexey Proskuryakov.
100 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
101 (Bugzilla._parse_bug_id_from_attachment_page): Since rel tag is no longer present, parsing the bug id from bug_title.
102 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fixed unit test.
104 2017-03-21 Aakash Jain <aakash_jain@apple.com>
106 ews should indicate in logs when it fails to parse_bug_id_from_attachment_page
107 https://bugs.webkit.org/show_bug.cgi?id=169927
109 Reviewed by Alexey Proskuryakov.
111 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
112 (Bugzilla._parse_bug_id_from_attachment_page): Added log statement.
114 2017-03-20 Simon Fraser <simon.fraser@apple.com>
116 Add a system trace point for memory warning handling
117 https://bugs.webkit.org/show_bug.cgi?id=169893
119 Reviewed by Zalan Bujtas.
121 Describe the new trace points.
123 * Tracing/SystemTracePoints.plist:
125 2017-03-20 Alex Christensen <achristensen@webkit.org>
127 WebPageProxy DecidePolicyForNavigationAction and DecidePolicyForResponseSync should be Delayed reply messages
128 https://bugs.webkit.org/show_bug.cgi?id=167183
129 <rdar://problem/30203539>
131 Reviewed by Andy Estes.
133 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
134 (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
136 2017-03-20 Jonathan Bedard <jbedard@apple.com>
138 webkitpy: Work around simctl launch returning dead processes
139 https://bugs.webkit.org/show_bug.cgi?id=169878
141 Reviewed by Daniel Bates.
143 simctl launch will sometimes give the PID of a process which has just been terminated.
144 To work around this, we will always check if the returned PID is of a process which is
147 * Scripts/webkitpy/port/simulator_process.py:
148 (SimulatorProcess.Popen.__init__): Accept device argument.
149 (SimulatorProcess.Popen.poll): Call device.poll().
150 (SimulatorProcess._start): Pass device into Popen object.
151 * Scripts/webkitpy/xcode/device.py:
152 (Device.poll): Added.
153 * Scripts/webkitpy/xcode/simulated_device.py:
154 (SimulatedDevice.install_app): Change attempts to timeout.
155 (SimulatedDevice.launch_app): Check that the process being returned is active, use a
156 timeout instead of attempts.
158 (SimulatedDevice.poll): Added.
160 2017-03-20 Jonathan Bedard <jbedard@apple.com>
162 buildbot: run-webkit-tests should display test failures and run exceptions differently
163 https://bugs.webkit.org/show_bug.cgi?id=169793
164 <rdar://problem/30987863>
166 Reviewed by Alexey Proskuryakov.
168 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
169 (RunWebKitTests.evaluateCommand): Return EXCEPTION when run-webkit-tests returns with a code of 254.
171 2017-03-17 Michael Saboff <msaboff@apple.com>
173 Use USE_INTERNAL_SDK to compute ENABLE_FAST_JIT_PERMISSIONS instead of HAVE_INTERNAL_SDK
174 https://bugs.webkit.org/show_bug.cgi?id=169817
176 Reviewed by Filip Pizlo.
178 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
180 2017-03-16 Simon Fraser <simon.fraser@apple.com>
182 Improve the system tracing points
183 https://bugs.webkit.org/show_bug.cgi?id=169790
185 Reviewed by Zalan Bujtas.
187 Use a more cohesive set of system trace points that give a good overview of what
188 WebKit is doing. Added points for resource loading, render tree building, sync messages
189 to the web process, async image decode, WASM and fetching cookies.
191 * Tracing/SystemTracePoints.plist:
193 2017-03-16 Youenn Fablet <youenn@apple.com>
195 Wrap legacy WebRTC API in runtime flag
196 https://bugs.webkit.org/show_bug.cgi?id=169646
198 Reviewed by Alex Christensen.
200 * DumpRenderTree/mac/DumpRenderTree.mm:
201 (enableExperimentalFeatures):
202 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
203 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
204 (WTR::InjectedBundle::beginTesting):
205 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
206 (WTR::TestRunner::setWebRTCLegacyAPIEnabled):
207 * WebKitTestRunner/InjectedBundle/TestRunner.h:
209 2017-03-16 Brady Eidson <beidson@apple.com>
211 Update the WKHTTPCookieStore API to be simpler and add observers.
212 <rdar://problem/31096000> and https://bugs.webkit.org/show_bug.cgi?id=169776
214 Reviewed by Alex Christensen.
216 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
217 * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm.
218 (-[CookieObserver cookiesDidChangeInCookieStore:]):
219 (TEST): Also test delete and observers.
221 2017-03-16 Kocsen Chung <kocsen_chung@apple.com>
223 Fix quotes around --pretty format git flag.
224 https://bugs.webkit.org/show_bug.cgi?id=169712
226 Reviewed by Ryosuke Niwa.
228 Remove double quotes from command list element '--pretty="format:%ct"' since it will cause
229 subprocess to not work as expected.
230 Additionally, take advantage of `git -C` flag.
232 * Scripts/webkitpy/common/checkout/scm/git.py:
233 (Git.native_revision):
234 Take advantage of `git -C` flag.
235 (Git.timestamp_of_native_revision):
236 Take advantage of `git -C` flag and remove double quotes from git formatter.
237 We know this works from `committer_email_for_revision()` function.
239 2017-03-16 Alex Christensen <achristensen@webkit.org>
241 Clean up WKContentExtension API
242 https://bugs.webkit.org/show_bug.cgi?id=169772
244 Reviewed by Geoffrey Garen.
246 * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
248 (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
250 2017-03-16 Jonathan Bedard <jbedard@apple.com>
252 webktpy: Fix device regular expression for parsing simctl output
253 https://bugs.webkit.org/show_bug.cgi?id=169757
255 Reviewed by Alex Christensen.
257 If a device is unavailable, the changes in r213164 mean that the
258 name of the device will consume the UDID and return the state as
259 the device UDID and the availability string as the device state.
261 * Scripts/webkitpy/xcode/simulator.py:
262 (Simulator): Make UDID regular expression more strict.
263 * Scripts/webkitpy/xcode/simulator_unittest.py: Test an unavailable device.
265 2017-03-15 Tim Horton <timothy_horton@apple.com>
267 Null deref under callAfterNextPresentationUpdate
268 https://bugs.webkit.org/show_bug.cgi?id=169710
269 <rdar://problem/30987863>
271 Reviewed by Simon Fraser.
273 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
274 * TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm: Added.
277 2017-03-15 Chris Dumez <cdumez@apple.com>
279 Document state (e.g. form data) is lost after a tab is terminated in the background for power reasons
280 https://bugs.webkit.org/show_bug.cgi?id=169635
281 <rdar://problem/31046729>
283 Reviewed by Andreas Kling.
285 Add API test coverage.
287 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
288 * TestWebKitAPI/Tests/WebKit2/mac/RestoreStateAfterTermination.mm: Added.
289 (TestWebKitAPI::runJavaScriptAlert):
290 (TestWebKitAPI::didFinishLoad):
291 (TestWebKitAPI::didCrash):
292 (TestWebKitAPI::TEST):
293 * TestWebKitAPI/Tests/WebKit2/simple-form.html:
295 2017-03-15 Alex Christensen <achristensen@webkit.org>
297 Compiled content extensions should include the JSON source
298 https://bugs.webkit.org/show_bug.cgi?id=169643
300 Reviewed by Geoffrey Garen.
302 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
303 * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
306 2017-03-15 Kocsen Chung <kocsen_chung@apple.com>
308 Use git's -C flag when possible in VCSUtils.pm
309 https://bugs.webkit.org/show_bug.cgi?id=169003
311 Reviewed by Sam Weinig.
313 Use the git -C flag where appropriate to perform the
314 operation on a target directory and avoid unnecessary logic
315 to `cd` in and out of the target directory.
317 * Scripts/VCSUtils.pm:
320 (svnRevisionForDirectory):
322 For all four subroutines, use git's -C flag and strip `cd` logic.
324 2017-03-14 Aakash Jain <aakash_jain@apple.com>
326 start-queue-mac.sh should create logs directory if it doesn't exist
327 https://bugs.webkit.org/show_bug.cgi?id=169634
329 Reviewed by Alexey Proskuryakov.
331 * EWSTools/start-queue-mac.sh: Creating logs directory if it doesn't exist.
333 2017-03-14 Andy Estes <aestes@apple.com>
335 [iOS] -[WKWebView _dataForDisplayedPDF] returns nil when called before an encrypted PDF has been unlocked
336 https://bugs.webkit.org/show_bug.cgi?id=169653
337 <rdar://problem/24137675>
339 Reviewed by Tim Horton.
341 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
342 * TestWebKitAPI/Tests/WebKit2/encrypted.pdf: Added.
343 * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFView.mm: Added.
347 2017-03-14 Brady Eidson <beidson@apple.com>
349 Rename WKHTTPCookieStorage to WKHTTPCookieStore.
350 https://bugs.webkit.org/show_bug.cgi?id=169630
352 Reviewed by Tim Horton.
354 * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm:
357 2017-03-14 Jonathan Bedard <jbedard@apple.com>
359 webkitpy: Efficient app installation for device testing
360 https://bugs.webkit.org/show_bug.cgi?id=169054
361 <rdar://problem/30790207>
363 Reviewed by Daniel Bates.
365 We should only install an app on a device once, not every time the app is run.
366 Move app installation to setup.
368 * Scripts/webkitpy/port/ios.py:
369 (IOSPort.setup_test_run): Install app to device.
370 * Scripts/webkitpy/port/simulator_process.py:
371 (SimulatorProcess.__init__): Remove app installation.
373 2017-03-14 Fujii Hironori <Hironori.Fujii@sony.com>
375 Nwtr ignores ImageDiff's errors for ref tests
376 https://bugs.webkit.org/show_bug.cgi?id=168033
378 Reviewed by Alexey Proskuryakov.
380 Nwtr checks ImageDiff's errors only for pixel tests, but for ref
381 tests. Those errors of ref tests also should be checked.
383 In the current implementation of expected mismatch ref tests,
384 diff_image was called if the image hashes match. This is useless
385 because two images are ensured identical in that case. Calling
386 image_hash is considered unnecessary for expected mismatch ref
387 tests. Do not call diff_image for them.
389 As the result, check the error only for expected match ref tests.
391 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
392 (SingleTestRunner._compare_image): Rename a variable 'err_str' to 'error_string'.
393 (SingleTestRunner._compare_output_with_reference): Do not call
394 diff_image for expected mismatch ref tests. Check the error and
395 marked the test failed for expected match ref tests.
397 2017-03-14 Brady Eidson <beidson@apple.com>
399 REGRESSION (r213877): WebKit2.CookieManager fails.
400 https://bugs.webkit.org/show_bug.cgi?id=169581
402 Reviewed by Tim Horton.
404 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Reenable the test.
406 2017-03-14 Wenson Hsieh <wenson_hsieh@apple.com>
408 [WK2] Data interaction tests occasionally hit assertions in debug builds
409 https://bugs.webkit.org/show_bug.cgi?id=169002
410 <rdar://problem/30994806>
412 Reviewed by Tim Horton.
414 Reenables and refactors data interaction tests.
416 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
417 * TestWebKitAPI/ios/DataInteractionSimulator.h:
418 * TestWebKitAPI/ios/DataInteractionSimulator.mm:
419 (-[DataInteractionSimulator _resetSimulatedState]):
420 (-[DataInteractionSimulator runFrom:to:]):
421 (-[DataInteractionSimulator _advanceProgress]):
423 2017-03-13 Brady Eidson <beidson@apple.com>
425 REGRESSION (r213877): WebKit2.CookieManager fails.
426 https://bugs.webkit.org/show_bug.cgi?id=169581
430 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Skip for now until I can fix.
432 2017-03-14 Yusuke Suzuki <utatane.tea@gmail.com>
434 [WTF] Clean up RunLoop and WorkQueue with Seconds and Function
435 https://bugs.webkit.org/show_bug.cgi?id=169537
437 Reviewed by Carlos Garcia Campos.
439 * TestWebKitAPI/Tests/WTF/Time.cpp:
440 (TestWebKitAPI::TEST):
442 2017-03-13 Brady Eidson <beidson@apple.com>
444 WKWebView provides no access to cookies.
445 https://bugs.webkit.org/show_bug.cgi?id=140191
447 Reviewed by Tim Horton.
449 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
451 2017-03-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
453 [GTK] install-dependencies needs to install Perl CGI modules on Debian based distros
454 https://bugs.webkit.org/show_bug.cgi?id=169563
456 Reviewed by Michael Catanzaro.
458 * gtk/install-dependencies:
460 2017-03-13 Devin Rousso <webkit@devinrousso.com>
462 Unreviewed, fix accidental comma.
464 * Scripts/webkitpy/common/config/contributors.json:
466 2017-03-13 Devin Rousso <webkit@devinrousso.com>
468 Unreviewed, change my email.
470 * Scripts/webkitpy/common/config/contributors.json:
472 2017-03-13 Anders Carlsson <andersca@apple.com>
476 * MiniBrowser/mac/AppDelegate.m:
477 (-[BrowserAppDelegate openDocument:]):
478 * MiniBrowser/mac/ExtensionManagerWindowController.m:
479 (-[ExtensionManagerWindowController add:]):
480 * MiniBrowser/mac/WK2BrowserWindowController.m:
481 (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
483 2017-03-13 Martin Robinson <mrobinson@igalia.com>
485 Remove my email from some of the watchlists
486 https://bugs.webkit.org/show_bug.cgi?id=169541
488 Reviewed by Manuel Rego Casasnovas.
490 * Scripts/webkitpy/common/config/watchlist: Remove my name from some lists.
492 2017-03-13 Yusuke Suzuki <utatane.tea@gmail.com>
494 [WTF] Clean up RunLoop and WorkQueue with Seconds and Function
495 https://bugs.webkit.org/show_bug.cgi?id=169537
497 Reviewed by Sam Weinig.
499 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
500 (TestWebKitAPI::TEST):
502 2017-03-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
504 [GTK] Remove dead code from previous autotools build in build-jsc
505 https://bugs.webkit.org/show_bug.cgi?id=169555
507 Reviewed by Carlos Garcia Campos.
512 2017-03-13 Carlos Garcia Campos <cgarcia@igalia.com>
514 MiniBrowser: a tab closed from javascript always closes the window
515 https://bugs.webkit.org/show_bug.cgi?id=169415
517 Reviewed by Michael Catanzaro.
519 When I implemented tabs support in MiniBrowser I forgot about web view close. We connect to the signal (only for
520 the active tab) and close the window. That worked when we didn't have tabs, but now we should close the tab, or
521 the window if it's the last tab.
523 * MiniBrowser/gtk/BrowserWindow.c:
524 (webViewClose): Destroy the window if therte's only one tab, otherwise search for the tab corresponding to the web
526 (browserWindowSwitchTab): Re-connect to close signal, we want to handle close on all tabs.
528 2017-03-11 Said Abou-Hallawa <sabouhallawa@apple.com>
530 Enable async image decoding for large images
531 https://bugs.webkit.org/show_bug.cgi?id=165039
533 Reviewed by Simon Fraser.
535 Disable LargeImageAsyncDecoding for DRT/WTR.
537 * DumpRenderTree/mac/DumpRenderTree.mm:
538 (resetWebPreferencesToConsistentValues):
539 * WebKitTestRunner/TestController.cpp:
540 (WTR::TestController::resetPreferencesToConsistentValues):
542 2017-03-10 Alex Christensen <achristensen@webkit.org>
544 Fix watch and tv builds after r213294
545 https://bugs.webkit.org/show_bug.cgi?id=169508
547 Reviewed by Dan Bernstein.
549 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
551 2017-03-10 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
553 checkpatchrelevance: Exception message is printed twice due to ScriptError handler
554 https://bugs.webkit.org/show_bug.cgi?id=169496
558 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add --quiet flag to expected logs.
560 2017-03-10 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
562 checkpatchrelevance: Exception message is printed twice due to ScriptError handler
563 https://bugs.webkit.org/show_bug.cgi?id=169496
565 Reviewed by Alexey Proskuryakov.
567 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
568 (PatchAnalysisTask._check_patch_relevance): Pass --quiet flag.
569 * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
570 (CheckPatchRelevance.options): Accept options.quiet to prevent duplicate output to stdout.
572 2017-03-10 Ryan Haddad <ryanhaddad@apple.com>
574 Add new EWS queues to bot watcher's dashboard.
575 https://bugs.webkit.org/show_bug.cgi?id=169485
577 Reviewed by Alexey Proskuryakov.
579 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
580 (BubbleQueueServer): Add Bindings and JSC EWS queues.
582 2017-03-10 Andy Estes <aestes@apple.com>
584 Skip an API test that isn't expected to pass on iOS 10.
586 * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
588 2017-03-10 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
590 Add bindings-ews to queue status server
591 https://bugs.webkit.org/show_bug.cgi?id=169307
593 Reviewed by Alexey Proskuryakov.
595 * QueueStatusServer/config/queues.py: Add "bindings-ews" to the list of ewses.
597 2017-03-10 Andy Estes <aestes@apple.com>
599 [QuickLook] Add WKNavigationDelegate SPI to notify when a password is requested
600 https://bugs.webkit.org/show_bug.cgi?id=169459
601 <rdar://problem/30621913>
603 Reviewed by Alex Christensen.
605 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
606 * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
609 (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
611 2017-03-10 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
613 Add support for Bindings EWS
614 https://bugs.webkit.org/show_bug.cgi?id=169308
616 Reviewed by Alexey Proskuryakov.
618 * Scripts/webkitpy/common/config/ews.json: Add bindings-ews. Can test without building; should_build = False.
619 * Scripts/webkitpy/common/net/bindingstestresults.py:
620 (BindingsTestResults.__init__): Removed 'errors'.
621 (BindingsTestResults.results_from_string): Ditto.
622 (BindingsTestResults.is_subset): Ditto.
623 (BindingsTestResults.equals): Ditto.
624 (BindingsTestResults.all_passed): Ditto.
625 (BindingsTestResults.failing_tests): Ditto.
626 * Scripts/webkitpy/common/net/bindingstestresults_unittest.py:
627 (BindingsTestResultsTest.test_results_from_string): Removed 'errors'.
628 (BindingsTestResultsTest.test_results_from_string_success): Removed 'errors'.
629 * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
630 (EarlyWarningSystemTask.__init__): Add should_build parameter.
631 (EarlyWarningSystemTask.run): Check should_build before calling self._build().
632 * Scripts/webkitpy/tool/bot/retrylogic_unittest.py: Renamed from Tools/Scripts/webkitpy/tool/bot/jscews_unittest.py.
633 (MockBindingsEarlyWarningSystem): Based of MockJSCEarlyWarningSystem. Mocked so we can provide test results.
634 (MockBindingsEarlyWarningSystem.__init__): Sets attributes.
635 (MockBindingsEarlyWarningSystem.test_results): Returns test results provided by us, instead of JSON output.
636 (BindingsEarlyWarningSystemTest): Class to test retry logic in below situations.
637 (BindingsEarlyWarningSystemTest._results_indicate_all_passed): False if None or or has failures, else True.
638 (BindingsEarlyWarningSystemTest._create_task):
639 (BindingsEarlyWarningSystemTest.test_success_case): Clean patch on clean tree.
640 (BindingsEarlyWarningSystemTest.test_test_failure): Red patch on clean tree.
641 (BindingsEarlyWarningSystemTest.test_fix): Clean patch on red tree.
642 (BindingsEarlyWarningSystemTest.test_ineffective_patch): Red patch on red tree.
643 (BindingsEarlyWarningSystemTest.test_partially_effective_patch): Red patch on redder tree.
644 (BindingsEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Red patch on red tree.
645 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
646 (PatchAnalysisTask._build_and_test_without_patch): Don't build if should_build is False (eg. on Bindings EWS).
647 (PatchAnalysisTask._retry_bindings_tests): Retry logic for Bindings tests.
648 (PatchAnalysisTask._test_patch): If tests failed on Bindings EWS, and call _retry_bindings_tests.
649 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
650 (AbstractEarlyWarningSystem.begin_work_queue): Use BindingsTestResultsReader on Bindings EWS.
651 (AbstractEarlyWarningSystem._create_task): Pass should_build argument.
652 (AbstractEarlyWarningSystem.load_ews_classes): Add should_build argument (True by default).
653 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
654 (TestBindingsEWS): Bindings EWS class, derived from AbstractEarlyWarningSystem.
655 (AbstractEarlyWarningSystemTest.test_failing_bindings_tests_message): Unit test message posted to Bugzilla.
656 (EarlyWarningSystemTest._default_expected_logs): Not building on all ewses anymore; make build line optional.
657 (EarlyWarningSystemTest.test_ews_name): Add bindings-ews.
658 * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
659 (CheckPatchRelevance): Add bindings paths.
660 (CheckPatchRelevance._changes_are_relevant): Cleaner way to check if we should perform this step.
661 * Scripts/webkitpy/tool/steps/steps_unittest.py: Add unit tests for Bindings EWS patch relevance.
662 (test_patch_relevant_bindings): Test for patch relevant to bindings.
663 (test_patch_not_relevant_bindings): Test for patch not relevant to bindings.
665 2017-03-09 Simon Fraser <simon.fraser@apple.com>
667 [iOS WK2] Layer content blurry with nested perspective and transforms
668 https://bugs.webkit.org/show_bug.cgi?id=169457
669 rdar://problem/29879484
671 Reviewed by Tim Horton.
673 We set rasterizationScale on CALayers to the same values as contentsScale, to
674 avoid blurry layers when CA rasterizes, which often happens with nested perspective
677 However, in UI-side compositing, if the page is not zoomed, we never applied the
678 rasterizationScale in the UI process. This happened because the PlatformCALayerRemote
679 constructor set m_properties.contentsScale, but did not set the dirty bit that
680 triggers the application of contentsScale and rasterizationScale in RemoteLayerTreePropertyApplier.
681 The fix is to set this dirty bit.
683 The rest of the changes are for testing. Internals now exposes layerIDForElement()
684 for returns an internal (non-stable-across-loads) layerID, which can be passed
685 to UIScriptController.propertiesOfLayerWithID() in the UI process, which inspects
686 the built layer (UIView) hierarchy. propertiesOfLayerWithID() returns a dictionary
687 which the test can dump as JSON, or pull values out of.
689 A few #pragma once cleanups also.
691 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
692 (WTR::UIScriptController::propertiesOfLayerWithID):
693 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
694 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
695 (WTR::UIScriptController::propertiesOfLayerWithID):
696 * TestRunnerShared/UIScriptContext/UIScriptController.h:
697 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
698 (WTR::UIScriptController::propertiesOfLayerWithID):
700 2017-03-10 Commit Queue <commit-queue@webkit.org>
702 Unreviewed, rolling out r213618.
703 https://bugs.webkit.org/show_bug.cgi?id=169475
705 Suspect this is the cause of a large memory regression
706 (Requested by jonlee_ on #webkit).
710 "Enable async image decoding for large images"
711 https://bugs.webkit.org/show_bug.cgi?id=165039
712 http://trac.webkit.org/changeset/213618
714 2017-03-09 Brian Nicholson <bnicholson@mozilla.com> and Alex Christensen <achristensen@webkit.org>
716 Expose public APIs for content filters
717 https://bugs.webkit.org/show_bug.cgi?id=150479
719 Reviewed by Brady Eidson and Geoff Garen.
721 Keep the existing tests to verify that I made the wrapper classes for the old SPI work correctly.
722 Add new identical tests for the new API are added with the new names.
723 We should keep both until we migrate from and remove the old SPI.
724 Enum error code values and strings have changed, but the API is source compatible.
726 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
727 * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm.
728 (WKUserContentExtensionStoreTest::SetUp):
731 (_WKUserContentExtensionStoreTest::SetUp): Deleted.
732 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
735 2017-03-09 Daniel Bates <dabates@apple.com>
737 Attempt to fix the WebKit2 test bots following <https://trac.webkit.org/changeset/213676>
738 (https://bugs.webkit.org/show_bug.cgi?id=169364)
740 Create new WebView with Credential Management enabled when the enableCredentialManagement
741 WebKitTestRunner option is specified.
743 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
744 (WTR::PlatformWebView::viewSupportsOptions):
745 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
746 (WTR::PlatformWebView::viewSupportsOptions):
748 2017-03-09 John Wilander <wilander@apple.com>
750 Resource Load Statistics: Remove statistics data as part of full website data removal
751 https://bugs.webkit.org/show_bug.cgi?id=169448
753 Reviewed by Alex Christensen.
755 This patch adds infrastructure for the new TestRunner function
756 statisticsClearInMemoryAndPersistentStore().
758 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
759 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
760 (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
761 * WebKitTestRunner/InjectedBundle/TestRunner.h:
762 * WebKitTestRunner/TestController.cpp:
763 (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
764 * WebKitTestRunner/TestController.h:
765 * WebKitTestRunner/TestInvocation.cpp:
766 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
768 2017-03-09 Dean Jackson <dino@apple.com>
770 WebGPU: Backend - Buffers
771 https://bugs.webkit.org/show_bug.cgi?id=169451
772 <rdar://problem/30959168>
774 Reviewed by Tim Horton.
776 Test for GPUBuffer object.
778 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
779 * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm: Added.
780 (TestWebKitAPI::TEST_F):
781 * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
782 * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
784 2017-03-09 Daniel Bates <dabates@apple.com>
786 Guard Credential Management implementation behind a runtime enabled feature flag
787 https://bugs.webkit.org/show_bug.cgi?id=169364
788 <rdar://problem/30957425>
790 Reviewed by Brent Fulgham.
792 Add a new test option header, enableCredentialManagement, to DumpRenderTree/WebKitTestRunner
793 to enable Credential Management.
795 * DumpRenderTree/TestOptions.h:
796 * DumpRenderTree/TestOptions.mm:
797 (TestOptions::TestOptions):
798 * DumpRenderTree/mac/DumpRenderTree.mm:
799 (enableExperimentalFeatures):
800 (setWebPreferencesForTestOptions):
801 * WebKitTestRunner/TestController.cpp:
802 (WTR::TestController::resetPreferencesToConsistentValues):
803 (WTR::updateTestOptionsFromTestHeader):
804 * WebKitTestRunner/TestOptions.h:
806 2017-03-09 Anders Carlsson <andersca@apple.com>
808 Add delegate support to WebCore
809 https://bugs.webkit.org/show_bug.cgi?id=169427
810 Part of rdar://problem/28880714.
812 Reviewed by Geoffrey Garen.
814 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
816 2017-03-09 Alex Christensen <achristensen@webkit.org>
818 [Content Extensions] Introduce if-top-url and unless-top-url
819 https://bugs.webkit.org/show_bug.cgi?id=169433
821 Reviewed by Brady Eidson.
823 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
824 (TestWebKitAPI::TEST_F):
825 Add tests for new functionality and new failure types.
827 2017-03-09 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
829 JSC EWS repeat the log message thrice about patch not being relevant
830 https://bugs.webkit.org/show_bug.cgi?id=169330
832 Reviewed by Chris Dumez.
834 * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
835 (CheckPatchRelevance.run): Change log level to 'debug' to reduce stdout traffic.
837 2017-03-08 Matt Rajca <mrajca@apple.com>
839 Let clients control autoplay quirks with website policies.
840 https://bugs.webkit.org/show_bug.cgi?id=169390
842 Reviewed by Wenson Hsieh.
844 * TestWebKitAPI/Tests/WebKit2/autoplay-check.html:
845 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
846 (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
849 2017-03-09 Devin Rousso <dcrousso+webkit@gmail.com>
851 Unreviewed, change my status to be a WebKit reviewer
853 * Scripts/webkitpy/common/config/contributors.json:
855 2017-03-09 Jonathan Bedard <jbedard@apple.com>
857 Standardize device/simulator naming conventions
858 https://bugs.webkit.org/show_bug.cgi?id=169083
859 <rdar://problem/30810466>
861 Reviewed by Alexey Proskuryakov.
863 * Scripts/build-webkit: Document --ios-device and --simulator options.
864 * Scripts/package-root:
866 * Scripts/run-api-tests: Document --simulator option.
867 * Scripts/webkitdirs.pm:
868 (argumentsForConfiguration): Use --ios-device by default rather than --device.
869 (determineXcodeSDK): Parse --ios-device and --simulator options.
870 * Scripts/webkitpy/common/config/ews.json: Change port name from ios to ios-device.
871 * Scripts/webkitpy/common/config/ports.py: Ditto.
872 (DeprecatedPort.port):
873 (IOSPort): Change port name from ios to ios-device.
874 * Scripts/webkitpy/port/factory.py:
875 (platform_options): Add --simulator option.
876 (PortFactory): Update comment.
877 * Scripts/webkitpy/port/ios_device.py:
878 (IOSDevicePort): Change port name from ios to ios-device.
879 (IOSDevicePort.operating_system): Ditto.
881 2017-03-09 Jonathan Bedard <jbedard@apple.com>
883 webkitpy: Add unit test to prevent breakage of EWS
884 https://bugs.webkit.org/show_bug.cgi?id=169385
886 Reviewed by Alexey Proskuryakov.
888 Prevent <http://trac.webkit.org/changeset/213545> from happening in the future.
890 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
891 (test_ews_name): Added.
893 2017-03-08 Dean Jackson <dino@apple.com>
895 WebGPU: Backend - Library and Functions
896 https://bugs.webkit.org/show_bug.cgi?id=169371
897 <rdar://problem/30928792>
899 Reviewed by Tim Horton.
901 Add tests for GPULibrary and GPUFunction.
903 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
904 * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:
905 (TestWebKitAPI::TEST_F):
906 (TestWebKitAPI::TEST): Deleted.
907 * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
908 (TestWebKitAPI::TEST_F):
909 * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
910 (TestWebKitAPI::TEST_F):
911 * TestWebKitAPI/Tests/WebCore/mac/GPUTest.h: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
912 (TestWebKitAPI::GPU::librarySourceCode):
914 2017-03-08 Filip Pizlo <fpizlo@apple.com>
916 WTF should make it super easy to do ARM concurrency tricks
917 https://bugs.webkit.org/show_bug.cgi?id=169300
919 Reviewed by Mark Lam.
921 This vastly simplifies the consume API. The new API is thoroughly tested by being used
922 in the GC's guts. I think that unit tests are a pain to maintain, so we shouldn't have
923 them unless we are legitimately worried about coverage. We're not in this case.
925 * TestWebKitAPI/CMakeLists.txt:
926 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
927 * TestWebKitAPI/Tests/WTF/Consume.cpp: Removed.
929 2017-03-08 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
931 Fix error/warning duplication in JSON bindings results
932 https://bugs.webkit.org/show_bug.cgi?id=169305
934 Reviewed by Alexey Proskuryakov.
936 The distinction between failures and errors is not meaningful, since all errors will also be failures.
937 As a result, we only need to keep track of failures.
939 * Scripts/webkitpy/bindings/main.py:
940 (BindingsTests.__init__): Remove errors.
941 (BindingsTests.detect_changes): Remove errors.
942 (BindingsTests.main): Remove errors.
944 2017-03-08 Yusuke Suzuki <utatane.tea@gmail.com>
946 [JSC] Add helpers to run Six Speed to run-jsc-benchmarks
947 https://bugs.webkit.org/show_bug.cgi?id=169351
949 Reviewed by Saam Barati.
951 This patch adds an ability to run six-speed microbenchmarks
952 from run-jsc-benchmarks by specifying six-speed directory in
953 arewefastyet repository.
955 While it is a collection of microbenchmarks, it is useful
956 to ensure that our ES6 optimization covers major use cases.
957 For the macrobenchmark, we already have ARES-6.
959 * Scripts/run-jsc-benchmarks:
961 2017-03-08 Sam Weinig <sam@webkit.org>
963 import-w3c-tests doesn't work with svn repositories.
964 https://bugs.webkit.org/show_bug.cgi?id=169190
966 Reviewed by Tim Horton.
968 The script assumed you had WebKit checked-out as a git repository, but
969 there was no reason for that.
971 * Scripts/webkitpy/common/checkout/scm/git.py:
973 Add a class method to clone a repository which does not require
974 an existing checkout.
978 Add methods needed for test_downloader.py, so it doesn't have to use
979 the internal _run_git
981 * Scripts/webkitpy/w3c/test_downloader.py:
982 (TestDownloader.checkout_test_repository):
983 Switch to using Git.clone(), which doesn't require an existing git
984 directory, and then also adopt non private methods to fetch/checkout.
986 2017-03-08 John Wilander <wilander@apple.com>
988 Resource Load Statistics: Communicate to the network process which domains to partition
989 https://bugs.webkit.org/show_bug.cgi?id=169322
990 <rdar://problem/30768921>
992 Reviewed by Alex Christensen.
994 These changes add support for two new TestRunner functions:
995 - setCookieStoragePartitioningEnabled()
996 - statisticsFireShouldPartitionCookiesHandler()
998 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
999 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1000 (WTR::TestRunner::setCookieStoragePartitioningEnabled):
1001 (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandler):
1002 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1003 * WebKitTestRunner/TestController.cpp:
1004 (WTR::TestController::statisticsFireShouldPartitionCookiesHandler):
1005 * WebKitTestRunner/TestController.h:
1006 * WebKitTestRunner/TestInvocation.cpp:
1007 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1009 2017-03-08 Said Abou-Hallawa <sabouhallawa@apple.com>
1011 Enable async image decoding for large images
1012 https://bugs.webkit.org/show_bug.cgi?id=165039
1014 Reviewed by Simon Fraser.
1016 Disable LargeImageAsyncDecoding for DRT/WTR.
1018 * DumpRenderTree/mac/DumpRenderTree.mm:
1019 (resetWebPreferencesToConsistentValues):
1020 * WebKitTestRunner/TestController.cpp:
1021 (WTR::TestController::resetPreferencesToConsistentValues):
1023 2017-03-08 Matt Rajca <mrajca@apple.com>
1025 Add support for updating autoplay policies after a page has been loaded.
1026 https://bugs.webkit.org/show_bug.cgi?id=169360
1028 Reviewed by Alex Christensen.
1030 * TestWebKitAPI/Tests/WebKit2/autoplay-check.html:
1031 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1034 2017-03-08 Jonathan Bedard <jbedard@apple.com>
1036 Unreviewed, rolling out r213545.
1038 iOS EWS broken by this change
1042 "Standardize device/simulator naming conventions"
1043 https://bugs.webkit.org/show_bug.cgi?id=169083
1044 http://trac.webkit.org/changeset/213545
1046 2017-03-07 Kocsen Chung <kocsen_chung@apple.com>
1048 Perf and layout test results should report using correct scm revision.
1049 https://bugs.webkit.org/show_bug.cgi?id=169171
1051 Reviewed by Ryosuke Niwa.
1053 For accurate record keeping, perf test and layout test results should
1054 report using the native scm revision as an identifier.
1055 To do so we introduce a new scm functions:
1056 `native_revision()` and `timestamp_of_native_revision()`.
1057 The former is responsible for returning a git hash if scm.git or an
1058 svn revision if scm.svn. The latter is responsible for retrieving the correct timestamp.
1059 We also add the corresponding tests and a helper function `_most_recent_log_for_revision`.
1061 * Scripts/webkitpy/common/checkout/scm/scm.py:
1063 Drive-by indentation fix to adhere to WebKit style conventions.
1065 Remove superfluous comment.
1066 (SCM.native_revision):
1067 Add new abstract function `native_revision` and make it a `_subclass_must_implement()`
1068 as we want to closely mimic `svn_revision()` function due to their similar behavior.
1069 (SCM.timestamp_of_native_revision):
1070 Add new abstract function `timestamp_of_native_revision` to closely mimic `timestamp_of_revision`.
1072 * Scripts/webkitpy/common/checkout/scm/git.py:
1073 (Git._most_recent_log_for_revision):
1074 New helper function similar to `_most_recent_log_matching` that is git hash friendly.
1075 (Git.native_revision):
1076 Implement new function `native_revision()`. Get the native_revision by running:
1078 `git log -1 --pretty=format:%H`
1080 and thus returning the latest git hash (in long format).
1081 (Git.timestamp_of_native_revision):
1082 Since perftestrunner and layout_test.controllers.manager use the new native_revision
1083 function, we create a new native_revision timestamp retriever.
1084 You will notice this uses a far more simplified way to retrieve UTC strict-ISO timestamp
1085 than its non-native counterpart: `timestamp_of_revision()`.
1086 * Scripts/webkitpy/common/checkout/scm/svn.py:
1087 (SVN.native_revision):
1088 Implement native_revision for SVN: simply return self.svn_revision()
1089 (SVN.timestamp_of_native_revision):
1090 Implement timestamp_of_native_revision for SVN: simply return self.timestamp_of_revision()
1092 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1093 (test_native_revision):
1094 [SVN] Confirm that svn_revision == native_revision. And that native_revision returns 5.
1095 Use '.' as the path parameter instead of svn_checkout_path to avoid violating pylint/E1101
1096 and since we are guaranteed by test setUp to be in the correct SVN dir.
1097 (GitTest.test_native_revision):
1098 [Git] Confirm that `git rev-parse HEAD` is equal to newly implemented native_revision().
1099 (GitSVNTest.test_native_revision):
1100 [Git] Confirm that `git rev-parse HEAD` is equal to newly implemented native_revision().
1101 (test_timestamp_of_native_revision):
1102 Test new function `timestamp_of_native_revision`. Very similar fashion to
1103 `test_timestamp_of_revision`.
1105 * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1106 (MockSCM.native_revision):
1107 Add MockSCM.native_revision to behave like svn.py (default).
1108 (MockSCM.test_native_revision):
1109 Add MockSCM.test_native_revision to behave like its non-native counterpart.
1111 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1112 (Manager.upload_results):
1113 When iterating through a list of projects, make sure we use the project's new native revision.
1114 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1115 (_generate_results_dict):
1116 As per the FIXME in manager.py, we have duplicate code in perftestsrunner.py.
1117 So make the same exact change here.
1119 2017-03-07 Tim Horton <timothy_horton@apple.com>
1121 Fix the TestWebKitAPI build
1123 Rubber-stamped by Anders Carlsson.
1125 * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1126 (TestWebKitAPI::TEST_F):
1127 Fix a new warning about default argument promotion and va_start by
1128 making this a enum class.
1130 2017-03-07 Dean Jackson <dino@apple.com>
1132 Some platforms won't be able to create a GPUDevice
1133 https://bugs.webkit.org/show_bug.cgi?id=169314
1134 <rdar://problems/30907521>
1136 Reviewed by Jon Lee.
1138 Protect for the case where the hardware doesn't support Metal.
1140 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1141 * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:
1142 (TestWebKitAPI::TEST):
1144 2017-03-07 Maureen Daum <mdaum@apple.com>
1146 Correctly check for an empty database file.
1147 <rdar://problem/30542242> Removing Website Data not working (WebSQL directories being left behind)
1148 https://bugs.webkit.org/show_bug.cgi?id=169256
1150 Reviewed by Brady Eidson.
1152 Add a test for DatabaseTracker::deleteDatabaseFileIfEmpty that verifies
1153 that if we pass in an empty file it actually gets deleted.
1155 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1156 Add TestWebKitAPI/Tests/WebCore/DatabaseTrackerTest.cpp.
1157 * TestWebKitAPI/Tests/WebCore/DatabaseTrackerTest.cpp: Added.
1158 (TestWebKitAPI::TEST):
1160 2017-03-07 Alex Christensen <achristensen@webkit.org>
1162 [URLParser] Fix file URLs that are just file:// and a Windows drive letter
1163 https://bugs.webkit.org/show_bug.cgi?id=169242
1165 Reviewed by Tim Horton.
1167 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1168 (TestWebKitAPI::TEST_F):
1170 2017-03-07 Jonathan Bedard <jbedard@apple.com>
1172 Standardize device/simulator naming conventions
1173 https://bugs.webkit.org/show_bug.cgi?id=169083
1174 <rdar://problem/30810466>
1176 Reviewed by Alexey Proskuryakov.
1178 * Scripts/build-webkit: Document --ios-device and --simulator options.
1179 * Scripts/package-root:
1181 * Scripts/run-api-tests: Document --simulator option.
1182 * Scripts/webkitdirs.pm:
1183 (argumentsForConfiguration): Use --ios-device by default rather than --device.
1184 (determineXcodeSDK): Parse --ios-device and --simulator options.
1185 * Scripts/webkitpy/common/config/ews.json: Change port name from ios to ios-device.
1186 * Scripts/webkitpy/common/config/ports.py: Ditto.
1187 (DeprecatedPort.port):
1188 (IOSPort): Change port name from ios to ios-device.
1189 * Scripts/webkitpy/port/factory.py:
1190 (platform_options): Add --simulator option.
1191 (PortFactory): Update comment.
1192 * Scripts/webkitpy/port/ios_device.py:
1193 (IOSDevicePort): Change port name from ios to ios-device.
1194 (IOSDevicePort.operating_system): Ditto.
1196 2017-03-07 Dean Jackson <dino@apple.com>
1198 Add GPUDevice implementation and WebGPULayer
1199 https://bugs.webkit.org/show_bug.cgi?id=169219
1200 <rdar://problem/30879048>
1202 Reviewed by Sam Weinig.
1204 Test for WebCore's GPUDevice class.
1206 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1207 * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm: Added.
1208 (TestWebKitAPI::TEST):
1210 2017-03-07 Alex Christensen <achristensen@webkit.org>
1212 [Content Extensions] Rename "Domain" to "Condition" where appropriate
1213 https://bugs.webkit.org/show_bug.cgi?id=169297
1215 Reviewed by Brady Eidson.
1217 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1218 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1219 (TestWebKitAPI::TEST_F):
1221 2017-03-07 Jonathan Bedard <jbedard@apple.com>
1223 webkitpy: Refactor setup_test_run for IOSPort and IOSSimulator
1224 https://bugs.webkit.org/show_bug.cgi?id=169220
1225 <rdar://problem/30879645>
1227 Reviewed by Daniel Bates.
1229 Provide more specific port setup functions for iOS ports to allow more sharing of common code.
1231 * Scripts/webkitpy/port/ios.py:
1233 (IOSPort._create_devices): Added.
1234 (IOSPort.setup_test_run): Shared iOS device setup code.
1235 * Scripts/webkitpy/port/ios_simulator.py:
1236 (IOSSimulatorPort._create_devices): Renamed from setup_test_run.
1237 (IOSSimulatorPort.setup_test_run): Renamed as _create_devices.
1239 2017-03-07 Anders Carlsson <andersca@apple.com>
1241 Rewrite the DRT Pasteboard implementation to use UTIs and WTF types
1242 https://bugs.webkit.org/show_bug.cgi?id=169289
1244 Reviewed by Tim Horton.
1246 * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
1247 (-[LocalPasteboard initWithName:]):
1248 (-[LocalPasteboard name]):
1249 (-[LocalPasteboard declareTypes:owner:]):
1252 (-[LocalPasteboard addTypes:owner:]):
1253 (-[LocalPasteboard changeCount]):
1254 (-[LocalPasteboard types]):
1255 (-[LocalPasteboard availableTypeFromArray:]):
1256 (-[LocalPasteboard setData:forType:]):
1257 (-[LocalPasteboard dataForType:]):
1258 (-[LocalPasteboard writeObjects:]):
1259 (-[LocalPasteboard dealloc]): Deleted.
1261 2017-03-07 Myles C. Maxfield <mmaxfield@apple.com>
1263 Add David Jonathan Ross to contributors.json
1264 https://bugs.webkit.org/show_bug.cgi?id=169265
1268 David Jonathan Ross very kindly offered to create and contribute his Boxis font in r211060,
1269 which is used for testing font variations.
1271 * Scripts/webkitpy/common/config/contributors.json:
1273 2017-03-07 Youenn Fablet <youennf@gmail.com>
1275 W3C importer should be able to update the import expectations file
1276 https://bugs.webkit.org/show_bug.cgi?id=168037
1278 Reviewed by Ryosuke Niwa.
1280 Changing import expectations from an array to a map.
1281 Marking all test paths as import and updating import expectations file accordingly.
1283 * Scripts/webkitpy/w3c/test_downloader.py:
1284 (TestDownloader.__init__):
1285 (TestDownloader._init_paths_from_expectations):
1287 (TestDownloader.update_import_expectations):
1288 * Scripts/webkitpy/w3c/test_importer.py:
1289 (TestImporter.do_import):
1290 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1292 2017-03-07 Philip Rogers <pdr@google.com>
1294 Add pdr to the rendering watchlist
1295 https://bugs.webkit.org/show_bug.cgi?id=167298
1297 Reviewed by Andreas Kling.
1299 * Scripts/webkitpy/common/config/contributors.json: Switch to pdr+autocc@chromium.org
1300 * Scripts/webkitpy/common/config/watchlist: Add pdr to the rendering watchlist.
1302 2017-03-07 Mario Sanchez Prada <mario@webkit.org>
1304 Unreviewed. Removed myself from the Accessibility watch list
1306 * Scripts/webkitpy/common/config/watchlist: Removed myself.
1308 2017-03-06 Fujii Hironori <Hironori.Fujii@sony.com>
1310 Add Fujii Hironori to contributor's list
1311 https://bugs.webkit.org/show_bug.cgi?id=169261
1313 Reviewed by Yusuke Suzuki.
1315 Add myself to the contributor's lists so that my e-mail autocompletes for CC
1317 * Scripts/webkitpy/common/config/contributors.json:
1319 2017-03-06 Carlos Alberto Lopez Perez <clopez@igalia.com>
1321 [GTK] Mark WTF_Lock.ContendedLongSection and WTF_WordLock.ContendedLongSection as slow.
1323 Unreviewed test gardening.
1325 The ContendedShortSection version of this tests were already marked as slow.
1326 And the ContendedLongSection version takes more or less the same time to run.
1327 They cause time outs on the bot sometimes.
1329 * Scripts/run-gtk-tests:
1332 2017-03-06 Michael Saboff <msaboff@apple.com>
1334 Take advantage of fast permissions switching of JIT memory for devices that support it
1335 https://bugs.webkit.org/show_bug.cgi?id=169155
1337 Reviewed by Saam Barati.
1339 Updated the Xcode config files to match what is in the JavaScriptCore ones.
1341 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1343 2017-03-06 Lucas Forschler <lforschler@apple.com>
1345 https://bugs.webkit.org/show_bug.cgi?id=169234
1346 torchmobile.com.cn is no longer a registered domain. These email addresses will bounce, so clean them up.
1348 Reviewed by Alexey Proskuryakov.
1350 * Scripts/webkitpy/common/config/contributors.json:
1352 2017-03-03 Matt Rajca <mrajca@apple.com>
1354 Media: notify clients when the user never plays a media element that was prevented from auto-playing
1355 https://bugs.webkit.org/show_bug.cgi?id=169150
1357 Reviewed by Alex Christensen.
1359 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1362 2017-03-06 Alex Christensen <achristensen@webkit.org>
1364 Fix URLs relative to file URLs with paths beginning with Windows drive letters
1365 https://bugs.webkit.org/show_bug.cgi?id=169178
1367 Reviewed by Tim Horton.
1369 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1370 (TestWebKitAPI::TEST_F):
1372 2017-03-06 Myles C. Maxfield <mmaxfield@apple.com>
1374 Expand font-weight and font-stretch to take any number
1375 https://bugs.webkit.org/show_bug.cgi?id=168889
1377 Reviewed by Simon Fraser.
1379 Migrate off old enum types.
1381 * TestWebKitAPI/Tests/WebCore/FontCache.cpp:
1382 (TestWebKitAPI::createPlatformFont):
1383 (TestWebKitAPI::compareFonts):
1384 (TestWebKitAPI::TEST_F):
1386 2017-03-06 Yusuke Suzuki <utatane.tea@gmail.com>
1388 [GTK][JSCOnly] Enable WebAssembly on Linux environment
1389 https://bugs.webkit.org/show_bug.cgi?id=164032
1391 Reviewed by Michael Catanzaro.
1393 * Scripts/run-jsc-stress-tests:
1396 * Scripts/webkitperl/FeatureList.pm:
1399 2017-03-04 Lucas Forschler <lforschler@apple.com>
1401 Test commit against svn.webkit.org after SHA-1 cleanup.
1405 2017-03-03 Dean Jackson <dino@apple.com>
1407 Add WebGPU compile flag and experimental feature flag
1408 https://bugs.webkit.org/show_bug.cgi?id=169161
1409 <rdar://problem/30846689>
1411 Reviewed by Tim Horton.
1413 Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
1414 and an InternalSetting.
1416 * DumpRenderTree/mac/DumpRenderTree.mm:
1417 (enableExperimentalFeatures):
1418 (resetWebPreferencesToConsistentValues):
1419 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1420 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1421 (WTR::InjectedBundle::beginTesting):
1422 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1423 (WTR::TestRunner::setWebGL2Enabled):
1424 (WTR::TestRunner::setWebGPUEnabled):
1425 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1427 2017-03-03 Dean Jackson <dino@apple.com>
1429 Add a script to synchronize FeatureDefines.xcconfig files
1430 https://bugs.webkit.org/show_bug.cgi?id=169151
1431 <rdar://problem/30841856>
1433 Reviewed by Simon Fraser.
1435 I got sick of manually copying the FeatureDefines.xcconfig
1436 files, so I added a script to do it. As long as you
1437 run this after you've edited one, it will take the most
1438 recently updated and copy it to all the others.
1440 * Scripts/sync-feature-defines: Added.
1441 * Scripts/webkitpy/style/checkers/featuredefines.py:
1442 (FeatureDefinesChecker.check): Export the list of files,
1443 and give a suggestion to use the sync script.
1445 2017-03-03 Alex Christensen <achristensen@webkit.org>
1447 [URLParser] Fix file: as a relative file URL
1448 https://bugs.webkit.org/show_bug.cgi?id=169122
1450 Reviewed by Tim Horton.
1452 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1453 (TestWebKitAPI::TEST_F):
1455 2017-03-02 Myles C. Maxfield <mmaxfield@apple.com>
1457 Migrate font-stretch to use fixed-point values
1458 https://bugs.webkit.org/show_bug.cgi?id=169107
1460 Reviewed by Dean Jackson.
1462 Update to new types.
1464 * TestWebKitAPI/Tests/WebCore/FontCache.cpp:
1465 (TestWebKitAPI::createPlatformFont):
1467 2017-03-02 Brady Eidson <beidson@apple.com>
1469 Update WKWebsiteDatastoreConfiguration SPI.
1470 https://bugs.webkit.org/show_bug.cgi?id=169102
1472 Reviewed by Tim Horton.
1474 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1475 (-[WebsiteDataStoreCustomPathsMessageHandler userContentController:didReceiveScriptMessage:]):
1478 2017-03-02 Jer Noble <jer.noble@apple.com>
1480 Sufficently large timeValue and timeScale arguments to MediaTime will cause wrapping in toTimeScale().
1481 https://bugs.webkit.org/show_bug.cgi?id=169098
1483 Reviewed by Keith Miller.
1485 * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1486 (TestWebKitAPI::TEST):
1488 2017-03-02 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
1490 Add ability to read bindings test results
1491 https://bugs.webkit.org/show_bug.cgi?id=169063
1493 Reviewed by Alexey Proskuryakov.
1495 * Scripts/webkitpy/common/net/bindingstestresults.py: Added.
1496 (BindingsTestResults): Conforms to the AbstractTestResults interface.
1497 (BindingsTestResults.__init__): Constructor.
1498 (BindingsTestResults.results_from_string): Generates BindingsTestResults object from JSON string.
1499 (BindingsTestResults.is_subset): Compare failing tests in two BindingsTestResults objects.
1500 (BindingsTestResults.equals): Checks if two BindingsTestResults objects contain the same failing test names.
1501 (BindingsTestResults.all_passed): Return True if all bindings tests passed.
1502 (BindingsTestResults.failing_tests): Returns a list of failing tests.
1503 (BindingsTestResults.did_exceed_test_failure_limit): Always returns False, exists to conform to the interface.
1504 * Scripts/webkitpy/common/net/bindingstestresults_unittest.py: Added.
1505 (BindingsTestResultsTest): Class to test BindingsTestResults.
1506 (BindingsTestResultsTest.test_results_from_string): Unit tests string -> BindingsTestResults conversion.
1507 (BindingsTestResultsTest.test_results_from_string_success): Ditto, for success cases.
1508 * Scripts/webkitpy/tool/bot/bindingstestresultsreader.py: Added.
1509 (BindingsTestResultsReader): Conforms to the AbstractTestResultsReader interface.
1510 (BindingsTestResultsReader.results): Reads the results file and returns a BindingsTestResults object.
1512 2017-03-02 Aakash Jain <aakash_jain@apple.com>
1514 Move stringMatchesWildcardString from WebKit2 to WebCore
1515 https://bugs.webkit.org/show_bug.cgi?id=169065
1517 Reviewed by Alexey Proskuryakov.
1519 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Moved StringUtilities.mm
1520 * TestWebKitAPI/Tests/WebCore/StringUtilities.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm.
1521 (TestWebKitAPI::TEST):
1522 * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Removed.
1524 2017-02-28 Matt Rajca <mrajca@apple.com>
1526 Media: send "did interfere with playback" events when the user pauses an autoplaying element
1527 https://bugs.webkit.org/show_bug.cgi?id=169006
1529 Reviewed by Alex Christensen.
1531 * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html:
1532 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1535 2017-03-02 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
1537 Refactor test results classes in webkitpy to enable faster EWS iteration
1538 https://bugs.webkit.org/show_bug.cgi?id=169053
1540 Reviewed by Alexey Proskuryakov.
1542 * Scripts/webkitpy/common/net/abstracttestresults.py:
1543 (AbstractTestResults): Import json for parse_json_string().
1544 (AbstractTestResults.parse_json_string): Abstracted out from JSCTestResults.results_from_string().
1545 * Scripts/webkitpy/common/net/abstracttestresults_unittest.py: Added.
1546 (AbstractTestResultsTest): Class that tests AbstractTestResults.
1547 (AbstractTestResultsTest.test_parse_json_string_invalid_inputs): Move unit tests from JSCTestResultsTest.
1548 (AbstractTestResultsTest.test_parse_json_string_valid_input): Add a unit test for a success case.
1549 * Scripts/webkitpy/common/net/jsctestresults.py:
1550 (JSCTestResults.results_from_string): Call parse_json_string because it was abstracted out.
1551 * Scripts/webkitpy/common/net/jsctestresults_unittest.py:
1552 (JSCTestResultsTest.test_results_from_string): Remove JSON parsing unit tests, because they were moved.
1553 * Scripts/webkitpy/tool/bot/abstracttestresultsreader.py: Added.
1554 (AbstractTestResultsReader): Generic TestResultsReader with functions common to jsc, bindings etc.
1555 (AbstractTestResultsReader.__init__): Moved from JSCTestResultsReader.__init__().
1556 (AbstractTestResultsReader._read_file_contents): Moved from JSCTestResultsReader._read_file_contents().
1557 (AbstractTestResultsReader.results): Stub.
1558 * Scripts/webkitpy/tool/bot/jsctestresultsreader.py:
1559 (JSCTestResultsReader): Now inherits from AbstractTestResultsReader.
1560 (JSCTestResultsReader.__init__): Deleted.
1561 (JSCTestResultsReader._read_file_contents): Deleted.
1562 * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1563 (LayoutTestResultsReader): Now inherits from AbstractTestResultsReader.
1565 2017-03-02 Alex Christensen <achristensen@webkit.org>
1567 Continue enabling WebRTC
1568 https://bugs.webkit.org/show_bug.cgi?id=169056
1570 Reviewed by Jon Lee.
1572 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1574 2017-03-02 Ryan Haddad <ryanhaddad@apple.com>
1576 Unreviewed, rolling out r213281.
1578 This change caused API test WebKit2.UserMediaBasic to time
1583 "[MediaStream] UIClient may not be notified of capture state
1584 change when leaving a page"
1585 https://bugs.webkit.org/show_bug.cgi?id=169014
1586 http://trac.webkit.org/changeset/213281
1588 2017-03-02 Tomas Popela <tpopela@redhat.com>
1590 [WK2] Keyboard menu key should show context menu
1591 https://bugs.webkit.org/show_bug.cgi?id=72099
1593 Show the context menu when the GtkWidget::popup-menu signal is
1594 emitted. This signal is triggered by pressing a key (usually
1595 the Menu key or the Shift + F10 shortcut) or it could be emitted on
1598 Reviewed by Carlos Garcia Campos.
1600 * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1601 (testContextMenuDefaultMenu):
1602 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1603 (WebViewTest::emitPopupMenuSignal):
1604 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1606 2017-03-01 Wenson Hsieh <wenson_hsieh@apple.com>
1608 Replace -[WKWebView adjustedDataInteractionItemProviders:] with a UI delegate method
1609 https://bugs.webkit.org/show_bug.cgi?id=169013
1611 Reviewed by Dan Bernstein.
1613 Adjusts TestWebKitAPI for changes in WebKit2. See Source/WebKit2/ChangeLog for more details.
1615 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1616 (TestWebKitAPI::TEST):
1617 (-[CustomItemProviderWebView _adjustedDataInteractionItemProviders:]): Deleted.
1618 * TestWebKitAPI/ios/DataInteractionSimulator.h:
1619 * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1620 (-[DataInteractionSimulator initWithWebView:]):
1621 (-[DataInteractionSimulator dealloc]):
1622 (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]):
1624 2017-03-01 Per Arne Vollan <pvollan@apple.com>
1626 [Win] DRT should not dispatch messages after test is done.
1627 https://bugs.webkit.org/show_bug.cgi?id=169026
1629 Reviewed by Brent Fulgham.
1631 Exiting the message loop with PostQuitMessage will leave room for
1632 a few messages to be dispatched after the test is done.
1634 * DumpRenderTree/win/DumpRenderTree.cpp:
1638 2017-03-01 Myles C. Maxfield <mmaxfield@apple.com>
1640 Implement font-stretch for installed fonts
1641 https://bugs.webkit.org/show_bug.cgi?id=168888
1643 Reviewed by Darin Adler and Dave Hyatt.
1645 Update TestWebKitAPI tests to test font-stretch too.
1647 * TestWebKitAPI/Tests/WebCore/FontCache.cpp:
1648 (TestWebKitAPI::createPlatformFont):
1649 (TestWebKitAPI::compareFonts):
1650 (TestWebKitAPI::TEST_F):
1652 2017-03-01 Alex Christensen <achristensen@webkit.org>
1654 Unreviewed, rolling out r213259.
1656 Broke an internal build
1660 "Continue enabling WebRTC"
1661 https://bugs.webkit.org/show_bug.cgi?id=169056
1662 http://trac.webkit.org/changeset/213259
1664 2017-03-01 Alex Christensen <achristensen@webkit.org>
1666 Continue enabling WebRTC
1667 https://bugs.webkit.org/show_bug.cgi?id=169056
1669 Reviewed by Jon Lee.
1671 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1673 2017-02-28 Matt Rajca <mrajca@apple.com>
1675 Media: notify clients when autoplayed media is muted
1676 https://bugs.webkit.org/show_bug.cgi?id=168987
1678 Reviewed by Alex Christensen.
1680 * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html:
1681 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1684 2017-03-01 Brady Eidson <beidson@apple.com>
1686 Add SPI to create WebsiteDataStore objects pointing to custom paths.
1687 https://bugs.webkit.org/show_bug.cgi?id=169044
1689 Reviewed by Tim Horton.
1691 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1693 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html: Added.
1694 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm: Added.
1695 (-[WebsiteDataStoreCustomPathsMessageHandler userContentController:didReceiveScriptMessage:]):
1699 2017-03-01 Simon Fraser <simon.fraser@apple.com>
1701 Add a way to watch the CSSProperties.json file, and add me and Dan Bates to watch it.
1703 * Scripts/webkitpy/common/config/watchlist:
1705 2017-03-01 Jonathan Bedard <jbedard@apple.com>
1707 webkitpy: Move some device management from iOSSimulatorPort to iOSPort class
1708 https://bugs.webkit.org/show_bug.cgi?id=168681
1710 Reviewed by Daniel Bates.
1712 This patch moves high-level device management into iOSPort and adds a new iOSDevicePort class
1713 which inherits from iOSPort. Additionally, this change renames device_id_for_worker_number to
1714 device_for_worker_number and manages devices by object instead of by UDID.
1716 * Scripts/webkitpy/port/factory.py:
1717 (PortFactory): Correct import path for IOSSimulatorPort and IOSDevicePort.
1718 * Scripts/webkitpy/port/ios.py:
1719 (IOSPort.__init__): Define variables shared between iOS ports.
1720 (IOSPort.driver_cmd_line_for_logging): From IOSSimulatorPort.
1721 (IOSPort.driver_name): From IOSSimulatorPort.
1722 (IOSPort.using_multiple_devices): Check if this port supports multiple devices.
1723 (IOSPort._testing_device): Map worker number to device.
1724 (IOSPort.device_for_worker_number): Return _testing_device() or _current_device based on using_multiple_devices.
1725 (IOSSimulatorPort): Moved to ios_simulator.py
1726 * Scripts/webkitpy/port/ios_device.py: Added.
1727 (IOSDevicePort): Moved functionality from IOSPort.
1728 (IOSDevicePort.determine_full_port_name): Moved from IOSPort.
1729 (IOSDevicePort._build_driver_flags): Ditto.
1730 (IOSDevicePort.operating_system): Ditto.
1731 * Scripts/webkitpy/port/ios_simulator.py: Added.
1732 (IOSSimulatorPort): Moved from ios.py.
1733 (IOSSimulatorPort.__init__): Init parent class, setup device map.
1734 (IOSSimulatorPort._create_simulators): Use object over unbound methods.
1735 (IOSSimulatorPort.setup_test_run): Ditto.
1736 (IOSSimulatorPort.using_multiple_devices): True if we are managing the simulators.
1737 (IOSSimulatorPort._create_device): Use object over unbound methods.
1738 (IOSSimulatorPort._remove_device): Ditto.
1739 (IOSSimulatorPort.driver_name): Moved to parent class.
1740 (IOSSimulatorPort.driver_cmd_line_for_logging): Ditto.
1741 (IOSSimulatorPort.child_processes): Ditto.
1742 (IOSSimulatorPort._testing_device): Ditto.
1743 (IOSSimulatorPort.device_id_for_worker_number): Renamed as device_for_worker_number.
1744 (SimulatorProcess.__init__): Call find_device_by_udid, device_id_for_worker_number has been removed.
1745 * Scripts/webkitpy/xcode/simulator.py:
1746 (Simulator): Make _managed_devices public.
1747 (Simulator.create_device): Ditto.
1748 (Simulator.remove_device): Ditto.
1749 (Simulator.device_number): Ditto.
1751 2017-03-01 Alexey Proskuryakov <ap@apple.com>
1753 IndexedDB.IndexedDBMultiProcess is a flaky timeout
1754 https://bugs.webkit.org/show_bug.cgi?id=160780
1756 Reviewed by Brady Eidson.
1758 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Releasing the object
1759 once doesn't necessarily deallocate the object, there can be other references.
1760 We can use -[WKWebView _close] or -[WKWebView _killWebContentProcessAndResetState].
1761 The latter seems more appropriate, because "kill" is what the comment says.
1763 2017-02-28 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
1765 Add ability for webkitpy to run bindings tests
1766 https://bugs.webkit.org/show_bug.cgi?id=168979
1768 Reviewed by Alexey Proskuryakov.
1770 This allows the below command to run bindings tests with json output, and is a required part
1771 of adding an EWS for bindings tests. (Note: this won't build because --build is not passed).
1772 webkit-patch build-and-test --no-clean --no-update --test --non-interactive --group="bindings"
1774 * Scripts/webkitpy/port/base.py:
1775 (Port.bindings_results_directory): Return the directory to place JSON results for bindings tests.
1776 * Scripts/webkitpy/tool/steps/runtests.py:
1777 (RunTests.run): Checks if we should be running bindings tests.
1778 (RunTests._run_bindings_tests): Generates the command for bindings tests, and executes it.
1779 * Scripts/webkitpy/tool/steps/steps_unittest.py:
1780 (test_runtests_bindings): Unit test for the generated run-bindings-tests command.
1782 2017-02-28 Myles C. Maxfield <mmaxfield@apple.com>
1784 Test fix after r213163
1785 https://bugs.webkit.org/show_bug.cgi?id=168678
1789 Tests and builds are timing out because this file is gigantic.
1791 * TestWebKitAPI/Tests/WebCore/FontCache.cpp:
1792 (TestWebKitAPI::TEST_F):
1794 2017-02-28 Wenson Hsieh <wenson_hsieh@apple.com>
1796 Data interaction should support attachment elements
1797 https://bugs.webkit.org/show_bug.cgi?id=168916
1798 <rdar://problem/30664519>
1800 Reviewed by Ryosuke Niwa.
1802 Adds a new unit test verifying that a client injected bundle is able to augment UIItemProvider data vended to
1805 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1806 * TestWebKitAPI/Tests/WebKit2Cocoa/attachment-element.html: Added.
1807 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1808 (-[CustomItemProviderWebView _adjustedDataInteractionItemProviders:]):
1809 (TestWebKitAPI::TEST):
1811 2017-02-28 Chris Dumez <cdumez@apple.com>
1813 [iOS] Throttle requestAnimationFrame to 30fps in low power mode
1814 https://bugs.webkit.org/show_bug.cgi?id=168837
1815 <rdar://problem/30700929>
1817 Reviewed by Simon Fraser.
1819 Add unit test for -= operator on WTF::OptionSet.
1821 * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
1822 (TestWebKitAPI::TEST):
1824 2017-02-28 Jonathan Bedard <jbedard@apple.com>
1826 webkitpy: Regular expression for parsing simctl device information is wrong for iPad Pro
1827 https://bugs.webkit.org/show_bug.cgi?id=168394
1829 Reviewed by Daniel Bates.
1831 * Scripts/webkitpy/xcode/simulator.py:
1832 (Simulator): Allow for parenthesis in device name.
1833 * Scripts/webkitpy/xcode/simulator_unittest.py: Add iPad Pro to test.
1835 2017-02-28 Myles C. Maxfield <mmaxfield@apple.com>
1837 [macOS] Migrate off of CTFontCreateForCSS
1838 https://bugs.webkit.org/show_bug.cgi?id=168678
1840 Reviewed by David Hyatt.
1842 Exhaustively test the font matching algorithm on Sierra.
1844 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1845 * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Added.
1846 (TestWebKitAPI::FontCacheTest::SetUp):
1847 (TestWebKitAPI::createPlatformFont):
1848 (TestWebKitAPI::compareFonts):
1849 (TestWebKitAPI::TEST_F):
1851 2017-02-28 Basuke Suzuki <Basuke.Suzuki@am.sony.com>
1853 Windows build doesn't start build if the git branch is not master
1854 https://bugs.webkit.org/show_bug.cgi?id=168843
1856 Reviewed by Myles C. Maxfield.
1858 Use correct value for product base dir.
1860 * Scripts/build-webkit:
1862 2017-02-24 Matt Rajca <mrajca@apple.com>
1864 Media: notify clients when autoplayed media ends without being paused
1865 https://bugs.webkit.org/show_bug.cgi?id=168852
1867 Reviewed by Alex Christensen.
1869 * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html:
1870 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1873 2017-02-28 Jonathan Bedard <jbedard@apple.com>
1875 webkitpy: jsc-ews should run when Makefiles and build scripts are changed
1876 https://bugs.webkit.org/show_bug.cgi?id=168950
1878 Reviewed by Alexey Proskuryakov.
1880 * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1881 (CheckPatchRelevance): Add makefiles and build scripts to jsc_paths.
1883 2017-02-27 Alex Christensen <achristensen@webkit.org>
1885 Begin enabling WebRTC on 64-bit
1886 https://bugs.webkit.org/show_bug.cgi?id=168915
1888 Reviewed by Eric Carlson.
1890 * Scripts/build-webkit:
1891 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1893 2017-02-27 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
1895 Windows regression: webkitpy.tool.steps.steps_unittest.StepsTest.test_runtests_jsc[_debug]
1896 https://bugs.webkit.org/show_bug.cgi?id=168628
1898 Reviewed by Alexey Proskuryakov.
1900 * Scripts/webkitpy/tool/steps/runtests.py:
1901 (RunTests._run_javascriptcore_tests): Pass options to the Base instance.
1902 * Scripts/webkitpy/tool/steps/steps_unittest.py:
1903 (StepsTest._step_options): Add a new 'root' option that's passed through to the Base instance.
1904 (test_runtests_jsc): Not running webkit-build-directory anymore, and changed json output directory.
1905 (test_runtests_jsc_debug): Ditto
1907 2017-02-27 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
1909 Add machine-readable results for bindings tests
1910 https://bugs.webkit.org/show_bug.cgi?id=168626
1912 Reviewed by Alexey Proskuryakov.
1914 * Scripts/run-bindings-tests:
1915 (main): Add optional --json-output command-line parameter.
1916 * Scripts/webkitpy/bindings/main.py:
1917 (BindingsTests.__init__): Add variables to store machine-readable results.
1918 (BindingsTests.detect_changes): Store results in machine-readable form if applicable.
1919 (BindingsTests.main): Write data to JSON file if applicable.
1921 2017-02-27 Wenson Hsieh <wenson_hsieh@apple.com>
1923 Unreviewed, roll out r213065.
1925 We need these temporary fixes to keep the perf bots running.
1927 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1928 * TestWebKitAPI/ios/DataInteractionSimulator.h:
1929 * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1930 (-[DataInteractionSimulator _advanceProgress]):
1932 2017-02-27 Simon Fraser <simon.fraser@apple.com>
1934 Add specification and status metadata to CSSProperties.json, and validate it
1935 https://bugs.webkit.org/show_bug.cgi?id=168901
1937 Reviewed by Darin Adler.
1939 Enhance check-webkit-style to validate the status and spec data in CSSProperties.json.
1941 Current validation is basic type validation and some cross-referencing, but could be
1944 * Scripts/webkitpy/style/checkers/jsonchecker.py:
1945 (JSONCSSPropertiesChecker.check):
1946 (JSONCSSPropertiesChecker.check_category):
1947 (JSONCSSPropertiesChecker):
1948 (JSONCSSPropertiesChecker.check_categories):
1949 (JSONCSSPropertiesChecker.validate_url):
1950 (JSONCSSPropertiesChecker.validate_status_type):
1951 (JSONCSSPropertiesChecker.validate_comment):
1952 (JSONCSSPropertiesChecker.validate_status):
1953 (JSONCSSPropertiesChecker.validate_property_category):
1954 (JSONCSSPropertiesChecker.validate_property_specification):
1955 (JSONCSSPropertiesChecker.check_property):
1957 2017-02-27 Carlos Garcia Campos <cgarcia@igalia.com>
1959 Unreviewed. Fix two GTK+ unit tests failing after r213062.
1961 We were building wrong Content-Disposition headers that libsoup doesn't parse correctly.
1963 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1964 (addContentDispositionHTTPHeaderToResponse):
1965 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1968 2017-02-24 Jer Noble <jer.noble@apple.com>
1970 Add public method to MediaTime for doing timeScale conversion.
1971 https://bugs.webkit.org/show_bug.cgi?id=168860
1973 Reviewed by Eric Carlson.
1975 * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1976 (TestWebKitAPI::TEST):
1978 2017-02-26 Wenson Hsieh <wenson_hsieh@apple.com>
1980 Unreviewed, revert all temporary build fixes for data interaction
1982 Rolls out r212990, r212988 and r212984.
1984 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1985 * TestWebKitAPI/ios/DataInteractionSimulator.h:
1986 * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1987 (-[DataInteractionSimulator _advanceProgress]):
1989 2017-02-27 Alex Christensen <achristensen@webkit.org>
1991 [libwebrtc] Enable WebRTC in some Production Builds
1992 https://bugs.webkit.org/show_bug.cgi?id=168858
1994 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1996 2017-02-27 Andy Estes <aestes@apple.com>
1998 Add a way to test file input without relying on drag and drop
1999 https://bugs.webkit.org/show_bug.cgi?id=168848
2000 <rdar://problem/22258242>
2002 Reviewed by Tim Horton.
2004 Existing layout tests relied on drag and drop support in EventSender to configure a file
2005 input element for testing. This had several problems:
2007 1. WebKitTestRunner has no support for beginDragWithFiles(), and DumpRenderTree doesn't
2009 2. We have no test coverage for selecting files via the runOpenPanel UI delegate, leading to
2010 bugs like webkit.org/b/159686.
2012 Even if we fixed (1), we'd still have a test coverage gap due to (2), so this patch
2013 introduces a way for a test to specify the list of files that should be selected by the
2014 runOpenPanel UI delegate: TestRunner.setOpenPanelFiles(). It also creates versions of a
2015 number of existing file input tests using TestRunner.setOpenPanelFiles() instead of
2016 EventSender.beginDragWithFiles().
2018 * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
2019 (-[DumpRenderTreeBrowserView webView:runOpenPanelForFileButtonWithResultListener:configuration:]):
2020 Overrode to call the corresponding method on UIDelegate.
2021 * DumpRenderTree/TestRunner.cpp:
2022 (setOpenPanelFilesCallback): Added to call TestRunner::setOpenPanelFiles().
2023 (TestRunner::staticFunctions): Registered setOpenPanelFiles.
2024 (TestRunner::setOpenPanelFiles): Added. Converts the JavaScript array of file paths to a
2025 std::vector of std::strings.
2026 * DumpRenderTree/TestRunner.h:
2027 (TestRunner::openPanelFiles):
2028 * DumpRenderTree/mac/UIDelegate.mm:
2029 (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
2030 Added. Converts the array of file paths to an NSArray of NSURLs, resolving the file paths
2031 relative to the current test URL. Returns either the first item or all items depending on
2032 the value of allowMultipleFiles.
2033 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Defined setOpenPanelFiles.
2034 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2035 (WTR::TestRunner::setOpenPanelFiles): Added. Converts the JavaScript array of file paths to
2036 a WKArray of WKURLs, resolving the file paths relative to the current test URL, and sends
2037 the WKArray to the UI process with the "SetOpenPanelFileURLs" message.
2038 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2039 * WebKitTestRunner/TestController.cpp:
2040 (WTR::runOpenPanel): Calls the WKOpenPanelResultListener with either the first item or all
2041 items, depending on the value of WKOpenPanelParametersGetAllowsMultipleFiles().
2042 (WTR::TestController::resetStateToConsistentValues): Clear m_openPanelFileURLs.
2043 * WebKitTestRunner/TestController.h:
2044 (WTR::TestController::openPanelFileURLs):
2045 (WTR::TestController::setOpenPanelFileURLs):
2046 * WebKitTestRunner/TestInvocation.cpp:
2047 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Added code to handle the
2048 "SetOpenPanelFileURLs" message.
2050 2017-02-26 Wenson Hsieh <wenson_hsieh@apple.com>
2052 REGRESSION (r211312): Double-clicking a word selects it along with the space that follows it
2053 https://bugs.webkit.org/show_bug.cgi?id=168821
2054 <rdar://problem/30690431>
2056 Reviewed by Tim Horton.
2058 Adds the ability for TestWKWebView to send a sequence of clicks to its window, and uses this capability to
2059 verify that double clicking to select a word in a WKWebView on Mac selects just the word, and not a trailing
2060 space along with it.
2062 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2063 * TestWebKitAPI/Tests/WebKit2Cocoa/double-click-does-not-select-trailing-space.html: Added.
2064 * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm: Copied from Tools/TestWebKitAPI/cocoa/TestWKWebView.h.
2066 * TestWebKitAPI/cocoa/TestWKWebView.h:
2067 * TestWebKitAPI/cocoa/TestWKWebView.mm:
2068 (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
2069 (-[TestWKWebViewHostWindow _mouseUpAtPoint:clickCount:]):
2070 (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2071 (-[TestWKWebView mouseUpAtPoint:]):
2072 (-[TestWKWebView sendClicksAtPoint:numberOfClicks:]):
2073 (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]): Deleted.
2074 (-[TestWKWebViewHostWindow _mouseUpAtPoint:]): Deleted.
2076 2017-02-25 Simon Fraser <simon.fraser@apple.com>
2078 Make check-webkit-style do some basic validation for CSSProperties.json
2079 https://bugs.webkit.org/show_bug.cgi?id=168874
2081 Reviewed by Zalan Bujtas.
2083 Do checking of the keys and the value types.
2085 Print exceptions if they occur; previously, coding errors caused silent failure.
2087 * Scripts/webkitpy/style/checker.py:
2088 (CheckerDispatcher._create_checker):
2089 * Scripts/webkitpy/style/checkers/jsonchecker.py:
2090 (JSONFeaturesChecker.check):
2091 (JSONCSSPropertiesChecker):
2092 (JSONCSSPropertiesChecker.check):
2093 (JSONCSSPropertiesChecker.validate_comment):
2094 (JSONCSSPropertiesChecker.validate_type):
2095 (JSONCSSPropertiesChecker.validate_boolean):
2096 (JSONCSSPropertiesChecker.validate_string):
2097 (JSONCSSPropertiesChecker.validate_array):
2098 (JSONCSSPropertiesChecker.validate_codegen_properties):
2099 (JSONCSSPropertiesChecker.check_property):
2100 (JSONCSSPropertiesChecker.check_codegen_properties):
2102 2017-02-26 Chris Dumez <cdumez@apple.com>
2104 HitTestResult's linkSuggestedFilename should sanitize download attribute
2105 https://bugs.webkit.org/show_bug.cgi?id=168856
2106 <rdar://problem/30683109>
2108 Reviewed by Antti Koivisto.
2112 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2113 * TestWebKitAPI/Tests/WebKit2/link-with-download-attribute-with-slashes.html: Added.
2114 * TestWebKitAPI/Tests/WebKit2/mac/ContextMenuDownload.mm:
2115 (TestWebKitAPI::decideDestinationWithSuggestedFilenameContainingSlashes):
2116 (TestWebKitAPI::TEST):
2118 2017-02-24 Joseph Pecoraro <pecoraro@apple.com>
2120 [Resource Timing] Media elements initiated loads should set the initiatorType to their element name (video/audio)
2121 https://bugs.webkit.org/show_bug.cgi?id=168680
2123 Reviewed by Youenn Fablet.
2125 * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2126 (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2127 Include a dummy HTMLVideoElement.
2129 2017-02-24 Wenson Hsieh <wenson_hsieh@apple.com>
2131 Unreviewed, temporarily disable all data interaction tests.
2133 They will be reenabled once the bots are ready to build and run them.
2135 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2136 * TestWebKitAPI/ios/DataInteractionSimulator.h:
2137 * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2139 2017-02-24 Wenson Hsieh <wenson_hsieh@apple.com>
2141 Unreviewed, fix the internal build.
2143 * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2144 (-[DataInteractionSimulator _advanceProgress]):
2146 2017-02-24 Matt Rajca <mrajca@apple.com>
2148 Media: notify clients when autoplay is denied
2149 https://bugs.webkit.org/show_bug.cgi?id=168840
2151 Reviewed by Alex Christensen.
2153 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2154 (handleAutoplayEvent):
2155 (runUntilReceivesAutoplayEvent):
2158 2017-02-23 Matt Rajca <mrajca@apple.com>
2160 API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay is timing out
2161 https://bugs.webkit.org/show_bug.cgi?id=167466
2163 Reviewed by Alex Christensen.
2165 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2166 (TEST): Use the correct API version.
2168 2017-02-20 Wenson Hsieh <wenson_hsieh@apple.com>
2170 Refactor data interaction to use new WKDataInteraction SPI
2171 https://bugs.webkit.org/show_bug.cgi?id=168602
2172 Work towards <rdar://problem/30313681>
2174 Reviewed by Tim Horton.
2176 Update DataInteractionSimulator to simulate data interaction using updated SPI. See changes in WebKit2 for more details.
2178 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2179 (TestWebKitAPI::TEST):
2180 * TestWebKitAPI/ios/DataInteractionSimulator.h:
2181 * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2182 (-[DataInteractionSimulator _resetSimulatedState]):
2183 (-[DataInteractionSimulator runFrom:to:]):
2184 (-[DataInteractionSimulator _advanceProgress]):
2185 (-[DataInteractionSimulator _currentLocation]):
2186 (-[DataInteractionSimulator _finishDataInteraction]): Deleted.
2187 (-[DataInteractionSimulator webViewDidSendDataInteractionStartRequest:]): Deleted.
2188 (-[DataInteractionSimulator webView:didReceiveDataInteractionStartResponse:]): Deleted.
2190 2017-02-20 Wenson Hsieh <wenson_hsieh@apple.com>
2192 Remove the data interaction gesture recognizer
2193 https://bugs.webkit.org/show_bug.cgi?id=168600
2194 <rdar://problem/30313681>
2196 Reviewed by Anders Carlsson.
2198 Adjust TestWebKitAPI for changes in WebKit2.
2200 * TestWebKitAPI/ios/DataInteractionSimulator.h:
2201 * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2202 (-[DataInteractionSimulator initWithWebView:]):
2203 (-[DataInteractionSimulator runFrom:to:]):
2204 (-[DataInteractionSimulator _advanceProgress]):
2205 (-[DataInteractionSimulator _finishDataInteraction]):
2206 (-[MockLongPressGestureRecognizer initWithWindow:]): Deleted.
2207 (-[MockLongPressGestureRecognizer locationInView:]): Deleted.
2208 (-[MockLongPressGestureRecognizer state]): Deleted.
2209 (-[MockLongPressGestureRecognizer numberOfTouches]): Deleted.
2210 (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]): Deleted.
2211 (-[DataInteractionSimulator dataInteractionGestureRecognizer]): Deleted.
2212 (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]): Deleted.
2214 2017-02-24 John Wilander <wilander@apple.com>
2216 Resource Load Statistics: Add alternate classification method
2217 https://bugs.webkit.org/show_bug.cgi?id=168347
2218 <rdar://problem/30352793>
2219 <rdar://problem/30646710>
2220 <rdar://problem/30660708>
2222 Reviewed by Alex Christensen.
2224 Added three testRunner functions to facilitate layout tests:
2225 - setStatisticsSubframeUnderTopFrameOrigin()
2226 - setStatisticsSubresourceUnderTopFrameOrigin()
2227 - setStatisticsSubresourceUniqueRedirectTo()
2229 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2230 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2231 (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2232 (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2233 (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2234 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2235 * WebKitTestRunner/TestController.cpp:
2236 (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
2237 (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
2238 (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
2239 * WebKitTestRunner/TestController.h:
2240 * WebKitTestRunner/TestInvocation.cpp:
2241 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2243 2017-02-23 Joseph Pecoraro <pecoraro@apple.com>
2245 [Resource Timing] Add Experimental Feature Flag
2246 https://bugs.webkit.org/show_bug.cgi?id=167147
2248 Reviewed by Ryosuke Niwa.
2250 * DumpRenderTree/mac/DumpRenderTree.mm:
2251 (enableExperimentalFeatures):
2252 (resetWebPreferencesToConsistentValues):
2253 * DumpRenderTree/win/DumpRenderTree.cpp:
2254 (enableExperimentalFeatures):
2255 (resetWebPreferencesToConsistentValues):
2256 Put experimental flags in the experimental section.
2258 2017-02-23 Beth Dakin <bdakin@apple.com> + Dan Saunders <dasau@microsoft.com>
2260 No reliable way to get a snapshot of WKWebView (macOS)
2261 https://bugs.webkit.org/show_bug.cgi?id=161450
2263 <rdar://problem/23846039>
2265 Reviewed by Tim Horton.
2267 Test for WKWebView’s new API takeSnapshotWithConfiguration:completionHandler:
2269 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2270 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm: Added.
2275 2017-02-23 Saam Barati <sbarati@apple.com>
2277 Speculative fix for jsc timing out tests
2278 https://bugs.webkit.org/show_bug.cgi?id=168791
2280 Rubber Stamped by Keith Miller.
2282 Play musical chairs with IRC and Briggs options on
2283 ftl-eager and ftl-eager-no-cjit.
2285 * Scripts/run-jsc-stress-tests:
2287 2017-02-23 Carlos Alberto Lopez Perez <clopez@igalia.com>
2289 Improve error message when the WPT server fails to start.
2290 https://bugs.webkit.org/show_bug.cgi?id=168759
2292 Reviewed by Ryosuke Niwa.
2294 Check if the WPT server is running after 1 second, and if is not
2295 print useful information for helping the user to debug the issue.
2297 Using check_running_pid() to check if the process is still running
2298 doesn't work. A process started via subprocess popen that has ended
2299 will be in a zombie state until a call to wait/communicate/poll
2300 is done, or until the object is deleted or garbage collected.
2302 This adds also support for testing the behaviour of subprocess
2303 poll() on the unit tests that use MockProcess.
2305 A new test is added also for the battery of tests for the WPT
2308 * Scripts/webkitpy/common/system/executive_mock.py:
2309 (MockProcess.__init__):
2311 (MockProcess.communicate):
2313 (MockExecutive.popen):
2314 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2315 (WebPlatformTestServer.__init__):
2316 (WebPlatformTestServer._prepare_config):
2317 (WebPlatformTestServer._spawn_process):
2318 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2319 (TestWebPlatformTestServer.test_corrupted_subserver_files):
2320 (TestWebPlatformTestServer):
2321 (TestWebPlatformTestServer.test_server_fails_to_start_throws_exception):
2323 2017-02-23 Wenson Hsieh <wenson_hsieh@apple.com>
2325 Unreviewed, temporarily disable DataInteractionTests in TestWebKitAPI.
2327 These will be reenabled in https://bugs.webkit.org/show_bug.cgi?id=168602.
2329 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2331 2017-02-22 Wenson Hsieh <wenson_hsieh@apple.com>
2333 Data interaction causes selection to fall out of sync between web/UI processes
2334 https://bugs.webkit.org/show_bug.cgi?id=168735
2335 <rdar://problem/30657817>
2337 Reviewed by Tim Horton.
2339 Adds a new method to TestWKWebView for querying selection view rects from the UI process and augments data
2340 interaction unit tests to check for selection rects using this new hook.
2342 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2344 (TestWebKitAPI::TEST):
2345 * TestWebKitAPI/cocoa/TestWKWebView.h:
2346 * TestWebKitAPI/cocoa/TestWKWebView.mm:
2347 (-[TestWKWebView selectionRectsAfterPresentationUpdate]):
2348 * TestWebKitAPI/ios/DataInteractionSimulator.h:
2349 * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2350 (-[DataInteractionSimulator _resetSimulatedState]):
2351 (-[DataInteractionSimulator runFrom:to:]):
2352 (-[DataInteractionSimulator finalSelectionRects]):
2354 2017-02-22 Carlos Garcia Campos <cgarcia@igalia.com>
2356 Better handle Thread and RunLoop initialization
2357 https://bugs.webkit.org/show_bug.cgi?id=167828
2359 Reviewed by Yusuke Suzuki.
2361 Remove unnecessary calls to WTF::initializeMainThread().
2363 * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2364 (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2365 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2366 (TestWebKitAPI::ContentExtensionTest::SetUp):
2367 * WebKitTestRunner/TestController.cpp:
2368 (WTR::TestController::initialize):
2370 2017-02-22 Myles C. Maxfield <mmaxfield@apple.com>
2372 [Cocoa] Remove Yosemite-specific font lookup code
2373 https://bugs.webkit.org/show_bug.cgi?id=168682
2375 Reviewed by Zalan Bujtas.
2377 * DumpRenderTree/mac/DumpRenderTree.mm:
2380 (createWebViewAndOffscreenWindow):
2381 (drt_NSFontManager_availableFontFamilies): Deleted.
2382 (drt_NSFontManager_availableFonts): Deleted.
2383 (swizzleNSFontManagerMethods): Deleted.
2384 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2385 (WTR::activateFonts):
2386 (WTR::allowedFontFamilySet): Deleted.
2387 (WTR::systemHiddenFontFamilySet): Deleted.
2388 (WTR::wtr_NSFontManager_availableFontFamilies): Deleted.
2389 (WTR::wtr_NSFontManager_availableFonts): Deleted.
2390 (WTR::swizzleNSFontManagerMethods): Deleted.
2391 * WebKitTestRunner/mac/TestControllerMac.mm:
2392 (WTR::generateWhitelist):
2393 (WTR::TestController::platformInitializeContext):
2395 2017-02-22 Carlos Alberto Lopez Perez <clopez@igalia.com>
2397 AutoInstaller should not skip the install step if the package is downloaded but not installed
2398 https://bugs.webkit.org/show_bug.cgi?id=168737
2400 Reviewed by Ryosuke Niwa.
2402 Don't skip the install step if the package target path don't exists.
2403 Fix the description for "should_refresh" optional argument.
2405 * Scripts/webkitpy/common/system/autoinstall.py:
2406 (AutoInstaller.install):
2408 2017-02-22 Carlos Garcia Campos <cgarcia@igalia.com>
2410 [GTK] Do not use g_return_if_fail in EventSenderProxy::continuousMouseScrollBy
2411 https://bugs.webkit.org/show_bug.cgi?id=168721
2413 Reviewed by Michael Catanzaro.
2415 Use WTFLogAlways instead. It's still shown in stderr, but it won't crash if we ever run tests with fatal
2418 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2419 (WTR::EventSenderProxy::continuousMouseScrollBy):
2421 2017-02-21 Youenn Fablet <youenn@apple.com>
2423 [WebRTC][Mac] Activate libwebrtc
2424 https://bugs.webkit.org/show_bug.cgi?id=167293
2425 <rdar://problem/30401864>
2427 Reviewed by Alex Christensen.
2429 Fixing paths to allow loading libwebrtc.dylib successfully.
2431 * Scripts/build-webkit:
2432 * Scripts/webkitdirs.pm:
2433 (setupMacWebKitEnvironment):
2434 (setupIOSWebKitEnvironment):
2435 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2437 2017-02-21 Saam Barati <sbarati@apple.com>
2439 Add the Briggs optimistic allocator to run on ARM64
2440 https://bugs.webkit.org/show_bug.cgi?id=168454
2442 Reviewed by Filip Pizlo.
2444 * Scripts/run-jsc-stress-tests:
2446 2017-02-20 Filip Pizlo <fpizlo@apple.com>
2448 The collector thread should only start when the mutator doesn't have heap access
2449 https://bugs.webkit.org/show_bug.cgi?id=167737
2451 Reviewed by Keith Miller.
2453 Make more tests collect continuously.
2455 * Scripts/run-jsc-stress-tests:
2457 2017-02-20 Simon Fraser <simon.fraser@apple.com>
2459 Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
2460 https://bugs.webkit.org/show_bug.cgi?id=168620
2461 <rdar://problem/30617772>
2463 Reviewed by Tim Horton.
2465 Add a setting that allows one to toggle subpixel-antialiased layer text on and off.
2467 * DumpRenderTree/mac/DumpRenderTree.mm:
2468 (resetWebPreferencesToConsistentValues):
2469 * MiniBrowser/mac/SettingsController.h:
2470 * MiniBrowser/mac/SettingsController.m:
2471 (-[SettingsController _populateMenu]):
2472 (-[SettingsController validateMenuItem:]):
2473 (-[SettingsController toggleSubpixelAntialiasedLayerTextEnabled:]):
2474 (-[SettingsController subpixelAntialiasedLayerTextEnabled]):
2475 * MiniBrowser/mac/WK1BrowserWindowController.m:
2476 (-[WK1BrowserWindowController didChangeSettings]):
2477 * MiniBrowser/mac/WK2BrowserWindowController.m:
2478 (-[WK2BrowserWindowController didChangeSettings]):
2479 * WebKitTestRunner/TestController.cpp:
2480 (WTR::TestController::resetPreferencesToConsistentValues):
2482 2017-02-21 Jonathan Bedard <jbedard@apple.com>
2484 webkitpy: Refactor Device class
2485 https://bugs.webkit.org/show_bug.cgi?id=168332
2487 Reviewed by Alexey Proskuryakov.
2489 Separate the more specific SimulatedDevice from the abstract
2492 * Scripts/webkitpy/xcode/device.py: Added.
2493 (Device): Base device class.
2494 (Device.__init__): Initialize _host, name and udid.
2495 (Device.install_app): Function declaration.
2496 (Device.launch_app): Ditto.
2497 (Device.__eq__): Compare two devices by udid.
2498 (Device.__ne__): Ditto.
2499 (Device.__repr__): Return device name and udid in formatted string.
2500 * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/simulator.py.
2502 (SimulatedDevice.__init__): Call Device.__init__ first.
2503 (SimulatedDevice.delete): Device -> SimulatedDevice.
2504 (SimulatedDevice.reset): Ditto.
2505 (SimulatedDevice.__eq__): Moved to device.py.
2506 (SimulatedDevice.__ne__): Ditto.
2507 (SimulatedDevice.__repr__): Call Device __repr__ first.
2508 (DeviceType): Kept in Scripts/webkitpy/xcode/simulator.py.
2509 (Runtime): Kept in Scripts/webkitpy/xcode/simulator.py.
2510 (Device): Renamed SimulatedDevice.
2511 (Simulator): Kept in Scripts/webkitpy/xcode/simulator.py.
2512 * Scripts/webkitpy/xcode/simulator.py:
2513 (Simulator): Define Simulator.Device class as None.
2514 (Simulator.__init__): Import SimulatedDevice as Simulator.Device.
2515 (Simulator.delete_device): Use Simulator.Device.
2516 (Simulator.reset_device): Ditto.
2517 (Simulator._parse_devices): Ditto.
2518 (Simulator.lookup_or_create_device): Make
2519 (Device): Moved to simulated_device as SimulatedDevice.
2521 2017-02-21 JF Bastien <jfbastien@apple.com>
2524 https://bugs.webkit.org/show_bug.cgi?id=168665
2526 Reviewed by Mark Lam.
2528 It was broken by r212555 and r212681.
2530 * DumpRenderTree/PlatformMac.cmake:
2532 2017-02-21 Alexey Proskuryakov <ap@apple.com>
2534 Improve bot watcher's dashboard performance
2535 https://bugs.webkit.org/show_bug.cgi?id=168624
2536 <rdar://problem/30190109>
2538 Reviewed by Daniel Bates.
2540 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2541 There was an unnecessary linear complexity algorithm in indexOfRevision().
2543 2017-02-21 Alex Christensen <achristensen@webkit.org>
2545 Unreviewed, rolling out r212699.
2547 Internal build not ready
2551 "[WebRTC][Mac] Activate libwebrtc"
2552 https://bugs.webkit.org/show_bug.cgi?id=167293
2553 http://trac.webkit.org/changeset/212699
2555 2017-02-20 Carlos Garcia Campos <cgarcia@igalia.com>
2557 Remove ENABLE_THREADED_COMPOSITOR build option
2558 https://bugs.webkit.org/show_bug.cgi?id=168606
2560 Reviewed by Michael Catanzaro.
2562 * Scripts/webkitperl/FeatureList.pm:
2564 2017-02-20 Youenn Fablet <youenn@apple.com>
2566 [WebRTC][Mac] Activate libwebrtc
2567 https://bugs.webkit.org/show_bug.cgi?id=167293
2568 <rdar://problem/30401864>
2570 Reviewed by Alex Christensen.
2572 Fixing paths to allow loading libwebrtc.dylib successfully.
2574 * Scripts/build-webkit:
2575 * Scripts/webkitdirs.pm:
2576 (setupMacWebKitEnvironment):
2577 (setupIOSWebKitEnvironment):
2579 2017-02-20 Ryan Haddad <ryanhaddad@apple.com>
2581 Unreviewed, rolling out r212685.
2583 This change broke the 32-bit Sierra build.
2587 "Resource Load Statistics: Add alternate classification
2589 https://bugs.webkit.org/show_bug.cgi?id=168347
2590 http://trac.webkit.org/changeset/212685
2592 2017-02-20 John Wilander <wilander@apple.com>
2594 Resource Load Statistics: Add alternate classification method
2595 https://bugs.webkit.org/show_bug.cgi?id=168347
2596 <rdar://problem/30352793>
2598 Reviewed by Alex Christensen.
2600 Added three testRunner functions to facilitate layout tests:
2601 - setStatisticsSubframeUnderTopFrameOrigin()
2602 - setStatisticsSubresourceUnderTopFrameOrigin()
2603 - setStatisticsSubresourceUniqueRedirectTo()
2605 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2606 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2607 (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2608 (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2609 (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2610 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2611 * WebKitTestRunner/TestController.cpp:
2612 (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
2613 (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
2614 (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
2615 * WebKitTestRunner/TestController.h:
2616 * WebKitTestRunner/TestInvocation.cpp:
2617 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2619 2017-02-20 Anders Carlsson <andersca@apple.com>
2621 Use the new drag code path when dragging links
2622 https://bugs.webkit.org/show_bug.cgi?id=168612
2624 Reviewed by Tim Horton.
2626 If a type is not dynamic, just use the static UTI.
2628 * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
2629 (-[LocalPasteboard writeObjects:]):
2631 2017-02-17 Anders Carlsson <andersca@apple.com>
2633 Add a new drag code path and use it for dragging plain text
2634 https://bugs.webkit.org/show_bug.cgi?id=168534
2636 Reviewed by Geoffrey Garen.
2638 Update the testing infrastructure to handle NSDraggingSession.
2640 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2641 * DumpRenderTree/mac/DumpRenderTreePasteboard.mm: Renamed from Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m.
2642 (-[LocalPasteboard writeObjects:]):
2643 Implement this in terms of the legacy pasteboard API.
2645 * DumpRenderTree/mac/EventSendingController.mm:
2646 (drt_WebHTMLView_beginDraggingSessionWithItemsEventSource):
2647 (+[EventSendingController initialize]):
2648 Swizzle the drag method instead of adding a delegate method (like the old code does).
2650 2017-02-20 Florian Bruhin <git@the-compiler.org>
2652 Handle EINTR during webkitpy server process select()
2653 https://bugs.webkit.org/show_bug.cgi?id=168361
2655 Reviewed by Michael Catanzaro.
2657 Otherwise, on my machine, resizing the terminal run-webkit-tests is running in
2660 * Scripts/webkitpy/port/server_process.py:
2661 (ServerProcess._wait_for_data_and_update_buffers_using_select):
2663 2017-02-20 Carlos Garcia Campos <cgarcia@igalia.com>
2665 Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/default-menu.
2667 It can happen that the window onload event is dispatched after the load finished is received in the UI
2668 process. Move the script to select the text to the body instead of using a window onload handler.
2670 * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2671 (testContextMenuDefaultMenu):
2673 2017-02-20 Manuel Rego Casasnovas <rego@igalia.com>
2675 [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
2676 https://bugs.webkit.org/show_bug.cgi?id=167693
2678 Reviewed by Sergio Villar Senin.
2680 * Scripts/webkitperl/FeatureList.pm:
2681 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2682 * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
2683 (TestWebKitAPI::computeNumberOfTracks):
2684 (TestWebKitAPI::TEST):
2685 * TestWebKitAPI/Tests/WebCore/GridPosition.cpp:
2686 (TestWebKitAPI::TEST):
2688 2017-02-19 Commit Queue <commit-queue@webkit.org>
2690 Unreviewed, rolling out r212466.
2691 https://bugs.webkit.org/show_bug.cgi?id=168577
2693 causes crashes on AArch64 on linux, maybe it's causing crashes
2694 on iOS too (Requested by pizlo on #webkit).
2698 "The collector thread should only start when the mutator
2699 doesn't have heap access"
2700 https://bugs.webkit.org/show_bug.cgi?id=167737
2701 http://trac.webkit.org/changeset/212466
2703 2017-02-17 Aakash Jain <aakash_jain@apple.com>
2705 Fix failure from r212579.
2707 Unreviewed build-fix.
2709 * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
2710 (CheckPatchRelevance._changes_are_relevant): Return true for all groups others than jsc for now.
2712 2017-02-17 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
2714 EWS should run JavaScriptCore tests
2715 https://bugs.webkit.org/show_bug.cgi?id=162458
2717 Reviewed by Alexey Proskuryakov.
2719 * QueueStatusServer/config/queues.py: Add jsc-ews queue.
2720 * QueueStatusServer/model/queuestatus.py:
2721 (QueueStatus.did_skip): Returns whether patch was skipped, based on status.
2722 * QueueStatusServer/handlers/statusbubble.py:
2723 (StatusBubble._should_show_bubble_for): Add logic to hide jsc-ews bubble if the patch does not touch jsc.
2724 * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2725 (MockSCM.__init__): Add _mockChangedFiles variable.
2726 (MockSCM.changed_files): Change to use _mockChangedFiles variables.
2727 * Scripts/webkitpy/common/config/ews.json: Add config info for JSC EWS.
2728 * Scripts/webkitpy/common/config/ports.py: Add support for JSC EWS in Mac Port.
2729 (DeprecatedPort._append_build_style_flag): Helper function to append build_style to a command.
2730 (DeprecatedPort.build_jsc_command): Added - command to build JSC only (quicker than building all of WebKit).
2731 (DeprecatedPort.run_javascriptcore_tests_command): Allow JSC EWS to only run JSC tests.
2732 (MacPort.run_webkit_tests_command): Check for JSC.
2733 * Scripts/webkitpy/common/config/ports_mock.py:
2734 (MockPort.run_javascriptcore_tests_command): Add build_style argument.
2735 * Scripts/webkitpy/common/config/ports_unittest.py:
2736 (DeprecatedPortTest.test_mac_port): Add unit tests for build-jsc shell command.
2737 * Scripts/webkitpy/common/net/abstracttestresults.py: Added.
2738 (AbstractTestResults): Abstract superclass of JSCTestResults and JSCTestResults.
2739 (AbstractTestResults.test_results): Stub.
2740 (AbstractTestResults.failing_tests): Stub.
2741 (AbstractTestResults.did_exceed_test_failure_limit): Stub.
2742 * Scripts/webkitpy/common/net/jsctestresults.py: Added.
2743 (JSCTestResults): Added.
2744 (JSCTestResults.intersection): Return a JSCTestResults object with failures common to both input objects.
2745 (JSCTestResults.results_from_string): Use json library to parse results.
2746 (JSCTestResults.__init__): Initialize members.
2747 (JSCTestResults.equals): This enables unit testing.
2748 (JSCTestResults.is_subset): Checks if one set of failures is a subset of another.
2749 (JSCTestResults.all_passed): Getter.
2750 (JSCTestResults.failing_tests): Getter.
2751 (JSCTestResults.did_exceed_test_failure_limit): Getter.
2752 * Scripts/webkitpy/common/net/jsctestresults_unittest.py: Added.
2753 (JSCTestResultsTest): Class to test JSCTestResults.
2754 (JSCTestResultsTest.test_results_from_string): Tests parsing.
2755 (JSCTestResultsTest.test_intersection_api_tests): Unit test for intersection() class method.
2756 (JSCTestResultsTest.test_intersection_stress_tests): Unit test for intersection() class method.
2757 (JSCTestResultsTest.test_intersection_general_case): Unit test for intersection() class method.
2758 * Scripts/webkitpy/port/base.py:
2759 (Port.jsc_results_directory): Returns the directory for the JSC test results JSON file.
2760 * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2761 (EarlyWarningSystemTask.run): Add check_patch_relevance step.
2762 * Scripts/webkitpy/tool/bot/jscews_unittest.py: Added.
2763 (MockPatchAnalysisTask): Mocked-out version of PatchAnalysisTask that doesn't run commands.
2764 (MockPatchAnalysisTask.__init__): Sets attributes.
2765 (MockPatchAnalysisTask._test): Override to not run command.
2766 (MockPatchAnalysisTask._build_and_test_without_patch): Override to not run command.
2767 (MockPatchAnalysisTask.validate): Assume mocked patch is valid for purposes of testing retry logic.
2768 (MockPatchAnalysisTask.test_run_count): Specific to the mocked version, to test retry logic.
2769 (MockJSCEarlyWarningSystem): Mocked-out version of AbstarctEarlyWarningSystem so we can provide test results.
2770 (MockJSCEarlyWarningSystem.__init__): Sets attributes, also sets group to jsc.
2771 (MockJSCEarlyWarningSystem.test_results): Returns test results provided by us, instead of using a JSON reader.
2772 (JSCEarlyWarningSystemTest): Class to test retry logic in below situations.
2773 (JSCEarlyWarningSystemTest._create_task): Helper function to abstract out common code.
2774 (JSCEarlyWarningSystemTest._results_indicate_all_passed): False if input is None or has failures, else True.
2775 (JSCEarlyWarningSystemTest.test_success_case): Clean patch on clean tree.
2776 (JSCEarlyWarningSystemTest.test_test_failure): Failed patch on clean tree.
2777 (JSCEarlyWarningSystemTest.test_fix): Patch that fixes all tree redness.
2778 (JSCEarlyWarningSystemTest.test_ineffective_patch): Patch that has same failures as tree.
2779 (JSCEarlyWarningSystemTest.test_partially_effective_patch): Patch fixes some failures but adds no new failures.
2780 (JSCEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Patch has some failures not in tree.
2781 (JSCEarlyWarningSystemTest.test_first_results_could_not_be_read): Patch results not readable.
2782 (JSCEarlyWarningSystemTest.test_second_results_could_not_be_read): Patch results not readable on second run.
2783 (JSCEarlyWarningSystemTest.test_clean_results_could_not_be_read): Results from clean tree not readable.
2784 (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass): Patch has one flake and no failures.
2785 (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass_v2): Patch has one flake and no failures.
2786 (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_failure): Patch has flakes and failed tests.
2787 (JSCEarlyWarningSystemTest.test_flaky_results_on_red_tree_pass): Patch has same failures as tree, plus a flake.
2788 * Scripts/webkitpy/tool/bot/jsctestresultsreader.py: Added.
2789 (JSCTestResultsReader): Reads results file.
2790 (JSCTestResultsReader.__init__): Sets attributes.
2791 (JSCTestResultsReader._read_file_contents): Reads file.
2792 (JSCTestResultsReader.results): Reads the results file and returns a JSCTestResults object.
2793 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2794 (PatchIsNotApplicable): Exception for when patch doesn't have relevant changes.
2795 (PatchAnalysisTask._check_patch_relevance): Added.
2796 (PatchAnalysisTask._build): Check for JSC.
2797 (PatchAnalysisTask._build_without_patch): Check for JSC.
2798 (PatchAnalysisTask._test): Check for JSC.
2799 (PatchAnalysisTask._build_and_test_without_patch): Check for JSC.
2800 (PatchAnalysisTask._retry_jsc_tests): Retry logic for JSC EWS.
2801 (PatchAnalysisTask._retry_layout_tests): Retry logic for layout tests EWS.
2802 (PatchAnalysisTask._test_patch): Add retry logic for JSC.
2803 * Scripts/webkitpy/tool/commands/download.py:
2804 (CheckPatchRelevance): Add check-patch-relevance command.
2805 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2806 (AbstractEarlyWarningSystem._create_task): Abstract out to enable mocking.
2807 (AbstractEarlyWarningSystem.begin_work_queue): Use JSCTestResultsReader not LayoutTestResultsReader in JSC EWS.
2808 (AbstractEarlyWarningSystem.review_patch): Handle PatchIsApplicable.
2809 (AbstractEarlyWarningSystem.test_results): _layout_test_results_reader -> _test_results_reader.
2810 (AbstractEarlyWarningSystem.archive_last_test_results): _layout_test_results_reader -> _test_results_reader.
2811 (AbstractEarlyWarningSystem.group): This attribute determines the type of EWS (eg. JSC).
2812 (AbstractEarlyWarningSystem.load_ews_classes): Add _group, and make classes of type cls to enable mocking.
2813 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2814 (TestEWS): Sample layout test EWS class used for unit testing.
2815 (TestJSCEWS): Sample JSC EWS class used for unit testing.
2816 (AbstractEarlyWarningSystemTest.test_failing_tests_message.TestEWS): Add _group.
2817 (AbstractEarlyWarningSystemTest.test_failing_jsc_tests_message.TestEWS): Added test for jsc failures message.
2818 (AbstractEarlyWarningSystemTest): Add _group variable.
2819 (EarlyWarningSystemTest._default_expected_logs): Add check-patch-relevance step, inconclusive logs, and group.
2820 (EarlyWarningSystemTest._test_ews): Add logs_are_conclusive option to pass through to default_expected_logs().
2821 (EarlyWarningSystemTest.test_inconclusive_test_results): Test not removing patch from queue if not conclusive.
2822 (MockAbstractEarlyWarningSystemForInconclusiveJSCResults): Added.
2823 (MockAbstractEarlyWarningSystemForInconclusiveJSCResults._test_patch): Simulates running tests but not getting a conclusive result.
2824 (MockEarlyWarningSystemTaskForInconclusiveJSCResults): Added.
2825 (MockEarlyWarningSystemTaskForInconclusiveJSCResults._create_task): Use MockEarlyWarningSystemTask (not EarlyWarningSystemTask).
2826 * Scripts/webkitpy/tool/steps/__init__.py: Add CheckPatchRelevance import.
2827 * Scripts/webkitpy/tool/steps/build.py:
2828 (Build.options): Check for JSC.
2829 (Build.build): Check for JSC.
2830 (Build.run): Check for JSC.
2831 * Scripts/webkitpy/tool/steps/checkpatchrelevance.py: Added.
2832 (CheckPatchRelevance): Added.
2833 (CheckPatchRelevance._does_contain_change_in_paths): Abstract function to perform regex matching.
2834 (CheckPatchRelevance.run): Check if changed files in patch belong in certain folders.
2835 * Scripts/webkitpy/tool/steps/options.py:
2836 (Options): Add --group command line option.
2837 * Scripts/webkitpy/tool/steps/runtests.py:
2838 (RunTests.options): Add group.
2839 (RunTests.run): Check for JSC.
2840 (RunTests._run_webkit_tests): Check for JSC.
2841 (RunTests): Add _group attribute.
2842 (RunTests._run_javascriptcore_tests): New.
2843 * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
2845 2017-02-17 Aakash Jain <aakash_jain@apple.com>
2847 Fix tools that were broken by Efl removal
2848 https://bugs.webkit.org/show_bug.cgi?id=168496
2850 Reviewed by Alexey Proskuryakov.
2852 * QueueStatusServer/config/queues.py:
2853 * Scripts/webkitpy/common/config/ews.json:
2854 * TestResultServer/static-dashboards/builders.jsonp:
2855 * TestResultServer/static-dashboards/flakiness_dashboard.js:
2856 * TestResultServer/static-dashboards/loader_unittests.js:
2858 2017-02-16 Lucas Forschler <lforschler@apple.com>
2860 https://bugs.webkit.org/show_bug.cgi?id=168442
2861 Move the SVN checkout from http -> https.
2864 Reviewed by Alexey Proskuryakov.
2866 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2867 (CheckOutSource.__init__):
2868 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2869 (SVNMirrorTest.get_SVNMirrorFromConfig):
2870 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2872 2017-02-16 Commit Queue <commit-queue@webkit.org>
2874 Unreviewed, rolling out r212514.
2875 https://bugs.webkit.org/show_bug.cgi?id=168489
2877 broke test runner (Requested by alexchristensen on #webkit).
2881 "Remove EFL-specific files in Tools."
2882 http://trac.webkit.org/changeset/212514
2884 2017-02-16 Alex Christensen <achristensen@webkit.org>
2886 Remove EFL-specific files in Tools.
2888 Rubber-stamped by Anders Carlsson.
2890 * ImageDiff/efl: Removed.
2891 * ImageDiff/efl/ImageDiff.cpp: Removed.
2892 * MiniBrowser/efl: Removed.
2893 * MiniBrowser/efl/CMakeLists.txt: Removed.
2894 * MiniBrowser/efl/main.c: Removed.
2895 * Scripts/run-efl-tests: Removed.
2896 * Scripts/update-webkitefl-libs: Removed.
2897 * Scripts/webkitpy/port/efl.py: Removed.
2898 * Scripts/webkitpy/port/efl_unittest.py: Removed.
2899 * TestWebKitAPI/Tests/WebKit2/efl: Removed.
2900 * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
2901 * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
2902 * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
2903 * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
2904 * TestWebKitAPI/efl: Removed.
2905 * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
2906 * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
2907 * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
2908 * TestWebKitAPI/efl/main.cpp: Removed.
2909 * WebKitTestRunner/InjectedBundle/efl: Removed.
2910 * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
2911 * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
2912 * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
2913 * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
2914 * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
2915 * WebKitTestRunner/efl: Removed.
2916 * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
2917 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
2918 * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
2919 * WebKitTestRunner/efl/main.cpp: Removed.
2921 * efl/install-dependencies: Removed.
2922 * efl/jhbuild-optional.modules: Removed.
2923 * efl/jhbuild.modules: Removed.
2924 * efl/jhbuildrc: Removed.
2925 * efl/patches: Removed.
2926 * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
2927 * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
2928 * efl/patches/gst-libav.patch: Removed.
2929 * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
2930 * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2931 * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2932 * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
2934 2017-02-16 Myles C. Maxfield <mmaxfield@apple.com>
2936 font-weight in @font-face can cause a font to be downloaded even when it's not used
2937 https://bugs.webkit.org/show_bug.cgi?id=168114
2938 <rdar://problem/30301317>
2940 Reviewed by Darin Adler.
2942 LastResort needs to be usable in tests.
2944 * DumpRenderTree/mac/DumpRenderTree.mm:
2945 (allowedFontFamilySet):
2946 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2947 (WTR::allowedFontFamilySet):
2948 * WebKitTestRunner/mac/TestControllerMac.mm:
2949 (WTR::allowedFontFamilySet):
2951 2017-02-16 Alex Christensen <achristensen@webkit.org>
2953 Remove old URL parser
2954 https://bugs.webkit.org/show_bug.cgi?id=168483
2956 Reviewed by Tim Horton.
2958 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2959 (TestWebKitAPI::checkURL):
2960 (TestWebKitAPI::checkRelativeURL):
2961 (TestWebKitAPI::checkURLDifferences):
2962 (TestWebKitAPI::checkRelativeURLDifferences):
2964 2017-02-16 Wenson Hsieh <wenson_hsieh@apple.com>
2966 [WK2] Add additional test infrastructure and unit tests for data interaction
2967 https://bugs.webkit.org/show_bug.cgi?id=168439
2968 <rdar://problem/30557942>
2970 Reviewed by Tim Horton.
2972 Adds test support for additional data interaction scenarios that we currently cannot test, and also adds 7 new
2973 test cases to DataInteractionTests. Most of the changes here refactor and augment DataInteractionSimulator to
2974 support data interaction from See per-method descriptions below for more details.
2976 * Configurations/TestWebKitAPI.xcconfig:
2978 Add MobileCoreServices to the list of additional frameworks to link against on iOS.
2980 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2982 Add a new build phase that copies additional resources from WebKitAdditions/Resources/TestWebKitAPI and dumps
2983 them into TestWebKitAPI.resources/ in the build directory, if the WebKitAdditions folder exists.
2985 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2986 (-[TestWKWebView editorContainsImageElement]):
2987 (-[TestWKWebView editorValue]):
2989 New helper methods for querying information from the "editor" element in a test page.
2991 (TestWebKitAPI::TEST):
2992 (TestWebKitAPI::runTestsExpectingToObserveEvents): Deleted.
2994 Moves logic for capturing events during a simulated data interaction run from the test file to
2995 DataInteractionSimulator. See -[DataInteractionSimulator observedEventNames].
2997 * TestWebKitAPI/cocoa/TestWKWebView.h:
2998 * TestWebKitAPI/cocoa/TestWKWebView.mm:
2999 (-[TestMessageHandler removeMessage:]):
3000 (-[TestWKWebView clearMessageHandlers:]):
3002 Add the ability to clear message handlers from the TestWKWebView.
3004 * TestWebKitAPI/ios/DataInteractionSimulator.h:
3005 * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3006 (dataInteractionEventNames):
3007 (-[DataInteractionSimulator initWithWebView:]):
3008 (-[DataInteractionSimulator _resetSimulatedState]):
3010 Moves logic to clear test harness state from any previous runs into a helper. Called at the beginning when
3011 simulating data interaction.
3013 (-[DataInteractionSimulator observedEventNames]):
3015 Returns a list of the names of events relevant to data interaction that were observed over the course of the
3018 (-[DataInteractionSimulator runFrom:to:]):
3020 Changes -run to -runFrom:to:, which takes window-relative start and end locations. This allows the test harness
3021 to run the same data interaction for multiple simulated gestures.
3023 (-[DataInteractionSimulator _advanceProgress]):
3024 (-[DataInteractionSimulator _finishDataInteraction]):
3025 (-[DataInteractionSimulator externalItemProvider]):
3026 (-[DataInteractionSimulator setExternalItemProvider:]):
3028 Adds the -externalItemProvider property to DataInteractionSimulator. Setting this skips the gesture recognition
3029 phase of a test run.
3031 (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
3032 (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
3033 (-[DataInteractionSimulator webViewDidSendDataInteractionStartRequest:]):
3034 (-[DataInteractionSimulator webView:didReceiveDataInteractionStartResponse:]):
3036 While a request to start data interaction is in flight, put the remainder of the test on hold until the web
3037 process returns. Then continue the test by scheduling a progress advance call. This addresses a race condition
3038 wherein the the web process might take longer than usual to process the request to start data interaction, and
3039 in the meantime, DataInteractionSimulator would end up completing the rest of the test before a response from
3040 the web process is received, which then causes no simulated delegate methods to be fired.
3042 (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]): Deleted.
3043 (-[DataInteractionSimulator run]): Deleted.
3045 2017-02-16 Wenson Hsieh <wenson_hsieh@apple.com>
3047 Remove unused test pages in TestWebKitAPI
3048 https://bugs.webkit.org/show_bug.cgi?id=168462
3050 Reviewed by Anders Carlsson.
3052 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3053 * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
3054 * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
3055 * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
3056 * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
3057 * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
3059 2017-02-16 Alex Christensen <achristensen@webkit.org>
3061 Special URLs without a host are invalid
3062 https://bugs.webkit.org/show_bug.cgi?id=168461
3064 Reviewed by Tim Horton.
3066 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3067 (TestWebKitAPI::TEST_F):
3069 2017-02-10 Filip Pizlo <fpizlo@apple.com>
3071 The collector thread should only start when the mutator doesn't have heap access
3072 https://bugs.webkit.org/show_bug.cgi?id=167737
3074 Reviewed by Keith Miller.
3076 Make more tests collect continuously.
3078 * Scripts/run-jsc-stress-tests:
3080 2017-02-16 Tim Horton <timothy_horton@apple.com>
3082 WKWebView inside a UICollectionView flashes when items are inserted above it
3083 https://bugs.webkit.org/show_bug.cgi?id=168376
3084 <rdar://problem/29322051>
3086 Reviewed by Simon Fraser.
3088 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3089 (-[TestRunnerWKWebView _setStableStateOverride:]):
3090 Update the one external caller of this internal method...
3092 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3093 (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
3094 * DumpRenderTree/mac/UIScriptControllerMac.mm:
3095 (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
3096 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3097 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3098 (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
3099 * TestRunnerShared/UIScriptContext/UIScriptController.h:
3100 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3101 (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
3102 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3103 (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
3104 Expose doAfterVisibleContentRectUpdate to DRT and WKTR. It is called
3105 back after we dispatch a visible content rect update from the UI process
3106 to the Web Content process, so any messages sent from the block will arrive
3107 after the visible content rect update.
3109 2017-02-16 Carlos Alberto Lopez Perez <clopez@igalia.com>
3111 [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS.
3112 https://bugs.webkit.org/show_bug.cgi?id=168321
3114 This bots should be added to the trunk build scheduler.
3115 Unreviewed fix after r212429.
3117 * BuildSlaveSupport/build.webkit.org-config/config.json:
3119 2017-02-16 Carlos Alberto Lopez Perez <clopez@igalia.com>
3121 [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS
3122 https://bugs.webkit.org/show_bug.cgi?id=168321
3124 Reviewed by Michael Catanzaro.
3126 The additionalArgument --default-cmake-features is used both to
3127 skip the JHBuild (InstallGtkDependencies) build step and to build
3128 with the default features from the CMake config.
3130 * BuildSlaveSupport/build.webkit.org-config/config.json:
3131 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3133 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3135 2017-02-15 Lucas Forschler <lforschler@apple.com>
3137 https://bugs.webkit.org/show_bug.cgi?id=168386
3138 Remove EFL from build.webkit.org
3140 Reviewed by Alex Christensen
3142 * BuildSlaveSupport/build.webkit.org-config/config.json:
3143 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3144 (DeleteStaleBuildFiles.start):
3145 (appendCustomBuildFlags):
3146 (RunWebKitTests.start):
3149 (TestFactory.__init__):
3150 (loadBuilderConfig):
3151 (InstallEflDependencies): Deleted.
3152 (RunEflAPITests): Deleted.
3153 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3154 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3155 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3156 (BubbleQueueServer):
3157 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3158 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3159 (Analyzer.prototype._triggeringQueue):
3160 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3162 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3163 (table.queue-grid tr.platform.linux-efl img.logo): Deleted.
3164 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3165 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3166 (_should_file_trigger_build):
3168 2017-02-15 Alex Christensen <achristensen@webkit.org>
3170 Unreviewed, rolling out r212169.
3172 Broke iOS WebInspector
3176 "WebInspector: refactor RemoteInspector to move cocoa specific
3177 code to their own files"
3178 https://bugs.webkit.org/show_bug.cgi?id=166681
3179 http://trac.webkit.org/changeset/212169
3181 2017-02-15 Jonathan Bedard <jbedard@apple.com>
3183 webkitpy: Fix DarwinPort._get_crash_log()
3184 https://bugs.webkit.org/show_bug.cgi?id=168372
3185 <rdar://problem/30535156>
3187 Reviewed by Daniel Bates.
3189 Callers of _get_crash_log expect a pair to be returned and do not check it's return value.
3190 DarwinPort should return the expected return value for _get_crash_log.
3192 * Scripts/webkitpy/port/darwin.py:
3193 (DarwinPort._get_crash_log): Call parent class's implementation of _get_crash_log.
3195 2017-02-15 Chris Dumez <cdumez@apple.com>
3197 [iOS] Form Validation Bubble should be sensitive to Dynamic Type
3198 https://bugs.webkit.org/show_bug.cgi?id=168291
3199 <rdar://problem/30508593>
3201 Reviewed by Tim Horton.
3203 Drop overridePreference() implementation in iOS's UIScriptController
3204 as it was only used for the minimum font size setting and this setting
3205 is not exposed on iOS.
3207 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3208 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3209 (WTR::UIScriptController::overridePreference):
3210 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3212 2017-02-15 Jonathan Bedard <jbedard@apple.com>
3214 webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
3215 https://bugs.webkit.org/show_bug.cgi?id=168329
3216 <rdar://problem/30518832>
3218 Reviewed by Daniel Bates.
3220 When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
3221 never change given the same input arguments. Memoize function for efficiency.
3223 * Scripts/webkitpy/port/darwin.py: Add memoized import.
3225 (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.
3228 2017-02-15 Jonathan Bedard <jbedard@apple.com>
3230 webkitpy: Remove unused import from darwin.py
3231 https://bugs.webkit.org/show_bug.cgi?id=168371
3233 Reviewed by Alex Christensen.
3235 * Scripts/webkitpy/port/darwin.py: Remove unused 'time' module.
3237 2017-02-15 Carlos Garcia Campos <cgarcia@igalia.com>
3239 [SOUP] Credentials stored by libsoup are used even StoredCredentials policy is DoNotAllowStoredCredentials
3240 https://bugs.webkit.org/show_bug.cgi?id=168364
3242 Reviewed by Michael Catanzaro.
3244 This can happen if a previous load with allowed to use stored credentials authenticated successfully, saving the
3245 credentials in libsoup. It's actually a libsoup bug, but since it's causing layout test failures and we have
3246 patches for them, let's patch out jhbuild until we have a new libsoup version to depend on.
3248 Fixes: http/tests/security/credentials-from-different-domains.html
3249 http/tests/xmlhttprequest/cross-origin-no-authorization.html
3251 * gtk/jhbuild.modules:
3252 * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Added.
3253 * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Added.
3255 2017-02-14 Carlos Garcia Campos <cgarcia@igalia.com>
3257 [GTK] Update cookie manager API to properly work with ephemeral sessions
3258 https://bugs.webkit.org/show_bug.cgi?id=168230
3260 Reviewed by Michael Catanzaro.
3262 Update unit tests and add new cases for the new API.
3264 * MiniBrowser/gtk/main.c:
3265 (gotWebsiteDataCallback):
3266 * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
3267 (testCookieManagerEphemeral):
3268 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3269 (testWebContextEphemeral):
3270 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3271 (testWebViewEphemeral):
3272 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
3274 (testWebsiteDataEphemeral):
3275 (testWebsiteDataCookies):
3278 2017-02-14 Wenson Hsieh <wenson_hsieh@apple.com>
3280 [WK2] Support data interaction on links
3281 https://bugs.webkit.org/show_bug.cgi?id=168331
3282 <rdar://problem/30200837>
3284 Reviewed by Tim Horton.
3286 Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
3287 editable area results in the link URL being inserted.
3289 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3290 * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
3291 * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
3292 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3293 (TestWebKitAPI::TEST):
3295 2017-02-14 Jason Rinn <jrinn@apple.com>
3297 Add a test for new WebKit Cocoa API, _getContentsAsString.
3298 https://bugs.webkit.org/show_bug.cgi?id=168147
3299 <rdar://problem/30502539>
3301 Reviewed by Tim Horton.
3303 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3304 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.
3307 2017-02-14 Matt Rajca <mrajca@apple.com>
3309 Website policies: iframes should respect the autoplay policy of the top-level document
3310 https://bugs.webkit.org/show_bug.cgi?id=168333
3312 Reviewed by Alex Christensen.
3314 * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
3315 * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
3316 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3317 (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3320 2017-02-14 Chris Dumez <cdumez@apple.com>
3322 HTML Form Validation bubble should take minimum font size setting into consideration
3323 https://bugs.webkit.org/show_bug.cgi?id=168271
3324 <rdar://problem/29869869>
3326 Reviewed by Simon Fraser.
3328 Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
3329 font size of the validation bubble.
3331 Add an overridePreference() method to UIScriptController. This is currently
3332 used to override the value of the minimumFontSize setting. testRunner's
3333 overridePreference() is not usable on WK2 because it does not update the
3334 value of the preference on the UIProcess side.
3336 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3337 (WTR::UIScriptController::overridePreference):
3338 * DumpRenderTree/mac/UIScriptControllerMac.mm:
3339 (WTR::UIScriptController::overridePreference):
3340 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3341 * TestRunnerShared/UIScriptContext/UIScriptController.h:
3342 * WebKitTestRunner/TestController.cpp:
3343 (WTR::TestController::resetPreferencesToConsistentValues):
3344 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3345 (WTR::UIScriptController::overridePreference):
3346 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3347 (WTR::UIScriptController::contentsOfUserInterfaceItem):
3348 (WTR::UIScriptController::overridePreference):
3350 2017-02-14 Florian Bruhin <git@the-compiler.org>
3352 Use a set instead of a list for tests when parsing expectations
3353 https://bugs.webkit.org/show_bug.cgi?id=168304
3355 In _collect_matching_tests, a lot of membership tests are done on a giant list
3356 of strings. By making it a set instead, we can make those much faster, and
3357 there's no reason for it to be a list.
3359 With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
3360 to 3s on my machine.
3362 Reviewed by Ryosuke Niwa.
3364 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3365 (TestExpectationParser.__init__):
3366 (TestExpectationParser._collect_matching_tests):
3368 2017-02-14 Jonathan Bedard <jbedard@apple.com>
3370 Unreviewed build-fix after r212297.
3372 * Scripts/webkitpy/port/simulator_process.py:
3373 (SimulatorProcess.stop): Should return value of the ServerProcess's stop.
3375 2017-02-14 Carlos Alberto Lopez Perez <clopez@igalia.com>
3377 [CMake] build-webkit should allow building with the default cmake configuration
3378 https://bugs.webkit.org/show_bug.cgi?id=168323
3380 Reviewed by Michael Catanzaro.
3382 Add a --default-cmake-features switch that makes the script pass
3383 no value for any of the features defined by build-webkit, that
3384 way the default values from the port cmake config will be used.
3386 * Scripts/build-webkit:
3387 (cMakeArgsFromFeatures):
3389 2017-02-14 Jonathan Bedard <jbedard@apple.com>
3391 Unreviewed build-fix after r212297.
3393 * Scripts/webkitpy/port/simulator_process.py:
3394 (SimulatorProcess.stop): Handle case where there is no process to kill.
3396 2017-02-14 Carlos Alberto Lopez Perez <clopez@igalia.com>
3398 [CMake] build-webkit should print the cmake command executed
3399 https://bugs.webkit.org/show_bug.cgi?id=168318
3401 Reviewed by Michael Catanzaro.
3403 Run the cmake commands to configure or start the build through
3404 a wrapper that prints the command before executing it.
3406 * Scripts/webkitdirs.pm:
3408 (generateBuildSystemFromCMakeProject):
3409 (buildCMakeGeneratedProject):
3410 (cleanCMakeGeneratedProject):
3412 2017-02-14 Jonathan Bedard <jbedard@apple.com>
3414 run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
3415 https://bugs.webkit.org/show_bug.cgi?id=168150
3417 Reviewed by Alexey Proskuryakov.
3419 * Scripts/webkitpy/port/simulator_process.py:
3420 (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
3421 (SimulatorProcess._kill): Move closing of app into stop().
3422 * Scripts/webkitpy/xcode/simulator.py:
3423 (Device.launch_app):
3424 (Device.terminate_app): Deleted.
3426 2017-02-14 Carlos Garcia Campos <cgarcia@igalia.com>
3428 REGRESSION(r212192): [GTK] Broke downloads API tests
3429 https://bugs.webkit.org/show_bug.cgi?id=168193
3431 Unreviewed. Update test expectations after r212192.
3433 The suggested filename now includes a file extensions if the MIME type is known.
3435 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3436 (testDownloadRemoteFile):
3437 (testDownloadMIMEType):
3439 2017-02-14 Commit Queue <commit-queue@webkit.org>
3441 Unreviewed, rolling out r212237.
3442 https://bugs.webkit.org/show_bug.cgi?id=168298
3444 This was a wrong fix (Requested by rniwa on #webkit).
3448 "Nwtr unexpectedly passes mismatch ref test if the hashes
3449 doesn't match but no diff"
3450 https://bugs.webkit.org/show_bug.cgi?id=168221
3451 http://trac.webkit.org/changeset/212237
3453 2017-02-13 Alex Christensen <achristensen@webkit.org>
3455 URLs with an invalid IPv4 address should be invalid
3456 https://bugs.webkit.org/show_bug.cgi?id=168260
3458 Reviewed by Tim Horton.
3460 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3461 (TestWebKitAPI::TEST_F):
3462 Update tests to reflect new correct behavior.
3464 2017-02-13 Don Olmstead <don.olmstead@am.sony.com>
3466 [WinCairo] Add Build Slave
3467 https://bugs.webkit.org/show_bug.cgi?id=168263
3469 Reviewed by Lucas Forschler.
3471 * BuildSlaveSupport/build.webkit.org-config/config.json:
3473 2017-02-13 Wenson Hsieh <wenson_hsieh@apple.com>
3475 Fix the build after r212254
3477 * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3478 (-[DataInteractionSimulator _currentLocation]):
3480 2017-02-13 Wenson Hsieh <wenson_hsieh@apple.com>
3482 [WK2] Add test infrastructure and unit tests for data interaction
3483 https://bugs.webkit.org/show_bug.cgi?id=168159
3484 <rdar://problem/30477634>
3486 Reviewed by Tim Horton.
3488 Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
3489 interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
3490 recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
3491 gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
3492 gesture has already been recognized) at regular intervals over the course of the test.
3494 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3495 * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
3496 * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
3497 * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
3499 New test pages for data interaction.
3501 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
3502 (TestWebKitAPI::runTestsExpectingToObserveEvents):
3503 (TestWebKitAPI::TEST):
3504 * TestWebKitAPI/cocoa/TestWKWebView.mm:
3505 (-[TestWKWebView stringByEvaluatingJavaScript:]):
3506 * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
3507 * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
3508 (-[MockLongPressGestureRecognizer initWithWindow:]):
3509 (-[MockLongPressGestureRecognizer locationInView:]):
3510 (-[MockLongPressGestureRecognizer state]):
3511 (-[MockLongPressGestureRecognizer numberOfTouches]):
3512 (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
3513 (-[DataInteractionSimulator dealloc]):
3514 (-[DataInteractionSimulator run]):
3516 Performs a data interaction gesture from the start location to the end location with linear interpolation. For
3517 now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
3518 in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
3520 (-[DataInteractionSimulator _advanceProgress]):
3522 Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
3523 completed, and calls _finishDataInteraction when progress is at 1.
3525 (-[DataInteractionSimulator _finishDataInteraction]):
3526 (-[DataInteractionSimulator _currentLocation]):
3527 (-[DataInteractionSimulator _scheduleAdvanceProgress]):
3528 (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
3529 (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
3530 (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
3531 (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
3533 2017-02-13 Alex Christensen <achristensen@webkit.org>
3535 Percent should be allowed in non-special URL hosts
3536 https://bugs.webkit.org/show_bug.cgi?id=168255
3538 Reviewed by Tim Horton.
3540 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3541 (TestWebKitAPI::TEST_F):
3543 2017-02-13 Fujii Hironori <Hironori.Fujii@sony.com>
3545 Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
3546 https://bugs.webkit.org/show_bug.cgi?id=168221
3548 Reviewed by Ryosuke Niwa.
3550 There is a logic error in comparing mismatch ref test images. In
3551 mismatch ref tests, it should be failed if two images has no diff.
3552 But, if the hashes are different, nwtr unexpectedly pass the
3555 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3556 (SingleTestRunner._compare_output_with_reference): Fail the
3557 mismatch ref test if hashes of two images are equal. Invoke
3558 ImageDiff if the hashes don't match.
3560 2017-02-13 Myles C. Maxfield <mmaxfield@apple.com>
3562 Update custom line breaking iterators to the latest version of Unicode
3563 https://bugs.webkit.org/show_bug.cgi?id=168182
3565 Reviewed by Zalan Bujtas.
3567 Treat the system's ICU as the source of truth to compare breaking positions against.
3569 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3570 * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
3571 (generateJavaScriptForTest):
3572 (breakingLocationsFromICU):
3575 * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
3576 * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
3578 2017-02-12 Michael Catanzaro <mcatanzaro@igalia.com>
3580 [GTK] Several failing WebViewEditor API tests
3581 https://bugs.webkit.org/show_bug.cgi?id=161608
3583 Reviewed by Carlos Garcia Campos.
3585 Selection.collapse() requires arguments; passing no arguments means the JS that selects the
3586 text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
3587 Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
3588 except the first one, which is still broken due to unrelated bug #151654.
3590 * Scripts/run-gtk-tests:
3592 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3594 2017-02-12 Michael Catanzaro <mcatanzaro@igalia.com>
3596 Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
3598 * Scripts/run-gtk-tests:
3601 2017-02-12 Michael Catanzaro <mcatanzaro@igalia.com>
3603 Unreviewed, skip flaky form-controls-associated-signal test
3605 * Scripts/run-gtk-tests:
3608 2017-02-12 Carlos Garcia Campos <cgarcia@igalia.com>
3610 [GTK] Handle caps lock indicator in event modifiers
3611 https://bugs.webkit.org/show_bug.cgi?id=168186
3613 Reviewed by Michael Catanzaro.
3615 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3616 (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
3618 2017-02-11 Simon Fraser <simon.fraser@apple.com>
3620 MiniBrowser WK1 fails to update URL for within-page navigations
3621 https://bugs.webkit.org/show_bug.cgi?id=168173
3623 Reviewed by Tim Horton.
3625 Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
3626 anchors updates the URL field.
3628 * MiniBrowser/mac/WK1BrowserWindowController.m:
3629 (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
3631 2017-02-10 John Wilander <wilander@apple.com>
3633 Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
3634 https://bugs.webkit.org/show_bug.cgi?id=167474
3635 <rdar://problem/24681808>
3636 <rdar://problem/24703286>
3637 <rdar://problem/30290270>
3639 This patch adds test infrastructure to allow testing
3640 of the various rules in place for data records removal.
3642 Reviewed by Andy Estes.
3644 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3645 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3646 (WTR::InjectedBundle::didReceiveMessageToPage):
3647 Callback mechanism to tell pages that a website data store
3649 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3650 (WTR::TestRunner::setStatisticsPrevalentResource):
3651 (WTR::TestRunner::isStatisticsPrevalentResource):
3652 (WTR::TestRunner::setStatisticsHasHadUserInteraction):
3653 (WTR::TestRunner::isStatisticsHasHadUserInteraction):
3654 (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
3655 (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
3656 (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
3657 (WTR::TestRunner::statisticsFireDataModificationHandler):
3658 (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3659 (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
3660 (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
3661 (WTR::TestRunner::statisticsResetToConsistentState):
3662 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3663 * WebKitTestRunner/TestController.cpp:
3664 (WTR::TestController::setStatisticsPrevalentResource):
3665 (WTR::TestController::isStatisticsPrevalentResource):
3666 (WTR::TestController::setStatisticsHasHadUserInteraction):
3667 (WTR::TestController::isStatisticsHasHadUserInteraction):
3668 (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3669 (WTR::TestController::statisticsFireDataModificationHandler):
3670 (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3671 (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
3672 (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
3673 (WTR::TestController::statisticsResetToConsistentState):
3674 * WebKitTestRunner/TestController.h:
3675 These are all configuration and test functions.
3676 * WebKitTestRunner/TestInvocation.cpp:
3677 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3679 2017-02-10 Carlos Alberto Lopez Perez <clopez@igalia.com>
3681 REGRESSION(r182916) run-perf-tests never timeouts
3682 https://bugs.webkit.org/show_bug.cgi?id=167626
3684 Reviewed by Ryosuke Niwa.
3686 The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
3687 was beeing ignored because the driver was created with no_timeout=True
3689 This adds a new parameter --no-timeout (disabled by default), that
3690 allows to use the driver with the expected timeout values.
3691 It also passes --no-timeout to DRT/WTR to ensure that timeouts
3692 are always controlled by the Python Driver.
3694 * Scripts/webkitpy/performance_tests/perftest.py:
3695 (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
3696 (PerfTest.run): Disabling timeout should be done when the Driver is created.
3697 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3698 (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
3699 (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
3700 (_run_tests_set): Pass the no-timeout parameter.
3701 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3702 (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
3703 (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
3704 (MainTest.test_parse_args): Test that the argument no-timeout.
3706 2017-02-10 Daniel Bates <dabates@apple.com>
3708 Detach frame from document when entering page cache
3709 https://bugs.webkit.org/show_bug.cgi?id=166774
3710 <rdar://problem/29904368>
3712 Reviewed by Chris Dumez.
3714 * DumpRenderTree/mac/DumpRenderTree.mm:
3715 (resetWebPreferencesToConsistentValues):
3716 * DumpRenderTree/win/DumpRenderTree.cpp:
3717 (resetWebPreferencesToConsistentValues):
3718 * WebKitTestRunner/TestController.cpp:
3719 (WTR::TestController::resetPreferencesToConsistentValues):
3721 2017-02-10 Tim Horton <timothy_horton@apple.com>
3723 Infinite UI process hang under ensurePositionInformationIsUpToDate
3724 https://bugs.webkit.org/show_bug.cgi?id=168154
3725 <rdar://problem/30428673>
3727 Reviewed by Simon Fraser.
3729 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3730 * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
3731 (recursiveFindHighlightLongPressRecognizer):
3733 Add a somewhat nasty test that does an async interaction information update, but
3734 kills the Web process before it arrives, and then does a sync interaction
3735 information update, which will wait for the oustanding async interaction
3736 information update if we still think it's coming. Before the patch, this
3737 test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
3739 2017-02-10 Simon Fraser <simon.fraser@apple.com>
3741 Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
3742 https://bugs.webkit.org/show_bug.cgi?id=168127
3743 rdar://problem/30467120
3745 Reviewed by Tim Horton.
3747 Reparent the web view before we try to fetch it via:
3748 [[[window contentView] subviews] objectAtIndex:0];
3749 which would throw an exception if the test unparented it.
3751 * DumpRenderTree/mac/DumpRenderTree.mm:
3752 (resetWebViewToConsistentStateBeforeTesting):
3755 2017-02-10 Joseph Pecoraro <pecoraro@apple.com>
3757 [Resource Timing] Enable Resource Timing by default in Tests
3758 https://bugs.webkit.org/show_bug.cgi?id=168145
3760 Reviewed by Ryosuke Niwa.
3762 * DumpRenderTree/mac/DumpRenderTree.mm:
3763 (resetWebPreferencesToConsistentValues):
3764 * DumpRenderTree/win/DumpRenderTree.cpp:
3765 (resetWebPreferencesToConsistentValues):
3766 * WebKitTestRunner/TestController.cpp:
3767 (WTR::TestController::resetPreferencesToConsistentValues):
3769 2017-02-10 Jonathan Bedard <jbedard@apple.com>
3771 Removing LayoutTestRelay
3772 https://bugs.webkit.org/show_bug.cgi?id=165927
3774 Reviewed by Daniel Bates.
3777 LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
3778 simulators through simctl (iOS 10 and later), use this functionality instead.
3780 * BuildSlaveSupport/built-product-archive:
3781 (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
3782 Added a FIXME that we will need to implement similar archiving machinery once we build
3783 ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
3784 * BuildSlaveSupport/kill-old-processes:
3785 (main): Remove LayoutTestRelay from list of processes.
3786 * LayoutTestRelay: Removed LayoutTestRelay.
3788 * Scripts/build-layouttestrelay: Removed.
3789 * Scripts/build-webkit: Removed LayoutTestRelay references.
3791 2017-02-10 Jiewen Tan <jiewen_tan@apple.com>
3793 [WebCrypto] Add WebCryptoAPI to watchlist
3794 https://bugs.webkit.org/show_bug.cgi?id=168138
3796 Reviewed by Youenn Fablet.
3798 * Scripts/webkitpy/common/config/watchlist:
3800 2017-02-10 Brady Eidson <beidson@apple.com>
3802 Replace all WebKit Library Version checks in WK2 with SDK version checks.
3803 https://bugs.webkit.org/show_bug.cgi?id=168124
3805 Reviewed by Geoffrey Garen.
3807 For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
3809 * MiniBrowser/mac/main.m:
3811 * MobileMiniBrowser/MobileMiniBrowser/main.m:
3813 * TestWebKitAPI/ios/mainIOS.mm:
3815 * TestWebKitAPI/mac/mainMac.mm:
3817 * WebKitTestRunner/ios/mainIOS.mm:
3819 * WebKitTestRunner/mac/main.mm:
3820 (setDefaultsToConsistentValuesForTesting):
3822 2017-02-10 Alex Christensen <achristensen@webkit.org>
3824 Fix El Capitan build.
3826 * Scripts/build-webkit:
3827 Don't build libwebrtc anywhere for now.
3829 2017-02-10 Andy Estes <aestes@apple.com>
3831 Move two MiniBrowserBundle settings out of the .pbxproj
3832 https://bugs.webkit.org/show_bug.cgi?id=168106
3834 Reviewed by Tim Horton.
3836 INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
3837 the project file. This removes the project file override.
3839 WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
3841 * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
3842 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3844 2017-02-10 Alex Christensen <achristensen@webkit.org>
3846 Fix 32-and-64-bit build on El Capitan.
3848 * Scripts/build-webkit:
3849 Somebody's building with something like this:
3850 build-webkit ARCHS="i386 x86_64"
3851 We want this to also not build libwebrtc for now.
3853 2017-02-10 Alex Christensen <achristensen@webkit.org>
3855 Fix 32-bit build on El Capitan.
3857 * Scripts/build-webkit:
3858 The bot uses ARCHS=i386 instead of --32-bit.
3859 This is a hack, but it should fix the bot until I can do a better fix in the morning.
3861 2017-02-10 Alex Christensen <achristensen@webkit.org>
3863 Fix 32-bit build on El Capitan.
3865 * Scripts/build-webkit:
3866 Don't build i386 libwebrtc.
3868 2017-02-09 Alex Christensen <achristensen@webkit.org>
3870 Unreviewed, rolling out r212040.
3872 Broke build. I'm not surprised
3876 "[WebRTC][Mac] Activate libwebrtc"
3877 https://bugs.webkit.org/show_bug.cgi?id=167293
3878 http://trac.webkit.org/changeset/212040
3880 2017-02-09 Alex Christensen <achristensen@webkit.org>
3882 Build libwebrtc on bots without using it yet
3883 https://bugs.webkit.org/show_bug.cgi?id=168062
3885 Reviewed by Brent Fulgham.
3887 * Scripts/build-webkit:
3889 2017-02-09 Alex Christensen <achristensen@webkit.org>
3891 Don't build libwebrtc.
3893 * Scripts/build-webkit:
3894 Not ready yet. It broke El Capitan and iOS.
3896 2017-02-09 Alex Christensen <achristensen@webkit.org>
3898 Build libwebrtc on bots without using it yet
3899 https://bugs.webkit.org/show_bug.cgi?id=168062
3901 Reviewed by Brent Fulgham.
3903 * Scripts/build-webkit:
3905 2017-02-09 Alex Christensen <achristensen@webkit.org>
3907 Rename isAppleMacWebKit to isAppleCocoaWebKit
3908 https://bugs.webkit.org/show_bug.cgi?id=168075
3910 Reviewed by Geoffrey Garen.
3912 It returns true for Mac and iOS. "isAppleMacWebKit" is confusing and wrong.
3914 * Scripts/build-api-tests:
3915 * Scripts/build-dumprendertree:
3916 * Scripts/build-jsc:
3918 * Scripts/build-layouttestrelay:
3919 * Scripts/build-webkit:
3920 * Scripts/build-webkittestrunner:
3921 * Scripts/run-api-tests:
3922 (isSupportedPlatform):
3925 (prepareEnvironmentForRunningTestTool):
3926 * Scripts/run-content-extension-tester:
3927 * Scripts/run-javascriptcore-tests:
3928 * Scripts/run-minibrowser:
3929 * Scripts/show-pretty-diff:
3930 * Scripts/webkitdirs.pm:
3931 (determineBaseProductDir):
3932 (determineArchitecture):
3933 (determinePassedArchitecture):
3935 (builtDylibPathForName):
3938 (isAppleCocoaWebKit):
3941 (wrapperPrefixIfNeeded):
3943 (mobileSafariBundle):
3948 (runWebKitTestRunner):
3949 (debugWebKitTestRunner):
3950 (isAppleMacWebKit): Deleted.
3951 * Scripts/webkitperl/FeatureList.pm:
3953 2017-02-09 Alex Christensen <achristensen@webkit.org>
3956 https://bugs.webkit.org/show_bug.cgi?id=168062
3958 * Scripts/build-webkit:
3959 Not quite ready yet.
3961 2017-02-09 Alex Christensen <achristensen@webkit.org>
3963 Build libwebrtc on bots without using it yet
3964 https://bugs.webkit.org/show_bug.cgi?id=168062
3966 Reviewed by Brent Fulgham.
3968 * Scripts/build-webkit:
3969 Build libwebrtc on Mac when we build ANGLE.
3971 2017-02-09 Youenn Fablet <youenn@apple.com>
3973 Improve W3C importer command line options
3974 https://bugs.webkit.org/show_bug.cgi?id=167448
3976 Reviewed by Ryosuke Niwa.
3978 Making the list of test paths to import the main arguments of the script.
3979 Allow passing the source directory to import as a -s option.
3980 Adding a warning when given test paths are skipped by default in ImportExpectations.
3982 Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
3983 Link conversion rules do not change when imported tests are downloaded by the script.
3985 * Scripts/webkitpy/w3c/test_importer.py:
3988 (TestImporter.__init__):
3989 (TestImporter.do_import):
3991 (TestImporter.check_imported_expectations):
3993 2017-02-08 Chris Dumez <cdumez@apple.com>
3995 Update web-platform-tests resources
3996 https://bugs.webkit.org/show_bug.cgi?id=168026
3998 Reviewed by Youenn Fablet.
4000 Stop copying testharness.js from resources/ to web-platform-tests/resources.
4002 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
4003 (WebPlatformTestServer._copy_webkit_test_files):
4005 2017-02-08 Andy Estes <aestes@apple.com>
4007 Custom protocols should not continue loading after a network process crash
4008 https://bugs.webkit.org/show_bug.cgi?id=168028
4009 <rdar://problem/27607520>
4011 Reviewed by Brady Eidson.
4013 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
4015 (-[CloseWhileStartingProtocol startLoading]):
4016 (-[CloseWhileStartingProtocol stopLoading]):
4017 (TestWebKitAPI::runTest):
4018 (TestWebKitAPI::TEST):
4020 2017-02-08 Dan Bernstein <mitz@apple.com>
4022 [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
4023 https://bugs.webkit.org/show_bug.cgi?id=168031
4025 Reviewed by Tim Horton.
4027 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
4028 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
4030 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
4031 (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
4033 2017-02-08 Chris Dumez <cdumez@apple.com>
4035 Use smaller tiles in windows that are not active to facilitate App Napping
4036 https://bugs.webkit.org/show_bug.cgi?id=167997
4037 <rdar://problem/30358835>
4039 Reviewed by Simon Fraser.
4041 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4042 (WTR::PlatformWebView::setWindowIsKey):
4043 Actually update windowIsKey state of NSWindow so the WebView
4044 properly updates its activity state.
4046 2017-02-08 Wenson Hsieh <wenson_hsieh@apple.com>
4048 Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
4049 https://bugs.webkit.org/show_bug.cgi?id=167942
4050 <rdar://problem/30315079>
4052 Reviewed by Tim Horton.
4054 Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
4055 contenteditable area. An image element and the plain text content, respectively, should be inserted into the
4056 contenteditable in these cases.
4058 The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
4059 events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
4060 performDragOperation:) directly.
4062 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4063 * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
4064 (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
4065 (-[FrameLoadCompletionListener initWithCompletionBlock:]):
4066 (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
4067 (-[DragSource draggingSourceOperationMaskForLocal:]):
4068 (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
4069 (-[DragInfo lastMousePosition]):
4070 (-[DragInfo setLastMousePosition:]):
4071 (-[DragInfo draggingDestinationWindow]):
4072 (-[DragInfo draggingSourceOperationMask]):
4073 (-[DragInfo draggingLocation]):
4074 (-[DragInfo draggedImageLocation]):
4075 (-[DragInfo draggedImage]):
4076 (-[DragInfo draggingPasteboard]):
4077 (-[DragInfo draggingSource]):
4078 (-[DragInfo draggingSequenceNumber]):
4079 (-[DragInfo slideDraggedImageTo:]):
4080 (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
4081 (-[DragInfo draggingFormation]):
4082 (-[DragInfo setDraggingFormation:]):
4083 (-[DragInfo animatesToDestination]):
4084 (-[DragInfo setAnimatesToDestination:]):
4085 (-[DragInfo numberOfValidItemsForDrop]):
4086 (-[DragInfo setNumberOfValidItemsForDrop:]):
4087 (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
4088 (-[DragInfo springLoadingHighlight]):
4089 (-[DragInfo resetSpringLoading]):
4090 (TestWebKitAPI::getTestImage):
4091 (TestWebKitAPI::webViewAfterPerformingDragOperation):
4092 (TestWebKitAPI::TEST):
4093 * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
4095 2017-02-08 Jer Noble <jer.noble@apple.com>
4097 Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
4098 https://bugs.webkit.org/show_bug.cgi?id=168007
4100 Reviewed by Alex Christensen.
4102 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
4103 (didFinishLoadForFrame):
4104 (TestWebKitAPI::TEST):
4106 2017-02-08 Commit Queue <commit-queue@webkit.org>
4108 Unreviewed, rolling out r211873.
4109 https://bugs.webkit.org/show_bug.cgi?id=168001
4111 It's in jhbuild for consistent layout tests (Requested by
4112 mcatanzaro on #webkit).
4116 "[GTK] Add icu packages to Tools/gtk/install-dependencies"
4117 https://bugs.webkit.org/show_bug.cgi?id=167993
4118 http://trac.webkit.org/changeset/211873
4120 2017-02-08 Adrian Perez de Castro <aperez@igalia.com>
4122 [GTK] Add icu packages to Tools/gtk/install-dependencies
4123 https://bugs.webkit.org/show_bug.cgi?id=167993
4125 Reviewed by Michael Catanzaro.
4127 * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
4128 depending in the GNU/Linux distribution)
4130 2017-02-07 Ryan Haddad <ryanhaddad@apple.com>
4132 Update flakiness dashboard configuration.
4133 https://bugs.webkit.org/show_bug.cgi?id=167957
4135 Reviewed by Alexey Proskuryakov.
4137 * TestResultServer/static-dashboards/builders.jsonp:
4139 2017-02-07 Ryan Haddad <ryanhaddad@apple.com>
4141 Replace a bot that has an incorrect configuration.
4142 https://bugs.webkit.org/show_bug.cgi?id=167747
4144 Rubber-stamped by Alexey Proskuryakov.
4146 * BuildSlaveSupport/build.webkit.org-config/config.json:
4148 2017-02-07 Myles C. Maxfield <mmaxfield@apple.com>
4150 [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
4151 https://bugs.webkit.org/show_bug.cgi?id=167927
4153 Reviewed by Brent Fulgham.
4155 Enable ComplexTextController API tests on the Win and GTK ports.
4157 * TestWebKitAPI/PlatformGTK.cmake:
4158 * TestWebKitAPI/PlatformWin.cmake:
4160 2017-02-07 Jonathan Bedard <jbedard@apple.com>
4162 File index appended to previous file in svn-create-patch with SVN 1.9
4163 https://bugs.webkit.org/show_bug.cgi?id=167903
4164 <rdar://problem/30387395>
4166 Reviewed by Daniel Bates.
4168 * Scripts/VCSUtils.pm:
4169 (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
4170 * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
4171 trailing newline character from the expected result before comparing it to the actual result.
4173 2017-02-07 Olivier Blin <olivier.blin@softathome.com>
4175 [webkitdirs] remove unused host_processor variable in determineArchitecture()
4176 https://bugs.webkit.org/show_bug.cgi?id=167936
4178 Reviewed by Michael Catanzaro.
4180 * Scripts/webkitdirs.pm:
4181 (determineArchitecture):
4182 The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
4185 2017-02-07 Youenn Fablet <youenn@apple.com>
4187 Use a JSON file to define which WPT files/folders to import
4188 https://bugs.webkit.org/show_bug.cgi?id=167923
4190 Reviewed by Alex Christensen.
4192 * Scripts/webkitpy/w3c/test_downloader.py:
4193 (TestDownloader.__init__):
4194 (TestDownloader._init_paths_from_expectations):
4195 * Scripts/webkitpy/w3c/test_importer.py:
4197 * Scripts/webkitpy/w3c/test_importer_unittest.py:
4199 2017-02-06 Fujii Hironori <Hironori.Fujii@sony.com>
4201 [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
4202 https://bugs.webkit.org/show_bug.cgi?id=167916
4204 Reviewed by Carlos Garcia Campos.
4206 URL of mesa-11.0.6.tar.xz has been moved.
4208 * gtk/jhbuild.modules: Fix the module path.
4210 2017-02-06 Joseph Pecoraro <pecoraro@apple.com>
4212 Static Analyzer: Address some leaks in MiniBrowser
4213 https://bugs.webkit.org/show_bug.cgi?id=167897
4215 Reviewed by Alexey Proskuryakov.
4217 * MiniBrowser/mac/BrowserWindowController.m:
4218 (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
4219 * MiniBrowser/mac/ExtensionManagerWindowController.m:
4220 (-[ExtensionManagerWindowController add:]):
4221 (-[ExtensionManagerWindowController remove:]):
4222 * MiniBrowser/mac/SettingsController.m:
4223 (-[SettingsController _populateMenu]):
4224 (-[SettingsController togglePerWindowWebProcessesDisabled:]):
4225 Address obvious leaks caught by the static analyzer.
4227 2017-02-06 Myles C. Maxfield <mmaxfield@apple.com>
4229 Migrate ComplexTextController to use platform-independent types
4230 https://bugs.webkit.org/show_bug.cgi?id=167833
4232 Reviewed by Brent Fulgham.
4234 Migrate tests away from platform-dependent types.
4236 * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
4237 (TestWebKitAPI::TEST_F):
4239 2017-02-06 Brent Fulgham <bfulgham@apple.com>
4241 Correct File Path Handling in SecurityOrigin and FileSystem
4242 https://bugs.webkit.org/show_bug.cgi?id=167894
4243 <rdar://problem/30380080>
4245 Reviewed by Alexey Proskuryakov.
4247 * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
4248 and perform same-volume checks using filesystem-compatible paths.
4249 * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
4250 filesystem paths, and perform validation of same-volume checks.
4251 (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
4252 (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
4253 (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
4254 (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
4256 2017-02-06 Jer Noble <jer.noble@apple.com>
4258 Playback stalls when a SourceBuffer append causes frame eviction
4259 https://bugs.webkit.org/show_bug.cgi?id=167834
4261 Reviewed by Eric Carlson.
4263 Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
4264 for the WTF::MediaTime class.
4266 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4267 * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
4268 (TestWebKitAPI::TEST):
4269 * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
4271 (TestWebKitAPI::TestSample::create):
4272 (TestWebKitAPI::TestSample::TestSample):
4273 (TestWebKitAPI::TEST_F):
4275 2017-02-06 Ryan Haddad <ryanhaddad@apple.com>
4277 Change capitalization in platform name after r211735.
4279 Unreviewed dashboard fix.
4281 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4284 2017-02-06 Alexey Proskuryakov <ap@apple.com>
4286 Move the Leaks bot to Sierra
4287 https://bugs.webkit.org/show_bug.cgi?id=167886
4289 Reviewed by Daniel Bates.
4291 * BuildSlaveSupport/build.webkit.org-config/config.json:
4292 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4293 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
4294 (LeaksViewer._displayURLPrompt):
4295 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4298 2017-02-06 Jonathan Bedard <jbedard@apple.com>
4300 Prevent app crash on launch during simctl install workaround
4301 https://bugs.webkit.org/show_bug.cgi?id=167685
4303 Reviewed by Daniel Bates.
4305 * Scripts/webkitpy/port/simulator_process.py:
4306 (SimulatorProcess.__init__): Pass environment to install.
4307 * Scripts/webkitpy/xcode/simulator.py:
4308 (Device.install_app): Accept environment, pass environment to launch.
4310 2017-02-06 Alex Christensen <achristensen@webkit.org>
4312 Rebase API tests after r211638
4313 https://bugs.webkit.org/show_bug.cgi?id=167779
4315 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4316 (TestWebKitAPI::TEST_F):
4317 URLs with non-special schemes and characters like % in the host now fail to parse,
4318 more like their special counterparts and according to spec.
4320 2017-02-06 Csaba Osztrogonác <ossy@webkit.org>
4322 Unreviewed trivial fix after r211697.
4323 https://bugs.webkit.org/show_bug.cgi?id=167863
4325 * Scripts/run-javascriptcore-tests:
4326 (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
4328 2017-02-04 Simon Fraser <simon.fraser@apple.com>
4330 Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
4331 https://bugs.webkit.org/show_bug.cgi?id=167850
4333 Reviewed by Tim Horton.
4335 * DumpRenderTree/TestRunner.cpp:
4336 (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
4338 2017-02-04 Andreas Kling <akling@apple.com>
4340 Plug some leaks in TestController and UIScriptContext.
4341 <https://webkit.org/b/167839>
4343 Reviewed by Alexey Proskuryakov.
4345 Fix a couple of the leaks seen on the leaks bot.
4347 * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
4348 (UIScriptContext::runUIScript):
4349 * WebKitTestRunner/TestController.cpp:
4350 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
4351 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
4353 2017-02-03 Jeremy Jones <jeremyj@apple.com>
4355 WK1 mouse events are missing movementX and movementY for pointerlock.
4356 https://bugs.webkit.org/show_bug.cgi?id=167775
4357 rdar://problem/30343810
4359 Reviewed by Alexey Proskuryakov.
4361 Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
4363 * DumpRenderTree/mac/EventSendingController.mm:
4364 (-[EventSendingController mouseMoveToX:Y:]):
4365 * WebKitTestRunner/mac/EventSenderProxy.mm:
4366 (WTR::EventSenderProxy::mouseMoveTo):
4368 2017-02-03 Simon Fraser <simon.fraser@apple.com>
4370 Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
4371 https://bugs.webkit.org/show_bug.cgi?id=167774
4373 Reviewed by Tim Horton.
4375 Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
4376 up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
4377 web process are async, so the callback fires after the web process gets the new state.
4379 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4380 (WTR::UIScriptController::removeViewFromWindow):
4381 (WTR::UIScriptController::addViewToWindow):
4382 * DumpRenderTree/mac/DumpRenderTree.mm:
4383 (createWebViewAndOffscreenWindow):
4384 (resetWebViewToConsistentStateBeforeTesting):
4385 * DumpRenderTree/mac/DumpRenderTreeMac.h:
4386 * DumpRenderTree/mac/UIScriptControllerMac.mm:
4387 (WTR::UIScriptController::removeViewFromWindow):
4388 (WTR::UIScriptController::addViewToWindow):
4389 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4390 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4391 (WTR::UIScriptController::removeViewFromWindow):
4392 (WTR::UIScriptController::addViewToWindow):
4393 * TestRunnerShared/UIScriptContext/UIScriptController.h:
4394 * WebKitTestRunner/PlatformWebView.h:
4395 * WebKitTestRunner/TestController.cpp:
4396 (WTR::TestController::resetStateToConsistentValues):
4397 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4398 (WTR::PlatformWebView::removeFromWindow):
4399 (WTR::PlatformWebView::addToWindow):
4400 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4401 (WTR::UIScriptController::removeViewFromWindow):
4402 (WTR::UIScriptController::addViewToWindow):
4403 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4404 (WTR::PlatformWebView::removeFromWindow):
4405 (WTR::PlatformWebView::addToWindow):
4406 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4407 (WTR::UIScriptController::removeViewFromWindow):
4408 (WTR::UIScriptController::addViewToWindow):
4410 2017-02-03 Alexey Proskuryakov <ap@apple.com>
4412 Remove check for SkipSafariExecutableEntitlementChecks
4413 https://bugs.webkit.org/show_bug.cgi?id=167762
4415 Reviewed by Dan Bernstein.
4417 Follow-up fix: don't break internal behavior.
4419 * Scripts/webkitdirs.pm:
4421 (executableHasEntitlements): Deleted.
4422 (safariPathFromSafariBundle): Deleted.
4423 (installedSafariPath): Deleted.
4425 2017-02-03 Daniel Bates <dabates@apple.com>
4427 [Mac][WK2] Add SPI to override the Content Security Policy of a page
4428 https://bugs.webkit.org/show_bug.cgi?id=167810
4429 <rdar://problem/30102568>
4431 Reviewed by Anders Carlsson.
4433 Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
4435 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4436 * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
4438 * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
4439 * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
4440 * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
4441 * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
4443 2017-02-02 Alex Christensen <achristensen@webkit.org>
4445 URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
4446 https://bugs.webkit.org/show_bug.cgi?id=167773
4447 <rdar://problem/30221102>
4449 Reviewed by Ryosuke Niwa.
4451 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4452 (TestWebKitAPI::TEST_F):
4454 2017-02-02 Alexey Proskuryakov <ap@apple.com>
4456 Remove check for SkipSafariExecutableEntitlementChecks
4457 https://bugs.webkit.org/show_bug.cgi?id=167762
4458 rdar://problem/22480673
4460 Reviewed by Dan Bernstein.
4462 * Scripts/webkitdirs.pm:
4463 (safariPathFromSafariBundle):
4464 (skipSafariExecutableEntitlementChecks): Deleted.
4466 2017-02-02 Jonathan Bedard <jbedard@apple.com>
4468 Undefined subroutine in svn-create-patch
4469 https://bugs.webkit.org/show_bug.cgi?id=167742
4471 Unreviewed build-fix after r211543.
4473 * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
4475 2017-02-02 Xabier Rodriguez Calvar <calvaris@igalia.com>
4477 Unreviewed. Fix jhbuild dependencies build.
4479 * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
4482 2017-02-02 Xabier Rodriguez Calvar <calvaris@igalia.com>
4484 [EME][GStreamer] Fixed decryptor selection
4485 https://bugs.webkit.org/show_bug.cgi?id=167588
4487 Reviewed by Žan Doberšek.
4489 This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
4491 * gtk/jhbuild.modules: Added patches to gstreamer and
4492 gst-plugins-good packages.
4493 * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
4494 * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
4496 2017-02-01 Dewei Zhu <dewei_zhu@apple.com>
4498 Make run-benchmark script supports 'config' key in test plan.
4499 https://bugs.webkit.org/show_bug.cgi?id=167715
4501 Reviewed by Ryosuke Niwa.
4503 Add support for 'config' key in test paln.
4504 'config' key is a dictionary that specifies environment configurations while test is running.
4505 Specifies orientation to be portrait in MotionMark benchmark.
4507 * Scripts/webkitpy/benchmark_runner/README.md:
4508 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
4509 (BenchmarkRunner.__init__):
4510 (BenchmarkRunner._run_benchmark):
4511 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
4512 (BrowserDriver.prepare_env):
4513 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
4514 (LinuxBrowserDriver.prepare_env):
4515 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
4516 (OSXBrowserDriver.prepare_env):
4517 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
4518 (OSXSafariDriver.prepare_env):
4519 * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
4521 2017-02-01 Daniel Bates <dabates@apple.com>
4523 REGRESSION (r210820): svn-create-patch does not emit property change only diff
4524 https://bugs.webkit.org/show_bug.cgi?id=167169
4526 Reviewed by David Kilzer.
4528 More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
4529 - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
4530 header from the output of "svn diff" on a file that was copied or moved.
4532 Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
4533 chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
4534 output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
4535 of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
4536 line followed by a separator line) with an empty body; => no chunk range lines. However a diff
4537 of a file with only a property change also does not contain any chunk range lines. Therefore
4538 svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
4539 a SVN diff header with an empty body by counting the number of chunk range lines in the diff
4540 we should directly test for the presence of a leading SVN diff header with an empty body and
4541 remove such lines from the diff.
4543 * Scripts/VCSUtils.pm:
4544 (fixSVNPatchForAdditionWithHistory): Added.
4545 * Scripts/svn-create-patch:
4546 (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
4547 we have a non empty patch for an added file with history (i.e. a copied or moved file).
4548 * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
4550 2017-02-01 Eric Carlson <eric.carlson@apple.com>
4552 [Mac] Update CARingBuffer class
4553 https://bugs.webkit.org/show_bug.cgi?id=167656
4555 Reviewed by Jer Noble.
4557 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4558 * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
4559 (TestWebKitAPI::CARingBufferTest::SetUp):
4560 (TestWebKitAPI::CARingBufferTest::setup):
4561 (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
4562 (TestWebKitAPI::CARingBufferTest::description):
4563 (TestWebKitAPI::CARingBufferTest::bufferList):
4564 (TestWebKitAPI::CARingBufferTest::ringBuffer):
4565 (TestWebKitAPI::CARingBufferTest::capacity):
4566 (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
4567 (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
4568 (TestWebKitAPI::TEST_F):
4569 (TestWebKitAPI::MixingTest::run):
4571 2017-02-01 Alexey Proskuryakov <ap@apple.com>
4573 [Mac] TestWebKitAPI includes system frameworks incorrectly
4574 https://bugs.webkit.org/show_bug.cgi?id=167703
4575 rdar://problem/30301498
4577 Reviewed by Ryosuke Niwa.
4579 FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
4580 Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
4582 Also, reduced the number of subframework search paths, looks like we only need one now.
4584 * TestWebKitAPI/Configurations/Base.xcconfig:
4586 2017-02-01 Brent Fulgham <bfulgham@apple.com>
4588 Correct "filesHaveSameVolume" predicate
4589 https://bugs.webkit.org/show_bug.cgi?id=167696
4590 <rdar://problem/30298722>
4592 Reviewed by David Kilzer.
4594 Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
4595 percent-escaped path inputs.
4597 * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
4598 (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
4599 (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
4600 (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
4601 (TestWebKitAPI::TEST_F):
4603 2017-02-01 Tomas Popela <tpopela@redhat.com>
4605 Unreviewed. Fix coding style in MiniBrowser
4607 * MiniBrowser/gtk/BrowserWindow.c:
4608 (editingCommandCallback):
4609 (insertImageCommandCallback):
4610 (insertLinkCommandCallback):
4612 2017-02-01 Tomas Popela <tpopela@redhat.com>
4614 [GTK] Add an API to add a custom tab into the print dialog
4615 https://bugs.webkit.org/show_bug.cgi?id=151998
4617 Reviewed by Carlos Garcia Campos.
4619 Add a new WebKitPrintOperation/custom-widget test in TestPrinting
4620 that is testing a newly added API.
4622 * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
4623 (testPrintCustomWidget):
4626 2017-02-01 Enrique Ocaña González <eocanha@igalia.com>
4628 [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
4629 https://bugs.webkit.org/show_bug.cgi?id=166529
4631 Reviewed by Xabier Rodriguez-Calvar.
4633 * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
4634 New patch version accepted in GStreamer upstream.
4636 2017-02-01 Xabier Rodriguez Calvar <calvaris@igalia.com>
4638 [GTK] Install either libxfont1-dev or libxfont-dev as dependency
4639 https://bugs.webkit.org/show_bug.cgi?id=167498
4641 Reviewed by Carlos Garcia Campos.
4643 Depending on the distro version you can need either libxfont1-dev
4644 or libfont-dev to build with jhbuild.
4646 * gtk/install-dependencies:
4648 2017-01-31 Ryan Haddad <ryanhaddad@apple.com>
4650 Disable API test WebKit2.WKWebProcessPlugInRangeHandle
4651 https://bugs.webkit.org/show_bug.cgi?id=167594
4653 Unreviewed test gardening.
4655 Disabling this test while we investigate the cause of a timeout on ios-simulator.
4657 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
4660 2017-01-31 Filip Pizlo <fpizlo@apple.com>
4662 Move slow-running microbenchmarks out of JSTests/microbenchmarks
4663 https://bugs.webkit.org/show_bug.cgi?id=167676
4665 Reviewed by Saam Barati.
4667 * Scripts/run-javascriptcore-tests:
4668 (runJSCStressTests): Add slowMicrobenchmarks.yaml.
4670 2017-01-31 Megan Gardner <megan_gardner@apple.com>
4672 Make Dump Render Tree not crash
4673 https://bugs.webkit.org/show_bug.cgi?id=167667
4675 DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running.
4676 DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
4677 So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
4678 This does not fix any tests, it just fixes the crash.
4680 Reviewed by Simon Fraser.
4682 * DumpRenderTree/TestRunner.cpp:
4683 (TestRunner::callUIScriptCallback):
4685 2017-01-31 Jonathan Bedard <jbedard@apple.com>
4687 Workaround for simctl install failing to report install failure
4688 https://bugs.webkit.org/show_bug.cgi?id=167654
4690 Reviewed by Daniel Bates.
4692 simctl install will sometimes report success even though install has failed.
4693 To workaround this bug, we attempt an app launch after install to ensure
4694 install has succeeded.
4696 * Scripts/webkitpy/xcode/simulator.py:
4697 (Device.install_app): Attempt app launch after install, retry install if launch fails.
4698 (Device.launch_app): Correct comment.
4700 2017-01-31 Jonathan Bedard <jbedard@apple.com>
4702 Unreviewed webkitpy fix after r211405.
4704 * Scripts/webkitpy/xcode/simulator.py:
4705 (Device.launch_app): Remove @staticmethod on _log_debug_error.
4707 2017-01-31 Carlos Garcia Campos <cgarcia@igalia.com>
4709 Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
4711 * gtk/manifest.txt.in:
4713 2017-01-31 Chris Fleizach <cfleizach@apple.com>
4715 AX: enable search predication for iOS
4716 https://bugs.webkit.org/show_bug.cgi?id=167558
4717 <rdar://problem/30251367>
4719 Reviewed by Joanmarie Diggs.
4721 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
4722 (AccessibilityUIElement::uiElementForSearchPredicate):
4723 * DumpRenderTree/mac/AccessibilityCommonMac.h:
4724 * DumpRenderTree/mac/AccessibilityCommonMac.mm:
4725 (searchPredicateParameterizedAttributeForSearchCriteria):
4726 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4727 (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
4728 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4729 (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
4730 (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
4731 * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
4732 * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
4733 (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
4734 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4735 (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
4736 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4738 2017-01-30 Jonathan Bedard <jbedard@apple.com>
4740 Workaround for simctl launch bug
4741 https://bugs.webkit.org/show_bug.cgi?id=167613
4743 Reviewed by Daniel Bates.
4745 simctl launch will sometimes fail because of a race condition when many
4746 simulators are being run simultaneously. These failures will always have
4747 an exit code of 1. This change attempts to launch an app multiple times
4748 before reporting a failure to workaround this bug.
4750 * Scripts/webkitpy/xcode/simulator.py:
4751 (Device.launch_app): Execute multiple launch attempts, better logging of failures.
4753 2017-01-30 Alexey Proskuryakov <ap@apple.com>
4755 Commit queue fails to look at real name aliases for the reviewer
4756 https://bugs.webkit.org/show_bug.cgi?id=167422
4758 Reviewed by Joseph Pecoraro.
4760 * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4761 (test_has_valid_reviewer): Added tests.
4763 * Scripts/webkitpy/common/config/committers.py:
4764 (CommitterList._name_to_contributor_map):
4765 Made _name_to_contributor_map include alias names.
4767 * Scripts/webkitpy/common/config/committers_unittest.py:
4768 (CommittersTest.test_contributors_by_fuzzy_match):
4769 Removed subtests that are now obsolete, as these matches are strict. It is not
4770 obvious if distance based fuzzy matching for names is useful at all, but we can
4771 look into that some other time.
4773 2017-01-30 Aakash Jain <aakash_jain@apple.com>
4775 QueueStatusServer should have an explicit timeout for _fetch_url
4776 https://bugs.webkit.org/show_bug.cgi?id=167467
4778 Reviewed by Alexey Proskuryakov.
4780 * Scripts/webkitpy/common/net/statusserver.py:
4781 (StatusServer._fetch_url): Add an explicit timeout of 300s.
4783 2017-01-30 Kocsen Chung <kocsen_chung@apple.com>
4785 Add support for Trac instances that host multiple projects.
4786 https://bugs.webkit.org/show_bug.cgi?id=167524
4788 Reviewed by Alexey Proskuryakov.
4790 When multiple projects are hosted on a single Trac instance, the current
4791 behavior will retrieve changesets from all tracked projects.
4792 This patch teaches Trac.js to get project-specific changesets from Trac.
4793 We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
4794 when querying the Trac timeline.
4796 To tell Trac to be aware of multi-project instances we leverage the
4797 `options` parameter when creating a new instance:
4799 new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
4801 If this option is not provided, the original behaviour will prevail.
4802 Additionally, add corresponding tests.
4804 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
4805 (Trac): Reason about new optional parameter 'projectIdentifier'.
4806 (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
4807 (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
4808 replace default parameter `changeset=on` with `repo-projectname=on`.
4809 (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
4810 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
4811 (MockTrac): Add support for instantiating Trac with a projectIdentifier.
4812 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
4813 (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
4814 Add the following tests:
4816 test("revisionURL with Trac Identifier")
4817 test("_xmlTimelineURL")
4818 test("_xmlTimelineURL with Trac Identifier")
4819 (this.view._latestProductiveIteration): Fix missing ';'.
4821 2017-01-30 Myles C. Maxfield <mmaxfield@apple.com>
4823 Correct spacing regression on inter-element complex path shaping on some fonts
4824 https://bugs.webkit.org/show_bug.cgi?id=166013
4826 Reviewed by Simon Fraser.
4828 Unskip existing tests and make some new tests:
4829 - Testing complex text with no origins
4830 - Testing initial expansions
4831 - Testing the sign of vertical advances
4833 * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
4834 (TestWebKitAPI::TEST_F):
4836 2017-01-30 Carlos Alberto Lopez Perez <clopez@igalia.com>
4838 [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
4839 https://bugs.webkit.org/show_bug.cgi?id=167596
4841 Reviewed by Daniel Bates.
4843 We avoid needing a thin directory by invoking the zip program with
4844 the list of directories from the build directory to be zipped,
4845 and by using the zip feature to exclude files matching a pattern.
4847 * BuildSlaveSupport/built-product-archive:
4849 (createZipFromList):
4850 (archiveBuiltProduct):
4852 2017-01-30 Jonathan Bedard <jbedard@apple.com>
4854 Use simctl instead of LayoutTestRelay
4855 https://bugs.webkit.org/show_bug.cgi?id=165927
4857 Reviewed by Daniel Bates.
4861 LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
4862 simulators through simctl (iOS 10 and later), use this functionality instead.
4864 * Scripts/webkitpy/port/base.py:
4865 (Port.__init__): Added _test_runner_process_constructor.
4866 * Scripts/webkitpy/port/darwin.py:
4867 (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
4868 * Scripts/webkitpy/port/driver.py:
4869 (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
4870 (IOSSimulatorDriver): Deleted.
4871 * Scripts/webkitpy/port/driver_unittest.py:
4872 (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
4873 (DriverTest.test_two_starts_cleans_up_properly): Ditto.
4874 (DriverTest.test_start_actually_starts): Ditto.
4875 * Scripts/webkitpy/port/ios.py:
4876 (IOSSimulatorPort): Remove relay_name.
4877 (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
4878 (IOSSimulatorPort._create_simulators): Formatting change.
4879 (IOSSimulatorPort.relay_path): Deleted.
4880 (IOSSimulatorPort._check_relay): Deleted.
4881 (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
4882 (IOSSimulatorPort._build_relay): Deleted.
4883 (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
4884 (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
4885 * Scripts/webkitpy/port/ios_unittest.py:
4886 (iosTest.test_32bit): Update test.
4887 (iosTest.test_64bit): Update test.
4888 * Scripts/webkitpy/port/server_process.py:
4889 (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
4890 (ServerProcess._set_file_nonblocking): Added to share common code.
4891 * Scripts/webkitpy/port/server_process_mock.py:
4892 (MockServerProcess.__init__): Added argument worker_number.
4893 * Scripts/webkitpy/port/simulator_process.py: Added.
4894 (SimulatorProcess): Added.
4895 (SimulatorProcess.Popen): Added.
4896 (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
4897 (SimulatorProcess.Popen.poll): Added. Check if the process is running.
4898 (SimulatorProcess.Popen.wait): Added. Wait for process to close.
4899 (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
4900 (SimulatorProcess._reset): Added. Unlink fifos.
4901 (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
4902 (SimulatorProcess._kill): Added. Shutdown app on simulator.
4903 * Scripts/webkitpy/xcode/simulator.py:
4904 (Device.__init__): Accept host to run install/launch/terminate.
4905 (Device.install_app): Install app to target Device.
4906 (Device.launch_app): Launch app on target Device.
4907 (Device.terminate_app): Shutdown app on target Device.
4908 (Simulator._parse_devices): Pass host to Device.
4910 2017-01-30 Carlos Alberto Lopez Perez <clopez@igalia.com>
4912 [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
4913 https://bugs.webkit.org/show_bug.cgi?id=167411
4915 Reviewed by Michael Catanzaro.
4917 Disable the ARM iwMMXt fast path for pixman, because it triggers
4918 a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
4920 * gtk/jhbuild.modules:
4922 2017-01-30 Carlos Garcia Campos <cgarcia@igalia.com>
4924 [GTK] Add API to handle the accelerated compositing policy
4925 https://bugs.webkit.org/show_bug.cgi?id=167509
4927 Reviewed by Michael Catanzaro.
4929 Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
4930 as a special case. Also add test cases to the get/set API.
4932 * MiniBrowser/gtk/BrowserSettingsDialog.c:
4933 (hardwareAccelerationPolicyToString):
4934 (stringToHardwareAccelerationPolicy):
4935 (cellRendererChanged):
4936 (browserSettingsDialogConstructed):
4937 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
4938 (testWebKitSettings):
4940 2017-01-29 Andy Estes <aestes@apple.com>
4942 [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
4943 https://bugs.webkit.org/show_bug.cgi?id=167563
4944 <rdar://problem/30253207>
4946 Reviewed by Andreas Kling.
4948 * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
4949 (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4950 (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4952 (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
4955 2017-01-29 Dan Bernstein <mitz@apple.com>
4957 [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
4958 https://bugs.webkit.org/show_bug.cgi?id=167565
4960 Reviewed by Sam Weinig.
4962 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4963 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
4964 (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
4965 (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
4967 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
4968 (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4969 (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
4970 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
4972 2017-01-28 Yoav Weiss <yoav@yoav.ws>
4974 Add Link Preload as an off-by-default experimental feature menu item.
4975 https://bugs.webkit.org/show_bug.cgi?id=167201
4977 Reviewed by Ryosuke Niwa.
4979 * DumpRenderTree/mac/DumpRenderTree.mm:
4980 (resetWebPreferencesToConsistentValues):
4981 * DumpRenderTree/win/DumpRenderTree.cpp:
4982 (resetWebPreferencesToConsistentValues):
4984 2017-01-28 Joseph Pecoraro <pecoraro@apple.com>
4986 Add User Timing Experimental Feature
4987 https://bugs.webkit.org/show_bug.cgi?id=167542
4988 <rdar://problem/22746307>
4990 Reviewed by Ryosuke Niwa.
4992 * DumpRenderTree/mac/DumpRenderTree.mm:
4993 (enableExperimentalFeatures):
4994 (resetWebPreferencesToConsistentValues):
4995 * DumpRenderTree/win/DumpRenderTree.cpp:
4996 (enableExperimentalFeatures):
4998 2017-01-28 Joseph Pecoraro <pecoraro@apple.com>
5000 Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
5001 https://bugs.webkit.org/show_bug.cgi?id=167519
5003 Reviewed by Ryosuke Niwa.
5005 * QueueStatusServer/templates/statusbubble.html:
5006 To measure the bubbleContainer's width, it must not be wrapping based
5007 on its parent container. So when measuring the width temporarily set
5008 the parent to a very large width so as to not artificially wrap us.
5009 Restore the parent's width after measuring.
5011 2017-01-27 Andy Estes <aestes@apple.com>
5013 [iOS] Add a test for _WKNSFileManagerExtras
5014 https://bugs.webkit.org/show_bug.cgi?id=167478
5016 Reviewed by Andreas Kling.
5018 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
5019 * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
5023 2017-01-27 Keith Miller <keith_miller@apple.com>
5025 run-benchmarks should make sure it passes the test url to the right application
5026 https://bugs.webkit.org/show_bug.cgi?id=167533
5028 Reviewed by Joseph Pecoraro.
5030 This fixes an issue when trying to run-benchmark script with the
5031 system default browser set to STP. Previously, it would run
5032 the test in STP rather than the provided build. Now, it should run
5033 in the provided build.
5035 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
5036 (OSXSafariDriver.launch_url):
5038 2017-01-27 Myles C. Maxfield <mmaxfield@apple.com>
5040 [Cocoa] Prepare ComplexTextController for unit testing
5041 https://bugs.webkit.org/show_bug.cgi?id=167493
5043 Reviewed by Simon Fraser.
5045 Addressing post-review comments from Simon Fraser.
5047 * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
5048 (TestWebKitAPI::TEST_F):
5050 2017-01-27 Myles C. Maxfield <mmaxfield@apple.com>
5052 [Cocoa] Prepare ComplexTextController for unit testing
5053 https://bugs.webkit.org/show_bug.cgi?id=167493
5055 Reviewed by Dean Jackson.
5057 Create four unit tests.
5059 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
5060 * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
5061 (TestWebKitAPI::ComplexTextControllerTest::SetUp):
5062 (TestWebKitAPI::TEST_F):
5064 2017-01-26 Chris Dumez <cdumez@apple.com>
5066 Crash when navigating back to a page in PacheCache when one of its frames has been removed
5067 https://bugs.webkit.org/show_bug.cgi?id=167421
5068 <rdar://problem/30188490>
5070 Reviewed by Darin Adler.
5072 Add a new setting allowing layout tests to enable PageCache in a window
5073 that has an opener, for convenience.
5075 * DumpRenderTree/mac/DumpRenderTree.mm:
5076 (resetWebPreferencesToConsistentValues):
5077 * DumpRenderTree/win/DumpRenderTree.cpp:
5078 (resetWebPreferencesToConsistentValues):
5079 * WebKitTestRunner/TestController.cpp:
5080 (WTR::TestController::resetPreferencesToConsistentValues):
5082 2017-01-26 Keith Miller <keith_miller@apple.com>
5084 classInfo should take a VM so it is not materialized from the object on each call
5085 https://bugs.webkit.org/show_bug.cgi?id=167424
5087 Rubber Stamped by Michael Saboff.
5089 Previously, classInfo() would get the VM from the target's
5090 MarkedBlock. Most callers already have a VM on hand, so it is
5091 wasteful to compute the VM from the marked block every time. This
5092 patch refactors some of the most common callers of classInfo(),
5093 jsDynamicCast and inherits to take a VM as well.
5095 * DumpRenderTree/TestRunner.cpp:
5096 (setAudioResultCallback):
5098 2017-01-26 Jer Noble <jer.noble@apple.com>
5100 Autoplay muted videos stop playback of any streaming app in the background
5101 https://bugs.webkit.org/show_bug.cgi?id=163993
5102 <rdar://problem/29020431>
5104 Reviewed by Eric Carlson.
5106 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
5107 * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
5108 (TestWebKitAPI::TEST):
5109 * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
5111 2017-01-26 Ryan Haddad <ryanhaddad@apple.com>
5113 Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
5114 https://bugs.webkit.org/show_bug.cgi?id=167466
5116 Unreviewed test gardening.
5118 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
5121 2017-01-26 Matt Rajca <mrajca@apple.com>
5123 Notify clients when the user plays media otherwise prevented from autoplaying
5124 https://bugs.webkit.org/show_bug.cgi?id=167390
5126 Reviewed by Alex Christensen.
5128 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
5129 * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
5130 * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
5131 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
5132 (didPlayMediaPreventedFromPlayingWithoutUserGesture):
5134 * TestWebKitAPI/cocoa/TestWKWebView.h:
5135 * TestWebKitAPI/cocoa/TestWKWebView.mm:
5136 (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
5137 (-[TestWKWebView waitForLoad]):
5138 (-[TestWKWebView mouseUpAtPoint:]):
5139 * WebKitTestRunner/TestController.cpp:
5140 (WTR::TestController::createOtherPage):
5141 (WTR::TestController::createWebViewWithOptions):
5143 2017-01-26 Per Arne Vollan <pvollan@apple.com>
5145 Crash when setting custom scale factor.
5146 https://bugs.webkit.org/show_bug.cgi?id=167369
5148 Reviewed by Sam Weinig.
5152 * TestWebKitAPI/PlatformWin.cmake:
5153 * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
5154 (TestWebKitAPI::WebKitCreateInstance):
5155 (TestWebKitAPI::ScaleWebView::SetUp):
5156 (TestWebKitAPI::ScaleWebView::TearDown):
5157 (TestWebKitAPI::TEST_F):
5159 2017-01-25 Ryosuke Niwa <rniwa@webkit.org>
5161 run-benchmark nests MotionMark results by the suite name twice
5162 https://bugs.webkit.org/show_bug.cgi?id=164948
5164 Reviewed by Said Abou-Hallawa.
5166 Use a single level MotionMark now that this is the name of the benchmark,
5167 and we no longer have tests that aren't part of the MotionMark suite.
5169 * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
5171 2017-01-25 Ryan Haddad <ryanhaddad@apple.com>
5173 Unreviewed, rolling out r211193.
5175 This change broke internal builds.
5179 "Notify clients when the user plays media otherwise prevented
5181 https://bugs.webkit.org/show_bug.cgi?id=167390
5182 http://trac.webkit.org/changeset/211193
5184 2017-01-25 Matt Rajca <mrajca@apple.com>
5186 Notify clients when the user plays media otherwise prevented from autoplaying
5187 https://bugs.webkit.org/show_bug.cgi?id=167390
5189 Reviewed by Alex Christensen.
5191 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
5192 * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
5193 * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
5194 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
5195 (didPlayMediaPreventedFromPlayingWithoutUserGesture):
5197 * TestWebKitAPI/cocoa/TestWKWebView.h:
5198 * TestWebKitAPI/cocoa/TestWKWebView.mm:
5199 (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
5200 (-[TestWKWebView waitForLoad]):
5201 (-[TestWKWebView mouseUpAtPoint:]):
5202 * WebKitTestRunner/TestController.cpp:
5203 (WTR::TestController::createOtherPage):
5204 (WTR::TestController::createWebViewWithOptions):
5206 2017-01-25 Matt Rajca <mrajca@apple.com>
5208 [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
5209 https://bugs.webkit.org/show_bug.cgi?id=167385
5211 Reviewed by Alex Christensen.
5213 * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
5214 * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
5215 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
5216 (TEST): Allow inline (rather than full screen) media playback on iOS.
5218 2017-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
5220 [GTK] Icon Database should be in private browsing mode for ephemeral web views
5221 https://bugs.webkit.org/show_bug.cgi?id=167414
5223 Reviewed by Michael Catanzaro.
5225 Add a test case to check ephemeral web views don't write favicons to the database.
5227 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
5228 (ephemeralViewLoadChanged):
5229 (testPrivateBrowsing):
5230 (testFaviconDatabase):
5232 2017-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
5234 [GTK] Add a private browsing mode to MiniBrowser
5235 https://bugs.webkit.org/show_bug.cgi?id=167413
5237 Reviewed by Michael Catanzaro.
5239 Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
5240 private windows, even on non-private instances.
5242 * MiniBrowser/gtk/BrowserWindow.c:
5243 (webViewTitleChanged): Add [Private] to title window for private windows.
5244 (webViewCreate): Pass web context to browser_window_new.
5245 (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
5246 (browserWindowFinalize): Disconnect web context signal handlers.
5247 (browser_window_init): Add shortcut for opening private window.
5248 (browser_window_new): It now receives the context and connect to download-started here.
5249 (browser_window_get_web_context): Return the context.
5250 * MiniBrowser/gtk/BrowserWindow.h:
5251 * MiniBrowser/gtk/main.c:
5252 (createBrowserTab): Create the web view for the window web context.
5253 (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
5254 (aboutDataHandleRequest): Ditto.
5255 (aboutURISchemeRequestCallback): Ditto.
5256 (main): Create ephemeral web context if private command line option is used.
5258 2017-01-25 Ryosuke Niwa <rniwa@webkit.org>
5260 collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
5261 https://bugs.webkit.org/show_bug.cgi?id=167409
5263 Reviewed by Antti Koivisto.
5265 Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
5266 as well as tests for the newly added matchingElementInFlatTree.
5268 * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
5269 (TestWebKitAPI::runJavaScriptAlert):
5270 * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
5271 (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
5272 * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
5274 2017-01-24 Carlos Garcia Campos <cgarcia@igalia.com>
5276 [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
5277 https://bugs.webkit.org/show_bug.cgi?id=167370
5279 Reviewed by Michael Catanzaro.
5281 Add several test cases of ephemeral web views.
5283 * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
5284 (testWebViewAuthenticationStorage):
5285 * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
5286 (ephemeralViewloadChanged):
5287 (testCookieManagerEphemeral):
5289 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
5290 (testWebKitSettings):
5291 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
5292 (testWebContextEphemeral):
5293 (ephemeralViewloadChanged):
5294 (testWebContextProxySettings):
5296 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
5297 (ephemeralViewloadChanged):
5298 (testWebViewEphemeral):
5300 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
5301 (ephemeralViewloadChanged):
5302 (testWebsiteDataEphemeral):
5305 2017-01-24 Alex Christensen <achristensen@webkit.org>
5307 REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
5308 https://bugs.webkit.org/show_bug.cgi?id=167402
5310 Reviewed by Ryosuke Niwa.
5312 * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
5313 (TestWebKitAPI::TEST):
5315 2017-01-24 Zalan Bujtas <zalan@apple.com>
5317 Add simple line layout toggle to MiniBrowser
5318 https://bugs.webkit.org/show_bug.cgi?id=167405
5320 Reviewed by Andreas Kling.
5322 * MiniBrowser/mac/SettingsController.h:
5323 * MiniBrowser/mac/SettingsController.m:
5324 (-[SettingsController _populateMenu]):
5325 (-[SettingsController validateMenuItem:]):
5326 (-[SettingsController toggleSimpleLineLayoutEnabled:]):
5327 (-[SettingsController simpleLineLayoutEnabled]):
5328 * MiniBrowser/mac/WK1BrowserWindowController.m:
5329 (-[WK1BrowserWindowController didChangeSettings]):
5330 * MiniBrowser/mac/WK2BrowserWindowController.m:
5331 (-[WK2BrowserWindowController didChangeSettings]):
5333 2017-01-24 Joseph Pecoraro <pecoraro@apple.com>
5335 WKR does not include my nick when commit-queue lands my patch
5336 https://bugs.webkit.org/show_bug.cgi?id=167388
5338 Reviewed by Ryosuke Niwa.
5340 * Scripts/webkitpy/tool/commands/newcommitbot.py:
5341 (NewCommitBot._summarize_commit_log):
5342 * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
5343 Perform nickname insertion before grabbing "Patch by" details.
5344 This way we can include the nickname with the full name.
5346 2017-01-24 Joseph Pecoraro <pecoraro@apple.com>
5348 Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
5349 https://bugs.webkit.org/show_bug.cgi?id=167394
5351 Reviewed by Ryosuke Niwa.
5353 * Scripts/webkitperl/FeatureList.pm:
5354 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
5356 2017-01-24 Youenn Fablet <youenn@apple.com>
5358 [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
5359 https://bugs.webkit.org/show_bug.cgi?id=167353
5361 Reviewed by Alex Christensen.
5363 * Scripts/webkitpy/libwebrtc/generate_cmake.py:
5364 (CMakeGenerator.initialize_targets):
5366 2017-01-24 Michael Catanzaro <mcatanzaro@igalia.com>
5368 WKR should not confuse Miguel Gomez with Andres Gomez
5369 https://bugs.webkit.org/show_bug.cgi?id=167389
5371 Reviewed by Lucas Forschler.
5373 Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
5374 "mAndres Gomez". Fix this.
5376 * Scripts/webkitpy/tool/commands/newcommitbot.py:
5377 (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
5378 space on each side of the email address, so expect both spaces to be there before
5379 considering the email for replacement.
5380 * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
5382 2017-01-24 Matt Rajca <mrajca@apple.com>
5384 Pass down website autoplay policies to media elements
5385 https://bugs.webkit.org/show_bug.cgi?id=167355
5387 Reviewed by Alex Christensen.
5389 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
5390 * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
5391 * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
5392 * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
5393 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
5394 (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
5397 2017-01-24 Nan Wang <n_wang@apple.com>
5399 AX: Speak Selection does not work in an iframe
5400 https://bugs.webkit.org/show_bug.cgi?id=166794
5401 <rdar://problem/29913013>
5403 Reviewed by Chris Fleizach.
5405 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
5406 (WTR::UIScriptController::retrieveSpeakSelectionContent):
5407 (WTR::UIScriptController::accessibilitySpeakSelectionContent):
5408 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
5409 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
5410 (WTR::UIScriptController::retrieveSpeakSelectionContent):
5411 (WTR::UIScriptController::accessibilitySpeakSelectionContent):
5412 * TestRunnerShared/UIScriptContext/UIScriptController.h:
5413 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
5414 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
5415 (-[TestRunnerWKWebView dealloc]):
5416 (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
5417 (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
5418 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
5419 (WTR::UIScriptController::retrieveSpeakSelectionContent):
5420 (WTR::UIScriptController::accessibilitySpeakSelectionContent):
5422 2017-01-24 Daniel Bates <dabates@apple.com>
5424 StringView.split() should use an iterator design pattern instead of allocating a Vector
5425 https://bugs.webkit.org/show_bug.cgi?id=163225
5427 Reviewed by Darin Adler.
5429 Add unit tests for StringView.split().
5431 * TestWebKitAPI/Tests/WTF/StringView.cpp:
5432 (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
5433 used in the StringView.split() unit tests.
5434 (TestWebKitAPI::stringViewFromUTF8): Ditto.
5435 (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
5436 object to a Vector of String objects.
5437 (TestWebKitAPI::TEST): Added the following tests:
5438 - WTF.StringViewSplitEmptyAndNullStrings
5439 - WTF.StringViewSplitBasic
5440 - WTF.StringViewSplitWithConsecutiveSeparators
5442 2017-01-23 Anders Carlsson <andersca@apple.com>
5444 The Score Esports crashes on launch
5445 https://bugs.webkit.org/show_bug.cgi?id=167338
5446 rdar://problem/29948645
5448 Reviewed by Dan Bernstein.
5450 * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
5451 (TestWebKitAPI::TEST):
5454 2017-01-23 Carlos Garcia Campos <cgarcia@igalia.com>
5456 [GTK] Add API to WebKitWebsiteDataManager to handle website data
5457 https://bugs.webkit.org/show_bug.cgi?id=146589
5459 Reviewed by Michael Catanzaro.
5461 Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
5462 new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
5464 * MiniBrowser/gtk/BrowserWindow.c:
5465 (webViewDecidePolicy):
5467 * MiniBrowser/gtk/main.c:
5469 (aboutDataRequestFree):
5470 (aboutDataRequestNew):
5471 (aboutDataRequestForView):
5472 (websiteDataRemovedCallback):
5473 (websiteDataClearedCallback):
5474 (aboutDataScriptMessageReceivedCallback):
5476 (aboutDataFillTable):
5477 (gotWebsiteDataCallback):
5478 (aboutDataHandleRequest):
5479 (aboutURISchemeRequestCallback):
5481 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
5482 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
5485 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
5487 (WebsiteDataTest::WebsiteDataTest):
5488 (WebsiteDataTest::~WebsiteDataTest):
5489 (WebsiteDataTest::fetch):
5490 (WebsiteDataTest::remove):
5491 (WebsiteDataTest::clear):
5492 (testWebsiteDataConfiguration):
5493 (testWebsiteDataCache):
5494 (testWebsiteDataStorage):
5495 (testWebsiteDataDatabases):
5496 (testWebsiteDataAppcache):
5500 2017-01-23 Commit Queue <commit-queue@webkit.org>
5502 Unreviewed, rolling out r211062.
5503 https://bugs.webkit.org/show_bug.cgi?id=167354
5505 broke API tests (Requested by alexchristensen on #webkit).
5509 "Pass down website autoplay policies to media elements"
5510 https://bugs.webkit.org/show_bug.cgi?id=167132
5511 http://trac.webkit.org/changeset/211062
5513 2017-01-23 Alex Christensen <achristensen@webkit.org>
5515 URLParser should fail to parse percent-encoded invalid UTF-8 sequences
5516 https://bugs.webkit.org/show_bug.cgi?id=167330
5518 Reviewed by Tim Horton.
5520 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
5521 (TestWebKitAPI::TEST_F):
5523 2017-01-23 Alex Christensen <achristensen@webkit.org>
5525 Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
5526 https://bugs.webkit.org/show_bug.cgi?id=167317
5528 Reviewed by Sam Weinig.
5530 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
5531 (TestWebKitAPI::TEST_F):
5533 2017-01-23 Jonathan Bedard <jbedard@apple.com>
5535 svn-create-patch should emit properties when files are moved or copied
5536 https://bugs.webkit.org/show_bug.cgi?id=167264
5538 Reviewed by Daniel Bates.
5540 * Scripts/svn-create-patch:
5541 (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
5543 2017-01-23 Youenn Fablet <youenn@apple.com>
5545 [WebRTC] Filter libwebrtc link flags
5546 https://bugs.webkit.org/show_bug.cgi?id=167287
5548 Reviewed by Alex Christensen.
5550 * Scripts/webkitpy/libwebrtc/generate_cmake.py:
5551 (CMakeGenerator._compute_link_flags):
5552 (CMakeGenerator._compute_link_flags.keep_flag):
5553 (CMakeGenerator._generate_compile_target_options):
5555 2017-01-23 Youenn Fablet <youennf@gmail.com>
5557 [WebRTC] Make VP8 optional in libwebrtc
5558 https://bugs.webkit.org/show_bug.cgi?id=167257
5560 Reviewed by Darin Adler.
5562 * Scripts/webkitpy/libwebrtc/generate_cmake.py:
5563 (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
5565 2017-01-23 Jer Noble <jer.noble@apple.com>
5567 Video details does not apear and missing scrubber in Control Center
5568 https://bugs.webkit.org/show_bug.cgi?id=167233
5570 Reviewed by Alex Christensen.
5572 Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
5573 NowPlayingControlTests for iOS.
5575 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
5576 * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
5577 (-[NowPlayingTestWebView setWindowVisible:]):
5578 (TestWebKitAPI::TEST):
5579 * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
5580 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
5581 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
5582 * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
5583 * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
5585 (-[TestMessageHandler addMessage:withHandler:]):
5586 (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
5587 (__simulated_forceClickAssociatedEventsMask):
5588 (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
5589 (-[TestWKWebViewHostWindow isKeyWindow]):
5590 (-[TestWKWebViewHostWindow makeKeyWindow]):
5591 (-[TestWKWebViewHostWindow resignKeyWindow]):
5592 (-[TestWKWebView initWithFrame:]):
5593 (-[TestWKWebView initWithFrame:configuration:]):
5594 (-[TestWKWebView _setUpTestWindow:]):
5595 (-[TestWKWebView performAfterReceivingMessage:action:]):
5596 (-[TestWKWebView loadTestPageNamed:]):
5597 (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
5598 (-[TestWKWebView stringByEvaluatingJavaScript:]):
5599 (-[TestWKWebView waitForMessage:]):
5600 (-[TestWKWebView performAfterLoading:]):
5601 (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
5602 (-[TestWKWebView typeCharacter:]):
5604 2017-01-21 Carlos Garcia Campos <cgarcia@igalia.com>
5606 Unreviewed. Bring back gtk-doc error messages after r209981.
5608 Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
5609 impossible to know what's wrong.
5612 (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
5614 2017-01-20 Youenn Fablet <youennf@gmail.com>
5616 [WebRTC] Update build system to make G711 optional in libwebrtc
5617 https://bugs.webkit.org/show_bug.cgi?id=167256
5619 Reviewed by Alex Christensen.
5621 * Scripts/webkitpy/libwebrtc/generate_cmake.py:
5622 (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
5624 2017-01-20 Joseph Pecoraro <pecoraro@apple.com>
5626 Cleanup RuntimeEnabledFeatures
5627 https://bugs.webkit.org/show_bug.cgi?id=167228
5629 Reviewed by Simon Fraser.
5631 * DumpRenderTree/mac/DumpRenderTree.mm:
5632 (enableExperimentalFeatures):
5633 (resetWebPreferencesToConsistentValues):
5634 (setWebPreferencesForTestOptions):
5635 (resetWebViewToConsistentStateBeforeTesting):
5636 * DumpRenderTree/win/DumpRenderTree.cpp:
5637 (enableExperimentalFeatures):
5638 (resetWebPreferencesToConsistentValues):
5639 More closely match WebKitTestRunner initialization of preferences
5640 for experimental features.
5642 2017-01-20 Alex Christensen <achristensen@webkit.org>
5644 Build Fix for Windows DumpRenderTree after r210976
5645 https://bugs.webkit.org/show_bug.cgi?id=167115
5647 * DumpRenderTree/win/DumpRenderTree.cpp:
5648 (resetWebPreferencesToConsistentValues):
5650 2017-01-20 Joseph Pecoraro <pecoraro@apple.com>
5652 Remove outdated ENABLE(CSP_NEXT) build flag
5653 https://bugs.webkit.org/show_bug.cgi?id=167252
5655 Reviewed by Brent Fulgham.
5657 * Scripts/webkitperl/FeatureList.pm:
5658 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
5660 2017-01-20 Joseph Pecoraro <pecoraro@apple.com>
5662 Build Fix for Windows DumpRenderTree after r210976
5664 * DumpRenderTree/win/DumpRenderTree.cpp:
5665 (resetWebPreferencesToConsistentValues):
5667 2017-01-20 Antoine Quint <graouts@apple.com>
5669 Web Animations should be off by default and enabled as an experimental feature
5670 https://bugs.webkit.org/show_bug.cgi?id=167115
5671 <rdar://problem/30048963>
5673 Reviewed by Joseph Pecoraro.
5675 Turn Web Animations on in DRT.
5677 * DumpRenderTree/mac/DumpRenderTree.mm:
5678 (resetWebPreferencesToConsistentValues):
5679 * DumpRenderTree/win/DumpRenderTree.cpp:
5680 (resetWebPreferencesToConsistentValues):
5682 2017-01-20 Youenn Fablet <youenn@apple.com>
5684 [WebRTC] Add libwebrtc build infrastructure
5685 https://bugs.webkit.org/show_bug.cgi?id=167207
5687 Reviewed by Alex Christensen.
5689 Adding a script doing the libwebrtc project json to CMake file conversion.
5691 * Scripts/generate-libwebrtc-cmake: Added.
5692 * Scripts/webkitpy/libwebrtc/__init__.py: Added.
5693 * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
5695 2017-01-20 Joseph Pecoraro <pecoraro@apple.com>
5697 Mini Browser: Show tooltip for Experimental Features
5698 https://bugs.webkit.org/show_bug.cgi?id=167225
5700 Reviewed by Alex Christensen.
5702 * MiniBrowser/mac/SettingsController.m:
5703 (-[SettingsController _populateMenu]):
5704 Include the full details string as a tooltip.
5706 2017-01-20 Per Arne Vollan <pvollan@apple.com>
5708 [Win] Test output results should not be written twice.
5709 https://bugs.webkit.org/show_bug.cgi?id=167197
5711 Reviewed by Brent Fulgham.
5713 Prevent test output from being written twice by returning early from
5714 the dump() function, if it already has been called.
5715 This patch also adds a missing newline to a test output line.
5717 * DumpRenderTree/win/DumpRenderTree.cpp:
5720 2017-01-20 Antoine Quint <graouts@apple.com>
5722 [Modern Media Controls] Turn modern media controls on by default
5723 https://bugs.webkit.org/show_bug.cgi?id=165668
5725 Reviewed by Dean Jackson.
5727 Enabled modern media controls by default in test runners.
5729 * DumpRenderTree/TestOptions.h:
5730 * WebKitTestRunner/TestOptions.h:
5732 2017-01-19 Chris Dumez <cdumez@apple.com>
5734 iterable<> should be enabled on WK1
5735 https://bugs.webkit.org/show_bug.cgi?id=167221
5736 <rdar://problem/30108531>
5738 Reviewed by Youenn Fablet.
5740 * DumpRenderTree/mac/DumpRenderTree.mm:
5741 (resetWebPreferencesToConsistentValues):
5742 * DumpRenderTree/win/DumpRenderTree.cpp:
5743 (resetWebPreferencesToConsistentValues):
5744 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
5745 (WTR::InjectedBundle::beginTesting):
5746 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
5747 (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
5748 * WebKitTestRunner/InjectedBundle/TestRunner.h:
5750 2017-01-19 Aakash Jain <aakash_jain@apple.com>
5752 Ensure status server logs go to log file
5753 https://bugs.webkit.org/show_bug.cgi?id=167210
5755 Reviewed by Alexey Proskuryakov.
5757 * Scripts/webkitpy/common/net/statusserver.py:
5758 (StatusServer.next_work_item): Change log level from debug to info in
5759 order to facilitate deubgging issues.
5760 (StatusServer.update_work_items): Same.
5762 2017-01-19 Megan Gardner <megan_gardner@apple.com>
5764 Additional selection tests and interpolation fix
5765 https://bugs.webkit.org/show_bug.cgi?id=167171
5767 Reviewed by Simon Fraser.
5769 We weren't adding the final event when interpolating event streams.
5771 * WebKitTestRunner/ios/HIDEventGenerator.mm:
5772 (-[HIDEventGenerator interpolatedEvents:]):
5774 2017-01-19 Myles C. Maxfield <mmaxfield@apple.com>
5776 [Cocoa] Variation fonts are erroneously disabled on iOS
5777 https://bugs.webkit.org/show_bug.cgi?id=167172
5779 Reviewed by Simon Fraser.
5781 OpenSource builders don't seem to understand sdk=embedded*.
5783 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
5785 2017-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
5787 Unreviewed. Fix GTK+ unit tests failing since r210531.
5789 Avoid using paths to files that don't actually exist.
5791 * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
5792 (testWebKitConsoleMessageNetworkError):
5793 * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
5794 (testContextMenuDefaultMenu):
5795 * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
5796 * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
5797 * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
5799 2017-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
5801 [GTK] Provide API to set proxy settings
5802 https://bugs.webkit.org/show_bug.cgi?id=128674
5804 Reviewed by Michael Catanzaro.
5806 Add tests for new proxy settings API.
5808 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
5810 (ProxyTest::ProxyTest):
5811 (ProxyTest::~ProxyTest):
5812 (ProxyTest::loadURIAndGetMainResourceData):
5813 (ProxyTest::proxyServerPortAsString):
5814 (testWebContextProxySettings):
5817 2017-01-19 Timothy Hatcher <timothy@hatcher.name>
5819 Add back my old email address so old commits will still match it.
5821 * Scripts/webkitpy/common/config/contributors.json:
5823 2017-01-19 Timothy Hatcher <timothy@hatcher.name>
5825 Remove my old email address from contributors.json and watchlist.
5827 * Scripts/validate-committer-lists:
5828 (CommitterListFromGit): Change the mapping to the correct email.
5829 * Scripts/webkitpy/common/config/contributors.json:
5830 * Scripts/webkitpy/common/config/watchlist:
5832 2017-01-18 Ryan Haddad <ryanhaddad@apple.com>
5834 Unreviewed, rolling out r210848.
5836 This change introduced media-related LayoutTest failures and
5841 "[Modern Media Controls] Turn modern media controls on by
5843 https://bugs.webkit.org/show_bug.cgi?id=165668
5844 http://trac.webkit.org/changeset/210848
5846 2017-01-18 Andreas Kling <akling@apple.com>
5848 Document::securityOrigin() should return a reference.
5849 <https://webkit.org/b/167124>
5851 Reviewed by Sam Weinig.
5853 * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
5854 (TestWebKitAPI::TEST_F):
5856 2017-01-18 Per Arne Vollan <pvollan@apple.com>
5858 [Win] Clipboard tests are flaky.
5859 https://bugs.webkit.org/show_bug.cgi?id=167088
5861 Reviewed by Brent Fulgham.
5863 Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global.
5864 We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
5866 * DumpRenderTree/win/DumpRenderTree.cpp:
5869 2017-01-18 Antoine Quint <graouts@apple.com>
5871 [Modern Media Controls] Turn modern media controls on by default
5872 https://bugs.webkit.org/show_bug.cgi?id=165668
5874 Reviewed by Dean Jackson.
5876 Enabled modern media controls by default in test runners.
5878 * DumpRenderTree/TestOptions.h:
5879 * WebKitTestRunner/TestOptions.h:
5881 2017-01-17 Michael Catanzaro <mcatanzaro@igalia.com>
5883 Unreviewed, rolling out r210834
5884 https://bugs.webkit.org/show_bug.cgi?id=165668
5886 It introduced dozens of test timeouts.
5889 "[Modern Media Controls] Turn modern media controls on by default"
5890 https://bugs.webkit.org/show_bug.cgi?id=165668
5891 http://trac.webkit.org/changeset/210834
5893 2017-01-17 Antoine Quint <graouts@apple.com>
5895 [Modern Media Controls] Turn modern media controls on by default
5896 https://bugs.webkit.org/show_bug.cgi?id=165668
5898 Reviewed by Dean Jackson.
5900 Enabled modern media controls by default in test runners.
5902 * DumpRenderTree/TestOptions.h:
5903 * WebKitTestRunner/TestOptions.h:
5905 2017-01-17 Chris Dumez <cdumez@apple.com>
5907 Document title changed twice when setting document.title
5908 https://bugs.webkit.org/show_bug.cgi?id=167065
5910 Reviewed by Darin Adler.
5912 Add WebKit2GTK API test that was written by Michael Catanzaro.
5914 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
5915 (testWebViewTitleChange):
5918 2017-01-17 Joseph Pecoraro <pecoraro@apple.com>
5920 ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
5921 https://bugs.webkit.org/show_bug.cgi?id=116551
5922 <rdar://problem/13949830>
5924 Reviewed by Alex Christensen.
5926 * Scripts/webkitperl/FeatureList.pm:
5927 Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
5928 that is part of the existing WEB_TIMING feature.
5930 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
5932 2017-01-17 Jonathan Bedard <jbedard@apple.com>
5934 'webkit-patch post' no longer works with moved/copied files
5935 https://bugs.webkit.org/show_bug.cgi?id=166914
5936 <rdar://problem/29979707>
5938 Reviewed by Daniel Bates.
5940 SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
5941 file outputs only the "Index:" line with an empty body. This workaround
5942 ignores such output from svn diff. A issue has been filed with SVN, a link to the
5943 public email list tracking this bug is below.
5944 http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
5947 * Scripts/svn-create-patch:
5948 (generateDiff): Ignore an "Index:" line with an empty body.
5950 2017-01-16 Joseph Pecoraro <pecoraro@apple.com>
5952 Remove the REQUEST_ANIMATION_FRAME flag
5953 https://bugs.webkit.org/show_bug.cgi?id=156980
5954 <rdar://problem/25906849>
5956 Reviewed by Simon Fraser.
5958 * Scripts/webkitperl/FeatureList.pm:
5959 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
5961 2017-01-15 Sam Weinig <sam@webkit.org>
5963 Add the ability to use numbers in makeString()
5964 https://bugs.webkit.org/show_bug.cgi?id=167087
5966 Reviewed by Darin Adler.
5968 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
5969 * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
5970 Add tests for StringConcatenate, focusing on new numeric additions.
5972 2017-01-15 Michael Catanzaro <mcatanzaro@igalia.com>
5974 Unreviewed, remove stale comment.
5976 This test was fixed by r163173.
5978 * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
5980 2017-01-14 Yusuke Suzuki <utatane.tea@gmail.com>
5982 Annotate large string tests with largeHeap
5983 https://bugs.webkit.org/show_bug.cgi?id=167054
5985 Reviewed by Filip Pizlo.
5987 * Scripts/run-javascriptcore-tests:
5988 * Scripts/run-jsc-stress-tests:
5990 2017-01-14 Joseph Pecoraro <pecoraro@apple.com>
5992 Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
5993 https://bugs.webkit.org/show_bug.cgi?id=167043
5995 Reviewed by Darin Adler.
5997 * Scripts/webkitperl/FeatureList.pm:
5999 2017-01-13 Joseph Pecoraro <pecoraro@apple.com>
6001 Remove ENABLE(DETAILS_ELEMENT) guards
6002 https://bugs.webkit.org/show_bug.cgi?id=167042
6004 Reviewed by Alex Christensen.
6006 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
6008 2017-01-13 Said Abou-Hallawa <sabouhallawa@apple.com>
6010 26 MotionMark performance tests failing
6011 https://bugs.webkit.org/show_bug.cgi?id=166854
6013 Reviewed by Ryosuke Niwa.
6015 Unrelated change. This is the last place that we need to rename Animometer
6018 * Scripts/webkitpy/common/config/watchlist:
6020 2017-01-13 Yusuke Suzuki <utatane.tea@gmail.com>
6022 run-jsc-benchmarks' echo should have -e option
6023 https://bugs.webkit.org/show_bug.cgi?id=167009
6025 Reviewed by Sam Weinig.
6027 echo requires `-e` option to use escape sequence.
6028 Without it, in some environment (in my Fedora 25), the escape sequence is not
6029 recognized and just dumped as `\c` etc.
6031 * Scripts/run-jsc-benchmarks:
6033 2017-01-12 Chris Dumez <cdumez@apple.com>
6035 Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
6036 https://bugs.webkit.org/show_bug.cgi?id=166995
6038 Reviewed by Jer Noble.
6040 Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
6041 as some people are having trouble building without it.
6043 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
6045 2017-01-12 Sam Weinig <sam@webkit.org>
6047 Add the ability to filter the set of bindings tests you want to run
6048 https://bugs.webkit.org/show_bug.cgi?id=166977
6050 Reviewed by Tim Horton.
6052 Allows doing things like:
6053 run-bindings-tests TestObj* TestCEReactions*
6055 to run only those tests that match the patterns.
6057 * Scripts/run-bindings-tests:
6059 Switch to using optparse and pass the remaining args as the filters.
6061 * Scripts/webkitpy/bindings/main.py:
6062 (BindingsTests.__init__):
6065 (BindingsTests.test_matches_patterns):
6066 Add helper predicate to determine if a test should be run. When no
6067 patterns are present, all tests should run.
6069 (BindingsTests.run_tests):
6070 Filter tests using the passed in patterns.
6072 2017-01-12 Per Arne Vollan <pvollan@apple.com>
6074 Followup fix after r210503.
6075 https://bugs.webkit.org/show_bug.cgi?id=166887
6077 Reviewed by Alex Christensen.
6079 After <http://trac.webkit.org/changeset/210503>, test results are written to a
6080 duplicated file handle on Windows. This patch fixes the remaining call sites.
6082 * DumpRenderTree/PixelDumpSupport.cpp:
6083 * DumpRenderTree/TestRunner.cpp:
6084 (TestRunner::waitToDumpWatchdogTimerFired):
6085 * DumpRenderTree/TestRunner.h:
6086 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
6087 * DumpRenderTree/win/DumpRenderTree.cpp:
6088 * DumpRenderTree/win/DumpRenderTreeWin.h:
6089 * DumpRenderTree/win/TestRunnerWin.cpp:
6090 (TestRunner::setSpellCheckerLoggingEnabled):
6092 2017-01-11 Megan Gardner <megan_gardner@apple.com>
6094 Add committer status for Megan
6095 https://bugs.webkit.org/show_bug.cgi?id=166954
6097 Reviewed by Tim Horton.
6099 Add committer status for Megan Gardner
6101 * Scripts/webkitpy/common/config/contributors.json:
6103 2017-01-11 Brent Fulgham <bfulgham@apple.com>
6105 Unreviewed test fix after r210599.
6107 * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
6108 (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
6110 2017-01-11 Brent Fulgham <bfulgham@apple.com>
6112 Unreviewed build fix after r210599.
6116 * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
6117 * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
6119 2017-01-11 Brent Fulgham <bfulgham@apple.com>
6121 File scheme should not allow access of a resource on a different volume.
6122 https://bugs.webkit.org/show_bug.cgi?id=158552
6123 <rdar://problem/15307582>
6125 Reviewed by Alex Christensen.
6127 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
6128 * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
6129 * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
6131 2017-01-11 Ryan Haddad <ryanhaddad@apple.com>
6133 Unreviewed, rolling out r210571.
6135 This change broke the 32-bit macOS build and caused LayoutTest
6140 "File scheme should not allow access of a resource on a
6142 https://bugs.webkit.org/show_bug.cgi?id=158552
6143 http://trac.webkit.org/changeset/210571
6145 2017-01-10 Carlos Alberto Lopez Perez <clopez@igalia.com>
6147 [GTK] install-dependencies script misses gdb
6148 https://bugs.webkit.org/show_bug.cgi?id=166917
6150 Reviewed by Michael Catanzaro.
6152 gdb is needed for generating the crash logs.
6154 * gtk/install-dependencies:
6156 2017-01-10 Michael Catanzaro <mcatanzaro@igalia.com>
6158 [GTK] No way for applications to set notification permissions without waiting for permission request
6159 https://bugs.webkit.org/show_bug.cgi?id=163366
6161 Reviewed by Carlos Garcia Campos.
6163 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
6164 (testWebViewNotification):
6165 (setInitialNotificationPermissionsAllowedCallback):
6166 (setInitialNotificationPermissionsDisallowedCallback):
6167 (testWebViewNotificationInitialPermissionAllowed):
6168 (testWebViewNotificationInitialPermissionDisallowed):
6170 * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
6171 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
6172 (WebViewTest::WebViewTest):
6173 (WebViewTest::initializeWebView):
6174 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
6176 2017-01-10 Tim Horton <timothy_horton@apple.com>
6178 MobileMiniBrowser tests don't work by default
6179 https://bugs.webkit.org/show_bug.cgi?id=166910
6181 Reviewed by Alex Christensen.
6183 * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
6184 Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
6186 2017-01-10 Brent Fulgham <bfulgham@apple.com>
6188 File scheme should not allow access of a resource on a different volume.
6189 https://bugs.webkit.org/show_bug.cgi?id=158552
6190 <rdar://problem/15307582>
6192 Reviewed by Alex Christensen.
6194 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
6195 * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
6196 * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
6198 2017-01-10 Mark Lam <mark.lam@apple.com>
6200 Reverting run-jsc-stress-tests' $buildType to use string values.
6201 https://bugs.webkit.org/show_bug.cgi?id=166912
6203 Rubber stamped by Filip Pizlo.
6205 This is so that we can test for it in the tests e.g.
6206 //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
6208 * Scripts/run-jsc-stress-tests:
6210 2017-01-10 Ryosuke Niwa <rniwa@webkit.org>
6212 Temporarily add back the file removed in r210463 to unbreak internal bots.
6214 * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
6216 2017-01-10 Jonathan Bedard <jbedard@apple.com>
6218 svn-apply failed to apply a patch (deleting file with svn property)
6219 https://bugs.webkit.org/show_bug.cgi?id=165953
6221 Reviewed by Daniel Bates.
6223 * Scripts/VCSUtils.pm:
6224 (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
6225 * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
6227 2017-01-10 Ryan Haddad <ryanhaddad@apple.com>
6229 Update flakiness dashboard configuration.
6230 https://bugs.webkit.org/show_bug.cgi?id=166869
6232 Reviewed by Alexey Proskuryakov.
6234 * TestResultServer/static-dashboards/builders.jsonp:
6235 * TestResultServer/static-dashboards/flakiness_dashboard.js:
6237 2017-01-10 Carlos Alberto Lopez Perez <clopez@igalia.com>
6239 [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
6240 https://bugs.webkit.org/show_bug.cgi?id=165232
6242 Unreviewed follow-up patch after r210539 and r210523.
6244 Instead of using that environment variable, the argument
6245 --display-server=xorg should be passed now.
6247 The GTK+ performance bot was the only bot using this, and is
6248 already passing --display-server=xorg after r210539.
6250 * Scripts/webkitpy/port/gtk.py:
6251 (GtkPort._driver_class):
6253 2017-01-10 Carlos Alberto Lopez Perez <clopez@igalia.com>
6255 [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
6256 https://bugs.webkit.org/show_bug.cgi?id=166872
6258 Reviewed by Michael Catanzaro.
6260 Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
6261 Define the required "--display-server=driver" in the bot additionalArguments config entry.
6262 Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
6263 The step RunWebKitTests already has support for it.
6265 * BuildSlaveSupport/build.webkit.org-config/config.json:
6266 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
6267 (RunGtkAPITests.start):
6268 (RunAndUploadPerfTests.start):
6269 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
6271 2017-01-09 Ryan Haddad <ryanhaddad@apple.com>
6273 Unreviewed, rolling out r210531.
6275 This change broke the 32-bit macOS build and caused LayoutTest
6280 "File scheme should not allow access of a resource on a
6282 https://bugs.webkit.org/show_bug.cgi?id=158552
6283 http://trac.webkit.org/changeset/210531
6285 2017-01-09 Brent Fulgham <bfulgham@apple.com>
6287 File scheme should not allow access of a resource on a different volume.
6288 https://bugs.webkit.org/show_bug.cgi?id=158552
6289 <rdar://problem/15307582>
6291 Reviewed by Alex Christensen.
6293 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
6294 * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
6295 * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
6297 2017-01-09 Carlos Alberto Lopez Perez <clopez@igalia.com>
6299 [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
6300 https://bugs.webkit.org/show_bug.cgi?id=165232
6302 Reviewed by Michael Catanzaro.
6304 Add a new WaylandDriver to run the tests in the user current wayland session.
6306 Also merge all the configuration options for selecting the display server inside one
6307 switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
6309 This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
6311 * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
6312 (TestRunner._create_driver):
6313 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
6315 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
6316 (PerfTestsRunner._parse_args):
6317 * Scripts/webkitpy/port/gtk.py:
6319 (GtkPort._driver_class):
6320 (GtkPort._search_paths):
6321 * Scripts/webkitpy/port/waylanddriver.py: Added.
6323 (WaylandDriver.check_driver):
6324 (WaylandDriver._setup_environ_for_test):
6325 (WaylandDriver._start):
6327 2017-01-09 Andy Estes <aestes@apple.com>
6329 [QuickLook] Add a layout test for webkit.org/b/135651
6330 https://bugs.webkit.org/show_bug.cgi?id=166855
6332 Reviewed by Andreas Kling.
6334 * DumpRenderTree/mac/FrameLoadDelegate.mm:
6335 (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
6336 errors with code WebKitErrorCannotShowURL.
6337 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
6338 (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
6339 not specific to WebKit2 error codes.
6341 2017-01-09 Antoine Quint <graouts@apple.com>
6343 Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
6344 https://bugs.webkit.org/show_bug.cgi?id=166837
6346 Reviewed by Alex Christensen.
6348 We now correctly handle the --absolutePath argument in DumpRenderTree and use
6349 the provided value when trying to determine the path to the test file. Failing
6350 that, we use the computed URL or the raw path provided to cover all cases.
6352 This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
6353 by applying this patch and seeing the number test failures dramatically reduced
6354 with WK1 due to the option to turn modern media controls off for older media controls
6357 * DumpRenderTree/DumpRenderTree.h:
6358 * DumpRenderTree/DumpRenderTreeCommon.cpp:
6360 * DumpRenderTree/TestOptions.h:
6361 * DumpRenderTree/TestOptions.mm:
6362 (TestOptions::TestOptions):
6363 * DumpRenderTree/mac/DumpRenderTree.mm:
6366 2017-01-09 Milan Crha <mcrha@redhat.com>
6368 prepare-ChangeLog: Correct help string for --style option
6369 https://bugs.webkit.org/show_bug.cgi?id=166725
6371 Reviewed by Alexey Proskuryakov.
6373 * Scripts/prepare-ChangeLog:
6376 2017-01-09 Lucas Forschler <lforschler@apple.com>
6378 https://bugs.webkit.org/show_bug.cgi?id=166839
6379 Add php7 support for macOS.
6380 Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
6382 Reviewed by Alexey Proskuryakov.
6384 * Scripts/webkitpy/port/base.py:
6385 (Port._is_darwin_php_version_7):
6386 (Port._debian_php_version):
6388 (Port._darwin_php_version):
6389 (Port._apache_config_file_name_for_platform):
6391 2017-01-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6393 [GTK] Should support key and code properties on keyboard events
6394 https://bugs.webkit.org/show_bug.cgi?id=166759
6396 Reviewed by Carlos Garcia Campos.
6398 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
6399 (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
6402 2017-01-06 Per Arne Vollan <pvollan@apple.com>
6404 [Win] Some tests are flaky because certain DLLs are writing to stdout.
6405 https://bugs.webkit.org/show_bug.cgi?id=166760
6407 Reviewed by Darin Adler.
6409 Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
6410 We can work around that by duplicating and redirecting stdout.
6412 * DumpRenderTree/PixelDumpSupport.cpp:
6413 (dumpWebViewAsPixelsAndCompareWithExpected):
6415 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
6417 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
6418 (DRTDesktopNotificationPresenter::showDesktopNotification):
6419 (DRTDesktopNotificationPresenter::cancelDesktopNotification):
6420 (DRTDesktopNotificationPresenter::requestNotificationPermission):
6421 * DumpRenderTree/win/DumpRenderTree.cpp:
6422 (dumpFrameScrollPosition):
6424 (dumpBackForwardList):
6428 * DumpRenderTree/win/DumpRenderTreeWin.h:
6429 * DumpRenderTree/win/EditingDelegate.cpp:
6430 (EditingDelegate::shouldBeginEditingInDOMRange):
6431 (EditingDelegate::shouldEndEditingInDOMRange):
6432 (EditingDelegate::shouldInsertNode):
6433 (EditingDelegate::shouldInsertText):
6434 (EditingDelegate::shouldDeleteDOMRange):
6435 (EditingDelegate::shouldChangeSelectedDOMRange):
6436 (EditingDelegate::shouldApplyStyle):
6437 (EditingDelegate::shouldChangeTypingStyle):
6438 (EditingDelegate::doPlatformCommand):
6439 (EditingDelegate::webViewDidBeginEditing):
6440 (EditingDelegate::webViewDidChange):
6441 (EditingDelegate::webViewDidEndEditing):
6442 (EditingDelegate::webViewDidChangeTypingStyle):
6443 (EditingDelegate::webViewDidChangeSelection):
6444 * DumpRenderTree/win/FrameLoadDelegate.cpp:
6445 (FrameLoadDelegate::didStartProvisionalLoadForFrame):
6446 (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
6447 (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
6448 (FrameLoadDelegate::didFailProvisionalLoadWithError):
6449 (FrameLoadDelegate::didCommitLoadForFrame):
6450 (FrameLoadDelegate::didReceiveTitle):
6451 (FrameLoadDelegate::didFinishLoadForFrame):
6452 (FrameLoadDelegate::didFailLoadWithError):
6453 (FrameLoadDelegate::willPerformClientRedirectToURL):
6454 (FrameLoadDelegate::didCancelClientRedirectForFrame):
6455 (FrameLoadDelegate::windowScriptObjectAvailable):
6456 (FrameLoadDelegate::didFinishDocumentLoadForFrame):
6457 (FrameLoadDelegate::didHandleOnloadEventsForFrame):
6458 (FrameLoadDelegate::didDisplayInsecureContent):
6459 (FrameLoadDelegate::didRunInsecureContent):
6460 (FrameLoadDelegate::webViewProgressFinishedNotification):
6461 * DumpRenderTree/win/HistoryDelegate.cpp:
6462 (HistoryDelegate::didNavigateWithNavigationData):
6463 (HistoryDelegate::didPerformClientRedirectFromURL):
6464 (HistoryDelegate::didPerformServerRedirectFromURL):
6465 (HistoryDelegate::updateHistoryTitle):
6466 (HistoryDelegate::populateVisitedLinksForWebView):
6467 * DumpRenderTree/win/PolicyDelegate.cpp:
6468 (PolicyDelegate::decidePolicyForNavigationAction):
6469 (PolicyDelegate::unableToImplementPolicyWithError):
6470 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
6471 (ResourceLoadDelegate::willSendRequest):
6472 (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
6473 (ResourceLoadDelegate::didReceiveResponse):
6474 (ResourceLoadDelegate::didFinishLoadingFromDataSource):
6475 (ResourceLoadDelegate::didFailLoadingWithError):
6476 * DumpRenderTree/win/TestRunnerWin.cpp:
6477 (TestRunner::addDisallowedURL):
6478 (TestRunner::originsWithApplicationCache):
6479 (TestRunner::setStorageDatabaseIdleInterval):
6480 (TestRunner::closeIdleLocalStorageDatabases):
6481 (TestRunner::copyDecodedHostName):
6482 (TestRunner::copyEncodedHostName):
6483 (TestRunner::numberOfPendingGeolocationPermissionRequests):
6484 (TestRunner::isGeolocationProviderActive):
6485 (TestRunner::pathToLocalResource):
6486 (TestRunner::setMockDeviceOrientation):
6487 (TestRunner::setMockGeolocationPosition):
6488 (TestRunner::setMockGeolocationPositionUnavailableError):
6489 (TestRunner::setSpatialNavigationEnabled):
6490 (TestRunner::setAutomaticLinkDetectionEnabled):
6491 (TestRunner::isCommandEnabled):
6492 (TestRunner::authenticateSession):
6493 (TestRunner::addChromeInputField):
6494 (TestRunner::removeChromeInputField):
6495 (TestRunner::focusWebView):
6496 (TestRunner::grantWebNotificationPermission):
6497 (TestRunner::denyWebNotificationPermission):
6498 (TestRunner::removeAllWebNotificationPermissions):
6499 (TestRunner::simulateWebNotificationClick):
6500 (TestRunner::imageCountInGeneralPasteboard):
6501 * DumpRenderTree/win/UIDelegate.cpp:
6502 (UIDelegate::runJavaScriptAlertPanelWithMessage):
6503 (UIDelegate::runJavaScriptConfirmPanelWithMessage):
6504 (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
6505 (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
6506 (UIDelegate::webViewAddMessageToConsole):
6507 (UIDelegate::exceededDatabaseQuota):
6508 (UIDelegate::setStatusText):
6509 (UIDelegate::didPressMissingPluginButton):
6511 2017-01-07 Tim Horton <timothy_horton@apple.com>
6513 Add a setting to create editable MiniBrowser windows by default
6514 https://bugs.webkit.org/show_bug.cgi?id=166806
6516 Reviewed by Beth Dakin.
6518 * MiniBrowser/mac/AppDelegate.m:
6519 (-[BrowserAppDelegate createBrowserWindowController:]):
6520 (-[BrowserAppDelegate applicationDidFinishLaunching:]):
6521 (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
6522 * MiniBrowser/mac/SettingsController.h:
6523 * MiniBrowser/mac/SettingsController.m:
6524 (-[SettingsController _populateMenu]):
6525 (-[SettingsController validateMenuItem:]):
6526 (-[SettingsController toggleCreateEditorByDefault:]):
6527 (-[SettingsController createEditorByDefault]):
6528 Add a setting and update the key equivalents accordingly.
6529 Also make sure to make the right kind of window on launch.
6531 2017-01-07 Tim Horton <timothy_horton@apple.com>
6533 Fix the 32-bit build.
6535 * MiniBrowser/mac/BrowserWindowController.h:
6536 * MiniBrowser/mac/BrowserWindowController.m:
6538 2017-01-07 Tim Horton <timothy_horton@apple.com>
6540 Fix the 32-bit build.
6542 * MiniBrowser/mac/BrowserWindowController.m:
6544 2017-01-07 Tim Horton <timothy_horton@apple.com>
6546 Make it possible to drop HTML files on the MiniBrowser icon
6547 https://bugs.webkit.org/show_bug.cgi?id=166802
6549 Reviewed by Simon Fraser.
6551 * MiniBrowser/mac/AppDelegate.m:
6552 (-[BrowserAppDelegate application:openFile:]):
6553 * MiniBrowser/mac/Info.plist:
6554 If you're using an editable window, the usual trick of dropping on the
6555 window doesn't work anymore (it makes an <attachment> instead).
6557 2017-01-07 Tim Horton <timothy_horton@apple.com>
6559 MiniBrowser window gets smaller each time it is instantiated
6560 https://bugs.webkit.org/show_bug.cgi?id=166807
6562 Reviewed by Andy Estes.
6564 * MiniBrowser/mac/BrowserWindowController.m:
6565 (-[BrowserWindowController windowDidLoad]):
6566 * MiniBrowser/mac/BrowserWindow.xib:
6567 Turn on full-window content view support with IB, instead of waiting
6568 until after the views have been loaded. This seems to resolve the
6569 longstanding ever-shrinking-window problem.
6571 2017-01-07 Tim Horton <timothy_horton@apple.com>
6573 Add indent/outdent items to MiniBrowser's new format menu
6574 https://bugs.webkit.org/show_bug.cgi?id=166805
6576 Reviewed by Dan Bernstein.
6578 * MiniBrowser/mac/MainMenu.xib:
6580 2017-01-07 Tim Horton <timothy_horton@apple.com>
6582 Add a stock Format menu to MiniBrowser
6583 https://bugs.webkit.org/show_bug.cgi?id=166804
6585 Reviewed by Andy Estes.
6587 * MiniBrowser/mac/MainMenu.xib:
6588 Many of the features automatically work with editable web views.
6589 However, this seems to expose a bug where none of the font-related features
6590 (Cmd-B, for example) work until the first time the font panel is shown,
6591 per process, which will need to be investigated separately.
6593 2017-01-07 Tim Horton <timothy_horton@apple.com>
6595 Remove unused applicationWillTerminate methods from MiniBrowser
6596 https://bugs.webkit.org/show_bug.cgi?id=166803
6598 Reviewed by Andy Estes.
6600 * MiniBrowser/mac/AppDelegate.m:
6601 (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
6602 * MiniBrowser/mac/BrowserWindowController.h:
6603 * MiniBrowser/mac/BrowserWindowController.m:
6604 (-[BrowserWindowController applicationTerminating]): Deleted.
6605 * MiniBrowser/mac/WK1BrowserWindowController.m:
6606 (-[WK1BrowserWindowController applicationTerminating]): Deleted.
6607 * MiniBrowser/mac/WK2BrowserWindowController.m:
6608 (-[WK2BrowserWindowController applicationTerminating]): Deleted.
6610 2017-01-07 Tim Horton <timothy_horton@apple.com>
6612 Add the ability to create empty contentEditable windows in MiniBrowser
6613 https://bugs.webkit.org/show_bug.cgi?id=166801
6615 Reviewed by Wenson Hsieh.
6617 * MiniBrowser/mac/AppDelegate.h:
6618 * MiniBrowser/mac/AppDelegate.m:
6619 (-[BrowserAppDelegate createBrowserWindowController:]):
6620 (-[BrowserAppDelegate newWindow:]):
6621 (-[BrowserAppDelegate newEditorWindow:]):
6622 (-[BrowserAppDelegate openDocument:]):
6623 (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
6624 * MiniBrowser/mac/BrowserWindowController.h:
6625 * MiniBrowser/mac/BrowserWindowController.m:
6626 (-[BrowserWindowController loadHTMLString:]):
6627 (-[BrowserWindowController toggleEditable:]):
6628 * MiniBrowser/mac/MainMenu.xib:
6629 * MiniBrowser/mac/WK1BrowserWindowController.m:
6630 (-[WK1BrowserWindowController awakeFromNib]):
6631 (-[WK1BrowserWindowController loadHTMLString:]):
6632 (-[WK1BrowserWindowController validateMenuItem:]):
6633 (-[WK1BrowserWindowController setEditable:]):
6634 (-[WK1BrowserWindowController updateTitle:]):
6635 * MiniBrowser/mac/WK2BrowserWindowController.m:
6636 (-[WK2BrowserWindowController awakeFromNib]):
6637 (-[WK2BrowserWindowController validateMenuItem:]):
6638 (-[WK2BrowserWindowController setEditable:]):
6639 (-[WK2BrowserWindowController updateTitle:]):
6640 (-[WK2BrowserWindowController loadHTMLString:]):
6641 Merge more functionality from WebEditingTester.
6642 Add two menu items for creating empty editable WebKit1/2 windows.
6643 Add a menu item to the Edit menu to toggle editability on any window.
6645 2017-01-07 Tim Horton <timothy_horton@apple.com>
6647 Implement find-in-page in MiniBrowser
6648 https://bugs.webkit.org/show_bug.cgi?id=166799
6650 Reviewed by Andy Estes.
6652 * MiniBrowser/mac/BrowserWindow.xib:
6653 * MiniBrowser/mac/BrowserWindowController.h:
6654 * MiniBrowser/mac/BrowserWindowController.m:
6655 (-[BrowserWindowController find:]): Deleted.
6656 * MiniBrowser/mac/MainMenu.xib:
6657 * MiniBrowser/mac/WK1BrowserWindowController.m:
6658 (-[WK1BrowserWindowController toggleShrinkToFit:]):
6659 (-[WK1BrowserWindowController find:]): Deleted.
6660 * MiniBrowser/mac/WK2BrowserWindowController.m:
6661 (-[WK2BrowserWindowController awakeFromNib]):
6662 (-[WK2BrowserWindowController dealloc]):
6663 (-[WK2BrowserWindowController validateMenuItem:]):
6664 (-[WK2BrowserWindowController performTextFinderAction:]):
6665 (-[WK2BrowserWindowController findBarView]):
6666 (-[WK2BrowserWindowController setFindBarView:]):
6667 (-[WK2BrowserWindowController isFindBarVisible]):
6668 (-[WK2BrowserWindowController setFindBarVisible:]):
6669 (-[WK2BrowserWindowController contentView]):
6670 (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
6671 (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
6672 (-[WK2BrowserWindowController find:]): Deleted.
6673 Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
6674 protocol. At first glance, it's pretty broken, but vaguely works.
6676 2017-01-07 Tim Horton <timothy_horton@apple.com>
6678 Share the implementation of MiniBrowser view hiding functionality
6679 https://bugs.webkit.org/show_bug.cgi?id=166800
6681 Reviewed by Andy Estes.
6683 * MiniBrowser/mac/BrowserWindowController.m:
6684 (-[BrowserWindowController showHideWebView:]):
6685 (-[BrowserWindowController removeReinsertWebView:]):
6686 * MiniBrowser/mac/WK1BrowserWindowController.m:
6687 (-[WK1BrowserWindowController showHideWebView:]): Deleted.
6688 (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
6689 * MiniBrowser/mac/WK2BrowserWindowController.m:
6690 (-[WK2BrowserWindowController showHideWebView:]): Deleted.
6691 (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
6692 Move the implementation of these two things to the shared superclass,
6693 since they don't depend on WebKit-specific things.
6694 Also, there was no reason to retain the (WK)WebView while it was unparented,
6695 as the BrowserWindowController maintains a reference the entire time.
6697 2017-01-06 Andy Estes <aestes@apple.com>
6699 [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
6700 https://bugs.webkit.org/show_bug.cgi?id=166789
6702 Reviewed by Alex Christensen.
6704 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
6705 * DumpRenderTree/PlatformMac.cmake:
6706 * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
6707 * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
6708 * DumpRenderTree/mac/DumpRenderTree.mm:
6709 Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
6710 createXMLStringFromWebArchiveData().
6711 * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
6712 * WebKitTestRunner/Configurations/Base.xcconfig:
6713 Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
6714 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
6715 (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
6716 Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
6717 createXMLStringFromWebArchiveData().
6718 * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
6719 * WebKitTestRunner/PlatformMac.cmake:
6720 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
6721 * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
6723 2017-01-06 Tim Horton <timothy_horton@apple.com>
6725 Minor cleanups to IndentOutdentCommand and related code
6726 https://bugs.webkit.org/show_bug.cgi?id=166791
6728 Reviewed by Simon Fraser.
6730 * WebEditingTester/EditingOperations.m:
6731 (editingOperations):
6732 Add the outdent operation to WebEditingTester.
6734 2017-01-06 Said Abou-Hallawa <sabouhallawa@apple.com>
6736 Create a plan and a patch files for MotionMark and delete the Animometer's ones
6737 https://bugs.webkit.org/show_bug.cgi?id=166785
6739 Reviewed by Ryosuke Niwa.
6741 * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
6742 * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
6744 2017-01-06 Antoine Quint <graouts@apple.com>
6746 Support webkit-test-runner key-value pairs in http tests
6747 https://bugs.webkit.org/show_bug.cgi?id=149812
6749 Reviewed by Alex Christensen.
6751 We pass the absolute path for a test through to WKTR so that we can parse
6752 tests that are running as URLs for webkit-test-runner options.
6754 * DumpRenderTree/DumpRenderTreeCommon.cpp:
6757 Explicitly skip the --absolute-path option in DRT or else we'd crash.
6759 * Scripts/webkitpy/port/driver.py:
6760 (Driver._command_from_driver_input):
6762 Pass the absolute path to the file through the CLI.
6764 * WebKitTestRunner/TestController.cpp:
6765 (WTR::updateTestOptionsFromTestHeader):
6766 (WTR::TestController::testOptionsForTest):
6767 (WTR::parseInputLine):
6768 (WTR::TestController::runTest):
6769 * WebKitTestRunner/TestController.h:
6771 2017-01-06 Tim Horton <timothy_horton@apple.com>
6773 Warning about unconnectable outlets when opening a MiniBrowser window
6774 https://bugs.webkit.org/show_bug.cgi?id=166756
6776 Reviewed by Dan Bernstein.
6778 * MiniBrowser/mac/BrowserWindow.xib:
6779 When launching MiniBrowser, it says:
6780 Failed to connect (Share) outlet from (WK1BrowserWindowController) to
6781 (MBToolbarItem): missing setter or instance variable
6782 Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
6783 (NSButtonCell): missing setter or instance variable.
6785 It looks like someone added the connection from the share button
6786 to the BrowserWindowController three times; only one of the connections
6787 is valid. Remove the other two.
6789 2017-01-05 Keith Rollin <krollin@apple.com>
6791 Add WebCore::URL::protocolHostAndPort
6792 https://bugs.webkit.org/show_bug.cgi?id=166426
6794 Reviewed by Alex Christensen.
6796 Add test for protocolHostAndPort.
6798 * TestWebKitAPI/Tests/WebCore/URL.cpp:
6799 (TestWebKitAPI::TEST_F):
6801 2017-01-05 Per Arne Vollan <pvollan@apple.com>
6803 [Win] Archive test result is failing.
6804 https://bugs.webkit.org/show_bug.cgi?id=166720
6806 Reviewed by Alex Christensen.
6808 Deleting the layout test result folder is sometimes failing
6809 on Windows. This is not a critical error.
6811 * BuildSlaveSupport/test-result-archive:
6812 (archiveTestResults):
6814 2017-01-04 Tomas Popela <tpopela@redhat.com>
6816 [GTK] Minibrowser: Add printing support
6817 https://bugs.webkit.org/show_bug.cgi?id=165298
6819 Open a print dialog when the Ctrl + P shortcut is pressed. If there is
6820 an error during the print, it's printed on the console.
6822 Reviewed by Michael Catanzaro.
6824 * MiniBrowser/gtk/BrowserWindow.c:
6825 (webKitPrintOperationFailedCallback):
6827 (browser_window_init):
6829 2017-01-04 Manuel Rego Casasnovas <rego@igalia.com>
6831 [css-grid] Fix crash clamping grid lines
6832 https://bugs.webkit.org/show_bug.cgi?id=166637
6834 Reviewed by Darin Adler.
6836 Creates new unit test to verify that the maximum tracks limit
6837 is used in GridPosition too.
6839 * TestWebKitAPI/PlatformEfl.cmake:
6840 * TestWebKitAPI/PlatformGTK.cmake:
6841 * TestWebKitAPI/PlatformWin.cmake:
6842 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
6843 * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
6844 (TestWebKitAPI::TEST):
6846 2017-01-04 Wenson Hsieh <wenson_hsieh@apple.com>
6848 Move editing history scripts to WebCore PrivateHeaders
6849 https://bugs.webkit.org/show_bug.cgi?id=166709
6850 <rdar://problem/29876612>
6852 Reviewed by Dan Bernstein.
6854 Update references to editing script files in WebCore that were moved.
6856 * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
6858 2017-01-04 Yusuke Suzuki <utatane.tea@gmail.com>
6860 Unreviewed, build fix after r210313 part 2
6861 https://bugs.webkit.org/show_bug.cgi?id=166676
6865 * TestWebKitAPI/Tests/WTF/StringView.cpp:
6866 (TestWebKitAPI::TEST):
6867 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
6868 (TestWebKitAPI::TEST):
6870 2017-01-04 Yusuke Suzuki <utatane.tea@gmail.com>
6872 Limit thread name appropriately
6873 https://bugs.webkit.org/show_bug.cgi?id=166676
6875 Reviewed by Sam Weinig.
6877 * TestWebKitAPI/Tests/WTF/StringView.cpp:
6878 (TestWebKitAPI::TEST):
6879 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
6880 (TestWebKitAPI::TEST):
6882 2017-01-04 Andy Estes <aestes@apple.com>
6884 [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
6885 https://bugs.webkit.org/show_bug.cgi?id=166696
6887 Reviewed by Tim Horton.
6889 * TestWebKitAPI/PlatformGTK.cmake:
6890 * TestWebKitAPI/PlatformWin.cmake:
6891 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
6892 * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
6893 * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
6894 * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
6895 * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
6896 (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
6897 (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
6899 2017-01-03 Brian Burg <bburg@apple.com>
6901 Web Inspector: teach the protocol generator about platform-specific types, events, and commands
6902 https://bugs.webkit.org/show_bug.cgi?id=166003
6903 <rdar://problem/28718990>
6905 Reviewed by Joseph Pecoraro.
6907 Teach run-inspector-generator-tests to generate test output using the platform name
6908 derived from the directory that the test is in. For example, tests in the /generic/
6909 subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
6911 * Scripts/webkitpy/inspector/main.py:
6912 (InspectorGeneratorTests.generate_from_json):
6913 (InspectorGeneratorTests.run_tests):
6914 (InspectorGeneratorTests.main):
6916 2017-01-04 Csaba Osztrogonác <ossy@webkit.org>
6918 Unreviewed cmake buildfix after r210266.
6920 * DumpRenderTree/PlatformMac.cmake:
6922 2017-01-04 Tim Horton <timothy_horton@apple.com>
6924 Provide a setting for clients to always prefer low-power WebGL
6925 https://bugs.webkit.org/show_bug.cgi?id=166675
6926 <rdar://problem/29834093>
6928 Reviewed by Dan Bernstein.
6930 * MiniBrowser/mac/Info.plist:
6931 Have MiniBrowser claim to be a modern app that supports
6932 automatic graphics switching. WebKit needs to support automatic
6933 graphics switching, so our test app might as well. Without this
6934 Info.plist parameter, this change has no effect, and bringing up
6935 a WebGL context still brings up the discrete GPU (also true of the
6936 existing web-exposed preferLowPowerToHighPerformance API).
6938 2017-01-03 Yusuke Suzuki <utatane.tea@gmail.com>
6940 WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
6941 https://bugs.webkit.org/show_bug.cgi?id=166645
6943 Reviewed by Carlos Garcia Campos.
6945 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
6946 (TestWebKitAPI::TEST):
6948 2017-01-03 Andy Estes <aestes@apple.com>
6950 Place all the Cocoa WebCore API tests in the same directory
6951 https://bugs.webkit.org/show_bug.cgi?id=166673
6953 Reviewed by Michael Catanzaro.
6955 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
6956 * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
6957 * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
6958 * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
6960 2017-01-03 Tim Horton <timothy_horton@apple.com>
6962 NSSpellChecker's recordResponse isn't called for unseen automatic corrections
6963 https://bugs.webkit.org/show_bug.cgi?id=166450
6964 <rdar://problem/29447824>
6966 Reviewed by Darin Adler.
6968 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
6969 * DumpRenderTree/TestRunner.cpp:
6970 (TestRunner::staticFunctions):
6971 * DumpRenderTree/mac/TestRunnerMac.mm:
6972 (setSpellCheckerLoggingEnabledCallback):
6973 * DumpRenderTree/win/TestRunnerWin.cpp:
6974 (setSpellCheckerLoggingEnabledCallback):
6975 * DumpRenderTree/mac/DumpRenderTree.mm:
6976 (resetWebViewToConsistentStateBeforeTesting):
6977 * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
6978 * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
6979 (stringForCorrectionResponse):
6980 (drt_NSSpellChecker_recordResponseToCorrection):
6981 (swizzleNSSpellCheckerMethodsIfNeeded):
6982 (setSpellCheckerLoggingEnabled):
6983 Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
6984 set to true, logs to stdout (which ends up in the test result) whenever
6985 NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
6986 is called, and then calls the original method. It is reset to false between tests.
6988 2017-01-03 Sam Weinig <sam@webkit.org>
6990 Make WTF::Expected support Ref template parameters
6991 https://bugs.webkit.org/show_bug.cgi?id=166662
6993 Reviewed by Alex Christensen.
6995 * TestWebKitAPI/Tests/WTF/Expected.cpp:
6996 (TestWebKitAPI::TEST):
6997 Add tests for using Ref with Expected.
6999 2017-01-03 Michael Catanzaro <mcatanzaro@igalia.com>
7001 [GTK] Expose WebKitSecurityOrigin API
7002 https://bugs.webkit.org/show_bug.cgi?id=166632
7004 Reviewed by Carlos Garcia Campos.
7006 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
7007 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
7008 (testSecurityOriginBasicConstructor):
7009 (testSecurityOriginURIConstructor):
7010 (testSecurityOriginDefaultPort):
7011 (testSecurityOriginFileURI):
7012 (testSecurityOriginDataURI):
7016 2017-01-03 Carlos Garcia Campos <cgarcia@igalia.com>
7018 [GTK] HTTP auth layout tests are flaky
7019 https://bugs.webkit.org/show_bug.cgi?id=158919
7021 Reviewed by Michael Catanzaro.
7023 * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
7024 * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
7025 introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
7026 missing valac in the bots.
7028 2017-01-03 Carlos Garcia Campos <cgarcia@igalia.com>
7030 REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
7031 https://bugs.webkit.org/show_bug.cgi?id=165797
7033 Reviewed by Michael Catanzaro.
7035 Move directory ruleset after all exclude rules of Source rulset.
7037 * gtk/manifest.txt.in:
7039 2017-01-02 Yusuke Suzuki <utatane.tea@gmail.com>
7041 Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
7042 https://bugs.webkit.org/show_bug.cgi?id=166636
7044 Reviewed by Darin Adler.
7046 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
7047 (TestWebKitAPI::TEST):
7049 2017-01-02 Manuel Rego Casasnovas <rego@igalia.com>
7051 [GTK] WebCore/CSSParser unit test is not being built
7052 https://bugs.webkit.org/show_bug.cgi?id=166492
7054 Reviewed by Michael Catanzaro.
7056 This test was introduced in r175930, but we were not building
7057 it on GTK+ port since r176015.
7058 This patch marks the test to be built again on GTK+.
7059 JFTR, the test is passing right now.
7061 * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
7062 ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
7064 2017-01-02 Chris Fleizach <cfleizach@apple.com>
7066 AX: Expose block quote level to iOS API
7067 https://bugs.webkit.org/show_bug.cgi?id=166629
7068 <rdar://problem/29834793>
7070 Reviewed by Darin Adler.
7072 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
7073 (AccessibilityUIElement::numberAttributeValue):
7074 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
7075 (WTR::AccessibilityUIElement::numberAttributeValue):
7077 2016-12-31 Michael Catanzaro <mcatanzaro@igalia.com>
7079 SecurityOrigin::create triplet constructor does not canonicalize port
7080 https://bugs.webkit.org/show_bug.cgi?id=166624
7082 Reviewed by Daniel Bates.
7084 * TestWebKitAPI/PlatformGTK.cmake:
7085 * TestWebKitAPI/PlatformWin.cmake:
7086 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
7087 * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
7088 (TestWebKitAPI::SecurityOriginTest::SetUp):
7089 (TestWebKitAPI::TEST_F):
7091 2016-12-30 Michael Catanzaro <mcatanzaro@igalia.com>
7093 [GTK] Improve user agent construction
7094 https://bugs.webkit.org/show_bug.cgi?id=142074
7096 Reviewed by Carlos Garcia Campos.
7098 * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
7099 (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
7100 (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
7101 (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
7102 (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
7103 (TestWebKitAPI::TEST):
7105 2016-12-27 Michael Catanzaro <mcatanzaro@igalia.com>
7107 [GTK] Improve user agent construction
7108 https://bugs.webkit.org/show_bug.cgi?id=142074
7110 Reviewed by Carlos Garcia Campos.
7112 * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
7113 (TestWebKitAPI::TEST):
7115 2016-12-23 Simon Fraser <simon.fraser@apple.com>
7117 REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
7118 https://bugs.webkit.org/show_bug.cgi?id=166472
7119 rdar://problem/29675551
7121 Reviewed by Tim Horton.
7123 These changes are necessary to allow the mouse to leave the WTR window while
7124 drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
7125 (which DRT does); we'd always go through mouseMoved, which hits an early return
7126 in WebViewImpl::mouseMoved() when the point is outside the view.
7128 * WebKitTestRunner/mac/EventSenderProxy.mm:
7129 (WTR::EventSenderProxy::mouseMoveTo):
7131 2016-12-23 Andy Estes <aestes@apple.com>
7133 [iOS] Fix some crashing webarchive tests
7134 https://bugs.webkit.org/show_bug.cgi?id=166470
7136 Reviewed by Andreas Kling.
7138 Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
7139 of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
7140 so this change uses that on both platforms.
7142 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
7143 WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
7144 * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
7145 Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
7146 * WebKitTestRunner/PlatformMac.cmake:
7147 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
7148 * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
7150 2016-12-22 Saam Barati <sbarati@apple.com>
7152 WebAssembly: Silence the output of the spec-tests
7153 https://bugs.webkit.org/show_bug.cgi?id=166417
7155 Reviewed by Mark Lam.
7157 * Scripts/run-jsc-stress-tests:
7159 2016-12-22 Zhuo Li <zachli@apple.com>
7161 [Cocoa] SPI for setloadsImagesAutomatically.
7162 https://bugs.webkit.org/show_bug.cgi?id=166401.
7164 Reviewed by Darin Adler.
7166 * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
7167 (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
7168 _loadsImagesAutomatically returns YES.
7170 2016-12-22 Wenson Hsieh <wenson_hsieh@apple.com>
7172 fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
7173 https://bugs.webkit.org/show_bug.cgi?id=161328
7174 <rdar://problem/28475977>
7176 Reviewed by Darin Adler.
7178 Running a test that scales the viewport and listens to a didEndZooming callback (such as
7179 viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
7180 scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
7181 the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
7182 animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
7183 load, should prevent this from happening, but from reading documentation and code inspection, this is not
7184 intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
7185 for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
7186 we finish running a test and before we load the next test.
7188 One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
7189 recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
7190 previous test started zooming and then finished before zooming completed. Since this happens before the next
7191 test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
7193 * WebKitTestRunner/ios/TestControllerIOS.mm:
7194 (WTR::TestController::platformResetStateToConsistentValues):
7196 2016-12-22 Jer Noble <jer.noble@apple.com>
7198 Muted media element playback should not interrupt other audio playback
7199 https://bugs.webkit.org/show_bug.cgi?id=166347
7201 Reviewed by Eric Carlson.
7203 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
7204 * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
7205 (TestWebKitAPI::TEST):
7206 * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
7208 2016-12-22 Alejandro G. Castro <alex@igalia.com>
7210 [WebRTC] Add support for runtime PeeConnection setting, required after r209757
7211 https://bugs.webkit.org/show_bug.cgi?id=166346
7213 Reviewed by Carlos Garcia Campos.
7215 Enable WebRTC by default to simplify testing.
7217 * MiniBrowser/gtk/main.c:
7220 2016-12-21 Alexey Proskuryakov <ap@apple.com>
7222 REGRESSION: API test failure: WKWebView.LocalStorageClear
7223 https://bugs.webkit.org/show_bug.cgi?id=166032
7224 <rdar://problem/29758423>
7226 Reviewed by Simon Fraser.
7228 Add an @autoreleasepool around the code that allocates then clears the WKWebView,
7229 to ensure that the view is destroyed before the callback fires.
7231 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
7234 2016-12-21 Saam Barati <sbarati@apple.com>
7236 WebAssembly: Import spec tests
7237 https://bugs.webkit.org/show_bug.cgi?id=166395
7239 Rubber stamped by Keith Miller.
7241 * Scripts/run-jsc-stress-tests:
7243 2016-12-21 Alexey Proskuryakov <ap@apple.com>
7245 REGRESSION: API test failure: _WKDownload.OriginatingWebView
7246 https://bugs.webkit.org/show_bug.cgi?id=166033
7247 <rdar://problem/29758428>
7249 Reviewed by Simon Fraser.
7251 Add an @autoreleasepool around the code that allocates the WKWebView,
7252 so that it can be destroyed by removing the last reference in _downloadDidStart.
7254 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
7257 2016-12-21 Daniel Bates <dabates@apple.com>
7259 WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
7260 https://bugs.webkit.org/show_bug.cgi?id=166356
7262 Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
7263 as a means to allow a test to explicit allow an embedding client to open a new windows
7264 such that the default behavior is for the embedding client to forbid such an action.
7265 The test plugins/get-url-with-blank-target.html assumes this default behavior though
7266 it is currently skipped on WebKit2 because questions were raised in the patch for
7267 <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
7268 We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
7271 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
7272 (WTR::TestRunner::setCanOpenWindows):
7274 2016-12-20 Simon Fraser <simon.fraser@apple.com>
7276 REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
7277 https://bugs.webkit.org/show_bug.cgi?id=166031
7279 Reviewed by Tim Horton.
7281 Add an @autoreleasepool around the code that allocates then clears the WKWebView,
7282 to ensure that the view is destroyed before the callback fires.
7284 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
7286 2016-12-20 Megan Gardner <megan_gardner@apple.com>
7288 Throw Exception when test doesn't clean up HID Events properly
7289 https://bugs.webkit.org/show_bug.cgi?id=166271
7291 Reviewed by Simon Fraser.
7293 Add in a check when UIScriptController is deleted to make sure that the HID event
7294 callback dictionary is empty. If it is not, and a HID event is hit, this will cause
7295 the program to crash without any good information. Crashes are race-y, and will still
7296 happen with malformed test, but the information will be much more helpful.
7298 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
7299 (WTR::UIScriptController::checkForClean):
7300 * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
7301 (UIScriptContext::~UIScriptContext):
7302 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
7303 (WTR::UIScriptController::checkForClean):
7304 * TestRunnerShared/UIScriptContext/UIScriptController.h:
7305 * WebKitTestRunner/ios/HIDEventGenerator.h:
7306 * WebKitTestRunner/ios/HIDEventGenerator.mm:
7307 (-[HIDEventGenerator checkHIDCallbacksClear]):
7308 * WebKitTestRunner/ios/TestControllerIOS.mm:
7309 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
7310 (WTR::UIScriptController::checkForClean):
7312 2016-12-20 Andy Estes <aestes@apple.com>
7314 [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
7315 https://bugs.webkit.org/show_bug.cgi?id=165992
7317 Reviewed by Brady Eidson.
7319 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
7320 * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
7322 (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
7323 (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
7324 (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
7325 (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
7326 (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
7327 (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
7328 (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
7330 * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
7332 2016-12-20 Dean Jackson <dino@apple.com>
7335 https://bugs.webkit.org/show_bug.cgi?id=165881
7336 <rdar://problem/29672532>
7338 Reviewed by Simon Fraser.
7340 The Indie UI work has been discontinued.
7342 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
7344 2016-12-19 Yusuke Suzuki <utatane.tea@gmail.com>
7346 [ES6] Enable ES6 Modules
7347 https://bugs.webkit.org/show_bug.cgi?id=165849
7349 Reviewed by Geoffrey Garen.
7351 * DumpRenderTree/mac/DumpRenderTree.mm:
7352 (resetWebPreferencesToConsistentValues):
7353 * DumpRenderTree/win/DumpRenderTree.cpp:
7354 (resetWebPreferencesToConsistentValues):
7355 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
7356 (WTR::InjectedBundle::beginTesting):
7357 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
7358 (WTR::TestRunner::setES6ModulesEnabled): Deleted.
7359 * WebKitTestRunner/InjectedBundle/TestRunner.h:
7361 2016-12-19 Ryan Haddad <ryanhaddad@apple.com>
7363 Repurpose bots and clean up dashboard.
7364 https://bugs.webkit.org/show_bug.cgi?id=166045
7366 Reviewed by Lucas Forschler.
7368 * BuildSlaveSupport/build.webkit.org-config/config.json:
7369 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
7370 (BubbleQueueServer):
7371 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
7372 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
7374 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
7375 (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
7377 2016-12-19 Michael Catanzaro <mcatanzaro@igalia.com>
7379 [CMake] TestWebKitAPIBase links to itself
7380 https://bugs.webkit.org/show_bug.cgi?id=165985
7382 Reviewed by Alex Christensen.
7384 Fix CMake warning about a target linking to itself, which makes no sense.
7386 * TestWebKitAPI/CMakeLists.txt:
7388 2016-12-19 Michael Catanzaro <mcatanzaro@igalia.com>
7390 [GTK] GtkDoc build should be quieter
7391 https://bugs.webkit.org/show_bug.cgi?id=165994
7393 Reviewed by Carlos Garcia Campos.
7395 Make it not print by default.
7397 * gtk/generate-gtkdoc:
7398 (get_generator_for_config):
7401 (GTKDoc._run_command):
7402 (GTKDoc._copy_doc_files_to_output_dir):
7404 2016-12-18 Simon Fraser <simon.fraser@apple.com>
7406 Expose a way for MiniBrowser to simulate header and footer banners
7407 https://bugs.webkit.org/show_bug.cgi?id=166005
7409 Reviewed by Wenson Hsieh.
7411 Add a MiniBrowser menu item and setting to toggle adding space for header and footer
7412 banners. This only works in WebKit2.
7414 We need to reset these on each navigation, since newly created FrameViews
7415 don't re-fetch the header and footer height stored on Page.
7417 Also fix the signature of webView:didFinishNavigation: to follow API changes,
7418 as well as fixing webViewWebContentProcessDidTerminate:
7420 * MiniBrowser/mac/SettingsController.h:
7421 * MiniBrowser/mac/SettingsController.m:
7422 (-[SettingsController _populateMenu]):
7423 (-[SettingsController validateMenuItem:]):
7424 (-[SettingsController toggleReserveSpaceForBanners:]):
7425 (-[SettingsController isSpaceReservedForBanners]):
7426 * MiniBrowser/mac/WK2BrowserWindowController.m:
7427 (-[WK2BrowserWindowController didChangeSettings]):
7428 (-[WK2BrowserWindowController webView:didFinishNavigation:]):
7429 (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
7430 (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
7431 (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
7433 2016-12-17 Simon Fraser <simon.fraser@apple.com>
7435 Fix iOS test results after r209967.
7437 Subtracting out the status bar height was erroneously happening for all tests,
7438 not just for flexible viewport tests.
7440 Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
7442 * WebKitTestRunner/PlatformWebView.h:
7443 * WebKitTestRunner/TestController.cpp:
7444 (WTR::TestController::resetStateToConsistentValues):
7445 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
7446 (WTR::PlatformWebView::resizeTo):
7447 (WTR::PlatformWebView::setWindowFrame):
7448 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
7449 (WTR::PlatformWebView::resizeTo):
7450 (WTR::PlatformWebView::setWindowFrame):
7451 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
7452 (WTR::PlatformWebView::resizeTo):
7453 (WTR::PlatformWebView::setWindowFrame):
7454 * WebKitTestRunner/ios/TestControllerIOS.mm:
7455 (WTR::TestController::platformConfigureViewForTest):
7456 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
7457 (WTR::PlatformWebView::resizeTo):
7458 (WTR::PlatformWebView::setWindowFrame):
7460 2016-12-17 Joonghun Park <jh718.park@samsung.com>
7462 [EFL] bump EFL version to 1.18.4
7463 https://bugs.webkit.org/show_bug.cgi?id=166004
7465 Reviewed by Gyuyoung Kim.
7467 * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
7469 2016-12-17 Wenson Hsieh <wenson_hsieh@apple.com>
7471 Visual viewports: bottom fixed elements disappear behind the keyboard
7472 https://bugs.webkit.org/show_bug.cgi?id=165983
7473 <rdar://problem/29409852>
7475 Reviewed by Simon Fraser.
7477 Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
7478 the keyboard when it is up.
7480 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
7481 (WTR::UIScriptController::inputViewBounds):
7482 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
7483 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
7484 (WTR::UIScriptController::inputViewBounds):
7485 * TestRunnerShared/UIScriptContext/UIScriptController.h:
7486 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
7487 (WTR::viewRectForWindowRect):
7489 Previously, we accounted for the status bar height by translating the entire web view down by the height of the
7490 status bar. However, we did not shrink the height of the web view itself, which means that for tests which
7491 involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
7493 (WTR::PlatformWebView::PlatformWebView):
7494 (WTR::PlatformWebView::setWindowFrame):
7495 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
7496 (WTR::UIScriptController::inputViewBounds):
7498 2016-12-16 Ryosuke Niwa <rniwa@webkit.org>
7500 Deleting a character converted from pinyin after an image causes a Safari crash
7501 https://bugs.webkit.org/show_bug.cgi?id=165839
7502 <rdar://problem/27951933>
7504 Reviewed by Wenson Hsieh.
7506 Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
7507 while the proposed range contains an image. This should not cause a WebProcess to crash
7508 or send an invalid message to the UIProcess.
7510 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
7511 * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
7512 * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
7513 (TestWebKitAPI::didFinishLoadForFrame):
7514 (TestWebKitAPI::processDidCrash):
7515 (TestWebKitAPI::invalidMessageFunction):
7516 (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
7518 2016-12-16 Wenson Hsieh <wenson_hsieh@apple.com>
7520 Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
7521 https://bugs.webkit.org/show_bug.cgi?id=165767
7522 <rdar://problem/29602382>
7524 Reviewed by Simon Fraser.
7526 Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
7527 WebKit2 ChangeLog for more details.
7529 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
7530 (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
7531 (WTR::UIScriptController::textSelectionCaretRect):
7532 * DumpRenderTree/mac/UIScriptControllerMac.mm:
7533 (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
7534 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
7535 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
7536 (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
7537 (WTR::UIScriptController::textSelectionCaretRect):
7538 * TestRunnerShared/UIScriptContext/UIScriptController.h:
7539 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
7540 (-[TestRunnerWKWebView _setStableStateOverride:]):
7542 Force the WKWebView to update its visible content rects when changing the stable state override.
7544 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
7545 (WTR::toNSDictionary):
7546 (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
7547 (WTR::UIScriptController::selectionRangeViewRects):
7548 (WTR::UIScriptController::textSelectionCaretRect):
7549 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
7550 (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
7552 2016-12-15 Brent Fulgham <bfulgham@apple.com>
7554 Arguments called in wrong order
7555 https://bugs.webkit.org/show_bug.cgi?id=165923
7557 Reviewed by Simon Fraser.
7559 The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
7560 and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
7562 * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
7563 (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
7564 order of arguments to WKUserMediaPermissionRequestAllow are flipped.
7566 2016-12-16 Hunseop Jeong <hs85.jeong@samsung.com>
7568 [EFL] Disable non-srcdir builds for failing libraries
7569 https://bugs.webkit.org/show_bug.cgi?id=165896
7571 Reviewed by Gyuyoung Kim.
7573 * efl/jhbuild.modules: Set non srcdir builds to no
7575 2016-12-15 Daniel Bates <dabates@apple.com>
7577 check-style should not complain about code in icu directories
7578 https://bugs.webkit.org/show_bug.cgi?id=53929
7580 Reviewed by Darin Adler.
7582 Skip style checking of imported ICU headers to avoid a deluge of style issues
7583 as they do not conform to the WebKit Code Style guideline. We want to preserve
7584 the formatting of these headers so as to make it straightforward to merge
7585 changes to them, if necessary.
7587 * Scripts/webkitpy/style/checker.py:
7589 2016-12-15 Alexey Proskuryakov <ap@apple.com>
7591 Move JSC testers from Yosemite to Sierra
7592 https://bugs.webkit.org/show_bug.cgi?id=165925
7594 Reviewed by Lucas Forschler.
7596 * BuildSlaveSupport/build.webkit.org-config/config.json:
7597 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
7600 2016-12-15 Megan Gardner <megan_gardner@apple.com>
7602 Add coordinate space to event streams and streamline tests
7603 https://bugs.webkit.org/show_bug.cgi?id=165119
7605 Reviewed by Simon Fraser.
7607 Update event streams to allow for both content and global coordinate space.
7608 Update example script to more accurately show all the available options.
7610 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
7611 * WebKitTestRunner/ios/HIDEventGenerator.h:
7612 * WebKitTestRunner/ios/HIDEventGenerator.mm:
7613 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
7614 (WTR::convertCoordinates):
7615 (WTR::UIScriptController::sendEventStream):
7617 2016-12-15 Claudio Saavedra <csaavedra@igalia.com>
7619 [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
7620 https://bugs.webkit.org/show_bug.cgi?id=165855
7622 Reviewed by Philippe Normand.
7624 GStreamer's autogen.sh enables gtk-doc always so we end up building
7625 docs even if we disable them. Use the configure script instead, since
7626 we build from packages and these include it already.
7628 * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
7629 upstream gstreamer packages.
7631 2016-12-15 Alex Christensen <achristensen@webkit.org>
7633 REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
7634 https://bugs.webkit.org/show_bug.cgi?id=165885
7635 <rdar://problem/29476917>
7637 Reviewed by Darin Adler.
7639 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
7640 (TestWebKitAPI::utf16String): Deleted.
7641 * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
7642 (TestWebKitAPI::TEST_F):
7643 * TestWebKitAPI/WTFStringUtilities.h:
7645 Moved from URLParser to share with other tests.
7647 2016-12-14 Ryosuke Niwa <rniwa@webkit.org>
7649 iOS: An element with tabindex is not focusable unless there is no mouse event handler
7650 https://bugs.webkit.org/show_bug.cgi?id=165843
7652 Reviewed by Antti Koivisto.
7654 Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
7655 Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
7656 and DumpRenderTree's runUIScript would hit an assertion :(
7658 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
7659 * WebKitTestRunner/InjectedBundle/TestRunner.h:
7660 (WTR::TestRunner::isWebKit2):
7662 2016-12-14 Brady Eidson <beidson@apple.com>
7664 IndexedDB 2.0: Massively speedup IDBIndex.get().
7665 https://bugs.webkit.org/show_bug.cgi?id=165802
7667 Reviewed by Alex Christensen.
7669 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
7670 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
7671 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
7672 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
7673 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
7675 2016-12-14 Carlos Alberto Lopez Perez <clopez@igalia.com>
7677 [GTK][EFL] Update the JHBuild version.
7678 https://bugs.webkit.org/show_bug.cgi?id=165838
7680 Reviewed by Michael Catanzaro.
7682 * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
7683 usage of the JHBUILD_MIRROR feature with git repositories.
7685 2016-12-14 Carlos Alberto Lopez Perez <clopez@igalia.com>
7687 [GTK] Yasm is needed for building the JHBuild after r208940
7688 https://bugs.webkit.org/show_bug.cgi?id=165837
7690 Reviewed by Alejandro G. Castro.
7692 * gtk/install-dependencies: Yasm is needed for building libvpx.
7694 2016-12-14 Youenn Fablet <youenn@apple.com>
7696 Test infrastructure should allow to filter out text output before doing a comparison with the baseline
7697 https://bugs.webkit.org/show_bug.cgi?id=161310
7699 Reviewed by Ryosuke Niwa.
7701 Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
7702 When set, WTR and DRT output JS console log in the stderr and not the test output.
7703 This allows removing potentially flaky information while still being able to read it for investigation.
7705 Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
7707 Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
7708 This test should have this option when fetch API will start logging resource loader errors.
7710 * DumpRenderTree/DumpRenderTree.h:
7711 (TestCommand::TestCommand): Deleted.
7712 * DumpRenderTree/DumpRenderTreeCommon.cpp:
7714 * DumpRenderTree/TestRunner.h:
7715 (TestRunner::setDumpJSConsoleLogInStdErr):
7716 (TestRunner::dumpJSConsoleLogInStdErr):
7717 * DumpRenderTree/mac/DumpRenderTree.mm:
7719 * DumpRenderTree/mac/UIDelegate.mm:
7720 (-[UIDelegate webView:addMessageToConsole:withSource:]):
7721 * DumpRenderTree/win/DumpRenderTree.cpp:
7723 * DumpRenderTree/win/UIDelegate.cpp:
7724 (UIDelegate::webViewAddMessageToConsole):
7725 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
7726 (TestExpectationParser._tokenize_line):
7727 * Scripts/webkitpy/port/driver.py:
7728 (Driver._command_from_driver_input):
7729 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
7730 (WTR::InjectedBundle::didReceiveMessageToPage):
7731 (WTR::InjectedBundle::dumpToStdErr):
7732 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
7733 (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
7734 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
7735 (WTR::InjectedBundlePage::willAddMessageToConsole):
7736 * WebKitTestRunner/TestController.cpp:
7737 (WTR::parseInputLine):
7738 (WTR::TestController::runTest):
7739 (WTR::TestCommand::TestCommand): Deleted.
7740 * WebKitTestRunner/TestInvocation.cpp:
7741 (WTR::TestInvocation::invoke):
7742 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
7743 * WebKitTestRunner/TestInvocation.h:
7744 (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
7747 2016-12-14 Enrique Ocaña González <eocanha@igalia.com>
7749 REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
7750 https://bugs.webkit.org/show_bug.cgi?id=164022
7752 Reviewed by Xabier Rodriguez-Calvar.
7754 * Scripts/webkitperl/FeatureList.pm:
7755 Re-enable MEDIA_SOURCE for the GTK+ port.
7757 2016-12-13 Alex Christensen <achristensen@webkit.org>
7761 * DumpRenderTree/PlatformMac.cmake:
7762 Define NS_RETURNS_RETAINED as nothing for now.
7764 2016-12-13 Jer Noble <jer.noble@apple.com>
7766 Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
7767 https://bugs.webkit.org/show_bug.cgi?id=165697
7769 Reviewed by Tim Horton.
7771 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
7772 (TestWebKitAPI::TEST):
7774 2016-12-13 Andy Estes <aestes@apple.com>
7776 [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
7777 https://bugs.webkit.org/show_bug.cgi?id=165785
7778 <rdar://problem/26929398>
7780 Reviewed by Darin Adler.
7782 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
7783 (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
7784 expectations for the text, range, and action.
7785 (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
7786 will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
7787 plain-text string to the pasteboard, executed a paste action, and verified that the selected
7788 text in the web view did not change.
7789 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
7790 (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
7791 _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
7793 (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
7794 Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
7795 and returned the value of _editingDelegateShouldInsertText.
7796 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
7797 -shouldInsertText:replacingRange:givenAction:.
7799 2016-12-13 Chris Dumez <cdumez@apple.com>
7801 Unreviewed, rolling out r209544.
7803 Looks like r209489 did not cause the performance regression
7808 "Unreviewed, rolling out r209489."
7809 https://bugs.webkit.org/show_bug.cgi?id=165550
7810 http://trac.webkit.org/changeset/209544
7812 2016-12-12 Sam Weinig <sam@webkit.org>
7814 [WebIDL] Remove use of Dictionary in ApplePaySession
7815 https://bugs.webkit.org/show_bug.cgi?id=165787
7817 Reviewed by Anders Carlsson.
7819 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
7820 (WTR::initializeWebViewConfiguration):
7821 (WTR::TestController::platformCreateWebView):
7822 Enable ApplePay for the tests (where supported).
7824 2016-12-13 Eric Carlson <eric.carlson@apple.com>
7826 Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
7827 https://bugs.webkit.org/show_bug.cgi?id=165251
7829 Reviewed by Youenn Fablet.
7831 * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
7832 (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
7833 the preferences have been set.
7835 2016-12-08 Antti Koivisto <antti@apple.com>
7837 Enable network cache speculative revalidation in MiniBrowser
7838 https://bugs.webkit.org/show_bug.cgi?id=165616
7840 Reviewed by Darin Adler.
7842 Match Safari. Also add a menu item to disable it.
7844 * MiniBrowser/mac/AppDelegate.m:
7845 (defaultConfiguration):
7846 * MiniBrowser/mac/SettingsController.h:
7847 * MiniBrowser/mac/SettingsController.m:
7848 (-[SettingsController _populateMenu]):
7849 (-[SettingsController validateMenuItem:]):
7850 (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
7851 (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
7853 2016-12-12 Alexey Proskuryakov <ap@apple.com>
7855 ChangeLogs become readonly after resolving a conflict
7856 https://bugs.webkit.org/show_bug.cgi?id=165440
7857 rdar://problem/29491002
7859 Reviewed by Darin Adler.
7861 * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
7864 2016-12-12 Filip Pizlo <fpizlo@apple.com>
7866 Re-enable collectContinuously since it doesn't crash anymore
7868 Rubber stamped by Michael Saboff.
7870 * Scripts/run-jsc-stress-tests:
7872 2016-12-11 Konstantin Tokarev <annulen@yandex.ru>
7874 Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
7875 https://bugs.webkit.org/show_bug.cgi?id=165686
7877 * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
7878 so that right config.h comes first in include path.
7880 2016-12-11 Dave Hyatt <hyatt@apple.com>
7882 [CSS Parser] Make sure content extensions initialize AtomicString
7883 https://bugs.webkit.org/show_bug.cgi?id=165737
7885 Reviewed by Darin Adler.
7887 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
7888 (TestWebKitAPI::makeBackend):
7890 2016-12-08 Dave Hyatt <hyatt@apple.com>
7892 [CSS Parser] Remove the old CSS Parser
7893 https://bugs.webkit.org/show_bug.cgi?id=165645
7895 Reviewed by Daniel Bates.
7897 * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
7898 (TestWebKitAPI::TEST):
7900 2016-12-10 Konstantin Tokarev <annulen@yandex.ru>
7902 [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
7903 https://bugs.webkit.org/show_bug.cgi?id=165686
7905 Reviewed by Michael Catanzaro.
7907 This change reduces duplication of include path lists between modules,
7908 and reduces future need for fixes like r209605 (broken build because of
7909 WebCore header suddenly becoming used in WebKit2).
7911 * DumpRenderTree/CMakeLists.txt:
7912 * DumpRenderTree/PlatformMac.cmake:
7913 * ImageDiff/CMakeLists.txt:
7914 * MiniBrowser/gtk/CMakeLists.txt:
7915 * MiniBrowser/mac/CMakeLists.txt:
7916 * MiniBrowser/win/CMakeLists.txt:
7917 * TestWebKitAPI/CMakeLists.txt:
7918 * TestWebKitAPI/PlatformEfl.cmake:
7919 * TestWebKitAPI/PlatformJSCOnly.cmake:
7920 * TestWebKitAPI/PlatformMac.cmake:
7921 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
7922 * WebKitTestRunner/CMakeLists.txt:
7923 * WebKitTestRunner/PlatformGTK.cmake:
7924 * WebKitTestRunner/PlatformMac.cmake:
7926 2016-12-09 Csaba Osztrogonác <ossy@webkit.org>
7928 Unreviewed buildfix after r209630.
7930 * Scripts/build-jsc: Remove building the non-existing testWASM.
7932 2016-12-09 Eric Carlson <eric.carlson@apple.com>
7934 Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
7935 https://bugs.webkit.org/show_bug.cgi?id=165251
7937 Reviewed by Dean Jackson.
7939 Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
7941 * DumpRenderTree/mac/DumpRenderTree.mm:
7942 (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
7944 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
7945 (WTR::InjectedBundle::beginTesting): Ditto.
7947 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
7948 (WTR::TestRunner::setMediaStreamEnabled): New.
7949 (WTR::TestRunner::setPeerConnectionEnabled): New.
7950 * WebKitTestRunner/InjectedBundle/TestRunner.h:
7952 2016-12-09 Brady Eidson <beidson@apple.com>
7955 Add _WKIconLoadingDelegate SPI.
7956 https://bugs.webkit.org/show_bug.cgi?id=164894
7958 Reviewed by Alex Christensen.
7960 Add MiniBrowser support for this new SPI, configurable with a setting.
7962 * MiniBrowser/mac/SettingsController.h:
7963 * MiniBrowser/mac/SettingsController.m:
7964 (-[SettingsController _populateMenu]):
7965 (-[SettingsController validateMenuItem:]):
7966 (-[SettingsController loadsAllSiteIcons]):
7967 (-[SettingsController toggleLoadsAllSiteIcons:]):
7968 * MiniBrowser/mac/WK2BrowserWindowController.m:
7969 (-[WK2BrowserWindowController awakeFromNib]):
7970 (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]):
7972 2016-12-09 Ryan Haddad <ryanhaddad@apple.com>
7974 Fix the 32-bit build.
7976 Unreviewed build fix.
7978 * MiniBrowser/mac/SettingsController.h:
7980 2016-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7982 Fedora also needs a PHP7 config file alternative
7983 https://bugs.webkit.org/show_bug.cgi?id=165606
7985 Reviewed by Michael Catanzaro.
7987 * Scripts/webkitpy/port/base.py:
7988 (Port._is_fedora_php_version_7): check for the php7 library.
7989 (Port._fedora_php_version): get the appropriate filename for Fedora.
7990 (Port._apache_config_file_name_for_platform):
7992 2016-12-09 Ryan Haddad <ryanhaddad@apple.com>
7994 Complete the revert of r208865.
7995 https://bugs.webkit.org/show_bug.cgi?id=164894
7997 Unreviewed build fix.
7999 * MiniBrowser/mac/SettingsController.h:
8000 * MiniBrowser/mac/SettingsController.m:
8001 (-[SettingsController _populateMenu]):
8002 (-[SettingsController validateMenuItem:]):
8003 (-[SettingsController loadsAllSiteIcons]): Deleted.
8004 (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
8005 * MiniBrowser/mac/WK2BrowserWindowController.m:
8006 (-[WK2BrowserWindowController awakeFromNib]):
8007 (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
8009 2016-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8011 [GTK] Force GDK backend to x11 when running with XvfbDriver
8012 https://bugs.webkit.org/show_bug.cgi?id=165612
8014 Reviewed by Michael Catanzaro.
8016 When the developer is running a Wayland session, GDK may get confused
8017 and try to use its Wayland backend (which is higher priority) instead.
8018 This ensures it will use the appropriate backend when running under
8021 * Scripts/webkitpy/port/gtk.py:
8022 (GtkPort.setup_environ_for_server): when running with XvfbDriver,
8023 force GDK_BACKEND to x11.
8025 2016-12-08 Keith Miller <keith_miller@apple.com>
8027 Add 64-bit signed LEB decode method
8028 https://bugs.webkit.org/show_bug.cgi?id=165630
8030 Reviewed by Ryosuke Niwa.
8032 Add tests for LEB int64 and uint64 decode since I guess
8033 I forgot to add tests before.
8035 * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
8036 (TestWebKitAPI::testUInt32LEBDecode):
8037 (TestWebKitAPI::TEST):
8038 (TestWebKitAPI::testUInt64LEBDecode):
8039 (TestWebKitAPI::testInt32LEBDecode):
8040 (TestWebKitAPI::testInt64LEBDecode):
8041 (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
8043 2016-12-08 Filip Pizlo <fpizlo@apple.com>
8045 Make it easy to enable --force-collectContinuously
8046 https://bugs.webkit.org/show_bug.cgi?id=165638
8048 Reviewed by Keith Miller.
8050 * Scripts/run-javascriptcore-tests:
8051 (runJSCStressTests):
8053 2016-12-08 Filip Pizlo <fpizlo@apple.com>
8055 Disable the collectContinuously mode until I investigate failures.
8057 Rubber stamped by Keith Miller.
8059 I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
8060 while I investigate.
8062 * Scripts/run-jsc-stress-tests:
8064 2016-12-08 Alex Christensen <achristensen@webkit.org>
8066 REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
8067 https://bugs.webkit.org/show_bug.cgi?id=165621
8069 Reviewed by Dan Bernstein.
8071 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
8072 (TestWebKitAPI::TEST_F):
8074 2016-12-06 Filip Pizlo <fpizlo@apple.com>
8076 Concurrent GC should be stable enough to land enabled
8077 https://bugs.webkit.org/show_bug.cgi?id=164990
8079 Reviewed by Geoffrey Garen.
8081 Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
8083 It's clear that this works just fine in release, but I'm still trying to figure out if it's
8084 safe for debug. It might be too slow for debug.
8086 * Scripts/run-jsc-stress-tests:
8088 2016-12-08 Alex Christensen <achristensen@webkit.org>
8090 Add SPI for sending WebsiteSettings to WebProcess during navigation
8091 https://bugs.webkit.org/show_bug.cgi?id=165517
8094 Reviewed by Anders Carlsson.
8096 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
8097 * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
8098 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
8099 (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
8100 (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
8101 (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
8104 2016-12-08 Chris Dumez <cdumez@apple.com>
8106 Unreviewed, rolling out r209489.
8108 Likely caused large regressions on JetStream, Sunspider and
8113 "Add system trace points for JavaScript VM entry/exit"
8114 https://bugs.webkit.org/show_bug.cgi?id=165550
8115 http://trac.webkit.org/changeset/209489
8117 2016-12-08 Keith Miller <keith_miller@apple.com>
8119 Move LEB tests to API tests
8120 https://bugs.webkit.org/show_bug.cgi?id=165586
8122 Reviewed by Saam Barati.
8124 Move the tests from testWasm.cpp and make them functions
8127 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
8128 * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
8129 (TestWebKitAPI::testUnsignedLEBDecode):
8130 (TestWebKitAPI::TEST):
8131 (TestWebKitAPI::testInt32LEBDecode):
8133 2016-12-08 Chris Dumez <cdumez@apple.com>
8135 Support running the layout tests offline
8136 https://bugs.webkit.org/show_bug.cgi?id=165534
8138 Reviewed by Ryosuke Niwa.
8140 * Scripts/webkitpy/common/system/autoinstall.py:
8141 (AutoInstaller._download_to_stream):
8142 getcode() returns None for file URLs so handle this.
8144 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
8145 (WebPlatformTestServer._install_modules):
8146 Deal with local path in the json file and resolve them into file URLs
8147 before using AutoInstall.
8149 2016-12-08 Alex Christensen <achristensen@webkit.org>
8153 * DumpRenderTree/PlatformMac.cmake:
8154 Remove CheckedMalloc.cpp after r209516.
8156 2016-12-07 Mark Lam <mark.lam@apple.com>
8158 DumpRenderTree should stop using CheckedMalloc.
8159 https://bugs.webkit.org/show_bug.cgi?id=165563
8160 <rdar://problem/28945820>
8162 Reviewed by Geoffrey Garen.
8164 1. WebKitTestRunner does not have equivalent behavior to that which is implemented
8166 2. bmalloc does not honor the settings of CheckedMalloc.
8168 The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
8169 malloc. As a result, DRT exhibits different behavior from the normal way we run
8170 our tests. We should obsolete CheckedMalloc and make DRT behave consistently
8173 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
8174 * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
8175 * DumpRenderTree/mac/CheckedMalloc.h: Removed.
8176 * DumpRenderTree/mac/DumpRenderTree.mm:
8177 (prepareConsistentTestingEnvironment):
8179 2016-12-07 Dean Jackson <dino@apple.com>
8181 Remove runtime toggle for pointer-lock
8182 https://bugs.webkit.org/show_bug.cgi?id=165577
8183 <rdar://problems/29566996>
8185 Reviewed by Jon Lee.
8187 Remove any runtime calls to check if pointer-lock is enabled. It's
8188 either compiled in or out.
8190 * DumpRenderTree/mac/DumpRenderTree.mm:
8191 (resetWebPreferencesToConsistentValues):
8192 * WebKitTestRunner/TestController.cpp:
8193 (WTR::TestController::resetPreferencesToConsistentValues):
8195 2016-12-07 Eric Carlson <eric.carlson@apple.com>
8197 [MediaStream][Mac] Revoke sandbox extensions when capture ends
8198 https://bugs.webkit.org/show_bug.cgi?id=165476
8200 Reviewed by Brady Eidson.
8202 Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
8203 page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
8204 is reset and recreated when a web page exits and is reloaded.
8206 * TestWebKitAPI/PlatformGTK.cmake:
8207 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
8208 * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
8209 (TestWebKitAPI::checkUserMediaPermissionCallback):
8210 (TestWebKitAPI::TEST):
8211 * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
8213 2016-12-07 Jeremy Jones <jeremyj@apple.com>
8215 One esc to exit fullscreen and pointer lock
8216 https://bugs.webkit.org/show_bug.cgi?id=165416
8217 rdar://problem/29430711
8219 Reviewed by Jer Noble.
8221 Implement WKPageUIClientV8 for pointer lock support.
8222 Add "escape" key support in EventSenderProxy.
8224 * WebKitTestRunner/TestController.cpp:
8225 (WTR::requestPointerLock):
8226 (WTR::TestController::createOtherPage):
8227 (WTR::TestController::createWebViewWithOptions):
8228 * WebKitTestRunner/mac/EventSenderProxy.mm:
8229 (WTR::EventSenderProxy::keyDown):
8231 2016-12-07 Simon Fraser <simon.fraser@apple.com>
8233 Add system trace points for JavaScript VM entry/exit
8234 https://bugs.webkit.org/show_bug.cgi?id=165550
8236 Reviewed by Tim Horton.
8238 Add trace points for entry/exit into/out of the JS VM.
8240 * Tracing/SystemTracePoints.plist:
8242 2016-12-07 ChangSeok Oh <changseok@webkit.org>
8244 [GTK] Cannot build GTK+ with CUPS 2.* versions
8245 https://bugs.webkit.org/show_bug.cgi?id=163591
8247 Reviewed by Michael Catanzaro.
8249 GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
8250 does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
8251 GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
8252 old gtk+ since it requires not only bumping up glib accordingly and its consequence
8253 causes many printing test failures. So, I propose to fix the configuration issue by
8254 applying the change to the configure file directly. By doing this, we don't need to
8255 upgrade glib and worry about any test failures as a consequence of the upgraded glib.
8257 * gtk/jhbuild.modules:
8258 * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
8260 2016-12-07 Simon Fraser <simon.fraser@apple.com>
8262 Fix use of enum in a WK2 C SPI header.
8263 rdar://problem/28725583
8265 Followup to correctly prefix the enum values.
8267 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
8268 (WTR::InjectedBundlePage::prepare):
8270 2016-12-07 Simon Fraser <simon.fraser@apple.com>
8272 Fix use of enum in a WK2 C SPI header.
8273 rdar://problem/28725583
8275 Reviewed by Dan Bernstein.
8277 Use correct enum style for a C SPI header and fix the callers.
8279 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
8280 (WTR::InjectedBundlePage::prepare):
8282 2016-12-07 Wenson Hsieh <wenson_hsieh@apple.com>
8284 Add a new project for recording and playing back editing commands in editable web content
8285 https://bugs.webkit.org/show_bug.cgi?id=165114
8286 <rdar://problem/29408135>
8288 Reviewed by Beth Dakin.
8290 Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
8291 wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
8292 capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
8293 then be dragged into the playback test harness.
8295 Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
8298 1. Load the capture harness and perform test-specific editing on the web view.
8299 2. Let originalState be a dump of the DOM at this point in time.
8300 3. Extract the JSON-serialized editing history data and load the playback harness with this data.
8301 4. Rewind all editing to the beginning.
8302 5. Playback all editing to the end.
8303 6. Dump the state of the DOM. This should be identical to originalState.
8305 * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
8306 * EditingHistory/EditingHistory/Info.plist: Added.
8307 * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
8308 * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
8309 * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
8310 * EditingHistory/EditingHistory/TestRunner.h: Added.
8311 * EditingHistory/EditingHistory/TestRunner.m: Added.
8312 (injectedMessageEventHandlerScript):
8313 (-[TestRunner init]):
8314 (-[TestRunner deleteBackwards:]):
8315 (-[TestRunner typeString:]):
8316 (-[TestRunner bodyElementSubtree]):
8317 (-[TestRunner bodyTextContent]):
8318 (-[TestRunner editingHistoryJSON]):
8319 (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
8320 (-[TestRunner numberOfUpdates]):
8321 (-[TestRunner jumpToUpdateIndex:]):
8322 (-[TestRunner expectEvents:afterPerforming:]):
8323 (-[TestRunner loadCaptureTestHarness]):
8324 (-[TestRunner setTextObfuscationEnabled:]):
8325 (-[TestRunner isDoneWaitingForPendingEvents]):
8326 (-[TestRunner userContentController:didReceiveScriptMessage:]):
8328 The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
8329 or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
8331 * EditingHistory/EditingHistory/TestUtil.h: Added.
8332 * EditingHistory/EditingHistory/TestUtil.m: Added.
8333 (waitUntilWithTimeout):
8336 Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
8338 * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
8339 * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
8340 (-[WKWebView loadPageFromBundleNamed:]):
8341 (-[WKWebView typeCharacter:]):
8342 (-[WKWebView keyPressWithCharacters:keyCode:]):
8343 (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
8345 Provides utilities for simulating interaction in a web view.
8347 * EditingHistory/EditingHistory/main.m: Added.
8349 * EditingHistory/EditingHistoryTests/Info.plist: Added.
8350 * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
8351 (-[RewindAndPlaybackTests setUp]):
8352 (-[RewindAndPlaybackTests tearDown]):
8353 (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
8354 (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
8355 (-[RewindAndPlaybackTests testTypingAndDeletingText]):
8356 (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
8357 (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
8359 2016-12-07 Philippe Normand <pnormand@igalia.com>
8361 [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
8362 https://bugs.webkit.org/show_bug.cgi?id=165525
8364 Reviewed by Carlos Garcia Campos.
8366 * gtk/jhbuild.modules: gst-plugins-good should depend on the
8367 libvpx package built within jhbuild.
8369 2016-12-07 Philippe Normand <pnormand@igalia.com>
8371 [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
8372 https://bugs.webkit.org/show_bug.cgi?id=165520
8374 Reviewed by Carlos Garcia Campos.
8376 * gtk/jhbuild.modules: Added missing dependency on openh264 in
8377 gst-plugins-bad, along with 2 upstream patches fixing the build
8378 against OpenSSL 1.1.0.
8379 * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
8380 * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
8382 2016-12-06 Alexey Proskuryakov <ap@apple.com>
8384 Correct SDKROOT values in xcconfig files
8385 https://bugs.webkit.org/show_bug.cgi?id=165487
8386 rdar://problem/29539209
8388 Reviewed by Dan Bernstein.
8390 Fix suggested by Dan Bernstein.
8392 * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
8393 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
8394 * MiniBrowser/Configurations/DebugRelease.xcconfig:
8395 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
8396 * WebEditingTester/Configurations/DebugRelease.xcconfig:
8397 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
8399 2016-12-06 Daniel Bates <dabates@apple.com>
8401 WebKitTestRunner: Plugins are disabled in new windows
8402 https://bugs.webkit.org/show_bug.cgi?id=165410
8404 Reviewed by Alex Christensen.
8406 Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
8407 a new window and loads a plugin will fail. We should enable plugins in all windows by
8408 default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
8410 Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
8411 in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
8412 will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
8414 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
8415 (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
8416 WKBundleSetPluginsEnabled().
8417 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
8418 (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
8419 and make use of WKBundleOverrideBoolPreferenceForTestRunner().
8421 2016-12-05 Dean Jackson <dino@apple.com>
8423 pointer lock needs to be feature detectable
8424 https://bugs.webkit.org/show_bug.cgi?id=165426
8425 <rdar://problem/29486715>
8427 Reviewed by Antoine Quint.
8429 Expose the comment line to turn on/off pointer lock.
8431 * DumpRenderTree/TestOptions.h:
8432 * DumpRenderTree/TestOptions.mm:
8433 (TestOptions::TestOptions):
8434 * DumpRenderTree/mac/DumpRenderTree.mm:
8435 (resetWebPreferencesToConsistentValues):
8436 * WebKitTestRunner/TestController.cpp:
8437 (WTR::TestController::resetPreferencesToConsistentValues):
8438 (WTR::updateTestOptionsFromTestHeader):
8439 * WebKitTestRunner/TestOptions.h:
8440 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
8441 (WTR::PlatformWebView::viewSupportsOptions):
8442 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
8443 (WTR::PlatformWebView::viewSupportsOptions):
8445 2016-12-05 Jonathan Bedard <jbedard@apple.com>
8447 Make it possible to use an existing simulator instance for one-off testing
8448 https://bugs.webkit.org/show_bug.cgi?id=164568
8449 <rdar://problem/29189133>
8451 Reviewed by Daniel Bates.
8453 With this patch, if a simulator is currently running on the machine and
8454 '--dedicated-simulators' is not passed into the application, only one simulator
8455 instance will be used, and this instance will be the existing instance.
8456 If no simulator is running or '--dedicated-simulators' is passed to the script,
8457 previous behavior will be used.
8459 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
8461 * Scripts/webkitpy/port/ios.py:
8462 (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
8463 (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
8464 (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
8465 (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
8466 (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them.
8467 (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
8468 (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
8469 * Scripts/webkitpy/xcode/simulator.py:
8470 (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator.
8471 (Simulator.current_device): Get currently running device.
8473 2016-12-05 Dan Bernstein <mitz@apple.com>
8475 Disable a crashing test on iOS.
8477 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
8479 2016-12-04 Gyuyoung Kim <gyuyoung.kim@webkit.org>
8481 Fix a build break on EFL since r209303.
8483 Unreviewed build fix.
8485 * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily.
8487 2016-12-03 Yusuke Suzuki <utatane.tea@gmail.com>
8489 Refactor SymbolImpl layout
8490 https://bugs.webkit.org/show_bug.cgi?id=165247
8492 Reviewed by Darin Adler.
8494 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
8495 (TestWebKitAPI::TEST):
8497 2016-12-03 Dan Bernstein <mitz@apple.com>
8499 Fixed the build after r209307.
8501 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
8504 2016-12-03 Dan Bernstein <mitz@apple.com>
8506 [Cocoa] Expose InjectedBundlePageEditorClient via the Objective-C bundle SPI
8507 https://bugs.webkit.org/show_bug.cgi?id=165276
8508 <rdar://problem/29467040>
8510 Reviewed by Darin Adler.
8512 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
8513 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Added.
8514 (-[BundleEditingDelegateRemoteObject willWriteToPasteboard:]):
8515 (-[BundleEditingDelegateRemoteObject didWriteToPasteboard]):
8517 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Added.
8518 (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
8519 (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:willWriteRangeToPasteboard:]):
8520 (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
8521 (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextControllerDidWriteToPasteboard:]):
8522 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Added.
8524 2016-12-02 Andy Estes <aestes@apple.com>
8526 [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
8527 https://bugs.webkit.org/show_bug.cgi?id=164492
8529 Reviewed by Dan Bernstein.
8531 * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
8532 com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
8533 * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
8534 org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
8535 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
8536 PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
8537 * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
8538 PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
8539 * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
8540 org.webkit.$(PRODUCT_NAME:rfc1034identifier).
8541 * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
8542 com.apple.$(PRODUCT_NAME:rfc1034identifier).
8543 * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
8544 com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
8545 * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
8546 org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
8547 * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
8548 InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
8549 com.apple.$(PRODUCT_NAME:rfc1034identifier).
8550 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
8551 com.apple.$(PRODUCT_NAME:rfc1034identifier).
8552 * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
8553 com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
8554 * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
8555 value ${PRODUCT_BUNDLE_IDENTIFIER}.
8556 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
8557 InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
8558 com.apple.WebKitTestRunner.InjectedBundle.
8559 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
8560 PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
8561 * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
8562 com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
8563 * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
8564 CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
8565 ${PRODUCT_BUNDLE_IDENTIFIER}.
8567 2016-12-02 Brady Eidson <beidson@apple.com>
8569 Make IndexedDB.WebProcessKillIDBCleanup even more reliable.
8570 https://bugs.webkit.org/show_bug.cgi?id=165330
8572 Reviewed by Alex Christensen.
8574 The test currently nulls out a RetainPtr<WKWebView> to try to destroy the view and kill the process.
8576 Problem is that doesn't reliably destroy the view.
8577 We should explicitly kill the process instead.
8579 Also, by relocating when we kill the process, we can better test behavior of the IndexedDB mechanism.
8580 e.g. We explicitly confirm that a second WebProcess can simultaneously attach to the same unique database as the first.
8582 * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
8585 2016-12-02 Commit Queue <commit-queue@webkit.org>
8587 Unreviewed, rolling out r209136.
8588 https://bugs.webkit.org/show_bug.cgi?id=165337
8590 broke 36 webkitpy tests (Requested by mcatanzaro on #webkit).
8594 "Make it possible to use an existing simulator instance for
8596 https://bugs.webkit.org/show_bug.cgi?id=164568
8597 http://trac.webkit.org/changeset/209136
8599 2016-12-02 Chris Dumez <cdumez@apple.com>
8601 [Mac][WK1] Implement new HTML interactive form validation user interface
8602 https://bugs.webkit.org/show_bug.cgi?id=164483
8604 Reviewed by Simon Fraser.
8606 Add support for UIScriptController's contentsOfUserInterfaceItem("validationBubble")
8607 on Mac DRT as this is needed by the HTML form validation layout tests.
8609 * DumpRenderTree/mac/UIScriptControllerMac.mm:
8610 (WTR::UIScriptController::contentsOfUserInterfaceItem):
8612 2016-12-02 Brady Eidson <beidson@apple.com>
8614 IndexedDB.IndexedDBMultiProcess and IndexedDB.WebProcessKillIDBCleanup sometimes timeout.
8615 https://bugs.webkit.org/show_bug.cgi?id=160780 and https://bugs.webkit.org/show_bug.cgi?id=161001
8617 Reviewed by Alexey Proskuryakov.
8619 These tests had "run-loop races."
8621 The test spins the runloop waiting for one message.
8622 Two messages might come in from the WebProcess in short succession, and both be delivered to the
8623 UIProcess in the same spin of the runloop.
8625 Therefore by the time the test stops spinning the runloop, notified that a message was received,
8626 the first message has been overwritten by the second.
8628 These tests are fixed by queueing the incoming messages instead of just storing one.
8630 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
8631 (-[IndexedDBMPMessageHandler userContentController:didReceiveScriptMessage:]):
8635 * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
8636 (-[IndexedDBWebProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
8640 2016-12-01 Jiewen Tan <jiewen_tan@apple.com>
8642 Add a runtime flag for SubtleCrypto
8643 https://bugs.webkit.org/show_bug.cgi?id=164982
8645 Reviewed by Brent Fulgham.
8647 * DumpRenderTree/mac/DumpRenderTree.mm:
8648 (resetWebPreferencesToConsistentValues):
8649 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
8650 (WTR::InjectedBundle::beginTesting):
8651 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
8652 (WTR::TestRunner::setSubtleCryptoEnabled):
8653 * WebKitTestRunner/InjectedBundle/TestRunner.h:
8655 2016-12-01 Alexey Proskuryakov <ap@apple.com>
8657 Remove webkitpy dependency on Eliza
8658 https://bugs.webkit.org/show_bug.cgi?id=164979
8660 Reviewed by Daniel Bates.
8662 This module is not on pypi, so installing it is a challenge. The jokes feel pretty old too!
8664 * Scripts/webkitpy/thirdparty/__init__.py:
8665 * Scripts/webkitpy/thirdparty/__init___unittest.py: Changed mock import hook to
8666 test buildbot instead of eliza.
8667 * Scripts/webkitpy/tool/bot/ircbot.py:
8668 * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
8670 2016-12-01 Beth Dakin <bdakin@apple.com>
8672 Force clicking tests fail on some machines
8673 https://bugs.webkit.org/show_bug.cgi?id=165263
8675 Reviewed by Tim Horton.
8677 Initialize com.apple.trackpad.forceClick to 1 so that we don’t have to depend on
8678 the user account having this feature enabled.
8679 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
8680 (WTR::InjectedBundle::platformInitialize):
8681 * WebKitTestRunner/mac/main.mm:
8682 (setDefaultsToConsistentValuesForTesting):
8684 2016-12-01 Yusuke Suzuki <utatane.tea@gmail.com>
8686 Introduce StringImpl::StaticStringImpl with constexpr constructor
8687 https://bugs.webkit.org/show_bug.cgi?id=165093
8689 Reviewed by Darin Adler.
8691 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
8692 (TestWebKitAPI::TEST):
8694 2016-11-30 Antoine Quint <graouts@apple.com>
8696 [Modern Media Controls] Add an HTML comment flag to turn the feature on
8697 https://bugs.webkit.org/show_bug.cgi?id=165226
8699 Reviewed by Dean Jackson.
8701 Add a new flag to turn Modern Media Controls on in the test runners.
8703 * DumpRenderTree/TestOptions.h:
8704 * DumpRenderTree/TestOptions.mm:
8705 (TestOptions::TestOptions):
8706 * DumpRenderTree/mac/DumpRenderTree.mm:
8707 (resetWebPreferencesToConsistentValues):
8708 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
8709 (WTR::InjectedBundle::beginTesting):
8710 * WebKitTestRunner/TestController.cpp:
8711 (WTR::TestController::resetPreferencesToConsistentValues):
8712 (WTR::updateTestOptionsFromTestHeader):
8713 * WebKitTestRunner/TestOptions.h:
8714 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
8715 (WTR::PlatformWebView::viewSupportsOptions):
8716 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
8717 (WTR::PlatformWebView::viewSupportsOptions):
8719 2016-11-30 Said Abou-Hallawa <sabouhallawa@apple.com>
8721 Add separate settings and preferences to enable/disable async decoding for large images and animated images
8722 https://bugs.webkit.org/show_bug.cgi?id=165177
8724 Reviewed by Simon Fraser.
8726 Pref and a menu item to toggle async image decoding settings for WebKits 1 and 2.
8728 * MiniBrowser/mac/SettingsController.h:
8729 * MiniBrowser/mac/SettingsController.m:
8730 (-[SettingsController _populateMenu]):
8731 (-[SettingsController validateMenuItem:]):
8732 (-[SettingsController toggleLargeImageAsyncDecodingEnabled:]):
8733 (-[SettingsController largeImageAsyncDecodingEnabled]):
8734 (-[SettingsController toggleAnimatedImageAsyncDecodingEnabled:]):
8735 (-[SettingsController animatedImageAsyncDecodingEnabled]):
8736 (-[SettingsController toggleAsyncImageDecodingEnabled:]): Deleted.
8737 (-[SettingsController asyncImageDecodingEnabled]): Deleted.
8738 * MiniBrowser/mac/WK1BrowserWindowController.m:
8739 (-[WK1BrowserWindowController didChangeSettings]):
8740 * MiniBrowser/mac/WK2BrowserWindowController.m:
8741 (-[WK2BrowserWindowController didChangeSettings]):
8743 2016-11-30 Jonathan Bedard <jbedard@apple.com>
8745 Make it possible to use an existing simulator instance for one-off testing
8746 https://bugs.webkit.org/show_bug.cgi?id=164568
8747 <rdar://problem/29189133>
8749 Reviewed by Daniel Bates.
8751 With this patch, if a simulator is currently running on the machine and
8752 '--dedicated-simulators' is not passed into the application, only one simulator
8753 instance will be used, and this instance will be the existing instance.
8754 If no simulator is running or '--dedicated-simulators' is passed to the script,
8755 previous behavior will be used.
8757 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
8759 * Scripts/webkitpy/port/ios.py:
8760 (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
8761 (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
8762 (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
8763 (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
8764 (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them.
8765 (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
8766 (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
8767 * Scripts/webkitpy/xcode/simulator.py:
8768 (Simulator.current_device): Get currently running device.
8770 2016-11-29 Carlos Alberto Lopez Perez <clopez@igalia.com>
8772 [Linux] run-benchmark should be able to execute the benchmarks with more browsers.
8773 https://bugs.webkit.org/show_bug.cgi?id=164792
8775 Reviewed by Michael Catanzaro.
8777 This removes the GTKBrowserDriver (and the platform 'gtk') from the run-benchmark script,
8778 and adds a new LinuxBrowserDriver with a platform 'linux'.
8780 It add also drivers for Chrome (Chromium), Firefox, Epiphany and MiniBrowser-GTK (previously MiniBrowser).
8782 The detection of the platform is now done automatically, so it is not longer needed to pass a "--platform" parameter.
8784 The tracking of the browser process is now more robust, we track the pid of the browser process and we only try to
8785 kill the ones that were executed by this script, instead of doing a 'killall $browser' (like before).
8786 We also check for browser process childs and we kill them if they are still alive after the main browser process has been killed.
8787 This depends on psutil, so this will only be done if psutil is installed.
8789 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
8790 (RunBenchmarkTests.start): The platform is now autodetected and the MiniBrowser driver is renamed to MiniBrowser-GTK.
8791 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
8792 (BenchmarkRunner._run_benchmark): Fix a bug that caused close_browsers to be called twice. Its already called inside BenchmarkRunner._run_one_test.
8793 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py: Added.
8794 (LinuxBrowserDriver): Implement base class that has all the needed functionality for driving the browsers.
8795 (LinuxBrowserDriver.__init__):
8796 (LinuxBrowserDriver.prepare_env):
8797 (LinuxBrowserDriver.restore_env):
8798 (LinuxBrowserDriver.close_browsers): Made the dependency on psutil optional (because it was listed as such on the README file <Tools/Scripts/webkitpy/benchmark_runner/README.md>)
8799 (LinuxBrowserDriver.launch_url):
8800 (LinuxBrowserDriver._get_first_executable_path_from_list):
8801 (LinuxBrowserDriver._screen_size):
8802 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
8803 (LinuxChromeDriver):
8804 (LinuxChromeDriver.launch_url):
8805 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py.
8806 (EpiphanyBrowserDriver):
8807 (EpiphanyBrowserDriver.launch_url):
8808 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
8809 (LinuxFirefoxDriver):
8810 (LinuxFirefoxDriver.launch_url):
8811 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
8812 (GTKMiniBrowserDriver):
8813 (GTKMiniBrowserDriver.launch_url):
8814 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
8815 (SimpleHTTPServerDriver):
8816 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
8818 (getdefaultbrowser):
8820 * Scripts/webkitpy/benchmark_runner/utils.py:
8821 (load_subclasses): The loading of subclasses was still (even after r196979) sensitive to the order in which the modules are loaded.
8822 We have to ensure that the files containing subclasses of the base_class_file are loaded after the base_class_file,
8823 we can do that by matching against the base_class_file pattern when the list is created.
8825 2016-11-29 Andy Estes <aestes@apple.com>
8827 [Cocoa] Enable two clang warnings recommended by Xcode
8828 https://bugs.webkit.org/show_bug.cgi?id=164498
8830 Reviewed by Mark Lam.
8832 * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
8833 * MiniBrowser/Configurations/Base.xcconfig: Ditto.
8834 * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
8835 * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
8837 2016-11-29 Eric Carlson <eric.carlson@apple.com>
8839 [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
8840 https://bugs.webkit.org/show_bug.cgi?id=164760
8841 <rdar://problem/29261266>
8843 Reviewed by Youenn Fablet.
8845 Allow scripts to determine the number of times the user has been prompted for capture device access.
8847 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
8848 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
8849 (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
8850 (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):
8851 (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
8852 (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted.
8853 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
8854 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
8855 (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin):
8856 (WTR::TestRunner::userMediaPermissionRequestCountForOrigin):
8857 (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin):
8858 (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted.
8859 * WebKitTestRunner/InjectedBundle/TestRunner.h:
8860 * WebKitTestRunner/TestController.cpp:
8861 (WTR::TestController::resetStateToConsistentValues):
8862 (WTR::OriginSettings::incrementRequestCount):
8863 (WTR::OriginSettings::resetRequestCount):
8864 (WTR::OriginSettings::requestCount):
8865 (WTR::TestController::saltForOrigin):
8866 (WTR::TestController::setUserMediaPersistentPermissionForOrigin):
8867 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
8868 (WTR::TestController::settingsForOrigin):
8869 (WTR::TestController::userMediaPermissionRequestCountForOrigin):
8870 (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin):
8871 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
8872 (WTR::TestController::setUserMediaPermissionForOrigin): Deleted.
8873 * WebKitTestRunner/TestController.h:
8874 * WebKitTestRunner/TestInvocation.cpp:
8875 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
8876 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
8878 2016-11-29 Simon Fraser <simon.fraser@apple.com>
8880 intersection-observer-entry-interface.html test fails on the bots
8881 https://bugs.webkit.org/show_bug.cgi?id=165133
8883 Reviewed by Darin Adler.
8885 Tests that enabled Intersection Observer via <!-- webkit-test-runner [ enableIntersectionObserver=true ] -->
8886 would fail sometimes, because TestController::ensureViewSupportsOptionsForTest() failed to check
8887 to see if this option required creating a new web view, so would just use the old view without
8888 even resetting preferences.
8890 In general, TestController doesn't distinguish properly between options that require the creation
8891 of a new view (like mock scrollbars), and those that can be simply reset as resetPreferencesToConsistentValues()
8894 Do the easy fix of having viewSupportsOptions() check options.enableIntersectionObserver. We should probably
8895 just call resetPreferencesToConsistentValues() even when re-use the same view.
8897 * WebKitTestRunner/TestController.cpp:
8898 (WTR::TestController::resetPreferencesToConsistentValues):
8899 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
8900 (WTR::PlatformWebView::viewSupportsOptions):
8901 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
8902 (WTR::PlatformWebView::viewSupportsOptions):
8904 2016-11-28 Ryan Haddad <ryanhaddad@apple.com>
8906 Unreviewed, rolling out r209008.
8908 This change appears to have caused two fast/mediastrem
8909 LayoutTests to fail.
8913 "[MediaStream] Don't request user permission for a device if
8914 it has already been granted in the current browsing context"
8915 https://bugs.webkit.org/show_bug.cgi?id=164760
8916 http://trac.webkit.org/changeset/209008
8918 2016-11-28 Daniel Bates <dabates@apple.com>
8920 Teach webkitpy how to read CSSProperties.json r209001
8921 https://bugs.webkit.org/show_bug.cgi?id=165108
8923 Reviewed by Simon Fraser.
8925 Fix webkitpy logic so that it can read CSS property names from CSSProperties.json following r209001.
8927 Following r209001 CSSPropertyNames.in no longer exists as it was replaced with CSSProperties.json.
8928 We need to modify the webkitpy machinery that processed CSSPropertyNames.in to process CSSProperties.json.
8930 * Scripts/webkitpy/w3c/test_converter.py:
8931 (_W3CTestConverter.__init__): Make self._css_property_file and self._css_property_value_file local
8932 variables as it is unnecessary for them to be instance variables. Call read_webkit_prefixed_css_property_list()
8933 to read the property names from file CSSProperties.json. Call legacy_read_webkit_prefixed_css_property_list() to
8934 read CSS keyword values from CSSValueKeywords.in.
8935 (_W3CTestConverter.read_webkit_prefixed_css_property_list): Added.
8936 (_W3CTestConverter):
8937 (_W3CTestConverter.legacy_read_webkit_prefixed_css_property_list): Renamed from read_webkit_prefixed_css_property_list.
8938 * Scripts/webkitpy/w3c/test_importer_unittest.py:
8939 (TestImporterTest.test_harnesslinks_conversion): Substitute CSSProperties.json for CSSPropertyNames.in.
8941 2016-11-28 Eric Carlson <eric.carlson@apple.com>
8943 [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
8944 https://bugs.webkit.org/show_bug.cgi?id=164760
8945 <rdar://problem/29261266>
8947 Reviewed by Youenn Fablet.
8949 Allow scripts to determine the number of times the user has been prompted for capture device access.
8951 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
8952 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
8953 (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
8954 (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):
8955 (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
8956 (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted.
8957 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
8958 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
8959 (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin):
8960 (WTR::TestRunner::userMediaPermissionRequestCountForOrigin):
8961 (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin):
8962 (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted.
8963 * WebKitTestRunner/InjectedBundle/TestRunner.h:
8964 * WebKitTestRunner/TestController.cpp:
8965 (WTR::TestController::resetStateToConsistentValues):
8966 (WTR::OriginSettings::incrementRequestCount):
8967 (WTR::OriginSettings::resetRequestCount):
8968 (WTR::OriginSettings::requestCount):
8969 (WTR::TestController::saltForOrigin):
8970 (WTR::TestController::setUserMediaPersistentPermissionForOrigin):
8971 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
8972 (WTR::TestController::settingsForOrigin):
8973 (WTR::TestController::userMediaPermissionRequestCountForOrigin):
8974 (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin):
8975 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
8976 (WTR::TestController::setUserMediaPermissionForOrigin): Deleted.
8977 * WebKitTestRunner/TestController.h:
8978 * WebKitTestRunner/TestInvocation.cpp:
8979 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
8980 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
8982 2016-11-18 Jer Noble <jer.noble@apple.com>
8984 Add some performance tests for various aspects of media loading and playback.
8985 https://bugs.webkit.org/show_bug.cgi?id=164977
8987 Reviewed by Darin Adler.
8989 Allow callers to pass in extra alias/directory pairs to run-webkit-httpd.
8991 * Scripts/run-webkit-httpd:
8995 2016-11-27 Simon Fraser <simon.fraser@apple.com>
8997 Another fix for CMake.
8999 * DumpRenderTree/TestOptions.h:
9000 * DumpRenderTree/TestOptions.mm:
9002 2016-11-26 Simon Fraser <simon.fraser@apple.com>
9004 Better fix for the Mac CMake build.
9006 * DumpRenderTree/PlatformMac.cmake:
9008 2016-11-26 Simon Fraser <simon.fraser@apple.com>
9010 Attempt to fix Mac CMake build.
9012 * DumpRenderTree/PlatformMac.cmake:
9014 2016-11-26 Yusuke Suzuki <utatane.tea@gmail.com>
9016 [WTF] Import std::optional reference implementation as WTF::Optional
9017 https://bugs.webkit.org/show_bug.cgi?id=164199
9019 Reviewed by Saam Barati and Sam Weinig.
9021 Use WTF::Optional::value_or.
9023 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
9024 (WTR::UIScriptController::stableStateOverride):
9025 (WTR::UIScriptController::setStableStateOverride):
9026 * TestRunnerShared/Bindings/JSWrappable.h:
9027 (WTR::JSValueMakeBooleanOrNull):
9028 (WTR::JSValueToNullableBoolean):
9029 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
9030 (WTR::UIScriptController::stableStateOverride):
9031 (WTR::UIScriptController::setStableStateOverride):
9032 * TestRunnerShared/UIScriptContext/UIScriptController.h:
9033 * TestWebKitAPI/Tests/WTF/Optional.cpp:
9034 (TestWebKitAPI::TEST):
9035 * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
9036 (TestWebKitAPI::testParseHTMLInteger):
9037 (TestWebKitAPI::testParseHTMLNonNegativeInteger):
9038 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
9039 (TestWebKitAPI::checkURL):
9040 (TestWebKitAPI::checkRelativeURL):
9041 (TestWebKitAPI::checkURLDifferences):
9042 (TestWebKitAPI::checkRelativeURLDifferences):
9043 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
9044 (WTR::UIScriptController::stableStateOverride):
9045 (WTR::UIScriptController::setStableStateOverride):
9047 2016-11-26 Sam Weinig <sam@webkit.org>
9049 Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
9050 https://bugs.webkit.org/show_bug.cgi?id=164965
9052 Reviewed by Simon Fraser.
9054 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9057 * DumpRenderTree/TestOptions.h: Added.
9058 * DumpRenderTree/TestOptions.mm: Added.
9059 (parseBooleanTestHeaderValue):
9060 (TestOptions::TestOptions):
9061 Port TestOption parsing from WKTR to DRT.
9063 * DumpRenderTree/mac/DumpRenderTree.mm:
9064 (resetWebPreferencesToConsistentValues):
9065 (resetWebViewToConsistentStateBeforeTesting):
9067 * WebKitTestRunner/TestController.cpp:
9068 Pass TestOptions down to resetWebPreferencesToConsistentValues to allow setting
9069 preferences conditionally.
9071 (WTR::TestController::resetPreferencesToConsistentValues):
9072 (WTR::updateTestOptionsFromTestHeader):
9073 * WebKitTestRunner/TestOptions.h:
9074 Add a new test option header, enableIntersectionObserver, to enable IntersectionObserver.
9076 2016-11-26 Simon Fraser <simon.fraser@apple.com>
9078 Migrate some layout timer-related code from std::chrono to Seconds and MonotonicTime
9079 https://bugs.webkit.org/show_bug.cgi?id=164992
9081 Reviewed by Darin Adler.
9083 Use Seconds::zero().
9085 * TestWebKitAPI/Tests/WTF/Condition.cpp:
9087 2016-11-26 Simon Fraser <simon.fraser@apple.com>
9089 Add literals for various time units
9090 https://bugs.webkit.org/show_bug.cgi?id=165074
9092 Reviewed by Filip Pizlo.
9094 Add tests for new time literals. Add new tests for units.
9096 * TestWebKitAPI/Tests/WTF/Time.cpp:
9097 (TestWebKitAPI::TEST):
9099 2016-11-25 Csaba Osztrogonác <ossy@webkit.org>
9101 Fix compile warnings after r208415
9102 https://bugs.webkit.org/show_bug.cgi?id=165061
9104 Reviewed by Andy Estes.
9106 * TestWebKitAPI/Tests/WTF/Time.cpp:
9107 (TestWebKitAPI::TEST):
9109 2016-11-24 Michael Catanzaro <mcatanzaro@igalia.com>
9111 [GTK] Notifications API does not expose or respect the "tag" attribute
9112 https://bugs.webkit.org/show_bug.cgi?id=164771
9114 Reviewed by Gustavo Noronha Silva.
9116 Verify that showing a notification with the same tag as another notification closes the
9117 previous notification before the new notification is shown.
9119 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
9120 (testWebViewNotification):
9122 2016-11-24 Carlos Garcia Campos <cgarcia@igalia.com>
9124 Unreviewed. Fix GTK+ test /webkit2/WebKitWebContext/get-plugins after r208429.
9126 Test plugin library was renamed as libTestNetscapePlugIn.so in r208429.
9128 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
9129 (testWebContextGetPlugins): Update the library name.
9131 2016-11-22 Darin Adler <darin@apple.com>
9133 Make normal case fast in the input element limitString function
9134 https://bugs.webkit.org/show_bug.cgi?id=165023
9136 Reviewed by Dan Bernstein.
9138 * TestWebKitAPI/CMakeLists.txt: Added TextBreakIterator.cpp.
9139 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
9140 * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp: Added.
9141 Contains some tests for the numGraphemeClusters and
9142 numCharactersInGraphemeClusters functions that I used to make sure
9143 that the new fast paths I added work correctly.
9145 2016-11-22 Tomas Popela <tpopela@redhat.com>
9147 Unreviewed, add myself as a WebKit committer.
9149 * Scripts/webkitpy/common/config/contributors.json:
9151 2016-11-21 Mark Lam <mark.lam@apple.com>
9153 Hasher::addCharacters() should be able to handle zero length strings.
9154 https://bugs.webkit.org/show_bug.cgi?id=165024
9156 Reviewed by Yusuke Suzuki.
9158 * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
9159 (TestWebKitAPI::TEST):
9161 2016-11-21 Carlos Alberto Lopez Perez <clopez@igalia.com>
9163 [CMake] build fails after update to cmake 3.7
9164 https://bugs.webkit.org/show_bug.cgi?id=165008
9166 Reviewed by Dan Bernstein.
9168 When we remove the CMake cache, we should remove both the
9169 CMakeCache.txt file and the CMakeFiles directory.
9170 See: https://gitlab.kitware.com/cmake/cmake/issues/14820
9172 * Scripts/webkitdirs.pm:
9176 2016-11-16 Philippe Normand <pnormand@igalia.com>
9178 [GTK][WebRTC] Switch to downstream OpenWebRTC and more recent GStreamer
9179 https://bugs.webkit.org/show_bug.cgi?id=164817
9181 Reviewed by Alejandro G. Castro.
9183 This is temporary, hopefully. The OpenWebRTC patches will/should
9184 be soon reviewed and upstream but meanwhile it makes sense to use
9185 the Igalia downstream fork so that the WebRTC testing is easier.
9187 Recent GStreamer patches are also needed for RTP bundling support
9188 and RTP retransmission fixes.
9190 * gtk/jhbuild.modules:
9191 * gtk/openwebrtc.modules: Removed.
9192 * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Added.
9193 * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Added.
9194 * gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
9196 2016-11-20 Zan Dobersek <zdobersek@igalia.com>
9198 [EncryptedMedia] Make EME API runtime-enabled
9199 https://bugs.webkit.org/show_bug.cgi?id=164927
9201 Reviewed by Jer Noble.
9203 Enable the EME API via the WKTR InjectedBundle whenever testing
9204 commences. This does not have any effect unless the EME feature
9205 is enabled at compile-time, but it's still added to match other
9206 features and for future use.
9208 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
9209 (WTR::InjectedBundle::beginTesting):
9210 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
9211 (WTR::TestRunner::setEncryptedMediaAPIEnabled):
9212 * WebKitTestRunner/InjectedBundle/TestRunner.h:
9214 2016-11-19 Simon Fraser <simon.fraser@apple.com>
9216 Fix the Mac and iOS bulds.
9218 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
9219 (-[TestRunnerWKWebView _stableStateOverride]):
9220 (-[TestRunnerWKWebView _setStableStateOverride:]):
9222 2016-11-18 Simon Fraser <simon.fraser@apple.com>
9224 Make it possible to test non-stable-state scrolling on iOS
9225 https://bugs.webkit.org/show_bug.cgi?id=164905
9227 Reviewed by Dan Bernstein.
9229 Make it possible for an iOS layout test to force every visible rect update
9230 from the UI process to the web process to be in a non-stable state. This emulates
9231 what happens during panning and zooming interactions, and allows us to test the
9232 scrolling and layer trees in these transient states.
9234 This is done by adding a testing property on WKWebView, _stableStateOverride, whose
9235 getters and setters are overridden in TestRunnerWKWebView. When non-nil, we _updateVisibleContentRectAfterScrollInView
9236 consults the NSNumber's boolValue and uses it to override the stable state.
9238 To facilitate this kind of testing, also add immediateScrollToOffset() and
9239 immediateZoomToScale() to UIScriptController. Finally, add doAfterPresentationUpdate()
9240 which provides a callback that fires after one trip to the web process and back.
9242 Add code generation support for optional boolean attributes in IDL.
9244 Align CodeGeneratorDumpRenderTree.pm and CodeGeneratorTestRunner.pm.
9246 * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
9247 (_generateImplementationFile):
9248 (_platformTypeConstructor):
9249 (_returnExpression):
9250 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
9251 (WTR::UIScriptController::doAfterPresentationUpdate):
9252 (WTR::contentOffsetBoundedInValidRange):
9253 (WTR::UIScriptController::scrollToOffset):
9254 (WTR::UIScriptController::immediateScrollToOffset):
9255 (WTR::UIScriptController::immediateZoomToScale):
9256 (WTR::UIScriptController::stableStateOverride):
9257 (WTR::UIScriptController::setStableStateOverride):
9258 * DumpRenderTree/mac/UIScriptControllerMac.mm:
9259 (WTR::UIScriptController::doAfterPresentationUpdate):
9260 * TestRunnerShared/Bindings/JSWrappable.h:
9261 (WTR::JSValueMakeBooleanOrNull):
9262 (WTR::JSValueToNullableBoolean):
9263 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
9264 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
9265 (WTR::UIScriptController::immediateScrollToOffset):
9266 (WTR::UIScriptController::immediateZoomToScale):
9267 (WTR::UIScriptController::stableStateOverride):
9268 (WTR::UIScriptController::setStableStateOverride):
9269 * TestRunnerShared/UIScriptContext/UIScriptController.h:
9270 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
9272 (_platformTypeConstructor):
9273 (_returnExpression):
9274 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
9275 (-[TestRunnerWKWebView dealloc]):
9276 (-[TestRunnerWKWebView _stableStateOverride]):
9277 (-[TestRunnerWKWebView _setStableStateOverride:]):
9278 * WebKitTestRunner/ios/TestControllerIOS.mm:
9279 (WTR::TestController::platformResetStateToConsistentValues):
9280 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
9281 (WTR::UIScriptController::doAsyncTask):
9282 (WTR::UIScriptController::doAfterPresentationUpdate):
9283 (WTR::UIScriptController::zoomToScale):
9284 (WTR::UIScriptController::immediateScrollToOffset):
9285 (WTR::UIScriptController::immediateZoomToScale):
9286 (WTR::UIScriptController::stableStateOverride):
9287 (WTR::UIScriptController::setStableStateOverride):
9288 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
9289 (WTR::UIScriptController::doAfterPresentationUpdate):
9291 2016-11-19 Joanmarie Diggs <jdiggs@igalia.com>
9293 AX: [ATK] Expose aria-busy via ATK_STATE_BUSY
9294 https://bugs.webkit.org/show_bug.cgi?id=164909
9296 Reviewed by Chris Fleizach.
9298 Implement boolAttributeValue() for ATK so we can test AXElementBusy.
9300 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
9301 (WTR::AccessibilityUIElement::boolAttributeValue):
9303 2016-11-18 Simon Fraser <simon.fraser@apple.com>
9305 [iOS WK2] Eliminate a source of flakiness in layout tests by forcing WebPage into "responsive" mode for all tests, with an internals override
9306 https://bugs.webkit.org/show_bug.cgi?id=164980
9308 Reviewed by Chris Dumez.
9310 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
9311 (WTR::InjectedBundlePage::prepare):
9313 2016-11-18 Dean Jackson <dino@apple.com>
9315 AX: "(inverted-colors)" media query only matches on page reload; should match on change
9316 https://bugs.webkit.org/show_bug.cgi?id=163564
9317 <rdar://problem/28807350>
9319 Reviewed by Simon Fraser.
9321 Add a UIScriptController method that tricks WebKit into thinking
9322 it has received a notification that accessibility settings have
9323 changed. Combined with our forced overrides, this allows us to
9324 test if a page would react to the notifications.
9326 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
9327 (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
9328 * DumpRenderTree/mac/UIScriptControllerMac.mm:
9329 (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
9330 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
9331 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
9332 (WTR::simulateAccessibilitySettingsChangeNotification):
9333 * TestRunnerShared/UIScriptContext/UIScriptController.h:
9334 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
9335 (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
9336 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
9337 (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
9339 2016-11-18 Alex Christensen <achristensen@webkit.org>
9341 Fix API test after r208902
9342 https://bugs.webkit.org/show_bug.cgi?id=144194
9344 * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
9345 (TestWebKitAPI::TEST):
9346 The fullwidth solidus, U+FF0F, changed encoding from IDN2003 to IDN2008, probably to prevent domains from using it
9347 to spoof other domains. https://webkit.org/blog/ and https://webkit.org\uFF0Fblog/ would otherwise look
9348 too similar when rendered.
9350 2016-11-17 Alex Christensen <achristensen@webkit.org>
9352 Support IDN2008 with UTS #46 instead of IDN2003
9353 https://bugs.webkit.org/show_bug.cgi?id=144194
9355 Reviewed by Darin Adler.
9357 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
9358 (TestWebKitAPI::TEST_F):
9359 Add some tests from http://unicode.org/faq/idn.html verifying that we follow UTS46's deviations from IDN2008.
9360 Add some tests based on https://tools.ietf.org/html/rfc5893 verifying that we check for bidirectional text.
9361 Add a test based on https://tools.ietf.org/html/rfc5892 verifying that we do not do ContextO check.
9362 Add a test for U+321D and U+321E which have particularly interesting punycode encodings. We match Firefox here now.
9363 Also add a test from http://www.unicode.org/reports/tr46/#IDNAComparison verifying we are not using IDN2003.
9364 We should consider importing all of http://www.unicode.org/Public/idna/9.0.0/IdnaTest.txt as URL domain tests.
9366 2016-11-17 Carlos Garcia Campos <cgarcia@igalia.com>
9368 Downloads started by context menu actions should also have a web view associated
9369 https://bugs.webkit.org/show_bug.cgi?id=164364
9371 Reviewed by Michael Catanzaro.
9373 Add a GTK+ unit tests to check that downloads started by the context menu have a web view associated.
9375 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
9376 (downloadLocalFileSuccessfully):
9377 (testDownloadOverwriteDestinationDisallowed):
9378 (testDownloadLocalFileError):
9379 (testDownloadRemoteFile):
9380 (testDownloadRemoteFileError):
9381 (testDownloadMIMEType):
9382 (contextMenuCallback):
9383 (testContextMenuDownloadActions):
9386 2016-11-17 Ryosuke Niwa <rniwa@webkit.org>
9388 Add an experimental API to find elements across shadow boundaries
9389 https://bugs.webkit.org/show_bug.cgi?id=164851
9390 <rdar://problem/28220092>
9392 Reviewed by Sam Weinig.
9394 Added test cases for window.collectMatchingElementsInFlatTree to WebKit2.InjectedBundleMakeAllShadowRootOpen.
9396 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9397 * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRoot*s*Open_Bundle.cpp: Renamed
9398 from InjectedBundleMakeAllShadowRootOpen_Bundle.cpp.
9399 (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize): Added test cases for
9400 window.collectMatchingElementsInFlatTree by calling alert() many times.
9401 * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
9402 (TestWebKitAPI::runJavaScriptAlert): Added expectations for multiple test cases. Each test case
9403 finishes with a call to alert, and moves testNumber forward.
9404 (TestWebKitAPI::TEST): Use the newly added closed-shadow-tree-test.html
9405 * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html: Added. Creates a shadow tree with slots
9406 and tests that window.collectMatchingElementsInFlatTree is not present when
9407 an event named "testnormalworld" is dispatched by the injected bundle.
9409 2016-11-17 Brady Eidson <beidson@apple.com>
9411 Add _WKIconLoadingDelegate SPI.
9412 https://bugs.webkit.org/show_bug.cgi?id=164894
9414 Reviewed by Alex Christensen.
9416 Add MiniBrowser support for this new SPI, configurable with a setting.
9418 * MiniBrowser/mac/SettingsController.h:
9419 * MiniBrowser/mac/SettingsController.m:
9420 (-[SettingsController _populateMenu]):
9421 (-[SettingsController validateMenuItem:]):
9422 (-[SettingsController loadsAllSiteIcons]):
9423 (-[SettingsController toggleLoadsAllSiteIcons:]):
9424 * MiniBrowser/mac/WK2BrowserWindowController.m:
9425 (-[WK2BrowserWindowController awakeFromNib]):
9426 (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]):
9428 2016-11-17 Caitlin Potter <caitp@igalia.com>
9430 [JSC] remove leftover references to ES2017_ASYNCFUNCTION_SYNTAX flag
9431 https://bugs.webkit.org/show_bug.cgi?id=164879
9433 Reviewed by Alex Christensen.
9435 The flag was referenced in FeatureList.pm and in one of the
9436 FeatureDefines.xcconfig files, despite being removed.
9438 * Scripts/webkitperl/FeatureList.pm:
9439 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
9441 2016-11-17 Per Arne Vollan <pvollan@apple.com>
9443 [Win] run-api-tests is failing.
9444 https://bugs.webkit.org/show_bug.cgi?id=164818
9446 Reviewed by Alexey Proskuryakov.
9448 Make sure Visual Studio interprets string literal as utf8.
9450 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
9451 (TestWebKitAPI::TEST_F):
9453 2016-11-17 Yusuke Suzuki <utatane.tea@gmail.com>
9455 [JSC] WTF::TemporaryChange with WTF::SetForScope
9456 https://bugs.webkit.org/show_bug.cgi?id=164761
9458 Reviewed by Saam Barati.
9460 * TestWebKitAPI/CMakeLists.txt:
9461 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9462 * TestWebKitAPI/Tests/WTF/SetForScope.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporaryChange.cpp.
9463 (TestWebKitAPI::TEST):
9464 * WebKitTestRunner/TestController.cpp:
9465 (WTR::TestController::resetStateToConsistentValues):
9467 2016-11-16 Alexey Proskuryakov <ap@apple.com>
9469 REGRESSION (r208455): LayoutTests swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html are failing
9470 https://bugs.webkit.org/show_bug.cgi?id=164572
9472 Reviewed by Tim Horton.
9474 * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformResetStateToConsistentValues):
9475 Use the correct constant.
9477 2016-11-16 Yusuke Suzuki <utatane.tea@gmail.com>
9479 [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
9480 https://bugs.webkit.org/show_bug.cgi?id=164827
9482 Reviewed by Ryosuke Niwa.
9484 Enabled ES6 Modules in test runners.
9486 * DumpRenderTree/mac/DumpRenderTree.mm:
9487 (resetWebPreferencesToConsistentValues):
9488 * DumpRenderTree/win/DumpRenderTree.cpp:
9489 (resetWebPreferencesToConsistentValues):
9490 * Scripts/webkitperl/FeatureList.pm:
9491 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
9492 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
9493 (WTR::InjectedBundle::beginTesting):
9494 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
9495 (WTR::TestRunner::setES6ModulesEnabled):
9496 * WebKitTestRunner/InjectedBundle/TestRunner.h:
9498 2016-11-16 Simon Fraser <simon.fraser@apple.com>
9500 Hard to write reliable UIScriptController scrollingTreeAsText tests
9501 https://bugs.webkit.org/show_bug.cgi?id=164764
9503 Reviewed by Wenson Hsieh.
9505 Fix one cause of flakiness by resetting the WKWebView's UIScrollView scale
9506 and scroll position between tests.
9508 * WebKitTestRunner/ios/TestControllerIOS.mm:
9509 (WTR::TestController::platformResetStateToConsistentValues):
9511 2016-11-16 Simon Fraser <simon.fraser@apple.com>
9513 UIScriptController: script with no async tasks fails if an earlier script registered a callback
9514 https://bugs.webkit.org/show_bug.cgi?id=164762
9516 Reviewed by Wenson Hsieh.
9518 Make TestRunner::callUIScriptCallback() async in DumpRenderTree to match WebKitTestRunner behavior.
9519 This fixes ui-side-script-with-callback.html in WK1, which failed because the second runUIScript()
9520 would occur inside the completion callback from the first. This no longer happens.
9522 * DumpRenderTree/TestRunner.cpp:
9523 (TestRunner::callUIScriptCallback):
9524 * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
9525 (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
9527 2016-11-16 Ryan Haddad <ryanhaddad@apple.com>
9529 Unreviewed, rolling out r208770.
9531 The test added with this change is timing out on mac-wk1.
9535 "UIScriptController: script with no async tasks fails if an
9536 earlier script registered a callback"
9537 https://bugs.webkit.org/show_bug.cgi?id=164762
9538 http://trac.webkit.org/changeset/208770
9540 2016-11-16 Per Arne Vollan <pvollan@apple.com>
9542 [Win] WebCore test is failing.
9543 https://bugs.webkit.org/show_bug.cgi?id=164772
9545 Reviewed by Brent Fulgham.
9547 The value of CGRectInfinite is not the same on Windows as on Mac.
9549 * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
9550 (TestWebKitAPI::TEST):
9552 2016-11-15 Alexey Proskuryakov <ap@apple.com>
9554 Update Youenn's e-mail addresses.
9556 * Scripts/webkitpy/common/config/contributors.json:
9558 2016-11-15 Simon Fraser <simon.fraser@apple.com>
9560 UIScriptController: script with no async tasks fails if an earlier script registered a callback
9561 https://bugs.webkit.org/show_bug.cgi?id=164762
9563 Reviewed by Wenson Hsieh.
9565 UIScriptContext::runUIScript() considers a script to be "immediate" if that script doesn't
9566 queue any async tasks. However, if an earlier UI script registered a callback, UIScriptContext::runUIScript()
9567 would consider that an outstanding task.
9569 Fix by unregistering any callbacks associated with the current UI script when uiScriptComplete() is called.
9571 * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
9572 (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
9574 2016-11-15 Simon Fraser <simon.fraser@apple.com>
9576 UIScriptController: setting a callback to undefined should unregister it
9577 https://bugs.webkit.org/show_bug.cgi?id=164796
9579 Reviewed by Dean Jackson.
9581 "Immediate" UI scripts (those that don't schedule any async tasks) should return
9582 immediately, without the need to call uiScriptComplete(). However, this is broken if
9583 an earlier UI script registered a callback (since no-one clears that callback after the
9584 first script completes).
9586 Make possible the workaround of setting the callback to undefined, which previously did
9587 not clear the callback registration.
9589 * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
9590 (UIScriptContext::registerCallback):
9591 * TestRunnerShared/UIScriptContext/UIScriptContext.h:
9592 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
9593 (WTR::UIScriptController::platformClearAllCallbacks):
9595 2016-11-14 Mark Lam <mark.lam@apple.com>
9597 Enhance run-jsc-stress-test script to allow optional test specific options to be added for all test run configurations.
9598 https://bugs.webkit.org/show_bug.cgi?id=164695
9600 Reviewed by Keith Miller.
9602 This gives us more flexibility when specific tests needs to enable special JSC
9603 options in order to exercise specific code paths to be tested. It also saves us
9604 from having to create duplicate test run configurations e.g. runMiscFTLNoCJITTest.
9605 We can now just use runFTLNoCJIT in its place.
9607 Also replaced the ifJSCArgIsntProvidedAreWeReleaseBuild variable with $buildType
9608 so that we have the ability to skip certain tests for release or debug builds.
9609 This will be needed in the upcoming patch for https://webkit.org/b/155145.
9611 * Scripts/run-jsc-stress-tests:
9613 2016-11-14 Joanmarie Diggs <jdiggs@igalia.com>
9615 AX: [ATK] Expose STATE_SINGLE_LINE and STATE_MULTI_LINE for ARIA searchbox role
9616 https://bugs.webkit.org/show_bug.cgi?id=164712
9618 Reviewed by Chris Fleizach.
9620 Add AccessibilityUIElement::isSingleLine, AccessibilityUIElement::isMultiLine
9621 to DRT and WKTR. Implement it for ATK.
9623 * DumpRenderTree/AccessibilityUIElement.h:
9624 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
9625 (AccessibilityUIElement::isSingleLine):
9626 (AccessibilityUIElement::isMultiLine):
9627 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
9628 (AccessibilityUIElement::isSingleLine):
9629 (AccessibilityUIElement::isMultiLine):
9630 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
9631 (AccessibilityUIElement::isSingleLine):
9632 (AccessibilityUIElement::isMultiLine):
9633 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
9634 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
9635 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
9636 (WTR::AccessibilityUIElement::isSingleLine):
9637 (WTR::AccessibilityUIElement::isMultiLine):
9638 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
9639 (WTR::AccessibilityUIElement::isSingleLine):
9640 (WTR::AccessibilityUIElement::isMultiLine):
9641 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
9642 (WTR::AccessibilityUIElement::isSingleLine):
9643 (WTR::AccessibilityUIElement::isMultiLine):
9645 2016-11-14 Youenn Fablet <youenn@apple.com>
9647 Support WPT templated tests
9648 https://bugs.webkit.org/show_bug.cgi?id=164707
9650 Reviewed by Sam Weinig.
9652 * Scripts/webkitpy/w3c/test_importer.py:
9653 (TestImporter.write_html_files_for_templated_js_tests): Generating empty HTML files for templated JS tests.
9654 (TestImporter.import_tests):
9656 2016-11-13 JF Bastien <jfbastien@apple.com>
9658 Implement WTF::Expected
9659 https://bugs.webkit.org/show_bug.cgi?id=164526
9661 Reviewed by Yusuke Suzuki.
9663 std::expected isn't in C++17, and may be in C++20. It's a nice
9664 complement to std::any / std::optional because it's a type-tagged
9665 union which has a single expected result but could also contain an
9668 This would be useful in the WebAssembly parser, for example.
9670 Using this implementation will allow us to provide feedback to the
9671 standards committee and guide std::expected's design before it
9672 gets standardized. I've already sent a bunch of feedback to the
9673 author based on my experience implementing this.
9675 This could supplement WTF::Either and WTF::ExceptionOr.
9677 * TestWebKitAPI/CMakeLists.txt:
9678 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9679 * TestWebKitAPI/Tests/WTF/Expected.cpp: Added.
9681 (TestWebKitAPI::TEST):
9682 (TestWebKitAPI::foo::foo):
9683 (TestWebKitAPI::foo::~foo):
9684 (TestWebKitAPI::foo::operator==):
9685 (TestWebKitAPI::operator<<):
9687 2016-11-12 Simon Fraser <simon.fraser@apple.com>
9689 Add a way to get the UI-side scrolling tree as text via UIScriptController
9690 https://bugs.webkit.org/show_bug.cgi?id=164697
9692 Reviewed by Zalan Bujtas.
9694 Add UIScriptController::scrollingTreeAsText(), which gets the state of the scrolling
9695 tree in the UI process, including the current positions of CALayers. This will be used
9696 to test UI-side scrolling and visual viewports.
9698 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
9699 (WTR::UIScriptController::scrollingTreeAsText):
9700 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
9701 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
9702 (WTR::UIScriptController::scrollingTreeAsText):
9703 * TestRunnerShared/UIScriptContext/UIScriptController.h:
9704 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
9705 (WTR::UIScriptController::scrollingTreeAsText):
9707 2016-11-12 Wenson Hsieh <wenson_hsieh@apple.com>
9709 The main content heuristic should be robust when handling large media elements
9710 https://bugs.webkit.org/show_bug.cgi?id=164676
9711 <rdar://problem/29211503>
9713 Reviewed by Eric Carlson.
9715 Added a new test verifying that enormous video elements are handled gracefully when put through the main
9718 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9719 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
9720 (TestWebKitAPI::TEST):
9721 * TestWebKitAPI/Tests/WebKit2Cocoa/enormous-video-with-sound.html: Added.
9723 2016-11-12 Dan Bernstein <mitz@apple.com>
9725 run-safari does not work for open source contributors
9726 https://bugs.webkit.org/show_bug.cgi?id=164667
9727 <rdar://problem/29229894>
9729 Reviewed by Joseph Pecoraro.
9731 * Scripts/run-api-tests:
9732 (archCommandLineArgumentsForRestrictedEnvironmentVariables): Moved from here…
9733 * Scripts/webkitdirs.pm:
9734 (archCommandLineArgumentsForRestrictedEnvironmentVariables): …to here
9735 (runMacWebKitApp): Have arch(1) carry the DYLD_* variables we set in our environmet over
9736 to the environment of the app being run.
9738 2016-11-11 Joseph Pecoraro <pecoraro@apple.com>
9740 Removed unused INCLUDE_OPTIONS_FOR_DEBUGGING
9741 https://bugs.webkit.org/show_bug.cgi?id=164664
9743 Reviewed by Dan Bernstein.
9745 * Scripts/debug-minibrowser:
9746 * Scripts/debug-safari:
9747 * Scripts/debug-test-runner:
9748 * Scripts/webkitdirs.pm:
9749 (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
9750 There are no debug specific options anymore.
9752 2016-11-11 Wenson Hsieh <wenson_hsieh@apple.com>
9754 [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
9755 https://bugs.webkit.org/show_bug.cgi?id=164538
9756 <rdar://problem/8418711>
9758 Reviewed by Ryosuke Niwa.
9760 Adds support for being able to test autocorrect and autocapitalize attributes in contenteditable areas. To do
9761 this, we add removeAllDynamicDictionaries to UIScriptController in order to ensure that autocorrect suggestions
9762 are reset to their defaults prior to running contenteditable-autocorrect-off.html.
9764 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
9765 (WTR::UIScriptController::removeAllDynamicDictionaries):
9766 * Scripts/webkitpy/port/ios.py:
9767 (IOSSimulatorPort._createSimulatorApp):
9768 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
9769 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
9770 (WTR::UIScriptController::removeAllDynamicDictionaries):
9771 * TestRunnerShared/UIScriptContext/UIScriptController.h:
9772 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
9773 (-[TestRunnerWKWebView _keyboardDidShow:]):
9774 (-[TestRunnerWKWebView _keyboardDidHide:]):
9776 Work around an issue where consecutive UIKeyboardDidShowNotification would cause keyboard appearance callbacks
9777 to be fired multiple times. This was causing a single key press to cause two characters to be typed. While this
9778 does not affect the correctness of existing tests, the new autocorrection test requires this workaround.
9780 * WebKitTestRunner/ios/UIKitSPI.h:
9781 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
9782 (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
9783 (WTR::UIScriptController::removeAllDynamicDictionaries):
9785 2016-11-11 Alex Christensen <achristensen@webkit.org>
9787 Build all Mac API tests
9788 https://bugs.webkit.org/show_bug.cgi?id=164633
9790 Reviewed by Gyuyoung Kim.
9792 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9793 * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
9795 2016-11-11 Alex Christensen <achristensen@webkit.org>
9797 Allow mutable lambdas in HashMap::ensure
9798 https://bugs.webkit.org/show_bug.cgi?id=164642
9800 Reviewed by Sam Weinig.
9802 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
9803 (TestWebKitAPI::TEST):
9805 2016-11-10 Wenson Hsieh <wenson_hsieh@apple.com>
9807 Composition state should be cleared when changing focus to a non-editable element
9808 https://bugs.webkit.org/show_bug.cgi?id=164595
9809 <rdar://problem/26412551>
9811 Reviewed by Enrica Casucci.
9813 Adds support for window.textInputController in DumpRenderTree on iOS. So far, only the methods needed for the
9814 new layout test (editing/focus-change-with-marked-text.html) are supported. These are insertText, setMarkedText,
9817 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9818 * DumpRenderTree/TextInputController.h: Renamed from Tools/DumpRenderTree/mac/TextInputController.h.
9820 Remove the PLATFORM(MAC) guard for defining the TextInputController. Also, move the TextInputController header
9821 out of the /mac platform directory.
9823 * DumpRenderTree/ios/TextInputControllerIOS.m: Added.
9824 (+[TextInputController isSelectorExcludedFromWebScript:]):
9825 (+[TextInputController webScriptNameForSelector:]):
9826 (-[TextInputController initWithWebView:]):
9827 (-[TextInputController markedRange]):
9828 (-[TextInputController insertText:]):
9829 (-[TextInputController setMarkedText:selectedFrom:length:]):
9831 Introduces TextInputControllerIOS.m, which contains an iOS implementation of TextInputController. Only a subset
9832 of the methods available on the Mac version will be available on iOS for now (see above).
9834 * DumpRenderTree/mac/FrameLoadDelegate.mm:
9836 Remove the PLATFORM(MAC) guard for initializing the TextInputController and binding it to the window object.
9838 (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
9839 * DumpRenderTree/mac/TextInputControllerMac.m: Renamed from Tools/DumpRenderTree/mac/TextInputController.m.
9840 (-[WebHTMLView interpretKeyEvents:]):
9841 (-[WebNSRange initWithNSRange:]):
9842 (-[WebNSRange location]):
9843 (-[WebNSRange length]):
9844 (+[WebNSRange isSelectorExcludedFromWebScript:]):
9845 (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
9846 (+[NSMutableAttributedString webScriptNameForSelector:]):
9847 (-[NSMutableAttributedString getLength]):
9848 (-[NSMutableAttributedString ranges]):
9849 (-[NSMutableAttributedString attributeNamesAtIndex:]):
9850 (-[NSMutableAttributedString valueOfAttribute:atIndex:]):
9851 (-[NSMutableAttributedString addAttribute:value:]):
9852 (-[NSMutableAttributedString addAttribute:value:from:length:]):
9853 (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:]):
9854 (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:from:length:]):
9855 (-[NSMutableAttributedString addFontAttribute:fontName:size:]):
9856 (-[NSMutableAttributedString addFontAttribute:fontName:size:from:length:]):
9857 (+[TextInputController isSelectorExcludedFromWebScript:]):
9858 (+[TextInputController webScriptNameForSelector:]):
9859 (-[TextInputController initWithWebView:]):
9860 (-[TextInputController dealloc]):
9861 (-[TextInputController textInput]):
9862 (-[TextInputController insertText:]):
9863 (-[TextInputController doCommand:]):
9864 (-[TextInputController setMarkedText:selectedFrom:length:]):
9865 (-[TextInputController unmarkText]):
9866 (-[TextInputController hasMarkedText]):
9867 (-[TextInputController conversationIdentifier]):
9868 (-[TextInputController substringFrom:length:]):
9869 (-[TextInputController attributedSubstringFrom:length:]):
9870 (-[TextInputController legacyAttributedString:]):
9871 (-[TextInputController markedRange]):
9872 (-[TextInputController selectedRange]):
9873 (-[TextInputController firstRectForCharactersFrom:length:]):
9874 (-[TextInputController characterIndexForPointX:Y:]):
9875 (-[TextInputController validAttributesForMarkedText]):
9876 (-[TextInputController attributedStringWithString:]):
9877 (-[TextInputController stringWithUndoGroupingInsertion:]):
9878 (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
9879 (-[TextInputController setInputMethodHandler:]):
9880 (-[TextInputController interpretKeyEvents:withSender:]):
9882 Fixes miscellaneous style issues.
9884 2016-11-11 Philippe Normand <pnormand@igalia.com>
9886 [GTK][JHbuild] bump libnice version in openwebrtc.modules
9887 https://bugs.webkit.org/show_bug.cgi?id=164586
9889 Reviewed by Michael Catanzaro.
9891 Update to a recent libnice git snapshot and remove patches already
9892 upstream or not applying anymore. The patches not upstream yet
9893 will be reported in Phabricator.
9895 * gtk/openwebrtc.modules:
9896 * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Removed.
9897 * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Removed.
9898 * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Removed.
9899 * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Removed.
9900 * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Removed.
9902 2016-11-10 Alex Christensen <achristensen@webkit.org>
9904 Fix assertion after r208534.
9905 https://bugs.webkit.org/show_bug.cgi?id=160497
9907 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9908 * TestWebKitAPI/Tests/mac/MemoryPressureHandler.mm: Added.
9909 (TestWebKitAPI::TEST):
9910 Add a regression test.
9912 2016-11-10 Chris Dumez <cdumez@apple.com>
9914 REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure
9915 https://bugs.webkit.org/show_bug.cgi?id=164570
9917 Reviewed by Simon Fraser.
9919 Properly reset TestController::m_shouldDownloadUndisplayableMIMETypes between tests to
9922 * WebKitTestRunner/TestController.cpp:
9923 (WTR::TestController::resetStateToConsistentValues):
9925 2016-11-10 Miguel Gomez <magomez@igalia.com>
9927 Unreviewed. Added myself to the list of committers.
9929 * Scripts/webkitpy/common/config/contributors.json:
9931 2016-10-27 Sergio Villar Senin <svillar@igalia.com>
9933 [GTK] New API to notify about dynamically added forms
9934 https://bugs.webkit.org/show_bug.cgi?id=164050
9936 Reviewed by Carlos Garcia Campos.
9938 Added a new test case to verify that dinamically added forms correctly trigger the
9939 "form-controls-associated" signal from WebPage.
9941 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
9942 (didAssociateFormControlsCallback):
9943 (testWebExtensionFormControlsAssociated):
9945 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
9946 (DelayedSignal::DelayedSignal):
9947 (emitFormControlsAssociated):
9948 (formControlsAssociatedCallback):
9949 (pageCreatedCallback):
9951 2016-11-09 Ryosuke Niwa <rniwa@webkit.org>
9953 WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
9954 https://bugs.webkit.org/show_bug.cgi?id=164501
9955 <rdar://problem/29152282>
9957 Reviewed by Sam Weinig.
9959 * DumpRenderTree/mac/TextInputController.m:
9960 (-[TextInputController legacyAttributedString:]):
9962 2016-11-09 Chris Dumez <cdumez@apple.com>
9964 [WK2][NETWORK_SESSION] Add support for downloading file backed blobs
9965 https://bugs.webkit.org/show_bug.cgi?id=164458
9966 <rdar://problem/28905514>
9968 Reviewed by Darin Adler.
9970 Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout
9971 tests can request that such resources are downloaded instead of being ignored.
9973 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
9974 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
9975 (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
9976 * WebKitTestRunner/InjectedBundle/TestRunner.h:
9977 * WebKitTestRunner/TestController.cpp:
9978 (WTR::TestController::decidePolicyForNavigationResponse):
9979 * WebKitTestRunner/TestController.h:
9980 (WTR::TestController::setShouldDownloadUndisplayableMIMETypes):
9981 * WebKitTestRunner/TestInvocation.cpp:
9982 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
9984 2016-11-09 Carlos Garcia Campos <cgarcia@igalia.com>
9986 NetworkSession: Network process crash when converting main resource to download
9987 https://bugs.webkit.org/show_bug.cgi?id=164220
9989 Reviewed by Alex Christensen.
9991 Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
9992 converted to a download and another one to test the cancellation as the test was doing before. When doing the
9993 full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
9996 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
9997 (testPolicyResponseDownload):
9998 (testPolicyResponseDownloadCancel):
10001 2016-11-09 KwangHyuk Kim <hyuki.kim@samsung.com>
10003 [EFL] fix error message caused by eina log
10004 https://bugs.webkit.org/show_bug.cgi?id=164546
10006 Reviewed by Gyuyoung Kim.
10008 Fix error message caused by eina log when MiniBrowser is working with help option.
10010 * MiniBrowser/efl/main.c:
10013 2016-11-09 Brent Fulgham <bfulgham@apple.com>
10015 Unreviewed build fix after r208509.
10017 * DumpRenderTree/win/TestRunnerWin.cpp:
10018 (TestRunner::setNeedsStorageAccessFromFileURLsQuirk): Add missing TestRunner implementation."
10020 2016-11-09 Alex Christensen <achristensen@webkit.org>
10022 Unreviewed, rolling out r208438.
10026 Reverted changeset:
10028 "[WK2][NETWORK_SESSION] Add support for downloading file
10030 https://bugs.webkit.org/show_bug.cgi?id=164458
10031 http://trac.webkit.org/changeset/208438
10033 2016-11-04 Brent Fulgham <bfulgham@apple.com>
10035 Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
10036 https://bugs.webkit.org/show_bug.cgi?id=155185
10037 <rdar://problem/11101440>
10039 Reviewed by Brady Eidson.
10041 * DumpRenderTree/TestRunner.cpp:
10042 (setNeedsLocalStorageQuirkCallback): Added.
10043 (TestRunner::staticFunctions):
10044 * DumpRenderTree/TestRunner.h:
10045 * DumpRenderTree/mac/DumpRenderTree.mm:
10046 (resetWebPreferencesToConsistentValues): Update for new quirk setting.
10047 * DumpRenderTree/mac/TestRunnerMac.mm:
10048 (TestRunner::setNeedsLocalStorageQuirk):
10049 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10050 * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
10051 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
10052 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm:
10053 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkEnabled.html: Added.
10054 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkTest.mm: Added.
10055 (-[LocalStorageQuirkMessageHandler userContentController:didReceiveScriptMessage:]):
10056 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
10057 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
10058 (WTR::InjectedBundle::beginTesting): Update for new quirk setting.
10059 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
10060 (WTR::TestRunner::setNeedsLocalStorageQuirk): Added.
10061 * WebKitTestRunner/InjectedBundle/TestRunner.h:
10063 2016-11-09 Alex Christensen <achristensen@webkit.org>
10065 URLParser should not consider path of URLs with no host to start at the first slash after the colon
10066 https://bugs.webkit.org/show_bug.cgi?id=164555
10068 Reviewed by Tim Horton.
10070 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
10071 (TestWebKitAPI::TEST_F):
10073 2016-11-09 Jonathan Bedard <jbedard@apple.com>
10075 test-webkitpy failing test_create_patch_is_full_patch unit test
10076 https://bugs.webkit.org/show_bug.cgi?id=164385
10078 Reviewed by Darin Adler.
10080 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Fixed expected output to match output.
10082 2016-11-09 Chris Dumez <cdumez@apple.com>
10084 [Mac] Stop using deprecated AppKit enumeration values
10085 https://bugs.webkit.org/show_bug.cgi?id=164494
10087 Reviewed by Darin Adler.
10089 Stop using deprecated AppKit enumeration values.
10091 * DumpRenderTree/mac/EventSendingController.mm:
10092 (eventTypeForMouseButtonAndAction):
10094 (-[EventSendingController mouseMoveToX:Y:]):
10095 (-[EventSendingController contextClick]):
10096 (-[EventSendingController keyDown:withModifiers:withLocation:]):
10097 * DumpRenderTree/mac/TextInputController.m:
10098 (-[TextInputController interpretKeyEvents:withSender:]):
10099 * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
10100 (simulateCommandArrow):
10101 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
10102 (TestWebKitAPI::TEST):
10103 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm:
10104 (TestWebKitAPI::TEST):
10105 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
10106 (TestWebKitAPI::TEST):
10107 * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
10109 * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm:
10110 (UserInitiatedActionTest::SetUp):
10111 (UserInitiatedActionTest::click):
10112 * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
10113 (TestWebKitAPI::AcceptsFirstMouse::runTest):
10114 * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
10115 (TestWebKitAPI::contextMenuCopyLink):
10116 (TestWebKitAPI::TEST):
10117 * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
10118 (TestWebKitAPI::TEST):
10119 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
10120 (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
10121 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
10122 (TestWebKitAPI::TEST):
10123 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
10124 (TestWebKitAPI::Util::isKeyDown):
10125 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
10126 (TestWebKitAPI::PlatformWebView::initialize):
10127 (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
10128 (TestWebKitAPI::PlatformWebView::simulateRightClick):
10129 (TestWebKitAPI::PlatformWebView::simulateMouseMove):
10130 (TestWebKitAPI::eventTypeForButton):
10131 (TestWebKitAPI::modifierFlagsForWKModifiers):
10132 * TestWebKitAPI/mac/TestWKWebViewMac.mm:
10133 (__simulated_forceClickAssociatedEventsMask):
10134 (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
10135 (-[TestWKWebView _setUpTestWindow:]):
10136 (-[TestWKWebView typeCharacter:]):
10137 * WebKitTestRunner/mac/EventSenderProxy.mm:
10138 (WTR::eventTypeForMouseButtonAndAction):
10139 (WTR::buildModifierFlags):
10140 (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
10141 (WTR::EventSenderProxy::mouseForceClick):
10142 (WTR::EventSenderProxy::startAndCancelMouseForceClick):
10143 (WTR::EventSenderProxy::mouseMoveTo):
10144 (WTR::EventSenderProxy::keyDown):
10145 (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
10146 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
10147 (WTR::PlatformWebView::PlatformWebView):
10148 * WebKitTestRunner/mac/TestControllerMac.mm:
10149 (WTR::TestController::platformResetStateToConsistentValues):
10151 2016-11-09 Beth Dakin <bdakin@apple.com>
10153 Support TouchBar in WebKit
10154 https://bugs.webkit.org/show_bug.cgi?id=164437
10155 -and corresponding-
10156 rdar://problem/28876524
10158 Reviewed by Darin Adler.
10160 This makes MiniBrowser support TouchBar customization.
10162 * MiniBrowser/mac/AppDelegate.m:
10163 (-[BrowserAppDelegate awakeFromNib]):
10165 2016-11-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
10167 [EFL] Use libgcrypt instead of GnuTLS for CryptoDigest
10168 https://bugs.webkit.org/show_bug.cgi?id=164461
10170 Reviewed by Michael Catanzaro.
10172 As GTK port in r208297, EFL port starts to use libgcrypt instead of GnuTLS as well.
10174 * efl/install-dependencies: Add libgcript package dependecy.
10176 2016-11-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
10178 [EFL] Remove unused function in MiniBrowser
10179 https://bugs.webkit.org/show_bug.cgi?id=164398
10181 Reviewed by Darin Adler.
10183 * MiniBrowser/efl/main.c:
10184 (window_find_with_elm_window): Deleted because it is not used anywhere.
10186 2016-11-09 Chris Dumez <cdumez@apple.com>
10188 [WK2][NETWORK_SESSION] Add support for downloading file backed blobs
10189 https://bugs.webkit.org/show_bug.cgi?id=164458
10190 <rdar://problem/28905514>
10192 Reviewed by Darin Adler.
10194 Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout
10195 tests can request that such resources are downloaded instead of being ignored.
10197 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
10198 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
10199 (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
10200 * WebKitTestRunner/InjectedBundle/TestRunner.h:
10201 * WebKitTestRunner/TestController.cpp:
10202 (WTR::TestController::decidePolicyForNavigationResponse):
10203 * WebKitTestRunner/TestController.h:
10204 (WTR::TestController::setShouldDownloadUndisplayableMIMETypes):
10205 * WebKitTestRunner/TestInvocation.cpp:
10206 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
10208 2016-11-09 Jonathan Bedard <jbedard@apple.com>
10210 Make rpaths more robust for iOS Simulators
10211 https://bugs.webkit.org/show_bug.cgi?id=164521
10213 Reviewed by Simon Fraser.
10215 * Scripts/webkitpy/port/ios.py:
10216 (IOSSimulatorPort._createSimulatorApp): Added more robust path.
10218 2016-11-09 Csaba Osztrogonác <ossy@webkit.org>
10220 Fix Tools build on case sensitive file systems
10221 https://bugs.webkit.org/show_bug.cgi?id=164474
10223 Unreviewed buildfix.
10225 * DumpRenderTree/CMakeLists.txt:
10226 * DumpRenderTree/PlatformMac.cmake:
10227 * DumpRenderTree/PlatformWin.cmake:
10228 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
10229 * MiniBrowser/mac/CMakeLists.txt:
10231 2016-11-04 Filip Pizlo <fpizlo@apple.com>
10233 WTF::ParkingLot should stop using std::chrono because std::chrono::duration casts are prone to overflows
10234 https://bugs.webkit.org/show_bug.cgi?id=152045
10236 Reviewed by Andy Estes.
10238 * TestWebKitAPI/CMakeLists.txt:
10239 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10240 * TestWebKitAPI/Tests/WTF/Condition.cpp:
10241 (TestWebKitAPI::TEST):
10242 * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
10243 (TestWebKitAPI::ToUpperConverter::stopProducing):
10244 (TestWebKitAPI::ToUpperConverter::stopConsuming):
10245 * TestWebKitAPI/Tests/WTF/Time.cpp: Added.
10247 (TestWebKitAPI::TEST):
10249 2016-11-04 Alex Christensen <achristensen@webkit.org>
10251 Unreviewed, rolling out r208293.
10253 asserts in API tests.
10255 Reverted changeset:
10257 "NetworkSession: Network process crash when converting main
10258 resource to download"
10259 https://bugs.webkit.org/show_bug.cgi?id=164220
10260 http://trac.webkit.org/changeset/208293
10262 2016-11-04 Said Abou-Hallawa <sabouhallawa@apple.com>
10264 Add a setting and preferences to enable/disable async image decoding
10265 https://bugs.webkit.org/show_bug.cgi?id=164417
10267 Reviewed by Simon Fraser.
10269 Pref and a menu item to toggle asyncImageDecodingEnabled for WebKits 1 and 2.
10271 * MiniBrowser/mac/SettingsController.h:
10272 * MiniBrowser/mac/SettingsController.m:
10273 (-[SettingsController _populateMenu]):
10274 (-[SettingsController validateMenuItem:]):
10275 (-[SettingsController toggleAsyncImageDecodingEnabled:]):
10276 (-[SettingsController asyncImageDecodingEnabled]):
10277 * MiniBrowser/mac/WK1BrowserWindowController.m:
10278 (-[WK1BrowserWindowController didChangeSettings]):
10279 * MiniBrowser/mac/WK2BrowserWindowController.m:
10280 (-[WK2BrowserWindowController didChangeSettings]):
10282 2016-11-04 Brady Eidson <beidson@apple.com>
10284 REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail
10285 https://bugs.webkit.org/show_bug.cgi?id=164390
10287 Reviewed by Geoffrey Garen.
10289 Operating under the assumption that the behavior change is okay/desirable, this updates the test.
10291 * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
10292 (TestWebKitAPI::TEST):
10294 2016-11-04 Joanmarie Diggs <jdiggs@igalia.com>
10296 AX: [ATK] Attempting to clear selection on ARIA listboxes results in crash
10297 https://bugs.webkit.org/show_bug.cgi?id=164331
10299 Reviewed by Chris Fleizach.
10301 Add AccessibilityUIElement::clearSelectedChildren() to DRT and WKTR.
10302 Implement it for ATK.
10304 * DumpRenderTree/AccessibilityUIElement.h:
10305 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
10306 (AccessibilityUIElement::clearSelectedChildren):
10307 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
10308 (AccessibilityUIElement::clearSelectedChildren):
10309 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
10310 (AccessibilityUIElement::clearSelectedChildren):
10311 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
10312 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
10313 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
10314 (WTR::AccessibilityUIElement::clearSelectedChildren):
10315 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
10316 (WTR::AccessibilityUIElement::clearSelectedChildren):
10317 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
10318 (WTR::AccessibilityUIElement::clearSelectedChildren):
10320 2016-11-04 Per Arne Vollan <pvollan@apple.com>
10322 [Win] Page visibility tests are timing out.
10323 https://bugs.webkit.org/show_bug.cgi?id=164363
10325 Reviewed by Brent Fulgham.
10327 Implement methods to set page visibility.
10329 * DumpRenderTree/win/TestRunnerWin.cpp:
10330 (TestRunner::resetPageVisibility):
10331 (TestRunner::setPageVisibility):
10333 2016-11-03 Simon Fraser <simon.fraser@apple.com>
10335 Give all the geometry classes a single-argument scale() function for consistency
10336 https://bugs.webkit.org/show_bug.cgi?id=164400
10338 Reviewed by Zalan Bujtas.
10340 Test single-argument scale().
10342 * TestWebKitAPI/Tests/WebCore/FloatPoint.cpp:
10343 (TestWebKitAPI::TEST):
10345 2016-11-03 Chris Dumez <cdumez@apple.com>
10347 [WK2][Cocoa] Implement user interface for HTML form validation
10348 https://bugs.webkit.org/show_bug.cgi?id=164143
10349 <rdar://problem/28944652>
10351 Reviewed by Simon Fraser.
10353 Add support for UIScriptController::contentsOfUserInterfaceItem("validationBubble")
10354 on both Mac and iOS to retrieve the currently displayed validation message.
10356 * DumpRenderTree/mac/UIScriptControllerMac.mm:
10357 (WTR::UIScriptController::contentsOfUserInterfaceItem):
10358 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
10359 (WTR::UIScriptController::contentsOfUserInterfaceItem):
10360 (WTR::UIScriptController::selectFormAccessoryPickerRow):
10361 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
10362 (WTR::UIScriptController::contentsOfUserInterfaceItem):
10364 2016-11-03 Konstantin Tokarev <annulen@yandex.ru>
10366 Fixes to build JSCOnly on macOS
10367 https://bugs.webkit.org/show_bug.cgi?id=164379
10369 Reviewed by Michael Catanzaro.
10371 * TestWebKitAPI/PlatformJSCOnly.cmake: Moved BUILDING_JSCONLY__
10372 definition to OptionsJSCOnly.cmake
10374 2016-11-03 Dan Bernstein <mitz@apple.com>
10376 WKWebView’s _observedRenderingProgressEvents not restored after web process crash
10377 https://bugs.webkit.org/show_bug.cgi?id=164368
10378 <rdar://problem/29091954>
10380 Reviewed by Anders Carlsson.
10382 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10383 * TestWebKitAPI/Tests/WebKit2Cocoa/ObservedRenderingProgressEventsAfterCrash.mm: Added.
10386 2016-11-03 Alex Christensen <achristensen@webkit.org>
10388 Purge PassRefPtr from Tools
10389 https://bugs.webkit.org/show_bug.cgi?id=164358
10391 Reviewed by Michael Catanzaro.
10393 * ImageDiff/efl/ImageDiff.cpp:
10394 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
10395 * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
10396 (WTR::AccessibilityController::create):
10397 (WTR::AccessibilityController::rootElement):
10398 (WTR::AccessibilityController::focusedElement):
10399 (WTR::AccessibilityController::elementAtPoint):
10400 (WTR::AccessibilityController::addNotificationListener): Deleted.
10401 (WTR::AccessibilityController::removeNotificationListener): Deleted.
10402 (WTR::AccessibilityController::accessibleElementById): Deleted.
10403 (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
10404 (WTR::AccessibilityController::resetToConsistentState): Deleted.
10405 (WTR::AccessibilityController::platformName): Deleted.
10406 * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
10407 (WTR::AccessibilityController::logAccessibilityEvents):
10408 * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
10409 (WTR::AccessibilityTextMarker::create):
10410 * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h:
10411 * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
10412 (WTR::AccessibilityTextMarkerRange::create):
10413 * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h:
10414 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
10415 (WTR::AccessibilityUIElement::create):
10416 (WTR::AccessibilityUIElement::linkedElement):
10417 (WTR::AccessibilityUIElement::headerElementAtIndex):
10418 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
10419 (WTR::AccessibilityUIElement::characterAtOffset):
10420 (WTR::AccessibilityUIElement::wordAtOffset):
10421 (WTR::AccessibilityUIElement::lineAtOffset):
10422 (WTR::AccessibilityUIElement::sentenceAtOffset):
10423 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
10424 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
10425 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
10426 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
10427 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
10428 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
10429 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
10430 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
10431 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
10432 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
10433 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
10434 (WTR::AccessibilityUIElement::AccessibilityUIElement): Deleted.
10435 (WTR::AccessibilityUIElement::~AccessibilityUIElement): Deleted.
10436 (WTR::AccessibilityUIElement::isEqual): Deleted.
10437 (WTR::AccessibilityUIElement::elementAtPoint): Deleted.
10438 (WTR::AccessibilityUIElement::childAtIndex): Deleted.
10439 (WTR::AccessibilityUIElement::indexOfChild): Deleted.
10440 (WTR::AccessibilityUIElement::childrenCount): Deleted.
10441 (WTR::AccessibilityUIElement::titleUIElement): Deleted.
10442 (WTR::AccessibilityUIElement::parentElement): Deleted.
10443 (WTR::AccessibilityUIElement::takeFocus): Deleted.
10444 (WTR::AccessibilityUIElement::takeSelection): Deleted.
10445 (WTR::AccessibilityUIElement::addSelection): Deleted.
10446 (WTR::AccessibilityUIElement::removeSelection): Deleted.
10447 (WTR::AccessibilityUIElement::allAttributes): Deleted.
10448 (WTR::AccessibilityUIElement::attributesOfLinkedUIElements): Deleted.
10449 (WTR::AccessibilityUIElement::linkedUIElementAtIndex): Deleted.
10450 (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Deleted.
10451 (WTR::AccessibilityUIElement::attributesOfChildren): Deleted.
10452 (WTR::AccessibilityUIElement::parameterizedAttributeNames): Deleted.
10453 (WTR::AccessibilityUIElement::increment): Deleted.
10454 (WTR::AccessibilityUIElement::decrement): Deleted.
10455 (WTR::AccessibilityUIElement::showMenu): Deleted.
10456 (WTR::AccessibilityUIElement::press): Deleted.
10457 (WTR::AccessibilityUIElement::stringAttributeValue): Deleted.
10458 (WTR::AccessibilityUIElement::uiElementArrayAttributeValue): Deleted.
10459 (WTR::AccessibilityUIElement::uiElementAttributeValue): Deleted.
10460 (WTR::AccessibilityUIElement::numberAttributeValue): Deleted.
10461 (WTR::AccessibilityUIElement::boolAttributeValue): Deleted.
10462 (WTR::AccessibilityUIElement::isAttributeSupported): Deleted.
10463 (WTR::AccessibilityUIElement::isAttributeSettable): Deleted.
10464 (WTR::AccessibilityUIElement::isPressActionSupported): Deleted.
10465 (WTR::AccessibilityUIElement::isIncrementActionSupported): Deleted.
10466 (WTR::AccessibilityUIElement::isDecrementActionSupported): Deleted.
10467 (WTR::AccessibilityUIElement::role): Deleted.
10468 (WTR::AccessibilityUIElement::subrole): Deleted.
10469 (WTR::AccessibilityUIElement::roleDescription): Deleted.
10470 (WTR::AccessibilityUIElement::computedRoleString): Deleted.
10471 (WTR::AccessibilityUIElement::title): Deleted.
10472 (WTR::AccessibilityUIElement::description): Deleted.
10473 (WTR::AccessibilityUIElement::language): Deleted.
10474 (WTR::AccessibilityUIElement::stringValue): Deleted.
10475 (WTR::AccessibilityUIElement::accessibilityValue): Deleted.
10476 (WTR::AccessibilityUIElement::helpText): Deleted.
10477 (WTR::AccessibilityUIElement::orientation): Deleted.
10478 (WTR::AccessibilityUIElement::x): Deleted.
10479 (WTR::AccessibilityUIElement::y): Deleted.
10480 (WTR::AccessibilityUIElement::width): Deleted.
10481 (WTR::AccessibilityUIElement::height): Deleted.
10482 (WTR::AccessibilityUIElement::intValue): Deleted.
10483 (WTR::AccessibilityUIElement::minValue): Deleted.
10484 (WTR::AccessibilityUIElement::maxValue): Deleted.
10485 (WTR::AccessibilityUIElement::valueDescription): Deleted.
10486 (WTR::AccessibilityUIElement::insertionPointLineNumber): Deleted.
10487 (WTR::AccessibilityUIElement::selectedTextRange): Deleted.
10488 (WTR::AccessibilityUIElement::isEnabled): Deleted.
10489 (WTR::AccessibilityUIElement::isRequired): Deleted.
10490 (WTR::AccessibilityUIElement::isFocused): Deleted.
10491 (WTR::AccessibilityUIElement::isFocusable): Deleted.
10492 (WTR::AccessibilityUIElement::isSelected): Deleted.
10493 (WTR::AccessibilityUIElement::isSelectedOptionActive): Deleted.
10494 (WTR::AccessibilityUIElement::isSelectable): Deleted.
10495 (WTR::AccessibilityUIElement::isMultiSelectable): Deleted.
10496 (WTR::AccessibilityUIElement::setSelectedChild): Deleted.
10497 (WTR::AccessibilityUIElement::setSelectedChildAtIndex): Deleted.
10498 (WTR::AccessibilityUIElement::removeSelectionAtIndex): Deleted.
10499 (WTR::AccessibilityUIElement::selectedChildrenCount): Deleted.
10500 (WTR::AccessibilityUIElement::selectedChildAtIndex): Deleted.
10501 (WTR::AccessibilityUIElement::isExpanded): Deleted.
10502 (WTR::AccessibilityUIElement::isChecked): Deleted.
10503 (WTR::AccessibilityUIElement::isIndeterminate): Deleted.
10504 (WTR::AccessibilityUIElement::isVisible): Deleted.
10505 (WTR::AccessibilityUIElement::isOffScreen): Deleted.
10506 (WTR::AccessibilityUIElement::isCollapsed): Deleted.
10507 (WTR::AccessibilityUIElement::isIgnored): Deleted.
10508 (WTR::AccessibilityUIElement::hasPopup): Deleted.
10509 (WTR::AccessibilityUIElement::hierarchicalLevel): Deleted.
10510 (WTR::AccessibilityUIElement::clickPointX): Deleted.
10511 (WTR::AccessibilityUIElement::clickPointY): Deleted.
10512 (WTR::AccessibilityUIElement::documentEncoding): Deleted.
10513 (WTR::AccessibilityUIElement::documentURI): Deleted.
10514 (WTR::AccessibilityUIElement::url): Deleted.
10515 (WTR::AccessibilityUIElement::speak): Deleted.
10516 (WTR::AccessibilityUIElement::attributesOfColumnHeaders): Deleted.
10517 (WTR::AccessibilityUIElement::attributesOfRowHeaders): Deleted.
10518 (WTR::AccessibilityUIElement::attributesOfColumns): Deleted.
10519 (WTR::AccessibilityUIElement::attributesOfRows): Deleted.
10520 (WTR::AccessibilityUIElement::attributesOfVisibleCells): Deleted.
10521 (WTR::AccessibilityUIElement::attributesOfHeader): Deleted.
10522 (WTR::AccessibilityUIElement::indexInTable): Deleted.
10523 (WTR::AccessibilityUIElement::rowIndexRange): Deleted.
10524 (WTR::AccessibilityUIElement::columnIndexRange): Deleted.
10525 (WTR::AccessibilityUIElement::rowCount): Deleted.
10526 (WTR::AccessibilityUIElement::columnCount): Deleted.
10527 (WTR::AccessibilityUIElement::rowHeaders): Deleted.
10528 (WTR::AccessibilityUIElement::columnHeaders): Deleted.
10529 (WTR::AccessibilityUIElement::selectedRowAtIndex): Deleted.
10530 (WTR::AccessibilityUIElement::disclosedByRow): Deleted.
10531 (WTR::AccessibilityUIElement::disclosedRowAtIndex): Deleted.
10532 (WTR::AccessibilityUIElement::rowAtIndex): Deleted.
10533 (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex): Deleted.
10534 (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex): Deleted.
10535 (WTR::AccessibilityUIElement::ariaControlsElementAtIndex): Deleted.
10536 (WTR::AccessibilityUIElement::ariaIsGrabbed): Deleted.
10537 (WTR::AccessibilityUIElement::ariaDropEffects): Deleted.
10538 (WTR::AccessibilityUIElement::classList): Deleted.
10539 (WTR::AccessibilityUIElement::lineForIndex): Deleted.
10540 (WTR::AccessibilityUIElement::rangeForLine): Deleted.
10541 (WTR::AccessibilityUIElement::rangeForPosition): Deleted.
10542 (WTR::AccessibilityUIElement::boundsForRange): Deleted.
10543 (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
10544 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Deleted.
10545 (WTR::AccessibilityUIElement::stringForRange): Deleted.
10546 (WTR::AccessibilityUIElement::attributedStringForRange): Deleted.
10547 (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled): Deleted.
10548 (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): Deleted.
10549 (WTR::AccessibilityUIElement::uiElementForSearchPredicate): Deleted.
10550 (WTR::AccessibilityUIElement::selectTextWithCriteria): Deleted.
10551 (WTR::AccessibilityUIElement::cellForColumnAndRow): Deleted.
10552 (WTR::AccessibilityUIElement::horizontalScrollbar): Deleted.
10553 (WTR::AccessibilityUIElement::verticalScrollbar): Deleted.
10554 (WTR::AccessibilityUIElement::addNotificationListener): Deleted.
10555 (WTR::AccessibilityUIElement::removeNotificationListener): Deleted.
10556 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Deleted.
10557 (WTR::AccessibilityUIElement::textMarkerRangeForElement): Deleted.
10558 (WTR::AccessibilityUIElement::textMarkerRangeLength): Deleted.
10559 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Deleted.
10560 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Deleted.
10561 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Deleted.
10562 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Deleted.
10563 (WTR::AccessibilityUIElement::endTextMarkerForBounds): Deleted.
10564 (WTR::AccessibilityUIElement::startTextMarkerForBounds): Deleted.
10565 (WTR::AccessibilityUIElement::textMarkerForPoint): Deleted.
10566 (WTR::AccessibilityUIElement::previousTextMarker): Deleted.
10567 (WTR::AccessibilityUIElement::nextTextMarker): Deleted.
10568 (WTR::AccessibilityUIElement::startTextMarker): Deleted.
10569 (WTR::AccessibilityUIElement::endTextMarker): Deleted.
10570 (WTR::AccessibilityUIElement::stringForTextMarkerRange): Deleted.
10571 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Deleted.
10572 (WTR::AccessibilityUIElement::indexForTextMarker): Deleted.
10573 (WTR::AccessibilityUIElement::isTextMarkerValid): Deleted.
10574 (WTR::AccessibilityUIElement::textMarkerForIndex): Deleted.
10575 (WTR::AccessibilityUIElement::scrollToMakeVisible): Deleted.
10576 (WTR::AccessibilityUIElement::scrollToGlobalPoint): Deleted.
10577 (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): Deleted.
10578 (WTR::AccessibilityUIElement::supportedActions): Deleted.
10579 (WTR::AccessibilityUIElement::mathPostscriptsDescription): Deleted.
10580 (WTR::AccessibilityUIElement::mathPrescriptsDescription): Deleted.
10581 (WTR::AccessibilityUIElement::pathDescription): Deleted.
10582 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
10583 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
10584 (WTR::EventSendingController::create):
10585 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
10586 * WebKitTestRunner/InjectedBundle/GCController.cpp:
10587 (WTR::GCController::create):
10588 * WebKitTestRunner/InjectedBundle/GCController.h:
10589 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
10590 (WTR::InjectedBundle::beginTesting):
10591 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
10592 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
10593 (WTR::TestRunner::create):
10594 * WebKitTestRunner/InjectedBundle/TestRunner.h:
10595 * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
10596 (WTR::TextInputController::create):
10597 * WebKitTestRunner/InjectedBundle/TextInputController.h:
10598 * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
10599 (WTR::AccessibilityController::accessibleElementById):
10600 (WTR::AccessibilityController::rootElement):
10601 (WTR::AccessibilityController::focusedElement):
10602 (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
10603 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
10604 (WTR::AccessibilityNotificationHandler::create):
10605 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
10606 (WTR::AccessibilityUIElement::elementAtPoint):
10607 (WTR::AccessibilityUIElement::childAtIndex):
10608 (WTR::accessibilityElementAtIndex):
10609 (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
10610 (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
10611 (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
10612 (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
10613 (WTR::AccessibilityUIElement::disclosedRowAtIndex):
10614 (WTR::AccessibilityUIElement::rowAtIndex):
10615 (WTR::AccessibilityUIElement::selectedChildAtIndex):
10616 (WTR::AccessibilityUIElement::selectedRowAtIndex):
10617 (WTR::AccessibilityUIElement::titleUIElement):
10618 (WTR::AccessibilityUIElement::parentElement):
10619 (WTR::AccessibilityUIElement::disclosedByRow):
10620 (WTR::AccessibilityUIElement::uiElementAttributeValue):
10621 (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
10622 (WTR::AccessibilityUIElement::cellForColumnAndRow):
10623 (WTR::AccessibilityUIElement::horizontalScrollbar):
10624 (WTR::AccessibilityUIElement::verticalScrollbar):
10625 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
10626 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
10627 (WTR::AccessibilityUIElement::previousTextMarker):
10628 (WTR::AccessibilityUIElement::nextTextMarker):
10629 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
10630 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
10631 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
10632 (WTR::AccessibilityUIElement::endTextMarkerForBounds):
10633 (WTR::AccessibilityUIElement::startTextMarkerForBounds):
10634 (WTR::AccessibilityUIElement::textMarkerForPoint):
10635 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
10636 (WTR::AccessibilityUIElement::textMarkerForIndex):
10637 (WTR::AccessibilityUIElement::startTextMarker):
10638 (WTR::AccessibilityUIElement::endTextMarker):
10639 * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
10640 (WTR::AccessibilityController::accessibleElementById):
10641 (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
10642 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
10643 (WTR::AccessibilityUIElement::headerElementAtIndex):
10644 (WTR::AccessibilityUIElement::linkedElement):
10645 (WTR::AccessibilityUIElement::elementAtPoint):
10646 (WTR::AccessibilityUIElement::childAtIndex):
10647 (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
10648 (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
10649 (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
10650 (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
10651 (WTR::AccessibilityUIElement::disclosedRowAtIndex):
10652 (WTR::AccessibilityUIElement::rowAtIndex):
10653 (WTR::AccessibilityUIElement::selectedChildAtIndex):
10654 (WTR::AccessibilityUIElement::selectedRowAtIndex):
10655 (WTR::AccessibilityUIElement::titleUIElement):
10656 (WTR::AccessibilityUIElement::parentElement):
10657 (WTR::AccessibilityUIElement::disclosedByRow):
10658 (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
10659 (WTR::AccessibilityUIElement::uiElementAttributeValue):
10660 (WTR::AccessibilityUIElement::rangeForLine):
10661 (WTR::AccessibilityUIElement::rangeForPosition):
10662 (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
10663 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
10664 (WTR::AccessibilityUIElement::cellForColumnAndRow):
10665 (WTR::AccessibilityUIElement::horizontalScrollbar):
10666 (WTR::AccessibilityUIElement::verticalScrollbar):
10667 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
10668 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
10669 (WTR::AccessibilityUIElement::previousTextMarker):
10670 (WTR::AccessibilityUIElement::nextTextMarker):
10671 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
10672 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
10673 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
10674 (WTR::AccessibilityUIElement::endTextMarkerForBounds):
10675 (WTR::AccessibilityUIElement::startTextMarkerForBounds):
10676 (WTR::AccessibilityUIElement::textMarkerForPoint):
10677 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
10678 (WTR::AccessibilityUIElement::textMarkerForIndex):
10679 (WTR::AccessibilityUIElement::startTextMarker):
10680 (WTR::AccessibilityUIElement::endTextMarker):
10681 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
10682 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
10683 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
10684 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
10685 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
10686 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
10687 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
10688 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
10689 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
10690 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
10691 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
10692 (WTR::AccessibilityUIElement::mathPrescriptsDescription):
10693 (WTR::AccessibilityUIElement::supportedActions):
10694 * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
10695 (WTR::AccessibilityController::accessibleElementById):
10696 (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
10697 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
10698 (makeValueRefForValue):
10699 (-[AccessibilityNotificationHandler _notificationReceived:]):
10700 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
10701 (WTR::AccessibilityUIElement::elementAtPoint):
10702 (WTR::AccessibilityUIElement::childAtIndex):
10703 (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
10704 (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
10705 (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
10706 (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
10707 (WTR::AccessibilityUIElement::disclosedRowAtIndex):
10708 (WTR::AccessibilityUIElement::rowAtIndex):
10709 (WTR::AccessibilityUIElement::selectedChildAtIndex):
10710 (WTR::AccessibilityUIElement::selectedRowAtIndex):
10711 (WTR::AccessibilityUIElement::titleUIElement):
10712 (WTR::AccessibilityUIElement::parentElement):
10713 (WTR::AccessibilityUIElement::disclosedByRow):
10714 (WTR::AccessibilityUIElement::uiElementAttributeValue):
10715 (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
10716 (WTR::AccessibilityUIElement::cellForColumnAndRow):
10717 (WTR::AccessibilityUIElement::horizontalScrollbar):
10718 (WTR::AccessibilityUIElement::verticalScrollbar):
10719 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
10720 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
10721 (WTR::AccessibilityUIElement::previousTextMarker):
10722 (WTR::AccessibilityUIElement::nextTextMarker):
10723 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
10724 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
10725 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
10726 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
10727 (WTR::AccessibilityUIElement::endTextMarkerForBounds):
10728 (WTR::AccessibilityUIElement::startTextMarkerForBounds):
10729 (WTR::AccessibilityUIElement::textMarkerForPoint):
10730 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
10731 (WTR::AccessibilityUIElement::textMarkerForIndex):
10732 (WTR::AccessibilityUIElement::startTextMarker):
10733 (WTR::AccessibilityUIElement::endTextMarker):
10734 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
10735 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
10736 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
10737 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
10738 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
10739 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
10740 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
10741 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
10742 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
10743 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
10744 * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
10748 2016-11-02 Alex Christensen <achristensen@webkit.org>
10750 Remove Battery Status API from the tree
10751 https://bugs.webkit.org/show_bug.cgi?id=164213
10753 Reviewed by Sam Weinig.
10755 * Scripts/webkitperl/FeatureList.pm:
10756 * Scripts/webkitpy/common/config/watchlist:
10758 2016-11-02 Olivier Blin <olivier.blin@softathome.com>
10760 [GTK] Use libgcrypt instead of GnuTLS for CryptoDigest and SubtleCrypto HMAC implementation
10761 https://bugs.webkit.org/show_bug.cgi?id=163125
10763 Reviewed by Michael Catanzaro.
10765 * gtk/install-dependencies: List libgcrypt for WebKitGTK+ build, and gnutls for jhbuild only.
10766 gnutls is useful for glib-networking in jhbuild.
10768 2016-11-02 Carlos Garcia Campos <cgarcia@igalia.com>
10770 NetworkSession: Network process crash when converting main resource to download
10771 https://bugs.webkit.org/show_bug.cgi?id=164220
10773 Reviewed by Alex Christensen.
10775 Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
10776 converted to a download and another one to test the cancellation as the test was doing before. When doing the
10777 full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
10780 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
10781 (testPolicyResponseDownload):
10782 (testPolicyResponseDownloadCancel):
10785 2016-11-01 Alex Christensen <achristensen@webkit.org>
10787 Remove PassRefPtr from DumpRenderTree
10788 https://bugs.webkit.org/show_bug.cgi?id=164307
10790 Reviewed by Sam Weinig.
10792 * DumpRenderTree/PixelDumpSupport.h:
10793 * DumpRenderTree/TestRunner.cpp:
10794 (TestRunner::create):
10795 * DumpRenderTree/TestRunner.h:
10796 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
10797 (createBitmapContext):
10798 * DumpRenderTree/cg/PixelDumpSupportCG.h:
10799 (BitmapContext::createByAdoptingBitmapAndContext):
10800 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
10801 (createBitmapContextFromWebView):
10802 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
10803 (createBitmapContextFromWebView):
10804 (createPagedBitmapContext):
10805 * DumpRenderTree/mac/TestRunnerMac.mm:
10806 * DumpRenderTree/win/PixelDumpSupportWin.cpp:
10807 (createBitmapContextFromWebView):
10808 * DumpRenderTree/win/TextInputController.h:
10810 2016-11-02 Carlos Garcia Campos <cgarcia@igalia.com>
10812 [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp
10813 https://bugs.webkit.org/show_bug.cgi?id=161481
10815 Reviewed by Michael Catanzaro.
10817 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
10818 (WebKitTestBus::WebKitTestBus):
10819 (WebKitTestBus::~WebKitTestBus):
10820 (WebKitTestBus::run):
10821 (WebKitTestBus::getOrCreateConnection):
10822 (WebKitTestBus::createProxy):
10823 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
10825 2016-11-02 Carlos Garcia Campos <cgarcia@igalia.com>
10827 Unreviewed. Fix /webkit2/WebKitWebContext/get-plugins in the bots after r208273.
10829 The test fails now if WEBKIT_TEST_PLUGIN_DIR contains symlinks, which is the case of the GTK+ bots.
10831 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
10832 (testWebContextGetPlugins): Use realpath with WEBKIT_TEST_PLUGIN_DIR when building the expected plugins path.
10834 2016-11-02 Romain Bellessort <romain.bellessort@crf.canon.fr>
10836 [Readable Streams API] Enable creation of ReadableByteStreamController
10837 https://bugs.webkit.org/show_bug.cgi?id=164014
10839 Reviewed by Youenn Fablet.
10841 Enable the byte stream part of Readable Streams API by default.
10843 * Scripts/webkitperl/FeatureList.pm:
10844 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
10846 2016-11-01 Ryosuke Niwa <rniwa@webkit.org>
10848 Remove CUSTOM_ELEMENTS build flag
10849 https://bugs.webkit.org/show_bug.cgi?id=164267
10851 Reviewed by Antti Koivisto.
10853 Removed the build flag.
10855 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
10857 2016-11-01 Alex Christensen <achristensen@webkit.org>
10859 Percent-encode non-ASCII code points in hosts of URLs with unrecognized schemes
10860 https://bugs.webkit.org/show_bug.cgi?id=164290
10862 Reviewed by Tim Horton.
10864 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
10865 (TestWebKitAPI::checkRelativeURL):
10866 (TestWebKitAPI::checkURLDifferences):
10867 (TestWebKitAPI::checkRelativeURLDifferences):
10868 Move helper functions to the top so I can use them from any tests.
10869 (TestWebKitAPI::shouldFail):
10870 (TestWebKitAPI::checkURL):
10871 (TestWebKitAPI::TEST_F):
10873 2016-11-01 Hyowon Kim <hw1008.kim@samsung.com>
10875 [GTK] Failed to generate GeoClue2Interface files.
10876 https://bugs.webkit.org/show_bug.cgi?id=164270
10878 Reviewed by Michael Catanzaro.
10880 To generate codes for D-Bus interfaces,
10881 geoclue-2.0 package including D-Bus introspection XML files should be installed.
10883 * gtk/install-dependencies: add geoclue-2.0 package.
10885 2016-11-01 Fujii Hironori <Hironori.Fujii@sony.com>
10887 [CMake] generate-bindings-all.pl uses USES_TERMINAL which leaves a noisy line in interactive Ninja build
10888 https://bugs.webkit.org/show_bug.cgi?id=163868
10890 Reviewed by Michael Catanzaro.
10892 It takes long time for generate-bindings-all.pl to generate all
10893 bindings. So, it shows the progress while running and
10894 USES_TERMINAL option of add_custom_target have been used to invoke
10895 the command. However, USES_TERMINAL leaves a noisy line in
10896 Ninja's neat build log of interactive build.
10898 A new CMake option SHOW_BINDINGS_GENERATION_PROGRESS is added to
10899 stop using USES_TERMINAL only in case of interactive Ninja build.
10901 * Scripts/webkitdirs.pm:
10902 (generateBuildSystemFromCMakeProject): Enable
10903 SHOW_BINDINGS_GENERATION_PROGRESS not in case of interactive
10906 2016-10-31 Simon Fraser <simon.fraser@apple.com>
10908 Add basic visual/layout viewport support for fixed position layout
10909 https://bugs.webkit.org/show_bug.cgi?id=164261
10911 Reviewed by Dean Jackson.
10913 Don't give tests in the "visual-viewport" directory a flexible viewport.
10915 * DumpRenderTree/mac/DumpRenderTree.mm:
10916 (shouldMakeViewportFlexible):
10917 * WebKitTestRunner/TestOptions.cpp:
10918 (WTR::shouldMakeViewportFlexible):
10920 2016-10-29 Filip Pizlo <fpizlo@apple.com>
10922 JSC should support SharedArrayBuffer
10923 https://bugs.webkit.org/show_bug.cgi?id=163986
10925 Reviewed by Keith Miller.
10927 Use the right kind of typed array API.
10929 * DumpRenderTree/TestRunner.cpp:
10930 (setAudioResultCallback):
10932 2016-10-31 Simon Fraser <simon.fraser@apple.com>
10934 Make UIScriptController::zoomToScale() work on Mac WK1 and WK2
10935 https://bugs.webkit.org/show_bug.cgi?id=164238
10937 Reviewed by Dean Jackson.
10939 Implement UIScriptController::zoomToScale() for WTR and DRT on Mac.
10941 * DumpRenderTree/mac/UIScriptControllerMac.mm:
10942 (WTR::UIScriptController::zoomToScale):
10943 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
10944 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
10945 (WTR::UIScriptController::zoomToScale):
10947 2016-10-31 Dewei Zhu <dewei_zhu@apple.com>
10949 Update twisted version in webkitpy.thirdparty.autoinstalled module.
10950 https://bugs.webkit.org/show_bug.cgi?id=154667
10952 Reviewed by Ryosuke Niwa.
10954 Use twisted_15_5_0 for the twisted module used by run-benchmark because there is a bug in twisted 12.1.0 which sometimes stops the test.
10955 Installing twisted was introduced in https://bugs.webkit.org/show_bug.cgi?id=147082 for run-benchmark script.
10956 Since buildbot relies on twisted 12.1.0 and has not been verified the compatibility on twisted 15.5.0, it would be more secure to use an individual version for run-benchmark script.
10958 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
10959 * Scripts/webkitpy/thirdparty/__init__.py:
10960 (AutoinstallImportHook.find_module):
10961 (AutoinstallImportHook._install_twisted_15_5_0):
10962 (AutoinstallImportHook._install_twisted): Deleted.
10964 2016-10-31 Ryosuke Niwa <rniwa@webkit.org>
10966 Enable custom elements by default everywhere
10967 https://bugs.webkit.org/show_bug.cgi?id=164242
10969 Reviewed by Antti Koivisto.
10971 Enable custom elements API on every port by default.
10973 * Scripts/webkitperl/FeatureList.pm:
10975 2016-10-31 Nan Wang <n_wang@apple.com>
10977 AX: aria-sort is not exposed on iOS
10978 https://bugs.webkit.org/show_bug.cgi?id=164245
10980 Reviewed by Chris Fleizach.
10982 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
10983 (AccessibilityUIElement::stringAttributeValue):
10984 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
10985 (WTR::AccessibilityUIElement::stringAttributeValue):
10987 2016-10-31 Simon Fraser <simon.fraser@apple.com>
10989 Implement IntersectionObserver
10990 https://bugs.webkit.org/show_bug.cgi?id=159475
10992 Reviewed by Ryosuke Niwa.
10994 Add ENABLE_INTERSECTION_OBSERVER, enabled by default.
10996 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
10998 2016-10-31 Ryan Haddad <ryanhaddad@apple.com>
11000 Unreviewed, rolling out r208154.
11002 This change caused an assertion failure during API tests on
11005 Reverted changeset:
11007 "NetworkSession: Network process crash when converting main
11008 resource to download"
11009 https://bugs.webkit.org/show_bug.cgi?id=164220
11010 http://trac.webkit.org/changeset/208154
11012 2016-10-31 Said Abou-Hallawa <sabouhallawa@apple.com>
11014 Unreviewed, change my status to be a WebKit reviewer
11016 * Scripts/webkitpy/common/config/contributors.json:
11018 2016-10-31 Carlos Garcia Campos <cgarcia@igalia.com>
11020 NetworkSession: Network process crash when converting main resource to download
11021 https://bugs.webkit.org/show_bug.cgi?id=164220
11023 Reviewed by Alex Christensen.
11025 Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
11026 converted to a download and another one to test the cancellation as the test was doing before. When doing the
11027 full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
11030 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
11031 (testPolicyResponseDownload):
11032 (testPolicyResponseDownloadCancel):
11035 2016-10-31 Keith Miller <keith_miller@apple.com>
11037 Unreviewed, fix watchlist regexp for wasm.
11039 * Scripts/webkitpy/common/config/watchlist:
11041 2016-10-31 Keith Miller <keith_miller@apple.com>
11043 autogenerated files from wasm.json should be in derived sources.
11044 https://bugs.webkit.org/show_bug.cgi?id=164152
11046 Reviewed by Filip Pizlo.
11048 Add message to make sure that people keep the wasm.jsons up to date.
11050 * Scripts/webkitpy/common/config/watchlist:
11052 2016-10-31 Wenson Hsieh <wenson_hsieh@apple.com>
11054 Holding down a key to choose an accented character should fire "insertReplacementText" input events
11055 https://bugs.webkit.org/show_bug.cgi?id=164209
11056 <rdar://problem/29019305>
11058 Reviewed by Darin Adler.
11060 Adds test support for inserting replacement text on Mac. This is equivalent to holding down a vowel key (e.g.
11061 'a') to bring up the menu containing accented version of the character, then selecting an accented character to
11062 insert in place of the typed character. This is exposed via UIScriptController.insertText, which takes a string
11063 and an insertion range.
11065 * DumpRenderTree/mac/UIScriptControllerMac.mm:
11066 (WTR::UIScriptController::insertText):
11067 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
11069 Note that there is no callback argument to insertText, since UIScriptController::insertText is synchronous in
11070 the UI process. The tests end when corresponding input events fired as a result of insertText have been received
11071 in the web process. Please see the new layout tests for more detail.
11073 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
11074 (WTR::UIScriptController::insertText):
11075 * TestRunnerShared/UIScriptContext/UIScriptController.h:
11076 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
11077 (WTR::nsStringFromJSString):
11078 (WTR::UIScriptController::insertText):
11080 2016-10-30 Sam Weinig <sam@webkit.org>
11082 [WebIDL] Restructure IDLParser structs to better match modern WebIDL concepts
11083 https://bugs.webkit.org/show_bug.cgi?id=164208
11085 Reviewed by Darin Adler.
11087 * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
11088 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
11089 Update for new struct types.
11091 2016-10-29 Darin Adler <darin@apple.com>
11093 Fix failing ExtendedColor tests.
11095 * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp:
11096 Changed the tests in two ways: First, use EXPECT_EQ instead of EXPECT_TRUE
11097 for the string equality comparisons. This required including WTFStringUtilities.h.
11098 Second, change expected results to match what the code is currently generating,
11099 so alpha channels are "0.25" rather than "0.25 / 1". I'll let Dean fix both these
11100 tests and the code if these results are incorrect.
11102 2016-10-29 Wenson Hsieh <wenson_hsieh@apple.com>
11104 UIScriptControllerIOS.mm should not be soft-linking UIKit
11105 https://bugs.webkit.org/show_bug.cgi?id=164171
11107 Reviewed by Darin Adler.
11109 Follow-up to r208090. Instead of soft-linking, we can simply grab UIKeyboardPredictionView by name instead.
11111 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
11112 (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
11114 2016-10-28 Darin Adler <darin@apple.com>
11116 Move all classes in the HTML directory from ExceptionCode to Exception
11117 https://bugs.webkit.org/show_bug.cgi?id=163876
11119 Reviewed by Sam Weinig.
11121 * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:
11122 (TestWebKitAPI::ToString): Updated for changes to the TimeRanges class.
11123 (TestWebKitAPI::TEST): Ditto.
11125 2016-10-28 Devin Rousso <dcrousso+webkit@gmail.com>
11127 Unreviewed, changed Devin Rousso's email and nick.
11129 * Scripts/webkitpy/common/config/contributors.json:
11131 2016-10-28 Wenson Hsieh <wenson_hsieh@apple.com>
11133 Unreviewed, fix the iOS build after r208090.
11135 Use soft-linking as needed in UIScriptControllerIOS.mm.
11137 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
11138 (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
11140 2016-10-28 Wenson Hsieh <wenson_hsieh@apple.com>
11142 iOS autocorrection does not trigger an input event of inputType "insertReplacementText"
11143 https://bugs.webkit.org/show_bug.cgi?id=164077
11144 <rdar://problem/28987810>
11146 Reviewed by Simon Fraser.
11148 Adds test support for inserting text candidates on iOS in the form of
11149 UIScriptController.selectTextCandidateAtIndex(index, callback), which selects the text candidate at a given
11150 index (this needs to be a value between 0-2 on iOS) and fires the callback when done.
11152 To implement this, we wait for the text prediction view to have predictions (we determine this by polling at a
11153 given interval) and then tap the center of the text prediction view at the given index.
11155 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
11156 (WTR::UIScriptController::selectTextCandidateAtIndex):
11157 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
11158 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
11159 (WTR::UIScriptController::selectTextCandidateAtIndex):
11160 (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
11161 * TestRunnerShared/UIScriptContext/UIScriptController.h:
11162 * WebKitTestRunner/ios/UIKitSPI.h:
11163 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
11164 (WTR::UIScriptController::selectTextCandidateAtIndex):
11165 (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
11167 2016-10-28 Commit Queue <commit-queue@webkit.org>
11169 Unreviewed, rolling out r207700.
11170 https://bugs.webkit.org/show_bug.cgi?id=164168
11172 We are ready after r208086 (Requested by alexchristensen on
11175 Reverted changeset:
11177 "Unreviewed, rolling out r207582."
11178 https://bugs.webkit.org/show_bug.cgi?id=163819
11179 http://trac.webkit.org/changeset/207700
11181 2016-10-28 Alex Christensen <achristensen@webkit.org>
11183 Partially revert 207805 after resolution in URL spec issue 87
11184 https://bugs.webkit.org/show_bug.cgi?id=164142
11186 Reviewed by Andy Estes.
11188 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
11189 (TestWebKitAPI::TEST_F):
11191 2016-10-28 Alex Christensen <achristensen@webkit.org>
11193 URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
11194 https://bugs.webkit.org/show_bug.cgi?id=164154
11196 Reviewed by Andy Estes.
11198 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
11199 (TestWebKitAPI::TEST_F):
11201 2016-10-28 Sam Weinig <sam@webkit.org>
11203 [WebIDL] Update parser and code generators to only access type information through the type property
11204 https://bugs.webkit.org/show_bug.cgi?id=164141
11206 Reviewed by Anders Carlsson.
11208 * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
11209 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
11210 Update to always access type information through type accessors. Remove use of removed
11213 2016-10-28 Frederic Wang <fwang@igalia.com>
11215 [GTK] Upgrade HarfBuzz to version 1.3.3
11216 https://bugs.webkit.org/show_bug.cgi?id=162719
11218 Reviewed by Michael Catanzaro.
11220 * gtk/jhbuild.modules:
11222 2016-10-27 Chris Dumez <cdumez@apple.com>
11224 Regression(r203601): Caused crashes in iBooks
11225 https://bugs.webkit.org/show_bug.cgi?id=164093
11226 <rdar://problem/28745634>
11228 Reviewed by Darin Adler.
11230 Add API test coverage.
11232 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11233 * TestWebKitAPI/Tests/mac/DOMNode.mm: Added.
11234 (-[DOMNodeTest webView:didFinishLoadForFrame:]):
11235 (TestWebKitAPI::TEST):
11237 2016-10-27 Sam Weinig <sam@webkit.org>
11239 [WebIDL] Move code generators off of domSignature::type and onto domSignature::idlType
11240 https://bugs.webkit.org/show_bug.cgi?id=164089
11242 Reviewed by Alex Christensen.
11244 * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
11245 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
11246 Update for the removal of domSignature::type, and new signatures of helper predicates.
11248 2016-10-27 Commit Queue <commit-queue@webkit.org>
11250 Unreviewed, rolling out r207992.
11251 https://bugs.webkit.org/show_bug.cgi?id=164070
11253 triggered aclocal version conflict (Requested by mcatanzaro on
11256 Reverted changeset:
11258 "[GTK] Bump glib to 2.50.1 (or find alternative solution to
11259 Gtk+ CUPS build issue)"
11260 https://bugs.webkit.org/show_bug.cgi?id=163689
11261 http://trac.webkit.org/changeset/207992
11263 2016-10-27 Joanmarie Diggs <jdiggs@igalia.com>
11265 [GTK] Bump glib to 2.50.1 (or find alternative solution to Gtk+ CUPS build issue)
11266 https://bugs.webkit.org/show_bug.cgi?id=163689
11268 Reviewed by Michael Catanzaro.
11270 In order to fix bug #163591, we need to apply an upstream patch to GTK+.
11271 But GTK+ won't build with that patch due to the following error:
11273 m4_copy: won't overwrite defined macro: glib_DEFUN
11275 There is an upstream GLib patch which solves that issue. We should apply
11276 that patch as well, until we bump GLib to 2.50.1 or later.
11278 * gtk/jhbuild.modules: Apply upstream GLib patch.
11279 * gtk/patches/glib-deprecate-am-glib-gnu-gettext.patch: Added.
11281 2016-10-27 Xabier Rodriguez Calvar <calvaris@igalia.com>
11283 Unreviewed fix of GTK and EFL test bots.
11285 * Scripts/webkitperl/FeatureList.pm: Deactivated media-source and
11286 legacy-encrypted-media by default for GTK and EFL.
11288 2016-10-26 Yusuke Suzuki <utatane.tea@gmail.com>
11290 [GTK] JSC test wasm.yaml/wasm/js-api/test_basic_api.js.default-wasm and wasm.yaml/wasm/js-api/test_Module.js.default-wasm fail with Exception: ReferenceError: Can't find variable: WebAssembly
11291 https://bugs.webkit.org/show_bug.cgi?id=163846
11293 Reviewed by Michael Catanzaro.
11295 WebAssembly is now developed for Darwin right now.
11296 Disable WASM tests in the other platforms.
11298 * Scripts/run-jsc-stress-tests:
11300 2016-10-26 Enrique Ocaña González <eocanha@igalia.com>
11302 [cmake][GStreamer][MSE][EME] Build MSE and EME code after refactoring
11303 https://bugs.webkit.org/show_bug.cgi?id=162928
11305 Reviewed by Xabier Rodriguez-Calvar.
11307 Explicitly enable MSE and EME on WebKitGTK+ buildbots.
11309 This patch is co-authored with Philippe Normand <philn@igalia.com> (EME support).
11311 * Scripts/webkitperl/FeatureList.pm:
11313 2016-10-25 Antoine Quint <graouts@apple.com>
11315 [Modern Media Controls] Media Controller: skip back support
11316 https://bugs.webkit.org/show_bug.cgi?id=163725
11317 <rdar://problem/27989480>
11319 Reviewed by Dean Jackson.
11321 * Scripts/webkitpy/layout_tests/servers/aliases.json: Adding a new alias such that we may
11322 access the modern-media-controls source files through the web server.
11324 2016-10-19 Jer Noble <jer.noble@apple.com>
11326 Add WKWebView fullscreen delegate SPI
11327 https://bugs.webkit.org/show_bug.cgi?id=163674
11329 Reviewed by Anders Carlsson.
11331 Add a new API test which verifies that the fullscreen delegate receives notifications.
11333 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
11334 (-[FullscreenDelegateMessageHandler userContentController:didReceiveScriptMessage:]):
11335 (-[FullscreenDelegateMessageHandler _webViewWillEnterFullscreen:]):
11336 (-[FullscreenDelegateMessageHandler _webViewDidEnterFullscreen:]):
11337 (-[FullscreenDelegateMessageHandler _webViewWillExitFullscreen:]):
11338 (-[FullscreenDelegateMessageHandler _webViewDidExitFullscreen:]):
11339 (TestWebKitAPI::TEST):
11341 2016-10-24 Alex Christensen <achristensen@webkit.org>
11343 URLParser should match old URL::parse with %2E in path
11344 https://bugs.webkit.org/show_bug.cgi?id=163929
11346 Reviewed by Alexey Proskuryakov.
11348 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
11349 (TestWebKitAPI::TEST_F):
11351 2016-10-24 Ryan Haddad <ryanhaddad@apple.com>
11353 Unreviewed, rolling out r207795.
11355 Introduced API test failures on iOS and macOS.
11357 Reverted changeset:
11359 "URLParser should match old URL::parse with %2E in path"
11360 https://bugs.webkit.org/show_bug.cgi?id=163929
11361 http://trac.webkit.org/changeset/207795
11363 2016-10-24 Alex Christensen <achristensen@webkit.org>
11365 URLParser should match old URL::parse with %2E in path
11366 https://bugs.webkit.org/show_bug.cgi?id=163929
11368 Reviewed by Alexey Proskuryakov.
11370 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
11371 (TestWebKitAPI::TEST_F):
11373 2016-10-21 Alex Christensen <achristensen@webkit.org>
11375 URL::port should return Optional<uint16_t>
11376 https://bugs.webkit.org/show_bug.cgi?id=163806
11378 Reviewed by Darin Adler.
11380 * TestWebKitAPI/Tests/WebCore/URL.cpp:
11381 (TestWebKitAPI::TEST_F):
11382 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
11383 (TestWebKitAPI::checkURL):
11384 (TestWebKitAPI::checkRelativeURL):
11385 (TestWebKitAPI::checkURLDifferences):
11386 (TestWebKitAPI::checkRelativeURLDifferences):
11387 (TestWebKitAPI::TEST_F):
11389 2016-10-24 Youenn Fablet <youenn@apple.com>
11391 Activate WEB_RTC compilation flags for Mac bots
11392 https://bugs.webkit.org/show_bug.cgi?id=163886
11394 Reviewed by Eric Carlson.
11396 * Scripts/webkitperl/FeatureList.pm:
11397 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
11399 2016-10-24 Wenson Hsieh <wenson_hsieh@apple.com>
11401 Unreviewed, add myself as a WebKit reviewer
11403 * Scripts/webkitpy/common/config/contributors.json:
11405 2016-10-22 Dan Bernstein <mitz@apple.com>
11407 Improve MiniBrowser window titles for URLs without paths and with no title
11408 <https://webkit.org/b/163843>
11410 Reviewed by Darin Adler.
11412 * MiniBrowser/mac/WK1BrowserWindowController.m:
11413 (-[WK1BrowserWindowController fetch:]): While we’re here, deploy
11414 +[NSURL _webkit_URLWithUserTypedString:] here to match the WK2BrowserWindowController
11415 version of this method.
11416 (-[WK1BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
11417 use the entire URL.
11418 (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]): Also while we’re here,
11419 deploy +[NSURL _web_userVisibleString] here to match the WK2BrowserWindowController
11422 * MiniBrowser/mac/WK2BrowserWindowController.m:
11423 (-[WK2BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
11424 use the entire URL.
11426 2016-10-21 David Kilzer <ddkilzer@apple.com>
11428 Bug 163762: IntSize::area() should used checked arithmetic
11429 <https://webkit.org/b/163762>
11431 Reviewed by Darin Adler.
11433 * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
11434 (TestWebKitAPI::TEST): Call unsafeGet().
11435 * TestWebKitAPI/Tests/WebCore/IntSize.cpp:
11436 (TestWebKitAPI::TEST): Ditto.
11438 2016-10-21 James Craig <jcraig@apple.com>
11440 Unreviewed: Added Aaron Chu <aaron_chu@apple.com> to contributors list.
11442 * Scripts/webkitpy/common/config/contributors.json:
11444 2016-10-21 Commit Queue <commit-queue@webkit.org>
11446 Unreviewed, rolling out r207582.
11447 https://bugs.webkit.org/show_bug.cgi?id=163819
11449 Not quite ready rdar://problem/28897179 (Requested by
11450 alexchristensen on #webkit).
11452 Reverted changeset:
11454 "Re-enable URLParser for non-Safari Cocoa apps after r207321"
11455 https://bugs.webkit.org/show_bug.cgi?id=163690
11456 http://trac.webkit.org/changeset/207582
11458 2016-10-21 Jonathan Bedard <jbedard@apple.com>
11460 WebKitTestRunnerApp packages .idl file
11461 https://bugs.webkit.org/show_bug.cgi?id=163788
11463 Reviewed by Darin Adler.
11465 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Removed .idl file from app package, removed bad reference to app icon.
11467 2016-10-21 Csaba Osztrogonác <ossy@webkit.org>
11469 [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package
11470 https://bugs.webkit.org/show_bug.cgi?id=163733
11472 Reviewed by Gyuyoung Kim.
11474 * efl/install-dependencies: Added geoclue-2.0 package.
11476 2016-10-21 Commit Queue <commit-queue@webkit.org>
11478 Unreviewed, rolling out r207609.
11479 https://bugs.webkit.org/show_bug.cgi?id=163776
11481 As glib bump was rollout, we need to rollout this too
11482 (Requested by rego on #webkit).
11484 Reverted changeset:
11486 "[GTK] Cannot build GTK+ with CUPS 2.* versions"
11487 https://bugs.webkit.org/show_bug.cgi?id=163591
11488 http://trac.webkit.org/changeset/207609
11490 2016-10-20 Chris Dumez <cdumez@apple.com>
11492 "Download Linked File" context menu action should use 'download' attribute as suggested filename
11493 https://bugs.webkit.org/show_bug.cgi?id=163742
11494 <rdar://problem/28840734>
11496 Reviewed by Darin Adler.
11498 Add API test coverage.
11500 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11501 * TestWebKitAPI/Tests/WebKit2/link-with-download-attribute.html: Added.
11502 * TestWebKitAPI/Tests/WebKit2/mac/ContextMenuDownload.mm: Added.
11503 (TestWebKitAPI::didFinishLoadForFrame):
11504 (TestWebKitAPI::getContextMenuFromProposedMenu):
11505 (TestWebKitAPI::decideDestinationWithSuggestedFilename):
11506 (TestWebKitAPI::TEST):
11508 2016-10-20 Commit Queue <commit-queue@webkit.org>
11510 Unreviewed, rolling out r207589.
11511 https://bugs.webkit.org/show_bug.cgi?id=163765
11513 Introduced 17 new layout test failures (Requested by
11514 mcatanzaro on #webkit).
11516 Reverted changeset:
11518 "[GTK] Bump glib to 2.50.1"
11519 https://bugs.webkit.org/show_bug.cgi?id=163689
11520 http://trac.webkit.org/changeset/207589
11522 2016-10-19 Myles C. Maxfield <mmaxfield@apple.com>
11524 [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
11525 https://bugs.webkit.org/show_bug.cgi?id=163374
11527 Reviewed by Darin Adler.
11529 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
11531 2016-10-20 Sam Weinig <sam@webkit.org>
11533 Add convenience function that combines WTF::visit(...) with WTF::makeVisitor(...)
11534 https://bugs.webkit.org/show_bug.cgi?id=163713
11536 Reviewed by Dan Bernstein.
11538 * TestWebKitAPI/Tests/WTF/Variant.cpp:
11539 Add test for WTF::switchOn()
11541 2016-10-20 Fujii Hironori <Hironori.Fujii@sony.com>
11543 [CMake] CMake does not support the dep files for implicit dependency
11544 https://bugs.webkit.org/show_bug.cgi?id=161433
11546 Reviewed by Brent Fulgham.
11548 Created a Perl script to generate all IDL bindings for CMake.
11549 This script can regenerate outdated bindings by based on the
11550 supplemental dependency and dep files created by
11551 '--write-dependencies' switch of generate-bindings.pl.
11553 add_custom_target is used to invoke the script instead of
11554 add_custom_command because Ninja deletes all output files before
11555 executing the command in case of add_custom_command.
11557 USES_TERMINAL option of add_custom_target has two effects:
11558 1) Not buffering output of the command
11559 2) Invoking the command in the special Ninja pool which inhibits parallel build
11560 One needs to use CMake 3.2 or later to enable this feature.
11562 * DumpRenderTree/CMakeLists.txt: Specified a target name for
11563 GENERATE_BINDINGS. Added dependency for the target.
11564 * WebKitTestRunner/CMakeLists.txt: Ditto.
11566 2016-10-20 Manuel Rego Casasnovas <rego@igalia.com>
11568 [GTK] Cannot build GTK+ with CUPS 2.* versions
11569 https://bugs.webkit.org/show_bug.cgi?id=163591
11571 Reviewed by Michael Catanzaro.
11573 GTK+ is wrongly checking about the available CUPS version,
11574 so if you have CUPS 2.* the configure step fails.
11576 This has been already fixed upstream and included in 2.30 series:
11577 https://git.gnome.org/browse/gtk+/commit/?id=631f6b536485829a0bd00532f5826ad302b4951b
11579 Added patch on JHBuild so we can now build GTK+ with CUPS 2.*.
11581 * gtk/jhbuild.modules: Applied patch and avoid using "configure" script directly
11582 as the patch modifies "configure.ac".
11583 * gtk/patches/configure-fix-detecting-CUPS-2.x.patch: Added.
11585 2016-10-20 Manuel Rego Casasnovas <rego@igalia.com>
11587 [GTK] Bump glib to 2.50.1
11588 https://bugs.webkit.org/show_bug.cgi?id=163689
11590 Reviewed by Michael Catanzaro.
11592 This is need in order to fix GTK+ build with CUPS 2.* (bug #163591).
11594 * gtk/jhbuild.modules: Bump glib version. Pass --disable-libmount to build properly.
11595 Also we don't need the patches anymore.
11596 * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Removed.
11597 * gtk/patches/glib-warning-fix.patch: Removed.
11599 2016-10-19 Alex Christensen <achristensen@webkit.org>
11601 Re-enable URLParser for non-Safari Cocoa apps after r207321
11602 https://bugs.webkit.org/show_bug.cgi?id=163690
11604 Reviewed by Darin Adler.
11606 * DumpRenderTree/mac/DumpRenderTree.mm:
11607 (DumpRenderTreeMain):
11608 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
11609 (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
11610 * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
11611 (TestWebKitAPI::TEST):
11612 * WebKitTestRunner/TestController.cpp:
11613 (WTR::TestController::TestController):
11615 2016-10-19 Ryan Haddad <ryanhaddad@apple.com>
11617 Unreviewed, rolling out r207557.
11619 This change caused animations/font-variations tests to time
11620 out on pre-Sierra Macs.
11622 Reverted changeset:
11624 "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
11626 https://bugs.webkit.org/show_bug.cgi?id=163374
11627 http://trac.webkit.org/changeset/207557
11629 2016-10-19 Andy Estes <aestes@apple.com>
11631 Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type
11632 https://bugs.webkit.org/show_bug.cgi?id=163476
11633 <rdar://problem/26941395>
11635 Reviewed by Andreas Kling.
11637 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11638 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added.
11639 (TEST): Added an API test that passes a nil MIMEType to
11640 -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:].
11642 2016-10-19 Jer Noble <jer.noble@apple.com>
11644 Modify testrunner to mute audio during tests
11645 https://bugs.webkit.org/show_bug.cgi?id=162582
11647 Reviewed by Alexey Proskuryakov.
11649 * DumpRenderTree/mac/DumpRenderTree.mm:
11650 (createWebViewAndOffscreenWindow):
11651 * WebKitTestRunner/TestController.cpp:
11652 (WTR::TestController::resetStateToConsistentValues):
11654 2016-10-19 Joseph Pecoraro <pecoraro@apple.com>
11656 check-webkit-style: fix false-positive warnings about using #pragma once header guard
11657 https://bugs.webkit.org/show_bug.cgi?id=163575
11659 Reviewed by Brady Eidson.
11661 There were some false positive warnings about header guards
11662 for ObjC headers that don't need guards. This changes the
11663 style checker to no longer warn if there is no #pragma once.
11664 It only warns if there are #ifndef that should be #pragma once.
11666 * Scripts/webkitpy/style/checkers/cpp.py:
11667 (check_for_header_guard):
11668 Change when we output an error.
11670 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
11671 (CppStyleTest.test_build_header_guard):
11674 2016-10-19 Myles C. Maxfield <mmaxfield@apple.com>
11676 [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
11677 https://bugs.webkit.org/show_bug.cgi?id=163374
11679 Reviewed by Darin Adler.
11681 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
11683 2016-10-18 Philippe Normand <pnormand@igalia.com>
11685 WebRTC: [GTK] Update jhbuild environment for OpenWebRTC
11686 https://bugs.webkit.org/show_bug.cgi?id=163330
11688 Reviewed by Michael Catanzaro.
11690 Bring back the openwebrtc JHBuild moduleset in the time being. It
11691 should be removed after the bump to GStreamer 1.10 is complete and
11692 the libnice patches have been upstreamed. The GStreamer git
11693 snapshots used in this patch are the ones configured in Ericsson's
11694 GStreamer Cerbero fork.
11696 * gtk/openwebrtc.modules: Added.
11697 * gtk/patches/libnice-0001-TURN-allow-REALM-to-be-empty.patch: Added.
11698 * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Added.
11699 * gtk/patches/libnice-0001-nicesrc-spin-the-agent-mainloop-in-a-separate-thread.patch: Added.
11700 * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Added.
11701 * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Added.
11702 * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Added.
11703 * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Added.
11705 2016-10-18 Sam Weinig <sam@webkit.org>
11707 Replace std::experimental::variant with WTF::Variant (or similar)
11708 https://bugs.webkit.org/show_bug.cgi?id=163626
11710 Reviewed by Chris Dumez.
11712 Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
11713 into the WTF namespace.
11715 * TestWebKitAPI/Tests/WTF/Variant.cpp:
11716 (TestWebKitAPI::TEST):
11718 2016-10-18 Simon Fraser <simon.fraser@apple.com>
11720 Add a MiniBrowser menu item to apply page scale in WK1 and WK2
11721 https://bugs.webkit.org/show_bug.cgi?id=163627
11723 Reviewed by Dean Jackson.
11725 Rename setScale: to setViewScale: and add setPageScale:, hooking it up for WK1 (via exisiting SPI)
11726 and WK2 (via new SPI).
11728 * MiniBrowser/mac/BrowserWindowController.h:
11729 * MiniBrowser/mac/BrowserWindowController.m:
11730 (-[BrowserWindowController pageScaleForMenuItemTag:]):
11731 (-[BrowserWindowController setPageScale:]):
11732 (-[BrowserWindowController setViewScale:]):
11733 (-[BrowserWindowController setScale:]): Deleted.
11734 * MiniBrowser/mac/MainMenu.xib:
11735 * MiniBrowser/mac/WK1BrowserWindowController.m:
11736 (-[WK1BrowserWindowController setPageScale:]):
11737 (-[WK1BrowserWindowController setViewScale:]):
11738 (areEssentiallyEqual):
11739 (-[WK1BrowserWindowController validateMenuItem:]):
11740 (-[WK1BrowserWindowController setScale:]): Deleted.
11741 * MiniBrowser/mac/WK2BrowserWindowController.m:
11742 (-[WK2BrowserWindowController setPageScale:]):
11743 (-[WK2BrowserWindowController viewScaleForMenuItemTag:]):
11744 (-[WK2BrowserWindowController setViewScale:]):
11745 (areEssentiallyEqual):
11746 (-[WK2BrowserWindowController validateMenuItem:]):
11747 (viewScaleForMenuItemTag): Deleted.
11748 (-[WK2BrowserWindowController setScale:]): Deleted.
11750 2016-10-18 Anders Carlsson <andersca@apple.com>
11752 Add an beforeunload alert to the WebKitLegacy MiniBrowser
11753 https://bugs.webkit.org/show_bug.cgi?id=163634
11755 Reviewed by Sam Weinig.
11757 * MiniBrowser/mac/WK1BrowserWindowController.m:
11758 (-[WK1BrowserWindowController webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]):
11760 2016-10-18 Commit Queue <commit-queue@webkit.org>
11762 Unreviewed, rolling out r207443.
11763 https://bugs.webkit.org/show_bug.cgi?id=163616
11765 "Caused 5% PLT regression" (Requested by krollin on #webkit).
11767 Reverted changeset:
11769 "Crash in ASCIICaseInsensitiveHash::hash() when a response has
11771 https://bugs.webkit.org/show_bug.cgi?id=163476
11772 http://trac.webkit.org/changeset/207443
11774 2016-10-18 Eric Carlson <eric.carlson@apple.com>
11776 [MediaStream] Resolve constraints and enumerate devices in the UI process
11777 https://bugs.webkit.org/show_bug.cgi?id=162147
11778 <rdar://problem/28803569>
11780 Reviewed by Darin Adler.
11782 * WebKitTestRunner/TestController.cpp:
11783 (WTR::TestController::resetPreferencesToConsistentValues): Enable mock capture devices.
11784 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update for API changes.
11786 2016-10-17 Megan Gardner <megan_gardner@apple.com>
11788 Add test and infrastructure for link popover
11789 https://bugs.webkit.org/show_bug.cgi?id=163406
11791 Reviewed by Simon Fraser.
11793 Added functionality test for link popovers.
11794 Can query for what URL is loaded, and that the popover has appeared or has
11796 Added a link popover test.
11798 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
11799 (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
11800 (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
11801 (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
11802 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
11803 * TestRunnerShared/UIScriptContext/UIScriptContext.h:
11804 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
11805 (WTR::UIScriptController::setDidShowForcePressPreviewCallback):
11806 (WTR::UIScriptController::didShowForcePressPreviewCallback):
11807 (WTR::UIScriptController::setDidDismissForcePressPreviewCallback):
11808 (WTR::UIScriptController::didDismissForcePressPreviewCallback):
11809 (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
11810 (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
11811 (WTR::UIScriptController::didEndFormControlInteractionCallback): Deleted.
11812 (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
11813 * TestRunnerShared/UIScriptContext/UIScriptController.h:
11814 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
11815 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
11816 (-[TestRunnerWKWebView dealloc]):
11817 (-[TestRunnerWKWebView didShowForcePressPreview]):
11818 (-[TestRunnerWKWebView didDismissForcePressPreview]):
11819 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
11820 (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
11821 (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
11822 (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
11824 2016-10-17 Tim Horton <timothy_horton@apple.com>
11826 REGRESSION (r169805): WKWebView canGoBack returning YES when nothing is in the back-forward list after restoring session state
11827 https://bugs.webkit.org/show_bug.cgi?id=163573
11828 <rdar://problem/28744549>
11830 Reviewed by Dan Bernstein.
11832 * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
11834 Add a test ensuring that canGoBack returns NO after restoring session state without navigating.
11836 2016-10-17 Andy Estes <aestes@apple.com>
11838 Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type
11839 https://bugs.webkit.org/show_bug.cgi?id=163476
11840 <rdar://problem/26941395>
11842 Reviewed by Tim Horton.
11844 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11845 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added.
11846 (TEST): Added an API test that passes a nil MIMEType to
11847 -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:].
11849 2016-10-17 Dean Jackson <dino@apple.com>
11851 Allow creation of ExtendedColors and make Color immutable
11852 https://bugs.webkit.org/show_bug.cgi?id=163557
11853 <rdar://problem/28805360>
11855 Reviewed by Darin Adler and Dave Hyatt.
11857 API tests for ExtendedColor.
11859 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11860 * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp: Added.
11861 (TestWebKitAPI::TEST):
11862 (TestWebKitAPI::makeColor):
11864 2016-10-17 JF Bastien <jfbastien@apple.com>
11866 WebAssembly JS API: implement basic stub
11868 Implement the global WebAssembly JavaScript object, and its constructor +
11869 function properties as described in:
11870 https://github.com/WebAssembly/design/blob/master/JS.md
11872 These don't do anything at the moment, the parent bug will take care of adding
11873 more functionality and associated tests.
11875 WebAssembly JS API: implement basic stub
11876 https://bugs.webkit.org/show_bug.cgi?id=163404
11878 Reviewed by Keith Miller.
11880 * Scripts/run-jsc-stress-tests: use the new JSC option which exposes the WebAssembly object.
11882 2016-10-17 Fujii Hironori <Hironori.Fujii@sony.com>
11884 resolve-ChangeLogs: Specify --no-page to git diff
11885 https://bugs.webkit.org/show_bug.cgi?id=163441
11887 Reviewed by Darin Adler.
11889 resolve-ChangeLogs shows the result after resolving by invoking
11890 'git diff'. It runs a pager for every ChangeLog if it is under
11893 * Scripts/resolve-ChangeLogs:
11894 (showStatus): Specify '--no-page' to git diff.
11896 2016-10-17 Michael Catanzaro <mcatanzaro@igalia.com>
11898 Move user agent quirks to cross-platform location
11899 https://bugs.webkit.org/show_bug.cgi?id=163508
11901 Reviewed by Carlos Garcia Campos.
11903 Move the test to a cross-platform location and improve it to better check the full list of
11904 sites we have defined quirks for.
11906 * TestWebKitAPI/PlatformGTK.cmake:
11907 * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp.
11908 (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
11909 (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
11910 (TestWebKitAPI::TEST):
11912 2016-10-17 Carlos Garcia Campos <cgarcia@igalia.com>
11914 [SOUP] Downloads should always sniff contents
11915 https://bugs.webkit.org/show_bug.cgi?id=163538
11917 Reviewed by Michael Catanzaro.
11919 Add a test case to check that the MIME type is correctly guessed for downloads.
11921 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
11924 (testDownloadMIMEType):
11926 (writeNextChunkIdle): Deleted.
11928 2016-10-16 Daniel Bates <dabates@apple.com>
11930 Fix Perl warning about masked variable following <http://trac.webkit.org/changeset/207382>
11931 (https://bugs.webkit.org/show_bug.cgi?id=163456)
11933 * Scripts/prepare-ChangeLog:
11934 (actuallyGenerateFunctionLists):
11936 2016-10-16 Carlos Garcia Campos <cgarcia@igalia.com>
11938 Unreviewed. Fix GTK+ unit test /webkit2/WebKitWebContext/languages after r206949.
11940 After r206949 navigator.language returns en-US instead of en-us. Language tags in Accept-Language header are
11941 actually case-insensitive, so we should actually do case-insensitive comparisons, but we only have
11942 g_assert_cmpstr for tests.
11944 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
11945 (testWebContextLanguages):
11947 2016-10-16 Carlos Garcia Campos <cgarcia@igalia.com>
11949 [GTK] WebKitWebPage URI not updated after URI is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
11950 https://bugs.webkit.org/show_bug.cgi?id=163389
11952 Reviewed by Michael Catanzaro.
11954 Update /webkit2/WebKitWebPage/get-uri test to check that web view and page uri always match even when request is
11955 modified by WebKitWebPage::send-request signal.
11957 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
11960 2016-10-16 Carlos Garcia Campos <cgarcia@igalia.com>
11962 Document request not updated after willSendRequest is called for a redirect
11963 https://bugs.webkit.org/show_bug.cgi?id=163436
11965 Reviewed by Michael Catanzaro.
11967 Update /webkit2/WebKitWebView/active-uri test to check the active URI also when modified by
11968 WebKitPage::send-request signal in a web extension.
11970 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
11971 (testWebViewActiveURI):
11973 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
11974 (sendRequestCallback):
11975 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
11976 (loadChangedCallback):
11978 2016-10-15 Dan Bernstein <mitz@apple.com>
11980 REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
11981 https://bugs.webkit.org/show_bug.cgi?id=163492
11982 <rdar://problem/28654799>
11984 Reviewed by Darin Adler.
11986 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11987 * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm: Added.
11988 (-[ContextMenuDefaultItemsHaveTagsDelegate webView:didFinishLoadForFrame:]):
11989 (TestWebKitAPI::TEST):
11991 2016-10-15 Daniel Bates <dabates@apple.com>
11993 prepare-ChangeLog erroneously said that a python __init__ method was deleted
11994 https://bugs.webkit.org/show_bug.cgi?id=163456
11996 Reviewed by Simon Fraser.
11998 Fixes an issue where prepare-ChangeLog may list as deleted functions that are
11999 immediately above added code.
12001 Currently prepare-ChangeLog makes use of the same overlap detection algorithm
12002 to compute the list of deleted functions as it does to compute added and modified
12003 functions. We consider a function deleted if its entire function body and signature
12004 are removed. It is sufficient to compare the list of functions before the patch
12005 is applied and the list of functions are the patch is applied to identify
12008 * Scripts/prepare-ChangeLog: Fix some style nits, including using Camel Case for
12010 (actuallyGenerateFunctionLists): Modified to call computeModifiedFunctions(). Always
12011 compute the list of functions in the file after the patch regardless of whether the
12012 patch only contains deletions. We will compare this list against the list of functions
12013 before the patch was applied to determine the deleted functions.
12014 (computeModifiedFunctions): Renamed; formerly named generateFunctionListsByRanges.
12015 Removed out argument for the seen functions as we no longer make use of when computing
12016 the list of deleted functions.
12017 (diffCommand): Update comment.
12018 (generateFunctionListsByRanges): Deleted.
12019 * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added more unit tests.
12021 2016-10-14 Simon Fraser <simon.fraser@apple.com>
12023 REGRESSION (r206973): Running "webkit-patch suggest-reviewers" throws an AttributeError: 'NoneType' object has no attribute 'full_name'
12024 https://bugs.webkit.org/show_bug.cgi?id=163478
12026 Reviewed by Daniel Bates.
12028 Handle a None other in Contributor.__eq__.
12030 * Scripts/webkitpy/common/config/committers.py:
12031 (Contributor.__eq__):
12033 2016-10-14 JF Bastien <jfbastien@apple.com>
12035 Basic WebAssembly testing
12037 Create a small DSL in JavaScript which can build WebAssembly binary modules based on the JSON description of the format as described in:
12038 https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md
12040 This DSL can then be used to write small text description of valid and invalid WebAssembly binaries, making testing the JSC implementation much easier.
12042 Details and example in README.md.
12044 Basic WebAssembly testing
12045 https://bugs.webkit.org/show_bug.cgi?id=163267
12047 Reviewed by Keith Miller.
12049 * Scripts/run-javascriptcore-tests:
12050 (runJSCStressTests): run wasm.yaml tests
12051 * Scripts/run-jsc-stress-tests: add a WebAssembly-specific runner
12053 2016-10-14 Simon Fraser <simon.fraser@apple.com>
12055 Annotate bots in contributors.json and don't show them on webkit.org/team
12056 https://bugs.webkit.org/show_bug.cgi?id=163317
12058 Reviewed by Daniel Bates.
12060 Add "class" : "bot" for non-humans in contributors.json and round-trip it.
12062 * Scripts/webkitpy/common/config/committers.py:
12063 (Contributor.__init__):
12064 (Contributor.as_dict):
12067 (CommitterList.load_json):
12068 * Scripts/webkitpy/common/config/contributors.json:
12070 2016-10-14 Simon Fraser <simon.fraser@apple.com>
12072 Fix printing in WK2 MiniBrowser
12073 https://bugs.webkit.org/show_bug.cgi?id=163455
12075 Reviewed by Tim Horton.
12077 Call the basic -_printOperationWithPrintInfo: which doens't require a frame argument.
12079 * MiniBrowser/mac/WK2BrowserWindowController.m:
12080 (-[WK2BrowserWindowController printWebView:]):
12082 2016-10-14 Commit Queue <commit-queue@webkit.org>
12084 Unreviewed, rolling out r207335.
12085 https://bugs.webkit.org/show_bug.cgi?id=163445
12087 WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing
12088 out on Mac bots (Requested by youenn on #webkit).
12090 Reverted changeset:
12092 "Add ProvisionalURLAfterWillSendRequestCallback.cpp and
12093 ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac
12095 https://bugs.webkit.org/show_bug.cgi?id=163440
12096 http://trac.webkit.org/changeset/207335
12098 2016-10-14 Youenn Fablet <youenn@apple.com>
12100 Add ProvisionalURLAfterWillSendRequestCallback.cpp and ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac builds
12101 https://bugs.webkit.org/show_bug.cgi?id=163440
12105 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Adding new test files introduced in
12106 https://bugs.webkit.org/show_bug.cgi?id=146306 patch.
12108 2016-10-13 Carlos Garcia Campos <cgarcia@igalia.com>
12110 Unreviewed. Removed myself from BindingsScripts watch list.
12112 * Scripts/webkitpy/common/config/watchlist:
12114 2016-10-13 Carlos Garcia Campos <cgarcia@igalia.com>
12116 WebView and WebPage URLs not updated after URL is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
12117 https://bugs.webkit.org/show_bug.cgi?id=146306
12119 Reviewed by Darin Adler.
12121 Add unit test to check that the committed URL is updated when changed in willSendRequest callback.
12123 * TestWebKitAPI/CMakeLists.txt:
12124 * TestWebKitAPI/PlatformEfl.cmake:
12125 * TestWebKitAPI/PlatformGTK.cmake:
12126 * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp: Added.
12127 (TestWebKitAPI::didCommitLoadForFrame):
12128 (TestWebKitAPI::TEST):
12129 * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp: Added.
12130 (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::ProvisionalURLAfterWillSendRequestCallbackTest):
12131 (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::willSendRequestForFrame):
12132 (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::didCommitLoadForFrame):
12134 2016-10-13 Alex Christensen <achristensen@webkit.org>
12136 Hosts of URLs with non-special schemes should be case-sensitive, and non-ASCII characters in such hosts should be punycode-encoded
12137 https://bugs.webkit.org/show_bug.cgi?id=163413
12139 Reviewed by Tim Horton.
12141 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
12142 (TestWebKitAPI::TEST_F):
12143 Update parsing results. There are now fewer differences between the new URLParser and the old URL::parse.
12145 2016-10-13 Alex Christensen <achristensen@webkit.org>
12147 Rebase API tests after r207305.
12149 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12150 Actually build Tests/mac/LoadInvalidURLRequest.mm so we are running the WebKit1.LoadInvalidURLRequest API test.
12151 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
12152 (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
12153 * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
12154 (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
12155 Change results back to what they were before r207162, r207167, and r207184.
12157 2016-10-13 Alex Christensen <achristensen@webkit.org>
12159 Disable URLParser for non-Safari iOS and Mac apps for now
12160 https://bugs.webkit.org/show_bug.cgi?id=163397
12162 Reviewed by Tim Horton.
12164 * DumpRenderTree/mac/DumpRenderTree.mm:
12165 (DumpRenderTreeMain):
12166 * WebKitTestRunner/TestController.cpp:
12167 Enable the URLParser for testing.
12168 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
12169 Link with WebCoreTestSupport so we can find setURLParserEnabled.
12171 2016-10-13 Ryan Haddad <ryanhaddad@apple.com>
12173 Unreviewed, rolling out r207297.
12175 This change broke the iOS build.
12177 Reverted changeset:
12179 "Disable URLParser for non-Safari iOS and Mac apps for now"
12180 https://bugs.webkit.org/show_bug.cgi?id=163397
12181 http://trac.webkit.org/changeset/207297
12183 2016-10-13 Alex Christensen <achristensen@webkit.org>
12185 Disable URLParser for non-Safari iOS and Mac apps for now
12186 https://bugs.webkit.org/show_bug.cgi?id=163397
12188 Reviewed by Tim Horton.
12190 * DumpRenderTree/mac/DumpRenderTree.mm:
12191 (DumpRenderTreeMain):
12192 * WebKitTestRunner/ios/mainIOS.mm:
12194 * WebKitTestRunner/mac/main.mm:
12197 2016-10-12 Alex Christensen <achristensen@webkit.org>
12199 Fix out-of-bounds reading in URLParser when parsing improperly percent-encoded values
12200 https://bugs.webkit.org/show_bug.cgi?id=163376
12202 Reviewed by Saam Barati.
12204 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
12205 (TestWebKitAPI::TEST_F):
12207 2016-10-11 Dean Jackson <dino@apple.com>
12209 Add preliminary support for extended colors to WebCore::Color
12210 https://bugs.webkit.org/show_bug.cgi?id=162878
12211 <rdar://problem/28596413>
12213 Reviewed by Darin Adler.
12215 A new API test for Colors.
12217 * TestWebKitAPI/Tests/WebCore/Color.cpp:
12218 (TestWebKitAPI::TEST):
12220 2016-10-12 Ryan Haddad <ryanhaddad@apple.com>
12222 Unreviewed, rolling out r207225.
12224 This change causes debug tests to exit early with crashes.
12226 Reverted changeset:
12228 "Optional's move-constructor and move-assignment operator
12229 don't disengage the value being moved from"
12230 https://bugs.webkit.org/show_bug.cgi?id=163309
12231 http://trac.webkit.org/changeset/207225
12233 2016-10-12 Alex Christensen <achristensen@webkit.org>
12235 Fix assertion after switching to URLParser
12236 https://bugs.webkit.org/show_bug.cgi?id=163350
12237 rdar://problem/28739938
12239 Reviewed by Brady Eidson.
12241 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
12244 2016-10-11 Sam Weinig <sam@webkit.org>
12246 Optional's move-constructor and move-assignment operator don't disengage the value being moved from
12247 https://bugs.webkit.org/show_bug.cgi?id=163309
12249 Reviewed by Anders Carlsson.
12251 * TestWebKitAPI/Tests/WTF/Optional.cpp:
12252 (TestWebKitAPI::TEST):
12253 Add tests for Optional's move-constructor and move-assignment operator.
12255 2016-10-12 Wenson Hsieh <wenson_hsieh@apple.com>
12257 Now playing media sessions are always cleared for the active foreground tab
12258 https://bugs.webkit.org/show_bug.cgi?id=163310
12259 <rdar://problem/28573301>
12261 Reviewed by Jer Noble.
12263 Tweaks existing unit tests to verify that media session info persists when backgrounding and foregrounding, but
12264 that media session info is correctly cleared out if the media session itself is no longer eligible for Now
12265 Playing (not accounting for foreground/active state). Previously, these tests were verifying that we would
12266 always clear out the information, but this is incorrect, and is the source of the problem.
12268 * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
12269 (-[NowPlayingTestWebView waitForNowPlayingInfoToChange]):
12270 (TestWebKitAPI::TEST):
12272 2016-10-12 Per Arne Vollan <pvollan@apple.com>
12274 [Win] Parallel DRTs are sharing preferences and cache.
12275 https://bugs.webkit.org/show_bug.cgi?id=163013
12277 Reviewed by Brent Fulgham.
12279 Use separate cache and preferences for each DRT instance.
12281 * DumpRenderTree/win/DumpRenderTree.cpp:
12283 (setApplicationId):
12285 (setDefaultsToConsistentValuesForTesting):
12286 * Scripts/webkitpy/port/win.py:
12287 (WinPort.setup_test_run):
12289 2016-10-11 Alex Christensen <achristensen@webkit.org>
12291 Update API test expectation after r207162.
12292 https://bugs.webkit.org/show_bug.cgi?id=162660
12294 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
12295 (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
12296 Like r207167 but with a WebKit2 test.
12297 "https://www.example.com<>/" was an invalid URL with the old URL parser, is now valid with URLParser but not with NSURL's parser.
12299 2016-10-11 Alex Christensen <achristensen@webkit.org>
12301 Update API test expectation after r207162.
12302 https://bugs.webkit.org/show_bug.cgi?id=162660
12304 * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
12305 (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
12306 "https://www.example.com<>/" was an invalid URL with the old URL parser.
12307 It is now a valid URL, but NSURL still considers it invalid.
12308 This will be looked into more with https://bugs.webkit.org/show_bug.cgi?id=163127
12310 2016-10-11 Edward O'Connor <eoconnor@apple.com>
12312 Update my name in contributors.json
12313 https://bugs.webkit.org/show_bug.cgi?id=163251
12315 Reviewed by Simon Fraser.
12317 * Scripts/webkitpy/common/config/contributors.json:
12319 2016-10-11 Said Abou-Hallawa <sabouhallawa@apple.com>
12321 Add SynchronizedFixedQueue class
12322 https://bugs.webkit.org/show_bug.cgi?id=162478
12324 Reviewed by Geoffrey Garen.
12326 Add a new test for SynchronizedFixedQueue. The test defines a new class
12327 called ToUpperConverter which converts strings from lower case to upper
12328 case. It creates two threads : (1) produce thread and (2) consume thread.
12329 Here is what each thread does:
12331 1. Main threads: Enqueues lower case strings into m_lowerQueue.
12332 2. Produce thread: Dequeues lower case strings from m_lowerQueue and
12333 enqueue their upper case strings in the m_upperQueue.
12334 3. Consume thread: Dequeues upper case strings from m_upperQueue.
12336 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12337 * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp: Added.
12338 (TestWebKitAPI::textItem): A helper function which returns a lower case string given an index.
12339 (TestWebKitAPI::toUpper): A helper function which Returns the upper case of a string.
12340 (TestWebKitAPI::ToUpperConverter::ToUpperConverter):
12341 (TestWebKitAPI::ToUpperConverter::produceQueue): Returns a workQueue for the produce thread.
12342 (TestWebKitAPI::ToUpperConverter::consumeQueue): Returns a workQueue for the consume thread.
12343 (TestWebKitAPI::ToUpperConverter::startProducing): Creates a thread for the producer.
12344 (TestWebKitAPI::ToUpperConverter::startConsuming): Creates a thread for the consumer.
12345 (TestWebKitAPI::ToUpperConverter::start): Starts both the producer and the consumer threads.
12346 (TestWebKitAPI::ToUpperConverter::stopProducing): Terminates the producer thread.
12347 (TestWebKitAPI::ToUpperConverter::stopConsuming): Terminates the consumer thread.
12348 (TestWebKitAPI::ToUpperConverter::stop): Terminates both the producer and the consumer threads.
12349 (TestWebKitAPI::ToUpperConverter::enqueueLower): Adds a lower case string to the m_lowerQueue on the main thread.
12350 (TestWebKitAPI::ToUpperConverter::isProducing): Returns whether the producing thread is active.
12351 (TestWebKitAPI::ToUpperConverter::isConsuming): Returns whether the consuming thread is active.
12352 (TestWebKitAPI::ToUpperConverter::produceCount): Returns the number of produced elements.
12353 (TestWebKitAPI::ToUpperConverter::consumeCount): Returns the number of consumed elements.
12354 (TestWebKitAPI::TEST):
12356 2016-10-11 Megan Gardner <megan_gardner@apple.com>
12358 Extend event stream to include interpolated events and add a force press test that uses that interpolation
12359 https://bugs.webkit.org/show_bug.cgi?id=163161
12361 Reviewed by Simon Fraser.
12363 Added functionality to the event stream to allow for interpolated events.
12364 Can now do long press, as well as a better way to do drag and other time-based
12365 events that require a large stream of descrete HID events.
12366 Added a basic force touch test to demostrate this interpolation.
12367 Also updated the script to allow for iPhone 7 specific tests, as force touch
12368 needs to be on a device that had force touch.
12370 * Scripts/webkitpy/port/ios.py:
12371 (IOSSimulatorPort):
12372 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
12373 * WebKitTestRunner/ios/HIDEventGenerator.mm:
12374 (linearInterpolation):
12375 (simpleCurveInterpolation):
12376 (calculateNextCurveLocation):
12378 (interpolationFromString):
12379 (-[HIDEventGenerator eventMaskFromEventInfo:]):
12380 (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
12381 (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
12382 (-[HIDEventGenerator interpolatedEvents:]):
12383 (-[HIDEventGenerator processEventsArray:withStartTime:]):
12384 (-[HIDEventGenerator eventDispatchThreadEntry:]):
12385 (simpleDragCurve): Deleted.
12386 (calculateNextLocation): Deleted.
12388 2016-10-11 Alex Christensen <achristensen@webkit.org>
12390 URLParser should percent-encode non-ASCII and non-printable characters in fragment
12391 https://bugs.webkit.org/show_bug.cgi?id=163287
12393 Reviewed by Brady Eidson.
12395 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
12396 (TestWebKitAPI::TEST_F):
12398 2016-10-11 Alex Christensen <achristensen@webkit.org>
12400 Remove dead networking code
12401 https://bugs.webkit.org/show_bug.cgi?id=163263
12403 Reviewed by Daniel Bates.
12405 * DumpRenderTree/DumpRenderTree.h:
12406 * DumpRenderTree/config.h:
12407 * DumpRenderTree/win/DumpRenderTree.cpp:
12410 2016-10-11 John Wilander <wilander@apple.com>
12412 Modify check-webkit-style to prohibit sensitive phrases
12413 https://bugs.webkit.org/show_bug.cgi?id=163048
12414 <rdar://problem/28289755>
12416 Terms considered or found to be too general to flag:
12417 ASSERT_WITH_SECURITY_IMPLICATION, bad cast, bug, bypass, crash,
12418 denial of service, dereference, disclosure, error, exploit,
12419 failure, heap, integer overflow, leak, null dereference,
12420 null pointer dereference, out of bounds, overflow,
12421 race condition, sensitive information, stack, type confusion.
12423 Reviewed by Brent Fulgham.
12425 * Scripts/webkitpy/style/checkers/changelog.py:
12426 (ChangeLogChecker.check_entry):
12427 Now calls ChangeLogChecker.check_for_unwanted_security_terms().
12428 (ChangeLogChecker):
12429 (ChangeLogChecker.check_for_unwanted_security_terms):
12430 New function to check for sensitive terms.
12431 (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm):
12432 (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm.__init__):
12434 * Scripts/webkitpy/style/checkers/changelog_unittest.py:
12435 (ChangeLogCheckerTest.test_unwanted_security_terms):
12437 2016-10-11 Ryan Haddad <ryanhaddad@apple.com>
12439 Unreviewed, rolling out r207067.
12441 This change caused webkitpy test failures.
12443 Reverted changeset:
12445 "[Win] Parallel DRTs are sharing preferences and cache."
12446 https://bugs.webkit.org/show_bug.cgi?id=163013
12447 http://trac.webkit.org/changeset/207067
12449 2016-10-11 Per Arne Vollan <pvollan@apple.com>
12451 [Win] Parallel DRTs are sharing preferences and cache.
12452 https://bugs.webkit.org/show_bug.cgi?id=163013
12454 Reviewed by Brent Fulgham.
12456 Use separate cache and preferences for each DRT instance.
12458 * DumpRenderTree/win/DumpRenderTree.cpp:
12460 (setApplicationId):
12462 (setDefaultsToConsistentValuesForTesting):
12463 * Scripts/webkitpy/port/win.py:
12464 (WinPort.setup_test_run):
12466 2016-10-10 Zan Dobersek <zdobersek@igalia.com>
12468 Add ENABLE_ENCRYPTED_MEDIA configuration option
12469 https://bugs.webkit.org/show_bug.cgi?id=163219
12471 Reviewed by Darin Adler.
12473 * Scripts/webkitperl/FeatureList.pm:
12474 Make the ENABLE_ENCRYPTED_MEDIA option overridable via build-webkit.
12475 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
12476 Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
12477 to enable or disable the new EME implementation at build-time.
12479 2016-10-10 Commit Queue <commit-queue@webkit.org>
12481 Unreviewed, rolling out r206972.
12482 https://bugs.webkit.org/show_bug.cgi?id=163227
12484 Making EWS flaky (Requested by bfulgham_ on #webkit).
12486 Reverted changeset:
12488 "[CMake] CMake does not support the dep files for implicit
12490 https://bugs.webkit.org/show_bug.cgi?id=161433
12491 http://trac.webkit.org/changeset/206972
12493 2016-10-10 Youenn Fablet <youenn@apple.com>
12495 W3C test downloader should be able to import specific files/sub-directories in a skipped directory
12496 https://bugs.webkit.org/show_bug.cgi?id=161789
12498 Reviewed by Ryosuke Niwa.
12500 Removed tests_directory option and corresponding test.
12501 This option was allowing to import a sub-directory from a test repository.
12502 We can readd it if necessary.
12504 Adding support for finer-grained import rules.
12505 Previously skipped directories were fully removed.
12506 Now, directories may be skipped but sub directories of them may be imported.
12507 This currently happens in web-platform-tests repo.
12509 * Scripts/webkitpy/w3c/test_downloader.py:
12510 (TestDownloader._add_test_suite_paths): Removing tests_directory option.
12511 (TestDownloader.copy_tests): Refactoring file copy by generating the list of all directories for which direct files should be imported.
12512 (TestDownloader.copy_tests.should_copy_dir):
12513 (TestDownloader.copy_tests.should_copy_file):
12514 * Scripts/webkitpy/w3c/test_importer_unittest.py:
12515 (TestImporterTest.test_tests_directory): Deleted.
12516 (TestImporterTest.test_skip_test_import): Added.
12518 2016-10-09 Simon Fraser <simon.fraser@apple.com>
12520 Make validate-committer-lists show inactive reviewers
12521 https://bugs.webkit.org/show_bug.cgi?id=163193
12523 Reviewed by Sam Weinig.
12525 In preparation for updating contributors.json with the WebKit policy of retiring
12526 inactive reviewers, make validate-committer-lists show the list of reviewers who
12527 have not reviewed in the past year.
12529 This list is computed by grepping the output of 'git log --since=1.year" for
12530 the reviewer line, and looking up reviewers via Contributor.mentioned_in_text(),
12531 which looks for full names, aliases, irc nicks and email addresses.
12533 Support for aliases is added to Contributor. Aliases are alternates
12534 or misspellings of the reviewer's name. Some common aliases were added to
12535 contributors.json by manual examination of "Reviewed by" lines.
12537 * Scripts/validate-committer-lists:
12538 (CommitterListFromGit.possibly_expired_committers):
12539 (CommitterListFromGit):
12540 (CommitterListFromGit.possibly_inactive_reviewers):
12541 (CommitterListFromGit.print_possibly_expired_committers):
12542 (CommitterListFromGit.print_possibly_inactive_reviewers):
12543 * Scripts/webkitpy/common/config/committers.py:
12544 (Contributor.__init__):
12545 (Contributor.contains_string):
12546 (Contributor.mentioned_in_text):
12547 (Contributor.as_dict):
12548 (Committer.__init__):
12549 (Reviewer.__init__):
12550 (CommitterList.load_json):
12551 * Scripts/webkitpy/common/config/contributors.json:
12553 2016-10-09 Simon Fraser <simon.fraser@apple.com>
12555 Convert contributors.json to a flat list
12556 https://bugs.webkit.org/show_bug.cgi?id=163183
12558 Reviewed by Darin Adler.
12560 Make contributors.json easier to maintain by eliminating the big groupings ("Committers", "Reviewers" etc)
12561 and moving that data to a "status" property on each contributor.
12563 * Scripts/webkitpy/common/config/committers.py:
12564 (Contributor.__eq__): Implement this to fix unit tests, now that load_json() is not @memoized.
12565 (Contributor.as_dict): Include status in the dict.
12566 (CommitterList.__init__): Clean up to make the testing code path more explicit.
12567 (CommitterList.load_json):
12568 (CommitterList.load_test_data):
12569 (CommitterList.as_json):
12570 (Contributor.__unicode__): Deleted.
12571 * Scripts/webkitpy/common/config/contributors.json:
12572 * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
12573 (IRCCommandTest.test_whois): The ordering here is now alphabetical.
12575 2016-10-09 Fujii Hironori <Hironori.Fujii@sony.com>
12577 [CMake] CMake does not support the dep files for implicit dependency
12578 https://bugs.webkit.org/show_bug.cgi?id=161433
12580 Reviewed by Brent Fulgham.
12582 Created a Perl script to generate all IDL bindings for CMake.
12583 This script can regenerate outdated bindings by based on the
12584 supplemental dependency and dep files created by
12585 '--write-dependencies' switch of generate-bindings.pl.
12587 add_custom_target is used to invoke the script instead of
12588 add_custom_command because Ninja deletes all output files before
12589 executing the command in case of add_custom_command.
12591 USES_TERMINAL option of add_custom_target has two effects:
12592 1) Not buffering output of the command
12593 2) Invoking the command in the special Ninja pool which inhibits parallel build
12594 One needs to use CMake 3.2 or later to enable this feature.
12596 * DumpRenderTree/CMakeLists.txt: Specified a target name for
12597 GENERATE_BINDINGS. Added dependency for the target.
12598 * WebKitTestRunner/CMakeLists.txt: Ditto.
12600 2016-10-09 Simon Fraser <simon.fraser@apple.com>
12602 Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
12603 https://bugs.webkit.org/show_bug.cgi?id=163177
12607 For unknown reasons, overriding Commiter.__dict__() caused mysterious test failures.
12608 Rename it to as_dict().
12610 * Scripts/webkitpy/common/config/committers.py:
12611 (Contributor.as_dict):
12612 (CommitterList._contributor_list_to_dict):
12613 (Contributor.__dict__): Deleted.
12615 2016-10-08 Simon Fraser <simon.fraser@apple.com>
12617 Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
12618 https://bugs.webkit.org/show_bug.cgi?id=163177
12620 Reviewed by Ryosuke Niwa.
12622 Make it possible to round-trip contributors.json through CommitterList, so we can
12623 support writing out contributors.json in canonical format. This requires saving
12624 the case-preserved email and expertise in Contributor. CommitterList also needs
12625 to be able to generate the "exclusive" lists, since it currently uses lists
12626 that are the union of, say, committers and reviewers.
12628 If contributors.json is malformed (invalid JSON), catch the Exception, report it
12629 and exit rather than allowing the exception to propagate. With an invalid file,
12630 an exception would be thrown before the JSON style checker reached this file, so
12631 the error was not correctly reported.
12633 Add style/checker/committer.py for checking that committers.json has the canonical format.
12635 Add support to validate-committer-lists to dump out the canonical json (-d) or update
12636 the file in-place (-c).
12638 * Scripts/validate-committer-lists:
12639 (CommitterListFromGit._print_three_column_row):
12640 (CommitterListFromGit.possibly_expired_committers):
12641 (CommitterListFromGit):
12642 (CommitterListFromGit.print_possibly_expired_committers):
12644 * Scripts/webkitpy/common/config/committers.py:
12645 (Contributor.__init__):
12646 (Contributor.__dict__):
12647 (Committer.__init__):
12648 (Reviewer.__init__):
12649 (CommitterList.load_json):
12651 (CommitterList._contributor_list_to_dict):
12652 (CommitterList.as_json):
12653 (CommitterList.reformat_in_place):
12654 (CommitterList._exclusive_contributors):
12655 (CommitterList._exclusive_committers):
12656 (Contributor.matches_glob): Deleted.
12657 (CommitterList.contributors): Deleted.
12658 * Scripts/webkitpy/common/config/contributors.json:
12659 * Scripts/webkitpy/style/checker.py:
12660 (CheckerDispatcher._create_checker):
12661 * Scripts/webkitpy/style/checkers/contributors.py: Added.
12662 (ContributorsChecker):
12663 (ContributorsChecker.__init__):
12664 (ContributorsChecker.check):
12665 (ContributorsChecker._unidiff_output):
12667 2016-10-06 Darin Adler <darin@apple.com>
12669 Next step on moving to modern way to return DOM exceptions
12670 https://bugs.webkit.org/show_bug.cgi?id=163016
12672 Reviewed by Ryosuke Niwa.
12674 * Scripts/do-webcore-rename: Add proposed name change of setDOMException
12675 to propagateException, since this function is primarily used to take an
12676 exception already effectively "thrown" by setting an ExceptionCode out
12677 argument and propagate it into the JavaScript engine's exception machinery.
12679 2016-10-07 Alex Christensen <achristensen@webkit.org>
12681 Non-special URL fragments should percent-encode non-ASCII characters
12682 https://bugs.webkit.org/show_bug.cgi?id=163153
12684 Reviewed by Tim Horton.
12686 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
12687 (TestWebKitAPI::TEST_F):
12689 2016-10-07 Jonathan Bedard <jbedard@apple.com>
12691 Build fix for “Move functionality common to Darwin ports into a base class”
12692 https://bugs.webkit.org/show_bug.cgi?id=160709
12694 Unreviewed build fix.
12696 * Scripts/webkitpy/port/ios.py:
12697 (IOSSimulatorPort._get_crash_log): Added iOS implementation.
12698 * Scripts/webkitpy/port/mac.py:
12699 (MacPort._get_crash_log): Added Mac implementation.
12701 2016-10-07 Chelsea Pugh <cpugh@apple.com>
12703 Unreviewed. Added myself to the list of committers.
12705 * Scripts/webkitpy/common/config/contributors.json:
12707 2016-10-07 Jonathan Bedard <jbedard@apple.com>
12709 Move functionality common to Darwin ports into a base class
12710 https://bugs.webkit.org/show_bug.cgi?id=160709
12712 Reviewed by Darin Adler.
12714 * Scripts/webkitpy/port/apple.py:
12715 (ApplePort.determine_full_port_name): Specific iOS port check.
12716 (ApplePort.__init__): Move leak detector to DarwinPort.
12717 (ApplePort._make_leak_detector): Moved to DarwinPort.
12718 (ApplePort.supports_per_test_timeout): Moved to Port.
12719 (ApplePort.check_for_leaks): Moved to DarwinPort.
12720 (ApplePort.print_leaks_summary): Moved to DarwinPort.
12721 (ApplePort._path_to_webcore_library): Moved to DarwinPort.
12722 (ApplePort.show_results_html_file): Moved to DarwinPort.
12723 (ApplePort._merge_crash_logs): Moved to DarwinPort.
12724 (ApplePort._look_for_all_crash_logs_in_log_dir): Moved to DarwinPort.
12725 (ApplePort._get_crash_log): Moved to DarwinPort.
12726 (ApplePort.look_for_new_crash_logs): Moved to DarwinPort.
12727 (ApplePort.sample_process): Moved to DarwinPort.
12728 (ApplePort.sample_file_path): Moved to DarwinPort.
12729 (ApplePort.look_for_new_samples): Moved to DarwinPort.
12730 * Scripts/webkitpy/port/base.py:
12731 (Port.supports_per_test_timeout): Return true for all ports.
12732 * Scripts/webkitpy/port/darwin.py: Added.
12733 (DarwinPort): Shared iOS and Mac functions.
12734 * Scripts/webkitpy/port/darwin_testcase.py: Added.
12735 (DarwinTest): Shared iOS and Mac testing.
12736 * Scripts/webkitpy/port/efl.py:
12738 (EflPort.supports_per_test_timeout): Moved to Port.
12739 * Scripts/webkitpy/port/gtk.py:
12740 (GtkPort._driver_class):
12742 (GtkPort.supports_per_test_timeout): Moved to Port.
12743 * Scripts/webkitpy/port/ios.py:
12745 (IOSPort.operating_system):
12746 (IOSSimulatorPort):
12747 (IOSSimulatorPort.__init__): Inherits from DarwinPort.
12748 (IOSSimulatorPort._port_specific_expectations_files): Moved to DarwinPort.
12749 (IOSSimulatorPort._get_crash_log): Deleted.
12750 (IOSSimulatorPort.xcrun_find): Deleted.
12751 * Scripts/webkitpy/port/ios_unittest.py: Added.
12752 (iosTest): Unit tests for the iOS port.
12753 * Scripts/webkitpy/port/mac.py:
12755 (MacPort.__init__): Inherits from DarwinPort.
12756 (MacPort._port_specific_expectations_files): Moved to DarwinPort.
12757 (MacPort.make_command): Moved to DarwinPort.
12758 (MacPort._get_crash_log): Moved to DarwinPort.
12759 (MacPort.nm_command): Moved to DarwinPort.
12760 * Scripts/webkitpy/port/mac_unittest.py:
12762 (MacTest.test_sdk_name): Added test.
12763 (MacTest.test_xcrun): Added test.
12764 (MacTest.assert_skipped_file_search_paths): Moved to DarwinTest.
12765 (MacTest.test_default_timeout_ms): Moved to DarwinTest.
12766 (MacTest.assert_name): Moved to DarwinTest.
12767 (MacTest.test_helper_starts): Moved to DarwinTest.
12768 (MacTest.test_helper_fails_to_start): Moved to DarwinTest.
12769 (MacTest.test_helper_fails_to_stop): Moved to DarwinTest.
12770 (MacTest.test_spindump): Moved to DarwinTest.
12771 (MacTest.test_sample_process): Moved to DarwinTest.
12772 (MacTest.test_sample_process_exception): Moved to DarwinTest.
12773 * Scripts/webkitpy/port/port_testcase.py:
12775 (PortTestCase.test_diff_image): Added is_simulator flag.
12776 (PortTestCase.test_diff_image): Skip test if on a simulator.
12777 (PortTestCase.test_diff_image_crashed): Skip test if on a simulator.
12778 * Scripts/webkitpy/port/win.py:
12780 (WinPort.look_for_new_samples): Used default, ApplePort no longer implements.
12781 (WinPort.sample_process): Ditto.
12782 (WinPort._make_leak_detector): Ditto.
12783 (WinPort.check_for_leaks): Ditto.
12784 (WinPort.print_leaks_summary): Ditto.
12785 (WinPort._path_to_webcore_library): Ditto.
12787 2016-10-07 Anders Carlsson <andersca@apple.com>
12789 Get rid of WKPageSetSession
12790 https://bugs.webkit.org/show_bug.cgi?id=163129
12792 Reviewed by Tim Horton.
12794 Rewrite this test to use WKPageConfigurationRef and WKWebsiteDataStoreRef.
12796 * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
12797 (TestWebKitAPI::TEST):
12799 2016-10-07 Andreas Kling <akling@apple.com>
12801 [WK2] didRemoveFrameFromHierarchy callback doesn't fire for subframes when evicting from PageCache.
12802 <https://webkit.org/b/163098>
12803 <rdar://problem/28663488>
12805 Reviewed by Antti Koivisto.
12807 Add an API test that puts a 10-subframe page into the page cache, then loads other pages
12808 until the first page gets kicked out. The test succeeds if we receive didRemoveFrameFromHierarchy
12809 callbacks for all the subframes.
12811 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12812 * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache.cpp: Added.
12813 (TestWebKitAPI::didFinishLoadForFrame):
12814 (TestWebKitAPI::setPageLoaderClient):
12815 (TestWebKitAPI::didReceivePageMessageFromInjectedBundle):
12816 (TestWebKitAPI::setInjectedBundleClient):
12817 (TestWebKitAPI::TEST):
12818 * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp: Added.
12819 (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
12820 (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::DidRemoveFrameFromHiearchyInPageCacheTest):
12821 (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::didCreatePage):
12822 * TestWebKitAPI/Tests/WebKit2/many-iframes.html: Added.
12824 2016-10-07 Emanuele Aina <emanuele.aina@collabora.com>
12826 Replace bug URL placeholders independently of the short desc one
12827 https://bugs.webkit.org/show_bug.cgi?id=161684
12829 Reviewed by Darin Adler.
12831 Instead of adding the bug URL when replacing the short description
12832 placeholder and then ignoring the bug URL placeholder, use the former
12833 to set the short description and the latter for the bug URL.
12834 This means that developers can fully prepare the changelog with short
12835 and long description before submission leaving the bug placeholder in
12836 place, and the changelog machinery will make sure to replace the
12837 latter with the URL of the newly created bug while submitting.
12839 Note that this also means that the short description placeholder alone
12840 no longer causes the bug URL to be added.
12842 * Scripts/webkitpy/common/checkout/changelog.py:
12843 (ChangeLog.set_short_description_and_bug_url):
12844 * Scripts/webkitpy/common/checkout/changelog_unittest.py:
12845 (test_set_short_description_and_bug_url):
12847 2016-10-07 Jonathan Bedard <jbedard@apple.com>
12849 Style Checking Error when Objective C Blocks passed as Argument
12850 https://bugs.webkit.org/show_bug.cgi?id=162463
12852 Reviewed by Darin Adler.
12854 * Scripts/webkitpy/style/checkers/cpp.py:
12855 (regex_for_lambdas_and_blocks): Consider case where block is passed as a function argument.
12856 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
12857 (CppStyleTest.test_objective_c_block_as_argument): Test case where block is passed as a function argument.
12859 2016-10-07 Philippe Normand <pnormand@igalia.com>
12861 [GTK] Docs build failure
12862 https://bugs.webkit.org/show_bug.cgi?id=163102
12864 Reviewed by Carlos Garcia Campos.
12866 * gtk/jhbuild.modules: Bump to gtk-doc 1.25 to fix build errors on Debian Testing.
12868 2016-10-06 Joseph Pecoraro <pecoraro@apple.com>
12870 check-webkit-style: Enable the legal/copyright rule for cpp/h files
12871 https://bugs.webkit.org/show_bug.cgi?id=162707
12873 Reviewed by Darin Adler.
12875 * Scripts/webkitpy/style/checker.py:
12876 Enable this rule by default.
12878 2016-10-06 Joseph Pecoraro <pecoraro@apple.com>
12880 Header guard style should be updated to be "#pragma once"
12881 https://bugs.webkit.org/show_bug.cgi?id=159785
12883 Reviewed by Darin Adler.
12885 * Scripts/webkitpy/style/checkers/cpp.py:
12886 (check_for_header_guard):
12888 Simplify header_guard check to warn for a missing #pragma once
12889 in header files. For legacy files that contain an #ifndef only
12890 warn if the #ifndef line itself is changing.
12892 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
12893 (CppStyleTestBase.perform_header_guard_check):
12894 (CppStyleTestBase.assert_header_guard):
12895 Helpers for enabling just this warning.
12897 (CppStyleTest.test_build_header_guard):
12898 Test different header guard cases.
12900 * Scripts/webkitpy/style/error_handlers.py:
12901 (DefaultStyleErrorHandler.should_line_be_checked):
12902 Always allow warnings that output for "line 0" which won't be in
12903 the list of modified lines that are 1-based.
12905 2016-10-06 Commit Queue <commit-queue@webkit.org>
12907 Unreviewed, rolling out r206713.
12908 https://bugs.webkit.org/show_bug.cgi?id=163097
12910 triggers apparent codegen bug on ARM 32-bit (Requested by smfr
12913 Reverted changeset:
12915 "Support transitions/animations of background-position with
12916 right/bottom-relative values"
12917 https://bugs.webkit.org/show_bug.cgi?id=162048
12918 http://trac.webkit.org/changeset/206713
12920 2016-10-06 Alex Christensen <achristensen@webkit.org>
12922 URLParser: Non-ASCII characters in Non-UTF-8 encoded queries of relative URLs with ws, wss, or nonspecial schemes should be UTF-8 encoded
12923 https://bugs.webkit.org/show_bug.cgi?id=163089
12925 Reviewed by Tim Horton.
12927 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
12928 (TestWebKitAPI::checkURL):
12929 (TestWebKitAPI::TEST_F):
12931 2016-10-06 Alex Christensen <achristensen@webkit.org>
12933 Skip tabs and newlines between end of query and beginning of fragment in non-UTF-8-encoded URLs
12934 https://bugs.webkit.org/show_bug.cgi?id=163071
12936 Reviewed by Tim Horton.
12938 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
12939 (TestWebKitAPI::TEST_F):
12941 2016-10-06 Alex Christensen <achristensen@webkit.org>
12943 URLParser should parse file URLs with ports consistently
12944 https://bugs.webkit.org/show_bug.cgi?id=163075
12946 Reviewed by Brady Eidson.
12948 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
12949 (TestWebKitAPI::TEST_F):
12951 2016-10-06 John Wilander <wilander@apple.com>
12953 Update Resource Load Statistics
12954 https://bugs.webkit.org/show_bug.cgi?id=162811
12956 Reviewed by Alex Christensen.
12958 * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
12959 Change from USE(PUBLIC_SUFFIX_LIST) to ENABLE(PUBLIC_SUFFIX_LIST)
12961 2016-10-05 Philippe Normand <pnormand@igalia.com>
12963 [GStreamer][OWR] GL rendering support
12964 https://bugs.webkit.org/show_bug.cgi?id=162972
12966 Reviewed by Žan Doberšek.
12968 When GStreamer-GL is enabled the GL context needs to be properly passed
12969 to the GStreamer pipeline running within the OpenWebRTC video renderer.
12970 This is now supported using a new OpenWebRTC API that allows the
12971 renderer to request the context from the application using a callback
12972 registered within the renderer.
12974 * gtk/jhbuild.modules: Bump to latest OpenWebRTC for the new
12975 owr_video_renderer_set_request_context_callback API added
12978 2016-10-05 Youenn Fablet <youenn@apple.com>
12980 Reuse CodeGenerator::UpdateFile in Tools CodeGenerator
12981 https://bugs.webkit.org/show_bug.cgi?id=162960
12983 Reviewed by Alex Christensen.
12985 * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
12986 (WriteData): Using CodeGenerator::UpdateFile to do lazy generated file update when it is made feasible.
12987 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
12988 (WriteData): Ditto.
12990 2016-10-05 Alex Christensen <achristensen@webkit.org>
12992 URLParser should parse IPv4 addresses as the last two pieces of an IPv6 address
12993 https://bugs.webkit.org/show_bug.cgi?id=162991
12995 Reviewed by Saam Barati.
12997 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
12998 (TestWebKitAPI::TEST_F):
13000 2016-10-05 Tim Horton <timothy_horton@apple.com>
13002 Avoid automatically re-taking snapshots for back-forward items that were never loaded into the view
13003 https://bugs.webkit.org/show_bug.cgi?id=162955
13004 <rdar://problem/27659173>
13006 Reviewed by Simon Fraser.
13008 * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
13009 (-[SnapshotTestWKWebView init]):
13010 (forceRepaintCallback):
13011 (-[SnapshotTestWKWebView synchronouslyForceRepaint]):
13012 (-[SnapshotTestWKWebView synchronouslyLoadTestPageAndForceRepaint:]):
13014 (makeRedSquareView):
13015 Add a test that restoring session state into a web view without navigating,
13016 then explicitly snapshotting and navigating away, leaves the original snapshot alone.
13018 Adjust the existing test, as well, to ensure that it will reliably fail
13019 if the feature is broken. Use an explicitly added and removed red square
13020 instead of scrolling, because we can't scroll in the restore-without-navigating case.
13022 Stop trying to override the window scale, because it's not working (we're getting partial snapshots)
13023 and isn't necessary; instead just multiply the expected value by the page scale.
13025 (-[SnapshotTestWKWebView loadPageNamed:]): Deleted.
13026 * TestWebKitAPI/mac/TestWKWebViewMac.h:
13027 * TestWebKitAPI/mac/TestWKWebViewMac.mm:
13028 (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
13029 Reorganize to reduce duplication.
13031 2016-10-05 Tim Horton <timothy_horton@apple.com>
13033 Make it possible to test ViewSnapshotStore behaviors
13034 https://bugs.webkit.org/show_bug.cgi?id=162983
13036 Reviewed by Simon Fraser.
13038 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13039 * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm: Added.
13040 (-[SnapshotTestWKWebView init]):
13041 (-[SnapshotTestWKWebView loadPageNamed:]):
13043 Add tests for existing basic snapshotting behavior:
13045 - a back-forward item shouldn't have a snapshot
13046 until it is navigated away from
13048 - causing a back-forward item to fall out of the
13049 back-forward list should remove the snapshot
13051 - calling the explicit snapshotting SPI, then navigating away from the page,
13052 should result in the snapshot being retaken
13054 2016-10-05 Chris Dumez <cdumez@apple.com>
13056 KeyboardEvent.getModifierState() should support "CapsLock" modifier
13057 https://bugs.webkit.org/show_bug.cgi?id=162861
13059 Reviewed by Darin Adler.
13061 Add support for 'capsLockKey' modifier for EventSender.keyDown() so
13062 that we can test this new modifier support for layout tests.
13064 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
13065 (TestWebKitAPI::modifierFlagsForWKModifiers):
13066 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
13067 (WTR::parseModifier):
13068 * WebKitTestRunner/mac/EventSenderProxy.mm:
13069 (WTR::buildModifierFlags):
13071 2016-10-05 Jeremy Jones <jeremyj@apple.com>
13073 Add MobileMiniBrowser tests for control center and looping fullscreen.
13074 https://bugs.webkit.org/show_bug.cgi?id=162748
13076 Reviewed by Jer Noble.
13078 Refactor existing MobileMiniBrowserTests and add new tests for
13079 - fullscreen rotation
13080 - fullscreen looping (failing)
13081 - control center interruption (failing)
13083 * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
13084 * MobileMiniBrowser/MobileMiniBrowserFramework/Resources/looping2s.html: Added.
13085 * MobileMiniBrowser/MobileMiniBrowserFramework/test2s.mp4: Added.
13086 * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
13087 (-[MobileMiniBrowserUITests setUp]):
13088 (-[MobileMiniBrowserUITests waitToTapButtonNamed:forApp:]):
13089 (-[MobileMiniBrowserUITests loadURL:]):
13090 (-[MobileMiniBrowserUITests requireMinFPS:sampleDurationSeconds:message:]):
13091 (-[MobileMiniBrowserUITests ensureFullscreenControls]):
13092 (-[MobileMiniBrowserUITests timeForTimeString:]):
13093 (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
13094 (-[MobileMiniBrowserUITests testBasicVideoFullscreen]):
13095 (-[MobileMiniBrowserUITests testVideoFullscreenAndRotationAnimation]):
13096 (-[MobileMiniBrowserUITests testVideoFullscreenControlCenter]):
13097 (-[MobileMiniBrowserUITests testLoopingFullscreenLockup]):
13099 2016-10-05 Alex Christensen <achristensen@webkit.org>
13101 URLParser should correctly strip unnecessary 0's in IPv6 addresses
13102 https://bugs.webkit.org/show_bug.cgi?id=162979
13104 Reviewed by Brady Eidson.
13106 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13107 (TestWebKitAPI::TEST_F):
13109 2016-10-05 Alex Christensen <achristensen@webkit.org>
13111 UTF-8 encode queries of nonspecial and websocket schemes
13112 https://bugs.webkit.org/show_bug.cgi?id=162956
13114 Reviewed by Geoffrey Garen and Brady Eidson.
13116 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13117 (TestWebKitAPI::TEST_F):
13119 2016-10-05 Alex Christensen <achristensen@webkit.org>
13121 Prepare to enable URLParser
13122 https://bugs.webkit.org/show_bug.cgi?id=162974
13124 Reviewed by Brady Eidson.
13126 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13127 (TestWebKitAPI::TEST_F):
13128 Added some tests that are unrelated to the code change, but these are
13129 reflected in changed LayoutTest results when enabling the URLParser,
13130 and they weren't in the URLParser tests yet. They should be.
13132 2016-10-05 Zan Dobersek <zdobersek@igalia.com>
13134 Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
13135 https://bugs.webkit.org/show_bug.cgi?id=162903
13137 Reviewed by Alex Christensen.
13139 Rename build guards for the remaining implementation of the legacy EME API
13140 to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
13141 of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
13143 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Also remove the
13144 ENABLE_IOS_TEXT_AUTOSIZING feature define that was renamed in r206395 and was
13145 throwing up style checker errors.
13147 2016-10-04 Andy Estes <aestes@apple.com>
13149 [iOS] Crash in WebResourceLoaderQuickLookDelegate when the client cancels the navigation to a QuickLook resource
13150 https://bugs.webkit.org/show_bug.cgi?id=162950
13151 <rdar://problem/23759114>
13153 Reviewed by Brady Eidson.
13155 Added a new API test.
13157 * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Sorted imports and removed redundant
13158 initialization of static bools.
13159 (runTest): Factored out the common test logic between QuickLook.NavigationDelegate and
13160 QuickLook.CancelNavigationAfterResponse.
13161 (TEST): Added QuickLook.CancelNavigationAfterResponse.
13162 (-[QuickLookDecidePolicyDelegate
13163 webView:decidePolicyForNavigationResponse:decisionHandler:]): Canceled the navigation.
13164 (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Set
13167 2016-10-04 Ryosuke Niwa <rniwa@webkit.org>
13169 Add the support for running ES6SampleBench to run-benchmark
13170 https://bugs.webkit.org/show_bug.cgi?id=162890
13172 Reviewed by Saam Barati.
13174 Added the support for running ES6SampleBench as "es6bench".
13175 e.g. ./Tools/Scripts/run-benchmark --platform osx --plan es6bench --browser safari
13177 Instead of the default 10 iterations, run the test 4 iterations using 5 instances of browser
13178 for the total of 20 iterations.
13180 * Scripts/webkitpy/benchmark_runner/data/patches/ES6SampleBench.patch: Added.
13181 * Scripts/webkitpy/benchmark_runner/data/plans/es6bench.plan: Added.
13182 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
13183 (start): Fixed the bug that the linter will complain about the presence of "debugOutput" by
13184 removing it if it's present.
13186 2016-10-04 Simon Fraser <simon.fraser@apple.com>
13188 [iOS WK2] Make it possible for a test to describe a user gesture as a stream of events in JSON format
13189 https://bugs.webkit.org/show_bug.cgi?id=162934
13191 Reviewed by Dean Jackson.
13193 With this change, a test can describe a user gesture in an "event stream", which is
13194 some JSON describing an array of events with their underlying touches. The added
13195 test describes a single tap.
13197 The implementation fires up an NSThread, and sleeps the thread between events to dispatch
13198 them at close to real time.
13200 In future, HIDEventGenerator could use this internally for all of the "compound" interactions.
13202 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
13203 (WTR::UIScriptController::sendEventStream):
13204 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
13205 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
13206 (WTR::UIScriptController::sendEventStream):
13207 * TestRunnerShared/UIScriptContext/UIScriptController.h:
13208 * WebKitTestRunner/ios/HIDEventGenerator.h:
13209 * WebKitTestRunner/ios/HIDEventGenerator.mm:
13210 (transducerTypeFromString):
13212 (-[HIDEventGenerator eventMaskFromEventInfo:]):
13213 (-[HIDEventGenerator touchFromEventInfo:]):
13214 (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
13215 (-[HIDEventGenerator dispatchEventWithInfo:]):
13216 (-[HIDEventGenerator eventDispatchThreadEntry:]):
13217 (-[HIDEventGenerator sendEventStream:completionBlock:]):
13218 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
13219 (WTR::UIScriptController::sendEventStream):
13221 2016-10-04 Megan Gardner <megan_gardner@apple.com>
13223 Add Megan to contributor's list
13224 https://bugs.webkit.org/show_bug.cgi?id=162944
13226 Reviewed by Tim Horton.
13228 Add Megan to the contributor's lists so that her e-mail autocompletes for CC
13230 * Scripts/webkitpy/common/config/contributors.json:
13232 2016-10-04 Alex Christensen <achristensen@webkit.org>
13234 Add tests verifying non-special URL hosts are parsed according to spec
13235 https://bugs.webkit.org/show_bug.cgi?id=162885
13237 Reviewed by Sam Weinig.
13239 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13240 (TestWebKitAPI::TEST_F):
13242 2016-10-04 Anders Carlsson <andersca@apple.com>
13244 Properly kill web processes in the launching state
13245 https://bugs.webkit.org/show_bug.cgi?id=162938
13247 Reviewed by Tim Horton.
13249 * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
13250 Enable this test again.
13252 2016-10-04 Alex Christensen <achristensen@webkit.org>
13254 URLParser: query-only URLs relative to file URLs should just add a query
13255 https://bugs.webkit.org/show_bug.cgi?id=162888
13257 Reviewed by Tim Horton.
13259 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13260 (TestWebKitAPI::TEST_F):
13262 2016-10-04 Alex Christensen <achristensen@webkit.org>
13264 URLParser should match URL::parse and other browsers when parsing a URL containing only scheme://
13265 https://bugs.webkit.org/show_bug.cgi?id=162909
13267 Reviewed by Tim Horton.
13269 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13270 (TestWebKitAPI::TEST_F):
13272 2016-10-04 Yusuke Suzuki <utatane.tea@gmail.com>
13274 [DOMJIT] Introduce DOMJIT::GetterSetter to tell JIT information
13275 https://bugs.webkit.org/show_bug.cgi?id=162916
13277 Reviewed by Filip Pizlo.
13279 * DumpRenderTree/CMakeLists.txt:
13281 2016-10-04 Wenson Hsieh <wenson_hsieh@apple.com>
13283 Media controls are displayed in the incorrect state momentarily after switching between tabs playing media
13284 https://bugs.webkit.org/show_bug.cgi?id=162766
13285 <rdar://problem/28533523>
13287 Reviewed by Jer Noble.
13289 Adds new tests and tweaks existing tests to verify last updated Now Playing information.
13291 * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
13292 (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]):
13293 (TestWebKitAPI::TEST):
13294 (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]): Deleted.
13295 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html:
13297 2016-10-03 Alex Christensen <achristensen@webkit.org>
13299 URLParser should ignore tabs at all locations
13300 https://bugs.webkit.org/show_bug.cgi?id=162836
13302 Reviewed by Geoffrey Garen.
13304 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13305 (TestWebKitAPI::checkURL):
13306 (TestWebKitAPI::checkRelativeURL):
13307 (TestWebKitAPI::checkURLDifferences):
13308 (TestWebKitAPI::checkRelativeURLDifferences):
13309 (TestWebKitAPI::TEST_F):
13311 2016-10-03 Alex Christensen <achristensen@webkit.org>
13313 URLParser: fragment-only URLs relative to file URLs should just add a fragment
13314 https://bugs.webkit.org/show_bug.cgi?id=162871
13316 Reviewed by Geoffrey Garen.
13318 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13319 (TestWebKitAPI::TEST_F):
13321 2016-10-03 Per Arne Vollan <pvollan@apple.com>
13323 [Win] DRT temp folder is not used.
13324 https://bugs.webkit.org/show_bug.cgi?id=162863
13326 Reviewed by Alex Christensen.
13328 Convert DRT temp folder to DOS path, which DRT can use.
13330 * Scripts/webkitpy/port/driver.py:
13331 (Driver._setup_environ_for_driver):
13333 2016-10-03 Alex Christensen <achristensen@webkit.org>
13335 URLParser: empty relative URLs should not copy fragment from the base URL
13336 https://bugs.webkit.org/show_bug.cgi?id=162864
13338 Reviewed by Chris Dumez.
13340 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13341 (TestWebKitAPI::TEST_F):
13343 2016-10-03 Carlos Garcia Campos <cgarcia@igalia.com>
13345 [SOUP] Cleanup persistent credential storage code
13346 https://bugs.webkit.org/show_bug.cgi?id=162777
13348 Reviewed by Alex Christensen.
13350 Use USE(LIBSECRET) instead of ENABLE(CREDENTIAL_STORAGE).
13352 * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
13353 (testWebViewAuthenticationStorage):
13355 2016-10-02 Darin Adler <darin@apple.com>
13357 Rename ExceptionCode-based exception handling to "legacy"
13358 https://bugs.webkit.org/show_bug.cgi?id=162859
13360 Reviewed by Chris Dumez.
13362 * Scripts/do-webcore-rename: Updated script to do this round of renames.
13364 2016-10-02 Wenson Hsieh <wenson_hsieh@apple.com>
13366 Media controls for Soundcloud easily falls out of sync with what's actually playing
13367 https://bugs.webkit.org/show_bug.cgi?id=162843
13368 <rdar://problem/28176874>
13370 Reviewed by Beth Dakin.
13372 Adds two new tests simulating audio playback behavior on soundcloud. Also tweaks some of the WKWebView test
13373 message handling logic to support having multiple message-handler mappings.
13375 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13376 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
13377 (TestWebKitAPI::TEST):
13378 * TestWebKitAPI/Tests/WebKit2Cocoa/play-audio-on-click.html: Added.
13379 * TestWebKitAPI/mac/TestWKWebViewMac.h:
13380 * TestWebKitAPI/mac/TestWKWebViewMac.mm:
13381 (-[TestMessageHandler addMessage:withHandler:]):
13382 (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
13383 (-[TestWKWebView performAfterReceivingMessage:action:]):
13384 (-[TestWKWebView performAfterLoading:]):
13385 (-[TestMessageHandler initWithMessage:handler:]): Deleted.
13387 2016-09-30 Alex Christensen <achristensen@webkit.org>
13389 Fix off-by-one error in URLParser::parseIPv4Host
13390 https://bugs.webkit.org/show_bug.cgi?id=162789
13392 Reviewed by Tim Horton.
13394 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13395 (TestWebKitAPI::TEST_F):
13397 2016-09-30 Alex Christensen <achristensen@webkit.org>
13399 URLParser: parsing a URL with an empty host and a colon should fail
13400 https://bugs.webkit.org/show_bug.cgi?id=162795
13402 Reviewed by Tim Horton.
13404 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13405 (TestWebKitAPI::TEST_F):
13407 2016-09-30 Alex Christensen <achristensen@webkit.org>
13409 URLParser: handle syntax violations in non-UTF-8 encoded queries
13410 https://bugs.webkit.org/show_bug.cgi?id=162770
13412 Reviewed by Tim Horton.
13414 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13415 (TestWebKitAPI::checkURL):
13416 (TestWebKitAPI::TEST_F):
13417 Tests with emoji change behavior when we insert a tab between the surrogates, so don't do the
13418 insert-tab-at-each-location verification that syntax violations are handled correctly.
13420 2016-09-30 Megan Gardner <megan_gardner@apple.com>
13422 Make it possible to test web-related user-interface features
13423 https://bugs.webkit.org/show_bug.cgi?id=162657
13425 Reviewed by Simon Fraser.
13427 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
13428 (WTR::UIScriptController::contentsOfUserInterfaceItem):
13429 (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
13430 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
13431 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
13432 (WTR::UIScriptController::contentsOfUserInterfaceItem):
13433 (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
13434 * TestRunnerShared/UIScriptContext/UIScriptController.h:
13435 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
13436 (WTR::UIScriptController::contentsOfUserInterfaceItem):
13437 (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
13439 2016-09-29 Jiewen Tan <jiewen_tan@apple.com>
13441 Expose CryptoKey to web workers
13442 https://bugs.webkit.org/show_bug.cgi?id=162640
13443 <rdar://problem/28182204>
13445 Reviewed by Brent Fulgham.
13447 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13448 * TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm: Added.
13449 (TestWebKitAPI::TEST_F):
13450 Add API tests for SerializedCryptoKeyWrap APIs.
13452 2016-09-29 Alex Christensen <achristensen@webkit.org>
13454 Fix syntax violation handling in IPv4 address parsing
13455 https://bugs.webkit.org/show_bug.cgi?id=162756
13457 Reviewed by Tim Horton.
13459 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13460 (TestWebKitAPI::TEST_F):
13462 2016-09-29 Alex Christensen <achristensen@webkit.org>
13464 URLParser should correctly parse ports with leading 0's
13465 https://bugs.webkit.org/show_bug.cgi?id=162752
13467 Reviewed by Tim Horton.
13469 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13470 (TestWebKitAPI::TEST_F):
13472 2016-09-29 Alex Christensen <achristensen@webkit.org>
13474 URLParser: make parsing invalid IPv4 addresses more robust and correct
13475 https://bugs.webkit.org/show_bug.cgi?id=162746
13477 Reviewed by Tim Horton.
13479 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13480 (TestWebKitAPI::TEST_F):
13482 2016-09-29 Alex Christensen <achristensen@webkit.org>
13484 URLParser: IPv6 addresses followed by a colon are invalid
13485 https://bugs.webkit.org/show_bug.cgi?id=162747
13487 Reviewed by Tim Horton.
13489 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13490 (TestWebKitAPI::TEST_F):
13492 2016-09-29 Alexey Proskuryakov <ap@apple.com>
13494 Make WKTR short timeout dynamic
13495 https://bugs.webkit.org/show_bug.cgi?id=162733
13497 Reviewed by Alex Christensen.
13499 WebKitTestRunner has a hardcoded value for how long to wait for IPC responses,
13500 which is 5 seconds, or 10 seconds under ASan. But some of the operations can be
13501 fairly time consuming - e.g. launching Networking process on demand.
13502 These may take longer under load, especially with GuardMalloc.
13504 * WebKitTestRunner/TestController.cpp:
13505 (WTR::TestController::resetStateToConsistentValues):
13506 (WTR::TestController::reattachPageToWebProcess):
13507 * WebKitTestRunner/TestController.h:
13508 * WebKitTestRunner/TestInvocation.cpp:
13509 (WTR::TestInvocation::shortTimeout):
13510 (WTR::TestInvocation::invoke):
13511 (WTR::TestInvocation::dumpResults):
13513 * WebKitTestRunner/TestInvocation.h:
13514 (WTR::TestInvocation::customTimeout): Deleted, this function was unused.
13516 2016-09-29 Alex Christensen <achristensen@webkit.org>
13518 URLParser should fail to parse unclosed IPv6 addresses
13519 https://bugs.webkit.org/show_bug.cgi?id=162715
13521 Reviewed by Tim Horton.
13523 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13524 (TestWebKitAPI::TEST_F):
13526 2016-09-29 Alex Christensen <achristensen@webkit.org>
13528 URLParser should ignore tabs at all possible locations
13529 https://bugs.webkit.org/show_bug.cgi?id=162711
13531 Reviewed by Tim Horton.
13533 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13534 (TestWebKitAPI::ExpectedParts::isInvalid):
13535 (TestWebKitAPI::checkURL):
13536 (TestWebKitAPI::TEST_F):
13538 2016-09-29 Gyuyoung Kim <gyuyoung.kim@navercorp.com>
13540 [EFL] Add search button to url bar in MiniBrowser
13541 https://bugs.webkit.org/show_bug.cgi?id=162716
13543 Reviewed by Michael Catanzaro.
13545 As a bug title, it would be good to add a search button to URL bar.
13546 Additionally this patch changes color of button to recognize the buttons.
13548 * MiniBrowser/efl/main.c:
13549 (_search_button_clicked_cb):
13550 (_create_toolbar_button):
13552 (create_toolbar_button): Deleted.
13554 2016-09-28 Tim Horton <timothy_horton@apple.com>
13556 API test WebKit2.AutoLayoutIntegration is a flaky timeout
13557 https://bugs.webkit.org/show_bug.cgi?id=160284
13559 Reviewed by Dan Bernstein.
13561 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
13562 (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
13563 (-[AutoLayoutWKWebView beginLayoutAtMinimumWidth:andExpectContentSizeChange:]):
13564 (-[AutoLayoutWKWebView waitForContentSizeChangeResettingWidth:]):
13565 (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
13566 (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
13568 Make the autolayout tests a bit more flexible regarding the ordering of
13569 invalidateIntrinsicContentSize, to avoid a race between the load
13570 completing and the invalidation.
13572 Also, move the newly added test to use its own WKWebView, since once in a
13573 while we get a first layout notification from the previous page, causing the test to fail.
13575 Un-disable the tests, which now run without any flakes for me with quite a few iterations.
13577 2016-09-28 Alex Christensen <achristensen@webkit.org>
13579 URLParser should properly handle unexpected periods and overflows in IPv4 addresses
13580 https://bugs.webkit.org/show_bug.cgi?id=162655
13582 Reviewed by Geoffrey Garen.
13584 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13585 (TestWebKitAPI::TEST_F):
13587 2016-09-28 Ryan Haddad <ryanhaddad@apple.com>
13589 Disable flaky API test WebKit2.AutoLayoutIntegration.
13590 https://bugs.webkit.org/show_bug.cgi?id=160284
13592 Unreviewed test gardening.
13594 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
13597 2016-09-28 Alex Christensen <achristensen@webkit.org>
13599 URLParser should ignore tabs in authority
13600 https://bugs.webkit.org/show_bug.cgi?id=162694
13602 Reviewed by Geoffrey Garen.
13604 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13605 (TestWebKitAPI::TEST_F):
13607 2016-09-28 Alex Christensen <achristensen@webkit.org>
13609 URLParser should ignore extra slashes after scheme:// and handle a missing slash after the port
13610 https://bugs.webkit.org/show_bug.cgi?id=162690
13612 Reviewed by Geoffrey Garen.
13614 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13615 (TestWebKitAPI::TEST_F):
13617 2016-09-28 Alex Christensen <achristensen@webkit.org>
13619 URLParser should correctly canonicalize uppercase IPv6 addresses
13620 https://bugs.webkit.org/show_bug.cgi?id=162680
13622 Reviewed by Tim Horton.
13624 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13625 (TestWebKitAPI::TEST_F):
13627 2016-09-27 Wenson Hsieh <wenson_hsieh@apple.com>
13629 Adopt MediaRemote SPI to achieve desired Now Playing behavior
13630 https://bugs.webkit.org/show_bug.cgi?id=162658
13631 <rdar://problem/28499358>
13633 Reviewed by Jer Noble.
13635 Introduces 2 unit tests in the new NowPlayingControlsTests test suite. Also provides some basic support for
13636 mocking key window status for TestWKWebViews.
13638 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13639 * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: Added.
13640 (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
13641 (-[NowPlayingTestWebView expectHasActiveNowPlayingSession:]):
13642 (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]):
13643 (TestWebKitAPI::TEST):
13644 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html: Added.
13645 * TestWebKitAPI/mac/TestWKWebViewMac.mm:
13646 (-[TestWKWebViewHostWindow isKeyWindow]):
13647 (-[TestWKWebViewHostWindow makeKeyWindow]):
13648 (-[TestWKWebViewHostWindow resignKeyWindow]):
13650 2016-09-28 Per Arne Vollan <pvollan@apple.com>
13653 https://bugs.webkit.org/show_bug.cgi?id=162670
13655 Reviewed by Brent Fulgham.
13657 Make sure we include JavaScriptCore files from the forwarding headers folder.
13658 Otherwise we might get multiple definitions if a JSC file is included both
13659 from the forwarding headers folder and the JSC source folder, since
13660 #pragma once is used in the header files.
13662 * DumpRenderTree/TestRunner.cpp:
13664 2016-09-28 Michael Catanzaro <mcatanzaro@igalia.com>
13666 [GTK] Add Chrome UA quirk
13667 https://bugs.webkit.org/show_bug.cgi?id=162617
13669 Reviewed by Carlos Garcia Campos.
13671 Update test. This portion of the commit was actually unreviewed.
13673 * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
13674 (TestWebKitAPI::TEST):
13676 2016-09-28 Michael Catanzaro <mcatanzaro@igalia.com>
13678 [GTK] Adjust OS X UA quirks list
13679 https://bugs.webkit.org/show_bug.cgi?id=162616
13681 "Reviewed" by Carlos Garcia Campos.
13683 Update test. This portion of the commit was actually unreviewed.
13685 * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
13686 (TestWebKitAPI::TEST):
13688 2016-09-28 Carlos Garcia Campos <cgarcia@igalia.com>
13690 [GTK] Switch to use GMenu internally in the context menu implementation
13691 https://bugs.webkit.org/show_bug.cgi?id=162603
13693 Reviewed by Michael Catanzaro.
13695 Remove smart separators test, since that's now done automatically by GTK+.
13697 * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
13699 (testContextMenuWebExtensionMenu): Deleted.
13701 2016-09-27 Alex Christensen <achristensen@webkit.org>
13703 Correctly parse URLs with the first tab in the fragment
13704 https://bugs.webkit.org/show_bug.cgi?id=162650
13706 Reviewed by Saam Barati.
13708 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13709 (TestWebKitAPI::TEST_F):
13711 2016-09-27 Alex Christensen <achristensen@webkit.org>
13713 URLParser: Handle windows drive letters after two slashes in relative URLs according to spec
13714 https://bugs.webkit.org/show_bug.cgi?id=162646
13716 Reviewed by Saam Barati.
13718 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13719 (TestWebKitAPI::TEST_F):
13721 2016-09-27 Alex Christensen <achristensen@webkit.org>
13723 URLs with @ in the user should only search for the last @ until the end of the authority and host
13724 https://bugs.webkit.org/show_bug.cgi?id=162635
13726 Reviewed by Geoffrey Garen.
13728 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13729 (TestWebKitAPI::TEST_F):
13731 2016-09-27 JF Bastien <jfbastien@apple.com>
13733 Speed up Heap::isMarkedConcurrently
13734 https://bugs.webkit.org/show_bug.cgi?id=162095
13736 Reviewed by Filip Pizlo.
13738 * TestWebKitAPI/CMakeLists.txt:
13739 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13740 * TestWebKitAPI/Tests/WTF/Consume.cpp: Added.
13742 (TestWebKitAPI::TEST):
13744 2016-09-26 Alex Christensen <achristensen@webkit.org>
13746 Implement URLParser::syntaxViolation
13747 https://bugs.webkit.org/show_bug.cgi?id=162593
13749 Reviewed by Geoffrey Garen.
13751 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13752 (TestWebKitAPI::TEST_F):
13754 2016-09-27 Anders Carlsson <andersca@apple.com>
13756 Turns out OptionSet.cpp wasn't added to the right target. Add it and fix the build for real.
13758 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13759 * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
13760 (TestWebKitAPI::TEST):
13762 2016-09-27 Anders Carlsson <andersca@apple.com>
13764 Try to fix the GTK+ build.
13766 * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
13767 (TestWebKitAPI::TEST):
13769 2016-09-27 Dan Bernstein <mitz@apple.com>
13771 [iOS] REGRESSION (r182126): Selection highlight and handles aren’t visible with WKSelectionGranularityCharacter
13772 https://bugs.webkit.org/show_bug.cgi?id=162577
13773 <rdar://problem/28481984>
13775 Reviewed by Simon Fraser.
13777 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
13778 (WTR::UIScriptController::selectionRangeViewRects): Returns null.
13780 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Declared new
13781 selectionRangeViewRects attribute.
13783 * TestRunnerShared/UIScriptContext/UIScriptContext.h:
13784 (WTR::UIScriptContext::jsContext): Added this public accessor.
13786 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
13787 (WTR::selectionRangeViewRects): Generic implementation that returns null.
13788 * TestRunnerShared/UIScriptContext/UIScriptController.h:
13790 * WebKitTestRunner/TestController.cpp:
13791 (WTR::updateTestOptionsFromTestHeader): Parse the new useCharacterSelectionGranularity
13794 * WebKitTestRunner/TestOptions.h: Added new useCharacterSelectionGranularity option.
13796 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
13797 (WTR::TestController::platformCreateWebView): Set the configuration’s selectionGranularity
13798 property based on the new option.
13800 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
13801 (WTR::PlatformWebView::viewSupportsOptions): Compare selection granularity option values.
13803 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
13804 (WTR::UIScriptController::selectionRangeViewRects): iOS-specific implementation that calls
13805 the new -[WKWebView _uiTextSelectionRectViews] and returns an array of view frame
13808 2016-09-27 Daniel Bates <dabates@apple.com>
13810 Cannot run dump-class-layout; dies with "global name 'lldb' is not defined"
13811 https://bugs.webkit.org/show_bug.cgi?id=162585
13813 Reviewed by Simon Fraser.
13815 Import the lldb module into the global namespace.
13817 Currently dump-class-layout imports the lldb Python module using the import statement
13818 from the helper function import_lldb. The import statement imports the names of the
13819 specified module into the scope of import_lldb(); => the names imported from this
13820 module cannot be accessed outside the scope of import_lldb(). Other functions in
13821 this script assume that the lldb module was imported into the global scope. We should
13822 import the module lldb into the global scope, if it exists, so that these functions
13823 can find it. Otherwise, we should emit a human readable error message that explains
13824 that we failed to import the lldb module.
13826 Also remove some unnecessary semicolon characters.
13828 * Scripts/dump-class-layout:
13831 2016-09-27 Jer Noble <jer.noble@apple.com>
13833 Remove deprecated ENCRYPTED_MEDIA implementation.
13834 https://bugs.webkit.org/show_bug.cgi?id=161010
13836 Reviewed by Eric Carlson.
13838 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
13840 2016-09-27 Chris Dumez <cdumez@apple.com>
13842 [WK2] Navigating to a Blob URL does not trigger a download
13843 https://bugs.webkit.org/show_bug.cgi?id=162574
13845 Reviewed by Darin Adler.
13847 Add API that tests navigating to a Blob URL and checks that that the load
13848 properly gets converted into a download.
13850 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13851 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
13852 (-[BlobDownloadDelegate _downloadDidStart:]):
13853 (-[BlobDownloadDelegate _download:didReceiveResponse:]):
13854 (-[BlobDownloadDelegate _download:didReceiveData:]):
13855 (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
13856 (-[BlobDownloadDelegate _downloadDidFinish:]):
13857 (-[DownloadBlobURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
13859 * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestBlobURL.html: Added.
13861 2016-09-27 Michael Catanzaro <mcatanzaro@igalia.com>
13863 [GTK] Install binaries to pkglibexecdir rather than bindir
13864 https://bugs.webkit.org/show_bug.cgi?id=162602
13866 Reviewed by Carlos Garcia Campos.
13868 Install MiniBrowser to LIBEXEC_INSTALL_DIR rather than EXEC_INSTALL_DIR.
13870 * MiniBrowser/gtk/CMakeLists.txt:
13872 2016-09-27 Gyuyoung Kim <gyuyoung.kim@webkit.org>
13874 [EFL] Locate color picker popup to center of window
13875 https://bugs.webkit.org/show_bug.cgi?id=162540
13877 Reviewed by Michael Catanzaro.
13879 Color picker popup hasn't located in a center of main window, because
13880 elm_win_center() function doesn't work correctly. It looks a bug.
13882 To fix the problem, this patch uses evas_object_geometry_set() instead.
13884 * MiniBrowser/efl/main.c:
13885 (_color_picker_request_cb):
13887 2016-09-27 Michael Catanzaro <mcatanzaro@igalia.com>
13889 [GTK] Disable ACCELERATED_2D_CANVAS when using build-webkit
13890 https://bugs.webkit.org/show_bug.cgi?id=162600
13892 Reviewed by Carlos Garcia Campos.
13894 * Scripts/webkitperl/FeatureList.pm:
13896 2016-09-27 Michael Catanzaro <mcatanzaro@igalia.com>
13898 PyGIWarnings printed by webkit-patch
13899 https://bugs.webkit.org/show_bug.cgi?id=152470
13901 Reviewed by Carlos Garcia Campos.
13903 Update to a newer version of the keyring module, since this bug has been fixed upstream for
13904 a while. But be careful not to update to the latest version, since it has some compatibility
13905 breaks and requires the SecretService python module on Linux, but I couldn't figure out how
13906 to autoinstall it successfully.
13908 * Scripts/webkitpy/thirdparty/__init__.py:
13909 (AutoinstallImportHook._install_keyring):
13911 2016-09-26 Ryan Haddad <ryanhaddad@apple.com>
13913 Add Sierra to the flakiness dashboard.
13914 https://bugs.webkit.org/show_bug.cgi?id=162509
13916 Reviewed by Alexey Proskuryakov.
13918 * TestResultServer/static-dashboards/builders.jsonp:
13920 2016-09-26 Daniel Bates <dabates@apple.com>
13922 Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
13923 https://bugs.webkit.org/show_bug.cgi?id=162365
13925 Reviewed by Simon Fraser.
13927 * DumpRenderTree/TestRunner.h:
13928 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
13930 2016-09-26 Tomas Popela <tpopela@redhat.com>
13932 [GTK] TestContextMenu is failing
13933 https://bugs.webkit.org/show_bug.cgi?id=162569
13935 We cannot use the MP3 file in the TestContextMenu, as it will not work
13936 by default on most distributions (that don't have an MP3 codecs
13937 installed). Change the test to use OGG file instead.
13939 Reviewed by Michael Catanzaro.
13941 * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
13942 (testContextMenuDefaultMenu):
13944 2016-09-26 Yusuke Suzuki <utatane.tea@gmail.com>
13946 Using char16_t instead of wchar_t in TestWebKitAPI URLParser tests
13947 https://bugs.webkit.org/show_bug.cgi?id=162537
13949 Reviewed by Alex Christensen.
13951 Some build bot (Linux ARM GTK port) fails since we cannot select
13952 the specific StringBuilder::append method for wchar_t.
13954 wchar_t implementation highly depends on platforms. sizeof(wchar_t) == 2
13955 in Windows, while sizeof(wchar_t) == 4 in Linux and OS X. So, ICU
13956 uses wchar_t for UChar (UTF-16) in Windows while it doesn't in other
13959 StringBuilder::append is overloaded for UChar. In Windows, we can pass
13960 wchar_t since UChar is wchar_t. However, we cannot do that in other platforms.
13962 Instead of using wchar_t, we use more platform portable UTF-16 literal for
13963 testing. Use char16_t and C++11 UTF-16 literal.
13965 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
13966 (TestWebKitAPI::utf16String):
13967 (TestWebKitAPI::TEST_F):
13968 (TestWebKitAPI::wideString): Deleted.
13970 2016-09-25 Gyuyoung Kim <gyuyoung.kim@webkit.org>
13972 [EFL] Adjust EFL indentation to EFL MiniBrowser
13973 https://bugs.webkit.org/show_bug.cgi?id=162542
13975 Unreviewed, EFL simple coding style fix.
13977 Some functions wasn't applied EFL coding style in prefix fix.
13979 * MiniBrowser/efl/main.c:
13984 (_title_changed_cb):
13986 (_back_forward_list_changed_cb):
13989 (_download_request_cb):
13990 (close_file_picker):
13991 (_filepicker_parent_deletion_cb):
13992 (_filepicker_deletion_cb):
13993 (_fileselector_done_cb):
13994 (_file_chooser_request_cb):
13995 (_download_finished_cb):
13996 (_download_failed_cb):
13997 (_color_changed_cb):
13998 (_color_item_selected_cb):
13999 (_color_picker_ok_clicked_cb):
14000 (_color_picker_cancel_clicked_cb):
14001 (_color_picker_dismiss_cb):
14002 (_color_picker_request_cb):
14005 (url_from_user_input):
14006 (url_load_from_user_input):
14007 (_url_bar_activated_cb):
14008 (_url_bar_clicked_cb):
14009 (_search_field_aborted_cb):
14010 (_search_field_activated_cb):
14011 (_search_field_clicked_cb):
14012 (_back_button_clicked_cb):
14013 (_forward_button_clicked_cb):
14014 (_search_backward_button_clicked_cb):
14015 (_search_forward_button_clicked_cb):
14016 (_search_case_option_changed):
14017 (_search_word_start_option_changed_cb):
14018 (_search_close_button_clicked_cb):
14019 (_refresh_button_clicked_cb):
14020 (_stop_button_clicked_cb):
14021 (list_item_label_get):
14022 (_list_item_select_cb):
14023 (navigation_button_longpress_process):
14024 (_forward_button_longpress_cb):
14025 (_back_button_longpress_cb):
14028 (_file_entry_dialog_show):
14030 2016-09-24 Chris Dumez <cdumez@apple.com>
14032 [WK2] anchor.download attribute value is ignored by NETWORK_SESSION code path
14033 https://bugs.webkit.org/show_bug.cgi?id=162531
14035 Reviewed by Darin Adler.
14037 Update decideDestinationWithSuggestedFilename() to return a actual file path
14038 instead of nullptr. The NETWORK_SESSION code path cancels the download when
14039 decideDestinationWithSuggestedFilename() returns an empty file path, unlike
14040 the !NETWORK_SESSION code path that just continue downloading without
14041 explicitely setting a destination path. This lead to different test results
14042 for NETWORK_SESSION and !NETWORK_SESSION code paths. Returns a valid
14043 destination path makes more sense and leads to consistent results.
14045 * WebKitTestRunner/TestController.cpp:
14046 (WTR::TestController::decideDestinationWithSuggestedFilename):
14048 2016-09-23 Wenson Hsieh <wenson_hsieh@apple.com>
14050 [mac-sierra] 2 WKWebViewCandidateTests API test failures
14051 https://bugs.webkit.org/show_bug.cgi?id=162470
14053 Reviewed by Tim Horton.
14055 VideoControlsManager, WKWebViewCandidateTests and CandidateTests should not be running on 10.12.0. Guard these
14056 tests with an SDK check to prevent 10.12.0 bots from building them.
14058 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
14059 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
14060 * TestWebKitAPI/Tests/mac/CandidateTests.mm:
14062 2016-09-23 Alex Christensen <achristensen@webkit.org>
14065 https://bugs.webkit.org/show_bug.cgi?id=162516
14067 Reviewed by Brady Eidson.
14069 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14070 (TestWebKitAPI::TEST_F):
14072 2016-09-23 Caitlin Potter <caitp@igalia.com>
14074 [JSC] Implement parsing of Async Functions
14075 https://bugs.webkit.org/show_bug.cgi?id=161409
14077 Reviewed by Yusuke Suzuki.
14079 * Scripts/build-jsc:
14080 (cMakeArgsFromFeatures):
14081 * Scripts/webkitperl/FeatureList.pm:
14082 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
14084 2016-09-23 Alex Christensen <achristensen@webkit.org>
14087 https://bugs.webkit.org/show_bug.cgi?id=162511
14089 Reviewed by Brady Eidson.
14091 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14092 (TestWebKitAPI::TEST_F):
14093 (TestWebKitAPI::checkURL):
14095 2016-09-23 Alexey Proskuryakov <ap@apple.com>
14097 iOS playback user action tests fail on some machines
14098 https://bugs.webkit.org/show_bug.cgi?id=162504
14099 rdar://problem/28013994
14101 Reviewed by Jer Noble.
14103 Avoid the need to have a timeout.
14105 * TestWebKitAPI/Tests/WebKit/ios/audio-only.html:
14106 * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
14107 * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
14108 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html:
14110 2016-09-23 Carlos Garcia Campos <cgarcia@igalia.com>
14112 REGRESSION(r204163): [GTK] API test /webkit2/WebKitSecurityManager/file-xhr is failing
14113 https://bugs.webkit.org/show_bug.cgi?id=161607
14115 Reviewed by Michael Catanzaro.
14117 Since r204163, in case of cross origin error when loading the XHR, the load fails and an error message is shown
14118 in the console, but there isn't any js expcetion, which is what we were checking. Now, we check that there
14119 aren't exceptions, and that the error message is sent to the console.
14121 * Scripts/run-gtk-tests:
14123 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
14124 (consoleMessageReceivedCallback):
14125 (testWebContextSecurityFileXHR):
14127 2016-09-23 Ryan Haddad <ryanhaddad@apple.com>
14129 Use correct hardware for Sierra Debug WK2 testers.
14130 https://bugs.webkit.org/show_bug.cgi?id=162474
14132 Reviewed by Alexey Proskuryakov.
14134 * BuildSlaveSupport/build.webkit.org-config/config.json:
14136 2016-09-23 Carlos Garcia Campos <cgarcia@igalia.com>
14138 [GTK] Make all WebView tests have a WebKitUserContentManager
14139 https://bugs.webkit.org/show_bug.cgi?id=162487
14141 Reviewed by Michael Catanzaro.
14143 It simplifies tests using the user content manager, and allows to use it without having to subclass WebViewTest.
14145 * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
14146 (ConsoleMessageTest::ConsoleMessageTest):
14147 (ConsoleMessageTest::~ConsoleMessageTest):
14148 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
14149 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
14150 (testUserContentManagerInjectedStyleSheet):
14151 (testUserContentManagerInjectedScript):
14152 (UserScriptMessageTest::UserScriptMessageTest):
14154 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
14155 (testWebViewIsPlayingAudio):
14156 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
14157 (WebViewTest::WebViewTest):
14158 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
14160 2016-09-23 Antoine Quint <graouts@apple.com>
14162 Add a new runtime flag for work on modern media controls (off by default)
14163 https://bugs.webkit.org/show_bug.cgi?id=162420
14164 <rdar://problem/27989489>
14166 Reviewed by Eric Carlson.
14168 * DumpRenderTree/mac/DumpRenderTree.mm:
14169 (resetWebPreferencesToConsistentValues):
14170 * DumpRenderTree/win/DumpRenderTree.cpp:
14171 (resetWebPreferencesToConsistentValues):
14172 * Scripts/webkitperl/FeatureList.pm:
14173 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
14174 (WTR::InjectedBundle::beginTesting):
14175 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
14176 (WTR::TestRunner::setModernMediaControlsEnabled):
14177 * WebKitTestRunner/InjectedBundle/TestRunner.h:
14179 2016-09-23 Carlos Garcia Campos <cgarcia@igalia.com>
14181 REGRESSION(r194387): Crash on github.com in IntlDateTimeFormat::resolvedOptions in C locale
14182 https://bugs.webkit.org/show_bug.cgi?id=162139
14184 Reviewed by Michael Catanzaro.
14186 Add test cases to check the behavior when using the C locale and an invalid locale.
14188 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
14189 (testWebContextLanguages):
14191 2016-09-22 Hunseop Jeong <hs85.jeong@samsung.com>
14193 [EFL] alert box is not displayed
14194 https://bugs.webkit.org/show_bug.cgi?id=156395
14196 Reviewed by Gyuyoung Kim.
14198 Some popup objects(alert, confirm, prompt, file entry dialog) used the ecore_main_loop_begin() to make
14199 the modal popup but ecore_main_loop_begin() was not executed inside an exisiting main loop. So we have
14200 to use the ecore_main_loop_iterate() instead of the ecore_main_loop_begin().
14202 * MiniBrowser/efl/main.c:
14204 (_file_entry_dialog_show):
14205 (_javascript_alert_cb):
14206 (_javascript_confirm_cb):
14207 (_javascript_prompt_cb):
14208 (quit_event_loop): Deleted.
14210 2016-09-22 Matthew Hanson <matthew_hanson@apple.com>
14212 Add an API for getting the branch identifier from a Git or SVN checkout.
14213 https://bugs.webkit.org/show_bug.cgi?id=151570
14214 rdar://problem/17959831
14216 Reviewed by David Kilzer.
14218 This patch adds a function called svnIdentifierForPath. This function returns either "trunk",
14219 the name of the tag, or the name of the branch, as appropriate. This function is necessary for
14220 a VCSUtils client that is not checked in to the WebKit project.
14222 This patch also breaks up pathRelativeToSVNRepositoryRootForPath into four functions:
14223 - pathRelativeToSVNRepositoryRootForPath
14226 - svnRepositoryRootForPath
14228 This allows us to reuse logic from pathRelativeToSVNRepositoryRootForPath in svnIdentifierForPath and
14229 allows clients of VCSUtils to extract what arbitrary information from the `svn info` command regardless
14232 * Scripts/VCSUtils.pm:
14234 Copied logic that previously lived in pathRelativeToSVNRepositoryRootForPath.
14235 Make code safe to use for a path, and not just for the CWD.
14238 Calls svnInfoForPath and extracts the URL.
14240 (svnRepositoryRootForPath):
14241 Calls svnInfoForPath and extracts the Repository Root.
14243 (svnIdentifierForPath):
14244 Calls pathRelativeToSVNRepositoryRootForPath and extracts the repository identifier.
14246 (pathRelativeToSVNRepositoryRootForPath):
14247 Now uses svnURLForPath and svnRepositoryRootForPath instead of being responsible for
14248 determining both values.
14250 2016-09-22 Megan Gardner <megan_gardner@apple.com>
14252 Add long press selection test
14253 https://bugs.webkit.org/show_bug.cgi?id=162367
14255 Reviewed by Simon Fraser.
14257 Add support to UIScriptController to synthesize long press events on iOS.
14258 This required adding long-press functionality to HIDEventGenerator.
14260 HIDEventGenerator sends the touchDown, but must then send the touchUp with
14261 a dispatch_after (rather than sleeping, as we do for other events) in order
14262 for the gesture recognizers to correctly detect a long press.
14264 Use the long press synthesis in a test that detects whether a long press
14265 gesture triggers text selection.
14267 Fixed incorrect constants. NSTimeInterval is in seconds, original numbers
14268 were nanoseconds and typedefed to long without regard to the type
14269 differences. Redid constants to be the right value, and converted upon use.
14271 Cleaned up unused enum types.
14273 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
14274 (WTR::UIScriptController::longPressAtPoint):
14275 (WTR::UIScriptController::forcePressAtPoint):
14276 (WTR::UIScriptController::dragFromPointToPoint): Deleted.
14277 * Scripts/webkitpy/common/config/contributors.json:
14278 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
14279 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
14280 (WTR::UIScriptController::longPressAtPoint):
14281 (WTR::UIScriptController::forcePressAtPoint):
14282 (WTR::UIScriptController::dragFromPointToPoint): Deleted.
14283 * TestRunnerShared/UIScriptContext/UIScriptController.h:
14284 * WebKitTestRunner/ios/HIDEventGenerator.h:
14285 * WebKitTestRunner/ios/HIDEventGenerator.mm:
14286 (-[HIDEventGenerator _createIOHIDEventType:]):
14287 (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
14288 (-[HIDEventGenerator clearTap:]):
14289 (-[HIDEventGenerator longPressTimerCall:]):
14290 (-[HIDEventGenerator longPressFinish:completionBlock:]):
14291 (-[HIDEventGenerator longPress:completionBlock:]):
14292 (-[HIDEventGenerator forcePress:completionBlock:]):
14293 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
14294 (WTR::UIScriptController::longPressAtPoint):
14295 (WTR::UIScriptController::forcePressAtPoint):
14296 (WTR::UIScriptController::dragFromPointToPoint): Deleted.
14298 2016-09-22 Jonathan Bedard <jbedard@apple.com>
14300 Automatic Text Replacement Testing in WebKit2
14301 https://bugs.webkit.org/show_bug.cgi?id=161919
14303 Reviewed by Ryosuke Niwa.
14305 Implemented test hooks for text replacement for WebKit2.
14306 Note that spell checking has not been implemented, so most tests which use text replacement still fail.
14308 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Removed setAutomaticLinkDetectionEnabled from TestRunner, moved to Internals.
14309 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
14310 (WTR::InjectedBundle::beginTesting): Ditto.
14311 * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
14312 * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
14313 * WebKitTestRunner/TestController.cpp:
14314 (WTR::TestController::runTest): Place TextChecker into testing mode.
14316 2016-09-21 Dan Bernstein <mitz@apple.com>
14318 [macOS] Upon layout, _webView:renderingProgressDidChange: fires before the intrinsic content size is updated
14319 https://bugs.webkit.org/show_bug.cgi?id=162359
14320 <rdar://problem/27776454>
14322 Reviewed by Tim Horton.
14324 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
14327 2016-09-21 Keith Miller <keith_miller@apple.com>
14329 Fix build for future versions of Clang.
14330 https://bugs.webkit.org/show_bug.cgi?id=162346
14332 Reviewed by Filip Pizlo.
14334 * TestWebKitAPI/Counters.cpp:
14335 * TestWebKitAPI/Counters.h:
14336 (DeleterCounter::deleterCount):
14337 (DeleterCounter::TestingScope::TestingScope):
14338 (DeleterCounter::operator()):
14339 * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
14340 (TestWebKitAPI::TEST):
14341 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
14342 (TestWebKitAPI::TEST):
14344 2016-09-21 Commit Queue <commit-queue@webkit.org>
14346 Unreviewed, rolling out r206222 and r206227.
14347 https://bugs.webkit.org/show_bug.cgi?id=162361
14349 "broke the windows build" (Requested by keith_mi_ on #webkit).
14351 Reverted changesets:
14353 "Fix build for future versions of Clang."
14354 https://bugs.webkit.org/show_bug.cgi?id=162346
14355 http://trac.webkit.org/changeset/206222
14357 "Attempt to fix windows build after r206222."
14358 http://trac.webkit.org/changeset/206227
14360 2016-09-21 Alex Christensen <achristensen@webkit.org>
14362 URLParser should match URL::parse when parsing data urls with slashes in them
14363 https://bugs.webkit.org/show_bug.cgi?id=162352
14365 Reviewed by Darin Adler.
14367 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14368 (TestWebKitAPI::TEST_F):
14370 2016-09-21 Alex Christensen <achristensen@webkit.org>
14372 URLParser should fail when parsing invalid relative URLs with no schemes
14373 https://bugs.webkit.org/show_bug.cgi?id=162355
14375 Reviewed by Tim Horton.
14377 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14378 (TestWebKitAPI::TEST_F):
14380 2016-09-21 Keith Miller <keith_miller@apple.com>
14382 Fix build for future versions of Clang.
14383 https://bugs.webkit.org/show_bug.cgi?id=162346
14385 Reviewed by Filip Pizlo.
14387 * TestWebKitAPI/Counters.cpp:
14388 * TestWebKitAPI/Counters.h:
14389 (DeleterCounter::deleterCount):
14390 (DeleterCounter::TestingScope::TestingScope):
14391 (DeleterCounter::operator()):
14392 * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
14393 (TestWebKitAPI::TEST):
14394 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
14395 (TestWebKitAPI::TEST):
14397 2016-09-21 Alex Christensen <achristensen@webkit.org>
14399 Prepare API tests for enabling URLParser by default
14400 https://bugs.webkit.org/show_bug.cgi?id=162341
14402 Reviewed by Tim Horton.
14404 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14405 (TestWebKitAPI::checkURL):
14406 (TestWebKitAPI::checkRelativeURL):
14407 (TestWebKitAPI::checkURLDifferences):
14408 (TestWebKitAPI::checkRelativeURLDifferences):
14409 (TestWebKitAPI::shouldFail):
14411 2016-09-21 Alex Christensen <achristensen@webkit.org>
14413 URLParser: Correctly parse URLs that are just nonspecialscheme:/
14414 https://bugs.webkit.org/show_bug.cgi?id=162340
14416 Reviewed by Tim Horton.
14418 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14419 (TestWebKitAPI::TEST_F):
14421 2016-09-21 Alex Christensen <achristensen@webkit.org>
14423 URLParser: correctly parse relative URLs that are just one character
14424 https://bugs.webkit.org/show_bug.cgi?id=162344
14426 Reviewed by Tim Horton.
14428 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14429 (TestWebKitAPI::TEST_F):
14431 2016-09-20 Alex Christensen <achristensen@webkit.org>
14434 https://bugs.webkit.org/show_bug.cgi?id=162105
14436 Reviewed by Geoffrey Garen.
14438 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14439 (TestWebKitAPI::TEST_F):
14441 2016-09-20 Aakash Jain <aakash_jain@apple.com>
14443 enable remote_api (for debugging) in flakiness dashboard app
14444 https://bugs.webkit.org/show_bug.cgi?id=162325
14446 Reviewed by Alexey Proskuryakov.
14448 * TestResultServer/app.yaml: enabled remote_api and datastore_admin.
14450 2016-09-20 Ryan Haddad <ryanhaddad@apple.com>
14452 Unreviewed, rolling out r206180.
14454 Roll r206178 back in as the necessary changes have been made
14455 on the build master.
14457 Reverted changeset:
14459 "Unreviewed, rolling out r206178."
14460 https://bugs.webkit.org/show_bug.cgi?id=162249
14461 http://trac.webkit.org/changeset/206180
14463 2016-09-20 Alexey Proskuryakov <ap@apple.com>
14465 Use a hardcoded patch for sRGB color profile
14466 https://bugs.webkit.org/show_bug.cgi?id=162320
14467 rdar://problem/28387318
14469 Reviewed by Simon Fraser.
14471 This is a workaround for rdar://problem/28392768
14473 * DumpRenderTree/mac/LayoutTestHelper.m:
14474 (installLayoutTestColorProfile):
14476 2016-09-20 Ryan Haddad <ryanhaddad@apple.com>
14478 Unreviewed, rolling out r206178.
14480 This change caused buildbot config issues.
14482 Reverted changeset:
14484 "Add Sierra bots to buildbot and dashboard."
14485 https://bugs.webkit.org/show_bug.cgi?id=162249
14486 http://trac.webkit.org/changeset/206178
14488 2016-09-20 Dean Johnson <dean_johnson@apple.com>
14490 Add Sierra bots to buildbot and dashboard.
14491 https://bugs.webkit.org/show_bug.cgi?id=162249
14493 Reviewed by Alexey Proskuryakov.
14495 * BuildSlaveSupport/build.webkit.org-config/config.json:
14496 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
14497 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
14500 2016-09-20 Alex Christensen <achristensen@webkit.org>
14502 Reduce allocations in URLParser
14503 https://bugs.webkit.org/show_bug.cgi?id=162241
14505 Reviewed by Chris Dumez.
14507 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14508 (TestWebKitAPI::TEST_F):
14509 (TestWebKitAPI::checkURL):
14511 2016-09-20 Alex Christensen <achristensen@webkit.org>
14513 Align URLParser with web platform tests when parsing non-special relative URLs ending in AuthorityOrHost state
14514 https://bugs.webkit.org/show_bug.cgi?id=162251
14516 Reviewed by Tim Horton.
14518 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14519 (TestWebKitAPI::checkURL):
14520 (TestWebKitAPI::TEST_F):
14521 (TestWebKitAPI::checkRelativeURL):
14522 (TestWebKitAPI::checkURLDifferences):
14523 (TestWebKitAPI::checkRelativeURLDifferences):
14525 2016-09-20 Alex Christensen <achristensen@webkit.org>
14527 URLParser should allow '@' in user
14528 https://bugs.webkit.org/show_bug.cgi?id=162272
14530 Reviewed by Tim Horton.
14532 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14533 (TestWebKitAPI::TEST_F):
14535 2016-09-20 Alex Christensen <achristensen@webkit.org>
14537 URLParser: Fix parsing relative URLs with one slash after the scheme:
14538 https://bugs.webkit.org/show_bug.cgi?id=162294
14540 Reviewed by Tim Horton.
14542 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14543 (TestWebKitAPI::TEST_F):
14545 2016-09-20 Alex Christensen <achristensen@webkit.org>
14547 Fix Windows file URL quirks in URLParser
14548 https://bugs.webkit.org/show_bug.cgi?id=162303
14550 Reviewed by Tim Horton.
14552 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14553 (TestWebKitAPI::TEST_F):
14555 2016-09-20 Filip Pizlo <fpizlo@apple.com>
14557 Make MarkedBlock state tracking support overlapped allocation and marking state
14558 https://bugs.webkit.org/show_bug.cgi?id=161581
14560 Reviewed by Geoffrey Garen.
14562 Remove the always-trigger-copy-phase configuration.
14564 * Scripts/run-jsc-stress-tests:
14566 2016-09-20 Don Olmstead <don.olmstead@am.sony.com>
14568 [WinCairo] Use find_package cairo in build
14569 https://bugs.webkit.org/show_bug.cgi?id=162239
14571 Reviewed by Alex Christensen.
14573 * DumpRenderTree/PlatformWin.cmake:
14574 * TestWebKitAPI/PlatformWin.cmake:
14576 2016-09-20 Wenson Hsieh <wenson_hsieh@apple.com>
14578 Unreviewed build fix on 10.10 bots.
14580 * TestWebKitAPI/mac/TestWKWebViewMac.h:
14582 2016-09-20 Wenson Hsieh <wenson_hsieh@apple.com>
14584 VideoControlsManager.VideoControlsManagerSingleLargeVideo fails intermittently on the Mac WK2 bot
14585 https://bugs.webkit.org/show_bug.cgi?id=162255
14587 Reviewed by Jer Noble.
14589 This is reproducible by running the test repeatedly in a for loop (locally, I observed that running the test
14590 back-to-back would result in the second one failing). This suggests that even on the runloop after the video
14591 starts playing, the state of the playback controls manager may not be up to date in the UI process. Instead, we
14592 can just spin the runloop until the playback controls are shown, which makes back-to-back tests to succeed and
14593 will probably address flakiness on the bots for this test.
14595 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
14596 (TestWebKitAPI::TEST):
14597 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
14599 2016-09-20 Per Arne Vollan <pvollan@apple.com>
14601 [Win] Run layout tests in parallel.
14602 https://bugs.webkit.org/show_bug.cgi?id=162145
14604 Reviewed by Brent Fulgham.
14606 To speed up layout tests, try running them in parallel.
14608 * Scripts/webkitpy/port/win.py:
14609 (WinPort.default_child_processes): Deleted.
14611 2016-09-19 Wenson Hsieh <wenson_hsieh@apple.com>
14613 Unreviewed build fix after r206135
14615 NSEventMaskLeftMouseDown and friends are only available on 10.12.
14617 * TestWebKitAPI/mac/TestWKWebViewMac.mm:
14618 (__simulated_forceClickAssociatedEventsMask):
14620 2016-09-19 Wenson Hsieh <wenson_hsieh@apple.com>
14622 Add a unit test covering <https://trac.webkit.org/changeset/205983>
14623 https://bugs.webkit.org/show_bug.cgi?id=162112
14625 Reviewed by Beth Dakin.
14627 Adds a new unit test covering the changes in r205983 along with the infrastructure needed to support it. Also
14628 further refactors the TestWKWebView used by VideoControlsManager and WKWebViewCandidateTests so that in both
14629 cases, we add the WKWebView to a visible key window, and when sending a mouse down event, we propagate the event
14630 at the window level rather than the view level, allowing greater flexibility to simulate behaviors such as
14631 pressure-sensitive events that are needed for the new test.
14633 Also rewrites currently disabled unit tests in CandidateTests as WebKit2 unit tests in WKWebViewCandidateTests,
14634 checking whether or not to should be requesting candidates in password and non-password fields.
14636 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
14637 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
14638 (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
14639 (TestWebKitAPI::TEST):
14640 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
14641 (-[CandidateTestWebView typeString:inputMessage:]):
14642 (+[CandidateTestWebView setUpWithFrame:testPage:]):
14643 * TestWebKitAPI/Tests/WebKit2Cocoa/large-input-field-focus-onload.html: Added.
14644 * TestWebKitAPI/Tests/WebKit2Cocoa/text-and-password-inputs.html: Added.
14645 * TestWebKitAPI/mac/TestWKWebViewMac.h:
14646 * TestWebKitAPI/mac/TestWKWebViewMac.mm:
14647 (__simulated_forceClickAssociatedEventsMask):
14648 (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
14649 (-[TestWKWebView initWithFrame:]):
14650 (-[TestWKWebView initWithFrame:configuration:]):
14651 (-[TestWKWebView _setUpTestWindow:]):
14652 (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
14653 (-[TestWKWebView typeCharacter:]):
14654 (-[TestWKWebView mouseDownAtPoint:]): Deleted.
14656 2016-09-19 Alex Christensen <achristensen@webkit.org>
14658 URLParser can read memory out of bounds
14659 https://bugs.webkit.org/show_bug.cgi?id=162206
14661 Reviewed by Geoff Garen.
14663 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14664 (TestWebKitAPI::TEST_F):
14666 2016-09-19 Daniel Bates <dabates@apple.com>
14668 Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
14669 https://bugs.webkit.org/show_bug.cgi?id=162167
14671 Reviewed by Simon Fraser.
14673 * Scripts/webkitperl/FeatureList.pm:
14674 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
14676 2016-09-19 Nan Wang <n_wang@apple.com>
14678 AX: Add accessibility support for details element on iOS
14679 https://bugs.webkit.org/show_bug.cgi?id=162041
14681 Reviewed by Chris Fleizach.
14683 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
14684 (AccessibilityUIElement::isExpanded):
14685 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
14686 (WTR::AccessibilityUIElement::isExpanded):
14688 2016-09-18 Gyuyoung Kim <gyuyoung.kim@navercorp.com>
14690 [EFL] Bump efl library to 1.18.1
14691 https://bugs.webkit.org/show_bug.cgi?id=162120
14693 Reviewed by Michael Catanzaro.
14695 * efl/jhbuild.modules: Use efl-1.18.1 instead of 1.18.
14697 2016-09-18 Gyuyoung Kim <gyuyoung.kim@webkit.org>
14699 [EFL] Adjust EFL coding style to EFL MiniBrowser
14700 https://bugs.webkit.org/show_bug.cgi?id=162119
14702 Reviewed by Michael Catanzaro.
14704 Apply EFL coding style to main.c for MiniBrowser.
14705 - Use _foo_cb instead of on_foo for callback function
14706 - Use 3 spaces and use 2 spaces in keywords.
14708 - EFL coding style.
14709 https://phab.enlightenment.org/w/coding_convention/
14711 Additionally this patch adds an exception rule that style checker doesn't
14712 check indentation rule in EFL MiniBrowser.
14714 * MiniBrowser/efl/main.c:
14715 (miniBrowserViewSmartClass):
14716 (window_find_with_ewk_view):
14718 (window_tooltip_hide):
14719 (window_tooltip_update):
14724 (_window_resize_cb):
14725 (update_view_favicon):
14726 (_icon_changed_cb):
14729 (search_icon_show):
14732 (history_list_hide):
14733 (save_page_contents_callback):
14734 (script_execute_callback):
14735 (toggle_window_fullscreen):
14738 (_title_changed_cb):
14740 (_back_forward_list_changed_cb):
14743 (_download_request_cb):
14744 (close_file_picker):
14745 (_filepicker_parent_deletion_cb):
14746 (_filepicker_deletion_cb):
14747 (_fileselector_done_cb):
14748 (_file_chooser_request_cb):
14749 (_download_finished_cb):
14750 (_download_failed_cb):
14751 (_color_changed_cb):
14752 (_color_item_selected_cb):
14753 (_color_picker_ok_clicked_cb):
14754 (_color_picker_cancel_clicked_cb):
14755 (_color_picker_dismiss_cb):
14756 (_color_picker_request_cb):
14757 (_url_bar_activated_cb):
14758 (_url_bar_clicked_cb):
14759 (_search_field_aborted_cb):
14760 (_search_field_activated_cb):
14761 (_search_field_clicked_cb):
14762 (_back_button_clicked_cb):
14763 (_forward_button_clicked_cb):
14764 (_search_backward_button_clicked_cb):
14765 (_search_forward_button_clicked_cb):
14766 (_search_case_option_changed):
14767 (_search_word_start_option_changed_cb):
14768 (_search_close_button_clicked_cb):
14769 (_refresh_button_clicked_cb):
14770 (_stop_button_clicked_cb):
14771 (_list_item_select_cb):
14772 (navigation_button_longpress_process):
14773 (_forward_button_longpress_cb):
14774 (_back_button_longpress_cb):
14776 (_file_entry_dialog_show):
14777 (_javascript_alert_cb):
14778 (_javascript_confirm_cb):
14779 (_javascript_prompt_cb):
14780 (_javascript_before_unload_confirm_cb):
14781 (_popup_menu_item_clicked_cb):
14782 (popup_menu_populate):
14783 (_popup_menu_show):
14784 (_popup_menu_hide):
14785 (_window_geometry_get):
14786 (_window_geometry_set):
14787 (_fullscreen_accept_cb):
14788 (_fullscreen_deny_cb):
14789 (_fullscreen_enter_cb):
14790 (_fullscreen_exit_cb):
14791 (_window_create_cb):
14792 (_window_close_cb):
14793 (_context_menu_item_selected_cb):
14794 (context_menu_populate):
14795 (_context_menu_show):
14796 (_context_menu_hide):
14797 (auth_popup_close):
14800 (_authentication_request_cb):
14801 (_search_text_found_cb):
14802 (_tooltip_text_set):
14803 (_tooltip_text_unset):
14804 (_navigation_policy_decision_cb):
14805 (_home_button_clicked_cb):
14806 (_window_deletion_cb):
14807 (create_toolbar_button):
14810 (parse_cookies_policy):
14811 (parse_window_size):
14813 (on_tooltip_show): Deleted.
14814 (on_mouse_in): Deleted.
14815 (on_mouse_move): Deleted.
14816 (on_mouse_out): Deleted.
14817 (on_mouse_wheel): Deleted.
14818 (on_window_resize): Deleted.
14819 (on_icon_changed_cb): Deleted.
14820 (on_key_down): Deleted.
14821 (on_mouse_down): Deleted.
14822 (on_title_changed): Deleted.
14823 (on_url_changed): Deleted.
14824 (on_back_forward_list_changed): Deleted.
14825 (on_progress): Deleted.
14826 (on_error): Deleted.
14827 (on_download_request): Deleted.
14828 (on_filepicker_parent_deletion): Deleted.
14829 (on_filepicker_deletion): Deleted.
14830 (on_fileselector_done): Deleted.
14831 (on_file_chooser_request): Deleted.
14832 (on_download_finished): Deleted.
14833 (on_download_failed): Deleted.
14834 (on_color_changed): Deleted.
14835 (on_color_item_selected): Deleted.
14836 (on_color_picker_ok_clicked): Deleted.
14837 (on_color_picker_cancel_clicked): Deleted.
14838 (on_color_picker_dismiss): Deleted.
14839 (on_color_picker_request): Deleted.
14840 (on_url_bar_activated): Deleted.
14841 (on_url_bar_clicked): Deleted.
14842 (on_search_field_aborted): Deleted.
14843 (on_search_field_activated): Deleted.
14844 (on_search_field_clicked): Deleted.
14845 (on_back_button_clicked): Deleted.
14846 (on_forward_button_clicked): Deleted.
14847 (on_search_backward_button_clicked): Deleted.
14848 (on_search_forward_button_clicked): Deleted.
14849 (on_search_case_option_changed): Deleted.
14850 (on_search_word_start_option_changed): Deleted.
14851 (on_search_close_button_clicked): Deleted.
14852 (on_refresh_button_clicked): Deleted.
14853 (on_stop_button_clicked): Deleted.
14854 (on_list_item_select): Deleted.
14855 (on_forward_button_longpress): Deleted.
14856 (on_back_button_longpress): Deleted.
14857 (on_ok_clicked): Deleted.
14858 (show_file_entry_dialog): Deleted.
14859 (on_javascript_alert): Deleted.
14860 (on_javascript_confirm): Deleted.
14861 (on_javascript_prompt): Deleted.
14862 (on_javascript_before_unload_confirm): Deleted.
14863 (on_popup_menu_item_clicked): Deleted.
14864 (on_popup_menu_show): Deleted.
14865 (on_popup_menu_hide): Deleted.
14866 (on_window_geometry_get): Deleted.
14867 (on_window_geometry_set): Deleted.
14868 (on_fullscreen_accept): Deleted.
14869 (on_fullscreen_deny): Deleted.
14870 (on_fullscreen_enter): Deleted.
14871 (on_fullscreen_exit): Deleted.
14872 (on_window_create): Deleted.
14873 (on_window_close): Deleted.
14874 (context_menu_item_selected_cb): Deleted.
14875 (on_context_menu_show): Deleted.
14876 (on_context_menu_hide): Deleted.
14877 (on_auth_cancel): Deleted.
14878 (on_auth_ok): Deleted.
14879 (on_authentication_request): Deleted.
14880 (on_search_text_found): Deleted.
14881 (on_tooltip_text_set): Deleted.
14882 (on_tooltip_text_unset): Deleted.
14883 (on_navigation_policy_decision): Deleted.
14884 (on_home_button_clicked): Deleted.
14885 (on_window_deletion): Deleted.
14886 * Scripts/webkitpy/style/checker.py:
14888 2016-09-16 Dave Hyatt <hyatt@apple.com>
14890 [CSS Parser] Get CSSPropertyParserHelpers.cpp compiling
14891 https://bugs.webkit.org/show_bug.cgi?id=162078
14893 Reviewed by Dean Jackson.
14895 * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
14896 (TestWebKitAPI::createTestValue):
14897 Convert to ValueRange.
14899 2016-09-16 Alex Christensen <achristensen@webkit.org>
14901 Fix API tests after r206036
14902 https://bugs.webkit.org/show_bug.cgi?id=162049
14904 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14905 (TestWebKitAPI::TEST_F):
14906 An emoji had been UTF-8 encoded in the patch that was applied.
14907 The test needed to check the encoding of the emoji, not the UTF-8 encoding of the emoji.
14908 Everything was correct except applying the patch before committing.
14910 2016-09-16 Wenson Hsieh <wenson_hsieh@apple.com>
14912 RequiresUserActionForPlayback TestWebKitAPI tests are broken after r206033.
14913 https://bugs.webkit.org/show_bug.cgi?id=162080
14915 Reviewed by Jer Noble.
14917 I renamed "playingHandler" to the more generalized "testHandler", but did not realize that the
14918 RequiresUserActionForPlayback tests also used "playingHandler". Renames the handler to account for this change.
14920 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
14921 (RequiresUserActionForPlaybackTest::SetUp):
14923 2016-09-16 Alex Christensen <achristensen@webkit.org>
14925 URLParser should percent encode the user and password according to spec
14926 https://bugs.webkit.org/show_bug.cgi?id=162049
14928 Reviewed by Tim Horton.
14930 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14931 (TestWebKitAPI::TEST_F):
14933 2016-09-16 Alex Christensen <achristensen@webkit.org>
14935 Fix more edge cases in URLParser
14936 https://bugs.webkit.org/show_bug.cgi?id=162051
14938 Reviewed by Tim Horton.
14940 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14941 (TestWebKitAPI::TEST_F):
14943 2016-09-16 Wenson Hsieh <wenson_hsieh@apple.com>
14945 Inserting a space after inserting an accepted candidate scrolls the document and causes a flicker
14946 https://bugs.webkit.org/show_bug.cgi?id=162009
14947 <rdar://problem/28086237>
14949 Reviewed by Tim Horton.
14951 Adds 3 new text editing API tests covering candidate insertion, as well as support for testing candidates in
14952 WKWebViews. Refactors common WKWebView helpers across both VideoControlsManager tests and the new
14953 WKWebViewCandidateTests into a new utility class, TestWKWebView in TestWKWebView.mm, which is capable of
14954 simulating mouse and keyboard events as well as waiting for JavaScript messages sent from the web process and
14955 performing actions in response.
14957 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
14958 * TestWebKitAPI/Tests/WebKit/ios/audio-only.html:
14959 * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
14960 * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
14961 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
14962 (TestWebKitAPI::TEST):
14963 (-[MessageHandler initWithMessage:handler:]): Deleted.
14964 (-[MessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
14965 (-[VideoControlsManagerTestWebView mouseDownAtPoint:]): Deleted.
14966 (-[VideoControlsManagerTestWebView performAfterLoading:]): Deleted.
14967 (-[VideoControlsManagerTestWebView callJavascriptFunction:]): Deleted.
14968 (-[VideoControlsManagerTestWebView loadTestPageNamed:]): Deleted.
14969 (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]): Deleted.
14970 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm: Added.
14971 (-[TestCandidate initWithReplacementString:inRange:]):
14972 (-[TestCandidate replacementString]):
14973 (-[TestCandidate resultType]):
14974 (-[TestCandidate range]):
14975 (-[CandidateTestWebView insertCandidatesAndWaitForResponse:range:]):
14976 (-[CandidateTestWebView _didHandleAcceptedCandidate]):
14977 (-[CandidateTestWebView expectCandidateListVisibilityUpdates:whenPerformingActions:]):
14978 (-[CandidateTestWebView _didUpdateCandidateListVisibility:]):
14980 * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html:
14981 * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html:
14982 * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html:
14983 * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html:
14984 * TestWebKitAPI/Tests/WebKit2Cocoa/input-field-in-scrollable-document.html: Added.
14985 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html:
14986 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-mutes-onplaying.html:
14987 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html:
14988 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html:
14989 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html:
14990 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html:
14991 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
14992 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html:
14993 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html:
14994 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html:
14995 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html:
14996 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html:
14997 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html:
14998 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html:
14999 * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html:
15000 * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html:
15001 * TestWebKitAPI/mac/TestWKWebViewMac.h: Added.
15002 * TestWebKitAPI/mac/TestWKWebViewMac.mm: Added.
15003 (-[TestMessageHandler initWithMessage:handler:]):
15004 (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
15005 (-[TestWKWebView mouseDownAtPoint:]):
15006 (-[TestWKWebView performAfterReceivingMessage:action:]):
15007 (-[TestWKWebView loadTestPageNamed:]):
15008 (-[TestWKWebView typeCharacter:]):
15009 (-[TestWKWebView stringByEvaluatingJavaScript:]):
15010 (-[TestWKWebView waitForMessage:]):
15011 (-[TestWKWebView performAfterLoading:]):
15013 2016-09-14 Jer Noble <jer.noble@apple.com>
15015 [media-source] fix imported/w3c/web-platform-tests/media-source/mediasource-duration.html
15016 https://bugs.webkit.org/show_bug.cgi?id=161999
15018 Reviewed by Eric Carlson.
15020 * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
15021 (TestWebKitAPI::TEST):
15023 2016-09-16 Anders Carlsson <andersca@apple.com>
15025 Fix isValidEnum to work with older versions of GCC
15026 https://bugs.webkit.org/show_bug.cgi?id=162065
15028 Reviewed by Michael Catanzaro.
15030 Add EnumTraits.cpp to the CMake build.
15032 * TestWebKitAPI/CMakeLists.txt:
15034 2016-09-16 Nael Ouedraogo <nael.ouedraogo@crf.canon.fr>
15036 Unreviewed: Change my primary address for auto-complete in bugzilla.
15038 * Scripts/webkitpy/common/config/contributors.json:
15040 2016-09-15 Alex Christensen <achristensen@webkit.org>
15042 URLParser: Check for invalid characters in the host
15043 https://bugs.webkit.org/show_bug.cgi?id=162023
15045 Reviewed by Tim Horton.
15047 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15048 (TestWebKitAPI::TEST_F):
15050 2016-09-15 Fujii Hironori <Hironori.Fujii@sony.com>
15052 [CMake] Refactor GENERATE_BINDINGS
15053 https://bugs.webkit.org/show_bug.cgi?id=161854
15055 Reviewed by Gyuyoung Kim.
15057 * DumpRenderTree/CMakeLists.txt: Changed the arguments of
15058 GENERATE_BINDINGS to new style.
15059 * WebKitTestRunner/CMakeLists.txt: Ditto.
15061 2016-09-15 Ryan Haddad <ryanhaddad@apple.com>
15063 Disable failing API WebKit2.DataDetectionReferenceDate until it can be investigated.
15064 https://bugs.webkit.org/show_bug.cgi?id=161967
15066 Unreviewed test gardening.
15068 * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
15071 2016-09-15 Per Arne Vollan <pvollan@apple.com>
15073 [Win] run-api-tests is failing.
15074 https://bugs.webkit.org/show_bug.cgi?id=162015
15076 Reviewed by Brent Fulgham.
15078 MSVC is not interpreting C++ string literals with unicode characters correctly when the source file
15079 doesn't contain encoding information. Save the file with utf8 encoding with signature.
15081 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15083 2016-09-15 Jonathan Bedard <jbedard@apple.com>
15085 Move --no-sample-on-timeout to config.json for each bot
15086 https://bugs.webkit.org/show_bug.cgi?id=161964
15088 Reviewed by Daniel Bates.
15090 Roll out changes from 205573 and move them into config.json. At this time, only macOS and iOS simulator sample a process on timeout, —no-sample-on-timeout is unneeded for GTK, EFL and Windows.
15092 * BuildSlaveSupport/build.webkit.org-config/config.json: Each bot now independently defines if it will be running sample on timeout.
15093 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
15094 (RunWebKitTests.start): Rolled out changes from 205573.
15096 2016-09-15 Csaba Osztrogonác <ossy@webkit.org>
15098 js/stringimpl-to-jsstring-on-large-strings tests consume huge memory
15099 https://bugs.webkit.org/show_bug.cgi?id=159807
15101 Reviewed by Saam Barati.
15103 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
15104 (RunRemoteJavaScriptCoreTests.start): JSCOnly bots are memory limited devices, tests should run with --memory-limited option.
15105 * Scripts/run-javascriptcore-tests:
15106 (runJSCStressTests): Pass through --memory-limited option to run-jsc-stress-tests.
15107 * Scripts/run-jsc-stress-tests: Typo fix.
15109 2016-09-14 Wenson Hsieh <wenson_hsieh@apple.com>
15111 Media controls behave strangely when changing media sources
15112 https://bugs.webkit.org/show_bug.cgi?id=161914
15113 <rdar://problem/28227805>
15115 Reviewed by Tim Horton.
15117 Adds three new unit tests verifying that media controls remain stable during common `src` change scenarios. Also
15118 tweaks an existing test to account for new `ended` behavior.
15120 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
15121 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
15122 (-[VideoControlsManagerTestWebView waitForMediaControlsToShow]):
15123 (-[VideoControlsManagerTestWebView waitForMediaControlsToHide]):
15124 (TestWebKitAPI::TEST):
15125 * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html: Added.
15126 * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html: Added.
15127 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html: Added.
15129 2016-09-14 Jonathan Bedard <jbedard@apple.com>
15131 Fix mastercfg_unittest
15132 https://bugs.webkit.org/show_bug.cgi?id=161816
15134 Reviewed by Daniel Bates.
15136 (RunWebKitTests.start):
15137 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Fixed broken unit tests.
15139 2016-09-13 Alexey Proskuryakov <ap@apple.com>
15141 Landing optimized .png files, forgot to do it initially.
15143 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
15144 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
15145 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
15146 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
15147 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
15149 2016-09-13 Alexey Proskuryakov <ap@apple.com>
15151 Switch build.webkit.org to iOS 10
15152 https://bugs.webkit.org/show_bug.cgi?id=161930
15154 Reviewed by Daniel Bates.
15156 * BuildSlaveSupport/build.webkit.org-config/config.json:
15157 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
15158 (RunWebKitTests.start):
15159 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
15160 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png: Added.
15161 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png: Added.
15162 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png: Added.
15163 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png: Added.
15164 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
15165 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
15166 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png: Added.
15167 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png: Added.
15168 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
15169 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
15170 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
15171 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
15172 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
15173 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
15174 * Scripts/webkitpy/port/ios.py:
15175 * TestResultServer/static-dashboards/builders.jsonp:
15177 2016-09-13 Tim Horton <timothy_horton@apple.com>
15179 Provide a mechanism to specify the maximum width of WKThumbnailView snapshots
15180 https://bugs.webkit.org/show_bug.cgi?id=161896
15181 <rdar://problem/28229827>
15183 Reviewed by Simon Fraser.
15185 * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm:
15186 (TestWebKitAPI::TEST):
15187 Add a test for the new property.
15188 Also fix the old new test to run on arbitrary scale displays without failing.
15190 2016-09-12 Brent Fulgham <bfulgham@apple.com>
15192 [Win][Direct2D] Provide Direct2D-based geometry and transform cast operations
15193 https://bugs.webkit.org/show_bug.cgi?id=161818
15195 Reviewed by Dean Jackson.
15197 Add several new test suites for the various geometric primitives in WebCore.
15199 * TestWebKitAPI/PlatformWin.cmake: Add new files for test cases.
15200 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
15201 * TestWebKitAPI/Tests/WebCore/AffineTransform.cpp: Added.
15202 * TestWebKitAPI/Tests/WebCore/FloatPoint.cpp: Added.
15203 * TestWebKitAPI/Tests/WebCore/FloatRect.cpp: Added.
15204 * TestWebKitAPI/Tests/WebCore/FloatSize.cpp: Added.
15205 * TestWebKitAPI/Tests/WebCore/IntPoint.cpp: Added.
15206 * TestWebKitAPI/Tests/WebCore/IntRect.cpp: Added.
15207 * TestWebKitAPI/Tests/WebCore/IntSize.cpp: Added.
15208 * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Add some new
15209 Windows-focused test cases.
15211 2016-09-12 Chris Dumez <cdumez@apple.com>
15213 Fix post-landing review comments after r205787
15214 https://bugs.webkit.org/show_bug.cgi?id=161885
15216 Reviewed by Darin Adler.
15218 Leverage new StringBuilder::append(CFStringRef) overload.
15220 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
15221 (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
15223 2016-09-12 Alex Christensen <achristensen@webkit.org>
15225 URLParser: Correctly ignore spaces before relative URLs with no scheme
15226 https://bugs.webkit.org/show_bug.cgi?id=161889
15228 Reviewed by Daniel Bates.
15230 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15231 (TestWebKitAPI::TEST_F):
15233 2016-09-12 Alex Christensen <achristensen@webkit.org>
15235 URLParser: Fix relative URLs containing only fragments
15236 https://bugs.webkit.org/show_bug.cgi?id=161882
15238 Reviewed by Brady Eidson.
15240 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15241 (TestWebKitAPI::TEST_F):
15243 2016-09-12 Alex Christensen <achristensen@webkit.org>
15245 URLParser: Correctly handle relative URLs that are just a scheme and a colon
15246 https://bugs.webkit.org/show_bug.cgi?id=161876
15248 Reviewed by Brady Eidson.
15250 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15251 (TestWebKitAPI::TEST_F):
15253 2016-09-12 DAN SAUNDERS <dasau@microsoft.com>
15255 AX: WKWebView for macOS does not allow configuration of tabsToLinks
15256 https://bugs.webkit.org/show_bug.cgi?id=161394
15258 Reviewed by Anders Carlsson.
15260 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
15263 2016-09-12 Alex Christensen <achristensen@webkit.org>
15265 Remove trailing control characters and spaces before parsing a URL
15266 https://bugs.webkit.org/show_bug.cgi?id=161870
15268 Reviewed by Tim Horton.
15270 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15271 (TestWebKitAPI::TEST_F):
15273 2016-09-12 Alex Christensen <achristensen@webkit.org>
15275 Fix more URLParser quirks
15276 https://bugs.webkit.org/show_bug.cgi?id=161834
15278 Reviewed by Brady Eidson.
15280 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15281 (TestWebKitAPI::TEST_F):
15283 2016-09-10 Alex Christensen <achristensen@webkit.org>
15285 Optimize URLParser performance
15286 https://bugs.webkit.org/show_bug.cgi?id=161837
15288 Reviewed by Brady Eidson.
15290 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15291 (TestWebKitAPI::TEST_F):
15292 Added a test to verify the case insensitivity of the default port checks.
15294 2016-09-10 Chris Dumez <cdumez@apple.com>
15296 parseHTMLInteger() should take a StringView in parameter
15297 https://bugs.webkit.org/show_bug.cgi?id=161669
15299 Reviewed by Ryosuke Niwa.
15301 Explicitly construct a String from the CFStringRef in order to call
15302 StringBuilder::append(). This is needed now that there is an append()
15303 overload taking an AtomicString in parameter.
15305 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
15306 (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
15308 2016-09-10 Wenson Hsieh <wenson_hsieh@apple.com>
15310 Apple.com keynote does not display media controls
15311 https://bugs.webkit.org/show_bug.cgi?id=161833
15312 <rdar://problem/28230123>
15314 Reviewed by Tim Horton.
15316 New unit test verifying that wide videos (~2 aspect ratio) still get media controls.
15318 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
15319 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
15320 (TestWebKitAPI::TEST):
15321 * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html: Added.
15323 2016-09-09 Tim Horton <timothy_horton@apple.com>
15325 WKThumbnailView should expose a mode where it can be reparented without resnapshotting
15326 https://bugs.webkit.org/show_bug.cgi?id=161828
15327 <rdar://problem/28229756>
15329 Reviewed by Alex Christensen.
15331 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
15332 * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm: Added.
15333 (-[SnapshotSizeObserver observeValueForKeyPath:ofObject:change:context:]):
15334 (TestWebKitAPI::didFinishLoadForFrame):
15335 (TestWebKitAPI::setPageLoaderClient):
15336 (TestWebKitAPI::TEST):
15337 Add a test ensuring that this behaves correctly.
15339 2016-09-09 Alex Christensen <achristensen@webkit.org>
15341 URLParser: Keep track of cannot-be-a-base-url according to spec
15342 https://bugs.webkit.org/show_bug.cgi?id=161830
15344 Reviewed by Tim Horton.
15346 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15347 (TestWebKitAPI::TEST_F):
15349 2016-09-09 Alex Christensen <achristensen@webkit.org>
15351 Fix API tests after r205774.
15352 https://bugs.webkit.org/show_bug.cgi?id=161820
15354 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15355 (TestWebKitAPI::TEST_F):
15356 I had committed the wrong expected path in one case. The functionality is correct.
15358 2016-09-09 Michael Saboff <msaboff@apple.com>
15360 Unreviewed, rolling r205759 back in with a fix.
15362 An expectation file, JSTests/ChakraCore/test/Lib/tostring.baseline-jsc,
15363 should be named "toString.baseline-jsc". For systems with case-insensitive
15364 filesystems, the wrong name isn't an issue. That rename is part of this
15367 * Scripts/run-javascriptcore-tests:
15368 (runJSCStressTests):
15370 2016-09-09 Johan K. Jensen <johan_jensen@apple.com>
15372 Unreviewed. Added myself to the list of committers.
15374 * Scripts/webkitpy/common/config/contributors.json:
15376 2016-09-09 Alex Christensen <achristensen@webkit.org>
15378 URLParser should convert ASCII hosts to lowercase
15379 https://bugs.webkit.org/show_bug.cgi?id=161820
15381 Reviewed by Geoffrey Garen.
15383 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15384 (TestWebKitAPI::TEST_F):
15386 2016-09-09 Ryan Haddad <ryanhaddad@apple.com>
15388 Unreviewed, rolling out r205759.
15390 This change broke all JSC tests
15392 Reverted changeset:
15394 "Add ChakraCore tests to run-javascriptcore-tests"
15395 https://bugs.webkit.org/show_bug.cgi?id=161808
15396 http://trac.webkit.org/changeset/205759
15398 2016-09-09 Ryan Haddad <ryanhaddad@apple.com>
15400 Revert r205770 because Ricky is already a committer.
15404 * Scripts/webkitpy/common/config/contributors.json:
15406 2016-09-09 Ricky Mondello <rmondello@apple.com>
15408 Unreviewed. Added myself to the list of committers.
15410 * Scripts/webkitpy/common/config/contributors.json:
15412 2016-09-09 Alex Christensen <achristensen@webkit.org>
15414 URLParser: Fix and optimize parsing file URLs ending with a host but no slash
15415 https://bugs.webkit.org/show_bug.cgi?id=161815
15417 Reviewed by Geoffrey Garen.
15419 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15420 (TestWebKitAPI::TEST_F):
15422 2016-09-08 Dean Jackson <dino@apple.com>
15424 Expose Apple Pencil data to Touch events
15425 https://bugs.webkit.org/show_bug.cgi?id=161783
15426 <rdar://problem/28218898>
15428 Reviewed by Beth Dakin.
15430 The values that IOHID expects are different from their
15431 documentation, and from what UITouch interprets. Tweak
15432 incoming data so it will produce the output we expect.
15434 * WebKitTestRunner/ios/HIDEventGenerator.mm:
15435 (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:]):
15436 (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:]):
15438 2016-09-09 JF Bastien <jfbastien@apple.com>
15440 Unreviewed. Added myself to the list of committers.
15442 * Scripts/webkitpy/common/config/contributors.json:
15444 2016-09-09 Michael Saboff <msaboff@apple.com>
15446 Add ChakraCore tests to run-javascriptcore-tests
15447 https://bugs.webkit.org/show_bug.cgi?id=161808
15449 Reviewed by Saam Barati.
15451 Added ChakraCore tests to the default list of tests to run.
15453 * Scripts/run-javascriptcore-tests:
15454 (runJSCStressTests):
15456 2016-09-09 Alex Christensen <achristensen@webkit.org>
15458 URLParser: Handle \ in path according to spec
15459 https://bugs.webkit.org/show_bug.cgi?id=161805
15461 Reviewed by Andy Estes.
15463 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15464 (TestWebKitAPI::TEST_F):
15466 2016-09-09 Alex Christensen <achristensen@webkit.org>
15468 URLParser should parse URLs with non-special schemes
15469 https://bugs.webkit.org/show_bug.cgi?id=161786
15471 Reviewed by Andy Estes.
15473 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15474 (TestWebKitAPI::TEST_F):
15476 2016-09-08 Yusuke Suzuki <utatane.tea@gmail.com>
15478 [WTF] HashTable's rehash is not compatible to Ref<T> and ASan
15479 https://bugs.webkit.org/show_bug.cgi?id=161763
15481 Reviewed by Mark Lam.
15483 Add tests that inserts many Ref<>s. It incurs HashTable::rehash, and we can ensure
15484 that ASan crash does not occur with this patch.
15486 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
15487 (TestWebKitAPI::TEST):
15488 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
15489 (TestWebKitAPI::TEST):
15491 2016-09-08 Alex Christensen <achristensen@webkit.org>
15493 URLParser: Handle \ in paths of special URLs according to spec
15494 https://bugs.webkit.org/show_bug.cgi?id=161781
15496 Reviewed by Tim Horton.
15498 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15499 (TestWebKitAPI::TEST_F):
15501 2016-09-08 Simon Fraser <simon.fraser@apple.com>
15503 Update the content-animation.plan file to run css-accelerated-animation.html
15504 and pull SVN revision r205680.
15506 * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
15508 2016-09-08 Simon Fraser <simon.fraser@apple.com>
15510 Add a content-animation test with accelerated CSS animations
15511 https://bugs.webkit.org/show_bug.cgi?id=161776
15513 Reviewed by Dean Jackson.
15515 * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
15517 2016-09-08 Alex Christensen <achristensen@webkit.org>
15519 URLParser: Parsing empty URLs with a base URL should return the base URL
15520 https://bugs.webkit.org/show_bug.cgi?id=161777
15522 Reviewed by Tim Horton.
15524 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15525 (TestWebKitAPI::TEST_F):
15527 2016-09-08 Alex Christensen <achristensen@webkit.org>
15529 URLParser failures should preserve the original input string
15530 https://bugs.webkit.org/show_bug.cgi?id=161769
15532 Reviewed by Tim Horton.
15534 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15535 (TestWebKitAPI::TEST_F):
15536 (TestWebKitAPI::shouldFail):
15538 2016-09-08 Alex Christensen <achristensen@webkit.org>
15540 URLParser should parse URLs with a user but no password
15541 https://bugs.webkit.org/show_bug.cgi?id=161773
15543 Reviewed by Brady Eidson.
15545 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15546 (TestWebKitAPI::TEST_F):
15548 2016-09-08 Alex Christensen <achristensen@webkit.org>
15550 URLParser should parse ports after IPv4 and IPv6 hosts
15551 https://bugs.webkit.org/show_bug.cgi?id=161731
15553 Reviewed by Brady Eidson.
15555 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15556 (TestWebKitAPI::TEST_F):
15558 2016-09-08 Alex Christensen <achristensen@webkit.org>
15560 URLParser should correctly handle \ in path
15561 https://bugs.webkit.org/show_bug.cgi?id=161762
15563 Reviewed by Brady Eidson.
15565 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15566 (TestWebKitAPI::TEST_F):
15568 2016-09-08 Alex Christensen <achristensen@webkit.org>
15570 URLParser should handle URLs with empty authority
15571 https://bugs.webkit.org/show_bug.cgi?id=161711
15573 Reviewed by Brady Eidson.
15575 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15576 (TestWebKitAPI::TEST_F):
15578 2016-09-08 Alex Christensen <achristensen@webkit.org>
15580 Re-land r205580 after r205649 fixed the test failures
15581 https://bugs.webkit.org/show_bug.cgi?id=161668
15583 Re-landing changesets:
15585 "Punycode encode non-ascii hosts in URLParser"
15586 https://bugs.webkit.org/show_bug.cgi?id=161655
15587 http://trac.webkit.org/changeset/205521
15589 "Fix query-only and fragment-only relative URLs when using
15591 https://bugs.webkit.org/show_bug.cgi?id=161657
15592 http://trac.webkit.org/changeset/205526
15594 "URLParser should parse / as a relative URL"
15595 https://bugs.webkit.org/show_bug.cgi?id=161667
15596 http://trac.webkit.org/changeset/205532
15598 2016-09-08 Dean Jackson <dino@apple.com>
15600 Expose Apple Pencil input to testing system
15601 https://bugs.webkit.org/show_bug.cgi?id=161670
15602 <rdar://problem/28183327>
15604 I fixed the internal builds, now try to fix the public builds.
15606 * WebKitTestRunner/ios/IOKitSPI.h: Add new enum values.
15608 2016-09-07 Dean Jackson <dino@apple.com>
15610 Expose Apple Pencil input to testing system
15611 https://bugs.webkit.org/show_bug.cgi?id=161670
15612 <rdar://problem/28183327>
15614 Attempt to fix iOS 9 builds.
15616 * WebKitTestRunner/ios/HIDEventGenerator.mm:
15617 (-[HIDEventGenerator _createIOHIDEventType:]):
15619 2016-09-07 Alex Christensen <achristensen@webkit.org>
15621 Roll out r205580 and r205582.
15622 https://bugs.webkit.org/show_bug.cgi?id=161668
15624 I need to figure out why this is failing on the bots before landing any more URLParser progress.
15626 2016-09-07 Alex Christensen <achristensen@webkit.org>
15628 Unreviewed, revert r205533.
15629 https://bugs.webkit.org/show_bug.cgi?id=161668
15631 Re-landing changesets:
15633 "Punycode encode non-ascii hosts in URLParser"
15634 https://bugs.webkit.org/show_bug.cgi?id=161655
15635 http://trac.webkit.org/changeset/205521
15637 "Fix query-only and fragment-only relative URLs when using
15639 https://bugs.webkit.org/show_bug.cgi?id=161657
15640 http://trac.webkit.org/changeset/205526
15642 "URLParser should parse / as a relative URL"
15643 https://bugs.webkit.org/show_bug.cgi?id=161667
15644 http://trac.webkit.org/changeset/205532
15646 2016-09-07 Simon Fraser <simon.fraser@apple.com>
15648 Enable the <meter> element on iOS
15649 https://bugs.webkit.org/show_bug.cgi?id=161714
15650 rdar://problem/8978410
15652 Reviewed by Tim Horton.
15654 Define ENABLE_METER_ELEMENT unconditionally now.
15656 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
15658 2016-09-07 Jonathan Bedard <jbedard@apple.com>
15660 Run spindumps on timeout on iOS 9 Simulator Release WK2 (Tests)
15661 https://bugs.webkit.org/show_bug.cgi?id=161699
15663 Reviewed by Alexey Proskuryakov.
15665 This change does not have testing associated with it because the testing infrastructure does not exists, we cannot currently mock build-bot variables.
15667 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
15668 (RunWebKitTests): Enable sample on timeout for everything.
15669 (RunWebKitTests.start): Disable sample on timeout for everything except iOS 9 WK2 release simulators.
15671 2016-09-06 Dean Jackson <dino@apple.com>
15673 Expose Apple Pencil input to testing system
15674 https://bugs.webkit.org/show_bug.cgi?id=161670
15675 <rdar://problem/28183327>
15677 Reviewed by Simon Fraser.
15679 Add API to UIScriptController that allows a test to emulate
15680 stylus input, such as from the Apple Pencil.
15682 The code is only implemented for WebKitTestRunner.
15684 There are also four new tests that ensure an Apple Pencil
15685 operates similarly to a regular touch. The main difference
15686 is that you can't have multiple touches when using an Apple Pencil.
15688 * DumpRenderTree/ios/UIScriptControllerIOS.mm: New methods. Empty implementations.
15689 (WTR::UIScriptController::stylusDownAtPoint):
15690 (WTR::UIScriptController::stylusMoveToPoint):
15691 (WTR::UIScriptController::stylusUpAtPoint):
15692 (WTR::UIScriptController::stylusTapAtPoint):
15693 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: New methods.
15694 * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Empty implementations.
15695 (WTR::UIScriptController::stylusDownAtPoint):
15696 (WTR::UIScriptController::stylusMoveToPoint):
15697 (WTR::UIScriptController::stylusUpAtPoint):
15698 (WTR::UIScriptController::stylusTapAtPoint):
15699 * TestRunnerShared/UIScriptContext/UIScriptController.h:
15701 * WebKitTestRunner/ios/HIDEventGenerator.h:
15702 * WebKitTestRunner/ios/HIDEventGenerator.mm: New StylusEvent types. Add some properties
15703 to SyntheticEventDigitizerInfo.
15704 (-[HIDEventGenerator _createIOHIDEventType:]): Add support for StylusEvent types.
15705 (-[HIDEventGenerator touchDownAtPoints:touchCount:]): Clear any old stylus info.
15706 (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:]):
15707 (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:]):
15708 (-[HIDEventGenerator stylusUpAtPoint:]):
15709 (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
15710 (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
15711 (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
15712 (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
15713 * WebKitTestRunner/ios/IOKitSPI.h: Add new include, and new SPI.
15714 * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Calls into the HIDEventGenerator for the new API.
15715 (WTR::UIScriptController::stylusDownAtPoint):
15716 (WTR::UIScriptController::stylusMoveToPoint):
15717 (WTR::UIScriptController::stylusUpAtPoint):
15718 (WTR::UIScriptController::stylusTapAtPoint):
15720 2016-09-07 Daniel Bates <dabates@apple.com>
15722 Update WebKitSystemInterface
15724 Rubber-stamped by Dean Jackson.
15726 Copy WebKitSystemInterface for iOS 10 to the built products directory.
15728 * Scripts/copy-webkitlibraries-to-product-directory:
15730 2016-09-07 Youenn Fablet <youenn@apple.com>
15732 [Streams API] Separate compile flag for ReadableStream and WritableStream
15733 https://bugs.webkit.org/show_bug.cgi?id=161044
15735 Reviewed by Alex Christensen.
15737 Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
15739 * Scripts/webkitperl/FeatureList.pm:
15740 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
15742 2016-09-07 Carlos Garcia Campos <cgarcia@igalia.com>
15744 [GTK] Move some GObject DOM unstable API to stable
15745 https://bugs.webkit.org/show_bug.cgi?id=161681
15747 Reviewed by Žan Doberšek.
15749 Do not use user message handler unstable API in the tests, since we have stable convenient API for that.
15751 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
15752 (testUserContentManagerScriptMessageFromDOMBindings):
15753 (serverCallback): Deleted.
15754 (beforeAll): Deleted.
15755 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
15756 (documentLoadedCallback):
15757 (emitURIChanged): Deleted.
15759 2016-09-07 Youenn Fablet <youenn@apple.com>
15761 Using tests-options.json to compute whether tests are slow
15762 https://bugs.webkit.org/show_bug.cgi?id=161626
15764 Reviewed by Darin Adler.
15766 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Updated first test to use a MockHost.
15767 * Scripts/webkitpy/layout_tests/controllers/manager.py:
15768 (Manager.__init__): Loading tests-options.json
15769 (Manager._test_is_slow): Computing timeout value based on tests-options.json.
15771 2016-09-07 Hunseop Jeong <hs85.jeong@samsung.com>
15773 [EFL] Need the libosmesa to support the software backend drawing.
15774 https://bugs.webkit.org/show_bug.cgi?id=147065
15776 Reviewed by Gyuyoung Kim.
15778 Added the libosmesa to support the software backend drawing.
15780 * efl/install-dependencies:
15782 2016-09-06 Commit Queue <commit-queue@webkit.org>
15784 Unreviewed, rolling out r205521, r205526, and r205532.
15785 https://bugs.webkit.org/show_bug.cgi?id=161668
15787 broke API tests (Requested by alexchristensen on #webkit).
15789 Reverted changesets:
15791 "Punycode encode non-ascii hosts in URLParser"
15792 https://bugs.webkit.org/show_bug.cgi?id=161655
15793 http://trac.webkit.org/changeset/205521
15795 "Fix query-only and fragment-only relative URLs when using
15797 https://bugs.webkit.org/show_bug.cgi?id=161657
15798 http://trac.webkit.org/changeset/205526
15800 "URLParser should parse / as a relative URL"
15801 https://bugs.webkit.org/show_bug.cgi?id=161667
15802 http://trac.webkit.org/changeset/205532
15804 2016-09-06 Alex Christensen <achristensen@webkit.org>
15806 URLParser should parse / as a relative URL
15807 https://bugs.webkit.org/show_bug.cgi?id=161667
15809 Reviewed by Tim Horton.
15811 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15812 (TestWebKitAPI::TEST_F):
15814 2016-09-06 Daniel Bates <dabates@apple.com>
15816 [iOS] DumpRenderTree and WebKitTestRunner fail to build - "Ad Hoc code signing is not allowed with SDK 'Simulator - iOS 10.0'"
15817 https://bugs.webkit.org/show_bug.cgi?id=161661
15819 Reviewed by Darin Adler.
15821 Allow ad-hoc code signing when building the dummy DumpRenderTree and WebKitTestRunner
15822 command line tools for simulator with the iOS 10 beta SDK.
15824 * DumpRenderTree/mac/Configurations/Base.xcconfig:
15825 * WebKitTestRunner/Configurations/Base.xcconfig:
15827 2016-09-06 Alex Christensen <achristensen@webkit.org>
15829 Fix query-only and fragment-only relative URLs when using URLParser
15830 https://bugs.webkit.org/show_bug.cgi?id=161657
15832 Reviewed by Tim Horton.
15834 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15835 (TestWebKitAPI::TEST_F):
15837 2016-09-06 Alex Christensen <achristensen@webkit.org>
15839 Punycode encode non-ascii hosts in URLParser
15840 https://bugs.webkit.org/show_bug.cgi?id=161655
15842 Reviewed by Tim Horton.
15844 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15845 (TestWebKitAPI::wideString):
15846 (TestWebKitAPI::TEST_F):
15848 2016-09-05 Alex Christensen <achristensen@webkit.org>
15850 Implement relative file urls and begin implementing character encoding in URLParser
15851 https://bugs.webkit.org/show_bug.cgi?id=161618
15853 Reviewed by Tim Horton.
15855 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
15856 (TestWebKitAPI::TEST_F):
15858 2016-09-06 Commit Queue <commit-queue@webkit.org>
15860 Unreviewed, rolling out r205480.
15861 https://bugs.webkit.org/show_bug.cgi?id=161630
15863 tests-options.json is not known from knockout filesystem
15864 (Requested by youenn on #webkit).
15866 Reverted changeset:
15868 "Using tests-options.json to compute whether tests are slow"
15869 https://bugs.webkit.org/show_bug.cgi?id=161626
15870 http://trac.webkit.org/changeset/205480
15872 2016-09-06 Michael Catanzaro <mcatanzaro@igalia.com>
15874 "Redundant argument in sprintf" warning spam from prepare-ChangeLog
15875 https://bugs.webkit.org/show_bug.cgi?id=161606
15877 Reviewed by Darin Adler.
15879 Avoid extra arguments in call to sprintf, hopefully without introducing new warnings this
15882 * Scripts/prepare-ChangeLog:
15883 (statusDescription):
15885 2016-09-06 Youenn Fablet <youenn@apple.com>
15887 Using tests-options.json to compute whether tests are slow
15888 https://bugs.webkit.org/show_bug.cgi?id=161626
15890 Reviewed by Darin Adler.
15892 * Scripts/webkitpy/layout_tests/controllers/manager.py:
15893 (Manager.__init__): Loading tests-options.json
15894 (Manager._test_is_slow): Computing timeout value based on tests-options.json.
15896 2016-09-06 Commit Queue <commit-queue@webkit.org>
15898 Unreviewed, rolling out r205461.
15899 https://bugs.webkit.org/show_bug.cgi?id=161628
15901 Introduced "Use of uninitialized value $original in sprintf"
15902 warning (Requested by mcatanzaro on #webkit).
15904 Reverted changeset:
15906 ""Redundant argument in sprintf" warning spam from prepare-
15908 https://bugs.webkit.org/show_bug.cgi?id=161606
15909 http://trac.webkit.org/changeset/205461
15911 2016-09-06 Youenn Fablet <youenn@apple.com>
15913 W3C test importer should be able to identify slow test
15914 https://bugs.webkit.org/show_bug.cgi?id=161601
15916 Reviewed by Darin Adler.
15918 Test parser is now identifying slow tests based on "meta element name=timeout content=long" elements.
15919 Test importer is updating test-options.json file according that information.
15921 In case of clean import, the test-options.json is cleaned from 'slow' options for all W3C tests.
15923 * Scripts/webkitpy/w3c/test_importer.py:
15924 (TestImporter.__init__):
15925 (TestImporter.find_importable_tests):
15926 (TestImporter.import_tests):
15927 (TestImporter.update_test_options):
15929 (TestImporter.remove_slow_from_w3c_test_options):
15930 * Scripts/webkitpy/w3c/test_parser.py:
15931 (TestParser.analyze_test):
15932 (TestParser.is_slow_test):
15933 (TestParser.potential_ref_filename):
15935 2016-09-06 Per Arne Vollan <pvollan@apple.com>
15937 [Win] Crash logs have incorrect symbols.
15938 https://bugs.webkit.org/show_bug.cgi?id=161603
15940 Reviewed by Darin Adler.
15942 Add build path to _NT_SYMBOL_PATH environment variable.
15944 * Scripts/webkitpy/port/win.py:
15945 (WinPort.setup_crash_log_saving):
15947 2016-08-31 Filip Pizlo <fpizlo@apple.com>
15949 Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
15950 https://bugs.webkit.org/show_bug.cgi?id=160125
15952 Reviewed by Geoffrey Garen and Keith Miller.
15954 * DumpRenderTree/TestRunner.cpp:
15955 * DumpRenderTree/mac/DumpRenderTree.mm:
15956 (DumpRenderTreeMain):
15957 * Scripts/run-jsc-stress-tests:
15958 * TestWebKitAPI/Tests/WTF/Vector.cpp:
15959 (TestWebKitAPI::TEST):
15961 2016-09-05 Michael Catanzaro <mcatanzaro@igalia.com>
15963 "Redundant argument in sprintf" warning spam from prepare-ChangeLog
15964 https://bugs.webkit.org/show_bug.cgi?id=161606
15966 Reviewed by Darin Adler.
15968 Avoid extra arguments in call to sprintf.
15970 * Scripts/prepare-ChangeLog:
15971 (statusDescription):
15973 2016-09-05 Michael Catanzaro <mcatanzaro@igalia.com>
15975 [GTK] Skip several failing API tests
15977 Unfortunately we don't have any form of test expectations for API tests, so we'll just skip
15978 them after bugs are filed.
15980 * Scripts/run-gtk-tests:
15983 2016-09-05 Youenn Fablet <youenn@apple.com>
15985 Fix W3C test importer unit tests after r205447
15986 https://bugs.webkit.org/show_bug.cgi?id=161604
15990 * Scripts/webkitpy/w3c/test_importer.py:
15991 (TestImporter.__init__): Skip cleaning test_resource_files files if resource-files.json cannot be read.
15993 2016-09-05 Philippe Normand <pnormand@igalia.com>
15995 WebRTC: Several media stream tests crashing
15996 https://bugs.webkit.org/show_bug.cgi?id=161582
15998 Reviewed by Alejandro G. Castro.
16000 * gtk/jhbuild.modules: Bump to latest OpenWebRTC master fixing the crash on missing
16001 glvideoflip GStreamer element.
16003 2016-09-05 Youenn Fablet <youenn@apple.com>
16005 W3C test importer should generate the list of resource files
16006 https://bugs.webkit.org/show_bug.cgi?id=161578
16008 Reviewed by Ryosuke Niwa.
16010 Generating LayoutTests/imported/w3c/resources/resource-files.json when importing tests.
16012 * Scripts/webkitpy/w3c/test_importer.py:
16013 (TestImporter.__init__): Reading test resource files configuration file.
16014 (TestImporter.find_importable_tests):
16015 (TestImporter.import_tests): Update the test resource files based on test parsed files.
16017 (TestImporter._already_identified_as_resource_file): Helper routine to know whether a file is already set as a resource file.
16018 (TestImporter._is_in_resources_directory: Helper routine to know whether a file is in a resources directory.
16020 2016-09-03 Wenson Hsieh <wenson_hsieh@apple.com>
16022 Media controls behave strangely when videos mute from within a playing handler
16023 https://bugs.webkit.org/show_bug.cgi?id=161559
16024 <rdar://problem/28018438>
16026 Reviewed by Darin Adler.
16028 Accounts for changes when determining whether or not to show media controls for autoplaying videos that have not
16029 begun playing yet. Rather than check for a controlled media element upon page load, we force tests to wait until
16030 all autoplaying videos have actually begun playing. This extends to tests that involve interaction, such as
16031 clicking or scrolling.
16033 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
16034 (-[VideoControlsManagerTestWebView callJavascriptFunction:]):
16035 (-[VideoControlsManagerTestWebView expectControlsManager:afterReceivingMessage:]):
16036 (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
16037 (-[VideoControlsManagerTestWebView waitForPageToLoadWithAutoplayingVideos:]):
16038 (TestWebKitAPI::TEST):
16039 (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]): Deleted.
16040 * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html:
16041 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html:
16042 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html:
16043 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html:
16044 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html:
16045 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html:
16046 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html:
16047 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html:
16048 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html:
16050 2016-09-03 Wenson Hsieh <wenson_hsieh@apple.com>
16052 Refactor the heuristic for showing media controls to take all media sessions into account
16053 https://bugs.webkit.org/show_bug.cgi?id=161503
16054 <rdar://problem/28033783>
16056 Reviewed by Darin Adler.
16058 Adds new unit tests verifying the behavior of media playback controls when scrolling another video into view.
16059 Please see the WebCore ChangeLog for more details about this change. Also refactors existing
16060 VideoControlsManager tests by folding duplicated setup and testing logic into helper methods to make the unit
16061 tests more readable.
16063 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16064 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
16065 (-[MessageHandler initWithMessage:handler:]):
16066 (-[MessageHandler userContentController:didReceiveScriptMessage:]):
16067 (-[VideoControlsManagerTestWebView performAfterLoading:]):
16068 (-[VideoControlsManagerTestWebView loadTestPageNamed:]):
16069 (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]):
16070 (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
16071 (-[VideoControlsManagerTestWebView controlledElementID]):
16072 (-[VideoControlsManagerTestWebView _handleControlledElementIDResponse:]):
16073 (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
16074 (TestWebKitAPI::TEST):
16075 (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]): Deleted.
16076 (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
16077 (-[OnLoadMessageHandler initWithWKWebView:handler:]): Deleted.
16078 (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
16079 (-[WKWebView performAfterLoading:]): Deleted.
16080 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: Added.
16081 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: Added.
16082 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: Added.
16083 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: Added.
16084 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: Added.
16085 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: Added.
16087 2016-09-03 Youenn Fablet <youenn@apple.com>
16089 run-webkit-tests should detect w3c test resource files
16090 https://bugs.webkit.org/show_bug.cgi?id=161307
16092 Reviewed by Ryosuke Niwa.
16094 * Scripts/webkitpy/port/base.py:
16095 (Port.__init__): Adding self._w3c_resource_files to store the list of resource files.
16096 (Port.potential_test_names_from_expected_file):
16097 (Port._real_tests):
16098 (Port.is_w3c_resource_file): Computing whether a file is a resource file based on imported/w3c/resources/resource-files.json.
16099 (Port._is_test_file): Updated to call Port.is_w3c_resource_file. _is_test_file is no longer static.
16101 * Scripts/webkitpy/port/base_unittest.py:
16102 (PortTest.test_additional_platform_directory):
16103 (PortTest.test_find_no_paths_specified):
16104 (PortTest.test_is_test_file): Updated to use non-static version of _is_test_file.
16105 (PortTest.test_is_w3c_resource_file): Adding tests.
16107 2016-09-02 Carlos Garcia Campos <cgarcia@igalia.com>
16109 Unreviewed. Fix archive-built-product step in GTK+ bots after r205280.
16111 * BuildSlaveSupport/built-product-archive:
16112 (archiveBuiltProduct): Do not copy to the archive the files needed to run GObject DOM bindings API breaks tests
16113 that no longer exist.
16115 2016-09-02 Alex Christensen <achristensen@webkit.org>
16117 URLParser should parse file URLs
16118 https://bugs.webkit.org/show_bug.cgi?id=161556
16120 Reviewed by Tim Horton.
16122 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
16123 (TestWebKitAPI::TEST_F):
16124 (TestWebKitAPI::checkURLDifferences):
16126 2016-09-01 Michael Saboff <msaboff@apple.com>
16128 Import Chakra tests to JSC
16129 https://bugs.webkit.org/show_bug.cgi?id=154697
16131 Reviewed by Saam Barati.
16133 Added "runChakra" and "chakraPassFailErrorHandler" to support the running of
16136 * Scripts/run-jsc-stress-tests:
16138 2016-09-02 Jonathan Bedard <jbedard@apple.com>
16140 WebKitTestRunner needs layoutTestController.setDashboardCompatibilityMode
16141 https://bugs.webkit.org/show_bug.cgi?id=42547
16143 Reviewed by Darin Adler.
16145 Added JavaScript bindings and C++ implementation of setUseDashboardCompatibilityMode for the WebKit2 sTestRunner.
16146 Note: this bug mistakenly called this function setDashboardCompatibilityMode, it is actually setUseDashboardCompatibilityMode.
16148 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added dashboard compatiblity mode setter.
16149 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
16150 (WTR::InjectedBundle::beginTesting): Reset dashboard compatibility mode.
16151 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
16152 (WTR::TestRunner::setJavaScriptCanAccessClipboard): Code style changes.
16153 (WTR::TestRunner::setPrivateBrowsingEnabled): Code style changes.
16154 (WTR::TestRunner::setUseDashboardCompatibilityMode): Added dashboard compatiblity mode setter.
16155 (WTR::TestRunner::setPopupBlockingEnabled): Code style changes.
16156 (WTR::TestRunner::setAuthorAndUserStylesEnabled): Code style changes.
16157 (WTR::TestRunner::addOriginAccessWhitelistEntry): Code style changes.
16158 * WebKitTestRunner/InjectedBundle/TestRunner.h: Added dashboard compatiblity mode setter.
16160 2016-09-02 Jer Noble <jer.noble@apple.com>
16162 Unreviewed build fix: restore storyboard files to Xcode 7-compatability.
16164 * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
16165 * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard:
16167 2016-09-02 Tim Horton <timothy_horton@apple.com>
16169 REGRESSION (r205329): Two API tests time out on iOS Simulator
16170 https://bugs.webkit.org/show_bug.cgi?id=161542
16172 Reviewed by Brady Eidson.
16174 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
16175 (createAnimatedResizeWebView):
16176 (createFirstVisuallyNonEmptyWatchingNavigationDelegate):
16178 (animatedResizeWebView): Deleted.
16179 The navigation delegate was being stored in a local and went out of scope
16180 before the test was over. Keep it around, instead.
16182 2016-08-31 Jer Noble <jer.noble@apple.com>
16184 Refactor MobileMiniBrowser into an application framework to allow external XCTesting
16185 https://bugs.webkit.org/show_bug.cgi?id=161462
16187 Reviewed by Eric Carlson.
16189 XCTest targets need to be in the same project as the application which they're testing. To facilitate
16190 having external projects with XCTest targets, move the application's implementation into a framework
16191 that can be included with a bare-bones application shell for testing.
16193 Simultaneously, add the ability to load files from within the new framework's bundle by using a
16194 'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
16195 an external server for testing.
16197 * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
16198 * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
16199 * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
16200 * MobileMiniBrowser/MobileMiniBrowser/main.m:
16201 * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
16202 * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
16203 (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
16204 controller from the framework's bundle.
16205 * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
16206 * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
16207 * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
16208 * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
16209 * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
16210 * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
16211 * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
16212 * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
16213 (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
16214 (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
16215 (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
16216 pointing to the framework's resources directory.
16217 (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
16218 * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
16219 (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
16221 2016-09-02 Jonathan Bedard <jbedard@apple.com>
16223 Fix --no-sample-on-timeout command line argument
16224 https://bugs.webkit.org/show_bug.cgi?id=161507
16226 Reviewed by Alexey Proskuryakov.
16228 This patch fixes the —no-sample-on-timeout flag and correctly names spindumps as spindump.txt.
16230 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
16231 (parse_args): Fixed —-no-sample-on-timeout.
16232 * Scripts/webkitpy/port/apple.py:
16233 (ApplePort.sample_process): Use correct file name.
16234 (ApplePort.spindump_file_path): Spindump and sample file names are different.
16235 * Scripts/webkitpy/port/driver.py:
16236 (Driver._check_for_driver_timeout): Check “sample_on_timeout” flag.
16237 * Scripts/webkitpy/port/mac_unittest.py:
16238 (MacTest.test_spindump): Modified for correct filename.
16240 2016-09-02 Jonathan Bedard <jbedard@apple.com>
16242 Unreviewed: moved myself to the reviewers list.
16244 * Scripts/webkitpy/common/config/contributors.json:
16246 2016-09-02 Tomas Popela <tpopela@redhat.com>
16248 [GTK] Fix compiler warning in MiniBrowser
16249 https://bugs.webkit.org/show_bug.cgi?id=161529
16251 We were missing a return statement in decidePermissionRequest() and
16252 also there was unused variable in browserWindowConstructed().
16254 Reviewed by Carlos Garcia Campos.
16256 * MiniBrowser/gtk/BrowserTab.c:
16257 (decidePermissionRequest):
16258 * MiniBrowser/gtk/BrowserWindow.c:
16259 (browserWindowConstructed):
16261 2016-09-01 Dan Bernstein <mitz@apple.com>
16265 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
16267 2016-09-01 Tim Horton <timothy_horton@apple.com>
16269 Provide a TestWebKitAPI-wide WKNavigationDelegate to simplify tests
16270 https://bugs.webkit.org/show_bug.cgi?id=161413
16272 Reviewed by Simon Fraser.
16274 Add TestNavigationDelegate, which provides block properties to make
16275 writing tests feel a little more natural (the callbacks can be inline),
16276 and also add WKWebView _test_waitForDidFinishNavigation, so that many
16277 tests don't even need to manually allocate a navigation delegate at all.
16279 Adopt in some of the simpler tests; there are a few navigation delegates
16280 left behind, which we can move to the new model in the future.
16282 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16283 * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
16285 (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]): Deleted.
16286 * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm:
16288 (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]): Deleted.
16289 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
16290 (animatedResizeWebView):
16291 (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]): Deleted.
16292 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
16293 (-[AutoLayoutWKWebView initWithFrame:configuration:]):
16294 (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
16296 (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]): Deleted.
16297 * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
16299 (-[CancelFontSubresourceNavigationDelegate webView:didFinishNavigation:]): Deleted.
16300 * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
16301 (WebKit2_CommandBackForwardTestWKWebView::SetUp):
16302 (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
16304 (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]): Deleted.
16305 * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
16308 (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]): Deleted.
16309 * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
16311 (-[FindInPageNavigationDelegate webView:didFinishNavigation:]): Deleted.
16312 * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
16314 (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
16315 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
16317 (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]): Deleted.
16318 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
16319 (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]): Deleted.
16320 * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm:
16322 (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]): Deleted.
16323 (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]): Deleted.
16324 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
16325 (RequiresUserActionForPlaybackTest::createWebView):
16326 (RequiresUserActionForPlaybackTest::testVideoWithAudio):
16327 (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
16328 (RequiresUserActionForPlaybackTest::testAudioOnly):
16329 (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]): Deleted.
16330 * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:
16332 (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]): Deleted.
16333 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
16335 (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
16336 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
16338 (-[SimpleDelegate webView:didFinishNavigation:]): Deleted.
16339 * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm:
16341 (-[WKPDFViewResizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
16342 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
16344 (-[EvaluateJavaScriptNavigationDelegate webView:didFinishNavigation:]): Deleted.
16345 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
16347 (-[DummyNavigationDelegate webView:didFinishNavigation:]): Deleted.
16348 * TestWebKitAPI/cocoa/TestNavigationDelegate.h: Added.
16349 * TestWebKitAPI/cocoa/TestNavigationDelegate.mm: Added.
16350 (-[TestNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
16351 (-[TestNavigationDelegate webView:didFinishNavigation:]):
16352 (-[TestNavigationDelegate _webView:renderingProgressDidChange:]):
16353 (-[TestNavigationDelegate waitForDidFinishNavigation]):
16354 (-[WKWebView _test_waitForDidFinishNavigation]):
16356 2016-09-01 Ricky Mondello <rmondello@apple.com>
16358 YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs
16359 https://bugs.webkit.org/show_bug.cgi?id=161478
16360 <rdar://problem/28050847>
16362 Reviewed by Eric Carlson.
16364 * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
16365 (TestWebKitAPI::TEST_F): Update expected results.
16367 2016-09-01 Anders Carlsson <andersca@apple.com>
16369 add BlockPtr::fromCallable
16370 https://bugs.webkit.org/show_bug.cgi?id=161504
16372 Reviewed by Tim Horton.
16376 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16377 * TestWebKitAPI/Tests/WTF/BlockPtr.mm: Added.
16378 (TestWebKitAPI::TEST):
16380 2016-09-01 Alex Christensen <achristensen@webkit.org>
16382 URLParser should handle . and .. in URL paths
16383 https://bugs.webkit.org/show_bug.cgi?id=161443
16385 Reviewed by Brady Eidson.
16387 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
16388 (TestWebKitAPI::eq):
16389 (TestWebKitAPI::TEST_F):
16391 2016-09-01 Commit Queue <commit-queue@webkit.org>
16393 Unreviewed, rolling out r205295 and r205303.
16394 https://bugs.webkit.org/show_bug.cgi?id=161505
16396 Broke the iOS build (Requested by ryanhaddad on #webkit).
16398 Reverted changesets:
16400 "Refactor MobileMiniBrowser into an application framework to
16401 allow external XCTesting"
16402 https://bugs.webkit.org/show_bug.cgi?id=161462
16403 http://trac.webkit.org/changeset/205295
16405 "Unreviewed build-fix; don't specify an explicit deployment
16407 http://trac.webkit.org/changeset/205303
16409 2016-09-01 Ricky Mondello <rmondello@apple.com>
16411 YouTube Flash plug-in replacement facility should more gracefully handle malformed queries
16412 https://bugs.webkit.org/show_bug.cgi?id=161476
16413 <rdar://problem/28050847>
16415 Reviewed by Eric Carlson.
16417 * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
16418 (TestWebKitAPI::TEST_F): New tests. The first two and second-to-last test cases cover the "malformed" query
16419 logic. A few other tests are added, too.
16421 2016-09-01 Jer Noble <jer.noble@apple.com>
16423 Unreviewed build-fix; don't specify an explicit deployment target.
16425 * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
16427 2016-08-31 Jer Noble <jer.noble@apple.com>
16429 Refactor MobileMiniBrowser into an application framework to allow external XCTesting
16430 https://bugs.webkit.org/show_bug.cgi?id=161462
16432 Reviewed by Eric Carlson.
16434 XCTest targets need to be in the same project as the application which they're testing. To facilitate
16435 having external projects with XCTest targets, move the application's implementation into a framework
16436 that can be included with a bare-bones application shell for testing.
16438 Simultaneously, add the ability to load files from within the new framework's bundle by using a
16439 'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
16440 an external server for testing.
16442 * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
16443 * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
16444 * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
16445 * MobileMiniBrowser/MobileMiniBrowser/main.m:
16446 * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
16447 * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
16448 (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
16449 controller from the framework's bundle.
16450 * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
16451 * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
16452 * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
16453 * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
16454 * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
16455 * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
16456 * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
16457 * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
16458 (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
16459 (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
16460 (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
16461 pointing to the framework's resources directory.
16462 (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
16463 * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
16464 (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
16466 2016-09-01 Carlos Garcia Campos <cgarcia@igalia.com>
16468 Unreviewed. Fix webkitpy unit tests after r205280.
16470 * Scripts/webkitpy/style/checker_unittest.py:
16471 (GlobalVariablesTest.test_path_rules_specifier):
16473 2016-08-31 Carlos Garcia Campos <cgarcia@igalia.com>
16475 [GTK] Move GObject DOM bindings to WebKit2 layer and stop auto generating them
16476 https://bugs.webkit.org/show_bug.cgi?id=161438
16478 Reviewed by Michael Catanzaro.
16480 Remove scripts related to the GObject DOM bindings auto-generation.
16482 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
16483 (RunGtkAPITests.getText2):
16484 (TestFactory.__init__):
16485 (RunWebKit1Tests): Deleted.
16486 (RunWebKit1Tests.start): Deleted.
16487 (RunWebKit1LeakTests): Deleted.
16488 (RunWebKit1LeakTests.start): Deleted.
16489 (RunAndUploadPerfTests): Deleted.
16490 (RunAndUploadPerfTests.start): Deleted.
16491 (BuildAndRemoteJSCTestsFactory.__init__): Deleted.
16492 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
16493 (BuildStepsTest.test_unnecessary_expected_results):
16494 (RunAndUploadPerfTestsTest): Deleted.
16495 (RunAndUploadPerfTestsTest.assertResults): Deleted.
16496 (RunAndUploadPerfTestsTest.test_success): Deleted.
16497 (RunAndUploadPerfTestsTest.test_tests_failed): Deleted.
16498 (RunAndUploadPerfTestsTest.test_build_bad_build): Deleted.
16499 (RunAndUploadPerfTestsTest.test_build_bad_source_json): Deleted.
16500 (RunAndUploadPerfTestsTest.test_build_bad_marge): Deleted.
16501 (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading): Deleted.
16502 (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
16503 (RunAndUploadPerfTestsTest.test_buildbot_timeout): Deleted.
16504 (RunBenchmarkTest): Deleted.
16505 (RunBenchmarkTest.assertResults): Deleted.
16506 (RunBenchmarkTest.test_success): Deleted.
16507 * Scripts/run-bindings-tests:
16509 * Scripts/webkitpy/style/checker.py:
16510 * gtk/check-for-webkitdom-api-breaks: Removed.
16511 * gtk/generate-gtkdoc:
16512 * gtk/webkitdom.py: Removed.
16514 2016-08-31 Gyuyoung Kim <gyuyoung.kim@webkit.org>
16516 [EFL] Small clean up in MiniBrowser
16517 https://bugs.webkit.org/show_bug.cgi?id=161428
16519 Reviewed by Yusuke Suzuki.
16521 This patch resizes MiniBrowser, add *char* constants for scheme,
16522 does line breaking, and remove unnecessary spaces.
16524 * MiniBrowser/efl/main.c:
16526 (history_list_hide):
16527 (script_execute_callback):
16531 (on_color_picker_request):
16532 (url_from_user_input):
16533 (url_load_from_user_input):
16534 (on_back_button_clicked):
16535 (on_search_case_option_changed):
16536 (on_search_word_start_option_changed):
16537 (on_list_item_select):
16538 (navigation_button_longpress_process):
16539 (on_navigation_policy_decision):
16541 (parse_cookies_policy):
16543 2016-08-31 Alex Christensen <achristensen@webkit.org>
16545 Implement IPv6 parsing in URLParser
16546 https://bugs.webkit.org/show_bug.cgi?id=161390
16548 Reviewed by Darin Adler.
16550 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
16551 (TestWebKitAPI::TEST_F):
16552 (TestWebKitAPI::checkURLDifferences):
16554 2016-08-31 Brady Eidson <beidson@apple.com>
16556 WK2 Gamepad provider on iOS.
16557 https://bugs.webkit.org/show_bug.cgi?id=161412
16559 Reviewed by Tim Horton.
16561 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
16563 2016-08-30 Ricky Mondello <rmondello@apple.com>
16565 YouTubePluginReplacementTest's URL transformation logic should have tests
16566 https://bugs.webkit.org/show_bug.cgi?id=161406
16567 <rdar://problem/28050847>
16569 Reviewed by Eric Carlson.
16571 Add some very basic tests. Future patches should expand on these to find and fix bugs.
16573 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add YouTubePluginReplacement.cpp.
16574 * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp: Added.
16575 (TestWebKitAPI::test): Added.
16576 (TestWebKitAPI::TEST_F): Added.
16578 2016-08-30 Brady Eidson <beidson@apple.com>
16580 GameController.framework backend for gamepad API.
16581 https://bugs.webkit.org/show_bug.cgi?id=161086
16583 Reviewed by Alex Christensen.
16585 * MiniBrowser/mac/AppDelegate.m:
16586 (-[BrowserAppDelegate awakeFromNib]):
16588 * MiniBrowser/mac/SettingsController.h:
16589 * MiniBrowser/mac/SettingsController.m:
16590 (-[SettingsController _populateMenu]):
16591 (-[SettingsController validateMenuItem:]):
16592 (-[SettingsController usesGameControllerFramework]):
16593 (-[SettingsController toggleUsesGameControllerFramework:]):
16595 2016-08-30 Brent Fulgham <bfulgham@apple.com>
16597 Use of uninitialised memory in TransformationMatrx::blend4()
16598 https://bugs.webkit.org/show_bug.cgi?id=134621
16599 <rdar://problem/27337539>
16601 Reviewed by Dean Jackson.
16603 Change is based on the Blink change (patch by <alancutter@chromium.org>):
16604 <https://src.chromium.org/viewvc/blink?revision=177453&view=revision>
16606 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16607 * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Added.
16608 (TestWebKitAPI::TEST):
16610 2016-08-30 Alex Christensen <achristensen@webkit.org>
16612 URLParser should handle relative URLs that start with //
16613 https://bugs.webkit.org/show_bug.cgi?id=161364
16615 Reviewed by Darin Adler.
16617 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
16618 (TestWebKitAPI::checkRelativeURL):
16619 (TestWebKitAPI::TEST_F):
16621 2016-08-29 Aakash Jain <aakash_jain@apple.com>
16623 EWS patch status page should indicate bot corresponding to each status message
16624 https://bugs.webkit.org/show_bug.cgi?id=161280
16626 Reviewed by Alexey Proskuryakov.
16628 * QueueStatusServer/templates/patch.html: Formatting changes.
16630 2016-08-29 Aakash Jain <aakash_jain@apple.com>
16632 EWS should indicate which bot processed the patch
16633 https://bugs.webkit.org/show_bug.cgi?id=161222
16635 Reviewed by Alexey Proskuryakov.
16637 * QueueStatusServer/handlers/statusbubble.py:
16638 (StatusBubble._build_bubble): Remove the bot id from bubbles as it is confusing.
16639 bot ids are now displayed in patch status page.
16641 2016-08-29 Alex Christensen <achristensen@webkit.org>
16643 URLParser should parse about:blank
16644 https://bugs.webkit.org/show_bug.cgi?id=161324
16646 Reviewed by Brady Eidson.
16648 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
16649 (TestWebKitAPI::TEST_F):
16651 2016-08-29 JF Bastien <jfbastien@apple.com>
16653 Bug 161165 - check-webkit-style doesn't understand macros containing `else` or labels
16654 https://bugs.webkit.org/show_bug.cgi?id=161165
16656 Reviewed by Geoffrey Garen.
16658 Fix handling of `else` in a macro. Don't handle labels in a macro:
16659 the checker is already pretty messy in that area and it should be
16662 * Scripts/webkitpy/style/checkers/cpp.py:
16664 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
16665 (CppStyleTest.test_else_clause_not_on_same_line_as_else):
16667 2016-08-29 Alex Christensen <achristensen@webkit.org>
16669 API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED
16670 https://bugs.webkit.org/show_bug.cgi?id=161317
16672 Reviewed by Brady Eidson.
16674 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
16675 (TestWebKitAPI::TEST_F):
16677 2016-08-29 Jer Noble <jer.noble@apple.com>
16679 Unreviewed gardening; only build MiniBrowser against iOS SDK targets.
16683 2016-08-29 Jonathan Bedard <jbedard@apple.com>
16685 Sample Process on notifyDone timed out
16686 https://bugs.webkit.org/show_bug.cgi?id=161063
16688 Reviewed by Darin Adler.
16690 * Scripts/webkitpy/port/driver.py:
16691 (Driver._check_for_driver_timeout):
16692 * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Call sample_process during notifyDone timeouts.
16693 (WTR::TestRunner::waitToDumpWatchdogTimerFired):
16694 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Log pid and name for testing harness.
16696 2016-08-29 Jonathan Bedard <jbedard@apple.com>
16698 Check-webkit-style does not work with Objective-C blocks
16699 https://bugs.webkit.org/show_bug.cgi?id=161247
16701 Reviewed by Darin Adler.
16703 * Scripts/webkitpy/style/checkers/cpp.py:
16704 (regex_for_lambda_functions): Changed to regex_for_lambdas_and_blocks.
16705 (regex_for_lambdas_and_blocks): Added check for Objective-C blocks.
16706 (check_spacing_for_function_call): Pass file state for lambda check.
16707 (check_spacing): Pass file state for lambda check.
16708 (check_braces): Pass file state for lambda check.
16709 (check_style): Pass file state for lambda check.
16710 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
16711 (CppStyleTest.test_cpp_lambda_functions): Changed from ‘test_lambda_functions’.
16712 (CppStyleTest.test_objective_c_block): Tests Objective-C blocks.
16713 (CppStyleTest.test_lambda_functions): Changed to ‘test_cpp_lambda_functions’.
16715 2016-08-29 Aakash Jain <aakash_jain@apple.com>
16717 EWS patch status page should indicate bot corresponding to each status message
16718 https://bugs.webkit.org/show_bug.cgi?id=161280
16720 Reviewed by Alexey Proskuryakov.
16722 * QueueStatusServer/templates/patch.html: Added bot_id in the template so that bot id is displayed
16723 for each status message.
16724 * QueueStatusServer/stylesheets/common.css:
16725 (.status-bot): Added corresponding stylesheet class.
16727 2016-08-29 Per Arne Vollan <pvollan@apple.com>
16729 Attempt to fix Windows build after r205090.
16731 Unreviewed build fix.
16733 * DumpRenderTree/win/DRTDataObject.cpp:
16734 (cfFileNameWFormat):
16737 2016-08-27 Alex Christensen <achristensen@webkit.org>
16739 URLParser should parse relative URLs
16740 https://bugs.webkit.org/show_bug.cgi?id=161282
16742 Reviewed by Darin Adler.
16744 * TestWebKitAPI/Tests/WTF/StringView.cpp:
16745 (TestWebKitAPI::TEST):
16746 Added some tests for the new operator=.
16747 Test saving iterators, restoring iterators, and even assigning iterators to new CodePoints objects.
16748 Using the same iterator to iterate multiple objects is bad practice, but it's possible and now tested.
16749 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
16750 (TestWebKitAPI::checkURL):
16751 (TestWebKitAPI::TEST_F):
16752 (TestWebKitAPI::checkRelativeURL):
16753 (TestWebKitAPI::checkURLDifferences):
16754 (TestWebKitAPI::shouldFail):
16755 Add some relative URL tests.
16757 2016-08-27 Jonathan Bedard <jbedard@apple.com>
16759 WTR needs an implementation of setAutomaticLinkDetectionEnabled
16760 https://bugs.webkit.org/show_bug.cgi?id=87162
16762 Reviewed by Darin Adler.
16764 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added setAutomaticLinkDetectionEnabled binding.
16765 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
16766 (WTR::InjectedBundle::beginTesting): Set automatic link detection to false by default.
16767 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
16768 (WTR::TestRunner::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition.
16769 * WebKitTestRunner/InjectedBundle/TestRunner.h: Added setAutomaticLinkDetectionEnabled declaration.
16771 2016-08-27 Joseph Pecoraro <pecoraro@apple.com>
16773 Web Inspector: Make localizedString.js diff and commit friendly (UTF16 -> UTF8)
16774 https://bugs.webkit.org/show_bug.cgi?id=28685
16775 <rdar://problem/16460975>
16777 Reviewed by Darin Adler.
16779 * Scripts/extract-localizable-js-strings:
16780 * Scripts/update-webkit-localizable-strings:
16781 WebInspectorUI localizedStrings.js is now UTF-8. Other clients of
16782 this script still use UTF-16, so keep that the default.
16784 2016-08-27 Alexey Proskuryakov <ap@apple.com>
16786 REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
16787 https://bugs.webkit.org/show_bug.cgi?id=161254
16789 Reviewed by Darin Adler.
16791 Simplify the CSS. My understanding that the CSS was correct, and the root cause
16792 is tracked in bug 160478.
16794 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
16796 2016-08-27 Simon Fraser <simon.fraser@apple.com>
16798 Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests
16799 https://bugs.webkit.org/show_bug.cgi?id=161217
16801 Reviewed by Ryosuke Niwa.
16803 "run-webkit-tests --print-expectations" runs the same logic as running the tests, but
16804 dumps out the lists of tests that would be run and skipped, and, for each, the entry
16805 in TestExpectations that determines the expected outcome of the test.
16807 This is an improved version of webkit-patch print-expectations.
16809 See bug for sample output.
16811 * Scripts/webkitpy/layout_tests/controllers/manager.py:
16812 (Manager._print_expectations_for_subset): Print out the list of tests and expected
16813 outcome for some subset of tests.
16814 (Manager.print_expectations): Do the same splitting by device class that running tests
16815 does, and for each subset of tests, call _print_expectations_for_subset.
16816 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
16817 (TestExpectationParser.expectation_for_skipped_test): Set the flag
16818 expectation_line.not_applicable_to_current_platform
16819 (TestExpectationLine.__init__): Init not_applicable_to_current_platform to False
16820 (TestExpectationLine.expected_behavior): line.expectation is ['PASS'] by default,
16821 even for skipped tests. This function returns a list relevant for display, taking the skipped
16822 modifier into account.
16823 (TestExpectationLine.create_passing_expectation): expectations is normally a list, not a set.
16824 (TestExpectations.readable_filename_and_line_number): Return something printable for
16825 lines with and without filenames
16826 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
16827 (main): Handle options.print_expectations
16828 (parse_args): Add support for --print-expectations
16829 (_print_expectations):
16830 * Scripts/webkitpy/port/ios.py:
16831 (IOSSimulatorPort.default_child_processes): Make this a debug log.
16833 2016-08-26 Dan Bernstein <mitz@apple.com>
16835 Keep trying to fix the build after r205057.
16837 * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
16839 2016-08-26 Dan Bernstein <mitz@apple.com>
16841 Keep trying to fix the build after r205057.
16843 * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent
16844 config.h. This file is only meant to be built with Xcode anyway.
16845 * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile
16846 with Xcode 7.3 and deploy to iOS 9.0.
16847 * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto.
16848 * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h.
16849 * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto.
16851 2016-08-26 Dan Bernstein <mitz@apple.com>
16853 Start trying to fix the build after r205057.
16855 * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
16857 2016-08-26 Alexey Proskuryakov <ap@apple.com>
16859 Remove Yosemite Leaks from the flakiness dashboard
16860 https://bugs.webkit.org/show_bug.cgi?id=161253
16862 Reviewed by Anders Carlsson.
16864 * TestResultServer/static-dashboards/builders.jsonp:
16866 2016-08-26 Sam Weinig <sam@webkit.org>
16868 Remove support for ENABLE_LEGACY_WEB_AUDIO
16869 https://bugs.webkit.org/show_bug.cgi?id=161262
16871 Reviewed by Anders Carlsson.
16873 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
16875 2016-08-26 Jer Noble <jer.noble@apple.com>
16877 Add a test harness for running UI tests on the iOS Simulator
16878 https://bugs.webkit.org/show_bug.cgi?id=161265
16880 Reviewed by Simon Fraser.
16882 Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
16883 can serve as a test harness for WebKit UI tests.
16885 Also add a basic media playback test which verifies that a <video> element will begin playing in
16886 fullscreen on an iPhone device, but will play inline on an iPad device.
16888 * Makefile: Add MobileMiniBrowser as a Module for iOS builds.
16889 * MobileMiniBrowser/Configurations/Base.xcconfig: Added.
16890 * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
16891 * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
16892 * MobileMiniBrowser/Makefile: Added.
16893 * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
16894 * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
16895 * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.
16896 (-[AppDelegate application:didFinishLaunchingWithOptions:]):
16897 (-[AppDelegate applicationWillResignActive:]):
16898 (-[AppDelegate applicationDidEnterBackground:]):
16899 (-[AppDelegate applicationWillEnterForeground:]):
16900 (-[AppDelegate applicationDidBecomeActive:]):
16901 (-[AppDelegate applicationWillTerminate:]):
16902 * MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
16903 * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
16904 * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
16905 * MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
16906 * MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
16907 * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.
16908 (-[TabViewController dealloc]):
16909 (-[TabViewController viewDidLoad]):
16910 (-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
16911 (-[TabViewController tableView:cellForRowAtIndexPath:]):
16912 (-[TabViewController tableView:numberOfRowsInSection:]):
16913 (-[TabViewController numberOfSectionsInTableView:]):
16914 (-[TabViewController tableView:canEditRowAtIndexPath:]):
16915 (-[TabViewController tableView:canMoveRowAtIndexPath:]):
16916 (-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
16917 (-[TabViewController tableView:didSelectRowAtIndexPath:]):
16918 * MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
16919 * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.
16920 (-[WebViewController viewDidLoad]):
16921 (-[WebViewController didReceiveMemoryWarning]):
16922 (-[WebViewController reload:]):
16923 (-[WebViewController goBack:]):
16924 (-[WebViewController goForward:]):
16925 (-[WebViewController urlFieldEditingBegan:]):
16926 (-[WebViewController navigateTo:]):
16927 (-[WebViewController showTabs:]):
16928 (-[WebViewController selectWebViewAtIndex:]):
16929 (-[WebViewController removeWebViewAtIndex:]):
16930 (-[WebViewController addWebView]):
16931 (-[WebViewController createWebView]):
16932 (-[WebViewController removeWebView:]):
16933 (-[WebViewController setCurrentWebView:]):
16934 (-[WebViewController webView:didFailNavigation:withError:]):
16935 (-[WebViewController observeValueForKeyPath:ofObject:change:context:]):
16936 * MobileMiniBrowser/MobileMiniBrowser/main.m: Added.
16938 * MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
16939 * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.
16940 (-[MobileMiniBrowserUITests setUp]):
16941 (-[MobileMiniBrowserUITests tearDown]):
16942 (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
16944 2016-08-26 Aakash Jain <aakash_jain@apple.com>
16946 webkit-queues queue-status page should should list more recent statuses
16947 https://bugs.webkit.org/show_bug.cgi?id=161220
16949 Reviewed by Daniel Bates.
16951 * QueueStatusServer/handlers/queuestatus.py:
16952 (QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.
16954 2016-08-26 Dan Bernstein <mitz@apple.com>
16956 [Cocoa] Infinite recursion calling -charValue on a WKNSNumber
16957 https://bugs.webkit.org/show_bug.cgi?id=161258
16959 Reviewed by Anders Carlsson.
16961 * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
16962 (TestWebKitAPI::TEST):
16964 2016-08-26 Csaba Osztrogonác <ossy@webkit.org>
16966 Fix the ENABLE(WEBASSEMBLY) build on Linux
16967 https://bugs.webkit.org/show_bug.cgi?id=161197
16969 Reviewed by Mark Lam.
16971 * Scripts/build-jsc:
16973 2016-08-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
16975 [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
16976 https://bugs.webkit.org/show_bug.cgi?id=161149
16978 Reviewed by Carlos Garcia Campos.
16980 Add a new function for waiting for the accesibility bus. It sets
16981 the test environment variables before starting the GLib mainloop.
16982 And restores the previous environment after it has finished.
16983 It also adds a timeout (5 seconds) to abort in case it has not
16984 been able to detect the accesibility bus before the timeout expires.
16986 * Scripts/run-gtk-tests:
16988 (TestRunner._wait_for_accessibility_bus):
16989 (TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
16990 (TestRunner._start_accessibility_daemons):
16991 (TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
16993 2016-08-26 Per Arne Vollan <pvollan@apple.com>
16996 https://bugs.webkit.org/show_bug.cgi?id=161236
16998 Reviewed by Brent Fulgham.
17000 The & operator in the Test struct has no body.
17002 * TestWebKitAPI/Tests/WTF/Vector.cpp:
17003 (TestWebKitAPI::TEST):
17005 2016-08-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
17007 [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
17008 https://bugs.webkit.org/show_bug.cgi?id=160736
17010 Reviewed by Carlos Garcia Campos.
17012 This plugs run-gtk-tests into the webkitpy testing infrastructure.
17013 As a benefit of this, run-gtk-tests now can be executed over any of
17014 the existing supported gtk test display servers (xvfb, weston-over-xvfb,
17015 or native xorg). A new command line switch --wayland is added for
17018 * Scripts/run-gtk-tests:
17019 (TestRunner.__init__): Remove the --display command line switch, its not longer useful.
17020 Add a --wayland command line switch.
17021 (TestRunner._start_accessibility_daemons):
17023 (TestRunner.__init__):
17024 (TestRunner._run_xvfb): Deleted.
17025 (TestRunner._create_driver):
17026 (TestRunner._setup_testing_environment): Delete the environment variable definitions that
17027 are now done by driver._setup_environ_for_test().
17028 (TestRunner._tear_down_testing_environment):
17029 * Scripts/webkitpy/port/driver.py:
17030 (Driver.__init__): Define self._server_name in the constructor of the base class.
17031 It is used by several functions, so it makes sense to store once the value here.
17032 (Driver._setup_environ_for_test): Factorize setting the environment for a given test.
17033 (Driver._start): Get the environment from self._setup_environ_for_test()
17034 * Scripts/webkitpy/port/driver_unittest.py:
17036 (DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
17037 * Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
17038 (GtkPort.__init__):
17039 (GtkPort._driver_class):
17040 * Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
17041 (WestonDriver._setup_environ_for_test):
17042 (WestonDriver._start):
17043 * Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
17044 (XorgDriver._setup_environ_for_test):
17045 (XorgDriver._start):
17046 * Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
17047 (XvfbDriver._setup_environ_for_test):
17048 (XvfbDriver._start):
17050 2016-08-26 Csaba Osztrogonác <ossy@webkit.org>
17052 [EFL][GTK] REGRESSION(204877): Fix the clean build
17053 https://bugs.webkit.org/show_bug.cgi?id=161240
17055 Reviewed by Carlos Garcia Campos.
17057 * WebKitTestRunner/PlatformEfl.cmake:
17058 * WebKitTestRunner/PlatformGTK.cmake:
17060 2016-08-26 Aakash Jain <aakash_jain@apple.com>
17062 EWS should indicate which bot processed the patch
17063 https://bugs.webkit.org/show_bug.cgi?id=161222
17065 Reviewed by Daniel Bates.
17067 * QueueStatusServer/handlers/statusbubble.py:
17068 (StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
17069 after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
17070 Also added "Started processing patch" message to progress_statuses.
17071 I might consider displaying bot id in other statuses as well later on.
17073 2016-08-26 Gyuyoung Kim <gyuyoung.kim@webkit.org>
17075 [EFL] Change homepage url to www.ewebkit.org on MiniBrowser
17076 https://bugs.webkit.org/show_bug.cgi?id=161184
17078 Reviewed by Carlos Garcia Campos.
17080 * MiniBrowser/efl/main.c: Set www.ewebkit.org.
17082 2016-08-25 Aakash Jain <aakash_jain@apple.com>
17084 ews queues should update status server when they start processing patch
17085 https://bugs.webkit.org/show_bug.cgi?id=161223
17087 Reviewed by Daniel Bates.
17089 * Scripts/webkitpy/tool/commands/queues.py:
17090 (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
17091 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
17092 (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
17093 * Scripts/webkitpy/tool/commands/queues_unittest.py:
17094 (StyleQueueTest.test_style_queue_with_style_exception): Same.
17095 (test_style_queue_with_watch_list_exception): Same.
17096 (test_non_valid_patch): Same.
17098 2016-08-25 Alex Christensen <achristensen@webkit.org>
17102 * DumpRenderTree/PlatformMac.cmake:
17104 2016-08-25 Alex Christensen <achristensen@webkit.org>
17106 Fix URLParserTest with GuardMalloc
17107 https://bugs.webkit.org/show_bug.cgi?id=161214
17108 rdar://problem/28014390
17110 Reviewed by Tim Horton.
17112 The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
17113 This just does the comparison of the CStrings instead to keep them in scope during the comparison.
17115 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
17116 (TestWebKitAPI::eq):
17117 (TestWebKitAPI::checkURL):
17118 (TestWebKitAPI::checkURLDifferences):
17119 (TestWebKitAPI::s): Deleted.
17121 2016-08-25 Wenson Hsieh <wenson_hsieh@apple.com>
17123 Dragging against the end of the inline media scrubber causes the media scrubber to hide
17124 https://bugs.webkit.org/show_bug.cgi?id=161207
17126 Reviewed by Eric Carlson.
17128 Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
17129 controls in this case, we should actually continue showing them. This is because seeking due to user gestures
17130 similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
17132 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
17133 (TestWebKitAPI::TEST):
17135 2016-08-25 Daniel Bates <dabates@apple.com>
17139 * Scripts/webkitpy/common/config/watchlist:
17141 2016-08-25 Daniel Bates <dabates@apple.com>
17143 Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
17144 (https://bugs.webkit.org/show_bug.cgi?id=148437)
17146 Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
17147 and is not installed on the GTK Linux bots.
17149 * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
17150 (writeFileWithContent): Added.
17152 2016-08-25 Per Arne Vollan <pvollan@apple.com>
17154 [Win] run-api-tests is failing.
17155 https://bugs.webkit.org/show_bug.cgi?id=161140
17157 Reviewed by Brent Fulgham.
17159 Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
17161 * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
17162 (TestWebKitAPI::TEST):
17164 2016-08-24 Per Arne Vollan <pvollan@apple.com>
17166 [Win] run-api-tests is failing.
17167 https://bugs.webkit.org/show_bug.cgi?id=161140
17169 Reviewed by Brent Fulgham.
17171 The number of times the move constructor is called is different on Windows in this test. This seems
17172 to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
17174 * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
17175 (TestWebKitAPI::TEST):
17177 2016-08-24 Simon Fraser <simon.fraser@apple.com>
17181 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
17182 (WTR::UIScriptController::zoomToScale):
17184 2016-08-24 Simon Fraser <simon.fraser@apple.com>
17186 [iOS DRT] Hook up uiController.zoomToScale() for DRT
17187 https://bugs.webkit.org/show_bug.cgi?id=161173
17189 Reviewed by Tim Horton.
17191 Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
17192 UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
17194 UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
17195 the WebThread!), but queue up the callback first.
17197 * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
17198 * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
17199 (-[DumpRenderTreeWebScrollView initWithFrame:]):
17200 (-[DumpRenderTreeWebScrollView dealloc]):
17201 (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
17202 (-[DumpRenderTreeWebScrollView completedZoomToScale]):
17203 (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
17204 (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
17205 (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
17206 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
17207 (WTR::UIScriptController::zoomToScale):
17208 * DumpRenderTree/mac/DumpRenderTree.mm:
17209 (createWebViewAndOffscreenWindow):
17210 * TestRunnerShared/UIScriptContext/UIScriptController.h:
17211 (WTR::UIScriptController::context):
17213 2016-08-24 Ryan Haddad <ryanhaddad@apple.com>
17215 Attempt to fix Windows build after r204918.
17217 Unreviewed build fix.
17219 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
17220 (ResourceLoadDelegate::willSendRequest):
17222 2016-08-24 Simon Fraser <simon.fraser@apple.com>
17224 [iOS DRT] Get basic viewport tests working in DRT
17225 https://bugs.webkit.org/show_bug.cgi?id=161160
17227 Reviewed by Tim Horton.
17229 Hook up enough of UIScriptController in iOS DRT to be able to read viewport
17230 scale, and get the contentVisibleRect.
17232 Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
17233 requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
17235 One test has different results between DRT and WTR, but DRT behavior seems to differ
17236 from UIWebView here, so just give it a WK1-specific result.
17238 * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
17239 * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
17240 (-[DumpRenderTreeBrowserView documentVisibleRect]):
17241 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
17242 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
17243 (WTR::UIScriptController::zoomScale):
17244 (WTR::UIScriptController::minimumZoomScale):
17245 (WTR::UIScriptController::maximumZoomScale):
17246 (WTR::UIScriptController::contentVisibleRect):
17247 * DumpRenderTree/mac/DumpRenderTree.mm:
17248 (createWebViewAndOffscreenWindow):
17249 * DumpRenderTree/mac/DumpRenderTreeMac.h:
17251 2016-08-24 Simon Fraser <simon.fraser@apple.com>
17253 Minor project rearrangement.
17255 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
17257 2016-08-24 Simon Fraser <simon.fraser@apple.com>
17259 [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
17260 https://bugs.webkit.org/show_bug.cgi?id=161124
17262 Reviewed by Daniel Bates.
17264 Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
17265 and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
17267 Remove some unnecessary zero initializations of static variables.
17269 Change _setVisibleSize to use the window size, which should not be a behavior change
17270 because this it just used for text autosizing, which is disabled by default,
17271 and only the width is consulted.
17273 * DumpRenderTree/mac/DumpRenderTree.mm:
17274 (adjustWebDocumentForFlexibleViewport):
17275 (adjustWebDocumentForStandardViewport):
17276 (createWebViewAndOffscreenWindow):
17278 2016-08-24 Jonathan Bedard <jbedard@apple.com>
17280 WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
17281 https://bugs.webkit.org/show_bug.cgi?id=42777
17283 Reviewed by Darin Adler.
17285 The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called. Removed function and test.
17287 * DumpRenderTree/TestRunner.cpp:
17288 (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
17289 * DumpRenderTree/TestRunner.h:
17290 (TestRunner::deferMainResourceDataLoad): Ditto.
17291 (TestRunner::setDeferMainResourceDataLoad): Ditto.
17292 * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
17294 2016-08-23 Anders Carlsson <andersca@apple.com>
17296 Add enum traits and use them in the IPC::Decoder
17297 https://bugs.webkit.org/show_bug.cgi?id=161103
17299 Reviewed by Sam Weinig.
17303 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17304 * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
17305 (TestWebKitAPI::TEST):
17307 2016-08-24 Filip Pizlo <fpizlo@apple.com>
17309 Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
17311 * DumpRenderTree/TestRunner.cpp:
17312 * DumpRenderTree/mac/DumpRenderTree.mm:
17313 (DumpRenderTreeMain):
17314 * Scripts/run-jsc-stress-tests:
17315 * TestWebKitAPI/Tests/WTF/Vector.cpp:
17316 (TestWebKitAPI::TEST):
17318 2016-08-24 Simon Fraser <simon.fraser@apple.com>
17320 Try to fix Production builds.
17322 PRODUCTION_FRAMEWORKS_DIR was undefined here.
17324 * DumpRenderTree/mac/Configurations/Base.xcconfig:
17326 2016-08-24 Dan Bernstein <mitz@apple.com>
17328 Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
17329 https://bugs.webkit.org/show_bug.cgi?id=161152
17331 Reviewed by Anders Carlsson.
17333 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17334 * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
17335 (TestWebKitAPI::didFinishLoadForFrame):
17336 (TestWebKitAPI::TEST):
17338 2016-08-24 Nan Wang <n_wang@apple.com>
17340 AX: Add test for line text marker range on iOS
17341 https://bugs.webkit.org/show_bug.cgi?id=161108
17342 <rdar://problem/27976405>
17344 Reviewed by Chris Fleizach.
17346 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
17347 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
17348 (AccessibilityUIElement::textMarkerRangeForElement):
17349 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
17350 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
17351 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
17353 2016-08-24 Per Arne Vollan <pvollan@apple.com>
17355 [Win] Warning fixes.
17356 https://bugs.webkit.org/show_bug.cgi?id=161079
17358 Reviewed by Brent Fulgham.
17360 * MiniBrowser/win/WebDownloadDelegate.cpp:
17361 * MiniBrowser/win/WinMain.cpp:
17362 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
17363 (TestWebKitAPI::TEST):
17365 2016-08-23 Simon Fraser <simon.fraser@apple.com>
17367 Fix Windows DRT build.
17369 * DumpRenderTree/win/TestRunnerWin.cpp:
17370 (TestRunner::mainFrameJSContext):
17372 2016-08-23 Simon Fraser <simon.fraser@apple.com>
17374 Try to fix Windows build.
17376 Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
17377 so that perl finds CodeGeneratorDumpRenderTree.pm.
17379 * DumpRenderTree/CMakeLists.txt:
17381 2016-08-23 Simon Fraser <simon.fraser@apple.com>
17383 Hook up UIScriptController in DumpRenderTree
17384 https://bugs.webkit.org/show_bug.cgi?id=161064
17386 Reviewed by Sam Weinig.
17388 Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
17389 Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
17390 in fast/harness which test this.
17392 Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
17394 Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
17395 WK2-isms. Fix the makefiles to refer to the new location.
17397 Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
17398 by ID and firing them once they are complete.
17400 * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
17401 * DumpRenderTree/CMakeLists.txt:
17402 * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
17403 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
17404 * DumpRenderTree/TestRunner.cpp:
17405 (runUIScriptCallback):
17406 (TestRunner::staticFunctions):
17407 (TestRunner::cacheTestRunnerCallback):
17408 (TestRunner::callTestRunnerCallback):
17409 (TestRunner::clearTestRunnerCallbacks):
17410 (nextUIScriptCallbackID):
17411 (TestRunner::runUIScript):
17412 (TestRunner::callUIScriptCallback):
17413 (TestRunner::uiScriptDidComplete):
17414 (TestRunner::cleanup):
17415 * DumpRenderTree/TestRunner.h:
17416 * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
17417 * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
17418 * DumpRenderTree/mac/DumpRenderTree.mm:
17420 * DumpRenderTree/mac/TestRunnerMac.mm:
17421 (TestRunner::mainFrameJSContext):
17422 * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
17423 (WTR::UIScriptController::doAsyncTask):
17424 * DumpRenderTree/win/DumpRenderTree.cpp:
17425 * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
17426 (WTR::JSWrappable::~JSWrappable):
17427 (WTR::JSValueMakeStringOrNull):
17428 * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
17429 (WTR::JSWrapper::wrap):
17430 (WTR::JSWrapper::unwrap):
17431 (WTR::unwrapObject):
17432 (WTR::JSWrapper::initialize):
17433 (WTR::JSWrapper::finalize):
17434 * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
17436 (WTR::setProperty):
17437 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
17438 * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
17439 * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
17440 (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
17441 * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
17442 * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
17443 * WebKitTestRunner/CMakeLists.txt:
17444 * WebKitTestRunner/DerivedSources.make:
17445 * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
17446 (WTR::JSWrappable::~JSWrappable): Deleted.
17447 (WTR::JSValueMakeStringOrNull): Deleted.
17448 * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
17449 (WTR::JSWrapper::wrap): Deleted.
17450 (WTR::JSWrapper::unwrap): Deleted.
17451 (WTR::unwrapObject): Deleted.
17452 (WTR::JSWrapper::initialize): Deleted.
17453 (WTR::JSWrapper::finalize): Deleted.
17454 * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
17455 (WTR::toJS): Deleted.
17456 (WTR::setProperty): Deleted.
17457 * WebKitTestRunner/TestInvocation.cpp:
17458 (WTR::TestInvocation::runUISideScript):
17459 (WTR::TestInvocation::uiScriptDidComplete):
17460 * WebKitTestRunner/TestInvocation.h:
17461 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
17462 * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
17463 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
17464 * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
17465 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
17466 * WebKitTestRunner/config.h:
17467 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
17468 (WTR::UIScriptController::contentVisibleRect):
17470 2016-08-23 Saam Barati <sbarati@apple.com>
17472 JSC should have a "microbenchmarks" directory instead of "regress" directory
17473 https://bugs.webkit.org/show_bug.cgi?id=161096
17475 Rubber stamped by Mark Lam.
17477 This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
17478 directory and removes all the related html and txt files. I did this because
17479 that directory was only there for microbenchmarks, and not for "regression"
17480 tests. I also changed the various scripts to point to it.
17482 * Scripts/run-javascriptcore-tests:
17483 (runJSCStressTests):
17484 * Scripts/run-jsc-benchmarks:
17486 2016-08-23 Alex Christensen <achristensen@webkit.org>
17490 * TestWebKitAPI/CMakeLists.txt:
17491 Include new directory.
17493 2016-08-22 Filip Pizlo <fpizlo@apple.com>
17495 Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
17496 https://bugs.webkit.org/show_bug.cgi?id=160125
17498 Reviewed by Geoffrey Garen.
17500 * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
17501 * Scripts/run-jsc-stress-tests: New test flag!
17503 2016-08-23 Brady Eidson <beidson@apple.com>
17505 WK2 Gamepad layout test support.
17506 https://bugs.webkit.org/show_bug.cgi?id=134671
17508 Reviewed by Alex Christensen.
17510 Have the injected bundle expose the MockGamepadProvider to the UI process, which will then
17511 feed back into the UIGamepadProvider.
17513 Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
17514 as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
17516 * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
17518 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
17519 (WTR::TestRunner::setMockGamepadDetails):
17520 (WTR::TestRunner::setMockGamepadAxisValue):
17521 (WTR::TestRunner::setMockGamepadButtonValue):
17523 * WebKitTestRunner/PlatformWebView.h:
17525 * WebKitTestRunner/TestController.cpp:
17526 (WTR::TestController::initialize):
17528 * WebKitTestRunner/TestInvocation.cpp:
17529 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
17530 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
17532 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
17534 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
17535 (-[WebKitTestRunnerWindow initWithFrame:]):
17536 (-[WebKitTestRunnerWindow dealloc]):
17537 (WTR::PlatformWebView::keyWindow):
17539 * WebKitTestRunner/ios/TestControllerIOS.mm:
17540 (WTR::wtr_NSApplication_keyWindow):
17541 (WTR::TestController::platformInitialize):
17543 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
17544 (+[WebKitTestRunnerWindow _WTR_keyWindow]):
17545 (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
17546 (-[WebKitTestRunnerWindow dealloc]):
17547 (WTR::PlatformWebView::keyWindow):
17549 * WebKitTestRunner/mac/TestControllerMac.mm:
17550 (WTR::wtr_NSApplication_keyWindow):
17551 (WTR::TestController::platformInitialize):
17552 * WebKitTestRunner/mac/main.mm:
17554 2016-08-23 Alexey Proskuryakov <ap@apple.com>
17556 REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
17557 https://bugs.webkit.org/show_bug.cgi?id=161047
17558 rdar://problem/27434307
17560 Reviewed by Lucas Forschler.
17562 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
17564 2016-08-23 Chris Dumez <cdumez@apple.com>
17566 Unreviewed, rolling out r204243.
17568 Caused some layout test failures
17570 Reverted changeset:
17572 "Write API test to cover crash fix in r204135"
17573 https://bugs.webkit.org/show_bug.cgi?id=160587
17574 http://trac.webkit.org/changeset/204243
17576 2016-08-23 Rawinder Singh <rawinder.singh-webkit@cisra.canon.com.au>
17578 Order feature option list in FeatureList.pm
17579 https://bugs.webkit.org/show_bug.cgi?id=161074
17581 Reviewed by Michael Catanzaro.
17583 Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
17585 * Scripts/webkitperl/FeatureList.pm:
17587 2016-08-22 Dewei Zhu <dewei_zhu@apple.com>
17589 Stop python icon bouncing in the dock while running browser benchmarks.
17590 https://bugs.webkit.org/show_bug.cgi?id=161066
17592 Reviewed by Ryosuke Niwa.
17594 Bouncing python icon may impact browser benchmark results.
17595 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
17596 (OSXBrowserDriver.prepare_env):
17597 (OSXBrowserDriver.restore_env):
17599 2016-08-22 Simon Fraser <simon.fraser@apple.com>
17601 <select> menu on iPad causes shifting of hit-testing areas
17602 https://bugs.webkit.org/show_bug.cgi?id=150079
17604 Reviewed by Tim Horton.
17606 -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
17607 so when it changes we have to update visible rects. We were doing this on focus, but failing
17610 Added the ability to test by:
17611 1. Making it possible to initiate an animated scroll in the UI process
17612 2. Adding callbacks for starting and ending interaction with a form control. Sadly
17613 the "ending interaction" for <select> popovers on iPad isn't late enough, since we
17614 have no way currently to know when the dimming view behind the popover animates out,
17615 so for now the test keeps trying to tap a button.
17617 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
17618 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
17619 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
17620 (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
17621 (WTR::UIScriptController::didStartFormControlInteractionCallback):
17622 (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
17623 (WTR::UIScriptController::didEndFormControlInteractionCallback):
17624 (WTR::UIScriptController::scrollToOffset):
17625 (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
17626 (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
17627 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
17628 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
17629 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
17630 (-[TestRunnerWKWebView dealloc]):
17631 (-[TestRunnerWKWebView didStartFormControlInteraction]):
17632 (-[TestRunnerWKWebView didEndFormControlInteraction]):
17633 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
17634 (WTR::contentOffsetBoundedInValidRange):
17635 (WTR::UIScriptController::scrollToOffset):
17636 (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
17637 (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
17639 2016-08-22 Carlos Alberto Lopez Perez <clopez@igalia.com>
17641 [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
17642 https://bugs.webkit.org/show_bug.cgi?id=160927
17644 Reviewed by Daniel Bates.
17646 * Scripts/process-linux-coredump: Removed.
17647 * Scripts/webkitpy/port/efl.py:
17648 (EflPort._get_crash_log):
17649 * Scripts/webkitpy/port/gtk.py:
17650 (GtkPort._get_crash_log):
17651 * Scripts/webkitpy/port/linux_get_crash_log.py:
17652 (GDBCrashLogGenerator.__init__):
17653 (GDBCrashLogGenerator.generate_crash_log):
17654 * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
17655 (GDBCrashLogGeneratorTest.test_generate_crash_log):
17657 2016-08-22 Jonathan Bedard <jbedard@apple.com>
17659 check-webkit-style does not work with Lambda functions in C++
17660 https://bugs.webkit.org/show_bug.cgi?id=160910
17662 Reviewed by Darin Adler.
17664 This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
17666 * Scripts/webkitpy/style/checkers/cpp.py:
17667 (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
17668 (check_for_non_standard_constructs): Added lambda function check.
17669 (check_spacing_for_function_call): Added lambda function check.
17670 (check_braces): Added lambda function check.
17671 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
17672 (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
17674 2016-08-21 Alex Christensen <achristensen@webkit.org>
17676 URLParser should parse IPv4 addresses
17677 https://bugs.webkit.org/show_bug.cgi?id=161023
17679 Reviewed by Darin Adler.
17681 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
17682 (TestWebKitAPI::TEST_F):
17683 (TestWebKitAPI::checkURLDifferences):
17684 We are already getting differences between the old URL::parse and the new URLParser.
17685 (TestWebKitAPI::shouldFail):
17687 2016-08-21 Daniel Bates <dabates@apple.com>
17689 prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
17690 https://bugs.webkit.org/show_bug.cgi?id=148437
17692 Reviewed by Dan Bernstein.
17694 * Scripts/prepare-ChangeLog:
17695 (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
17696 This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
17697 assumes that its line ranges were from a unified diff without any context lines.
17698 (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
17699 (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
17700 * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
17701 based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
17702 * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
17703 (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
17704 to /dev/null for the duration of the function call.
17706 2016-08-20 Gyuyoung Kim <gyuyoung.kim@navercorp.com>
17708 [EFL] Remove unnecessary a patch to mute ecore warnings
17709 https://bugs.webkit.org/show_bug.cgi?id=160997
17711 Reviewed by Darin Adler.
17713 There is no warning messages during the layout test and perf test
17714 after bumping efl version from 1.17 to 1.18. Remove it.
17716 * efl/patches/ecore_remove_warnings.patch: Removed.
17718 2016-08-20 Simon Fraser <simon.fraser@apple.com>
17720 REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
17721 https://bugs.webkit.org/show_bug.cgi?id=160985
17723 Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
17724 device shutdown seems to happen as result of killing Simulator.apps, and we're racing
17727 * Scripts/webkitpy/layout_tests/views/printing.py:
17728 (Printer.print_config):
17729 * Scripts/webkitpy/port/base.py:
17730 (Port.driver_cmd_line_for_logging):
17731 (Port.driver_cmd_line): Deleted.
17732 * Scripts/webkitpy/port/driver.py:
17733 (IOSSimulatorDriver.cmd_line):
17734 * Scripts/webkitpy/port/ios.py:
17735 (IOSSimulatorPort.__init__):
17736 (IOSSimulatorPort.driver_cmd_line_for_logging):
17737 (IOSSimulatorPort._create_simulators):
17738 (IOSSimulatorPort.setup_test_run):
17739 (IOSSimulatorPort._quit_ios_simulator):
17740 (IOSSimulatorPort.clean_up_test_run):
17741 (IOSSimulatorPort._create_device):
17742 (IOSSimulatorPort):
17743 (IOSSimulatorPort._remove_device):
17744 (IOSSimulatorPort._testing_device):
17745 (IOSSimulatorPort.device_id_for_worker_number):
17746 (IOSSimulatorPort._set_device_class): Deleted.
17747 (IOSSimulatorPort.testing_device): Deleted.
17748 * Scripts/webkitpy/port/port_testcase.py:
17749 (PortTestCase.test_driver_cmd_line):
17750 * Scripts/webkitpy/xcode/simulator.py:
17756 (Simulator.create_device):
17757 (Simulator.remove_device):
17758 (Simulator.device_number):
17759 (Simulator.device_state_description):
17760 (Simulator.wait_until_device_is_in_state):
17762 2016-08-19 Ryan Haddad <ryanhaddad@apple.com>
17764 Unreviewed, rolling out r204659.
17766 This change appears to have caused ios-simulator LayoutTests
17767 to fail when shutting down the simulator
17769 Reverted changeset:
17771 "REGRESSION (r204477): Running LayoutTests on ios-simulator
17772 became ~15 minutes slower"
17773 https://bugs.webkit.org/show_bug.cgi?id=160985
17774 http://trac.webkit.org/changeset/204659
17776 2016-08-19 Alexey Proskuryakov <ap@apple.com>
17778 Build fix for non-USE_SIM_SERVICE_CONTEXT builds
17779 * LayoutTestRelay/LayoutTestRelay/main.m: (main):
17781 2016-08-18 Simon Fraser <simon.fraser@apple.com>
17783 REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
17784 https://bugs.webkit.org/show_bug.cgi?id=160985
17786 Reviewed by Alexey Proskuryakov.
17788 r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
17789 a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
17790 must not be @memoized, because their return value depends on the value of simulator_device_type().
17792 Fix by adding some global state in simulator.py that tracks the created devices
17793 in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
17794 and delete them in clean_up_test_run().
17796 Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
17797 that killing the Simulator apps isn't enough.
17799 Simulator tracks the devices in a global dictionary, since state needs to persist
17800 across different instances of IOSSimulatorPort.
17802 Annoyingly, the "Command line:" dumping tried to access a device before we'd done
17803 any setup. Rather than implicitly creating a device here (which the old code did),
17804 override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
17805 and set flag to say that device_id_for_worker_number() doesn't need to return a real
17808 * Scripts/webkitpy/layout_tests/views/printing.py:
17810 (Printer.print_config):
17811 * Scripts/webkitpy/port/base.py:
17812 (Port.driver_cmd_line_for_logging):
17813 (Port.driver_cmd_line): Deleted.
17814 * Scripts/webkitpy/port/driver.py:
17815 (IOSSimulatorDriver.cmd_line):
17816 * Scripts/webkitpy/port/ios.py:
17817 (IOSSimulatorPort.__init__):
17818 (IOSSimulatorPort.driver_cmd_line_for_logging):
17819 (IOSSimulatorPort._create_simulators):
17820 (IOSSimulatorPort.setup_test_run):
17821 (IOSSimulatorPort.clean_up_test_run):
17822 (IOSSimulatorPort._create_device):
17823 (IOSSimulatorPort):
17824 (IOSSimulatorPort._remove_device):
17825 (IOSSimulatorPort._testing_device):
17826 (IOSSimulatorPort.device_id_for_worker_number):
17827 (IOSSimulatorPort._set_device_class): Deleted.
17828 (IOSSimulatorPort.testing_device): Deleted.
17829 * Scripts/webkitpy/port/port_testcase.py:
17830 (PortTestCase.test_driver_cmd_line):
17831 * Scripts/webkitpy/xcode/simulator.py:
17835 (Simulator.create_device):
17836 (Simulator.remove_device):
17837 (Simulator.device_number):
17838 (Simulator.device_state_description):
17839 (Simulator.wait_until_device_is_in_state):
17841 2016-08-19 Alexey Proskuryakov <ap@apple.com>
17843 Adopt SimServiceContext in LayoutTestRelay
17844 https://bugs.webkit.org/show_bug.cgi?id=161000
17845 <rdar://problem/25765594>
17847 Reviewed by Daniel Bates.
17849 * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
17850 * LayoutTestRelay/LayoutTestRelay/main.m:
17852 2016-08-19 Lucas Forschler <lforschler@apple.com>
17854 Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
17856 Reviewed by Kocsen Chung.
17858 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
17861 2016-08-19 Alexey Proskuryakov <ap@apple.com>
17863 Partial revert of r203811 - this key is not needed.
17865 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
17867 2016-08-19 Daniel Bates <dabates@apple.com>
17869 Another attempt to fix the iOS 9.3 build
17871 Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
17873 * DumpRenderTree/mac/Configurations/Base.xcconfig:
17874 * WebKitTestRunner/Configurations/Base.xcconfig:
17876 2016-08-19 Lucas Forschler <lforschler@apple.com>
17878 Remove Yosemite Leaks bot from config.json
17880 Reviewed by Alexey Proskuryakov.
17882 * BuildSlaveSupport/build.webkit.org-config/config.json:
17884 2016-08-18 Dan Bernstein <mitz@apple.com>
17886 [Cocoa] API::Number needs to be wrapped by an NSNumber
17887 https://bugs.webkit.org/show_bug.cgi?id=160977
17888 <rdar://problem/27877735>
17890 Reviewed by Anders Carlsson.
17892 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17893 * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
17894 (TestWebKitAPI::TEST):
17896 2016-08-17 Myles C. Maxfield <mmaxfield@apple.com>
17898 [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
17899 https://bugs.webkit.org/show_bug.cgi?id=160895
17901 Reviewed by Dean Jackson.
17903 Link to the existing CoreText framework.
17905 * DumpRenderTree/PlatformWin.cmake:
17906 * TestWebKitAPI/PlatformWin.cmake:
17908 2016-08-17 Brent Fulgham <bfulgham@apple.com>
17910 [Win] Remove old libraries from build inputs
17911 https://bugs.webkit.org/show_bug.cgi?id=160949
17913 Reviewed by Dean Jackson.
17915 Modify the download script to remove the old 'icuuc.lib' and
17916 'icuin.lib' files for Windows builds.
17918 * Scripts/update-webkit-auxiliary-libs:
17920 2016-08-17 Jonathan Bedard <jbedard@apple.com>
17922 Extra logging for crash reason
17923 https://bugs.webkit.org/show_bug.cgi?id=160943
17925 Reviewed by Alexey Proskuryakov.
17927 A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
17929 * Scripts/webkitpy/port/server_process.py:
17930 (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
17931 (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
17932 (ServerProcess.has_crashed): Ditto.
17934 2016-08-17 Dan Bernstein <mitz@apple.com>
17936 [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
17937 https://bugs.webkit.org/show_bug.cgi?id=160938
17938 <rdar://problem/27876652>
17940 Reviewed by Anders Carlsson.
17942 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17943 * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
17944 (TestWebKitAPI::TEST):
17946 2016-08-17 Chris Fleizach <cfleizach@apple.com>
17948 AX: Support abbreviations in iOS
17949 https://bugs.webkit.org/show_bug.cgi?id=160907
17951 Reviewed by Joanmarie Diggs.
17953 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
17954 (AccessibilityUIElement::stringAttributeValue):
17955 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
17956 (WTR::AccessibilityUIElement::stringAttributeValue):
17958 2016-08-17 Gyuyoung Kim <gyuyoung.kim@navercorp.com>
17960 [EFL] Bump efl version from 1.17 to 1.18
17961 https://bugs.webkit.org/show_bug.cgi?id=160899
17963 Reviewed by Antonio Gomes.
17965 To use efl-1.18, EFL port needs to update install dependencies as well.
17967 * efl/install-dependencies:
17968 * efl/jhbuild.modules:
17970 2016-08-17 Per Arne Vollan <pvollan@apple.com>
17972 [Win] Add tests for linked fonts.
17973 https://bugs.webkit.org/show_bug.cgi?id=160898
17975 Reviewed by Brent Fulgham.
17977 Add tests for https://trac.webkit.org/changeset/204502.
17979 * TestWebKitAPI/PlatformWin.cmake:
17980 * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
17981 (TestWebKitAPI::TEST):
17983 2016-08-16 Daniel Bates <dabates@apple.com>
17985 prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
17986 https://bugs.webkit.org/show_bug.cgi?id=160924
17988 Reviewed by Stephanie Lewis.
17990 Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
17991 and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
17992 We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
17993 test the generate function list machinery without requiring a SCM checkout by substituting a delegate
17994 object that mocks out the file system and SCM operations.
17996 * Scripts/VCSUtils.pm:
17997 (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
17998 * Scripts/prepare-ChangeLog:
17999 (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
18000 abstracting the logic to query the file system and SCM into functions on a delegate object that
18002 (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
18003 (diffHeaderFormat): Deleted.
18005 2016-08-16 Alex Christensen <achristensen@webkit.org>
18007 URLParser should parse URLs without credentials
18008 https://bugs.webkit.org/show_bug.cgi?id=160913
18010 Reviewed by Brady Eidson.
18012 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
18013 (TestWebKitAPI::s):
18014 (TestWebKitAPI::checkURL):
18015 (TestWebKitAPI::TEST_F):
18017 2016-08-16 Anders Carlsson <andersca@apple.com>
18020 https://bugs.webkit.org/show_bug.cgi?id=160908
18022 Reviewed by Geoffrey Garen.
18024 * TestWebKitAPI/CMakeLists.txt:
18025 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
18026 * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
18027 (TestWebKitAPI::TEST):
18029 2016-08-16 Aakash Jain <aakash_jain@apple.com>
18031 EWS logs file are rotated too quickly
18032 https://bugs.webkit.org/show_bug.cgi?id=160724
18034 Reviewed by Daniel Bates.
18036 Currently we are rotating the log file after 10 iterations of queue. If the queue
18037 doesn't have any pending patches, these iterations result in very small amount of
18038 logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
18039 This results in a lot of log files in a day. This patch ensures that we rotate the
18040 log file when its file size is greater than or equal to 100 KB.
18042 * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
18044 2016-08-16 Daniel Bates <dabates@apple.com>
18046 WKSI static library should be named by major iOS revision, not individual updates
18047 https://bugs.webkit.org/show_bug.cgi?id=160727
18048 <rdar://problem/22274848>
18050 Reviewed by Alexey Proskuryakov.
18052 * DumpRenderTree/mac/Configurations/Base.xcconfig:
18053 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
18054 * Scripts/copy-webkitlibraries-to-product-directory:
18055 * WebKitTestRunner/Configurations/Base.xcconfig:
18056 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
18058 2016-08-16 Simon Fraser <simon.fraser@apple.com>
18060 Make it possible to test iOS select elements, and add iPhone and iPad tests for them
18061 https://bugs.webkit.org/show_bug.cgi?id=160909
18063 Reviewed by Enrica Casucci.
18065 Add functions to UIScriptController to dismiss the form accessory view for iOS,
18066 and to programmatically pick a row from a <select> picker.
18068 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
18069 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
18070 (WTR::UIScriptController::dismissFormAccessoryView):
18071 (WTR::UIScriptController::selectFormAccessoryPickerRow):
18072 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
18073 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
18074 (WTR::UIScriptController::dismissFormAccessoryView):
18075 (WTR::UIScriptController::selectFormAccessoryPickerRow):
18077 2016-08-15 Simon Fraser <simon.fraser@apple.com>
18079 [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
18080 https://bugs.webkit.org/show_bug.cgi?id=160878
18082 Reviewed by Tim Horton.
18084 Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
18085 now that we have the ability to run tests in the iPad simulator.
18087 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
18088 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
18089 (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
18090 (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
18091 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
18092 * WebKitTestRunner/ios/TestControllerIOS.mm:
18093 (WTR::TestController::platformResetStateToConsistentValues): Deleted.
18094 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
18095 (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
18096 (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
18098 2016-08-15 Anders Carlsson <andersca@apple.com>
18100 Add an address-of operator to RetainPtr
18101 https://bugs.webkit.org/show_bug.cgi?id=160879
18103 Reviewed by Tim Horton.
18105 Test HashMap and HashSet with an object whose operator& is deleted.
18107 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
18108 Sort the Xcode project.
18110 * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
18111 (DeletedAddressOfOperator::DeletedAddressOfOperator):
18112 (DeletedAddressOfOperator::value):
18113 (DeletedAddressOfOperator::operator==):
18114 (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
18115 (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
18116 (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
18117 (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
18118 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
18119 (TestWebKitAPI::TEST):
18120 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
18121 (TestWebKitAPI::TEST):
18123 2016-08-16 Jonathan Bedard <jbedard@apple.com>
18125 False crashes in fast/text/emoji-gender-* tests
18126 https://bugs.webkit.org/show_bug.cgi?id=160779
18128 Reviewed by Alexey Proskuryakov.
18130 Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
18132 * Scripts/webkitpy/port/driver.py:
18133 (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
18134 * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
18135 * Scripts/webkitpy/port/server_process.py:
18136 (ServerProcess.write): Allow caller to disable crash flag on exception.
18138 2016-08-15 Simon Fraser <simon.fraser@apple.com>
18140 webkitpy error in TestRunResults.merge()
18141 https://bugs.webkit.org/show_bug.cgi?id=160882
18143 Reviewed by Daniel Bates.
18145 The argument to TestRunResults.merge() can be None if there are no device-specifc
18146 initial results or retry results in Manager.run(), so just return early in that case.
18148 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
18149 (TestRunResults.merge):
18151 2016-08-15 Sam Weinig <sam@webkit.org>
18153 Speed up compile times by not including wtf/Variant.h so much
18154 https://bugs.webkit.org/show_bug.cgi?id=160847
18156 Reviewed by Alex Christensen and Saam Barati.
18158 * TestWebKitAPI/Tests/WTF/Variant.cpp:
18159 (TestWebKitAPI::TEST):
18160 Explicitly use std::experimental::variant.
18162 2016-08-15 Simon Fraser <simon.fraser@apple.com>
18164 Allow a port to run tests with a custom device setup
18165 https://bugs.webkit.org/show_bug.cgi?id=160833
18167 Reviewed by Daniel Bates.
18169 These changes allow the IOSSimulator port to run tests in iPad mode.
18171 This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
18172 in this case 'ipad'. When specified, any test in a directory with a suffix that matches
18173 a custom device will be collected into a set, and run in that device's environment after
18174 the other tests have run.
18176 * Scripts/webkitpy/layout_tests/controllers/manager.py:
18177 (Manager._custom_device_for_test): If the test contains a directory matching a
18178 custom device suffix, return that custom device.
18179 (Manager._set_up_run): Push the custom device class, if any, into options so
18180 that the Worker can get to it.
18181 (Manager.run): Go through the list of tests, and break it down into device-generic
18182 tests, and tests for each device class. _run_test_subset is then called for
18183 each collection of tests, and the results merged.
18184 (Manager._run_test_subset): Some lines unwrapped.
18185 (Manager._end_test_run):
18186 (Manager._run_tests):
18187 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
18188 (SingleTestRunner.__init__): Unwrapped a line.
18189 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
18190 (TestRunResults.merge): Add this function to merge TestRunResults
18191 * Scripts/webkitpy/layout_tests/views/printing.py:
18192 (Printer.print_workers_and_shards): Print the custom device, if any.
18193 * Scripts/webkitpy/port/base.py:
18194 (Port): Base port has empty array of custom devices.
18195 (Port.setup_test_run): Add device_class argument.
18196 * Scripts/webkitpy/port/driver.py:
18197 (DriverInput.__repr__):
18198 (Driver.check_driver.implementation):
18199 * Scripts/webkitpy/port/efl.py:
18200 (EflPort.setup_test_run):
18201 * Scripts/webkitpy/port/gtk.py:
18202 (GtkPort.setup_test_run):
18203 * Scripts/webkitpy/port/ios.py:
18204 (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
18205 (IOSSimulatorPort.__init__):
18206 (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
18207 based on the custom device class.
18208 (IOSSimulatorPort._set_device_class):
18209 (IOSSimulatorPort._create_simulators): Factor some code into this function.
18210 (IOSSimulatorPort.setup_test_run):
18211 (IOSSimulatorPort.testing_device):
18212 (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
18213 seemed wrong for this function. That was moved to setup_test_run().
18214 (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
18215 but this happened too early, before we knew which kind of devices to create. Devices
18216 are now created in setup_test_run().
18217 * Scripts/webkitpy/port/win.py:
18218 (WinPort.setup_test_run):
18220 2016-08-15 Daniel Bates <dabates@apple.com>
18222 Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
18223 private frameworks and libraries
18224 https://bugs.webkit.org/show_bug.cgi?id=155931
18225 <rdar://problem/25807989>
18227 Reviewed by Dan Bernstein.
18229 Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
18230 where X is the major version of the active iOS SDK.
18232 * DumpRenderTree/mac/Configurations/Base.xcconfig:
18233 * WebKitTestRunner/Configurations/Base.xcconfig:
18235 2016-08-15 Simon Fraser <simon.fraser@apple.com>
18237 Add a setting and preferences to enable visual viewport mode
18238 https://bugs.webkit.org/show_bug.cgi?id=160843
18240 Reviewed by Sam Weinig.
18242 Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
18244 * MiniBrowser/mac/SettingsController.h:
18245 * MiniBrowser/mac/SettingsController.m:
18246 (-[SettingsController _populateMenu]):
18247 (-[SettingsController validateMenuItem:]):
18248 (-[SettingsController visualViewportEnabled]):
18249 (-[SettingsController toggleVisualViewportEnabled:]):
18250 * MiniBrowser/mac/WK1BrowserWindowController.m:
18251 (-[WK1BrowserWindowController didChangeSettings]):
18252 * MiniBrowser/mac/WK2BrowserWindowController.m:
18253 (-[WK2BrowserWindowController didChangeSettings]):
18255 2016-08-15 Konstantin Tokarev <annulen@yandex.ru>
18257 Allow using make-dist with non-GTK ports
18258 https://bugs.webkit.org/show_bug.cgi?id=160842
18260 Reviewed by Michael Catanzaro.
18262 This patch adds support for setting base name of tarball and argument
18263 passed to cmake's -DPORT= via command line arguments.
18265 * gtk/make-dist.py:
18266 (Distcheck.configure):
18268 (get_tarball_root_and_output_filename_from_arguments):
18270 2016-08-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
18272 [GTK] Install script lacks gstreamer related dependencies
18273 https://bugs.webkit.org/show_bug.cgi?id=160814
18275 Reviewed by Carlos Garcia Campos.
18277 * gtk/install-dependencies: Fedora case had already listed this dependencies,
18278 but both Arch and Debian/Ubuntu were missing them.
18280 2016-08-13 Konstantin Tokarev <annulen@yandex.ru>
18282 make-dist.py should not allow unknown rules in manifest
18283 https://bugs.webkit.org/show_bug.cgi?id=160841
18285 Reviewed by Carlos Garcia Campos.
18287 * gtk/make-dist.py:
18288 (Manifest.process_line):
18290 2016-08-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
18292 [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
18293 https://bugs.webkit.org/show_bug.cgi?id=160809
18295 Reviewed by Carlos Garcia Campos.
18297 * efl/install-dependencies: Factorize the previous logic for handling the php5/7
18298 case, and use it also for the new package names of libpng and libgeoclue.
18299 * gtk/install-dependencies: Ditto.
18301 2016-08-12 Gyuyoung Kim <gyuyoung.kim@webkit.org>
18303 Skip to check directories existence in build-webkit
18304 https://bugs.webkit.org/show_bug.cgi?id=160691
18306 Reviewed by Alex Christensen.
18308 CMake checks if directories are there itself. So CMake ports
18309 don't need to check it in the build-webkit script.
18311 * Scripts/build-webkit:
18312 * Scripts/webkitdirs.pm:
18313 (determineSourceDir):
18316 2016-08-12 Alex Christensen <achristensen@webkit.org>
18318 Make URLParser work with URLs missing URL parts
18319 https://bugs.webkit.org/show_bug.cgi?id=160824
18321 Reviewed by Brady Eidson.
18323 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
18324 (TestWebKitAPI::s):
18325 (TestWebKitAPI::checkURL):
18326 (TestWebKitAPI::TEST_F):
18327 (TestWebKitAPI::eq): Deleted.
18329 2016-08-12 John Wilander <wilander@apple.com>
18331 Add HashCountedSet API tests to TestWTFLibrary target
18332 https://bugs.webkit.org/show_bug.cgi?id=160815
18334 Reviewed by Alex Christensen.
18336 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
18337 Added HashCountedSet.cpp and sorted the file reference section
18338 according to UNIX sort.
18340 2016-08-12 Ryosuke Niwa <rniwa@webkit.org>
18342 run-benchmark should run JetStream 1.1 instead of 1.0.1
18343 https://bugs.webkit.org/show_bug.cgi?id=160816
18345 Reviewed by Filip Pizlo.
18347 Use the latest JetStream 1.1 in run-benchmark.
18349 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
18350 (BenchmarkBuilder.__exit__):
18351 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
18352 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
18353 change to JetStream directory.
18355 2016-08-12 Alex Christensen <achristensen@webkit.org>
18357 Initial URLParser implementation
18358 https://bugs.webkit.org/show_bug.cgi?id=160811
18360 Reviewed by Brady Eidson.
18362 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
18363 (TestWebKitAPI::eq):
18364 (TestWebKitAPI::checkURL):
18365 (TestWebKitAPI::TEST_F):
18367 2016-08-12 Brady Eidson <beidson@apple.com>
18369 Fix the 32-bit Mac build after:
18370 Add WK2 ExperimentalFeature support to MiniBrowser
18371 https://bugs.webkit.org/show_bug.cgi?id=160788
18375 Sprinkle "#if WK_API_ENABLED"s liberally.
18377 * MiniBrowser/mac/AppDelegate.m:
18378 (defaultConfiguration):
18379 * MiniBrowser/mac/SettingsController.m:
18380 (-[SettingsController _populateMenu]):
18381 (-[SettingsController validateMenuItem:]):
18383 2016-08-12 Philippe Normand <pnormand@igalia.com>
18385 [GStreamer][OWR] Video rendering fixes
18386 https://bugs.webkit.org/show_bug.cgi?id=160764
18388 Reviewed by Xabier Rodriguez-Calvar.
18390 * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
18392 2016-08-12 Per Arne Vollan <pvollan@apple.com>
18394 Add missing return statement in convertFast function added in r204376.
18398 * Scripts/webkitpy/common/system/path.py:
18399 (_CygPath.convertFast):
18401 2016-08-11 Brady Eidson <beidson@apple.com>
18403 Add WK2 ExperimentalFeature support to MiniBrowser.
18404 https://bugs.webkit.org/show_bug.cgi?id=160788
18406 Reviewed by Alex Christensen.
18408 * MiniBrowser/mac/AppDelegate.h:
18409 * MiniBrowser/mac/AppDelegate.m:
18410 (defaultConfiguration):
18411 (defaultPreferences):
18413 * MiniBrowser/mac/SettingsController.m:
18414 (-[SettingsController _populateMenu]):
18415 (-[SettingsController validateMenuItem:]):
18416 (-[SettingsController toggleExperimentalFeature:]):
18418 2016-08-11 Aakash Jain <aakash_jain@apple.com>
18420 Keep EWS logs for longer
18421 https://bugs.webkit.org/show_bug.cgi?id=160776
18423 Reviewed by Daniel Bates.
18425 * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
18427 2016-08-11 Simon Fraser <simon.fraser@apple.com>
18429 iOS DRT/WTR project cleanup
18430 https://bugs.webkit.org/show_bug.cgi?id=160778
18432 Reviewed by Tim Horton.
18434 Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
18436 Remove AppDelegate.* which were unused.
18438 Exclude ios/Launch.storyboard on more platforms.
18440 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
18441 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
18442 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
18443 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
18444 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
18445 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
18446 (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
18448 2016-08-11 Alex Christensen <achristensen@webkit.org>
18450 Fix Yosemite bots' cookie accept policies after r204365.
18451 https://bugs.webkit.org/show_bug.cgi?id=160758
18453 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
18455 This makes the test fully clean up after itself.
18457 2016-08-11 Alex Christensen <achristensen@webkit.org>
18459 Fix Yosemite bots' cookie accept policies after r204365.
18460 https://bugs.webkit.org/show_bug.cgi?id=160758
18462 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
18464 I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
18465 On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
18466 On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
18467 causing any problems because there are no other API tests that do anything with cookies.
18468 My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
18469 but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
18470 to reset any bots that have run tests since r204365. I will commit a followup that sets it to originalCookieAcceptPolicy.
18472 2016-08-11 Aakash Jain <aakash_jain@apple.com>
18474 EWS should check if the patch is still valid before executing every major step
18475 https://bugs.webkit.org/show_bug.cgi?id=160739
18476 rdar://problem/27768813
18478 Reviewed by Alexey Proskuryakov.
18480 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
18481 (CommitQueueTask.run): validate method is now executed in base class.
18482 * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
18483 (EarlyWarningSystemTask.run): validate method is now executed in base class.
18484 * Scripts/webkitpy/tool/bot/stylequeuetask.py:
18485 (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
18486 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
18487 (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
18488 that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
18489 * Scripts/webkitpy/tool/commands/perfalizer.py:
18490 (PerfalizerTask.validate): Added.
18491 * Scripts/webkitpy/tool/commands/queues_unittest.py:
18492 (test_manual_reject_during_processing): Updated test case.
18494 2016-08-11 Alex Christensen <achristensen@webkit.org>
18497 https://bugs.webkit.org/show_bug.cgi?id=160770
18499 Reviewed by Sam Weinig.
18501 * TestWebKitAPI/PlatformGTK.cmake:
18502 * TestWebKitAPI/PlatformWin.cmake:
18503 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
18504 * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
18505 (TestWebKitAPI::TEST_F):
18507 2016-08-10 Simon Fraser <simon.fraser@apple.com>
18509 [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
18510 https://bugs.webkit.org/show_bug.cgi?id=160761
18512 Reviewed by Tim Horton.
18514 Give iOS DRT a Launch storyboard.
18516 Have it use a UIViewController so future forms testing works correctly.
18518 Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
18519 can run in iPad mode.
18521 Remove empty InfoPlist.strings files.
18523 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
18524 * DumpRenderTree/ios/Info.plist:
18525 * DumpRenderTree/ios/Launch.storyboard: Added.
18526 * DumpRenderTree/mac/DumpRenderTree.mm:
18527 (createWebViewAndOffscreenWindow):
18528 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
18529 * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
18530 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
18531 (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
18533 2016-08-11 Per Arne Vollan <pvollan@apple.com>
18535 [Win] Unable to reliably run tests in parallel
18536 https://bugs.webkit.org/show_bug.cgi?id=140914
18538 Reviewed by Brent Fulgham.
18540 The cygpath utility function can fail badly when running with multiple DumpRenderTree
18541 processes. We can use string replacement to convert the Cygwin path to a Windows path
18544 * Scripts/webkitpy/common/system/path.py:
18546 * Scripts/webkitpy/port/driver.py:
18547 (Driver._command_from_driver_input):
18549 2016-08-10 Alex Christensen <achristensen@webkit.org>
18551 Fix crash when changing cookie accept policy after r204327
18552 https://bugs.webkit.org/show_bug.cgi?id=160758
18554 Reviewed by Simon Fraser.
18556 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
18557 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
18558 (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
18560 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
18562 2016-08-10 Simon Fraser <simon.fraser@apple.com>
18564 [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
18565 https://bugs.webkit.org/show_bug.cgi?id=160757
18567 Reviewed by Tim Horton.
18569 When programmatically creating the test UIWindow, make a root UIViewController and parent
18570 the WKWebView in its view. This makes the app more like a normal UIKit application.
18572 Move the WKWebView down 20px to avoid the status bar.
18574 Give the UIWindow a gray background so it's obvious where the window and view positioned.
18576 Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
18578 Remove duplicate references to Launch.storyboard.
18580 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
18581 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
18582 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
18583 (-[AppDelegate applicationWillResignActive:]): Deleted.
18584 (-[AppDelegate applicationDidEnterBackground:]): Deleted.
18585 (-[AppDelegate applicationWillEnterForeground:]): Deleted.
18586 (-[AppDelegate applicationDidBecomeActive:]): Deleted.
18587 (-[AppDelegate applicationWillTerminate:]): Deleted.
18588 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
18589 (WTR::viewRectForWindowRect):
18590 (WTR::PlatformWebView::PlatformWebView):
18591 (WTR::PlatformWebView::setWindowFrame):
18593 2016-08-10 Simon Fraser <simon.fraser@apple.com>
18595 [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
18596 https://bugs.webkit.org/show_bug.cgi?id=160748
18598 Reviewed by Tim Horton.
18600 Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
18601 opens the door for tests using other device sizes.
18603 * WebKitTestRunner/ios/TestControllerIOS.mm:
18604 (WTR::TestController::platformConfigureViewForTest):
18606 2016-08-10 Simon Fraser <simon.fraser@apple.com>
18608 Sort the feature flags in the FEATURE_DEFINES lines
18609 https://bugs.webkit.org/show_bug.cgi?id=160742
18611 Reviewed by Anders Carlsson.
18613 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
18615 2016-08-09 Simon Fraser <simon.fraser@apple.com>
18617 Logging and other minor improvements to iOS webkitpy
18618 https://bugs.webkit.org/show_bug.cgi?id=160722
18620 Reviewed by Dan Bates.
18622 Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
18623 to make it easier to debug launching issues.
18625 Have reset_preferences() reset the device, rather than just nuking the data
18626 directory (which broke some versions of the simulator).
18628 Make the Simulator.app launch in the background with open -g.
18630 Wait for the simulator device to be in a known state in some more places.
18632 * Scripts/webkitpy/port/ios.py:
18633 (IOSSimulatorPort.setup_test_run):
18634 (IOSSimulatorPort._quit_ios_simulator):
18635 (IOSSimulatorPort.clean_up_test_run):
18636 (IOSSimulatorPort.setup_environ_for_server):
18637 (IOSSimulatorPort.reset_preferences):
18638 * Scripts/webkitpy/xcode/simulator.py:
18643 (Simulator.wait_until_device_is_booted):
18644 (Simulator.wait_until_device_is_in_state):
18646 (Simulator.delete_device):
18647 (Simulator.reset_device):
18648 (Simulator.lookup_or_create_device):
18650 2016-08-10 Carlos Alberto Lopez Perez <clopez@igalia.com>
18652 [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
18653 https://bugs.webkit.org/show_bug.cgi?id=160697
18655 Reviewed by Antonio Gomes.
18657 * Scripts/webkitpy/port/base.py:
18658 (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
18659 list of environment variables to copy.
18661 2016-08-09 George Ruan <gruan@apple.com>
18663 Implement functionality of media capture on iOS
18664 https://bugs.webkit.org/show_bug.cgi?id=158945
18665 <rdar://problem/26893343>
18667 Reviewed by Tim Horton.
18669 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
18670 Capture feature on iOS.
18672 2016-08-09 Saam Barati <sbarati@apple.com>
18674 Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
18675 https://bugs.webkit.org/show_bug.cgi?id=160671
18676 <rdar://problem/27756112>
18678 Reviewed by Mark Lam.
18680 * Scripts/run-jsc-stress-tests:
18682 2016-08-09 Alexey Proskuryakov <ap@apple.com>
18684 Make directory reading code in iOSSimulatorDevices() more strict
18685 https://bugs.webkit.org/show_bug.cgi?id=160702
18687 Reviewed by Tim Horton.
18689 * Scripts/webkitdirs.pm:
18690 (iOSSimulatorDevices):
18692 2016-08-06 Sam Weinig <sam@webkit.org>
18694 Replace NodeOrString with std::variant<RefPtr<Node>, String>
18695 https://bugs.webkit.org/show_bug.cgi?id=160638
18697 Reviewed by Anders Carlsson.
18699 * TestWebKitAPI/CMakeLists.txt:
18700 * TestWebKitAPI/Tests/WTF/Variant.cpp:
18701 Add additional tests for the initial state of std::variant and using
18702 makeVisitor for visiting.
18704 2016-08-09 Aakash Jain <aakash_jain@apple.com>
18706 EWS logging should ensure the logging to file is stopped on queue termination
18707 https://bugs.webkit.org/show_bug.cgi?id=160698
18708 rdar://problem/24464570
18710 Reviewed by Daniel Bates.
18712 * Scripts/webkitpy/tool/bot/queueengine.py:
18713 (QueueEngine._stopping): Stop logging to file on queue termination.
18714 (QueueEngine._begin_logging): Configure the Python logger to log to file.
18715 * Scripts/webkitpy/common/system/logutils.py:
18716 (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
18717 * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
18718 (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
18719 * Scripts/webkitpy/tool/commands/queues.py:
18720 (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
18721 (AbstractQueue.queue_log_path): Same.
18722 (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
18723 (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
18724 which moved to QueueEngine now.
18725 (PatchProcessingQueue.__init__): Same.
18726 (CommitQueue.__init__): Same.
18727 (AbstractReviewQueue.__init__): Same.
18728 (StyleQueue.__init__): Same.
18729 * Scripts/webkitpy/tool/commands/queues_unittest.py:
18730 (TestCommitQueue): Removed host parameter.
18731 (TestCommitQueue.__init__): Same.
18732 (AbstractPatchQueueTest.test_next_patch): Same.
18733 (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
18734 (test_commit_queue_failure): Same.
18735 (mock_run_webkit_patch):
18736 (MockCommitQueueTask.results_from_patch_test_run): Same.
18737 (test_rollout_lands): Same.
18738 (test_non_valid_patch): Same.
18739 (test_auto_retry): Same.
18740 (test_style_queue_with_watch_list_exception): Same.
18741 (TestQueue.__init__): Deleted.
18742 (TestReviewQueue.__init__): Deleted.
18743 (TestFeederQueue.__init__): Deleted.
18745 2016-08-09 Konstantin Tokarev <annulen@yandex.ru>
18747 webkit-gtk tarball fails to build due to missing files
18748 https://bugs.webkit.org/show_bug.cgi?id=160684
18750 Reviewed by Alex Christensen.
18752 * gtk/manifest.txt.in: Added back spi directories.
18754 2016-08-09 Carlos Alberto Lopez Perez <clopez@igalia.com>
18756 [GTK] Build the jhbuild with -O2 optimization level by default
18757 https://bugs.webkit.org/show_bug.cgi?id=160544
18759 Reviewed by Michael Catanzaro.
18761 * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
18762 which don't increases the required disk space significatively and
18763 provides better debug information than no passing it.
18765 2016-08-09 Csaba Osztrogonác <ossy@webkit.org>
18767 Allow more --cmakeargs option in build-jsc and build-webkit
18768 https://bugs.webkit.org/show_bug.cgi?id=160340
18770 Reviewed by Michael Catanzaro.
18772 * Scripts/build-jsc:
18773 * Scripts/build-webkit:
18775 2016-08-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
18777 Do not check if WebKitLibraries folder exists on EFL and GTK
18778 https://bugs.webkit.org/show_bug.cgi?id=160659
18780 Reviewed by Csaba Osztrogonác.
18782 Though WebKitLibraries is only needed by mac and win ports,
18783 EFL and GTK ports have checked whether it exists.
18785 * Scripts/build-webkit:
18787 2016-08-08 Aakash Jain <aakash_jain@apple.com>
18789 Some EWS console logs doesn't go to log file
18790 https://bugs.webkit.org/show_bug.cgi?id=160585
18791 rdar://problem/24464570
18793 Reviewed by Daniel Bates.
18795 * Scripts/webkitpy/common/system/logutils.py:
18796 (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
18797 any possible overwriting.
18798 * Scripts/webkitpy/common/system/filesystem.py:
18799 (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
18800 * Scripts/webkitpy/common/system/filesystem_mock.py:
18801 (MockFileSystem.open_text_file_for_writing): Same.
18802 * Scripts/webkitpy/common/system/filesystem_unittest.py:
18803 (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
18804 (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
18805 * Scripts/webkitpy/tool/commands/queues.py:
18806 (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
18807 This will ensure that all the sub-modules inside webkitpy will log to file.
18809 2016-08-08 Simon Fraser <simon.fraser@apple.com>
18811 Have the iOS platform interit from the Apple platform in webkitpy
18812 https://bugs.webkit.org/show_bug.cgi?id=160672
18814 Reviewed by Dan Bates.
18816 The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
18817 Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
18820 Since WinPort also inherits from ApplePort, it needs to stub out some things
18821 that are unavailable on Windows (leaks, sampling).
18823 Some SnowLeopard-related code and the associated test were removed.
18825 * Scripts/webkitpy/port/apple.py:
18826 (ApplePort.__init__):
18828 (ApplePort._make_leak_detector):
18829 (ApplePort.default_timeout_ms):
18830 (ApplePort.supports_per_test_timeout):
18831 (ApplePort.should_retry_crashes):
18832 (ApplePort._generate_all_test_configurations):
18833 (ApplePort.check_for_leaks):
18834 (ApplePort.print_leaks_summary):
18835 (ApplePort._path_to_webcore_library):
18836 (ApplePort.show_results_html_file):
18837 (ApplePort._merge_crash_logs):
18838 (ApplePort._look_for_all_crash_logs_in_log_dir):
18839 (ApplePort._get_crash_log):
18840 (ApplePort.look_for_new_crash_logs):
18841 (ApplePort.sample_process):
18842 (ApplePort.sample_file_path):
18843 (ApplePort.look_for_new_samples):
18844 (ApplePort._path_to_helper):
18845 (ApplePort.determine_full_port_name): Deleted.
18846 * Scripts/webkitpy/port/ios.py:
18847 (IOSSimulatorPort):
18848 (IOSSimulatorPort.__init__):
18849 (IOSSimulatorPort.default_timeout_ms): Deleted.
18850 (IOSSimulatorPort.supports_per_test_timeout): Deleted.
18851 (IOSSimulatorPort.should_retry_crashes): Deleted.
18852 (IOSSimulatorPort.check_for_leaks): Deleted.
18853 (IOSSimulatorPort.print_leaks_summary): Deleted.
18854 (IOSSimulatorPort._path_to_webcore_library): Deleted.
18855 (IOSSimulatorPort.show_results_html_file): Deleted.
18856 (IOSSimulatorPort.sample_file_path): Deleted.
18857 (IOSSimulatorPort._merge_crash_logs): Deleted.
18858 (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
18859 (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
18860 (IOSSimulatorPort.look_for_new_samples): Deleted.
18861 (IOSSimulatorPort.sample_process): Deleted.
18862 (IOSSimulatorPort._path_to_helper): Deleted.
18863 (IOSSimulatorPort.make_command): Deleted.
18864 * Scripts/webkitpy/port/mac.py:
18865 (MacPort.__init__):
18866 (MacPort.make_command):
18867 (MacPort._build_java_test_support):
18868 (MacPort): Deleted.
18869 (MacPort.default_timeout_ms): Deleted.
18870 (MacPort.supports_per_test_timeout): Deleted.
18871 (MacPort.should_retry_crashes): Deleted.
18872 (MacPort.default_child_processes): Deleted.
18873 (MacPort.check_for_leaks): Deleted.
18874 (MacPort.print_leaks_summary): Deleted.
18875 (MacPort._path_to_webcore_library): Deleted.
18876 (MacPort.show_results_html_file): Deleted.
18877 (MacPort.sample_file_path): Deleted.
18878 (MacPort._merge_crash_logs): Deleted.
18879 (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
18880 (MacPort.look_for_new_crash_logs): Deleted.
18881 (MacPort.look_for_new_samples): Deleted.
18882 (MacPort.sample_process): Deleted.
18883 (MacPort._path_to_helper): Deleted.
18884 * Scripts/webkitpy/port/mac_unittest.py:
18885 (MacTest.test_default_child_processes): Deleted.
18886 * Scripts/webkitpy/port/win.py:
18887 (WinPort.look_for_new_samples):
18889 (WinPort.sample_process):
18890 (WinPort._make_leak_detector):
18891 (WinPort.check_for_leaks):
18892 (WinPort.print_leaks_summary):
18893 (WinPort._path_to_webcore_library):
18895 2016-08-08 Matt Baker <mattbaker@apple.com>
18897 Unreviewed: moved myself to the reviewers list.
18899 * Scripts/webkitpy/common/config/contributors.json:
18901 2016-08-08 Chris Dumez <cdumez@apple.com>
18903 Update API tests in mac/SetDocumentURI.mm after r204247
18904 https://bugs.webkit.org/show_bug.cgi?id=160660
18906 Reviewed by Alex Christensen.
18908 * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
18909 (TestWebKitAPI::TEST):
18911 2016-08-08 Jonathan Bedard <jbedard@apple.com>
18913 run-webkit-tests should trigger a spindump when WebContent process is unresponsive
18914 https://bugs.webkit.org/show_bug.cgi?id=159827
18916 Reviewed by Daniel Bates.
18918 This change was spurred by a process hang which occurred between tests and did
18919 not produce a meaningful crashlog.
18921 * Scripts/webkitpy/port/driver.py:
18922 (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
18924 * Scripts/webkitpy/port/ios.py:
18925 (IOSSimulatorPort):
18926 (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
18927 * Scripts/webkitpy/port/mac.py:
18929 (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
18931 * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
18932 * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
18934 * WebKitTestRunner/TestController.h:
18935 (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
18936 * WebKitTestRunner/TestInvocation.cpp:
18937 (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
18939 2016-08-07 Dan Bernstein <mitz@apple.com>
18941 [Cocoa] Reply block leaks if the remote object doesn’t call it
18942 https://bugs.webkit.org/show_bug.cgi?id=160642
18944 Reviewed by Sam Weinig.
18946 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
18947 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
18948 (TEST): Added a test case that checks that the reply block is released even when it’s not
18950 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
18951 (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
18952 calling the completion handler.
18954 2016-08-07 Chris Dumez <cdumez@apple.com>
18956 Write API test to cover crash fix in r204135
18957 https://bugs.webkit.org/show_bug.cgi?id=160587
18959 Reviewed by Darin Adler.
18961 Add API test to cover crash fix in r204135. This reproduces the crash
18962 by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
18965 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
18966 (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
18969 2016-08-06 Chris Dumez <cdumez@apple.com>
18971 Unreviewed, rolling out r204226.
18973 Broke some API tests
18975 Reverted changeset:
18977 "Write API test to cover crash fix in r204135"
18978 https://bugs.webkit.org/show_bug.cgi?id=160587
18979 http://trac.webkit.org/changeset/204226
18981 2016-08-06 Aakash Jain <aakash_jain@apple.com>
18983 EWS Style Queue fails to process patches which fails validation
18984 https://bugs.webkit.org/show_bug.cgi?id=160632
18986 Reviewed by Alexey Proskuryakov.
18988 * Scripts/webkitpy/tool/bot/stylequeuetask.py:
18989 (StyleQueueTask.validate): Add more information about validation failure.
18990 (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
18991 * Scripts/webkitpy/tool/commands/queues_unittest.py:
18992 (test_non_valid_patch): Add a unit test to test the above code path.
18994 2016-08-06 Sam Weinig <sam@webkit.org>
18996 WTF needs a variant implementation
18997 https://bugs.webkit.org/show_bug.cgi?id=160618
18999 Reviewed by Darin Adler.
19001 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19002 * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
19003 Add tests for the variant implementation.
19005 2016-08-06 Chris Dumez <cdumez@apple.com>
19007 Write API test to cover crash fix in r204135
19008 https://bugs.webkit.org/show_bug.cgi?id=160587
19010 Reviewed by Darin Adler.
19012 Add API test to cover crash fix in r204135. This reproduces the crash
19013 by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
19016 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
19017 (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
19020 2016-08-05 Tim Horton <timothy_horton@apple.com>
19022 run-api-tests should use a headed simulator
19023 https://bugs.webkit.org/show_bug.cgi?id=160611
19025 Reviewed by Sam Weinig.
19027 CADisplayLink doesn't work in a headless simulator, but is
19028 vital for the proper functioning of WebKit2 painting on iOS.
19029 So, we should not use a headless simulator.
19031 * Scripts/run-api-tests:
19032 Launch a simulator app, don't just boot the simulator.
19034 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
19035 Re-enable a test that works now.
19037 2016-08-05 Dan Bernstein <mitz@apple.com>
19039 [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
19040 https://bugs.webkit.org/show_bug.cgi?id=160589
19042 Reviewed by Tim Horton.
19044 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
19045 (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
19046 blocks, which wasn’t caught because the test wasn’t run correctly.
19047 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
19048 (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
19049 added a test that sends over an NSRange.
19050 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
19051 (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
19052 handler with the range‘s location and length.
19054 2016-08-05 Enrica Casucci <enrica@apple.com>
19056 Fixing tests failing after r204175.
19060 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
19062 2016-08-05 Enrica Casucci <enrica@apple.com>
19064 Build fix after 204053.
19068 * TestWebKitAPI/Configurations/Base.xcconfig:
19069 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
19070 (-[MockContentFilterEnabler initWithCoder:]):
19071 (-[MockContentFilterEnabler dealloc]):
19073 2016-08-05 Konstantin Tokarev <annulen@yandex.ru>
19075 Print test name in "Last character read from DRT..." error message.
19076 https://bugs.webkit.org/show_bug.cgi?id=160559
19078 Reviewed by Michael Catanzaro.
19080 * Scripts/webkitpy/port/driver.py:
19082 (Driver._read_first_block):
19083 (Driver._read_optional_image_block):
19084 (Driver._read_block):
19085 * Scripts/webkitpy/port/driver_unittest.py:
19086 (DriverTest.test_read_block):
19087 (DriverTest.test_read_binary_block):
19088 (DriverTest.test_read_base64_block):
19090 2016-08-05 Commit Queue <commit-queue@webkit.org>
19092 Unreviewed, rolling out r204123.
19093 https://bugs.webkit.org/show_bug.cgi?id=160597
19095 Caused layout test timeouts on Windows. (Requested by perarne
19098 Reverted changeset:
19100 "[Win] Unable to reliably run tests in parallel"
19101 https://bugs.webkit.org/show_bug.cgi?id=140914
19102 http://trac.webkit.org/changeset/204123
19104 2016-08-04 Saam Barati <sbarati@apple.com>
19106 Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
19107 https://bugs.webkit.org/show_bug.cgi?id=151241
19109 Reviewed by Benjamin Poulain.
19111 * Scripts/run-jsc-stress-tests:
19113 2016-08-04 Dean Johnson <dean_johnson@apple.com>
19115 UI improvements to Flakiness Dashboard.
19116 https://bugs.webkit.org/show_bug.cgi?id=153295
19118 Reviewed by Alexey Proskuryakov.
19120 * TestResultServer/static-dashboards/flakiness_dashboard.css:
19121 (td.options-container): Center text in most fields.
19122 * TestResultServer/static-dashboards/flakiness_dashboard.js:
19123 (createBugHTML): Text/Grammar updates.
19124 (tableHeaders): Ditto.
19125 (htmlForSingleTestRow): Ditto.
19126 (headerForTestTableHtml): Ditto.
19127 * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
19128 (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
19130 2016-08-04 Carlos Alberto Lopez Perez <clopez@igalia.com>
19132 [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
19133 https://bugs.webkit.org/show_bug.cgi?id=160518
19135 Reviewed by Michael Catanzaro.
19137 * Scripts/webkitpy/thirdparty/__init__.py:
19138 (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
19139 * gtk/install-dependencies:
19141 2016-08-04 Alexey Proskuryakov <ap@apple.com>
19143 Optimize bot watcher's dashboard a little
19144 https://bugs.webkit.org/show_bug.cgi?id=160515
19145 rdar://problem/26096900
19147 Reviewed by Lucas Forschler.
19149 Made re-sorting after loading an iteration more efficient.
19151 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
19152 (BuildbotIteration.prototype._updateWithData):
19153 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
19154 (BuildbotQueue.prototype.updateIterationPosition):
19156 2016-08-04 Per Arne Vollan <pvollan@apple.com>
19158 [Win] Unable to reliably run tests in parallel
19159 https://bugs.webkit.org/show_bug.cgi?id=140914
19161 Reviewed by Brent Fulgham.
19163 The cygpath utility function can fail badly when running with multiple DumpRenderTree
19164 processes. We can use string replacement to convert the Cygwin path to a Windows path
19167 * Scripts/webkitpy/common/system/path.py:
19169 * Scripts/webkitpy/port/driver.py:
19170 (Driver._command_from_driver_input):
19172 2016-08-03 Aakash Jain <aakash_jain@apple.com>
19174 Document instructions for increasing process and file limits
19175 https://bugs.webkit.org/show_bug.cgi?id=160528
19176 rdar://problem/24777576
19178 Reviewed by Alexey Proskuryakov.
19180 * Scripts/webkitpy/port/ios.py:
19181 (IOSSimulatorPort.default_child_processes):
19183 2016-08-03 Anders Carlsson <andersca@apple.com>
19185 Remove the Objective-C bindings generator
19186 https://bugs.webkit.org/show_bug.cgi?id=160526
19188 Reviewed by Sam Weinig.
19190 * Scripts/run-bindings-tests:
19193 2016-08-03 Tim Horton <timothy_horton@apple.com>
19195 Revise a TestWebKitAPI comment to mention the actual underlying problem
19197 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
19198 Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
19200 2016-08-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
19202 Benchmark test content-animation timeouts always
19203 https://bugs.webkit.org/show_bug.cgi?id=160057
19205 Reviewed by Simon Fraser.
19207 * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
19208 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
19211 2016-08-02 Nan Wang <n_wang@apple.com>
19213 AX: Simulated touch events are not working on iOS
19214 https://bugs.webkit.org/show_bug.cgi?id=160395
19215 <rdar://problem/27633597>
19217 Reviewed by Chris Fleizach.
19219 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
19220 (WTR::AccessibilityUIElement::press):
19221 (WTR::AccessibilityUIElement::setSelectedChild):
19223 2016-08-02 Filip Pizlo <fpizlo@apple.com>
19225 run-javascriptcore-tests should accept multiple --extra-tests
19226 https://bugs.webkit.org/show_bug.cgi?id=160486
19228 Reviewed by Saam Barati.
19230 We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
19231 test suites. This does it by using GetOpt::Long's array support.
19233 * Scripts/run-javascriptcore-tests:
19234 (runJSCStressTests):
19236 2016-08-02 Enrica Casucci <enrica@apple.com>
19238 Allow building with content filtering disabled.
19239 https://bugs.webkit.org/show_bug.cgi?id=160454
19241 Reviewed by Simon Fraser.
19243 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
19245 2016-08-02 Brady Eidson <beidson@apple.com>
19247 Removing IndexedDB WebsiteData can fail for some users.
19248 https://bugs.webkit.org/show_bug.cgi?id=160463
19250 Reviewed by Alex Christensen.
19252 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
19254 2016-08-01 Alex Christensen <achristensen@webkit.org>
19256 _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
19257 https://bugs.webkit.org/show_bug.cgi?id=160437
19258 <rdar://problem/27578272>
19260 Reviewed by Brady Eidson.
19262 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
19263 (-[DownloadDelegate _download:didReceiveResponse:]):
19264 (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
19266 Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
19268 2016-08-01 Carlos Alberto Lopez Perez <clopez@igalia.com>
19270 [Tools] The GDB backtrace report tool don't checks the gdb return code.
19271 https://bugs.webkit.org/show_bug.cgi?id=160414
19273 Reviewed by Michael Catanzaro.
19275 * Scripts/webkitpy/port/linux_get_crash_log.py:
19276 (GDBCrashLogGenerator._wait_for_corefile):
19278 2016-08-01 Youenn Fablet <youenn@apple.com>
19280 Make wpt server generate its certificates in layout test results folder
19281 https://bugs.webkit.org/show_bug.cgi?id=160422
19283 Reviewed by Chris Dumez.
19285 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
19286 (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
19288 2016-08-01 Jonathan Bedard <jbedard@apple.com>
19290 Function Call on NULL Object
19291 https://bugs.webkit.org/show_bug.cgi?id=160325
19293 Reviewed by Darin Adler.
19295 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
19296 (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
19297 * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
19299 2016-08-01 Keith Miller <keith_miller@apple.com>
19301 We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
19302 https://bugs.webkit.org/show_bug.cgi?id=160372
19304 Rubber stamped by Geoffrey Garen.
19306 This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
19307 a new top level directory, JSTests. Having the tests in the Source directory
19308 was both confusing an inconvenient for people that just want to checkout the
19309 source code of WebKit. Since there is no other obvious place to put all the
19310 JavaScript tests a new top level directory seemed the most sensible.
19312 * Scripts/import-test262-tests:
19313 * Scripts/run-javascriptcore-tests:
19314 * Scripts/update-javascriptcore-test-res:
19316 2016-07-31 Nan Wang <n_wang@apple.com>
19318 AX: Add a check for touch event listener on iOS accessibility object
19319 https://bugs.webkit.org/show_bug.cgi?id=160388
19321 Reviewed by Chris Fleizach.
19323 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
19324 (AccessibilityUIElement::boolAttributeValue):
19325 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
19326 (WTR::AccessibilityUIElement::boolAttributeValue):
19328 2016-07-30 Manuel Rego Casasnovas <rego@igalia.com>
19330 Unreviewed: add myself to the reviewers list.
19332 * Scripts/webkitpy/common/config/contributors.json:
19334 2016-07-29 Alexey Proskuryakov <ap@apple.com>
19336 Undo r203939, and copy over a rule that clips the logos.
19338 Sierra wasn't the only logo without transparency.
19340 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
19341 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
19342 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
19344 2016-07-29 Alan Sien Wei Hshieh <hshieh@apple.com>
19346 The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
19347 https://bugs.webkit.org/show_bug.cgi?id=160377
19349 Reviewed by Brian Weinstein.
19351 Update assets to remove the white background and use a transparent background instead.
19353 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
19354 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
19356 2016-07-29 David Kilzer <ddkilzer@apple.com>
19358 Ignore most check-webkit-style checks for ANGLE project
19359 <https://webkit.org/b/160333>
19361 Reviewed by Daniel Bates.
19363 * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
19365 - No spaces at the end of lines.
19366 - No carriage returns (DOS line endings).
19368 2016-07-29 Wenson Hsieh <wenson_hsieh@apple.com>
19370 Media controls are not displayed for some autoplaying videos at certain browser dimensions
19371 https://bugs.webkit.org/show_bug.cgi?id=160360
19372 <rdar://problem/27179484>
19374 Reviewed by Myles C. Maxfield.
19376 Adds two tests verifying that videos may be considered main content as long as they
19377 are large enough and cover a majority of the mainframe's viewport.
19379 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19380 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
19381 (TestWebKitAPI::TEST):
19382 * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
19383 * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
19385 2016-07-29 Mark Lam <mark.lam@apple.com>
19387 Gardening: removed unused variable.
19391 * TestWebKitAPI/Tests/WTF/StringView.cpp:
19392 (TestWebKitAPI::TEST):
19394 2016-07-29 Wenson Hsieh <wenson_hsieh@apple.com>
19396 Add TestWebKitAPI support for interacting with media controls
19397 https://bugs.webkit.org/show_bug.cgi?id=160342
19398 <rdar://problem/27610246>
19400 Reviewed by Beth Dakin.
19402 Adds support for testing interaction with some media controls, as well as a basic test
19403 verifying that media control teardown after interaction does not result in a crash.
19405 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
19406 (-[WKWebView mouseDownAtPoint:]):
19407 (-[WKWebView performAfterLoading:]):
19408 (TestWebKitAPI::TEST):
19410 2016-07-29 Jonathan Bedard <jbedard@apple.com>
19412 Crash Log Clobbering on Unbound Crashes
19413 https://bugs.webkit.org/show_bug.cgi?id=160198
19414 <rdar://problem/27472618>
19416 Reviewed by Alexey Proskuryakov.
19418 * Scripts/webkitpy/common/system/crashlogs.py:
19419 (CrashLogs): Fix header order.
19420 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
19421 (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
19423 2016-07-29 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
19425 Update for contributors.json
19426 https://bugs.webkit.org/show_bug.cgi?id=160294
19428 * Scripts/webkitpy/common/config/contributors.json:
19430 2016-07-28 Myles C. Maxfield <mmaxfield@apple.com>
19432 Remove deprecated SPI for video inline / fullscreen controls
19433 https://bugs.webkit.org/show_bug.cgi?id=160318
19435 Reviewed by Tim Horton.
19437 * DumpRenderTree/mac/DumpRenderTree.mm:
19438 (setDefaultsToConsistentValuesForTesting): Deleted.
19439 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
19440 (RequiresUserActionForPlaybackTest::SetUp): Deleted.
19441 * WebKitTestRunner/TestController.cpp:
19442 (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
19443 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
19444 (WTR::initializeWebViewConfiguration): Deleted.
19446 2016-07-28 Daniel Bates <dabates@apple.com>
19448 [iOS] TestWebKitAPI bundle targets are not code signed
19449 https://bugs.webkit.org/show_bug.cgi?id=160328
19450 <rdar://problem/27409246>
19452 Reviewed by Andy Estes.
19454 Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
19455 CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
19456 the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
19458 * TestWebKitAPI/Configurations/Base.xcconfig:
19460 2016-07-28 Tim Horton <timothy_horton@apple.com>
19462 Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
19464 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
19465 (animatedResizeWebView):
19467 This test times out only when run in the WebKit Testing simulator environment,
19468 but not in a fresh simulator. Disabling to keep the bots green while under investigation.
19470 2016-07-28 Tim Horton <timothy_horton@apple.com>
19472 Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
19473 https://bugs.webkit.org/show_bug.cgi?id=160289
19474 <rdar://problem/27553464>
19476 Reviewed by Simon Fraser.
19478 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
19479 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19480 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
19481 (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
19482 (-[AnimatedResizeWebView _endAnimatedResize]):
19483 (animatedResizeWebView):
19485 * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
19486 Add two tests that ensure that hidden-content and animated resizes
19487 don't cause unnecessary synchronous waits. Only the hidden-content
19488 one fails before my patch, but it seemed reasonable to add both anyway.
19490 2016-07-28 David Kilzer <ddkilzer@apple.com>
19492 webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
19493 <https://webkit.org/b/83342>
19495 Reviewed by Ryosuke Niwa.
19497 * Scripts/webkitpy/common/checkout/scm/git.py:
19498 (Git.revisions_changing_file): Remove code to raise an exception
19499 when the file doesn't exist. If a file was moved or renamed,
19500 then this caused the script to terminate, which was very
19501 frustrating when you wanted a list of reviewers.
19502 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
19503 (SCMTest._shared_test_revisions_changing_file): Update test
19504 expectation to return an empty list of revisions.
19505 (test_create_patch_is_full_patch): Drive-by fix when running all
19506 webkitpy tests (including scm tests).
19507 * Scripts/webkitpy/common/checkout/scm/svn.py:
19508 (SVN.revisions_changing_file): Catch ScriptError exceptions and
19509 return an empty array of revisions if this occurs.
19511 2016-07-28 Aakash Jain <aakash_jain@apple.com>
19513 EWS error message "Error: * did not process patch" should include explanation
19514 https://bugs.webkit.org/show_bug.cgi?id=159903
19515 <rdar://problem/27410788>
19517 Reviewed by Alexey Proskuryakov.
19519 * QueueStatusServer/handlers/statusbubble.py:
19520 (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
19522 * QueueStatusServer/handlers/processingtimesjson.py:
19523 (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
19525 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
19526 (CommitQueueTask.validate): Add more information about validation failure.
19527 (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
19528 * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
19529 (EarlyWarningSystemTask.validate): Add more information about validation failure.
19530 (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
19531 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
19532 (PatchIsNotValid.__init__): Add the failure_message argument.
19533 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
19534 (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
19536 * Scripts/webkitpy/tool/commands/queues.py:
19537 (CommitQueue.process_work_item): Same.
19538 (StyleQueue.review_patch): Same.
19539 * Scripts/webkitpy/tool/commands/queues_unittest.py:
19540 (test_non_valid_patch): Updated test-cases messages to match the above changes.
19542 2016-07-27 Alexey Proskuryakov <ap@apple.com>
19544 LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
19545 https://bugs.webkit.org/show_bug.cgi?id=160262
19547 Reviewed by Daniel Bates.
19549 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
19550 (-[LTRelayController installApp]):
19552 2016-07-27 Ryan Haddad <ryanhaddad@apple.com>
19554 Disable WebCoreNSURLSessionTest API tests on ios-simulator
19555 https://bugs.webkit.org/show_bug.cgi?id=160225
19557 Reviewed by Alexey Proskuryakov.
19559 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
19561 2016-07-27 Miguel Gomez <magomez@igalia.com>
19563 [GTK] Fix some video/canvas tests that should be passing
19564 https://bugs.webkit.org/show_bug.cgi?id=160023
19566 Reviewed by Carlos Garcia Campos.
19568 Add a platform identifier to the TestRunner's page user agent when the tests are run on the
19569 EFL or GTK platforms.
19571 * WebKitTestRunner/efl/TestControllerEfl.cpp:
19572 (WTR::TestController::platformConfigureViewForTest):
19573 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
19574 (WTR::TestController::platformConfigureViewForTest):
19576 2016-07-27 Carlos Alberto Lopez Perez <clopez@igalia.com>
19578 [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
19579 https://bugs.webkit.org/show_bug.cgi?id=160247
19581 Reviewed by Michael Catanzaro.
19583 * BuildSlaveSupport/built-product-archive:
19586 (archiveBuiltProduct):
19588 2016-07-26 Alex Christensen <achristensen@webkit.org>
19590 Fix tests after r203743.
19591 https://bugs.webkit.org/show_bug.cgi?id=156947
19593 * WebKitTestRunner/TestController.cpp:
19594 (WTR::TestController::resetStateToConsistentValues):
19595 Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
19597 2016-07-26 Myles C. Maxfield <mmaxfield@apple.com>
19599 [iPhone] Playing a video on tudou.com plays only sound, no video
19600 https://bugs.webkit.org/show_bug.cgi?id=160178
19601 <rdar://problem/27535468>
19603 Reviewed by Dan Bernstein.
19605 * DumpRenderTree/mac/DumpRenderTree.mm:
19606 (setDefaultsToConsistentValuesForTesting):
19607 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
19608 (RequiresUserActionForPlaybackTest::SetUp):
19609 * WebKitTestRunner/TestController.cpp:
19610 (WTR::TestController::resetPreferencesToConsistentValues):
19611 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
19612 (WTR::initializeWebViewConfiguration):
19614 2016-07-26 Simon Fraser <simon.fraser@apple.com>
19616 Allow LOG macros to be used outside the namespace, and other logging cleanup
19617 https://bugs.webkit.org/show_bug.cgi?id=160216
19619 Reviewed by Anders Carlsson.
19621 initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
19623 * DumpRenderTree/TestRunner.cpp:
19624 * DumpRenderTree/mac/DumpRenderTree.mm:
19625 (resetWebViewToConsistentStateBeforeTesting):
19627 2016-07-26 David Kilzer <ddkilzer@apple.com>
19629 Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
19630 https://bugs.webkit.org/show_bug.cgi?id=156947
19631 <rdar://problem/23325160>
19633 Reviewed by Alex Christensen.
19635 * DumpRenderTree/TestRunner.cpp:
19636 (TestRunner::TestRunner):
19637 (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
19638 * DumpRenderTree/TestRunner.h:
19639 (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
19640 (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
19641 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
19642 (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
19643 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
19644 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
19645 (WTR::TestRunner::queueNonLoadingScript):
19646 (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
19647 * WebKitTestRunner/InjectedBundle/TestRunner.h:
19648 * WebKitTestRunner/TestController.cpp:
19649 (WTR::TestController::didReceiveAuthenticationChallenge):
19650 * WebKitTestRunner/TestController.h:
19651 (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
19652 * WebKitTestRunner/TestInvocation.cpp:
19653 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
19654 Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
19656 2016-07-26 David Kilzer <ddkilzer@apple.com>
19658 check-for-exit-time-destructors should be usable outside Xcode
19659 <https://webkit.org/b/160195>
19661 Reviewed by Darin Adler.
19663 * Scripts/check-for-exit-time-destructors: Update to parse
19664 -h|--help switch, or to take one argument to a binary to check
19665 for exit time destructors on the command-line. The clang
19666 compiler will find these at compile-time with the
19667 -Wexit-time-destructors switch, but this script will check for
19668 them after-the-fact.
19670 2016-07-26 Lucas Forschler <lforschler@apple.com>
19672 Test svn.webkit.org functionality after maintenance.
19674 2016-07-25 Brady Eidson <beidson@apple.com>
19676 Modern IDB: Make sure IndexedDB works from file:// url documents by default
19677 https://bugs.webkit.org/show_bug.cgi?id=153783
19679 Reviewed by Alex Christensen.
19681 Previously, to grant IndexedDB access to file:// urls for testing purposes,
19682 we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
19684 As of https://trac.webkit.org/changeset/203695 this is no longer required.
19686 Change the relevant API tests to make sure this continues to be no longer required.
19688 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
19689 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
19690 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
19691 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
19692 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
19693 * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
19695 2016-07-25 Wenson Hsieh <wenson_hsieh@apple.com>
19697 Media controls should not be displayed for a video until it starts playing
19698 https://bugs.webkit.org/show_bug.cgi?id=160092
19699 <rdar://problem/26986673>
19701 Reviewed by Beth Dakin.
19703 Verify that multiple videos do or don't show the media controller depending on whether videos
19704 are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
19705 passing because we were always showing media controls for large videos with audio, even if they
19706 had not played back yet. This change ensures that large videos with audio show media controls
19707 only after they begin to play back, and not by virtue of being large enough for main content.
19709 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19710 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
19711 (TestWebKitAPI::TEST):
19712 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
19713 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
19714 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
19716 2016-07-25 Wenson Hsieh <wenson_hsieh@apple.com>
19718 Media controls on apple.com don't disappear when movie finishes playing
19719 https://bugs.webkit.org/show_bug.cgi?id=160068
19720 <rdar://problem/26668526>
19722 Reviewed by Darin Adler.
19724 Adds new API tests. Please see WebCore ChangeLog for more details.
19726 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19727 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
19728 (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
19729 (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
19730 (TestWebKitAPI::TEST):
19731 (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
19732 (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
19733 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
19734 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
19735 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
19737 2016-07-25 Philippe Normand <pnormand@igalia.com>
19739 Unreviewed, fix test-webkitpy after r203674.
19741 * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
19742 (GDBCrashLogGeneratorTest.test_generate_crash_log):
19744 2016-07-24 Philippe Normand <pnormand@igalia.com>
19746 Unreviewed, forgot to commit this file in r203674.
19748 * Scripts/process-linux-coredump: Added.
19751 2016-07-25 Philippe Normand <pnormand@igalia.com>
19753 Improve GDB backtrace generation for GTK/EFL
19754 https://bugs.webkit.org/show_bug.cgi?id=128928
19756 Reviewed by Carlos Garcia Campos.
19758 The PID of the crashed process is now correctly supplied to the
19759 crash log reporter. The kernel core_pattern needs to be updated
19760 after this change to something like:
19762 echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
19764 * Scripts/process-linux-coredump: Added.
19765 (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
19766 * Scripts/webkitpy/port/efl.py:
19767 (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
19768 * Scripts/webkitpy/port/gtk.py:
19769 (GtkPort._get_crash_log): Ditto.
19770 * Scripts/webkitpy/port/linux_get_crash_log.py:
19771 (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
19772 (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
19773 (GDBCrashLogGenerator): Deleted.
19774 * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
19775 (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
19776 * WebKitTestRunner/TestController.cpp:
19777 (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
19778 (WTR::TestController::databaseProcessDidCrash): Ditto.
19779 (WTR::TestController::processDidCrash): Ditto.
19781 2016-07-23 Youenn Fablet <youenn@apple.com>
19783 WPT stash server should be kept running when launching wpt server
19784 https://bugs.webkit.org/show_bug.cgi?id=160052
19786 Reviewed by Sam Weinig.
19788 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
19789 (main): waiting to read stdin while stash server is started.
19791 2016-07-22 Wenson Hsieh <wenson_hsieh@apple.com>
19793 Media controls should be displayed for media in media documents
19794 https://bugs.webkit.org/show_bug.cgi?id=160104
19795 <rdar://problem/27438936>
19797 Reviewed by Myles C. Maxfield.
19799 Verifies that even a small video with audio in a media document gets media controls.
19801 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
19802 (TestWebKitAPI::TEST):
19804 2016-07-22 Michael Saboff <msaboff@apple.com>
19806 REGRESSION(203616): no FTL testing was inadvertently removed
19807 https://bugs.webkit.org/show_bug.cgi?id=160100
19809 Rubber-stamped by Filip Pizlo.
19811 Added runNoFTL back into the set of tests we run on FTL enabled platforms.
19812 Renamed runLayoutTestNoFTL to runLayoutTestDefault. Restructured the test
19813 logic for the runLayout and runNoisy variants to match the run test logic,
19814 that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
19817 * Scripts/run-jsc-stress-tests:
19819 2016-07-22 Brady Eidson <beidson@apple.com>
19821 Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
19822 https://bugs.webkit.org/show_bug.cgi?id=160089
19824 Reviewed by Darin Adler.
19826 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19827 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
19828 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
19830 2016-07-22 Konstantin Tokarev <annulen@yandex.ru>
19832 [GTK] Improved exclusion patterns in make-dist.py manifest.
19833 https://bugs.webkit.org/show_bug.cgi?id=160094
19835 Reviewed by Michael Catanzaro.
19837 * gtk/manifest.txt.in:
19838 Exclude Platform*.cmake files for more ports.
19839 Removed obsolete .gyp and .pro.user patterns.
19840 Exclude 'Configurations' and 'spi' directories.
19841 Exclude CMakeLists.txt.user (Qt Creator IDE).
19843 2016-07-22 Michael Saboff <msaboff@apple.com>
19845 Don't run FTL related JSC stress tests on non-FTL platforms
19846 https://bugs.webkit.org/show_bug.cgi?id=160033
19848 Reviewed by Mark Lam.
19850 Added check for running tests on platforms that don't enable FTL to not run FTL tests.
19851 Refactored several of the runXXX test methods to always runXXXDefault and made those
19852 runXXXDefault to pass FTL_OPTIONS. For platforms that don't enable the FTL, FTL_OPTIONS
19853 doesn't cause a problem.
19855 * Scripts/run-jsc-stress-tests:
19857 2016-07-22 Per Arne Vollan <pvollan@apple.com>
19859 IWebView::mainFrame crashes if called after IWebView::close
19860 https://bugs.webkit.org/show_bug.cgi?id=32868
19862 Reviewed by Brent Fulgham.
19864 * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
19865 (TestWebKitAPI::TEST_F): Added test.
19867 2016-07-22 Carlos Garcia Campos <cgarcia@igalia.com>
19869 [GTK] Enable threaded compositor by default
19870 https://bugs.webkit.org/show_bug.cgi?id=160079
19872 Reviewed by Žan Doberšek.
19874 * Scripts/webkitperl/FeatureList.pm:
19876 2016-07-22 Youenn Fablet <youenn@apple.com>
19878 run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
19879 https://bugs.webkit.org/show_bug.cgi?id=159921
19881 Reviewed by Brian Burg.
19883 Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
19885 * Scripts/webkitpy/codegen/main.py:
19886 (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
19887 (BuiltinsGeneratorTests):
19888 (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
19889 (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
19890 (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
19891 (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
19893 2016-07-21 Dan Bernstein <mitz@apple.com>
19895 [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
19896 https://bugs.webkit.org/show_bug.cgi?id=160072
19898 Reviewed by Andy Estes.
19900 * Scripts/webkitdirs.pm:
19901 (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
19902 for old Xcode versions.
19903 (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
19904 to readXcodeUserDefault.
19905 (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
19907 (determineDebugger): Ditto.
19908 (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
19910 (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
19912 (execMacWebKitAppForDebugging): Removed support for GDB.
19914 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
19916 Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
19917 https://bugs.webkit.org/show_bug.cgi?id=160066
19919 Reviewed by Dean Jackson.
19921 * DumpRenderTree/mac/DumpRenderTree.mm:
19922 (setDefaultsToConsistentValuesForTesting): Deleted.
19923 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
19924 (RequiresUserActionForPlaybackTest::SetUp): Deleted.
19925 * WebKitTestRunner/TestController.cpp:
19926 (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
19927 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
19928 (WTR::initializeWebViewConfiguration): Deleted.
19930 2016-07-21 Chelsea Pugh <cpugh@apple.com>
19932 [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
19933 https://bugs.webkit.org/show_bug.cgi?id=159980
19934 rdar://problem/27450825
19936 Reviewed by Dan Bernstein.
19938 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19939 * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
19940 (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
19941 when our delegate has hit -dealloc.
19942 (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
19943 and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
19944 will not be messaged.
19946 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
19948 Follow-up patch to r203520
19949 https://bugs.webkit.org/show_bug.cgi?id=159967
19950 <rdar://problem/26964090>
19954 * DumpRenderTree/mac/DumpRenderTree.mm:
19955 (setDefaultsToConsistentValuesForTesting):
19956 * WebKitTestRunner/TestController.cpp:
19957 (WTR::TestController::resetPreferencesToConsistentValues):
19959 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
19961 [iPhone] Playing a video on tudou.com plays only sound, no video
19962 https://bugs.webkit.org/show_bug.cgi?id=159967
19963 <rdar://problem/26964090>
19965 Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
19967 Migrate tests to use new SPI.
19969 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
19970 (RequiresUserActionForPlaybackTest::SetUp):
19971 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
19972 (WTR::initializeWebViewConfiguration):
19974 2016-07-21 Csaba Osztrogonác <ossy@webkit.org>
19976 Clarify testing mode names in run-jsc-stress-tests
19977 https://bugs.webkit.org/show_bug.cgi?id=160021
19979 Reviewed by Mark Lam.
19981 Default should mean really default, not default with disabled FTL, renamed
19982 - runMozillaTestDefault to runMozillaTestNoFTL
19983 - runMozillaTestDefaultFTL to runMozillaTestDefault
19984 - runDefault to runNoFTL
19985 - runDefaultFTL to runDefault
19986 - runLayoutTestDefault to runLayoutTestNoFTL
19987 - runLayoutTestDefaultFTL to runLayoutTestDefault
19988 - runNoisyTestDefault to runNoisyTestNoFTL
19989 - runNoisyTestDefaultFTL to runNoisyTestDefault
19991 * Scripts/run-jsc-stress-tests:
19993 2016-07-21 Yongjun Zhang <yongjun_zhang@apple.com>
19995 WebBackForwardList's currentIndex could get out of bounds when filtering items.
19996 https://bugs.webkit.org/show_bug.cgi?id=159986
19998 Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
20001 Reviewed by Dan Bernstein.
20003 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20004 * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
20005 (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
20008 2016-07-21 Carlos Garcia Campos <cgarcia@igalia.com>
20010 [GTK] Web view background colors don't work in accelerated compositing mode
20011 https://bugs.webkit.org/show_bug.cgi?id=159455
20013 Reviewed by Michael Catanzaro.
20015 Set always RGBA visual to the view widget when setting a background color.
20017 * MiniBrowser/gtk/BrowserWindow.c:
20018 (browser_window_set_background_color):
20020 2016-07-20 Youenn Fablet <youenn@apple.com>
20022 Bots should run built-ins generator tests
20023 https://bugs.webkit.org/show_bug.cgi?id=159971
20025 Reviewed by Alexey Proskuryakov.
20027 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
20028 (RunBuiltinsTests): New step to run built-in generator tests.
20029 (TestFactory.__init__): Adding an additional step for bultin generator tests.
20030 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
20031 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
20033 2016-07-20 Aakash Jain <aakash_jain@apple.com>
20035 Revert temporary fix r203417
20036 https://bugs.webkit.org/show_bug.cgi?id=160001
20038 Reviewed by Alexey Proskuryakov.
20040 * EWSTools/start-queue-mac.sh: Revert the temporary fix.
20042 2016-07-20 Aakash Jain <aakash_jain@apple.com>
20044 REGRESSION(r148588): ews classes might get garbage collected
20045 https://bugs.webkit.org/show_bug.cgi?id=159990
20047 Reviewed by Ryosuke Niwa.
20049 * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
20050 in a variable so that they do not get garbage collected.
20052 2016-07-20 Jeremy Jones <jeremyj@apple.com>
20054 Add API test for layout constraints after exit fullscreen
20055 https://bugs.webkit.org/show_bug.cgi?id=159900
20057 Reviewed by Jon Lee.
20059 Added Fullscreen.LaytoutConstraints API test.
20060 Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
20062 This test compares layout constraints on the web view before and after fullscreen to make sure
20063 they are preserved.
20065 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
20066 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
20067 (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
20068 (TestWebKitAPI::TEST):
20070 2016-07-20 Ryan Haddad <ryanhaddad@apple.com>
20072 Disable two failing API tests.
20074 Unreviewed test gardening.
20076 * TestWebKitAPI/Tests/mac/CandidateTests.mm:
20077 (TestWebKitAPI::TEST):
20079 2016-07-20 Wenson Hsieh <wenson_hsieh@apple.com>
20081 Unreviewed iOS build fix.
20083 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
20085 2016-07-20 Wenson Hsieh <wenson_hsieh@apple.com>
20087 Media controls don't appear when pausing a small autoplaying video
20088 https://bugs.webkit.org/show_bug.cgi?id=159972
20089 <rdar://problem/27180657>
20091 Reviewed by Beth Dakin.
20093 Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
20094 for simulating basic user interaction in VideoControlsManager.
20096 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20097 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
20098 (-[WKWebView mouseDownAtPoint:]):
20099 (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
20100 (-[OnLoadMessageHandler initWithWKWebView:handler:]):
20101 (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
20102 (TestWebKitAPI::TEST):
20103 * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
20105 2016-07-20 Per Arne Vollan <pvollan@apple.com>
20107 [Win] MathML fonts are not found.
20108 https://bugs.webkit.org/show_bug.cgi?id=159920
20110 Reviewed by Alex Christensen.
20112 When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
20113 for a specific registry key value.
20115 * Scripts/webkitdirs.pm:
20118 2016-07-20 Joseph Pecoraro <pecoraro@apple.com>
20120 Improve prepare-ChangeLog for @media blocks
20121 https://bugs.webkit.org/show_bug.cgi?id=159907
20123 Reviewed by Timothy Hatcher.
20125 * Scripts/prepare-ChangeLog:
20126 (get_selector_line_ranges_for_css):
20127 Get a range for @media blocks just like a selector.
20128 Start Line = line with '{'
20129 End line = line with '}'
20130 Name = "@media ..."
20132 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
20133 Improved error messages for unbalanced portions.
20135 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
20136 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
20137 (.media-query::before):
20138 (@media only screen and (max-width: 980px)):
20140 (@media (-webkit-min-device-pixel-ratio: 2)):
20144 (.media-query::after):
20146 2016-07-20 Csaba Osztrogonác <ossy@webkit.org>
20148 Fix expectedFailErrorHandler in run-jsc-stress-tests
20149 https://bugs.webkit.org/show_bug.cgi?id=159811
20151 Reviewed by Yusuke Suzuki.
20153 * Scripts/run-jsc-stress-tests:
20155 2016-07-20 Csaba Osztrogonác <ossy@webkit.org>
20157 Unreviewed Mac cmake buildfix after r203426. Just for fun.
20159 * TestWebKitAPI/PlatformMac.cmake:
20161 2016-07-19 Filip Pizlo <fpizlo@apple.com>
20163 The default testing mode should not involve disabling the FTL JIT
20164 https://bugs.webkit.org/show_bug.cgi?id=159929
20166 Rubber stamped by Mark Lam and Saam Barati.
20168 It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
20169 Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
20170 FTL was not the default. You had to enable it with an option.
20172 For some reason we have kept this arrangement even though the FTL JIT is now the default on
20173 all of the major ports. This has become a serious pain. For example, it's useful to be able
20174 to say that a test should only run in the default config that is representative of what a
20175 normal user would see if they ran JSC. Clearly, this would be a config that does not
20176 explicitly disable the FTL JIT on the command line. However, if you try to specify this then
20177 your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
20179 So, this change gets rid of all of this logic. I think it's better to get rid of it then to
20180 try to fix it, because:
20182 - I don't know what the fix would look like. Presumably it would ensure that ports that don't
20183 have the FTL enabled never run any tests that explicitly disable the FTL, since that
20184 doesn't do anything. The code is not really structured to allow this.
20186 - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
20187 disabled in testing. On the other hand there are already build bots that do FTL tests
20188 despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
20189 preserving this broken feature, we should create something that (a) acknowledges the fact
20190 that the FTL is the default on those platforms that support it and (b) avoids running
20191 no-ftl tests on precisely those platforms that don't have FTL.
20193 - To the extent that some bots benefited from disabling FTL tests, they were doing it by
20194 relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
20195 default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
20196 pretending that the FTL JIT is not the default just because some bots used that as an
20199 This change allows me to speed up some debug tests and paint some bots green.
20201 * Scripts/run-javascriptcore-tests:
20202 (runJSCStressTests):
20203 * Scripts/run-jsc-stress-tests:
20205 2016-07-19 Alex Christensen <achristensen@webkit.org>
20207 Fix API test after r203426.
20208 https://bugs.webkit.org/show_bug.cgi?id=159949
20210 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
20212 If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
20213 This is no problem. We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
20215 2016-07-19 Andy Estes <aestes@apple.com>
20217 Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
20218 https://bugs.webkit.org/show_bug.cgi?id=159956
20220 Reviewed by Dan Bernstein.
20222 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
20223 (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
20224 Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
20225 * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
20227 2016-07-19 Alex Christensen <achristensen@webkit.org>
20229 Add regression test for r203392
20230 https://bugs.webkit.org/show_bug.cgi?id=159949
20232 Reviewed by Brady Eidson.
20234 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
20236 (swizzledBundleIdentifierWebBookmarksD):
20237 (defaultApplicationCacheDirectory):
20239 (swizzledBundleIdentifierMobileSafari): Deleted.
20240 This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
20241 I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
20242 problems with the static bools that are set once in RuntimeApplicationChecks.mm.
20244 2016-07-19 Alex Christensen <achristensen@webkit.org>
20246 Add regression test for r203392
20247 https://bugs.webkit.org/show_bug.cgi?id=159949
20249 Reviewed by Brady Eidson.
20251 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20252 * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
20253 * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
20254 * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
20255 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
20258 (swizzledBundleIdentifierMobileSafari):
20259 (swizzledBundleIdentifierWebBookmarksD):
20260 (defaultApplicationCacheDirectory):
20261 * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
20262 * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
20263 * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
20264 * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
20266 2016-07-19 Keith Miller <keith_miller@apple.com>
20268 Test262 should have a file with the revision and url
20269 https://bugs.webkit.org/show_bug.cgi?id=159937
20271 Reviewed by Mark Lam.
20273 The import script should update the information from
20274 the path to the test262 repository it gets.
20276 * Scripts/import-test262-tests:
20278 2016-07-19 Alexey Proskuryakov <ap@apple.com>
20280 Temporary workaround for iOS EWS failing after the fix for bug 159539.
20281 To be deleted once the root cause is found and addressed.
20283 * EWSTools/start-queue-mac.sh:
20285 2016-07-19 Frederic Wang <fwang@igalia.com>
20287 [win] Fixup the register name for STIX Math and Latin Modern Math
20289 Unreviewed follow-up of r203406
20291 * Scripts/webkitdirs.pm:
20292 (checkInstalledTools):
20294 2016-07-19 Frederic Wang <fwang@igalia.com>
20296 [win] Update the list of MathML fonts
20297 https://bugs.webkit.org/show_bug.cgi?id=156838
20299 The set of recommended math fonts is now described at
20300 https://trac.webkit.org/wiki/MathML/Fonts
20301 We update the Perl script to use the latest list of fonts.
20303 Reviewed by Brent Fulgham.
20305 * Scripts/webkitdirs.pm:
20306 (checkInstalledTools):
20308 2016-07-19 Per Arne Vollan <pvollan@apple.com>
20310 [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
20311 https://bugs.webkit.org/show_bug.cgi?id=159342
20313 Reviewed by Darin Adler.
20315 Implement required functions in event sender.
20317 * DumpRenderTree/PlatformWin.cmake:
20318 * DumpRenderTree/win/EventSender.cpp:
20319 (monitorWheelEvents): Added.
20320 (callAfterScrollingCompletes): Added.
20322 2016-07-19 Youenn Fablet <youenn@apple.com>
20324 Add new aliases to http test server
20325 https://bugs.webkit.org/show_bug.cgi?id=159878
20327 Reviewed by Darin Adler.
20329 Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
20330 Adding explicitly these links to perl script.
20331 Extracting default alias in an aliases.json file.
20332 Reading that file from python scripts to initialize aliases from that file.
20334 Python script changes covered by unit tests and changed layout test.
20336 * Scripts/webkitperl/httpd.pm:
20337 (getDefaultConfigForTestDirectory): Adding 3 new aliases
20338 * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
20339 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
20340 (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
20341 Adding -c directives for each alias.
20342 * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
20343 (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
20344 * Scripts/webkitpy/layout_tests/servers/http_server.py:
20345 (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
20346 Adding alias directive for each alias.
20347 (Lighttpd._prepare_config):
20348 * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
20349 (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
20350 (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
20351 layout tests directory.
20352 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
20353 (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
20354 (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
20356 2016-07-18 Aakash Jain <aakash_jain@apple.com>
20358 EWS console logs doesn't go to log file
20359 https://bugs.webkit.org/show_bug.cgi?id=159539
20360 <rdar://problem/24464570>
20362 Reviewed by David Kilzer.
20364 * Scripts/webkitpy/common/system/logutils.py:
20365 (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
20366 (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
20367 to filesystem. It also supports passing MockFilesystem.
20368 (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
20369 (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
20370 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
20371 (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
20373 * Scripts/webkitpy/tool/commands/queues.py:
20374 (AbstractQueue.begin_work_queue): Configure the logger to log to file.
20375 (AbstractQueue._log_directory): Using filesystem object instead of os.
20376 (AbstractQueue.queue_log_path): Same.
20377 (AbstractQueue.__init__): Passed host parameter.
20378 (PatchProcessingQueue.__init__): Same.
20379 (CommitQueue.__init__): Same.
20380 (AbstractReviewQueue.__init__): Same.
20381 (StyleQueue.__init__): Same.
20382 * Scripts/webkitpy/tool/commands/queues_unittest.py:
20383 (TestCommitQueue): Passed MockHost() as host.
20384 (TestCommitQueue.__init__): Same.
20385 (TestQueue.__init__): Same.
20386 (TestReviewQueue.__init__): Same.
20387 (TestFeederQueue.__init__): Same.
20388 (AbstractPatchQueueTest.test_next_patch): Same.
20389 (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
20390 (test_commit_queue_failure): Same.
20391 (MockCommitQueueTask.results_from_patch_test_run): Same.
20392 (test_rollout_lands): Same.
20393 (test_non_valid_patch): Same.
20394 (test_auto_retry): Same.
20395 (test_style_queue_with_watch_list_exception): Same.
20397 2016-07-02 Filip Pizlo <fpizlo@apple.com>
20399 WTF::Lock should be fair eventually
20400 https://bugs.webkit.org/show_bug.cgi?id=159384
20402 Reviewed by Geoffrey Garen.
20404 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
20406 2016-07-17 Sam Weinig <sam@webkit.org>
20408 [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
20409 <rdar://problem/26554137>
20410 https://bugs.webkit.org/show_bug.cgi?id=159856
20412 Reviewed by Dan Bernstein.
20414 * MiniBrowser/mac/WK2BrowserWindowController.m:
20415 (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
20416 Add basic window.open implementation.
20418 (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
20419 Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
20420 to open a single non-web URL, all others are dropped.
20422 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20423 * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
20424 * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
20425 Add API for the new SPI.
20427 2016-07-17 Yusuke Suzuki <utatane.tea@gmail.com>
20429 [JSC] Enable test262 module tests
20430 https://bugs.webkit.org/show_bug.cgi?id=159854
20432 Reviewed by Saam Barati.
20434 Use --module-file instead.
20436 * Scripts/run-jsc-stress-tests:
20438 2016-07-16 Chris Dumez <cdumez@apple.com>
20440 Unreviewed, rolling out r203318.
20442 Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
20445 Reverted changeset:
20447 "[JSC] Change some parameters based on a random search"
20448 https://bugs.webkit.org/show_bug.cgi?id=158514
20449 http://trac.webkit.org/changeset/203318
20451 2016-07-16 Chris Dumez <cdumez@apple.com>
20453 Add move constructor / assignment operator to ListHashSet
20454 https://bugs.webkit.org/show_bug.cgi?id=159837
20456 Reviewed by Darin Adler.
20460 * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
20461 (TestWebKitAPI::TEST):
20463 2016-07-15 Benjamin Poulain <bpoulain@apple.com>
20465 [JSC] Change some parameters based on a random search
20466 https://bugs.webkit.org/show_bug.cgi?id=158514
20468 Reviewed by Saam Barati.
20470 * Scripts/run-jsc-stress-tests:
20472 2016-07-15 Jon Davis <jond@apple.com>
20474 Changed the start page URL for WebKit Nightly builds.
20475 https://bugs.webkit.org/show_bug.cgi?id=159816
20477 Reviewed by Timothy Hatcher.
20479 * WebKitLauncher/start.html:
20481 2016-07-15 Per Arne Vollan <pvollan@apple.com>
20483 Uninitialized variable in DIBPixelData can cause a dangerous memory write
20484 https://bugs.webkit.org/show_bug.cgi?id=159414
20486 Reviewed by Brent Fulgham.
20488 Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
20489 when the HDC parameter is invalid.
20491 * TestWebKitAPI/PlatformWin.cmake:
20492 * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
20493 (TestWebKitAPI::TEST):
20495 2016-07-15 Carlos Garcia Campos <cgarcia@igalia.com>
20497 [GTK] Add basic tabs support to MiniBrowser
20498 https://bugs.webkit.org/show_bug.cgi?id=159803
20500 Reviewed by Sergio Villar Senin.
20502 It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
20503 like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
20505 * MiniBrowser/gtk/BrowserTab.c: Added.
20507 (isLoadingChanged):
20509 (removeChildIfInfoBar):
20511 (createInfoBarQuestionMessage):
20512 (tlsErrorsDialogResponse):
20513 (loadFailedWithTLSerrors):
20514 (permissionRequestDialogResponse):
20515 (decidePermissionRequest):
20516 (colorChooserRGBAChanged):
20517 (popoverColorClosed):
20518 (colorChooserRequestFinished):
20519 (runColorChooserCallback):
20520 (inspectorOpenedInWindow):
20522 (browserTabSetProperty):
20523 (browserTabFinalize):
20524 (browser_tab_init):
20525 (browserTabConstructed):
20526 (browser_tab_class_init):
20529 (browser_tab_get_web_view):
20530 (browser_tab_load_uri):
20531 (browser_tab_get_title_widget):
20532 (browser_tab_set_status_text):
20533 (browser_tab_toggle_inspector):
20534 (browser_tab_start_search):
20535 (browser_tab_stop_search):
20536 (browser_tab_add_accelerators):
20537 (fullScreenMessageTimeoutCallback):
20538 (browser_tab_enter_fullscreen):
20539 (browser_tab_leave_fullscreen):
20540 * MiniBrowser/gtk/BrowserTab.h: Added.
20541 * MiniBrowser/gtk/BrowserWindow.c:
20543 (browserWindowSetStatusText):
20544 (reloadOrStopCallback):
20546 (goForwardCallback):
20547 (settingsCallback):
20548 (webViewURIChanged):
20549 (browserWindowHistoryItemActivated):
20550 (browserWindowUpdateNavigationActions):
20552 (webViewEnterFullScreen):
20553 (webViewLeaveFullScreen):
20554 (webViewDecidePolicy):
20555 (browserWindowCanZoomIn):
20556 (browserWindowCanZoomOut):
20557 (browserWindowZoomIn):
20558 (browserWindowZoomOut):
20559 (scrollEventCallback):
20561 (webViewIsLoadingChanged):
20562 (defaultZoomCallback):
20565 (toggleWebInspector):
20567 (reloadPageIgnoringCache):
20570 (editingCommandCallback):
20571 (insertImageCommandCallback):
20572 (insertLinkCommandCallback):
20573 (browserWindowSetupEditorToolbar):
20574 (browserWindowSwitchTab):
20575 (browserWindowTabAddedOrRemoved):
20576 (browser_window_init):
20577 (browserWindowConstructed):
20578 (browserWindowSaveSession):
20579 (browserWindowDeleteEvent):
20580 (browser_window_new):
20581 (browser_window_append_view):
20582 (browser_window_load_uri):
20583 (browser_window_load_session):
20584 (browser_window_set_background_color):
20585 (resetStatusText): Deleted.
20586 (activateUriEntryCallback): Deleted.
20587 (webViewTitleChanged): Deleted.
20588 (resetEntryProgress): Deleted.
20589 (browserWindowCreateBackForwardMenu): Deleted.
20590 (webViewReadyToShow): Deleted.
20591 (webViewLoadFailed): Deleted.
20592 (webViewMouseTargetChanged): Deleted.
20593 (browserWindowUpdateZoomActions): Deleted.
20594 (webViewZoomLevelChanged): Deleted.
20595 (updateUriEntryIcon): Deleted.
20596 (zoomInCallback): Deleted.
20597 (zoomOutCallback): Deleted.
20598 (toggleFullScreen): Deleted.
20599 (browserWindowEditingCommandToggleButtonSetActive): Deleted.
20600 (browserWindowFinalize): Deleted.
20601 (browser_window_class_init): Deleted.
20602 * MiniBrowser/gtk/BrowserWindow.h:
20603 * MiniBrowser/gtk/CMakeLists.txt:
20604 * MiniBrowser/gtk/main.c:
20605 (createBrowserTab):
20606 (aboutURISchemeRequestCallback):
20608 (parseBackgroundColor): Deleted.
20610 2016-07-14 Alex Christensen <achristensen@webkit.org>
20612 Allow RefPtrs of const RefCounted types
20613 https://bugs.webkit.org/show_bug.cgi?id=158269
20615 Reviewed by Anders Carlsson.
20617 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
20618 (TestWebKitAPI::TEST):
20619 (TestWebKitAPI::ConstRefCounted::create):
20620 (TestWebKitAPI::returnConstRefCountedRef):
20621 (TestWebKitAPI::returnRefCountedRef):
20623 2016-07-13 Carlos Garcia Campos <cgarcia@igalia.com>
20625 Test WTF.StringViewIterators is crashing since r203119
20626 https://bugs.webkit.org/show_bug.cgi?id=159710
20628 Reviewed by Darin Adler.
20630 There are two problems in the test case added in r203119. First is that it's testing
20631 StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
20632 StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
20633 const reference to the string view member of the deleted CodePoints object.
20635 * TestWebKitAPI/Tests/WTF/StringView.cpp:
20636 (TestWebKitAPI::TEST):
20638 2016-07-13 Daniel Bates <dabates@apple.com>
20640 [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
20641 https://bugs.webkit.org/show_bug.cgi?id=159738
20642 <rdar://problem/27304649>
20644 Reviewed by Dan Bernstein.
20646 The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
20647 code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
20648 of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
20649 PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
20651 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
20652 * WebKitTestRunner/ios/TestControllerIOS.mm:
20653 (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
20654 bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
20656 2016-07-13 Beth Dakin <bdakin@apple.com>
20658 Attempted build fix.
20660 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20662 2016-07-12 Ryosuke Niwa <rniwa@webkit.org>
20664 REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
20665 https://bugs.webkit.org/show_bug.cgi?id=159686
20667 Reviewed by Chris Dumez.
20669 Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
20671 * WebKitTestRunner/TestController.cpp:
20672 (WTR::runOpenPanel):
20673 (WTR::TestController::createOtherPage):
20674 (WTR::TestController::createWebViewWithOptions):
20676 2016-07-13 Beth Dakin <bdakin@apple.com>
20678 Add more candidate tests
20679 https://bugs.webkit.org/show_bug.cgi?id=159730
20681 Reviewed by Tim Horton.
20683 This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds
20684 two new tests to that file.
20685 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20686 * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
20687 * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
20688 (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
20689 (TestWebKitAPI::TEST):
20690 * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
20692 2016-07-13 Joanmarie Diggs <jdiggs@igalia.com>
20694 AX: [ATK] spinbutton-crash.html fails
20695 https://bugs.webkit.org/show_bug.cgi?id=159723
20697 Reviewed by Chris Fleizach.
20699 Implement support for AXDecrementButton and AXIncrementButton in
20700 ATK's AccessibilityUIElement::uiElementAttributeValue().
20702 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
20703 (WTR::AccessibilityUIElement::uiElementAttributeValue):
20705 2016-07-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
20707 [EFL] [GTK] Enable back crypto subtle on development builds.
20708 https://bugs.webkit.org/show_bug.cgi?id=159260
20710 Reviewed by Carlos Garcia Campos.
20712 * Scripts/webkitperl/FeatureList.pm:
20714 2016-07-12 Mark Lam <mark.lam@apple.com>
20716 We should use different stack limits for stack checks from JS and host code.
20717 https://bugs.webkit.org/show_bug.cgi?id=159442
20718 <rdar://problem/26889188>
20720 Reviewed by Geoffrey Garen.
20722 In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
20723 run with to keep stack overflow tests sane. Turns out, we also need to teach the
20724 LayoutTestRelay to pass env vars over to the iOS simulator. This is needed in
20725 order to keep the js/regress-139548.html test happy with this patch.
20727 Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
20728 JSC_maxPerThreadStackUsage option. Otherwise, it will pass a float value.
20730 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
20731 (-[LTRelayController _environmentVariables]):
20732 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
20735 2016-07-12 Filip Pizlo <fpizlo@apple.com>
20737 platformUserPreferredLanguages on Mac should not try to put the region into the language
20738 https://bugs.webkit.org/show_bug.cgi?id=159693
20740 Rubber stamped by Alexey Proskuryakov.
20742 Revert the test change in r200105.
20744 * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
20745 (TestWebKitAPI::languageForSystemLanguage):
20747 2016-07-12 Chris Dumez <cdumez@apple.com>
20749 [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
20750 https://bugs.webkit.org/show_bug.cgi?id=159663
20751 <rdar://problem/18995873>
20753 Reviewed by Benjamin Poulain.
20755 Add API test coverage.
20757 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20758 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
20759 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
20760 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
20761 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
20762 (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
20765 2016-07-12 Myles C. Maxfield <mmaxfield@apple.com>
20767 Relax ordering requirements on StringView::CodePoints iterator
20768 https://bugs.webkit.org/show_bug.cgi?id=159609
20770 Reviewed by Darin Adler.
20772 * TestWebKitAPI/Tests/WTF/StringView.cpp:
20773 (TestWebKitAPI::TEST):
20775 2016-07-12 Youenn Fablet <youenn@apple.com>
20777 Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
20778 https://bugs.webkit.org/show_bug.cgi?id=159564
20780 Reviewed by Brian Burg.
20782 * Scripts/webkitpy/codegen/main.py:
20783 (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
20785 2016-07-12 Gyuyoung Kim <gyuyoung.kim@webkit.org>
20787 Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
20788 https://bugs.webkit.org/show_bug.cgi?id=159671
20790 Reviewed by Csaba Osztrogonác.
20792 ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
20793 https://bugs.webkit.org/show_bug.cgi?id=89235
20795 So this guard can be removed in build scripts.
20797 * Scripts/webkitperl/FeatureList.pm:
20798 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
20800 2016-07-11 Jason Marcell <jmarcell@apple.com>
20802 SVN.create_patch should find svn-create-patch relative to the WebKit root.
20803 https://bugs.webkit.org/show_bug.cgi?id=159652
20805 Reviewed by Daniel Bates.
20807 * Scripts/webkitpy/common/checkout/scm/svn.py:
20808 (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
20810 2016-07-11 Myles C. Maxfield <mmaxfield@apple.com>
20812 Implement grapheme cluster iterator on StringView
20813 https://bugs.webkit.org/show_bug.cgi?id=159598
20815 Reviewed by Anders Carlsson.
20817 This is in preparation for honoring the second argument to FontFaceSet.load().
20819 * TestWebKitAPI/Tests/WTF/StringView.cpp:
20820 (TestWebKitAPI::compareLoopIterations):
20821 (TestWebKitAPI::TEST):
20823 2016-07-11 Nan Wang <n_wang@apple.com>
20825 AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
20826 https://bugs.webkit.org/show_bug.cgi?id=158364
20828 Reviewed by Anders Carlsson.
20830 Added a function in TestRunner so that we can toggle the ignoring viewport
20831 scale limits setting. Also added a test option for that in order to change the
20832 configuration of the webview in test.
20834 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
20835 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
20836 (WTR::TestRunner::setNavigationGesturesEnabled):
20837 (WTR::TestRunner::setIgnoresViewportScaleLimits):
20838 (WTR::nextUIScriptCallbackID):
20839 * WebKitTestRunner/InjectedBundle/TestRunner.h:
20840 (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
20841 * WebKitTestRunner/TestController.cpp:
20842 (WTR::TestController::resetStateToConsistentValues):
20843 (WTR::updateTestOptionsFromTestHeader):
20844 (WTR::TestController::setNavigationGesturesEnabled):
20845 (WTR::TestController::setIgnoresViewportScaleLimits):
20846 (WTR::TestController::platformWillRunTest):
20847 * WebKitTestRunner/TestController.h:
20848 (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
20849 * WebKitTestRunner/TestInvocation.cpp:
20850 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
20851 * WebKitTestRunner/TestOptions.h:
20852 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
20853 (WTR::TestController::platformCreateWebView):
20855 2016-07-11 Konstantin Tokarev <annulen@yandex.ru>
20857 [GTK] install-dependencies should not install packages built by jhbuild.
20858 https://bugs.webkit.org/show_bug.cgi?id=159628
20860 Reviewed by Michael Catanzaro.
20862 * gtk/install-dependencies:
20863 Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
20865 2016-07-11 Olivier Blin <olivier.blin@softathome.com>
20867 System proxy settings not used when building deps with jhbuild
20868 https://bugs.webkit.org/show_bug.cgi?id=159567
20870 Reviewed by Michael Catanzaro.
20872 This adds the gsettings-desktop-schemas-devel build dep to enable
20873 the libgiognomeproxy.so gio module in glib-networking, which uses
20874 GSettings on org.gnome.system.proxy.
20875 This is needed to query system proxy settings for Gnome desktops.
20877 dconf can be manually added to jhbuild to build the
20878 libdconfsettings.so gio module for GSettings, so that
20879 libgiognomeproxy.so can access system settings.
20880 https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
20882 As an alternative to dconf settings, this commit also adds the
20883 libproxy-devel build dep to enable the libgiolibproxy.so module in
20884 glib-networking (suggested by Fujii Hironori).
20886 It is useful to read proxy settings from environment variables.
20887 From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
20888 environment variable to force using the envvar module in libproxy.
20890 * gtk/install-dependencies:
20892 2016-07-11 Mark Lam <mark.lam@apple.com>
20894 Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
20895 https://bugs.webkit.org/show_bug.cgi?id=159524
20897 Reviewed by Michael Saboff.
20899 Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
20900 Also fixed up some tests to behave better to work with this new limit. This
20901 should make stack overflow tests complete sooner.
20903 * Scripts/run-jsc-stress-tests:
20904 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
20907 2016-07-11 Michael Catanzaro <mcatanzaro@igalia.com>
20909 [GTK] Whitespace fixes in install-dependencies script
20913 * gtk/install-dependencies:
20915 2016-07-11 Michael Catanzaro <mcatanzaro@igalia.com>
20917 [GTK] Install missing Fedora dependencies
20921 * gtk/install-dependencies:
20923 2016-07-09 Dan Bernstein <mitz@apple.com>
20925 Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
20926 https://bugs.webkit.org/show_bug.cgi?id=159600
20928 Reviewed by Daniel Bates.
20930 * Scripts/git-add-reviewer:
20931 Added the -s|--rubber-stamp option.
20932 (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
20935 2016-07-08 Andy Estes <aestes@apple.com>
20937 [Content Filtering] Load blocked pages more like other error pages are loaded
20938 https://bugs.webkit.org/show_bug.cgi?id=159485
20939 <rdar://problem/26014076>
20941 Reviewed by Brady Eidson.
20943 Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
20944 to a content filtering provisional navigation failure is ignored in preference of
20945 ContentFilter's own error page.
20947 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
20948 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20949 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
20950 (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
20951 (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
20952 (loadAlternateTest):
20954 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
20955 (-[MockContentFilterEnabler initWithCoder:]):
20956 * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
20957 (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
20958 (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
20959 (TestWebKitAPI::loadAlternateTest):
20960 (TestWebKitAPI::TEST):
20962 2016-07-08 Commit Queue <commit-queue@webkit.org>
20964 Unreviewed, rolling out r202944.
20965 https://bugs.webkit.org/show_bug.cgi?id=159570
20967 caused some tests to crash under GuardMalloc (Requested by
20970 Reverted changeset:
20972 "[Content Filtering] Load blocked pages more like other error
20974 https://bugs.webkit.org/show_bug.cgi?id=159485
20975 http://trac.webkit.org/changeset/202944
20977 2016-07-08 Martin Robinson <mrobinson@igalia.com>
20979 Remove mrobinson from the MathML watchlist
20980 https://bugs.webkit.org/show_bug.cgi?id=159559
20982 Reviewed by Philippe Normand.
20984 * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
20986 2016-07-08 Brady Eidson <beidson@apple.com>
20988 Clearing LocalStorage doesn't also delete -wal and -shm files.
20989 <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
20991 Reviewed by Brent Fulgham.
20992 Also helpfully picked over by Andy "Never Forgets" Estes.
20994 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20995 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
20996 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
20998 2016-07-08 Konstantin Tokarev <annulen@yandex.ru>
21000 Removed Qt leftovers from Tools.
21001 https://bugs.webkit.org/show_bug.cgi?id=159557
21003 Reviewed by Csaba Osztrogonác.
21005 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
21006 Removed 'qt' platform config.
21007 * Scripts/webkitpy/common/net/bugzilla/bug.py:
21008 Deleted non-functional e-mail address.
21010 2016-07-08 Commit Queue <commit-queue@webkit.org>
21012 Unreviewed, rolling out r202967.
21013 https://bugs.webkit.org/show_bug.cgi?id=159556
21015 This patch caused crashes in https tests on Windows (Requested
21016 by perarne on #webkit).
21018 Reverted changeset:
21020 "[Win] The test http/tests/security/contentSecurityPolicy
21021 /upgrade-insecure-requests/basic-upgrade.https.html is
21023 https://bugs.webkit.org/show_bug.cgi?id=159510
21024 http://trac.webkit.org/changeset/202967
21026 2016-07-08 Youenn Fablet <youenn@apple.com>
21028 Generate WebCore builtin wrapper files
21029 https://bugs.webkit.org/show_bug.cgi?id=159461
21031 Reviewed by Brian Burg.
21033 * Scripts/webkitpy/codegen/main.py:
21034 (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
21035 (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
21037 2016-07-08 Hunseop Jeong <hs85.jeong@samsung.com>
21039 [EFL] Fix build when media-stream is enabled.
21040 https://bugs.webkit.org/show_bug.cgi?id=159206
21042 Bump up the openwebrtc to find the correct package.
21044 Reviewed by Gyuyoung Kim.
21046 * efl/jhbuild.modules:
21047 * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
21049 2016-07-07 Per Arne Vollan <pvollan@apple.com>
21051 [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
21052 https://bugs.webkit.org/show_bug.cgi?id=159510
21054 Reviewed by Brent Fulgham.
21056 Allow any https certificate when running tests.
21058 * DumpRenderTree/win/DumpRenderTree.cpp:
21061 2016-07-07 Beth Dakin <bdakin@apple.com>
21063 API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
21064 https://bugs.webkit.org/show_bug.cgi?id=159532
21065 -and corresponding-
21066 rdar://problem/27177179
21068 Reviewed by Tim Horton.
21070 * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
21071 (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
21073 2016-07-07 Andy Estes <aestes@apple.com>
21075 [Content Filtering] Load blocked pages more like other error pages are loaded
21076 https://bugs.webkit.org/show_bug.cgi?id=159485
21077 <rdar://problem/26014076>
21079 Reviewed by Brady Eidson.
21081 Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
21082 to a content filtering provisional navigation failure is ignored in preference of
21083 ContentFilter's own error page.
21085 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
21086 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21087 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
21088 (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
21089 (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
21090 (loadAlternateTest):
21092 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
21093 (-[MockContentFilterEnabler initWithCoder:]):
21094 * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
21095 (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
21096 (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
21097 (TestWebKitAPI::loadAlternateTest):
21098 (TestWebKitAPI::TEST):
21100 2016-07-07 Per Arne Vollan <pvollan@apple.com>
21102 Unreviewed: add myself to the reviewers list.
21104 * Scripts/webkitpy/common/config/contributors.json:
21106 2016-07-07 Per Arne Vollan <pvollan@apple.com>
21108 [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
21109 https://bugs.webkit.org/show_bug.cgi?id=159509
21111 Reviewed by Alex Christensen.
21113 We should always insert the url in the url map when identifierForInitialRequest
21114 is called. Otherwise we can end up with identifiers not having an entry in the
21115 url map when urls are written to the test output file.
21117 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
21118 (ResourceLoadDelegate::identifierForInitialRequest):
21120 2016-07-06 Tim Horton <timothy_horton@apple.com>
21122 Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
21123 https://bugs.webkit.org/show_bug.cgi?id=159498
21124 <rdar://problem/26719903>
21126 Reviewed by Sam Weinig.
21128 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21129 * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
21130 (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
21131 (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
21134 Add a test ensuring that ReferenceDate in the DataDetectors context is respected
21135 when deciding what to linkify.
21137 2016-07-06 Alexey Proskuryakov <ap@apple.com>
21139 Build fix - work around rdar://problem/27196668.
21141 * LayoutTestRelay/Configurations/Base.xcconfig:
21143 2016-07-05 Per Arne Vollan <pvollan@apple.com>
21145 Enhance Windows DRT implementation to support platform scroll wheel events.
21146 https://bugs.webkit.org/show_bug.cgi?id=36002
21148 Reviewed by Brent Fulgham.
21150 Implement function continuousMouseScrollBy in Windows event sender.
21152 * DumpRenderTree/win/EventSender.cpp:
21154 (continuousMouseScrollBy):
21156 2016-07-05 Myles C. Maxfield <mmaxfield@apple.com>
21158 [Sierra] Rebaseline tests to use un-mocked system font metrics
21159 https://bugs.webkit.org/show_bug.cgi?id=159311
21160 <rdar://problem/24138411>
21162 Reviewed in person by Alexey Proskuryakov.
21164 Stop mocking the system font on Sierra.
21166 * DumpRenderTree/mac/DumpRenderTree.mm:
21167 (setDefaultsToConsistentValuesForTesting):
21168 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
21169 (WTR::InjectedBundle::platformInitialize):
21171 2016-07-05 Brady Eidson <beidson@apple.com>
21173 Database process crashes deleting a corrupt SQLite database file (null deref).
21174 https://bugs.webkit.org/show_bug.cgi?id=155506.
21176 Reviewed by Alex Christensen.
21178 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21179 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
21180 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
21181 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
21182 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
21183 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
21185 2016-07-05 Alexey Proskuryakov <ap@apple.com>
21187 run-webkit-tests should print more complete baseline search paths
21188 https://bugs.webkit.org/show_bug.cgi?id=159354
21190 Reviewed by Daniel Bates.
21192 run-webkit-tests used to only print directory names in baseline search paths.
21193 This was ok in basic usage, but quickly got confusing when using
21194 --additional-platform-directory flags.
21196 * Scripts/webkitpy/layout_tests/views/printing.py:
21197 (Printer.print_config):
21198 * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
21199 (Testprinter.test_print_config):
21200 (Testprinter.test_print_one_line_summary):
21202 2016-07-04 Brady Eidson <beidson@apple.com>
21204 WebProcesses don't handle DatabaseProcess going away uncleanly..
21205 https://bugs.webkit.org/show_bug.cgi?id=159371
21207 Reviewed by Alex Christensen.
21209 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21210 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
21211 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
21212 (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
21213 (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
21215 2016-07-04 Carlos Alberto Lopez Perez <clopez@igalia.com>
21217 [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
21218 https://bugs.webkit.org/show_bug.cgi?id=158141
21220 Rubber-stamped by Michael Catanzaro.
21222 Instead of checking for an specific Ubuntu version, query the apt
21223 database to see which version of PHP is available.
21225 * efl/install-dependencies:
21226 * gtk/install-dependencies:
21228 2016-07-04 Fujii Hironori <Hironori.Fujii@sony.com>
21230 webkit-patch failure-reason always raises TypeError
21231 https://bugs.webkit.org/show_bug.cgi?id=159394
21233 Reviewed by Benjamin Poulain.
21235 In r170637 (Bug 133067), the first and second arguments of
21236 pluralize were swapped.
21238 * Scripts/webkitpy/tool/commands/queries.py:
21239 (FailureReason._builder_to_explain): Swap the first and second
21240 arguments of pluralize.
21242 2016-07-02 Youenn Fablet <youennf@gmail.com>
21244 Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
21245 https://bugs.webkit.org/show_bug.cgi?id=152486
21247 Reviewed by Daniel Bates.
21249 Add launch of web-platform-tests server by run-webkit-httpd.
21250 Add two options to disable starting httpd and web-platform-tests servers.
21252 * Scripts/run-webkit-httpd:
21256 2016-07-01 Myles C. Maxfield <mmaxfield@apple.com>
21258 REGRESSION(r189668): Notification tests are flakey
21259 https://bugs.webkit.org/show_bug.cgi?id=159375
21260 <rdar://problem/22760990>
21262 Reviewed by Alexey Proskuryakov.
21264 Notifications are objects which must exist in both the UI Process and the Web Process. Each process
21265 identifies a notification object by a unique ID. When the Web Process sends a message regarding a
21266 notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
21267 (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
21269 Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
21270 by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
21271 to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
21272 global notification ID mapping, causing the wrong notification to be investigated.
21274 The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
21275 manually perform this same mapping. Luckily, this object already receives callbacks every time a
21276 notification is created or destroyed. However, because this object is implemented outside WebKit,
21277 it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
21278 this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
21279 WebNotificationProvider can properly map between the different IDs.
21281 * WebKitTestRunner/TestController.cpp:
21282 (WTR::TestController::runTestingServerLoop):
21283 (WTR::TestController::simulateWebNotificationClick):
21284 * WebKitTestRunner/WebNotificationProvider.cpp:
21285 (WTR::WebNotificationProvider::showWebNotification):
21286 (WTR::removeGlobalIDFromIDMap):
21287 (WTR::WebNotificationProvider::closeWebNotification):
21288 (WTR::WebNotificationProvider::removeNotificationManager):
21289 (WTR::WebNotificationProvider::simulateWebNotificationClick):
21290 (WTR::WebNotificationProvider::reset):
21291 * WebKitTestRunner/WebNotificationProvider.h:
21293 2016-07-01 Alexey Proskuryakov <ap@apple.com>
21295 Simplify LayoutTestRelay
21296 https://bugs.webkit.org/show_bug.cgi?id=159353
21298 Reviewed by Daniel Bates.
21300 1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
21301 by name and runtime makes no sense.
21302 2. Removed code to create devices, webkitpy always does this in advance.
21303 3. Don't create copies of testing apps - we can install the same one into
21304 each simulator, now that we don't run multiple tester processes in a single simulator.
21305 4. Pass information on how to find I/O pipes via environment, not via Info.plist.
21306 5. Removed code that kept testing apps alive in the background.
21307 6. Slightly updated coding style in functions that I touched.
21309 * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
21310 Updated for what we acually use at this point.
21312 * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
21313 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
21314 (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
21315 (-[LTRelayController ipcIdentifier]):
21316 (-[LTRelayController processName]):
21317 (-[LTRelayController didReceiveStdoutData:]):
21318 (-[LTRelayController didCrashWithMessage:]):
21319 (-[LTRelayController installApp]):
21320 (-[LTRelayController _environmentVariables]):
21321 (-[LTRelayController launchApp]):
21322 (-[LTRelayController start]):
21323 (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
21324 (-[LTRelayController uniqueAppPath]): Deleted.
21325 (-[LTRelayController uniqueAppURL]): Deleted.
21326 (-[LTRelayController uniqueAppIdentifier]): Deleted.
21327 (-[LTRelayController createUniqueApp]): Deleted.
21328 * LayoutTestRelay/LayoutTestRelay/main.m:
21330 (getRequiredStringArgument):
21332 (getTestingSimDevice): Deleted.
21333 * Scripts/webkitpy/port/driver.py:
21334 (IOSSimulatorDriver.cmd_line):
21335 * WebKitTestRunner/ios/TestControllerIOS.mm:
21336 (WTR::TestController::platformInitialize):
21337 * WebKitTestRunner/ios/mainIOS.mm:
21338 (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
21339 * DumpRenderTree/mac/DumpRenderTree.mm:
21341 (-[DumpRenderTree applicationDidEnterBackground:]):
21343 2016-07-01 Konstantin Tokarev <annulen@yandex.ru>
21345 [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
21346 https://bugs.webkit.org/show_bug.cgi?id=159344
21348 Reviewed by Alex Christensen.
21350 * DumpRenderTree/CMakeLists.txt:
21352 2016-07-01 Youenn Fablet <youennf@gmail.com>
21354 Add a runtime flag for DOM iterators
21355 https://bugs.webkit.org/show_bug.cgi?id=159300
21357 Reviewed by Alex Christensen.
21359 * DumpRenderTree/mac/DumpRenderTree.mm:
21360 (resetWebPreferencesToConsistentValues):
21361 * DumpRenderTree/win/DumpRenderTree.cpp:
21362 (resetWebPreferencesToConsistentValues):
21363 * Scripts/webkitperl/FeatureList.pm:
21364 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
21365 (WTR::InjectedBundle::beginTesting):
21366 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
21367 (WTR::TestRunner::setDOMIteratorEnabled):
21368 * WebKitTestRunner/InjectedBundle/TestRunner.h:
21370 2016-06-30 Tina Liu <iting_liu@apple.com>
21372 Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
21373 https://bugs.webkit.org/show_bug.cgi?id=159326
21375 Reviewed by Brady Eidson.
21377 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21378 * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
21379 (TestWebKitAPI::didFinishLoadForFrame):
21380 (TestWebKitAPI::didChangeBackForwardListForPage):
21381 (TestWebKitAPI::setPageLoaderClient):
21382 Set the page loader client and register for didFinishLoadForFrame and
21383 didChangeBackForwardList callbacks.
21384 (TestWebKitAPI::createSessionStateData):
21385 Load a webpage ("simple.html") and return the session state for this page.
21386 (TestWebKitAPI::TEST):
21387 Restore the page session state with that of "simple.html" without navigation.
21388 Verify that the committed URL is NULL since there's no navigation involved.
21389 Verify that the current item in the back forward list, which should be what
21390 we restored from the session state, has the expected URL.
21392 2016-06-29 Filip Pizlo <fpizlo@apple.com>
21394 Generators violate bytecode liveness validation
21395 https://bugs.webkit.org/show_bug.cgi?id=159279
21397 Reviewed by Yusuke Suzuki.
21399 Add Basic to our test harness.
21401 * Scripts/run-javascriptcore-tests:
21402 (runJSCStressTests):
21404 2016-06-30 Per Arne Vollan <pvollan@apple.com>
21406 [Win][Debug] Assertion fails in TestWTF.
21407 https://bugs.webkit.org/show_bug.cgi?id=159299
21409 Reviewed by Alex Christensen.
21411 The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
21412 The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
21413 the assertion failure. Since the variable is actually used, there is no need to use the
21414 UNUSED_PARAM macro.
21416 * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
21417 (TestWebKitAPI::TEST):
21419 2016-06-30 Youenn Fablet <youennf@gmail.com>
21421 LayoutTests intermittently failing to run due to issues starting Web Platform Test server
21422 https://bugs.webkit.org/show_bug.cgi?id=159166
21423 <rdar://problem/27051759>
21425 Reviewed by Alexey Proskuryakov.
21427 Setting the certificate directory to the copied config.json.
21429 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
21430 (WebPlatformTestServer._copy_webkit_test_files):
21432 2016-06-29 Mark Lam <mark.lam@apple.com>
21434 Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
21435 https://bugs.webkit.org/show_bug.cgi?id=159274
21437 Reviewed by Keith Miller.
21439 * DumpRenderTree/mac/DumpRenderTree.mm:
21440 (DumpRenderTreeMain):
21442 2016-06-29 Alex Christensen <achristensen@webkit.org>
21444 WKWebView should ask WKNavigationDelegate about bad ssl certificates
21445 https://bugs.webkit.org/show_bug.cgi?id=159176
21447 Reviewed by Sam Weinig.
21449 * MiniBrowser/mac/WK2BrowserWindowController.m:
21450 (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
21451 (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
21452 (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
21454 2016-06-29 Carlos Alberto Lopez Perez <clopez@igalia.com>
21456 [GTK] Add missing install dependency after r202619
21457 https://bugs.webkit.org/show_bug.cgi?id=156716
21461 * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
21463 2016-06-29 Carlos Alberto Lopez Perez <clopez@igalia.com>
21465 [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
21466 https://bugs.webkit.org/show_bug.cgi?id=156716
21468 Reviewed by Carlos Garcia Campos and Michael Catanzaro.
21470 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
21472 * Scripts/webkitpy/port/gtk.py:
21473 (GtkPort.__init__):
21474 (GtkPort._driver_class):
21475 (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
21476 (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
21477 platform directory for storing the wayland specific layout test results and expectations for ${port}.
21478 For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
21479 test expectations file on the GTK port when running the tests with the --wayland command line switch.
21480 Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
21481 * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
21482 (WestonDriver.check_driver):
21483 (WestonDriver.__init__):
21484 (WestonDriver._start):
21485 * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
21486 (WestonXvfbDriverDisplayTest):
21487 (WestonXvfbDriverDisplayTest.__init__):
21488 (WestonXvfbDriverDisplayTest._xvfb_run):
21489 (WestonDriverTest.make_driver):
21490 (WestonDriverTest.test_start):
21491 * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
21492 or to satisfy the pkg-config check of the new added modules in JHBuild.
21493 * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
21494 and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
21495 provided by the system are already new enough.
21496 Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
21497 It was the only way to get the software EGL rasterizer working without depending on user drivers.
21498 Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
21499 feature to avoid building libdrm when the one provided by the system is new enough.
21501 * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
21502 Xorg had no support for searching the DRI drivers on a custom path at runtime.
21503 This patch implements support for that reusing the same variable that we use with Mesa to set the
21504 custom path for the DRI drivers path.
21506 2016-06-29 Alejandro G. Castro <alex@igalia.com>
21508 [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
21509 https://bugs.webkit.org/show_bug.cgi?id=159256
21511 Reviewed by Philippe Normand.
21513 We need the last fixes in the repository to make the scream queue
21516 * gtk/jhbuild.modules:
21518 2016-06-28 Commit Queue <commit-queue@webkit.org>
21520 Unreviewed, rolling out r202580.
21521 https://bugs.webkit.org/show_bug.cgi?id=159245
21523 Caused all WKTR tests to fail on GuardMalloc and Production
21524 only for unknown reasons, investigating offline. (Requested by
21525 brrian on #webkit).
21527 Reverted changeset:
21529 "RunLoop::Timer should use constructor templates instead of
21531 https://bugs.webkit.org/show_bug.cgi?id=159153
21532 http://trac.webkit.org/changeset/202580
21534 2016-06-28 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
21536 Use a regex to check if a test step is for JavaScriptCore
21537 https://bugs.webkit.org/show_bug.cgi?id=159224
21539 Reviewed by Geoffrey Garen.
21541 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
21542 (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
21543 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
21544 (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
21545 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
21546 (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
21548 2016-06-28 Michael Saboff <msaboff@apple.com>
21550 btjs no longer accepts optional frame count argument
21551 https://bugs.webkit.org/show_bug.cgi?id=159235
21553 Reviewed by Saam Barati.
21555 Fix the detection of optional backtrace-depth parameter to use the length
21558 * lldb/lldb_webkit.py:
21561 2016-06-28 Jon Lee <jonlee@apple.com>
21563 Update animometer.plan
21565 Rubber-stamped by Said Abou-Hallawa.
21567 * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
21569 2016-06-28 Filip Pizlo <fpizlo@apple.com>
21571 Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
21573 * Scripts/run-javascriptcore-tests:
21574 (runJSCStressTests):
21576 2016-06-28 Brian Burg <bburg@apple.com>
21578 RunLoop::Timer should use constructor templates instead of class templates
21579 https://bugs.webkit.org/show_bug.cgi?id=159153
21581 Reviewed by Alex Christensen.
21583 Remove the RunLoop::Timer class template argument, and pass its constructor
21584 a reference to `this` instead of a pointer to `this`.
21586 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
21587 (WTR::TestRunner::TestRunner):
21588 * WebKitTestRunner/InjectedBundle/TestRunner.h:
21589 * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
21590 (TestWebKitAPI::TEST):
21592 2016-06-28 Ryosuke Niwa <rniwa@webkit.org>
21594 REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
21595 https://bugs.webkit.org/show_bug.cgi?id=159199
21597 Reviewed by Alexey Proskuryakov.
21599 Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
21601 * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
21602 * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
21603 * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
21604 an input element getting automatically focused on Mac.
21606 2016-06-28 Per Arne Vollan <pvollan@apple.com>
21608 [Win] Custom elements tests are failing.
21609 https://bugs.webkit.org/show_bug.cgi?id=159139
21611 Reviewed by Alex Christensen.
21613 Enable custom element API when running tests.
21615 * DumpRenderTree/win/DumpRenderTree.cpp:
21616 (resetWebPreferencesToConsistentValues):
21618 2016-06-27 Lucas Forschler <lforschler@apple.com>
21620 Test commit. Please ignore.
21622 2016-06-27 Michael Catanzaro <mcatanzaro@igalia.com>
21624 [GTK][EFL] Disable subtle-crypto in FeatureList.pm
21625 https://bugs.webkit.org/show_bug.cgi?id=155073
21627 Reviewed by Daniel Bates.
21629 * Scripts/webkitperl/FeatureList.pm:
21631 2016-06-27 Simon Fraser <simon.fraser@apple.com>
21633 [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
21634 https://bugs.webkit.org/show_bug.cgi?id=159077
21636 Reviewed by Tim Horton.
21638 Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
21640 Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
21641 which is necessary for UI-side compositing.
21643 Add some null checks to fix issues when the WKWebView gets resized to be empty, which
21644 seems to happen for some tests that call window.resizeTo().
21646 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
21647 (WTR::InjectedBundlePage::dump): Deleted.
21648 * WebKitTestRunner/TestInvocation.cpp:
21649 (WTR::TestInvocation::dumpResults):
21650 * WebKitTestRunner/cg/TestInvocationCG.cpp:
21651 (WTR::createCGContextFromImage):
21652 (WTR::computeMD5HashStringForContext):
21653 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
21654 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
21655 (WTR::PlatformWebView::windowSnapshotImage):
21657 2016-06-27 Gyuyoung Kim <gyuyoung.kim@webkit.org>
21659 [EFL] Support to build on Debian linux
21660 https://bugs.webkit.org/show_bug.cgi?id=159123
21662 Reviewed by Antonio Gomes.
21664 * efl/install-dependencies: Install libgnutls28-dev.
21666 2016-06-27 Alex Christensen <achristensen@webkit.org>
21668 Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
21669 https://bugs.webkit.org/show_bug.cgi?id=159071
21671 Reviewed by Brady Eidson.
21673 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
21674 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
21675 (WTR::TestRunner::setHandlesAuthenticationChallenges):
21676 (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
21677 (WTR::TestRunner::setAuthenticationUsername):
21678 * WebKitTestRunner/InjectedBundle/TestRunner.h:
21679 * WebKitTestRunner/TestController.cpp:
21680 (WTR::TestController::TestController):
21681 (WTR::TestController::resetStateToConsistentValues):
21682 (WTR::TestController::didFinishNavigation):
21683 (WTR::TestController::canAuthenticateAgainstProtectionSpace):
21684 (WTR::TestController::didReceiveAuthenticationChallenge):
21685 (WTR::TestController::didCommitNavigation):
21686 * WebKitTestRunner/TestController.h:
21687 (WTR::TestController::setBlockAllPlugins):
21688 (WTR::TestController::setShouldLogHistoryClientCallbacks):
21689 (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
21690 (WTR::TestController::isCurrentInvocation):
21691 * WebKitTestRunner/TestInvocation.cpp:
21692 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
21693 Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
21695 2016-06-27 Per Arne Vollan <pvollan@apple.com>
21697 [Win] The test fast/events/wheel-event-outside-body.html is timing out.
21698 https://bugs.webkit.org/show_bug.cgi?id=159129
21700 Reviewed by Alex Christensen.
21702 Implement the function mouseScrollBy in the Windows event sender.
21704 * DumpRenderTree/win/EventSender.cpp:
21706 (mouseScrollByWithWheelAndMomentumPhasesCallback):
21708 2016-06-25 Filip Pizlo <fpizlo@apple.com>
21710 REGRESSION: Weak symbol warning when linking TestWebKitAPI
21711 https://bugs.webkit.org/show_bug.cgi?id=159104
21713 Reviewed by Dan Bernstein.
21715 This uses a better approach to turn on -fvisility=hidden. All of the other projects set
21716 this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
21718 * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
21719 * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
21720 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
21722 2016-06-25 Per Arne Vollan <pvollan@apple.com>
21724 [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
21725 https://bugs.webkit.org/show_bug.cgi?id=159086
21727 Reviewed by Alex Christensen.
21729 Implement required wheel event function in event sender.
21731 * DumpRenderTree/win/EventSender.cpp:
21732 (mouseScrollByWithWheelAndMomentumPhasesCallback):
21734 2016-06-24 Filip Pizlo <fpizlo@apple.com>
21736 REGRESSION: Weak symbol warning when linking TestWebKitAPI
21737 https://bugs.webkit.org/show_bug.cgi?id=159104
21739 Reviewed by Mark Lam.
21741 The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
21744 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21746 2016-06-24 David Kilzer <ddkilzer@apple.com>
21748 parser_unittests.pl should not hardcode list of tests
21749 <https://webkit.org/b/159074>
21751 Reviewed by Daniel Bates.
21753 * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
21754 Update to read the list of tests from the 'resources' directory,
21755 and instead map file extensions to subroutine names. Switch to
21756 use File::Basename::fileparse() to get basename and file
21757 extension for each test.
21758 (readTestFiles): Added. Reads files from the directory passed
21759 in and ignores: hidden files, anything that isn't a plain file,
21760 and expected test results files.
21762 2016-06-23 Simon Fraser <simon.fraser@apple.com>
21766 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
21767 * DumpRenderTree/cg/PixelDumpSupportCG.h:
21769 2016-06-23 Gyuyoung Kim <gyuyoung.kim@webkit.org>
21771 [EFL] Change download path of libxslt
21773 Unreviewed EFL build fix.
21775 In Korea current download path can't be accessed. Change it.
21777 * efl/jhbuild.modules:
21779 2016-06-23 Simon Fraser <simon.fraser@apple.com>
21781 https://bugs.webkit.org/show_bug.cgi?id=159077
21783 Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
21784 snapshot the final state of the test in release builds.
21786 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
21787 (WTR::InjectedBundlePage::dump):
21789 2016-06-23 Simon Fraser <simon.fraser@apple.com>
21791 Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
21793 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
21794 (createBitmapContextFromWebView):
21795 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
21796 (WTR::PlatformWebView::windowSnapshotImage):
21798 2016-06-23 Simon Fraser <simon.fraser@apple.com>
21800 [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
21801 https://bugs.webkit.org/show_bug.cgi?id=159077
21803 Reviewed by Tim Horton.
21805 Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
21806 This allows them to capture compositing layers in snapshots, rather than doing a software paint,
21807 thus enabling testing of more things.
21809 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
21810 (createBitmapContext): Moved to this file to share it.
21811 * DumpRenderTree/cg/PixelDumpSupportCG.h:
21812 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
21813 (createBitmapContextFromWebView):
21814 (BitmapContext::createFromUIImage): Deleted.
21815 (BitmapContext::pixelData): Deleted.
21816 (BitmapContext::BitmapContext): Deleted.
21817 (computeMD5HashStringForBitmapContext): Deleted.
21818 (dumpBitmap): Deleted.
21819 * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
21820 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
21821 (createPagedBitmapContext):
21822 (createBitmapContext): Deleted.
21823 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
21824 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
21825 (WTR::InjectedBundlePage::dump): Deleted.
21826 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
21827 (WTR::PlatformWebView::windowSnapshotImage):
21829 2016-06-23 Konstantin Tokarev <annulen@yandex.ru>
21831 [jhbuild] Added libxslt module.
21832 https://bugs.webkit.org/show_bug.cgi?id=159034
21834 Unreviewed, followup for r202373.
21836 * efl/install-dependencies: Removed libxslt
21837 * gtk/install-dependencies: Ditto.
21839 2016-06-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
21841 [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
21842 https://bugs.webkit.org/show_bug.cgi?id=159050
21844 Reviewed by Antonio Gomes.
21846 To be sync with GTK port, this patch bumps gstreamer version for EFL port.
21848 * efl/jhbuild.modules:
21849 * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
21850 * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
21852 2016-06-23 Konstantin Tokarev <annulen@yandex.ru>
21854 [jhbuild] Added libxslt module.
21855 https://bugs.webkit.org/show_bug.cgi?id=159034
21857 Reviewed by Michael Catanzaro.
21859 * efl/jhbuild.modules:
21860 * gtk/jhbuild.modules:
21862 2016-06-22 Per Arne Vollan <pvollan@apple.com>
21864 [Win] Use Windows api function to find top level parent.
21865 https://bugs.webkit.org/show_bug.cgi?id=159021
21867 Reviewed by Brent Fulgham.
21869 Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
21871 * DumpRenderTree/win/UIDelegate.cpp:
21872 (UIDelegate::runModal):
21873 (findTopLevelParent): Deleted.
21874 * MiniBrowser/win/PrintWebUIDelegate.cpp:
21875 (PrintWebUIDelegate::runModal):
21876 (findTopLevelParent): Deleted.
21878 2016-06-22 Per Arne Vollan <pvollan@apple.com>
21880 [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
21881 https://bugs.webkit.org/show_bug.cgi?id=158934
21883 Reviewed by Brent Fulgham.
21885 DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
21887 * DumpRenderTree/win/TestRunnerWin.cpp:
21888 (TestRunner::clearAllDatabases):
21890 2016-06-22 Saam Barati <sbarati@apple.com>
21892 run-javascriptcore-tests should have some environment variables for commonly used settings
21893 https://bugs.webkit.org/show_bug.cgi?id=159047
21895 Reviewed by Keith Miller.
21897 This patch adds three environment variables that run-javascriptcore-tests
21899 - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
21900 determines if we should run the api tests or not.
21901 - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
21902 determines if we will perform a build or not before running the tests.
21903 to set the default should-build setting.
21904 - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
21905 a yaml file. If set, we will run the extra tests it refers to.
21907 All the values in these environment variables will be overridden if an
21908 option is explicitly passed in. For example, the following will run
21910 `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
21912 * Scripts/run-javascriptcore-tests:
21914 2016-06-22 Saam barati <sbarati@apple.com>
21916 TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
21917 https://bugs.webkit.org/show_bug.cgi?id=159037
21918 <rdar://problem/26935349>
21920 Reviewed by Benjamin Poulain.
21922 Run typeProfiler.yaml tests under an additional CJIT enabled mode.
21924 * Scripts/run-jsc-stress-tests:
21926 2016-06-22 Aakash Jain <aakash_jain@apple.com>
21928 Fix style issues in webkitpy
21929 https://bugs.webkit.org/show_bug.cgi?id=159019
21931 Reviewed by Daniel Bates.
21933 Fixed the formatting issues as reported by check-webkit-style in webkitpy.
21934 There is no functionality change.
21935 Only affected file names retained below for brevity.
21937 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
21938 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
21939 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
21940 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
21941 * Scripts/webkitpy/benchmark_runner/utils.py:
21942 * Scripts/webkitpy/common/checkout/changelog.py:
21943 * Scripts/webkitpy/common/checkout/changelog_unittest.py:
21944 * Scripts/webkitpy/common/checkout/checkout.py:
21945 * Scripts/webkitpy/common/checkout/checkout_mock.py:
21946 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
21947 * Scripts/webkitpy/common/checkout/commitinfo.py:
21948 * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
21949 * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
21950 * Scripts/webkitpy/common/checkout/scm/scm.py:
21951 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
21952 * Scripts/webkitpy/common/config/committers_unittest.py:
21953 * Scripts/webkitpy/common/config/irc.py:
21954 * Scripts/webkitpy/common/config/ports.py:
21955 * Scripts/webkitpy/common/config/ports_unittest.py:
21956 * Scripts/webkitpy/common/config/urls.py:
21957 * Scripts/webkitpy/common/host_mock.py:
21958 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
21959 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
21960 * Scripts/webkitpy/common/net/buildbot/buildbot.py:
21961 * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
21962 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
21963 * Scripts/webkitpy/common/net/credentials_unittest.py:
21964 * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
21965 * Scripts/webkitpy/common/net/networktransaction_unittest.py:
21966 * Scripts/webkitpy/common/net/statusserver.py:
21967 * Scripts/webkitpy/common/system/autoinstall.py:
21968 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
21969 * Scripts/webkitpy/common/system/executive.py:
21970 * Scripts/webkitpy/common/system/executive_mock.py:
21971 * Scripts/webkitpy/common/system/executive_unittest.py:
21972 * Scripts/webkitpy/common/system/filesystem_mock.py:
21973 * Scripts/webkitpy/common/system/filesystem_unittest.py:
21974 * Scripts/webkitpy/common/system/logutils_unittest.py:
21975 * Scripts/webkitpy/common/system/path.py:
21976 * Scripts/webkitpy/common/system/path_unittest.py:
21977 * Scripts/webkitpy/common/system/platforminfo.py:
21978 * Scripts/webkitpy/common/system/user.py:
21979 * Scripts/webkitpy/common/system/user_unittest.py:
21980 * Scripts/webkitpy/common/system/workspace_unittest.py:
21981 * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
21982 * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
21983 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
21984 * Scripts/webkitpy/layout_tests/controllers/manager.py:
21985 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
21986 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
21987 * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
21988 * Scripts/webkitpy/layout_tests/models/test_configuration.py:
21989 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
21990 * Scripts/webkitpy/layout_tests/models/test_failures.py:
21991 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
21992 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
21993 * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
21994 * Scripts/webkitpy/layout_tests/views/printing.py:
21995 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
21996 * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
21997 * Scripts/webkitpy/port/base_unittest.py:
21998 * Scripts/webkitpy/port/driver.py:
21999 * Scripts/webkitpy/port/driver_unittest.py:
22000 * Scripts/webkitpy/port/factory.py:
22001 * Scripts/webkitpy/port/gtk.py:
22002 * Scripts/webkitpy/port/server_process_unittest.py:
22003 * Scripts/webkitpy/port/test.py:
22004 * Scripts/webkitpy/port/win.py:
22005 * Scripts/webkitpy/style/checker.py:
22006 * Scripts/webkitpy/style/checkers/common_unittest.py:
22007 * Scripts/webkitpy/style/checkers/cpp.py:
22008 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
22009 * Scripts/webkitpy/style/checkers/js.py:
22010 * Scripts/webkitpy/style/checkers/jsonchecker.py:
22011 * Scripts/webkitpy/style/checkers/png.py:
22012 * Scripts/webkitpy/style/checkers/text.py:
22013 * Scripts/webkitpy/style/checkers/text_unittest.py:
22014 * Scripts/webkitpy/style/error_handlers.py:
22015 * Scripts/webkitpy/style/filter.py:
22016 * Scripts/webkitpy/style/filter_unittest.py:
22017 * Scripts/webkitpy/style/optparser.py:
22018 * Scripts/webkitpy/style/optparser_unittest.py:
22019 * Scripts/webkitpy/test/main.py:
22020 * Scripts/webkitpy/w3c/test_converter.py:
22021 * Scripts/webkitpy/w3c/test_converter_unittest.py:
22022 * Scripts/webkitpy/w3c/test_importer_unittest.py:
22023 * Scripts/webkitpy/xcode/simulator.py:
22025 2016-06-22 Brady Eidson <beidson@apple.com>
22027 DatabaseProcess doesn't handle WebProcesses going away uncleanly.
22028 https://bugs.webkit.org/show_bug.cgi?id=158894
22030 Reviewed by Alex Christensen.
22032 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22033 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
22034 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
22035 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
22037 2016-06-22 Jon Lee <jonlee@apple.com>
22039 Update animometer.plan
22040 https://bugs.webkit.org/show_bug.cgi?id=159012
22042 Reviewed by Ryosuke Niwa.
22044 * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
22046 2016-06-22 Youenn Fablet <youenn.fablet@crf.canon.fr>
22048 W3C test importer should generate files to ignore by WebKit SCM
22049 https://bugs.webkit.org/show_bug.cgi?id=142743
22051 Reviewed by Darin Adler.
22053 TestDownloader generates the .gitignore file according submodules git repository information.
22054 TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.
22056 * Scripts/webkitpy/w3c/test_downloader.py:
22057 (TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
22058 * Scripts/webkitpy/w3c/test_importer.py:
22059 (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
22061 (TestImporter.write_init_py): Writing not empty __init__.py files.
22062 (TestImporter.import_tests): Using of write_init_py.
22063 * Scripts/webkitpy/w3c/test_importer_unittest.py:
22064 (TestImporterTest.test_git_ignore_generation): Added .gitignore test.
22065 (TestImporterTest):
22066 (TestImporterTest.test_initpy_generation): Added __init__.py test.
22068 2016-06-21 Sam Weinig <sam@webkit.org>
22070 WKWebView with no WKNavigationDelegate does not follow universal links
22071 <rdar://problem/24374110>
22072 https://bugs.webkit.org/show_bug.cgi?id=158997
22074 Reviewed by Dan Bernstein.
22076 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22077 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
22078 Add a new test that shows that we have a default navigation delegate by swizzling
22079 -[NSWorkspace openURL:]. This will only be called if there is a default client.
22081 2016-06-22 Per Arne Vollan <pvollan@apple.com>
22083 [Win] Implement modal dialog support in MiniBrowser.
22084 https://bugs.webkit.org/show_bug.cgi?id=158976
22086 Reviewed by Brent Fulgham.
22088 * MiniBrowser/win/PrintWebUIDelegate.cpp:
22089 (PrintWebUIDelegate::createWebViewWithRequest):
22090 (getHandleFromWebView):
22091 (PrintWebUIDelegate::webViewClose):
22092 (PrintWebUIDelegate::setFrame):
22093 (PrintWebUIDelegate::webViewFrame):
22094 (PrintWebUIDelegate::canRunModal):
22095 (findTopLevelParent):
22096 (PrintWebUIDelegate::runModal):
22097 (PrintWebUIDelegate::createModalDialog):
22098 * MiniBrowser/win/PrintWebUIDelegate.h:
22099 (PrintWebUIDelegate::webViewClose):
22100 (PrintWebUIDelegate::setFrame):
22101 (PrintWebUIDelegate::webViewFrame):
22102 (PrintWebUIDelegate::canRunModal):
22103 (PrintWebUIDelegate::runModal):
22105 2016-06-22 Per Arne Vollan <pvollan@apple.com>
22107 window.showModalDialog doesn't work in DumpRenderTree on Windows
22108 https://bugs.webkit.org/show_bug.cgi?id=53675
22110 Reviewed by Brent Fulgham.
22112 Implement modal dialog support in DumpRenderTree.
22114 * DumpRenderTree/win/UIDelegate.cpp:
22115 (UIDelegate::canRunModal):
22116 (getHandleFromWebView):
22117 (UIDelegate::createModalDialog):
22118 (findTopLevelParent):
22119 (UIDelegate::runModal):
22120 (UIDelegate::webViewClose):
22121 * DumpRenderTree/win/UIDelegate.h:
22123 2016-06-21 Aakash Jain <aakash_jain@apple.com>
22125 Fix formatting issues reported by check-webkit-style
22126 https://bugs.webkit.org/show_bug.cgi?id=159008
22128 Reviewed by Alexey Proskuryakov.
22130 Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
22131 There is no functionality change.
22133 * Scripts/webkitpy/tool/bot/irc_command.py:
22136 * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
22137 (IRCBotTest.test_exception_during_command):
22138 (IRCBotTest.test_exception_during_command.CommandWithException):
22139 (IRCBotTest.test_exception_during_command.CommandWithException.execute):
22140 * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
22141 (test_missing_unit_test_results_path):
22142 (test_layout_test_results):
22143 * Scripts/webkitpy/tool/bot/queueengine.py:
22144 * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
22145 * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
22146 (AbstractSequencedCommand):
22147 (AbstractSequencedCommand.__init__):
22148 * Scripts/webkitpy/tool/commands/download.py:
22150 * Scripts/webkitpy/tool/commands/openbugs.py:
22151 * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
22153 * Scripts/webkitpy/tool/commands/queries.py:
22154 (PatchesToCommitQueue):
22155 (PatchesToCommitQueue.__init__):
22156 (PatchesToCommitQueue._needs_commit_queue):
22157 * Scripts/webkitpy/tool/commands/queries_unittest.py:
22158 (PrintExpectationsTest.test_platform):
22159 (PrintBaselinesTest):
22160 (PrintBaselinesTest.setUp):
22161 * Scripts/webkitpy/tool/commands/queues.py:
22163 (AbstractQueue.__init__):
22164 (AbstractQueue.execute):
22165 * Scripts/webkitpy/tool/commands/queues_unittest.py:
22167 * Scripts/webkitpy/tool/commands/rebaseline.py:
22168 (AbstractParallelRebaselineCommand._files_to_add):
22169 (AbstractParallelRebaselineCommand):
22170 (AbstractParallelRebaselineCommand._rebaseline):
22171 * Scripts/webkitpy/tool/commands/setupgitclone.py:
22173 * Scripts/webkitpy/tool/commands/sheriffbot.py:
22174 * Scripts/webkitpy/tool/commands/stepsequence.py:
22175 * Scripts/webkitpy/tool/commands/upload.py:
22176 (PostCommits._comment_text_for_commit):
22178 (PostCommits.execute):
22180 (MarkBugFixed.__init__):
22181 * Scripts/webkitpy/tool/commands/upload_unittest.py:
22182 (UploadCommandsTest):
22183 (UploadCommandsTest.test_commit_message_for_current_diff):
22184 * Scripts/webkitpy/tool/grammar_unittest.py:
22186 (GrammarTest.test_join_with_separators):
22187 * Scripts/webkitpy/tool/multicommandtool.py:
22188 (HelpCommand.__init__):
22190 (HelpCommand._help_epilog):
22191 (HelpCommand._remove_help_options):
22192 (MultiCommandTool):
22193 (MultiCommandTool.__init__):
22194 (MultiCommandTool.main):
22195 * Scripts/webkitpy/tool/multicommandtool_unittest.py:
22197 (TrivialCommand.__init__):
22198 (MultiCommandToolTest):
22199 (MultiCommandToolTest._assert_tool_main_outputs):
22200 (MultiCommandToolTest.test_retry):
22201 (test_command_help):
22202 * Scripts/webkitpy/tool/steps/__init__.py:
22203 * Scripts/webkitpy/tool/steps/abstractstep.py:
22204 * Scripts/webkitpy/tool/steps/applypatch.py:
22205 * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
22206 (ApplyPatchWithLocalCommit):
22207 (ApplyPatchWithLocalCommit.options):
22208 * Scripts/webkitpy/tool/steps/build.py:
22209 * Scripts/webkitpy/tool/steps/checkstyle.py:
22211 (CheckStyle.options):
22212 * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
22213 * Scripts/webkitpy/tool/steps/closebug.py:
22214 * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
22215 * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
22216 (CloseBugForLandDiffTest):
22217 (CloseBugForLandDiffTest.test_empty_state):
22218 * Scripts/webkitpy/tool/steps/closepatch.py:
22219 * Scripts/webkitpy/tool/steps/commit.py:
22221 * Scripts/webkitpy/tool/steps/confirmdiff.py:
22222 * Scripts/webkitpy/tool/steps/editchangelog.py:
22223 * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
22224 * Scripts/webkitpy/tool/steps/metastep.py:
22226 (MetaStep.__init__):
22228 * Scripts/webkitpy/tool/steps/obsoletepatches.py:
22229 * Scripts/webkitpy/tool/steps/options.py:
22231 * Scripts/webkitpy/tool/steps/postdiff.py:
22232 * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
22233 * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
22234 * Scripts/webkitpy/tool/steps/preparechangelog.py:
22235 * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
22236 (PrepareChangeLogTest):
22237 (PrepareChangeLogTest.test_resolve_existing_entry):
22238 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
22239 * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
22240 * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
22241 * Scripts/webkitpy/tool/steps/revertrevision.py:
22242 * Scripts/webkitpy/tool/steps/runtests.py:
22243 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
22244 * Scripts/webkitpy/tool/steps/steps_unittest.py:
22246 (StepsTest._step_options):
22247 * Scripts/webkitpy/tool/steps/update.py:
22248 * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
22249 (UpdateChangeLogsWithReviewerTest):
22250 (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
22251 * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
22252 * Scripts/webkitpy/tool/steps/validatereviewer.py:
22254 2016-06-21 Chris Dumez <cdumez@apple.com>
22256 Unreviewed, rolling out r202296.
22258 Broke basic browsing in Safari
22260 Reverted changeset:
22262 "WKWebView with no WKNavigationDelegate does not follow
22264 https://bugs.webkit.org/show_bug.cgi?id=158997
22265 http://trac.webkit.org/changeset/202296
22267 2016-06-21 Anders Carlsson <andersca@apple.com>
22271 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
22273 2016-06-21 Anders Carlsson <andersca@apple.com>
22275 Begin moving the Apple Pay code to the open source repository
22276 https://bugs.webkit.org/show_bug.cgi?id=158998
22278 Reviewed by Tim Horton.
22280 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
22281 Add ENABLE_APPLE_PAY.
22283 2016-06-21 Said Abou-Hallawa <sabouhallawa@apple,com>
22285 Add system tracing points for requestAnimationFrame() workflow
22286 https://bugs.webkit.org/show_bug.cgi?id=158723
22288 Reviewed by Simon Fraser.
22290 Add new plist entries to be used by kdebug_trace() viewing tools.
22292 * Tracing/SystemTracePoints.plist:
22294 2016-06-21 Sam Weinig <sam@webkit.org>
22296 WKWebView with no WKNavigationDelegate does not follow universal links
22297 <rdar://problem/24374110>
22298 https://bugs.webkit.org/show_bug.cgi?id=158997
22300 Reviewed by Dan Bernstein.
22302 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22303 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
22304 Add a new test that shows that we have a default navigation delegate by swizzling
22305 -[NSWorkspace openURL:]. This will only be called if there is a default client.
22307 2016-06-21 Aakash Jain <aakash_jain@apple.com>
22309 run-javascriptcore-tests should have flag to skip mozilla tests
22310 https://bugs.webkit.org/show_bug.cgi?id=158963
22311 rdar://problem/25838924
22313 Reviewed by Alexey Proskuryakov.
22315 * Scripts/run-javascriptcore-tests:
22316 (runJSCStressTests): Added flag to skip mozilla tests.
22318 2016-06-20 Commit Queue <commit-queue@webkit.org>
22320 Unreviewed, rolling out r202136.
22321 https://bugs.webkit.org/show_bug.cgi?id=158932
22323 JSBench wasn't regressed by r202002 and r202111 on iOS after
22324 all (Requested by rniwa_ on #webkit).
22326 Reverted changeset:
22328 "Unreviewed, rolling out r202002 and r202111."
22329 https://bugs.webkit.org/show_bug.cgi?id=158638
22330 http://trac.webkit.org/changeset/202136
22332 2016-06-20 Keith Rollin <krollin@apple.com>
22334 Remove RefPtr::release() and change calls sites to use WTFMove()
22335 https://bugs.webkit.org/show_bug.cgi?id=158369
22337 Reviewed by Chris Dumez.
22339 RefPtr::release() releases its managed pointer awkwardly. It's more
22340 direct and clearer to use WTFMove to transfer ownership of the managed
22343 As part of this cleanup, also change a lot of explicit data types to
22346 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
22347 (createBitmapContextFromWebView):
22348 (createPagedBitmapContext):
22349 * DumpRenderTree/mac/TestRunnerMac.mm:
22350 (TestRunner::setMockGeolocationPosition):
22351 * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
22352 (TestWebKitAPI::TEST):
22353 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
22354 (TestWebKitAPI::TEST):
22356 2016-06-20 Tim Horton <timothy_horton@apple.com>
22358 Add a API test for *DeferringViewInWindowChanges as fixed in r202230
22359 https://bugs.webkit.org/show_bug.cgi?id=158947
22361 Reviewed by Simon Fraser.
22363 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22364 * TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Added.
22365 (TestWebKitAPI::didFinishLoadForFrame):
22366 (TestWebKitAPI::setPageLoaderClient):
22367 (TestWebKitAPI::TEST):
22368 Add a test ensuring that in-window state changes are deferred when using
22369 the SPI for deferring them, as fixed in r202230.
22371 2016-06-20 Fujii Hironori <Hironori.Fujii@sony.com>
22373 WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE"
22374 https://bugs.webkit.org/show_bug.cgi?id=158931
22376 Reviewed by Alexey Proskuryakov.
22378 * WebKitTestRunner/TestInvocation.cpp:
22379 (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Appended missing \n at the end of line.
22381 2016-06-17 Alexey Proskuryakov <ap@apple.com>
22383 Add test expectations for macOS Sierra
22384 https://bugs.webkit.org/show_bug.cgi?id=158903
22386 Reviewed by Alex Christensen.
22388 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png: Added.
22389 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png: Added.
22390 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
22391 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
22392 Added dashboard support.
22394 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
22395 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
22396 Trigger the right build queues on check-in.
22398 * Scripts/webkitpy/common/system/platforminfo.py:
22399 * Scripts/webkitpy/common/system/platforminfo_unittest.py:
22400 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
22401 * Scripts/webkitpy/port/mac.py:
22402 * Scripts/webkitpy/port/mac_unittest.py:
22403 * TestResultServer/static-dashboards/flakiness_dashboard.js:
22404 Added cases for Sierra, and updated tests for new baseline search paths.
22406 2016-06-19 Alexey Proskuryakov <ap@apple.com>
22408 Another buid fix for master.cfg.
22410 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
22411 (CompileWebKit.start):
22413 2016-06-19 Alexey Proskuryakov <ap@apple.com>
22415 Another buid fix for master.cfg.
22417 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
22418 (CompileWebKit.start):
22420 2016-06-19 Lucas Forschler <lforschler@apple.com>
22424 Unreviewed build fix.
22426 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
22427 (CompileWebKit.start):
22429 2016-06-19 Lucas Forschler <lforschler@apple.com>
22431 Test another commit.
22435 2016-06-19 Lucas Forschler <lforschler@apple.com>
22437 Testing fix for trac-mirror.
22441 2016-06-19 Lucas Forschler <lforschler@apple.com>
22443 Test a commit against the SVN 1.9 server upgrade.
22447 2016-06-17 Daniel Bates <dabates@apple.com>
22449 Unreviewed, rolling out r202186.
22451 Broke the Apple Windows, Apple Yosemite, GTK, and WinCairo
22454 Reverted changeset:
22456 "File scheme should not allow access of a resource on a
22458 https://bugs.webkit.org/show_bug.cgi?id=158552
22459 http://trac.webkit.org/changeset/202186
22461 2016-06-17 Pranjal Jumde <pjumde@apple.com>
22463 File scheme should not allow access of a resource on a different volume.
22464 https://bugs.webkit.org/show_bug.cgi?id=158552
22465 <rdar://problem/15307582>
22467 Reviewed by Brent Fulgham.
22469 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22470 * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
22471 * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
22472 (-[CrossPartitionFileSchemeAccessNavigationDelegate webView:didFinishNavigation:]):
22473 When the main page load is complete fetch the contents of the document to check if iframe was loaded
22475 Create a disk image and load the contents of the file.
22477 (TestWebKitAPI::TEST):
22479 2016-06-17 Enrique Ocaña González <eocanha@igalia.com>
22481 Unreviewed. Added myself to the list of committers.
22483 * Scripts/webkitpy/common/config/contributors.json:
22485 2016-06-16 Gyuyoung Kim <gyuyoung.kim@webkit.org>
22487 [EFL][GTK] LayoutTest doesn't run on Ubuntu 16.04
22488 https://bugs.webkit.org/show_bug.cgi?id=158141
22490 Reviewed by Michael Catanzaro.
22492 * Scripts/webkitpy/port/base.py: Detect php version in system, then use it.
22493 (Port._is_debian_php_version_7):
22494 (Port._debian_php_version):
22495 (Port._apache_config_file_name_for_platform):
22496 * efl/install-dependencies:
22497 * gtk/install-dependencies:
22499 2016-06-16 Filip Pizlo <fpizlo@apple.com>
22501 Baseline JIT should be concurrent
22502 https://bugs.webkit.org/show_bug.cgi?id=158755
22504 Reviewed by Geoffrey Garen.
22506 Need to disable concurrent JIT when running profiler tests. We should have been doing this
22509 * Scripts/run-jsc-stress-tests:
22511 2016-06-16 Per Arne Vollan <pvollan@apple.com>
22513 [Win] Accessibility implementation unable to recurse through document (sometimes) to find named elements
22514 https://bugs.webkit.org/show_bug.cgi?id=140798
22516 Reviewed by Brent Fulgham.
22518 Make sure layout is up-to-date before trying to find named elements.
22520 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
22521 (AccessibilityController::rootElement):
22523 2016-06-16 Chris Dumez <cdumez@apple.com>
22525 Unreviewed, rolling out r202002 and r202111.
22527 Ryosuke says this was a JSBench regression on iOS
22529 Reverted changesets:
22531 "Make HashMap and HashSet work with Refs"
22532 https://bugs.webkit.org/show_bug.cgi?id=158638
22533 http://trac.webkit.org/changeset/202002
22535 "Improve HashMap and HashSet support for Ref"
22536 https://bugs.webkit.org/show_bug.cgi?id=158789
22537 http://trac.webkit.org/changeset/202111
22539 2016-06-15 Simon Fraser <simon.fraser@apple.com>
22541 [iOS WK2] On iPad, indirect focussing of a text field doesn't always scroll to the correct location
22542 https://bugs.webkit.org/show_bug.cgi?id=158828
22544 Reviewed by Enrica Casucci.
22546 Expose "forceIPadStyleZoomOnInputFocus" on UIScriptController, which allows iPad-style
22547 zooming behavior on <input> focus in the iPhone simulator, which is used for testing.
22549 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
22550 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
22551 (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
22552 (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
22553 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
22554 * WebKitTestRunner/ios/TestControllerIOS.mm:
22555 (WTR::TestController::platformResetStateToConsistentValues):
22556 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
22557 (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
22558 (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
22560 2016-06-15 Sam Weinig <sam@webkit.org>
22562 Forward/Back keyboard shortcuts need to flip for RTL
22563 https://bugs.webkit.org/show_bug.cgi?id=158823
22564 <rdar://problem/25975359>
22566 Reviewed by Darin Adler.
22568 Add tests for flipping the behavior of command-left and command-right
22571 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22572 * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Added.
22573 (-[CommandBackForwardOffscreenWindow isKeyWindow]):
22574 (-[CommandBackForwardOffscreenWindow isVisible]):
22575 (simulateCommandArrow):
22576 (WebKit2_CommandBackForwardTest::SetUp):
22577 (WebKit2_CommandBackForwardTestWKView::didFinishLoadForFrame):
22578 (WebKit2_CommandBackForwardTestWKView::SetUp):
22579 (WebKit2_CommandBackForwardTestWKView::loadFiles):
22580 (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]):
22581 (WebKit2_CommandBackForwardTestWKWebView::SetUp):
22582 (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
22584 2016-06-15 Tim Horton <timothy_horton@apple.com>
22586 Expose _shouldExpandContentToViewHeightForAutoLayout SPI on WKWebView
22587 https://bugs.webkit.org/show_bug.cgi?id=158824
22588 <rdar://problem/23713857>
22590 Reviewed by Simon Fraser.
22592 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
22593 (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
22594 (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
22595 (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
22597 Add a test for _shouldExpandContentToViewHeightForAutoLayout.
22599 2016-06-13 Simon Fraser <simon.fraser@apple.com>
22601 [iOS WK2] Make it possible to test the Next/Previous buttons in the keyboard accessory bar
22602 https://bugs.webkit.org/show_bug.cgi?id=158714
22604 Reviewed by Enrica Casucci.
22606 Add UIScriptController.keyboardAccessoryBar{Next,Previous} and hook it up to the WKContentView
22607 method that gets called from UIKit.
22609 Add a test that exercises it.
22611 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
22612 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
22613 (WTR::UIScriptController::keyboardAccessoryBarNext):
22614 (WTR::UIScriptController::keyboardAccessoryBarPrevious):
22615 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
22616 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
22617 (WTR::UIScriptController::keyboardAccessoryBarNext):
22618 (WTR::UIScriptController::keyboardAccessoryBarPrevious):
22620 2016-06-15 Sam Weinig <sam@webkit.org>
22622 Improve HashMap and HashSet support for Ref
22623 https://bugs.webkit.org/show_bug.cgi?id=158789
22625 Reviewed by Chris Dumez.
22627 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
22628 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
22629 Add more cases to WTF_HashMap.Ref_Key, WTF_HashMap.Ref_Value and WTF_HashSet.Ref
22631 2016-06-15 Aakash Jain <aakash_jain@apple.com>
22633 Too much log data generated during layout-tests on iOS Simulator
22634 https://bugs.webkit.org/show_bug.cgi?id=158751
22636 Reviewed by Alexey Proskuryakov.
22638 * Scripts/webkitpy/port/ios.py:
22639 (IOSSimulatorPort.developer_dir): memoized the property so that it is not called
22642 2016-06-15 Per Arne Vollan <pvollan@apple.com>
22644 [Win][CMake] Changes in WebKit options are not reflected in incremental builds.
22645 https://bugs.webkit.org/show_bug.cgi?id=158727
22647 Reviewed by Alex Christensen.
22649 Delete CMake cache file if WebKit options have been modified.
22651 * Scripts/build-webkit:
22652 * Scripts/webkitdirs.pm:
22653 (shouldRemoveCMakeCache):
22655 2016-06-15 Romain Bellessort <romain.bellessort@crf.canon.fr>
22657 Enabling Shadow DOM for all platforms
22658 https://bugs.webkit.org/show_bug.cgi?id=158738
22660 Reviewed by Ryosuke Niwa.
22662 Removed Shadow DOM from options (enabled by default)
22664 * Scripts/webkitperl/FeatureList.pm:
22665 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
22667 2016-06-15 Per Arne Vollan <pvollan@apple.com>
22669 [Win] The test accessibility/selected-text-range-aria-elements.html is failing.
22670 https://bugs.webkit.org/show_bug.cgi?id=158732
22672 Reviewed by Brent Fulgham.
22674 Implement selectedTextRange() method.
22676 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
22677 (AccessibilityUIElement::selectedTextRange):
22679 2016-06-15 Per Arne Vollan <pvollan@apple.com>
22681 [Win] MiniBrowser is not DPI aware.
22682 https://bugs.webkit.org/show_bug.cgi?id=158733
22684 Reviewed by Brent Fulgham.
22686 Call Win32 api function to let Windows know that we will scale the contents ourselves.
22688 * MiniBrowser/win/WinMain.cpp:
22691 2016-06-15 Per Arne Vollan <pvollan@apple.com>
22693 Unreviewed: add new email address to contributors.json.
22695 * Scripts/webkitpy/common/config/contributors.json:
22697 2016-06-14 Keith Miller <keith_miller@apple.com>
22699 JSBench should use geometric mean
22700 https://bugs.webkit.org/show_bug.cgi?id=158775
22702 Reviewed by Mark Lam.
22704 For some reason JSBench was using algebraic mean. Since each test
22705 is pretty substantially different it should use geometric mean
22708 * Scripts/run-jsc-benchmarks:
22710 2016-06-14 Alexey Proskuryakov <ap@apple.com>
22712 Debug crash logs are not fully symbolicated on Yosemite
22713 https://bugs.webkit.org/show_bug.cgi?id=158760
22715 Reviewed by Darin Adler.
22717 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Don't enable dSYM generation
22718 for debug builds on Yosemite.
22720 2016-06-14 Alexey Proskuryakov <ap@apple.com>
22722 Tests don't work in iOS Simulator when ASan is enabled
22723 https://bugs.webkit.org/show_bug.cgi?id=158726
22725 Reviewed by David Kilzer.
22727 * Scripts/webkitpy/port/driver.py:
22728 (Driver._setup_environ_for_driver): Added a FIXME.
22729 * Scripts/webkitpy/port/ios.py:
22730 (IOSSimulatorPort.setup_environ_for_server): Don't try to insert a dylib built for
22731 simulator into LayoutTestRelay, which is a macOS tool.
22733 2016-06-14 Aakash Jain <aakash_jain@apple.com>
22735 Continuous "Reentrancy avoided" error messages in run-webkit-tests if Simulator quits unexpectedly
22736 https://bugs.webkit.org/show_bug.cgi?id=158756
22738 Reviewed by Alexey Proskuryakov.
22740 * Scripts/webkitpy/xcode/simulator.py:
22741 (Simulator.wait_until_device_is_booted): If checking Simulator boot state fails, verify if
22742 the "simulator device" is still in booted state. Since we ensured that simulator device
22743 was in booted state earlier in this method, this indicates that simulator device has shut down
22746 2016-06-14 David Kilzer <ddkilzer@apple.com>
22748 Follow-up fix #2: REGRESSION (r202020): El Capitan CMake Debug build broken
22749 <https://webkit.org/b/158743>
22751 Unreviewed build fix.
22753 * DumpRenderTree/PlatformMac.cmake: Fix silly typo.
22755 2016-06-14 Aakash Jain <aakash_jain@apple.com>
22757 Too much log data generated during layout-tests on iOS Simulator
22758 https://bugs.webkit.org/show_bug.cgi?id=158751
22760 Reviewed by Alexey Proskuryakov.
22762 * Scripts/webkitpy/port/ios.py:
22763 (IOSSimulatorPort._quit_ios_simulator): Do not use -v flag.
22764 (IOSSimulatorPort.clean_up_test_run): Ditto.
22765 (IOSSimulatorPort._createSimulatorApp): Ditto.
22767 2016-06-14 David Kilzer <ddkilzer@apple.com>
22769 Follow-up fix: REGRESSION (r202020): El Capitan CMake Debug build broken
22770 <https://webkit.org/b/158743>
22772 Unreviewed build fix.
22774 The fix in r202056 clobbered DumpRenderTree_SOURCES and
22775 TestNetscapePlugin_SOURCES from DumpRenderTree/CMakeLists.txt,
22776 so the build failure is now that we're not building the common
22779 Fix that by saving the common sources (which are all C++ source
22780 files) into *_Cpp_SOURCES lists first, then setting the compiler
22781 flags, then creating the final *_SOURCES lists.
22783 * DumpRenderTree/PlatformMac.cmake: Add
22784 ${TestNetscapePlugin_Cpp_SOURCES} to list that needs
22785 "-std=c++14" compiler switch.
22786 (TestNetscapePlugin_Cpp_SOURCES): Add new list for C++ source
22787 files for TestNetscapePlugin. Seeded with
22788 ${TestNetscapePlugin_SOURCES} from CMakeLists.txt.
22789 (TestNetscapePlugin_SOURCES): Add
22790 ${TestNetscapePlugin_Cpp_SOURCES} to the list of files.
22791 (DumpRenderTree_Cpp_SOURCES): Seed list for C++ source files
22792 with ${DumpRenderTree_SOURCES} from CMakeLists.txt.
22793 (DumpRenderTree_SOURCES): Reformat and sort source lists.
22795 2016-06-14 David Kilzer <ddkilzer@apple.com>
22797 REGRESSION (r202020): El Capitan CMake Debug build broken
22798 <https://webkit.org/b/158743>
22800 Reviewed by Alex Christensen.
22802 The bug was that pure C++ source files (and Objective-C source
22803 files) were being compiled as Objective-C++ source files. This
22804 is obviously incorrect, so the fix was to split out the list of
22805 source files by language, then define compiler switches based on
22808 * DumpRenderTree/PlatformMac.cmake: Replace add_definitions()
22809 with separate foreach loops that set compiler flags based on
22810 each source file's type.
22811 (TestNetscapePlugin_ObjCpp_SOURCES): Rename from
22812 TestNetscapePlugin_SOURCES.
22813 (TestNetscapePlugin_SOURCES): Create based on
22814 ${TestNetscapePlugin_ObjCpp_SOURCES}.
22815 (DumpRenderTree_ObjC_SOURCES): Split from DumpRenderTree_SOURCES.
22816 (DumpRenderTree_Cpp_SOURCES): Ditto.
22817 (DumpRenderTree_ObjCpp_SOURCES): Ditto.
22818 (DumpRenderTree_SOURCES): Create from above three lists.
22820 2016-06-14 Lucas Forschler <lforschler@apple.com>
22822 <rdar://problem/26685782>
22823 Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
22825 Rubber-stamped by Jessie Berlin.
22827 * Scripts/copy-webkitlibraries-to-product-directory:
22829 2016-06-14 Youenn Fablet <youenn.fablet@crf.canon.fr>
22831 Activate CMake export compile commands option
22832 https://bugs.webkit.org/show_bug.cgi?id=158734
22834 Reviewed by Alex Christensen.
22836 * Scripts/webkitdirs.pm:
22837 (generateBuildSystemFromCMakeProject): Activating this option for all CMake builds.
22838 This allows using ymcd for WebKit hacking.
22840 2016-06-14 David Kilzer <ddkilzer@apple.com>
22842 Modernize DumpRenderTreeMac.h
22843 <https://webkit.org/b/158721>
22845 Reviewed by Andy Estes.
22847 * DumpRenderTree/mac/DumpRenderTreeMac.h:
22848 - Update copyright.
22850 - Use #pragma once.
22851 - Use OBJC_CLASS macro.
22853 2016-06-13 David Kilzer <ddkilzer@apple.com>
22855 False-positive over-release of WebView in destroyWebViewAndOffscreenWindow() in DumpRenderTree.mm
22856 <https://webkit.org/b/158716>
22858 Reviewed by Andy Estes.
22860 * DumpRenderTree/mac/DumpRenderTree.mm:
22861 (destroyWebViewAndOffscreenWindow): Change this function to take
22862 a WebView, and assert that it's the same as [mainFrame webView].
22863 (dumpRenderTree): Pass 'webView' into
22864 destroyWebViewAndOffscreenWindow().
22865 * DumpRenderTree/mac/DumpRenderTreeMac.h:
22866 (createWebViewAndOffscreenWindow): Add NS_RETURNS_RETAINED since
22867 this function returns a +1 WebView. Declare this method only for
22868 Objective-C[++] source.
22870 2016-06-13 Sam Weinig <sam@webkit.org>
22872 Make HashMap and HashSet work with Refs
22873 https://bugs.webkit.org/show_bug.cgi?id=158638
22875 Reviewed by Darin Adler.
22877 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
22878 (TestWebKitAPI::TEST):
22879 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
22880 (TestWebKitAPI::TEST):
22881 Add tests for using Refs in HashMaps (both as key and value) and HashSets.
22883 2016-06-13 Mark Lam <mark.lam@apple.com>
22885 Add a mechanism for collecting LLINT stats.
22886 https://bugs.webkit.org/show_bug.cgi?id=158668
22888 Reviewed by Filip Pizlo.
22890 * DumpRenderTree/mac/DumpRenderTree.mm:
22891 (DumpRenderTreeMain):
22893 2016-06-13 Romain Bellessort <romain.bellessort@crf.canon.fr>
22895 [GTK] Enabling Shadow DOM by default
22896 https://bugs.webkit.org/show_bug.cgi?id=158686
22898 Reviewed by Carlos Garcia Campos.
22900 Added support for enabling Shadow DOM by default for GTK.
22901 Changed GTK test expectations for fast/shadow-dom tests (most tests
22904 * Scripts/webkitperl/FeatureList.pm:
22906 2016-06-12 Aakash Jain <aakash_jain@apple.com>
22908 run-safari/run-webkit-app fail to quit iOS simulator after Xcode installation
22909 https://bugs.webkit.org/show_bug.cgi?id=158651
22910 rdar://problem/26499824
22912 Reviewed by Daniel Bates.
22914 This change is to make our tools more robust. Sometimes run-safari/run-webkit-app fails
22915 to start the tests as one of the first thing these scripts do is to relaunch iOS Simulators,
22916 and in process call quitIOSSimulator. In case the Simulator is not registered in LaunchServices
22917 for some reason, quitIOSSimulator fails and the script stops. This change will make the scripts
22918 still continue when they fail to quit iOS Simuator, and modify the way Simulator is opened,
22919 so that Simulator is implicitly registered with LaunchServices while opening it.
22921 * Scripts/webkitdirs.pm:
22922 (relaunchIOSSimulator):
22923 Launch iOS Simulator using complete path. Partially reverting http://trac.webkit.org/changeset/184202.
22924 (quitIOSSimulator):
22925 Do not die if quitting ios Simulator fails, so that relaunchIOSSimulator can still
22926 attempt to launch the simulator.
22927 (waitUntilIOSSimulatorDeviceIsInState):
22930 2016-06-11 Myles C. Maxfield <mmaxfield@apple.com>
22932 Addressing post-review comments after r201978.
22933 https://bugs.webkit.org/show_bug.cgi?id=158649
22934 <rdar://problem/13258122>
22938 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
22939 (TestWebKitAPI::TEST):
22941 2016-06-11 Alexey Proskuryakov <ap@apple.com>
22943 Unreviewed leak fix after r201863.
22945 * DumpRenderTree/mac/DumpRenderTree.mm:
22946 (dumpFramesAsText):
22948 2016-06-11 Myles C. Maxfield <mmaxfield@apple.com>
22950 [Cocoa] Map commonly used Chinese Windows font names to names present on Cocoa operating systems
22951 https://bugs.webkit.org/show_bug.cgi?id=158649
22952 <rdar://problem/13258122>
22954 Reviewed by Darin Adler.
22956 * TestWebKitAPI/Tests/WTF/WTFString.h:
22957 (TestWebKitAPI::TEST):
22959 2016-06-10 Alex Christensen <achristensen@webkit.org>
22963 * TestWebKitAPI/PlatformMac.cmake:
22965 2016-06-10 Filip Pizlo <fpizlo@apple.com>
22967 Rename JSAir to Air.js
22969 Rubber stamped by Mark Lam.
22971 * Scripts/run-javascriptcore-tests:
22973 2016-06-10 Filip Pizlo <fpizlo@apple.com>
22975 JSC Stress Test failing: jsair-tests.yaml/test.js.ftl-eager-no-cjit
22976 https://bugs.webkit.org/show_bug.cgi?id=158571
22978 Reviewed by Keith Miller.
22980 Unskip the JSAir test.
22982 * Scripts/run-javascriptcore-tests:
22983 (runJSCStressTests):
22985 2016-06-10 Sam Weinig <sam@webkit.org>
22987 Re-disable the UserMedia tests which are timing out.
22989 They used to be accidentally disabled, due to not including
22990 the FeatureDefines correctly, but not we explicitly disable it.
22992 * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
22993 (TestWebKitAPI::TEST):
22995 2016-06-10 Alex Christensen <achristensen@webkit.org>
22997 Introduce WTF::UniqueRef
22998 https://bugs.webkit.org/show_bug.cgi?id=158596
23000 Reviewed by Brady Eidson.
23002 * TestWebKitAPI/CMakeLists.txt:
23003 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23004 * TestWebKitAPI/Tests/WTF/UniqueRef.cpp: Added.
23005 (TestWebKitAPI::B::B):
23006 (TestWebKitAPI::C::C):
23007 (TestWebKitAPI::function):
23008 (TestWebKitAPI::TEST):
23010 2016-06-10 Sam Weinig <sam@webkit.org>
23012 Refactor TestWebKitAPI to allow just testing WTF
23013 https://bugs.webkit.org/show_bug.cgi?id=158625
23015 Reviewed by Tim Horton.
23017 Extract all the WTF tests into a new target to allow a faster build / test / fix
23018 cycle when working on WTF bugs and features.
23020 By calling `run-api-tests --wtf-only`, you don't need to have a build of JavaScriptCore/WebCore/etc
23021 to test WTF only changes.
23023 * Scripts/build-api-tests:
23024 * Scripts/run-api-tests:
23027 Add new options to build-api-tests and run-api-tests to only build/run the WTF test runner.
23029 * TestWebKitAPI/CMakeLists.txt:
23030 * TestWebKitAPI/Configurations/TestWTF.xcconfig: Added.
23031 * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Added.
23032 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23033 Add two new targets, TestWTFLibrary which contains all the WTF tests, and TestWTF,
23034 the test runner that runs the WTF tests.
23036 * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
23037 Use Utilities.h rather than PlatformUtilities.h.
23039 * TestWebKitAPI/Utilities.h: Added.
23040 * TestWebKitAPI/PlatformUtilities.h:
23041 * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
23042 * TestWebKitAPI/cocoa/UtilitiesCocoa.mm: Added.
23043 Move the sleep and run functions into a new Utilities.h/cpp file. This file contains utilities
23044 that don't depend on anything in the WebKit project.
23046 2016-06-10 Brady Eidson <beidson@apple.com>
23048 REGRESSION(r201928?) API test WTF.StringOperators failing
23049 https://bugs.webkit.org/show_bug.cgi?id=158623
23051 Unreviewed, but buddy coded with Alex Christensen.
23053 * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
23054 (TestWebKitAPI::LifetimeLogger::fullName): Only one file in all of TestWebKitAPI is allowed
23055 to use string concatenation, otherwise the linker will mess up on the symbol related to
23056 this bizarre WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING macro expansion.
23058 2016-06-10 Brady Eidson <beidson@apple.com>
23060 WTF_CrossThreadTask.Basic fails in all non mac ports.
23061 https://bugs.webkit.org/show_bug.cgi?id=158612
23063 Reviewed by Alex Christensen.
23065 The test is very sensitive to argument evaluation order which is explicitly undefined in C++.
23067 Instead, we should just count the appropriate events to forget their order.
23069 * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
23070 (TestWebKitAPI::LifetimeLogger::LifetimeLogger):
23071 (TestWebKitAPI::LifetimeLogger::~LifetimeLogger):
23072 (TestWebKitAPI::LifetimeLogger::isolatedCopy):
23073 (TestWebKitAPI::LifetimeLogger::fullName):
23074 (TestWebKitAPI::testFunction):
23075 (TestWebKitAPI::TEST):
23076 (TestWebKitAPI::LifetimeLogger::log): Deleted.
23077 (TestWebKitAPI::LifetimeLogger::takeLogStr): Deleted.
23079 2016-06-09 Alex Christensen <achristensen@webkit.org>
23081 Clean up Tools *.vcxproj after switching to CMake.
23083 * DumpRenderTree/DumpRenderTree.sln: Removed.
23084 * DumpRenderTree/DumpRenderTree.vcxproj: Removed.
23085 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Removed.
23086 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
23087 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
23088 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h: Removed.
23089 * DumpRenderTree/PlatformWin.cmake:
23090 * DumpRenderTree/win/TestNetscapePlugin.def: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def.
23091 * DumpRenderTree/win/TestNetscapePlugin.rc: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc.
23092 * DumpRenderTree/win/resource.h: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h.
23093 * MiniBrowser/MiniBrowser.vcxproj: Removed.
23094 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Removed.
23095 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Removed.
23096 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Removed.
23097 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Removed.
23098 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Removed.
23099 * MiniBrowser/MiniBrowser.vcxproj/small.ico: Removed.
23100 * MiniBrowser/win/CMakeLists.txt:
23101 * MiniBrowser/win/MiniBrowser.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico.
23102 * MiniBrowser/win/MiniBrowser.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc.
23103 * MiniBrowser/win/MiniBrowserLib.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc.
23104 * MiniBrowser/win/MiniBrowserLibResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h.
23105 * MiniBrowser/win/MiniBrowserResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h.
23106 * MiniBrowser/win/small.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/small.ico.
23107 * WebKitTestRunner/WebKitTestRunner.sln: Removed.
23108 * win/DLLLauncher/DLLLauncherWinCairo.props: Removed.
23110 2016-06-09 Zalan Bujtas <zalan@apple.com>
23112 Add testing support for 3x device scale factor.
23113 https://bugs.webkit.org/show_bug.cgi?id=158597
23115 Reviewed by Simon Fraser.
23117 Set 3x device scale factor on the test canvas when the test url is prefixed with hidpi-3x-.
23119 * DumpRenderTree/mac/DumpRenderTree.mm:
23120 (changeWindowScaleIfNeeded):
23121 * WebKitTestRunner/TestController.cpp:
23122 (WTR::TestController::updateWindowScaleForTest):
23123 * WebKitTestRunner/TestOptions.cpp:
23124 (WTR::deviceScaleFactorForTest):
23125 (WTR::TestOptions::TestOptions):
23126 (WTR::isHiDPITestPath): Deleted.
23127 * WebKitTestRunner/TestOptions.h:
23129 2016-06-09 Michael Catanzaro <mcatanzaro@igalia.com>
23131 Add comments to clarify feature enablement
23132 https://bugs.webkit.org/show_bug.cgi?id=158567
23134 Reviewed by Alex Christensen.
23136 * Scripts/webkitperl/FeatureList.pm:
23138 2016-06-09 Filip Pizlo <fpizlo@apple.com>
23140 Unreviewed, skip jsair tests while we figure out the debug timeouts.
23142 * Scripts/run-javascriptcore-tests:
23143 (runJSCStressTests):
23145 2016-06-09 Commit Queue <commit-queue@webkit.org>
23147 Unreviewed, rolling out r201815.
23148 https://bugs.webkit.org/show_bug.cgi?id=158570
23150 This broke the cmake build. (Requested by lforschler on
23153 Reverted changeset:
23155 "Teach cmake about libWebKitSystemInterfaceOSX10.12"
23156 http://trac.webkit.org/changeset/201815
23158 2016-06-09 Brady Eidson <beidson@apple.com>
23160 Greatly simplify CrossThreadTask.h.
23161 https://bugs.webkit.org/show_bug.cgi?id=158542
23163 Reviewed by Darin Adler.
23165 * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
23166 (TestWebKitAPI::TEST):
23168 2016-06-09 Chris Dumez <cdumez@apple.com>
23170 Unreviewed, rolling out r201836, r201845, and r201848.
23172 Looks like a 1-2% PLT regression on iOS
23174 Reverted changesets:
23176 "[JSC] Change some parameters based on a random search"
23177 https://bugs.webkit.org/show_bug.cgi?id=158514
23178 http://trac.webkit.org/changeset/201836
23180 "Tempory fix for the debug bots"
23181 http://trac.webkit.org/changeset/201845
23183 "Change thresholdForOptimizeSoon to match
23184 thresholdForOptimizeAfterWarmUp"
23185 http://trac.webkit.org/changeset/201848
23187 2016-06-09 Michael Saboff <msaboff@apple.com>
23189 WebKitTestRunner and DumpRenderTree do not handle dangling surrogate characters
23190 https://bugs.webkit.org/show_bug.cgi?id=154863
23192 Reviewed by Alexey Proskuryakov.
23194 Added a non-strict verions of WKStringGetUTF8CString() that will handle dangling
23195 surrogates. Changed the extraction of inner text from frames in DumpRenderTree
23196 to use the new WKStringGetUTF8CStringNonStrict() function instead of NSString
23197 conversion since NSString doesn't have a way to handle dangling surrogates.
23198 The code added in DumpRenderTree matches what was changed in WebKitTestRunner.
23200 * DumpRenderTree/mac/DumpRenderTree.mm:
23201 (dumpFramesAsText):
23202 * WebKitTestRunner/StringFunctions.h:
23203 (WTR::toWTFString):
23205 2016-06-08 Hunseop Jeong <hs85.jeong@samsung.com>
23207 Try to fix the EFL build.
23211 * TestWebKitAPI/CMakeLists.txt:
23213 2016-06-08 Alex Christensen <achristensen@webkit.org>
23217 * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
23219 2016-06-08 Alex Christensen <achristensen@webkit.org>
23223 * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
23224 (BitmapContext::createByAdoptingBitmapAndContext):
23225 (BitmapContext::~BitmapContext):
23227 2016-06-08 Benjamin Poulain <benjamin@webkit.org>
23229 [JSC] Change some parameters based on a random search
23230 https://bugs.webkit.org/show_bug.cgi?id=158514
23232 Reviewed by Filip Pizlo.
23234 * Scripts/run-jsc-stress-tests:
23236 2016-06-08 Aakash Jain <aakash_jain@apple.com>
23238 tests fail if display sleeps while run-webkit-tests is running
23239 https://bugs.webkit.org/show_bug.cgi?id=153919
23241 Reviewed by Alexey Proskuryakov.
23243 * DumpRenderTree/mac/LayoutTestHelper.m:
23244 (releaseSleepAssertions): Release both Display sleep and System sleep assertions.
23245 (addSleepAssertions): Add sleep assertion for both Display sleep and System sleep.
23247 2016-06-08 Lucas Forschler <lforschler@apple.com>
23249 Reverted changeset 201814.
23251 * Scripts/copy-webkitlibraries-to-product-directory:
23253 2016-06-08 Per Arne Vollan <pvollan@apple.com>
23255 [Win] Shadow DOM tests are failing.
23256 https://bugs.webkit.org/show_bug.cgi?id=158524
23258 Reviewed by Brent Fulgham.
23260 Enable Shadow DOM when running tests.
23262 * DumpRenderTree/win/DumpRenderTree.cpp:
23263 (resetWebPreferencesToConsistentValues):
23265 2016-06-08 Lucas Forschler <lforschler@apple.com>
23267 Teach cmake about libWebKitSystemInterfaceOSX10.12
23268 This patch also removes duplicated logic inside DumpRenderTree/PlatformMac.cmake
23270 Rubber-stamped by Alex Christensen.
23272 * DumpRenderTree/PlatformMac.cmake:
23273 * WebKitTestRunner/PlatformMac.cmake:
23275 2016-06-07 Lucas Forschler <lforschler@apple.com>
23277 <rdar://problem/26685782>
23278 Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
23280 Rubber-stamped by Jessie Berlin.
23282 * Scripts/copy-webkitlibraries-to-product-directory:
23284 2016-06-08 Aakash Jain <aakash_jain@apple.com>
23286 Don't try to cleanup non-existing ios Simulators
23287 https://bugs.webkit.org/show_bug.cgi?id=158510
23289 Reviewed by Alexey Proskuryakov.
23291 * Scripts/webkitpy/port/ios.py:
23292 (IOSSimulatorPort.clean_up_test_run):
23293 Check if simulator exists before trying to clean it up.
23295 2016-06-08 Brady Eidson <beidson@apple.com>
23297 Try to fix the Windows build.
23301 * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
23302 (TestWebKitAPI::LifetimeLogger::log):
23303 (TestWebKitAPI::LifetimeLogger::takeLogStr):
23304 (TestWebKitAPI::testFunction):
23305 (TestWebKitAPI::TEST):
23306 (TestWebKitAPI::log): Deleted. (VS was seeing it as a dupe symbol)
23307 (TestWebKitAPI::takeLogStr): Deleted. (VS was seeing it as a dupe symbol)
23309 2016-06-08 Brady Eidson <beidson@apple.com>
23311 Make CrossThreadCopier more efficient (fewer copies!).
23312 https://bugs.webkit.org/show_bug.cgi?id=158456
23314 Reviewed by Alex Christensen.
23316 * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
23317 (TestWebKitAPI::TEST):
23319 2016-06-07 Filip Pizlo <fpizlo@apple.com>
23321 Add result validation to JSAir
23322 https://bugs.webkit.org/show_bug.cgi?id=158493
23324 Reviewed by Saam Barati.
23328 * Scripts/run-javascriptcore-tests:
23329 (runJSCStressTests):
23331 2016-06-08 Brady Eidson <beidson@apple.com>
23333 Add an API test that confirms object constructor/destructor calls during creation of a CrossThreadTask.
23334 https://bugs.webkit.org/show_bug.cgi?id=158528
23336 Reviewed by Alex Christensen.
23338 * TestWebKitAPI/CMakeLists.txt:
23339 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23340 * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp: Added.
23341 (TestWebKitAPI::log):
23342 (TestWebKitAPI::takeLogStr):
23343 (TestWebKitAPI::LifetimeLogger::LifetimeLogger):
23344 (TestWebKitAPI::LifetimeLogger::~LifetimeLogger):
23345 (TestWebKitAPI::LifetimeLogger::isolatedCopy):
23346 (TestWebKitAPI::testFunction):
23347 (TestWebKitAPI::TEST):
23349 2016-06-08 Konstantin Tokarev <annulen@yandex.ru>
23351 TestWebKitAPI: Removed redunandant check PLATFORM(GTK) && !defined(BUILDING_WEBKIT2__)
23352 https://bugs.webkit.org/show_bug.cgi?id=158521
23354 Reviewed by Carlos Garcia Campos.
23356 * TestWebKitAPI/config.h:
23358 2016-06-07 Carlos Garcia Campos <cgarcia@igalia.com>
23360 [GTK] Use a longer timeout for glib unit tests
23361 https://bugs.webkit.org/show_bug.cgi?id=158476
23363 Reviewed by Darin Adler.
23365 The timeout is supposed to be per test case, but in the case of GLib tests it affects all the tests cases of the
23366 same test program. Some test programs like TestLoaderClient, that have a lot of test cases, often time out in
23367 the bots because the timeout is not enough to run all the tests cases. So, we should use a longer timeout for
23370 * Scripts/run-gtk-tests:
23371 (TestRunner._run_test_glib):
23373 2016-06-07 Keith Rollin <krollin@apple.com>
23375 Remove all uses of PassRefPtr in WTF
23376 https://bugs.webkit.org/show_bug.cgi?id=157596
23377 <rdar://problem/26234391>
23379 Reviewed by Chris Dumez.
23381 Update calls to interfaces that no longer take or return PassRefPtrs.
23383 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
23384 (TestWebKitAPI::stringFromUTF8):
23385 (TestWebKitAPI::TEST):
23387 2016-06-07 Per Arne Vollan <pvollan@apple.com>
23389 [Win] Imported markup insertion test is failing.
23390 https://bugs.webkit.org/show_bug.cgi?id=158477
23392 Reviewed by Darin Adler.
23394 Make sure the empty synchronous request is loaded after each test.
23396 * DumpRenderTree/win/DumpRenderTree.cpp:
23399 2016-06-06 Carlos Alberto Lopez Perez <clopez@igalia.com>
23401 REGRESSION(r201449) [GTK] ARMv7 build fails with libicudata.so.55: cannot open shared object file on gtkdoc-scangobj step.
23402 https://bugs.webkit.org/show_bug.cgi?id=158417
23404 Reviewed by Michael Catanzaro.
23406 The toolchain on armhf (ARMv7) seems unable to properly handle
23407 a shared library that doesn't link with anything.
23409 And libicudata is built by default in this way because it only
23410 contains static data.
23412 That makes icu unusable on armhf because the linker will be
23413 unable to resolve the libicudata dependencies.
23415 Most (if not all) distributions workaround this by linking
23416 libicudata with libc6, which is already a needed dependency for
23417 any of the other icu shared libraries.
23419 So import here the Debian patch fixing this issue. For further
23420 details check https://bugs.debian.org/653457
23422 * gtk/jhbuild.modules:
23423 * gtk/patches/icudata-stdlibs.patch: Added.
23425 2016-06-06 Per Arne Vollan <pvollan@apple.com>
23427 REGRESSION (r104174): 500+ tests failing on Windows
23428 https://bugs.webkit.org/show_bug.cgi?id=75965
23430 Reviewed by Michael Catanzaro.
23432 Reset WebView scale factors before running next test.
23434 * DumpRenderTree/win/DumpRenderTree.cpp:
23435 (resetWebViewToConsistentStateBeforeTesting):
23437 2016-06-04 Alexey Proskuryakov <ap@apple.com>
23439 REGRESSION (r201263): Some tests have become flaky timeouts.
23440 https://bugs.webkit.org/show_bug.cgi?id=157990
23442 Reviewed by Darin Adler.
23444 * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
23445 It is somewhat legitimate for WebContent to not respond to messages after the test
23446 is done; it can be e.g. re-doing a costly repaint. So, we should restart is silently,
23447 without making the current test fail.
23449 2016-06-03 Youenn Fablet <youenn.fablet@crf.canon.fr>
23451 [GTK] Update YouCompleteMe script to make all include paths absolute
23452 https://bugs.webkit.org/show_bug.cgi?id=158301
23454 Reviewed by Michael Catanzaro.
23456 Before this patch, some include paths were not made absolute.
23457 This could make YouCompleteMe plugin to fail extracting information or validating cpp files.
23459 * gtk/ycm_extra_conf.py:
23461 2016-06-03 Nael Ouedraogo <nael.ouedraogo@crf.canon.fr>
23463 Unreviewed: add myself to the committers list.
23465 * Scripts/webkitpy/common/config/contributors.json:
23467 2016-06-02 Per Arne Vollan <pvollan@apple.com>
23469 [Win] Fetch API tests are failing.
23470 https://bugs.webkit.org/show_bug.cgi?id=158296
23472 Reviewed by Alex Christensen.
23474 Enable Fetch API when running tests.
23476 * DumpRenderTree/win/DumpRenderTree.cpp:
23477 (resetWebPreferencesToConsistentValues):
23479 2016-06-02 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
23481 Really display failing JSC stress tests in buildbot dashboard
23482 https://bugs.webkit.org/show_bug.cgi?id=158324
23484 Reviewed by Alexey Proskuryakov.
23486 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
23487 (BuildbotCombinedQueueView.prototype.update): Correctly check for string membership in array.
23488 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
23489 (BuildbotIteration.prototype._parseData): Correctly check for string membership in array.
23490 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
23491 (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Correctly check for string
23492 membership in array.
23493 (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Ensure that the correct URL is
23494 generated after the first time.
23495 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
23496 (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Correctly check for string membership in array.
23498 2016-06-02 Michael Saboff <msaboff@apple.com>
23500 [iOS]: Some JSC stress tests fail running out of executable memory when the LLInt is disabled
23501 https://bugs.webkit.org/show_bug.cgi?id=158317
23503 Reviewed by Saam Barati.
23505 Added defaultNoNoLLIntRun variant to run the default tests with the exception of the no-llint
23508 * Scripts/run-jsc-stress-tests:
23510 2016-06-02 Aakash Jain <aakash_jain@apple.com>
23512 LayoutTests time out intermittently due to alert about reopening Simulator after it unexpectedly quit
23513 https://bugs.webkit.org/show_bug.cgi?id=158305
23515 Reviewed by Alexey Proskuryakov.
23517 * Scripts/webkitpy/port/ios.py:
23518 (IOSSimulatorPort.clean_up_test_run): Delete simulator's savedState directories during cleanup.
23520 2016-06-01 Brian Burg <bburg@apple.com>
23522 REGRESSION(r191907): Can't enter combining diacritic marks in Web Inspector fields
23523 https://bugs.webkit.org/show_bug.cgi?id=158227
23524 <rdar://problem/26232464>
23526 Reviewed by Alexey Proskuryakov.
23528 Add a regression test that runs on Mac only.
23530 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23531 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Added.
23532 (-[DummyNavigationDelegate webView:didFinishNavigation:]):
23534 * TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Added.
23536 2016-06-01 Chris Fleizach <cfleizach@apple.com>
23538 AX: iOS: VoiceOver can't access attachments in mail messages
23539 https://bugs.webkit.org/show_bug.cgi?id=158198
23541 Reviewed by Joanmarie Diggs.
23543 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
23544 (AccessibilityUIElement::stringForRange):
23545 (AccessibilityUIElement::attributedStringForRange):
23546 (AccessibilityUIElement::attributedStringRangeIsMisspelled):
23547 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
23548 (WTR::AccessibilityUIElement::attributedStringForRange):
23549 (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
23551 2016-06-01 Carlos Garcia Campos <cgarcia@igalia.com>
23553 Unreviewed. Mark GTK+ test /webkit2/WebKitWebInspectorServer/test-open-debugging-session as slow.
23555 It's timing out in the bots, but it seems to pass when running run-gtk-tests with no timeout. For GLib tests the
23556 timeout is applied per tester program not per test case, so we need to mark the whole test
23557 WebKit2Gtk/TestInspectorServer as slow.
23559 * Scripts/run-gtk-tests:
23561 (TestRunner._run_test_glib):
23563 2016-06-01 Carlos Garcia Campos <cgarcia@igalia.com>
23565 Unreviewed. Skip media permission request GTK+ unit tests.
23567 They are timing out in the bots.
23569 * Scripts/run-gtk-tests:
23572 2016-05-31 Jer Noble <jer.noble@apple.com>
23574 Yet another unreviewed build fix; move the closing brace of the namespace declaration inside
23577 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
23579 2016-05-31 Jer Noble <jer.noble@apple.com>
23581 Further unreviewed build fix; only run FullscreenTopContentInset test on Mac.
23583 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
23585 2016-05-31 Jer Noble <jer.noble@apple.com>
23587 Unreviewed build fix; only run FullscreetTopContentInset test on platforms
23588 where WK_API_ENABLED is set.
23590 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
23592 2016-05-31 Jer Noble <jer.noble@apple.com>
23594 REGRESSION (r201405): trailers.apple.com HUD is missing in fullscreen
23595 https://bugs.webkit.org/show_bug.cgi?id=158156
23596 <rdar://problem/26519589>
23598 Reviewed by Darin Adler.
23600 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23601 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Added.
23602 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Added.
23603 (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
23604 (TestWebKitAPI::TEST):
23606 2016-05-31 Jon Lee <jonlee@apple.com>
23608 Unreviewed: add myself to the reviewers list.
23610 * Scripts/webkitpy/common/config/contributors.json:
23612 2016-05-31 Carlos Alberto Lopez Perez <clopez@igalia.com>
23614 [GTK] Provide alternative mirror for the ICU tarball.
23615 https://bugs.webkit.org/show_bug.cgi?id=154530
23619 * gtk/jhbuild.modules: After r201449 the GTK+ ARM buildbot is having
23620 a hard time trying to download the ICU tarball from download.icu-project.org
23621 (which redirects to sourceforge and gives problems with something related to
23622 SSL). Provide this alternative mirror to make things working back.
23624 2016-05-31 Carlos Garcia Campos <cgarcia@igalia.com>
23626 [GTK] Test /webkit2/WebKitWebView/geolocation-permission-requests is failing since r201423
23627 https://bugs.webkit.org/show_bug.cgi?id=158200
23629 Reviewed by Philippe Normand.
23631 This is because geolocation is no longer allowed for non secure sites, like HTTP. In that case
23632 POSITION_UNAVAILABLE is returned without asking the API layer.
23634 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
23635 (testWebViewGeolocationPermissionRequests): Keep the HTTP case to check that it indeed returns
23636 POSITION_UNAVAILABLE and use HTTPS URLs to check permission requests are allowed or denied. Also stop using the
23637 document title, and use user script messages that are more reliable instead.
23639 2016-05-28 Aakash Jain <aakash_jain@apple.com>
23641 tests fail if display sleeps while run-webkit-tests is running
23642 https://bugs.webkit.org/show_bug.cgi?id=153919
23644 Reviewed by Darin Adler.
23646 * DumpRenderTree/mac/LayoutTestHelper.m:
23647 (addDisplaySleepAssertion): Use PreventUserIdleSystemSleep flag, same as set by caffeinate tool.
23649 2016-05-27 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
23651 Display failing JSC stress tests in buildbot dashboard
23652 https://bugs.webkit.org/show_bug.cgi?id=156595
23654 Reviewed by Alexey Proskuryakov.
23656 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
23657 (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
23658 (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
23659 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
23660 (BuildbotCombinedQueueView.prototype.update):
23661 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
23662 (BuildbotIteration):
23663 (BuildbotIteration.prototype._parseData):
23664 (BuildbotIteration.prototype.loadLayoutTestResults):
23665 (BuildbotIteration.prototype.):
23666 (BuildbotIteration.prototype.loadJavaScriptCoreTestResults):
23667 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
23668 (BuildbotQueueView.prototype._createLoadingIndicator):
23669 (BuildbotQueueView.prototype.):
23670 (BuildbotQueueView.prototype._onPopoverCopy):
23671 (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions):
23672 (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions):
23673 (BuildbotQueueView.prototype._addIterationHeadingToPopover):
23674 (BuildbotQueueView.prototype._testStepFailureDescription):
23675 (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount):
23676 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
23677 (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
23678 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
23679 (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
23680 (BuildbotTesterQueueView.prototype.update):
23681 (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
23682 (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions):
23683 (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted.
23684 (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted.
23685 (BuildbotTesterQueueView.prototype.): Deleted.
23686 (BuildbotTesterQueueView.prototype.content.oncopy): Deleted.
23687 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:
23688 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
23690 (MockBuildbot.prototype.buildPageURLForIteration):
23691 (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
23692 (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
23693 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
23694 (MockBuildbotQueue):
23695 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
23696 (MockBuildbotTestResults):
23697 (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
23698 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
23699 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
23701 2016-05-27 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
23703 Display failing JSC stress tests in buildbot dashboard
23704 https://bugs.webkit.org/show_bug.cgi?id=156595
23706 Reviewed by Alexey Proskuryakov.
23708 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
23709 (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Generate the URL for raw JSON output of
23711 (Buildbot.prototype.javaScriptCoreTestStdioURLForIteration): Generate the URL for human-readable stdio output
23713 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
23714 (BuildbotCombinedQueueView.prototype.update): Display JSC test results in popover.
23715 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
23716 (BuildbotIteration): Add javaScriptCoreTestResults variable.
23717 (BuildbotIteration.prototype.): Check for javascriptcore tests step.
23718 (BuildbotIteration.prototype.loadLayoutTestResults): Add comma at closing brace.
23719 (BuildbotIteration.prototype.loadJavaScriptCoreTestResults): Fetch JSON from Buildbot server.
23720 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
23721 (BuildbotQueueView.prototype._createLoadingIndicator): Reusable function.
23722 (BuildbotQueueView.prototype._onPopoverCopy): Reusable copy event handler to allow accurate copying of text
23724 (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Generates the popover bubble's
23725 inner HTML from the JSC failure data.
23726 (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Generate the popover bubble
23727 for JSC results and handle request failures.
23728 (BuildbotQueueView.prototype._testStepFailureDescription): Moved from subclass.
23729 (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount): Moved from subclass.
23730 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
23731 (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Parse JSON into a list of failing tests.
23732 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
23733 (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Instantiate PopoverTrackers for builds whose
23734 only failures are JSC tests.
23735 (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Use _onPopoverCopy.
23736 (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Use _createLoadingIndicator.
23737 (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted. Moved to superclass.
23738 (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted. Moved to superclass.
23739 (BuildbotTesterQueueView.prototype.content.oncopy): Deleted. Using superclass's reusable function as copy handler instead.
23740 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Add new script files.
23741 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Added.
23742 (MockBuildbot): Mocked version of Buildbot, only containing URL methods.
23743 (MockBuildbot.prototype.buildPageURLForIteration): Same as real Buildbot.js
23744 (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Points to local file containing JSON for test.
23745 (MockBuildbot.prototype.javaScriptCoreTestStdioURLForIteration): Same as real Buildbot.js
23746 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
23747 (MockBuildbotQueue): Use a MockBuildbot() instead of a string.
23748 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Added.
23749 (MockBuildbotTestResults): Mocked version of BuildbotTestResults.
23750 (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Sets the 'regressions' variable.
23751 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
23752 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Add four groups of tests.
23754 2016-05-27 Chris Dumez <cdumez@apple.com>
23756 WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables
23757 https://bugs.webkit.org/show_bug.cgi?id=158111
23759 Reviewed by Darin Adler.
23761 WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables.
23762 These are often used cross-thread and copying the captured lambda variables can be
23763 dangerous (e.g. we do not want to copy a String after calling isolatedCopy() upon
23766 * WebKitTestRunner/TestController.cpp:
23767 (WTR::TestController::decidePolicyForNavigationAction):
23769 2016-05-27 Brady Eidson <beidson@apple.com>
23771 Modern IDB: After closing a Netflix video, trying to watch it again fails.
23772 <rdar://problem/25092473> and https://bugs.webkit.org/show_bug.cgi?id=158160
23774 Reviewed by Alex Christensen.
23776 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23777 * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Added.
23778 * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Added.
23779 * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Added.
23781 2016-05-27 Joanmarie Diggs <jdiggs@igalia.com>
23783 AX: [ATK] accessibility/gtk/no-notification-for-unrendered-iframe-children.html began failing after r201416
23784 https://bugs.webkit.org/show_bug.cgi?id=158152
23786 Reviewed by Chris Fleizach.
23788 The failure is actually a bug fix because only one child is being added, but two
23789 notifications were being emitted. Now there is only one notification. To verify
23790 this was the case, we really should examine the child reportedly being added. That
23791 child is the ATK event's any_data, so pass along that child to the listener.
23793 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
23795 2016-05-26 Alex Christensen <achristensen@webkit.org>
23797 Expose content extension failure error codes in SPI
23798 https://bugs.webkit.org/show_bug.cgi?id=158095
23799 rdar://problem/26475651
23801 Reviewed by Anders Carlsson.
23803 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
23806 Add tests that use the new enum.
23808 2016-05-27 Carlos Garcia Campos <cgarcia@igalia.com>
23810 New intl-numberformat.js test fails on many Linux platforms
23811 https://bugs.webkit.org/show_bug.cgi?id=154530
23813 Reviewed by Darin Adler.
23815 The test is actually failing because of a bug in the icu version installed in the bots, using a newer version of
23816 icu makes the tests pass and explains why it worked for some people. So, let's add icu 55.1 to the internal
23817 jhbuild to ensure JSC tests pass in the bots no matter what the icu version installed is.
23819 * gtk/jhbuild.modules:
23821 2016-05-26 Yusuke Suzuki <utatane.tea@gmail.com>
23823 [JSC] Allow JSBench to use precise time
23824 https://bugs.webkit.org/show_bug.cgi?id=158050
23826 Reviewed by Geoffrey Garen.
23828 JSBench use `new Date().getTime()` without options and there is no way to use precise time.
23829 This patch modifies the JSBench code to inject the code taking the precise time.
23830 `currentTimeInMS` is given by the benchmerk harness and JSBench uses it.
23831 run-jsc-benchmark switches this function's implementation between `Date.now()` and
23832 testRunner's precise time one.
23834 While this patch modifies the code of JSBench, the last release of JSBench is Jan 2013 and
23835 the contents are not changed for a long time. As described in the original paper[1], the
23836 tests can be generated by using JSBench's record & replay system, but in that case, we can
23837 adopt this modification by changing the tool side.
23839 We also add currentTimeInMS implementation in harness.js and u?rem.js directly.
23840 u?rem.js implementation is required when it is executed in u?rem.html without harness.
23841 And harness.js implementation is required when it is executed in the JSBench's harness.
23842 In these implementation, we follow the JetStream's time measuring function: performance.now(),
23843 preciseTime(), or Date.now().
23845 [1]: http://dl.acm.org/citation.cfm?id=2048119
23847 * Scripts/run-jsc-benchmarks:
23849 2016-05-26 Brent Fulgham <bfulgham@apple.com>
23851 Unreviewed test fix after r201427.
23852 https://bugs.webkit.org/show_bug.cgi?id=157423
23853 <rdar://problem/23751632>
23855 A debug assertion was firing during some test runs due to the Geolocation permission
23856 being turned off during the test. The timer logic was originally written to assert
23857 if the timer fired when permissions were disabled. But this is no longer valid,
23858 because we expect the Geolocation system to be active and become deactivated if the
23859 browsing context violates one of the security criteria.
23861 * DumpRenderTree/mac/UIDelegate.mm:
23862 (-[UIDelegate timerFired]): Remove invalid assertion.
23864 2016-05-26 Filip Pizlo <fpizlo@apple.com>
23866 ScopedLambda should have a lifetime story that makes sense to the compiler
23867 https://bugs.webkit.org/show_bug.cgi?id=158118
23869 Reviewed by Mark Lam.
23871 Added a test case. This test crashes before the fix and now it passes.
23873 * TestWebKitAPI/CMakeLists.txt:
23874 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23875 * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp: Added.
23876 (TestWebKitAPI::TEST):
23878 2016-05-26 Myles C. Maxfield <mmaxfield@apple.com>
23882 Rubber stamped by Lucas Forschler.
23884 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
23885 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
23887 2016-05-25 Anders Carlsson <andersca@apple.com>
23889 Get rid of WTF/Functional.h
23890 https://bugs.webkit.org/show_bug.cgi?id=158081
23892 Reviewed by Chris Dumez.
23894 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23895 * TestWebKitAPI/Tests/WTF/Functional.cpp: Removed.
23896 (TestWebKitAPI::returnFortyTwo): Deleted.
23897 (TestWebKitAPI::TEST): Deleted.
23898 (TestWebKitAPI::multiplyByTwo): Deleted.
23899 (TestWebKitAPI::multiplyByOneAndAHalf): Deleted.
23900 (TestWebKitAPI::multiply): Deleted.
23901 (TestWebKitAPI::subtract): Deleted.
23902 (TestWebKitAPI::A::A): Deleted.
23903 (TestWebKitAPI::A::f): Deleted.
23904 (TestWebKitAPI::A::addF): Deleted.
23905 (TestWebKitAPI::B::B): Deleted.
23906 (TestWebKitAPI::B::~B): Deleted.
23907 (TestWebKitAPI::B::ref): Deleted.
23908 (TestWebKitAPI::B::deref): Deleted.
23909 (TestWebKitAPI::B::f): Deleted.
23910 (TestWebKitAPI::B::g): Deleted.
23911 (TestWebKitAPI::Number::create): Deleted.
23912 (TestWebKitAPI::Number::~Number): Deleted.
23913 (TestWebKitAPI::Number::value): Deleted.
23914 (TestWebKitAPI::Number::Number): Deleted.
23915 (TestWebKitAPI::multiplyNumberByTwo): Deleted.
23917 2016-05-25 Daniel Bates <dabates@apple.com> and Brent Fulgham <bfulgham@apple.com>
23919 [WebSockets] No infrastructure for testing secure web sockets (wss)
23920 https://bugs.webkit.org/show_bug.cgi?id=157884
23921 <rdar://problem/26477197>
23923 Reviewed by Andy Estes.
23925 Add support to webkitpy to start and stop a secure Web Socket server running on port 9323
23926 using the certificate, private-key from file LayoutTests/http/conf/webkit-httpd.pem. Also
23927 teaches run-webkit-httpd to start and stop the Web Socket servers.
23929 Modify DumpRenderTree and WebKitTestRunner to understand a new testRunner method,
23930 'setAllowsAnySSLCertificate', which allows us to use the same self-signed test certificate
23931 we do for our HTTPS tests.
23933 * DumpRenderTree/TestRunner.cpp:
23934 (setAllowsAnySSLCertificateCallback):
23935 (TestRunner::setAllowsAnySSLCertificate):
23936 * DumpRenderTree/TestRunner.h:
23937 * DumpRenderTree/mac/DumpRenderTree.mm:
23938 (resetWebViewToConsistentStateBeforeTesting): Make sure we turn off the new flag between tests.
23939 * Scripts/run-webkit-httpd:
23940 (main): Start the websocket server at launch.
23941 * Scripts/webkitpy/layout_tests/controllers/manager.py:
23942 (Manager.__init__): Remove dead code.
23943 * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
23944 (PyWebSocket.__init__): Cleanup code.
23945 (PyWebSocket): Pass '--tls-client-ca' to start command.
23946 (PyWebSocket._prepare_config): Cleanups.
23947 * Scripts/webkitpy/port/base.py:
23948 (Port.to.start_http_server):
23950 (Port.to._extract_certificate_from_pem): Added.
23951 (Port.to._extract_private_key_from_pem): Added.
23952 (Port.to.start_websocket_server): Start secure socket server.
23953 (Port.to.stop_websocket_server): Stop secure socket server.
23954 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add new API.
23955 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
23956 (WTR::InjectedBundle::setAllowsAnySSLCertificate): Added.
23957 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
23958 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
23959 (WTR::TestRunner::setAllowsAnySSLCertificate): Added.
23960 * WebKitTestRunner/InjectedBundle/TestRunner.h:
23962 2016-05-25 Keith Miller <keith_miller@apple.com>
23964 run-jsc-benchmarks should use the new JSBench rather than look for it in the config file.
23965 https://bugs.webkit.org/show_bug.cgi?id=158077
23967 Reviewed by Mark Lam.
23969 Since we didn't have JSBench in the tree before we needed to lookup the path to it from
23970 benchmark config file. That's no longer the case so we should just fix it in the script.
23972 * Scripts/run-jsc-benchmarks:
23974 2016-05-24 Aakash Jain <aakash_jain@apple.com>
23976 Reorganize dashboard code: move code from _timeIntervalString to base class
23977 https://bugs.webkit.org/show_bug.cgi?id=158047
23978 rdar://problem/26457274
23980 Reviewed by Alexey Proskuryakov and Dean Johnson.
23982 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
23983 (BubbleQueueView.prototype._timeIntervalString): Moved core logic to base class so as to make it re-usable.
23984 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
23985 (QueueView.prototype._readableTimeString): Same.
23987 2016-05-24 Yusuke Suzuki <utatane.tea@gmail.com>
23989 [JSC][GTK][EFL] Allow run-jsc-benchmark to use WebKitTestRunner in EFL / GTK ports
23990 https://bugs.webkit.org/show_bug.cgi?id=158016
23992 Reviewed by Darin Adler.
23994 This patch easily allows run-jsc-benchmark to run WebKitTestRunner-based tests in GTK / EFL ports.
23995 This change encourages us to run tests with the browser-heap in nix environments.
23996 Two things are modified.
23998 1. Add a fall-back to look up the library path in GTK / EFL / JSCOnly environment.
24000 In GTK / EFL / JSCOnly ports, the hierarchy of the build directory is slightly different from Apple port.
24001 For example, the jsc bin locate at "WebKitBuild/XXX/Release/bin/jsc" and the lib path is "WebKitBuild/XXX/Release/lib"
24002 while the one of Apple port is "WebKitBuild/XXX/Release/jsc" and "WebKitBuild/XXX/Release/lib".
24003 And based on this library path, we configure the required environment variables to run WebKitTestRunner in GTK / EFL ports.
24005 2. Add --dependencies option to add dependent library paths.
24007 While Apple ports does not require any additional dependent library path, GTK and EFL ports require this path,
24008 typically WebKitBuild/DependenciesGTK and WebKitBuild/DependenciesEFL respectively. So we need to add such paths to LD_LIBRARY_PATH.
24009 Instead of adding platform options like --gtk / --efl, we add --dependencies option to add the additional dependent library paths.
24010 The platform options still require the build path to look up the dependent library directory. So we pass it directly through --dependencies.
24011 Multiple additional dependent library paths can be added by using --dependencies multiple times.
24013 By using these change, we can run benchmarks that require WebKitTestRunner in GTK / EFL ports (If you would like to run them in a headless manner, you can use xvbuf.).
24015 `Tools/Scripts/run-jsc-benchmarks baseline:WebKitBuild/baseline/Release/bin/WebKitTestRunner patched:WebKitBuild/patched/Release/bin/WebKitTestRunner --dependencies WebKitBuild/DependenciesGTK/Root/lib --js-bench`
24017 * Scripts/run-jsc-benchmarks:
24019 2016-05-20 Keith Miller <keith_miller@apple.com>
24020 We should have JSBench in PerformanceTests
24021 https://bugs.webkit.org/show_bug.cgi?id=157952
24023 Rubber-stamped by Saam Barati.
24025 This changes the runner to use the layout of the newest version of JSBench.
24027 * Scripts/run-jsc-benchmarks:
24029 2016-05-24 Chris Dumez <cdumez@apple.com>
24031 Use auto for some of our lambda function parameters
24032 https://bugs.webkit.org/show_bug.cgi?id=158001
24034 Reviewed by Darin Adler.
24036 Use auto for some of our lambda function parameters now that we build with c++14.
24038 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
24039 (WTR::InjectedBundle::willDestroyPage):
24041 2016-05-23 Brady Eidson <beidson@apple.com>
24043 check-webkit-style gets flags std::literals::chrono_literals as bad naming.
24044 https://bugs.webkit.org/show_bug.cgi?id=157969
24046 Reviewed by Alex Christensen.
24048 * Scripts/webkitpy/style/checkers/cpp.py:
24049 (check_identifier_name_in_declaration):
24050 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
24051 (WebKitStyleTest.test_names):
24053 2016-05-22 Alexey Proskuryakov <ap@apple.com>
24055 RELEASE_ASSERT(TestController::singleton().isCurrentInvocation(testInvocation)) is sometimes hit when running tests
24056 https://bugs.webkit.org/show_bug.cgi?id=157977
24057 rdar://problem/20874156
24059 Reviewed by David Kilzer.
24061 * WebKitTestRunner/TestInvocation.cpp:
24062 (WTR::TestInvocation::invoke): Be more certain to launch a new process when there was
24063 a timeout detected. If we don't, there is a chance that the process is not quite frozen,
24064 and will still send a response that we no longer expect.
24065 (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Print timeout details to stderr
24066 too, as stdout is not available, at least not in the case that I was observing.
24068 2016-05-22 Brady Eidson <beidson@apple.com>
24071 https://bugs.webkit.org/show_bug.cgi?id=157948
24073 Reviewed by Michael Catanzaro.
24075 * DumpRenderTree/mac/Configurations/Base.xcconfig:
24076 * MiniBrowser/Configurations/Base.xcconfig:
24077 * TestWebKitAPI/Configurations/Base.xcconfig:
24078 * WebKitTestRunner/Configurations/Base.xcconfig:
24080 2016-05-21 Aakash Jain <aakash_jain@apple.com>
24082 Simulator launch fails intermittently due to failure in checking simulator boot status
24083 https://bugs.webkit.org/show_bug.cgi?id=157965
24084 rdar://problem/26402404
24086 Reviewed by Alexey Proskuryakov.
24088 * Scripts/webkitpy/xcode/simulator.py:
24089 (Simulator.wait_until_device_is_booted): Ignore CalledProcessError exception while checking
24090 whether simulator has finished booting.
24092 2016-05-21 Dan Bernstein <mitz@apple.com>
24094 Silence warnings from svn propget when using newer versions of Subversion.
24095 https://bugs.webkit.org/show_bug.cgi?id=157879
24097 Reviewed by Daniel Bates.
24099 * Scripts/prepare-ChangeLog:
24100 (attributeCommand): Redirect svn propget stderr to /dev/null.
24101 * Scripts/svn-create-patch:
24102 (findMimeType): Ditto.
24104 2016-05-20 Ryosuke Niwa <rniwa@webkit.org>
24106 run-benchmark's results should contain Animometer's debug output
24107 https://bugs.webkit.org/show_bug.cgi?id=157941
24109 Reviewed by Stephanie Lewis.
24111 Modified the Animometer patch to store debug output and made benchmark_runner extract them together as a single array.
24112 The result can be dragged and dropped into Animometer's developer.html page.
24114 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
24115 (BenchmarkRunner._run_one_test): Parse JSON here instead of doing it in multiple call sites.
24116 (BenchmarkRunner._run_benchmark): Strip debugOutput from individual test result, and merge them together separately.
24117 * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:
24118 Modified the patch to store the debug output.
24119 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
24120 (ServerControl.render_POST): Fixed a bug that POST to /report results in 500 because getvalue is not defined
24121 when the request body is larger than a certain size on twisted.
24123 2016-05-20 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
24125 Use clearer names for JSON output of javascriptcore test results
24126 https://bugs.webkit.org/show_bug.cgi?id=157921
24128 Reviewed by Alexey Proskuryakov.
24130 "failures" and "apiTestResult" were somewhat ambiguous names.
24132 * Scripts/run-javascriptcore-tests:
24133 (runJSCStressTests): "failures" -> "stressFailures", "apiTestResult" -> "allApiTestsPassed".
24135 2016-05-20 Chris Dumez <cdumez@apple.com>
24137 Unreviewed, fix API test introduced in r201213.
24139 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
24140 (TestWebKitAPI::TEST):
24142 2016-05-20 Rawinder Singh <rawinder.singh-webkit@cisra.canon.com.au>
24144 Implement operator== for WeakPtr
24145 https://bugs.webkit.org/show_bug.cgi?id=157883
24147 Reviewed by Chris Dumez.
24149 Implement operator== and operator!= for WeakPtr and update code to use the operators.
24151 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
24152 (TestWebKitAPI::TEST):
24154 2016-05-19 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
24156 Add JSON results to 32-bit and CLoop JSC tests
24157 https://bugs.webkit.org/show_bug.cgi?id=157929
24159 Reviewed by Alexey Proskuryakov.
24161 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
24162 (RunLLINTCLoopTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
24163 (Run32bitJSCTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
24165 2016-05-19 Csaba Osztrogonác <ossy@webkit.org>
24167 Typo fix in import-test262-tests
24168 https://bugs.webkit.org/show_bug.cgi?id=157902
24170 Reviewed by Keith Miller.
24172 * Scripts/import-test262-tests:
24174 2016-05-19 Csaba Osztrogonác <ossy@webkit.org>
24176 [EFL] Fix the gst-libav build on ARM Thumb2 after r199649
24177 https://bugs.webkit.org/show_bug.cgi?id=157893
24179 Reviewed by Antonio Gomes.
24181 * efl/patches/gst-libav.patch:
24183 2016-05-19 Jer Noble <jer.noble@apple.com>
24185 REGRESSION(r200951): VideoControlsManager API tests time out
24186 https://bugs.webkit.org/show_bug.cgi?id=157896
24187 <rdar://problem/26326293>
24189 Reviewed by Eric Carlson.
24191 Explicitly disable user gesture requirements for playback.
24193 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
24194 (TestWebKitAPI::TEST):
24196 2016-05-19 Csaba Osztrogonác <ossy@webkit.org>
24198 Slow JSC stress tests times out in 32 bit debug mode
24199 https://bugs.webkit.org/show_bug.cgi?id=154964
24201 Reviewed by Michael Catanzaro.
24203 * Scripts/run-javascriptcore-tests:
24204 (runJSCStressTests): Pass through the --debug option.
24205 * Scripts/run-jsc-stress-tests: Increase the timeout for debug builds.
24207 2016-05-18 Aakash Jain <aakash_jain@apple.com>
24209 Remove underline from Status Bubbles on dashboard
24210 https://bugs.webkit.org/show_bug.cgi?id=157870
24211 rdar://problem/26332321
24213 Reviewed by Alexey Proskuryakov.
24215 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Reverted style
24216 change made in http://trac.webkit.org/r200880
24218 2016-05-18 Michael Saboff <msaboff@apple.com>
24220 r199812 broke test262
24221 https://bugs.webkit.org/show_bug.cgi?id=157595
24223 Reviewed by Filip Pizlo.
24225 Added a new run type, runOneLargeHeap, for tests that use a large amount of memory.
24226 This run type will not run with the --memory-limited option. Without that option,
24227 we'll only the default test variant.
24229 * Scripts/run-jsc-stress-tests:
24231 2016-05-18 Simon Fraser <simon.fraser@apple.com>
24233 REGRESSION (r200534) Command-+ no longer zooms pages
24234 https://bugs.webkit.org/show_bug.cgi?id=157826
24235 rdar://problem/26334636
24237 Reviewed by Dean Jackson.
24239 * DumpRenderTree/mac/DumpRenderTree.mm:
24240 (resetWebPreferencesToConsistentValues): Remove ENABLE() #ifdefs that do nothing (see http://webkit.org/b/157828).
24242 2016-05-18 Joanmarie Diggs <jdiggs@igalia.com>
24244 [GTK] accessibility/meter-element.html is failing
24245 https://bugs.webkit.org/show_bug.cgi?id=115633
24247 Reviewed by Chris Fleizach.
24249 Implement AccessibilityUIElement::valueDescription() and add mapping
24250 from ATK_ROLE_LEVEL_BAR to AXProgressIndicator.
24252 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
24253 (WTR::AccessibilityUIElement::valueDescription):
24255 2016-05-18 Brady Eidson <beidson@apple.com>
24257 Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported).
24258 https://bugs.webkit.org/show_bug.cgi?id=157823
24260 Reviewed by Alex Christensen.
24262 * DumpRenderTree/mac/TestRunnerMac.mm:
24263 (TestRunner::clearAllDatabases):
24265 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
24266 (WTR::TestRunner::clearAllDatabases):
24268 * WebKitTestRunner/TestInvocation.cpp:
24269 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
24271 2016-05-18 Joanmarie Diggs <jdiggs@igalia.com>
24273 AX: [ATK] Use WebCore Accessibility's AccessibilityText for AtkObject name and description
24274 https://bugs.webkit.org/show_bug.cgi?id=157822
24276 Reviewed by Chris Fleizach.
24278 Fix AccessibilityUIElement::helpText() so that it returns an empty string rather than
24279 nullptr upon failure.
24281 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
24282 (WTR::AccessibilityUIElement::helpText):
24284 2016-05-17 Beth Dakin <bdakin@apple.com>
24286 Make handleAcceptedCandidate a public function
24287 https://bugs.webkit.org/show_bug.cgi?id=157763
24288 -and corresponding-
24289 rdar://problem/26206397
24291 Reviewed by Tim Horton.
24293 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24294 * TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Added.
24295 * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Added.
24296 (-[DoNotLeakWebView dealloc]):
24297 (-[DoNotLeakWebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
24298 (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
24299 (TestWebKitAPI::TEST):
24301 2016-05-17 Keith Miller <keith_miller@apple.com>
24303 Add test262 harness support code
24304 https://bugs.webkit.org/show_bug.cgi?id=157797
24306 Reviewed by Filip Pizlo.
24308 The import-test262-tests script is used to generate the yaml file used to run test262. It
24309 takes a path to the local copy of the Test262 repository as well as an optional path to file
24310 containing a list of failures. This script currently just creates the yaml file used to run
24311 the script. It does not relocate the test files into our tests directory. In the future I
24312 plan to add that feature but it didn't seem essential for the first iteration. Since many
24313 test262 tests need to be run in both strict and non-strict mode, import-test262-tests
24314 creates two separate runs for those tests. This enables us to distinguish between failures
24315 in only one of the two modes.
24317 This patch also updates the run-jsc-stress-tests Script to run tests from Test262. In order
24318 to do so two new run commands were needed runTest262 and prepareTest262Fixture. runTest262
24319 takes an actual test file along with the metadata associated with it. prepareTest262Fixture
24320 takes a fixture file (used by module tests for importing) and makes sure that file is
24321 properly relocated to the test runner directory.
24323 The proccess I used to import the tests was to first run import-test262-tests to create a
24324 yaml for all the tests (import-test262-tests assumes all tests pass if to failures file is
24325 passed). Then I ran the generated yaml file with "run-jsc-stress-tests -v -c 1" piping the
24326 output to a file and collected all the lines with "FAIL" in it. Finally, I reran
24327 import-test262-tests with the new failure file to create the final yaml.
24329 * Scripts/import-test262-tests: Added.
24330 * Scripts/run-jsc-stress-tests:
24332 2016-05-16 Enrica Casucci <enrica@apple.com>
24334 build fix after r200968 and r200969
24338 * DumpRenderTree/mac/EventSendingController.mm:
24339 (-[EventSendingController keyDown:withModifiers:withLocation:]):
24341 2016-05-16 Jer Noble <jer.noble@apple.com>
24343 API test WebKit2.MSEIsPlayingAudio timing out after r200951
24344 https://bugs.webkit.org/show_bug.cgi?id=157748
24346 Reviewed by Eric Carlson.
24348 The file-with-mse.html testcase only calls play() once it's own XHR loading is complete; the
24349 "user gesture" check fails at that point. Call play() up front; playback will begin as soon
24350 as enough data is loaded.
24352 * TestWebKitAPI/Tests/WebKit2/file-with-mse.html:
24354 2016-05-16 Enrica Casucci <enrica@apple.com>
24356 Remove unused initializer for WebEvent on iOS.
24357 https://bugs.webkit.org/show_bug.cgi?id=157689
24359 Reviewed by Anders Carlsson.
24361 Adopting different initializer for WebEvent to fix the build.
24363 * DumpRenderTree/mac/EventSendingController.mm:
24364 (-[EventSendingController keyDown:withModifiers:withLocation:]):
24366 2016-05-16 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
24368 Add machine-readable results for JSC API tests to the Buildbot json log
24369 https://bugs.webkit.org/show_bug.cgi?id=157642
24371 Reviewed by Geoffrey Garen.
24373 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
24374 (RunJavaScriptCoreTests): Use --no-fail-fast option on run-javascriptcore-tests
24375 * Scripts/run-javascriptcore-tests:
24376 (runJSCStressTests): Abstracted out writing JSON to file (new function below)
24377 (writeJsonDataIfApplicable): Added
24379 2016-04-06 Jer Noble <jer.noble@apple.com>
24381 [WK2] Add API to WKWebViewConfiguration to control autoplay policy.
24382 https://bugs.webkit.org/show_bug.cgi?id=156312
24384 Reviewed by Dan Bernstein.
24386 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
24387 (WTR::initializeWebViewConfiguration):
24388 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
24391 2016-05-16 Brent Fulgham <bfulgham@apple.com>
24393 REGRESSION (r192098): Content missing after copy and paste to Notes App on retina displays
24394 https://bugs.webkit.org/show_bug.cgi?id=157630
24395 <rdar://problem/25277577>
24397 Reviewed by Simon Fraser.
24399 Update test infrastructure to support checking the number of images in the pasteboard.
24401 * DumpRenderTree/TestRunner.cpp:
24402 (imageCountInGeneralPasteboardCallback): Added.
24403 (TestRunner::staticFunctions):
24404 * DumpRenderTree/TestRunner.h:
24405 * DumpRenderTree/mac/TestRunnerMac.mm:
24406 (TestRunner::imageCountInGeneralPasteboard): Added.
24407 * DumpRenderTree/win/TestRunnerWin.cpp:
24408 (TestRunner::imageCountInGeneralPasteboard): Added stub method.
24409 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
24410 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
24411 (WTR::InjectedBundle::imageCountInGeneralPasteboard): Added.
24412 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
24413 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
24414 (WTR::TestRunner::imageCountInGeneralPasteboard): Added.
24415 * WebKitTestRunner/InjectedBundle/TestRunner.h:
24416 * WebKitTestRunner/TestController.cpp:
24417 (WTR::TestController::imageCountInGeneralPasteboard): Added stub implementation.
24418 * WebKitTestRunner/TestController.h:
24419 * WebKitTestRunner/TestInvocation.cpp:
24420 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Handle copy message.
24421 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
24422 (WTR::TestController::imageCountInGeneralPasteboard): Added.
24424 2016-05-13 Dewei Zhu <dewei_zhu@apple.com>
24426 Fix JSBench which causes math domain error in run-benchmark script.
24427 https://bugs.webkit.org/show_bug.cgi?id=157697
24428 <rdar://problem/26279292>
24430 Reviewed by Ryosuke Niwa.
24432 Some tests of JSBench give time usage to be 0 ms which will causes error while calculating geometric mean.
24433 Also fix a round-off error while calculating stdev.
24435 * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
24436 (BenchmarkResults._format_values):
24437 * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
24439 2016-05-13 Brady Eidson <beidson@apple.com>
24441 Extend protector naming code style guideline to cover operator= assignment.
24442 https://bugs.webkit.org/show_bug.cgi?id=157693
24444 Reviewed by Darin Adler.
24446 * Scripts/webkitpy/style/checkers/cpp.py:
24447 (check_identifier_name_in_declaration):
24448 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
24449 (WebKitStyleTest.test_names):
24451 2016-05-13 Aakash Jain <aakash_jain@apple.com>
24453 Dashboard code restructuring
24454 https://bugs.webkit.org/show_bug.cgi?id=157680
24455 <rdar://problem/14736888>
24457 Reviewed by Alexey Proskuryakov.
24459 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
24460 (BubbleQueueView.prototype.addLinkToRow): Moved to base class.
24461 (BubbleQueueView.prototype.addTextToRow): Moved to base class.
24462 (BubbleQueueView.prototype._addDividerToPopover): Moved to base class.
24463 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
24464 (BuildbotBuilderQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
24465 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
24466 (BuildbotCombinedQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
24467 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
24468 (BuildbotTesterQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
24469 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
24470 (BuildbotQueueView.prototype._appendPendingRevisionCount): Moved to base class and modified to take
24471 additional argument.
24472 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Moved to base class.
24473 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved to base class.
24474 (BuildbotQueueView.prototype._addDividerToPopover): Moved to base class.
24475 (BuildbotQueueView.prototype._formatRevisionForDisplay): Moved to base class.
24476 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
24477 (documentReady): Display any customView if available.
24478 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
24479 (QueueView.prototype.addLinkToRow): Moved from child class, no changes.
24480 (QueueView.prototype.addTextToRow): Moved from child class, no changes.
24481 (QueueView.prototype._addDividerToPopover): Moved from child class, no changes.
24482 (QueueView.prototype._appendPendingRevisionCount): Moved from child class, made it more generic
24483 by taking latestIterationGetter method as an argument.
24484 (QueueView.prototype._popoverLinesForCommitRange): Moved from child class, no changes.
24485 (QueueView.prototype._presentPopoverForPendingCommits): Moved from child class, no changes.
24486 (QueueView.prototype._formatRevisionForDisplay): Moved from child class, no changes.
24487 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
24488 (a:hover:link): Underline only when there is a link.
24490 2016-05-13 Yoav Weiss <yoav@yoav.ws>
24492 Turn on WEB_TIMING for all ports
24493 https://bugs.webkit.org/show_bug.cgi?id=157673
24495 Reviewed by Alex Christensen.
24497 * Scripts/webkitperl/FeatureList.pm: Make sure that WEB_TIMING is on by default.
24499 2016-05-13 Brady Eidson <beidson@apple.com>
24501 Protector Ref/RefPtrs should have a specified naming style.
24502 https://bugs.webkit.org/show_bug.cgi?id=157591
24504 Reviewed by Darin Adler.
24506 * Scripts/webkitpy/style/checkers/cpp.py:
24507 (check_identifier_name_in_declaration):
24509 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
24510 (WebKitStyleTest.test_names):
24512 2016-05-12 Csaba Osztrogonác <ossy@webkit.org>
24514 Remove ENABLE(ES6_ARROWFUNCTION_SYNTAX) guards
24515 https://bugs.webkit.org/show_bug.cgi?id=157564
24517 Reviewed by Darin Adler.
24519 * Scripts/webkitperl/FeatureList.pm:
24520 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
24522 2016-05-11 Joanmarie Diggs <jdiggs@igalia.com>
24524 [GTK] accessibility/aria-readonly.html is failing
24525 https://bugs.webkit.org/show_bug.cgi?id=98357
24527 Reviewed by Chris Fleizach.
24529 Add checks to isAttributeSettable() for ATK_STATE_READ_ONLY and the 'readonly'
24530 AtkObject attribute along with ATK_STATE_CHECKABLE for toggle-able elements,
24531 ATK_STATE_SELECTABLE for select elements, and ATK_STATE_FOCUSABLE combined
24532 with range verification for inputs which implement AtkValue. The latter two
24533 additions are admittedly a heuristic workaround for platform accessibility
24534 API differences. But they should be sufficient to facilitate cross-platform
24535 testing of isAttributeSettable() for form elements which lack ARIA attributes.
24537 Bump the minimum version of at-spi2-core and at-spi2-atk
24538 to 2.15.4 (earliest version that supports STATE_READ_ONLY).
24540 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
24541 (WTR::AccessibilityUIElement::isAttributeSettable):
24542 * gtk/jhbuild.modules:
24544 2016-05-10 Ryan Haddad <ryanhaddad@apple.com>
24546 Another attempt to fix the build after r200668.
24548 Unreviewed build fix.
24550 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
24553 2016-05-10 Dan Bernstein <mitz@apple.com>
24555 Tried to fix the Mac build after r200668.
24557 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
24558 (WTR::TestController::platformCreateWebView):
24560 2016-05-10 Sam Weinig <sam@webkit.org>
24562 Tweak underline style for data detected links
24563 https://bugs.webkit.org/show_bug.cgi?id=157546
24565 Reviewed by Tim Horton.
24567 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24568 * TestWebKitAPI/Tests/WebCore/Color.cpp: Added.
24569 (TestWebKitAPI::TEST):
24570 Add tests for the new Color::getHSV() function.
24572 2016-05-10 Filip Pizlo <fpizlo@apple.com>
24574 Internal JSC profiler should have a timestamped log of events for each code block
24575 https://bugs.webkit.org/show_bug.cgi?id=157538
24577 Reviewed by Benjamin Poulain.
24579 * Scripts/display-profiler-output:
24581 2016-05-10 Michael Catanzaro <mcatanzaro@igalia.com>
24583 [Linux] Remove seccomp filters support
24584 https://bugs.webkit.org/show_bug.cgi?id=157380
24586 Reviewed by Darin Adler.
24588 * Scripts/webkitperl/FeatureList.pm:
24589 * TestWebKitAPI/PlatformEfl.cmake:
24590 * TestWebKitAPI/PlatformGTK.cmake:
24591 * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Removed.
24592 * efl/jhbuild.modules:
24593 * gtk/jhbuild.modules:
24595 2016-05-09 Simon Fraser <simon.fraser@apple.com>
24597 [iOS] visibility:hidden -webkit-overflow-scrolling: touch divs can interfere with page scrolling
24598 https://bugs.webkit.org/show_bug.cgi?id=157496
24599 rdar://problem/22963278
24601 Reviewed by Tim Horton.
24603 Enhance UIScriptController to generate a drag, which is useful for scrolling.
24605 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
24606 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
24607 (WTR::UIScriptController::dragFromPointToPoint):
24608 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
24609 * WebKitTestRunner/ios/HIDEventGenerator.h:
24610 * WebKitTestRunner/ios/HIDEventGenerator.mm:
24611 (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
24612 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
24613 (WTR::UIScriptController::dragFromPointToPoint):
24615 2016-05-09 Simon Fraser <simon.fraser@apple.com>
24617 Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it
24618 https://bugs.webkit.org/show_bug.cgi?id=157480
24620 Reviewed by Zalan Bujtas.
24622 Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled()
24623 and move it next to the other iOS text autosizing tests.
24625 Remove testRunner.setTextAutosizingEnabled(), which was only implemented in DumpRenderTree.
24627 * DumpRenderTree/TestRunner.cpp:
24628 (setTextAutosizingEnabledCallback): Deleted.
24629 (TestRunner::staticFunctions): Deleted.
24630 * DumpRenderTree/mac/TestRunnerMac.mm:
24631 (TestRunner::setTextAutosizingEnabled): Deleted.
24633 2016-05-07 Darin Adler <darin@apple.com>
24635 Next step on dictionary bindings, along with other bindings refinements
24636 https://bugs.webkit.org/show_bug.cgi?id=157451
24638 Reviewed by Chris Dumez.
24640 * Scripts/do-webcore-rename: Use this to rename JSDOMBuild.h to JSDOMConvert.h.
24641 Also skip test expectations in a directory that this was modifying unnecessarily.
24643 2016-05-06 Simon Fraser <simon.fraser@apple.com>
24645 Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
24646 https://bugs.webkit.org/show_bug.cgi?id=157432
24647 rdar://problem/16406720
24649 Reviewed by Dean Jackson.
24651 Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.
24653 Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2
24654 preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests.
24655 These two settings are shared with TEXT_AUTOSIZING.
24657 Add a TextAutosizing log channel, which is useful for generated -expected.html results.
24659 Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
24662 An implication of this set of changes is that the way clients enable text autosizing
24663 has changed. Previously, they set the "MinimumZoomFontSize" preference to 0.
24664 Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing
24665 on iPhone only, not iPad.
24667 Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
24668 instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.
24670 UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size,
24671 which will now always return 15, but had no other code that toggled this. So it's safe to just rely
24672 on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad.
24674 * DumpRenderTree/mac/DumpRenderTree.mm:
24675 (resetWebPreferencesToConsistentValues):
24676 * DumpRenderTree/mac/TestRunnerMac.mm:
24677 (TestRunner::setTextAutosizingEnabled):
24678 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
24679 * WebKitTestRunner/ios/TestControllerIOS.mm:
24680 (WTR::TestController::platformResetPreferencesToConsistentValues):
24682 2016-05-06 Dean Jackson <dino@apple.com>
24684 Regions, Shapes and Tracks don't need runtime features
24685 https://bugs.webkit.org/show_bug.cgi?id=157426
24686 <rdar://problem/26146262>
24688 Reviewed by Simon Fraser.
24690 The following RuntimeEnabledFeatures can be removed since
24691 we have no need to disable them (they are stable and have
24692 shipped for a while):
24697 * DumpRenderTree/mac/DumpRenderTree.mm:
24698 (resetWebPreferencesToConsistentValues): Deleted.
24700 2016-05-06 Ryan Haddad <ryanhaddad@apple.com>
24702 Increase delay when launching multiple ios-simulators in parallel
24703 https://bugs.webkit.org/show_bug.cgi?id=157422
24705 Reviewed by Alexey Proskuryakov.
24707 Tests are intermittently failing when launching multiple simulators in parallel due to "You are opening
24708 this application for the first time" confirmation dialogs. Increasing the delay to alleviate this issue.
24710 * Scripts/webkitpy/port/ios.py:
24711 (IOSSimulatorPort.setup_test_run):
24713 2016-05-06 Per Arne Vollan <peavo@outlook.com>
24715 [Win] Remove WinXP support.
24716 https://bugs.webkit.org/show_bug.cgi?id=157416
24718 Reviewed by Brent Fulgham.
24720 * win/DLLLauncher/DLLLauncherMain.cpp:
24721 (enableTerminationOnHeapCorruption):
24723 2016-05-06 Manuel Rego Casasnovas <rego@igalia.com>
24725 [css-grid] Unprefix CSS Grid Layout properties
24726 https://bugs.webkit.org/show_bug.cgi?id=157137
24728 Reviewed by Simon Fraser.
24730 Remove "-webkit" prefix from all the grid layout properties,
24731 including the display value.
24732 Update the source code to remove the prefix where it was used too.
24734 * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
24735 (TestWebKitAPI::TEST):
24737 2016-05-05 Alexey Proskuryakov <ap@apple.com>
24739 Partially revert http://trac.webkit.org/r200504
24740 Improve HTTP test names in WebKitTestRunner's crash report information
24741 https://bugs.webkit.org/show_bug.cgi?id=157389
24743 * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Turns out that we can't have URLs
24744 in crash reporter information.
24746 2016-05-05 Alexey Proskuryakov <ap@apple.com>
24748 Improve HTTP test names in WebKitTestRunner's crash report information
24749 https://bugs.webkit.org/show_bug.cgi?id=157389
24751 Reviewed by Alex Christensen.
24753 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
24754 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Added a FIXME.
24756 * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
24757 (WTR::testDescription): Don't bail out if the port is neither 8000 nor 8443; we
24758 use other port numbers too. For http tests, return the complete URL string, not
24761 2016-05-04 Alex Christensen <achristensen@webkit.org>
24763 Blocked redirected main resource requests need descriptive errors
24764 https://bugs.webkit.org/show_bug.cgi?id=156828
24765 rdar://problem/25711316
24767 Reviewed by Daniel Bates.
24769 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
24770 (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
24771 Print out the error type to make sure we have the most descriptive error type.
24773 2016-05-05 Enrique Ocaña González <eocanha@igalia.com>
24775 [GStreamer] Bump internal jhbuild versions to 1.8.0 and patches to support MSE
24776 https://bugs.webkit.org/show_bug.cgi?id=157341
24778 Reviewed by Xabier Rodriguez-Calvar.
24780 * gtk/jhbuild.modules:
24781 * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
24782 * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
24784 2016-05-04 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
24786 Add JSC test results in JSON format to a Buildbot log
24787 https://bugs.webkit.org/show_bug.cgi?id=156920
24789 Reviewed by Daniel Bates.
24791 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
24792 (RunJavaScriptCoreTests): Move command-line option for output file out
24795 2016-05-04 Dean Jackson <dino@apple.com>
24797 TestRunner should always enable all the experimental features
24798 https://bugs.webkit.org/show_bug.cgi?id=157360
24799 <rdar://problem/26099748>
24801 Reviewed by Anders Carlsson.
24803 Call the new SPI that enables all the experimental features.
24805 * WebKitTestRunner/TestController.cpp:
24806 (WTR::TestController::resetPreferencesToConsistentValues):
24808 2016-05-04 Mark Lam <mark.lam@apple.com>
24810 ES6 Function.name inferred from property names of literal objects can break some websites.
24811 https://bugs.webkit.org/show_bug.cgi?id=157246
24813 Reviewed by Geoffrey Garen.
24815 * WebKitTestRunner/TestController.cpp:
24816 (WTR::TestController::resetPreferencesToConsistentValues):
24817 (WTR::updateTestOptionsFromTestHeader):
24818 * WebKitTestRunner/TestOptions.h:
24820 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
24821 (WTR::PlatformWebView::viewSupportsOptions):
24822 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
24823 (WTR::PlatformWebView::viewSupportsOptions):
24824 - Add needsSiteSpecificQuirks to WKTR options that can be set.
24826 2016-05-04 Joanmarie Diggs <jdiggs@igalia.com>
24828 AX: ARIA 'region' role is now a landmark; HTML 'section' element should be a landmark only if named
24829 https://bugs.webkit.org/show_bug.cgi?id=157331
24831 Reviewed by Chris Fleizach.
24833 Add AXLandmarkRegion to the landmark strings handled by roleToString
24834 for objects with ATK_ROLE_LANDMARK.
24836 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
24838 2016-05-03 Beth Dakin <bdakin@apple.com>
24840 Add VideoControlsManager tests
24841 https://bugs.webkit.org/show_bug.cgi?id=157332
24842 -and corresponding-
24843 rdar://problem/24358431
24845 Reviewed by Sam Weinig.
24847 This patch adds three VideoControlsManager tests.
24849 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24850 * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
24851 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Added.
24852 (-[DidPlayMessageHandler initWithWKWebView:]):
24853 (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
24854 (TestWebKitAPI::TEST):
24855 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Added.
24856 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Added.
24857 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Added.
24859 2016-05-03 Joanmarie Diggs <jdiggs@igalia.com>
24861 [ATK] accessibility/document-attributes.html is failing
24862 https://bugs.webkit.org/show_bug.cgi?id=125348
24864 Reviewed by Chris Fleizach.
24866 The test was failing because the WebArea is now being exposed with the role of
24867 ATK_ROLE_DOCUMENT_WEB; not ATK_ROLE_DOCUMENT_FRAME. Unfortunately, when that
24868 change was made, documentEncoding() and documentURI() were not updated accordingly.
24870 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
24871 (WTR::AccessibilityUIElement::documentEncoding):
24872 (WTR::AccessibilityUIElement::documentURI):
24874 2016-05-03 Brent Fulgham <bfulgham@apple.com>
24876 [Win] Unreviewed build fix.
24878 * EWSTools/start-queue-win.sh: Establish proper VS2015 build
24879 environment at start of queue run.
24881 2016-05-03 Joanmarie Diggs <jdiggs@igalia.com>
24883 [ATK] accessibility/content-editable-as-textarea.html fails
24884 https://bugs.webkit.org/show_bug.cgi?id=155353
24886 Reviewed by Darin Adler.
24888 The test was timing out because it expected an AXValueChanged notification.
24889 In ATK, AXValueChanged notifications are made for widgets which implement
24890 the AtkValue interface (sliders, progress bars, etc.). We should be listening
24891 for AXTextChanged instead. AtkText's text-insert and text-remove have been
24892 added to the AccessibilityNotificationHandler.
24894 Also, ATK's AccessibilityUIElement support had a number of unimplemented
24895 methods that are being used as part of the previously-failing test. Those
24896 methods are now implemented so that the ATK results are much more similar
24897 to those on the Mac.
24899 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
24900 (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
24901 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
24902 (WTR::AccessibilityUIElement::stringAttributeValue):
24903 (WTR::AccessibilityUIElement::rangeForLine):
24904 (WTR::AccessibilityUIElement::boundsForRange):
24905 (WTR::AccessibilityUIElement::attributedStringForRange):
24907 2016-05-02 Brady Eidson <beidson@apple.com>
24909 Add the ability to accumulate logs for specific logging channels to help diagnose test timeouts.
24910 https://bugs.webkit.org/show_bug.cgi?id=157274
24912 Reviewed by Alex Christensen.
24914 Add the new accumulate method to DRT's TestRunner, dump the accumulated logs if there's a timeout,
24915 and reset them in between tests:
24916 * DumpRenderTree/TestRunner.cpp:
24917 (accummulateLogsForChannel):
24918 (TestRunner::staticFunctions):
24919 (TestRunner::waitToDumpWatchdogTimerFired):
24920 (TestRunner::setAccummulateLogsForChannel):
24921 * DumpRenderTree/TestRunner.h:
24922 * DumpRenderTree/mac/DumpRenderTree.mm:
24923 (resetWebViewToConsistentStateBeforeTesting):
24925 Also add the new method to WKTR's TestRunner, but just stubbed for now:
24926 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
24927 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
24928 (WTR::TestRunner::accummulateLogsForChannel):
24929 * WebKitTestRunner/InjectedBundle/TestRunner.h:
24931 2016-05-02 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
24933 Add fail-fast option to run-javascriptcore-tests
24934 https://bugs.webkit.org/show_bug.cgi?id=157270
24936 Reviewed by Geoffrey Garen.
24938 * Scripts/run-javascriptcore-tests: Add fail-fast command line option.
24939 Defaults to yes, which is the current behavior.
24941 2016-05-02 Carlos Alberto Lopez Perez <clopez@igalia.com>
24943 [CMake] MiniBrowser fails to build because libsoup link flags are not defined.
24944 https://bugs.webkit.org/show_bug.cgi?id=157268
24946 Reviewed by Michael Catanzaro.
24948 * MiniBrowser/gtk/CMakeLists.txt:
24950 2016-04-30 Darin Adler <darin@apple.com>
24952 Streamline and remove unused bindings generation code
24953 https://bugs.webkit.org/show_bug.cgi?id=157237
24955 Reviewed by Chris Dumez.
24957 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
24958 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
24959 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
24960 Replace non-standard "int" with standard "long", which means the same thing.
24962 2016-04-30 Darin Adler <darin@apple.com>
24964 Next batch of conversions to use C++ enum class instead of strings for enumerations
24965 https://bugs.webkit.org/show_bug.cgi?id=157232
24967 Reviewed by Chris Dumez.
24969 * Scripts/webkitpy/style/checker.py: Skip the bindings script tests when doing style
24970 checking. We don't want to waste time trying to make our generated code match our style.
24972 2016-04-29 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
24974 Add JSC test results in JSON format to a Buildbot log.
24975 https://bugs.webkit.org/show_bug.cgi?id=156920
24977 Reviewed by Daniel Bates.
24979 Generate JSON results for JSC tests and upload them to the master
24980 using Buildbot's logfiles machinery.
24982 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
24983 (RunJavaScriptCoreTests): Use --json-output option when invoking the
24984 run-javascriptcore-tests Perl script, and expose this JSON output as a
24986 * Scripts/run-javascriptcore-tests:
24987 (runJSCStressTests): Change key names and remove redundant count key.
24989 2016-04-29 Joanmarie Diggs <jdiggs@igalia.com>
24991 [ATK] Expose the value of aria-roledescription via an AtkObject attribute
24992 https://bugs.webkit.org/show_bug.cgi?id=146719
24994 Reviewed by Chris Fleizach.
24996 Implement roleDescription() so that the implementation can be tested.
24998 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
24999 (WTR::AccessibilityUIElement::roleDescription):
25001 2016-04-27 Alexey Proskuryakov <ap@apple.com>
25003 Don't throttle GuardMalloc on 8-core Macs
25004 https://bugs.webkit.org/show_bug.cgi?id=157108
25006 Reviewed by Alex Christensen.
25008 This was making them slower unnecessarily.
25010 * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
25012 2016-04-26 Konstantin Tokarev <annulen@yandex.ru>
25014 Unreviewed: add myself to the committers list.
25016 * Scripts/webkitpy/common/config/contributors.json:
25018 2016-04-26 Ryosuke Niwa <rniwa@webkit.org>
25020 Fix text in log files autogenerated by import-w3c-tests
25021 https://bugs.webkit.org/show_bug.cgi?id=157021
25023 Unreviewed. Fixing the second typo.
25025 * Scripts/webkitpy/w3c/test_importer.py:
25026 (TestImporter.write_import_log):
25028 2016-04-26 Filip Pizlo <fpizlo@apple.com>
25030 WebCore on Mac ignores the user's preferred region (country) while getting the language
25031 https://bugs.webkit.org/show_bug.cgi?id=156993
25033 Reviewed by Geoffrey Garen.
25035 Change the test expectations for this test. If the variant is not explicitly specified in
25036 the AppleLanguage, then we use the locale's country code, which this test assumes is US.
25038 * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
25039 (TestWebKitAPI::languageForSystemLanguage):
25040 (TestWebKitAPI::TEST):
25042 2016-04-25 Ryosuke Niwa <rniwa@webkit.org>
25044 Remove the build flag for template elements
25045 https://bugs.webkit.org/show_bug.cgi?id=157022
25047 Reviewed by Daniel Bates.
25049 Removed the build option.
25051 * Scripts/webkitperl/FeatureList.pm:
25053 2016-04-25 Ryosuke Niwa <rniwa@webkit.org>
25055 Fix text in log files autogenerated by import-w3c-tests
25056 https://bugs.webkit.org/show_bug.cgi?id=157021
25058 Reviewed by Chris Dumez.
25060 s/Webkit/WebKit/ and end each sentence with a period.
25062 * Scripts/webkitpy/w3c/test_importer.py:
25063 (TestImporter.write_import_log):
25065 2016-04-25 Myles C. Maxfield <mmaxfield@apple.com>
25067 [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr
25068 https://bugs.webkit.org/show_bug.cgi?id=156929
25070 Reviewed by Darin Adler.
25072 * TestWebKitAPI/Tests/mac/StringTruncator.mm:
25073 (TestWebKitAPI::TEST):
25075 2016-04-25 Caitlin Potter <caitp@igalia.com>
25077 [Tools] whitelist all-uppercase JSTokenType enum in JavaScriptCore
25078 https://bugs.webkit.org/show_bug.cgi?id=156976
25080 Reviewed by Darin Adler.
25082 Mitigate style-checker spam on bugs which introduce new JavaScript
25085 * Scripts/webkitpy/style/checkers/cpp.py:
25086 (_EnumState.__init__):
25087 (_EnumState.process_clean_line):
25088 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
25089 (NoNonVirtualDestructorsTest.test_enum_casing):
25091 2016-04-25 Simon Fraser <simon.fraser@apple.com>
25093 Fix issues with content-animation performance tests
25094 https://bugs.webkit.org/show_bug.cgi?id=157001
25096 Reviewed by Sam Weinig.
25098 Add patch content for svg-animation.html, and fix the paths in the patch so
25099 it applies correctly.
25101 Add the patch file to the .plan file.
25103 * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
25104 * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
25106 2016-04-25 Brady Eidson <beidson@apple.com>
25108 Tweaking IndexedDB watchlist and adding myself to it.
25110 * Scripts/webkitpy/common/config/watchlist:
25112 2016-04-25 Commit Queue <commit-queue@webkit.org>
25114 Unreviewed, rolling out r199916.
25115 https://bugs.webkit.org/show_bug.cgi?id=156989
25117 Might break buildbot when master is restarted (Requested by
25118 Srinivasan Vijayaraghava, Guest100, on #webkit).
25120 Reverted changeset:
25122 "Add JSC test results in json format to a buildbot log"
25123 https://bugs.webkit.org/show_bug.cgi?id=156920
25124 http://trac.webkit.org/changeset/199916
25126 2016-04-23 Chris Dumez <cdumez@apple.com>
25128 [WebIDL] Drop [Default] WebKit-IDL extended attribute
25129 https://bugs.webkit.org/show_bug.cgi?id=156955
25131 Reviewed by Darin Adler.
25133 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
25135 2016-04-23 Csaba Osztrogonác <ossy@webkit.org>
25137 Really enable INDEXED_DATABASE on Apple Mac cmake build
25138 https://bugs.webkit.org/show_bug.cgi?id=156902
25140 Reviewed by Michael Catanzaro.
25142 * Scripts/webkitperl/FeatureList.pm:
25144 2016-04-23 Andy Estes <aestes@apple.com>
25146 check-webkit-style: fix false-positive warnings about @synchronized
25147 https://bugs.webkit.org/show_bug.cgi?id=156957
25149 Reviewed by Dan Bernstein.
25151 * Scripts/webkitpy/style/checkers/cpp.py:
25152 (check_spacing_for_function_call): Ignore @synchronized lines.
25153 (check_braces): Ditto.
25154 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
25155 (CppStyleTest.test_brace_at_begin_of_line): Added a test case.
25157 2016-04-22 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
25159 Add JSC test results in json format to a buildbot log
25160 https://bugs.webkit.org/show_bug.cgi?id=156920
25162 Reviewed by Alexey Proskuryakov.
25164 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
25165 (RunJavaScriptCoreTests):
25166 Add runtime flag to output json into buildbot
25167 * Scripts/run-javascriptcore-tests:
25168 (runJSCStressTests):
25169 Change key names and remove redundant count key
25171 2016-04-22 Ryan Haddad <ryanhaddad@apple.com>
25173 Update expected result for WKPreferencesGetOfflineWebApplicationCacheEnabled after r199854
25175 Unreviewed test gardening.
25177 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
25178 (TestWebKitAPI::TEST):
25180 2016-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
25182 [GTK] Enable the download attribute support
25183 https://bugs.webkit.org/show_bug.cgi?id=99025
25185 Reviewed by Žan Doberšek.
25187 * Scripts/webkitperl/FeatureList.pm:
25189 2016-04-21 Keith Miller <keith_miller@apple.com>
25191 WebScriptObject description swizzler should work in a multi-threaded world
25192 https://bugs.webkit.org/show_bug.cgi?id=156808
25194 Add a test for our NSObject swizzling TLS implementation. The test runs on
25195 two threads. One in JS and another in Objective-C. We expect the JS thread
25196 to use our NSObject description override and the Objective-C thread to act
25197 as though it was using the original NSObject description method.
25199 Reviewed by Geoffrey Garen.
25201 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25202 * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.html: Added.
25203 * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm: Added.
25204 (nsObjectDescriptionTest):
25205 (-[WebScriptDescriptionTest webView:didFinishLoadForFrame:]):
25206 (TestWebKitAPI::TEST):
25208 2016-04-21 Carlos Garcia Campos <cgarcia@igalia.com>
25210 [GTK] WebKitWebView should claim the contents size as its natural size
25211 https://bugs.webkit.org/show_bug.cgi?id=156835
25213 Reviewed by Žan Doberšek.
25215 Add test case to check the WebKitWebView preferred size.
25217 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
25218 (testWebViewPreferredSize):
25221 2016-04-20 Simon Fraser <simon.fraser@apple.com>
25223 Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
25224 https://bugs.webkit.org/show_bug.cgi?id=156827
25226 Update the .plan file now that the files are present in SVN.
25228 * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
25230 2016-04-20 Simon Fraser <simon.fraser@apple.com>
25232 Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
25233 https://bugs.webkit.org/show_bug.cgi?id=156827
25234 rdar://problem/24358135
25236 Reviewed by Stephanie Lewis.
25238 Enhance benchmark_runner so that a benchmark can load a set of tests sequentially,
25239 and collate results across them. Also add the ability for the browser_driver to supply
25240 additional results, allowing for tests that collect results data in native code, rather
25241 than generating it in the web page.
25243 Add a set of "content animation" tests that use this new functionality, which test
25244 CSS animation and requestAnimationFrame performance.
25246 'plan' files have two new optional keys:
25247 'test_files': a list of files to run as a suite
25248 'options': optional parameters. Currently supports one new option,
25249 'animation_command', which affects the way that iOS tests are run,
25250 and is passed to MobileSafari as a parameter on launch.
25252 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
25253 (BenchmarkRunner.__init__): If options is not specified in the plan file, set it to an empty dictionary.
25254 (BenchmarkRunner._get_result): Allow the browser_driver to modify the test results.
25256 (BenchmarkRunner._run_one_test): Factored out of _run_benchmark, this contains logic for
25257 running a single test. It starts and stops the http_server_driver.
25258 (BenchmarkRunner._run_benchmark): Run a test in the traditional way if the plan has an 'entry_point'
25259 key, otherwise look for the new 'test_files' and load each in a loop.
25260 (BenchmarkRunner._dump):
25261 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
25262 (BrowserDriver.launch_url): Pass options.
25263 (BrowserDriver.add_additional_results): Allow a driver to supply additional results.
25265 * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py:
25266 (GTKMiniBrowserDriver.launch_url):
25267 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
25268 (OSXBrowserDriver.close_browsers):
25269 (OSXBrowserDriver._terminate_processes): Fix spelling mistake.
25270 (OSXBrowserDriver._terminiate_processes): Deleted.
25271 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
25272 (OSXChromeDriver.launch_url):
25273 (OSXChromeCanaryDriver.launch_url):
25274 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
25275 (OSXFirefoxDriver.launch_url):
25276 (OSXFirefoxNightlyDriver.launch_url):
25277 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
25278 (OSXSafariDriver.launch_url):
25279 * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch: Added.
25280 * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan: Added.
25282 2016-04-20 Dustin Falgout <dustin@falgout.us>
25284 [GTK] Expose AllowUniversalAccessFromFileURLs preference now that calling localStorage.getItem() results in SecurityError: DOM Exception 18
25285 https://bugs.webkit.org/show_bug.cgi?id=156651
25287 Reviewed by Michael Catanzaro.
25289 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
25290 (testWebKitSettings):
25292 2016-04-20 Brady Eidson <beidson@apple.com>
25294 Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
25295 https://bugs.webkit.org/show_bug.cgi?id=156782
25297 Reviewed by Alex Christensen.
25299 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
25301 2016-04-19 Brent Fulgham <bfulgham@apple.com>
25303 Unreviewed build fix after r199752.
25305 * DumpRenderTree/win/FrameLoadDelegate.cpp:
25306 (FrameLoadDelegate::didChangeIcons): Remove call to removed function.
25308 2016-04-19 Brent Fulgham <bfulgham@apple.com>
25310 Remove remaining bits of dynamic <link> rel='icon' loading
25311 https://bugs.webkit.org/show_bug.cgi?id=156727
25313 Reviewed by Darin Adler.
25315 Remove unused test infrastructure. This code never existed in WebKit2
25316 testing since was only used on Windows.
25318 * DumpRenderTree/TestRunner.cpp:
25319 (dumpIconChangesCallback): Deleted.
25320 * DumpRenderTree/TestRunner.h:
25321 (TestRunner::dumpIconChanges): Deleted.
25322 (TestRunner::setDumpIconChanges): Deleted.
25324 2016-04-19 Keith Miller <keith_miller@apple.com>
25326 ObjcInstance::stringValue should not call NSObject's description method
25327 https://bugs.webkit.org/show_bug.cgi?id=156758
25329 Reviewed by Geoffrey Garen.
25331 Add new methods to ObjCController that expose two Types of WebScriptObjects. The first is
25332 an NSObject and the second is an NSArray of NSObjects. These are used to test that we don't
25333 call the NSObjects description method without first swizzling it.
25335 * DumpRenderTree/mac/ObjCController.m:
25336 (+[ObjCController isSelectorExcludedFromWebScript:]):
25337 (+[ObjCController webScriptNameForSelector:]):
25338 (-[ObjCController testArrayOfObjects]):
25339 (-[ObjCController testObject]):
25341 2016-04-18 Dan Bernstein <mitz@apple.com>
25343 Fixed building with old Xcode.
25345 * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
25348 2016-04-18 Dean Jackson <dino@apple.com>
25350 New SPI to export a dictionary of runtime features
25351 https://bugs.webkit.org/show_bug.cgi?id=156645
25352 <rdar://problem/23621666>
25354 Reviewed by Darin Adler.
25356 Test the experimental features SPI on WKPreferences.
25358 * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
25360 2016-04-18 Yusuke Suzuki <utatane.tea@gmail.com>
25362 [JSCOnly] Implement RunLoop and remove glib dependency
25363 https://bugs.webkit.org/show_bug.cgi?id=155706
25365 Reviewed by Michael Catanzaro.
25367 Add TestWTF to JSCOnly port to test WorkQueue and RunLoop.
25368 Platform specific ones locate under jsconly directory since
25369 it is not `generic` (Since it includes the GLIB event loop case).
25372 * TestWebKitAPI/PlatformJSCOnly.cmake: Added.
25373 * TestWebKitAPI/PlatformUtilities.h:
25374 * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
25375 (TestWebKitAPI::TEST):
25376 * TestWebKitAPI/config.h:
25377 * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp: Renamed from Source/WTF/wtf/none/RunLoopNone.cpp.
25378 (TestWebKitAPI::Util::run):
25379 (TestWebKitAPI::Util::sleep):
25380 * TestWebKitAPI/jsconly/main.cpp: Renamed from Source/WTF/wtf/none/WorkQueueNone.cpp.
25383 2016-04-18 Jon Lee <jonlee@apple.com>
25385 Update Animometer plan.
25386 https://bugs.webkit.org/show_bug.cgi?id=156652
25388 Reviewed by Darin Adler.
25390 * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199616.
25392 2016-04-18 Dana Burkart <dburkart@apple.com>
25394 svn-apply: add option for ignoring changes to ChangeLog files
25395 https://bugs.webkit.org/show_bug.cgi?id=156618
25397 Reviewed by Darin Adler.
25399 This change adds a new option to svn-apply, --skip-changelogs, which short-circuits out of
25400 patch() if the file in question is a ChangeLog.
25402 * Scripts/svn-apply:
25405 2016-04-18 Carlos Garcia Campos <cgarcia@igalia.com>
25407 Pending API Request URL is wrong after reloading
25408 https://bugs.webkit.org/show_bug.cgi?id=139342
25410 Reviewed by Darin Adler.
25412 Update test case to check that the active URL should remain the
25413 same after a reload.
25415 * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp:
25416 (TestWebKitAPI::TEST):
25418 2016-04-18 Carlos Garcia Campos <cgarcia@igalia.com>
25420 Pending API request URL no set when loading Data, Alternate HTML or plain text
25421 https://bugs.webkit.org/show_bug.cgi?id=136916
25423 Reviewed by Darin Adler.
25425 Add new test to check that active URL is the requested one right
25426 after calling WKPage load methods.
25428 * TestWebKitAPI/PlatformEfl.cmake:
25429 * TestWebKitAPI/PlatformGTK.cmake:
25430 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25431 * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
25432 (TestWebKitAPI::TEST):
25433 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
25434 (WebViewTest::loadPlainText): Remove FIXME.
25435 (WebViewTest::loadBytes): Ditto.
25436 (WebViewTest::loadAlternateHTML): Ditto.
25438 2016-04-18 Commit Queue <commit-queue@webkit.org>
25440 Unreviewed, rolling out r199660.
25441 https://bugs.webkit.org/show_bug.cgi?id=156691
25443 It broke the iOS build (Requested by KaL on #webkit).
25445 Reverted changeset:
25447 "Pending API request URL no set when loading Data, Alternate
25448 HTML or plain text"
25449 https://bugs.webkit.org/show_bug.cgi?id=136916
25450 http://trac.webkit.org/changeset/199660
25452 2016-04-18 Carlos Garcia Campos <cgarcia@igalia.com>
25454 Pending API request URL no set when loading Data, Alternate HTML or plain text
25455 https://bugs.webkit.org/show_bug.cgi?id=136916
25457 Reviewed by Darin Adler.
25459 Add new test to check that active URL is the requested one right
25460 after calling WKPage load methods.
25462 * TestWebKitAPI/PlatformEfl.cmake:
25463 * TestWebKitAPI/PlatformGTK.cmake:
25464 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25465 * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
25466 (TestWebKitAPI::TEST):
25467 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
25468 (WebViewTest::loadPlainText): Remove FIXME.
25469 (WebViewTest::loadBytes): Ditto.
25470 (WebViewTest::loadAlternateHTML): Ditto.
25472 2016-04-18 Jeremy Huddleston Sequoia <jeremyhu@apple.com>
25474 Fix incorrect assumption that APPLE implies Mac.
25475 https://bugs.webkit.org/show_bug.cgi?id=156679
25477 Addresses build failure introduced in r198947
25479 Reviewed by Alex Christensen.
25483 2016-04-18 Carlos Garcia Campos <cgarcia@igalia.com>
25485 [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
25486 https://bugs.webkit.org/show_bug.cgi?id=156621
25488 Reviewed by Martin Robinson.
25490 This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
25491 scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
25492 simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
25494 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
25495 (testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
25497 2016-04-17 Gyuyoung Kim <gyuyoung.kim@webkit.org>
25499 [EFL] Bump gstreamer from 1.4.4 to 1.6.3
25500 https://bugs.webkit.org/show_bug.cgi?id=156655
25502 Reviewed by Antonio Gomes.
25504 To support html5 video feature, we should bump gstreamer version.
25506 * efl/jhbuild.modules:
25507 * efl/patches/gst-libav.patch: Update against newer version.
25508 * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed because this patch was merged.
25510 2016-04-16 Sam Weinig <sam@webkit.org>
25514 * MiniBrowser/mac/BrowserWindowController.m:
25515 (-[BrowserWindowController share:]):
25517 2016-04-16 Sam Weinig <sam@webkit.org>
25521 * MiniBrowser/mac/BrowserWindowController.m:
25522 (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
25524 2016-04-16 Sam Weinig <sam@webkit.org>
25528 * MiniBrowser/mac/BrowserWindowController.m:
25529 (-[BrowserWindowController share:]):
25530 (-[BrowserWindowController fetch:]):
25531 (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
25533 2016-04-15 Sam Weinig <sam@webkit.org>
25535 Add support for NSSharingService to MiniBrowser, for no great reasons
25536 https://bugs.webkit.org/show_bug.cgi?id=156658
25538 Reviewed by Darin Adler.
25540 * MiniBrowser/mac/BrowserWindow.xib:
25541 * MiniBrowser/mac/BrowserWindowController.h:
25542 Add the share button.
25544 * MiniBrowser/mac/BrowserWindowController.m:
25545 (-[BrowserWindowController windowDidLoad]):
25546 Set the share button to fire it's actions on mouse down, as it is supposed to act like a menu.
25548 (-[BrowserWindowController share:]):
25549 Show the picker when the button is pressed.
25550 (-[BrowserWindowController mainContentView]):
25551 Add a new override to get the main content view of derived classes (either a WKWebView or the WebView).
25553 (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
25554 (-[BrowserWindowController sharingServicePicker:delegateForSharingService:]):
25555 (-[BrowserWindowController sharingServicePicker:didChooseSharingService:]):
25556 (-[BrowserWindowController sharingService:sourceFrameOnScreenForShareItem:]):
25557 (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
25558 (-[BrowserWindowController sharingService:sourceWindowForShareItems:sharingContentScope:]):
25559 Add delegate methods.
25561 * MiniBrowser/mac/WK1BrowserWindowController.m:
25562 (-[WK1BrowserWindowController mainContentView]):
25563 * MiniBrowser/mac/WK2BrowserWindowController.m:
25564 (-[WK2BrowserWindowController mainContentView]):
25565 Implement to return the web view.
25567 2016-04-16 Alexey Proskuryakov <ap@apple.com>
25571 Temporary workaround for rdar://problem/25754945.
25573 * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
25575 2016-04-15 Commit Queue <commit-queue@webkit.org>
25577 Unreviewed, rolling out r199600.
25578 https://bugs.webkit.org/show_bug.cgi?id=156642
25580 It didn't help (Requested by ap_ on #webkit).
25582 Reverted changeset:
25585 http://trac.webkit.org/changeset/199600
25587 2016-04-15 Alexey Proskuryakov <ap@apple.com>
25591 * LayoutTestRelay/LayoutTestRelay/main.m: Allow some deprecated methods.
25593 2016-04-14 Alexey Proskuryakov <ap@apple.com>
25595 Some GuardMalloc bots are not happy when running many parallel processes
25596 https://bugs.webkit.org/show_bug.cgi?id=156614
25597 rdar://problem/24711525
25599 Reviewed by David Kilzer.
25601 * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
25603 2016-04-14 Brent Fulgham <bfulgham@apple.com>
25605 Make <a download> a runtime enabled option
25606 https://bugs.webkit.org/show_bug.cgi?id=156583
25607 <rdar://problem/25733449>
25609 Reviewed by Alex Christensen.
25611 * DumpRenderTree/mac/DumpRenderTree.mm:
25612 (resetWebPreferencesToConsistentValues):
25613 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
25614 (WTR::InjectedBundle::beginTesting):
25615 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
25616 (WTR::TestRunner::setDownloadAttributeEnabled):
25617 * WebKitTestRunner/InjectedBundle/TestRunner.h:
25619 2016-04-14 Anders Carlsson <andersca@apple.com>
25621 Another build fix attempt.
25623 * MiniBrowser/mac/WK2BrowserWindowController.m:
25625 2016-04-14 Anders Carlsson <andersca@apple.com>
25629 * MiniBrowser/mac/WK2BrowserWindowController.m:
25630 (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
25632 2016-04-14 Anders Carlsson <andersca@apple.com>
25634 [Mac] Add API for open panel handling to WKWebView
25635 https://bugs.webkit.org/show_bug.cgi?id=137759
25636 rdar://problem/23278623
25638 Reviewed by Tim Horton.
25640 Have MiniBrowser implement the new delegate method.
25642 * MiniBrowser/mac/WK2BrowserWindowController.m:
25643 (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
25645 2016-04-14 Jiewen Tan <jiewen_tan@apple.com>
25647 Unreviewed, rolling out r199554.
25649 The change breaks Yosemite Release/Debug build
25651 Reverted changeset:
25653 "[Mac] Add API for open panel handling to WKWebView"
25654 https://bugs.webkit.org/show_bug.cgi?id=137759
25655 http://trac.webkit.org/changeset/199554
25657 2016-04-14 Anders Carlsson <andersca@apple.com>
25659 [Mac] Add API for open panel handling to WKWebView
25660 https://bugs.webkit.org/show_bug.cgi?id=137759
25661 rdar://problem/23278623
25663 Reviewed by Tim Horton.
25665 Have MiniBrowser implement the new delegate method.
25667 * MiniBrowser/mac/WK2BrowserWindowController.m:
25668 (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
25670 2016-04-14 Jon Lee <jonlee@apple.com>
25672 Update Animometer plan
25673 https://bugs.webkit.org/show_bug.cgi?id=156569
25675 Reviewed by Alex Christensen.
25677 * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199328. Includes update to screen
25678 resolution, starting with complexity of 1, and fixing SVG, multiply, and text tests.
25680 2016-04-13 Alex Christensen <achristensen@webkit.org>
25682 CMake MiniBrowser should be an app bundle
25683 https://bugs.webkit.org/show_bug.cgi?id=156521
25685 Reviewed by Brent Fulgham.
25687 * MiniBrowser/mac/CMakeLists.txt:
25688 Make an app bundle and compile nibs.
25689 * MiniBrowser/mac/Info.plist:
25690 CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it. This is just MiniBrowser.
25692 2016-04-13 Chris Dumez <cdumez@apple.com>
25694 We should not speculatively revalidate cached redirects
25695 https://bugs.webkit.org/show_bug.cgi?id=156548
25696 <rdar://problem/25583886>
25698 Reviewed by Darin Adler.
25700 Re-enable speculative loading in the context of layout tests. This was
25701 turned off by mistake when speculative loading was turned into a
25704 * WebKitTestRunner/TestController.cpp:
25705 (WTR::TestController::generatePageConfiguration):
25707 2016-04-12 Alexey Proskuryakov <ap@apple.com>
25709 Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky
25710 https://bugs.webkit.org/show_bug.cgi?id=155367
25712 Reviewed by Darin Adler.
25714 * Scripts/webkitpy/common/system/executive.py: (Executive.kill_process):
25715 Don't flakily consume the return code with waitpid, callers need to do waitpid on
25716 their own. Not sure if this line of code was even intentional.
25718 2016-04-12 Myles C. Maxfield <mmaxfield@apple.com>
25720 [OS X] Flakey crash after ScrollAnimatorMac destruction
25721 https://bugs.webkit.org/show_bug.cgi?id=156372
25723 Reviewed by Darin Adler.
25725 Implement the new <!-- webkit-test-runner --> flag.
25727 * WebKitTestRunner/TestController.cpp:
25728 (WTR::TestController::createWebViewWithOptions):
25729 (WTR::TestController::ensureViewSupportsOptionsForTest):
25730 (WTR::TestController::resetPreferencesToConsistentValues):
25731 (WTR::TestController::resetStateToConsistentValues):
25732 (WTR::updateTestOptionsFromTestHeader):
25733 * WebKitTestRunner/TestController.h:
25734 * WebKitTestRunner/TestInvocation.cpp:
25735 (WTR::TestInvocation::invoke):
25736 * WebKitTestRunner/TestOptions.h:
25737 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
25738 (WKR::PlatformWebView::viewSupportsOptions):
25740 2016-04-12 Tomas Popela <tpopela@redhat.com>
25742 Modify the CXXFLAGS in webkitdirs.pm just on architectures where the flags are supported
25743 https://bugs.webkit.org/show_bug.cgi?id=156338
25745 Reviewed by Michael Catanzaro.
25747 Add the "-march=pentium4 -msse2 -mfpmath=sse " into the CXXFLAGS just
25748 for the i686 where it is supported and not for other architectures
25749 (such as s390(x) and ppc(64)) where the build will fail with these
25752 * Scripts/webkitdirs.pm:
25753 (generateBuildSystemFromCMakeProject):
25755 2016-04-11 Alex Christensen <achristensen@webkit.org>
25757 Build MiniBrowser with CMake on Mac
25758 https://bugs.webkit.org/show_bug.cgi?id=156471
25760 Reviewed by Daniel Bates.
25763 * DumpRenderTree/CMakeLists.txt:
25764 * DumpRenderTree/PlatformWin.cmake:
25765 * MiniBrowser/mac/CMakeLists.txt: Added.
25767 2016-04-11 Ryuan Choi <ryuan.choi@navercorp.com>
25769 [EFL] Do not pass context to EwkViewCreate
25770 https://bugs.webkit.org/show_bug.cgi?id=156461
25772 Reviewed by Darin Adler.
25774 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
25775 (TestWebKitAPI::TEST): Removed context argument from EwkViewCreate calls.
25776 * TestWebKitAPI/efl/PlatformWebView.cpp:
25777 (TestWebKitAPI::PlatformWebView::PlatformWebView): Ditto.
25778 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
25779 (WTR::PlatformWebView::PlatformWebView): Ditto.
25781 2016-04-11 Fujii Hironori <Hironori.Fujii@jp.sony.com>
25783 [CMake] Make FOLDER property INHERITED
25784 https://bugs.webkit.org/show_bug.cgi?id=156460
25786 Reviewed by Brent Fulgham.
25789 * DumpRenderTree/CMakeLists.txt:
25790 * DumpRenderTree/PlatformWin.cmake:
25791 * ImageDiff/CMakeLists.txt:
25792 * MiniBrowser/efl/CMakeLists.txt:
25793 * MiniBrowser/gtk/CMakeLists.txt:
25794 * MiniBrowser/win/CMakeLists.txt:
25795 Set FOLDER property as a directory property not a target property
25797 2016-04-10 Caitlin Potter <caitp@igalia.com>
25799 [Tools] correctly check for braces in multiline branches in macro definition
25800 https://bugs.webkit.org/show_bug.cgi?id=156441
25802 Reviewed by Darin Adler.
25804 Prevents emitting whitespace/braces warning for code like the
25815 * Scripts/webkitpy/style/checkers/cpp.py:
25817 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
25818 (WebKitStyleTest.test_line_breaking):
25820 2016-04-08 Youenn Fablet <youenn.fablet@crf.canon.fr>
25822 Testharness-based tests that time out should be able to produce a detailed output
25823 https://bugs.webkit.org/show_bug.cgi?id=145313
25825 Reviewed by Xabier Rodriguez-Calvar.
25827 Adding timeout readonly accessor to TestRunner for both WK1 and WK2.
25829 * DumpRenderTree/TestRunner.cpp:
25830 (getTimeoutCallback): The js "timeout" property getter.
25831 (TestRunner::staticValues): Adding "timeout" property to DumpRenderTree so that testRunner.timeout called from JS returns the timeout value.
25832 * DumpRenderTree/TestRunner.h:
25833 (TestRunner::timeout): Adding access to DRT m_timeout private value.
25834 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding timeout readonly attribute so that testRunner.timeout can be called from JS.
25835 * WebKitTestRunner/InjectedBundle/TestRunner.h: Adding DOM timeout getter to implement timeout IDL definition.
25836 (WTR::TestRunner::timeout):
25838 2016-04-07 Joseph Pecoraro <pecoraro@apple.com>
25840 stylebot should know about TestWebKitAPI FeatureDefines.xcconfig
25841 https://bugs.webkit.org/show_bug.cgi?id=156387
25843 Rubber-stamped by Dan Bernstein.
25845 * Scripts/webkitpy/style/checkers/featuredefines.py:
25846 (FeatureDefinesChecker.check):
25848 2016-04-07 Joseph Pecoraro <pecoraro@apple.com>
25850 Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
25851 https://bugs.webkit.org/show_bug.cgi?id=156384
25853 Reviewed by Ryosuke Niwa.
25855 * Scripts/webkitperl/FeatureList.pm:
25856 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
25858 2016-04-06 Dean Jackson <dino@apple.com>
25860 Watchlist modifications:
25861 - remove roger_fong
25862 - add myself to a few areas
25863 - remove graouts from WebInspectorAPI
25865 * Scripts/webkitpy/common/config/watchlist:
25867 2016-04-07 Simon Fraser <simon.fraser@apple.com>
25869 Make it possible to test effect of view exposed rect on tiled backing
25870 https://bugs.webkit.org/show_bug.cgi?id=156365
25872 Reviewed by Tim Horton.
25874 Expose testRunner.setViewSize() and internals.setViewExposedRect() to enable
25875 testing of tile coverage when setViewExposedRect() is passed a non-null rectangle.
25877 testRunner.setViewSize() is used instead of using window.resizeTo(), since we
25878 can't easily resize a window to larger than the screen being tested on.
25880 * DumpRenderTree/TestRunner.cpp:
25881 (setViewSizeCallback):
25882 (TestRunner::staticFunctions):
25883 * DumpRenderTree/TestRunner.h:
25884 * DumpRenderTree/mac/TestRunnerMac.mm:
25885 (TestRunner::setViewSize):
25886 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
25887 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
25888 (WTR::InjectedBundle::postSetViewSize):
25889 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
25890 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
25891 (WTR::TestRunner::setViewSize):
25892 * WebKitTestRunner/InjectedBundle/TestRunner.h:
25893 * WebKitTestRunner/TestInvocation.cpp:
25894 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
25896 2016-04-07 Jason Marcell <jmarcell@apple.com>
25898 Adding layout tests for the bot watcher's dashboard QUnit tests.
25899 https://bugs.webkit.org/show_bug.cgi?id=155272
25901 Reviewed by Daniel Bates.
25903 Moved supporting resources into a resources folder and updated index.html accordingly
25904 to point to the new locations. Added code to tests.js to dumpAsText when QUnit is done.
25906 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt: Added.
25907 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Updated to point to tests.js and Mock files in resources directory.
25908 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js: Renamed from
25909 Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js.
25910 (MockBuildbotQueue):
25911 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueueView.js: Renamed from
25912 Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js.
25913 (MockBuildbotQueueView):
25914 (MockBuildbotQueueView.prototype._latestProductiveIteration):
25915 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js: Renamed from
25916 Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js.
25918 (MockTrac.prototype.get oldestRecordedRevisionNumber):
25919 (MockTrac.prototype.get latestRecordedRevisionNumber):
25920 (MockTrac.prototype.loadMoreHistoricalData):
25921 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-git-trac-rss.xml: Renamed from
25922 Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml.
25923 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-trac-rss.xml: Renamed from
25924 Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml.
25925 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Renamed from
25926 Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js.
25927 Updated the unit tests for Trac._loaded() to point to the XML files that are now located in the 'resources' directory.
25928 (QUnit.done): Added. Removes machine-specific output from test results and calls testRunner.notifyDone to let the layout test harness know that all testing is done.
25929 * Scripts/run-dashboard-tests: Added.
25931 2016-04-06 ChangSeok Oh <changseok@webkit.org>
25933 Unreviewed, Update my primary email address and expertise.
25935 * Scripts/webkitpy/common/config/contributors.json:
25937 2016-04-06 Jon Lee <jonlee@apple.com>
25939 Update the Animometer patch and plan files
25940 https://bugs.webkit.org/show_bug.cgi?id=156263
25942 Reviewed by Ryosuke Niwa.
25944 Measure the latest set of tests by updating the plan revision to r199134.
25946 * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Update to run the master suite only.
25947 * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to use the release page instead
25948 of the developer page.
25950 2016-04-06 Saam barati <sbarati@apple.com>
25952 jsc-layout-tests.yaml/js/script-tests/regress-141098.js failing on Yosemite Debug after r198989
25953 https://bugs.webkit.org/show_bug.cgi?id=156187
25955 Reviewed by Keith Miller.
25957 * Scripts/run-jsc-stress-tests:
25959 2016-04-06 Alex Christensen <achristensen@webkit.org>
25961 Compile WebKitTestRunner with CMake on Mac
25962 https://bugs.webkit.org/show_bug.cgi?id=156310
25964 Reviewed by Daniel Bates.
25967 * WebKitTestRunner/CMakeLists.txt:
25968 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
25969 * WebKitTestRunner/PlatformEfl.cmake:
25970 * WebKitTestRunner/PlatformGTK.cmake:
25971 * WebKitTestRunner/PlatformMac.cmake: Added.
25973 2016-04-05 Simon Fraser <simon.fraser@apple.com>
25975 Implement operator== and operator!= for Optional<>
25976 https://bugs.webkit.org/show_bug.cgi?id=156266
25978 Reviewed by Anders Carlsson.
25980 * TestWebKitAPI/Tests/WTF/Optional.cpp:
25981 (TestWebKitAPI::TEST):
25983 2016-04-05 Alex Christensen <achristensen@webkit.org>
25985 Make CMake-generated binaries on Mac able to run
25986 https://bugs.webkit.org/show_bug.cgi?id=156268
25988 Reviewed by Daniel Bates.
25990 * DumpRenderTree/CMakeLists.txt:
25991 * DumpRenderTree/PlatformMac.cmake:
25992 * DumpRenderTree/PlatformWin.cmake:
25993 * TestWebKitAPI/PlatformMac.cmake:
25995 2016-04-05 Youenn Fablet <youenn.fablet@crf.canon.fr>
25997 [Fetch API] Add a runtime flag to fetch API and related constructs
25998 https://bugs.webkit.org/show_bug.cgi?id=156113
26000 Reviewed by Alex Christensen.
26002 * DumpRenderTree/TestRunner.h:
26003 * DumpRenderTree/mac/DumpRenderTree.mm:
26004 (resetWebPreferencesToConsistentValues):
26005 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
26006 (WTR::InjectedBundle::beginTesting):
26007 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
26008 (WTR::TestRunner::setWebGL2Enabled):
26009 (WTR::TestRunner::setFetchAPIEnabled):
26010 (WTR::TestRunner::setAllowUniversalAccessFromFileURLs):
26011 * WebKitTestRunner/InjectedBundle/TestRunner.h:
26013 2016-04-05 Keith Miller <keith_miller@apple.com>
26015 Make Keith a reviewer!
26016 https://bugs.webkit.org/show_bug.cgi?id=156246
26018 Reviewed by Mark Lam.
26020 * Scripts/webkitpy/common/config/contributors.json:
26022 2016-04-05 Antoine Quint <graouts@apple.com>
26024 [WebGL2] Allow enabling WebGL2 with a runtime flag
26025 https://bugs.webkit.org/show_bug.cgi?id=156166
26026 <rdar://problem/25526929>
26028 Always enable WebGL2 during testing.
26030 Reviewed by Dean Jackson.
26032 * DumpRenderTree/mac/DumpRenderTree.mm:
26033 (resetWebPreferencesToConsistentValues):
26034 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
26035 (WTR::InjectedBundle::beginTesting):
26036 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
26037 (WTR::TestRunner::setWebGL2Enabled):
26038 * WebKitTestRunner/InjectedBundle/TestRunner.h:
26040 2016-04-04 Bill Ming <mbbill@gmail.com>
26042 [win] run-webkit-tests failed to launch DumpRenderTree
26043 https://bugs.webkit.org/show_bug.cgi?id=156150
26045 Reviewed by Alex Christensen.
26047 * Tools/Scripts/webkitpy/port/base.py:
26049 2016-04-04 Bill Ming <mbbill@gmail.com>
26051 prepare-ChangeLog set endl incorrectly.
26052 https://bugs.webkit.org/show_bug.cgi?id=156151
26054 Reviewed by Alex Christensen.
26056 * Tools/Scripts/prepare-ChangeLog:
26058 2016-04-03 Sam Weinig <sam@webkit.org>
26060 Add SPI to allow install script message handlers in isolated worlds
26061 https://bugs.webkit.org/show_bug.cgi?id=156153
26063 Reviewed by Anders Carlsson.
26065 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
26066 Add new test, WKUserContentController.ScriptMessageHandlerBasicPostIsolatedWorld
26068 2016-04-04 Jiewen Tan <jiewen_tan@apple.com>
26070 Build fix for r198956.
26074 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
26075 (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
26076 * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
26077 (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
26079 2016-04-04 Bill Ming <mbbill@gmail.com>
26081 [win] prepare-ChangeLog should treat windows path differently.
26082 https://bugs.webkit.org/show_bug.cgi?id=156120
26084 Reviewed by Brent Fulgham.
26086 * Scripts/prepare-ChangeLog:
26088 2016-04-04 Alejandro G. Castro <alex@igalia.com>
26090 REGRESSION(r198492): [GTK] The WEB_RTC flag was not correctly added in some situations
26091 https://bugs.webkit.org/show_bug.cgi?id=156164
26093 Reviewed by Philippe Normand.
26095 Enable the new WEB_RTC option by default for Gtk+.
26097 * Scripts/webkitperl/FeatureList.pm:
26099 2016-04-03 Dan Bernstein <mitz@apple.com>
26101 Use the correct value for the first nightly build with frameworks built for OS X 10.11.
26103 * Scripts/bisect-builds:
26106 2016-04-03 Dan Bernstein <mitz@apple.com>
26108 Made bisect-builds work again.
26110 Rubber-stamped by Sam Weinig.
26112 * Scripts/bisect-builds:
26113 Changed to use HTTPS to access nightly.webkit.org, and added a minimum revision for OS X 10.11.
26115 2016-04-01 Jiewen Tan <jiewen_tan@apple.com>
26117 Build fix for r198956.
26121 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
26122 * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm.
26123 (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]):
26124 (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]):
26126 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
26127 (-[LoadInvalidSchemeDelegate browsingContextController:didFailProvisionalLoadWithError:]):
26128 (TestWebKitAPI::TEST):
26130 2016-04-01 Jiewen Tan <jiewen_tan@apple.com>
26132 WebKit should dispatchDidFailProvisionalLoad while loading invalid URLs
26133 https://bugs.webkit.org/show_bug.cgi?id=155995
26134 <rdar://problem/14967004>
26136 Reviewed by Andy Estes.
26138 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
26139 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm:
26140 (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
26141 (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didStartProvisionalNavigation:]):
26143 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: Added.
26145 (-[LoadInvalidURLNavigationActionDelegate webView:didCommitNavigation:]):
26146 (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
26147 (TestWebKitAPI::TEST):
26148 * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html: Added.
26149 * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm: Added.
26150 (-[LoadInvalidURLWebFrameLoadDelegate webView:didCommitLoadForFrame:]):
26151 (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
26152 (TestWebKitAPI::TEST):
26154 2016-04-01 Brent Fulgham <bfulgham@apple.com>
26156 Confirm <a download> satisfies specification criteria
26157 https://bugs.webkit.org/show_bug.cgi?id=156057
26159 Reviewed by Andy Estes.
26161 Revise WebKitTestRunner:
26162 (1) Provide a download client delegate.
26163 (2) Teach WKTR to wait to finish a test until a download finishes.
26164 (3) Allow WKTR to notify the current TestRunner that it can finish.
26166 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
26167 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
26168 (WTR::InjectedBundle::didReceiveMessageToPage): Update to recognize a new
26169 message "NotifyDownloadDone".
26170 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
26171 (WTR::InjectedBundlePage::decidePolicyForNavigationAction): Handle 'download'
26173 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
26174 (WTR::TestRunner::waitUntilDownload): Added.
26175 * WebKitTestRunner/InjectedBundle/TestRunner.h:
26176 (WTR::TestRunner::shouldFinishAfterDownload): Added.
26177 * WebKitTestRunner/TestController.cpp:
26178 (WTR::TestController::createWebViewWithOptions): Set up the download client.
26179 (WTR::TestController::downloadDidStart): Added.
26180 (WTR::TestController::decideDestinationWithSuggestedFilename): Added.
26181 (WTR::TestController::downloadDidFinish): Added.
26182 (WTR::TestController::downloadDidFail): Added.
26183 (WTR::TestController::downloadDidCancel): Added.
26184 * WebKitTestRunner/TestController.h:
26185 * WebKitTestRunner/TestInvocation.cpp:
26186 (WTR::TestInvocation::notifyDownloadDone): Added.
26187 * WebKitTestRunner/TestInvocation.h:
26189 2016-04-01 Alex Christensen <achristensen@webkit.org>
26191 Compile DumpRenderTree with CMake on Mac
26192 https://bugs.webkit.org/show_bug.cgi?id=156088
26194 Reviewed by Brent Fulgham.
26197 * DumpRenderTree/CMakeLists.txt:
26198 * DumpRenderTree/DefaultPolicyDelegate.m:
26199 (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
26200 * DumpRenderTree/DumpRenderTreeFileDraggingSource.m:
26201 * DumpRenderTree/PlatformMac.cmake: Added.
26202 * DumpRenderTree/PlatformWin.cmake:
26203 * DumpRenderTree/mac/AppleScriptController.m:
26204 (convertAEDescToObject):
26205 * DumpRenderTree/mac/DumpRenderTreeMain.mm:
26206 * DumpRenderTree/mac/LayoutTestHelper.m:
26208 2016-03-31 Bill Ming <mbbill@gmail.com>
26210 https://bugs.webkit.org/show_bug.cgi?id=156094
26211 [Win] TestWebCore target build sometimes fail.
26213 Reviewed by Alex Christensen.
26215 * Tools/TestWebKitAPI/PlatformWin.cmake:
26217 2016-03-31 Gyuyoung Kim <gyuyoung.kim@webkit.org>
26219 [EFL] Bump EFL version to 1.17.0
26220 https://bugs.webkit.org/show_bug.cgi?id=153008
26222 Reviewed by Michael Catanzaro.
26224 Original author is Csaba Osztrogonác <ossy@webkit.org>
26226 * efl/jhbuild.modules:
26228 2016-03-31 Daniel Bates <dabates@apple.com>
26230 run-webkit-tests fails to create user's cache directory when System Integrity Protection is enabled
26231 https://bugs.webkit.org/show_bug.cgi?id=156071
26232 <rdar://problem/25467827>
26234 Reviewed by Brent Fulgham.
26236 Fixes an issue where run-webkit-tests will fail to create the suffixed user's cache directory
26237 on non-Apple Internal machines with System Integrity Protection enabled because the OS only
26238 honors the suffix, specified by the environment variable DIRHELPER_USER_DIR_SUFFIX, in
26239 privileged processes. And python(1) does not have sufficient privileges. As a workaround for
26240 systems that have System Integrity Protection enabled we compute the path to the suffixed
26241 user's cache directory by hand.
26243 Additionally, fix an issue where the user's cache directory created by run-webkit-test was
26244 never deleted on cessation of the test run.
26246 * Scripts/webkitpy/port/driver.py:
26247 (Driver._start): Actually store the path to the user's cache directory in self._driver_user_cache_directory
26248 so that we can delete this directory on cessation of the test run.
26249 * Scripts/webkitpy/port/mac.py:
26251 (MacPort._path_to_user_cache_directory): Unset the environment variable DIRHELPER_USER_DIR_SUFFIX (if set),
26252 query the OS for the path to the user's cache directory and concatenate this path with the
26255 2016-03-31 Jiewen Tan <jiewen_tan@apple.com>
26257 WebKit should set Original URL of a download request correctly
26258 https://bugs.webkit.org/show_bug.cgi?id=155914
26259 <rdar://problem/10473811>
26261 Reviewed by Anders Carlsson.
26263 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
26264 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
26265 (-[DownloadRequestOriginalURLDelegate initWithExpectOriginalURL:]):
26266 (-[DownloadRequestOriginalURLDelegate _downloadDidStart:]):
26267 (-[DownloadRequestOriginalURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
26269 * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL.html: Added.
26270 * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL2.html: Added.
26271 * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURLFrame.html: Added.
26273 2016-03-30 Dewei Zhu <dewei_zhu@apple.com>
26275 Extend animometer timeout for slow CPUs.
26276 https://bugs.webkit.org/show_bug.cgi?id=156047
26278 Reviewed by Ryosuke Niwa.
26280 Extend animometer timeout to 30 minutes for slow device.
26282 * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan:
26284 2016-03-30 Daniel Bates <dabates@apple.com>
26286 run-webkit-tests must create parent directory of user's cache directory before running tests
26287 https://bugs.webkit.org/show_bug.cgi?id=156009
26288 <rdar://problem/25442682>
26290 Reviewed by Alexey Proskuryakov.
26292 The script run-webkit-tests must create the parent directory of the user's cache directory
26293 before running tests because a WebKit2 child process expects that this directory exists
26296 The script run-webkit-tests influences the path chosen by a WebKit2 child process for the
26297 user's temporary directory and user's cache directory via the environment variable
26298 DIRHELPER_USER_DIR_SUFFIX. For the user's temporary directory, run-webkit-tests creates it
26299 as part of setting up the test environment. But run-webkit-tests does not create the user's
26300 cache directory. Therefore there is race between the time AppKit creates it and when the
26301 launched WebContent and Network processes query for the path to the user's cache directory
26302 such that the OS may return the empty string to the WebContent and Network processes if
26303 queried for this directory before AppKit creates it.
26305 * Scripts/webkitpy/port/base.py:
26306 (Port._path_to_user_cache_directory): Added. Base class implementation that returns the
26307 empty string. We will override this method for the OS X port to return the path to the
26308 user's cache directory with the specified suffix.
26309 (Port.remove_cache_directory): Deleted.
26310 * Scripts/webkitpy/port/driver.py:
26311 (Driver.__init__): Initialize self._driver_user_directory_suffix and self._driver_user_cache_directory
26312 to the suffix to use for the user's temporary and cache directories and the path to the
26313 user's cache directory, respectively.
26314 (Driver._setup_environ_for_driver): Modified to set the environment variable DIRHELPER_USER_DIR_SUFFIX
26315 to self._driver_user_directory_suffix.
26316 (Driver._start): Compute the user directory suffix and the path to the user's cache
26317 directory. Create the user's cache directory (if applicable).
26318 (Driver.stop): Modified to remove directory self._driver_user_cache_directory (if applicable).
26319 * Scripts/webkitpy/port/mac.py:
26320 (MacPort.user_cache_directory): Added. Overrides Port._path_to_user_cache_directory().
26321 (MacPort.remove_cache_directory): Deleted.
26323 2016-03-29 Benjamin Poulain <bpoulain@apple.com>
26325 [WTF] Removing a smart pointer from HashTable issues two stores to the same location
26326 https://bugs.webkit.org/show_bug.cgi?id=155676
26328 Reviewed by Darin Adler.
26330 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
26331 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
26333 2016-03-29 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
26335 Add machine-readable results for JSC stress tests
26336 https://bugs.webkit.org/show_bug.cgi?id=155771
26338 Reviewed by Darin Adler and Dean Johnson
26340 Add an option to output JSC stress test results to a user-specified file in JSON format.
26342 * Scripts/run-javascriptcore-tests:
26343 (runJSCStressTests): Add JSON output support
26344 (readAllLines): Remove trailing newline from the end of each item
26346 2016-03-29 Alex Christensen <achristensen@webkit.org>
26350 * TestWebKitAPI/PlatformWin.cmake:
26352 2016-03-29 Timothy Hatcher <timothy@apple.com>
26354 Update WebKit nightly to have a red needle to better match Safari
26356 https://bugs.webkit.org/show_bug.cgi?id=155983
26358 Reviewed by Joseph Pecoraro.
26360 * WebKitLauncher/webkit.icns:
26362 2016-03-28 Joanmarie Diggs <jdiggs@igalia.com>
26364 Adding myself as a reviewer.
26368 * Scripts/webkitpy/common/config/contributors.json:
26370 2016-03-25 Dewei Zhu <dewei_zhu@apple.com>
26372 Dromaeo patch used by run-benchmark should not include an invalid address.
26373 https://bugs.webkit.org/show_bug.cgi?id=155910
26375 Reviewed by Ryosuke Niwa.
26377 Should not use invalid 'http://127.0.0.1/Icons/w3c_home' in the patched version of test.
26378 * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
26380 2016-03-25 Daniel Bates <dabates@apple.com>
26382 Add WebKitSystemInterface for iOS 9.3
26383 https://bugs.webkit.org/show_bug.cgi?id=155893
26385 Rubber-stamped by Alexey Proskuryakov.
26387 * Scripts/copy-webkitlibraries-to-product-directory:
26389 2016-03-25 Daniel Bates <dabates@apple.com>
26391 Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK()
26392 in copy-webkitlibraries-to-product-directory
26393 https://bugs.webkit.org/show_bug.cgi?id=155869
26395 Reviewed by Alexey Proskuryakov.
26397 It is sufficient and more direct to call webkitdirs::determineXcodeSDK() instead of
26398 webkitdirs::willUseIOSDeviceSDK() to process the --sdk/--device/--ios-simulator command
26401 * Scripts/copy-webkitlibraries-to-product-directory:
26403 2016-03-25 Konstantin Tokarev <annulen@yandex.ru>
26405 Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port.
26406 https://bugs.webkit.org/show_bug.cgi?id=155882
26408 Reviewed by Michael Catanzaro.
26410 It was already enabled in all trunk ports, and is required for
26411 WebInspectorUI to work.
26413 * Scripts/webkitperl/FeatureList.pm:
26415 2016-03-24 Jeremy Zerfas <WebKit@JeremyZerfas.com>
26417 Improve update-webkit-dependency script.
26418 https://bugs.webkit.org/show_bug.cgi?id=155576
26420 Reviewed by Brent Fulgham.
26422 * Scripts/update-webkit-dependency:
26423 -Updated script to also use ETags for helping to determine whether dependency is up to date.
26424 -Updated script so it usually won't need to download the entire dependency each time it is
26426 -Updated script to ensure zip file contains expected directories before trying to install.
26427 -Added some more error checking and improved error messages.
26428 (lastModifiedToUnixTime): Deleted.
26430 * Scripts/update-webkit-wincairo-libs:
26431 -Corrected comment about what script does.
26433 2016-03-24 Bill Ming <mbbill@gmail.com>
26435 Fix webkitpy tests after r198617
26436 https://bugs.webkit.org/show_bug.cgi?id=155827
26438 Reviewed by Alex Christensen.
26440 * Scripts/webkitpy/tool/steps/confirmdiff.py:
26441 (ConfirmDiff._show_pretty_diff):
26443 2016-03-23 Bill Ming <mbbill@gmail.com>
26445 webkit-patch failed to open pretty diff on Windows
26446 https://bugs.webkit.org/show_bug.cgi?id=155827
26448 Reviewed by Alex Christensen.
26450 * Scripts/webkitpy/tool/steps/confirmdiff.py:
26451 (ConfirmDiff._show_pretty_diff):
26453 2016-03-23 Jer Noble <jer.noble@apple.com>
26455 [ios-sim] RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForVideoButNotAudioPlayback failing
26456 https://bugs.webkit.org/show_bug.cgi?id=155764
26458 Reviewed by Eric Carlson.
26460 Remove the requirement for media elements to have webkit-playsinline attributes on iOS.
26462 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
26463 (RequiresUserActionForPlaybackTest::SetUp):
26465 2016-03-23 Anders Carlsson <andersca@apple.com>
26467 Crash when using KVO from within -[WebView initWithCoder:]
26468 https://bugs.webkit.org/show_bug.cgi?id=155816
26469 rdar://problem/17073265
26471 Reviewed by Dan Bernstein.
26475 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
26476 * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Added.
26477 (-[EarlyKVOCrashResponder initWithWebView:]):
26478 (-[EarlyKVOCrashResponder initWithCoder:]):
26479 (-[EarlyKVOCrashResponder dealloc]):
26480 (-[EarlyKVOCrashResponder encodeWithCoder:]):
26481 (TestWebKitAPI::TEST):
26483 2016-03-23 Lucas Forschler <lforschler@apple.com>
26485 Teach kill-old-processes about perl 5.18.
26487 Reviewed by Alexey Proskuryakov
26489 * BuildSlaveSupport/kill-old-processes:
26492 2016-03-22 Keith Rollin <krollin@apple.com>
26494 Unreviewed: add Keith Rollin to the committers list.
26496 * Scripts/webkitpy/common/config/contributors.json:
26498 2016-03-22 Per Arne Vollan <peavo@outlook.com>
26500 [Win] [64-bit] Remove MSVC 2013 FMA3 Bug Workaround
26501 https://bugs.webkit.org/show_bug.cgi?id=141499
26503 Reviewed by Brent Fulgham.
26505 As we have moved on to VS2015, this workaround is no longer needed.
26507 * DumpRenderTree/cg/ImageDiffCG.cpp:
26509 * DumpRenderTree/win/DumpRenderTree.cpp:
26511 * DumpRenderTree/win/ImageDiffCairo.cpp:
26513 * MiniBrowser/win/Common.cpp:
26515 * TestWebKitAPI/win/main.cpp:
26517 * win/DLLLauncher/DLLLauncherMain.cpp:
26520 2016-03-22 Yusuke Suzuki <utatane.tea@gmail.com>
26522 [JSC] ASMBench cannot be run without JSBENCH_PATH
26523 https://bugs.webkit.org/show_bug.cgi?id=155751
26525 Reviewed by Saam Barati.
26527 Check ASMBENCH_PATH instead of JSBENCH_PATH for ASMBench files.
26529 * Scripts/run-jsc-benchmarks:
26531 2016-03-21 Brent Fulgham <bfulgham@apple.com>
26533 [Win] SharedBuffer::copy() can cause a segmentation fault.
26534 https://bugs.webkit.org/show_bug.cgi?id=155739
26536 Reviewed by Ryosuke Niwa.
26538 * TestWebKitAPI/PlatformWin.cmake: Build and run the
26539 SharedBuffer tests.
26541 2016-03-22 Csaba Osztrogonác <ossy@webkit.org>
26543 [buildbot] Move ARM Linux bots to JSCOnly port
26544 https://bugs.webkit.org/show_bug.cgi?id=155655
26546 Reviewed by Lucas Forschler.
26548 * BuildSlaveSupport/build.webkit.org-config/config.json:
26549 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
26550 (ConfigureBuild.__init__):
26551 (appendCustomBuildFlags):
26553 (Factory.__init__):
26554 (BuildAndRemoteJSCTestsFactory):
26555 (BuildAndRemoteJSCTestsFactory.__init__):
26556 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
26557 * BuildSlaveSupport/clean-build:
26560 2016-03-21 Brent Fulgham <bfulgham@apple.com>
26562 Improve SharedBuffer testing
26563 https://bugs.webkit.org/show_bug.cgi?id=93078
26564 <rdar://problem/25277829>
26566 Reviewed by Ryosuke Niwa.
26568 Based on a Blink patch by Huang Dongsung <luxtella@company100.net>.
26569 <https://src.chromium.org/viewvc/blink?revision=153850&view=revision,
26570 and a Blink patch by <tyoshino@chromium.org>
26571 <https://src.chromium.org/viewvc/blink?view=rev&revision=151617>
26573 Add three test cases from the Blink project that cover various append,
26574 copy, and createArrayBuffer calls.
26576 * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
26577 (TestWebKitAPI::TEST_F):
26579 2016-03-21 Hyungwook Lee <hyungwook.lee@navercorp.com>
26581 [Win] Connect layoutTestController.findString() to support testing
26582 https://bugs.webkit.org/show_bug.cgi?id=50234
26584 Reviewed by Alex Christensen.
26586 Implement TestRunner::findString().
26588 * DumpRenderTree/win/TestRunnerWin.cpp:
26589 (TestRunner::findString):
26591 2016-03-20 Dan Bernstein <mitz@apple.com>
26593 [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR
26594 https://bugs.webkit.org/show_bug.cgi?id=155707
26595 <rdar://problem/24980691>
26597 Reviewed by Darin Adler.
26599 * ContentExtensionTester/Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR
26600 based on the last component of MACOSX_DEPLOYMENT_TARGET.
26601 * ContentExtensionTester/Configurations/DebugRelease.xcconfig: For engineering builds,
26602 preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.
26604 Similarly for these projects:
26606 * DumpRenderTree/mac/Configurations/Base.xcconfig:
26607 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
26608 * LayoutTestRelay/Configurations/Base.xcconfig:
26609 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
26610 * MiniBrowser/Configurations/Base.xcconfig:
26611 * MiniBrowser/Configurations/DebugRelease.xcconfig:
26612 * TestWebKitAPI/Configurations/Base.xcconfig:
26613 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
26614 * WebEditingTester/Configurations/Base.xcconfig:
26615 * WebEditingTester/Configurations/DebugRelease.xcconfig:
26616 * WebKitTestRunner/Configurations/Base.xcconfig:
26617 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
26619 2016-03-20 Dan Bernstein <mitz@apple.com>
26621 Update build settings
26623 Rubber-stamped by Andy Estes.
26625 * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
26626 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
26627 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
26628 * MiniBrowser/Configurations/DebugRelease.xcconfig:
26629 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
26630 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Synced up to the ones in ../Source.
26631 * WebEditingTester/Configurations/DebugRelease.xcconfig:
26632 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
26633 * asan/asan.xcconfig:
26635 2016-03-18 Sam Weinig <sam@webkit.org>
26637 Add test for HashMap::ensure that shows that moving into the lambda does not incure extra cost
26638 https://bugs.webkit.org/show_bug.cgi?id=155621
26640 Reviewed by Alex Christensen.
26642 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
26643 (TestWebKitAPI::ObjectWithRefLogger::ObjectWithRefLogger):
26644 (TestWebKitAPI::testMovingUsingEnsure):
26645 (TestWebKitAPI::testMovingUsingAdd):
26646 Add tests ensuring that objects moved into a map using ensure don't
26647 have extra ref-churn.
26649 2016-03-17 Tim Horton <timothy_horton@apple.com>
26651 Fix some deprecation warnings in WebEditingTester
26652 https://bugs.webkit.org/show_bug.cgi?id=155601
26654 Reviewed by Simon Fraser.
26656 * WebEditingTester/AppDelegate.m:
26657 (-[WebEditingAppDelegate showOperations:]):
26658 (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
26660 2016-03-17 Tim Horton <timothy_horton@apple.com>
26662 Find-in-page indicator in Mail viewer is the wrong scale and cut off
26663 https://bugs.webkit.org/show_bug.cgi?id=155605
26664 <rdar://problem/23948165>
26666 Reviewed by Simon Fraser.
26668 * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
26670 Add a test that ensures that the find result image is correctly @2x.
26671 The NSImage size should be in points.
26673 2016-03-16 Commit Queue <commit-queue@webkit.org>
26675 Unreviewed, rolling out r198187.
26676 https://bugs.webkit.org/show_bug.cgi?id=155564
26678 Potentially break testing on iOS (Requested by Guest23 on
26681 Reverted changeset:
26683 "Add twisted-15.5.0 module to
26684 webkitpy.thirdparty.autoinstalled."
26685 https://bugs.webkit.org/show_bug.cgi?id=154667
26686 http://trac.webkit.org/changeset/198187
26688 2016-03-16 David Kilzer <ddkilzer@apple.com>
26690 check-webkit-style: should warn about blank lines after #include "config.h" in TestWebKitAPI
26691 <http://webkit.org/b/155445>
26693 Reviewed by Darin Adler.
26695 * Scripts/webkitpy/style/checker.py:
26696 (_PATH_RULES_SPECIFIER): Do not ignore "build/include*" checks
26697 on TestWebKitAPI since this project uses a config.h header as of
26698 r95188. Also remove references to WebKitAPITest, which ceased
26699 to exist in r95944.
26701 * Scripts/webkitpy/style/checker_unittest.py:
26702 (GlobalVariablesTest.test_path_rules_specifier): Add tests.
26703 Remove reference to WebKitAPITest project.
26705 2016-03-16 Tim Horton <timothy_horton@apple.com>
26707 [mac] Printing test snapshots are upside-down after r198242
26708 https://bugs.webkit.org/show_bug.cgi?id=155543
26710 Reviewed by Simon Fraser.
26712 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
26713 (createPagedBitmapContext):
26714 Flip printing snapshots in DRT so that everything is right-side-up.
26716 2016-03-16 Alexey Proskuryakov <ap@apple.com>
26718 Update unit test for iOS debug queues.
26720 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
26722 2016-03-16 Jiewen Tan <jiewen_tan@apple.com>
26724 URL Parsing should signal failure for illegal IDN
26725 https://bugs.webkit.org/show_bug.cgi?id=154945
26726 <rdar://problem/8014795>
26728 Reviewed by Brent Fulgham.
26730 * MiniBrowser/mac/WK2BrowserWindowController.m:
26731 (-[WK2BrowserWindowController fetch:]):
26732 * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
26733 (TestWebKitAPI::TEST):
26735 2016-03-15 Tim Horton <timothy_horton@apple.com>
26737 [iOS Simulator] Test result snapshots are upside down
26738 https://bugs.webkit.org/show_bug.cgi?id=154761
26740 Reviewed by Simon Fraser.
26742 * WebKitTestRunner/cg/TestInvocationCG.cpp:
26743 (WTR::createCGContextFromImage):
26744 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
26745 In r97104, Simon added code to take WindowServer snapshots, which came
26746 in flipped, and added code to flip them back. At this point, WindowServer
26747 snapshots got flipped, and software snapshots did not.
26749 In r140067, Simon noticed that WindowServer ref test images were upside-down
26750 on Mac (not sure why this changed), so turned off the flipping code (but
26751 didn't delete it!). Now, WindowServer snapshots and software snapshots both
26754 In r190304, Carlos added an enum for the source of the snapshot ("WebView"
26755 for window server snapshots, and "WebContent" for software snapshots),
26756 and - critically - changed the flipping logic to flip software snapshots!
26758 We didn't notice this on Mac because at this point we've made it so that
26759 we *always* have WindowServer snapshots, but on iOS we still don't have
26760 WindowServer snapshots, so now they're flipped.
26762 And that's how we got here.
26764 To restore the behavior from r140067, and correctly unflip snapshots on
26765 iOS, just delete this code.
26767 2016-03-15 Alexey Proskuryakov <ap@apple.com>
26769 run-api-tests doesn't print test name when the test crashes
26770 https://bugs.webkit.org/show_bug.cgi?id=155476
26772 Reviewed by Daniel Bates.
26774 * Scripts/run-api-tests: Print "UNEXPECTEDLY EXITED" with a test name when output
26775 doesn't contain the test name yet. Changed test name output to always be before raw
26776 stdout for clarity.
26778 2016-03-15 Chris Dumez <cdumez@apple.com>
26780 Unreviewed, rolling out r198203.
26782 Favorites view is no longer loading on iOS
26784 Reverted changeset:
26786 "URL Parsing should signal failure for illegal IDN"
26787 https://bugs.webkit.org/show_bug.cgi?id=154945
26788 http://trac.webkit.org/changeset/198203
26790 2016-03-15 Jiewen Tan <jiewen_tan@apple.com>
26792 URL Parsing should signal failure for illegal IDN
26793 https://bugs.webkit.org/show_bug.cgi?id=154945
26794 <rdar://problem/8014795>
26796 Reviewed by Brent Fulgham.
26798 * MiniBrowser/mac/WK2BrowserWindowController.m:
26799 (-[WK2BrowserWindowController fetch:]):
26800 * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
26801 (TestWebKitAPI::TEST):
26803 2016-03-14 Chris Dumez <cdumez@apple.com>
26805 Unreviewed, rolling out r197981.
26807 Caused a massive PLT regression on Mac.
26809 Reverted changeset:
26811 "Font antialiasing (smoothing) changes when elements are
26812 rendered into compositing layers"
26813 https://bugs.webkit.org/show_bug.cgi?id=23364
26814 http://trac.webkit.org/changeset/197981
26816 2016-03-14 Dewei Zhu <dewei_zhu@apple.com>
26818 Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled.
26819 https://bugs.webkit.org/show_bug.cgi?id=154667
26821 Reviewed by Ryosuke Niwa and Simon Fraser.
26823 Add twisted-15.5.0 to webkitpy.thirdparty.autoinstalled.
26824 Minor fix for twsited_http_server used by run-benchmark that we should only stop http server while recieving 'GET /shutdown'.
26826 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
26827 (ServerControl.render_POST): Deleted.
26828 * Scripts/webkitpy/thirdparty/__init__.py:
26829 (AutoinstallImportHook.find_module):
26830 (AutoinstallImportHook._install_twisted_15_5_0):
26831 * Scripts/webkitpy/thirdparty/__init___unittest.py:
26832 (ThirdpartyTest.test_imports):
26834 2016-03-14 Mark Lam <mark.lam@apple.com>
26836 Need to distinguish between Symbol() and Symbol("").
26837 https://bugs.webkit.org/show_bug.cgi?id=155438
26839 Reviewed by Saam Barati.
26841 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
26842 (TestWebKitAPI::TEST):
26843 - Test that the a symbol with an empty string is not equivalent to a null symbol.
26845 2016-03-14 David Kilzer <ddkilzer@apple.com>
26847 Remove blank lines after #include "config.h"
26849 Follow-up fix from review comments on Bug 155394.
26851 * TestWebKitAPI/PlatformUtilities.cpp:
26852 * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
26854 2016-03-14 Frederic Wang <fred.wang@free.fr>
26856 Unreviewed: Add my professional email address.
26858 * Scripts/webkitpy/common/config/contributors.json:
26860 2016-03-14 Youenn Fablet <youenn.fablet@crf.canon.fr>
26862 Web platform test server should not try to launch servers on already bound sockets
26863 https://bugs.webkit.org/show_bug.cgi?id=141157
26865 Reviewed by Darin Adler.
26867 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
26868 (wpt_config_json): Load WPT config from LayoutTests/imported/w3c/resources/config.json.
26869 (base_url): Refactored to use wpt_config_json routine.
26870 (WebPlatformTestServer.__init__): Fill port mappings according WPT config.
26872 2016-03-13 Joseph Pecoraro <pecoraro@apple.com>
26874 Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards
26875 https://bugs.webkit.org/show_bug.cgi?id=155417
26877 Reviewed by Yusuke Suzuki.
26879 * Scripts/webkitperl/FeatureList.pm:
26880 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
26882 2016-03-13 Dean Jackson <dino@apple.com>
26884 DRT should enable WebGL by default on Mac
26885 https://bugs.webkit.org/show_bug.cgi?id=155419
26886 <rdar://problem/25136981>
26888 Reviewed by Sam Weinig.
26890 For some reason, lost in time, WebGL was enabled
26891 by default on trunk, but disabled by default
26892 in DumpRenderTree when using WebKit 1. This
26893 was very annoying, because each test had
26894 an explicit command to enable it.
26896 * DumpRenderTree/mac/DumpRenderTree.mm:
26897 (resetWebPreferencesToConsistentValues): Deleted WebGL line.
26899 2016-03-13 Konstantin Tokarev <annulen@yandex.ru>
26901 Added new port JSCOnly.
26902 https://bugs.webkit.org/show_bug.cgi?id=154512
26904 Reviewed by Michael Catanzaro.
26906 This port allows to build JavaScriptCore engine with minimal
26909 * Scripts/build-jsc:
26910 * Scripts/webkitdirs.pm:
26911 (argumentsForConfiguration):
26912 (executableProductDir):
26913 (determinePortName):
26915 (wrapperPrefixIfNeeded):
26916 (generateBuildSystemFromCMakeProject):
26917 (buildCMakeGeneratedProject):
26919 2016-03-13 David Kilzer <ddkilzer@apple.com>
26921 TestWebKitAPI: fix linker warnings
26922 <http://webkit.org/b/155394>
26924 Reviewed by Darin Adler.
26926 * TestWebKitAPI/CMakeLists.txt:
26927 - Add RefLogger.cpp source file.
26928 - Add other missing cross-platform source files.
26929 - Add FIXMEs about RunLoop.cpp and about missing
26930 platform-specific source files.
26931 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
26932 - Add RefLogger.cpp source file.
26934 * TestWebKitAPI/Counters.cpp:
26935 (DeleterCounter<ConstructorDestructorCounter>::deleterCount):
26936 Move specific declaration here to fix linker warning.
26937 * TestWebKitAPI/Counters.h:
26938 (DeleterCounter<T>::deleterCount): Remove declaration of global
26941 * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Added.
26942 (TestWebKitAPI::log): Added. Move inline definition in
26943 RefLogger.h to here to fix linker warning.
26945 * TestWebKitAPI/Tests/WTF/RefLogger.h:
26946 (TestWebKitAPI::log): Replace inline function with declaration.
26948 2016-03-12 David Kilzer <ddkilzer@apple.com>
26950 REGRESSION (r178615): Fix incorrect case in included header for WeakPtr.cpp
26952 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Change "test.h" to
26953 "Test.h" to fix incorrect case. This was discovered when adding
26954 WeakPtr.cpp to CMakeLists.txt for the patch on Bug 155394.
26956 2016-03-12 David Kilzer <ddkilzer@apple.com>
26958 run-webkit-tests: handle Darwin framework/library environment variables more consistently
26959 <http://webkit.org/b/155392>
26961 Reviewed by Daniel Bates.
26963 These changes will make it possible to pass through environment
26964 variables from the run-webkit-tests command-line.
26966 * Scripts/webkitpy/port/base.py:
26967 (Port.to.setup_environ_for_server): Add DYLD_FRAMEWORK_PATH,
26968 __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_LIBRARY_PATH to the
26969 list of variables to keep from the run-webkit-test environment.
26971 * Scripts/webkitpy/port/driver.py:
26972 (Driver._append_environment_variable_path): Add method to append
26973 a path to an environment variable, or set the path if the
26974 variable doesn't exist.
26975 (Driver._setup_environ_for_driver): Extract build_root_path into
26976 a local variable. Use Driver._append_environment_variable_path
26977 to extend DYLD_LIBRARY_PATH, __XPC_DYLD_LIBRARY_PATH,
26978 DYLD_FRAMEWORK_PATH and __XPC_DYLD_FRAMEWORK_PATH instead of
26981 * Scripts/webkitpy/port/driver_unittest.py:
26982 (DriverTest.test__append_environment_variable_path): Add test
26983 method to test Driver._append_environment_variable_path.
26985 2016-03-11 Alexey Proskuryakov <ap@apple.com>
26987 [ios-sim debug] API test WTF_Lock.ContendedShortSection and WTF_ParkingLot.UnparkOneFifty timing out
26988 https://bugs.webkit.org/show_bug.cgi?id=155276
26990 [ios-sim] API test WTF_Condition.TenProducersTenConsumersOneSlot timing out
26991 https://bugs.webkit.org/show_bug.cgi?id=155345
26993 [iOS Simulator] API test timeout: WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
26994 https://bugs.webkit.org/show_bug.cgi?id=153997
26995 <rdar://problem/23580034>
26997 <rdar://problem/23580018> TestWebKitAPI Timeout: WTF_ParkingLot.UnparkOneFifty
26999 Rubber-stamped by Filip Pizlo.
27001 * Scripts/run-api-tests: These tests are pretty slow. Increase API test timeout.
27003 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Start running WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
27006 2016-03-11 Jer Noble <jer.noble@apple.com>
27008 [ios-sim debug] API tests RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForAudioButNotVideoPlayback asserting
27009 https://bugs.webkit.org/show_bug.cgi?id=155365
27011 Reviewed by Darin Adler.
27013 Allow tests running on iOS simulator to play video inline, avoiding this assert.
27015 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
27016 (RequiresUserActionForPlaybackTest::SetUp):
27018 2016-03-11 Frederic Wang <fwang@igalia.com>
27020 [jhbuild] Disable LLVM OCaml bindings.
27021 https://bugs.webkit.org/show_bug.cgi?id=153274
27023 Reviewed by Michael Catanzaro.
27025 * gtk/jhbuild.modules: disable all (actually only OCaml) bindings for LLVM.
27027 2016-03-11 Commit Queue <commit-queue@webkit.org>
27029 Unreviewed, rolling out r197495.
27030 https://bugs.webkit.org/show_bug.cgi?id=155369
27032 LLVM is needed to run update-webkitgtk-libs reliably
27033 (Requested by mcatanzaro on #webkit).
27035 Reverted changeset:
27037 "[jhbuild] Remove LLVM dependency."
27038 https://bugs.webkit.org/show_bug.cgi?id=153274
27039 http://trac.webkit.org/changeset/197495
27041 2016-03-11 Youenn Fablet <youenn.fablet@crf.canon.fr>
27043 WTF should have a similar function as equalLettersIgnoringASCIICase to match beginning of strings
27044 https://bugs.webkit.org/show_bug.cgi?id=153419
27046 Reviewed by Darin Adler.
27048 * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
27049 (TestWebKitAPI::TEST): Adding test case for startsWithLettersIgnoringASCIICase.
27052 2016-03-10 Simon Fraser <simon.fraser@apple.com>
27054 Font antialiasing (smoothing) changes when elements are rendered into compositing layers
27055 https://bugs.webkit.org/show_bug.cgi?id=23364
27057 Reviewed by Tim Horton.
27059 Turn off smoothed layer text because it affects many layout test results.
27061 * DumpRenderTree/mac/DumpRenderTree.mm:
27062 (resetWebViewToConsistentStateBeforeTesting):
27063 * WebKitTestRunner/TestController.cpp:
27064 (WTR::TestController::resetStateToConsistentValues):
27066 2016-03-10 Jer Noble <jer.noble@apple.com>
27068 Partial roll-out of r197953; test fails because encode/decode support of those properties were never added.
27070 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
27073 2016-03-10 Myles C. Maxfield <mmaxfield@apple.com>
27075 [OS X] Main frame scrollbars should appear on the left on RTL systems
27076 https://bugs.webkit.org/show_bug.cgi?id=155149
27078 Reviewed by Simon Fraser.
27080 Setting the volatile default needs to be done early, so it is
27081 plumbed through the injected bundle's initialization routine.
27083 Control of RTL scrollbars is handled by putting the string
27084 <!-- webkit-test-runner [ rtlScrollbars=true ] -->
27085 on the first line of a test.
27087 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
27088 (WTR::shouldUseRTLScrollbars):
27089 (WTR::InjectedBundle::platformInitialize):
27090 * WebKitTestRunner/TestController.cpp:
27091 (WTR::TestController::generatePageConfiguration):
27092 (WTR::updateTestOptionsFromTestHeader):
27093 (WTR::TestController::getInjectedBundleInitializationUserData):
27094 * WebKitTestRunner/TestController.h:
27095 * WebKitTestRunner/TestOptions.h:
27096 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
27097 (WTR::PlatformWebView::viewSupportsOptions):
27099 2016-03-08 Jer Noble <jer.noble@apple.com>
27101 Add separate WK and WK2 preferences for requiring user gestures for video media, distinct from user gestures for media generally
27102 https://bugs.webkit.org/show_bug.cgi?id=155141
27104 Reviewed by Beth Dakin.
27106 Set the default values for media preferences unconditionally, not just on PLATFORM(IOS). Set "video requires user gesture"
27107 to sane defaults in addition to "audio requires user gesture" and (in the case of DumpREnderTree) instead of "media requires user gesture".
27109 Add a new test of WK2 user gesture requirement preferences.
27111 * DumpRenderTree/mac/DumpRenderTree.mm:
27112 (resetWebPreferencesToConsistentValues):
27113 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
27114 * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
27115 * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
27116 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: Added.
27117 (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]):
27118 (-[RequiresUserActionForPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
27119 (RequiresUserActionForPlaybackTest::SetUp):
27120 (RequiresUserActionForPlaybackTest::createWebView):
27121 (RequiresUserActionForPlaybackTest::testVideoWithAudio):
27122 (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
27123 (RequiresUserActionForPlaybackTest::testAudioOnly):
27125 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
27128 2016-03-10 Brian Burg <bburg@apple.com>
27130 Web Inspector: should be able to run protocol and input generator scripts from any directory
27131 https://bugs.webkit.org/show_bug.cgi?id=155307
27133 Reviewed by Joseph Pecoraro.
27135 * Scripts/webkitpy/inspector/main.py:
27136 (InspectorGeneratorTests.main):
27137 * Scripts/webkitpy/replay/main.py:
27138 (InputGeneratorTests.main):
27139 Compute the current SCM based on the location of the script being executed, not
27140 the $CWD which could be anything. There's rarely a good reason to use $CWD.
27142 2016-03-10 David Kilzer <ddkilzer@apple.com>
27144 [iOS] DumpRenderTree crashes when accessing window.testRunner.inspectorTestStubURL
27145 <http://webkit.org/b/155295>
27147 Reviewed by Brent Fulgham.
27149 * DumpRenderTree/mac/TestRunnerMac.mm:
27150 (TestRunner::inspectorTestStubURL): Always return nullptr for
27151 PLATFORM(IOS). This matches what we did in r192604 for
27152 WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm.
27154 2016-03-10 Frederic Wang <fwang@igalia.com>
27156 [GTK] Add support for WOFF2
27157 https://bugs.webkit.org/show_bug.cgi?id=152616
27159 Reviewed by Carlos Garcia Campos.
27161 * Scripts/webkitpy/style/checker.py: Only verify basic style for third party modules brotli and woff2.
27163 2016-03-09 Ryosuke Niwa <rniwa@webkit.org>
27165 Add runtime flags for shadow DOM and custom elements
27166 https://bugs.webkit.org/show_bug.cgi?id=155213
27168 Reviewed by Dean Jackson.
27170 Always enable shadow DOM and custom elements during testing.
27172 * DumpRenderTree/mac/DumpRenderTree.mm:
27173 (resetWebPreferencesToConsistentValues):
27174 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
27175 (WTR::InjectedBundle::beginTesting):
27176 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
27177 (WTR::TestRunner::setShadowDOMEnabled): Added.
27178 * WebKitTestRunner/InjectedBundle/TestRunner.h:
27180 2016-03-09 Brent Fulgham <bfulgham@apple.com>
27182 Handling 'allowUniversalAccessFromFileURLs' on WKWebViewConfiguration causes test breakage
27183 https://bugs.webkit.org/show_bug.cgi?id=155265
27184 <rdar://problem/11101440>
27186 Reviewed by Andy Estes.
27188 WK2 localStorage tests need the 'AllowUniversalAccessFromFileURLs' preference set by default.
27189 Tests that confirm blocking localStorage manually set the flag to "False" in the test.
27191 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
27192 (WTR::initializeWebViewConfiguration): Set the default state to the correct value.
27194 2016-03-09 David Kilzer <ddkilzer@apple.com>
27196 check-webkit-style: fix false-positive warnings about @try/@catch blocks in Objective-C++ source files
27197 <http://webkit.org/b/155273>
27199 Reviewed by Andy Estes.
27201 * Scripts/webkitpy/style/checkers/cpp.py:
27202 (check_spacing_for_function_call): Ignore @catch lines.
27203 (check_braces): Ditto.
27204 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
27205 (CppStyleTest.test_brace_at_begin_of_line): Add test case.
27207 2016-03-09 Jason Marcell <jmarcell@apple.com>
27209 Removing reference to Dashboard.Repository.Internal.trac from open source unit tests.
27210 https://bugs.webkit.org/show_bug.cgi?id=155274
27212 Reviewed by Alexey Proskuryakov.
27214 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:
27215 (setup): Deleted. In bug 154180 we removed Dashboard.Repository.Internal which was causing an
27216 error in the unit tests.
27218 2016-03-09 Aakash Jain <aakash_jain@apple.com>
27220 use ulimit command to check process limit in webkitpy
27221 https://bugs.webkit.org/show_bug.cgi?id=155260
27223 Reviewed by Alexey Proskuryakov.
27225 * Scripts/webkitpy/port/ios.py:
27226 (IOSSimulatorPort.default_child_processes): Use ulimit command output instead of
27227 launchctl limit maxproc command.
27229 2016-03-09 Alexey Proskuryakov <ap@apple.com>
27231 Stop building armv7 on iOS device builders
27232 https://bugs.webkit.org/show_bug.cgi?id=155246
27234 Reviewed by David Kilzer.
27236 * BuildSlaveSupport/build.webkit.org-config/config.json: Building both armv7 and
27237 armv7s makes the bots unnecessarily slow. We can catch super rare v7-only regressions
27240 * Scripts/webkitpy/common/config/ews.json: Changed EWS to match, as we always want
27241 EWS configuration to be verified by buildbot queues.
27243 * Scripts/webkitdirs.pm:
27244 * Scripts/webkitpy/port/ios.py:
27245 Changed default to arm64. I think that the default is probably not used in any
27246 practical scenarios, but it's nice to make it more sensible.
27248 2016-03-09 Alexey Proskuryakov <ap@apple.com>
27250 Add iOS Simulator EWS to bot watcher's dashboard
27251 https://bugs.webkit.org/show_bug.cgi?id=155220
27253 Reviewed by Lucas Forschler.
27255 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
27257 2016-03-09 Brent Fulgham <bfulgham@apple.com>
27259 Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
27260 https://bugs.webkit.org/show_bug.cgi?id=155185
27261 <rdar://problem/11101440>
27263 Reviewed by Anders Carlsson.
27265 * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
27266 (TestWebKitAPI::TEST): Allow local file accesss to run test.
27267 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
27269 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
27272 2016-03-09 Tim Horton <timothy_horton@apple.com>
27274 Removing and re-adding a script message handler with the same name results in an unusable message handler
27275 https://bugs.webkit.org/show_bug.cgi?id=155223
27277 Reviewed by Sam Weinig.
27279 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
27281 Add a test ensuring that it is possible to remove and re-add a script message handler
27282 with the same name and still dispatch messages to it.
27284 2016-03-08 Alexey Proskuryakov <ap@apple.com>
27286 Fix iOS Simulator EWS.
27288 Unreviewed build fix.
27290 * Scripts/webkitpy/common/config/ports.py:
27292 2016-03-08 Aakash Jain <aakash_jain@apple.com>
27294 Booting multiple iOS simulator parallely fails sometimes
27295 https://bugs.webkit.org/show_bug.cgi?id=155208
27296 <rdar://problem/25019651>
27298 Reviewed by Darin Adler.
27300 * Scripts/webkitpy/port/ios.py:
27301 (IOSSimulatorPort.setup_test_run): Increase the time delay between subsequent
27304 2016-03-08 Alexey Proskuryakov <ap@apple.com>
27306 Add iOS debug testers to flakiness dashboard
27307 https://bugs.webkit.org/show_bug.cgi?id=155206
27309 Reviewed by Darin Adler.
27311 * TestResultServer/static-dashboards/builders.jsonp:
27313 2016-03-08 Oliver Hunt <oliver@apple.com>
27315 Start moving to separated writable and executable mappings in the JIT
27316 https://bugs.webkit.org/show_bug.cgi?id=155178
27318 Reviewed by Fil Pizlo.
27320 Making run-jsc-benchmarks slightly happier on my machine.
27322 * Scripts/run-jsc-benchmarks:
27324 2016-03-08 Anders Carlsson <andersca@apple.com>
27326 Use NSUInteger instead of NSWindowStyleMask.
27328 * MiniBrowser/mac/MiniBrowser_Prefix.pch:
27330 2016-03-08 Anders Carlsson <andersca@apple.com>
27334 We intentionally don't use AppKitCompatibilityDeclarations.h here, since we want
27335 MiniBrowser to build without WTF.
27337 * MiniBrowser/mac/AppDelegate.m:
27338 (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
27339 * MiniBrowser/mac/BrowserWindowController.m:
27340 (-[BrowserWindowController windowDidLoad]):
27341 * MiniBrowser/mac/MiniBrowser_Prefix.pch:
27343 2016-03-08 Alexey Proskuryakov <ap@apple.com>
27345 Add iOS simulator EWS that runs tests
27346 https://bugs.webkit.org/show_bug.cgi?id=155175
27348 Reviewed by Lucas Forschler.
27350 * QueueStatusServer/config/queues.py:
27351 * Scripts/webkitpy/common/config/ews.json:
27352 * Scripts/webkitpy/common/config/ports.py:
27354 2016-03-08 Commit Queue <commit-queue@webkit.org>
27356 Unreviewed, rolling out r197793 and r197799.
27357 https://bugs.webkit.org/show_bug.cgi?id=155195
27359 something weird happened while landing this and everything
27360 broke (Requested by olliej on #webkit).
27362 Reverted changesets:
27364 "Start moving to separated writable and executable mappings in
27366 https://bugs.webkit.org/show_bug.cgi?id=155178
27367 http://trac.webkit.org/changeset/197793
27369 "arm64 build fix after r197793."
27370 http://trac.webkit.org/changeset/197799
27372 2016-03-08 Oliver Hunt <oliver@apple.com>
27374 Start moving to separated writable and executable mappings in the JIT
27375 https://bugs.webkit.org/show_bug.cgi?id=155178
27377 Reviewed by Filip Pizlo.
27379 Making run-jsc-benchmarks slightly happier on my machine.
27381 * Scripts/run-jsc-benchmarks:
27383 2016-03-08 Daniel Bates <dabates@apple.com>
27385 Support iterating over an OptionSet and checking if it is empty
27386 https://bugs.webkit.org/show_bug.cgi?id=154941
27387 <rdar://problem/24964187>
27389 Reviewed by Darin Adler.
27391 Add tests to ensure that we do not regression both iteration of an OptionSet and
27392 determining whether an OptionSet is empty.
27394 * TestWebKitAPI/Test.h:
27395 (TestWebKitAPI::Util::assertStrongEnum): Helper function to assert two strong enum type for equality.
27396 * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
27397 (TestWebKitAPI::TEST):
27399 2016-03-08 Alexey Proskuryakov <ap@apple.com>
27401 Add debug iOS Simulator bots to the dashboard
27402 https://bugs.webkit.org/show_bug.cgi?id=155157
27404 Reviewed by Darin Adler.
27406 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
27408 2016-03-08 Alejandro G. Castro <alex@igalia.com>
27410 Unreviewed EFL build fix after r197752.
27412 * Scripts/webkitperl/FeatureList.pm: Avoid MEDIA_STREAM
27413 compilation by default until EFL bumps gstreamer to 1.6.
27415 2016-03-08 Alejandro G. Castro <alex@igalia.com>
27417 [GTK] [EFL] Avoid running mediastream tests by default until we compile by default
27418 https://bugs.webkit.org/show_bug.cgi?id=153540
27420 Reviewed by Philippe Normand.
27422 After bumping gstreamer to 1.6.3 in r196804 we can enable again
27423 compilation of mediastream and running the tests.
27425 * Scripts/run-gtk-tests:
27426 (TestRunner): Enable again the UserMedia API test.
27427 * Scripts/webkitperl/FeatureList.pm: Enable the compilation of the
27428 mediastream by default.
27429 * gtk/jhbuild-webrtc.modules: Removed the specific jhbuild modules
27431 * gtk/jhbuild.modules: Bumped the openwebrtc version to the one we
27432 are currently using.
27434 2016-03-07 Jon Lee <jonlee@apple.com>
27436 Update perf bot configuration for Animometer
27437 https://bugs.webkit.org/show_bug.cgi?id=155134
27439 Reviewed by Ryosuke Niwa.
27441 * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Refactor the patch
27442 to work with the latest version of the harness.
27443 * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Bump up the timeout,
27444 and use the latest version of the harness.
27446 2016-03-07 Joanmarie Diggs <jdiggs@igalia.com>
27448 [GTK][jhbuild] OpenWebRTC build fails with GCC 6.0
27449 https://bugs.webkit.org/show_bug.cgi?id=154839
27451 Reviewed by Michael Catanzaro.
27453 Add '-Wno-error' to jhbuildrc; remove it from the module sets for macos.
27455 * gtk/jhbuild-webrtc.modules:
27456 * gtk/jhbuild.modules:
27459 2016-03-07 Aakash Jain <aakash_jain@apple.com>
27461 webkitpy should verify timestamp from CrashLogs while collecting all crash logs
27462 https://bugs.webkit.org/show_bug.cgi?id=155000
27463 <rdar://problem/24860219>
27465 Reviewed by Alexey Proskuryakov.
27467 * Scripts/webkitpy/common/system/crashlogs.py:
27468 (CrashLogs._find_all_logs_darwin): Make sure that crash log timestamp is within expected
27469 time range, because file modification time is not always accurate.
27470 (CrashLogs.get_timestamp_from_logs): Parse the timestamp from logs.
27471 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
27472 (CrashLogsTest.test_get_timestamp_from_logs_darwin): Testcase for above function.
27474 2016-03-06 Alexey Proskuryakov <ap@apple.com>
27476 build-webkit prints an error on iOS simulator bots
27477 https://bugs.webkit.org/show_bug.cgi?id=155078
27479 Reviewed by Dan Bernstein.
27481 This happens when build-layouttestrelay sets $xcodeSDK to undefined, to use host SDK.
27483 * Scripts/webkitdirs.pm: (buildXCodeProject): There is no need to pass -sdk, because
27484 XcodeOptions() already passes SDKROOT as appropriate.
27486 * Scripts/build-layouttestrelay: Added a FIXME. Resetting $xcodeSDK doesn't reset
27487 any other configuration variables that were derived from its initial value, like $portName.
27489 2016-03-05 Tim Horton <timothy_horton@apple.com>
27491 Create a DOMHTMLVideoElement when wrapping <video> elements
27492 https://bugs.webkit.org/show_bug.cgi?id=155084
27493 <rdar://problem/24997193>
27495 Reviewed by Dan Bernstein.
27497 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
27498 * TestWebKitAPI/Tests/mac/DOMHTMLVideoElementWrapper.mm: Added.
27499 (-[VideoWrapperFrameLoadDelegate webView:didFinishLoadForFrame:]):
27500 (TestWebKitAPI::TEST):
27501 Add an API test for this behavior.
27503 2016-03-05 Carlos Alberto Lopez Perez <clopez@igalia.com>
27505 [GTK] Fix logging details after r197505 (Run the run-benchmark script on the performance bot.)
27506 https://bugs.webkit.org/show_bug.cgi?id=154595
27510 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
27511 (start): Use logging.exception when a test fails in order to get the details about the error.
27513 2016-03-04 Alexey Proskuryakov <ap@apple.com>
27515 Add iOS simulator debug bots
27516 https://bugs.webkit.org/show_bug.cgi?id=155053
27518 Reviewed by Lucas Forschler.
27520 * BuildSlaveSupport/build.webkit.org-config/config.json:
27522 2016-03-04 Brent Fulgham <bfulgham@apple.com>
27524 [WK2] Gather resource load statistics
27525 https://bugs.webkit.org/show_bug.cgi?id=154278
27526 <rdar://problem/24702892>
27528 Reviewed by Andy Estes.
27530 * MiniBrowser/mac/AppDelegate.m:
27531 (defaultConfiguration): Retrieve state of the ResourceLoadStatisticsEnabled setting.
27532 * MiniBrowser/mac/SettingsController.m:
27533 (-[SettingsController _populateMenu]): Move setting from WK1-only to be
27534 universally applicable.
27535 * MiniBrowser/mac/WK2BrowserWindowController.m:
27536 (-[WK2BrowserWindowController didChangeSettings]): Recognize when the
27537 Resource Load Statistics flag has changed.
27539 2016-03-04 Alex Christensen <achristensen@webkit.org>
27541 Remove vcxproj build system
27542 https://bugs.webkit.org/show_bug.cgi?id=154388
27544 Rubber-stamped by Brent Fulgham.
27546 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree: Removed.
27547 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Removed.
27548 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: Removed.
27549 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters: Removed.
27550 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props: Removed.
27551 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props: Removed.
27552 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props: Removed.
27553 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Removed.
27554 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Removed.
27555 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props: Removed.
27556 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props: Removed.
27557 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Removed.
27558 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props: Removed.
27559 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Removed.
27560 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Removed.
27561 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Removed.
27562 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props: Removed.
27563 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Removed.
27564 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Removed.
27565 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj: Removed.
27566 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props: Removed.
27567 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Removed.
27568 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props: Removed.
27569 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Removed.
27570 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj: Removed.
27571 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props: Removed.
27572 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props: Removed.
27573 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Removed.
27574 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props: Removed.
27575 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPostBuild.cmd: Removed.
27576 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd: Removed.
27577 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Removed.
27578 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props: Removed.
27579 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Removed.
27580 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: Removed.
27581 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters: Removed.
27582 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props: Removed.
27583 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props: Removed.
27584 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPostBuild.cmd: Removed.
27585 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd: Removed.
27586 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Removed.
27587 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props: Removed.
27588 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Removed.
27589 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Removed.
27590 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Removed.
27591 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Removed.
27592 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Removed.
27593 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Removed.
27594 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Removed.
27595 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Removed.
27596 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Removed.
27597 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Removed.
27598 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Removed.
27599 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Removed.
27600 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Removed.
27601 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Removed.
27602 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Removed.
27603 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Removed.
27604 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Removed.
27605 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Removed.
27606 * TestWebKitAPI/TestWebKitAPI.vcxproj: Removed.
27607 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Removed.
27608 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Removed.
27609 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Removed.
27610 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Removed.
27611 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Removed.
27612 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props: Removed.
27613 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Removed.
27614 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Removed.
27615 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Removed.
27616 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Removed.
27617 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props: Removed.
27618 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Removed.
27619 * win/AssembleBuildLogs: Removed.
27620 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Removed.
27621 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Removed.
27622 * win/AssembleBuildLogs/AssembleLogs.cmd: Removed.
27623 * win/AssembleBuildLogs/README: Removed.
27625 2016-03-04 Myles C. Maxfield <mmaxfield@apple.com>
27627 Whitespace causes font-variant: all-small-caps to synthesize
27628 https://bugs.webkit.org/show_bug.cgi?id=155004
27629 <rdar://problem/24630796>
27631 Reviewed by Darin Adler.
27633 * DumpRenderTree/mac/DumpRenderTree.mm:
27634 (allowedFontFamilySet):
27635 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
27636 (WTR::allowedFontFamilySet):
27637 * WebKitTestRunner/mac/TestControllerMac.mm:
27638 (WTR::allowedFontFamilySet):
27640 2016-03-04 Myles C. Maxfield <mmaxfield@apple.com>
27642 [iOS] Crash during font loading when injected bundle cancels load
27643 https://bugs.webkit.org/show_bug.cgi?id=155001
27645 Reviewed by Tim Horton.
27647 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
27648 * TestWebKitAPI/Tests/WebKit2/Ahem.ttf: Added.
27649 * TestWebKitAPI/Tests/WebKit2/webfont.html: Added.
27650 * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm: Added.
27651 (-[Myles webView:didFinishNavigation:]):
27653 * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresourcePlugIn.mm: Added.
27654 (-[CancelFontSubresourcePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
27655 (-[CancelFontSubresourcePlugIn webProcessPlugInBrowserContextController:frame:willSendRequestForResource:request:redirectResponse:]):
27657 2016-03-04 Konstantin Tokarev <annulen@yandex.ru>
27659 [check-webkit-style] Added checks for redundant virtual specifiers.
27660 https://bugs.webkit.org/show_bug.cgi?id=155017
27662 Reviewed by Darin Adler.
27664 Added 3 new checks related to virtual, override, and final specifiers:
27666 1. When "override" is present, "virtual" is redundant.
27667 2. When "final" is present, "virtual" is redundant.
27668 3. When "final" is present, "override" is redundant.
27670 * Scripts/webkitpy/style/checkers/cpp.py:
27671 (_FunctionState.begin):
27672 (_FunctionState.is_virtual):
27673 (_check_parameter_name_against_text):
27674 (_error_redundant_specifier):
27675 (check_function_definition):
27677 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
27678 (FunctionDetectionTest.perform_function_detection):
27679 (FunctionDetectionTest.test_basic_function_detection):
27680 (FunctionDetectionTest.test_function_declaration_detection):
27681 (FunctionDetectionTest.test_pure_function_detection):
27682 (FunctionDetectionTest.test_override_and_final_function_detection):
27683 (FunctionDetectionTest.test_non_functions):
27684 (FunctionDetectionTest.test_parameter_list):
27686 2016-03-03 Darin Adler <darin@apple.com>
27689 Remove "virtual" from all lines that have both "virtual" and "override".
27690 https://bugs.webkit.org/show_bug.cgi?id=155005
27692 Reviewed by Geoffrey Garen.
27694 * Scripts/do-webcore-rename: Added more regular expressions to make sure we always
27695 use either override or final, not both, and to remove virtual from all lines that
27696 have both virtual and final.
27698 2016-03-03 Darin Adler <darin@apple.com>
27700 Remove "virtual" from all lines that have both "virtual" and "override".
27701 https://bugs.webkit.org/show_bug.cgi?id=155005
27703 Reviewed by Geoffrey Garen.
27705 * Scripts/do-webcore-rename: Added a regular expression to this script to do the job.
27707 2016-03-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
27709 [GTK] Unreviewed fix after r197505 (Run the run-benchmark script on the performance bot.)
27710 https://bugs.webkit.org/show_bug.cgi?id=154595
27712 Unreviewed fix after r197505.
27714 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
27715 (RunBenchmarkTests.start):
27717 2016-03-03 Daniel Bates <dabates@apple.com>
27719 Add unit tests for WTF::OptionSet
27720 https://bugs.webkit.org/show_bug.cgi?id=154925
27721 <rdar://problem/24964211>
27723 Reviewed by Darin Adler.
27725 Add tests to ensure that we do not regress the behavior of WTF::OptionSet.
27727 * TestWebKitAPI/CMakeLists.txt: Add file TestWebKitAPI/Tests/WTF/OptionSet.cpp.
27728 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
27729 * TestWebKitAPI/Tests/WTF/OptionSet.cpp: Added.
27730 (TestWebKitAPI::TEST):
27732 2016-03-03 Commit Queue <commit-queue@webkit.org>
27734 Unreviewed, rolling out r197442.
27735 https://bugs.webkit.org/show_bug.cgi?id=154967
27737 Broke tests, and also uses a wrong approach (Requested by ap
27740 Reverted changeset:
27742 "Disable FTL JIT testing on 32-bit JSC tester bots"
27743 https://bugs.webkit.org/show_bug.cgi?id=154858
27744 http://trac.webkit.org/changeset/197442
27746 2016-03-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
27748 [GTK] Run the run-benchmark script on the performance bot.
27749 https://bugs.webkit.org/show_bug.cgi?id=154595
27751 Reviewed by Carlos Garcia Campos.
27753 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add new RunBenchmarkTests step on the perf bots (only for the GTK+ port at this moment).
27754 (RunBenchmarkTests):
27755 (RunBenchmarkTests.start):
27756 (RunBenchmarkTests.getText):
27757 (RunBenchmarkTests.getText2):
27758 (BuildAndPerfTestFactory.__init__):
27759 (DownloadAndPerfTestFactory.__init__):
27760 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add new test for RunBenchmarkTests and update expected steps of GTK+ perf bot.
27761 (RunBenchmarkTest):
27762 (RunBenchmarkTest.assertResults):
27763 (RunBenchmarkTest.test_success):
27764 (RunBenchmarkTest.test_tests_failed):
27765 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Log both the current iteration as also the total iterations for the current benchmark/plan.
27766 (BenchmarkRunner._run_benchmark):
27767 * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Use python logging also for errors.
27768 (GTKMiniBrowserDriver.close_browsers):
27769 * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Implement support for running all available benchmark plans.
27774 2016-03-03 Gyuyoung Kim <gyuyoung.kim@webkit.org>
27776 [EFL] Remove u-szeged.hu SVN mirror in EFL perf bot
27777 https://bugs.webkit.org/show_bug.cgi?id=154960
27779 Reviewed by Csaba Osztrogonác.
27781 * BuildSlaveSupport/build.webkit.org-config/config.json: Remove szeged univ's svn mirror.
27782 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
27784 2016-03-03 Frederic Wang <fwang@igalia.com>
27786 [jhbuild] Remove LLVM dependency.
27787 https://bugs.webkit.org/show_bug.cgi?id=153274
27789 Reviewed by Carlos Garcia Campos.
27791 * gtk/jhbuild.modules:
27793 2016-03-02 Alejandro G. Castro <alex@igalia.com>
27795 Unreviewed build fix for media-stream after r197114.
27797 * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
27798 (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
27800 2016-03-01 Csaba Osztrogonác <ossy@webkit.org>
27802 Disable FTL JIT testing on 32-bit JSC tester bots
27803 https://bugs.webkit.org/show_bug.cgi?id=154858
27805 Reviewed by Saam Barati.
27807 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
27808 (Run32bitJSCTests):
27810 2016-03-01 Dean Johnson <dean_johnson@apple.com>
27813 https://bugs.webkit.org/show_bug.cgi?id=154880
27815 Reviewed by Alexey Proskuryakov.
27817 * Scripts/copy-webkitlibraries-to-product-directory:
27819 2016-02-29 Chris Dumez <cdumez@apple.com>
27821 Have parseHTMLInteger() / parseHTMLNonNegativeInteger() use WTF::Optional
27822 https://bugs.webkit.org/show_bug.cgi?id=154845
27824 Reviewed by Ryosuke Niwa.
27826 Update API tests accordingly.
27828 * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
27829 (TestWebKitAPI::testParseHTMLInteger):
27830 (TestWebKitAPI::parseHTMLIntegerFails):
27831 (TestWebKitAPI::testParseHTMLNonNegativeInteger):
27832 (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
27833 (TestWebKitAPI::TEST): Deleted.
27835 2016-02-29 Simon Fraser <simon.fraser@apple.com>
27837 Remove the experimental feature of antialiased font dilation
27838 https://bugs.webkit.org/show_bug.cgi?id=154843
27840 Reviewed by Zalan Bujtas.
27842 Remove the "antialiased font dilation" code path, and related prefs.
27844 * DumpRenderTree/mac/DumpRenderTree.mm:
27845 (resetWebPreferencesToConsistentValues): Deleted.
27846 * WebKitTestRunner/TestController.cpp:
27847 (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
27849 2016-02-29 Brady Eidson <beidson@apple.com>
27851 Fix timing flakiness in test I added in http://trac.webkit.org/changeset/197372
27855 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html:
27856 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
27857 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
27858 (TEST): Sometimes a third message from the first html file was leaking through. The message is expected
27859 so we should always wait for it and make sure we got it.
27861 2016-02-29 Brady Eidson <beidson@apple.com>
27863 Modern IDB: WebKit 2 IPC layer easily confused about multiple web processes being connected.
27864 https://bugs.webkit.org/show_bug.cgi?id=154837
27866 Reviewed by Alex Christensen.
27868 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
27869 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: Added.
27870 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: Added.
27871 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Added.
27873 2016-02-29 Joanmarie Diggs <jdiggs@igalia.com>
27875 [GTK][jhbuild] GLib build fails with GCC 6.0
27876 https://bugs.webkit.org/show_bug.cgi?id=154825
27878 Use the upstream work-around. https://bugzilla.gnome.org/show_bug.cgi?id=761550
27880 Reviewed by Csaba Osztrogonác.
27882 * gtk/jhbuild.modules: Apply upstream path.
27883 * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Added.
27885 2016-02-29 Filip Pizlo <fpizlo@apple.com>
27887 We've been running Octane/regexp all wrong in run-jsc-benchmarks
27888 https://bugs.webkit.org/show_bug.cgi?id=154827
27890 Reviewed by Andreas Kling.
27892 Octane v.2 and JetStream v.1.1 run this benchmark with warmup. This script was running
27893 it without warmup. This patches fixes this by making this script run it with warmup.
27895 This fix shows that my last patch, which added FTL support for regexp, was actually a 3%
27896 speed-up on Octane/regexp, not a slow-down as the ChangeLog claimed.
27898 It discovered this bug because for each Octane test that I want to debug, I usually make
27899 a standalone .js file that contains the whole test along with a miniharness - usually
27900 a plain loop - that runs it almost like it would for real but with whatever hacks I'm
27901 using for debugging. When I wrote such a thing for regexp, I used a ~20 iteration warmup
27902 to match the one second of warmup that this benchmark gets in Octane. To my surprise,
27903 this quite faithful regexp runner did not see the regression that run-jsc-benchmarks
27904 saw. That's when I found out that run-jsc-benchmarks was running it wrong.
27906 The reason for the no-warmup slow-down is that the FTL is actually fairly expensive to
27907 run on some of these very large functions in the regexp benchmark. I don't think we can
27908 do anything about that, and I'd argue that the speed-up we see after the compilation is
27909 done suggests that it was worth it.
27911 * Scripts/run-jsc-benchmarks:
27913 2016-02-29 Gavin Barraclough <barraclough@apple.com>
27915 RefCounter<T>::Event -> RefCounterEvent
27916 https://bugs.webkit.org/show_bug.cgi?id=154767
27918 Reviewed by Darin Adler.
27920 RefCounter<T>::Event is kinda verbose to use, and there is no need for this
27921 to be specific to a particular typeof RefCounter. Move the enum class up to
27922 the top level & rename to RefCounterEvent.
27924 * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
27925 (TestWebKitAPI::TEST):
27927 2016-02-29 Csaba Osztrogonác <ossy@webkit.org>
27929 Remove more LLVM related cruft
27930 https://bugs.webkit.org/show_bug.cgi?id=154821
27932 Reviewed by Darin Adler.
27934 * Scripts/build-jsc:
27935 * Scripts/build-webkit:
27936 * Scripts/copy-webkitlibraries-to-product-directory:
27937 * Scripts/export-llvm-build: Removed.
27938 * Scripts/run-jsc-stress-tests:
27940 2016-02-28 Sam Weinig <sam@webkit.org>
27942 Reimplement WKPageGroup in terms of WKUserContentController
27943 https://bugs.webkit.org/show_bug.cgi?id=154804
27945 Reviewed by Dan Bernstein.
27947 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
27948 * TestWebKitAPI/Tests/WebKit2/PageGroup.cpp: Added.
27950 2016-02-28 Sam Weinig <sam@webkit.org>
27952 Bind _WKUserStyleSheets to WKUserContentWorlds to allow for grouping of user content by associating to a world
27953 https://bugs.webkit.org/show_bug.cgi?id=154798
27955 Reviewed by Dan Bernstein.
27957 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
27958 Add tests for removing _WKUserStyleSheets and WKUserScripts
27960 2016-02-27 Alexey Proskuryakov <ap@apple.com>
27962 Silence leaks under TextCodecICU::registerCodecs
27963 https://bugs.webkit.org/show_bug.cgi?id=154737
27965 Reviewed by Darin Adler.
27967 * Scripts/webkitpy/port/leakdetector.py:
27968 (LeakDetector._callstacks_to_exclude_from_leaks):
27970 2016-02-26 Michael Catanzaro <mcatanzaro@igalia.com>
27972 [GTK] Fix incorrect cast
27976 * MiniBrowser/gtk/main.c:
27977 (createBrowserWindow):
27979 2016-02-26 Chris Dumez <cdumez@apple.com>
27981 Fix the behavior of reflecting IDL attributes of type unsigned long
27982 https://bugs.webkit.org/show_bug.cgi?id=154771
27984 Reviewed by Ryosuke Niwa.
27986 Update API tests to cover the fixes to the parseHTMLNonNegativeInteger()
27988 - "-0" is parsed as 0.
27989 - Range boundaries are now [0; 2147483647].
27991 * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
27992 (TestWebKitAPI::TEST):
27994 2016-02-26 Brady Eidson <beidson@apple.com>
27996 Modern IDB: New database versions are never committed to SQLite.
27997 <rdar://problem/24860952> and https://bugs.webkit.org/show_bug.cgi?id=154741
27999 Modern IDB: If a database handle is not open, files are not actually deleted from disk
28000 https://bugs.webkit.org/show_bug.cgi?id=154756
28002 Reviewed by Alex Christensen.
28004 This also happens to test the previously untested fix for http://trac.webkit.org/changeset/197190
28006 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
28007 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-1.html: Added.
28008 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-2.html: Added.
28009 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: Added.
28010 (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]):
28011 (-[IndexedDBMessageHandler userContentController:didReceiveScriptMessage:]):
28014 2016-02-26 Commit Queue <commit-queue@webkit.org>
28016 Unreviewed, rolling out r197216.
28017 https://bugs.webkit.org/show_bug.cgi?id=154766
28019 Test simply needs updated result (Requested by litherum on
28022 Reverted changeset:
28024 "Unreviewed, rolling out r197158."
28025 https://bugs.webkit.org/show_bug.cgi?id=154758
28026 http://trac.webkit.org/changeset/197216
28028 2016-02-26 Alexey Proskuryakov <ap@apple.com>
28030 [iOS Simulator] Reftests don't work
28031 https://bugs.webkit.org/show_bug.cgi?id=154764
28033 Reviewed by Daniel Bates.
28035 * Scripts/webkitpy/port/image_diff.py: (IOSSimulatorImageDiffer._start):
28036 Use simctl instead of sim.
28038 2016-02-26 Chris Dumez <cdumez@apple.com>
28040 Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger
28041 https://bugs.webkit.org/show_bug.cgi?id=154714
28043 Reviewed by Darin Adler.
28045 Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger as per:
28046 - https://html.spec.whatwg.org/multipage/infrastructure.html#signed-integers
28047 - https://html.spec.whatwg.org/multipage/infrastructure.html#non-negative-integers
28049 * TestWebKitAPI/PlatformEfl.cmake:
28050 * TestWebKitAPI/PlatformGTK.cmake:
28051 * TestWebKitAPI/PlatformWin.cmake:
28052 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
28053 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
28054 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
28055 * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp: Added.
28056 (TestWebKitAPI::testParseHTMLInteger):
28057 (TestWebKitAPI::parseHTMLIntegerFails):
28058 (TestWebKitAPI::TEST):
28059 (TestWebKitAPI::testParseHTMLNonNegativeInteger):
28060 (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
28062 2016-02-26 Commit Queue <commit-queue@webkit.org>
28064 Unreviewed, rolling out r197158.
28065 https://bugs.webkit.org/show_bug.cgi?id=154758
28067 This change did not fix the failing test (Requested by
28068 ryanhaddad on #webkit).
28070 Reverted changeset:
28072 "REGRESSION(r195795): [WK2] fast/text/crash-complex-text-
28073 surrogate.html is flakey"
28074 https://bugs.webkit.org/show_bug.cgi?id=154709
28075 http://trac.webkit.org/changeset/197158
28077 2016-02-26 Anders Carlsson <andersca@apple.com>
28079 WKWebsiteDataStore/WKWebsiteDataRecord needs to provide size information about each type of data
28080 https://bugs.webkit.org/show_bug.cgi?id=154750
28081 rdar://problem/23861395
28083 Reviewed by Tim Horton.
28085 * MiniBrowser/mac/WK2BrowserWindowController.m:
28086 (-[WK2BrowserWindowController fetchWebsiteData:]):
28087 Use the new WKWebsiteDataStore SPI to compute data sizes.
28089 2016-02-25 Gavin Barraclough <barraclough@apple.com>
28091 RefCounter value changed callback should be called on all changes (not just zero edge).
28092 https://bugs.webkit.org/show_bug.cgi?id=154699
28094 Reviewed by Geoff Garen.
28096 RefCounter currently only triggers a callback when the count goes from zero
28097 to non-zero and vice-versa. Change that, to be useful to more clients.
28099 * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
28100 (TestWebKitAPI::TEST):
28101 - Updated for change in RefCounter callback siganture & behaviour.
28103 2016-02-25 Sam Weinig <sam@webkit.org>
28105 Allow WKUserScripts to be run in isolated worlds
28106 https://bugs.webkit.org/show_bug.cgi?id=154701
28108 Reviewed by Anders Carlsson.
28110 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
28111 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorld.mm: Added.
28112 (-[SimpleDelegate webView:didFinishNavigation:]):
28113 (-[UserContentWorldRemoteObject didObserveNormalWorld]):
28114 (-[UserContentWorldRemoteObject didObserveWorldWithName:]):
28115 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldPlugIn.mm: Added.
28116 (-[_WKUserContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
28117 (-[_WKUserContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
28118 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldProtocol.h: Added.
28120 2016-02-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
28122 W3C test importer should have an option to clean the destination directory
28123 https://bugs.webkit.org/show_bug.cgi?id=152685
28125 Reviewed by Darin Adler.
28127 Adding --clean-dest-dir option to W3C test importer.
28128 When this option is set, all files in the destination directory will be deleted
28129 except for WebKit specific files (test expectations, .gitignore...) before new tests import.
28130 Dangling test expectations are removed after tests import.'
28132 Adding unit test and minor refactoring for the other tests.
28134 * Scripts/webkitpy/w3c/test_importer.py:
28135 (parse_args): Add '--clean-dest-dir' option.
28136 (TestImporter.do_import):
28137 (TestImporter._is_baseline): helper routine to capture -expected.txt files.
28139 (TestImporter._should_not_keep_when_importing): helper routine to filter files that should not be cleaned before importing.
28140 (TestImporter.clean_destination_directory):
28141 (TestImporter.remove_dangling_expectations):
28142 * Scripts/webkitpy/w3c/test_importer_unittest.py:
28143 (TestImporterTest._parse_options):
28144 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
28145 (TestImporterTest.test_import_dir_with_no_tests):
28146 (TestImporterTest.test_import_dir_with_empty_init_py):
28147 (test_clean_directory_option):
28149 2016-02-25 Myles C. Maxfield <mmaxfield@apple.com>
28151 REGRESSION(r195795): [WK2] fast/text/crash-complex-text-surrogate.html is flakey
28152 https://bugs.webkit.org/show_bug.cgi?id=154709
28153 <rdar://problem/24483596>
28155 Reviewed by Dan Bernstein.
28157 Force auto-activation rules to a consistent state.
28159 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
28160 (WTR::InjectedBundle::platformInitialize):
28162 2016-02-25 Jiewen Tan <jiewen_tan@apple.com>
28164 Unreivewed build fix for r197150.
28166 * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
28168 2016-02-25 Jiewen Tan <jiewen_tan@apple.com>
28170 Restrict information passed with navigation action which is triggered by untrusted event
28171 https://bugs.webkit.org/show_bug.cgi?id=154571
28172 <rdar://problem/15967937>
28174 Reviewed by Andy Estes.
28176 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
28177 * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm: Added.
28178 (-[WKNavigationActionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
28179 (TestWebKitAPI::TEST):
28180 (-[NavigationActionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
28181 * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.html: Added.
28183 2016-02-25 Gavin Barraclough <barraclough@apple.com>
28185 Should template RefCounter instead of RefCounter::Token
28186 https://bugs.webkit.org/show_bug.cgi?id=154691
28188 Reviewed by Anders Carlsson.
28190 Mechanical update per RefCounter interface change.
28192 * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
28193 (TestWebKitAPI::TEST):
28195 2016-02-25 Skachkov Aleksandr <gskachkov@gmail.com>
28197 Unreviewed: Add Aleksandr Skachkov as a commiter
28199 * Scripts/webkitpy/common/config/contributors.json:
28201 2016-02-25 Sam Weinig <sam@webkit.org>
28203 HashMap::ensure() should return an AddResult like all the other add-like functions
28204 https://bugs.webkit.org/show_bug.cgi?id=154680
28206 Reviewed by Anders Carlsson.
28208 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
28209 (TestWebKitAPI::TEST):
28210 Update tests to use/test the new AddResult result.
28212 2016-02-25 Alexey Proskuryakov <ap@apple.com>
28214 Enable MallocScribble when detecting leaks
28215 https://bugs.webkit.org/show_bug.cgi?id=154679
28217 Reviewed by Geoffrey Garen.
28219 * Scripts/webkitpy/port/ios.py:
28220 (IOSSimulatorPort.setup_environ_for_server):
28221 * Scripts/webkitpy/port/mac.py:
28222 (MacPort.setup_environ_for_server):
28223 * Scripts/webkitpy/port/mac_unittest.py:
28224 (MacTest.test_setup_environ_for_server):
28226 2016-02-25 Eric Carlson <eric.carlson@apple.com>
28228 Unreviewed, fix iOS builds after r197114.
28230 * WebKitTestRunner/TestController.cpp:
28231 (WTR::createCanonicalUUIDString):
28232 (WTR::TestController::saltForOrigin):
28234 2016-02-25 Eric Carlson <eric.carlson@apple.com>
28236 [MediaStream] MediaDeviceInfo deviceId and groupId must be unique to the page's origin
28237 https://bugs.webkit.org/show_bug.cgi?id=153163
28238 <rdar://problem/24334526>
28240 Reviewed by Tim Horton.
28242 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
28243 (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Take top level document origin.
28244 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
28246 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
28247 (WTR::TestRunner::setUserMediaPermissionForOrigin): Ditto.
28248 * WebKitTestRunner/InjectedBundle/TestRunner.h:
28250 * WebKitTestRunner/TestController.cpp:
28251 (WTR::decidePolicyForUserMediaPermissionRequest): Pass through top level document origin.
28252 (WTR::checkUserMediaPermissionForOrigin): Ditto.
28253 (WTR::TestController::resetStateToConsistentValues): m_userMediaOriginPermissions -> m_cahcedUserMediaPermissions.
28254 (WTR::originUserVisibleName): Return a String.
28255 (WTR::userMediaOriginHash): Create a hash of the origin plus top level document origin.
28256 (WTR::TestController::saltForOrigin): Return salt for an origin.
28257 (WTR::TestController::setUserMediaPermissionForOrigin): Return permission for an origin.
28258 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
28259 (WTR::TestController::handleUserMediaPermissionRequest):
28260 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
28261 (WTR::OriginSettings::OriginSettings): New, class to cache settings for an origin.
28262 (WTR::OriginSettings::persistentPermission): Persistent permissions for origin.
28263 (WTR::OriginSettings::setPersistentPermission): Set permissions for origin.
28264 (WTR::OriginSettings::persistentSalt): Return the persistent salt for the origin, if any.
28265 (WTR::OriginSettings::setPersistentSalt): Set the persistent salt for the origin
28266 (WTR::OriginSettings::ephemeralSalts): Return hashmap used to store per-frame salts.
28267 * WebKitTestRunner/TestController.h:
28269 * WebKitTestRunner/TestInvocation.cpp:
28270 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
28272 2016-02-24 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
28274 [web-animations] Add AnimationTimeline, DocumentTimeline and add extensions to Document interface
28275 https://bugs.webkit.org/show_bug.cgi?id=151688
28277 Reviewed by Dean Jackson.
28279 Enables the WEB_ANIMATIONS compiler switch by default.
28281 * Scripts/webkitperl/FeatureList.pm:
28283 2016-02-24 Youenn Fablet <youenn.fablet@crf.canon.fr>
28285 W3C importer should generate all web-platform-tests submodules descriptions
28286 https://bugs.webkit.org/show_bug.cgi?id=154587
28288 Reviewed by Darin Adler.
28290 Updated submodules description format (removing submodule name as it is the last string of the path really).
28291 Added git subroutines.
28293 * Scripts/webkitpy/common/checkout/scm/git.py:
28296 (Git.init_submodules):
28297 (Git.submodules_status):
28298 (Git.deinit_submodules):
28299 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
28300 (WebPlatformTestServer._install_modules): Updated to submodule name removal.
28301 * Scripts/webkitpy/w3c/test_downloader.py:
28302 (TestDownloader._git_submodules_description): Updated to cope with recursive submodules (use of submodule init/deinit).
28303 * Scripts/webkitpy/w3c/test_importer_unittest.py:
28304 (TestImporterTest.test_submodules_generation): Reactivated partially this test.
28306 2016-02-23 Dan Bernstein <mitz@apple.com>
28308 [Xcode] Linker errors display mangled names, but no longer should
28309 https://bugs.webkit.org/show_bug.cgi?id=154632
28311 Reviewed by Sam Weinig.
28313 * ContentExtensionTester/Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
28314 * DumpRenderTree/mac/Configurations/Base.xcconfig: Ditto.
28315 * LayoutTestRelay/Configurations/Base.xcconfig: Ditto.
28316 * MiniBrowser/Configurations/Base.xcconfig: Ditto.
28317 * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
28318 * WebEditingTester/Configurations/Base.xcconfig: Ditto.
28319 * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
28321 2016-02-23 Anders Carlsson <andersca@apple.com>
28323 WKWebView should implement NSCoding
28324 https://bugs.webkit.org/show_bug.cgi?id=137160
28326 Reviewed by Dan Bernstein.
28330 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
28333 2016-02-23 Anders Carlsson <andersca@apple.com>
28335 WKProcessPool should conform to NSCoding
28336 https://bugs.webkit.org/show_bug.cgi?id=154608
28338 Reviewed by Sam Weinig.
28342 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
28345 2016-02-23 Anders Carlsson <andersca@apple.com>
28347 WKWebsiteDataStore should conform to NSCoding
28348 https://bugs.webkit.org/show_bug.cgi?id=154605
28350 Reviewed by Dan Bernstein.
28352 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
28355 2016-02-23 Anders Carlsson <andersca@apple.com>
28357 WKWebViewConfiguration should conform to NSCoding
28358 https://bugs.webkit.org/show_bug.cgi?id=154602
28360 Reviewed by Beth Dakin.
28362 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
28365 2016-02-23 Anders Carlsson <andersca@apple.com>
28367 WKPreferences should conform to NSCoding
28368 https://bugs.webkit.org/show_bug.cgi?id=154597
28370 Reviewed by Sam Weinig.
28372 Test encoding and decoding WKPreferences.
28374 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
28378 2016-02-23 Anders Carlsson <andersca@apple.com>
28382 * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
28383 (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]):
28385 2016-02-23 Carlos Alberto Lopez Perez <clopez@igalia.com>
28387 [GTK] Allow to run the WebKitGTK+ MiniBrowser with the run-benchmark script.
28388 https://bugs.webkit.org/show_bug.cgi?id=153993
28390 Reviewed by Carlos Garcia Campos.
28392 * MiniBrowser/gtk/main.c:
28393 (createBrowserWindow): Support --geometry argument for MiniBrowser.
28394 We use this on the gtk_minibrowser_driver script to start the MiniBrowser maximized.
28395 * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Fix loading of subclasses:
28396 The base class has to be loaded first, otherwise any subclase referencing it will give import error.
28397 In OSX the ordering of os.listdir() causes the base class (browser_driver.py) to be first on the list, but not on Linux.
28398 By specifiying the name of the base class file, we ensure it is always loaded first on any system despite the ordering of listdir.
28399 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
28400 (BrowserDriverFactory.create):
28401 * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py: Added.
28402 (GTKBrowserDriver):
28403 (GTKBrowserDriver.prepare_env):
28404 (GTKBrowserDriver.restore_env):
28405 (GTKBrowserDriver.close_browsers):
28406 (GTKBrowserDriver._launch_process):
28407 (GTKBrowserDriver._terminate_processes):
28408 (GTKBrowserDriver._screen_size):
28409 * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Added.
28410 (GTKMiniBrowserDriver):
28411 (GTKMiniBrowserDriver.prepare_env):
28412 (GTKMiniBrowserDriver.launch_url):
28413 (GTKMiniBrowserDriver.close_browsers):
28414 * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Fix loading of subclasses. See description above.
28415 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
28416 (SimpleHTTPServerDriver):
28417 (SimpleHTTPServerDriver.kill_server): Check if the server is still running before trying to terminate it.
28418 Usually the server ends gracefully (no need to terminate it), so this was causing ugly errors on the log.
28419 * Scripts/webkitpy/benchmark_runner/utils.py: Fix loading of subclasses. See description above.
28422 2016-02-23 Alejandro G. Castro <alex@igalia.com>
28424 [GTK] Missing configuration patch for openh264 compilation
28425 https://bugs.webkit.org/show_bug.cgi?id=154455
28427 This patch is required for the openh264 compilation with the
28428 jhbuild-webrtc.modules. The code was implemented by Alessandro
28431 Reviewed by Philippe Normand.
28433 * gtk/patches/openh264-configure.patch: Added.
28435 2016-02-20 Olivier Blin <olivier.blin@softathome.com>
28437 [cmake] Use ICU include dirs in WebKit2 and WebKitTestRunner
28438 https://bugs.webkit.org/show_bug.cgi?id=154479
28440 Reviewed by Michael Catanzaro.
28442 * WebKitTestRunner/CMakeLists.txt:
28444 2016-02-19 Konstantin Tokarev <annulen@yandex.ru>
28446 [GTK] Fixed link error when G_DEFINE_AUTOPTR_CLEANUP_FUNC is not defined.
28447 https://bugs.webkit.org/show_bug.cgi?id=154467
28449 Reviewed by Michael Catanzaro.
28451 * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp:
28455 2016-02-19 Brady Eidson <beidson@apple.com>
28457 Add "databaseProcessDidCrash" to the WKContextClient; Adopt it in WKTR.
28458 https://bugs.webkit.org/show_bug.cgi?id=154428
28460 Reviewed by Jer Noble.
28462 * WebKitTestRunner/TestController.cpp:
28463 (WTR::TestController::generatePageConfiguration):
28464 (WTR::TestController::databaseProcessName):
28465 (WTR::TestController::databaseProcessDidCrash):
28466 * WebKitTestRunner/TestController.h:
28468 2016-02-18 Philippe Normand <pnormand@igalia.com>
28470 [GStreamer] Bump internal jhbuild versions to 1.6.3
28471 https://bugs.webkit.org/show_bug.cgi?id=149594
28473 Reviewed by Michael Catanzaro.
28475 * gtk/jhbuild.modules: Bump to GStreamer 1.6.3.
28476 * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
28477 * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
28478 * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
28480 2016-02-18 Brent Fulgham <bfulgham@apple.com>
28482 Extend HashCountedSet with a method to efficiently set the count of an entry
28483 https://bugs.webkit.org/show_bug.cgi?id=154352
28485 Reviewed by Geoffrey Garen.
28487 * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
28488 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
28489 * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
28491 2016-02-18 Commit Queue <commit-queue@webkit.org>
28493 Unreviewed, rolling out r196791.
28494 https://bugs.webkit.org/show_bug.cgi?id=154438
28496 broke windows build (Requested by alexchristensen on #webkit).
28498 Reverted changeset:
28500 "Extend HashCountedSet with a method to efficiently set the
28502 https://bugs.webkit.org/show_bug.cgi?id=154352
28503 http://trac.webkit.org/changeset/196791
28505 2016-02-18 Brent Fulgham <bfulgham@apple.com>
28507 Extend HashCountedSet with a method to efficiently set the count of an entry
28508 https://bugs.webkit.org/show_bug.cgi?id=154352
28510 Reviewed by Geoffrey Garen.
28512 * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
28513 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
28514 * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
28516 2016-02-18 Anders Carlsson <andersca@apple.com>
28518 Get rid of the --target-web-process and --use-web-process-xpc-service options.
28520 Rubber-stamped by Dan Bernstein.
28522 We now always use XPC, and --target-web-process is no longer supported.
28524 * Scripts/webkitdirs.pm:
28525 (execMacWebKitAppForDebugging):
28526 (shouldTargetWebProcess): Deleted.
28527 (determineShouldTargetWebProcess): Deleted.
28528 (shouldUseXPCServiceForWebProcess): Deleted.
28529 (determineShouldUseXPCServiceForWebProcess): Deleted.
28530 (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Deleted.
28531 (argumentsForRunAndDebugMacWebKitApp): Deleted.
28533 2016-02-18 Ryan Haddad <ryanhaddad@apple.com>
28535 Skip API test WTF_ParkingLot.UnparkOneFiftyThenFiftyAll on ios-simulator
28536 https://bugs.webkit.org/show_bug.cgi?id=153997
28538 Reviewed by Filip Pizlo.
28540 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
28542 2016-02-18 Jer Noble <jer.noble@apple.com>
28544 run-webkit-httpd should use webkitpy to run httpd.
28545 https://bugs.webkit.org/show_bug.cgi?id=154271
28547 Reviewed by Alexey Proskuryakov.
28549 Update run-webkit-httpd to use webkitpy.port to launch httpd. Pass on http_port and http_all_interface
28550 options to match the current run-webkit-httpd (optional) behavior.
28552 * Scripts/run-webkit-httpd:
28555 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
28556 (LayoutTestApacheHttpd.__init__):
28557 * Scripts/webkitpy/layout_tests/servers/http_server.py:
28558 (Lighttpd._prepare_config):
28559 * Scripts/webkitpy/port/base.py:
28560 (Port.to.start_http_server):
28562 2016-02-18 Filip Pizlo <fpizlo@apple.com>
28564 Remove remaining references to LLVM, and make sure comments refer to the backend as "B3" not "LLVM"
28565 https://bugs.webkit.org/show_bug.cgi?id=154383
28567 Reviewed by Saam Barati.
28569 * Scripts/run-jsc-stress-tests:
28571 2016-02-17 Filip Pizlo <fpizlo@apple.com>
28573 Remove LLVM dependencies from WebKit
28574 https://bugs.webkit.org/show_bug.cgi?id=154323
28576 Reviewed by Antti Koivisto and Benjamin Poulain.
28578 * Scripts/copy-webkitlibraries-to-product-directory:
28579 (isContentOfFileEqualToString):
28580 (fileContains): Deleted.
28581 (buildLLVM): Deleted.
28582 (symlinkLLVMLibrariesIfNeeded): Deleted.
28584 2016-02-16 Sam Weinig <sam@webkit.org>
28586 Add an ensure function on HashMap that takes a key and a function to make the lazy value initialization idiom easier
28587 https://bugs.webkit.org/show_bug.cgi?id=134857
28589 Reviewed by Geoffrey Garen.
28591 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
28592 Add tests for HashMap::ensure.
28594 2016-02-17 Nan Wang <n_wang@apple.com>
28596 AX: Implement sentence related text marker functions using TextIterator
28597 https://bugs.webkit.org/show_bug.cgi?id=154312
28599 Reviewed by Chris Fleizach.
28601 * DumpRenderTree/AccessibilityUIElement.cpp:
28602 (nextParagraphEndTextMarkerForTextMarkerCallback):
28603 (sentenceTextMarkerRangeForTextMarkerCallback):
28604 (previousSentenceStartTextMarkerForTextMarkerCallback):
28605 (nextSentenceEndTextMarkerForTextMarkerCallback):
28606 (setSelectedVisibleTextRangeCallback):
28607 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
28608 (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
28609 (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
28610 (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
28611 (AccessibilityUIElement::getJSClass):
28612 * DumpRenderTree/AccessibilityUIElement.h:
28613 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
28614 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
28615 (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
28616 (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
28617 (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
28618 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
28619 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
28620 (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
28621 (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
28622 (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
28623 (AccessibilityUIElement::supportedActions):
28624 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
28625 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
28626 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
28627 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
28628 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
28629 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
28630 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
28631 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
28632 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
28633 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
28634 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
28635 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
28636 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
28637 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
28638 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
28639 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
28640 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
28641 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
28642 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
28643 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
28644 (WTR::_convertMathMultiscriptPairsToString):
28646 2016-02-15 Brent Fulgham <bfulgham@apple.com>
28648 [Mac] Gather some rudimentary statistics during resource load
28649 https://bugs.webkit.org/show_bug.cgi?id=153575
28650 <rdar://problem/24075254>
28652 Reviewed by Brady Eidson.
28654 * MiniBrowser/mac/SettingsController.h:
28655 * MiniBrowser/mac/SettingsController.m:
28656 (-[SettingsController _populateMenu]): Add menu item for new debug flag.
28657 (-[SettingsController toggleResourceLoadStatisticsEnabled:]): Added.
28658 (-[SettingsController resourceLoadStatisticsEnabled]): Added.
28659 * MiniBrowser/mac/WK1BrowserWindowController.m:
28660 (-[WK1BrowserWindowController didChangeSettings]): React to changes in
28661 users's desire to track resource load statistics.
28663 2016-02-15 Csaba Osztrogonác <ossy@webkit.org>
28665 [EFL] Update Tools/efl/install-dependencies
28666 https://bugs.webkit.org/show_bug.cgi?id=154239
28668 Reviewed by Michael Catanzaro.
28670 * efl/install-dependencies:
28672 2016-02-15 Alex Christensen <achristensen@webkit.org>
28674 Fix internal Windows build of projects built after WebKit
28675 https://bugs.webkit.org/show_bug.cgi?id=154249
28676 rdar://problem/24644805
28678 Reviewed by Chris Dumez.
28680 * DumpRenderTree/PlatformWin.cmake:
28681 * MiniBrowser/win/CMakeLists.txt:
28682 Don't include DerivedSources/WebKit/Interfaces to make MiniBrowser and DumpRenderTree
28683 more like projects built internally after WebKit. They should only need to use what
28684 is in ForwardingHeaders/WebKit.
28686 2016-02-12 Nan Wang <n_wang@apple.com>
28688 AX: Implement paragraph related text marker functions using TextIterator
28689 https://bugs.webkit.org/show_bug.cgi?id=154098
28690 <rdar://problem/24269675>
28692 Reviewed by Chris Fleizach.
28694 * DumpRenderTree/AccessibilityUIElement.cpp:
28695 (nextWordEndTextMarkerForTextMarkerCallback):
28696 (paragraphTextMarkerRangeForTextMarkerCallback):
28697 (previousParagraphStartTextMarkerForTextMarkerCallback):
28698 (nextParagraphEndTextMarkerForTextMarkerCallback):
28699 (setSelectedVisibleTextRangeCallback):
28700 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
28701 (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
28702 (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
28703 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
28704 (AccessibilityUIElement::getJSClass):
28705 * DumpRenderTree/AccessibilityUIElement.h:
28706 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
28707 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
28708 (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
28709 (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
28710 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
28711 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
28712 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
28713 (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
28714 (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
28715 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
28716 (AccessibilityUIElement::supportedActions):
28717 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
28718 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
28719 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
28720 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
28721 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
28722 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
28723 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
28724 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
28725 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
28726 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
28727 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
28728 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
28729 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
28730 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
28731 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
28732 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
28733 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
28734 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
28735 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
28736 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
28737 (WTR::_convertMathMultiscriptPairsToString):
28739 2016-02-12 Jason Marcell <jmarcell@apple.com>
28741 Open source bot watcher's dashboard fails assertion in BuildbotQueue.prototype.compareIterationsByRevisions
28742 https://bugs.webkit.org/show_bug.cgi?id=154180
28744 Reviewed by Alexey Proskuryakov.
28746 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Remove reference to Internal
28749 2016-02-12 Jer Noble <jer.noble@apple.com>
28751 [Mac] Adopt MediaResourceLoader (instead of CachedResourceLoader) in WebCoreNSURLSession.
28752 https://bugs.webkit.org/show_bug.cgi?id=154136
28754 Reviewed by Alex Christensen.
28756 Use a MediaResourceLoader instead of a CachedResourceLoader for WebCoreNSURLSession.
28758 Drive-by fix: generate USE and ENABLE macros for TestWebKitAPI by adding FEATURE_DEFINES
28759 to GCC_PREPROCESSOR_DEFINES.
28761 * TestWebKitAPI/Configurations/Base.xcconfig:
28762 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
28763 (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
28764 (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
28765 (TestWebKitAPI::TEST_F):
28767 2016-02-11 Dana Burkart <dburkart@apple.com>
28769 Large logs can bring down the webkit master
28770 https://bugs.webkit.org/show_bug.cgi?id=122112
28772 Reviewed by Lucas Forschler.
28774 Implement the suggested fix of throwing away stdout / stderr.
28776 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
28777 (RunWebKit1LeakTests):
28779 2016-02-10 Jason Marcell <jmarcell@apple.com>
28781 Remove calls to parseInt in order to work with non-integer revisions
28782 https://bugs.webkit.org/show_bug.cgi?id=153820
28784 Reviewed by Daniel Bates.
28786 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
28787 (BuildbotIteration.prototype.sourceStampChanges): Remove calls to parseInt in order to work with non-integer
28789 (BuildbotIteration.prototype._parseData): Ditto.
28790 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
28791 (BuildbotQueue.prototype.update): Ditto.
28792 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:
28793 (MockBuildbotQueueView.prototype._latestProductiveIteration): Change integers to strings in test code.
28794 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
28795 (MockTrac.prototype.get oldestRecordedRevisionNumber): Ditto.
28796 (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
28797 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Ditto.
28799 2016-02-10 Jason Marcell <jmarcell@apple.com>
28801 Teach dashboard code to compare non-integer revisions
28802 https://bugs.webkit.org/show_bug.cgi?id=152345
28804 Reviewed by Daniel Bates.
28806 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
28807 (BuildbotQueue.prototype.compareIterationsByRevisions): Compare non-integer revisions.
28808 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
28809 (BuildbotQueueView.prototype._appendPendingRevisionCount): Use Trac.indexOfRevision in order to compare non-integer
28810 revisions. Also uses new Trac.commitsOnBranchLaterThanRevision method.
28811 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Ditto.
28812 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Use Trac.indexOfRevision in order to compare non-integer
28813 revisions. Also uses new Trac.nextRevision method to calculate a revision range.
28814 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
28815 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
28816 (Trac.prototype._commitsOnBranch): Renamed this to indicate that it should be a private method used by the latter two new
28818 (Trac.prototype.commitsOnBranchLaterThanRevision): Finds revisions on a branch later than the specified revision.
28819 (Trac.prototype.commitsOnBranchInRevisionRange): Finds revisions on a branch within a specified range.
28820 (Trac.prototype.nextRevision): Finds the next revision after a given revision on a specific branch.
28821 (Trac.prototype.indexOfRevision): Finds the index of a given revision within the recordedCommits array.
28822 (Trac.prototype.commitsOnBranch): Deleted. Renamed to _commitsOnBranch.
28823 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests.
28825 2016-02-09 Nan Wang <n_wang@apple.com>
28827 AX: Implement word related text marker functions using TextIterator
28828 https://bugs.webkit.org/show_bug.cgi?id=153939
28829 <rdar://problem/24269605>
28831 Reviewed by Chris Fleizach.
28833 * DumpRenderTree/AccessibilityUIElement.cpp:
28834 (endTextMarkerCallback):
28835 (leftWordTextMarkerRangeForTextMarkerCallback):
28836 (rightWordTextMarkerRangeForTextMarkerCallback):
28837 (previousWordStartTextMarkerForTextMarkerCallback):
28838 (nextWordEndTextMarkerForTextMarkerCallback):
28839 (setSelectedVisibleTextRangeCallback):
28840 (AccessibilityUIElement::setSelectedVisibleTextRange):
28841 (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
28842 (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
28843 (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
28844 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
28845 (AccessibilityUIElement::getJSClass):
28846 * DumpRenderTree/AccessibilityUIElement.h:
28847 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
28848 (AccessibilityUIElement::setSelectedVisibleTextRange):
28849 (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
28850 (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
28851 (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
28852 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
28853 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
28854 (AccessibilityUIElement::setSelectedVisibleTextRange):
28855 (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
28856 (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
28857 (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
28858 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
28859 (AccessibilityUIElement::supportedActions):
28860 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
28861 (WTR::AccessibilityUIElement::setBoolAttributeValue):
28862 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
28863 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
28864 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
28865 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
28866 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
28867 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
28868 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
28869 (WTR::AccessibilityUIElement::endTextMarker):
28870 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
28871 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
28872 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
28873 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
28874 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
28875 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
28876 (WTR::AccessibilityUIElement::endTextMarker):
28877 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
28878 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
28879 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
28880 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
28881 (WTR::_convertMathMultiscriptPairsToString):
28883 2016-02-09 Csaba Osztrogonác <ossy@webkit.org>
28885 [EFL] Remove eail related cruft after r195725
28886 https://bugs.webkit.org/show_bug.cgi?id=154030
28888 Reviewed by Alex Christensen.
28892 2016-02-09 Csaba Osztrogonác <ossy@webkit.org>
28894 [EFL] Remove LLVM related cruft after r196077
28895 https://bugs.webkit.org/show_bug.cgi?id=154031
28897 Reviewed by Alex Christensen.
28899 * efl/jhbuild.modules:
28900 * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Removed.
28901 * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed.
28902 * efl/patches/llvm-version-arm64.patch: Removed.
28904 2016-02-05 Aakash Jain <aakash_jain@apple.com>
28906 tests fail if display sleeps while run-webkit-tests is running
28907 https://bugs.webkit.org/show_bug.cgi?id=153919
28909 Reviewed by Alexey Proskuryakov.
28911 * DumpRenderTree/mac/LayoutTestHelper.m:
28912 (addDisplaySleepAssertion): Add the assertion so that the display doesn't turn off.
28913 (releaseDisplaySleepAssertion): Release the DisplaySleep Assertion.
28914 (simpleSignalHandler): Release the DisplaySleepAssertion in case of any iterrupt.
28916 2016-02-05 Alex Christensen <achristensen@webkit.org>
28918 Fix iOS API tests after r196082
28919 https://bugs.webkit.org/show_bug.cgi?id=153900
28921 Reviewed by Jer Noble.
28923 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
28924 (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
28925 [WebView initialize] doesn't call JSC::initializeThreading on iOS.
28927 2016-02-04 Jason Marcell <jmarcell@apple.com>
28929 The status message for passing combined builder queues should say "all builds succeeded" when expanded.
28930 https://bugs.webkit.org/show_bug.cgi?id=153882
28932 Reviewed by Alexey Proskuryakov.
28934 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
28935 (BuildbotCombinedQueueView.prototype.update): Set status to "all builds succeeded" for combined builder queues
28938 2016-02-03 Filip Pizlo <fpizlo@apple.com>
28940 run-jsc-stress-tests should be better at telling you details about test failures
28941 https://bugs.webkit.org/show_bug.cgi?id=153845
28943 Reviewed by Geoffrey Garen.
28945 Here's an example of the contents of results/resultsByFamily, one of the new files that this
28946 generates, for some local testing I'm doing. Notice how it groups families of tests together.
28948 You won't see this unless you cat results/resultsByFamily.
28950 regress.yaml/Regress/radar-24289839.js:
28951 regress.yaml/Regress/radar-24289839.js.default: PASS
28952 regress.yaml/Regress/radar-24289839.js.ftl: PASS
28953 regress.yaml/Regress/radar-24289839.js.ftl-no-cjit: FAIL
28954 regress.yaml/Regress/radar-24289839.js.ftl-eager-no-cjit: FAIL
28956 regress.yaml/Regress/radar-24290639.js:
28957 regress.yaml/Regress/radar-24290639.js.default: PASS
28958 regress.yaml/Regress/radar-24290639.js.ftl: PASS
28959 regress.yaml/Regress/radar-24290639.js.ftl-no-cjit: PASS
28960 regress.yaml/Regress/radar-24290639.js.ftl-eager-no-cjit: FAIL
28962 regress.yaml/Regress/radar-24290670.js: FAILED
28964 * Scripts/run-jsc-stress-tests:
28966 2016-02-03 Carlos Garcia Campos <cgarcia@igalia.com>
28968 [WTR] Crash in EventSendingController::contextClick() when context menu event is not handled
28969 https://bugs.webkit.org/show_bug.cgi?id=153835
28971 Reviewed by Martin Robinson.
28973 WKBundlePageCopyContextMenuAtPointInWindow() returns nullptr when
28974 the context menu event is not handled, but we are using the
28975 returned value without null checking it.
28977 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
28978 (WTR::EventSendingController::contextClick):
28980 2016-02-03 Jason Marcell <jmarcell@apple.com>
28982 Format revisions for display according to repository type
28983 https://bugs.webkit.org/show_bug.cgi?id=153818
28985 Reviewed by Alexey Proskuryakov.
28987 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
28988 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Use new _formatRevisionForDisplay to display revisions according
28989 to repository type.
28990 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
28991 (BuildbotQueueView.prototype._formatRevisionForDisplay): Formats revisions for display according to repository type.
28992 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test new
28993 _formatRevisionForDisplay function.
28995 2016-02-03 Aakash Jain <aakash_jain@apple.com>
28997 Logs/CoreSimulator filling up OS disk on WebKit testers
28998 https://bugs.webkit.org/show_bug.cgi?id=153853
28999 <rdar://problem/24496003>
29001 Reviewed by Alexey Proskuryakov.
29003 * Scripts/webkitpy/port/ios.py:
29004 (IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup.
29006 2016-02-03 Brian Burg <bburg@apple.com>
29008 git-add-reviewer should work when run from a subdirectory within the repository
29009 https://bugs.webkit.org/show_bug.cgi?id=153842
29011 Reviewed by David Kilzer.
29013 There are two problems that needed to be fixed:
29015 - We can't assume .git is in $PWD/.git
29016 - We can't specify absolute paths to `git commit`
29018 Fix these problems using the helpers in VCSUtils that were added to
29019 fix this same issue for prepare-changeCogs.
29021 * Scripts/VCSUtils.pm: Export gitDirectory()
29022 * Scripts/git-add-reviewer:
29023 (nonInteractive): Cache gitDirectory() result.
29026 (changeLogsForCommit): Make paths relative.
29028 2016-02-03 Jer Noble <jer.noble@apple.com>
29030 Yet another Yosemite build fix.
29032 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
29034 2016-02-03 Jer Noble <jer.noble@apple.com>
29036 iOS build fix after Yosemite build fix broke iOS build.
29038 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
29040 2016-02-03 Jer Noble <jer.noble@apple.com>
29042 Yosemite build fix; hide the entire WebCoreNSURLSessionDataTask class from Yosemite and prior.
29044 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
29046 2016-02-03 Joonghun Park <jh718.park@samsung.com>
29048 [Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well
29049 https://bugs.webkit.org/show_bug.cgi?id=153827
29051 Reviewed by Michael Catanzaro.
29053 When an array is passed to subroutines as argument in perl,
29054 a list containing its element is returned from the array.
29055 Currently @$ arguments are being passed, then it is going to be one list
29056 including all the elements not only from @ but also from $.
29057 As a result, --cmakeargs option's value is included in @cmakeArgs
29058 at generateBuildSystemFromCMakeProject subroutine,
29059 so $additionalCMakeArgs doesn't needed anymore.
29061 * Scripts/webkitdirs.pm:
29062 (generateBuildSystemFromCMakeProject):
29064 2016-02-03 Jer Noble <jer.noble@apple.com>
29066 [Mac] Wrap a resource and resource loader in a NSURLSession-like object for use by lower level frameworks
29067 https://bugs.webkit.org/show_bug.cgi?id=153669
29069 Reviewed by Alex Christensen.
29071 Add an API test for WebCoreNSURLSession, testing that it behaves like a regulare NSURLSession, including
29072 calling appropriate NSURLSessionDelegate callbacks.
29074 Drive-by fix: Add a FeatureDefines.xcconfig to TestWebKitAPI. Without this, the ENABLE macros in WebCore
29075 header files will not match the one used when compiling WebCore, leading to strange crashes and weird
29076 inconsistencies when calling, e.g., inline methods.
29078 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added.
29079 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
29080 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
29081 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: Added.
29082 (-[TestNSURLSessionLoaderDelegate webView:didCommitLoadForFrame:]):
29083 (-[TestNSURLSessionDataDelegate URLSession:task:didCompleteWithError:]):
29084 (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
29085 (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveData:]):
29086 (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
29087 (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
29088 (TestWebKitAPI::TEST_F):
29090 2016-02-03 Konstantin Tokarev <annulen@yandex.ru>
29092 [webkitdirs] Clarify logic behind is{PortName} functions.
29093 https://bugs.webkit.org/show_bug.cgi?id=153554
29095 Reviewed by Michael Catanzaro.
29097 * Scripts/webkitdirs.pm:
29098 (prohibitUnknownPort): This function makes determinePortName()
29100 (determinePortName): Added new function which decides which port are
29101 we building based on command line switches and platform defaults.
29102 (portName): Added getter for determined $portName.
29103 (isEfl): Modified to use portName().
29105 (isWinCairo): Ditto.
29106 (isAppleMacWebKit): Ditto.
29107 (isAppleWinWebKit): Ditto.
29108 (isIOSWebKit): Ditto.
29109 (cmakeBasedPortName): Return portName() with capitalized first letter.
29110 (determineIsEfl): Deleted.
29111 (determineIsGtk): Deleted.
29112 (determineIsWinCairo): Deleted.
29114 * Scripts/build-jsc: Call prohibitUnknownPort().
29115 * Scripts/run-minibrowser: Ditto.
29116 * Scripts/webkitperl/FeatureList.pm: Ditto.
29117 * Scripts/update-webkit: Call determinePortName() instead of
29118 determineIsWinCairo().
29120 2016-02-02 Dan Bernstein <mitz@apple.com>
29122 Better fix for Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
29123 https://bugs.webkit.org/show_bug.cgi?id=153683
29125 Reviewed by Darin Adler.
29127 * Scripts/webkitpy/port/driver.py:
29128 (Driver._setup_environ_for_driver): Reverted change from r196013. DUMPRENDERTREE_TEMP is not
29129 used by any code in the Web Content process. If that ever changed, we should send it over
29130 as a bundle parameter.
29132 * Scripts/webkitpy/port/ios.py:
29133 (IOSSimulatorPort.setup_environ_for_server): Reverted change from r196013.
29135 * Scripts/webkitpy/port/mac.py:
29136 (MacPort.setup_environ_for_server): Ditto.
29138 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
29139 (WTR::InjectedBundle::platformInitialize): Set XML_CATALOG_FILES in the Web Process
29140 environment. This is early enough that libxml2 has not been initialized yet.
29142 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
29143 (WTR::InjectedBundle::platformInitialize): Ditto.
29145 2016-02-02 Dan Bernstein <mitz@apple.com>
29147 Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
29148 https://bugs.webkit.org/show_bug.cgi?id=153683
29150 Reviewed by Alexey Proskuryakov.
29152 Ensure that XML_CATALOG_FILES is set in the Web Content service’s environment as well.
29154 * Scripts/webkitpy/port/driver.py:
29155 (Driver._setup_environ_for_driver): Also set __XPC_DUMPRENDERTREE_TEMP.
29156 * Scripts/webkitpy/port/ios.py:
29157 (IOSSimulatorPort.setup_environ_for_server): Set __XPC_XML_CATALOG_FILES.
29158 * Scripts/webkitpy/port/mac.py:
29159 (MacPort.setup_environ_for_server): Ditto.
29161 2016-01-29 Grzegorz Czajkowski <g.czajkowski@samsung.com>
29163 [EFL] Virtual Keyboard overlaps MiniBrowser's WebView
29164 https://bugs.webkit.org/show_bug.cgi?id=153009
29166 Reviewed by Gyuyoung Kim.
29168 On mobile, virtual keyboard represented by ecore_imf module appears on
29169 the top of application layer usually covering bottom part of the screen.
29170 If the web page contains the editable content on the bottom of the page
29171 it will be overlapped by keyboard which prevents user from seeing the
29174 Pack MiniBrowser layout into conformant widget to allow EFL to guess
29175 the space that will be required by the keyboard, finally resizing it
29176 to the desired size. As a result, webview gets resized and scrolled
29177 into focused elements which makes the editable elements visible while
29180 More details about elm_conformant widger can be found at:
29181 https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
29182 https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
29184 * MiniBrowser/efl/main.c:
29185 (window_create): pack a box into conformant widget.
29187 2016-02-02 Alejandro G. Castro <alex@igalia.com>
29189 [GTK][EFL] Upgrade OpenWebRTC dependency
29190 https://bugs.webkit.org/show_bug.cgi?id=153489
29192 Reviewed by Philippe Normand.
29194 * Scripts/run-gtk-tests:
29195 (TestRunner): Avoid running the mediastream API test.
29196 * Scripts/webkitperl/FeatureList.pm: Stop compiling mediastream by
29197 default for gtk and efl.
29198 * gtk/jhbuild-webrtc.modules: Added modules files with
29199 dependencies required to compile and test the mediastream.
29201 2016-02-01 Jason Marcell <jmarcell@apple.com>
29203 Add code to parse the git branches out of the Trac RSS feed
29204 https://bugs.webkit.org/show_bug.cgi?id=153624
29206 Reviewed by Daniel Bates.
29208 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
29209 (Trac.prototype.commitsOnBranch): Update filter to check for Git branches.
29210 (Trac.prototype._convertCommitInfoElementToObject): Parse Git branches from the Trac RSS feed. Also changed "branchName" to
29211 "branches" and updated the code to work with an array instead of a string.
29212 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
29213 (MockTrac): Refactored example commits out into a constant, MockTrac.EXAMPLE_TRAC_COMMITS.
29214 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml: Added. Test
29215 fixture that contains XML with a Git branch.
29216 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing Git
29217 branches from Trac RSS feed. Also updated code to work with the new MockTrac.EXAMPLE_TRAC_COMMITS constant.
29219 2016-02-01 Brady Eidson <beidson@apple.com>
29221 Add command line flag to DRT to output the number of tests completed in server mode.
29222 https://bugs.webkit.org/show_bug.cgi?id=153750
29224 Reviewed by Darin Adler.
29226 * DumpRenderTree/mac/DumpRenderTree.mm:
29227 (initializeGlobalsFromCommandLineOptions):
29228 (runTestingServerLoop):
29230 2016-02-01 Jason Marcell <jmarcell@apple.com>
29232 Improvements to botwatcher's dashboard unit tests.
29233 https://bugs.webkit.org/show_bug.cgi?id=153621
29235 Reviewed by Darin Adler.
29237 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
29238 (PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.
29239 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
29240 (MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and
29241 _popoverLinesForCommitRange have to traverse commits from different branches.
29242 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual
29243 in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
29244 _revisionContentWithPopoverForIteration.
29246 2016-02-01 Jason Marcell <jmarcell@apple.com>
29248 Refactor to add event listeners and start periodic updates for all trac instances.
29249 https://bugs.webkit.org/show_bug.cgi?id=153609
29251 Reviewed by Darin Adler.
29253 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
29254 (BuildbotQueueView): Adding event listeners for all trac instances.
29255 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Starting periodic updates
29256 for all trac instances.
29258 2016-01-31 Darin Adler <darin@apple.com>
29260 Replace CaseFoldingHash with ASCIICaseInsensitiveHash
29261 https://bugs.webkit.org/show_bug.cgi?id=153639
29263 Reviewed by Filip Pizlo.
29265 * Scripts/do-webcore-rename: Use script to do this rename.
29267 2016-01-30 Commit Queue <commit-queue@webkit.org>
29269 Unreviewed, rolling out r195911.
29270 https://bugs.webkit.org/show_bug.cgi?id=153723
29272 Caused frequent assertion failures on bots (Requested by ap on
29275 Reverted changeset:
29277 "Replace CaseFoldingHash with ASCIICaseInsensitiveHash"
29278 https://bugs.webkit.org/show_bug.cgi?id=153639
29279 http://trac.webkit.org/changeset/195911
29281 2016-01-30 Darin Adler <darin@apple.com>
29283 Replace CaseFoldingHash with ASCIICaseInsensitiveHash
29284 https://bugs.webkit.org/show_bug.cgi?id=153639
29286 Reviewed by Filip Pizlo.
29288 * Scripts/do-webcore-rename: Use script to do this rename.
29290 2016-01-30 Ryosuke Niwa <rniwa@webkit.org>
29292 TouchList should be retargeted
29293 https://bugs.webkit.org/show_bug.cgi?id=149592
29295 Reviewed by Antti Koivisto.
29297 Added touchDownAtPoint and liftUpAtPoint to UIScriptController so that we can test touch events with
29298 multiple touch targets on iOS. fast/shadow-dom/touch-event-ios.html uses this new testing feature.
29300 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
29301 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
29302 (WTR::UIScriptController::touchDownAtPoint): Added.
29303 (WTR::UIScriptController::liftUpAtPoint): Added.
29304 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
29305 * WebKitTestRunner/ios/HIDEventGenerator.h:
29306 * WebKitTestRunner/ios/HIDEventGenerator.mm:
29307 (-[HIDEventGenerator touchDown:touchCount:completionBlock:]): Added. Sends touch down and waits.
29308 (-[HIDEventGenerator liftUp:touchCount:completionBlock:]): Ditto for lift up.
29309 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
29310 (WTR::UIScriptController::touchDownAtPoint): Added.
29311 (WTR::UIScriptController::liftUpAtPoint): Added.
29313 2016-01-30 Yusuke Suzuki <utatane.tea@gmail.com>
29315 Enable SamplingProfiler on POSIX environment
29316 https://bugs.webkit.org/show_bug.cgi?id=153584
29318 Reviewed by Michael Saboff.
29320 * Scripts/run-jsc-stress-tests:
29322 2016-01-29 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
29324 update-webkit-dependency fails to fetch updates through firewall on Windows
29325 https://bugs.webkit.org/show_bug.cgi?id=153619
29327 Reviewed by Myles C. Maxfield.
29329 On Windows, when a firewall is present we need to read proxy settings
29330 from environment variables.
29332 This patch relies on the following environment variables being set:
29336 * Scripts/update-webkit-dependency:
29338 2016-01-28 Dan Bernstein <mitz@apple.com>
29340 [Cocoa] Use the non-Development variants of XPC services for development
29341 https://bugs.webkit.org/show_bug.cgi?id=152545
29343 Reviewed by Darin Adler.
29345 * Scripts/webkitdirs.pm:
29346 (setUpGuardMallocIfNeeded): Ensure that libgmalloc is loaded into XPC services as well.
29348 * Scripts/webkitpy/port/driver.py:
29349 (Driver._setup_environ_for_driver): Ensure that the DYLD_LIBRARY_PATH and ASAN_OPTIONS are
29350 set in the XPC services as well.
29352 * Scripts/webkitpy/port/ios.py:
29353 (IOSSimulatorPort.setup_environ_for_server): Ensure that malloc stack logging for leaks and
29354 Guard Malloc are enabled in XPC services as well.
29356 * Scripts/webkitpy/port/mac.py:
29357 (MacPort.setup_environ_for_server): Ditto.
29359 2016-01-28 Csaba Osztrogonác <ossy@webkit.org>
29361 Unreviewed buildfix after r195743.
29363 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
29364 (WTR::AccessibilityUIElement::isPressActionSupported):
29366 2016-01-12 Jer Noble <jer.noble@apple.com>
29368 Custom protocol loading through AVFoundation does not support byte-range requests.
29369 https://bugs.webkit.org/show_bug.cgi?id=152919
29370 <rdar://problem/23664657>
29372 Reviewed by Alex Christensen.
29374 Add tests for new ParsedContntRange class.
29376 * TestWebKitAPI/PlatformWin.cmake:
29377 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
29378 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
29379 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
29380 * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: Added.
29381 (TestWebKitAPI::TEST):
29383 2016-01-28 Konstantin Tokarev <annulen@yandex.ru>
29385 Use isAnyWindows() instead of isCygwin() || isWindows() in Perl scripts.
29386 https://bugs.webkit.org/show_bug.cgi?id=153594
29388 Reviewed by Alex Christensen.
29390 * Scripts/webkitdirs.pm:
29391 (determineNumberOfCPUs):
29395 (wrapperPrefixIfNeeded):
29396 (cmakeGeneratedBuildfile):
29397 (generateBuildSystemFromCMakeProject):
29398 * Scripts/webkitperl/features.pm:
29399 (libraryContainsSymbol):
29401 2016-01-28 Chris Dumez <cdumez@apple.com>
29403 Unreviewed, rolling out r195742.
29407 Reverted changeset:
29409 "[webkitdirs] Clarify logic behind is{PortName} functions."
29410 https://bugs.webkit.org/show_bug.cgi?id=153554
29411 http://trac.webkit.org/changeset/195742
29413 2016-01-28 Darin Adler <darin@apple.com>
29415 Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
29416 https://bugs.webkit.org/show_bug.cgi?id=153411
29418 Reviewed by Ryosuke Niwa.
29420 * Scripts/do-webcore-rename: Removed rename of equalIgnoringCase since we
29421 have removed the function instead.
29423 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
29424 (TestWebKitAPI::TEST): Updated test since nullptr is now ambiguous since we
29425 added overloads for const char*.
29427 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
29428 (WTR::AccessibilityUIElement::isPressActionSupported): Use equalLettersIgnoringASCIICase.
29429 (WTR::AccessibilityUIElement::hasPopup): Ditto.
29430 * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
29431 (WTR::testPathFromURL): Ditto.
29433 2016-01-28 Konstantin Tokarev <annulen@yandex.ru>
29435 [webkitdirs] Clarify logic behind is{PortName} functions.
29436 https://bugs.webkit.org/show_bug.cgi?id=153554
29438 Reviewed by Darin Adler.
29440 * Scripts/webkitdirs.pm:
29441 (determinePortName): Added new function which decides which port are
29442 we building based on command line switches and platform defaults.
29443 (portName): Added getter for determined $portName.
29444 (isEfl): Modified to use portName().
29446 (isWinCairo): Ditto.
29447 (isAppleMacWebKit): Ditto.
29448 (isAppleWinWebKit): Ditto.
29449 (isIOSWebKit): Ditto.
29450 (cmakeBasedPortName): Code replaced with portName() call.
29451 (determineIsEfl): Deleted.
29452 (determineIsGtk): Deleted.
29453 (determineIsWinCairo): Deleted.
29455 2016-01-28 Konstantin Tokarev <annulen@yandex.ru>
29457 [webkitdirs] Don't pass cmakeBasedPortName around.
29458 https://bugs.webkit.org/show_bug.cgi?id=153589
29460 Reviewed by Darin Adler.
29462 It should be local function of webkitdirs.pm instead.
29464 * Scripts/build-jsc: Don't pass cmakeBasedPortName to
29465 buildCMakeProjectOrExit().
29466 * Scripts/build-webkit: Don't pass cmakeBasedPortName to
29467 buildCMakeProjectOrExit() and generateBuildSystemFromCMakeProject().
29468 * Scripts/run-efl-tests: Don't pass cmakeBasedPortName to
29469 generateBuildSystemFromCMakeProject().
29470 * Scripts/webkitdirs.pm: Don't export cmakeBasedPortName.
29471 (generateBuildSystemFromCMakeProject): Removed $port argument as we
29472 can get it from cmakeBasedPortName().
29473 (buildCMakeProjectOrExit): Ditto.
29475 2016-01-28 Gwang Yoon Hwang <yoon@igalia.com>
29477 [GStreamer] Clean up includes and headers related with GStreamerGL
29478 https://bugs.webkit.org/show_bug.cgi?id=153590
29480 Reviewed by Philippe Normand.
29482 * Scripts/webkitpy/style/checker.py: Skips
29483 include_order check for MediaPlayerPrivateGStreamerBase.cpp
29484 Removes VideoSinkGStreamer1.cpp which doesn't exist anymore.
29486 2016-01-27 Krzysztof Czech <k.czech@samsung.com>
29488 [EFL] Remove unused accessibility related code
29489 https://bugs.webkit.org/show_bug.cgi?id=153543
29491 Reviewed by Darin Adler.
29493 Removed reference to EAIL library.
29494 It not going to be support anymore. There have been changes in
29495 EFL/Elementary in terms of the accessibility and we should
29498 * efl/jhbuild-optional.modules:
29500 2016-01-27 Daniel Bates <dabates@apple.com>
29502 Remove WebKitSystemInterface for iOS SDK < 9
29503 https://bugs.webkit.org/show_bug.cgi?id=153570
29505 Reviewed by Andy Estes.
29507 * Scripts/copy-webkitlibraries-to-product-directory:
29509 2016-01-27 Jason Marcell <jmarcell@apple.com>
29511 Fix bugs caused by incorrect usage of "branch" vs. "branchName".
29512 https://bugs.webkit.org/show_bug.cgi?id=153330
29514 Reviewed by Daniel Bates.
29516 In an earlier patch we started using the name "branch" to indicate a branch object, whereas
29517 "branchName" implies that the variable or property in question is simply a string. We fixed some
29518 inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
29519 spotted in BuildbotQueueView.js.
29521 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
29522 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
29523 Changed branchName to branch.name in call to commitsOnBranch.
29524 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
29525 _popoverLinesForCommitRange.
29526 (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
29527 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
29528 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
29531 2016-01-27 Ryosuke Niwa <rniwa@webkit.org>
29533 Add API to access closed shadowRoot in InjectedBundle
29534 https://bugs.webkit.org/show_bug.cgi?id=153533
29536 Reviewed by Antti Koivisto.
29538 Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
29540 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
29541 * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
29542 (TestWebKitAPI::runJavaScriptAlert):
29543 (TestWebKitAPI::TEST):
29544 * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
29545 (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
29546 (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
29548 2016-01-27 Jason Marcell <jmarcell@apple.com>
29550 Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
29551 https://bugs.webkit.org/show_bug.cgi?id=153332
29553 Reviewed by Alexey Proskuryakov.
29555 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
29556 (Trac.prototype._xmlTimelineURL): Uses new function.
29557 (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
29558 logic for parsing git hashes.
29559 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
29560 Trac._parseRevisionFromURL.
29562 2016-01-27 Alexey Proskuryakov <ap@apple.com>
29564 Remove Mavericks from the flakiness dashboard
29565 https://bugs.webkit.org/show_bug.cgi?id=153521
29567 Reviewed by Dan Bernstein.
29569 * TestResultServer/static-dashboards/builders.jsonp:
29570 * TestResultServer/static-dashboards/flakiness_dashboard.js:
29572 2016-01-27 Alexey Proskuryakov <ap@apple.com>
29574 Remove ENABLE_CURRENTSRC
29575 https://bugs.webkit.org/show_bug.cgi?id=153545
29577 Reviewed by Simon Fraser.
29579 * Scripts/webkitperl/FeatureList.pm:
29581 2016-01-26 Jason Marcell <jmarcell@apple.com>
29583 Sort incoming commits via date instead of revision number.
29584 https://bugs.webkit.org/show_bug.cgi?id=153467
29586 Reviewed by Alexey Proskuryakov.
29588 Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
29589 for sorting revisions. Instead we use the commit date to sort revisions chronologically.
29591 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
29592 (Trac.prototype._loaded): Sort via date instead of revision number.
29593 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
29594 (MockTrac): Fix up the mock data to look more like real-world data.
29595 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
29596 Fake RSS feed that adds three more commits.
29597 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
29600 2016-01-26 I-Ting Liu <iting_liu@apple.com>
29602 Add a test for WebKit::stringMatchesWildcardString.
29603 https://bugs.webkit.org/show_bug.cgi?id=153090
29605 Reviewed by Darin Adler.
29607 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
29608 Add the file to the project.
29610 * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
29611 (TestWebKitAPI::TEST):
29612 Test that a string matches another string that may contain wildcard characters.
29614 2016-01-26 Konstantin Tokarev <annulen@yandex.ru>
29616 [webkitdirs] Removed check for bison, gperf, and flex.
29617 https://bugs.webkit.org/show_bug.cgi?id=153496
29619 Reviewed by Alex Christensen.
29621 This prerequisites are checked in WebKitCommon.cmake and don't
29622 have to be in $PATH.
29624 * Scripts/webkitdirs.pm:
29625 (checkRequiredSystemConfig):
29627 2016-01-26 Konstantin Tokarev <annulen@yandex.ru>
29629 [webkitdirs] isCMakeBuild should be true by default
29630 https://bugs.webkit.org/show_bug.cgi?id=153497
29632 Reviewed by Michael Catanzaro.
29634 * Scripts/webkitdirs.pm:
29637 2016-01-26 Daniel Bates <dabates@apple.com>
29639 Add WebKitSystemInterface for iOS 9.2
29640 https://bugs.webkit.org/show_bug.cgi?id=153355
29642 Rubber-stamped by David Kilzer.
29644 * Scripts/copy-webkitlibraries-to-product-directory:
29646 2016-01-26 Daniel Bates <dabates@apple.com>
29648 WebKitTestRunner: Credential cache is not cleared between tests
29649 https://bugs.webkit.org/show_bug.cgi?id=153407
29650 <rdar://problem/24280834>
29652 Reviewed by Alexey Proskuryakov.
29654 * WebKitTestRunner/TestController.cpp:
29655 (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
29656 to clear cached credentials.
29658 2016-01-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
29660 kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
29661 https://bugs.webkit.org/show_bug.cgi?id=153483
29663 Reviewed by Csaba Osztrogonác.
29665 * BuildSlaveSupport/kill-old-processes:
29666 (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
29668 2016-01-25 Simon Fraser <simon.fraser@apple.com>
29670 Give the layout test results file a <title> showing the date and time the tests were run
29671 https://bugs.webkit.org/show_bug.cgi?id=153187
29673 Reviewed by Darin Adler.
29675 Include a 'date' property in the JSON with the date and time the tests completed.
29677 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
29678 (summarize_results):
29680 2016-01-25 Commit Queue <commit-queue@webkit.org>
29682 Unreviewed, rolling out r195543.
29683 https://bugs.webkit.org/show_bug.cgi?id=153451
29685 regressed performance of test bots by ~6% (Requested by dydz
29688 Reverted changeset:
29690 "WebKitTestRunner: Credential cache is not cleared between
29692 https://bugs.webkit.org/show_bug.cgi?id=153407
29693 http://trac.webkit.org/changeset/195543
29695 2016-01-25 Aakash Jain <aakash_jain@apple.com>
29697 Failing to upload to flakiness dashboard should not be a hard error
29698 https://bugs.webkit.org/show_bug.cgi?id=153444
29699 <rdar://problem/22146294>
29701 Reviewed by Alexey Proskuryakov.
29703 * Scripts/webkitpy/layout_tests/controllers/manager.py:
29704 (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
29706 2016-01-25 Daniel Bates <dabates@apple.com>
29708 WebKitTestRunner: Credential cache is not cleared between tests
29709 https://bugs.webkit.org/show_bug.cgi?id=153407
29710 <rdar://problem/24280834>
29712 Reviewed by Brady Eidson.
29714 * WebKitTestRunner/TestController.cpp:
29715 (WTR::TestController::resetStateToConsistentValues): Reset testing network session
29716 to clear cached credentials.
29718 2016-01-24 Dan Bernstein <mitz@apple.com>
29720 Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
29722 * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
29724 2016-01-22 Enrica Casucci <enrica@apple.com>
29726 Unreviewed build fix after http://trac.webkit.org/changeset/195474.
29728 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
29729 (WTR::TestController::platformCreateWebView):
29731 2016-01-22 Tim Horton <timothy_horton@apple.com>
29733 Add a test for iOS arrow-key repeat
29734 https://bugs.webkit.org/show_bug.cgi?id=152857
29735 <rdar://problem/24017380>
29737 Reviewed by Darin Adler.
29739 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
29740 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
29741 (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
29742 (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
29743 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
29744 * WebKitTestRunner/ios/HIDEventGenerator.h:
29745 * WebKitTestRunner/ios/HIDEventGenerator.mm:
29746 (-[HIDEventGenerator keyPress:completionBlock:]):
29747 (-[HIDEventGenerator keyDown:completionBlock:]):
29748 (-[HIDEventGenerator keyUp:completionBlock:]):
29749 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
29750 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
29751 (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
29752 (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
29753 Make it possible to independently send keyUp/keyDown, instead of just paired.
29755 2016-01-22 Tim Horton <timothy_horton@apple.com>
29757 Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
29758 https://bugs.webkit.org/show_bug.cgi?id=153193
29759 <rdar://problem/24222034>
29761 Reviewed by Darin Adler.
29763 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
29764 (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
29766 Add a test that exhibits the problems we're fixing here.
29767 Before, it would both log and assert in debug, and crash in release.
29768 Now it runs happily to completion.
29770 2016-01-22 Enrica Casucci <enrica@apple.com>
29772 Add support for testing data detection.
29773 https://bugs.webkit.org/show_bug.cgi?id=153360
29775 Reviewed by Tim Horton.
29777 Adding a new testing option (useDataDetection) to turn on
29778 data detection when running the a test.
29780 * WebKitTestRunner/TestController.cpp:
29781 (WTR::updateTestOptionsFromTestHeader):
29782 * WebKitTestRunner/TestOptions.h:
29783 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
29784 (WTR::TestController::platformCreateWebView):
29786 2016-01-21 Simon Fraser <simon.fraser@apple.com>
29788 Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
29789 https://bugs.webkit.org/show_bug.cgi?id=153334
29791 Reviewed by Zalan Bujtas.
29793 Evaluating expressions in the LayoutUnit summary provider seems to cause
29794 re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
29797 * lldb/lldb_webkit.py:
29798 (WebCoreLayoutUnitProvider.to_string):
29800 2016-01-21 Filip Pizlo <fpizlo@apple.com>
29802 display-profiler-output should be able to display code blocks sorted by machine counts
29803 https://bugs.webkit.org/show_bug.cgi?id=153298
29805 Reviewed by Oliver Hunt.
29807 * Scripts/display-profiler-output:
29809 2016-01-21 Julien Isorce <j.isorce@samsung.com>
29811 Ensure to use compatible liborc version with wanted gstreamer version
29812 https://bugs.webkit.org/show_bug.cgi?id=153276
29814 For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
29815 The user may have a very recent liborc installed on his system.
29817 Reviewed by Philippe Normand.
29819 * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
29820 * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
29822 2016-01-21 Nan Wang <n_wang@apple.com>
29824 AX: [IOS] Implement next/previous text marker functions using TextIterator
29825 https://bugs.webkit.org/show_bug.cgi?id=153292
29826 <rdar://problem/24268243>
29828 Reviewed by Chris Fleizach.
29830 Made text marker tests available on iOS.
29832 * DumpRenderTree/AccessibilityTextMarker.h:
29833 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
29834 * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
29835 (AccessibilityTextMarker::AccessibilityTextMarker):
29836 (AccessibilityTextMarker::~AccessibilityTextMarker):
29837 (AccessibilityTextMarker::isEqual):
29838 (AccessibilityTextMarker::platformTextMarker):
29839 (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
29840 (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
29841 (AccessibilityTextMarkerRange::isEqual):
29842 (AccessibilityTextMarkerRange::platformTextMarkerRange):
29843 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
29844 (AccessibilityUIElement::pathDescription):
29845 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
29846 (AccessibilityUIElement::textMarkerRangeForElement):
29847 (AccessibilityUIElement::selectedTextMarkerRange):
29848 (AccessibilityUIElement::resetSelectedTextMarkerRange):
29849 (AccessibilityUIElement::textMarkerRangeLength):
29850 (AccessibilityUIElement::textMarkerRangeForMarkers):
29851 (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
29852 (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
29853 (AccessibilityUIElement::accessibilityElementForTextMarker):
29854 (AccessibilityUIElement::endTextMarkerForBounds):
29855 (AccessibilityUIElement::startTextMarkerForBounds):
29856 (AccessibilityUIElement::textMarkerForPoint):
29857 (AccessibilityUIElement::previousTextMarker):
29858 (AccessibilityUIElement::nextTextMarker):
29859 (AccessibilityUIElement::stringForTextMarkerRange):
29860 (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
29861 (AccessibilityUIElement::indexForTextMarker):
29862 (AccessibilityUIElement::isTextMarkerValid):
29863 (AccessibilityUIElement::textMarkerForIndex):
29864 (AccessibilityUIElement::startTextMarker):
29865 (AccessibilityUIElement::endTextMarker):
29866 (AccessibilityUIElement::setSelectedVisibleTextRange):
29867 (AccessibilityUIElement::getLinkedUIElements):
29868 * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
29869 (AccessibilityTextMarkerRange::platformTextMarkerRange):
29870 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
29871 (AccessibilityUIElement::removeSelection):
29872 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
29873 (AccessibilityUIElement::setSelectedVisibleTextRange):
29874 (AccessibilityUIElement::supportedActions):
29875 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
29876 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
29877 (WTR::AccessibilityUIElement::textMarkerRangeLength):
29878 (WTR::AccessibilityUIElement::previousTextMarker):
29879 (WTR::AccessibilityUIElement::nextTextMarker):
29880 (WTR::AccessibilityUIElement::stringForTextMarkerRange):
29881 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
29882 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
29883 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
29884 (WTR::AccessibilityUIElement::endTextMarkerForBounds):
29885 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
29886 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
29888 2016-01-20 Filip Pizlo <fpizlo@apple.com>
29890 Unreviewed, revert accidental unreviewed commit.
29892 * Scripts/display-profiler-output:
29894 2016-01-20 Jason Marcell <jmarcell@apple.com>
29896 Refactor compareIterations to remove duplicate code.
29897 https://bugs.webkit.org/show_bug.cgi?id=152913
29899 Reviewed by Daniel Bates.
29901 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
29902 (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
29903 (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
29904 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
29905 the same behavior before and after refactor.
29907 2016-01-20 Dana Burkart <dburkart@apple.com>
29909 Botwatcher's dashboard should show an 'X' when the build is broken
29910 https://bugs.webkit.org/show_bug.cgi?id=152507
29912 Reviewed by David Kilzer.
29914 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
29915 (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
29916 (BuildbotStaticAnalyzerQueueView.prototype.update):
29918 2016-01-19 Jason Marcell <jmarcell@apple.com>
29920 Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
29921 https://bugs.webkit.org/show_bug.cgi?id=153262
29923 Reviewed by Alexey Proskuryakov.
29925 Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
29926 such cases this revisionContentForIteration method does not have any content to return, thus the
29929 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
29930 (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
29932 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
29934 [GTK] Runtime critical warnings when loading a URL after a session restore
29935 https://bugs.webkit.org/show_bug.cgi?id=153233
29937 Reviewed by Michael Catanzaro.
29941 * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
29943 (testWebKitWebViewNavigationAfterSessionRestore):
29946 2016-01-19 Michael Catanzaro <mcatanzaro@igalia.com>
29948 [GTK] Remove jhbuild-optional.modules
29949 https://bugs.webkit.org/show_bug.cgi?id=152964
29951 Reviewed by Alex Christensen.
29953 * gtk/jhbuild-optional.modules: Removed.
29954 * gtk/jhbuild.modules:
29956 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
29958 [GTK] Add support to load/save session in MiniBrowser
29959 https://bugs.webkit.org/show_bug.cgi?id=153201
29961 Reviewed by Michael Catanzaro.
29963 It makes it easier to test the new WebView session API.
29965 * MiniBrowser/gtk/BrowserWindow.c:
29966 (browserWindowFinalize): Free the session file path.
29967 (browserWindowSaveSession): Save the current WebView session if
29968 there's a session file path.
29969 (browserWindowDeleteEvent): Call browserWindowSaveSession().
29970 (browser_window_load_session): Try to load the session from the
29971 given file path, otherwise fall back to homepage and keep the
29972 session file to save the session on window close.
29973 * MiniBrowser/gtk/BrowserWindow.h:
29974 * MiniBrowser/gtk/main.c:
29975 (createBrowserWindow): Pass the given session file path when
29976 shouldLoadSession is TRUE.
29977 (main): Only allow to restore/save session when MiniBrowser is
29978 launched without URL arguments.
29980 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
29982 Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
29984 Geolocation is no longer allowed for unique origins after r195075.
29986 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
29987 (testWebViewGeolocationPermissionRequests):
29989 2016-01-18 Carlos Alberto Lopez Perez <clopez@igalia.com>
29991 [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
29992 https://bugs.webkit.org/show_bug.cgi?id=153216
29994 Reviewed by Michael Catanzaro.
29996 * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
29997 (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
29999 2016-01-18 Nan Wang <n_wang@apple.com>
30001 AX: [Mac] Implement next/previous text marker functions using TextIterator
30002 https://bugs.webkit.org/show_bug.cgi?id=152728
30004 Reviewed by Chris Fleizach.
30006 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
30007 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
30009 2016-01-18 Csaba Osztrogonác <ossy@webkit.org>
30011 [cmake] Add testair to the build system
30012 https://bugs.webkit.org/show_bug.cgi?id=153126
30014 Reviewed by Michael Catanzaro.
30016 * Scripts/build-jsc:
30018 2016-01-16 Myles C. Maxfield <mmaxfield@apple.com>
30020 Remove TextRun::allowsRoundingHacks()
30021 https://bugs.webkit.org/show_bug.cgi?id=153185
30023 Reviewed by Simon Fraser.
30025 * DumpRenderTree/mac/DumpRenderTree.mm:
30026 (resetWebViewToConsistentStateBeforeTesting): Deleted.
30028 2016-01-15 Konstantin Tokarev <annulen@yandex.ru>
30030 [webkitdirs] Avoid list form of open because it broke WinCairo
30031 https://bugs.webkit.org/show_bug.cgi?id=153106
30033 Reviewed by Alex Christensen.
30035 * Scripts/webkitdirs.pm:
30036 (determineArchitecture):
30038 2016-01-15 Simon Fraser <simon.fraser@apple.com>
30040 Add kdebug_trace signposts for a few WebCore operations
30041 https://bugs.webkit.org/show_bug.cgi?id=153136
30042 rdar://problem/24208487
30044 Reviewed by Sam Weinig.
30046 Plist used by kdebug_trace() viewing tools.
30048 * Tracing/SystemTracePoints.plist: Added.
30050 2016-01-14 Konstantin Tokarev <annulen@yandex.ru>
30052 [webkitdirs] Replaced grep invocation with perl code
30053 https://bugs.webkit.org/show_bug.cgi?id=153106
30055 Reviewed by Alex Christensen.
30057 * Scripts/webkitdirs.pm:
30058 (determineArchitecture):
30060 2016-01-14 Brian Burg <bburg@apple.com>
30062 prepare-changelog does not read paths containing spaces properly
30063 https://bugs.webkit.org/show_bug.cgi?id=137982
30065 Reviewed by Joseph Pecoraro.
30067 Escape whitespace in filenames before passing the file path to other functions.
30069 * Scripts/prepare-ChangeLog:
30070 (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
30072 2016-01-14 Jason Marcell <jmarcell@apple.com>
30074 Standardize the usage of "branch" vs. "branchName".
30075 https://bugs.webkit.org/show_bug.cgi?id=152982
30077 Reviewed by Daniel Bates.
30079 In an earlier patch we started using the name "branch" to indicate a branch object, whereas
30080 "branchName" implies that the variable or property in question is simply a string.
30082 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
30083 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
30084 (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
30085 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
30086 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
30087 (Trac.prototype.commitsOnBranch): Change branch to branchName.
30088 (Trac.prototype._convertCommitInfoElementToObject): Ditto.
30089 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
30092 2016-01-14 Jason Marcell <jmarcell@apple.com>
30094 Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
30095 https://bugs.webkit.org/show_bug.cgi?id=152910
30097 Reviewed by Daniel Bates.
30099 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
30100 (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
30101 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
30102 (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
30103 the need to talk to a real Buildbot server.
30104 (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
30105 without the need to talk to a real Buildbot server.
30106 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
30107 (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
30109 (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
30110 (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
30111 (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
30112 trying to talk to Trac.
30113 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
30115 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
30117 2016-01-14 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
30119 [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
30120 https://bugs.webkit.org/show_bug.cgi?id=132599
30122 Reviewed by Michael Catanzaro.
30124 Check if cmake Ninja generators are installed.
30126 * Scripts/webkitdirs.pm:
30127 (canUseNinjaGenerator):
30128 (canUseEclipseNinjaGenerator):
30129 (generateBuildSystemFromCMakeProject):
30130 (canUseEclipse): Deleted.
30132 2016-01-13 Myles C. Maxfield <mmaxfield@apple.com>
30134 [Cocoa] Testing with font family name "System Font" is unused
30135 https://bugs.webkit.org/show_bug.cgi?id=153073
30136 <rdar://problem/24091683>
30138 Reviewed by Brent Fulgham.
30140 * DumpRenderTree/mac/DumpRenderTree.mm:
30141 (allowedFontFamilySet): Deleted.
30142 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
30143 (WTR::allowedFontFamilySet): Deleted.
30144 * WebKitTestRunner/mac/TestControllerMac.mm:
30145 (WTR::allowedFontFamilySet): Deleted.
30147 2016-01-13 Daniel Bates <dabates@apple.com>
30149 [XSS Auditor] Add test when XSS payload is in the path portion of the URL
30150 https://bugs.webkit.org/show_bug.cgi?id=152871
30152 Reviewed by Brent Fulgham.
30154 Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
30155 <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
30157 * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
30159 2016-01-08 Andy Estes <aestes@apple.com>
30161 [Content Filtering] Lazily load platform frameworks
30162 https://bugs.webkit.org/show_bug.cgi?id=152881
30163 rdar://problem/23270886
30165 Reviewed by Brady Eidson.
30167 Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
30168 expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
30169 loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
30170 and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
30171 is loaded after an HTTPS request.
30173 To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
30174 Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
30175 WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
30176 also re-enabled on iOS after mistakenly being disabled by r188892.
30178 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
30179 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
30180 (TestWebKitAPI::TEST):
30181 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
30182 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
30183 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
30186 (-[LazilyLoadPlatformFrameworksController init]):
30187 (-[LazilyLoadPlatformFrameworksController webView]):
30188 (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
30189 (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
30190 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
30191 (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
30192 (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
30193 (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
30194 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
30195 (TestWebKitAPI::TEST):
30196 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
30197 (TestWebKitAPI::TEST): Deleted.
30198 * TestWebKitAPI/cocoa/TestProtocol.h:
30199 * TestWebKitAPI/cocoa/TestProtocol.mm:
30200 (+[TestProtocol registerWithScheme:]):
30201 (+[TestProtocol unregister]):
30203 2016-01-12 Dewei Zhu <dewei_zhu@apple.com>
30205 Fix the Sunpider converage in slow device.
30206 https://bugs.webkit.org/show_bug.cgi?id=152938
30207 <rdar://problem/22511411>
30209 Reviewed by Ryosuke Niwa.
30211 Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
30213 * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
30215 2016-01-12 Ryosuke Niwa <rniwa@webkit.org>
30217 Add a build flag for custom element
30218 https://bugs.webkit.org/show_bug.cgi?id=153005
30220 Reviewed by Alex Christensen.
30222 Added --custom-elements option to enable custom elements support.
30224 * Scripts/webkitperl/FeatureList.pm:
30226 2016-01-12 Benjamin Poulain <bpoulain@apple.com>
30228 [JSC] Add a help message when run-jsc-stress-tests fails
30229 https://bugs.webkit.org/show_bug.cgi?id=153014
30231 Reviewed by Csaba Osztrogonác.
30233 * Scripts/run-jsc-stress-tests:
30235 2016-01-11 Saam barati <sbarati@apple.com>
30237 run-jsc-stress-tests should try to figure out a JSC path
30238 https://bugs.webkit.org/show_bug.cgi?id=152971
30240 Reviewed by Yusuke Suzuki.
30242 This patch now allows run-jsc-stress-tests to be run
30243 without a "--jsc <jsc-path>" argument. It tries
30244 to take its best guess at a <jsc-path> automagically.
30246 This makes it much easier to just run run-jsc-stress-tests
30247 with a directory or a yaml file as an argument.
30248 You now just do this:
30249 `run-jsc-stress-tests <path-to-yaml>`
30251 `run-jsc-stress-tests <path-to-directory-of-js-files>`
30253 I wrote this patch because I'd often find myself hacking the
30254 run-javascriptcore-tests file just to run a particular subset of tests.
30255 Because I always forget the arguments to run-jsc-stress-tests (which means
30256 I always forgot to provide a --jsc argument), I always found it easier to
30257 just hack on that file instead of calling run-jsc-stress-tests directly.
30258 No longer is this true!
30260 * Scripts/run-jsc-stress-tests:
30262 2016-01-09 Andy Estes <aestes@apple.com>
30264 [Cocoa] Add SPI to opt out a URL scheme from the memory cache
30265 https://bugs.webkit.org/show_bug.cgi?id=152950
30266 rdar://problem/24066652
30268 Reviewed by Tim Horton.
30272 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
30273 * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
30274 (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
30275 (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
30276 (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
30277 (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
30278 (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
30279 (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
30282 2016-01-11 Commit Queue <commit-queue@webkit.org>
30284 Unreviewed, rolling out r194866.
30285 https://bugs.webkit.org/show_bug.cgi?id=152986
30287 This change broke the mac build (Requested by ryanhaddad on
30290 Reverted changeset:
30292 "[Cocoa] Add SPI to opt out a URL scheme from the memory
30294 https://bugs.webkit.org/show_bug.cgi?id=152950
30295 http://trac.webkit.org/changeset/194866
30297 2016-01-11 Andy Estes <aestes@apple.com>
30299 [Cocoa] Add SPI to opt out a URL scheme from the memory cache
30300 https://bugs.webkit.org/show_bug.cgi?id=152950
30301 rdar://problem/24066652
30303 Reviewed by Tim Horton.
30307 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
30308 * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
30309 (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
30310 (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
30311 (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
30312 (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
30313 (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
30314 (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
30317 2016-01-11 Konstantin Tokarev <annulen@yandex.ru>
30319 [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
30320 https://bugs.webkit.org/show_bug.cgi?id=152959
30322 Reviewed by Brent Fulgham.
30324 * Scripts/webkitdirs.pm:
30325 (determineArchitecture):
30327 2016-01-11 Michael Catanzaro <mcatanzaro@igalia.com>
30329 [GTK] W3C CSS2.1 anonymous table tests are failing
30330 https://bugs.webkit.org/show_bug.cgi?id=152455
30332 Reviewed by Mario Sanchez Prada.
30334 Add shared-mime-info to the jhbuild environment, since it affects the results of layout
30335 tests. Add upstream patches to fix detection of XHTML files.
30337 * gtk/jhbuild.modules:
30338 * gtk/patches/shared-mime-info-xht-glob.patch: Added.
30339 * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
30341 2016-01-10 Saam barati <sbarati@apple.com>
30343 Implement a sampling profiler
30344 https://bugs.webkit.org/show_bug.cgi?id=151713
30346 Reviewed by Filip Pizlo.
30348 * Scripts/run-jsc-stress-tests:
30350 2016-01-10 Konstantin Tokarev <annulen@yandex.ru>
30352 [webkitdirs] Try arch and uname commands on non-windows OS
30353 https://bugs.webkit.org/show_bug.cgi?id=152958
30355 Reviewed by Michael Catanzaro.
30357 Right now, determineArchitecture() uses `arch` and `uname -m`
30358 commands to determine architecture in case of condition (isGtk() ||
30359 isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
30360 instead, because this code is applicable to any non-windows OS WebKit
30361 supports (even Haiku which once was supported is moderately
30362 POSIX-compliant and has uname command).
30364 * Scripts/webkitdirs.pm:
30365 (determineArchitecture):
30367 2016-01-08 Aakash Jain <aakash_jain@apple.com>
30369 run-webkit-tests mis-counts totals when there are other crashes
30370 https://bugs.webkit.org/show_bug.cgi?id=152894
30371 <rdar://problem/24098697>
30373 Reviewed by Alexey Proskuryakov.
30375 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
30376 (TestRunResults.add): Do not update result counters for other crashes.
30378 2016-01-08 Youenn Fablet <youenn.fablet@crf.canon.fr>
30380 webkit-patch build-and-test should have an option to iterate over new tests
30381 https://bugs.webkit.org/show_bug.cgi?id=143093
30383 Reviewed by Michael Catanzaro.
30385 This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
30386 It allows running run-webkit-tests on modified or new paths in LayoutTests.
30387 Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
30388 It implements the translation of -expected.* paths to their related tests.
30389 It also implements the removal of skipped tests.
30391 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
30392 (LayoutTestFinder.find_touched_tests):
30393 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
30395 (MockPort.__init__):
30397 (LayoutTestFinderTests):
30398 (LayoutTestFinderTests.touched_files):
30399 (LayoutTestFinderTests.test_touched_test):
30400 (LayoutTestFinderTests.test_expected_touched_test):
30401 (LayoutTestFinderTests.test_platform_expected_touched_test):
30402 (LayoutTestFinderTests.test_platform_duplicate_touched_test):
30403 (LayoutTestFinderTests.test_touched_but_skipped_test):
30404 * Scripts/webkitpy/port/base.py:
30405 (Port.potential_test_names_from_expected_file):
30406 * Scripts/webkitpy/tool/commands/download_unittest.py:
30407 (DownloadCommandsTest._default_options):
30408 * Scripts/webkitpy/tool/steps/options.py:
30410 * Scripts/webkitpy/tool/steps/runtests.py:
30411 (RunTests.options):
30414 (RunTests._new_or_modified_tests):
30415 (RunTests._run_webkit_tests):
30416 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
30417 (RunTestsTest.test_webkit_run_unit_tests):
30418 * Scripts/webkitpy/tool/steps/steps_unittest.py:
30419 (StepsTest._step_options):
30421 2016-01-07 Joseph Pecoraro <pecoraro@apple.com>
30423 prepare-ChangeLog should include radar number
30424 https://bugs.webkit.org/show_bug.cgi?id=152839
30425 <rdar://problem/24093563>
30427 Reviewed by Daniel Bates.
30429 When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
30430 starts with a "<rdar://problem/####>" URL. If found, include that radar URL
30431 in the ChangeLog description after the bug URL.
30433 * Scripts/prepare-ChangeLog:
30434 (main): Update signatures.
30435 (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
30436 (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
30437 (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
30438 (generateNewChangeLogs): Include radar URL if we found one.
30440 * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
30441 Tests for the radar URL extraction.
30443 2016-01-07 Alexey Proskuryakov <ap@apple.com>
30445 testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
30446 https://bugs.webkit.org/show_bug.cgi?id=152390
30447 <rdar://problem/23948321>
30449 Reviewed by Simon Fraser.
30451 Fix two use-after-frees.
30453 1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
30454 but we may have already progressed to another test by the time the callback fires,
30455 having destroyed the TestInvocation.
30456 2. UIScriptController is a RefCounted object, but it has a raw pointer to
30457 UIScriptContext which has the same lifetime as a TestInvocation.
30458 As a result, completion blocks of UIScriptController actions would use a destroyed
30461 * WebKitTestRunner/TestInvocation.cpp:
30462 (WTR::TestInvocation::~TestInvocation):
30463 (WTR::TestInvocation::url):
30464 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
30465 (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
30466 (WTR::TestInvocation::runUISideScript):
30467 * WebKitTestRunner/TestInvocation.h:
30468 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
30469 (UIScriptContext::UIScriptContext):
30470 (UIScriptContext::~UIScriptContext):
30471 (UIScriptContext::runUIScript):
30472 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
30473 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
30474 (WTR::UIScriptController::UIScriptController):
30475 (WTR::UIScriptController::contextDestroyed):
30476 (WTR::UIScriptController::makeWindowObject):
30477 (WTR::UIScriptController::setWillBeginZoomingCallback):
30478 (WTR::UIScriptController::willBeginZoomingCallback):
30479 (WTR::UIScriptController::setDidEndZoomingCallback):
30480 (WTR::UIScriptController::didEndZoomingCallback):
30481 (WTR::UIScriptController::setDidEndScrollingCallback):
30482 (WTR::UIScriptController::didEndScrollingCallback):
30483 (WTR::UIScriptController::setDidShowKeyboardCallback):
30484 (WTR::UIScriptController::didShowKeyboardCallback):
30485 (WTR::UIScriptController::setDidHideKeyboardCallback):
30486 (WTR::UIScriptController::didHideKeyboardCallback):
30487 (WTR::UIScriptController::uiScriptComplete):
30488 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
30489 (WTR::UIScriptController::create):
30490 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
30491 (WTR::UIScriptController::doAsyncTask):
30492 (WTR::UIScriptController::zoomToScale):
30493 (WTR::UIScriptController::singleTapAtPoint):
30494 (WTR::UIScriptController::doubleTapAtPoint):
30495 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
30496 (WTR::UIScriptController::contentVisibleRect):
30497 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
30498 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
30499 (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
30500 (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
30501 (WTR::UIScriptController::platformSetDidEndScrollingCallback):
30502 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
30503 (WTR::UIScriptController::doAsyncTask):
30505 2016-01-07 Youenn Fablet <youenn.fablet@crf.canon.fr>
30507 [buildbot] clean-build script should remove untracked files and revert local changes too
30508 https://bugs.webkit.org/show_bug.cgi?id=142400
30510 Reviewed by Ryosuke Niwa.
30512 This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
30513 A helper routine SCM.discard_untracked_files is added for that purpose.
30515 * BuildSlaveSupport/clean-build:
30516 (main): Making call to Scripts/clean-webkit
30517 * Scripts/clean-webkit: Added.
30518 (main): Revert changes and delete untracked files.
30519 * Scripts/webkitpy/common/checkout/scm/scm.py:
30520 (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
30521 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
30522 (SCMTest._shared_test_discard_untracked_files):
30523 (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
30525 2016-01-06 Simon Fraser <simon.fraser@apple.com>
30527 Add a setting and preferences to enable display-list drawing. Does nothing yet.
30528 https://bugs.webkit.org/show_bug.cgi?id=152807
30530 Reviewed by Zalan Bujtas.
30532 Add an item to the Settings menu to toggle display-list drawing.
30534 * MiniBrowser/mac/SettingsController.h:
30535 * MiniBrowser/mac/SettingsController.m:
30536 (-[SettingsController _populateMenu]):
30537 (-[SettingsController validateMenuItem:]):
30538 (-[SettingsController toggleDisplayListDrawingEnabled:]):
30539 (-[SettingsController displayListDrawingEnabled]):
30540 * MiniBrowser/mac/WK2BrowserWindowController.m:
30541 (-[WK2BrowserWindowController didChangeSettings]):
30543 2016-01-06 Youenn Fablet <youenn.fablet@crf.canon.fr>
30545 Python SCM should be able to retrieve untracked files - Add GIT support
30546 https://bugs.webkit.org/show_bug.cgi?id=143135
30548 Reviewed by Michael Catanzaro.
30550 * Scripts/webkitpy/common/checkout/scm/git.py:
30551 (Git.untracked_files): Adding support for git.
30552 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
30554 (GitTest.test_untracked_files): Adding test.
30556 2016-01-05 Mark Lam <mark.lam@apple.com>
30558 Rename badly named JSC_timeout env var to JSCTEST_timeout.
30559 https://bugs.webkit.org/show_bug.cgi?id=152748
30561 Reviewed by Geoffrey Garen.
30563 Now that we validate JSC options, the badly named JSC_timeout env var causes the
30564 bots to have a bad time.
30566 * Scripts/run-javascriptcore-tests:
30567 * Scripts/run-jsc-stress-tests:
30569 2016-01-04 Carlos Garcia Campos <cgarcia@igalia.com>
30571 [GTK] Allow to save and restore session
30572 https://bugs.webkit.org/show_bug.cgi?id=115600
30574 Reviewed by Michael Catanzaro.
30576 Add test case to check the new session API.
30578 * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
30579 (testWebKitWebViewSessionState):
30580 (testWebKitWebViewSessionStateWithFormData):
30583 2016-01-04 Csaba Osztrogonác <ossy@webkit.org>
30585 [EFL] Bump EFL version to 1.16.1
30586 https://bugs.webkit.org/show_bug.cgi?id=152688
30588 Reviewed by Gyuyoung Kim.
30590 * efl/jhbuild.modules:
30592 2016-01-04 Aakash Jain <aakash_jain@apple.com>
30594 error running layout tests on iOS simulator on latest build
30595 https://bugs.webkit.org/show_bug.cgi?id=152719
30596 <rdar://problem/24009549>
30598 Reviewed by Alexey Proskuryakov.
30600 * Scripts/webkitpy/xcode/simulator.py:
30601 (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
30602 before running simctl spawn command.
30604 2016-01-03 Michael Catanzaro <mcatanzaro@igalia.com>
30606 Unreviewed, move Frédéric Wang to committers list
30608 He seems to be on the contributors list by accident. He has been landing his own commits for
30609 about two years now.
30611 * Scripts/webkitpy/common/config/contributors.json:
30613 2016-01-03 Michael Catanzaro <mcatanzaro@igalia.com>
30615 Unreviewed, move Sebastian Dröge to committers list harder
30617 He accidentally added himself to the reviewers list because the file is confusing. Then I
30618 accidentially moved him to the contributors list because the file is confusing, even though
30619 I knew the contributors list existed in this file and was attempting to add him to the
30620 committers list. Really move him to the committers list now.
30622 * Scripts/webkitpy/common/config/contributors.json:
30624 2016-01-02 Youenn Fablet <youenn.fablet@crf.canon.fr>
30626 Python SCM should be able to retrieve untracked files - Add SVN support
30627 https://bugs.webkit.org/show_bug.cgi?id=152546
30629 Reviewed by Michael Catanzaro.
30631 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
30632 (test_untracked_files): Activating test for SVN.
30633 * Scripts/webkitpy/common/checkout/scm/svn.py:
30634 (SVN.untracked_files): Implementing untracked files retrieval for SVN.
30636 2015-12-31 Andy Estes <aestes@apple.com>
30638 Replace WTF::move with WTFMove
30639 https://bugs.webkit.org/show_bug.cgi?id=152601
30641 Reviewed by Brady Eidson.
30643 * DumpRenderTree/TestRunner.h:
30644 (TestRunner::setAllowedHosts):
30645 * DumpRenderTree/win/DRTDataObject.cpp:
30646 (DRTDataObject::SetData):
30647 * TestWebKitAPI/Tests/WTF/Deque.cpp:
30648 (TestWebKitAPI::TEST):
30649 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
30650 (TestWebKitAPI::TEST):
30651 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
30652 (TestWebKitAPI::TEST):
30653 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
30654 (TestWebKitAPI::TEST):
30655 * TestWebKitAPI/Tests/WTF/Ref.cpp:
30656 (TestWebKitAPI::passWithRef):
30657 (TestWebKitAPI::TEST):
30658 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
30659 (TestWebKitAPI::TEST):
30660 * TestWebKitAPI/Tests/WTF/Vector.cpp:
30661 (TestWebKitAPI::TEST):
30662 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
30663 (TestWebKitAPI::TEST):
30664 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
30665 (TestWebKitAPI::TEST):
30666 * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
30667 (TestWebKitAPI::createTestValue):
30668 (TestWebKitAPI::TEST):
30669 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
30670 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
30671 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
30672 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
30673 (TestWebKitAPI::createNFAs):
30674 (TestWebKitAPI::TEST_F):
30675 * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
30676 (TestWebKitAPI::combine):
30677 * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
30678 (TestWebKitAPI::createNFAs):
30679 * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
30681 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
30682 (WebProcessTest::add):
30684 2016-01-01 Michael Catanzaro <mcatanzaro@igalia.com>
30686 [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
30687 https://bugs.webkit.org/show_bug.cgi?id=152634
30689 Reviewed by Carlos Garcia Campos.
30691 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
30692 (testLoadFromGResource): Added test.
30694 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
30695 (registerGResource): Added.
30696 (webkit_web_extension_initialize_with_user_data): Load the test gresource.
30697 * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
30698 * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
30700 2015-12-31 David Kilzer <ddkilzer@apple.com>
30702 REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
30703 <https://bugs.webkit.org/show_bug.cgi?id=152601>
30705 Ignore unknown pragmas on older clangs. Fixes the following
30708 Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
30709 #pragma clang diagnostic ignored "-Wself-move"
30713 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
30714 (TestWebKitAPI::TEST):
30715 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
30716 (TestWebKitAPI::TEST):
30718 2015-12-31 Andy Estes <aestes@apple.com>
30720 Update the style checker to advise using WTFMove() instead of WTF::move()
30721 https://bugs.webkit.org/show_bug.cgi?id=152601
30723 Reviewed by Daniel Bates.
30725 * Scripts/webkitpy/style/checkers/cpp.py:
30727 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
30728 (WebKitStyleTest.test_wtf_move):
30730 2015-12-31 Andy Estes <aestes@apple.com>
30732 Fix warnings uncovered by migrating to WTF_MOVE
30733 https://bugs.webkit.org/show_bug.cgi?id=152601
30735 Reviewed by Daniel Bates.
30737 Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
30738 self-move, even if doing so would trigger a warning.
30740 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
30741 (TestWebKitAPI::TEST):
30742 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
30743 (TestWebKitAPI::TEST):
30745 2015-12-31 Martin Robinson <mrobinson@igalia.com>
30747 [GTK] The install-dependencies script has a syntax error
30748 https://bugs.webkit.org/show_bug.cgi?id=152613
30750 Reviewed by Michael Catanzaro.
30752 * gtk/install-dependencies: Add the missing 'then.'
30754 2015-12-30 Philippe Normand <pnormand@igalia.com>
30756 [Mac][GTK] Jhbuild support for OSX
30757 https://bugs.webkit.org/show_bug.cgi?id=150799
30759 Reviewed by Michael Catanzaro.
30761 * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
30762 * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
30763 * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
30764 * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
30766 2015-12-28 Michael Catanzaro <mcatanzaro@igalia.com>
30768 Unreviewed, move Sebastian Dröge to committers list
30770 He accidentally added himself to the reviewers list because the file is confusing.
30772 * Scripts/webkitpy/common/config/contributors.json:
30774 2015-12-24 Simon Fraser <simon.fraser@apple.com>
30776 Remove the unused #define _USE_MATH_DEFINES
30777 https://bugs.webkit.org/show_bug.cgi?id=152034
30779 Reviewed by Tim Horton.
30781 Update this test to use piDouble from MathExtras.h, and
30782 std::numeric_limits<>.
30784 * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
30786 2015-12-24 Youenn Fablet <youenn.fablet@crf.canon.fr>
30788 Python SCM should be able to retrieve untracked files - Generic changes
30789 https://bugs.webkit.org/show_bug.cgi?id=152536
30791 Reviewed by Brent Fulgham.
30793 This patch introduces SCM.untracked_files to retrieve a list of untracked files.
30794 No support is yet added to GIT and SVN specific implementations.
30796 * Scripts/webkitpy/common/checkout/scm/scm.py:
30797 (SCM.untracked_files):
30798 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
30799 (SCMTest._shared_test_untracked_files):
30801 2015-12-23 Dewei Zhu <dewei_zhu@apple.com>
30803 SVN checkout used by RunBenchmark should be non-interactive
30804 https://bugs.webkit.org/show_bug.cgi?id=152542
30806 Reviewed by Ryosuke Niwa.
30808 RunBenchmark should not require user interaction while running.
30810 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
30811 (BenchmarkBuilder._checkout_with_subversion):
30813 2015-12-23 Brent Fulgham <bfulgham@apple.com>
30815 Web Inspector: add support for running protocol-test.js tests on Windows
30816 https://bugs.webkit.org/show_bug.cgi?id=148037
30817 <rdar://problem/22292237>
30819 Reviewed by Simon Fraser.
30821 * DumpRenderTree/win/TestRunnerWin.cpp:
30822 (TestRunner::inspectorTestStubURL): Provide implementation.
30824 2015-12-23 Eric Carlson <eric.carlson@apple.com>
30826 [MediaStream] MediaDeviceInfo.label must be empty in some situations
30827 https://bugs.webkit.org/show_bug.cgi?id=152000
30829 Reviewed by Brent Fulgham.
30831 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
30832 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
30833 (WTR::InjectedBundle::setUserMediaPermission):
30834 (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
30835 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
30837 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
30838 (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
30839 * WebKitTestRunner/InjectedBundle/TestRunner.h:
30841 * WebKitTestRunner/TestController.cpp:
30842 (WTR::TestController::setUserMediaPermissionForOrigin):
30843 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
30844 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add
30845 persistent permission for origin, that can be done from script now.
30846 * WebKitTestRunner/TestController.h:
30848 * WebKitTestRunner/TestInvocation.cpp:
30849 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
30850 SetUserMediaPermissionForOrigin.
30852 2015-12-23 Brent Fulgham <bfulgham@apple.com>
30854 [Win] Unreviewed build fix: Recognize Windows 10 variants.
30856 * Scripts/webkitpy/common/system/platforminfo.py:
30857 (PlatformInfo._determine_win_version):
30859 2015-12-23 Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
30861 Content blockers should be able to promote http to https
30862 https://bugs.webkit.org/show_bug.cgi?id=148966
30864 Reviewed by Benjamin Poulain.
30866 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
30867 (WebCore::ContentExtensions::operator<<):
30868 (TestWebKitAPI::TEST_F):
30870 2015-12-22 Hunseop Jeong <hs85.jeong@samsung.com>
30872 [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
30873 https://bugs.webkit.org/show_bug.cgi?id=152516
30875 Reviewed by Gyuyoung Kim.
30877 * MiniBrowser/efl/main.c:
30879 2015-12-22 Brent Fulgham <bfulgham@apple.com>
30881 Unreviewed: Add John Wilander as a contributor.
30883 * Scripts/webkitpy/common/config/contributors.json:
30885 2015-12-22 Chris Fleizach <cfleizach@apple.com>
30887 [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
30888 https://bugs.webkit.org/show_bug.cgi?id=152482
30890 Reviewed by Brent Fulgham.
30892 vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
30893 for the same property. On WK2, the element returned will not be valid, but is still present and
30894 that can lead to looping.
30896 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
30897 (AccessibilityUIElement::horizontalScrollbar):
30898 (AccessibilityUIElement::verticalScrollbar):
30899 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
30900 (WTR::AccessibilityUIElement::horizontalScrollbar):
30901 (WTR::AccessibilityUIElement::verticalScrollbar):
30903 2015-12-22 Xabier Rodriguez Calvar <calvaris@igalia.com>
30907 * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
30909 2015-12-21 Hunseop Jeong <hs85.jeong@samsung.com>
30911 [EFL] test_ewk2_context failed after r192808
30912 https://bugs.webkit.org/show_bug.cgi?id=151846
30914 Reviewed by Gyuyoung Kim.
30916 Used the added ewk_context_web_process_count_limit_set api
30917 instead of the deprecated ewk_context_process_model_set.
30919 * MiniBrowser/efl/main.c:
30922 2015-12-21 Michael Catanzaro <mcatanzaro@igalia.com>
30924 Unreviewed, move myself to reviewer list.
30926 * Scripts/webkitpy/common/config/contributors.json:
30928 2015-12-21 Aakash Jain <aakash_jain@apple.com>
30930 Unreviewed, add myself to the committers list.
30932 * Scripts/webkitpy/common/config/contributors.json:
30934 2015-12-21 Michael Catanzaro <mcatanzaro@igalia.com>
30936 [GTK] jquery.min.js violates DFSG
30937 https://bugs.webkit.org/show_bug.cgi?id=152428
30939 Reviewed by Joseph Pecoraro.
30941 Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
30942 into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
30944 * gtk/manifest.txt.in:
30946 2015-12-19 Dan Bernstein <mitz@apple.com>
30948 [Mac] WebKit contains dead source code for OS X Mavericks and earlier
30949 https://bugs.webkit.org/show_bug.cgi?id=152462
30951 Reviewed by Alexey Proskuryakov.
30953 - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
30956 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
30957 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
30958 * MiniBrowser/Configurations/DebugRelease.xcconfig:
30959 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
30960 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
30962 - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
30963 never getting compiled:
30965 * DumpRenderTree/mac/TextInputController.m:
30966 * MiniBrowser/mac/BrowserWindowController.m:
30967 * TestWebKitAPI/Tests/mac/AttributedString.mm:
30968 * WebKitTestRunner/mac/EventSenderProxy.mm:
30970 2015-12-18 Michael Catanzaro <mcatanzaro@igalia.com>
30972 Unreviewed, add WebKitGTK+ Bugzilla email to committers list
30974 This is to make it easy to CC it on Bugzilla.
30976 * Scripts/webkitpy/common/config/contributors.json:
30978 2015-12-18 Aakash Jain <aakash_jain@apple.com>
30980 Pasteboard get messed up after running kill-old-processes
30981 https://bugs.webkit.org/show_bug.cgi?id=152426
30983 Reviewed by Alexey Proskuryakov.
30985 * BuildSlaveSupport/kill-old-processes:
30986 (main): Do not kill pasteboard anymore.
30988 2015-12-17 Aakash Jain <aakash_jain@apple.com>
30990 run-webkit-tests shouldn't start multiple iOS simulators while only running one test
30991 https://bugs.webkit.org/show_bug.cgi?id=152157
30992 <rdar://problem/23851817>
30994 Reviewed by Alexey Proskuryakov.
30996 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
30997 (LayoutTestRunner.get_worker_count): Calculate required number of workers.
30998 * Scripts/webkitpy/layout_tests/controllers/manager.py:
30999 (Manager._get_test_inputs): Common method to calculate test_inputs.
31000 (Manager._update_worker_count): Calculate and update required number of workers.
31002 2015-12-16 Aakash Jain <aakash_jain@apple.com>
31004 run-webkit-tests fails to delete Simulator device during cleanup
31005 https://bugs.webkit.org/show_bug.cgi?id=152363
31007 Reviewed by Alexey Proskuryakov.
31009 * Scripts/webkitpy/xcode/simulator.py:
31010 (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
31012 2015-12-16 Tim Horton <timothy_horton@apple.com>
31014 [mac-wk2] fast/events force click tests crashing
31015 https://bugs.webkit.org/show_bug.cgi?id=152339
31017 Reviewed by Beth Dakin.
31019 * WebKitTestRunner/mac/EventSenderProxy.mm:
31020 (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
31021 Set the NSEvent's _type member in addition to overriding -type,
31022 because there are assertions in touch event handling code that depend on it.
31024 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
31026 Enforce temporarily bots to sync WebKit and WPT testharness.js
31027 https://bugs.webkit.org/show_bug.cgi?id=152334
31029 Reviewed by Darin Adler.
31031 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
31032 (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
31034 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
31036 [Fetch API] Add fetch API compile time flag
31037 https://bugs.webkit.org/show_bug.cgi?id=152254
31039 Reviewed by Darin Adler.
31041 * Scripts/webkitperl/FeatureList.pm:
31043 2015-12-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
31047 Added files that have impact in building Streams API to the watchlist.
31049 * Scripts/webkitpy/common/config/watchlist:
31051 2015-12-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
31055 Added imported tests to Streams API watchlist.
31057 * Scripts/webkitpy/common/config/watchlist:
31059 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
31061 Remove default copy of wpt testharness.js when launching wpt server
31062 https://bugs.webkit.org/show_bug.cgi?id=152298
31064 Reviewed by Darin Adler.
31066 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
31067 (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
31069 2015-12-15 David Kilzer <ddkilzer@apple.com>
31071 REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
31072 <http://webkit.org/b/152314>
31074 Reviewed by Daniel Bates.
31076 The change to DumpRenderTreeMain.mm in r192375 caused the iOS
31077 code path to exit immediately when calling main().
31078 Unfortunately, DumpRenderTreeMain.mm was used for both
31079 DumpRenderTree command-line binary and DumpRenderTree.app, which
31080 meant that the app would exit immediately with no error code
31083 The workaround is to introduce a separate source file called
31084 DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
31087 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
31088 DumpRenderTreeAppMain.mm to the project. Make it the only
31089 compiled source for the DumpRenderTree.app target.
31090 * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
31091 (main): Call DumpRenderTreeMain() on iOS. Assert on OS X in
31092 case someone tries mistakenly to use the app.
31093 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
31094 Link to JavaScriptCore.framework on iOS for the assert.
31095 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
31096 Link to JavaScriptCore.framework on OS X for the assert. Remove
31097 unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
31098 * DumpRenderTree/mac/DumpRenderTreeMain.mm:
31099 (main): Add assert for iOS so that a crash occurs if someone
31100 tries to run the wrong command.
31102 2015-12-14 Tim Horton <timothy_horton@apple.com>
31104 Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
31105 https://bugs.webkit.org/show_bug.cgi?id=152266
31106 <rdar://problem/22092676>
31108 Reviewed by Simon Fraser.
31110 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
31111 * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
31112 Add a test that crashed before this change, and doesn't crash after.
31114 2015-12-14 Chris Fleizach <cfleizach@apple.com>
31116 AX: iOS: Text field variations do not have the correct traits
31117 https://bugs.webkit.org/show_bug.cgi?id=152237
31119 Reviewed by Mario Sanchez Prada.
31121 Add iOS calls for determing if an object is a search field or a text area.
31123 * DumpRenderTree/AccessibilityUIElement.cpp:
31124 (getIsSearchFieldCallback):
31125 (getIsTextAreaCallback):
31126 (stringForSelectionCallback):
31127 (AccessibilityUIElement::getJSClass):
31128 * DumpRenderTree/AccessibilityUIElement.h:
31129 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
31130 (AccessibilityUIElement::identifier):
31131 (AccessibilityUIElement::isTextArea):
31132 (AccessibilityUIElement::isSearchField):
31133 (AccessibilityUIElement::traits):
31134 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
31135 (WTR::AccessibilityUIElement::scrollPageRight):
31136 (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
31137 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
31138 (WTR::AccessibilityUIElement::isSearchField):
31139 (WTR::AccessibilityUIElement::isTextArea):
31140 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
31141 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
31142 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
31143 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
31144 (WTR::AccessibilityUIElement::isTextArea):
31145 (WTR::AccessibilityUIElement::isSearchField):
31146 (WTR::AccessibilityUIElement::rowCount):
31148 2015-12-14 Carlos Alberto Lopez Perez <clopez@igalia.com>
31150 [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
31151 https://bugs.webkit.org/show_bug.cgi?id=152252
31153 Reviewed by Sergio Villar Senin.
31155 * gtk/install-dependencies: Add libtool-bin to the list of packages required
31156 for building the JHBuild on Debian systems.
31158 2015-12-11 Joseph Pecoraro <pecoraro@apple.com>
31160 check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
31161 https://bugs.webkit.org/show_bug.cgi?id=152156
31163 Reviewed by Dan Bernstein.
31165 Our frameworks should appropriately prefix all ObjC classes,
31166 not just external symbols.
31168 * Scripts/check-for-inappropriate-objc-class-names:
31169 Remove the -g switch to check all ObjC class names.
31171 2015-12-10 Eric Carlson <eric.carlson@apple.com>
31173 [MediaStream] Expose media capture devices persistent permissions to WebCore
31174 https://bugs.webkit.org/show_bug.cgi?id=152087
31176 Add support for the new user media permission checker page UI client method.
31178 Reviewed by Chris Dumez.
31180 * WebKitTestRunner/TestController.cpp:
31181 (WTR::decidePolicyForUserMediaPermissionRequest):
31182 (WTR::checkUserMediaPermissionForOrigin):
31183 (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
31184 (WTR::TestController::createWebViewWithOptions): Ditto.
31185 (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
31186 (WTR::originUserVisibleName): New, create a string for the origin.
31187 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
31188 according to the state of the origin permission map.
31189 (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
31190 request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
31191 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
31192 origin permission map.
31193 * WebKitTestRunner/TestController.h:
31195 2015-12-10 Alex Christensen <achristensen@webkit.org>
31197 REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
31198 https://bugs.webkit.org/show_bug.cgi?id=152022
31199 rdar://problem/23763584
31201 Reviewed by Darin Adler.
31203 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
31204 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
31205 (WTR::InjectedBundlePage::willSendRequestForFrame):
31206 * WebKitTestRunner/InjectedBundle/TestRunner.h:
31207 (WTR::TestRunner::setWillSendRequestReturnsNull):
31208 (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
31209 (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
31210 (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
31211 (WTR::TestRunner::willSendRequestHTTPBody):
31212 Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
31214 2015-12-10 Aakash Jain <aakash_jain@apple.com>
31216 Remove additional simulator checks before running layout-tests
31217 https://bugs.webkit.org/show_bug.cgi?id=152146
31219 Reviewed by Darin Adler.
31221 * Scripts/webkitpy/port/ios.py:
31222 (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
31223 * Scripts/webkitpy/xcode/simulator.py:
31224 (Simulator._boot_and_shutdown_simulator_device): Deleted.
31225 (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
31227 2015-12-09 Aakash Jain <aakash_jain@apple.com>
31229 Run atleast one simulator even if max process limit is low
31230 https://bugs.webkit.org/show_bug.cgi?id=152081
31231 <rdar://problem/23819694>
31233 Reviewed by Alexey Proskuryakov.
31235 2015-12-09 Mario Sanchez Prada <mario@endlessm.com>
31237 [GTK] Crash in WebProcess when loading large content with custom URI schemes
31238 https://bugs.webkit.org/show_bug.cgi?id=144262
31240 Reviewed by Carlos Garcia Campos.
31242 Added new unit test to check the additional scenarios we now
31243 handle for custom URI schemes.
31245 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
31246 (generateHTMLContent): New helper function to generate big enough content.
31247 (testWebContextURIScheme): New unit test.
31249 2015-12-09 Ryuan Choi <ryuan.choi@navercorp.com>
31251 [EFL] Fix unhandled web process message when launching MiniBrowser
31252 https://bugs.webkit.org/show_bug.cgi?id=152048
31254 Reviewed by Gyuyoung Kim.
31256 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
31257 (TestWebKitAPI::TEST):
31259 2015-12-09 Carlos Garcia Campos <cgarcia@igalia.com>
31261 [GTK] Add API to handle beforeunload events
31262 https://bugs.webkit.org/show_bug.cgi?id=139090
31264 Reviewed by Gustavo Noronha Silva.
31266 * MiniBrowser/gtk/BrowserWindow.c:
31267 (browserWindowConstructed):
31268 (browserWindowDeleteEvent):
31269 (browser_window_class_init):
31270 Handle delete-event to prevent the window from being closed when
31271 the page has beforeunload handlers. Use
31272 webkit_web_view_try_close() when the window is requested to be
31274 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
31275 (testWebViewJavaScriptDialogs):
31276 Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
31277 script dialog type.
31279 2015-12-09 Mario Sanchez Prada <mario@endlessm.com>
31281 Refactored initialization code in LoadTrackingTest.
31283 Rubber-stamped by Carlos Garcia Campos.
31285 Small refactoring to make sure that the state of a LoadTrackingTest
31286 gets properly reset before loading new web content.
31288 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
31289 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
31290 (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
31291 functions and reset the remaining local variables.
31292 (LoadTrackingTest::loadURI): Call reset();
31293 (LoadTrackingTest::loadHtml): Ditto.
31294 (LoadTrackingTest::loadPlainText): Ditto.
31295 (LoadTrackingTest::loadBytes): Ditto.
31296 (LoadTrackingTest::loadRequest): Ditto.
31297 (LoadTrackingTest::reload): Ditto.
31298 (LoadTrackingTest::goBack): Ditto.
31299 (LoadTrackingTest::goForward): Ditto.
31301 2015-12-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
31303 [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
31304 https://bugs.webkit.org/show_bug.cgi?id=151942
31306 Reviewed by Darin Adler.
31308 * MiniBrowser/efl/main.c:
31309 (window_create): Enable offline web application cache feature on MiniBrowser.
31312 2015-12-08 Aakash Jain <aakash_jain@apple.com>
31314 https://bugs.webkit.org/show_bug.cgi?id=151243
31315 <rdar://problem/22955197>
31317 Reviewed by Alexey Proskuryakov.
31319 * LayoutTestRelay/LayoutTestRelay/main.m:
31320 (getTestingSimDevice): Use separate testing device for each worker.
31321 * Scripts/webkitpy/layout_tests/controllers/manager.py:
31322 (Manager.run): Perform cleanup even if setup fails.
31323 * Scripts/webkitpy/port/ios.py:
31324 (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
31325 (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
31326 (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
31327 (IOSSimulatorPort._quit_ios_simulator): Same
31328 (IOSSimulatorPort.clean_up_test_run): Same
31329 (IOSSimulatorPort.check_sys_deps): Same
31330 (IOSSimulatorPort.testing_device): Same
31331 (IOSSimulatorPort.reset_preferences): Same
31332 (IOSSimulatorPort.get_simulator_path): Return simulator path.
31333 (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
31334 * Scripts/webkitpy/xcode/simulator.py:
31335 (Device.delete): Delete the simulator device.
31336 (Simulator.delete_device): Same
31337 (Simulator.wait_until_device_is_booted): Wait for device booting.
31339 2015-12-08 Ryuan Choi <ryuan.choi@navercorp.com>
31341 [EFL] Add API to provide preferences before creating ewk_view
31342 https://bugs.webkit.org/show_bug.cgi?id=151587
31344 Reviewed by Gyuyoung Kim.
31346 * MiniBrowser/efl/main.c:
31350 Moved settings related code to configuration() not to update settings
31351 whenever ewk_view is created.
31355 2015-12-08 Carlos Garcia Campos <cgarcia@igalia.com>
31357 Unreviewed. Fix GTK+ API tests after r193639.
31359 The new jhbuild version needs some more variables ot be present in
31360 the builtin dict, even if they are set to None.
31362 * jhbuild/jhbuildutils.py:
31363 (enter_jhbuild_environment_if_available):
31365 2015-12-07 Gustavo Noronha Silva <gns@gnome.org>
31367 [GTK] Notify WebCore when notification is clicked
31368 https://bugs.webkit.org/show_bug.cgi?id=151951
31370 Reviewed by Carlos Garcia Campos.
31372 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
31373 (testWebViewNotification): test the new API.
31375 2015-12-07 Michael Catanzaro <mcatanzaro@igalia.com>
31377 'jhbuild build' should fail immediately when building any module fails
31378 https://bugs.webkit.org/show_bug.cgi?id=145697
31380 Reviewed by Carlos Garcia Campos.
31382 * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
31383 * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
31384 Everything is placed under lib instead of lib64 now.
31385 * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
31386 --exit-on-error when running 'jhbuild build'.
31387 * jhbuild/jhbuildrc_common.py:
31388 (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
31389 jhbuild should be able to handle these for us without breaking things....
31391 2015-12-07 Xabier Rodriguez Calvar <calvaris@igalia.com>
31393 Add support to import w3c tests from a repository with a different root that the main repo dir
31394 https://bugs.webkit.org/show_bug.cgi?id=151751
31396 Reviewed by Ryosuke Niwa and Youenn Fablet.
31398 We should be able to import tests from repositories that are not pure test repositories and where tests are kept
31399 in a different directory than the repository root.
31401 This patch introduces a new parameter tests_directory that we will use as root directory to search for
31402 tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
31403 requires having the copy_path lists including tuples of origin and destination directories.
31405 * Scripts/webkitpy/w3c/test_downloader.py:
31406 (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
31407 (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
31408 * Scripts/webkitpy/w3c/test_importer_unittest.py:
31409 (TestImporterTest.test_tests_directory): Test.
31411 2015-12-07 Xabier Rodriguez Calvar <calvaris@igalia.com>
31413 Mock TestRepositories in W3C importer tests
31414 https://bugs.webkit.org/show_bug.cgi?id=151938
31416 Reviewed by Youenn Fablet.
31418 The test importer tests should use a fake repository instead of using the real one. The reason why this happened
31419 is because the test repository method reading the file was using the filesystem directly instead of taking the
31420 host one. This patch changes that.
31422 * Scripts/webkitpy/w3c/test_downloader.py:
31423 (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
31425 (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
31426 * Scripts/webkitpy/w3c/test_importer_unittest.py:
31427 (TestImporterTest.test_harnesslinks_conversion):
31428 (TestImporterTest.test_submodules_generation): Use a fake test repository file.
31430 2015-12-07 David Kilzer <ddkilzer@apple.com>
31432 TestNetscapePlugIn: Address review comment on 193607
31433 <http://webkit.org/b/151881>
31435 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
31436 (testSetStatus): Initializing std::unique_ptr<char[]> with
31437 nullptr is redundant.
31439 2015-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
31441 [GTK] Add webkit_uri_request_get_http_method
31442 https://bugs.webkit.org/show_bug.cgi?id=151601
31444 Reviewed by Martin Robinson.
31446 Add test case to check HTTP method of WebKitURIRequest.
31448 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
31449 (testURIRequestHTTPMethod):
31452 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
31453 (sendRequestCallback):
31455 2015-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
31457 [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
31458 https://bugs.webkit.org/show_bug.cgi?id=79918
31460 Reviewed by Gustavo Noronha Silva.
31462 Add unit tests to check the different console messages.
31464 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
31465 * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
31466 (ConsoleMessageTest::ConsoleMessage::operator==):
31467 (ConsoleMessageTest::consoleMessageReceivedCallback):
31468 (ConsoleMessageTest::ConsoleMessageTest):
31469 (ConsoleMessageTest::~ConsoleMessageTest):
31470 (ConsoleMessageTest::waitUntilConsoleMessageReceived):
31471 (testWebKitConsoleMessageConsoleAPI):
31472 (testWebKitConsoleMessageJavaScriptException):
31473 (testWebKitConsoleMessageNetworkError):
31474 (testWebKitConsoleMessageSecurityError):
31477 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
31478 (consoleMessageSentCallback):
31479 (pageCreatedCallback):
31481 2015-12-07 Ryuan Choi <ryuan.choi@navercorp.com>
31483 [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
31484 https://bugs.webkit.org/show_bug.cgi?id=151934
31486 Reviewed by Csaba Osztrogonác.
31488 * MiniBrowser/efl/main.c:
31489 (on_window_deletion): Revert the changes of r192767.
31491 2015-12-07 Michael Catanzaro <mcatanzaro@igalia.com>
31493 [GTK] update-webkitgtk-libs cannot build mesa
31494 https://bugs.webkit.org/show_bug.cgi?id=151535
31496 Reviewed by Martin Robinson.
31498 Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
31499 dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
31500 on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
31501 does not have a stable API and we cannot expect mesa to be buildable unless we control the
31502 LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
31503 --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
31505 * gtk/jhbuild.modules:
31507 2015-12-07 Philippe Normand <pnormand@igalia.com>
31509 [GTK][Mac] libWebExtensionTest link error
31510 https://bugs.webkit.org/show_bug.cgi?id=150802
31512 Reviewed by Carlos Garcia Campos.
31514 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
31516 2015-12-06 David Kilzer <ddkilzer@apple.com>
31518 TestNetscapePlugIn: Fix leaks found by static analyzer
31519 <http://webkit.org/b/151881>
31521 Reviewed by Darin Adler.
31523 Fixes the following leaks found by the static analyzer:
31524 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
31527 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
31530 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
31534 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
31535 (toCString): Switch to returning std::unique_ptr<char[]>. Add
31536 early return if allocation fails.
31537 (testPostURLFile): Switch to using std::unique_ptr<char[]>.
31538 Make sure to call fclose() on filehandle, even for an early
31540 (testSetStatus): Switch to using std::unique_ptr<char[]>.
31542 2015-12-05 David Kilzer <ddkilzer@apple.com>
31544 prepare-ChangeLog: Fix some warning messages when using svn
31545 <http://webkit.org/b/151914>
31547 Reviewed by Daniel Bates.
31549 * Scripts/prepare-ChangeLog:
31550 (generateFunctionLists): Simplify logic so that we never call
31551 normalizePath() with an undefined value.
31552 (attributeCommand): Quote $subPath for the shell so that we
31553 don't try to run "svn propget" on invalid paths.
31555 2015-12-04 David Kilzer <ddkilzer@apple.com>
31557 TestNetscapePlugIn: Fix remaining static analyzer warnings
31558 <http://webkit.org/b/151888>
31560 Reviewed by Alexey Proskuryakov.
31562 Fixes the following static analyzer warnings:
31563 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
31566 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
31567 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
31569 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
31570 return obj->pluginTest->NPP_SetWindow(window);
31572 2 warnings generated.
31574 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
31575 (CRASH): Use __builtin_trap() for gcc/clang.
31576 (NPP_SetWindow): Add early return if obj is nullptr.
31578 2015-12-03 Carlos Garcia Campos <cgarcia@igalia.com>
31580 [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
31581 https://bugs.webkit.org/show_bug.cgi?id=151797
31583 Reviewed by Martin Robinson.
31585 Since we switched to use the network process to run the unit tests
31586 the test /webkit2/WebKitWebResource/get-data sometimes fails and
31587 sometimes passes. We are now also getting the notification for the
31588 css image. Since we wait for 3 resources, sometimes the css image
31589 is loaded before and then checkResourceData is called for it, but
31590 not handled. When the css image is the last one loaded the test
31591 passes. So, we just need to wait for the 4 resources.
31593 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
31594 (testWebResourceGetData):
31596 2015-12-03 David Kilzer <ddkilzer@apple.com>
31598 DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
31599 <http://webkit.org/b/151845>
31601 Reviewed by Simon Fraser.
31603 Fixes the following static analyzer warning:
31604 DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
31605 WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
31606 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
31608 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
31609 (createBitmapContext): Free 'buffer' after using it in logging
31610 to fix the use-after-free. Assign a value of nullptr to buffer
31611 so we don't return with it set to a freed address.
31613 2015-12-03 Jer Noble <jer.noble@apple.com>
31615 Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
31616 https://bugs.webkit.org/show_bug.cgi?id=151830
31618 Reviewed by Anders Carlsson.
31620 Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
31622 * DumpRenderTree/mac/DumpRenderTree.mm:
31623 (resetWebPreferencesToConsistentValues):
31624 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
31625 (WTR::initializeWebViewConfiguration):
31627 2015-12-03 Anders Carlsson <andersca@apple.com>
31629 Remove Objective-C GC support
31630 https://bugs.webkit.org/show_bug.cgi?id=151819
31631 rdar://problem/23746991
31633 Reviewed by Dan Bernstein.
31635 * asan/asan.xcconfig:
31637 2015-12-02 Yusuke Suzuki <utatane.tea@gmail.com>
31639 Allow nil for unspecified benchmark pathes
31640 https://bugs.webkit.org/show_bug.cgi?id=151784
31642 Reviewed by Filip Pizlo.
31644 `Pathname.new(nil)` will raise an error.
31645 Only generate Pathname if the benchmark path is specified.
31647 * Scripts/run-jsc-benchmarks:
31649 2015-12-02 Brent Fulgham <bfulgham@apple.com>
31651 [Win] Run non-http tests without Cygwin
31652 https://bugs.webkit.org/show_bug.cgi?id=151721
31654 Reviewed by Andy Estes.
31656 Support native 32-bit and 64-bit Python (and Perl) builds
31659 1. Use "startswith('win')", rather than "== 'win32'" to support
31660 various Windows build types.
31661 2. Supply full path for some native Windows utilities, since the
31662 path environment does not always have the specified, and they are
31663 guaranteed to exist in those specific locations.
31664 3. Make sure native Windows Python test runs pass proper environment
31665 variables to run programs.
31666 4. Append 'exe' suffix when running Windows executables.
31667 5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
31668 command doesn't exist.
31670 * Scripts/update-webkit: Use Perl $^X command to refer to the path of
31671 the current Perl executable, rather than requiring a new path search.
31672 * Scripts/webkitpy/common/find_files_unittest.py:
31673 (TestWinNormalize.test_win): Use startswith('win').
31674 * Scripts/webkitpy/common/prettypatch_unittest.py:
31675 (test_pretty_diff_encodings): Ditto.
31676 * Scripts/webkitpy/common/system/executive.py:
31677 (Executive._should_close_fds): Ditto.
31678 (Executive.shell_command_for_script): Use startswith('win').
31679 (Executive.kill_process): Use full path to killall executable.
31680 (Executive.check_running_pid): Use startswith('win').
31681 (Executive.running_pids): Ditto.
31682 (Executive.kill_all): Ditto. Also use path to 'killall' executable when
31683 running under native Windows Python.
31684 (Executive._child_process_encoding): Use startswith('win').
31685 (Executive._should_encode_child_process_arguments): Ditto.
31686 (Executive.popen): Recognize proper script engine on Windows, since it
31687 does not support the shebang syntax.
31688 (Executive.run_in_parallel): Use startswith('win').
31689 * Scripts/webkitpy/common/system/executive_unittest.py:
31690 (never_ending_command): Ditto.
31691 (ExecutiveTest.test_run_command_with_unicode): Ditto.
31692 (ExecutiveTest.serial_test_kill_process): Ditto.
31693 (ExecutiveTest.serial_test_kill_all): Ditto.
31694 (ExecutiveTest.serial_test_check_running_pid): Ditto.
31695 (ExecutiveTest.serial_test_run_in_parallel): Ditto.
31697 * Scripts/webkitpy/common/system/file_lock.py:
31698 (FileLock._create_lock): Ditto.
31699 (FileLock._remove_lock): Ditto.
31700 * Scripts/webkitpy/common/system/filesystem_unittest.py:
31701 (RealFileSystemTest.test_chdir): Ditto.
31702 (RealFileSystemTest.test_chdir__notexists): Ditto.
31703 (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
31704 * Scripts/webkitpy/common/system/path_unittest.py:
31705 (AbspathTest.test_abspath_to_uri_win): Ditto.
31706 * Scripts/webkitpy/common/system/platforminfo.py:
31707 (PlatformInfo._determine_os_name): Ditto.
31708 * Scripts/webkitpy/common/system/user.py: Ditto.
31709 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
31710 (ManagerTest.integration_test_needs_servers): Ditto.
31711 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
31712 (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
31714 (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
31715 * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
31716 (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
31717 * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
31718 (HttpServerBase._check_that_all_ports_are_available): Ditto.
31719 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
31720 (TestHttpServer.test_start_cmd): Ditto.
31721 * Scripts/webkitpy/port/base.py:
31722 (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
31723 and 'SYSTEMROOT' in environment passed to test runners.
31724 (Port._apache_config_file_name_for_platform): Use startswith('win').
31725 (Port._build_path): Ditto.
31726 (Port._path_to_driver): Include 'exe' suffix when running under native
31728 * Scripts/webkitpy/port/driver.py:
31729 (Driver._setup_environ_for_driver): Explicitly make some environment
31731 * Scripts/webkitpy/port/server_process.py:
31732 (ServerProcess.__init__): Use startswith('win').
31733 * Scripts/webkitpy/port/win.py:
31734 (WinPort): Use the win32 registry utilities on Windows, and appropriate
31735 registry key formats.
31736 (WinPort._ntsd_location): Revise tool search paths for Windows 10.
31737 (WinPort.read_registry_value): Revise to use _winreg library on Windows,
31738 and regtool on Cygwin.
31739 (WinPort.write_registry_value): Ditto.
31740 (WinPort.setup_crash_log_saving): Ditto.
31741 (WinPort.restore_crash_log_saving): Ditto.
31742 (WinPort.prevent_error_dialogs): Ditto.
31743 (WinPort.allow_error_dialogs): Ditto.
31744 (WinPort.find_system_pid): Revise to use Windows management
31745 infrastructure on native Windows, continue using 'ps' on Cygwin.
31746 (WinPort.read_registry_string): Deleted.
31747 (WinPort.write_registry_string): Deleted.
31748 * Scripts/webkitpy/test/main.py:
31749 (main): Use startswith('win').
31750 (Tester._parse_args): Ditto.
31752 2015-12-01 Yusuke Suzuki <utatane.tea@gmail.com>
31754 [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
31755 https://bugs.webkit.org/show_bug.cgi?id=150792
31757 Reviewed by Saam Barati.
31759 * Scripts/webkitperl/FeatureList.pm:
31761 2015-12-01 Commit Queue <commit-queue@webkit.org>
31763 Unreviewed, rolling out r192914.
31764 https://bugs.webkit.org/show_bug.cgi?id=151734
31766 JSC tests for this change are failing on 32 and 64-bit bots
31767 (Requested by ryanhaddad on #webkit).
31769 Reverted changeset:
31771 "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
31772 enable this feature"
31773 https://bugs.webkit.org/show_bug.cgi?id=150792
31774 http://trac.webkit.org/changeset/192914
31776 2015-12-01 David Kilzer <ddkilzer@apple.com>
31778 EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
31779 <http://webkit.org/b/151726>
31781 Reviewed by Simon Fraser.
31783 * WebKitTestRunner/mac/EventSenderProxy.mm:
31784 (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
31785 Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
31787 2015-12-01 Myles C. Maxfield <mmaxfield@apple.com>
31789 Give String and AtomicString an existingHash() function
31790 https://bugs.webkit.org/show_bug.cgi?id=151717
31792 Reviewed by Andreas Kling.
31794 * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
31795 (TestWebKitAPI::TEST):
31796 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
31797 (TestWebKitAPI::TEST):
31799 2015-12-01 Yusuke Suzuki <utatane.tea@gmail.com>
31801 [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
31802 https://bugs.webkit.org/show_bug.cgi?id=150792
31804 Reviewed by Saam Barati.
31806 * Scripts/webkitperl/FeatureList.pm:
31808 2015-12-01 Sam Weinig <sam@webkit.org>
31810 Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
31811 <rdar://problem/23320863>
31812 https://bugs.webkit.org/show_bug.cgi?id=151708
31814 Reviewed by Anders Carlsson.
31816 * WebKitTestRunner/TestController.cpp:
31817 (WTR::TestController::createOtherPage):
31818 (WTR::TestController::createWebViewWithOptions):
31819 Update for new WKPageUIClient.
31821 2015-12-01 Anders Carlsson <andersca@apple.com>
31823 Remove WebKit2.framework
31824 https://bugs.webkit.org/show_bug.cgi?id=151715
31826 Reviewed by Dan Bernstein.
31828 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
31829 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
31830 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
31831 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
31832 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
31833 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
31834 * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
31836 2015-12-01 Joseph Pecoraro <pecoraro@apple.com>
31838 Unreviewed common typo fix "occurance" => "occurrence".
31840 * Scripts/webkitpy/tool/commands/queries.py:
31841 (FindFlakyTests._print_statistics):
31843 2015-11-30 Alex Christensen <achristensen@webkit.org>
31845 Make ProcessModel always MultipleSecondaryProcesses
31846 https://bugs.webkit.org/show_bug.cgi?id=151662
31848 Reviewed by Antti Koivisto.
31850 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
31851 (TestWebKitAPI::TEST):
31852 * WebKitTestRunner/TestController.cpp:
31853 (WTR::TestController::generatePageConfiguration):
31855 2015-11-30 Alex Christensen <achristensen@webkit.org>
31857 Make usesNetworkProcess always true
31858 https://bugs.webkit.org/show_bug.cgi?id=151580
31860 Reviewed by Darin Adler.
31862 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
31863 (TestWebKitAPI::TEST):
31864 * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
31865 (TestWebKitAPI::TEST):
31866 * WebKitTestRunner/TestController.cpp:
31867 (WTR::TestController::generatePageConfiguration):
31869 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
31871 Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
31873 Add a way to skip unit tests only for Debug or Release builds and
31874 skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
31876 * Scripts/run-gtk-tests:
31878 (SkippedTest.__init__):
31879 (SkippedTest.__str__):
31880 (SkippedTest.skip_entire_suite):
31881 (SkippedTest.skip_for_build_type):
31883 (TestRunner.__init__):
31885 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
31887 Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
31889 It's an assert hit because we are reloading a view loaded with
31890 HTML data which is not supported. Use loadURI instead.
31892 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
31893 (testWebViewCustomCharset):
31895 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
31897 [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
31898 https://bugs.webkit.org/show_bug.cgi?id=151633
31900 Reviewed by Csaba Osztrogonác.
31902 * TestWebKitAPI/PlatformGTK.cmake:
31903 * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
31905 2015-11-27 Carlos Garcia Campos <cgarcia@igalia.com>
31907 [GTK] Remove the remaining uses of GMainLoopSource
31908 https://bugs.webkit.org/show_bug.cgi?id=151632
31910 Reviewed by Žan Doberšek.
31912 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
31913 (testWebViewSyncRequestOnMaxConns):
31914 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
31915 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
31916 (WTR::TestRunner::TestRunner):
31917 * WebKitTestRunner/InjectedBundle/TestRunner.h:
31918 * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
31919 (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
31920 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
31921 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
31922 (WTR::timeoutSource):
31923 (WTR::TestController::notifyDone):
31924 (WTR::TestController::platformRunUntil):
31926 2015-11-27 Csaba Osztrogonác <ossy@webkit.org>
31928 [cmake] Add testb3 to the build system
31929 https://bugs.webkit.org/show_bug.cgi?id=151619
31931 Reviewed by Gyuyoung Kim.
31933 * Scripts/build-jsc:
31935 2015-11-27 Csaba Osztrogonác <ossy@webkit.org>
31937 [jhbuild] Fix pixman build with clang
31938 https://bugs.webkit.org/show_bug.cgi?id=151441
31940 Reviewed by Carlos Garcia Campos.
31942 * efl/jhbuild.modules:
31943 * gtk/jhbuild.modules:
31945 2015-11-26 David Kilzer <ddkilzer@apple.com>
31947 Extract prependToEnvironmentVariableList
31948 <http://webkit.org/b/151536>
31950 Reviewed by Daniel Bates.
31952 Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
31953 webkitdirs_unittest/prependToEnvironmentVariableList.pl
31955 * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
31956 and prependToEnvironmentVariableList.
31957 (appendToEnvironmentVariableList): Simplify variable name.
31958 Switch to use $Config{path_sep}.
31959 (prependToEnvironmentVariableList): Add new method.
31960 (setupMacWebKitEnvironment): Switch to use
31961 prependToEnvironmentVariableList().
31962 (setupIOSWebKitEnvironment): Ditto.
31964 * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
31965 * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
31967 2015-11-24 Gyuyoung Kim <gyuyoung.kim@webkit.org>
31969 REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
31970 https://bugs.webkit.org/show_bug.cgi?id=151567
31972 Reviewed by Darin Adler.
31974 * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
31975 (on_window_deletion):
31977 2015-11-23 Carlos Garcia Campos <cgarcia@igalia.com>
31979 [GTK] Use the network process unconditionally
31980 https://bugs.webkit.org/show_bug.cgi?id=151541
31982 Reviewed by Alex Christensen.
31984 Fix TestInspectorServer test. Do not assume we already have the
31985 title we want when the page has been loaded, since the title is
31986 changed afterwards. So, check if the title has already been set,
31987 and if not wait for it.
31989 * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
31990 (openRemoteDebuggingSession):
31992 2015-11-23 Alex Christensen <achristensen@webkit.org>
31994 Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
31995 https://bugs.webkit.org/show_bug.cgi?id=151532
31997 Reviewed by Benjamin Poulain.
31999 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
32000 (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
32001 (TestWebKitAPI::TEST):
32002 (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
32003 (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
32004 (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
32005 Properly load about:blank in all WebViews to clean up. Without this change, we had a
32006 Geolocation provider stopping after its state tracker was destroyed with its stack frame,
32007 so it was calling a function on a test object that had gone out of scope.
32008 Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
32009 but that will become the default soon and that call will be removed.
32011 2015-11-22 David Kilzer <ddkilzer@apple.com>
32013 run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
32014 <http://webkit.org/b/151542>
32016 Reviewed by Daniel Bates.
32018 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
32019 (base_url): Use the Port object (already passed in) to give us
32020 the path to the LayoutTests directory, which already checks for a
32021 --layout-tests-directory command-line switch.
32022 (WebPlatformTestServer.__init__): Remove layout_test_results_dir
32023 argument since we can get this from the Port object already
32024 passed in via Port.results_directory(). Also switch to use
32025 Port.layout_tests_dir() to get the LayoutTests directory.
32027 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
32028 (TestWebPlatformTestServer.test_custom_layout_tests_directory):
32029 Add test case for custom LayoutTests directory.
32030 (TestWebPlatformTestServer.test_previously_spawned_instance):
32031 Update Port object to set mock results directory as if it was
32032 set on the command-line. Remove unneeded argument from
32033 WebPlatformTestServer constructor.
32034 (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
32036 * Scripts/webkitpy/port/base.py:
32037 (Port.to.start_web_platform_test_server): Remove unneeded
32038 argument from WebPlatformTestServer constuctor.
32040 2015-11-22 Carlos Garcia Campos <cgarcia@igalia.com>
32042 [GTK] Some unit tests fail when using the network process
32043 https://bugs.webkit.org/show_bug.cgi?id=151490
32045 Reviewed by Martin Robinson.
32047 Run the soup server in a separate thread in TestResources test to
32050 This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
32051 /webkit2/WebKitWebResource/get-data when using the network process.
32053 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
32054 (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
32055 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
32056 (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
32057 present, create a WorkQueue to run the server.
32058 (WebKitTestServer::run): Run the server in the work queue if it
32060 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
32061 type into server options as flags.
32063 2015-11-22 Carlos Garcia Campos <cgarcia@igalia.com>
32065 [GTK] ImageDiff should normalize the diff image
32066 https://bugs.webkit.org/show_bug.cgi?id=151261
32068 Reviewed by Sergio Villar Senin.
32070 * ImageDiff/gtk/ImageDiff.cpp:
32071 (readPixbufFromStdin): Fix memory leak.
32072 (differenceImageFromDifferenceBuffer): Normalize diff buffer.
32073 (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
32075 == Rolled over to ChangeLog-2015-11-21 ==