Move tyler_w@apple.com to first entry in "emails" key
[webkit.git] / Tools / ChangeLog-2014-02-20
blob7871ad4cbaf177b1dea2dfb1141e506cd94ef69f
1 2014-02-20  Dean Jackson  <dino@apple.com>
3         Add an unresolved WebGLPolicy and an API to resolve it
4         https://bugs.webkit.org/show_bug.cgi?id=129109
6         Reviewed by Anders Carlsson.
8         Add a new entry for resolveWebGLLoadPolicy.
10         * WebKitTestRunner/TestController.cpp:
11         (WTR::TestController::createWebViewWithOptions):
13 2014-02-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
15         [GTK] Add new ARM build slave for GTK+
16         https://bugs.webkit.org/show_bug.cgi?id=128978
18         Reviewed by Brent Fulgham.
20         * BuildSlaveSupport/build.webkit.org-config/config.json:
22 2014-02-19  Zan Dobersek  <zdobersek@igalia.com>
24         Remove the remaining Nix cruft under Tools
25         https://bugs.webkit.org/show_bug.cgi?id=129003
27         Reviewed by Csaba Osztrogonác.
29         The Nix port was removed from the source tree so the remaining Nix-specific code
30         in the utility scripts is not required anymore.
32         * Scripts/run-nix-tests: Removed.
33         * Scripts/update-webkitnix-libs: Removed.
34         * Scripts/webkitpy/style/checker.py:
35         * jhbuild/jhbuild-wrapper:
36         (determine_platform):
37         * nix/common.py: Removed.
38         * nix/jhbuild.modules: Removed.
39         * nix/jhbuildrc: Removed.
41 2014-02-18  Jinwoo Song  <jinwoo7.song@samsung.com>
43         [EFL][MiniBrowser] Remove view_mode parameter in window_create()
44         https://bugs.webkit.org/show_bug.cgi?id=128960
46         Reviewed by Gyuyoung Kim.
48         As view source code is removed in r164254, window_create() also should remove view_mode.
50         * MiniBrowser/efl/main.c:
51         (on_key_down):
52         (on_window_create):
53         (window_create):
54         (elm_main):
56 2014-02-18  Diego Pino García  <dpino@igalia.com>
58         [GTK] Minibrowser: Add shortcut to open Web Inspector
59         https://bugs.webkit.org/show_bug.cgi?id=128813
61         Reviewed by Anders Carlsson.
63         Added shortcuts Ctrl+Shift+I and F12 for toggling Web Inspector.
65         * MiniBrowser/gtk/BrowserWindow.c:
66         (toggleWebInspector):
67         (browser_window_init):
69 2014-02-18  Dan Bernstein  <mitz@apple.com>
71         Stop using PLATFORM(MAC) except where it means “OS X but not iOS”
72         https://bugs.webkit.org/show_bug.cgi?id=128952
74         Reviewed by Anders Carlsson.
76         * TestWebKitAPI/JavaScriptTest.h: Changed PLATFORM(MAC) to PLATFORM(COCOA) and changed to
77         use OBJC_CLASS.
78         * TestWebKitAPI/PlatformUtilities.h: Changed PLATFORM(MAC) to USE(FOUNDATION) and changed
79         to use OBJC_CLASS.
80         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Changed PLATFORM(MAC) to
81         PLATFORM(COCOA).
82         (TestWebKitAPI::TEST):
83         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
84         (TestWebKitAPI::TEST): Added expected default font-family values for iOS.
85         * TestWebKitAPI/config.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
86         * WebKitTestRunner/EventSenderProxy.h: Ditto.
87         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Ditto.
88         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Ditto.
89         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Ditto.
90         (WTR::AccessibilityTextMarker::platformTextMarker):
91         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Ditto.
92         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Ditto.
93         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
94         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Ditto.
95         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Ditto.
96         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Ditto.
97         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Ditto.
98         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
99         * WebKitTestRunner/PlatformWebView.h: Ditto.
100         * WebKitTestRunner/TestController.cpp: Ditto.
101         (WTR::TestController::resetStateToConsistentValues):
102         (WTR::TestController::processDidCrash):
103         * WebKitTestRunner/TestInvocation.cpp: Ditto.
104         (WTR::updateThreadedScrollingForCurrentTest):
105         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
106         * WebKitTestRunner/cg/TestInvocationCG.cpp: Ditto.
107         (WTR::computeMD5HashStringForContext):
109 2014-02-17  Dan Bernstein  <mitz@apple.com>
111         Stop using PLATFORM(MAC) in DumpRenderTree except where it means “OS X but not iOS”
112         https://bugs.webkit.org/show_bug.cgi?id=128950
114         Reviewed by Anders Carlsson.
116         Changed all PLATFORM(MAC) instances that were not excluding iOS to PLATFORM(COCOA).
118         * DumpRenderTree/AccessibilityController.h:
119         * DumpRenderTree/AccessibilityTextMarker.h:
120         * DumpRenderTree/AccessibilityUIElement.cpp:
121         * DumpRenderTree/AccessibilityUIElement.h:
122         * DumpRenderTree/DumpRenderTree.h:
123         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
124         (computeMD5HashStringForBitmapContext):
125         * DumpRenderTree/cg/PixelDumpSupportCG.h:
126         (BitmapContext::~BitmapContext):
127         * DumpRenderTree/config.h:
129 2014-02-17  Filip Pizlo  <fpizlo@apple.com>
131         More ARM FTL glue
132         https://bugs.webkit.org/show_bug.cgi?id=128948
134         Reviewed by Sam Weinig.
136         * Scripts/configure-llvm: Removed. This isn't really practical now that we require a separate build directory.
137         * Scripts/copy-webkitlibraries-to-product-directory: Switch to using a separate build directory, and for setting a PATH before running LLVM's make.
139 2014-02-17  Brent Fulgham  <bfulgham@apple.com>
141         [Win] There's another Windows SDK. Make sure we recognize it.
142         https://bugs.webkit.org/show_bug.cgi?id=128932
144         Reviewed by Tim Horton.
146         * Scripts/webkitpy/port/win.py:
147         (WinPort._ntsd_location):
149 2014-02-17  Ryosuke Niwa  <rniwa@webkit.org>
151         webkitpy test fix on Mac after r164244.
153         It's somewhat crazy that we're trying to run unittests for Windows on Mac but whatever.
155         * Scripts/webkitpy/port/win.py:
156         (WinPort._ntsd_location):
158 2014-02-17  Brent Fulgham  <bfulgham@apple.com>
160         [Win] Fall back to Windows symbol servers when necessary
161         https://bugs.webkit.org/show_bug.cgi?id=128926
163         Reviewed by Ryosuke Niwa.
165         * Scripts/webkitpy/port/win.py:
166         (WinPort):
167         (setup_crash_log_saving): Fall back to Microsoft Symbol Server when local symbols are
168         not specified.
170 2014-02-17  László Langó  <llango.u-szeged@partner.samsung.com>
172         Fix typos in Tools/efl/jhbuild.modules.
173         https://bugs.webkit.org/show_bug.cgi?id=128908
175         Reviewed by Csaba Osztrogonác.
177         * efl/jhbuild.modules: 's/<deb /<dep /g'
179 2014-02-15  Ryuan Choi  <ryuan.choi@samsung.com>
181         Build break when disabled ACCESSIBILITY since r162986
182         https://bugs.webkit.org/show_bug.cgi?id=128880
184         Unreviewed build fix.
186         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
187         Added dummy implementations for newly added methods.
188         (WTR::AccessibilityUIElement::rowHeaders):
189         (WTR::AccessibilityUIElement::columnHeaders):
190         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
192 2014-02-15  Filip Pizlo  <fpizlo@apple.com>
194         Vector with inline capacity should work with non-PODs
195         https://bugs.webkit.org/show_bug.cgi?id=128864
197         Reviewed by Michael Saboff.
198         
199         This test experiences really bizarre behavior on trunk without the rest of
200         this fix. On my machine, it usually times out because it gets itself into an
201         infinite loop of some kind. With the fix, it passes.
203         * TestWebKitAPI/Tests/WTF/Vector.cpp:
204         (TestWebKitAPI::TEST):
206 2014-02-15  Ryuan Choi  <ryuan.choi@samsung.com>
208         [EFL][WK1] Do not include cairo header in the public headers
209         https://bugs.webkit.org/show_bug.cgi?id=128779
211         Reviewed by Gyuyoung Kim.
213         * DumpRenderTree/PlatformEfl.cmake:
214         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
215         (createBitmapContextFromWebView):
216         Used ewk_view_screenshot_contents_get instead of ewk_view_paint.
217         * EWebLauncher/main.c:
218         (print_history): Replaced ewk_history_item_icon_surface_get to ewk_history_item_icon_object_add
219         (on_key_down):
220         * Scripts/webkitpy/style/checker.py:
221         Added -runtime/ctype_function for EWebLauncher because EWebLauncher is sample
222         and it does not use WTF.
224 2014-02-15  Samuel White  <samuel_white@apple.com>
226         AX: Add ability to specify descendant type when using AXUIElementsForSearchPredicate.
227         https://bugs.webkit.org/show_bug.cgi?id=128747
229         Reviewed by Chris Fleizach.
231         Updated uiElementCountForSearchPredicate and uiElementForSearchPredicate test methods to support 'immediate descendant only' searching.
233         * DumpRenderTree/AccessibilityUIElement.cpp:
234         (uiElementCountForSearchPredicateCallback):
235         (uiElementForSearchPredicateCallback):
236         * DumpRenderTree/AccessibilityUIElement.h:
237         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
238         (AccessibilityUIElement::uiElementCountForSearchPredicate):
239         (AccessibilityUIElement::uiElementForSearchPredicate):
240         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
241         (AccessibilityUIElement::uiElementCountForSearchPredicate):
242         (AccessibilityUIElement::uiElementForSearchPredicate):
243         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
244         (searchPredicateParameterizedAttributeForSearchCriteria):
245         (AccessibilityUIElement::uiElementCountForSearchPredicate):
246         (AccessibilityUIElement::uiElementForSearchPredicate):
247         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
248         (AccessibilityUIElement::uiElementCountForSearchPredicate):
249         (AccessibilityUIElement::uiElementForSearchPredicate):
250         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
251         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
252         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
253         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
254         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
255         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
256         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
257         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
258         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
259         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
260         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
261         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
262         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
263         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
264         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
266 2014-02-15  Ryosuke Niwa  <rniwa@webkit.org>
268         CQ fix after r164105.
270         * DumpRenderTree/mac/EventSendingController.mm:
271         * WebKitTestRunner/mac/EventSenderProxy.mm:
273 2014-02-14  Ryosuke Niwa  <rniwa@webkit.org>
275         Another build fix after r164149.
277         * Scripts/webkitpy/port/port_testcase.py:
278         (test_apache_config_file_name_for_platform):
280 2014-02-14  Ryosuke Niwa  <rniwa@webkit.org>
282         Build fix after r164148.
284         * Scripts/webkitpy/port/base.py:
285         (Port._apache_config_file_name_for_platform):
287 2014-02-14  Ryosuke Niwa  <rniwa@webkit.org>
289         run-webkit-tests doesn't work with Apache 2.4
290         https://bugs.webkit.org/show_bug.cgi?id=128861
292         Reviewed by Andreas Kling.
294         Use apache<version>-httpd.conf like we do on Fedora and Debian.
296         * Scripts/webkitpy/port/base.py:
297         (Port._apache_config_file_name_for_platform):
299 2014-02-14  Brent Fulgham  <bfulgham@apple.com>
301         [Win] Make tests more consistent with Mac platform
302         https://bugs.webkit.org/show_bug.cgi?id=128848
304         Reviewed by Simon Fraser.
306         * DumpRenderTree/win/DumpRenderTree.cpp:
307         (resetDefaultsToConsistentValues): Turn CSS regions on,
308         turn mock scrollbars on, and allow screen font
309         substitution.
311 2014-02-14  Mark Hahnenberg  <mhahnenberg@apple.com>
313         Save ARGV in a local to avoid repeated lookups
315         Rubber stamped by Joseph Pecoraro.
317         * jsc-cli/jsc-cli/CLIInstance.m:
318         (-[CLIInstance didReceiveArguments:atOffset:withLength:]):
320 2014-02-14  Mark Hahnenberg  <mhahnenberg@apple.com>
322         jsc-cli should allow scripts to access argv
323         https://bugs.webkit.org/show_bug.cgi?id=127486
325         Reviewed by Oliver Hunt.
327         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj:
328         * jsc-cli/jsc-cli/CLIInstance.h:
329         * jsc-cli/jsc-cli/CLIInstance.m:
330         (-[CLIInstance init]):
331         (-[CLIInstance loadFile:]):
332         (-[CLIInstance didReceiveArguments:atOffset:withLength:]):
333         * jsc-cli/jsc-cli/JSRunLoopThread.h:
334         * jsc-cli/jsc-cli/JSRunLoopThread.m:
335         (-[JSRunLoopThread initWithContext:]):
336         (-[JSRunLoopThread loadFile:]):
337         (-[JSRunLoopThread start]):
338         * jsc-cli/jsc-cli/main.m:
339         (printUsage):
340         (main):
342 2014-02-14  Andreas Kling  <akling@apple.com>
344         Purge remaining ENABLE(SHADOW_DOM) cruft.
345         <https://webkit.org/b/128827>
347         Reviewed by Antti Koivisto.
349         * DumpRenderTree/gtk/DumpRenderTree.cpp:
350         (resetDefaultsToConsistentValues):
351         * Scripts/webkitperl/FeatureList.pm:
352         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
353         (WTR::InjectedBundle::beginTesting):
355 2014-02-13  Brent Fulgham  <bfulgham@apple.com>
357         Create some latched scrolling tests.
358         https://bugs.webkit.org/show_bug.cgi?id=127606
359         <rdar://problem/15911348>
361         Reviewed by Simon Fraser.
363         * DumpRenderTree/mac/EventSendingController.mm:
364         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize
365         the new "mouseScrollByX:andY:withWheel:andMomentumPhases:" selector.
366         (+[EventSendingController webScriptNameForSelector:]): Ditto.
367         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Implement
368         the new wheel event sender.
369         * WebKitTestRunner/EventSenderProxy.h:
370         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add declaration
371         of new mouseScrollByWithWheelAndMomentumPhases method.
372         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
373         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Added
374         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
375         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
376         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Add stub for iOS.
377         * WebKitTestRunner/TestController.cpp:
378         (WTR::TestController::didReceiveMessageFromInjectedBundle): Handle the new
379         mouseScrollByWithWheelAndMomentumPhases message.
380         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Handle the
381         new mouseScrollByWithWheelAndMomentumPhases.
382         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
383         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Provide stub that
384         relays to the standard mouse wheel handler.
385         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
386         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
387         * WebKitTestRunner/mac/EventSenderProxy.mm:
388         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Provide implementation
389         of mouse wheel gesture method.
391 2014-02-13  David Farler  <dfarler@apple.com>
393         DumpRenderTree fails to build: Perl support module building for OS X but linking for the simulator
394         https://bugs.webkit.org/show_bug.cgi?id=128780
396         Reviewed by Simon Fraser.
398         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
399         Use `xcrun -find clang` instead of `xcrun --sdk $ENV{SDKROOT} -find clang,
400         which will pick up SDKROOT=iphonesimulator from building the Xcode aggregate target.
402 2014-02-13  Commit Queue  <commit-queue@webkit.org>
404         Unreviewed, rolling out r164073 and r164080.
405         http://trac.webkit.org/changeset/164073
406         http://trac.webkit.org/changeset/164080
407         https://bugs.webkit.org/show_bug.cgi?id=128781
409         Broke Mac builds (Requested by rniwa on #webkit).
411         * DumpRenderTree/mac/EventSendingController.mm:
412         (+[EventSendingController isSelectorExcludedFromWebScript:]):
413         (+[EventSendingController webScriptNameForSelector:]):
414         * WebKitTestRunner/EventSenderProxy.h:
415         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
416         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
417         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
418         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
419         * WebKitTestRunner/TestController.cpp:
420         (WTR::TestController::didReceiveMessageFromInjectedBundle):
421         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
422         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
423         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
424         * WebKitTestRunner/mac/EventSenderProxy.mm:
426 2014-02-13  Brent Fulgham  <bfulgham@apple.com>
428         Unreviewed build fix for Mountain Lion.
430         * DumpRenderTree/mac/EventSendingController.mm: Provide definition
431         for kCGScrollWheelEventScrollPhase if it isn't found in the
432         system headers.
434 2014-02-04  Gustavo Noronha Silva  <gns@gnome.org>
436         [GTK][CMake] Generate GObject DOM bindings .symbols files
437         https://bugs.webkit.org/show_bug.cgi?id=126210
439         Reviewed by Martin Robinson.
441         * gtk/check-gdom-symbols: Added. Checks symbols compatibility.
442         (should_update_symbols_file):
444 2014-02-13  Brent Fulgham  <bfulgham@apple.com>
446         Create some latched scrolling tests.
447         https://bugs.webkit.org/show_bug.cgi?id=127606
448         <rdar://problem/15911348>
450         Reviewed by Simon Fraser.
452         * DumpRenderTree/mac/EventSendingController.mm:
453         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize
454         the new "mouseScrollByX:andY:withWheel:andMomentumPhases:" selector.
455         (+[EventSendingController webScriptNameForSelector:]): Ditto.
456         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Implement
457         the new wheel event sender.
458         * WebKitTestRunner/EventSenderProxy.h:
459         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add declaration
460         of new mouseScrollByWithWheelAndMomentumPhases method.
461         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
462         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Added
463         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
464         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
465         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Add stub for iOS.
466         * WebKitTestRunner/TestController.cpp:
467         (WTR::TestController::didReceiveMessageFromInjectedBundle): Handle the new
468         mouseScrollByWithWheelAndMomentumPhases message.
469         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Handle the
470         new mouseScrollByWithWheelAndMomentumPhases.
471         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
472         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Provide stub that
473         relays to the standard mouse wheel handler.
474         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
475         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
476         * WebKitTestRunner/mac/EventSenderProxy.mm:
477         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Provide implementation
478         of mouse wheel gesture method.
480 2014-02-13  Antoine Quint  <graouts@webkit.org>
482         Unreviewed. changing my email address.
484         * Scripts/webkitpy/common/config/contributors.json:
485         * Scripts/webkitpy/common/config/watchlist:
487 2014-02-13  Alexey Proskuryakov  <ap@apple.com>
489         [Mac] Add a WebKit1 SPI to get WebCrypto master key from a client
490         https://bugs.webkit.org/show_bug.cgi?id=128725
492         Reviewed by Anders Carlsson.
494         * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webCryptoMasterKeyForWebView:]):
495         Use the SPI to specify a key.
497 2014-02-13  Sergio Villar Senin  <svillar@igalia.com>
499         Unreviewed. Moved myself to the list of reviewers.
501         * Scripts/webkitpy/common/config/contributors.json:
503 2014-02-13  Tim Horton  <timothy_horton@apple.com>
505         Speculative build fix after r163998.
507         * DumpRenderTree/ios/PerlSupport/Makefile:
509 2014-02-12  Alexey Proskuryakov  <ap@apple.com>
511         [WK2] Add a C API to get WebCrypto master key from a client
512         https://bugs.webkit.org/show_bug.cgi?id=128702
514         Reviewed by Anders Carlsson.
516         * WebKitTestRunner/TestController.cpp:
517         (WTR::copyWebCryptoMasterKey):
518         (WTR::TestController::initialize):
519         Return a hardcoded key.
521 2014-02-12  David Farler  <dfarler@apple.com>
523         Upstream iOS old-run-webkit-tests for use with DumpRenderTree in the iOS Simulator
524         https://bugs.webkit.org/show_bug.cgi?id=127694
526         Reviewed by Simon Fraser.
528         This is a short-term effort to get layout tests working in the iOS simulator again.
530         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
531         Pass PLATFORM_NAME to the makefile.
532         * DumpRenderTree/ios/PerlSupport/Makefile:
533         Cleanup.
534         * Scripts/old-run-webkit-tests:
535         Added functions and some exceptions for the simulator.
536         (installAndLaunchDumpRenderTreeAppUsingNotification):
537         (openIPhoneSimulator):
538         (quitDumpRenderTreeAppUsingNotification):
539         (quitIPhoneSimulator):
540         (simulatorSessionUUID):
541         (openDiffTool):
542         (buildDumpTool):
543         (openDumpTool):
544         (closeDumpTool):
545         (dumpToolDidCrash):
546         (expectedDirectoryForTest):
547         (buildPlatformResultHierarchy):
548         * Scripts/webkitdirs.pm:
549         Support functions for old-run-webkit-tests.
550         (determineIPhoneSimulatorVersion):
551         (iPhoneSimulatorVersion):
553 2014-02-12  Mark Hahnenberg  <mhahnenberg@apple.com>
555         Basic framework for a modern jsc CLI
556         https://bugs.webkit.org/show_bug.cgi?id=127435
558         Rubber stamped by Geoffrey Garen.
560         * Scripts/build-jsc:
561         * jsc-cli: Added.
562         * jsc-cli/jsc-cli: Added.
563         * jsc-cli/jsc-cli.xcodeproj: Added.
564         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
565         * jsc-cli/jsc-cli/CLIInstance.h: Added.
566         * jsc-cli/jsc-cli/CLIInstance.m: Added.
567         (-[CLIInstance init]):
568         (-[CLIInstance loadFile:]):
569         (-[CLIInstance run]):
570         * jsc-cli/jsc-cli/JSModule.h: Added.
571         * jsc-cli/jsc-cli/JSModule.m: Added.
572         (coreModules):
573         (isCoreModule):
574         (classForModule):
575         (coreModuleFullPath):
576         (resolveModuleAsFile):
577         (resolveModuleAsDirectory):
578         (nodeModulePaths):
579         (resolveAsNodeModule):
580         (+[JSModule resolve:atPath:]):
581         (globalModuleCache):
582         (isCached):
583         (cachedModule):
584         (cacheModule):
585         (+[JSModule require:atPath:]):
586         (+[JSModule require:atPath:inContext:]):
587         (-[JSModule platformObjectInContext:]):
588         (-[JSModule initWithId:filename:context:]):
589         (-[JSModule dealloc]):
590         (-[JSModule didStartLoading]):
591         (-[JSModule didFinishLoading]):
592         (-[JSModule require:]):
593         (-[JSModule exports]):
594         * jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
595         * jsc-cli/jsc-cli/JSRunLoopThread.m: Added.
596         (jsThreadMain):
597         (+[JSRunLoopThread threadMain]):
598         (-[JSRunLoopThread initWithFiles:andContext:]):
599         (-[JSRunLoopThread startRunLoop]):
600         (-[JSRunLoopThread start]):
601         (-[JSRunLoopThread join]):
602         (-[JSRunLoopThread didReceiveInput:]):
603         (-[JSRunLoopThread performCallback:withError:]):
604         (-[JSRunLoopThread performCallback:withArguments:]):
605         (-[JSRunLoopThread didFinishRunLoopInitialization]):
606         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
607         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.
608         (-[ReadEvalPrintLoop initWithJSThread:]):
609         (prompt):
610         (escapeStringForOutput):
611         (-[ReadEvalPrintLoop processNextInput]):
612         (-[ReadEvalPrintLoop run]):
613         * jsc-cli/jsc-cli/RunLoopThread.h: Added.
614         * jsc-cli/jsc-cli/RunLoopThread.m: Added.
615         (+[RunLoopThread threadMain]):
616         (-[RunLoopThread init]):
617         (-[RunLoopThread dealloc]):
618         (-[RunLoopThread didFinishRunLoopInitialization]):
619         (-[RunLoopThread start]):
620         (-[RunLoopThread join]):
621         * jsc-cli/jsc-cli/ScriptInputSource.h: Added.
622         * jsc-cli/jsc-cli/ScriptInputSource.m: Added.
623         (scriptInputSourceScheduleRoutine):
624         (scriptInputSourcePerformRoutine):
625         (scriptInputSourceCancelRoutine):
626         (-[ScriptInputSource initWithContext:]):
627         (-[ScriptInputSource dealloc]):
628         (-[ScriptInputSource addToCurrentRunLoop]):
629         (-[ScriptInputSource removeFromRemoteRunLoop]):
630         (-[ScriptInputSource didReceiveScript:]):
631         (-[ScriptInputSource didReceiveSignal]):
632         (-[ScriptInputSource runScriptRemotely:]):
633         (-[ScriptInputSource finishAsyncCallback:withResult:]):
634         * jsc-cli/jsc-cli/main.m: Added.
635         (main):
637 2014-02-12  Ryosuke Niwa  <rniwa@webkit.org>
639         One more build fix after r163979.
641         * Scripts/webkitpy/port/mac_unittest.py:
642         (test_baseline_search_path):
644 2014-02-12  Ryosuke Niwa  <rniwa@webkit.org>
646         Add a mac-wk1 platform directory and TestExpectations file
647         https://bugs.webkit.org/show_bug.cgi?id=128676
649         Build fix. Put mac-wk1 between mac-mountainlion and mac.
651         * Scripts/webkitpy/port/mac.py:
652         (MacPort.default_baseline_search_path):
653         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
654         (TestRebaselineTest.test_baseline_directory):
656 2014-02-12  Brady Eidson  <beidson@apple.com>
658         Add a mac-wk1 platform directory and TestExpectations file
659         https://bugs.webkit.org/show_bug.cgi?id=128676
661         Reviewed by Alexey Proskuryakov.
663         * Scripts/webkitpy/port/mac.py:
664         (MacPort.default_baseline_search_path): When running WK1 tests on Mac,
665           make mac-wk1 be the frontmost search path.
667 2014-02-11  Oliver Hunt  <oliver@apple.com>
669         Make it possible to implement JS builtins in JS
670         https://bugs.webkit.org/show_bug.cgi?id=127887
672         Reviewed by Michael Saboff.
674         CMake updates
676         * DumpRenderTree/CMakeLists.txt:
677         * WebKitTestRunner/CMakeLists.txt:
678         * WinCELauncher/CMakeLists.txt:
680 2014-02-11  Filip Pizlo  <fpizlo@apple.com>
682         It should be possible to force copy-webkitlibraries-blahblah to copy things regardless of timestamp
683         https://bugs.webkit.org/show_bug.cgi?id=128646
685         Reviewed by Mark Rowe.
687         * Scripts/copy-webkitlibraries-to-product-directory:
688         (unpackIfNecessary):
689         (dittoHeaders):
691 2014-02-11  Brian Burg  <bburg@apple.com>
693         Web Replay: upstream replay input code generator and EncodedValue class
694         https://bugs.webkit.org/show_bug.cgi?id=128215
696         Reviewed by Joseph Pecoraro.
698         Add an executable script to launch the replay input generator tests.
699         Add a test harness for running the code generator tests, mostly taken
700         from the bindings test harness (but simplified).
702         * Scripts/run-input-generator-tests: Added.
703         (main):
704         * Scripts/webkitpy/replay/__init__.py: Added.
705         * Scripts/webkitpy/replay/main.py: Added.
706         (InputGeneratorTests):
707         (InputGeneratorTests.__init__):
708         (InputGeneratorTests.generate_from_json):
709         (InputGeneratorTests.write_error_file):
710         (InputGeneratorTests.detect_changes):
711         (InputGeneratorTests.run_tests):
712         (InputGeneratorTests.main):
714 2014-02-11  James Craig  <jcraig@apple.com>
716         Web Inspector: AX: Accessibility Node Inspection
717         https://bugs.webkit.org/show_bug.cgi?id=127447
719         Reviewed by Chris Fleizach.
721         Resolving build failure caused by r163891.
723         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
724         (WTR::AccessibilityUIElement::computedRoleString):
726 2014-02-11  Alex Christensen  <achristensen@webkit.org>
728         Fixed pointer truncation on Win64.
729         https://bugs.webkit.org/show_bug.cgi?id=128211
731         Reviewed by Brent Fulgham.
733         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
734         (AccessibilityController::rootElement):
735         * DumpRenderTree/win/TestRunnerWin.cpp:
736         (TestRunner::setWindowIsKey):
737         Removed all casts from &HWND to OLE_HANDLE*.
739 2014-02-11  Samuel White  <samuel_white@apple.com>
741         AX: Add text replacement activity support to NSAccessibilitySelectTextWithCriteriaParameterizedAttribute.
742         https://bugs.webkit.org/show_bug.cgi?id=128397
744         Reviewed by Chris Fleizach.
746         Updated testing methods to accept a replacement string. This enables us to test text
747         replacement support for the AXSelectTextWithCriteria parameterized attribute.
749         * DumpRenderTree/AccessibilityUIElement.cpp:
750         (selectTextWithCriteriaCallback):
751         * DumpRenderTree/AccessibilityUIElement.h:
752         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
753         (AccessibilityUIElement::selectTextWithCriteria):
754         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
755         (AccessibilityUIElement::selectTextWithCriteria):
756         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
757         (selectTextParameterizedAttributeForCriteria):
758         (AccessibilityUIElement::selectTextWithCriteria):
759         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
760         (AccessibilityUIElement::selectTextWithCriteria):
761         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
762         (WTR::AccessibilityUIElement::selectTextWithCriteria):
763         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
764         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
765         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
766         (WTR::AccessibilityUIElement::selectTextWithCriteria):
767         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
768         (WTR::AccessibilityUIElement::selectTextWithCriteria):
769         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
770         (WTR::selectTextParameterizedAttributeForCriteria):
771         (WTR::AccessibilityUIElement::selectTextWithCriteria):
773 2014-02-11  David Kilzer  <ddkilzer@apple.com>
775         [ASan] Fix build failures in Tools due to missing $(inherited) values
776         <http://webkit.org/b/128485>
778         Reviewed by Dean Jackson.
780         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
781         - Move $(inherited) from OTHER_LDFLAGS_macosx to OTHER_LDFLAGS.
783         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
784         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
785         - Add $(inherited) to OTHER_LDFLAGS.
787         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
788         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
789         - Add $(inherited) to OTHER_LDFLAGS, or move from
790           OTHER_LDFLAGS_BASE to OTHER_LDFLAGS.
791         - Extract $(OTHER_LDFLAGS_BASE) from platform-specific settings
792           into OTHER_LDFLAGS.
794 2014-02-11  James Craig  <jcraig@apple.com>
796         Web Inspector: AX: Accessibility Node Inspection
797         https://bugs.webkit.org/show_bug.cgi?id=127447
799         Reviewed by Timothy Hatcher.
801         New computedRoleString interfaces in DumpRenderTree/WebKitTestRunner
802         to support LayoutTest coverage of AccessibilityObject::computedRoleString()
804         * DumpRenderTree/AccessibilityUIElement.cpp:
805         * DumpRenderTree/AccessibilityUIElement.h:
806         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
807         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
808         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
809         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
810         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
811         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
812         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
813         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
814         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
816 2014-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
818         Unreviewed. Fix /webkit2/WebKitWebExtension/isolated-world after r163797.
820         Use a global variable for the script result.
822         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
823         (scriptDialogCallback):
824         (testWebExtensionIsolatedWorld):
826 2014-02-10  Filip Pizlo  <fpizlo@apple.com>
828         Make it possible to run tests with --llvmSimpleOpt=false
829         https://bugs.webkit.org/show_bug.cgi?id=128571
831         Reviewed by Mark Lam.
832         
833         This also makes it so all run functions for the FTL are safe to call with FTL disabled,
834         because they do their own $enableFTL check.
836         * Scripts/run-jsc-stress-tests:
838 2014-02-10  Gavin Barraclough  <barraclough@apple.com>
840         Remove WKPageSetVisibilityState
841         https://bugs.webkit.org/show_bug.cgi?id=128551
843         Reviewed by Anders Carlsson.
845         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
846         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
847         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
848             - visibilityState of offs-creen WKView is automatically prerender.
849         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
850         (WTR::InjectedBundle::setHidden):
851         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
852         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
853         (WTR::TestRunner::setPageVisibility):
854         (WTR::TestRunner::resetPageVisibility):
855         * WebKitTestRunner/TestController.cpp:
856         * WebKitTestRunner/TestController.h:
857         * WebKitTestRunner/TestInvocation.cpp:
858         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
859             - removed calls to WKPageSetVisibilityState.
861 2014-02-10  Carlos Garcia Campos  <cgarcia@igalia.com>
863         [GLIB] Add GUniqueOutPtr and use it instead of GOwnPtr
864         https://bugs.webkit.org/show_bug.cgi?id=127554
866         Reviewed by Gustavo Noronha Silva.
868         Use GUniqueOutPtr instead of GOwnPtr.
870         * DumpRenderTree/gtk/DumpRenderTree.cpp:
871         * DumpRenderTree/gtk/EventSender.cpp:
872         (createKeyPressEvent):
873         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
874         (TestWebKitAPI::returnOutChar):
875         (TestWebKitAPI::TEST):
876         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
877         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
878         (testInspectorServerPageList):
879         (openRemoteDebuggingSession):
880         (sendIncompleteRequest):
881         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
882         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
883         (testWebExtensionWindowObjectCleared):
884         (testWebExtensionIsolatedWorld):
885         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
886         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
887         (testWebViewRunJavaScript):
888         (testWebViewSave):
889         (testWebViewPageVisibility):
890         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
891         (isStyleSheetInjectedForURLAtPath):
892         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
893         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
894         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
895         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
896         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
897         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
898         (TestWebKitAPI::doKeyStroke):
899         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
900         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
901         (WebKitTestBus::run):
902         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
903         (resourceGetDataCallback):
904         (WebViewTest::keyStroke):
905         (onSnapshotReady):
906         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
907         (WTR::EventSenderProxy::keyDown):
909 2014-02-10  Carlos Garcia Campos  <cgarcia@igalia.com>
911         [GTK] Add API to create a webview related to another one
912         https://bugs.webkit.org/show_bug.cgi?id=128498
914         Reviewed by Gustavo Noronha Silva.
916         * MiniBrowser/gtk/BrowserWindow.c:
917         (webViewCreate): Use webkit_web_view_new_with_related_view() when
918         creating a new web view for window.open().
919         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
920         (testMultiprocessWebViewCreateReadyClose): Add test case to check
921         that window.open() works when creating the new WebView related to
922         the existing one, and that no new web process is spawned when
923         using webkit_web_view_new_with_related_view().
924         (beforeAll):
926 2014-02-10  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
928         If not running on Mac, build-webkit should not print Safari related output
929         https://bugs.webkit.org/show_bug.cgi?id=127169
931         Reviewed by Darin Adler.
933         * Scripts/build-webkit:
934         (writeCongrats):
935         * Scripts/webkitdirs.pm:
936         (isAppleWebKit):
937         (isAppleMacWebKit):
938         (isAppleWinWebKit):
939         (launcherName):
941 2014-02-10  Diego Pino Garcia  <dpino@igalia.com>
943         [GTK] Minibrowser: During text search, make navigation through list of matched words circular
944         https://bugs.webkit.org/show_bug.cgi?id=128463
946         Reviewed by Carlos Garcia Campos.
948         Initialize search options to WEBKIT_FIND_OPTIONS_WRAP_AROUND to make navigation
949         circular.
951         * MiniBrowser/gtk/BrowserSearchBar.c:
952         (doSearch):
954 2014-02-10  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
956         Code cleanup: Remove BUILDING_ON / TARGETING definitions.
957         https://bugs.webkit.org/show_bug.cgi?id=128242
959         Reviewed by Brent Fulgham.
961         The BUILDING_ON_* and TARGETING_* macros have not been used for a while.
962         According to the FIXME: they are removed.
964         * DumpRenderTree/config.h:
966 2014-02-10  Zan Dobersek  <zdobersek@igalia.com>
968         Fix a few mistakes that landed with r163749.
970         Rubber-stamped by Carlos Garcia Campos.
972         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
973         (WTR::EventSenderProxy::addTouchPoint): Avoid using the GUniquePtr<GdkEvent> after it's been moved
974         into the event vector since moving it invalidates the variable.
976 2014-02-09  Carlos Garnacho  <carlosg@gnome.org>
978         [GTK] Fix modifiers on EventSenderProxy::keyDown
979         https://bugs.webkit.org/show_bug.cgi?id=128496
981         Reviewed by Carlos Garcia Campos.
983         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
984         (WTR::EventSenderProxy::keyDown): do not attempt to doubly transform modifiers
985         into GTK+ ones.
987 2014-02-09  Carlos Garnacho  <carlosg@gnome.org>
989         [GTK] Enable touch features
990         https://bugs.webkit.org/show_bug.cgi?id=98931
992         Reviewed by Carlos Garcia Campos.
994         * WebKitTestRunner/EventSenderProxy.h:
995         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
996         (WTR::updateEventCoordinates):
997         (WTR::EventSenderProxy::createTouchEvent):
998         (WTR::EventSenderProxy::addTouchPoint):
999         (WTR::EventSenderProxy::updateTouchPoint):
1000         (WTR::EventSenderProxy::sendUpdatedTouchEvents):
1001         (WTR::EventSenderProxy::setTouchPointRadius):
1002         (WTR::EventSenderProxy::setTouchModifier): Implement touch event proxying.
1004 2014-02-08  Andreas Kling  <akling@apple.com>
1006         Let Instruments time profiler run until tests finish.
1007         <https://webkit.org/b/128488>
1009         Pass "-T 0" to iprofiler to ensure that we get a time profile of the
1010         entire performance test run instead of just the first 10 seconds.
1012         Reviewed by Brady Eidson.
1014         * Scripts/webkitpy/common/system/profiler.py:
1015         (IProfiler.attach_to_pid):
1017 2014-02-08  Rajaram Gaunker  <zimbabao@gmail.com>
1019         [GTK] Add stdlib include file to fix ImageDiff build with libc++
1020         https://bugs.webkit.org/show_bug.cgi?id=128454
1022         Reviewed by Darin Adler.
1024         * ImageDiff/gtk/ImageDiff.cpp:
1026 2014-02-08  Diego Pino Garcia  <dpino@igalia.com>
1028         [GTK] Minibrowser: Matched words of a searched text are not highlighted after reopening search bar
1029         https://bugs.webkit.org/show_bug.cgi?id=128380
1031         Reviewed by Carlos Garcia Campos.
1033         When open the search bar, perform last search if there is any.
1035         * MiniBrowser/gtk/BrowserSearchBar.c:
1036         (browser_search_bar_open):
1038 2014-02-08  Adrian Perez de Castro  <aperez@igalia.com>
1040         [GTK] Make process model names properly meaningful
1041         https://bugs.webkit.org/show_bug.cgi?id=128389
1043         Reviewed by Carlos Garcia Campos.
1045         The name WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
1046         is misleading because there are situations in which web views may
1047         share the same web process even when multi-process mode is enabled;
1048         for example when opening a related view and both interact using JS.
1050         * MiniBrowser/gtk/main.c:
1051         (main):
1052         Update usage of WebKitProcessModel enum values.
1053         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1054         (beforeAll):
1055         Ditto.
1057 2014-02-08  Diego Pino Garcia  <dpino@igalia.com>
1059         [GTK] build-webkit script always generate-gtk-doc even if '--disable-gtk-doc' param is passed
1060         https://bugs.webkit.org/show_bug.cgi?id=128376
1062         Reviewed by Carlos Garcia Campos.
1064         * Scripts/webkitdirs.pm:
1065         (buildAutotoolsProject):
1067 2014-02-06  Filip Pizlo  <fpizlo@apple.com>
1069         More FTL build scaffolding
1070         https://bugs.webkit.org/show_bug.cgi?id=128330
1072         Reviewed by Geoffrey Garen.
1074         * Scripts/copy-webkitlibraries-to-product-directory:
1076 2014-02-07  Tim Horton  <timothy_horton@apple.com>
1078         Touch Minibrowser for a hopeful build fix.
1080         * MiniBrowser/mac/WK2BrowserWindowController.m:
1082 2014-02-07  Krzysztof Czech  <k.czech@samsung.com>
1084         Build fix after r163632
1086         Unreviewed EFL build fix
1088         Added empty stub to WKTR to not break EFL build.
1090         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1091         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1093 2014-02-07  Samuel White  <samuel_white@apple.com>
1095         AX: Find and select text with respect to insertion point using accessibility API.
1096         https://bugs.webkit.org/show_bug.cgi?id=128026
1098         Reviewed by Chris Fleizach.
1100         Added method to AccessibilityUIElement to enable testing of accessibility text selection.
1102         * DumpRenderTree/AccessibilityUIElement.cpp:
1103         (selectTextWithCriteriaCallback):
1104         (AccessibilityUIElement::getJSClass):
1105         * DumpRenderTree/AccessibilityUIElement.h:
1106         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1107         (AccessibilityUIElement::selectTextWithCriteria):
1108         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1109         (AccessibilityUIElement::selectTextWithCriteria):
1110         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1111         (selectTextParameterizedAttributeForCriteria):
1112         (AccessibilityUIElement::selectTextWithCriteria):
1113         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1114         (AccessibilityUIElement::selectTextWithCriteria):
1115         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1116         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1117         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1118         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1119         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1120         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1121         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1122         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1123         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1124         (WTR::selectTextParameterizedAttributeForCriteria):
1125         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1127 2014-02-07  Manuel Rego Casasnovas  <rego@igalia.com>
1129         [GTK] Disable gtk-doc in EWS
1130         https://bugs.webkit.org/show_bug.cgi?id=128370
1132         Reviewed by Carlos Garcia Campos.
1134         Disable gtk-doc generation in EWS due to http://webkit.org/b/128369.
1136         * Scripts/webkitpy/common/config/ports.py:
1137         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
1138         (GtkWK2Port.build_webkit_command): Ditto.
1139         * Scripts/webkitpy/common/config/ports_unittest.py:
1140         (DeprecatedPortTest.test_gtk_port): Ditto.
1141         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
1143 2014-02-07  Jinwoo Song  <jinwoo7.song@samsung.com>
1145         [EFL][WK2] WebView should be able to configure to set fixed layout
1146         https://bugs.webkit.org/show_bug.cgi?id=128300
1148         Reviewed by Gyuyoung Kim.
1150         * MiniBrowser/efl/main.c:
1151         (window_create):
1152         (elm_main): Add command argument option to use fixed layout.
1154 2014-02-06  Ryosuke Niwa  <rniwa@webkit.org>
1156         Fix DoYouEvenBench after r163429.
1158         * Scripts/webkitpy/performance_tests/perftest.py:
1160 2014-02-06  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1162         Add support for multiple sources for AutoInstaller
1163         https://bugs.webkit.org/show_bug.cgi?id=124848
1165         Reviewed by Ryosuke Niwa.
1167         The autoinstaller in the webkitpy currently fails if the download source of a package is unavailable.
1168         This patch adds support for multiple sources to the script. The sources are provided in three environment variables.
1169         If it exists, the script will look at a local cache. If not, it will try to download the package from the original url.
1170         If it fails, it gets a mirror from the corresponding environment variable.(One for sourceforge.org and one for pypi.python.org)
1172         * Scripts/webkitpy/common/system/autoinstall.py:
1173         (AutoInstaller._copy_unpackaged_files_from_local_cache):  If the package is not packaged in its original form,
1174         this method will copy it to the scratch directory. Otherwise it would be deleted from the cache, which we do not want.
1175         (AutoInstaller._prepare_package): If the package is not zipped or tarred, and the file is in the cache, the
1176         _copy_unpackaged_files_from_local_cache function is called.
1177         (AutoInstaller._parse_colon_separated_mirrors_from_env): This will read the mirrors from the environment variables if possible,
1178         and prepares them for further use.
1179         (AutoInstaller):
1180         (AutoInstaller._replace_domain_with_next_mirror): If the original download url fails, it is replaced by a mirror provided
1181         in the environment variables. The function identifies the original source, and replaces it with a mirror. If it can't be done,
1182         the return url will be None, indicating that no mirrors are provided, or none of them could be reached.
1183         (AutoInstaller._download_to_stream): The timeout for one try is now limited to 30 seconds. Without this, the script waited for
1184         roughly 4 minutes before retrying. After three failiures the script will try to switch to a mirror.
1185         (AutoInstaller._check_package_in_local_autoinstall_cache): This method searches the cache for the currently downloaded module.
1186         If it's found there, its path is returned.
1187         (AutoInstaller._download):  Before downloading the module, it is looked up in the cache. If it's not found there,
1188         the script will continue with the download, and cache the module.
1190 2014-02-06  Benjamin Poulain  <benjamin@webkit.org>
1192         Remove run-test-webkit-api
1193         https://bugs.webkit.org/show_bug.cgi?id=118145
1195         Reviewed by Csaba Osztrogonác.
1197         Having two scripts doing the same thing is confusing. There are also cases failing
1198         on run-test-webkit-api since it does not restart a new process for each test.
1200         * Scripts/run-test-webkit-api: Removed.
1201         * Scripts/webkitdirs.pm:
1203 2014-02-06  Commit Queue  <commit-queue@webkit.org>
1205         Unreviewed, rolling out r163530.
1206         http://trac.webkit.org/changeset/163530
1207         https://bugs.webkit.org/show_bug.cgi?id=128311
1209         It broke run-gtk-tests (Requested by Ossy on #webkit).
1211         * efl/common.py: Copied from Tools/gtk/jhbuildrc.
1212         (script_path):
1213         (top_level_path):
1214         * efl/jhbuildrc:
1215         * gtk/common.py:
1216         (script_path):
1217         (top_level_path):
1218         * gtk/find-make-dist-errors:
1219         (get_missing_headers):
1220         * gtk/generate-gtkdoc:
1221         (get_webkit2_options):
1222         (get_webkit1_options.src_path):
1223         (get_webkit1_options):
1224         (get_webkitdom_options.src_path):
1225         (get_webkitdom_options):
1226         * gtk/generate-inspector-gresource-manifest.py:
1227         * gtk/jhbuildrc:
1228         * jhbuild/jhbuildrc_common.py: Removed.
1229         * nix/common.py: Copied from Tools/nix/jhbuildrc.
1230         (script_path):
1231         (top_level_path):
1232         * nix/jhbuildrc:
1234 2014-02-06  Denis Nomiyama  <d.nomiyama@samsung.com>
1236         Unreviewed. Add myself as a committer.
1238         * Scripts/webkitpy/common/config/contributors.json:
1240 2014-02-06  Peter Szanka  <h868064@stud.u-szeged.hu>
1242         Extract common parts from jhbuildrc files.
1243         https://bugs.webkit.org/show_bug.cgi?id=125986
1245         Reviewed by Csaba Osztrogonác.
1247         * efl/common.py: Removed.
1248         * efl/jhbuildrc:
1249         * gtk/common.py:
1250         (binary_build_path):
1251         * gtk/find-make-dist-errors:
1252         (get_missing_headers):
1253         * gtk/generate-gtkdoc:
1254         (get_webkit2_options):
1255         (get_webkit1_options.src_path):
1256         (get_webkit1_options):
1257         (get_webkitdom_options.src_path):
1258         (get_webkitdom_options):
1259         * gtk/generate-inspector-gresource-manifest.py:
1260         * gtk/jhbuildrc:
1261         * jhbuild/jhbuildrc_common.py: Added.
1262         (script_path):
1263         (top_level_path):
1264         (init):
1265         * nix/common.py: Removed.
1266         * nix/jhbuildrc:
1268 2014-02-06  Csaba Osztrogonác  <ossy@webkit.org>
1270         Unreviewed fix after r163520, remove Andrei from committers list, because
1271         he is reviewer now, and webkit-patch doesn't like duplicated entries.
1273         * Scripts/webkitpy/common/config/contributors.json:
1275 2014-02-06  Andrei Bucur  <abucur@adobe.com>
1277         Adding myself as a reviewer.
1279         Unreviewed.
1281         * Scripts/webkitpy/common/config/contributors.json:
1283 2014-02-05  Zan Dobersek  <zdobersek@igalia.com>
1285         Remove the WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS macro
1286         https://bugs.webkit.org/show_bug.cgi?id=128267
1288         Reviewed by Andreas Kling.
1290         Remove the COMPILER_SUPPORTS(CXX_GENERALIZED_INITIALIZERS) as the underlying macro is also
1291         being removed since the feature is supported by all the compilers the project approves.
1293         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1294         (TestWebKitAPI::TEST):
1295         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1296         (TestWebKitAPI::TEST):
1298 2014-02-05  Jinwoo Song  <jinwoo7.song@samsung.com>
1300         [EFL][WK2] Remove legacy behavior mode in MiniBrowser
1301         https://bugs.webkit.org/show_bug.cgi?id=128298
1303         Reviewed by Gyuyoung Kim.
1305         MiniBrowser is crashing when the legacy mode is set in creating webview.
1306         As EFL application cannot use this API for creating webview after r146265,
1307         it would be better to remove this invalid option.
1309         * MiniBrowser/efl/main.c:
1310         (window_create): Do not create webview with WKViewCreate API.
1311         (elm_main): Remove 'legacy' option.
1313 2014-02-05  Andreas Kling  <akling@apple.com>
1315         Remove ENABLE(DIRECTORY_UPLOAD).
1316         <https://webkit.org/b/128275>
1318         Rubber-stamped by Ryosuke Niwa.
1320         * Scripts/webkitperl/FeatureList.pm:
1322 2014-02-05  Filip Pizlo  <fpizlo@apple.com>
1324         Rename useExperimentalFTL to useFTLJIT.
1326         Rubber stamped by Mark Hahnenberg.
1328         * Scripts/run-jsc-stress-tests:
1330 2014-02-05  Filip Pizlo  <fpizlo@apple.com>
1332         JSC on Mac should pull LLVM from prefix=/usr/local/LLVMForJavaScriptCore and not /usr/local
1333         https://bugs.webkit.org/show_bug.cgi?id=128269
1335         Reviewed by Mark Hahnenberg.
1337         * Scripts/copy-webkitlibraries-to-product-directory:
1339 2014-02-05  Manuel Rego Casasnovas  <rego@igalia.com>
1341         Create CSS Grid Layout watchlist
1342         https://bugs.webkit.org/show_bug.cgi?id=128241
1344         Reviewed by Andreas Kling.
1346         Add Sergio Villar, Javier Fernandez and myself to it.
1348         Add Javier Fernandez as contributor.
1350         * Scripts/webkitpy/common/config/contributors.json:
1351         * Scripts/webkitpy/common/config/watchlist:
1353 2014-02-05  Alexey Proskuryakov  <ap@apple.com>
1355         Copying failing test paths from build.webkit.org/dashboard popovers also copies non-selectable links
1356         https://bugs.webkit.org/show_bug.cgi?id=128236
1358         Reviewed by Timothy Hatcher.
1360         Work around bug 80159 - copying should always respect user-select:none, but it doesn't yet.
1362         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1363         When copying, temporarily make non-selectable parts invisible, and put text of
1364         the selection onto pasteboard. Since we immediately make everything visible again,
1365         there is even no blinking.
1367 2014-02-05  Nick Diego Yamane  <nick.yamane@openbossa.org>
1369         Unreviewed. Add myself to contributors.json
1371         * Scripts/webkitpy/common/config/contributors.json:
1373 2014-02-05  Sergio Correia  <sergio.correia@openbossa.org>
1375         Unreviewed. Add myself to contributor and watch lists
1377         * Scripts/webkitpy/common/config/contributors.json:
1378         * Scripts/webkitpy/common/config/watchlist:
1380 2014-02-05  Alberto Garcia  <berto@igalia.com>
1382         Unreviewed. Add myself to some watchlists.
1384         * Scripts/webkitpy/common/config/watchlist:
1386 2014-02-05  Gabor Rapcsanyi  <rgabor@webkit.org>
1388         Fix WaitForSVNServer build step after r163372.
1390         Rubber-stamped by Csaba Osztrogonác.
1392         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1393         (WaitForSVNServer.evaluateCommand): add missing return SUCCESS
1395 2014-02-05  Csaba Osztrogonác  <ossy@webkit.org>
1397         Remove ENABLE(SVG) guards
1398         https://bugs.webkit.org/show_bug.cgi?id=127991
1400         Reviewed by Sam Weinig.
1402         * Scripts/webkitperl/FeatureList.pm:
1403         * TestWebKitAPI/GNUmakefile.am:
1405 2014-02-04  Andreas Kling  <akling@apple.com>
1407         Remove <iframe seamless> support.
1408         <https://webkit.org/b/128213>
1410         Rubber-stamped by Antti Koivisto.
1412         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1413         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1414         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1415         (resetDefaultsToConsistentValues):
1416         * DumpRenderTree/mac/DumpRenderTree.mm:
1417         (resetWebPreferencesToConsistentValues):
1418         * DumpRenderTree/win/DumpRenderTree.cpp:
1419         (resetDefaultsToConsistentValues):
1420         * Scripts/webkitperl/FeatureList.pm:
1421         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1422         (WTR::InjectedBundle::beginTesting):
1424 2014-02-04  Filip Pizlo  <fpizlo@apple.com>
1426         Fix build when the script is called from Xcode.
1428         * Scripts/copy-webkitlibraries-to-product-directory:
1430 2014-02-04  Filip Pizlo  <fpizlo@apple.com>
1432         DFG PutByVal on typed arrays should detect OutOfBounds sooner
1433         https://bugs.webkit.org/show_bug.cgi?id=128162
1435         Reviewed by Mark Hahnenberg.
1436         
1437         Add a defautNoEagerRun, which is intended to be used for convergence tests.
1439         * Scripts/run-jsc-stress-tests:
1441 2014-02-04  Filip Pizlo  <fpizlo@apple.com>
1443         export-llvm-build should work with git checkouts
1444         https://bugs.webkit.org/show_bug.cgi?id=128217
1446         Reviewed by Mark Hahnenberg.
1447         
1448         If svn export fails, just do ditto.
1450         * Scripts/export-llvm-build:
1452 2014-02-04  Carlos Garnacho  <carlosg@gnome.org>
1454         [Automake] Add missing $(feature_defines) when generating InjectedBundle bindings
1455         https://bugs.webkit.org/show_bug.cgi?id=128170
1457         Reviewed by Carlos Garcia Campos.
1459         * WebKitTestRunner/GNUmakefile.am: Add missing $(feature_defines) when
1460         generating the InjectedBundle bindings. So the various ENABLE_* defines
1461         are available there.
1463 2014-02-04  Carlos Garnacho  <carlosg@gnome.org>
1465         [GTK] Ensure generated events have given modifiers GDK understands
1466         https://bugs.webkit.org/show_bug.cgi?id=128171
1468         Reviewed by Carlos Garcia Campos.
1470         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1471         (WTR::webkitModifiersToGDKModifiers): Move around
1472         (WTR::EventSenderProxy::createMouseButtonEvent):
1473         (WTR::EventSenderProxy::keyDown): Use webkitModifiersToGDKModifiers to
1474         translate WKEventModifiers.
1476 2014-02-04  Gabor Rapcsanyi  <rgabor@webkit.org>
1478         Fine tuning the ARM EFL bots
1479         https://bugs.webkit.org/show_bug.cgi?id=128168
1481         Reviewed by Csaba Osztrogonác.
1483         * BuildSlaveSupport/build.webkit.org-config/config.json: Add custom SVN mirror.
1484         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1485         (WaitForSVNServer): Make it not to halt before the first repository checkout.
1486         (WaitForSVNServer.evaluateCommand):
1487         (Factory.__init__): Disable kill-old-processes step on EFL ARM bots, because these
1488         bots run on the same machine and they kill the processes of each other.
1490 2014-02-03  Ryosuke Niwa  <rniwa@webkit.org>
1492         kill-old-processes doesn't kill plugin processes
1493         https://bugs.webkit.org/show_bug.cgi?id=128138
1495         Reviewed by Andreas Kling.
1497         Add plugin process names to the list of processes to kill.
1499         * BuildSlaveSupport/kill-old-processes:
1500         (main):
1502 2014-02-03  Dean Jackson  <dino@apple.com>
1504         Feature flag for shape-inside
1505         https://bugs.webkit.org/show_bug.cgi?id=128001
1507         Reviewed by Simon Fraser.
1509         Add CSS_SHAPE_INSIDE flag, and -css-shape-inside build
1510         flag.
1512         * Scripts/webkitperl/FeatureList.pm:
1514 2014-02-03  Zoltan Horvath  <zoltan@webkit.org>
1516         Unreviewed. Reorder my e-mail addresses in contributors.json,
1517         so bugzilla will auto complete my actual bugzilla username.
1519         * Scripts/webkitpy/common/config/contributors.json:
1521 2014-02-03  Daniel Bates  <dabates@apple.com>
1523         WebKit Bot Watcher's Dashboard: Defer subsequent resource loads from access-restricted build bot when
1524         iteration fails to load with HTTP 401 status code
1525         https://bugs.webkit.org/show_bug.cgi?id=128077
1527         Reviewed by Alexey Proskuryakov.
1529         Similar to the fix for <https://bugs.webkit.org/show_bug.cgi?id=127849>, we should only prompt for
1530         the HTTP credentials of a build bot so long as an earlier authentication request wasn't cancelled
1531         (i.e. failed with an HTTP 401 Unauthorized status code). Currently an authentication dialog will be
1532         presented for an iteration each time the update queue timer fires until a person successfully
1533         authenticates. Instead we should update the authentication status of the build bot on receiving an
1534         HTTP 401 response code such that we defer subsequent requests to load any resource from the access-
1535         restricted build bot when the queue update timer fires.
1537         A person must explicitly click the "unauthorized" status line shown for the queue associated with the
1538         iteration in the dashboard and authenticate successfully for the iteration to be loaded once an
1539         authentication request for an iteration is cancelled.
1541         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1542         (BuildbotIteration.prototype.update): Early return if the associated Buildbot was given invalid credentials.
1543         Also notify the associated Buildbot and update the queue view when a load failed with an HTTP 401 status code.
1544         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
1545         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1546         (BuildbotQueueView): Modified to call BuildbotQueueView.prototype._unauthorizedAccess instead of
1547         QueueView.prototype._updateSoon when event BuildbotQueue.Event.UnauthorizedAccess is received.
1548         (BuildbotQueueView.prototype._unauthorizedAccess): Added.
1550 2014-02-03  Daniel Bates  <dabates@apple.com>
1552         WebKit Bot Watcher's Dashboard: Teach JSON.load() to interpret third argument as either an
1553         option dictionary or a failure callback
1554         https://bugs.webkit.org/show_bug.cgi?id=128080
1556         Reviewed by Alexey Proskuryakov.
1558         Currently JSON.load() takes a failure callback function as its third argument and
1559         an option dictionary as its fourth argument. So, a caller that wants to ignore errors
1560         and pass an option dictionary must pass null or a reference to an empty function for
1561         the value of third argument. Instead, we should make the third argument polymorphic for
1562         convenience. Then a caller can either pass a failure callback function or an option dictionary.
1564         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1566 2014-02-03  Krzysztof Czech  <k.czech@samsung.com>
1568         [ATK] Expose aria-controls through ATK_RELATION_CONTROLLER_FOR
1569         https://bugs.webkit.org/show_bug.cgi?id=127908
1571         Reviewed by Chris Fleizach.
1573         Updated AccessibilityUIElement both in WKTR and DRT so that aria-controls support could be tested properly.
1574         Added empty stubs to not break mac builds.
1576         * DumpRenderTree/AccessibilityUIElement.cpp:
1577         (ariaControlsElementAtIndexCallback):
1578         (AccessibilityUIElement::getJSClass):
1579         * DumpRenderTree/AccessibilityUIElement.h:
1580         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1581         (accessibilityElementAtIndex):
1582         (AccessibilityUIElement::disclosedRowAtIndex):
1583         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1584         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1585         (AccessibilityUIElement::ariaControlsElementAtIndex):
1586         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1587         (AccessibilityUIElement::ariaControlsElementAtIndex):
1588         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1589         (AccessibilityUIElement::ariaControlsElementAtIndex):
1590         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1591         (AccessibilityUIElement::ariaControlsElementAtIndex):
1592         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1593         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1594         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1595         (WTR::accessibilityElementAtIndex):
1596         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1597         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1598         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1599         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1600         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1601         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1602         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1603         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1605 2014-02-02  Daniel Bates  <dabates@apple.com>
1607         WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load
1608         https://bugs.webkit.org/show_bug.cgi?id=127849
1610         I inadvertently used the equality operator instead of the identity operator when comparing the
1611         value of the error HTTP status code with the numeric literal 401.
1613         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1614         (BuildbotQueue.prototype.update):
1616 2014-02-02  Daniel Bates  <dabates@apple.com>
1618         Attempt to fix production dashboard after <http://trac.webkit.org/changeset/163222>
1620         Actually pass option dictionary to JSON.load(); JSON.load() takes four arguments with the
1621         last-most argument being the option dictionary.
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1624         (BuildbotIteration.prototype.update):
1626 2014-02-01  Filip Pizlo  <fpizlo@apple.com>
1628         JSC profiler's stub info profiling support should work again
1629         https://bugs.webkit.org/show_bug.cgi?id=128057
1631         Reviewed by Mark Lam.
1633         * Scripts/display-profiler-output: Just make sure that there's always a space between the origin stack dump and the top bytecode index.
1635 2014-02-01  Filip Pizlo  <fpizlo@apple.com>
1637         JSC profiler should show reasons for jettison
1638         https://bugs.webkit.org/show_bug.cgi?id=128047
1640         Reviewed by Geoffrey Garen.
1641         
1642         Gave the tool a "log" command, that tells you all of the interesting things
1643         that happened to a piece of bytecode, from the standpoint of optimization.
1644         It's a great summary view for seeing how our tier-up machinery works.
1645         
1646         This uses a lot of information that was already available, plus the newly
1647         added jettisonReason field.
1649         * Scripts/display-profiler-output:
1651 2014-01-31  Ryosuke Niwa  <rniwa@webkit.org>
1653         Remove inline member functions of FrameSelection that access m_selection
1654         https://bugs.webkit.org/show_bug.cgi?id=127986
1656         Reviewed by Enrica Casucci.
1658         * TestWebKitAPI/Configurations/Base.xcconfig:
1660 2014-01-31  Anders Carlsson  <andersca@apple.com>
1662         Another attempt at fixing the build.
1664         * TestWebKitAPI/Configurations/Base.xcconfig:
1666 2014-01-31  Oliver Hunt  <oliver@apple.com>
1668         Rollout r163195 and related patches
1670         * DumpRenderTree/CMakeLists.txt:
1671         * WebKitTestRunner/CMakeLists.txt:
1672         * WinCELauncher/CMakeLists.txt:
1674 2014-01-31  Daniel Bates  <dabates@apple.com>
1676         Attempt to fix Production Dashboard after <http://trac.webkit.org/changeset/163213>
1677         (https://bugs.webkit.org/show_bug.cgi?id=127849)
1679         Reviewed by David Farler.
1681         Pass credentials when querying build bot iteration. 
1683         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1684         (BuildbotIteration.prototype.update):
1685         (BuildbotIteration.prototype.loadLayoutTestResults):
1687 2014-01-31  Anders Carlsson  <andersca@apple.com>
1689         Fix iOS build.
1691         * TestWebKitAPI/Configurations/Base.xcconfig:
1693 2014-01-31  Simon Fraser  <simon.fraser@apple.com>
1695         WebKitTestRunner project doesn't show Mac as a valid destination architecture.
1696         
1697         Make sure that SUPPORTED_PLATFORMS is defined in Base.xcconfig.
1698         
1699         Also add BaseTarget.xcconfig to the project.
1701         * WebKitTestRunner/Configurations/Base.xcconfig:
1702         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1704 2014-01-31  Daniel Bates  <dabates@apple.com>
1706         WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load
1707         https://bugs.webkit.org/show_bug.cgi?id=127849
1709         Reviewed by Alexey Proskuryakov.
1711         Currently whenever the dashboard updates the status of a queue whose Buildbot requires authentication
1712         it will cause a browser to prompt for credentials once per update until valid credentials are provided.
1713         Instead we should keep track of Buildbots that respond with an HTTP 401 Unauthorized status code to avoid
1714         subsequently querying them and hence cause a browser to prompt for credentials. Together with an optional
1715         hint provided when instantiating a Buildbot object as to whether it requires authentication, we can make
1716         the dashboard prompt for HTTP credentials exactly once per page load for each queue whose associated
1717         Buildbot requires authentication.
1719         Queues whose Buildbot wasn't authenticated will show in the dashboard as "unauthorized". Clicking on
1720         this status message will cause the browser to prompt for credentials.
1722         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1723         (Buildbot): Initialize instance variable authenticationStatus to Buildbot.AuthenticationStatus.Unauthenticated.
1724         (Buildbot.prototype.get needsAuthentication): Added.
1725         (Buildbot.prototype.get authenticationStatus): Added.
1726         (Buildbot.prototype.get isAuthenticated): Added.
1727         (Buildbot.prototype.set isAuthenticated): Added.
1728         (Buildbot.prototype.updateQueues): Added.
1729         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1730         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Modified to call
1731         BuildbotQueueView.prototype._appendUnauthorizedLineView() to update the view and show status of the queue as
1732         "unauthorized" if the Buildbot associated with the queue is either unauthenticated or was given invalid credentials.
1733         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1734         (BuildbotQueue.prototype.update): Return immediately if the associated Buildbot requires authentication.
1735         Additionally, if the JSON load fails with an HTTP 401 Unauthorized access error (say, credentials were
1736         invalidated) then update the authentication status of the Buildbot to avoid subsequently prompting a
1737         person for credentials the next time the queue update timer fires.
1738         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1739         (BuildbotQueueView): Register as a listener for event BuildbotQueue.Event.UnauthorizedAccess on each queue
1740         so that the view can be updated to show status "unauthorized".
1741         (BuildbotQueueView.prototype._appendUnauthorizedLineView): Added.
1742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1743         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added new status, StatusLineView.Status.Unauthorized.
1745         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1746         (.status-line.unauthorized .bubble): Added.
1747         (.status-line.unauthorized .bubble.pictogram): Added.
1748         (.status-line.unauthorized .message): Added.
1750 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
1752         Unreviewed, really make --copy-libraries a no-able option.
1753         
1754         * Scripts/build-jsc:
1756 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
1758         Unreviewed, really add the --copy-libraries option.
1760         * Scripts/build-jsc:
1762 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
1764         Unreviewed, fix the script for older Rubies.
1766         * Scripts/export-llvm-build:
1768 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
1770         Having a custom LLVM checkout should always override all other ways of getting LLVM
1771         https://bugs.webkit.org/show_bug.cgi?id=128015
1773         Reviewed by Oliver Hunt.
1775         * Scripts/copy-webkitlibraries-to-product-directory:
1777 2014-01-31  Daniel Bates  <dabates@apple.com>
1779         WebKit Bot Watcher's Dashboard: Teach JSON.load() to take optional failure callback function
1780         https://bugs.webkit.org/show_bug.cgi?id=127924
1782         Reviewed by Alexey Proskuryakov.
1784         Towards providing better error handling when a JSON load fails with a non-200 HTTP status
1785         code, we should teach JSON.load() to take an optional failure callback function and invoke
1786         it when either a load error or a JSON parsing error occurs.
1788         As a side benefit of having a failure callback function a caller can separate the error handling
1789         logic for a JSON load or parse error from the logic of handling a successful parsing of JSON content.
1791         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1792         (BuildbotIteration.prototype.loadLayoutTestResults): Move JSON parser error logic into failure
1793         callback function.
1794         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1795         (JSON.load): Modified to take optional failure callback function called failureCallback.
1797 2014-01-29  Oliver Hunt  <oliver@apple.com>
1799         Make it possible to implement JS builtins in JS
1800         https://bugs.webkit.org/show_bug.cgi?id=127887
1802         Reviewed by Michael Saboff.
1804         CMake updates
1806         * DumpRenderTree/CMakeLists.txt:
1807         * WebKitTestRunner/CMakeLists.txt:
1808         * WinCELauncher/CMakeLists.txt:
1810 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
1812         Allow more flexibility for copy-webkitlibraries-to-product-directory
1813         https://bugs.webkit.org/show_bug.cgi?id=128010
1815         Reviewed by Oliver Hunt.
1816         
1817         It's now the case that copy-webkitlibraries-to-product-directory does nothing by
1818         default, but you can tell it to either copy WebKitSystemInterface (--wksi) or LLVM
1819         (--llvm). You can also tell it where to get LLVM from.
1821         * Scripts/build-jsc:
1822         * Scripts/build-webkit:
1823         * Scripts/copy-webkitlibraries-to-product-directory:
1825 2014-01-31  David Farler  <dfarler@apple.com>
1827         DumpRenderTree iOS fails to link: missing rowHeaders and columnHeaders in AccessibilityUIElement
1828         https://bugs.webkit.org/show_bug.cgi?id=128004
1830         Reviewed by Chris Fleizach.
1832         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1833         (AccessibilityUIElement::columnHeaders): Stub added.
1834         (AccessibilityUIElement::rowHeaders): Stub added.
1836 2014-01-31  Zoltan Horvath  <zoltan@webkit.org>
1838         Unreviewed. Update my contributors.json entry.
1840         * Scripts/webkitpy/common/config/contributors.json:
1842 2014-01-31  Anders Carlsson  <andersca@apple.com>
1844         REGRESSION: WebKit2.PageLoadBasic API test is failing
1845         https://bugs.webkit.org/show_bug.cgi?id=127892
1847         Reviewed by Dan Bernstein.
1849         Re-enable test.
1851         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1853 2014-01-31  Csaba Osztrogonác  <ossy@webkit.org>
1855         [jhbuild] Disable escape sequences in EWS output
1856         https://bugs.webkit.org/show_bug.cgi?id=127922
1858         Reviewed by Alexey Proskuryakov.
1860         * Scripts/webkitpy/common/system/environment.py:
1861         (Environment.disable_gcc_smartquotes):
1862         (Environment):
1863         (Environment.disable_jhbuild_VT100_output):
1864         * Scripts/webkitpy/tool/commands/download_unittest.py:
1865         * Scripts/webkitpy/tool/steps/build.py:
1866         (Build.build):
1868 2014-01-30  Martin Robinson  <mrobinson@igalia.com>
1870         [GTK] [CMake] Add support for building against GTK+ 2
1871         https://bugs.webkit.org/show_bug.cgi?id=127959
1873         Reviewed by Anders Carlsson.
1875         * DumpRenderTree/PlatformGTK.cmake: Use the new API version variable and don't use GTK3 directly.
1876         * GtkLauncher/CMakeLists.txt: Ditto.
1877         * ImageDiff/PlatformGTK.cmake: Ditto.
1878         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Ditto.
1880 2014-01-30  Anders Carlsson  <andersca@apple.com>
1882         Add webView:didFinishLoadingNavigation: delegate method
1883         https://bugs.webkit.org/show_bug.cgi?id=127976
1885         Reviewed by Dan Bernstein.
1887         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1888         (-[NavigationDelegate webView:didCommitNavigation:]):
1889         (-[NavigationDelegate webView:didFinishLoadingNavigation:]):
1891 2014-01-30  Anders Carlsson  <andersca@apple.com>
1893         Add a webView:didCommitNavigation: delegate method
1894         https://bugs.webkit.org/show_bug.cgi?id=127972
1896         Reviewed by Dan Bernstein.
1898         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1899         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
1900         (-[NavigationDelegate webView:didCommitNavigation:]):
1902 2014-01-30  Anders Carlsson  <andersca@apple.com>
1904         Add a webView:didFailProvisionalNavigation:withError: delegate method
1905         https://bugs.webkit.org/show_bug.cgi?id=127968
1907         Reviewed by Dan Bernstein.
1909         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1910         (-[DidFailProvisionalNavigationDelegate webView:didStartProvisionalNavigation:]):
1911         (-[DidFailProvisionalNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1912         (TEST):
1914 2014-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1916         The test server build fixes.
1918         * TestResultServer/model/jsonresults.py:
1919         (JsonResults.merge):
1920         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1922 2014-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1924         NRWT shouldn't say "Finished writing JSON files" if it failed to to so
1925         https://bugs.webkit.org/show_bug.cgi?id=127966
1927         Reviewed by Alexey Proskuryakov.
1929         Don't say "Finished writing JSON files" if we had failed to generate the JSON file.
1930         Also explicitly say this is for test results server as we're generating two JSON files.
1932         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1933         (Manager._upload_json_files):
1934         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1935         (JSONLayoutResultsGenerator.__init__): Don't generate JSON file implicitly inside the constructor.
1936         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1937         (JSONResultsGenerator.generate_json_output): Return a boolean indicating whether the generation
1938         had succeeded or not.
1940 2014-01-30  Filip Pizlo  <fpizlo@apple.com>
1942         copy-webkitlibraries-to-product-directory should accept command-line arguments for extra work required for optional features rather than relying on environment variables
1943         https://bugs.webkit.org/show_bug.cgi?id=120221
1945         Reviewed by Mark Hahnenberg.
1947         * Scripts/build-jsc:
1948         * Scripts/build-webkit:
1949         * Scripts/copy-webkitlibraries-to-product-directory:
1951 2014-01-30  Anders Carlsson  <andersca@apple.com>
1953         Add a webView:didStartProvisionalNavigation: delegate method
1954         https://bugs.webkit.org/show_bug.cgi?id=127965
1956         Reviewed by Dan Bernstein.
1958         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1959         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
1960         (TEST):
1962 2014-01-30  Chris Fleizach  <cfleizach@apple.com>
1964         WebKitTestRunner fails to link - missing rowHeaders and columnHeaders
1965         https://bugs.webkit.org/show_bug.cgi?id=127917
1967         Reviewed by Andy Estes.
1969         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1970         (WTR::AccessibilityUIElement::rowHeaders):
1971         (WTR::AccessibilityUIElement::columnHeaders):
1973 2014-01-30  Martin Robinson  <mrobinson@igalia.com>
1975         [GTK] [CMake] Add a "make dist" target
1976         https://bugs.webkit.org/show_bug.cgi?id=116378
1978         Reviewed by Gustavo Noronha Silva.
1980         Added a script that reads a manifest file an produces a tarball. Also add
1981         the manifest.
1983         * gtk/make-dist.py: Added.
1984         * gtk/manifest.txt: Added.
1986 2014-01-30  David Farler  <dfarler@apple.com>
1988         Move OTHER_LDFLAGS erasure to DumpRenderTreeLibrary.xcconfig.
1989         https://bugs.webkit.org/show_bug.cgi?id=127935
1991         Reviewed by Andy Estes.
1993         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1994         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
1995         Move OTHER_LDFLAGS erasure to the static library's xcconfig.
1997 2014-01-30  David Farler  <dfarler@apple.com>
1999         DumpRenderTree fails to build with ASAN: -fsanitize=address passed to static DRT target
2000         https://bugs.webkit.org/show_bug.cgi?id=127935
2002         Reviewed by Andy Estes.
2004         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2005         Clear OTHER_LDFLAGS at the project level for the static library target.
2006         No other linker flags were inherited from DebugRelease.
2008 2014-01-30  David Farler  <dfarler@apple.com>
2010         package-root shouldn't prefix simulator roots with the SDK path
2011         http://bugs.webkit.org/show_bug.cgi?id=127923
2013         Reviewed by Dan Bernstein.
2015         * Scripts/package-root: Don't add an install path prefix.
2017 2014-01-30  Gabor Rapcsanyi  <rgabor@webkit.org>
2019         Add ARM EFL Linux builder bots to Apple buildmaster
2020         https://bugs.webkit.org/show_bug.cgi?id=127472
2022         Reviewed by Csaba Osztrogonác.
2024         There is no ARM buildslaves after removing the Qt builders.
2026         * BuildSlaveSupport/build.webkit.org-config/config.json:
2028 2014-01-30  Andy Estes  <aestes@apple.com>
2030         REGRESSION (r163037): WebKit2.PageLoadBasic API test failing on Mountain Lion
2031         https://bugs.webkit.org/show_bug.cgi?id=127934
2033         Disable the failing test on Mountain Lion.
2035         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2036         (TestWebKitAPI::TEST):
2038 2014-01-30  Anders Carlsson  <andersca@apple.com>
2040         Add WKNavigationDelegate class
2041         https://bugs.webkit.org/show_bug.cgi?id=127927
2043         Reviewed by Dan Bernstein.
2045         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2046         (TEST):
2048 2014-01-30  David Farler  <dfarler@apple.com>
2050         Enable iOS Tools builds by default
2051         https://bugs.webkit.org/show_bug.cgi?id=127919
2053         Reviewed by Andy Estes.
2055         * Makefile:
2056         Build all the tools except MiniBrowser on iOS
2057         * Scripts/build-webkit:
2058         Ditto.
2059         Build WebKitTestRunnerApp target on iOS.
2061 2014-01-30  David Farler  <dfarler@apple.com>
2063         Make TestWebKitAPI build and run for iOS
2064         https://bugs.webkit.org/show_bug.cgi?id=127925
2066         Reviewed by Andy Estes.
2068         * TestWebKitAPI/Configurations/Base.xcconfig:
2069         - Don't warn on 64-32 bit conversion on x86_64 and arm64
2070         - Don't build mac/*
2071         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2072         - Link WebKit2 on all platforms
2074 2014-01-30  David Farler  <dfarler@apple.com>
2076         package-root should copy ./usr from the build products directory
2077         https://bugs.webkit.org/show_bug.cgi?id=127878
2079         Reviewed by Daniel Bates.
2081         * Scripts/package-root:
2082         Copy ./usr in addition to the frameworks.
2084 2014-01-30  Andrei Bucur  <abucur@adobe.com>
2086         Remove the ACCELERATED_COMPOSITING flag
2087         https://bugs.webkit.org/show_bug.cgi?id=127833
2089         Reviewed by Antti Koivisto.
2091         Remove the USE(ACCELERATED_COMPOSITING) conditionals from the code base and make AC
2092         mandatory.
2094         * DumpRenderTree/efl/DumpRenderTree.cpp:
2095         (initEcoreEvas):
2096         * EWebLauncher/main.c:
2097         (windowCreate):
2098         * MiniBrowser/efl/main.c:
2099         (elm_main):
2100         * TestWebKitAPI/efl/PlatformWebView.cpp:
2101         (TestWebKitAPI::initEcoreEvas):
2102         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2103         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2104         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2105         (WTR::initEcoreEvas):
2107 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
2109         Remove ENABLE(JAVASCRIPT_DEBUGGER) leftovers
2110         https://bugs.webkit.org/show_bug.cgi?id=127845
2112         Reviewed by Joseph Pecoraro.
2114         * Scripts/webkitperl/FeatureList.pm:
2116 2014-01-29  Anders Carlsson  <andersca@apple.com>
2118         -[WKWebView loadRequest:] should return a WKNavigation
2119         https://bugs.webkit.org/show_bug.cgi?id=127873
2121         Reviewed by Dan Bernstein.
2123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2124         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm: Added.
2125         (TEST):
2127 2014-01-29  Tim Horton  <timothy_horton@apple.com>
2129         WebKit2 View Gestures (Swipe): Update rubberBandsAt{Left,Right} when WebKit swipe is enabled
2130         https://bugs.webkit.org/show_bug.cgi?id=127855
2131         <rdar://problem/15933878>
2133         Reviewed by Anders Carlsson.
2135         * MiniBrowser/mac/WK2BrowserWindowController.m:
2136         (-[WK2BrowserWindowController awakeFromNib]):
2137         Enable swipe in MiniBrowser for testing purposes.
2139 2014-01-29  Daniel Bates  <dabates@apple.com>
2141         Fix JSONP requests made by the WebKit Bot Watcher's Dashboard following <http://trac.webkit.org/changeset/163034>
2142         (https://bugs.webkit.org/show_bug.cgi?id=127784)
2144         Use dot-notation instead of array index notation to access the dictionary value for key jsonpCallbackName
2145         in the specified options dictionary.
2147         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2148         (JSON.load):
2150 2014-01-29  Daniel Bates  <dabates@apple.com>
2152         WebKit Bot Watcher's Dashboard: Add support for using HTTP authentication with Buildbot
2153         https://bugs.webkit.org/show_bug.cgi?id=127784
2155         Reviewed by Alexey Proskuryakov.
2157         Implement support for querying a Buildbot that requires HTTP authentication to access it.
2159         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2160         (Buildbot): Add optional argument, options, to pass a dictionary of Buildbot options.
2161         For now, we only support a single option, needsAuthentication, to indicate whether the
2162         Buildbots requires HTTP authentication (defaults to false - HTTP authentication is
2163         not required).
2164         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2165         (BuildbotIteration.prototype.loadLayoutTestResults): Modified to pass JSONP callback name
2166         to JSON.load() using the option dictionary.
2167         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2168         (BuildbotQueue.prototype.update): Modified to pass withCredentials to JSON.load().
2169         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2170         (JSON.load): Removed optional argument jsonpCallbackName and added optional argument options,
2171         which is a dictionary. The argument jsonpCallbackName is now specified as an entry in the
2172         options dictionary. Added boolean options withCredentials to toggle querying with HTTP
2173         authentication credentials.
2175 2014-01-29  Alexey Proskuryakov  <ap@apple.com>
2177         build.webkit.org/dashboard links to an old failing build rather than the most recent
2178         https://bugs.webkit.org/show_bug.cgi?id=127765
2179         <rdar://problem/15795228>
2181         Reviewed by Timothy Hatcher.
2183         This patch changes builder view to not show how many failures there were in a row,
2184         because it is not very relevant, and complicates the UI. Instead, we just show the
2185         latest failing build and the latest successful one.
2187         The patch also removes commit history popovers from revisions that can not be correlated
2188         with any change. These popovers are only helpful in the first line, when there is
2189         another line for comparison below. In this case, it's useful to see what changed
2190         between the revisions, but even then, only if it was an actual failure, not a buildbot
2191         exception.
2193         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2194         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
2195         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2197         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
2198         (BuildbotQueueView.prototype._revisionPopoverContentForIteration):
2199         (BuildbotQueueView.prototype.revisionContentForIteration):
2200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2201         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2203 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
2205         Remove ENABLE(JAVASCRIPT_DEBUGGER) guards
2206         https://bugs.webkit.org/show_bug.cgi?id=127840
2208         Reviewed by Mark Lam.
2210         * Scripts/webkitperl/FeatureList.pm:
2212 2014-01-29  Krzysztof Czech  <k.czech@samsung.com>
2214         [ATK] Expose aria-describedby with ATK_RELATION_DESCRIBED_BY
2215         https://bugs.webkit.org/show_bug.cgi?id=121684
2217         Reviewed by Mario Sanchez Prada.
2219         Implementing helpText by using relation ATK_RELATION_DESCRIBED_BY.
2221         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2222         (AccessibilityUIElement::helpText):
2223         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2224         (WTR::AccessibilityUIElement::helpText):
2226 2014-01-27  Chris Fleizach  <cfleizach@apple.com>
2228         AX: Support @scope in HTML tables
2229         https://bugs.webkit.org/show_bug.cgi?id=127688
2231         Reviewed by Mario Sanchez Prada.
2233         Add support for rowHeaders and columnHeaders.
2235         * DumpRenderTree/AccessibilityUIElement.cpp:
2236         (convertElementsToObjectArray):
2237         (columnHeadersCallback):
2238         (rowHeadersCallback):
2239         (uiElementArrayAttributeValueCallback):
2240         (AccessibilityUIElement::columnHeaders):
2241         (AccessibilityUIElement::rowHeaders):
2242         (AccessibilityUIElement::getJSClass):
2243         * DumpRenderTree/AccessibilityUIElement.h:
2244         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2245         (AccessibilityUIElement::rowHeaders):
2246         (AccessibilityUIElement::columnHeaders):
2247         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2248         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2249         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2250         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
2251         (WTR::AccessibilityUIElement::rowHeaders):
2252         (WTR::AccessibilityUIElement::columnHeaders):
2253         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2254         (WTR::convertElementsToObjectArray):
2255         (WTR::AccessibilityUIElement::rowHeaders):
2256         (WTR::AccessibilityUIElement::columnHeaders):
2257         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
2259 2014-01-28  Daniel Bates  <dabates@apple.com>
2261         Teach Buildbot dashboard to parse alternative revision format
2262         https://bugs.webkit.org/show_bug.cgi?id=127561
2264         Reviewed by Alexey Proskuryakov.
2266         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
2267         returns a dictionary for the value of property got_revision.
2269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2270         (isMultiCodebaseGotRevisionProperty): Added.
2271         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
2272         string or a dictionary.
2273         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
2274         the OpenSource and Internal revision numbers.
2276 2014-01-28  Adrian Perez de Castro  <aperez@igalia.com>
2278         [GTK] Add API to allow setting the process model in WebKitWebContext
2279         https://bugs.webkit.org/show_bug.cgi?id=125463
2281         Reviewed by Carlos Garcia Campos.
2283         Implements accessors in WebKitWebContext for the process model.
2284         The default behavior is unchanged, and a single web process is
2285         used. Using WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
2286         as the process model will make use one web process for each
2287         WebKitWebView. This also enables the network process. Setting
2288         the process model must be done as early as possible, before the
2289         very first web process is spawned.
2291         * MiniBrowser/gtk/main.c:
2292         (main):
2293         Enable multiple process mode if the MINIBROWSER_MULTIPROCESS
2294         environment variable is defined and not empty.
2295         * TestWebKitAPI/GNUmakefile.am:
2296         Add new TestMultiprocess test case.
2297         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2298         Add new TestMultiprocess test case.
2299         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: Added.
2300         (loadChanged):
2301         (testMultipleSecondaryProcesses):
2302         (initializeWebExtensions):
2303         (beforeAll):
2304         (afterAll):
2305         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2306         (methodCallCallback):
2307         Implement the GetProcessIdentifier D-Bus method.
2308         (makeBusName):
2309         Choose a different bus name when the web extension is used
2310         from TestMultiprocess.
2311         (webkit_web_extension_initialize_with_user_data):
2312         Use makeBusName() to choose the bus name.
2314 2014-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2316         [SOUP] Remove soupURIToKURL
2317         https://bugs.webkit.org/show_bug.cgi?id=127104
2319         Reviewed by Martin Robinson.
2321         * TestWebKitAPI/GNUmakefile.am: Add soup cppflags to WebCore unit
2322         tests, because URL.h now includes GUniquePtrSoup.h.
2323         * TestWebKitAPI/CMakeLists.txt: Ditto.
2324         * WebKitTestRunner/PlatformEfl.cmake: Add soup cppflags to WTR,
2325         because URL.h now includes GUniquePtrSoup.h.
2327 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2329         [GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
2330         https://bugs.webkit.org/show_bug.cgi?id=127614
2332         Reviewed by Gustavo Noronha Silva.
2334         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Bring
2335         back the custom URI scheme WebView check.
2337 2014-01-27  Tim Horton  <timothy_horton@apple.com>
2339         Revert yet one more tiny part of r162629 that didn't get reverted in r162883
2341         * WebKitTestRunner/TestController.cpp:
2342         (WTR::TestController::pluginLoadPolicy):
2343         * WebKitTestRunner/TestController.h:
2345 2014-01-27  Tim Horton  <timothy_horton@apple.com>
2347         Revert one more tiny part of r162629 that didn't get reverted in r162883.
2349         ... which was also causing test failures!
2351         * WebKitTestRunner/TestController.cpp:
2352         (WTR::TestController::createWebViewWithOptions):
2354 2014-01-27  David Farler  <dfarler@apple.com>
2356         iOS DumpRenderTree.app dies loading fonts
2357         https://bugs.webkit.org/show_bug.cgi?id=127730
2359         Reviewed by Daniel Bates.
2361         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2362         - Add Ahem to the __DATA section
2363         * DumpRenderTree/mac/DumpRenderTree.mm:
2364         (activateFontsIOS):
2365         - Load "WeightWatcher100" instead.
2367 2014-01-27  Alexey Proskuryakov  <ap@apple.com>
2369         [Mac] Extra logging output from run-safari --no-saved-state
2370         https://bugs.webkit.org/show_bug.cgi?id=127732
2372         Reviewed by Daniel Bates.
2374         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): Use an option that
2375         disables saved state without logging.
2377 2014-01-27  Tim Horton  <timothy_horton@apple.com>
2379         Revert the parts of r162629 that add a new pluginLoadPolicy and the context menu item.
2381         We're leaving the parts that make us use PDFPlugin instead of showing the blocked
2382         plugin indicator intact, though.
2384         * WebKitTestRunner/TestController.cpp:
2385         (WTR::TestController::createWebViewWithOptions):
2387 2014-01-27  Andy Estes  <aestes@apple.com>
2389         Scrub WebKit API headers of WTF macros
2390         https://bugs.webkit.org/show_bug.cgi?id=127706
2392         Reviewed by David Kilzer.
2394         * Scripts/check-for-inappropriate-macros-in-external-headers: Modified
2395         the regex to require a '(' after the macro name in order to be
2396         considered a match. This prevents things like 'ENABLE_SOME_FEATURE'
2397         from being flagged as an ENABLE() macro.
2399 2014-01-27  Commit Queue  <commit-queue@webkit.org>
2401         Unreviewed, rolling out r162846.
2402         http://trac.webkit.org/changeset/162846
2403         https://bugs.webkit.org/show_bug.cgi?id=127695
2405         "Broke the WebKit Bot Watcher's Dashboard; will fix offline"
2406         (Requested by dydz on #webkit).
2408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2409         (BuildbotIteration.prototype.update.):
2411 2014-01-27  Daniel Bates  <dabates@apple.com>
2413         Add support for displaying results from multiple Buildbots on WebKit Bot Watcher's Dashboard
2414         https://bugs.webkit.org/show_bug.cgi?id=127564
2416         Reviewed by Alexey Proskuryakov.
2418         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2419         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2421 2014-01-27  Daniel Bates  <dabates@apple.com>
2423         Teach Buildbot dashboard to parse alternative revision format
2424         https://bugs.webkit.org/show_bug.cgi?id=127561
2426         Reviewed by Alexey Proskuryakov.
2428         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
2429         returns a dictionary for the value of property got_revision.
2431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2432         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
2433         string or a dictionary.
2434         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
2435         the OpenSource and Internal revision numbers.
2437 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2439         [GTK] Implement custom URI schemes with CustomProtocols
2440         https://bugs.webkit.org/show_bug.cgi?id=127091
2442         Reviewed by Gustavo Noronha Silva.
2444         Temporarily disable the WebKitWebView check until we figure out
2445         how to implement it with CustomProtocols.
2447         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2449 2014-01-26  Alexey Proskuryakov  <ap@apple.com>
2451         REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.
2453         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):
2454         Fixed an incorrect ifdef.
2456 2014-01-26  Brendan Long  <b.long@cablelabs.com>
2458         [GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
2459         https://bugs.webkit.org/show_bug.cgi?id=110602
2461         Reviewed by Philippe Normand.
2463         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2464         (getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
2465         (initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).
2467 2014-01-24  Andy Estes  <aestes@apple.com>
2469         [iOS] Upstream changes in Tools/DumpRenderTree
2470         https://bugs.webkit.org/show_bug.cgi?id=127412
2472         Reviewed by Simon Fraser.
2474         Upstream all iOS changes. Added a new target called DumpRenderTree.app,
2475         which builds the DumpRenderTree static library into an app bundle as
2476         expected by the iOS Simulator.
2478         * DumpRenderTree/AccessibilityTextMarker.h:
2479         * DumpRenderTree/AccessibilityUIElement.h:
2480         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2481         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
2482         * DumpRenderTree/DumpRenderTreePrefix.h:
2483         * DumpRenderTree/PixelDumpSupport.cpp:
2484         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2485         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2486         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
2487         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2488         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2489         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2490         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
2491         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
2492         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
2493         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2494         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
2495         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
2496         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
2497         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2498         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
2499         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2500         * DumpRenderTree/TestRunner.cpp:
2501         * DumpRenderTree/TestRunner.h:
2502         * DumpRenderTree/cg/ImageDiffCG.cpp:
2503         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2504         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2505         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2506         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
2507         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
2508         * DumpRenderTree/ios/Info.plist: Added.
2509         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
2510         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
2511         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
2512         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
2513         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
2514         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
2515         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
2516         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
2517         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
2518         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
2519         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
2520         * DumpRenderTree/ios/PerlSupport/Makefile: Added.
2521         * DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
2522         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2523         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2524         * DumpRenderTree/mac/AppleScriptController.m:
2525         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2526         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2527         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2528         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
2529         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
2530         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2531         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
2532         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2533         * DumpRenderTree/mac/DumpRenderTree.mm:
2534         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2535         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2536         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2537         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2538         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2539         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2540         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2541         * DumpRenderTree/mac/EditingDelegate.h:
2542         * DumpRenderTree/mac/EventSendingController.h:
2543         * DumpRenderTree/mac/EventSendingController.mm:
2544         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2545         * DumpRenderTree/mac/HistoryDelegate.h:
2546         * DumpRenderTree/mac/LayoutTestHelper.m:
2547         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2548         * DumpRenderTree/mac/NavigationController.h:
2549         * DumpRenderTree/mac/ObjCPlugin.h:
2550         * DumpRenderTree/mac/ObjCPlugin.m:
2551         * DumpRenderTree/mac/ObjCPluginFunction.h:
2552         * DumpRenderTree/mac/PolicyDelegate.h:
2553         * DumpRenderTree/mac/ResourceLoadDelegate.h:
2554         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2555         * DumpRenderTree/mac/TestRunnerMac.mm:
2556         * DumpRenderTree/mac/TextInputController.h:
2557         * DumpRenderTree/mac/TextInputController.m:
2558         * DumpRenderTree/mac/UIDelegate.h:
2559         * DumpRenderTree/mac/UIDelegate.mm:
2561 2014-01-25  Darin Adler  <darin@apple.com>
2563         Call deprecatedCharacters instead of characters at more call sites
2564         https://bugs.webkit.org/show_bug.cgi?id=127631
2566         Reviewed by Sam Weinig.
2568         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2569         (TestWebKitAPI::expectBuilderContent):
2570         (TestWebKitAPI::expectEmpty):
2571         (TestWebKitAPI::TEST):
2572         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2573         (TestWebKitAPI::TEST):
2574         Use the new name.
2576 2014-01-25  Anders Carlsson  <andersca@apple.com>
2578         Modernize HashTable threading code
2579         https://bugs.webkit.org/show_bug.cgi?id=127621
2581         Reviewed by Darin Adler.
2583         Explicitly include headers that used to be brought in by HashTable.h
2585         * DumpRenderTree/JavaScriptThreading.cpp:
2587 2014-01-24  Eric Carlson  <eric.carlson@apple.com>
2589         Unreviewed. Add Philip Jägenstedt to watch and contributor lists.
2591         * Scripts/webkitpy/common/config/contributors.json:
2592         * Scripts/webkitpy/common/config/watchlist:
2594 2014-01-23  David Farler  <dfarler@apple.com>
2596         Make WebKitTestRunner work with iOS
2597         https://bugs.webkit.org/show_bug.cgi?id=127448
2599         Reviewed by Simon Fraser.
2601         Combined patch from Simon below with some additional xcconfig cleanups,
2602         rebasing and stubbing out a couple of new functions that popped up
2603         since then.
2605         2013-12-03  Simon Fraser  <simon.fraser@apple.com>
2607                 <rdar://problem/15515469> Get WebKitTestRunner working on iOS
2609                 Get WebKitTestRunner limping on iOS. Main parts:
2610                 - Stub out lots of accessibility-related functions.
2611                 - Stub out EventSender
2612                 - Create target to make a bundled app that runs in the simulator,
2613                   and copy the injected bundle library into it.
2614                 - Make a UIWindow and WKView to load tests in
2616                 It runs, load tests, and dumps results to output. More work will be
2617                 required once we can execute it via the webkitpy scripts.
2619         * WebKitTestRunner/Configurations/Base.xcconfig:
2620         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2621         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2622         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2623         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: Added.
2624         (WTR::AccessibilityController::addNotificationListener):
2625         (WTR::AccessibilityController::removeNotificationListener):
2626         (WTR::AccessibilityController::platformName):
2627         (WTR::AccessibilityController::logAccessibilityEvents):
2628         (WTR::AccessibilityController::resetToConsistentState):
2629         (WTR::findAccessibleObjectById):
2630         (WTR::AccessibilityController::accessibleElementById):
2631         * WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h: Added.
2632         * WebKitTestRunner/InjectedBundle/ios/AccessibilityTextMarkerIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
2633         (WTR::AccessibilityTextMarker::isEqual):
2634         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: Added.
2635         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2636         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
2637         (WTR::AccessibilityUIElement::isEqual):
2638         (WTR::AccessibilityUIElement::getLinkedUIElements):
2639         (WTR::AccessibilityUIElement::getDocumentLinks):
2640         (WTR::AccessibilityUIElement::getChildren):
2641         (WTR::AccessibilityUIElement::getChildrenWithRange):
2642         (WTR::AccessibilityUIElement::childrenCount):
2643         (WTR::AccessibilityUIElement::elementAtPoint):
2644         (WTR::AccessibilityUIElement::indexOfChild):
2645         (WTR::AccessibilityUIElement::childAtIndex):
2646         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2647         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2648         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2649         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2650         (WTR::AccessibilityUIElement::rowAtIndex):
2651         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2652         (WTR::AccessibilityUIElement::selectedChildrenCount):
2653         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2654         (WTR::AccessibilityUIElement::titleUIElement):
2655         (WTR::AccessibilityUIElement::parentElement):
2656         (WTR::AccessibilityUIElement::disclosedByRow):
2657         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2658         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
2659         (WTR::AccessibilityUIElement::attributesOfChildren):
2660         (WTR::AccessibilityUIElement::allAttributes):
2661         (WTR::AccessibilityUIElement::stringAttributeValue):
2662         (WTR::AccessibilityUIElement::numberAttributeValue):
2663         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
2664         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2665         (WTR::AccessibilityUIElement::boolAttributeValue):
2666         (WTR::AccessibilityUIElement::isAttributeSettable):
2667         (WTR::AccessibilityUIElement::isAttributeSupported):
2668         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
2669         (WTR::AccessibilityUIElement::role):
2670         (WTR::AccessibilityUIElement::subrole):
2671         (WTR::AccessibilityUIElement::roleDescription):
2672         (WTR::AccessibilityUIElement::title):
2673         (WTR::AccessibilityUIElement::description):
2674         (WTR::AccessibilityUIElement::orientation):
2675         (WTR::AccessibilityUIElement::stringValue):
2676         (WTR::AccessibilityUIElement::language):
2677         (WTR::AccessibilityUIElement::helpText):
2678         (WTR::AccessibilityUIElement::x):
2679         (WTR::AccessibilityUIElement::y):
2680         (WTR::AccessibilityUIElement::width):
2681         (WTR::AccessibilityUIElement::height):
2682         (WTR::AccessibilityUIElement::clickPointX):
2683         (WTR::AccessibilityUIElement::clickPointY):
2684         (WTR::AccessibilityUIElement::intValue):
2685         (WTR::AccessibilityUIElement::minValue):
2686         (WTR::AccessibilityUIElement::maxValue):
2687         (WTR::AccessibilityUIElement::valueDescription):
2688         (WTR::AccessibilityUIElement::insertionPointLineNumber):
2689         (WTR::AccessibilityUIElement::isPressActionSupported):
2690         (WTR::AccessibilityUIElement::isIncrementActionSupported):
2691         (WTR::AccessibilityUIElement::isDecrementActionSupported):
2692         (WTR::AccessibilityUIElement::isEnabled):
2693         (WTR::AccessibilityUIElement::isRequired):
2694         (WTR::AccessibilityUIElement::isFocused):
2695         (WTR::AccessibilityUIElement::isSelected):
2696         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2697         (WTR::AccessibilityUIElement::isIndeterminate):
2698         (WTR::AccessibilityUIElement::isExpanded):
2699         (WTR::AccessibilityUIElement::isChecked):
2700         (WTR::AccessibilityUIElement::hierarchicalLevel):
2701         (WTR::AccessibilityUIElement::classList):
2702         (WTR::AccessibilityUIElement::speak):
2703         (WTR::AccessibilityUIElement::ariaIsGrabbed):
2704         (WTR::AccessibilityUIElement::ariaDropEffects):
2705         (WTR::AccessibilityUIElement::lineForIndex):
2706         (WTR::AccessibilityUIElement::rangeForLine):
2707         (WTR::AccessibilityUIElement::rangeForPosition):
2708         (WTR::AccessibilityUIElement::boundsForRange):
2709         (WTR::AccessibilityUIElement::stringForRange):
2710         (WTR::AccessibilityUIElement::attributedStringForRange):
2711         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2712         (WTR::uiElementCountForSearchPredicate):
2713         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2714         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2715         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2716         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2717         (WTR::AccessibilityUIElement::attributesOfColumns):
2718         (WTR::AccessibilityUIElement::attributesOfRows):
2719         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2720         (WTR::AccessibilityUIElement::attributesOfHeader):
2721         (WTR::AccessibilityUIElement::rowCount):
2722         (WTR::AccessibilityUIElement::columnCount):
2723         (WTR::AccessibilityUIElement::indexInTable):
2724         (WTR::AccessibilityUIElement::rowIndexRange):
2725         (WTR::AccessibilityUIElement::columnIndexRange):
2726         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2727         (WTR::AccessibilityUIElement::horizontalScrollbar):
2728         (WTR::AccessibilityUIElement::verticalScrollbar):
2729         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2730         (WTR::AccessibilityUIElement::selectedTextRange):
2731         (WTR::AccessibilityUIElement::setSelectedTextRange):
2732         (WTR::AccessibilityUIElement::increment):
2733         (WTR::AccessibilityUIElement::decrement):
2734         (WTR::AccessibilityUIElement::showMenu):
2735         (WTR::AccessibilityUIElement::press):
2736         (WTR::AccessibilityUIElement::setSelectedChild):
2737         (WTR::AccessibilityUIElement::accessibilityValue):
2738         (WTR::AccessibilityUIElement::documentEncoding):
2739         (WTR::AccessibilityUIElement::documentURI):
2740         (WTR::AccessibilityUIElement::url):
2741         (WTR::AccessibilityUIElement::addNotificationListener):
2742         (WTR::AccessibilityUIElement::removeNotificationListener):
2743         (WTR::AccessibilityUIElement::isFocusable):
2744         (WTR::AccessibilityUIElement::isSelectable):
2745         (WTR::AccessibilityUIElement::isMultiSelectable):
2746         (WTR::AccessibilityUIElement::isVisible):
2747         (WTR::AccessibilityUIElement::isOffScreen):
2748         (WTR::AccessibilityUIElement::isCollapsed):
2749         (WTR::AccessibilityUIElement::isIgnored):
2750         (WTR::AccessibilityUIElement::hasPopup):
2751         (WTR::AccessibilityUIElement::takeFocus):
2752         (WTR::AccessibilityUIElement::takeSelection):
2753         (WTR::AccessibilityUIElement::addSelection):
2754         (WTR::AccessibilityUIElement::removeSelection):
2755         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2756         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2757         (WTR::AccessibilityUIElement::previousTextMarker):
2758         (WTR::AccessibilityUIElement::nextTextMarker):
2759         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2760         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2761         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2762         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2763         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2764         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
2765         (WTR::AccessibilityUIElement::textMarkerForPoint):
2766         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2767         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2768         (WTR::AccessibilityUIElement::indexForTextMarker):
2769         (WTR::AccessibilityUIElement::isTextMarkerValid):
2770         (WTR::AccessibilityUIElement::textMarkerForIndex):
2771         (WTR::AccessibilityUIElement::startTextMarker):
2772         (WTR::AccessibilityUIElement::endTextMarker):
2773         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2774         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2775         (WTR::AccessibilityUIElement::pathDescription):
2776         (WTR::AccessibilityUIElement::supportedActions):
2777         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
2778         (WTR::activateFonts):
2779         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm: Added.
2780         (WTR::EventSenderProxy::EventSenderProxy):
2781         (WTR::EventSenderProxy::~EventSenderProxy):
2782         (WTR::EventSenderProxy::updateClickCountForButton):
2783         (WTR::EventSenderProxy::mouseDown):
2784         (WTR::EventSenderProxy::mouseUp):
2785         (WTR::EventSenderProxy::mouseMoveTo):
2786         (WTR::EventSenderProxy::leapForward):
2787         (WTR::EventSenderProxy::keyDown):
2788         (WTR::EventSenderProxy::mouseScrollBy):
2789         (WTR::EventSenderProxy::continuousMouseScrollBy):
2790         (WTR::EventSenderProxy::addTouchPoint):
2791         (WTR::EventSenderProxy::updateTouchPoint):
2792         (WTR::EventSenderProxy::setTouchModifier):
2793         (WTR::EventSenderProxy::setTouchPointRadius):
2794         (WTR::EventSenderProxy::touchStart):
2795         (WTR::EventSenderProxy::touchMove):
2796         (WTR::EventSenderProxy::touchEnd):
2797         (WTR::EventSenderProxy::touchCancel):
2798         (WTR::EventSenderProxy::clearTouchPoints):
2799         (WTR::EventSenderProxy::releaseTouchPoint):
2800         (WTR::EventSenderProxy::cancelTouchPoint):
2801         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
2802         (WTR::InjectedBundle::platformInitialize):
2803         * WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
2804         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
2805         * WebKitTestRunner/Makefile:
2806         * WebKitTestRunner/TestController.cpp:
2807         (WTR::TestController::initialize):
2808         * WebKitTestRunner/TestController.h:
2809         * WebKitTestRunner/TestInvocation.cpp:
2810         (WTR::TestInvocation::invoke):
2811         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2812         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2813         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Added.
2814         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Added.
2815         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
2816         (-[AppDelegate applicationWillResignActive:]):
2817         (-[AppDelegate applicationDidEnterBackground:]):
2818         (-[AppDelegate applicationWillEnterForeground:]):
2819         (-[AppDelegate applicationDidBecomeActive:]):
2820         (-[AppDelegate applicationWillTerminate:]):
2821         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/AppIcon.appiconset/Contents.json: Added.
2822         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/LaunchImage.launchimage/Contents.json: Added.
2823         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Added.
2824         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Prefix.pch: Added.
2825         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Added.
2826         * WebKitTestRunner/WebKitTestRunnerApp/main.m: Added.
2827         (main):
2828         * WebKitTestRunner/WebKitTestRunnerAppTests-Info.plist: Added.
2829         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Added.
2830         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Added.
2831         (-[WebKitTestRunnerAppTests setUp]):
2832         (-[WebKitTestRunnerAppTests tearDown]):
2833         (-[WebKitTestRunnerAppTests testExample]):
2834         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Added.
2835         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2836         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2837         * WebKitTestRunner/iOS.xcconfig: Added.
2838         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Added.
2839         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
2840         (-[TestRunnerWKView _shouldUseTiledDrawingArea]):
2841         (-[WebKitTestRunnerWindow isKeyWindow]):
2842         (-[WebKitTestRunnerWindow setFrameOrigin:]):
2843         (-[WebKitTestRunnerWindow setFrame:]):
2844         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
2845         (-[WebKitTestRunnerWindow backingScaleFactor]):
2846         (WTR::PlatformWebView::PlatformWebView):
2847         (WTR::PlatformWebView::resizeTo):
2848         (WTR::PlatformWebView::~PlatformWebView):
2849         (WTR::PlatformWebView::page):
2850         (WTR::PlatformWebView::focus):
2851         (WTR::PlatformWebView::windowFrame):
2852         (WTR::PlatformWebView::setWindowFrame):
2853         (WTR::PlatformWebView::didInitializeClients):
2854         (WTR::PlatformWebView::addChromeInputField):
2855         (WTR::PlatformWebView::removeChromeInputField):
2856         (WTR::PlatformWebView::makeWebViewFirstResponder):
2857         (WTR::PlatformWebView::windowSnapshotImage):
2858         (WTR::PlatformWebView::viewSupportsOptions):
2859         * WebKitTestRunner/ios/TestControllerIOS.mm: Added.
2860         (WTR::TestController::notifyDone):
2861         (WTR::TestController::platformInitialize):
2862         (WTR::TestController::platformDestroy):
2863         (WTR::TestController::initializeInjectedBundlePath):
2864         (WTR::TestController::initializeTestPluginDirectory):
2865         (WTR::TestController::platformRunUntil):
2866         (WTR::TestController::platformInitializeContext):
2867         (WTR::TestController::runModal):
2868         (WTR::TestController::platformLibraryPathForTesting):
2869         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
2870         (createCFURLResponseFromResponseData):
2871         (supportedNonImageMIMETypes):
2872         * WebKitTestRunner/ios/mainIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
2873         (-[WebKitTestRunnerApp _runTestController]):
2874         (-[WebKitTestRunnerApp applicationDidFinishLaunching:]):
2875         (main):
2877 2014-01-24  Enrique Ocaña González  <eocanha@igalia.com>
2879         [GTK] Put cache files in XDG_CACHE_HOME
2880         https://bugs.webkit.org/show_bug.cgi?id=123458
2882         Reviewed by Martin Robinson.
2884         * GtkLauncher/main.c:
2885         (createBrowser):
2887 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
2889         Remove CSS Custom Filters code and tests
2890         https://bugs.webkit.org/show_bug.cgi?id=127382
2892         Reviewed by Simon Fraser.
2894         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2895         (resetDefaultsToConsistentValues):
2896         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2897         (TestRunner::overridePreference):
2899 2014-01-23  Tim Horton  <timothy_horton@apple.com>
2901         PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
2902         https://bugs.webkit.org/show_bug.cgi?id=127415
2903         <rdar://problem/12482452>
2905         Reviewed by Sam Weinig.
2907         Adopt the new page loader client plugin load callback.
2909         * WebKitTestRunner/TestController.cpp:
2910         (WTR::TestController::createWebViewWithOptions):
2911         (WTR::TestController::pluginLoadPolicy):
2912         * WebKitTestRunner/TestController.h:
2914 2014-01-23  peavo@outlook.com  <peavo@outlook.com>
2916         [Curl] There is no way to specify cache folder.
2917         https://bugs.webkit.org/show_bug.cgi?id=125028
2919         Reviewed by Brent Fulgham.
2921         Enable disc cache in WinLauncher by setting cache folder location.
2923         * WinLauncher/WinLauncher.cpp:
2924         (getAppDataFolder): Added function to get app data folder.
2925         (setCacheFolder): Added function to set cache folder.
2926         (createCrashReport): Use new getAppDataFolder function.
2927         (wWinMain): Use function setCacheFolder to set cache folder location.
2929 2014-01-23  Daniel Bates  <dabates@apple.com>
2931         build-webkit --sdk=iphonesimulator doesn't think it's building iOS
2932         https://bugs.webkit.org/show_bug.cgi?id=127379
2934         Reviewed by Simon Fraser.
2936         Teach build-webkit to recognize --sdk=X.
2938         Currently, build-webkit recognizes --sdk X to specify X as the Xcode SDK to use, which is also
2939         considered when determining the WebKit port to build. But build-webkit advertises --sdk=X in its
2940         help message. We should teach build-webkit to recognize both --sdk X and --sdk=X to make its handling
2941         of --sdk more consistent with the handling of other build-webkit options that take a value (e.g. --prefix).
2943         * Scripts/webkitdirs.pm:
2944         (checkForArgumentAndRemoveFromArrayRefGettingValue): Added.
2945         (checkForArgumentAndRemoveFromARGVGettingValue): Modified to call checkForArgumentAndRemoveFromArrayRefGettingValue().
2946         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl: Added.
2948 2014-01-23  Commit Queue  <commit-queue@webkit.org>
2950         Unreviewed, rolling out r162612.
2951         http://trac.webkit.org/changeset/162612
2952         https://bugs.webkit.org/show_bug.cgi?id=127488
2954         broke the build (Requested by mhahnenberg on #webkit).
2956         * Scripts/build-jsc:
2957         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Removed.
2958         * jsc-cli/jsc-cli/CLIInstance.h: Removed.
2959         * jsc-cli/jsc-cli/CLIInstance.m: Removed.
2960         * jsc-cli/jsc-cli/JSModule.h: Removed.
2961         * jsc-cli/jsc-cli/JSModule.m: Removed.
2962         * jsc-cli/jsc-cli/JSRunLoopThread.h: Removed.
2963         * jsc-cli/jsc-cli/JSRunLoopThread.m: Removed.
2964         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Removed.
2965         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Removed.
2966         * jsc-cli/jsc-cli/RunLoopThread.h: Removed.
2967         * jsc-cli/jsc-cli/RunLoopThread.m: Removed.
2968         * jsc-cli/jsc-cli/ScriptInputSource.h: Removed.
2969         * jsc-cli/jsc-cli/ScriptInputSource.m: Removed.
2970         * jsc-cli/jsc-cli/main.m: Removed.
2972 2014-01-23  Mark Hahnenberg  <mhahnenberg@apple.com>
2974         Basic framework for a modern jsc CLI
2975         https://bugs.webkit.org/show_bug.cgi?id=127435
2977         Reviewed by Geoffrey Garen.
2979         The most basic components of a modern jsc command line interface consist of the following:
2981         - A simple REPL to enter commands and receive results
2982         - The ability to define a module (which consists of various internal methods as well as a 
2983           set of externally visible methods)
2984         - The ability to load other modules at runtime
2985         - The ability to interact with the underlying platform to perform various "privileged" 
2986           functions (e.g. opening files, printing to the stdout, etc.)
2987         
2988         The basic architecture will look something like the following:
2989         - If the tool is run in REPL mode (i.e. no command line arguments), it will start the REPL 
2990           on the main thread and start a secondary thread with a run loop to handle various inputs 
2991           from the REPL thread.
2992         - If the tool is given a script to run, it will evaluate that script (and any scripts that 
2993           it might transitively load) within the run loop on the secondary thread while the main 
2994           thread blocks until it has completed.
2996         * Scripts/build-jsc:
2997         * jsc-cli: Added.
2998         * jsc-cli/jsc-cli: Added.
2999         * jsc-cli/jsc-cli.xcodeproj: Added.
3000         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
3001         * jsc-cli/jsc-cli/CLIInstance.h: Added.
3002         * jsc-cli/jsc-cli/CLIInstance.m: Added.
3003         (-[CLIInstance init]):
3004         (-[CLIInstance loadFile:]):
3005         (-[CLIInstance run]):
3006         * jsc-cli/jsc-cli/JSModule.h: Added.
3007         * jsc-cli/jsc-cli/JSModule.m: Added.
3008         (coreModules):
3009         (isCoreModule):
3010         (classForModule):
3011         (coreModuleFullPath):
3012         (resolveModuleAsFile):
3013         (resolveModuleAsDirectory):
3014         (nodeModulePaths):
3015         (resolveAsNodeModule):
3016         (+[JSModule resolve:atPath:]):
3017         (globalModuleCache):
3018         (isCached):
3019         (cachedModule):
3020         (cacheModule):
3021         (+[JSModule require:atPath:]):
3022         (+[JSModule require:atPath:inContext:]):
3023         (-[JSModule platformObjectInContext:]):
3024         (-[JSModule initWithId:filename:context:]):
3025         (-[JSModule dealloc]):
3026         (-[JSModule didStartLoading]):
3027         (-[JSModule didFinishLoading]):
3028         (-[JSModule require:]):
3029         (-[JSModule exports]):
3030         * jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
3031         * jsc-cli/jsc-cli/JSRunLoopThread.m: Added.
3032         (jsThreadMain):
3033         (+[JSRunLoopThread threadMain]):
3034         (-[JSRunLoopThread initWithFiles:andContext:]):
3035         (-[JSRunLoopThread startRunLoop]):
3036         (-[JSRunLoopThread start]):
3037         (-[JSRunLoopThread join]):
3038         (-[JSRunLoopThread didReceiveInput:]):
3039         (-[JSRunLoopThread performCallback:withError:]):
3040         (-[JSRunLoopThread performCallback:withArguments:]):
3041         (-[JSRunLoopThread didFinishRunLoopInitialization]):
3042         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
3043         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.
3044         (-[ReadEvalPrintLoop initWithJSThread:]):
3045         (prompt):
3046         (escapeStringForOutput):
3047         (-[ReadEvalPrintLoop processNextInput]):
3048         (-[ReadEvalPrintLoop run]):
3049         * jsc-cli/jsc-cli/RunLoopThread.h: Added.
3050         * jsc-cli/jsc-cli/RunLoopThread.m: Added.
3051         (+[RunLoopThread threadMain]):
3052         (-[RunLoopThread init]):
3053         (-[RunLoopThread dealloc]):
3054         (-[RunLoopThread didFinishRunLoopInitialization]):
3055         (-[RunLoopThread start]):
3056         (-[RunLoopThread join]):
3057         * jsc-cli/jsc-cli/ScriptInputSource.h: Added.
3058         * jsc-cli/jsc-cli/ScriptInputSource.m: Added.
3059         (scriptInputSourceScheduleRoutine):
3060         (scriptInputSourcePerformRoutine):
3061         (scriptInputSourceCancelRoutine):
3062         (-[ScriptInputSource initWithContext:]):
3063         (-[ScriptInputSource dealloc]):
3064         (-[ScriptInputSource addToCurrentRunLoop]):
3065         (-[ScriptInputSource removeFromRemoteRunLoop]):
3066         (-[ScriptInputSource didReceiveScript:]):
3067         (-[ScriptInputSource didReceiveSignal]):
3068         (-[ScriptInputSource runScriptRemotely:]):
3069         (-[ScriptInputSource finishAsyncCallback:withResult:]):
3070         * jsc-cli/jsc-cli/main.m: Added.
3071         (main):
3073 2014-01-23  László Langó  <llango.u-szeged@partner.samsung.com>
3075         Remove a FIXME comment that is already fixed.
3076         https://bugs.webkit.org/show_bug.cgi?id=127468
3078         Reviewed by Csaba Osztrogonác.
3080         * Scripts/webkitpy/style/filereader.py:
3081         (TextFileReader.__init__):
3083 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3085         [GLIB] Use GUniquePtr instead of GOwnPtr
3086         https://bugs.webkit.org/show_bug.cgi?id=127431
3088         Reviewed by Martin Robinson.
3090         GUniquePtr is a template alias of std::unique_ptr with a custom
3091         deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
3092         where the output pointer is needed, but it will also be replaced soon.
3094         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3095         (printAccessibilityEvent):
3096         (axObjectEventListener):
3097         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3098         (indexRangeInTable):
3099         (AccessibilityUIElement::role):
3100         (AccessibilityUIElement::title):
3101         (AccessibilityUIElement::description):
3102         (AccessibilityUIElement::stringValue):
3103         (AccessibilityUIElement::language):
3104         (AccessibilityUIElement::lineForIndex):
3105         (AccessibilityUIElement::selectedTextRange):
3106         (AccessibilityUIElement::url):
3107         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
3108         (AccessibilityController::accessibleElementById):
3109         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3110         (AccessibilityController::accessibleElementById):
3111         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3112         (getOutputDir):
3113         (getFontsPath):
3114         (initializeFonts):
3115         (dumpFramesAsText):
3116         (compareHistoryItems):
3117         (dumpHistoryItem):
3118         (soupURIToStringPreservingPassword):
3119         (resetDefaultsToConsistentValues):
3120         (temporaryDatabaseDirectory):
3121         (webViewTitleChanged):
3122         (webFrameLoadStatusNotified):
3123         (pathFromSoupURI):
3124         (convertWebResourceToURLPath):
3125         (urlSuitableForTestResult):
3126         (descriptionSuitableForTestResult):
3127         (willSendRequestCallback):
3128         (frameLoadEventCallback):
3129         * DumpRenderTree/gtk/EditingCallbacks.cpp:
3130         (dumpNodePath):
3131         (dumpRange):
3132         (shouldApplyStyle):
3133         * DumpRenderTree/gtk/EventSender.cpp:
3134         (contextClickCallback):
3135         (beginDragWithFilesCallback):
3136         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3137         (TestRunner::pathToLocalResource):
3138         (TestRunner::queueLoad):
3139         (TestRunner::removeOriginAccessWhitelistEntry):
3140         (TestRunner::setMockGeolocationPositionUnavailableError):
3141         (TestRunner::setIconDatabaseEnabled):
3142         (TestRunner::findString):
3143         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3144         (TestRunner::overridePreference):
3145         (TestRunner::addUserScript):
3146         (TestRunner::addUserStyleSheet):
3147         (TestRunner::setTextDirection):
3148         * DumpRenderTree/gtk/TextInputController.cpp:
3149         (setMarkedTextCallback):
3150         (insertTextCallback):
3151         (doCommandCallback):
3152         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
3153         (LoadHTMLStringItem::invoke):
3154         * TestWebKitAPI/PlatformGTK.cmake:
3155         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3156         (WebKitDOMNodeTest::testTagNames):
3157         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
3158         (testBackForwardListLimitAndCache):
3159         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3160         (testContextMenuSmartSeparators):
3161         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
3162         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3163         (testDownloadLocalFile):
3164         (testDownloadLocalFileError):
3165         (addContentDispositionHTTPHeaderToResponse):
3166         (serverCallback):
3167         (testDownloadRemoteFileError):
3168         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
3169         (startTestServer):
3170         (testInspectorServerPageList):
3171         (openRemoteDebuggingSession):
3172         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
3173         (testPrintOperationPrint):
3174         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3175         (addCacheHTTPHeadersToResponse):
3176         (serverCallback):
3177         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3178         (httpsServerCallback):
3179         (httpServerCallback):
3180         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3181         (testWebViewJavaScriptDialogs):
3182         (testWebViewWindowProperties):
3183         (testWebViewFileChooserRequest):
3184         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
3185         (testWebExtensionWindowObjectCleared):
3186         (testWebExtensionIsolatedWorld):
3187         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
3188         (startTestServer):
3189         (checkAtspiAccessible):
3190         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
3191         (serverCallback):
3192         (testClearDatabase):
3193         (testGetFaviconURI):
3194         (webkitFaviconDatabaseFinalizedCallback):
3195         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3196         (testWebContextGetPlugins):
3197         (testWebContextURIScheme):
3198         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3199         (testWebViewRunJavaScript):
3200         (testWebViewMode):
3201         (testWebViewPageVisibility):
3202         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
3203         (isStyleSheetInjectedForURLAtPath):
3204         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3205         (testWebViewEditorCutCopyPasteNonEditable):
3206         (testWebViewEditorCutCopyPasteEditable):
3207         (testWebViewEditorSelectAllNonEditable):
3208         (testWebViewEditorSelectAllEditable):
3209         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3210         (sendRequestCallback):
3211         (methodCallCallback):
3212         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
3213         (TestWebKitAPI::Util::createInjectedBundlePath):
3214         (TestWebKitAPI::Util::createURLForResource):
3215         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
3216         (TestWebKitAPI::doKeyStroke):
3217         (TestWebKitAPI::doMouseButtonEvent):
3218         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3219         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3220         (loadFailedCallback):
3221         (LoadTrackingTest::loadURI):
3222         (LoadTrackingTest::loadHtml):
3223         (LoadTrackingTest::loadPlainText):
3224         (LoadTrackingTest::loadRequest):
3225         (LoadTrackingTest::reload):
3226         (LoadTrackingTest::goBack):
3227         (LoadTrackingTest::goForward):
3228         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
3229         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
3230         (registerGResource):
3231         (removeNonEmptyDirectory):
3232         (main):
3233         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3234         (Test::getWebKit1TestResoucesDir):
3235         (Test::getResourcesDir):
3236         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
3237         (WebKitTestBus::run):
3238         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
3239         (WebKitTestServer::WebKitTestServer):
3240         (WebKitTestServer::getURIForPath):
3241         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
3242         (WebProcessTestRunner::runTest):
3243         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3244         (resourceGetDataCallback):
3245         (WebViewTest::mainResourceData):
3246         (WebViewTest::mouseMoveTo):
3247         (WebViewTest::keyStroke):
3248         (WebViewTest::doMouseButtonEvent):
3249         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3250         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3251         (WTR::AccessibilityController::accessibleElementById):
3252         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3253         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3254         (WTR::AccessibilityUIElement::role):
3255         (WTR::AccessibilityUIElement::title):
3256         (WTR::AccessibilityUIElement::description):
3257         (WTR::AccessibilityUIElement::stringValue):
3258         (WTR::AccessibilityUIElement::language):
3259         (WTR::AccessibilityUIElement::lineForIndex):
3260         (WTR::AccessibilityUIElement::selectedTextRange):
3261         (WTR::AccessibilityUIElement::url):
3262         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3263         (WTR::getOutputDir):
3264         (WTR::getFontsPath):
3265         (WTR::initializeFontConfigSetting):
3266         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3267         (WTR::topLevelPath):
3268         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3269         (WTR::TestRunner::pathToLocalResource):
3270         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3271         (WTR::TestController::initializeInjectedBundlePath):
3272         (WTR::TestController::initializeTestPluginDirectory):
3274 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
3276         [GTK] [CMake] run-webkit-tests should support the CMake build
3277         https://bugs.webkit.org/show_bug.cgi?id=126503
3279         Reviewed by Daniel Bates.
3281         Update run-launcher and gtk.py to work properly when dealing with the CMake port.
3282         run-webkit-tests does not need the --gtkcmake flag, but run-launcher does.
3284         * Scripts/run-launcher: Work properly with the gtkcmake flag.
3285         * Scripts/webkitpy/port/gtk.py:
3286         (GtkPort._is_cmake_build): Added this helper which looks for the CMakeCache
3287         file to detect a CMake build.
3288         (GtkPort._built_executables_path): Added this helper to locate the built executable path.
3289         (GtkPort._built_libraries_path): Added this helper to locate the built library path.
3290         (GtkPort._port_flag_for_scripts): Use --gtkcmake when appropriate.
3291         (GtkPort.setup_environ_for_server): The way CMake builds libraries differs from GTK+.
3292         (GtkPort._path_to_driver): Use the new helper.
3293         (GtkPort._path_to_image_diff): Use the new helper.
3294         (GtkPort._path_to_webcore_library): Use the new helper.
3295         (GtkPort.build_webkit_command): Use --gtkcmake when appropriate.
3297 2014-01-22  Ryuan Choi  <ryuan.choi@samsung.com>
3299         [EFL] Remove unnecessary smart method since ewk_view_tiled removed
3300         https://bugs.webkit.org/show_bug.cgi?id=127417
3302         Reviewed by Gyuyoung Kim.
3304         * EWebLauncher/main.c:
3305         (on_key_down): Removed shortcut to test pre render.
3307 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
3309         Remove CSS3_TEXT_DECORATION define
3310         https://bugs.webkit.org/show_bug.cgi?id=127333
3312         This is required for unprefixing the text-decoration-* CSS properties.
3314         Reviewed by Simon Fraser.
3316         * Configurations/FeatureDefines.xcconfig:
3318 2014-01-22  Andy Estes  <aestes@apple.com>
3320         [iOS] Prepare for upstreaming DumpRenderTree changes
3321         https://bugs.webkit.org/show_bug.cgi?id=127412
3323         Reviewed by Simon Fraser.
3325         Unlike on Mac where DumpRenderTree is a command-line tool, on iOS it is
3326         an application bundle. Instead of upstreaming a separate target for the
3327         app that duplicates the 'Compile Sources' phase of the tool, separate
3328         out the compilation into a static library target that both the
3329         command-line tool and the app can link against. Also, perform some
3330         unrelated cleanup.
3332         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated the
3333         project file format from 2.4- to 3.2-compatible. Removed the
3334         'Copy Headers' build phase and removed all files from the
3335         'Compile Sources' build phase of DumpRenderTree. Added some files that
3336         were missing from the project. Created a 'DumpRenderTree (Library)'
3337         target for building the static library and made the 'DumpRenderTree'
3338         target depend on it. Added a 'Compile Sources' build phase to this
3339         target that builds the same files the DumpRenderTree target used to.
3340         Created DumpRenderTreeMain.mm as the only source file of the
3341         DumpRenderTree target, since targets won't link a binary without at
3342         least one source file. Made DumpRenderTree (Library) use
3343         DumpRenderTreeLibrary.xcconfig and made LayoutTestHelper use
3344         BaseTarget.xcconfig (so that it doesn't try to link libDumpRenderTree.a).
3345         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Moved
3346         definitions of GCC_ENABLE_OBJC_EXCEPTIONS and GCC_PREFIX_HEADER from
3347         DumpRenderTree.xcconfig to here so that LayoutTestHelper can use them.
3348         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Passed
3349         -force_load $(BUILT_PRODUCTS_DIR)libDumpRenderTree.a to OTHER_LDFLAGS.
3350         This is needed to correctly link a static library containing an Objective-C
3351         category (see <https://developer.apple.com/library/mac/qa/qa1490/_index.html>).
3352         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Added.
3353         * DumpRenderTree/mac/DumpRenderTree.mm:
3354         (DumpRenderTreeMain): Renamed from main.
3355         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added declaration of DumpRenderTreeMain.
3356         * DumpRenderTree/mac/DumpRenderTreeMain.mm: Added.
3357         (main): Called DumpRenderTreeMain from main.
3359 2014-01-15  Martin Robinson  <mrobinson@igalia.com>
3361         [GTK][CMake] build-webkit should try harder to avoid re-running cmake
3362         https://bugs.webkit.org/show_bug.cgi?id=127073
3364         Reviewed by Daniel Bates.
3366         * Scripts/build-webkit: Unify all the ports that call buildCMakeProjectOrExit with
3367         the new isCMakeBuild conditional. This allows us to share more code between ports.
3368         Pass the build arguments to the removeCMakeCache function.
3369         * Scripts/webkitdirs.pm:
3370         (runAutogenForAutotoolsProjectIfNecessary): Renamed mustReRunAutogen to cachedArgumentFileOutOfDate
3371         because it's now shared with the CMake build.
3372         (cachedArgumentFileOutOfDate): Renamed.
3373         (cmakeCachePath): Added this helper which gets the CMakeCache.txt path.
3374         (shouldRemoveCMakeCache): Tries to preserve current behavior for all ports, 
3375         except GTK+ which examines the OptionsGTK.cmake and OptionsCommon.cmake file
3376         as well as checking if build-webkit has been run with different arguments.
3377         (removeCMakeCache): Call shouldRemoveCMakeCache now.
3378         (generateBuildSystemFromCMakeProject): Exit early if CMakeCache.txt exists for GTK+.
3379         (isCMakeBuild): Added.
3381 2014-01-22  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
3383         [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
3384         https://bugs.webkit.org/show_bug.cgi?id=127119
3386         Reviewed by Mario Sanchez Prada.
3388         Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
3390         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3391         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3392         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3393         (resetDefaultsToConsistentValues):
3394         (webViewWindowObjectCleared):
3395         (main):
3396         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3397         (WTR::AccessibilityController::platformName):
3398         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3399         (WTR::AccessibilityUIElement::isIndeterminate):
3401 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3404         [GTK] Add GUniquePtr
3405         https://bugs.webkit.org/show_bug.cgi?id=127170
3407         Reviewed by Gustavo Noronha Silva.
3409         Add unit tests for GUniquePtr.
3411         * TestWebKitAPI/GNUmakefile.am: Add new file to compilation.
3412         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: Added.
3413         (log):
3414         (takeLogStr):
3415         (TestWebKitAPI::TEST):
3417 2014-01-22  Jinwoo Song  <jinwoo7.song@samsung.com>
3419         Remove Nix files from Tools
3420         https://bugs.webkit.org/show_bug.cgi?id=127418
3422         Reviewed by Csaba Osztrogonác.
3424         * Scripts/build-webkit:
3425         * Scripts/update-webkit-libs-jhbuild:
3426         * Scripts/webkitdirs.pm:
3427         (determineArchitecture):
3428         (argumentsForConfiguration):
3429         (jscProductDir):
3430         (builtDylibPathForName):
3431         (isAppleWebKit):
3432         (launcherPath):
3433         (launcherName):
3434         (checkRequiredSystemConfig):
3435         (copyInspectorFrontendFiles):
3436         (jhbuildWrapperPrefixIfNeeded):
3437         (buildCMakeProjectOrExit):
3438         (cmakeBasedPortName):
3439         * Scripts/webkitpy/common/config/ports.py:
3440         (DeprecatedPort.port):
3441         (EflWK2Port.build_webkit_command):
3442         * Scripts/webkitpy/port/factory.py:
3443         (platform_options):
3444         (PortFactory):
3445         * Scripts/webkitpy/port/nix.py: Removed.
3446         * Scripts/webkitpy/port/nix_unittest.py: Removed.
3448 2014-01-21  Benjamin Poulain  <benjamin@webkit.org>
3450         Add Ian and Ricky to the contributor list
3452         * Scripts/webkitpy/common/config/contributors.json:
3453         I am too old to remember all those email addresses :)
3455 2014-01-21  David Farler  <dfarler@apple.com>
3457         Upstream package-root for iOS
3459         Reviewed by Daniel bates.
3461         * Scripts/package-root: Added.
3462         (usage):
3463         * Scripts/webkitdirs.pm:
3464         (XcodeSDKPath): Added function.
3466 2014-01-21  Daniel Bates  <dabates@apple.com>
3468         [iOS] Tools/Makefile shouldn't build modules DumpRenderTree, gtest, or TestWebKitAPI
3469         https://bugs.webkit.org/show_bug.cgi?id=127368
3471         Reviewed by Tim Horton.
3473         Similar to the build-webkit change in <https://bugs.webkit.org/show_bug.cgi?id=127364>,
3474         we don't want to build DumpRenderTree, gtest, or TestWebKitAPI when running make in
3475         Tools.
3477         * Makefile:
3479 2014-01-21  Daniel Bates  <dabates@apple.com>
3481         [iOS] Don't build DumpRenderTree, gtest, or TestWebKitAPI
3482         https://bugs.webkit.org/show_bug.cgi?id=127364
3484         Reviewed by Simon Fraser.
3486         For now, don't build DumpRenderTree and TestWebKitAPI for iOS as these
3487         projects fail to build because we need to upstream the relevant iOS changes.
3488         Also, don't build gtest, which is a dependency of TestWebKitAPI since we
3489         aren't building TestWebKitAPI.
3491         * Scripts/build-webkit:
3493 2014-01-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3495         Unreviewed, remove myself from some watchlist entries.
3497         * Scripts/webkitpy/common/config/watchlist:
3499 2014-01-21  Zalan Bujtas  <zalan@apple.com>
3501         Use 64 as the default value for the subpixel denominator.
3503         Reviewed by Simon Fraser.
3505         * lldb/lldb_webkit.py:
3506         (WebCoreLayoutUnitProvider.to_string):
3508 2014-01-21  ChangSeok Oh  <changseok.oh@collabora.com>
3510         [GTK] Fix a c++11 compliance issue for fontconfig
3511         https://bugs.webkit.org/show_bug.cgi?id=127283
3513         Reviewed by Martin Robinson.
3515         fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
3516         hotfix until bumping fontconfig up.
3518         * gtk/jhbuild.modules:
3519         * gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
3521 2014-01-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3523         run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var
3524         like run_webkit_test does
3525         https://bugs.webkit.org/show_bug.cgi?id=127349
3527         Reviewed by Csaba Osztrogonác.
3529         * Scripts/run-jsc-stress-tests:
3531 2014-01-21  Adrian Perez de Castro  <aperez@igalia.com>
3533         [GTK] Allow passing extra data to web extensions
3534         https://bugs.webkit.org/show_bug.cgi?id=125990
3536         Reviewed by Carlos Garcia Campos.
3538         Allow passing additional information to the injected bundle. On top
3539         of the string containing the path to the web extensions directory,
3540         a GVariant can be set with additional data using
3541         webkit_web_context_set_web_extensions_initialization_user_data().
3542         Also, a new initialize-web-extensions signal is emitted before
3543         launching a new WebProcess to allow setting different user data
3544         for each process. The GVariant is serialized as a string, passed
3545         to the injected bundle, and the injected bundle deserializes back
3546         the data, which is passed to web extensions which define the
3547         webkit_web_extension_initialize_with_user_data() function (for
3548         backwards compatibility, webkit_web_extension_initialize() is
3549         used as a fallback.)
3551         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
3552         (initializeWebExtensions): Handles the initialize-web-extensions
3553         signal, and sets the web extensions directory and the initialization
3554         user data.
3555         (testWebExtensionInitializationUserData): New test case for checking
3556         the user data passed on initialization to web extensions.
3557         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3558         (methodCallCallback): Added implementation for the
3559         GetInitializationUserData D-Bus method, used by
3560         testWebExtensionInitializationUserData().
3561         (webkit_web_extension_initialize_with_user_data): Define the
3562         initialization function with the additional user data parameter.
3564 2014-01-21  Siddharth Mathur  <s.mathur@ieee.org>
3566         Change my email address in contributors.json.
3568         Unreviewed.
3570         * Scripts/webkitpy/common/config/contributors.json:
3572 2014-01-21  Krzysztof Czech  <k.czech@samsung.com>
3574         [ATK] Expose aria-flowto through ATK_RELATION_FLOWS_TO
3575         https://bugs.webkit.org/show_bug.cgi?id=127291
3577         Reviewed by Mario Sanchez Prada.
3579         Implemented AccessibilityUIElement::ariaFlowToElementAtIndex method.
3581         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3582         (AccessibilityUIElement::ariaFlowToElementAtIndex):
3583         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3584         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
3586 2014-01-20  Zalan Bujtas  <zalan@apple.com>
3588         Force float division when calculating CSS px value.
3590         Reviewed by Simon Fraser.
3592         Note that in Python 3, this is the default behavior.
3594         * lldb/lldb_webkit.py:
3595         (WebCoreLayoutUnitProvider.to_string):
3597 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
3599         build.webkit.org/dashboard should display information about patches in EWS
3600         https://bugs.webkit.org/show_bug.cgi?id=127006
3602         Reviewed by Ryosuke Niwa.
3604         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3605         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js: Added.
3606         (Bugzilla.prototype.detailsURLForAttachment):
3607         Added a class for Bugzilla. So far, the only thing it can do is build patch URLs,
3608         which is needed when one wants to do something with a patch EWS is stuck on.
3610         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3611         Create a Bugzilla instance.
3613         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
3614         (EWS.prototype.jsonQueueLengthURL):
3615         (EWS.prototype.jsonQueueStatusURL):
3616         Build JSON ULRs here, not in EWSQueue, as this is how other classes are structured.
3618         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3619         (EWSQueue.prototype.get statusPageURL): Changed to use a URL provided by EWS instead
3620         of second guessing.
3621         (EWSQueue.prototype.get chartsPageURL): Added.
3622         (EWSQueue.prototype.get loadedDetailedStatus): Tells whether we currently have
3623         additional data already loaded (it's reset with every update).
3624         (EWSQueue.prototype.get patches): Get patch queue.
3625         (EWSQueue.prototype.get bots): Get bots.
3626         (EWSQueue.prototype.update): Changed to use a specialized cheaper URL.
3627         (EWSQueue.prototype.loadDetailedStatus): Load and transform detailed status JSON.
3629         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
3630         (EWSQueueView.prototype.update.appendQueue): Add a popover is there are any patches
3631         in the queue.
3632         (EWSQueueView.prototype.addLinkToRow): A helper to build the popover.
3633         (EWSQueueView.prototype.addTextToRow): Ditto.
3634         (EWSQueueView.prototype._addQueueHeadingToPopover): Ditto.
3635         (EWSQueueView.prototype._addBotsHeadingToPopover): Ditto.
3636         (EWSQueueView.prototype._addDividerToPopover): Ditto.
3637         (EWSQueueView.prototype._timeIntervalString): A helper to format a timestamp into a
3638         relative string.
3639         (EWSQueueView.prototype._popoverContentForEWSQueue): Build the popover.
3640         (EWSQueueView.prototype._presentPopoverForEWSQueue): Start loading data, and present
3641         it when done.
3643         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3644         Added rules for EWS popover. Removed a duplicate rule for build-logs-popover.
3645         Changed a few difficult to read padding styles to padding-left.
3647 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
3649         Fix webkitpy tests.
3651         * Scripts/webkitpy/common/net/web_mock.py: (MockBrowser.set_handle_robots):
3652         Added a mock implementation, as we now call this function.
3654 2014-01-20  Darin Adler  <darin@apple.com>
3656         Update style checker and tests to deal with override instead of OVERRIDE
3657         https://bugs.webkit.org/show_bug.cgi?id=127175
3659         Reviewed by Anders Carlsson.
3661         * Scripts/webkitpy/style/checkers/cpp.py:
3662         (check_braces): Use override instead of OVERRIDE.
3663         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3664         (CppStyleTest.test_brace_at_begin_of_line): Ditto.
3666 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
3668         EWS should provide better information to Dashboard via JSON
3669         https://bugs.webkit.org/show_bug.cgi?id=127265
3671         Reviewed by Ryosuke Niwa.
3673         * QueueStatusServer/app.yaml: Updated version.
3675         * QueueStatusServer/main.py:
3676         * QueueStatusServer/handlers/queuelengthjson.py:
3677         Added a way to cheaply get only the queue length, which is all the dashboard
3678         needs unless a popover is opened.
3680         * QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
3681         that we will need. Changed some field names to be more meaningful. Fixed bot listing
3682         to understand that a bot can be reprurposed and used in a different queue.
3684 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
3686         Make uploading results to EWS work despite robots.txt
3687         https://bugs.webkit.org/show_bug.cgi?id=127296
3689         Reviewed by Ryosuke Niwa.
3691         * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
3692         checking robots.txt.
3694         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
3695         Removed a comment saying that we would want to stop doing this. Not checking
3696         robots.txt is more efficient than checking it.
3698 2014-01-19  Ryuan Choi  <ryuan.choi@samsung.com>
3700         [EFL][WK1] Remove and refactor the APIs which use single and base keyword
3701         https://bugs.webkit.org/show_bug.cgi?id=127214
3703         Reviewed by Gyuyoung Kim.
3705         Followed the changes of API.
3707         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3708         (drtViewAdd):
3709         * EWebLauncher/main.c:
3710         (windowCreate):
3712 2014-01-19  Eunmi Lee  <eunmi15.lee@samsung.com>
3714         [EFL][WK2] Add touch events option to MiniBrowser.
3715         https://bugs.webkit.org/show_bug.cgi?id=127262
3717         Reviewed by Gyuyoung Kim.
3719         As a default, touch events are disabled and mouse events are enabled.
3720         If touch events option sets to true, touch events are enabled and mouse
3721         events are disabled.
3723         * MiniBrowser/efl/main.c:
3724         (window_create):
3725         (elm_main):
3727 2014-01-19  Zalan Bujtas  <zalan@apple.com>
3729         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
3730         https://bugs.webkit.org/show_bug.cgi?id=126080
3732         Reviewed by Sam Weinig.
3734         This changes the output of printing LayoutUnits to be in px but it also
3735         preserves the original LayoutUnit value.
3737         This will lead to lldb output like: (and it works even when subpixel is disabled)
3739         (const WebCore::LayoutRect) $0 = {
3740             m_location = { x = 2.25px (144), y = 1px (64)}
3741             m_size = { width = 13.75px (880), height = 20px (1280) }
3744         And gdb output like:
3746         m_frameRect = {
3747             m_location = LayoutPoint(0px (0), 0px(0)),
3748             m_size = LayoutSize(8px (512), 5px (320))
3749         }
3751         This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.
3753         * gdb/webkit.py:
3754         (WebCoreLayoutUnitPrinter):
3755         (WebCoreLayoutUnitPrinter.__init__):
3756         (WebCoreLayoutUnitPrinter.to_string):
3757         (WebCoreLayoutSizePrinter):
3758         (WebCoreLayoutSizePrinter.__init__):
3759         (WebCoreLayoutSizePrinter.to_string):
3760         (WebCoreLayoutPointPrinter):
3761         (WebCoreLayoutPointPrinter.__init__):
3762         (WebCoreLayoutPointPrinter.to_string):
3763         (add_pretty_printers):
3764         * lldb/lldb_webkit.py:
3765         (__lldb_init_module):
3766         (WebCoreLayoutUnit_SummaryProvider):
3767         (WebCoreLayoutSize_SummaryProvider):
3768         (WebCoreLayoutPoint_SummaryProvider):
3769         (WebCoreLayoutUnitProvider):
3770         (WebCoreLayoutUnitProvider.__init__):
3771         (WebCoreLayoutUnitProvider.to_string):
3772         (WebCoreLayoutSizeProvider):
3773         (WebCoreLayoutSizeProvider.__init__):
3774         (WebCoreLayoutSizeProvider.get_width):
3775         (WebCoreLayoutSizeProvider.get_height):
3776         (WebCoreLayoutPointProvider):
3777         (WebCoreLayoutPointProvider.__init__):
3778         (WebCoreLayoutPointProvider.get_x):
3779         (WebCoreLayoutPointProvider.get_y):
3781 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
3783         Add robots.txt to http://webkit-queues.appspot.com
3784         https://bugs.webkit.org/show_bug.cgi?id=127240
3786         * QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
3788 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
3790         Add robots.txt to http://webkit-queues.appspot.com
3791         https://bugs.webkit.org/show_bug.cgi?id=127240
3793         Reviewed by Ryosuke Niwa.
3795         * QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
3797         * QueueStatusServer/robots.txt: Added.
3799 2014-01-18  Alberto Garcia  <berto@igalia.com>
3801         Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
3802         https://bugs.webkit.org/show_bug.cgi?id=127217
3804         Reviewed by Daniel Bates.
3806         The syntax File::Temp->tempdir() was explicitly made invalid
3807         following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
3808         which was included in File::Temp v2.30, shipped with Perl v5.18.0.
3810         Use File::Temp::tempdir() instead.
3812         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3814 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
3816         build.webkit.org/dashboard should have image diff links in test results popovers
3817         https://bugs.webkit.org/show_bug.cgi?id=127188
3819         Reviewed by Timothy Hatcher.
3821         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3822         (Buildbot.prototype.layoutTestImagesURLForIteration):
3823         (Buildbot.prototype.layoutTestImageDiffURLForIteration):
3824         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3825         (BuildbotIteration.prototype.loadLayoutTestResults):
3826         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3827         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
3828         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
3829         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
3831 2014-01-18  Anders Carlsson  <andersca@apple.com>
3833         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
3834         https://bugs.webkit.org/show_bug.cgi?id=127225
3836         Reviewed by Andreas Kling.
3838         This concludes the removal of over 8.8 million lines of threaded parser code.
3840         * Scripts/webkitperl/FeatureList.pm:
3842 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
3844         build.webkit.org/dashboard should have diff links in test results popovers
3845         https://bugs.webkit.org/show_bug.cgi?id=126986
3847         Reviewed by Tim Horton.
3849         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3850         (Buildbot.prototype.layoutTestCrashLogURLForIteration):
3851         (Buildbot.prototype.layoutTestStderrURLForIteration):
3852         (Buildbot.prototype.layoutTestDiffURLForIteration):
3853         (Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
3854         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3855         (BuildbotIteration.prototype.loadLayoutTestResults):
3856         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3857         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
3859 2014-01-17  Matthew Hanson  <matthew_hanson@apple.com>
3861         Add the bare minimum support for branches to the bot-watchers dashboard
3862         https://bugs.webkit.org/show_bug.cgi?id=127124
3864         This patch simply introduces the notion of branches into the bot-watchers dashboard.
3865         Subsequent patches will build functionality on top of this simple bit of infrastructure.
3867         Reviewed by Timothy Hatcher.
3869         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3870         (BuildbotQueue): store the branch property in the BuildbotQueue constructor
3871         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3872         Initialize the Dashboard.Branch object
3874 2014-01-17  Chris Fleizach  <cfleizach@apple.com>
3876         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
3877         https://bugs.webkit.org/show_bug.cgi?id=127141
3879         Reviewed by Alexey Proskuryakov.
3881         Make sure to reset the notification handler each time.
3883         * DumpRenderTree/AccessibilityController.cpp:
3884         (AccessibilityController::resetToConsistentState):
3885         * DumpRenderTree/AccessibilityController.h:
3886         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3887         (AccessibilityController::platformResetToConsistentState):
3888         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3889         (AccessibilityController::platformResetToConsistentState):
3890         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3891         (AccessibilityController::~AccessibilityController):
3892         (AccessibilityController::platformResetToConsistentState):
3893         (AccessibilityController::removeNotificationListener):
3894         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3895         (AccessibilityController::platformResetToConsistentState):
3897 2014-01-17  Alberto Garcia  <berto@igalia.com>
3899         [GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
3900         https://bugs.webkit.org/show_bug.cgi?id=82329
3902         Reviewed by Carlos Garcia Campos.
3904         Unskip, this is working fine now.
3906         * Scripts/run-gtk-tests:
3907         (TestRunner):
3909 2014-01-17  Alberto Garcia  <berto@igalia.com>
3911         [GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
3912         https://bugs.webkit.org/show_bug.cgi?id=82328
3914         Reviewed by Carlos Garcia Campos.
3916         This was caused by the icon database being corrupted in the
3917         Release bot. After removing it the test works fine so it can be
3918         run again.
3920         * Scripts/run-gtk-tests:
3921         (TestRunner):
3923 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
3925         Test results popovers at http://build.webkit.org/dashboard should link to stderr
3926         https://bugs.webkit.org/show_bug.cgi?id=126929
3928         Reviewed by Timothy Hatcher.
3930         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3931         (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
3932         (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
3934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3935         (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
3937         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3938         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
3939         Add a link to stderr output if present.
3941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3942         (.test-results-popover .additional-link): Style with light grey (will use the same style
3943         for diff links).
3945 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
3947         Automate DoYouEvenBench
3948         https://bugs.webkit.org/show_bug.cgi?id=124497
3950         Reviewed by Geoffrey Garen.
3952         * Scripts/webkitpy/performance_tests/perftest.py:
3953         (PerfTestMetric.__init__): Added the aggregator name as an argument.
3954         (PerfTestMetric.aggregator): Added.
3955         (PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
3956         won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
3957         should be parsed as the metric and the aggregator respectively.
3958         (PerfTest._run_with_driver): Pass in the aggregator name.
3959         (PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
3960         which generates subtests of subtests within a single test file.
3962         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3963         (test_parse_output_with_subtests_and_total): Added.
3965         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3966         (_generate_results_dict): Add the aggregator name to the JSON when one is available.
3968         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3969         (TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
3971 2014-01-16  Chris Fleizach  <cfleizach@apple.com>
3973         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
3974         https://bugs.webkit.org/show_bug.cgi?id=127141
3976         Reviewed by Alexey Proskuryakov.
3978         Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
3980         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3981         (AccessibilityController::~AccessibilityController):
3983 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
3985         EWS shouldn't comment on Bugzilla for failing builds or style errors
3986         https://bugs.webkit.org/show_bug.cgi?id=127079
3988         Reviewed by Anders Carlsson.
3990         Since patch authors and reviewers could retrieve this information from bubbles,
3991         we shouldn't spam the Bugzilla with useless comments.
3993         We still post style errors but not python paths we used since it's a pure noise.
3995         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3996         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
3997         * Scripts/webkitpy/tool/commands/queues.py:
3998         (StyleQueue.review_patch):
4000 2014-01-15  Roger Fong  <roger_fong@apple.com>
4002         Add support for handling WebGL load policies.
4003         https://bugs.webkit.org/show_bug.cgi?id=126935
4004         <rdar://problem/15790448>.
4006         Reviewed by Timothy Horton.
4008         * WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
4009         (WTR::TestController::createWebViewWithOptions):
4011 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
4013         Remove workaround for compilers not supporting explicit override control
4014         https://bugs.webkit.org/show_bug.cgi?id=127111
4016         Reviewed by Anders Carlsson.
4018         Now all compilers support explicit override control, this workaround can be removed.
4020         * DumpRenderTree/gtk/fonts/fonts.conf:
4021         * Scripts/do-webcore-rename:
4022         Removed this rename operation from the list of contemplated future renames.
4023         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
4024         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
4025         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
4026         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
4027         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
4029 2014-01-16  Oliver Hunt  <oliver@apple.com>
4031         Stop run-jsc from consuming stderr output
4032         https://bugs.webkit.org/show_bug.cgi?id=127115
4034         Reviewed by Mark Lam.
4036         Simple patch to make run-jsc easier to deal with
4038         * Scripts/run-jsc:
4040 2014-01-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
4042         Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
4043         https://bugs.webkit.org/show_bug.cgi?id=126323
4045         Reviewed by Csaba Osztrogonác.
4047         * gtk/generate-feature-defines-files:
4049 2014-01-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
4051         [EFL][WK2] Implement TestController::setHidden
4052         https://bugs.webkit.org/show_bug.cgi?id=127036
4054         Reviewed by Gyuyoung Kim.
4056         WebKitTestRunner needs TestController::setHidden implementation to
4057         properly handle page visibility API layout tests after r161105.
4059         * WebKitTestRunner/efl/TestControllerEfl.cpp:
4060         (WTR::TestController::setHidden):
4062 2014-01-16  Zan Dobersek  <zdobersek@igalia.com>
4064         [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
4065         https://bugs.webkit.org/show_bug.cgi?id=127083
4067         Reviewed by Carlos Garcia Campos.
4069         When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
4070         The progress entry is then reset back to 0 in that callback and the timeout source is removed.
4072         The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
4073         assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
4074         To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
4075         BrowserWindow object is being finalized, preventing the callback from firing.
4077         * MiniBrowser/gtk/BrowserWindow.c:
4078         (resetEntryProgress):
4079         (webViewLoadProgressChanged):
4080         (browserWindowFinalize):
4082 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
4084         DumpRenderTree doesn't disable web preferences autosave
4085         https://bugs.webkit.org/show_bug.cgi?id=127062
4087         Reviewed by Dan Bernstein.
4089         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
4090         Do it.
4092 2014-01-15  Dean Jackson  <dino@apple.com>
4094         Improve filter-build-webkit, especially for iOS builds
4095         https://bugs.webkit.org/show_bug.cgi?id=81046
4097         Reviewed by Joseph Pecoraro.
4099         Lots of updates to the filtering rules, mostly from the
4100         iOS build output. Other highlights include:
4101         - ignoring escape sequences for color ouput
4102         - detecting escaped spaces in file name regexps
4104         * Scripts/filter-build-webkit:
4105         (shouldIgnoreLine):
4107 2014-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
4109         [GTK] Web process sometimes crashes when printing in synchronous mode
4110         https://bugs.webkit.org/show_bug.cgi?id=126979
4112         Reviewed by Gustavo Noronha Silva.
4114         * Scripts/run-gtk-tests:
4115         (TestRunner): Unskip
4116         /webkit2/WebKitPrintOperation/close-after-print.
4118 2014-01-15  ChangSeok Oh  <changseok.oh@collabora.com>
4120         [EFL] Change test font installed path to webkitgtk-font-tests
4121         https://bugs.webkit.org/show_bug.cgi?id=126723
4123         Reviewed by Gyuyoung Kim.
4125         I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
4126         to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
4127         hard-coded in FontManagement.cpp#105
4129         * DumpRenderTree/PlatformEfl.cmake:
4130         * WebKitTestRunner/PlatformEfl.cmake:
4131         * efl/jhbuild.modules:
4133 2014-01-14  Ryosuke Niwa  <rniwa@webkit.org>
4135         Make DoYouEvenBench runnable by run-perf-tests
4136         https://bugs.webkit.org/show_bug.cgi?id=127030
4138         Reviewed by Andreas Kling.
4140         Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
4141         ":Total" to appear at the end of a test name. We don't do anything with it for now.
4143         * Scripts/webkitpy/performance_tests/perftest.py:
4144         (PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
4145         to the JSON in a follow up patch for the perf dashboard.
4146         (PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
4148 2014-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4150         [GTK] UI process crashes when the web process crashes while printing
4151         https://bugs.webkit.org/show_bug.cgi?id=126977
4153         Reviewed by Gustavo Noronha Silva.
4155         Add new test case to check that closing the window right after
4156         printing works. It's skipped for now, because this patch only
4157         fixes the UI process crash, but not the web process one.
4159         * Scripts/run-gtk-tests:
4160         (TestRunner): Skip
4161         /webkit2/WebKitPrintOperation/close-after-print.
4162         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
4163         (testPrintOperationPrintPrinter):
4164         (findPrintToFilePrinter):
4165         (testPrintOperationPrint):
4166         (testPrintOperationErrors):
4167         (testPrintOperationCloseAfterPrint):
4168         (beforeAll):
4170 2014-01-14  Brent Fulgham  <bfulgham@apple.com>
4172         [WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
4173         https://bugs.webkit.org/show_bug.cgi?id=127002
4175         Reviewed by David Kilzer.
4177         * Scripts/webkitdirs.pm:
4178         (setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
4180 2014-01-14  Commit Queue  <commit-queue@webkit.org>
4182         Unreviewed, rolling out r162000.
4183         http://trac.webkit.org/changeset/162000
4184         https://bugs.webkit.org/show_bug.cgi?id=127009
4186         API versioning is wrong (Requested by rfong on #webkit).
4188         * MiniBrowser/mac/WK2BrowserWindowController.m:
4189         (-[WK2BrowserWindowController awakeFromNib]):
4190         * WebKitTestRunner/TestController.cpp:
4191         (WTR::TestController::createOtherPage):
4192         (WTR::TestController::createWebViewWithOptions):
4194 2014-01-13  Roger Fong  <roger_fong@apple.com>
4196         Add support for handling WebGL load policies.
4197         https://bugs.webkit.org/show_bug.cgi?id=126935
4198         <rdar://problem/15790448>.
4200         Reviewed by Brent Fulgham.
4202         * MiniBrowser/mac/WK2BrowserWindowController.m:
4203         (-[WK2BrowserWindowController awakeFromNib]):
4204         * WebKitTestRunner/TestController.cpp:
4205         (WTR::TestController::createWebViewWithOptions):
4207 2014-01-14  Zan Dobersek  <zdobersek@igalia.com>
4209         [GTK] Skip FontConfig initialization in WebKitTestRunner if requested
4210         https://bugs.webkit.org/show_bug.cgi?id=120110
4212         Reviewed by Martin Robinson.
4214         Skip the FontConfig settings initialization in WebKitTestRunner if the
4215         WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
4216         This is useful when profiling the WebKitTestRunner execution, where at the startup
4217         this step takes considerable amount of time and disturbs the profiling output.
4219         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4220         (WTR::initializeFontConfigSetting):
4222 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
4224         Add ENABLE(WEB_REPLAY) feature flag to the build system
4225         https://bugs.webkit.org/show_bug.cgi?id=126949
4227         Reviewed by Joseph Pecoraro.
4229         * Scripts/webkitperl/FeatureList.pm:
4231 2014-01-14  László Langó  <llango.u-szeged@partner.samsung.com>
4233         REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
4234         https://bugs.webkit.org/show_bug.cgi?id=126702
4236         Reviewed by Alexey Proskuryakov.
4238         Resolve regression and remove a FIXME comment that is already fixed.
4240         * Scripts/webkitpy/common/system/filesystem.py:
4241         (FileSystem.open_text_file_for_reading):
4242         * Scripts/webkitpy/common/system/filesystem_unittest.py:
4243         (RealFileSystemTest.test_read_and_write_file):
4244         * Scripts/webkitpy/style/filereader.py:
4245         (TextFileReader._read_lines):
4246         * Scripts/webkitpy/style/filereader_unittest.py:
4247         (TextFileReaderTest.test_count_delete_only_file):
4248         (TextFileReaderTest):
4249         (TextFileReaderTest.test_process_malformed_file):
4251 2014-01-02  Brian Holt  <brian.holt@samsung.com>
4253         [GTK] Parse Valgrind xml leak files
4254         https://bugs.webkit.org/show_bug.cgi?id=119446
4256         Reviewed by Alejandro G. Castro.
4258         Parse the xml files generated by Valgrind to yield useful
4259         information about the memory leaks.
4261         * Scripts/webkitpy/port/gtk.py:
4262         (GtkPort.__init__):
4263         (GtkPort.setup_test_run): Clear the previous output files before new
4264         run.
4265         (GtkPort.print_leaks_summary):
4267         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
4268         Parse the xml files generated by Valgrind and summarise leaks
4269         into an easily understandable list.
4270         (get_text_of):
4271         (get_CDATA_of):
4272         (gather_frames):
4273         (ValgrindError):
4274         (ValgrindError.__init__):
4275         (ValgrindError.__str__):
4276         (ValgrindError.unique_string):
4277         (ValgrindError.error_hash):
4278         (ValgrindError.__hash__):
4279         (ValgrindError.__eq__):
4280         (LeakDetectorValgrind):
4281         (LeakDetectorValgrind.__init__):
4282         (LeakDetectorValgrind._parse_leaks_output):
4283         (LeakDetectorValgrind.leaks_files_in_results_directory):
4284         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
4285         (LeakDetectorValgrind.parse_and_print_leaks_detail):
4287         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
4288         (make_mock_valgrind_output):
4289         (make_mock_incomplete_valgrind_output):
4290         (make_mock_valgrind_results):
4291         (make_mock_valgrind_results_incomplete):
4292         (make_mock_valgrind_results_empty):
4293         (make_mock_valgrind_results_misformatted):
4294         (mock_run_cppfilt_command):
4295         (LeakDetectorValgrindTest):
4296         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
4297         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
4298         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
4299         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
4300         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
4301         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
4302         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
4303         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
4305 2014-01-13  Lucas Forschler  <lforschler@apple.com>
4307         Update the LLINT CLoop Bot build infrastructure
4308         https://bugs.webkit.org/show_bug.cgi?id=126604
4309         
4310         Unreviewed.
4311         
4312         * BuildSlaveSupport/build.webkit.org-config/config.json:
4313         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4314         (CompileLLINTCLoop):
4315         (RunLLINTCLoopTests):
4316         (BuildAndTestLLINTCLoopFactory):
4317         (BuildAndTestLLINTCLoopFactory.__init__):
4319 2014-01-13  Jinwoo Song  <jinwoo7.song@samsung.com>
4321         [EFL][WK2] Disable failing API tests
4322         https://bugs.webkit.org/show_bug.cgi?id=126960
4324         Reviewed by Gyuyoung Kim.
4326         Disable WKViewUserViewportToContents test until bug 126261 is resolved.
4328         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
4329         (TestWebKitAPI::TEST):
4331 2014-01-13  Daniel Batyai  <dbatyai.u-szeged@partner.samsung.com>
4333         Remove wdiff
4334         https://bugs.webkit.org/show_bug.cgi?id=124766
4336         Reviewed by Ryosuke Niwa.
4338         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
4339         (ResultsJSONParserTest):
4340         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4341         (TestResultWriter):
4342         (TestResultWriter.create_text_diff_and_write_result):
4343         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
4344         (summarize_results):
4345         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4346         (RunTest.test_output_diffs):
4347         * Scripts/webkitpy/port/base.py:
4348         (Port.__init__):
4349         (Port.driver_stop_timeout):
4350         (Port.check_image_diff):
4351         (Port.repository_paths):
4352         (Port._path_to_lighttpd_php):
4353         * Scripts/webkitpy/port/base_unittest.py:
4354         (PortTest.test_default_child_processes):
4355         (PortTest.test_pretty_patch_script_error):
4356         * Scripts/webkitpy/port/port_testcase.py:
4357         (PortTestCase.test_diff_image_crashed):
4358         * Scripts/webkitpy/port/test.py:
4359         (TestPort.operating_system):
4361 2014-01-13  Martin Robinson  <mrobinson@igalia.com>
4363         Build fix for the GTK+ CMake port
4365         * TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
4367 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
4369         [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
4370         https://bugs.webkit.org/show_bug.cgi?id=126881
4372         Reviewed by Carlos Garcia Campos.
4374         * MiniBrowser/gtk/BrowserWindow.c:
4375         (browser_window_new):
4376         Explicitly cast GtkWindow** to gpointer* in call to
4377         g_object_add_weak_pointer to avoid compiler warnings.
4379 2014-01-13  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
4381         Remove parsing of old-run-webkit-tests output from master.cfg
4382         https://bugs.webkit.org/show_bug.cgi?id=126690
4384         Reviewed by Csaba Osztrogonác.
4386         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4387         Removed parsing of ORWT output, as it is not used anymore.
4388         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4389         Updated unit tests accordingly.
4391 2014-01-13  Commit Queue  <commit-queue@webkit.org>
4393         Unreviewed, rolling out r161808.
4394         http://trac.webkit.org/changeset/161808
4395         https://bugs.webkit.org/show_bug.cgi?id=126874
4397         This patch make several files to be always regenerated on
4398         every make (Requested by KaL on #webkit).
4400         * WebKitTestRunner/GNUmakefile.am:
4402 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
4404         [GTK] Make MiniBrowser windows non-transient by default
4405         https://bugs.webkit.org/show_bug.cgi?id=126840
4407         Reviewed by Carlos Garcia Campos.
4409         Instead of making new browser windows transient as soon as they are
4410         created, save the pointer to the parent window and set the transient
4411         state later on when handling the "run-as-modal" signal. This makes
4412         it easier to use the MiniBrowser to do tests involving multiple
4413         windows, and will be useful as well when multi-web-process mode is
4414         enabled for the GTK port.
4416         * MiniBrowser/gtk/BrowserWindow.c:
4417         (webViewRunAsModal): Set the parent window using
4418         gtk_window_set_transient_for() using the saved parent
4419         window.
4420         (browser_window_new): Save the parent window using
4421         g_object_set_data() instead of making the new window
4422         transient immediately.
4424 2014-01-12  Sergio Correia  <sergio.correia@openbossa.org>
4426         [EFL][WK2] Make API tests work again
4427         https://bugs.webkit.org/show_bug.cgi?id=126769
4429         Reviewed by Gyuyoung Kim.
4431         The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
4432         [E]WebKit2, respectively, and this causes problems because the logic to find
4433         where WebProcess is to look in the same directory of the running process and
4434         then proceed to use LIBEXECDIR (typically /usr/loca/bin).
4436         This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
4437         Gtk port, which allows us to look for WebProcess initially in this directory,
4438         if it's defined.
4440         * TestWebKitAPI/efl/main.cpp:
4441         (main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
4443 2014-01-12  Daniel Bates  <dabates@apple.com>
4445         [iOS] Fix the build
4447         For now, ensure we build WebKit System Interface before we build WebKit.
4448         We'll remove this constraint and the constraint to build WebKit Additions
4449         in a subsequent commit.
4451         * Scripts/build-webkit:
4453 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4455         Unreviewed. Fix make distcheck.
4457         * gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
4458         to EXTRA_DIST.
4460 2014-01-12  Tobias Mueller  <tobiasmue@gnome.org>
4462         --disable-dependency-tracking causes build failure due to missing directories
4463         https://bugs.webkit.org/show_bug.cgi?id=94488
4465         Reviewed by Gustavo Noronha Silva.
4467         Autotools build fix: Ensure output directory existing
4468         before generating DerivedSources. This allows for
4469         --disable-dependency-tracking to be run.
4472         * WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
4474 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4476         [GTK] Fix return value of WebKitDownload::created-destination
4477         https://bugs.webkit.org/show_bug.cgi?id=126741
4479         Reviewed by Martin Robinson.
4481         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
4482         value of several callbacks.
4484 2014-01-11  Sam Weinig  <sam@webkit.org>
4486         Add support for null StringViews
4487         https://bugs.webkit.org/show_bug.cgi?id=126827
4489         Reviewed by Anders Carlsson.
4491         Add new test for StringView.
4493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4494         * TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
4495         (TestWebKitAPI::TEST):
4497 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
4499         Remove the BlackBerry port from trunk
4500         https://bugs.webkit.org/show_bug.cgi?id=126715
4502         Reviewed by Anders Carlsson.
4504         * DumpRenderTree/DumpRenderTree.h:
4505         * DumpRenderTree/PixelDumpSupport.cpp:
4507 2014-01-10  Daniel Bates  <dabates@apple.com>
4509         [iOS] Fix project build order
4511         Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
4512         build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
4513         time of writing.
4515         * Scripts/build-webkit:
4517 2014-01-10  Mario Sanchez Prada  <mario.prada@samsung.com>
4519         Move platformName property from testRunner to accessibilityController
4520         https://bugs.webkit.org/show_bug.cgi?id=126689
4522         Reviewed by Chris Fleizach.
4524         Move the platformName property from the testRunner into
4525         accessibilityController, since this is a concept that has only be
4526         used by accessibility tests since it got added, and also because
4527         the real intention was not to distinguish among "ports" (mac, win,
4528         gtk, efl) but between platforms (atk, mac, win).
4530         This change will be very useful to merge GTK's roles-exposed.html
4531         and Mac's role-subrole-roledescription.html into one single test,
4532         since we will be specifying in the test itself which elements are
4533         supported in which accessibility "platform". In this context,
4534         being able to check accessibilityController.platformName directly
4535         against a list of supported accessibility platforms (e.g. "atk,mac")
4536         will certainly maintain the code cleaner and simpler.
4538         * DumpRenderTree/TestRunner.h:
4539         (TestRunner::platformName): Removed.
4540         * DumpRenderTree/TestRunner.cpp:
4541         (getPlatformNameCallback): Removed.
4542         (TestRunner::staticValues): Removed platformName
4543         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4544         (TestRunner::platformName): Removed.
4545         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4546         (TestRunner::platformName): Removed.
4547         * DumpRenderTree/mac/TestRunnerMac.mm:
4548         (TestRunner::platformName): Removed.
4549         * DumpRenderTree/win/TestRunnerWin.cpp:
4550         (TestRunner::platformName): Removed.
4552         * DumpRenderTree/AccessibilityController.h:
4553         (AccessibilityController::platformName): Added.
4554         * DumpRenderTree/AccessibilityController.cpp:
4555         (getPlatformNameCallback): Added.
4556         (AccessibilityController::getJSClass): Added platformName.
4557         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
4558         (AccessibilityController::platformName): Added, returning "atk".
4559         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4560         (AccessibilityController::platformName): Ditto, returning "mac".
4561         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
4562         (AccessibilityController::platformName): Ditto, returning "ios".
4563         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4564         (AccessibilityController::platformName): Ditto, returning "win".
4566         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4567         (platformName): Removed.
4568         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4569         (TestRunner::platformName): Removed.
4570         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
4571         (TestRunner::platformName): Removed.
4572         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
4573         (TestRunner::platformName): Removed.
4574         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4575         (TestRunner::platformName): Removed.
4576         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
4577         (TestRunner::platformName): Removed.
4579         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
4580         (WTR:AccessibilityController::platformName): Added.
4581         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
4582         (platformName): Added.
4583         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
4584         (WTR::AccessibilityController::platformName): Added, returning "atk".
4585         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
4586         (WTR::AccessibilityController::platformName): Added, returning "mac".
4588 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
4590         Remove the BlackBerry port from trunk
4591         https://bugs.webkit.org/show_bug.cgi?id=126715
4593         Reviewed by Anders Carlsson.
4595         * Scripts/webkitpy/common/config/watchlist:
4597 2014-01-09  Benjamin Poulain  <bpoulain@apple.com>
4599         Remove the BlackBerry files outside WebCore
4600         https://bugs.webkit.org/show_bug.cgi?id=126715
4602         Reviewed by Anders Carlsson.
4604         * DumpRenderTree/blackberry: Removed.
4606 2014-01-10  Simon Fraser  <simon.fraser@apple.com>
4608         Remove knowledge of Blackberry from build scripts
4609         https://bugs.webkit.org/show_bug.cgi?id=126766
4611         Reviewed by Anders Carlsson.
4612         
4613         Remove isBlackBerry() and references to it, and rmeove
4614         blackberry-related stuff from the watchlist.
4616         * Scripts/build-webkit:
4617         * Scripts/webkit-build-directory:
4618         * Scripts/webkitdirs.pm:
4619         (determineBaseProductDir):
4620         (argumentsForConfiguration):
4621         (builtDylibPathForName):
4622         (isAppleWebKit):
4623         (buildCMakeProjectOrExit):
4624         (cmakeBasedPortArguments):
4625         (cmakeBasedPortName):
4626         * Scripts/webkitperl/FeatureList.pm:
4627         * Scripts/webkitpy/common/config/watchlist:
4629 2014-01-10  Daniel Bates  <dabates@apple.com>
4631         [iOS] Fix up simulator build and enable default features
4633         Rubber-stamped by Joseph Pecoraro.
4635         * Scripts/webkitdirs.pm:
4636         (determineArchitecture):
4637         (determinePassedArchitecture):
4638         * Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
4639         by default only in iOS).
4641 2014-01-10  Daniel Bates  <dabates@apple.com>
4643         [iOS] Upstream WebCore and Tools miscellaneous changes
4644         https://bugs.webkit.org/show_bug.cgi?id=126698
4646         Reviewed by David Kilzer.
4648         * Scripts/check-for-inappropriate-objc-class-names:
4649         * Scripts/check-for-webkit-framework-include-consistency:
4651 2014-01-09  Dan Bernstein  <mitz@apple.com>
4653         [Cocoa] Promote WKBackForwardList{,Item}.h to public
4654         https://bugs.webkit.org/show_bug.cgi?id=126707
4656         Reviewed by Sam Weinig.
4658         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
4659         left behind in the build products directory after a private header is made public.
4661 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
4663         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
4664         https://bugs.webkit.org/show_bug.cgi?id=126686
4666         Reviewed by Martin Robinson.
4668         Test that partial files are not left on disk after a download has
4669         been cancelled after the destination has been decided. To make
4670         sure the download is cancelled after the destination has been
4671         decided and before the operation finishes, we cancel the download
4672         in the destination decided callback, and we use an infinite
4673         resource that writes chunks to the response body and never
4674         completes the body.
4676         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
4677         (addContentDispositionHTTPHeaderToResponse): Helper function to
4678         add the Content-Disposition to the response headers.
4679         (writeNextChunkIdle): Write next chunk to response body.
4680         (writeNextChunk): Write next chunk in an idle to avoid flooding
4681         the network with the inifnite resource.
4682         (serverCallback): Add an inifinite resource.
4683         (testDownloadRemoteFileError): Check that partial file is not
4684         present after the download has been cancelled.
4686 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
4688         Move myself to the committers list.
4690         Unreviewed.
4692         * Scripts/webkitpy/common/config/contributors.json:
4694 2014-01-08  Seokju Kwon  <seokju@webkit.org>
4696         [GTK] Unreviewed build fix after r161522.
4698         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
4700 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
4702         Missleading style error when mixing system and non-system header include lines.
4703         https://bugs.webkit.org/show_bug.cgi?id=126564
4705         Reviewed by Ryosuke Niwa.
4707         * Scripts/webkitpy/style/checkers/cpp.py:
4708         (check_include_line):
4709         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4710         (OrderOfIncludesTest.test_check_alphabetical_include_order):
4711         (OrderOfIncludesTest.test_public_primary_header):
4713 2014-01-08  Seokju Kwon  <seokju@webkit.org>
4715         [EFL] Unreviewed build fix after r161522.
4717         * TestWebKitAPI/CMakeLists.txt:
4718         * TestWebKitAPI/PlatformEfl.cmake:
4720 2014-01-08  Anders Carlsson  <andersca@apple.com>
4722         Remove WKConnectionRef tests
4723         https://bugs.webkit.org/show_bug.cgi?id=126666
4725         Reviewed by Dan Bernstein.
4727         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
4728         Remove the API tests as a first step towards killing the entire thing.
4730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4731         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
4732         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
4734 2014-01-08  Commit Queue  <commit-queue@webkit.org>
4736         Unreviewed, rolling out r161512.
4737         http://trac.webkit.org/changeset/161512
4738         https://bugs.webkit.org/show_bug.cgi?id=126655
4740         Broke webkitpy tests (Requested by ap on #webkit).
4742         * Scripts/webkitpy/port/gtk.py:
4743         (GtkPort.__init__):
4744         (GtkPort.setup_test_run):
4745         (GtkPort._port_specific_expectations_files):
4746         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
4747         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
4749 2014-01-08  Commit Queue  <commit-queue@webkit.org>
4751         Unreviewed, rolling out r161517.
4752         http://trac.webkit.org/changeset/161517
4753         https://bugs.webkit.org/show_bug.cgi?id=126659
4755         The fix didn't completely remove the problem and is now
4756         standing in the way of the rollout of the offending patch
4757         (Requested by zdobersek on #webkit).
4759         * Scripts/webkitpy/port/gtk.py:
4760         (GtkPort.__init__):
4762 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
4764         Unreviewed. Attempting to fix webkitpy tests after r161512.
4766         * Scripts/webkitpy/port/gtk.py:
4767         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
4769 2014-01-08  Brian Holt  <brian.holt@samsung.com>
4771         [GTK] Parse Valgrind xml leak files
4772         https://bugs.webkit.org/show_bug.cgi?id=119446
4774         Reviewed by Alejandro G. Castro.
4776         Parse the xml files generated by Valgrind to yield useful
4777         information about the memory leaks.
4779         * Scripts/webkitpy/port/gtk.py:
4780         (GtkPort.__init__):
4781         (GtkPort.setup_test_run): Clear the previous output files before new
4782         run.
4783         (GtkPort.print_leaks_summary):
4785         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
4786         Parse the xml files generated by Valgrind and summarise leaks
4787         into an easily understandable list.
4788         (get_text_of):
4789         (get_CDATA_of):
4790         (gather_frames):
4791         (ValgrindError):
4792         (ValgrindError.__init__):
4793         (ValgrindError.__str__):
4794         (ValgrindError.unique_string):
4795         (ValgrindError.error_hash):
4796         (ValgrindError.__hash__):
4797         (ValgrindError.__eq__):
4798         (LeakDetectorValgrind):
4799         (LeakDetectorValgrind.__init__):
4800         (LeakDetectorValgrind._parse_leaks_output):
4801         (LeakDetectorValgrind.leaks_files_in_results_directory):
4802         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
4803         (LeakDetectorValgrind.parse_and_print_leaks_detail):
4805         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
4806         (make_mock_valgrind_output):
4807         (make_mock_incomplete_valgrind_output):
4808         (make_mock_valgrind_results):
4809         (make_mock_valgrind_results_incomplete):
4810         (make_mock_valgrind_results_empty):
4811         (make_mock_valgrind_results_misformatted):
4812         (LeakDetectorValgrindTest):
4813         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
4814         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
4815         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
4816         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
4817         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
4818         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
4819         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
4820         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
4822 2014-01-08  Commit Queue  <commit-queue@webkit.org>
4824         Unreviewed, rolling out r161427.
4825         http://trac.webkit.org/changeset/161427
4826         https://bugs.webkit.org/show_bug.cgi?id=126645
4828         Emits a stye error on any newly added files (Requested by ap
4829         on #webkit).
4831         * Scripts/webkitpy/style/checkers/cpp.py:
4832         (check_style):
4833         (CppChecker):
4834         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4835         (WebKitStyleTest.test_other):
4837 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
4839         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
4840         https://bugs.webkit.org/show_bug.cgi?id=126580
4842         Reviewed by Csaba Osztrogonác.
4844         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4845         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
4846         run-webkit-tests script.
4847         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
4848         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
4850 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
4852         Update the list of non-committer u-szeged contributors
4853         https://bugs.webkit.org/show_bug.cgi?id=126640
4855         Reviewed by Csaba Osztrogonác.
4857         * Scripts/webkitpy/common/config/contributors.json:
4859 2014-01-08  Alberto Garcia  <berto@igalia.com>
4861         Fix some compilation warnings
4862         https://bugs.webkit.org/show_bug.cgi?id=126635
4864         Reviewed by Csaba Osztrogonác.
4866         * GtkLauncher/main.c:
4867         (createWindow): This function is not supposed to receive any
4868         parameter, yet we are passing one.
4870 2014-01-08  Brian Holt  <brian.holt@samsung.com>
4872         [GTK][WK2] unskip passing unit tests
4873         https://bugs.webkit.org/show_bug.cgi?id=126637
4875         Reviewed by Carlos Garcia Campos.
4877         Unskip TestResources and TestAuthentication unit tests since they
4878         are passing both under Xvfb and X.
4880         * Scripts/run-gtk-tests:
4881         (TestRunner):
4883 2014-01-08  Alberto Garcia  <berto@igalia.com>
4885         REGRESSION(r160304): [GTK] Disable libtool fast install
4886         https://bugs.webkit.org/show_bug.cgi?id=126381
4888         Reviewed by Gustavo Noronha Silva.
4890         Disable the libtool fast-install mode in developer/test builds.
4892         In this mode binaries are generated ready to be used directly from
4893         the build tree. Otherwise they would need to be relinked when they
4894         are executed, which can take a lot of resources, particularly in
4895         debug builds.
4897         * Scripts/webkitdirs.pm:
4898         (runAutogenForAutotoolsProjectIfNecessary):
4900 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
4902         Unreviewed GTK gardening.
4904         * Scripts/run-gtk-tests:
4905         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
4906         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
4908 2014-01-07  Lucas Forschler  <lforschler@apple.com>
4910         Add buildbot infrasctructure for building and testing JSC cloop
4911         https://bugs.webkit.org/show_bug.cgi?id=126604
4913         Reviewed by Geoffrey Garen.
4915         * BuildSlaveSupport/build.webkit.org-config/config.json:
4916         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4917         (CompileCLOOP):
4918         (RunCLOOPTests):
4919         (RunCLOOPTests.countFailures):
4920         (BuildAndTestCLOOP):
4922 2014-01-07  Brian Burg  <bburg@apple.com>
4924         Unreviewed. Add myself as a committer.
4926         * Scripts/webkitpy/common/config/contributors.json:
4928 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
4930         Popovers at build.webkit.org/dashboard could have titles
4931         https://bugs.webkit.org/show_bug.cgi?id=126495
4933         Reviewed by Timothy Hatcher.
4935         Added titles to all popovers except for pending revisions one, which I would like
4936         to improve more (probably add an ETA).
4938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
4939         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
4940         adding a title to base class.
4942         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
4943         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
4944         a divider to a separate function.
4945         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
4946         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
4947         title from above function.
4948         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
4949         variable to "content" to match all other code.
4950         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
4951         (BuildbotQueueView.prototype._addDividerToPopover): Added.
4953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
4954         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
4955         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
4956         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
4958         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
4960 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
4962         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
4963         https://bugs.webkit.org/show_bug.cgi?id=126472
4965         Reviewed by Timothy Hatcher.
4967         Added a delay when quickly switching to a different popover, making it easier to
4968         move mouse pointer from active element to its popover without accidentally opening
4969         a different popover.
4971         Used this code to add a delay before creating a popover. This doesn't change UI
4972         behavior, as there was alerady a delay before it became visible, but it avoids
4973         flooding buildbot server with http requests when quickly moving the mouse over
4974         dashboard page.
4976         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
4977         Fixed a case where popover could get stuck. If content was updated while fade-out
4978         transition was already in place, the transition was removed for no good reason.
4980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
4981         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
4983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
4984         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
4985         popover delay from 1s to 800ms.
4987 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
4989         Improve display of failed builds at build.webkit.org/dashboard
4990         https://bugs.webkit.org/show_bug.cgi?id=126542
4991         <rdar://problem/15753550>
4993         Reviewed by Timothy Hatcher.
4995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
4996         Instead of hardcoding step name, look for the first step that failed.
4997         While at it, added a popover with more links. There are multiple, and it's good
4998         to have a choice of which one to look at in each situation.
5000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
5001         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
5002         of having failed. Many iterations are interrupted for whatever reason internal to
5003         Buildbot, and these are suppoed to be orange, not red.
5004         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
5005         not only WillRetry ones.
5006         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
5007         actually failed, more likely indicating a problem with code base.
5008         (BuildbotIteration.prototype.get firstFailedStepName):
5009         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
5010         (BuildbotIteration.prototype.get failureLogs): Ditto.
5011         (BuildbotIteration.prototype.update): Store complete results for the failed step.
5012         Not every failure stops the iteration, so we could have multiple failed steps,
5013         but let's see if seeing just the first one will be enough.
5015         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
5016         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
5017         terms of successful iterations.
5018         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
5020         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
5021         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
5022         terms of successful iterations.
5024         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
5025         Removed code to create a path to build output, we now take it from results JSON.
5027         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
5028         Added styles for the new popover.
5030 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
5032         defined constants should use all uppercase names with words separated by underscores.
5033         https://bugs.webkit.org/show_bug.cgi?id=126055
5035         Reviewed by Alexey Proskuryakov.
5037         * Scripts/webkitpy/style/checkers/cpp.py:
5038         (check_style):
5039         (CppChecker):
5040         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
5041         (WebKitStyleTest.test_define_constants):
5043 2014-01-07  Brian Holt  <brian.holt@samsung.com>
5045         Unreviewed. Add myself as a committer.
5047         * Scripts/webkitpy/common/config/contributors.json:
5049 2014-01-07  Csaba Osztrogonác  <ossy@webkit.org>
5051         Remove the WinCE buildbot from build.webkit.org
5052         https://bugs.webkit.org/show_bug.cgi?id=126517
5054         Reviewed by Alexey Proskuryakov.
5056         * BuildSlaveSupport/build.webkit.org-config/config.json:
5057         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
5058         (appendCustomBuildFlags):
5060 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
5062         [EFL] Change ATK version to 2.11.4
5063         https://bugs.webkit.org/show_bug.cgi?id=126573
5065         Reviewed by Gyuyoung Kim.
5067         ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
5069         * efl/jhbuild.modules:
5071 2014-01-07  Alberto Garcia  <berto@igalia.com>
5073         [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
5074         https://bugs.webkit.org/show_bug.cgi?id=117275
5076         Reviewed by Carlos Garcia Campos.
5078         If we are not using the internal jhbuild we must not use the
5079         jhbuild-wrapper script, else it will try to download and install
5080         it.
5082         * Scripts/run-launcher:
5084 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
5086         [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
5087         https://bugs.webkit.org/show_bug.cgi?id=125855
5089         Reviewed by Mario Sanchez Prada.
5091         Added new function isIndeterminate for testing aria-checked mixed state.
5092         I provided respective, but empty function in mac port. Mac testing it differently.
5094         * DumpRenderTree/AccessibilityUIElement.cpp:
5095         (getIsIndeterminate):
5096         (AccessibilityUIElement::getJSClass):
5097         * DumpRenderTree/AccessibilityUIElement.h:
5098         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
5099         (AccessibilityUIElement::isIndeterminate):
5100         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added empty function.
5101         (AccessibilityUIElement::isIndeterminate):
5102         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added empty function.
5103         (AccessibilityUIElement::isIndeterminate):
5104         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added empty function.
5105         (AccessibilityUIElement::isIndeterminate):
5106         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
5107         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
5108         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
5109         (WTR::AccessibilityUIElement::isIndeterminate):
5110         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
5111         (WTR::AccessibilityUIElement::isIndeterminate):
5113 2014-01-06  Mark Rowe  <mrowe@apple.com>
5115         <https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums
5117         Reviewed by Ryosuke Niwa.
5119         * DumpRenderTree/mac/DumpRenderTree.mm:
5120         (-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
5121         with a single case. This avoids the potential for warnings about unhandled cases.
5122         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
5123         (WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.
5125 2014-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
5127         [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
5128         https://bugs.webkit.org/show_bug.cgi?id=126342
5130         Reviewed by Gustavo Noronha Silva.
5132         * CMakeLists.txt: Include the new unit tests subdirectories.
5133         * Scripts/run-gtk-tests: Update to refer to the new build locations.
5134         * Scripts/webkitpy/style/checker.py: Update the style checker.
5135         * Scripts/webkitpy/style/checker_unittest.py:
5136         * TestWebKitAPI/GNUmakefile.am:
5137         * TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
5138         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
5139         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
5140         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
5141         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
5142         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
5143         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
5144         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
5145         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
5146         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
5147         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
5148         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
5149         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
5150         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
5151         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
5152         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
5153         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
5154         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
5155         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
5156         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
5157         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
5158         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
5159         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
5160         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
5161         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
5162         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
5163         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
5164         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
5165         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
5166         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
5167         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
5168         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
5169         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
5170         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
5171         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
5172         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
5173         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
5174         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
5175         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
5176         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
5177         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
5178         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
5179         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
5180         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
5181         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
5182         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
5183         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
5184         * TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
5185         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
5186         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
5187         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
5188         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
5189         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
5190         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
5191         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
5192         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
5193         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
5194         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
5195         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
5196         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
5197         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
5198         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
5199         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
5200         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
5201         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
5202         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
5203         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
5204         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
5205         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
5206         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
5207         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
5208         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
5209         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
5210         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
5211         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
5212         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
5213         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
5214         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
5215         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
5216         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
5217         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
5218         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
5219         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
5220         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
5221         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
5222         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
5223         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
5225 2014-01-06  Alexey Proskuryakov  <ap@apple.com>
5227         Gtk and Efl API test results confuse the dashboard
5228         https://bugs.webkit.org/show_bug.cgi?id=126535
5230         Reviewed by Tim Horton.
5232         Added "API tests" step as "platform api tests".
5234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
5235         (Buildbot.prototype.platformAPITestResultsURLForIteration):
5236         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
5237         (BuildbotIteration):
5238         (BuildbotIteration.prototype.update):
5239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
5240         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
5241         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
5243 2014-01-06  Tim Horton  <timothy_horton@apple.com>
5245         build.webkit.org/dashboard should still function if localStorage is disabled
5246         https://bugs.webkit.org/show_bug.cgi?id=126511
5248         Reviewed by Alexey Proskuryakov.
5250         If localStorage is disabled, we should carry on with a warning.
5252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
5253         Don't show the gear if localStorage isn't working.
5255         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
5256         (QueueView.prototype._updateHiddenState):
5257         Bail if localStorage isn't working.
5259         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
5260         (Settings.prototype.available):
5262 2014-01-02  Roger Fong  <roger_fong@apple.com>
5264         Set VSINSTALLDIR in win ews start script.
5265         https://bugs.webkit.org/show_bug.cgi?id=126407
5267         Reviewed by Brent Fulgham.
5269         * EWSTools/start-queue-win.sh:
5271 2014-01-06  Bem Jones-Bey  <bjonesbe@adobe.com>
5273         Adding myself as a reviewer.
5275         Unreviewed.
5277         * Scripts/webkitpy/common/config/contributors.json:
5279 2014-01-06  Zan Dobersek  <zdobersek@igalia.com>
5281         Unreviewed. Unbreaking JSC tests after r161328.
5283         * Scripts/webkitdirs.pm:
5284         (cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
5285         through the CMake build system (i.e. passing --gtkcmake to build-webkit).
5287 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
5289         [GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
5290         https://bugs.webkit.org/show_bug.cgi?id=126212
5292         Reviewed by Daniel Bates.
5294         Allow building the GTK+ cmake port with --gtkcmake.
5296         * Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path
5297         when appropriate. Skip the autotoos path when isGtkAutotools is false.
5298         * Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.
5299         Add isGtk which checks isGtkCMake || isGtkAutotools
5300         (determineArchitecture): Use the CMake path for GTK+ when appropriate.
5301         (argumentsForConfiguration): use --gtkcmake when appropriate.
5302         (jscProductDir): Look in the CMake directory when appropriate.
5303         (builtDylibPathForName): CMake builds the library into a different directory, so handle that.
5304         (determineIsGtkCMake): Added.
5305         (isGtkCMake): Added.
5306         (isGtkAutotools): Renamed from isGtk.
5307         (isGtk): New function which returns isGtkAutotools || isGtkCMake.
5308         (determineIsGtkAutotools): Renamed from determineIsGtk.
5309         (cmakeBasedPortName): Added a GTK+ path.
5311 2014-01-04  Martin Robinson  <mrobinson@igalia.com>
5313         [GTK] [CMake] Fix the video and audio build
5314         https://bugs.webkit.org/show_bug.cgi?id=126464
5316         Reviewed by Philippe Normand.
5318         * GtkLauncher/CMakeLists.txt: Add GStreamer includes and libraries, since GtkLauncher uses it.
5320 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
5322         It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
5323         https://bugs.webkit.org/show_bug.cgi?id=126467
5325         Reviewed by Geoffrey Garen.
5327         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
5328         (StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
5329         pointer, or to tap.
5331 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
5333         build.webkit.org/dashboard says "failed build" even if it's another step that failed
5334         https://bugs.webkit.org/show_bug.cgi?id=126461
5336         Reviewed by Geoffrey Garen.
5338         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
5339         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
5340         build page if it's not the compilation that failed. Use text from buildbot for description.
5341         Show a yellow icon if it's a different kind of failure.
5343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
5344         (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
5346 2014-01-03  Bem Jones-Bey  <bjonesbe@adobe.com>
5348         setup-git-clone fails to get email address from git
5349         https://bugs.webkit.org/show_bug.cgi?id=126446
5351         Reviewed by Ryosuke Niwa.
5353         The setup-git-clone command fails to get an email address from git
5354         because of a bug in VCSUtils. This patch fixes that bug, and also
5355         makes it so that when VCSUtils fails for real because of a local
5356         misconfiguration, the error message is actually presented to the user
5357         of setup-git-clone.
5359         * Scripts/VCSUtils.pm:
5360         (gitConfig): Call isGit() instead of accessing $isGit directly to make
5361             sure that $isGit is properly initialized.
5362         * Scripts/webkitpy/tool/commands/setupgitclone.py:
5363         (SetupGitClone.execute): Pull out username and email acquistion to
5364             it's own method.
5365         (SetupGitClone._get_username_and_email): Catch the exception thrown
5366             when VCSUtils fails and print out the error message so that the
5367             user actually knows why the command failed.
5369 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
5371         It feels too hard to get rid of a popover at build.webkit.org/dashboard
5372         https://bugs.webkit.org/show_bug.cgi?id=126451
5374         Reviewed by Simon Fraser.
5376         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
5377         (.popover.fade-out): Reduced the timeout - 200 ms is enough to not have flicker
5378         when moving the mouse from an element to its popover.
5380 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
5382         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
5383         https://bugs.webkit.org/show_bug.cgi?id=122181
5385         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
5386         (BuildbotQueueView.prototype._presentNoChangePopover): Update one more place for
5387         popover.present signature change.
5389 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
5391         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
5392         https://bugs.webkit.org/show_bug.cgi?id=122181
5394         Reviewed by Timothy Hatcher and Timothy Horton.
5396         Detailed results are saved by run-webkit-tests to full_results.json (which is actually
5397         JSONP). Dashboard will load them on demand.
5399         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
5400         (Buildbot.prototype.layoutTestResultsURLForIteration): Moved from WebKitBuildbot.js
5401         and made it use a function from WebKitBuildbot that builds results directory path.
5402         (Buildbot.prototype.layoutTestFullResultsURLForIteration): Added a function that builds
5403         a URL for full_results.json.
5404         (Buildbot.prototype.layoutTestCrashLogForIteration): Added a function that builds
5405         a URL for a crash log.
5407         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
5408         (BuildbotIteration.prototype.loadLayoutTestResults): Load and cache layout test results for
5409         the iteration.
5411         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:        
5412         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Updated for changed
5413         popover API (see below).
5414         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Ditto.
5416         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
5417         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Added a check
5418         for iterations that were interrupted (previously, they were displayed incorrectly,
5419         often as passes). Install popover trackers for failure bubbles for which we can currently
5420         display something useful.
5421         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Build
5422         a popover for layout test regressions when we have the data loaded on demand.
5423         We have test paths, special indicators for crashes/timeouts, and links to test history
5424         at flakiness dashboard.
5425         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Show
5426         the popover for layout test regressions. Just shows "Loading..." until the data is
5427         loaded.
5428         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): List
5429         types of failures if there are multiple. There is a lot of similarity with
5430         appendBuilderQueueStatus(), but I couldn't find a good way to share the code.
5432         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
5433         Create a global test history object, which is used for links in layout test popover.
5435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
5436         Changed the API to be more like WebInspector again, allowing for changing content
5437         of an existing popover. As the size of a popover can change, making the mouse pointer
5438         enter it without a mousenter event, install a handler for mousewheel instead, and block
5439         document scrolling from this event handler when needed.
5441         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
5442         (StatusLineView.prototype.get statusBubbleElement): Added an accessor for status
5443         bubble element, making it possible to install a popover on it.
5445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
5446         (JSON.load): Added the ability to load JSONP by providing an optional callback name.
5448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
5449         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Switched from
5450         building a complete results URL to only building one for root results path. This is
5451         the part that depends on specific buildbot installation, everything relative to it
5452         is the same.
5454         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: Added.
5455         Build a path to test history page. In the future, we may consider adding code to
5456         load the data and display it inline.
5458         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
5459         Added styles for this new popover.
5461         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added
5462         a new file, WebKitTestHistory.js.
5464 2014-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
5466         REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214
5467         https://bugs.webkit.org/show_bug.cgi?id=126430
5469         Reviewed by Martin Robinson.
5471         * Scripts/run-gtk-tests:
5472         (TestRunner._setup_testing_environment):
5473         * gtk/common.py: Use common.tests_library_build_path() instead.
5474         (tests_library_build_path): Helper funtion that returns the path
5475         where the tests libraries are built.
5477 2014-01-03  Martin Robinson  <mrobinson@igalia.com>
5479         [CMake] Build TestWebKitAPI tests into a directory structure
5480         https://bugs.webkit.org/show_bug.cgi?id=126358
5482         Reviewed by Gyuyoung Kim.
5484         WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This
5485         is useful for keeping the "bin" directory tidy during building and will make it easier
5486         to integrate the CMake build into the existing WebKitGTK+ scripts.
5488         * TestWebKitAPI/CMakeLists.txt: Set the output directory of all TestWebKitAPI binaries
5489         and make the names simpler now that the directory identifies what category the test is in.
5491 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
5493         Provide a visual clue when element has a popover at build.webkit.org/dashboard
5494         https://bugs.webkit.org/show_bug.cgi?id=126281
5496         Reviewed by Timothy Hatcher.
5498         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
5499         (PopoverTracker): Add a class name to elements with popovers.
5501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
5502         (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
5503         I might have broke that recently.
5504         (*:link): Show hand cursor over links.
5505         (.popover-tracking:hover): Put a shadow on hover over element with popovers.
5507         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
5508         (.status-line .message .revision-number): Show text selection cursor on our only
5509         selectable text element.
5510         (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
5511         a white shadow than with a dark one on hover.
5513 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
5515         [GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
5516         https://bugs.webkit.org/show_bug.cgi?id=124652
5518         Reviewed by Martin Robinson.
5520         * MiniBrowser/gtk/BrowserWindow.c:
5521         (webViewDecidePolicy): Use the new API instead of
5522         webkit_web_view_can_show_mime_type().
5524 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
5526         REGRESSION(r160304): [GTK] Disable libtool fast install
5527         https://bugs.webkit.org/show_bug.cgi?id=126381
5529         Reviewed by Martin Robinson.
5531         Remove -no-fast-install ld flag since fast install is now disabled
5532         globally.
5534         * GNUmakefile.am:
5535         * GtkLauncher/GNUmakefile.am:
5536         * MiniBrowser/gtk/GNUmakefile.am:
5537         * TestWebKitAPI/GNUmakefile.am:
5538         * WebKitTestRunner/GNUmakefile.am:
5540 2014-01-02  Ryuan Choi  <ryuan.choi@samsung.com>
5542         Unreviewed. Add myself to EFL and related watch lists.
5544         * Scripts/webkitpy/common/config/watchlist:
5546 2014-01-02  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
5548         [GTK] fixing ycm_extra_conf.py file
5549         https://bugs.webkit.org/show_bug.cgi?id=126371
5551         It's an attempt to fix three problems with the current ycm_extra_conf file.
5552         The current implementation assumes that it's a symlink, which is not true.
5553         Usually python creates a pyc file, and this is what you get in __file__.
5554         the .pyc is not a symlink, and the current implementation doesn't work
5555         if that's the case.
5557         It also assumes that the user is in the root folder.
5558         If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
5560         Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an
5561         exception since "flag" doesn't exists.
5563         All those things were fixed.
5565         Reviewed by Martin Robinson.
5567         * gtk/ycm_extra_conf.py:
5568         (transform_relative_paths_to_absolute_paths):
5570 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
5572         Bindings tests results links are broken at build.webkit.org/dashboard
5573         https://bugs.webkit.org/show_bug.cgi?id=126402
5575         Reviewed by Tim Horton.
5577         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
5578         (Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
5579         since the beginning.
5581 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
5583         "+" is very confusing at http://build.webkit.org/dashboard
5584         https://bugs.webkit.org/show_bug.cgi?id=126400
5586         Reviewed by Tim Horton.
5588         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
5589         (BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
5590         source and internal counts separately, simply add them. One can always open a popover
5591         for more detail.
5593 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
5595         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
5596         https://bugs.webkit.org/show_bug.cgi?id=126391
5598         Reviewed by Dan Bernstein.
5600         Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
5601         One can request credentials use via Initialization.js.
5603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
5604         (Trac):
5605         (Trac.prototype.update):
5606         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
5607         (loadXML):
5609 2014-01-02  Commit Queue  <commit-queue@webkit.org>
5611         Unreviewed, rolling out r160846.
5612         http://trac.webkit.org/changeset/160846
5613         https://bugs.webkit.org/show_bug.cgi?id=126395
5615         Breaks build scripts for Windows when Visual Studio is not
5616         installed in Program Files (Requested by rfong on #webkit).
5618         * Scripts/webkitdirs.pm:
5619         (visualStudioInstallDir):
5621 2014-01-02  Martin Robinson  <mrobinson@igalia.com>
5623         [GTK] [CMake] run-gtk-tests should run with the cmake build
5624         https://bugs.webkit.org/show_bug.cgi?id=126341
5626         Reviewed by Carlos Garcia Campos.
5628         * Scripts/run-gtk-tests:
5629         (TestRunner.__init__): Use the new calling conventions for the common script.
5630         (TestRunner._setup_testing_environment): Ditto.
5631         * gtk/common.py:
5632         (set_build_types): Added set_build_types, to avoid having build_type arguments
5633         for all functions in common.
5634         (binary_build_path): Added this function which gets the path to the built binaries.
5635         (get_build_path): Removed the build_types argument.
5636         (build_path): Removed the build_types argument and call get_build_path directly now.
5638 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
5640         https://bugs.webkit.org/show_bug.cgi?id=126391
5641         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
5643         Rubber-stamped by Dan Bernstein.
5645         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
5646         (loadXML): Quick and dirty fix, with a FIXME.
5648 2014-01-01  Martin Robinson  <mrobinson@igalia.com>
5650         [GTK] Rename libtestnetscapeplugin to libTestNetscapePlugin
5651         https://bugs.webkit.org/show_bug.cgi?id=126349
5653         Reviewed by Carlos Garcia Campos.
5655         All CMake ports use "libTestNetscapePlugin," so choosing the same
5656         name in the autotools port will make the transition easier.
5658         * GNUmakefile.am: Rename the plugin library.
5660 2014-01-01  ChangSeok Oh  <changseok.oh@collabora.com>
5662         [GTK][WK2] Back items are shown in reverse order in MiniBrowser
5663         https://bugs.webkit.org/show_bug.cgi?id=126354
5665         Reviewed by Carlos Garcia Campos.
5667         The latest visited site for backward history should be placed on the top of a history stack
5668         as a common behavior. However currently its order is reverse.
5670         * MiniBrowser/gtk/BrowserWindow.c:
5671         (browserWindowUpdateNavigationActions):
5673 2013-12-30  Martin Robinson  <mrobinson@igalia.com>
5675         [GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build
5676         https://bugs.webkit.org/show_bug.cgi?id=126297
5678         Reviewed by Philippe Normand.
5680         * Scripts/run-gtk-tests: Looks for the tests in the new directories.
5681         (TestRunner): Ditto.
5682         (TestRunner._run_test): Ditto.
5684 2013-12-30  Alexey Proskuryakov  <ap@apple.com>
5686         full_results.json should distinguish unexpected failures from expected ones
5687         https://bugs.webkit.org/show_bug.cgi?id=126300
5689         Reviewed by Timothy Hatcher.
5691         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
5692         (summarize_results): Add "report" element to JSON, which tells the consumer how
5693         this result was counted for summary.
5695         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
5696         Updated results to include the new element.
5698         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
5699         (print_unexpected_results): Added a comment pointing to another place that
5700         summarizes results, and should stay in sync.
5702 2013-12-30  Ryuan Choi  <ryuan.choi@samsung.com>
5704         Replace remaning CoreIPC namespace to IPC
5705         https://bugs.webkit.org/show_bug.cgi?id=126305
5707         Reviewed by Anders Carlsson.
5709         * TestWebKitAPI/CMakeLists.txt: Replaced CoreIPC includes to IPC.
5710         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed temporal define for IPC.
5711         * WebKitTestRunner/CMakeLists.txt: Replaced CoreIPC includes to IPC.
5712         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed temporal define for IPC.
5714 2013-12-30  Brendan Long  <self@brendanlong.com>
5716         Add myself to the committers list.
5718         Unreviewed.
5720         * Scripts/webkitpy/common/config/contributors.json:
5722 2013-12-30  Carlos Garcia Campos  <cgarcia@igalia.com>
5724         [GTK] Split WebKit2APITests/TestWebKitWebView
5725         https://bugs.webkit.org/show_bug.cgi?id=126284
5727         Reviewed by Philippe Normand.
5729         Skip only WebKitWebView/mouse-target and all TestAuthentication
5730         tests that are timing out when running under xvfb.
5732         * Scripts/run-gtk-tests:
5733         (TestRunner):
5735 2013-12-29  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
5737         [EFL][WK2] Disable geolocation API test
5738         https://bugs.webkit.org/show_bug.cgi?id=125851
5740         Reviewed by Gyuyoung Kim.
5742         Geolocation is turned off by default in EFL port, so it shouldn't be tested.
5744         * TestWebKitAPI/PlatformEfl.cmake: Move Geolocation to test_webkit2_api_fail_BINARIES.
5746 2013-12-29  Ryuan Choi  <ryuan.choi@samsung.com>
5748         [EFL] Remove ewk_view_tiled
5749         https://bugs.webkit.org/show_bug.cgi?id=125961
5751         Reviewed by Gyuyoung Kim.
5753         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
5754         (shouldUseTiledBackingStore):
5755         Moved from DumpRenderTreeChrome to enable WebCore's TiledBackingStore
5756         instead of switching ewk_view_tiled.
5757         (DumpRenderTreeChrome::createView):
5758         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
5759         (drtViewAdd):
5760         * EWebLauncher/main.c: Removed ewk_view_tiled option.
5761         (windowCreate):
5762         (parseUserArguments):
5764 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
5766         Pending revision popover is slightly misplaced at build.webkit.org/dashboard
5767         https://bugs.webkit.org/show_bug.cgi?id=126278
5769         Reviewed by Timothy Hatcher.
5771         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
5772         (BuildbotQueueView.prototype._appendPendingRevisionCount): Create a span for the text,
5773         as StatusLineView message element has extra padding, and doesn't fit the text snugly.
5774         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Added bug number to a FIXME.
5776         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
5777         (StatusLineView.prototype.set messageElement): Removed the getter, as we no longer need it.
5779         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
5780         Removed display:inline-block hack for messageElement div, as we no longer use it for measuring text bounds.
5782 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
5784         Interrupted test runs should not count at build.webkit.org/dashboard
5785         https://bugs.webkit.org/show_bug.cgi?id=126279
5787         Reviewed by Timothy Hatcher.
5789         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
5790         (BuildbotIteration.prototype.get productive):
5791         (BuildbotIteration.prototype.get previousProductiveIteration): Replaced previous with
5792         this accessor to skips iterations that don't have relevant data. We still want to
5793         display them, but revision ranges should not be affected.
5794         (BuildbotIteration.prototype.update): Record whether the iteration was up for retry.
5796         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
5797         Use latest productive iteration instead of latest iteration for pending revision
5798         count and popovers.
5800 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
5802         Please display (and link to) revision ranges at build.webkit.org/dashboard
5803         https://bugs.webkit.org/show_bug.cgi?id=122187
5805         Reviewed by Timothy Hatcher.
5807         Added popovers for revision numbers. Removed direct links, because they were misleading -
5808         a test run covers a revision range, not just the latest revision. This also makes
5809         selecting a revision for copy easier.
5811         All revision numbers have the popovers for consistency, although they are most useful
5812         for iterations that are not the last ones in a view, because the content is a delta
5813         from previous iteration.
5815         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
5816         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
5817         revisionLinksForIteration() is now named revisionContentForIteration().
5819         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
5820         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
5821         Ditto.
5823         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
5824         (BuildbotIteration.prototype.get previous): Added a function to go back in iteration history.
5826         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
5827         Refactored to support the new popover variation. Replaced revisionLinksForIteration()
5828         with a function that builds an element with popover.
5830         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
5831         Changed to take a function for popover presentation instead of delegate object.
5832         We only need one delegate function, and it's easier to have multiple popovers per view class
5833         this way.
5835         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
5836         Removed a rule for selectable class. It's replaced with a semantic rule in StatusLineView.css.
5838         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
5839         Renamed pending-commits-popover class to commit-history-popover.
5841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
5842         (.status-line .message .revision-number): Added a rule for revision numbers.
5844 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
5846         Please display information about pending runs in build.webkit.org/dashboard
5847         https://bugs.webkit.org/show_bug.cgi?id=122180
5849         Reviewed by Timothy Hatcher.
5851         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
5852         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Added a semicolon at the end of a line.
5854         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
5855         (BuildbotQueueView.prototype._latestFinishedIteration): Factored out of _appendPendingRevisionCount.
5856         (BuildbotQueueView.prototype._appendPendingRevisionCount): Install a popover tracker over the element.
5857         (BuildbotQueueView.prototype.lineForCommit): Build an element for a particular commit ot be shown in popover.
5858         (BuildbotQueueView.prototype.presentPopoverForElement): Build and show popover content when PopoverTracker
5859         asks us to.
5861         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Geometry.js: Added.
5862         Taken from WebInspector with minimal changes:
5863         - Changed root name from WebInspector to Dashboard.
5864         - Removed some unused functionality.
5865         - Added Rect.containsPoint.
5867         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js: Added.
5868         Popover has extensive changes compared to WebInspector version, only drawing code is the same:
5869         - Fixed to work in scrollable pages - WebInspector version assumes that window
5870         and document coordinates are the same, and also erroneously dismisses a scrollable
5871         popover if scrolling cascades out of it after reaching a bound.
5872         - Simplified API and implementation to Dashboard needs, it is no longer possible to
5873         change content of an existing popover.
5874         - Rewrote visibility tracking to be more complete, and not rely on external tracker
5875         object so much.
5876         - Added code to flash scroll bars when showing a scrollable popover.
5878         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js: Added.
5879         Objects of this class show and hide popovers as appropriate for registered active elements.
5881         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
5882         (StatusLineView.prototype.get messageElement): Added an accessor, so that we could
5883         install a popover on message element. It's the only visible element in pending commit
5884         line, but the line has different bounds, so we can't install a popover on it (it
5885         would be incorrectly positioned if we did).
5887         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
5888         (Trac.prototype._convertCommitInfoElementToObject):
5889         - Some trac installations report author in a different element, updated to support that.
5890         - Changed to parse title out of description, because trac titles are ugly. Also,
5891         we get a nice HTML with links from the description.
5893         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
5894         (Node.prototype.isAncestor): Copied from Web Inspector, only changing the form for
5895         consistency with the rest of this file (add a property on prototype with assignment
5896         instead of using Object.defineProperty).
5897         (Node.prototype.isDescendant): Ditto.
5898         (Node.prototype.isSelfOrAncestor): Ditto.
5899         (Node.prototype.isSelfOrDescendant): Ditto.
5900         (DOMTokenList.prototype.contains): Ditto.
5902         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css: Added.
5903         Like JS counterpart, mostly lifted from Web Inspector.
5905         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
5906         Added style rules for pending commits popover.
5908         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
5909         (.status-line.no-bubble .message): Changed to display:inline-block, so that it fits
5910         to content, and we can show the popover in a correct place.
5912         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added new files.
5914 2013-12-27  Gavin Barraclough  <barraclough@apple.com>
5916         Merge PageVisibilityState & ViewState::IsVisible in WebKit2
5917         https://bugs.webkit.org/show_bug.cgi?id=126214
5919         Reviewed by Alexey Proskuryakov.
5921         WebKit2 redundantly tracks the visibility of the view through two mechanisms - the visibility
5922         state, and the view state. Remove visibility state from the WebKit2 layer. The visibility
5923         state also tracks the prerender state - so split this out and handle it separately (a change
5924         we should make in WebCore, too).
5926         Tools - WebKit2 no longer (poorly) supports a fake visibility state, so to test the page
5927         visibility mechanisms we should actually be changing characteristics of the view that will
5928         be detected by WebKit2 as a visibility change. This affects three things:
5929             1) On setVisibilityState WebKitTestRunner must actually change visibility of the view.
5930             2) The 'PageVisibilityState' test in the API tests is useless (as evidenced by the fact
5931                that page visibility has been broken in WebKit2 for a couple of months, and didn't
5932                catch this fact). Removed in favour of:
5933             3) 'PageVisibilityStateWithWindowChanges' - this is the good stuff. This actually tests
5934                the visibility mechanism. Beef this test up by adding coverage for: a) the prerender
5935             state, b) document.hidden, and c) too many state change notifications (it already looks
5936             for too few).
5938         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
5939         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Removed.
5940             - Removed PageVisibilityState - this test was ineffective, API no longer supports this
5941               test, and behaviour is covered by PageVisibilityStateWithWindowChanges.
5942         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
5943         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
5944         (runJavaScriptAlert):
5945             - Add checking for too many calls to the alert.
5946         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::setPrerender):
5947             - Added methods to set visibility to prerender.
5948         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
5949             - Added checking of 'document.hidden'.
5950         * WebKitTestRunner/TestController.cpp:
5951         (WTR::TestController::setVisibilityState):
5952         * WebKitTestRunner/TestController.h:
5953         * WebKitTestRunner/efl/TestControllerEfl.cpp:
5954         (WTR::TestController::setHidden):
5955         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
5956         (WTR::TestController::setHidden):
5957         * WebKitTestRunner/mac/TestControllerMac.mm:
5958         (WTR::TestController::setHidden):
5959             - Add setHidden method; call this from setVisibilityState.
5961 2013-12-27  Alexey Proskuryakov  <ap@apple.com>
5963         Display EWS status on bot watcher's dashboard
5964         https://bugs.webkit.org/show_bug.cgi?id=126224
5966         Silence spurious exceptions, no visible behavior change.
5968         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
5969         (EWSQueue.prototype.update): Removed code that was only needed for an experimental
5970         feature that wasn't landed.
5972 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
5974         Display EWS status on bot watcher's dashboard
5975         https://bugs.webkit.org/show_bug.cgi?id=126224
5977         Reviewed by Timothy Hatcher.
5979         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
5980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added.
5981         Moved platform definitions out of Buildbot.js, as they are also needed for EWS.
5983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
5984         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js: Added.
5985         (QueueView):
5986         (QueueView.prototype.updateSoon):
5987         (QueueView.prototype.update):
5988         (QueueView.prototype._updateHiddenState):
5989         Moved auto-update and hide logic to a base class, as it equally applies to EWS.
5991         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Added.
5992         This is a peer to Buildbot.js and WebKitBuildbot.js.
5994         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Added.
5995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Added.
5996         Quite simple for now, only keeping track of queue size.
5997         
5998         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
5999         Initialize EWS.
6001         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
6002         Create EWS views.
6004         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
6005         Updated for Buildbot.Platform rename, it's now Dashboard.Platform.
6007         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Removed.
6008         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Removed.
6009         These were empty, no reason to waste the time loading them.
6011         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Removed.
6012         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css.
6013         Renamed, as these styles apply to all queues, not just buildbot ones (and they have to, as columns should look alike).
6015         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
6016             - Changed page title, as it no longer displays just buildbot status.
6017             - Updated subresource lists for the new, renamed and removed files.
6019 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
6021         EWS status JSON should include Access-Control-Allow-Origin
6022         https://bugs.webkit.org/show_bug.cgi?id=126246
6024         Reviewed by Ryosuke Niwa.
6026         * QueueStatusServer/app.yaml: Update version.
6027         * QueueStatusServer/handlers/queuestatusjson.py:
6028         (QueueStatusJSON.get): Add the header field.
6030 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
6032         Some links at build.webkit.org/dashboard don't show status messages, and aren't keyboard accessible
6033         https://bugs.webkit.org/show_bug.cgi?id=126234
6035         Reviewed by Timothy Hatcher.
6037         Changed elements that are semantically links from <div> to <a>.
6039         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
6040         (StatusLineView): Create <a> or <div> elements conditionally on whether we have a URL.
6041         Don't try simulate a link with CSS/JS, it's not needed any more.
6042         (StatusLineView.prototype._clicked): Removed.
6044         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
6045         Removed text-decoration rules, default ones in Main.css now work for queue elements.
6047         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
6048         Simplified cursor rules.
6049         Added a universal rule for links to only show underline on hover, as this is what
6050         we want almost everywhere.
6052         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
6053         (.status-line .bubble): Added text-decoration: none, as this is the one place where
6054         we don't want it even on hover.
6055         (.status-line .label): Force display: block for consistent layout between <a>
6056         and <div>.
6058 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
6060         Please clarify "pending" reporting at build.webkit.org/dashboard
6061         https://bugs.webkit.org/show_bug.cgi?id=122191
6063         Reviewed by Timothy Hatcher.
6065         Reporting the count of pending runs didn't make a lot of sense - first, runs are
6066         coalesced and sometimes even out of order, and second, buildbot's notion of pending
6067         run was confusingly different from dashboard's.
6069         Let's display how many SVN revisions are pending. This can be somewhat misleading
6070         too, because some revisions (like those for other platforms) don't trigger builds,
6071         but it's better than what we had.
6073         This patch also lays the groundwork for displaying detailed information about
6074         pending revisions.
6076         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
6077         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
6078         building pending status line directly, call newly added base class method.
6080         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
6081         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Ditto.
6083         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
6084         (BuildbotQueueView): Listen for events when new SVN revisions are landed, and update the view.
6085         (BuildbotQueueView.prototype._appendPendingRevisionCount): Add a line for pending
6086         SVN revisions. It uses a new style, StatusLineView.Status.NoBubble, because this
6087         information is secondary, and doesn't need as much attention.
6088         (BuildbotQueueView.prototype.revisionLinksForIteration): Build revisionURL through
6089         Trac, not through Buildbot.
6090         (BuildbotQueueView.prototype._newCommitsRecorded): Schedule an update, just like when
6091         iterations are updated.
6093         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
6094         Initialize a global webkitTrac object.
6096         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
6097         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
6098         Added a new style for messages without a bubble.
6100         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
6101         Added a model class for Trac, which keeps track of SVN timeline, and notifies
6102         listeners of changes. It uses an RSS interface to Trac, because there is no JSON one.
6104         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
6105         (loadXML): Added a function to load XML asynchronously, just like existing JSON.load.
6107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
6108         Removed tracRevisionURL() function. Now that we have a Trac object, it just makes
6109         more sense to build trac URLs through it.
6111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
6112         Load Trac.js.
6114 2013-12-25  Jongwoo Choi  <jw0330.choi@samsung.com>
6116         [EFL] Activate keyboard homepage shortcut on efl minibrowser.
6117         https://bugs.webkit.org/show_bug.cgi?id=124636
6119         Reviewed by Gyuyoung Kim.
6121         * MiniBrowser/efl/main.c: Added.
6122         (on_key_down): Add a homepage shortcut using Alt + Home key. 
6124 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
6126         Revision selection behavior at build.webkit.org/dashboard is annoying
6127         https://bugs.webkit.org/show_bug.cgi?id=126235
6129         Reviewed by Tim Horton.
6131         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
6132         (BuildbotQueueView.prototype.revisionLinksForIteration): Make the whole message
6133         selectable, not just the numbers in it.
6134         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
6135         (.selectable): Make selectable enable default behavior, not user-select:all.
6137 2013-12-25  Martin Robinson  <mrobinson@igalia.com>
6139         [GTK] [CMake] Clean up generated sources directories
6140         https://bugs.webkit.org/show_bug.cgi?id=126216
6142         Reviewed by Gustavo Noronha Silva.
6144         * DumpRenderTree/PlatformGTK.cmake: Use the new derived sources variables.
6145         * GtkLauncher/CMakeLists.txt: Ditto.
6146         * MiniBrowser/gtk/CMakeLists.txt: Ditto.
6147         * TestWebKitAPI/CMakeLists.txt: Now that the EFL and GTK+ forwarding header locations differ,
6148         move the platform-specific includes to the EFL and GTK platform files. Also clean up forwarding
6149         header generation into on target.
6150         * TestWebKitAPI/PlatformEfl.cmake: Added EFL-specific locations to the include list.
6151         * TestWebKitAPI/PlatformGTK.cmake: Added GTK-specific locations to the include list.
6152         * WebKitTestRunner/CMakeLists.txt: Same as for TestWebKitAPI.
6153         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
6154         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
6155         * gtk/generate-gtkdoc: Update to select the appropriate derived sources locations for
6156         the cmake build.
6158 2013-12-23  Alexey Proskuryakov  <ap@apple.com>
6160         Add a JSON interface for getting EWS queue status
6161         https://bugs.webkit.org/show_bug.cgi?id=126182
6163         Reviewed by Ryosuke Niwa.
6165         The current goal is to add an indicator of how many patches are in the queue, and
6166         the JSON also includes some other information that was easy to add.
6168         * QueueStatusServer/app.yaml: Updated version for deployment.
6170         * QueueStatusServer/handlers/queuestatusjson.py: Added. Returns a JSON with some
6171         bot and patch queue information.
6173         * QueueStatusServer/index.yaml: Added an index for a new query that only returns
6174         bot ids.
6176         * QueueStatusServer/main.py: Map /queue-status-json/ directory to QueueStatusJSON
6177         handler.
6179         * QueueStatusServer/config: Added property svn:ignore.
6180         * QueueStatusServer/filters: Added property svn:ignore.
6181         * QueueStatusServer/loggers: Added property svn:ignore.
6182         * QueueStatusServer/handlers: Added property svn:ignore.
6183         * QueueStatusServer/model: Added property svn:ignore.
6184         Ignore compiled *.pyc files in all directories they appear in when running locally.
6186 2013-12-23  Martin Robinson  <mrobinson@igalia.com>
6188         Try to fix the build after r161017
6190         * gtk/common.py:
6191         (is_cmake_build): Instead of checking whether the return value of build_path
6192         of the CMakeCache.txt file is None, check if a file actually exists at that path.
6194 2013-12-23  Gustavo Noronha Silva  <gns@gnome.org>
6196         [GTK] [CMake] Add support for generating gtkdoc
6197         https://bugs.webkit.org/show_bug.cgi?id=116376
6199         Reviewed by Martin Robinson.
6201         * gtk/common.py: look for files in the directories used by the cmake build as well.
6203 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
6205         [GTK] Build with network process unconditionally
6206         https://bugs.webkit.org/show_bug.cgi?id=126128
6208         Reviewed by Martin Robinson.
6210         * Scripts/webkitperl/FeatureList.pm: Remove network-process
6211         feature command line option.
6213 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
6215         [GTK] run-gtk-tests should always run glib tests with -k option
6216         https://bugs.webkit.org/show_bug.cgi?id=126132
6218         Reviewed by Philippe Normand.
6220         With -k command line option, gtester continues running all other
6221         test cases after a failure.
6223         * Scripts/run-gtk-tests:
6224         (TestRunner._run_test_glib): Use -k option when runing glib tests
6225         to not stop on failure.
6227 2013-12-22  Martin Robinson  <mrobinson@igalia.com>
6229         [GTK][CMake] Integrate GResource for inspector files (and others?)
6230         https://bugs.webkit.org/show_bug.cgi?id=125569
6232         Reviewed by Gustavo Noronha Silva.
6234         * gtk/generate-inspector-gresource-manifest.py: Added.
6236 2013-12-22  Csaba Osztrogonác  <ossy@webkit.org>
6238         Last URTBF after r160971 to make EFL build happy.
6240         * TestWebKitAPI/efl/PlatformWebView.cpp:
6241         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
6243 2013-12-21  Carlos Garcia Campos  <cgarcia@igalia.com>
6245         Unreviewed. Add myself to some more watch lists.
6247         * Scripts/webkitpy/common/config/watchlist: Watch also soup, gst
6248         and binding scripts patches.
6250 2013-12-20  Commit Queue  <commit-queue@webkit.org>
6252         Unreviewed, rolling out r160941.
6253         http://trac.webkit.org/changeset/160941
6254         https://bugs.webkit.org/show_bug.cgi?id=126095
6256         Doesn't handle subpixel layout being disabled (Requested by
6257         smfr on #webkit).
6259         * gdb/webkit.py:
6260         (JSCJSStringPrinter.to_string):
6261         (add_pretty_printers):
6262         * lldb/lldb_webkit.py:
6263         (WTFMediaTime_SummaryProvider):
6264         (WTFStringProvider.to_string):
6266 2013-12-20  Bem Jones-Bey  <bjonesbe@adobe.com>
6268         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in gdb and lldb
6269         https://bugs.webkit.org/show_bug.cgi?id=126080
6271         Reviewed by Anders Carlsson.
6273         This changes the output of printing LayoutUnits to be in px, removing
6274         the need to divide by 64 manually.
6276         This will lead to gdb output like:
6278         m_frameRect = {
6279             m_location = LayoutPoint(0px, 0px),
6280             m_size = LayoutSize(800px, 585px)
6281         }
6283         And lldb output like:
6285         (const WebCore::LayoutRect) $0 = {
6286           m_location = { x = 744px, y = 1px }
6287           m_size = { width = 236px, height = 40px }
6288         }
6290         This patch is based on patch for Blink by cbiesinger@chromium.org.
6292         * gdb/webkit.py:
6293         (WebCoreLayoutUnitPrinter):
6294         (WebCoreLayoutUnitPrinter.__init__):
6295         (WebCoreLayoutUnitPrinter.to_string):
6296         (WebCoreLayoutSizePrinter):
6297         (WebCoreLayoutSizePrinter.__init__):
6298         (WebCoreLayoutSizePrinter.to_string):
6299         (WebCoreLayoutPointPrinter):
6300         (WebCoreLayoutPointPrinter.__init__):
6301         (WebCoreLayoutPointPrinter.to_string):
6302         (add_pretty_printers):
6303         * lldb/lldb_webkit.py:
6304         (__lldb_init_module):
6305         (WebCoreLayoutUnit_SummaryProvider):
6306         (WebCoreLayoutSize_SummaryProvider):
6307         (WebCoreLayoutPoint_SummaryProvider):
6308         (WebCoreLayoutUnitProvider):
6309         (WebCoreLayoutUnitProvider.__init__):
6310         (WebCoreLayoutUnitProvider.to_string):
6311         (WebCoreLayoutSizeProvider):
6312         (WebCoreLayoutSizeProvider.__init__):
6313         (WebCoreLayoutSizeProvider.get_width):
6314         (WebCoreLayoutSizeProvider.get_height):
6315         (WebCoreLayoutPointProvider):
6316         (WebCoreLayoutPointProvider.__init__):
6317         (WebCoreLayoutPointProvider.get_x):
6318         (WebCoreLayoutPointProvider.get_y):
6320 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
6322         [GTK] [CMake] Add support for building ImageDiff
6323         https://bugs.webkit.org/show_bug.cgi?id=125960
6325         Reviewed by Gustavo Noronha Silva.
6327         * CMakeLists.txt: Build ImageDiff for GTK+.
6328         * ImageDiff/PlatformGTK.cmake: Added.
6330 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
6332         [GTK] [CMake] Add support for building DumpRenderTree
6333         https://bugs.webkit.org/show_bug.cgi?id=125767
6335         Reviewed by Gustavo Noronha Silva.
6337         * CMakeLists.txt: Load the DumpRenderTree cmake file for GTK+ when WebKit1 is enabled.
6338         * DumpRenderTree/PlatformGTK.cmake: Added.
6340 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
6342         [GTK] [CMake] Add support for building WebKitTestRunner
6343         https://bugs.webkit.org/show_bug.cgi?id=125768
6345         Reviewed by Gustavo Noronha Silva.
6347         * CMakeLists.txt: Compile WebKitTestRunner for GTK+ when WebKit2 is enabled.
6348         * WebKitTestRunner/CMakeLists.txt: Remove some EFL specific flags from the common
6349         build file.
6350         * WebKitTestRunner/PlatformEfl.cmake: Move the flags here.
6351         * WebKitTestRunner/PlatformGTK.cmake: Added.
6353 2013-12-20  Myles C. Maxfield  <mmaxfield@apple.com>
6355         Myles C. Maxfield is a committer now
6357         Unreviewed.
6359         * Scripts/webkitpy/common/config/contributors.json:
6361 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
6363         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
6364         https://bugs.webkit.org/show_bug.cgi?id=125854
6366         Reviewed by Chris Fleizach.
6368         Ensure we don't ever create instances of AccessibilityUIElement
6369         wrapping invalid platform-specific accessibility objects in DRT,
6370         both for consistency with what WKTR does (so we avoid situations
6371         where some tests fail in WK2 and not in WK1) and also to avoid
6372         overlooking tests that might not be checking the right thing.
6374         * DumpRenderTree/AccessibilityUIElement.cpp:
6375         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
6376         nullPtr if the platformUIElement() is not a valid one.
6377         * DumpRenderTree/AccessibilityUIElement.h:
6378         (AccessibilityUIElement::platformUIElement): Added const modifier.
6380 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
6382         Programmatically-inserted children lack accessibility events
6383         https://bugs.webkit.org/show_bug.cgi?id=100275
6385         Reviewed by Chris Fleizach.
6387         Update DRT and WebKitTestRunner to handle the children-changed
6388         signal properly, considering the detail and optional parameters.
6390         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
6391         (axObjectEventListener):
6392         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
6394 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
6396         Removed unused BUILDER_BASE_URL.
6397         https://bugs.webkit.org/show_bug.cgi?id=125442
6399         Reviewed by Csaba Osztrogonác.
6401         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
6402         (JSONGeneratorTest._test_json_generation): Trivial test fix after r160900.
6404 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
6406         Removed unused BUILDER_BASE_URL.
6407         https://bugs.webkit.org/show_bug.cgi?id=125442
6409         Reviewed by Csaba Osztrogonác.
6411         The string constant BUILDER_BASE_URL is passed around several times,
6412         but we don't use it anywhere. It is a leftover from Chromium, cleaned it up.
6414         * Scripts/webkitpy/layout_tests/controllers/manager.py:
6415         (Manager._upload_json_files):
6416         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
6417         (JSONLayoutResultsGenerator.__init__):
6418         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
6419         (JSONResultsGenerator.__init__):
6421 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
6423         check-webkit-style mistakenly flags assigning to a dereferenced pointer
6424         https://bugs.webkit.org/show_bug.cgi?id=126041
6426         Reviewed by Ryosuke Niwa.
6428         When checking for lines like "Foo *bar;", check-webkit-style doesn't make
6429         sure that there is a declaration. This patch makes sure that there is a
6430         declaration in order to flag spacing around asterisks.
6432         * Scripts/webkitpy/style/checkers/cpp.py:
6433         (check_spacing):
6434         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
6435         (CppStyleTest.test_pointer_reference_marker_location):
6437 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
6439         check-webkit-style marks rvalue references as violations
6440         https://bugs.webkit.org/show_bug.cgi?id=126000
6442         Reviewed by Ryosuke Niwa.
6444         Previously, check-webkit-style was making sure that any line with "&&" had
6445         spaces around it. However, we can now legitimately use "&&" without a previous
6446         space when declaring an rvalue reference. This patch relaxes this check.
6448         * Scripts/webkitpy/style/checkers/cpp.py:
6449         (check_spacing):
6450         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
6451         (CppStyleTest.test_spacing_for_binary_ops):
6453 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
6455         check-webkit-style marks auto return types for functions as violations
6456         https://bugs.webkit.org/show_bug.cgi?id=125999
6458         Reviewed by Ryosuke Niwa.
6460         If a function declaration ends with a "->" followed by a non whitespace
6461         string, don't mark as an invalid "{" on its own line
6463         * Scripts/webkitpy/style/checkers/cpp.py:
6464         (check_braces):
6465         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
6466         (CppStyleTest.test_brace_at_begin_of_line):
6468 2013-12-19  Alex Christensen  <achristensen@webkit.org>
6470         [WinCairo] More GStreamer preparations.
6472         Unreviewed.
6474         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props:
6475         Include FeatureDefinesCairo and WinCairo to compile the GLib part of WinLauncher.
6477 2013-12-19  Lucas Forschler  <lforschler@apple.com>
6479         Add Apple Mavericks perf bot.
6480         
6481         Unreviewed.
6483         * BuildSlaveSupport/build.webkit.org-config/config.json:
6485 2013-12-19  Commit Queue  <commit-queue@webkit.org>
6487         Unreviewed, rolling out r160842.
6488         http://trac.webkit.org/changeset/160842
6489         https://bugs.webkit.org/show_bug.cgi?id=126003
6491         broke accessibility/loading-iframe-updates-axtree.html
6492         (Requested by ap on #webkit).
6494         * DumpRenderTree/AccessibilityUIElement.cpp:
6495         (AccessibilityUIElement::makeJSAccessibilityUIElement):
6496         * DumpRenderTree/AccessibilityUIElement.h:
6497         (AccessibilityUIElement::platformUIElement):
6499 2013-12-19  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
6501         get_test_baseline should get Host from test_config
6502         https://bugs.webkit.org/show_bug.cgi?id=125989
6504         Reviewed by Ryosuke Niwa.
6506         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
6507         (TestConfig.__init__):
6508         (RebaselineServer._prepare_config):
6509         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
6510         (get_test_baselines):
6511         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
6512         (get_test_config):
6514 2013-12-19  Roger Fong  <roger_fong@apple.com>
6516         Don't check VSINSTALLDIR when looking for Visual Studio install directory.
6517         https://bugs.webkit.org/show_bug.cgi?id=125998.
6519         Reviewed by Alexey Proskuryakov.
6521         * Scripts/webkitdirs.pm:
6522         (visualStudioInstallDir):
6523         Get rid of the VSINSTALLDIR check. We can't build on anything besides VS2013 now anyways.
6525 2013-12-19  Mario Sanchez Prada  <mario.prada@samsung.com>
6527         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
6528         https://bugs.webkit.org/show_bug.cgi?id=125854
6530         Reviewed by Chris Fleizach.
6532         Ensure we don't ever create instances of AccessibilityUIElement
6533         wrapping invalid platform-specific accessibility objects in DRT,
6534         both for consistency with what WKTR does (so we avoid situations
6535         where some tests fail in WK2 and not in WK1) and also to avoid
6536         overlooking tests that might not be checking the right thing.
6538         * DumpRenderTree/AccessibilityUIElement.cpp:
6539         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
6540         nullPtr if the platformUIElement() is not a valid one.
6541         * DumpRenderTree/AccessibilityUIElement.h:
6542         (AccessibilityUIElement::platformUIElement): Added const modifier.
6544 2013-12-18  Anders Carlsson  <andersca@apple.com>
6546         Deprecate some WKMutableDictionary functions
6547         https://bugs.webkit.org/show_bug.cgi?id=125962
6549         Reviewed by Tim Horton.
6551         * TestWebKitAPI/PlatformUtilities.cpp:
6552         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
6553         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
6554         (TestWebKitAPI::didAssociateFormControls):
6555         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
6556         (TestWebKitAPI::WillLoadTest::willLoadURLRequest):
6557         (TestWebKitAPI::WillLoadTest::willLoadDataRequest):
6558         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
6559         (WTR::createMouseMessageBody):
6560         (WTR::EventSendingController::mouseMoveTo):
6561         (WTR::EventSendingController::leapForward):
6562         (WTR::createKeyDownMessageBody):
6563         (WTR::EventSendingController::mouseScrollBy):
6564         (WTR::EventSendingController::continuousMouseScrollBy):
6565         (WTR::EventSendingController::addTouchPoint):
6566         (WTR::EventSendingController::updateTouchPoint):
6567         (WTR::EventSendingController::setTouchModifier):
6568         (WTR::EventSendingController::setTouchPointRadius):
6569         (WTR::EventSendingController::touchStart):
6570         (WTR::EventSendingController::touchMove):
6571         (WTR::EventSendingController::touchEnd):
6572         (WTR::EventSendingController::touchCancel):
6573         (WTR::EventSendingController::clearTouchPoints):
6574         (WTR::EventSendingController::releaseTouchPoint):
6575         (WTR::EventSendingController::cancelTouchPoint):
6576         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
6577         (WTR::InjectedBundle::done):
6578         (WTR::InjectedBundle::setMockGeolocationPosition):
6579         (WTR::InjectedBundle::setCustomPolicyDelegate):
6580         (WTR::InjectedBundle::setVisibilityState):
6581         (WTR::InjectedBundle::queueLoad):
6582         (WTR::InjectedBundle::queueLoadHTMLString):
6583         * WebKitTestRunner/TestController.cpp:
6584         (WTR::TestController::initialize):
6585         (WTR::TestController::resetStateToConsistentValues):
6586         * WebKitTestRunner/TestInvocation.cpp:
6587         (WTR::updateThreadedScrollingForCurrentTest):
6588         (WTR::updateLayoutType):
6589         (WTR::TestInvocation::invoke):
6591 2013-12-18  Martin Robinson  <mrobinson@igalia.com>
6593         [GTK] [CMake] Add support for building GtkLauncher
6594         https://bugs.webkit.org/show_bug.cgi?id=125766
6596         Reviewed by Gustavo Noronha Silva.
6598         * CMakeLists.txt: Add the GtkLauncher subdirectory for the GTK port.
6599         * GtkLauncher/CMakeLists.txt: Added.
6600         * GtkLauncher/main.c: Support including the CMake config file.
6602 2013-12-18  Alex Christensen  <achristensen@webkit.org>
6604         [WinCairo] Preparation for GStreamer on Windows.
6605         https://bugs.webkit.org/show_bug.cgi?id=125946
6607         Reviewed by Brent Fulgham.
6609         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
6610         Use new GStreamer property sheets for WinCairo.
6611         * win/DLLLauncher/DLLLauncherMain.cpp:
6612         (modifyPath):
6613         (wWinMain):
6614         Prepend GStreamer bin directory to path if it exists.
6616 2013-12-18  Anders Carlsson  <andersca@apple.com>
6618         Remove now useless test.
6620         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
6621         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Removed.
6622         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Removed.
6623         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Removed.
6625 2013-12-18  Gavin Barraclough  <barraclough@apple.com>
6627         Fix page visibility api test, initialization in WebKit2
6628         https://bugs.webkit.org/show_bug.cgi?id=125933
6630         Reviewed by Anders Carlsson.
6632         The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
6633         (introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
6635         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
6636         (TestWebKitAPI::TEST_F):
6637             - Running a test on WebKit1 twice is not the same as running it on WebKit2!
6639 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
6641         Should not have identifiers with underscores in them, especially not leading underscores.
6642         https://bugs.webkit.org/show_bug.cgi?id=125847
6644         Reviewed by Darin Adler.
6646         * Scripts/webkitpy/style/checkers/cpp.py:
6647         (check_identifier_name_in_declaration):
6648         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
6649         (CppStyleTest.test_runtime_selfinit):
6650         (WebKitStyleTest.test_names):
6652 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
6654         False webkit-check-style warnings on *.
6655         https://bugs.webkit.org/show_bug.cgi?id=125915
6657         Reviewed by Darin Adler.
6659         * Scripts/webkitpy/style/checkers/cpp.py:
6660         (check_spacing):
6661         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
6662         (CppStyleTest.test_pointer_reference_marker_location):
6664 2013-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
6666         prepare-ChangeLog doesn't handle templates properly
6667         https://bugs.webkit.org/show_bug.cgi?id=125853
6669         Reviewed by Daniel Bates.
6671         * Scripts/prepare-ChangeLog:
6672         (get_function_line_ranges_for_cpp):
6673         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
6674         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
6675         (Class110<TemplateClass>::func36):
6677 2013-12-18  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
6679         Move expectation parsing out of the constructor of TestExpectations
6680         https://bugs.webkit.org/show_bug.cgi?id=125439
6682         Reviewed by Csaba Osztrogonác.
6684         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
6685         (LayoutTestRunnerTests._run_tests):
6686         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
6687         (LayoutTestRunnerTests.test_update_summary_with_result):
6688         * Scripts/webkitpy/layout_tests/controllers/manager.py:
6689         (Manager.run):
6690         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
6691         (ManagerTest.test_look_for_new_crash_logs):
6692         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
6693         (lint):
6694         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
6695         (TestExpectations.suffixes_for_expectations):
6696         (TestExpectations.__init__):
6697         (TestExpectations):
6698         (TestExpectations.parse_generic_expectations):
6699         (TestExpectations.parse_default_port_expectations):
6700         (TestExpectations.parse_override_expectations):
6701         (TestExpectations.parse_all_expectations):
6702         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
6703         (parse_exp):
6704         (SkippedTests.check):
6705         (SkippedTests.test_skipped_entry_dont_exist):
6706         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
6707         (run_results):
6708         * Scripts/webkitpy/tool/commands/queries.py:
6709         (PrintExpectations._model):
6710         * Scripts/webkitpy/tool/commands/rebaseline.py:
6711         (RebaselineTest._update_expectations_file):
6712         (RebaselineExpectations._update_expectations_files):
6713         (RebaselineExpectations._tests_to_rebaseline):
6715 2013-12-17  Jer Noble  <jer.noble@apple.com>
6717         Fix TimeRanges::intersectWith
6718         https://bugs.webkit.org/show_bug.cgi?id=118802
6720         Reviewed by Eric Carlson.
6722         Add unit tests for WebCore/TimeRanges.
6724         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
6725         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: Added.
6726         (TestWebKitAPI::ToString):
6727         (TestWebKitAPI::TEST):
6729 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
6731         Botwatcher's dashboard ceases to update itself after a while
6732         https://bugs.webkit.org/show_bug.cgi?id=125885
6734         Reviewed by Timothy Hatcher.
6736         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
6737         Removed code that checked for the view being hidden. It's none of model's business.
6739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
6740         (BuildbotQueueView): Find out what platform the view is for. Initlialize update timer.
6741         (BuildbotQueueView.prototype._updateHiddenState): Start or stop update timer as appropriate.
6742         We now stop the timer for hidden views.
6743         (BuildbotQueueView.prototype._updateQueues): Removed the logic for ignoring some updates.
6745 2013-12-17  Anders Carlsson  <andersca@apple.com>
6747         Fix the 32-bit build.
6749         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
6750         * MiniBrowser/MiniBrowserWebProcessPlugIn.m:
6752 2013-12-17  Anders Carlsson  <andersca@apple.com>
6754         Give the MiniBrowser a bundle
6755         https://bugs.webkit.org/show_bug.cgi?id=125882
6757         Reviewed by Sam Weinig.
6759         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Added.
6760         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
6761         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Added.
6762         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Added.
6763         (-[MiniBrowserWebProcessPlugIn webProcessPlugIn:initializeWithObject:]):
6764         * MiniBrowser/mac/AppDelegate.m:
6765         (-[BrowserAppDelegate init]):
6766         * MiniBrowser/mac/Bundle/Info.plist: Added.
6767         * MiniBrowser/mac/Bundle/MiniBrowserBundle_Prefix.pch: Added.
6769 2013-12-17  Gavin Barraclough  <barraclough@apple.com>
6771         Remove PageVisibilityStateUnloaded
6772         https://bugs.webkit.org/show_bug.cgi?id=125869
6774         Reviewed by Anders Carlsson.
6776         This is not currently supported by WebKit, remove this enum value.
6777         We can always add this back later if/when we add support for this state.
6779         * DumpRenderTree/mac/TestRunnerMac.mm:
6780         (TestRunner::setPageVisibility):
6781         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
6782         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
6783         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
6784         (WTR::TestRunner::setPageVisibility):
6785             - remove test for visibility state "unloaded"; this is no longer supported (it never really was).
6787 2013-12-12  Martin Robinson  <mrobinson@igalia.com>
6789         [GTK] [CMake] Build the plugin process against GTK+ 2
6790         https://bugs.webkit.org/show_bug.cgi?id=116374
6792         Reviewed by Gustavo Noronha Silva.
6794         * TestWebKitAPI/PlatformGTK.cmake: Add WebCorePlatformGTK to the list of
6795         libraries required for WebCore unit tests.
6797 2013-12-17  Brent Fulgham  <bfulgham@apple.com>
6799         [Win] Revise filter-build-webkit to deal with Windows build logs
6800         https://bugs.webkit.org/show_bug.cgi?id=125866
6802         Reviewed by David Kilzer.
6804         Enhance the script to accept a 'platform' argument. When platform
6805         'win' is provided, use processing for the Windows build file format.
6806         Otherwise, process the files as normal.
6808         * Scripts/filter-build-webkit:
6809         (usageAndExit): Add a 'platform' argument
6810         (shouldIgnoreLine): When platform == 'win' use the new Windows
6811         rules for processing the build file.
6813 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
6815         Update style checker now that ENUM_CLASS is gone
6816         https://bugs.webkit.org/show_bug.cgi?id=125864
6818         Reviewed by Anders Carlsson.
6820         * Scripts/webkitpy/style/checkers/cpp.py:
6821         (_EnumState.process_clean_line):
6822         (check_braces):
6823         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
6824         (NoNonVirtualDestructorsTest.test_enum_casing.Foo):
6825         (NoNonVirtualDestructorsTest.test_enum_casing):
6826         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123):
6827         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass):
6828         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum):
6829         (WebKitStyleTest.test_braces.CPP11EnumClass):
6831 2013-12-17  Mario Sanchez Prada  <mario.prada@samsung.com>
6833         [ATK] Expose accessibility objects for <dl>, <dt> and <dd>
6834         https://bugs.webkit.org/show_bug.cgi?id=125857
6836         Reviewed by Chris Fleizach.
6838         Add mappings to DRT & WKTR for the newly exposed roles, and
6839         increase the version of ATK used by the internal jhbuild.
6841         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
6842         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
6843         * gtk/jhbuild.modules: Raise version of ATK up to 2.11.4.
6845 2013-12-17  Alex Christensen  <achristensen@webkit.org>
6847         [WinCairo] Adding support for GStreamer and GLib.
6848         https://bugs.webkit.org/show_bug.cgi?id=124867
6850         Reviewed by Philippe Normand.
6852         * WinLauncher/WinLauncher.cpp:
6853         (wWinMain):
6854         Added g_main_context_iteration in main event loop.
6856 2013-12-17  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
6858         Fix for C++ should have the & or * beside the type not the variable name check.
6859         https://bugs.webkit.org/show_bug.cgi?id=125846
6861         Reviewed by Darin Adler.
6863         * Scripts/webkitpy/style/checkers/cpp.py:
6864         (check_spacing):
6865         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
6866         (CppStyleTest.test_pointer_reference_marker_location):
6868 2013-12-16  Rob Buis  <rob.buis@samsung.com>
6870         Add my Samsung email address.
6872         Unreviewed.
6874         * Scripts/webkitpy/common/config/contributors.json:
6876 2013-12-16  Oliver Hunt  <oliver@apple.com>
6878         Cache getters and custom accessors on the prototype chain
6879         https://bugs.webkit.org/show_bug.cgi?id=125602
6881         Reviewed by Michael Saboff.
6883         Make sure bencher scripts also make noInline exist
6885         * Scripts/bencher:
6887 2013-12-16  Anders Carlsson  <andersca@apple.com>
6889         Fix crash when trying to load a null HTML string
6890         https://bugs.webkit.org/show_bug.cgi?id=125801
6892         Reviewed by Dan Bernstein.
6894         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
6895         (TestWebKitAPI::TEST_F):
6896         Update test results.
6898 2013-12-16  Alex Christensen  <achristensen@webkit.org>
6900         Fixed Win64 build on VS2013.
6901         https://bugs.webkit.org/show_bug.cgi?id=125753
6903         Reviewed by Brent Fulgham.
6905         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
6906         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
6907         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
6908         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
6909         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
6910         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
6911         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
6912         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
6913         * win/record-memory/record-memory.vcxproj:
6914         Added correct PlatformToolset for 64-bit builds.
6916 2013-12-16  Simon Fraser  <simon.fraser@apple.com>
6918         Add a menu option to MiniBrowser to enable UI-side compositing
6919         https://bugs.webkit.org/show_bug.cgi?id=125793
6921         Reviewed by Anders Carlsson.
6922         
6923         Make it possible to test UI-side compositing in MiniBrowser WK2 windows.
6925         * MiniBrowser/mac/BrowserWindowController.h: Add optional protocol method
6926         to toggle UI-side compositing.
6927         * MiniBrowser/mac/MainMenu.xib: Add menu item to Debug menu.
6928         * MiniBrowser/mac/WK2BrowserWindowController.m:
6929         (-[WK2BrowserWindowController validateMenuItem:]):
6930         (-[WK2BrowserWindowController isUISideCompositingEnabled]):
6931         (-[WK2BrowserWindowController toggleUISideCompositing:]):
6932         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
6933         Adjust the window title to indicate whether the window is using UI-side compositing.
6935 2013-12-16  Commit Queue  <commit-queue@webkit.org>
6937         Unreviewed, rolling out r160645.
6938         http://trac.webkit.org/changeset/160645
6939         https://bugs.webkit.org/show_bug.cgi?id=125787
6941         Change breaks test-webkitpy (Requested by bfulgham on
6942         #webkit).
6944         * Scripts/prepare-ChangeLog:
6945         (get_selector_line_ranges_for_css):
6947 2013-12-16  David Farler  <dfarler@apple.com>
6949         [ASAN] WebKitLauncher: Include libasancrashreporter.dylib in DYLD_INSERT_LIBRARIES if it exists
6950         https://bugs.webkit.org/show_bug.cgi?id=124610
6952         Reviewed by Mark Rowe.
6954         * WebKitLauncher/WebKitNightlyEnabler.m:
6955         (enableWebKitNightlyBehaviour):
6956         Add libasancrashreporter.dylib to DYLD_INSERT_LIBRARIES.
6957         * WebKitLauncher/main.m:
6958         (main):
6959         Include both libasancrashreporter and the nightly enabler to
6960         the list of libraries to insert.
6962 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
6964         Resolve inconsistant style warning caused by r160319.
6965         https://bugs.webkit.org/show_bug.cgi?id=125772
6967         Reviewed by Darin Adler.
6969         * Scripts/webkitpy/style/checkers/cpp.py:
6970         (check_for_extra_new_line_at_eof):
6971         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
6972         (CppStyleTest.test_newline_at_eof):
6973         (CppStyleTest.test_extra_newlines_at_eof):
6975 2013-12-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
6977         Remove mock_drt.py: parse_options() - --test-shell and --pixel-tests=<path>
6978         https://bugs.webkit.org/show_bug.cgi?id=125780
6980         Reviewed by Darin Adler.
6982         * Scripts/webkitpy/port/mock_drt.py:
6983         (main):
6984         (parse_options):
6985         (MockDRT.write_test_output):
6986         * Scripts/webkitpy/port/mock_drt_unittest.py:
6987         (MockDRTTest.assertTest):
6988         (MockDRTTest.test_reftest_mismatch):
6990 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
6992         prepare-Changelog treats CSS keyframes as mismatched parentheses.
6993         https://bugs.webkit.org/show_bug.cgi?id=125435
6995         Reviewed by Darin Adler.
6997         * Scripts/prepare-ChangeLog:
6998         (get_selector_line_ranges_for_css):
7000 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
7002         [ATK] Expose accessibility objects for more WAI-ARIA roles
7003         https://bugs.webkit.org/show_bug.cgi?id=125596
7005         Reviewed by Chris Fleizach.
7007         Add mappings to DRT & WKTR for the newly exposed roles.
7009         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
7010         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
7012 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
7014         [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
7015         https://bugs.webkit.org/show_bug.cgi?id=125594
7017         Reviewed by Chris Fleizach.
7019         Add mappings to DRT & WKTR for checkmenuitem role.
7021         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
7022         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
7024 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
7026         [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
7027         https://bugs.webkit.org/show_bug.cgi?id=125587
7029         Reviewed by Chris Fleizach.
7031         Add mappings to DRT & WKTR for article roles.
7033         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
7034         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
7036 2013-12-16  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
7038         [FTL] Allow EFL to build FTL with the build-jsc script.
7039         https://bugs.webkit.org/show_bug.cgi?id=125774
7041         Reviewed by Zoltan Herczeg.
7043         * Scripts/build-jsc:
7045 2013-12-16  Krzysztof Czech  <k.czech@samsung.com>
7047         Add myself as a committer
7049         Unreviewed.
7051         * Scripts/webkitpy/common/config/contributors.json:
7053 2013-12-15  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
7055         Refactor option handling in WebKitTestRunner.
7056         https://bugs.webkit.org/show_bug.cgi?id=123185
7058         Reviewed by Darin Adler.
7060         Option handling is refactored (according to the FIXME) that allows
7061         to automatically generate the help message.
7063         * WebKitTestRunner/CMakeLists.txt:
7064         * WebKitTestRunner/GNUmakefile.am:
7065         * WebKitTestRunner/Options.cpp: Added.
7066         (WTR::Options::Options):
7067         (WTR::handleOptionTimeout):
7068         (WTR::handleOptionNoTimeout):
7069         (WTR::handleOptionNoTimeoutAtAll):
7070         (WTR::handleOptionVerbose):
7071         (WTR::handleOptionGcBetweenTests):
7072         (WTR::handleOptionPixelTests):
7073         (WTR::handleOptionPrintSupportedFeatures):
7074         (WTR::handleOptionComplexText):
7075         (WTR::handleOptionAcceleratedDrawing):
7076         (WTR::handleOptionRemoteLayerTree):
7077         (WTR::handleOptionUnmatched):
7078         (WTR::OptionsHandler::OptionsHandler):
7079         (WTR::Option::Option):
7080         (WTR::Option::matches):
7081         (WTR::OptionsHandler::parse):
7082         (WTR::OptionsHandler::printHelp):
7083         * WebKitTestRunner/Options.h: Added.
7084         * WebKitTestRunner/TestController.cpp:
7085         (WTR::TestController::initialize):
7086         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
7088 2013-12-15  Dan Bernstein  <mitz@apple.com>
7090         32-bit build fix.
7092         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
7093         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
7095 2013-12-14  Tim Horton  <timothy_horton@apple.com>
7097         stylebot should warn when FeatureDefines differ
7098         https://bugs.webkit.org/show_bug.cgi?id=125748
7100         Reviewed by Dan Bernstein.
7102         Add a stylebot checker that ensures that FeatureDefines.xcconfig files
7103         are always exactly equal (and warns people adding new FeatureDefines.xcconfig files,
7104         an unlikely occurrance, to add them to the list).
7106         It's a bit nontraditional for stylebot because it will warn on existing errors in the tree,
7107         but that is the most straightforward way to implement it (and we're at zero diffs right now).
7109         * Scripts/webkitpy/style/checker.py:
7110         (_all_categories):
7111         (FileType):
7112         (CheckerDispatcher._file_type):
7113         (CheckerDispatcher._create_checker):
7114         * Scripts/webkitpy/style/checkers/featuredefines.py: Added.
7115         (FeatureDefinesChecker):
7116         (FeatureDefinesChecker.__init__):
7117         (FeatureDefinesChecker.check):
7119 2013-12-13  Sam Weinig  <sam@webkit.org>
7121         Fix API tests.
7123         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
7124         (TestWebKitAPI::TEST_F):
7126 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
7128         [Win] Remove Pre-VS2013 support code.
7129         https://bugs.webkit.org/show_bug.cgi?id=125693
7131         Reviewed by Darin Adler.
7133         * DumpRenderTree/cg/ImageDiffCG.cpp: Remove strtof stub now supplied by
7134         the math library.
7135         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
7137 2013-12-13  Lucas Forschler  <lforschler@apple.com>
7139         Update Webkit bots.
7140         
7141         Unreviewed.
7142         
7143         * BuildSlaveSupport/build.webkit.org-config/config.json:
7145 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
7147         [Win] Unreviewed build fix after r160548
7149         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Specify
7150         we are using vs12_xp target for Makefile-based projects.
7152 2013-12-13  Lucas Forschler  <lforschler@apple.com>
7154         Update Apple Webkit Bots
7155         
7156         Unreviewed.
7158         * BuildSlaveSupport/build.webkit.org-config/config.json:
7160 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
7162         Unreviewed build fix after r160548.
7164         * Scripts/webkitdirs.pm:
7165         (setupCygwinEnv): VCExpress.exe is now called WDExpress.exe.
7167 2013-12-13  Lucas Forschler  <lforschler@apple.com>
7169         Update Apple bots.
7170         
7171         Unreviewed.
7173         * BuildSlaveSupport/build.webkit.org-config/config.json:
7175 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
7177         [Win] Switch WebKit solution to Visual Studio 2013
7178         https://bugs.webkit.org/show_bug.cgi?id=125192
7180         Reviewed by Anders Carlsson.
7182         Project files must reference vs12_xp for 32-bit builds. 
7184         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
7185         Update for VS2013
7186         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
7187         Ditto
7188         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
7189         Ditto
7190         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
7191         Ditto
7192         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
7193         Ditto
7194         * Scripts/webkitdirs.pm:
7195         (visualStudioInstallDir): Specify VS2013
7196         (visualStudioVersion): Ditto.
7197         (setupAppleWinEnv): Use VS2013 in messages
7198         (setupCygwinEnv): Ditto
7199         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
7200         Update for VS2013
7201         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
7202         Ditto
7203         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
7204         Ditto
7205         * win/record-memory/record-memory.vcxproj:
7206         Ditto
7208 2013-12-11  Martin Robinson  <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
7210         Adding a .ycm_extra_conf file for webkitGtk
7211         https://bugs.webkit.org/show_bug.cgi?id=119618
7213         Reviewed by Gustavo Noronha Silva.
7215         Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
7216         read the GTK+ build files to determine dynamically what flags to compile a source
7217         file with. This allows Vim to provide auto-complete for C++/C language. See
7218         https://github.com/Valloric/YouCompleteMe for how to use this file.
7220         * gtk/common.py:
7221         (get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
7222         * gtk/ycm_extra_conf.py: Added.
7224 2013-12-12  Tim Horton  <timothy_horton@apple.com>
7226         [wk2] Handle pinch-to-zoom gesture
7227         https://bugs.webkit.org/show_bug.cgi?id=125604
7229         Reviewed by Simon Fraser.
7231         * MiniBrowser/mac/WK2BrowserWindowController.m:
7232         (-[WK2BrowserWindowController awakeFromNib]):
7233         Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
7235 2013-12-12  Eunmi Lee  <eunmi15.lee@samsung.com>
7237         Unreviewed. Add myself as a committer.
7239         * Scripts/webkitpy/common/config/contributors.json:
7241 2013-12-12  Lucas Forschler  <lforschler@apple.com>
7243         Update hardware for Apple bots.
7244         
7245         Unreviewed.
7247         * BuildSlaveSupport/build.webkit.org-config/config.json:
7249 2013-12-12  Lucas Forschler  <lforschler@apple.com>
7251         Remove unused Apple Bots.
7252         
7253         Unreviewed.
7255         * BuildSlaveSupport/build.webkit.org-config/config.json:
7257 2013-12-12  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
7259         Unreviewed. Add myself as a committer.
7261         * Scripts/webkitpy/common/config/contributors.json:
7263 2013-12-12  Joseph Pecoraro  <pecoraro@apple.com>
7265         Test new JSContext name APIs
7266         https://bugs.webkit.org/show_bug.cgi?id=125607
7268         Reviewed by Darin Adler.
7270         * Scripts/run-javascriptcore-tests:
7271         Remove trailing whitespace.
7273 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
7275         [Autotools] Prepend the WebCore layer archives' names with 'lib'
7276         https://bugs.webkit.org/show_bug.cgi?id=125627
7278         Reviewed by Martin Robinson.
7280         * TestWebKitAPI/GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended
7281         with 'lib' when they are used during linking, so the prefix is now added to avoid such issues.
7283 2013-12-12  Commit Queue  <commit-queue@webkit.org>
7285         Unreviewed, rolling out r160446.
7286         http://trac.webkit.org/changeset/160446
7287         https://bugs.webkit.org/show_bug.cgi?id=125630
7289         The upower-glib-based implementation is using API that was
7290         recently removed (Requested by zdobersek1 on #webkit).
7292         * Scripts/webkitperl/FeatureList.pm:
7294 2013-12-12  Commit Queue  <commit-queue@webkit.org>
7296         Unreviewed, rolling out r160417.
7297         http://trac.webkit.org/changeset/160417
7298         https://bugs.webkit.org/show_bug.cgi?id=125629
7300         The patch is causing crashes (Requested by zdobersek1 on
7301         #webkit).
7303         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
7304         (axObjectEventListener):
7305         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
7307 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
7309         Use of ar T option not supported by older binutils
7310         https://bugs.webkit.org/show_bug.cgi?id=118732
7312         Reviewed by Gustavo Noronha Silva.
7314         * TestWebKitAPI/GNUmakefile.am: To support non-thin archives when generating the WebCoreLayer archive,
7315         switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
7316         new archive. Non-thin archives also pose the problem as their members are only noted by the basename
7317         of the member's object file, and not the full path to it. To work around that, all the object files
7318         under the build directory are listed by their relative paths. The members of various archives then have
7319         the basenames of their paths grepped against that list, with the found path correlating to the member
7320         finally added as the new member of the WebCoreLayer archive.
7322 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
7324         check-webkit-style shouldn't check spacing in #if preprocessor lines
7325         https://bugs.webkit.org/show_bug.cgi?id=125534
7327         Reviewed by Ryosuke Niwa.
7329         Preprocessor lines that start with #if shouldn't have to adhere to
7330         the same spacing requirements that regular code does
7332         * Scripts/webkitpy/style/checkers/cpp.py:
7333         (check_spacing):
7334         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
7335         (CppStyleTest.test_spacing_for_binary_ops):
7336         (WebKitStyleTest.test_line_breaking):
7338 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
7340         check-webkit-style can't determine if a comma is part of an initialization list
7341         https://bugs.webkit.org/show_bug.cgi?id=125537
7343         Reviewed by Darin Adler.
7345         The original check to make sure that initialization list lines start with
7346         a comma didn't distinguish between commas that belong to the initialization
7347         list and commas that are part of function calls. Because we don't want to
7348         match parentheses with regular expressions, we should weaken this check to
7349         only check for commas at the end of initialization list lines.
7351         * Scripts/webkitpy/style/checkers/cpp.py:
7352         (check_member_initialization_list):
7353         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
7354         (WebKitStyleTest.test_member_initialization_list):
7356 2013-12-11  Tim Horton  <timothy_horton@apple.com>
7358         Make it possible to compare layout test results between various configurations of WebKit
7359         https://bugs.webkit.org/show_bug.cgi?id=125212
7360         <rdar://problem/15199108>
7362         Reviewed by Darin Adler.
7364         * Scripts/compare-webkit-configurations: Added.
7365         Add a script that allows comparison between the "normal" WebKit configuration
7366         used for testing and a different configuration (e.g. with accelerated drawing
7367         turned on, with the remote layer tree enabled, or WebKit1 vs WebKit2), like so:
7369         compare-webkit-configurations -2 --comparison=accelerated-drawing compositing/background-color
7371         This script runs the tests once in the default configuration, ignoring
7372         all test expectations, writing the results out to a temporary directory.
7374         It then runs the tests again in the modified configuration, against the
7375         just-written temporary results.
7377         Ref tests are treated as pixel tests, with their pixel output dumped to disk.
7379         * DumpRenderTree/mac/DumpRenderTree.mm:
7380         (resetWebPreferencesToConsistentValues):
7381         (initializeGlobalsFromCommandLineOptions):
7382         Enable accelerated drawing if requested.
7384         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7385         (parse_args):
7386         Add --accelerated-drawing and --remote-layer-tree feature switches, which
7387         are forwarded on to the test drivers.
7388         Move those two and --complex-text into their own "feature switches" section.
7389         Drive-by change "Mac OS X" to "OS X".
7390         Add --treat-ref-tests-as-pixel-tests option, which treats ref tests
7391         as traditional pixel tests (with PNGs dumped on disk), and
7392         ignores e.g. -expected.html files.
7394         * Scripts/webkitpy/port/base.py:
7395         (Port.reference_files):
7396         Pretend that there are no ref tests.
7397         Since is_reference_html_file is intact, our mechanism to ignore
7398         the expected files will continue working in this case.
7400         * Scripts/webkitpy/port/driver.py:
7401         (Driver.cmd_line):
7402         Forward --accelerated-drawing and --remote-layer-tree to DRT/WKTR.
7404         * WebKitTestRunner/TestController.cpp:
7405         (WTR::TestController::TestController):
7406         (WTR::TestController::initialize):
7407         (WTR::TestController::resetPreferencesToConsistentValues):
7408         * WebKitTestRunner/TestController.h:
7409         (WTR::TestController::shouldUseRemoteLayerTree):
7410         * WebKitTestRunner/TestInvocation.cpp:
7411         (WTR::updateThreadedScrollingForCurrentTest):
7412         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
7413         (WTR::PlatformWebView::PlatformWebView):
7414         Parse and implement the three feature switches.
7416 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
7418         [ATK] Expose accessibility objects WAI-ARIA landmark roles
7419         https://bugs.webkit.org/show_bug.cgi?id=125584
7421         Reviewed by Chris Fleizach.
7423         Add mappings to DRT & WKTR for landmark roles.
7425         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
7426         (AccessibilityUIElement::role):
7427         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
7428         (WTR::AccessibilityUIElement::role):
7429         * gtk/jhbuild.modules:
7431 2013-12-11  Alejandro G. Castro  <alex@igalia.com>
7433         [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
7434         https://bugs.webkit.org/show_bug.cgi?id=125441
7436         Reviewed by Martin Robinson.
7438         Just avoid the double quotations when building the parameter
7439         because some versions of valgrind are not handling it correctly.
7441         * Scripts/webkitpy/port/gtk.py:
7442         (GtkPort.setup_environ_for_server):
7444 2013-12-11  Zan Dobersek  <zdobersek@igalia.com>
7446         [GTK] Enable Battery Status API
7447         https://bugs.webkit.org/show_bug.cgi?id=125453
7449         Reviewed by Martin Robinson.
7451         * Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
7453 2013-12-11  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
7455         [GTK][WK2] Add the WebKitBatteryProvider class
7456         https://bugs.webkit.org/show_bug.cgi?id=115720
7458         Reviewed by Martin Robinson.
7460         * gtk/generate-gtkdoc:
7461         (get_webkit2_options): Ignore the WebKitBatteryProvider source files when generating the documentation.
7463 2013-12-11  Mark Rowe  <mrowe@apple.com>
7465         <https://webkit.org/b/125563> Remove the DumpRenderTree Perl Support module
7467         Now that old-run-webkit-tests is not used on OS X it's not worth the time and effort
7468         to build and maintain this custom Perl module.
7470         Reviewed by Anders Carlsson.
7472         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
7473         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Removed.
7474         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
7475         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
7476         * DumpRenderTree/mac/PerlSupport/Makefile: Removed.
7477         * Scripts/old-run-webkit-tests: Update a comment that referred to DumpRenderTreeSupport as a reason to
7478         build DumpRenderTree.
7479         (dumpToolDidCrash): Stop importing and using the module.
7480         * Scripts/webkitpy/port/base.py:
7481         (Port._build_driver): Update a comment in the same manner as in old-run-webkit-tests.
7483 2013-12-11  Brendan Long  <b.long@cablelabs.com>
7485         [GTK] Add "enable-mediasource" property to WebKitWebSettings
7486         https://bugs.webkit.org/show_bug.cgi?id=125566
7488         Reviewed by Philippe Normand.
7490         * DumpRenderTree/gtk/DumpRenderTree.cpp:
7491         (resetDefaultsToConsistentValues): Turn MediaSource on by default for easier testing.
7492         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
7493         (TestRunner::overridePreference): Allow overriding WebKitMediaSourceEnabled.
7495 2013-12-11  Dan Bernstein  <mitz@apple.com>
7497         [Mac] Observe the activeURL property to keep the MiniBrowser URL field up to date
7498         https://bugs.webkit.org/show_bug.cgi?id=125579
7500         Reviewed by Anders Carlsson.
7502         * MiniBrowser/mac/WK2BrowserWindowController.m:
7503         (-[WK2BrowserWindowController dealloc]): Stop observing the activeURL property.
7504         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): When the
7505         activeURL property changes, update the URL field with its value.
7506         (-[WK2BrowserWindowController awakeFromNib]): Start observing the activeURL property.
7507         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]): Just log.
7508         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
7509         Ditto.
7510         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]):
7511         Ditto.
7512         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
7513         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
7515 2013-12-11  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
7517         Fixed test-wepkitpy logging for buildslaves
7518         https://bugs.webkit.org/show_bug.cgi?id=125445
7520         Reviewed by Csaba Osztrogonác.
7522         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
7523         (RunPythonTests):
7525 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
7527         Programmatically-inserted children lack accessibility events
7528         https://bugs.webkit.org/show_bug.cgi?id=100275
7530         Reviewed by Chris Fleizach.
7532         Update DRT and WebKitTestRunner to handle the children-changed
7533         signal properly, considering the detail and optional parameters.
7535         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
7536         (axObjectEventListener):
7537         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
7539 2013-12-03  Mark Rowe  <mrowe@apple.com>
7541         <https://webkit.org/b/125139> Modernize the WebKit API headers
7542         <rdar://problem/15540175>
7544         Reviewed by Anders Carlsson.
7546         * DumpRenderTree/mac/TestRunnerMac.mm:
7547         (TestRunner::setCacheModel): Cast to the enum type.
7549 2013-12-10  Filip Pizlo  <fpizlo@apple.com>
7551         Get rid of forward exit on DoubleAsInt32
7552         https://bugs.webkit.org/show_bug.cgi?id=125552
7554         Reviewed by Oliver Hunt.
7555         
7556         Add some support for testing the generic (non-X86) paths on X86 by disabling
7557         architecture-specific optimizations (ASO's).
7559         * Scripts/run-javascriptcore-tests:
7560         * Scripts/run-jsc-stress-tests:
7562 2013-12-10  Ryuan Choi  <ryuan.choi@samsung.com>
7564         Unreviewed EFL build fix attempt
7566         * TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
7567         * WebKitTestRunner/CMakeLists.txt: Ditto.
7569 2013-12-10  Anders Carlsson  <andersca@apple.com>
7571         Add a HashMap constructor that takes an initializer list
7572         https://bugs.webkit.org/show_bug.cgi?id=125551
7574         Reviewed by Dan Bernstein.
7576         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
7577         (TestWebKitAPI::TEST):
7579 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
7581         Use std::array when computing MD5 checksum
7582         https://bugs.webkit.org/show_bug.cgi?id=125509
7584         Reviewed by Anders Carlsson.
7586         Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
7588         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
7589         (computeMD5HashStringForBitmapContext):
7590         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
7591         (computeMD5HashStringForBitmapContext):
7592         * TestWebKitAPI/Tests/WTF/MD5.cpp:
7593         (TestWebKitAPI::expectMD5):
7594         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
7595         (WTR::computeMD5HashStringForCairoSurface):
7596         * WebKitTestRunner/cg/TestInvocationCG.cpp:
7597         (WTR::computeMD5HashStringForContext):
7599 2013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
7601         [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
7602         https://bugs.webkit.org/show_bug.cgi?id=125522
7604         Reviewed by Chris Fleizach.
7606         Update strings representing ATK_ROLE_SEPARATOR for layout tests.
7608         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
7609         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
7611 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
7613         Add --makeargs option to build-jsc
7614         https://bugs.webkit.org/show_bug.cgi?id=125344
7616         Reviewed by Filip Pizlo.
7618         * Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
7620 2013-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
7622         AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
7623         https://bugs.webkit.org/show_bug.cgi?id=125497
7625         Reviewed by Mario Sanchez Prada.
7627         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
7628         (AccessibilityUIElement::stringForRange): Implemented.
7629         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
7630         (WTR::AccessibilityUIElement::stringForRange): Implemented.
7632 2013-12-10  Martin Robinson  <mrobinson@igalia.com>
7634         Various fixes for the CMake GTK+ build
7636         Reviewed by Gustavo Noronha.
7638         * MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
7639         * TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
7641 2013-12-10  László Langó  <lango@inf.u-szeged.hu>
7643         --cloop option does not work in Tools/Scripts/build-jsc.
7644         https://bugs.webkit.org/show_bug.cgi?id=125214
7646         Reviewed by Csaba Osztrogonác.
7648         * Scripts/build-jsc:
7650 2013-12-10  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
7652         Merge mark_for_landing and mark_for_commit_queue into one argument
7653         https://bugs.webkit.org/show_bug.cgi?id=125448
7655         Reviewed by Ryosuke Niwa.
7657         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
7658         (CommitQueueFlag):
7659         (Bugzilla._commit_queue_flag):
7660         (Bugzilla._fill_attachment_form):
7661         (Bugzilla.add_patch_to_bug):
7662         (Bugzilla.create_bug):
7663         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
7664         (test_commit_queue_flag.assert_commit_queue_flag):
7665         (test_commit_queue_flag):
7667 2013-12-09  Tim Horton  <timothy_horton@apple.com>
7669         Remove dead extract_reference_link.py (and the reftests module)
7670         https://bugs.webkit.org/show_bug.cgi?id=125116
7672         Reviewed by Ryosuke Niwa.
7674         This code doesn't seem to have ever been used.
7676         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Removed.
7677         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
7678         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
7680 2013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
7682         [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
7683         https://bugs.webkit.org/show_bug.cgi?id=125456
7685         Reviewed by Chris Fleizach.
7687         Return 'AXSection' for section roles instead of 'AXDiv'.
7689         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
7690         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
7692 2013-12-09  Brian J. Burg  <burg@cs.washington.edu>
7694         check-webkit-style should check for extra newlines at EOF
7695         https://bugs.webkit.org/show_bug.cgi?id=125424
7697         Reviewed by Darin Adler.
7699         Report a style violation if extraneous newlines are added
7700         to the end of a C++ file. There should only be one newline at EOF.
7702         * Scripts/webkitpy/style/checkers/cpp.py:
7703         (check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
7704         (check_for_extra_new_line_at_eof): Added.
7705         (_process_lines): Added new check and renamed existing EOF check.
7706         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
7707         (CppStyleTest.test_extra_newlines_at_eof): Added.
7708         (CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
7710 2013-12-09  Laszlo Vidacs  <lac@inf.u-szeged.hu>
7712         check-webkit-style: ternary operator in macro call identified as initialization list
7713         https://bugs.webkit.org/show_bug.cgi?id=125443
7715         Reviewed by Ryosuke Niwa.
7717         Do not match initialization list when questionmark is placed before :
7719         * Scripts/webkitpy/style/checkers/cpp.py:
7720         (check_member_initialization_list):
7722 2013-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
7724         AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
7725         https://bugs.webkit.org/show_bug.cgi?id=125451
7727         Reviewed by Mario Sanchez Prada.
7729         Create the needed callbacks for DRT and WKTR.
7731         * DumpRenderTree/AccessibilityUIElement.cpp:
7732         (characterAtOffsetCallback): added
7733         (wordAtOffsetCallback): added
7734         (lineAtOffsetCallback): added
7735         (sentenceAtOffsetCallback): added
7736         (AccessibilityUIElement::getJSClass):
7737         * DumpRenderTree/AccessibilityUIElement.h:
7738         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
7739         (stringAtOffset): added
7740         (AccessibilityUIElement::characterAtOffset): added
7741         (AccessibilityUIElement::wordAtOffset): added
7742         (AccessibilityUIElement::lineAtOffset): added
7743         (AccessibilityUIElement::sentenceAtOffset): added
7744         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
7745         (WTR::AccessibilityUIElement::characterAtOffset): added
7746         (WTR::AccessibilityUIElement::wordAtOffset): added
7747         (WTR::AccessibilityUIElement::lineAtOffset): added
7748         (WTR::AccessibilityUIElement::sentenceAtOffset): added
7749         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
7750         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
7751         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
7752         (WTR::stringAtOffset): added
7753         (WTR::AccessibilityUIElement::characterAtOffset): added
7754         (WTR::AccessibilityUIElement::wordAtOffset): added
7755         (WTR::AccessibilityUIElement::lineAtOffset): added
7756         (WTR::AccessibilityUIElement::sentenceAtOffset): added
7758 2013-12-08  Sam Weinig  <sam@webkit.org>
7760         32-bit MiniBrowser doesn't build
7761         https://bugs.webkit.org/show_bug.cgi?id=125420
7763         Reviewed by Dan Bernstein.
7765         * MiniBrowser/mac/AppDelegate.h:
7766         * MiniBrowser/mac/AppDelegate.m:
7767         (-[BrowserAppDelegate init]):
7768         (-[BrowserAppDelegate applicationWillTerminate:]):
7770 2013-12-08  Brian Holt  <brian.holt@samsung.com>
7772         [WK2] Add ENABLE_NETWORK_PROCESS flag
7773         https://bugs.webkit.org/show_bug.cgi?id=125421
7775         Add support to build with the Network Process enabled.
7777         Reviewed by Martin Robinson.
7779         * Scripts/webkitperl/FeatureList.pm:
7781 2013-12-07  Filip Pizlo  <fpizlo@apple.com>
7783         Fold typedArray.length if typedArray is constant
7784         https://bugs.webkit.org/show_bug.cgi?id=125252
7786         Reviewed by Sam Weinig.
7787         
7788         Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
7789         should put tests that run just like JSRegress but don't run as part of LayoutTests.
7790         Currently I'm using it for tests that require some surgical support from jsc.cpp.
7792         * Scripts/run-javascriptcore-tests:
7794 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
7796         [gdb] Update printers for WTF::CString, JSC::JSString
7797         https://bugs.webkit.org/show_bug.cgi?id=124600
7799         Reviewed by Gustavo Noronha Silva.
7801         Update the two printers after they fell behind the changes in implementation.
7803         * gdb/webkit.py:
7804         (WTFCStringPrinter.to_string):
7805         (JSCJSStringPrinter.to_string):
7807 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
7809         [webkitpy] Add a WestonDriver unit test
7810         https://bugs.webkit.org/show_bug.cgi?id=125408
7812         Reviewed by Gustavo Noronha Silva.
7814         Add a webkitpy unit test for the Weston driver.
7816         * Scripts/webkitpy/port/westondriver_unittest.py: Added.
7817         (WestonDriverTest):
7818         (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
7819         (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
7820         the server environment contains proper WAYLAND and GDK_BACKEND entries.
7821         (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
7822         the driver cleans up the temporary directory.
7823         (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
7824         (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
7826 2013-12-08  Brendan Long  <b.long@cablelabs.com>
7828         [Gtk] install-dependencies doesn't install libgtk-3-dev
7829         https://bugs.webkit.org/show_bug.cgi?id=125320
7831         Reviewed by Gustavo Noronha Silva.
7833         * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
7835 2013-12-07  Sam Weinig  <sam@webkit.org>
7837         [Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
7838         https://bugs.webkit.org/show_bug.cgi?id=125401
7840         Reviewed by Dan Bernstein.
7842         * MiniBrowser/mac/WK2BrowserWindowController.m:
7843         (-[WK2BrowserWindowController fetch:]):
7844         (-[WK2BrowserWindowController reload:]):
7845         (-[WK2BrowserWindowController goBack:]):
7846         (-[WK2BrowserWindowController goForward:]):
7847         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
7848         (-[WK2BrowserWindowController currentZoomFactor]):
7849         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
7850         (-[WK2BrowserWindowController zoomIn:]):
7851         (-[WK2BrowserWindowController zoomOut:]):
7852         (-[WK2BrowserWindowController canResetZoom]):
7853         (-[WK2BrowserWindowController resetZoom:]):
7854         (-[WK2BrowserWindowController toggleZoomMode:]):
7855         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
7857 2013-12-07  Sam Weinig  <sam@webkit.org>
7859         Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
7860         https://bugs.webkit.org/show_bug.cgi?id=125400
7862         Reviewed by Dan Bernstein.
7864         * MiniBrowser/mac/AppDelegate.h:
7865         * MiniBrowser/mac/AppDelegate.m:
7866         * MiniBrowser/mac/WK2BrowserWindowController.h:
7867         * MiniBrowser/mac/WK2BrowserWindowController.m:
7868         (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
7869         (-[WK2BrowserWindowController dealloc]):
7870         (createNewPage):
7871         (-[WK2BrowserWindowController awakeFromNib]):
7872         (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
7873         (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
7874         (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
7875         (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
7876         Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
7877         replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
7879 2013-12-07  Gustavo Noronha Silva  <gns@gnome.org>
7881         [GTK] Run each gtest subtest separately instead of in one go
7882         https://bugs.webkit.org/show_bug.cgi?id=125386
7884         Reviewed by Martin Robinson.
7886         This is what other ports are doing (except they build each test as a separate binary)
7887         and will help with the timeouts we sometimes hit because it applies to the full test
7888         run.
7890         * Scripts/run-gtk-tests:
7891         (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
7892         (TestRunner._run_google_test): run a single subtest from a gtest binary.
7893         (TestRunner._run_google_test_suite): call the binary once per subtest.
7895 2013-12-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
7897         Move PrettyPatch related code to prettypatch.py
7898         https://bugs.webkit.org/show_bug.cgi?id=124937
7900         Reviewed by Ryosuke Niwa.
7902         This code seems to have a better place here than in Port, since PrettyPatch already knows
7903         pretty_patch_path, and this also unifies the usage of PrettyPatch
7905         * Scripts/webkitpy/common/prettypatch.py:
7906         (PrettyPatch.__init__):
7907         (PrettyPatch.pretty_diff):
7908         (PrettyPatch):
7909         (PrettyPatch.pretty_patch_available):
7910         (PrettyPatch.check_pretty_patch):
7911         (PrettyPatch.pretty_patch_text):
7912         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
7913         (TestResultWriter.create_text_diff_and_write_result):
7914         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
7915         (summarize_results):
7916         * Scripts/webkitpy/port/base.py:
7917         (Port.__init__):
7918         (Port.wdiff_available):
7919         (Port.check_image_diff):
7920         (Port.wdiff_text):
7921         * Scripts/webkitpy/port/base_unittest.py:
7922         (PortTest.test_pretty_patch_os_error):
7923         (PortTest.test_pretty_patch_script_error):
7925 2013-12-06  Dan Bernstein  <mitz@apple.com>
7927         [Mac] MiniBrowser Debug builds are compiled with -Os
7928         https://bugs.webkit.org/show_bug.cgi?id=125376
7930         Reviewed by Tim Horton.
7932         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
7933         the Debug configuration at the project level.
7935 2013-12-06  Jer Noble  <jer.noble@apple.com>
7937         [MSE] Add a runtime-setting for the MediaSource constructor.
7938         https://bugs.webkit.org/show_bug.cgi?id=125336
7940         Reviewed by Eric Carlson.
7942         Enable MediaSource in DRT and WKTR.
7944         * DumpRenderTree/mac/DumpRenderTree.mm:
7945         (resetWebPreferencesToConsistentValues):
7946         * WebKitTestRunner/TestController.cpp:
7947         (WTR::TestController::resetPreferencesToConsistentValues):
7949 2013-12-06  Jer Noble  <jer.noble@apple.com>
7951         Strip out extraneous logging from AppleGVA in media tests.
7952         https://bugs.webkit.org/show_bug.cgi?id=125357
7954         Reviewed by Simon Fraser.
7956         Add a mechanism for stripping out abritrary regular expressions from test input and output.
7958         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
7959         (SingleTestRunner._run_compare_test): Strip out logging
7960         * Scripts/webkitpy/port/base.py:
7961         (Port.logging_patterns_to_strip): Return an empty list by default.
7962         * Scripts/webkitpy/port/driver.py:
7963         (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
7964         * Scripts/webkitpy/port/mac.py:
7965         (MacPort.logging_patterns_to_strip): Return a complete list.
7967 2013-12-06  Dean Jackson  <dino@apple.com>
7969         Updating ANGLE should point to instructions
7970         https://bugs.webkit.org/show_bug.cgi?id=125361
7972         Reviewed by Eric Carlson.
7974         Point to https://trac.webkit.org/wiki/UpdatingANGLE when
7975         someone wants to patch ANGLE.
7977         * Scripts/webkitpy/common/config/watchlist:
7979 2013-12-06  Dan Bernstein  <mitz@apple.com>
7981         [Mac] Transition MiniBrowser to the Cocoa API: load delegate
7982         https://bugs.webkit.org/show_bug.cgi?id=125334
7984         Reviewed by Darin Adler.
7986         * MiniBrowser/mac/WK2BrowserWindowController.m:
7987         (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
7988         title property.
7989         (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
7990         (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
7991         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
7992         window title with the title property changes.
7993         (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
7994         set the load delegate instead of the load client.
7995         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
7996         (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
7997         (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
7998         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
7999         Implemented this load delegate method.
8000         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
8001         Ditto.
8002         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
8003         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
8004         (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
8005         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
8006         (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
8007         Ditto.
8008         (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
8009         Ditto.
8010         (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
8012 2013-12-06  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
8014         Remove function from style/checkers/cpp.py.
8015         https://bugs.webkit.org/show_bug.cgi?id=125341
8017         Reviewed by Darin Adler.
8019         Corrects a FIXME: by removing a function from cpp.py.
8021         * Scripts/webkitpy/style/checkers/cpp.py:
8022         (CppChecker.__init__):
8023         (CppChecker.check):
8024         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
8025         (CppStyleTestBase.process_file_data):
8027 2013-12-06  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
8029         check-webkit-style: false positive warning for indentation of #ifdef code.
8030         https://bugs.webkit.org/show_bug.cgi?id=125254
8032         Reviewed by Darin Adler.
8034         * Scripts/webkitpy/style/checkers/cpp.py:
8035         (check_member_initialization_list):
8036         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
8037         (WebKitStyleTest.test_member_initialization_list):
8039 2013-12-06  Chris Fleizach  <cfleizach@apple.com>
8041         Fix spelling error in style checker: beggining
8042         https://bugs.webkit.org/show_bug.cgi?id=125347
8044         Reviewed by Anders Carlsson.
8046         * Scripts/webkitpy/style/checkers/cpp.py:
8047         (check_member_initialization_list):
8048         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
8049         (WebKitStyleTest.test_member_initialization_list):
8051 2013-12-06  Lukasz Gajowy  <l.gajowy@samsung.com>
8053         [ATK] Missing aria roles mappings
8054         https://bugs.webkit.org/show_bug.cgi?id=117729
8056         Reviewed by Mario Sanchez Prada.
8058         Added new mappings to AccessibilityUIElementAtk.cpp.
8060         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
8061         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
8063 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
8065         Typo fix after r160218.
8067         * Scripts/webkitpy/test/main.py:
8068         (main):
8070 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
8072         Unreviewed fix after r160206.
8074         * Scripts/webkitpy/test/main.py:
8075         (main): sys.platform can be win32 or cygwin too on Windows.
8077 2013-12-05  Csaba Osztrogonác  <ossy@webkit.org>
8079         Disable WebKit2 webkitpy unittests on Windows
8080         https://bugs.webkit.org/show_bug.cgi?id=125318
8082         Reviewed by Ryosuke Niwa.
8084         * Scripts/webkitpy/test/main.py:
8085         (main):
8087 2013-12-05  Anders Carlsson  <andersca@apple.com>
8089         Tweak WeakObjCPtr
8090         https://bugs.webkit.org/show_bug.cgi?id=125311
8092         Reviewed by Darin Adler.
8094         Split up tests into more logical groups. Add new tests for new functionality.
8096         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
8098 2013-12-05  Carlos Garcia Campos  <cgarcia@igalia.com>
8100         [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
8101         https://bugs.webkit.org/show_bug.cgi?id=125302
8103         Reviewed by Philippe Normand.
8105         * gtk/generate-webkitdom-doc-files:
8106         (WebKitDOMDocGeneratorSections.write_footer): Add a new section
8107         containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
8108         and WEBKIT_DEPRECATED_FOR macros.
8110 2013-12-05  Laszlo Vidacs  <lac@inf.u-szeged.hu>
8112         Fix cross compilation on x86
8113         https://bugs.webkit.org/show_bug.cgi?id=125295
8115         Reviewed by Zoltan Herczeg.
8117         Certain compiler flags should not be added when cross compilation is enabled.
8119         * Scripts/webkitdirs.pm:
8120         (runAutogenForAutotoolsProjectIfNecessary):
8121         (generateBuildSystemFromCMakeProject):
8123 2013-12-05  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
8125         Remove duplicated/dead code from cpp style checker unit tests.
8126         https://bugs.webkit.org/show_bug.cgi?id=125226
8128         Reviewed by Ryosuke Niwa.
8130         Remove the first definition of OrderOfIncludesTest class as it is
8131         overwritten by the second. Remove a duplicated assert statement
8132         from the second class.
8134         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
8135         (OrderOfIncludesTest.setUp):
8136         (OrderOfIncludesTest.test_try_drop_common_suffixes):
8137           The last assert was duplicated.
8139 2013-12-05  László Langó  <lango@inf.u-szeged.hu>
8141         Remove Scripts/generate-qt-inspector-resource.
8142         https://bugs.webkit.org/show_bug.cgi?id=125288
8144         Reviewed by Andreas Kling.
8146         * Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.
8147         We don't need this file.
8149 2013-12-05  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
8151         Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
8152         https://bugs.webkit.org/show_bug.cgi?id=125218
8154         Reviewed by Ryosuke Niwa.
8156         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
8157         (LayoutTestFinder.skip_tests):
8158         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
8159         (LayoutTestRunner.run_tests):
8160         (LayoutTestRunner._update_summary_with_result):
8161         * Scripts/webkitpy/layout_tests/controllers/manager.py:
8162         (Manager._test_is_slow):
8163         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
8164         (JSONLayoutResultsGenerator._insert_failure_summaries):
8165         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
8166         (TestExpectations.get_rebaselining_failures):
8167         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
8168         (assert_exp):
8169         (MiscTests.test_multiple_results):
8170         (MiscTests.test_category_expectations):
8171         (MiscTests.test_get_modifiers):
8172         (MiscTests.test_get_expectations_string):
8173         (MiscTests.test_expectation_to_string):
8174         (MiscTests.test_get_test_set):
8175         (MiscTests.test_more_specific_override_resets_skip):
8176         (SkippedTests.check):
8177         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
8178         (TestRunResults.__init__):
8179         (summarize_results):
8180         * Scripts/webkitpy/tool/commands/rebaseline.py:
8181         (RebaselineExpectations._tests_to_rebaseline):
8183 2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
8185         Enable HTMLTemplateElement by default
8186         https://bugs.webkit.org/show_bug.cgi?id=123851
8188         Reviewed by Antti Koivisto.
8190         * Scripts/webkitperl/FeatureList.pm:
8192 2013-12-04  Jozsef Berta  <jberta@inf.u-szeged.hu>
8194         [EFL] Bumping GStreamer version to 1.2.1
8195         https://bugs.webkit.org/show_bug.cgi?id=125155
8197         Reviewed by Gyuyoung Kim.
8199         * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
8202 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
8204         Update jhbuild revision.
8205         https://bugs.webkit.org/show_bug.cgi?id=124966
8206         
8207         Reviewed by Gyuyoung Kim.
8209         Used version of Jhbuild failed to create directories and caused
8210         update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
8212         * jhbuild/jhbuild-wrapper:
8214 2013-12-04  Anders Carlsson  <andersca@apple.com>
8216         Add a WeakObjCPtr class
8217         https://bugs.webkit.org/show_bug.cgi?id=125267
8219         Reviewed by Geoffrey Garen.
8221         Add API tests for WeakObjCPtr.
8223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
8224         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
8225         (TEST):
8227 2013-12-04  Anders Carlsson  <andersca@apple.com>
8229         Make the estimatedProgress property observable using KVO
8230         https://bugs.webkit.org/show_bug.cgi?id=125259
8232         Reviewed by Dan Bernstein.
8234         Bind the progress indicator value to the "estimatedProgress" property.
8236         * MiniBrowser/mac/WK2BrowserWindowController.m:
8237         (-[WK2BrowserWindowController dealloc]):
8238         (-[WK2BrowserWindowController awakeFromNib]):
8240 2013-12-04  Anders Carlsson  <andersca@apple.com>
8242         Add a loading property to WKBrowsingContextController
8243         https://bugs.webkit.org/show_bug.cgi?id=125256
8245         Reviewed by Dan Bernstein.
8247         Bind the progress indicator visibility to the "loading" property.
8249         * MiniBrowser/mac/WK2BrowserWindowController.m:
8250         (-[WK2BrowserWindowController dealloc]):
8251         (-[WK2BrowserWindowController awakeFromNib]):
8252         (-[WK2BrowserWindowController didStartProgress]):
8253         (-[WK2BrowserWindowController didFinishProgress]):
8255 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
8257         [EFL][WK2] Buildfix after r160104
8258         https://bugs.webkit.org/show_bug.cgi?id=125231
8260         Reviewed by Anders Carlsson.
8262         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
8263         (TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
8264         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
8265         (TestWebKitAPI::setViewClient): Ditto.
8267 2013-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
8269         check-webkit-style detected some ternary statements as initialization lists
8270         https://bugs.webkit.org/show_bug.cgi?id=125246
8272         Reviewed by Dean Jackson.
8274         The regular expression that check-webkit-tests uses to detect initialization
8275         lists was too broad, resulting in false positives. This patch makes the
8276         regex more specific
8278         * Scripts/webkitpy/style/checkers/cpp.py:
8279         (check_member_initialization_list):
8280         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
8281         (WebKitStyleTest.test_member_initialization_list):
8283 2013-12-04  Mark Hahnenberg  <mhahnenberg@apple.com>
8285         run-jsc-stress-tests can only run locally
8286         https://bugs.webkit.org/show_bug.cgi?id=124551
8288         Reviewed by Filip Pizlo.
8290         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
8291         killed before the lock directory was removed, future executions wouldn't make any progress. Also 
8292         added a couple more signals to handle gracefully at shutdown. 
8293         * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
8294         * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
8295         The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
8296         it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
8297         toward the end of the script to make it easier to tell which of the various modes do what.
8299 2013-12-04  Csaba Osztrogonác  <ossy@webkit.org>
8301         [EFL][WK2] Buildfix after r160104
8302         https://bugs.webkit.org/show_bug.cgi?id=125233
8304         Reviewed by Anders Carlsson.
8306         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
8307         (TestWebKitAPI::TEST):
8308         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
8309         (TestWebKitAPI::setPageLoaderClient):
8311 2013-12-03  Anders Carlsson  <andersca@apple.com>
8313         Deprecate all unversioned client structs in favor of having explicit versioned structs
8314         https://bugs.webkit.org/show_bug.cgi?id=125203
8316         Reviewed by Dan Bernstein.
8318         Update for WebKit2 API changes.
8320         * MiniBrowser/mac/AppDelegate.m:
8321         (-[BrowserAppDelegate init]):
8322         * MiniBrowser/mac/WK2BrowserWindowController.m:
8323         (-[WK2BrowserWindowController awakeFromNib]):
8324         * TestWebKitAPI/InjectedBundleController.cpp:
8325         (TestWebKitAPI::InjectedBundleController::initialize):
8326         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
8327         (TestWebKitAPI::TEST):
8328         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
8329         (TestWebKitAPI::setInjectedBundleClient):
8330         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
8331         (TestWebKitAPI::TEST):
8332         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
8333         (TestWebKitAPI::TEST):
8334         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
8335         (TestWebKitAPI::TEST):
8336         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
8337         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
8338         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
8339         (TestWebKitAPI::TEST):
8340         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
8341         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
8342         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
8343         (TestWebKitAPI::setInjectedBundleClient):
8344         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
8345         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
8346         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
8347         (TestWebKitAPI::TEST):
8348         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
8349         (TestWebKitAPI::TEST):
8350         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
8351         (TestWebKitAPI::setContextDownloadClient):
8352         (TestWebKitAPI::setPagePolicyClient):
8353         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
8354         (TestWebKitAPI::TEST):
8355         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
8356         (TestWebKitAPI::TEST):
8357         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
8358         (TestWebKitAPI::TEST):
8359         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
8360         (TestWebKitAPI::TEST):
8361         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
8362         (TestWebKitAPI::TEST):
8363         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
8364         (TestWebKitAPI::TEST):
8365         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
8366         (TestWebKitAPI::setupGeolocationProvider):
8367         (TestWebKitAPI::setupView):
8368         (TestWebKitAPI::TEST):
8369         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
8370         (TestWebKitAPI::TEST):
8371         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
8372         (TestWebKitAPI::setPageLoaderClient):
8373         (TestWebKitAPI::setInjectedBundleClient):
8374         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
8375         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
8376         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
8377         (TestWebKitAPI::TEST):
8378         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
8379         (TestWebKitAPI::setInjectedBundleClient):
8380         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
8381         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
8382         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
8383         (TestWebKitAPI::TEST):
8384         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
8385         (TestWebKitAPI::TEST):
8386         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
8387         (TestWebKitAPI::TEST):
8388         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
8389         (TestWebKitAPI::TEST):
8390         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
8391         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):
8392         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
8393         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
8394         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
8395         (TestWebKitAPI::setPageLoaderClient):
8396         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
8397         (TestWebKitAPI::setPageLoaderClient):
8398         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
8399         (TestWebKitAPI::setPageLoaderClient):
8400         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
8401         (TestWebKitAPI::setPageLoaderClient):
8402         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
8403         (TestWebKitAPI::setPageLoaderClient):
8404         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
8405         (TestWebKitAPI::TEST):
8406         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
8407         (TestWebKitAPI::TEST):
8408         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
8409         (TestWebKitAPI::setInjectedBundleClient):
8410         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
8411         (TestWebKitAPI::ParentFrameTest::didCreatePage):
8412         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
8413         (TestWebKitAPI::setInjectedBundleClient):
8414         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
8415         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
8416         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
8417         (TestWebKitAPI::TEST):
8418         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
8419         (TestWebKitAPI::TEST):
8420         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
8421         (TestWebKitAPI::TEST):
8422         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
8423         (TestWebKitAPI::TEST):
8424         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
8425         (TestWebKitAPI::setInjectedBundleClient):
8426         (TestWebKitAPI::setPageLoaderClient):
8427         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
8428         (TestWebKitAPI::setPageLoaderClient):
8429         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
8430         (TestWebKitAPI::TEST):
8431         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
8432         (TestWebKitAPI::setPageLoaderClient):
8433         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
8434         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
8435         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
8436         (TestWebKitAPI::TEST):
8437         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
8438         (TestWebKitAPI::TEST):
8439         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
8440         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
8441         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
8442         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:
8443         (TestWebKitAPI::TEST):
8444         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:
8445         (TestWebKitAPI::WKConnectionTest::initialize):
8446         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
8447         (TestWebKitAPI::setPageLoaderClient):
8448         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
8449         (TestWebKitAPI::setInjectedBundleClient):
8450         (TestWebKitAPI::TEST):
8451         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
8452         (TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):
8453         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
8454         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
8455         (TestWebKitAPI::setInjectedBundleClient):
8456         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
8457         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
8458         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
8459         (TestWebKitAPI::TEST):
8460         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
8461         (TestWebKitAPI::setInjectedBundleClient):
8462         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
8463         (TestWebKitAPI::TEST):
8464         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
8465         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
8466         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
8467         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
8468         (TestWebKitAPI::didCreateConnection):
8469         (TestWebKitAPI::TEST):
8470         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
8471         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
8472         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
8473         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
8474         (TestWebKitAPI::setPageLoaderClient):
8475         * WebKitTestRunner/GeolocationProviderMock.cpp:
8476         (WTR::GeolocationProviderMock::GeolocationProviderMock):
8477         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
8478         (WTR::InjectedBundle::initialize):
8479         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
8480         (WTR::InjectedBundlePage::InjectedBundlePage):
8481         * WebKitTestRunner/TestController.cpp:
8482         (WTR::TestController::createOtherPage):
8483         (WTR::TestController::initialize):
8484         (WTR::TestController::createWebViewWithOptions):
8486 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
8488         Style checker for .messages.in files (WTF:: prefix)
8489         https://bugs.webkit.org/show_bug.cgi?id=125142
8491         Reviewed by Anders Carlsson.
8493         A new style checker for .messages.in files, that checks for the use of WTF::
8494         prefix in these files. (Also checks for tabs as these files were previously
8495         handled as text files.)
8497         * Scripts/webkitpy/style/checker.py:
8498         (CheckerDispatcher._create_checker):
8499           New checker is returned for .messages.in files.
8500         * Scripts/webkitpy/style/checkers/messagesin.py: Added.
8501           The new style checker class.
8502         (MessagesInChecker):
8503         (MessagesInChecker.__init__):
8504         (MessagesInChecker.check):
8505         (MessagesInChecker.check_WTF_prefix):
8506         * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
8507           Unit test for the new style  checker class.
8508         (MessagesInCheckerStyleTestCase):
8509         (test_checker):
8510         (test_checker.error_handler_for_test):
8511         (MessagesInCheckerTestCase):
8512         (MessagesInCheckerTestCase.test_init):
8513         (MessagesInCheckerTestCase.test_init.error_handler_for_test):
8515 2013-12-04  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
8517         Style checker requires alphabetical ordering in cmake lists even it contains variable.
8518         https://bugs.webkit.org/show_bug.cgi?id=124918
8520         Reviewed by Csaba Osztrogonác.
8522         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
8523         (CMakeCheckerTest.test_check):
8524         * Scripts/webkitpy/style/checkers/cmake.py:
8525         (CMakeChecker._check_list_order):
8526         This will ignore lines with variable substitution.
8528 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
8530         check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
8531         https://bugs.webkit.org/show_bug.cgi?id=124731
8533         Reviewed by Zoltan Herczeg.
8535         * Scripts/webkitpy/style/checkers/cpp.py:
8536         (check_spacing):
8537         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
8538         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
8540 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
8542         Remove codecs and os dependencies from filereader.py in webkitpy/style.
8543         https://bugs.webkit.org/show_bug.cgi?id=124719
8545         Although TextFileReader requires a FileSystem it circumvents it in two places!
8546         We should use the FileSystem only and remove codecs and os imports.
8548         Reviewed by Zoltan Herczeg.
8550         * Scripts/webkitpy/common/system/filesystem.py:
8551         (FileSystem.open_stdin): Moved from TextFileReader
8552         * Scripts/webkitpy/style/filereader.py:
8553         (TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
8554         (TextFileReader._process_directory): use FileSystem instead of calling os.walk directly
8556 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
8558         check-webkit-style should check member initialization indentation.
8559         https://bugs.webkit.org/show_bug.cgi?id=124820
8561         Reviewed by Zoltan Herczeg.
8563         check-webkit-style should check member initialization indentation
8564         belongs to webkit coding style:
8565         http://www.webkit.org/coding/coding-style.html#punctuation-member-init
8567         * Scripts/webkitpy/style/checkers/cpp.py:
8568         (check_member_initialization_list): Add new method to check member
8569         initialization list.
8570         (check_style): Add the call of the new method.
8571         (check_language): Move self initialization checking into the new method.
8572         (CppChecker): Add a new category for initialization list.
8573         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
8574         (CppStyleTest.test_runtime_selfinit):
8575         (CppStyleTest.test_deprecated_cast):
8576         (WebKitStyleTest.test_member_initialization_list): Add new testcases for
8577         the new feature.
8579 2013-12-04  Tamas Gergely  <gertom@inf.u-szeged.hu>
8581         style-bot should reject Committer additions to committers.py
8582         https://bugs.webkit.org/show_bug.cgi?id=107574
8584         Reviewed by Zoltan Herczeg.
8586         The style check when executed in non-interactive mode (probably by a
8587         bot) will raise an additional error if the contributors.json file is
8588         modified. Non-interactive mode information is propagated to the
8589         Dispatcher, which creates a special JSON checker for the
8590         contributors.json file.
8592         * Scripts/webkitpy/style/checker.py:
8593         (check_webkit_style_configuration):
8594         (CheckerDispatcher._create_checker):
8595         (CheckerDispatcher.dispatch):
8596         (StyleProcessorConfiguration.__init__):
8597         (StyleProcessor.process):
8598         * Scripts/webkitpy/style/checker_unittest.py:
8599         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
8600         (CheckerDispatcherDispatchTest.dispatch):
8601         (StyleProcessorConfigurationTest._style_checker_configuration):
8602         (StyleProcessor_EndToEndTest.test_init):
8603         (StyleProcessor_EndToEndTest.test_process):
8604         (StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
8605         (StyleProcessor_CodeCoverageTest.setUp):
8606         * Scripts/webkitpy/style/checkers/jsonchecker.py:
8607         (JSONChecker.line_number_from_json_exception):
8608         (JSONContributorsChecker):
8609         (JSONContributorsChecker.check):
8610         * Scripts/webkitpy/style/error_handlers_unittest.py:
8611         (DefaultStyleErrorHandlerTest._style_checker_configuration):
8612         * Scripts/webkitpy/style/optparser.py:
8613         (CommandOptionValues.__init__):
8614         (ArgumentParser._create_option_parser):
8615         (ArgumentParser.parse):
8616         * Scripts/webkitpy/tool/commands/upload_unittest.py:
8617         (test_post):
8618         (test_upload):
8619         * Scripts/webkitpy/tool/steps/checkstyle.py:
8620         (CheckStyle.run):
8622 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
8624         [EFL][WK2] Fix build after API::Client changes
8625         https://bugs.webkit.org/show_bug.cgi?id=125206
8627         Reviewed by Csaba Osztrogonác.
8629         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
8630         (TestWebKitAPI::TEST):
8631         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
8632         (TestWebKitAPI::setViewClient):
8634 2013-12-03  Dan Bernstein  <mitz@apple.com>
8636         Fixed a test timing out after r160040.
8638         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
8639         (-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
8640         Updated for the delegate method rename.
8642 2013-12-03  Filip Pizlo  <fpizlo@apple.com>
8644         REGRESSION: repro scripts disappear when you rerun tests
8645         https://bugs.webkit.org/show_bug.cgi?id=125184
8647         Reviewed by Mark Hahnenberg.
8648         
8649         This bug made it difficult to quickly see if a test that recently failed is still
8650         failing while also running a new batch of tests.
8652         Repro scripts are supposed to stay around until you delete them explicitly. This
8653         patch accomplishes that.
8655         * Scripts/run-jsc-stress-tests:
8657 2013-12-03  peavo@outlook.com  <peavo@outlook.com>
8659         [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
8660         https://bugs.webkit.org/show_bug.cgi?id=125111
8662         Reviewed by Filip Pizlo.
8664         Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.
8666         * Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
8667         * Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.
8669 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
8671         Add a script to automatically configure a git clone
8672         https://bugs.webkit.org/show_bug.cgi?id=110073
8674         Revert the change to use https for now since git.webkit.org is setup with http.
8676         * Scripts/webkitpy/tool/commands/setupgitclone.py:
8677         (SetupGitClone.execute):
8679 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
8681         Add a script to automatically configure a git clone
8682         https://bugs.webkit.org/show_bug.cgi?id=110073
8684         Reviewed by Benjamin Poulain.
8686         Added "webkit-patch setup-git-clone" to setup a brand new Git clone.
8688         This command runs various commands listed on http://trac.webkit.org/wiki/UsingGitWithWebKit
8690         * Scripts/webkitpy/tool/commands/__init__.py:
8691         * Scripts/webkitpy/tool/commands/setupgitclone.py: Added.
8692         (SetupGitClone):
8693         (SetupGitClone.execute):
8695 2013-12-03  Anders Carlsson  <andersca@apple.com>
8697         Deprecate WKNotificationProvider
8698         https://bugs.webkit.org/show_bug.cgi?id=125178
8700         Reviewed by Sam Weinig.
8702         Update for WebKit2 changes.
8704         * WebKitTestRunner/TestController.cpp:
8705         (WTR::TestController::initialize):
8706         * WebKitTestRunner/WebNotificationProvider.cpp:
8707         (WTR::WebNotificationProvider::provider):
8708         * WebKitTestRunner/WebNotificationProvider.h:
8710 2013-12-03  Brent Fulgham  <bfulgham@apple.com>
8712         [Win] Support 64-bit Application Support Libraries Location 
8713         https://bugs.webkit.org/show_bug.cgi?id=125179
8715         Reviewed by Tim Horton.
8717         Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
8718         on Windows until an official distribution is available that properly creates registry settings
8719         to specify these locations.
8721         * Scripts/webkitdirs.pm:
8722         (setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
8723         (setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
8724         (appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
8725         running 64-bit builds.
8727 2013-12-03  Mark Hahnenberg  <mhahnenberg@apple.com>
8729         run-jsc-stress-tests only supports host environments that have make installed
8730         https://bugs.webkit.org/show_bug.cgi?id=124550
8732         Reviewed by Darin Adler.
8734         This might not be the case for all hosts, so this patch implements an alternate "backend" 
8735         for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at 
8736         least somewhat competitive with the make-based test runner, the shell backend uses subshells
8737         run in the background to allow tests to run in parallel. Since the concurrency primitives 
8738         in shell scripting are rather coarse, the overhead of this parallelism is higher than that 
8739         of the make-based runner.
8741         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into
8742         the bundle and controls all of the parallel aspects of the shell-based test runner.
8743         * Scripts/run-jsc-stress-tests:
8745 2013-12-03  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
8747         Remove function from TextChecker
8748         https://bugs.webkit.org/show_bug.cgi?id=125148
8750         Reviewed by Darin Adler.
8752         The process_file_data is used only from the unit tests, so it is simply moved there.
8754         * Scripts/webkitpy/style/checkers/text.py:
8755         (TextChecker.check):
8756         * Scripts/webkitpy/style/checkers/text_unittest.py:
8757         (TextStyleTestCase.process_file_data):
8758         (TextStyleTestCase.assertNoError):
8759         (TextStyleTestCase.assertError):
8761 2013-12-03  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
8763         Remove get_test() and reference test names directly instead.
8764         https://bugs.webkit.org/show_bug.cgi?id=124962
8766         Reviewed by Csaba Osztrogonác.
8768         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
8769         (Base.__init__):
8770         (Base.get_basic_tests):
8771         (assert_exp):
8772         (MiscTests.test_multiple_results):
8773         (MiscTests.test_category_expectations):
8774         (MiscTests.test_get_modifiers):
8775         (MiscTests.test_get_expectations_string):
8776         (MiscTests.test_get_test_set):
8777         (MiscTests.test_parse_warning):
8778         (MiscTests.test_pixel_tests_flag.match):
8780 2013-12-03  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
8782         Style Checker false pass.
8783         https://bugs.webkit.org/show_bug.cgi?id=112456
8785         Reviewed by Csaba Osztrogonác.
8787         * Scripts/webkitpy/style/checkers/changelog.py:
8788         (ChangeLogChecker.check_entry):
8789         simple regex fix to check "No new tests (...)."
8790         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
8791         (ChangeLogCheckerTest.test_no_new_tests):
8793 2013-12-02  Filip Pizlo  <fpizlo@apple.com>
8795         run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
8796         https://bugs.webkit.org/show_bug.cgi?id=125130
8798         Reviewed by Geoffrey Garen.
8800         * Scripts/run-jsc-stress-tests:
8802 2013-12-02  Samuel White  <samuel_white@apple.com>
8804         AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
8805         https://bugs.webkit.org/show_bug.cgi?id=124561
8807         Reviewed by Chris Fleizach.
8809         Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.
8811         * DumpRenderTree/AccessibilityUIElement.cpp:
8812         (uiElementCountForSearchPredicateCallback):
8813         (uiElementForSearchPredicateCallback):
8814         (AccessibilityUIElement::getJSClass):
8815         * DumpRenderTree/AccessibilityUIElement.h:
8816         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
8817         (AccessibilityUIElement::uiElementCountForSearchPredicate):
8818         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
8819         (AccessibilityUIElement::uiElementCountForSearchPredicate):
8820         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
8821         (searchPredicateParameterizedAttributeForSearchCriteria):
8822         (AccessibilityUIElement::uiElementCountForSearchPredicate):
8823         (AccessibilityUIElement::uiElementForSearchPredicate):
8824         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
8825         (AccessibilityUIElement::uiElementCountForSearchPredicate):
8826         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
8827         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
8828         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
8829         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
8830         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
8831         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
8832         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
8833         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
8834         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
8835         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
8837 2013-12-02  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
8839         Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
8840         https://bugs.webkit.org/show_bug.cgi?id=124714
8842         Reviewed by Ryosuke Niwa.
8844         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
8845         (write_test_result):
8846         * Scripts/webkitpy/layout_tests/models/test_failures.py:
8847         (TestFailure.write_failure):
8848         (FailureText):
8849         (FailureText.write_failure):
8850         (FailureAudio):
8851         (FailureAudio.write_failure):
8852         (FailureCrash.write_failure):
8853         (FailureMissingResult):
8854         (FailureTextMismatch):
8855         (FailureMissingImageHash.write_failure):
8856         (FailureMissingImage.write_failure):
8857         (FailureImageHashMismatch.write_failure):
8858         (FailureReftestMismatch.write_failure):
8859         (FailureReftestMismatchDidNotOccur.write_failure):
8860         (FailureMissingAudio):
8861         (FailureAudioMismatch):
8863 2013-12-02  László Langó  <lango@inf.u-szeged.hu>
8865         Remove the stderr_write attribute from StyleProcessorConfiguration
8866         https://bugs.webkit.org/show_bug.cgi?id=124703
8868         Reviewed by Ryosuke Niwa.
8870         Remove the stderr_write attribute from this class in checker and
8871         replace its use with calls to a logging module logger. We Should 
8872         use logging module instead of writing to stderr directly.
8874         * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.
8875         (check_webkit_style_configuration):
8876         (CheckerDispatcher.dispatch): Remove FIXME comment.
8877         (StyleProcessorConfiguration):
8878         (StyleProcessorConfiguration.__init__):
8879         (StyleProcessorConfiguration.write_style_error):
8880         * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.
8881         There is an "ERROR" prefix in log messiges from now.
8882         (StyleProcessorConfigurationTest):
8883         (StyleProcessorConfigurationTest._style_checker_configuration):
8884         (StyleProcessorConfigurationTest.test_init):
8885         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
8886         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
8887         (StyleProcessor_EndToEndTest.with):
8888         (StyleProcessor_EndToEndTest.test_init):
8889         (StyleProcessor_EndToEndTest.test_process):
8890         (StyleProcessor_CodeCoverageTest.setUp):
8891         * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.
8892         (DefaultStyleErrorHandler.__call__):
8893         * Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.
8894         There is an "ERROR" prefix in log messiges from now.
8895         (DefaultStyleErrorHandlerTest):
8896         (DefaultStyleErrorHandlerTest.setUp):
8897         (DefaultStyleErrorHandlerTest._mock_increment_error_count):
8898         (DefaultStyleErrorHandlerTest._style_checker_configuration):
8899         (DefaultStyleErrorHandlerTest._check_initialized):
8900         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
8901         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
8902         (DefaultStyleErrorHandlerTest.test_line_numbers):
8904 2013-12-02  Brian J. Burg  <burg@cs.washington.edu>
8906         Add JavaScript style checker and teach checker.py about .js files
8907         https://bugs.webkit.org/show_bug.cgi?id=125049
8909         Reviewed by Joseph Pecoraro.
8911         Add a JavaScript file type, extension, and checker (JSChecker).
8912         Use TextChecker for JavaScript tests, libraries, website resources,
8913         etc. and use JSChecker for files within WebInspectorUI/UserInterface.
8915         Amended tests for TextChecker to reflect the rule above.
8917         * Scripts/webkitpy/style/checker.py:
8918         (_all_categories): Add categories defined by JSChecker.
8919         (FileType): Add file type for JS and re-number the enum.
8920         (CheckerDispatcher._file_type): Detect .js files as JavaScript.
8921         (CheckerDispatcher._create_checker):
8922         Create a JSChecker or TextChecker depending on the file's path.
8924         * Scripts/webkitpy/style/checker_unittest.py:
8925         (CheckerDispatcherDispatchTest.assert_checker_js): Added.
8926         (CheckerDispatcherDispatchTest.test_js_paths): Added.
8927         (CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
8928         that end in .js but should be checked with TextChecker.
8929         * Scripts/webkitpy/style/checkers/js.py: Added.
8930         (JSChecker):
8931         (JSChecker.__init__):
8932         (JSChecker.check):
8933         * Scripts/webkitpy/style/checkers/js_unittest.py: Added.
8934         (JSTestCase):
8935         (JSTestCase.assertNoError):
8936         (JSTestCase.assertNoError.error_for_test):
8937         (JSTestCase.assertError):
8938         (JSTestCase.assertError.error_for_test):
8939         (JSTestCase.test_no_error):
8940         (JSTestCase.test_error):
8942 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
8944         run-jsc-stress-tests always copies the VM
8945         https://bugs.webkit.org/show_bug.cgi?id=125092
8947         Reviewed by Filip Pizlo.
8949         This can be slow, especially with full debug builds. It should just symlink the VM into the 
8950         bundle by default and do a full copy only when asked.
8952         * Scripts/run-jsc-stress-tests:
8954 2013-12-02  Brent Fulgham  <bfulgham@apple.com>
8956         [Win] Port run-jsc-stress-tests
8957         https://bugs.webkit.org/show_bug.cgi?id=124801
8959         Reviewed by Filip Pizlo.
8961         * Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl
8962         command on Windows so that stress tests can run.
8964 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
8966         Build fix after r159955
8968         * Scripts/run-jsc-stress-tests:
8970 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
8972         run-jsc-stress-tests should be able to package its tests and move them places
8973         https://bugs.webkit.org/show_bug.cgi?id=124549
8975         Reviewed by Filip Pizlo.
8977         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
8978         of grep -i -q
8979         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
8980         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
8981         We now also copy whatever VM was specified, along with its associated framework, into this directory.
8982         All of the generated scripts now are completely relative within the results directory. This allows
8983         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
8984         tarball of the generated results directory. Also refactored several portions of the script into
8985         separate functions to make it easier to run them conditionally depending on which mode we're running in. 
8987 2013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
8989         [ATK] Support active state for listbox elements.
8990         https://bugs.webkit.org/show_bug.cgi?id=125009
8992         Reviewed by Chris Fleizach.
8994         Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.
8996         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
8997         (AccessibilityUIElement::isSelectedOptionActive):
8998         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
8999         (WTR::AccessibilityUIElement::isSelectedOptionActive):
9000         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
9001         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
9002         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
9003         (WTR::AccessibilityUIElement::isSelectedOptionActive):
9004         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
9005         (WTR::AccessibilityUIElement::isSelectedOptionActive):
9007 2013-12-02  Zan Dobersek  <zdobersek@igalia.com>
9009         Unreviewed GTK gardening.
9011         * Scripts/run-gtk-tests:
9012         (TestRunner): Skip two unit tests that are causing the subsequent test to crash.
9014 2013-12-01  Dan Bernstein  <mitz@apple.com>
9016         [Mac] Transition MiniBrowser to the Cocoa API: policy delegate   
9017         https://bugs.webkit.org/show_bug.cgi?id=125046
9019         Reviewed by Sam Weinig.
9021         * MiniBrowser/mac/AppDelegate.m:
9022         (-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
9023         (-[BrowserAppDelegate openDocument:]): Ditto.
9024         * MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the
9025         interface to the implementation.
9026         * MiniBrowser/mac/WK2BrowserWindowController.m:
9027         (-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
9028         the policy client.
9029         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
9030         Moved policy client implementation into this delegate method.
9031         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
9032         Ditto.
9033         (-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
9034         Ditto.
9036 2013-12-01  Dan Bernstein  <mitz@apple.com>
9038         [Mac] Remove the MiniBrowser injected bundle
9039         https://bugs.webkit.org/show_bug.cgi?id=125041
9041         Reviewed by Anders Carlsson.
9043         It had no ops!
9045         * MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
9046         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
9047         * MiniBrowser/mac/AppDelegate.m:
9048         (-[BrowserAppDelegate init]):
9049         * MiniBrowser/mac/WebBundle/Info.plist: Removed.
9050         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
9052 2013-11-29  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
9054         check-webkit-style should check for extraneous newline between config.h and primary header.
9055         https://bugs.webkit.org/show_bug.cgi?id=124821
9057         Reviewed by Csaba Osztrogonác.
9059         * Scripts/webkitpy/style/checkers/cpp.py:
9060         (check_include_line):
9061         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
9062         (OrderOfIncludesTest.test_check_line_break_after_own_header):
9063         (OrderOfIncludesTest):
9064         (OrderOfIncludesTest.test_check_line_break_before_own_header):
9066 2013-11-29  Jozsef Berta  <jberta@inf.u-szeged.hu>
9068         test-webkit-scripts should show the failing tests and use an appropriate exit code
9069         https://bugs.webkit.org/show_bug.cgi?id=124840
9071         Reviewed by Ryosuke Niwa.
9073         A fixme in test-webkit-scripts asked that the script should display success or failiure
9074         and exit with a 0 or 1 value accordingly after all of the tests have completed.
9076         * Scripts/test-webkit-scripts:
9077         (ScriptsTester.run_test_script):
9078         The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
9079         because at this point we don't need to pass on more information other than success or failiure.
9080         (ScriptsTester.main):
9081         The return values are now stored for each script and when all tests have completed successfully,
9082         the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.
9084 2013-11-29  Krzysztof Czech  <k.czech@samsung.com>
9086         [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
9087         https://bugs.webkit.org/show_bug.cgi?id=124923
9089         Reviewed by Mario Sanchez Prada.
9091         Added missing implementation of isAttributeSettable. Using
9092         ATK_STATE_EDITABLE for checking whether attribute is settable.
9094         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
9095         (AccessibilityUIElement::isAttributeSettable):
9096         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
9097         (WTR::AccessibilityUIElement::isAttributeSettable):
9099 2013-11-28  Commit Queue  <commit-queue@webkit.org>
9101         Unreviewed, rolling out r159839.
9102         http://trac.webkit.org/changeset/159839
9103         https://bugs.webkit.org/show_bug.cgi?id=124974
9105         run-webkit-tests doesn't generate pretty diff (Requested by
9106         Ossy on #webkit).
9108         * Scripts/webkitpy/common/prettypatch.py:
9109         (PrettyPatch.__init__):
9110         (PrettyPatch.pretty_diff):
9111         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
9112         (TestResultWriter.create_text_diff_and_write_result):
9113         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
9114         (summarize_results):
9115         * Scripts/webkitpy/port/base.py:
9116         (Port.__init__):
9117         (Port.pretty_patch_available):
9118         (Port.check_pretty_patch):
9119         (Port.variable):
9120         (Port.variable.pretty_patch_text):
9121         * Scripts/webkitpy/port/base_unittest.py:
9122         (PortTest.test_pretty_patch_os_error):
9123         (PortTest.test_pretty_patch_script_error):
9125 2013-11-28  Antti Koivisto  <antti@apple.com>
9127         Remove feature: CSS variables
9128         https://bugs.webkit.org/show_bug.cgi?id=114119
9130         Reviewed by Andreas Kling.
9132         * Scripts/webkitperl/FeatureList.pm:
9134 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
9136         Move PrettyPatch related code to prettypatch.py
9137         https://bugs.webkit.org/show_bug.cgi?id=124937
9139         Reviewed by Ryosuke Niwa.
9141         This code seems to have a better place here than in Port, since PrettyPatch already knows
9142         pretty_patch_path, and this also unifies the usage of PrettyPatch
9144         * Scripts/webkitpy/common/prettypatch.py:
9145         (PrettyPatch.__init__):
9146         (PrettyPatch.pretty_diff):
9147         (PrettyPatch):
9148         (PrettyPatch.pretty_patch_available):
9149         (PrettyPatch.check_pretty_patch):
9150         (PrettyPatch.pretty_patch_text):
9151         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
9152         (TestResultWriter.create_text_diff_and_write_result):
9153         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
9154         (summarize_results):
9155         * Scripts/webkitpy/port/base.py:
9156         (Port.__init__):
9157         (Port.wdiff_available):
9158         (Port.check_image_diff):
9159         (Port.wdiff_text):
9160         * Scripts/webkitpy/port/base_unittest.py:
9161         (PortTest.test_pretty_patch_os_error):
9162         (PortTest.test_pretty_patch_script_error):
9164 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
9166         Checkout should own the scm object in Host
9167         https://bugs.webkit.org/show_bug.cgi?id=124943
9169         Reviewed by Ryosuke Niwa.
9171         * Scripts/webkitpy/common/host.py:
9172         (Host.__init__):
9173         (Host.initialize_scm):
9174         (Host.scm):
9176 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
9178         Do bytecode validation as part of testing
9179         https://bugs.webkit.org/show_bug.cgi?id=124913
9181         Reviewed by Oliver Hunt.
9183         * Scripts/run-jsc-stress-tests:
9185 2013-11-27  Andres Gomez  <agomez@igalia.com>
9187         [GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
9188         https://bugs.webkit.org/show_bug.cgi?id=124940
9190         Reviewed by Martin Robinson.
9192         xserver-font-utils is needed for building gtk port dependencies
9193         with jhbuild.
9195         * gtk/install-dependencies: Added xserver-font-utils to jhbuild
9196         dependecies.
9198 2013-11-27  Andres Gomez  <agomez@igalia.com>
9200         [GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
9201         https://bugs.webkit.org/show_bug.cgi?id=124938
9203         Reviewed by Philippe Normand.
9205         Added needed git dependency for building the gtk port with
9206         jhbuild. Also, the dependencies needed for building the gtk port
9207         are now sorted alphabetically.
9209         * gtk/install-dependencies: Added git as jhbuild dependency and
9210         sorted dependencies alphabetically.
9212 2013-11-27  Jozsef Berta  <jberta@inf.u-szeged.hu>
9214         run_webkit_tests.py: error: no such option: --wincairo
9215         https://bugs.webkit.org/show_bug.cgi?id=124927
9217         Reviewed by Ryosuke Niwa.
9219         * BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports
9220         the layout testing on wincairo, so it is turned off.
9222 2013-11-26  Marcelo Lira  <marcelo.lira@openbossa.org>
9224         Nix upstreaming - Adding build files and supporting scripts
9225         https://bugs.webkit.org/show_bug.cgi?id=118367
9227         Reviewed by Ryosuke Niwa.
9229         * Scripts/build-webkit:
9230         * Scripts/run-nix-tests: Added.
9231         * Scripts/run-webkit-tests:
9232         * Scripts/update-webkit-libs-jhbuild:
9233         * Scripts/update-webkitnix-libs: Added.
9234         * Scripts/webkitdirs.pm:
9235         (determineArchitecture):
9236         (argumentsForConfiguration):
9237         (jscProductDir):
9238         (builtDylibPathForName):
9239         (determineIsNix):
9240         (isNix):
9241         (isAppleWebKit):
9242         (launcherPath):
9243         (launcherName):
9244         (checkRequiredSystemConfig):
9245         (copyInspectorFrontendFiles):
9246         (jhbuildWrapperPrefixIfNeeded):
9247         (buildCMakeProjectOrExit):
9248         (cmakeBasedPortName):
9249         * Scripts/webkitpy/common/config/ports.py:
9250         (DeprecatedPort.port):
9251         (EflWK2Port.build_webkit_command):
9252         (NixPort):
9253         (NixPort.build_webkit_command):
9254         * Scripts/webkitpy/port/factory.py:
9255         (platform_options):
9256         (PortFactory):
9257         * Scripts/webkitpy/port/nix.py: Added.
9258         (NixPort):
9259         (NixPort._wk2_port_name):
9260         (NixPort.determine_full_port_name):
9261         (NixPort.__init__):
9262         (NixPort._port_flag_for_scripts):
9263         (NixPort.setup_test_run):
9264         (NixPort.setup_environ_for_server):
9265         (NixPort.default_timeout_ms):
9266         (NixPort.clean_up_test_run):
9267         (NixPort._generate_all_test_configurations):
9268         (NixPort._path_to_driver):
9269         (NixPort._path_to_image_diff):
9270         (NixPort._image_diff_command):
9271         (NixPort._search_paths):
9272         (NixPort.show_results_html_file):
9273         (NixPort._port_specific_expectations_files):
9274         (NixPort.default_baseline_search_path):
9275         * Scripts/webkitpy/port/nix_unittest.py: Added.
9276         (NixPortTest):
9277         (NixPortTest._assert_search_path):
9278         (NixPortTest._assert_expectations_files):
9279         (NixPortTest.test_baseline_search_path):
9280         (NixPortTest.test_expectations_files):
9281         (NixPortTest.test_default_timeout_ms):
9282         * jhbuild/jhbuild-wrapper:
9283         (determine_platform):
9284         * nix/common.py: Added.
9285         (script_path):
9286         (top_level_path):
9287         * nix/jhbuild.modules: Added.
9288         * nix/jhbuildrc: Added.
9290 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
9292         Record subtest values in Dromaeo tests
9293         https://bugs.webkit.org/show_bug.cgi?id=124498
9295         Reviewed by Andreas Kling.
9297         Supported parsing subtest results.
9299         * Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
9300         which contains a dictionary with its name and an ordered list of subtest's metrics.
9301         (PerfTest.__init__): Initialize _metrics as a list.
9302         (PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
9303         (PerfTest._run_with_driver):
9304         (PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.
9306         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
9307         (TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
9308         (TestPerfTest.test_parse_output): Ditto.
9309         (TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
9310         assertions to ensure subtest results are parsed properly.
9311         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
9312         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.
9314         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
9315         (_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
9316         incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
9317         adding new results.
9319         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
9320         (TestWithSubtestsData): Added.
9321         (TestDriver.run_test):
9322         (MainTest.test_run_test_with_subtests): Added.
9324 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
9326         Enable HTML template element on Windows ports
9327         https://bugs.webkit.org/show_bug.cgi?id=124758
9329         Reviewed by Andreas Kling.
9331         * Scripts/webkitperl/FeatureList.pm:
9333 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
9335         Remove replay performance tests as it's not actively maintained
9336         https://bugs.webkit.org/show_bug.cgi?id=124764
9338         Reviewed by Andreas Kling.
9340         Removed the feature.
9342         * Scripts/webkitpy/performance_tests/perftest.py:
9343         (SingleProcessPerfTest.__init__):
9344         (PerfTestFactory):
9345         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
9346         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
9347         (PerfTestsRunner._parse_args):
9348         (PerfTestsRunner._collect_tests):
9349         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
9350         (MainTest.test_collect_tests_with_ignored_skipped_list):
9351         (MainTest.test_default_args):
9352         * Scripts/webkitpy/thirdparty/__init__.py:
9353         (AutoinstallImportHook.find_module):
9354         (AutoinstallImportHook._install_unittest2):
9355         * Scripts/webkitpy/thirdparty/__init___unittest.py:
9356         (ThirdpartyTest.test_imports):
9358 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
9360         Enable aggressive DFG validation in testing
9361         https://bugs.webkit.org/show_bug.cgi?id=124911
9363         Rubber stamped by Ryosuke Niwa.
9364         
9365         This enables validation testing in non-concurrent-JIT runs.
9367         * Scripts/run-jsc-stress-tests:
9369 2013-11-26  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
9371         Moved methods which belong to Checkout into checkout.py
9372         https://bugs.webkit.org/show_bug.cgi?id=124889
9374         Reviewed by Ryosuke Niwa.
9376         * Scripts/webkitpy/common/checkout/checkout.py:
9377         (Checkout.scripts_directory):
9378         (Checkout):
9379         (Checkout.script_path):
9380         (Checkout.commit_message_for_this_commit):
9381         (Checkout.apply_patch):
9382         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
9383         (test_commit_message_for_this_commit):
9384         (CheckoutTest.test_apply_patch):
9385         * Scripts/webkitpy/common/checkout/scm/scm.py:
9386         (SCM.absolute_path):
9387         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
9388         (SCMTest._setup_webkittools_scripts_symlink):
9389         * Scripts/webkitpy/common/checkout/scm/svn.py:
9390         (SVN.create_patch):
9392 2013-11-25  Ryuan Choi  <ryuan.choi@samsung.com>
9394         [EFL] Use Config mode of find_package for EFL 1.8
9395         https://bugs.webkit.org/show_bug.cgi?id=124555
9397         Reviewed by Gyuyoung Kim.
9399         * MiniBrowser/efl/CMakeLists.txt:
9400         Added optional config mode and made version requirement optional.
9402 2013-11-25  Andres Gomez  <agomez@igalia.com>
9404         [GTK] Search functionality in MiniBrowser provides feedback on search fail
9405         https://bugs.webkit.org/show_bug.cgi?id=122681
9407         Reviewed by Mario Sanchez Prada.
9409         When using the search functionality in MiniBrowser, if the search
9410         fails, the entry background color gets red to report the user
9411         about the failing condition. When the entry is cleaned or the
9412         search is again succesful the background turns back to its
9413         original color.
9415         * MiniBrowser/gtk/BrowserSearchBar.c:
9416         (setFailedStyleForEntry): Added.
9417         (doSearch): Sets the entry's background to its original style if
9418         there is no text to search.
9419         (findControllerFailedToFindTextCallback): Added.
9420         (findControllerFoundTextCallback): Added.
9421         (browser_search_bar_init): Creates and adds a new CSS provider to
9422         the text entry so we can change its style based on the success
9423         condition of the search.
9424         (browserSearchBarFinalize): Frees the new CSS provider.
9425         (browser_search_bar_new): Connects the two new handlers to the
9426         "failed-to-find-text" and "found-text" signals emitted by the
9427         WebKitFindController.
9429 2013-11-25  Dan Bernstein  <mitz@apple.com>
9431         [Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
9432         https://bugs.webkit.org/show_bug.cgi?id=124850
9434         Reviewed by Brady Eidson.
9436         Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
9438         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
9439         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
9440         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
9441         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
9442         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
9443         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
9444         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
9446 2013-11-25  Commit Queue  <commit-queue@webkit.org>
9448         Unreviewed, rolling out r159752 and r159754.
9449         http://trac.webkit.org/changeset/159752
9450         http://trac.webkit.org/changeset/159754
9451         https://bugs.webkit.org/show_bug.cgi?id=124847
9453         Broke linux test bots. (Requested by mhahnenberg on #webkit).
9455         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
9456         * Scripts/run-javascriptcore-tests:
9457         * Scripts/run-jsc-stress-tests:
9459 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
9461         Followup fix after r159752
9463         * Scripts/run-jsc-stress-tests: We need to handle Release builds too.
9465 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
9467         run-jsc-stress-tests should be able to package its tests and move them places
9468         https://bugs.webkit.org/show_bug.cgi?id=124549
9470         Reviewed by Filip Pizlo.
9472         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation 
9473         of grep -i -q
9474         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
9475         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. 
9476         We now also copy whatever VM was specified, along with its associated framework, into this directory. 
9477         All of the generated scripts now are completely relative within the results directory. This allows 
9478         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a 
9479         tarball of the generated results directory. Also refactored several portions of the script into 
9480         separate functions to make it easier to run them conditionally depending on which mode we're running in.
9482 2013-11-25  László Langó  <lango@inf.u-szeged.hu>
9484         EWS creates 0 byte sized log files
9485         https://bugs.webkit.org/show_bug.cgi?id=107606
9487         Reviewed by Ryosuke Niwa.
9489         There was a modification in r138264, that tried to make less log,
9490         because some of the messeges were duplicated. After this the EWS
9491         created the log file (with the same name as the bugID) but doesn't
9492         write anything into it, even if there were errors during the build.
9493         From now only creates the log file only if there is some error.
9495         * Scripts/webkitpy/tool/bot/queueengine.py:
9496         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
9497         there is nothing to log. Open the log file only if a ScriptError was raised to
9498         avoid to make empty log files for bugs.
9499         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
9500         because of changes in r138264. Teeing is used for locally testing purposes and
9501         this feature is not used anymore.
9502         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
9503         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
9504         change.
9505         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
9506         (LoggingDelegate): The order of the callbacks was changed by this patch.
9507         (QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
9508         so we have to update this test.
9509         (QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
9510         this patch.
9511         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
9512         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
9513         to be able to handle it in QueueEngine.run. Without this change, the existing
9514         exception handler never run (the process_work_item method never raise ScriptError)
9515         We can get the error message only from the ScriptError at this point.
9517 2013-11-22  Dean Jackson  <dino@apple.com>
9519         Speculative Mountain Lion build fix.
9521         * MiniBrowser/mac/AppDelegate.m:
9522         (-[BrowserAppDelegate openDocument:]):
9524 2013-11-22  Anders Carlsson  <andersca@apple.com>
9526         Fix Mountain Lion bug.
9528         * MiniBrowser/mac/AppDelegate.m:
9529         (-[BrowserAppDelegate openDocument:]):
9531 2013-11-22  Anders Carlsson  <andersca@apple.com>
9533         MiniBrowser should use the blocks-based NSOpenPanel API
9534         https://bugs.webkit.org/show_bug.cgi?id=124786
9536         Reviewed by Simon Fraser.
9538         * MiniBrowser/mac/AppDelegate.m:
9539         (-[BrowserAppDelegate frontmostBrowserWindowController]):
9540         Account for windows that don't have a BrowserWindowController.
9542         (-[BrowserAppDelegate openDocument:]):
9544 2013-11-22  Commit Queue  <commit-queue@webkit.org>
9546         Unreviewed, rolling out r159690.
9547         http://trac.webkit.org/changeset/159690
9548         https://bugs.webkit.org/show_bug.cgi?id=124782
9550         Broke webkitpy tests (Requested by ap on #webkit).
9552         * Scripts/webkitpy/tool/bot/queueengine.py:
9553         (QueueEngine.run):
9554         (QueueEngine._open_work_log):
9555         (QueueEngine._ensure_work_log_closed):
9556         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
9557         (AbstractEarlyWarningSystem.review_patch):
9559 2013-11-22  László Langó  <lango@inf.u-szeged.hu>
9561         EWS creates 0 byte sized log files
9562         https://bugs.webkit.org/show_bug.cgi?id=107606
9564         Reviewed by Ryosuke Niwa.
9566         There was a modification in r138264, that tried to make less log, 
9567         because some of the messeges were duplicated. After this the EWS 
9568         created the log file (with the same name as the bugID) but doesn't 
9569         write anything into it, even if there were errors during the build. 
9570         From now only creates the log file only if there is some error.
9572         * Scripts/webkitpy/tool/bot/queueengine.py:
9573         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
9574         there is nothing to log. Open the log file only if a ScriptError was raised to
9575         avoid to make empty log files for bugs.
9576         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
9577         because of changes in r138264. Teeing is used for locally testing purposes and
9578         this feature is not used anymore.
9579         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output 
9580         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
9581         change.
9582         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
9583         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
9584         to be able to handle it in QueueEngine.run. Without this change, the existing
9585         exception handler never run (the process_work_item method never raise ScriptError)
9586         We can get the error message only from the ScriptError at this point.
9588 2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
9590         Remove ENABLE_WORKERS
9591         https://bugs.webkit.org/show_bug.cgi?id=105784
9593         Reviewed by Darin Adler.
9595         * Scripts/webkitperl/FeatureList.pm:
9597 2013-11-21  Darin Adler  <darin@apple.com>
9599         Try to fix buildbot Dashboard for people who have not hidden anything.
9601         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
9602         Add a null check for hidden platforms.
9604 2013-11-21  Peter Szanka  <h868064@stud.u-szeged.hu>
9606         Remove chrome/chromium related things from webkitpy.
9607         https://bugs.webkit.org/show_bug.cgi?id=124493
9609         Reviewed by Darin Adler.
9611         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
9612         (PortTest.assert_mock_port_works):
9613         * Scripts/webkitpy/port/base.py:
9614         (Port.to.setup_environ_for_server):
9615         * Scripts/webkitpy/port/mac_unittest.py:
9616         (test_tests_for_other_platforms):
9617         * Scripts/webkitpy/port/mock_drt.py:
9618         (MockTestShell.output_for_test):
9619         * Scripts/webkitpy/tool/bot/irc_command.py:
9620         (Restart.execute):
9621         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
9622         (IRCBotTest.test_help):
9624 2013-11-21  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
9626         In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
9627         https://bugs.webkit.org/show_bug.cgi?id=124717
9629         Reviewed by Ryosuke Niwa.
9631         * Scripts/webkitpy/style/filereader.py:
9632         (TextFileReader.process_file):
9633         * Scripts/webkitpy/style/filereader_unittest.py:
9634         (TextFileReaderTest.test_process_file__does_not_exist):
9636 2013-11-21  Mark Rowe  <mrowe@apple.com>
9638         <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
9640         All modern versions of Xcode set it appropriately for our needs.
9642         Reviewed by Alexey Proskuryakov.
9644         * MiniBrowser/Configurations/Base.xcconfig:
9645         * WebKitTestRunner/Configurations/Base.xcconfig:
9647 2013-11-21  Nick Diego Yamane  <nick.yamane@openbossa.org>
9649         webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
9650         https://bugs.webkit.org/show_bug.cgi?id=124676
9652         Reviewed by Daniel Bates.
9654         checkForArgumentAndRemoveFromArrayRef functions was removing wrong
9655         elements when there were more then one occurrence of that argument.
9656         E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
9657         {b, a}, when it should be {b, c}.
9659         * Scripts/webkitdirs.pm:
9660         (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
9661         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
9662         Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
9664 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
9666         Update build-webkit after r159550.
9668         * Scripts/webkitperl/FeatureList.pm:
9670 2013-11-21  Lucas Forschler  <lforschler@apple.com>
9672         Bring a new bot online, replacing the previous ones.
9673         
9674         Unreviewed.
9676         * BuildSlaveSupport/build.webkit.org-config/config.json:
9678 2013-11-21  Dean Jackson  <dino@apple.com>
9680         Don't fetch hidden platforms on build.webkit.org/dashboard
9681         https://bugs.webkit.org/show_bug.cgi?id=124750
9683         Reviewed by Tim Horton.
9685         If a platform is hidden, don't fetch its data. If it
9686         becomes unhidden, try to fetch immediately (unless
9687         you've recently fetched).
9689         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
9690         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
9692 2013-11-21  Commit Queue  <commit-queue@webkit.org>
9694         Unreviewed, rolling out r159633.
9695         http://trac.webkit.org/changeset/159633
9696         https://bugs.webkit.org/show_bug.cgi?id=124726
9698         it broke 10 webkitpy tests (Requested by dino_ on #webkit).
9700         * Scripts/webkitpy/style/checker.py:
9701         (check_webkit_style_configuration):
9702         (CheckerDispatcher.dispatch):
9703         (StyleProcessorConfiguration):
9704         (StyleProcessorConfiguration.__init__):
9705         (StyleProcessorConfiguration.write_style_error):
9707 2013-11-21  László Langó  <lango@inf.u-szeged.hu>
9709         Remove the stderr_write attribute from StyleProcessorConfiguration.
9710         https://bugs.webkit.org/show_bug.cgi?id=124703
9712         Reviewed by Brent Fulgham.
9714         * Scripts/webkitpy/style/checker.py:
9715         (check_webkit_style_configuration):
9716         (CheckerDispatcher.dispatch):
9717         (StyleProcessorConfiguration):
9718         (StyleProcessorConfiguration.__init__):
9719         (StyleProcessorConfiguration.write_style_error):
9721 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
9723         PerfTestRunner._generate_results_dict shouldn't depend on test objects
9724         https://bugs.webkit.org/show_bug.cgi?id=124623
9726         Removed the dependency on test objects from results JSON generation.
9727         This allows single test.run to return metrics for multiple tests
9729         Reviewed by Antti Koivisto.
9731         * Scripts/webkitpy/performance_tests/perftest.py:
9732         (PerfTestMetric.__init__): Takes the test path and test name.
9733         (PerfTestMetric.path): Added.
9734         (PerfTestMetric.test_file_name): Added.
9735         (PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
9736         (PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
9737         The path is going to have the names of subtests at the end once we support them.
9739         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
9740         (TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
9741         (TestPerfTestMetric.test_init_set_time_metric): Ditto.
9742         (TestPerfTestMetric.test_has_values): Ditto.
9743         (TestPerfTestMetric.test_append): Ditto.
9745         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
9746         (_generate_results_dict): Only use metrics.
9747         (_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
9749 2013-11-21  Manuel Rego Casasnovas  <rego@igalia.com>
9751         REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
9752         https://bugs.webkit.org/show_bug.cgi?id=124697
9754         Reviewed by Ryosuke Niwa.
9756         * Scripts/webkitdirs.pm:
9757         (checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
9758         before trying to access to the first element.
9760 2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
9762         [GTK] Mark all deprecated symbols in GObject DOM bindings
9763         https://bugs.webkit.org/show_bug.cgi?id=124406
9765         Reviewed by Gustavo Noronha Silva.
9767         * Scripts/webkitpy/style/checker.py: Add special case for
9768         WebKitDOMDeprecated.
9769         * gtk/generate-gtkdoc:
9770         (get_webkit2_options): Use the prefix of the methods as namespace,
9771         since this is what gtkdoc expects to sort the index.
9772         (get_webkit1_options): Ditto.
9773         (get_webkitdom_options): Ditto.
9774         * gtk/generate-webkitdom-doc-files:
9775         (WebKitDOMDocGenerator): Add a global list of deleted objects.
9776         (WebKitDOMDocGenerator.write_deleted_classes): New method to write
9777         the documentation for classes that are deprecated because they
9778         have been removed.
9779         (WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
9780         for deleted classes too.
9781         (WebKitDOMDocGeneratorSections.__init__): Build a list of
9782         deprecated symbols using the given symbols file.
9783         (WebKitDOMDocGeneratorSections._deleted_class): Returns the
9784         deleted class corresponding to the given function.
9785         (WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
9786         dictionary of deprecated symbols for every class.
9787         (WebKitDOMDocGeneratorSections.write_section): Add also the
9788         deprecated symbols in every section.
9789         (WebKitDOMDocGeneratorSections.write_deleted_classes): Add
9790         sections for deleted classes too.
9792 2013-11-20  László Langó  <lango@inf.u-szeged.hu>
9794         check-webkit-style should support C++11 rvalue references.
9795         https://bugs.webkit.org/show_bug.cgi?id=123406
9797         Reviewed by Brent Fulgham.
9799         * Scripts/webkitpy/style/checkers/cpp.py:
9800         (check_style):
9801         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
9802         (Cpp11StyleTest):
9803         (Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
9805 2013-11-20  Dean Jackson  <dino@apple.com>
9807         Allow settings to be shown/hidden on build.webkit.org/dashboard
9808         https://bugs.webkit.org/show_bug.cgi?id=124694
9810         Reviewed by Tim Horton.
9812         In preparation for more options/buttons, allow the page to
9813         show or hide all the interactive things using a little gear icon
9814         in the top left corner.
9816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
9817         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
9818         (Settings.prototype.toggleSettingsDisplay):
9819         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
9820         (div.cellButton.hide):
9821         (div.cellButton.unhide):
9822         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
9823         (.settings):
9824         (.settings:hover):
9825         (.settings-visible .settings):
9827 2013-11-20  Dean Jackson  <dino@apple.com>
9829         No need to base64 SVG on build.webkit.org/dashboard
9830         https://bugs.webkit.org/show_bug.cgi?id=124687
9832         Reviewed by Tim Horton.
9834         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
9835         (.status-line.good .bubble.pictogram):
9837 2013-11-20  Dean Jackson  <dino@apple.com>
9839         Make links look more like links on build.webkit.org/dashboard
9840         https://bugs.webkit.org/show_bug.cgi?id=124686
9842         Reviewed by Tim Horton.
9844         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
9845         (.queue-view .queueLabel:hover):
9846         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
9847         (.status-line.linked .label:hover):
9849 2013-11-20  Nick Diego Yamane  <nick.yamane@openbossa.org>
9851         Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
9852         https://bugs.webkit.org/show_bug.cgi?id=124581
9854         Reviewed by Daniel Bates.
9856         Some subroutines are replicating code from checkForArgument**
9857         functions instead of reusing them as is being done by all other functions.
9859         * Scripts/webkitdirs.pm:
9860         (determineXcodeSDK): Added.
9861         (determinePassedConfiguration): Added.
9862         (determinePassedArchitecture): Added.
9863         (checkForArgumentAndRemoveFromARGV): Added.
9864         (checkForArgumentAndRemoveFromARGVGettingValue): Added.
9866 2013-11-20  Jozsef Berta  <jberta@inf.u-szeged.hu>
9868         Delete baseline optimizer
9869         https://bugs.webkit.org/show_bug.cgi?id=122333
9871         Reviewed by Ryosuke Niwa.
9873         * Scripts/webkitpy/common/checkout/baselineoptimizer.py: Removed.
9874         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: Removed.
9875         * Scripts/webkitpy/tool/commands/rebaseline.py:
9876         (RebaselineTest.execute):
9877         (AbstractParallelRebaselineCommand._files_to_add):
9878         (AbstractParallelRebaselineCommand._rebaseline):
9879         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
9880         (TestRebaselineJson.test_rebaseline_all):
9881         (TestRebaselineJson.test_rebaseline_debug):
9882         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
9884 2013-11-20  Anders Carlsson  <andersca@apple.com>
9886         Enable PageLoadTest assertions again
9887         https://bugs.webkit.org/show_bug.cgi?id=124681
9889         Reviewed by Tim Horton.
9891         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9892         Actually install all-content-in-one-iframe.html, noticed while debugging this assertion.
9894 2013-11-20  Mark Rowe  <mrowe@apple.com>
9896         Remove some obsolete logic from WebKit.app.
9898         Reviewed by Alexey Proskuryakov.
9900         * WebKitLauncher/WebKitNightlyEnabler.m:
9901         (poseAsWebKitApp): Remove a pre-10.6 codepath.
9902         (enableWebKitNightlyBehaviour): Remove a 10.4-specific codepath.
9904 2013-11-20  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
9906         Moved stray urls from svn.py and statusserver.py into common.config.urls
9907         https://bugs.webkit.org/show_bug.cgi?id=124650
9909         Reviewed by Ryosuke Niwa.
9911         * Scripts/webkitpy/common/checkout/scm/svn.py:
9912         (SVNRepository):
9913         * Scripts/webkitpy/common/config/urls.py:
9914         * Scripts/webkitpy/common/net/statusserver.py:
9915         (StatusServer.__init__):
9916         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
9917         (_generate_results_dict):
9919 2013-11-20  Commit Queue  <commit-queue@webkit.org>
9921         Unreviewed, rolling out r159496.
9922         http://trac.webkit.org/changeset/159496
9923         https://bugs.webkit.org/show_bug.cgi?id=124641
9925         It caused warning and build break with cmake lower than 2.8.8
9926         (Requested by ryuan on #webkit).
9928         * MiniBrowser/efl/CMakeLists.txt:
9930 2013-11-20  Gabor Rapcsanyi  <rgabor@webkit.org>
9932         [EFL] libseccomp-2.0.0 doesn't support ARM architecture
9933         https://bugs.webkit.org/show_bug.cgi?id=124412
9935         Reviewed by Gyuyoung Kim.
9937         Update libseccomp to a newer 2.1.0 version.
9939         * efl/jhbuild.modules:
9941 2013-11-19  Mark Rowe  <mrowe@apple.com>
9943         <rdar://problem/15487072> Modernize WebKit.app's OS X version checking logic.
9945         Gestalt is deprecated on recent OS X versions so we should switch off it.
9947         Reviewed by Sam Weinig.
9949         * WebKitLauncher/main.m:
9950         (currentMacOSXVersion): Retrieve the version string from SystemVersion.plist.
9951         (currentMacOSXMajorVersion): Split the version string at the periods, retrieve the first
9952         two components, then join them back up.
9953         (main): Switch to using currentMacOSXMajorVersion to make it clearer which part of
9954         the version we care about.
9956 2013-11-19  Commit Queue  <commit-queue@webkit.org>
9958         Unreviewed, rolling out r159538.
9959         http://trac.webkit.org/changeset/159538
9960         https://bugs.webkit.org/show_bug.cgi?id=124627
9962         it broke run-jsc-stress-tests (Requested by mhahnenberg on
9963         #webkit).
9965         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
9966         * Scripts/run-javascriptcore-tests:
9967         * Scripts/run-jsc-stress-tests:
9969 2013-11-19  Mark Hahnenberg  <mhahnenberg@apple.com>
9971         run-jsc-stress-tests should be able to package its tests and move them places
9972         https://bugs.webkit.org/show_bug.cgi?id=124549
9974         Reviewed by Geoff Garen and Filip Pizlo.
9976         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. This script was just a ruby reimplementation 
9977         of grep -i -q 
9978         * Scripts/run-javascriptcore-tests: Pass through the --make-bundle flag.
9979         * Scripts/run-jsc-stress-tests: Added the new concept of a "bundle", which is a collection of all tests and any
9980         other files that those tests require to run in any environment along with a fixed root directory into which these
9981         files and their expected directory structure are cloned. The default Bundle class is basically 
9982         a no-op so that it functions like run-jsc-stress-tests prior to this patch. MovableBundle is a Bundle that knows 
9983         how to translate local paths to bundle paths and does all the work of moving each test file into the right place 
9984         inside the .tests directory. After all the test files have been created in jsc-stress-results MovableBundle 
9985         creates a tarball of the entire directory for easy relocation. The --make-bundle flag causes run-jsc-stress-tests 
9986         to use MovableBundle instead of just Bundle. 
9988 2013-11-19  Dan Bernstein  <mitz@apple.com>
9990         <rdar://problem/15139479> Reenable the JSC Objective-C API tests on Mountain Lion once the bots are running Xcode 5
9992         Rubber-stamped by Mark Rowe.
9994         Reverted r156840.
9996         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
9998 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
10000         Yet another build fix. Just allow any character.
10001         There are just too many special characters to be listed here.
10003         * Scripts/webkitpy/performance_tests/perftest.py:
10004         (PerfTest._lines_to_ignore_in_parser_result):
10005         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
10006         (TestPerfTest.test_parse_output_with_subtests)
10008 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
10010         Another build fix. Allow ':' in subtest names.
10012         * Scripts/webkitpy/performance_tests/perftest.py:
10013         (PerfTest._lines_to_ignore_in_parser_result):
10014         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
10015         (TestPerfTest.test_parse_output_with_subtests)
10017 2013-11-19  Ryuan Choi  <ryuan.choi@samsung.com>
10019         [EFL] Use Config mode of find_package for EFL 1.8
10020         https://bugs.webkit.org/show_bug.cgi?id=124555
10022         Reviewed by Gyuyoung Kim.
10024         * MiniBrowser/efl/CMakeLists.txt: Introduced a config mode to find elementary.
10026 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
10028         Build fix. Subtest names need to be more permissive.
10030         * Scripts/webkitpy/performance_tests/perftest.py:
10031         (PerfTest._lines_to_ignore_in_parser_result):
10032         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
10033         (TestPerfTest.test_parse_output_with_subtests)
10035 2013-11-18  Mark Rowe  <mrowe@apple.com>
10037         Use hw.activecpu for determining how many processes to spawn.
10039         It's documented as the preferred way to determine the number of threads
10040         or processes to create in a SMP aware application.
10042         Rubber-stamped by Tim Horton.
10044         * Scripts/copy-webkitlibraries-to-product-directory:
10045         * Scripts/run-jsc-stress-tests:
10046         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
10048 2013-11-18  Tim Horton  <timothy_horton@apple.com>
10050         build.webkit.org/dashboard builder headers should link to the builder page
10051         https://bugs.webkit.org/show_bug.cgi?id=124553
10053         Reviewed by Timothy Hatcher.
10055         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
10056         (BuildbotQueue.prototype.get overviewURL):
10057         Add overviewURL(), which returns the URL to the builder overview page, with the last 50 builds shown.
10059         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
10060         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture):
10061         (BuildbotBuilderQueueView.prototype.update):
10062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
10063         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
10064         (BuildbotTesterQueueView.prototype.update.appendBuild):
10065         (BuildbotTesterQueueView.prototype.update):
10066         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
10067         (.queue-view .queueLabel):
10068         (.queue-view .queueLabel:not(:first-child)):
10069         Make the header a link instead of a label, and wire it up to overviewURL.
10071 2013-11-18  Samuel White  <samuel_white@apple.com>
10073         AX: Add ability to fetch only visible table rows.
10074         https://bugs.webkit.org/show_bug.cgi?id=124430
10076         Reviewed by Chris Fleizach.
10078         Adding method to fetch array of AccessibilityUIElements to help with test brevity and test breakage. Specifically, we
10079         have a good deal of churn any time we add or update an element attribute. This happens because the number of tests
10080         that rely on a simple element description text dump to verify a single attribute is non trivial. So any time you
10081         change add an attribute, you have to update all the tests that are now implicitly verifying this new attribute. But
10082         as the test guidelines state, our tests should be more focused and specific about what they test.
10084         * DumpRenderTree/AccessibilityUIElement.cpp:
10085         (uiElementArrayAttributeValueCallback):
10086         (AccessibilityUIElement::uiElementArrayAttributeValue):
10087         (AccessibilityUIElement::getJSClass):
10088         * DumpRenderTree/AccessibilityUIElement.h:
10089         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
10090         (AccessibilityUIElement::uiElementArrayAttributeValue):
10091         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
10092         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
10093         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
10094         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
10095         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
10096         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
10097         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
10098         (WTR::AccessibilityUIElement::getUIElementsWithAttribute):
10099         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
10101 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
10103         Simplify and reformat the output of performance tests inside test runners
10104         https://bugs.webkit.org/show_bug.cgi?id=124496
10106         Reviewed by Antti Koivisto.
10108         As a preparation to support subtests for Dromaeo and DoYouEvenBench, simplify the output
10109         performance tests generate. Instead of spitting out noise in PerfTestRunner (runner.js)
10110         and ignoring it in PerfTest._filter_output (perftest.py), simply avoid generating it in
10111         the first place.
10113         Also modernize the output to adopt "metric" concept better and make it forward compatible
10114         with subtests.
10116         With this patch, performance tests written using runner.js only produces empty lines or
10117         lines of the following format inside test runners (DumpRenderTree and WebKitTestRunner):
10118         <subtest name> -> [<value 1>, <value 2>, ...]
10119         :<metric name> -> [<value 1>, <value 2>, ...]
10121         This greatly simplifies the parsing logic inside PerfTest._run_with_driver.
10123         * Scripts/webkitpy/performance_tests/perftest.py:
10124         (PerfTest): Removed a bunch of regular expressions that are no longer used.
10125         (PerfTest._run_with_driver): Just parse the values and description and treat everything
10126         else as errors.
10128         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
10129         (TestPerfTest.test_parse_output): Removed the junk.
10130         (TestPerfTest._assert_failed_on_line): Extracted from test_parse_output_with_failing_line,
10131         which was removed in favor of the tests below.
10132         (TestPerfTest.test_parse_output_with_running_five_times): Added.
10133         (TestPerfTest.test_parse_output_with_detailed_info): Added.
10134         (TestPerfTest.test_parse_output_with_statistics): Added.
10135         (TestPerfTest.test_parse_output_with_description): Removed the junk.
10136         (TestPerfTest.test_parse_output_with_subtests): Ditto.
10137         (TestSingleProcessPerfTest.test_use_only_one_process): Ditto.
10139         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
10140         (EventTargetWrapperTestData): Ditto.
10141         (SomeParserTestData): Ditto.
10142         (MemoryTestData): Ditto.
10144 2013-11-18  Tim Horton  <timothy_horton@apple.com>
10146         Occasionally, hundreds of tests fail with small text diffs on Mavericks
10147         https://bugs.webkit.org/show_bug.cgi?id=124312
10149         Reviewed by Simon Fraser.
10151         * Scripts/webkitpy/layout_tests/controllers/manager.py:
10152         (Manager._set_up_run):
10153         * Scripts/webkitpy/port/base.py:
10154         (Port.to.reset_preferences):
10155         * Scripts/webkitpy/port/mac.py:
10156         (MacPort.reset_preferences):
10157         Delete DumpRenderTree and WebKitTestRunner defaults domains before running tests,
10158         returning some of the functionality of 158652 after 159364 removed it.
10160 2013-11-18  Tim Horton  <timothy_horton@apple.com>
10162         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
10163         https://bugs.webkit.org/show_bug.cgi?id=122909
10165         Reviewed by Alexey Proskuryakov.
10167         Put the checkmark SVG in the CSS file as a data URI so it loads immediately.
10169         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
10170         (.status-line .bubble):
10171         (.status-line.good .bubble.pictogram):
10173 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
10175         Remove _lines_to_ignore_in_stderr, which was only used in Chromium port
10176         https://bugs.webkit.org/show_bug.cgi?id=124499
10178         Reviewed by Csaba Osztrogonác.
10180         Removed the code. I didn't like this hack back when it was added, and I don't like it today.
10182         * Scripts/webkitpy/performance_tests/perftest.py:
10183         (PerfTest._should_ignore_line):
10184         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
10185         (TestPerfTest): Removed the unit test.
10187 2013-11-17  Filip Pizlo  <fpizlo@apple.com>
10189         Unreviewed, fix this script for older Rubies where Pathname doesn't coerce to String
10190         quite as easily.
10191         
10192         With help from Andy Trick.
10194         * Scripts/export-llvm-build:
10196 2013-11-15  Filip Pizlo  <fpizlo@apple.com>
10198         FTL should have an explicit notion of bytecode liveness
10199         https://bugs.webkit.org/show_bug.cgi?id=124181
10201         Reviewed by Mark Hahnenberg.
10203         * Scripts/run-jsc-stress-tests:
10205 2013-11-16  Dan Bernstein  <mitz@apple.com>
10207         No way for policy client to determine if a the response’s MIME type can be shown
10208         https://bugs.webkit.org/show_bug.cgi?id=124445
10210         Reviewed by Sam Weinig.
10212         * MiniBrowser/mac/WK2BrowserWindowController.m:
10213         (decidePolicyForResponse): Added canShowMIMEType parameter.
10214         (-[WK2BrowserWindowController awakeFromNib]): Updated for changes in the policy client.
10216         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
10217         (TestWebKitAPI::decidePolicyForResponse): Added canShowMIMEType parameter.
10219         * WebKitTestRunner/TestController.cpp:
10220         (WTR::TestController::createWebViewWithOptions): Updated for changes in the policy client.
10221         (WTR::TestController::decidePolicyForResponse): Added canShowMIMEType parameter.
10222         * WebKitTestRunner/TestController.h:
10224 2013-11-16  Tim Horton  <timothy_horton@apple.com>
10226         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
10227         https://bugs.webkit.org/show_bug.cgi?id=122909
10229         Reviewed by Timothy Hatcher.
10231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/checkmark.svg: Added.
10232         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
10233         (StatusLineView.prototype.set repeatCount):
10234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
10235         (.status-line.good .bubble.pictogram):
10236         Use an SVG image instead of an obscure font for the checkboxes so they
10237         render identically on all platforms.
10239 2013-11-15  Tim Horton  <timothy_horton@apple.com>
10241         Occasionally, hundreds of tests fail with small text diffs on Mavericks
10242         https://bugs.webkit.org/show_bug.cgi?id=124312
10244         Reviewed by Alexey Proskuryakov.
10246         Try reverting the part of r158652 that deleted all of the persistent
10247         defaults, in the thought that there might be some sort of race between
10248         processes causing some settings to be left in the wrong state.
10250         * DumpRenderTree/mac/DumpRenderTree.mm:
10251         (setDefaultsToConsistentValuesForTesting):
10252         * WebKitTestRunner/mac/main.mm:
10253         (setDefaultsToConsistentValuesForTesting):
10255 2013-11-15  Dan Bernstein  <mitz@apple.com>
10257         Give the policy client the originating frame of a navigation action
10258         https://bugs.webkit.org/show_bug.cgi?id=124431
10260         Reviewed by Anders Carlsson.
10262         * MiniBrowser/mac/WK2BrowserWindowController.m:
10263         (decidePolicyForNavigationAction): Added originatingFrame parameter.
10264         (-[WK2BrowserWindowController awakeFromNib]): Updated for the new version of the policy
10265         client.
10267         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
10268         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
10269         (TestWebKitAPI::setPagePolicyClient): Updated for the new version of the policy client.
10271         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
10272         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
10273         (TestWebKitAPI::TEST): Updated for the new version of the policy client.
10275         * WebKitTestRunner/TestController.cpp:
10276         (WTR::TestController::createWebViewWithOptions): Updated for the new version of the policy
10277         client.
10278         (WTR::TestController::decidePolicyForNavigationAction): Added originatingFrame parameter.
10279         * WebKitTestRunner/TestController.h:
10281 2013-11-15  Tim Horton  <timothy_horton@apple.com>
10283         build.webkit.org/dashboard should provide a way to focus on a subset of bots
10284         https://bugs.webkit.org/show_bug.cgi?id=122676
10286         Reviewed by Timothy Hatcher.
10288         Add a small 'hide' button next to every platform logo, and a 'show all'
10289         button which only appears when at least one platform is hidden. Hidden
10290         platforms persist using localStorage.
10292         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
10293         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
10294         (updateHiddenPlatforms):
10295         (documentReady.unhideButton):
10296         (documentReady.hideButton):
10297         (documentReady):
10298         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: Added.
10299         (Settings.prototype.setObject):
10300         (Settings.prototype.getObject):
10301         (Settings.prototype.addSettingListener):
10302         (Settings.prototype.fireSettingListener):
10303         (Settings.prototype.toggleHiddenPlatform):
10304         (Settings.prototype.clearHiddenPlatforms):
10305         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
10306         (div.cellButton):
10307         (div.cellButton.hide):
10308         (.hidden):
10309         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
10311 2013-11-15  Jer Noble  <jer.noble@apple.com>
10313         MediaTime addition and subtraction operators have errors when the rhs is infinite.
10314         https://bugs.webkit.org/show_bug.cgi?id=124413
10316         Reviewed by Eric Carlson.
10318         Add a test for operator+ and operator- where an infinite value appears
10319         on the right-hand side:
10320         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
10321         (TestWebKitAPI::TEST):
10323         Add a LLDB summary provider for MediaTime which displays the rational
10324         time as well as the value in seconds:
10325         * lldb/lldb_webkit.py:
10326         (__lldb_init_module):
10327         (WTFMediaTime_SummaryProvider):
10328         (WTFHashTableProvider.has_children):
10329         (WTFMediaTimeProvider):
10330         (WTFMediaTimeProvider.__init__):
10331         (WTFMediaTimeProvider.timeValue):
10332         (WTFMediaTimeProvider.timeScale):
10333         (WTFMediaTimeProvider.isInvalid):
10334         (WTFMediaTimeProvider.isPositiveInfinity):
10335         (WTFMediaTimeProvider.isNegativeInfinity):
10336         (WTFMediaTimeProvider.isIndefinite):
10338 2013-11-15  Tim Horton  <timothy_horton@apple.com>
10340         Make it possible to select revision numbers on build.webkit.org/dashboard
10341         https://bugs.webkit.org/show_bug.cgi?id=124400
10343         Reviewed by Timothy Hatcher.
10345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
10346         (BuildbotQueueView.prototype.revisionLinksForIteration):
10347         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
10348         (.selectable):
10349         Add a child span to the trac link, which has '-webkit-user-select: all' on it.
10350         This way, a Dashboard user can highlight revision numbers for easy copying,
10351         and doesn't even have to be precise about the selection.
10353 2013-11-15  Tim Horton  <timothy_horton@apple.com>
10355         Adjust and add retina versions of EFL and GTK build.webkit.org/dashboard icons
10356         https://bugs.webkit.org/show_bug.cgi?id=124399
10358         Reviewed by Gustavo Noronha Silva.
10360         Add new EFL and GTK icons (derived from Wikipedia's SVGs) to make new 1x and 2x icons,
10361         with the icons adjusted to have solid backgrounds, to not be squished, and to not
10362         intersect the ring, similar to the Mac icons.
10364         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png:
10365         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Added.
10366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
10367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png: Added.
10368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
10369         (documentReady.hideButton):
10370         (documentReady):
10371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
10372         (table.queue-grid tr.platform.linux-gtk img.logo):
10373         (table.queue-grid tr.platform.linux-efl img.logo):
10375 2013-11-15  Stephane Jadaud  <sjadaud@sii.fr>
10377         [GStreamer] Add support for Media Source API
10378         https://bugs.webkit.org/show_bug.cgi?id=99065
10380         Reviewed by Philippe Normand.
10382         * Scripts/webkitperl/FeatureList.pm:
10384 2013-11-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
10386         [GTK] Bumping GStreamer version to 1.2.1 for the dependencies
10387         https://bugs.webkit.org/show_bug.cgi?id=124360
10389         Reviewed by Philippe Normand.
10391         * gtk/jhbuild.modules: Bumped GStreamer version up to 1.2.1
10393 2013-11-14  Brent Fulgham  <bfulgham@apple.com>
10395         [Win] Improve support for command line builds of 64-bit JSC
10396         https://bugs.webkit.org/show_bug.cgi?id=124380
10398         Reviewed by David Kilzer.
10400         * Scripts/webkitdirs.pm:
10401         (argumentsForConfiguration): Recognize all flavors of Debug and Release (i.e., 'Debug',
10402         'Debug|Win32', 'Debug|x64') when passing arguments to child processes.
10403         (determinePassedConfiguration): Don't suffix configuration with "|Win32" or "|x64". That's
10404         what the "$configurationForVisualStudio" value is for.
10406 2013-11-14  Oliver Hunt  <oliver@apple.com>
10408         Make CLoop easier to build, and make it work
10409         https://bugs.webkit.org/show_bug.cgi?id=124359
10411         Reviewed by Geoffrey Garen.
10413         Add --cloop support to forcibly enable to CLoop build
10415         * Scripts/build-jsc:
10416         * Scripts/build-webkit:
10418 2013-11-14  Lucas Forschler  <lforschler@apple.com>
10420         Add webkit slave.
10422         Unreviewed.
10424         * BuildSlaveSupport/build.webkit.org-config/config.json:
10426 2013-11-14  Tim Horton  <timothy_horton@apple.com>
10428         build.webkit.org/dashboard can’t open different results in two new tabs
10429         https://bugs.webkit.org/show_bug.cgi?id=124383
10431         Reviewed by Alexey Proskuryakov.
10433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
10434         (BuildbotQueueView.prototype.revisionLinksForIteration):
10435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
10436         (StatusLineView.prototype._clicked):
10437         Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
10438         real pseudo-target and instead acts as a named target and will end up causing all link clicks
10439         to open in the same secondary tab).
10441 2013-11-14  Anders Carlsson  <andersca@apple.com>
10443         Remove duplicate entry.
10445         * Scripts/webkitpy/common/config/contributors.json:
10447 2013-11-14  Krzysztof Czech  <k.czech@samsung.com>
10449         [ATK] Change WKTR/DRT AX methods to use nullptr 
10450         https://bugs.webkit.org/show_bug.cgi?id=124352
10452         Reviewed by Anders Carlsson.
10454         Change WKTR/DRT accessibility related methods to use nullptr.
10456         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
10457         (AccessibilityController::AccessibilityController):
10458         (AccessibilityController::elementAtPoint):
10459         (AccessibilityController::removeNotificationListener):
10460         (AccessibilityController::childElementById):
10461         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
10462         (AccessibilityNotificationHandler::AccessibilityNotificationHandler):
10463         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
10464         (AccessibilityUIElement::elementAtPoint):
10465         (AccessibilityUIElement::linkedUIElementAtIndex):
10466         (AccessibilityUIElement::getChildAtIndex):
10467         (AccessibilityUIElement::titleUIElement):
10468         (AccessibilityUIElement::parentElement):
10469         (AccessibilityUIElement::subrole):
10470         (AccessibilityUIElement::roleDescription):
10471         (AccessibilityUIElement::orientation):
10472         (AccessibilityUIElement::ariaDropEffects):
10473         (AccessibilityUIElement::uiElementForSearchPredicate):
10474         (AccessibilityUIElement::cellForColumnAndRow):
10475         (AccessibilityUIElement::disclosedRowAtIndex):
10476         (AccessibilityUIElement::ariaOwnsElementAtIndex):
10477         (AccessibilityUIElement::ariaFlowToElementAtIndex):
10478         (AccessibilityUIElement::selectedRowAtIndex):
10479         (AccessibilityUIElement::rowAtIndex):
10480         (AccessibilityUIElement::disclosedByRow):
10481         (AccessibilityUIElement::removeNotificationListener):
10482         (AccessibilityUIElement::classList):
10483         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
10484         (WTR::AccessibilityController::logAccessibilityEvents):
10485         (WTR::AccessibilityController::resetToConsistentState):
10486         (WTR::childElementById):
10487         (WTR::AccessibilityController::accessibleElementById):
10488         (WTR::AccessibilityController::removeNotificationListener):
10489         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
10490         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
10491         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
10492         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
10493         (WTR::AccessibilityUIElement::elementAtPoint):
10494         (WTR::AccessibilityUIElement::childAtIndex):
10495         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
10496         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
10497         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
10498         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
10499         (WTR::AccessibilityUIElement::rowAtIndex):
10500         (WTR::AccessibilityUIElement::selectedChildAtIndex):
10501         (WTR::AccessibilityUIElement::selectedRowAtIndex):
10502         (WTR::AccessibilityUIElement::titleUIElement):
10503         (WTR::AccessibilityUIElement::parentElement):
10504         (WTR::AccessibilityUIElement::disclosedByRow):
10505         (WTR::AccessibilityUIElement::uiElementAttributeValue):
10506         (WTR::AccessibilityUIElement::orientation):
10507         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
10508         (WTR::AccessibilityUIElement::cellForColumnAndRow):
10509         (WTR::AccessibilityUIElement::horizontalScrollbar):
10510         (WTR::AccessibilityUIElement::verticalScrollbar):
10511         (WTR::AccessibilityUIElement::removeNotificationListener):
10512         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
10513         (WTR::AccessibilityUIElement::previousTextMarker):
10514         (WTR::AccessibilityUIElement::nextTextMarker):
10515         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
10516         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
10517         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
10518         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
10519         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
10520         (WTR::AccessibilityUIElement::textMarkerForPoint):
10521         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
10522         (WTR::AccessibilityUIElement::textMarkerForIndex):
10523         (WTR::AccessibilityUIElement::supportedActions):
10524         (WTR::AccessibilityUIElement::pathDescription):
10525         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
10526         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
10527         (WTR::AccessibilityUIElement::classList):
10529 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
10531         run-perf-tests should warn loudly if you're using a Debug build.
10532         https://bugs.webkit.org/show_bug.cgi?id=105236
10534         Reviewed by Csaba Osztrogonác.
10536         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
10537         (PerfTestsRunner.run):
10539 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
10541         Fix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration is default
10542         https://bugs.webkit.org/show_bug.cgi?id=124143
10544         Reviewed by Csaba Osztrogonác.
10546         * Scripts/webkitpy/port/factory.py:
10547         (configuration_options):
10549 2013-11-13  Anders Carlsson  <andersca@apple.com>
10551         Add a Vector constructor that takes an std::initializer_list
10552         https://bugs.webkit.org/show_bug.cgi?id=124287
10554         Reviewed by Antti Koivisto.
10556         * TestWebKitAPI/Tests/WTF/Vector.cpp:
10557         (TestWebKitAPI::TEST):
10559 2013-11-13  Mario Sanchez Prada  <mario.prada@samsung.com>
10561         Unreviewed GTK gardening. Updated rebaseline unit tests to include WK2 bot.
10563         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
10564         (TestRebaselineTest.test_baseline_directory): Updated.
10566 2013-11-13  Krzysztof Czech  <k.czech@samsung.com>
10568         [ATK] Support compilation of EFL/GTK without accessibility
10569         https://bugs.webkit.org/show_bug.cgi?id=122448
10571         Reviewed by Chris Fleizach.
10573         Added missing HAVE(ACCESSIBILITY) guards and stubs to ATK's related files,
10574         so that in case of turning off the HAVE_ACCESSIBILITY macro EFL/GTK would compile properly.
10576         * DumpRenderTree/AccessibilityController.h:
10577         * DumpRenderTree/AccessibilityUIElement.h:
10578         * DumpRenderTree/atk/AccessibilityCallbacks.h:
10579         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
10580         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
10581         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
10582         (WTR::AccessibilityController::rootElement):
10583         (WTR::AccessibilityController::focusedElement):
10584         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
10585         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
10586         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
10587         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
10588         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
10589         * WebKitTestRunner/PlatformEfl.cmake:
10591 2013-11-12  Ryuan Choi  <ryuan.choi@samsung.com>
10593         [EFL] Added libxss-dev to install-dependencies
10594         https://bugs.webkit.org/show_bug.cgi?id=124254
10596         Reviewed by Gyuyoung Kim.
10598         libxss-dev is required to build EFL packages.
10599         see building part in http://www.enlightenment.org/p.php?p=contribute
10601         * efl/install-dependencies: Added libxss-dev to parameter of apt-get command.
10603 2013-11-12  Tim Horton  <timothy_horton@apple.com>
10605         After http://trac.webkit.org/changeset/159109, update
10606         rebaseline_unittest to use the new GTK bot names.
10608         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
10609         (TestRebaselineTest.test_baseline_directory):
10611 2013-11-12  Denis Nomiyama  <d.nomiyama@samsung.com>
10613         [GTK] Update GTK builders in Tools/Scripts/webkitpy/port/builders.py
10614         https://bugs.webkit.org/show_bug.cgi?id=124144
10616         Reviewed by Gustavo Noronha Silva.
10618         Updated the list of GTK builders in Tools/Scripts/webkitpy/port/builders.py
10619         according to http://build.webkit.org/builders.
10621         * Scripts/webkitpy/port/builders.py:
10623 2013-11-11  Samuel White  <samuel_white@apple.com>
10625         AX: support helpText() in DumpRenderTree
10626         https://bugs.webkit.org/show_bug.cgi?id=40194
10628         Reviewed by Chris Fleizach.
10630         Implemented stubbed helpText methods so we can move aria-help.html back to LayoutTests/accessibility.
10632         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
10633         (AccessibilityUIElement::helpText):
10635 2013-11-11  Anders Carlsson  <andersca@apple.com>
10637         Remove block based APIs from the WebKit2 C API
10638         https://bugs.webkit.org/show_bug.cgi?id=124157
10640         Reviewed by Sam Weinig.
10642         Update for WK2 changes.
10644         * MiniBrowser/mac/WK2BrowserWindowController.m:
10645         (dumpSource):
10646         (-[WK2BrowserWindowController dumpSourceToConsole:]):
10648 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
10650         The feeder queue will not feed patches older than one week.
10651         https://bugs.webkit.org/show_bug.cgi?id=107152
10653         Reviewed by Csaba Osztrogonác.
10655         The feeder queue will not feed patches older than one week.
10656         Unit test added to this scenario.
10658         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
10659         (BugzillaQueries._parse_attachment_ids_request_query):
10660           Handle date parameter.
10661         (BugzillaQueries):
10662         (BugzillaQueries._fetch_attachment_ids_request_query):
10663           Propagate date.
10664         (BugzillaQueries.fetch_attachment_ids_from_review_queue):
10665           Propagate date.
10666         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
10667         (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
10668           Handle date.
10669         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
10670         (test_request_page_parsing):
10671           Unit test added.
10672         * Scripts/webkitpy/tool/bot/feeders.py:
10673         (EWSFeeder.feed):
10674           Query patch ids with date parameter (now - 1 week).
10676 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
10678         Do not shut down ImageDiff server after every diff during the tests.
10679         https://bugs.webkit.org/show_bug.cgi?id=124140
10681         Reviewed by Csaba Osztrogonác.
10683         There was a FIXME: There is no need to shut down the ImageDiff
10684         server after every diff. Shutdown is removed from that point.
10686         * Scripts/webkitpy/port/image_diff.py:
10687         (ImageDiffer._read):
10689 2013-11-08  Matthew Hanson  <matthew_hanson@apple.com>
10691         Unreviewed. Added myself as a contributor.
10693         * Scripts/webkitpy/common/config/contributors.json:
10695 2013-11-08  Krzysztof Czech  <k.czech@samsung.com>
10697         [GTK] accessibility/aria-link-supports-press.html is failing
10698         https://bugs.webkit.org/show_bug.cgi?id=98355
10700         Reviewed by Mario Sanchez Prada.
10702         Checking "jump" action for link elements. Action "jump" occurs when a link 
10703         element is pressed/clicked.
10705         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
10706         (AccessibilityUIElement::isPressActionSupported):
10707         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
10708         (WTR::AccessibilityUIElement::isPressActionSupported):
10710 2013-11-08  Przemyslaw Szymanski  <p.szymanski3@samsung.com>
10712         [JHBUILD] Jhbuild Makefile build bug workaround
10713         https://bugs.webkit.org/show_bug.cgi?id=123971
10715         Reviewed by Ryosuke Niwa.
10717         After Jhbuild repository is cloned (for instance when you use
10718         Tools/Scripts/update-webkitefl-libs) it is built from sources.
10719         If you have GREP_OPTIONS grep env variable set (for instance
10720         GREP_OPTIONS=-n) then it is jhbuild build error. Makefile.plain
10721         uses shell grep. For specific GREP_OPTIONS grep output will be
10722         different than expected one by Jhbuild and there is an error
10723         with Jhbuild build. Jhbuild will not be built and then WebKit
10724         source also will not be built. This patch is a workaround to this
10725         issue. It disables GREP_OPTIONS for Jhbuild build time.
10727         * jhbuild/jhbuild-wrapper:
10728         (install_jhbuild):
10730 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
10732         [GTK] Ignore deprecated macros when generating gtk-doc
10733         https://bugs.webkit.org/show_bug.cgi?id=123988
10735         Reviewed by Philippe Normand.
10737         * gtk/generate-gtkdoc:
10738         (get_common_options): Ignore also WEBKIT_DEPRECATED and
10739         WEBKIT_DEPRECATED_FOR decorators.
10741 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
10743         [GTK] Pass the library namespace to gtkdoc-mkdb
10744         https://bugs.webkit.org/show_bug.cgi?id=123900
10746         Reviewed by Martin Robinson.
10748         This fixes the generation of the index of symbols in the API
10749         documentation.
10751         * gtk/generate-gtkdoc:
10752         (get_webkit2_options): Define namespace as WebKit.
10753         (get_webkit1_options): Ditto.
10754         (get_webkitdom_options): Define namespace as WebKitDOM.
10755         * gtk/gtkdoc.py:
10756         (GTKDoc.__init__): Add namespace option.
10757         (GTKDoc._run_gtkdoc_mkdb): Pass namespace to mkdb if present.
10759 2013-11-07  Chris Fleizach  <cfleizach@apple.com>
10761         Modify email order list for James Craig so his primary email is first.
10763         * Scripts/webkitpy/common/config/contributors.json:
10765 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
10767         [Gtk] Disable LTO when building cairo
10768         https://bugs.webkit.org/show_bug.cgi?id=123954
10770         Reviewed by Martin Robinson.
10772         Cairo always uses LTO, when it detects compiler support.
10773         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
10774         default. This patch disables LTO when building cairo library.
10775         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
10777         With gcc 4.7.3, for example, the build fails with the following message:
10778         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
10780         * gtk/jhbuild.modules:
10782 2013-11-07  Samuel White  <samuel_white@apple.com>
10784         AX: DRT AccessibilityUIElement::isFocused methods should be finished.
10785         https://bugs.webkit.org/show_bug.cgi?id=123774
10787         Reviewed by Chris Fleizach.
10789         Implemented AccessibilityUIElement::isFocused methods and removed FIXMEs.
10791         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
10792         (AccessibilityUIElement::isFocused):
10793         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
10794         (WTR::AccessibilityUIElement::isFocused):
10796 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
10798         Removed retrieveQMakespecVar function
10799         https://bugs.webkit.org/show_bug.cgi?id=123996
10801         Reviewed by Csaba Osztrogonác.
10803         * Scripts/webkitdirs.pm:
10805 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
10807         Removed QMake related filters
10808         https://bugs.webkit.org/show_bug.cgi?id=123992
10810         Reviewed by Csaba Osztrogonác.
10812         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
10813         (TestRebaseline.test_rebaseline):
10814         (TestRebaselineExpectations.test_rebaseline_expectations):
10816 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
10818         [Efl] Disable LTO when building cairo
10819         https://bugs.webkit.org/show_bug.cgi?id=123947
10821         Reviewed by Gyuyoung Kim.
10823         Cairo always uses LTO, when it detects compiler support.
10824         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
10825         default. This patch disables LTO when building cairo library.
10826         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
10828         With gcc 4.7.3, for example, the build fails with the following message:
10829         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
10831         * efl/jhbuild.modules:
10833 2013-11-07  Mario Sanchez Prada  <mario.prada@samsung.com>
10835         AX: [ATK] Video and audio elements are not properly exposed
10836         https://bugs.webkit.org/show_bug.cgi?id=123894
10838         Reviewed by Chris Fleizach.
10840         Update DRT and WKTR to handle the ATK_ROLE_EMBEDDED role.
10842         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Updated.
10843         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Updated.
10845 2013-11-07  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
10847         Change git_commit_from_svn_revision() to work in a pure git checkout
10848         https://bugs.webkit.org/show_bug.cgi?id=111668
10850         Reviewed by Ryosuke Niwa.
10852         * Scripts/webkitpy/common/checkout/scm/git.py:
10853         (Git.git_commit_from_svn_revision):
10855 2013-11-06  Jer Noble  <jer.noble@apple.com>
10857         Unreviewed webkitpy unit test fix; update baselines after r158765
10859         * Scripts/webkitpy/port/win_unittest.py:
10860         (WinPortTest.test_baseline_search_path):
10862 2013-11-06  Jer Noble  <jer.noble@apple.com>
10864         [Win] run-webkit-tests on the win platform should fall back to mac-mountainlion, not mac-lion.
10865         https://bugs.webkit.org/show_bug.cgi?id=123905
10867         Reviewed by Brent Fulgham.
10869         Now that the mac-lion results have been removed, the win port should fall back to
10870         the mac-mountainlion results.
10872         * Scripts/webkitpy/port/win.py:
10873         (WinPort.default_baseline_search_path):
10875 2013-11-06  Anders Carlsson  <andersca@apple.com>
10877         Fix a Mountain Lion test failure.
10879         NSURLRequest doesn't conform to NSSecureCoding on Mountain Lion, so don't try to test encoding it.
10881         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
10882         (TestWebKitAPI::TEST):
10884 2013-11-06  Krzysztof Czech  <k.czech@samsung.com>
10886         [ATK] Implement tables-related attributesOf*() functions for AccessibilityUIElement
10887         https://bugs.webkit.org/show_bug.cgi?id=118969
10889         Reviewed by Mario Sanchez Prada.
10891         Added missing implementation of attributesOfColumnHeaders, attributesOfRowHeaders, attributesOfVisibleCells.
10893         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
10894         (AccessibilityUIElement::attributesOfChildren):
10895         (AccessibilityUIElement::attributesOfColumnHeaders):
10896         (AccessibilityUIElement::attributesOfRowHeaders):
10897         (AccessibilityUIElement::attributesOfVisibleCells):
10898         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
10899         (WTR::AccessibilityUIElement::attributesOfChildren):
10900         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
10901         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
10902         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
10904 2013-11-05  Benjamin Poulain  <benjamin@webkit.org>
10906         [WK2] Add a WebKit2 API for Geolocation's highAccuracy
10907         https://bugs.webkit.org/show_bug.cgi?id=123786
10909         Reviewed by Darin Adler.
10911         Add basic testing for the Geolocation API (start, stop and change accuracy).
10913         * TestWebKitAPI/GNUmakefile.am:
10914         * TestWebKitAPI/PlatformEfl.cmake:
10915         * TestWebKitAPI/PlatformGTK.cmake:
10916         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10917         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: Added.
10918         (TestWebKitAPI::operator<<):
10919         (TestWebKitAPI::GeolocationStateTracker::~GeolocationStateTracker):
10920         (TestWebKitAPI::GeolocationStateTracker::eventsChanged):
10921         (TestWebKitAPI::GeolocationStateTracker::startUpdatingCallback):
10922         (TestWebKitAPI::GeolocationStateTracker::stopUpdatingCallback):
10923         (TestWebKitAPI::GeolocationStateTracker::setEnableHighAccuracyCallback):
10924         (TestWebKitAPI::decidePolicyForGeolocationPermissionRequestCallBack):
10925         (TestWebKitAPI::setupGeolocationProvider):
10926         (TestWebKitAPI::setupView):
10927         (TestWebKitAPI::GeolocationBasicStateTracker::GeolocationBasicStateTracker):
10928         (TestWebKitAPI::GeolocationBasicStateTracker::eventsChanged):
10929         (TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::GeolocationBasicWithHighAccuracyStateTracker):
10930         (TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::eventsChanged):
10931         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker):
10932         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
10933         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker):
10934         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
10935         (TestWebKitAPI::didFinishLoadForFrame):
10936         * TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPosition.html: Added.
10937         * TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPositionWithHighAccuracy.html: Added.
10938         * TestWebKitAPI/Tests/WebKit2/geolocationWatchPosition.html: Added.
10939         * TestWebKitAPI/Tests/WebKit2/geolocationWatchPositionWithHighAccuracy.html: Added.
10940         * WebKitTestRunner/GeolocationProviderMock.cpp:
10941         (WTR::GeolocationProviderMock::GeolocationProviderMock):
10943 2013-11-05  Anders Carlsson  <andersca@apple.com>
10945         Implement more NSCoder methods
10946         https://bugs.webkit.org/show_bug.cgi?id=123815
10948         Reviewed by Dan Bernstein.
10950         Add a method that takes an NSArray, an NSDictionary and an NSURLRequest.
10952         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
10953         (TestWebKitAPI::TEST):
10954         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
10955         (-[BundleObject testMethodWithArray:dictionary:request:]):
10956         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:
10958 2013-11-05  Filip Pizlo  <fpizlo@apple.com>
10960         Update ReducedFTL
10961         https://bugs.webkit.org/show_bug.cgi?id=123805
10963         Reviewed by Sam Weinig.
10964         
10965         - Make ReducedFTL build with debug info.
10966         
10967         - Give ReducedFTL a --loop mode that runs everything in a loop. Great for finding
10968           memory leaks and attaching a profiler.
10969         
10970         - Reorder the passes so that they match the FTL.
10971         
10972         - Make it possible to change the backend opt level and enable the fast isel.
10974         * ReducedFTL/ReducedFTL.c:
10975         (usage):
10976         (roundUpSize):
10977         (mmAllocateCodeSection):
10978         (main):
10979         * ReducedFTL/build.sh:
10981 2013-11-05  Chris Fleizach  <cfleizach@apple.com>
10983         AX: switch DRT AX methods to use nullptr
10984         https://bugs.webkit.org/show_bug.cgi?id=123773
10986         Reviewed by Andreas Kling.
10988         Switch AX related code in DRT and WKTR to use nullptr.
10990         * DumpRenderTree/AccessibilityUIElement.cpp:
10991         (AccessibilityUIElement::startTextMarker):
10992         (AccessibilityUIElement::endTextMarker):
10993         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
10994         (findAccessibleObjectById):
10995         (AccessibilityController::accessibleElementById):
10996         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
10997         (AccessibilityUIElement::getChildAtIndex):
10998         (AccessibilityUIElement::linkedUIElementAtIndex):
10999         (AccessibilityUIElement::ariaOwnsElementAtIndex):
11000         (AccessibilityUIElement::ariaFlowToElementAtIndex):
11001         (AccessibilityUIElement::disclosedRowAtIndex):
11002         (AccessibilityUIElement::selectedChildAtIndex):
11003         (AccessibilityUIElement::selectedRowAtIndex):
11004         (AccessibilityUIElement::rowAtIndex):
11005         (AccessibilityUIElement::titleUIElement):
11006         (AccessibilityUIElement::parentElement):
11007         (AccessibilityUIElement::disclosedByRow):
11008         (AccessibilityUIElement::stringAttributeValue):
11009         (AccessibilityUIElement::uiElementAttributeValue):
11010         (AccessibilityUIElement::role):
11011         (AccessibilityUIElement::subrole):
11012         (AccessibilityUIElement::roleDescription):
11013         (AccessibilityUIElement::title):
11014         (AccessibilityUIElement::description):
11015         (AccessibilityUIElement::orientation):
11016         (AccessibilityUIElement::stringValue):
11017         (AccessibilityUIElement::language):
11018         (AccessibilityUIElement::helpText):
11019         (AccessibilityUIElement::valueDescription):
11020         (AccessibilityUIElement::speak):
11021         (AccessibilityUIElement::classList):
11022         (AccessibilityUIElement::ariaDropEffects):
11023         (AccessibilityUIElement::rangeForLine):
11024         (AccessibilityUIElement::rangeForPosition):
11025         (AccessibilityUIElement::boundsForRange):
11026         (AccessibilityUIElement::stringForRange):
11027         (AccessibilityUIElement::attributedStringForRange):
11028         (AccessibilityUIElement::uiElementForSearchPredicate):
11029         (AccessibilityUIElement::attributesOfColumnHeaders):
11030         (AccessibilityUIElement::attributesOfRowHeaders):
11031         (AccessibilityUIElement::attributesOfColumns):
11032         (AccessibilityUIElement::attributesOfRows):
11033         (AccessibilityUIElement::attributesOfVisibleCells):
11034         (AccessibilityUIElement::attributesOfHeader):
11035         (AccessibilityUIElement::rowIndexRange):
11036         (AccessibilityUIElement::columnIndexRange):
11037         (AccessibilityUIElement::cellForColumnAndRow):
11038         (AccessibilityUIElement::horizontalScrollbar):
11039         (AccessibilityUIElement::verticalScrollbar):
11040         (AccessibilityUIElement::pathDescription):
11041         (AccessibilityUIElement::selectedTextRange):
11042         (AccessibilityUIElement::url):
11043         (AccessibilityUIElement::textMarkerRangeForElement):
11044         (AccessibilityUIElement::textMarkerForIndex):
11045         (AccessibilityUIElement::previousTextMarker):
11046         (AccessibilityUIElement::nextTextMarker):
11047         (AccessibilityUIElement::stringForTextMarkerRange):
11048         (AccessibilityUIElement::textMarkerRangeForMarkers):
11049         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
11050         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
11051         (AccessibilityUIElement::endTextMarkerForBounds):
11052         (AccessibilityUIElement::startTextMarkerForBounds):
11053         (AccessibilityUIElement::textMarkerForPoint):
11054         (AccessibilityUIElement::accessibilityElementForTextMarker):
11055         (AccessibilityUIElement::startTextMarker):
11056         (AccessibilityUIElement::endTextMarker):
11057         (AccessibilityUIElement::supportedActions):
11058         (AccessibilityUIElement::mathPostscriptsDescription):
11059         (AccessibilityUIElement::mathPrescriptsDescription):
11060         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
11061         (WTR::AccessibilityController::accessibleElementById):
11062         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
11063         (WTR::AccessibilityUIElement::startTextMarker):
11064         (WTR::AccessibilityUIElement::endTextMarker):
11065         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
11066         (WTR::findAccessibleObjectById):
11067         (WTR::AccessibilityController::accessibleElementById):
11068         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
11069         (WTR::AccessibilityUIElement::childAtIndex):
11070         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
11071         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
11072         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
11073         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
11074         (WTR::AccessibilityUIElement::rowAtIndex):
11075         (WTR::AccessibilityUIElement::selectedChildAtIndex):
11076         (WTR::AccessibilityUIElement::selectedRowAtIndex):
11077         (WTR::AccessibilityUIElement::titleUIElement):
11078         (WTR::AccessibilityUIElement::parentElement):
11079         (WTR::AccessibilityUIElement::disclosedByRow):
11080         (WTR::AccessibilityUIElement::stringAttributeValue):
11081         (WTR::AccessibilityUIElement::uiElementAttributeValue):
11082         (WTR::AccessibilityUIElement::role):
11083         (WTR::AccessibilityUIElement::subrole):
11084         (WTR::AccessibilityUIElement::roleDescription):
11085         (WTR::AccessibilityUIElement::title):
11086         (WTR::AccessibilityUIElement::description):
11087         (WTR::AccessibilityUIElement::orientation):
11088         (WTR::AccessibilityUIElement::stringValue):
11089         (WTR::AccessibilityUIElement::language):
11090         (WTR::AccessibilityUIElement::helpText):
11091         (WTR::AccessibilityUIElement::valueDescription):
11092         (WTR::AccessibilityUIElement::classList):
11093         (WTR::AccessibilityUIElement::speak):
11094         (WTR::AccessibilityUIElement::ariaDropEffects):
11095         (WTR::AccessibilityUIElement::rangeForLine):
11096         (WTR::AccessibilityUIElement::rangeForPosition):
11097         (WTR::AccessibilityUIElement::boundsForRange):
11098         (WTR::AccessibilityUIElement::stringForRange):
11099         (WTR::AccessibilityUIElement::attributedStringForRange):
11100         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
11101         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
11102         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
11103         (WTR::AccessibilityUIElement::attributesOfColumns):
11104         (WTR::AccessibilityUIElement::attributesOfRows):
11105         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
11106         (WTR::AccessibilityUIElement::attributesOfHeader):
11107         (WTR::AccessibilityUIElement::rowIndexRange):
11108         (WTR::AccessibilityUIElement::columnIndexRange):
11109         (WTR::AccessibilityUIElement::cellForColumnAndRow):
11110         (WTR::AccessibilityUIElement::horizontalScrollbar):
11111         (WTR::AccessibilityUIElement::verticalScrollbar):
11112         (WTR::AccessibilityUIElement::selectedTextRange):
11113         (WTR::AccessibilityUIElement::url):
11114         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
11115         (WTR::AccessibilityUIElement::previousTextMarker):
11116         (WTR::AccessibilityUIElement::nextTextMarker):
11117         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
11118         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
11119         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
11120         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
11121         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
11122         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
11123         (WTR::AccessibilityUIElement::textMarkerForPoint):
11124         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
11125         (WTR::AccessibilityUIElement::textMarkerForIndex):
11126         (WTR::AccessibilityUIElement::startTextMarker):
11127         (WTR::AccessibilityUIElement::endTextMarker):
11128         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
11129         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
11130         (WTR::AccessibilityUIElement::pathDescription):
11131         (WTR::AccessibilityUIElement::supportedActions):
11133 2013-11-05  László Langó  <laszlo.lango@frontendart.com>
11135         Remove leftover Qt related things from the flakiness_dashboard
11136         https://bugs.webkit.org/show_bug.cgi?id=123800
11138         Reviewed by Anders Carlsson.
11140         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
11141         (test):
11143 2013-11-05  Robert Plociennik  <r.plociennik@samsung.com>
11145         [EFL] accessibility/svg-group-element-with-title.html is failing
11146         https://bugs.webkit.org/show_bug.cgi?id=114151
11148         Reviewed by Mario Sanchez Prada.
11150         atk_component_ref_accessible_at_point(), utilized in
11151         AccessibilityUIElement::elementAtPoint(), is expected to 'get a reference to the
11152         accessible child, if one exists, at the coordinate point specified' and not
11153         explicitly return self in case of lack of child elements. This contradicts with
11154         expected behavior of elementAtPoint(). Therefore, elementAtPoint() is
11155         changed to return self regardless of coordinates specified, provided no child
11156         element could be retrieved, effectively mimicing the behaviour of equivalent
11157         Mac implementation in accessibilityHitTest().
11159         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
11160         (AccessibilityUIElement::elementAtPoint): Fixed.
11161         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
11162         (WTR::AccessibilityUIElement::elementAtPoint): Fixed.
11164 2013-11-05  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
11166         [CSS] Enable css-image-orientation on EFL and GTK ports.
11167         https://bugs.webkit.org/show_bug.cgi?id=123698
11169         Reviewed by Beth Dakin.
11171         r157909 added wrong early return for css-image-orientation. It causes about 20 regressions in layout test
11172         when enabling css-image-orientaiton. This fixes those wrong implementation as well as enables it on EFL
11173         and GTK ports by default.
11175         * Scripts/webkitperl/FeatureList.pm:
11177 2013-11-04  Alexey Proskuryakov  <ap@apple.com>
11179         DumpRenderTree should reset its preferences file on launch
11180         https://bugs.webkit.org/show_bug.cgi?id=29751
11182         Reviewed by Dan Bernstein.
11184         Using NSArgumentDomain was not a good idea. While it works with NSUserDefaults
11185         and CFPreferencesCopyAppValue family of functions, it doesn't work with
11186         CFPreferencesCopyValue(..., kCFPreferencesCurrentApplication, ...).
11188         So, now we'll just set defaults in the current application.
11190         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
11191         - Delete the defaults.
11192         - Removed CFPreferencesSetAppValue calls, as -setValuesForKeysWithDictionary: does the same.
11193         - The comment about [NSUserDefaults standardUserDefaults] indirectly initializing NSApplication was incorrect.
11195         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
11196         Switched to -setValuesForKeysWithDictionary for consistency.
11198 2013-11-04  Filip Pizlo  <fpizlo@apple.com>
11200         Running FTL tests shouldn't reduce coverage on DFG tests
11201         https://bugs.webkit.org/show_bug.cgi?id=123780
11203         Reviewed by Geoffrey Garen.
11205         * Scripts/run-jsc-stress-tests:
11207 2013-11-04  Anders Carlsson  <andersca@apple.com>
11209         More WKRemoteObjectRegistry work
11210         https://bugs.webkit.org/show_bug.cgi?id=123754
11212         Reviewed by Dan Bernstein.
11214         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
11215         (TestWebKitAPI::TEST):
11216         Use the correct bundle test name. Call Util::run.
11218         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
11219         (-[BundleObject sayHello]):
11220         (-[BundleObject testMethodWithString:double:integer:]):
11221         Add BundleObject implementation. Register the bundle object with
11222         the remote object registry. Call _handleMessageWithName:body: on the incoming message.
11224 2013-11-04  Krzysztof Czech  <k.czech@samsung.com>
11226         [EFL] Change ATK version to 2.10.0
11227         https://bugs.webkit.org/show_bug.cgi?id=123727
11229         Reviewed by Mario Sanchez Prada.
11231         Provided new API to retrieve text at a given offset.
11233         * efl/jhbuild.modules:
11235 2013-11-04  Robert Plociennik  <r.plociennik@samsung.com>
11237         [EFL] accessibility/textarea-line-for-index.html is failing
11238         https://bugs.webkit.org/show_bug.cgi?id=112015
11240         Reviewed by Mario Sanchez Prada.
11242         Provided implementation for AccessibilityUIElement::lineForIndex().
11244         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
11245         (AccessibilityUIElement::lineForIndex): Implemented.
11246         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
11247         (WTR::AccessibilityUIElement::lineForIndex): Implemented.
11249 2013-11-04  Krzysztof Czech  <k.czech@samsung.com>
11251         [EFL] accessibility/button-press-action.html
11252         https://bugs.webkit.org/show_bug.cgi?id=111993
11254         Reviewed by Mario Sanchez Prada.
11256         Provided an implementation for AccessibilityUIElement::isPressActionSupported.
11258         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
11259         (AccessibilityUIElement::isPressActionSupported):
11260         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
11261         (WTR::AccessibilityUIElement::isPressActionSupported):
11263 2013-11-03  Patrick Gansterer  <paroga@webkit.org>
11265         Add test for ListHashSet::removeLast()
11266         https://bugs.webkit.org/show_bug.cgi?id=121810
11268         Reviewed by Anders Carlsson.
11270         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
11271         (TestWebKitAPI::TEST):
11273 2013-11-02  Filip Pizlo  <fpizlo@apple.com>
11275         LLVM assertion failures should funnel into WTF's crash handling
11276         https://bugs.webkit.org/show_bug.cgi?id=123682
11278         Reviewed by Geoffrey Garen.
11279         
11280         Need to disable LLVM's crash overrides so that we can do our own crash overrides.
11282         * Scripts/configure-llvm:
11284 2013-11-01  Andy Estes  <aestes@apple.com>
11286         Teach check-for-webkit-framework-include-consistency to ignore stale iOS Private headers that might exist in build directories due to r158443
11287         https://bugs.webkit.org/show_bug.cgi?id=123636
11289         Reviewed by Andreas Kling.
11291         * Scripts/check-for-webkit-framework-include-consistency:
11293 2013-11-01  Anders Carlsson  <andersca@apple.com>
11295         Begin work on encoding argument types
11296         https://bugs.webkit.org/show_bug.cgi?id=123631
11298         Reviewed by Dan Bernstein.
11300         Add another test method.
11302         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
11303         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:
11305 2013-11-01  Afonso R. Costa Jr.  <afonso.costa@samsung.com>
11307         Expose setApplicationCacheOriginQuota via window.internals
11308         https://bugs.webkit.org/show_bug.cgi?id=87838
11310         Reviewed by Joseph Pecoraro.
11312         * DumpRenderTree/TestRunner.cpp: Move setApplicationCacheOriginQuota
11313         to window.internals
11314         (TestRunner::staticFunctions):
11315         * DumpRenderTree/TestRunner.h: Ditto.
11316         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setApplicationCacheOriginQuota.
11317         * DumpRenderTree/efl/TestRunnerEfl.cpp: Ditto.
11318         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Ditto.
11319         * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
11320         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
11321         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Ditto.
11322         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
11323         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
11325 2013-10-31  Mark Lam  <mark.lam@apple.com>
11327         REGRESSION: Crashes in -[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:].
11328         https://bugs.webkit.org/show_bug.cgi?id=123383.
11330         Reviewed by Geoffrey Garen.
11332         Removed an inappropriate assertion in DumpRenderTree/mac/UIDelegate.mm and
11333         added 2 attributes (databaseDefaultQuota and databaseMaxQuota) to allow
11334         tests to set appropriate quota settings to exercise quota expansion tests
11335         when needed.
11337         * DumpRenderTree/TestRunner.cpp:
11338         (TestRunner::TestRunner):
11339         (getDatabaseDefaultQuotaCallback):
11340         (getDatabaseMaxQuotaCallback):
11341         (setDatabaseDefaultQuotaCallback):
11342         (setDatabaseMaxQuotaCallback):
11343         (TestRunner::staticValues):
11344         * DumpRenderTree/TestRunner.h:
11345         (TestRunner::databaseDefaultQuota):
11346         (TestRunner::setDatabaseDefaultQuota):
11347         (TestRunner::databaseMaxQuota):
11348         (TestRunner::setDatabaseMaxQuota):
11349         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
11350         (BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
11351         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
11352         (onExceededDatabaseQuota):
11353         * DumpRenderTree/mac/UIDelegate.mm:
11354         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
11355         * DumpRenderTree/win/UIDelegate.cpp:
11356         (UIDelegate::exceededDatabaseQuota):
11357         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
11358         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
11359         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
11360         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
11361         (WTR::TestRunner::TestRunner):
11362         * WebKitTestRunner/InjectedBundle/TestRunner.h:
11363         (WTR::TestRunner::databaseDefaultQuota):
11364         (WTR::TestRunner::setDatabaseDefaultQuota):
11365         (WTR::TestRunner::databaseMaxQuota):
11366         (WTR::TestRunner::setDatabaseMaxQuota):
11367         * WebKitTestRunner/TestController.cpp:
11368         (WTR::TestController::createOtherPage):
11369         (WTR::TestController::createWebViewWithOptions):
11371 2013-10-31  Anders Carlsson  <andersca@apple.com>
11373         Add a WKRemoteObject class
11374         https://bugs.webkit.org/show_bug.cgi?id=123586
11376         Reviewed by Dan Bernstein.
11378         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
11379         (TestWebKitAPI::TEST):
11380         Add a conformsToProtocol: test.
11382 2013-10-30  Ryosuke Niwa  <rniwa@webkit.org>
11384         build.webkit.org should have a clean build button
11385         https://bugs.webkit.org/show_bug.cgi?id=123559
11387         Reviewed by Darin Adler.
11389         Add a new "clean" forced scheduler. When a build was created by this scheduler, CleanBuildIfScheduled
11390         step executes clean-build script that removes the WebKitBuild directory.
11392         Also added make-passwords-json.py which creates a fake passwords.json from config.json for testing purposes.
11394         * BuildSlaveSupport/build.webkit.org-config/make-passwords-json.py: Added.
11395         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
11396         (CleanBuildIfScheduled): Added.
11397         (CleanBuildIfScheduled.start): Added. Don't do a clean build if if this build wasn't schecueld by
11398         the clean build scheduler.
11399         (DeleteStaleBuildFiles): Added.
11400         (DeleteStaleBuildFiles.start): Added. Don't delete stale build files if this build was scheduled by
11401         the clean build scheduler since everything in the WebKitBuild directory had already been removed.
11402         (Factory.__init__): Always add CleanBuildIfScheduled.  The step itself checks whether to run
11403         clean-build script or hide itself.
11404         (loadBuilderConfig): Added the new clean build scheduler. Also make ForceScheduler future proof; in newer
11405         versions of buildbot, builderNames needs to be a list of regular strings.
11406         * BuildSlaveSupport/clean-build: Added.
11408 2013-10-31  Filip Pizlo  <fpizlo@apple.com>
11410         Remove CachedTranscendentalFunction because caching math functions is an ugly idea
11411         https://bugs.webkit.org/show_bug.cgi?id=123574
11413         Reviewed by Mark Hahnenberg.
11415         Make it easier to see that a test doesn't have an -expected file.
11417         * Scripts/run-jsc-stress-tests:
11419 2013-10-31  Tamas Gergely  <gertom@inf.u-szeged.hu>
11421         Run tests as if they are expected to pass when --force is given.
11422         https://bugs.webkit.org/show_bug.cgi?id=112890
11424         Reviewed by Ryosuke Niwa.
11426         The --force switch of new-run-webkit-tests is now forces all tests to
11427         be run with 'PASS' as expected result.
11429         * Scripts/webkitpy/layout_tests/controllers/manager.py:
11430         (Manager.run):
11431         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
11432         (TestExpectations.__init__):
11433         (TestExpectations._add_expectations):
11434         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
11435         (parse_args):
11436         (_set_up_derived_options):
11438 2013-10-31  Geoffrey Garen  <ggaren@apple.com>
11440         Added Mark Lam as a reviewer.
11442         Unreviewed.
11444         * Scripts/webkitpy/common/config/contributors.json:
11446 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
11448         Teach the style checker about ENUM_CLASS
11449         https://bugs.webkit.org/show_bug.cgi?id=123528
11451         Reviewed by Andy Estes.
11453         * Scripts/webkitpy/style/checkers/cpp.py:
11454         (_EnumState.process_clean_line): Make content of an ENUM_CLASS declaration
11455         equivalent to enum content for checking.
11456         (check_braces): Allow semicolon at the end.
11458         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
11459         (NoNonVirtualDestructorsTest.test_enum_casing):
11460         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon):
11461         (WebKitStyleTest.test_braces):
11462         Test it.
11464 2013-10-30  Ryosuke Niwa  <rniwa@webkit.org>
11466         kill-old-processes should kill Web Socket script
11467         https://bugs.webkit.org/show_bug.cgi?id=123546
11469         Reviewed by Benjamin Poulain.
11471         * BuildSlaveSupport/kill-old-processes:
11472         (main):
11474 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
11476         Set svn:ignore for .pyc files created for test-webkitpy.
11478         * Scripts/webkitpy/layout_tests/reftests: Added property svn:ignore.
11479         * Scripts/webkitpy/performance_tests: Added property svn:ignore.
11480         * Scripts/webkitpy/to_be_moved: Added property svn:ignore.
11481         * Scripts/webkitpy/w3c: Added property svn:ignore.
11483 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
11485         85 inspector tests asserting in DrawingAreaProxyImpl::updateAcceleratedCompositingMode()
11486         when there is a stale WebKitTestRunner preference
11487         https://bugs.webkit.org/show_bug.cgi?id=115115
11489         Reviewed by Darin Adler.
11491         Delete stale preferences on launch.
11493         * WebKitTestRunner/TestController.h:
11494         * WebKitTestRunner/TestController.cpp:
11495         (WTR::TestController::initialize): Now that we don't have preferences stored from
11496         the previous run, we need th reinstate them before creating a WKView. Not all preferences
11497         can be applied to an existing view retroactively.
11498         (WTR::TestController::resetPreferencesToConsistentValues): Split out of resetStateToConsistentValues,
11499         because there is no injected bundle yet when calling this function from initialize().
11501         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting): Delete
11502         the preferences.
11504         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
11505         Added some FIXMEs.
11507 2013-10-30  Anders Carlsson  <andersca@apple.com>
11509         Try to fix the 32-bit build.
11510         
11511         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
11512         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
11514 2013-10-30  Anders Carlsson  <andersca@apple.com>
11516         Begin fleshing out an API test for WKRemoteObjectRegistry
11517         https://bugs.webkit.org/show_bug.cgi?id=123531
11519         Reviewed by Andreas Kling.
11521         Add a very simple test that doesn't really test anything for now.
11523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11524         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Added.
11525         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Added.
11526         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Added.
11528 2013-10-30  Filip Pizlo  <fpizlo@apple.com>
11530         Remove unnecessary touch
11532         Rubber stamped by Mark Hahnenberg.
11534         * Scripts/run-jsc-stress-tests:
11536 2013-10-30  Samuel White  <samuel_white@apple.com>
11538         AX: Add samuel_white@apple.com to accessibility watchlist cc rules
11539         https://bugs.webkit.org/show_bug.cgi?id=123515
11541         Reviewed by Chris Fleizach.
11543         Adding myself and jcraig@apple.com (per his request) to the accessibility watchlist. Also
11544         updating contributors.json with permission from bweinstein@apple.com to make this possible.
11546         * Scripts/webkitpy/common/config/contributors.json:
11547         * Scripts/webkitpy/common/config/watchlist:
11549 2013-10-30  Patrick Gansterer  <paroga@webkit.org>
11551         [WIN] Add executable entry points to DRT and WinLauncher
11552         https://bugs.webkit.org/show_bug.cgi?id=121837
11554         Reviewed by Brent Fulgham.
11556         This allows to compile and run the executables without DLLLauncher.
11558         * DumpRenderTree/win/DumpRenderTree.cpp:
11559         (main):
11560         (dllLauncherEntryPoint):
11561         * WinLauncher/WinLauncher.cpp:
11562         (wWinMain):
11563         (dllLauncherEntryPoint):
11565 2013-10-30  Filip Pizlo  <fpizlo@apple.com>
11567         run-jsc-stress-tests should handle ".." in paths and "slow!" in cmd's
11568         https://bugs.webkit.org/show_bug.cgi?id=123521
11570         Reviewed by Mark Hahnenberg.
11572         * Scripts/run-jsc-stress-tests:
11574 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
11576         Mavericks: 128 tests are failing due to pixel differences
11577         https://bugs.webkit.org/show_bug.cgi?id=123488
11579         Reviewed by Simon Fraser.
11581         Apple font preferences cannot be fully reset after they've been read, so we
11582         need to set them using CFPreferences before initializing NSApplication.
11584         In theory, this should be an issue on WebKit2 as well, but somehow it doesn't
11585         appear to be. I guess we can figure out the reasons for this difference when/if
11586         any observable problems start to occur.
11588         * DumpRenderTree/mac/DumpRenderTree.mm:
11589         (setDefaultsToConsistentValuesForTesting): Only set defaults here, move other work
11590         to prepareConsistentTestingEnvironment().
11591         (main): Call setDefaultsToConsistentValuesForTesting before [NSApplication sharedApplication]
11592         (which is unnecessary anyway since NSUserDefaults will implicitly call it, but seems
11593         useful to keep in case we change out approach to defaults again).
11595 2013-10-29  Andy Estes  <aestes@apple.com>
11597         Teach the style checker how to handle Objective-C categories and NS_ENUM
11598         https://bugs.webkit.org/show_bug.cgi?id=123482
11600         Reviewed by Dan Bernstein.
11602         * Scripts/webkitpy/style/checkers/cpp.py:
11603         (check_spacing_for_function_call): Allow a space before '(' in a line
11604         starting with @interface or @implementation, since this is defining an
11605         Objective-C category rather than a function.
11606         (check_braces): The opening brace of an NS_ENUM should not be on its
11607         own line.
11608         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests.
11610 2013-10-30  Robert Plociennik  <r.plociennik@samsung.com>
11612         [EFL] accessibility/textarea-selected-text-range.html is failing
11613         https://bugs.webkit.org/show_bug.cgi?id=112016
11615         Reviewed by Mario Sanchez Prada.
11617         Provided implementation for AccessibilityUIElement::selectedTextRange() and
11618         AccessibilityUIElement::setSelectedTextRange().
11620         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
11621         (AccessibilityUIElement::selectedTextRange): Implemented.
11622         (AccessibilityUIElement::setSelectedTextRange): Implemented
11623         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
11624         (WTR::AccessibilityUIElement::selectedTextRange): Implemented.
11625         (WTR::AccessibilityUIElement::setSelectedTextRange): Implemented.
11627 2013-10-30  Robert Plociennik  <r.plociennik@samsung.com>
11629         [GTK] accessibility/svg-remote-element.html is failing
11630         https://bugs.webkit.org/show_bug.cgi?id=101185
11632         Reviewed by Chris Fleizach.
11634         Implemented missing methods by mimicing existing functionality in
11635         AccessibilityObject::clickPoint() using available ATK API.
11637         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
11638         (AccessibilityUIElement::clickPointX): Implemented.
11639         (AccessibilityUIElement::clickPointY): Implemented.
11640         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
11641         (WTR::AccessibilityUIElement::clickPointX): Implemented.
11642         (WTR::AccessibilityUIElement::clickPointY): Implemented.
11644 2013-10-30  Tamas Gergely  <gertom@inf.u-szeged.hu>
11646         Removed Windows platform configurations from WebKitTestRunner.
11647         https://bugs.webkit.org/show_bug.cgi?id=123152
11649         Reviewed by Csaba Osztrogonác.
11651         Removed Windows specific parts from the source files, Windows specific
11652         subdirectory (win) and Visual Studio property files from the WebKitTestRunner,
11653         as the platform is no longer supported by this tool.
11655         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Removed.
11656         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Removed.
11657         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Removed.
11658         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Removed.
11659         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Removed.
11660         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Removed.
11661         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
11662         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
11663         (WTR::AccessibilityController::rootElement):
11664         (WTR::AccessibilityController::focusedElement):
11665         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
11666         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
11667         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
11668         * WebKitTestRunner/InjectedBundle/TestRunner.h:
11669         * WebKitTestRunner/PlatformWebView.h:
11670         * WebKitTestRunner/TestController.cpp:
11671         (WTR::TestController::initialize):
11672         * WebKitTestRunner/TestInvocation.cpp:
11673         (WTR::createWKURL):
11674         * WebKitTestRunner/cg/TestInvocationCG.cpp:
11675         * WebKitTestRunner/config.h:
11676         * WebKitTestRunner/win/InjectedBundle.vcproj: Removed.
11677         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Removed.
11678         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Removed.
11679         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Removed.
11680         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Removed.
11681         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Removed.
11682         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Removed.
11683         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Removed.
11684         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Removed.
11685         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Removed.
11686         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Removed.
11687         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Removed.
11688         * WebKitTestRunner/win/TestControllerWin.cpp: Removed.
11689         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
11690         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed.
11691         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Removed.
11692         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Removed.
11693         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Removed.
11694         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Removed.
11695         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Removed.
11696         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Removed.
11697         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Removed.
11698         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Removed.
11699         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Removed.
11700         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Removed.
11701         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Removed.
11702         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Removed.
11703         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Removed.
11704         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Removed.
11705         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Removed.
11706         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Removed.
11707         * WebKitTestRunner/win/build-generated-files.sh: Removed.
11708         * WebKitTestRunner/win/main.cpp: Removed.
11710 2013-10-29  Alexey Proskuryakov  <ap@apple.com>
11712         Result of focus-option-control-on-page.html depends on system preferences
11713         https://bugs.webkit.org/show_bug.cgi?id=123304
11715         Reviewed by Simon Fraser.
11717         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
11718         Override a preference that WebKit reads to decide what Tab does, so that current
11719         user default doesn't affect tests.
11721         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
11722         Ditto.
11724 2013-10-29  Filip Pizlo  <fpizlo@apple.com>
11726         It should be possible to specify extra tests to run-javascriptcore-tests
11727         https://bugs.webkit.org/show_bug.cgi?id=123495
11729         Reviewed by Oliver Hunt.
11730         
11731         This adds two ways to specify additional tests: the option --extra-tests=<blah>, and
11732         the environment variable EXTRA_JSC_TESTS.
11733         
11734         Those two values (the command-line option and the environment variable) are passed
11735         as extra arguments to run-jsc-stress-tests.
11736         
11737         To make this extra super useful, run-jsc-stress-tests now allows yaml configuration
11738         files to be recursive: if a "- collection:" line is found, the string is handled
11739         just as if it was a command-line argument. This allows you to use --extra-tests=file
11740         where file contains a bunch of "- collection:" lines, and this is equivalent to each
11741         of those lines being a command-line argument.
11743         * Scripts/run-javascriptcore-tests:
11744         * Scripts/run-jsc-stress-tests:
11746 2013-10-29  Ryosuke Niwa  <rniwa@webkit.org>
11748         Add Mavericks builders to the old flakiness dashboard.
11750         * TestResultServer/static-dashboards/builders.jsonp:
11751         * TestResultServer/static-dashboards/flakiness_dashboard.js:
11753 2013-10-29  Seokju Kwon  <seokju@webkit.org>
11755         Fix memory leak in Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp
11756         https://bugs.webkit.org/show_bug.cgi?id=123478
11758         Reviewed by Anders Carlsson.
11760         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
11761         (NPP_Destroy): Add a missing free() for 'obj->evaluateScriptOnMouseDownOrKeyDown'.
11763 2013-10-29  Lucas Forschler  <lforschler@apple.com>
11765         Move the SEO bots from testers to archivers.
11766         
11767         Unreviewed.
11768         
11769         * BuildSlaveSupport/build.webkit.org-config/config.json:
11771 2013-10-29  Hugo Parente Lima  <hugo.lima@openbossa.org>
11773         Adding Nix files in Source/Platform to trunk
11774         https://bugs.webkit.org/show_bug.cgi?id=118331
11776         Reviewed by Benjamin Poulain.
11778         Add a special rule for Nix API files located at Source/Platform/nix.
11780         * Scripts/webkitpy/style/checker.py:
11782  2013-10-29  Nadav Rotem  <nrotem@apple.com>
11784          Add myself as a comitter.
11785          https://bugs.webkit.org/show_bug.cgi?id=123455
11787          Reviewed by Anders Carlsson.
11789          * Scripts/webkitpy/common/config/contributors.json:
11791 2013-10-29  Lucas Forschler  <lforschler@apple.com>
11793         Teach the WebKit2 testers to abort early by setting the shouldAbortEarly property to True.
11794         https://bugs.webkit.org/show_bug.cgi?id=123450
11796         Reviewed by Alexey Proskuryakov.
11798         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
11799         (RunWebKit2Tests.start):
11801 2013-10-29  Alexey Proskuryakov  <ap@apple.com>
11803         [Mac] Rationalize user defaults override code
11804         https://bugs.webkit.org/show_bug.cgi?id=123436
11806         Reviewed by Dan Bernstein.
11808         * DumpRenderTree/mac/DumpRenderTree.mm:
11809         (resetWebPreferencesToConsistentValues): Renamed from resetDefaultsToConsistentValues,
11810         because this function only resets WebPreferences now.
11811         (setDefaultsToConsistentValuesForTesting): Moved code for setting the defaults
11812         here, because tests never change them, and they only need to be set once, not
11813         before each test. Removed long obsolete workaround for HIToolbox preferences.
11814         Don't call resetWebPreferencesToConsistentValues, because it will be called before
11815         the first test anyway.
11816         (main): Don't set AppleMagnifiedMode here, moved that to setDefaultsToConsistentValuesForTesting.
11817         (resetWebViewToConsistentStateBeforeTesting): Moved TestRunner::setSerializeHTTPLoads
11818         and setlocale calls out of resetWebPreferencesToConsistentValues().
11819         Added AppleAquaAntiAliasingChanged notification that we had in WK2, because it's
11820         also needed in WK1.
11822         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
11823         (WTR::InjectedBundle::platformInitialize): Use literal syntax for defaults
11824         dictionary.
11826         * WebKitTestRunner/mac/main.mm:
11827         (setDefaultsToConsistentValuesForTesting): Factored out of main(), and changed to
11828         use NSArgumentDomain for everything.
11830 2013-10-29  Philippe Normand  <pnormand@igalia.com>
11832         [GTK] enable media-stream in build-webkit
11833         https://bugs.webkit.org/show_bug.cgi?id=123144
11835         Reviewed by Martin Robinson.
11837         * Scripts/webkitperl/FeatureList.pm: Enable media-stream build
11838         for the GTK+ port.
11840 2013-10-29  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
11842         EFL 32 bit buildbot doesn't work on dashboard
11843         https://bugs.webkit.org/show_bug.cgi?id=123435
11845         Reviewed by Csaba Osztrogonác.
11847         32 bit buildbot doesn't work on dashboard because name is different from buildbot list.
11849         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
11850         (WebKitBuildbot):
11852 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
11854         Floating left the header broke other pages, and this CSS has no way to customize
11855         per-page.
11857         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
11859 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
11861         Remove underlines on the bot names in the header.
11862         
11863         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
11864         (td.LastBuild a):
11866 2013-10-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
11868         Add EFL release bots to the buildbot dashboard
11869         https://bugs.webkit.org/show_bug.cgi?id=123430
11871         Reviewed by Darin Adler.
11873         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Added.
11874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
11875         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers and 32 bits release builder.
11876         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
11877         (table.queue-grid tr.platform.linux-efl img.logo): use the EFL logo in its dashboard line.
11879 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
11881         More waterfall tweaking.
11883         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
11884         (body > .header):
11885         (td.LastBuild):
11886         (td.LastBuild a):
11887         (td.LastBuild,td.Activity a,td.Change a,td.Builder a):
11889 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
11891         More waterfall tweaking.
11893         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
11894         (body.interface):
11895         (body > hr):
11896         (div.content h1):
11897         (body > .header):
11898         (td.Activity a,td.Change a,td.Builder a):
11899         (td.Builder):
11901 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
11903         Apply changes to default.css, revert buildbot.css which seems to be unused.
11905         * BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:
11906         (body):
11907         (body, td):
11908         (a:link,a:visited,a:active):
11909         (td.Time):
11910         (td.Activity):
11911         (.exception, td.offline):
11912         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
11913         (body.interface):
11914         (.auth):
11915         (td.LastBuild):
11916         (td.Time):
11917         (td.Activity):
11918         (.offline,td.offline,.retry):
11920 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
11922         Prettify the waterfall page, and make it a little more space-efficient.
11923         
11924         * BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:
11925         (body, td):
11926         (body.interface):
11927         (.auth):
11928         (.header):
11929         (div.content h1):
11930         (a):
11931         (a:link,a:active):
11932         (a:link,a:visited,a:active):
11933         (td.LastBuild):
11934         (td.Time):
11935         (td.Activity):
11936         (.exception, td.offline, .retry):
11938 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
11940         Fix Lion readableName (spotted by Dan Bernstein).
11942         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
11944 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
11946         Add tooltips to the platform icons in Dashboard
11947         https://bugs.webkit.org/show_bug.cgi?id=123429
11949         Reviewed by Alexey Proskuryakov.
11950         
11951         Add a human readable name to Buildbot.Platform entries, and use it to
11952         show a tooltip on the ring image.
11954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
11955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
11956         (documentReady):
11958 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
11960         Allow explicit sort order for Dashboard platforms
11961         https://bugs.webkit.org/show_bug.cgi?id=123419
11963         Reviewed by Tim Hatcher.
11964         
11965         Assign a specific sort order to Dashboard platforms, rather than
11966         just using object property order.
11968         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
11969         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
11970         (BuildbotQueue):
11971         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
11972         (documentReady):
11974 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
11976         Tidy up main http://build.webkit.org page
11977         https://bugs.webkit.org/show_bug.cgi?id=123413
11979         Reviewed by Alexey Proskuryakov.
11980         
11981         Break the list of links into sections. Add some font style.
11983         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
11985 2013-10-28  Myles C. Maxfield  <mmaxfield@apple.com>
11987         Parsing support for -webkit-text-decoration-skip: ink
11988         https://bugs.webkit.org/show_bug.cgi?id=123358
11990         Reviewed by Dean Jackson.
11992         Adding ENABLE(CSS3_TEXT_DECORATION)
11994         * Scripts/webkitperl/FeatureList.pm:
11996 2013-10-28  Lucas Forschler  <lforschler@apple.com>
11998         Add additional Apple Mavericks test bots.
11999         
12000         Unreviewed.
12001         
12002         * BuildSlaveSupport/build.webkit.org-config/config.json:
12004 2013-10-28  Bastien Nocera <hadess@hadess.net>
12006         Name all the GLib timeout sources
12007         https://bugs.webkit.org/show_bug.cgi?id=123229
12009         Reviewed by Anders Carlsson.
12011         Give a name to GLib timeout sources, this is helpful when
12012         profiling WebKitGTK applications.
12014 2013-10-28  Bastien Nocera <hadess@hadess.net>
12016         Replace 0 timeouts g_timeout_add() by g_idle_add()
12017         https://bugs.webkit.org/show_bug.cgi?id=123260
12019         Reviewed by Carlos Garcia Campos.
12021         A zero timeout should be equivalent to using g_idle_add_full(G_PRIORITY_DEFAULT, ...)
12022         without the nagging feeling that the wrong API was used.
12024         * DumpRenderTree/gtk/DumpRenderTree.cpp: Use g_idle_add() instead
12025         of 0-timer.
12026         (topLoadingFrameLoadFinished):
12027         * DumpRenderTree/gtk/EventSender.cpp: Ditto.
12028         (scheduleAsynchronousClickCallback):
12029         (scheduleAsynchronousKeyDownCallback):
12031 2013-10-25  Anton Obzhirov  <a.obzhirov@samsung.com>
12033         [GTK] [WebKit2] CanHandleRequest API test fails
12034         https://bugs.webkit.org/show_bug.cgi?id=88453
12036         Reviewed by Martin Robinson.
12038         * Scripts/run-gtk-tests:
12039         (TestRunner):
12041 2013-10-25  Ryosuke Niwa  <rniwa@webkit.org>
12043         Build fix after r157815. Don't resolve the path from webkit_base. Use the relative path as is.
12045         * Scripts/webkitpy/port/base.py:
12046         (Port.repository_paths):
12048 2013-10-25  Jer Noble  <jer.noble@apple.com>
12050         [WTF] Add a multiplication operator (and a few others) to MediaTime
12051         https://bugs.webkit.org/show_bug.cgi?id=123137
12053         Reviewed by Eric Carlson.
12055         Add tests for new MediaTime operators.
12057         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
12058         (TestWebKitAPI::TEST):
12060 2013-10-24  Mark Rowe  <mrowe@apple.com>
12062         Remove references to OS X 10.7 from Xcode configuration settings.
12064         Now that we're not building for OS X 10.7 they're no longer needed.
12066         Reviewed by Anders Carlsson.
12068         * DumpRenderTree/mac/Configurations/Base.xcconfig:
12069         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
12070         * MiniBrowser/Configurations/Base.xcconfig:
12071         * MiniBrowser/Configurations/DebugRelease.xcconfig:
12072         * TestWebKitAPI/Configurations/Base.xcconfig:
12073         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
12074         * WebKitLauncher/Configurations/Base.xcconfig:
12075         * WebKitTestRunner/Configurations/Base.xcconfig:
12076         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
12078 2013-10-24  Mark Rowe  <mrowe@apple.com>
12080         <rdar://problem/15312643> Prepare for the mysterious future.
12082         Reviewed by David Kilzer.
12084         * DumpRenderTree/mac/Configurations/Base.xcconfig:
12085         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
12086         * MiniBrowser/Configurations/Base.xcconfig:
12087         * MiniBrowser/Configurations/DebugRelease.xcconfig:
12088         * TestWebKitAPI/Configurations/Base.xcconfig:
12089         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
12090         * WebKitLauncher/Configurations/Base.xcconfig:
12091         * WebKitTestRunner/Configurations/Base.xcconfig:
12092         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
12094 2013-10-24  Daniel Bates  <dabates@apple.com>
12096         Crash in WebCore::NavigationScheduler::startTimer()
12097         https://bugs.webkit.org/show_bug.cgi?id=123288
12098         <rdar://problem/14055644>
12100         Reviewed by Alexey Proskuryakov.
12102         Add API test.
12104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12105         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.html: Added.
12106         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.mm: Added.
12108 2013-10-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
12110         [GTK] Disable css-image-orientation
12111         https://bugs.webkit.org/show_bug.cgi?id=123257
12113         Reviewed by Martin Robinson.
12115         CSS image orientation isn't stable yet. So, test regression happen since r157909.
12116         This feature should be enabled again after it is stable.
12118         * Scripts/webkitperl/FeatureList.pm:
12120 2013-10-24  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
12122         Fix argument passing for jhbuild.
12123         https://bugs.webkit.org/show_bug.cgi?id=123253
12125         Reviewed by Gustavo Noronha Silva.
12127         The update-webkit-libs-jhbuild previously didn't allowed
12128         extra arguments to be passed to jhbuild.
12130         * Scripts/update-webkit-libs-jhbuild:
12131         (runJhbuild):
12132         * Scripts/update-webkitefl-libs:
12134 2013-10-24  Sanghyup Lee  <sh53.lee@samsung.com>
12136         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
12137         https://bugs.webkit.org/show_bug.cgi?id=123251
12139         Reviewed by Csaba Osztrogonác.
12141         Replace %llu by PRIu64 macro to print an uint64_t value and silent a
12142         compilation warning on 64-Bit.
12144         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
12145         (onExceededDatabaseQuota):
12147 2013-10-24  Ryuan Choi  <ryuan.choi@samsung.com>
12149         [EFL] Build break with latest EFL 1.8 libraries.
12150         https://bugs.webkit.org/show_bug.cgi?id=123245
12152         Reviewed by Gyuyoung Kim.
12154         After fixed build break on EFL 1.8 at r138326, EFL libraries are changed
12155         Eo typedef and splitted header files which contain version macro.
12157         * TestWebKitAPI/PlatformWebView.h: Changed Eo typedef.
12158         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
12159         * WebKitTestRunner/PlatformWebView.h: Ditto.
12161 2013-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
12163         [GObject bindings] Make EventTarget interface introspectable
12164         https://bugs.webkit.org/show_bug.cgi?id=77835
12166         Reviewed by Gustavo Noronha Silva.
12168         * Scripts/webkitpy/style/checker.py: Add exceptions for custom
12169         GObject DOM bindings headers.
12171 2013-10-23  Lucas Forschler  <lforschler@apple.com>
12173         Add two more mac bots to the Mavericks Test Queue.
12174         
12175         Unreviewed.
12176         
12177         * BuildSlaveSupport/build.webkit.org-config/config.json:
12179 2013-10-23  Filip Pizlo  <fpizlo@apple.com>
12181         Have a way of dealing with slow tests in run-jsc-stress-tests
12182         https://bugs.webkit.org/show_bug.cgi?id=123221
12184         Reviewed by Mark Hahnenberg.
12185         
12186         If you add the slow! command to //@ then all subsequent plans are prepended to the run list
12187         rather than appended to it. This means that slow tests get queued up first and are less likely
12188         to block completion.
12190         * Scripts/run-jsc-stress-tests:
12192 2013-10-23  Alex Christensen  <achristensen@webkit.org>
12194         Explicitly build Win32 or x64 configuration on Windows.
12195         https://bugs.webkit.org/show_bug.cgi?id=123206
12197         Reviewed by Brent Fulgham.
12199         * Scripts/webkitdirs.pm:
12200         (jscPath):
12201         (determineConfigurationForVisualStudio):
12202         (determinePassedConfiguration):
12203         Add |Win32 to the end of 32-bit Visual Studio build configurations.
12204         (safariPath):
12205         * Scripts/build-webkit:
12206         * Scripts/old-run-webkit-tests:
12207         * Scripts/run-api-tests:
12208         (testToolPath):
12209         * Scripts/run-javascriptcore-tests:
12210         (testapiPath):
12211         * Scripts/run-regexp-tests:
12212         (testapiPath):
12213         * Scripts/sunspider-compare-results:
12214         (pathToBuiltJSC):
12215         Use configuration instead of configurationForVisualStudio, which are now always different.
12217 2013-10-23  Mark Lam  <mark.lam@apple.com>
12219         Re-instate ProposedDatabases needed by detailsForNameAndOrigin().
12220         https://bugs.webkit.org/show_bug.cgi?id=123131.
12222         Reviewed by Geoffrey Garen.
12224         Updated these files to allow database quotas to grow within a limit for
12225         testing purposes.
12227         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
12228         (BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
12229         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
12230         (onExceededDatabaseQuota):
12231         * DumpRenderTree/mac/UIDelegate.mm:
12232         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
12233         * DumpRenderTree/win/UIDelegate.cpp:
12234         (UIDelegate::exceededDatabaseQuota):
12235         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
12236         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
12237         * WebKitTestRunner/TestController.cpp:
12238         (WTR::exceededDatabaseQuota):
12240 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
12242         It's valid to have a build ID of 0.
12244         Reviewed by Tim Hatcher.
12246         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
12247         (BuildbotIteration):
12249 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
12251         Remove Lion bots from the Dashboard.
12253         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
12254         (WebKitBuildbot):
12256 2013-10-23  Mario Sanchez Prada  <mario.prada@samsung.com>
12258         [GTK] Expose image links properly
12259         https://bugs.webkit.org/show_bug.cgi?id=84044
12261         Reviewed by Chris Fleizach.
12263         Expose the accessible URL if present, as yet another attribute
12264         for the AccessibilityUIElement wrapper. For coherence with what
12265         the Mac port does (and what you would expect as the output of
12266         the layout test), we strip the absolute URL path for relative
12267         references, if it's the case, leaving the base of the URL path
12268         out of the exposed string.
12270         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
12271         (attributesOfElement): Print the AXURL, if available.
12272         (AccessibilityUIElement::url): Expose the URL if present. That
12273         is, if the wrapped AtkObject implements AtkHyperlinkImpl.
12274         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
12275         (attributesOfElement): Print the AXURL, if available.
12276         (WTR::AccessibilityUIElement::url): Expose the URL if present.
12277         That is, if the wrapped AtkObject implements AtkHyperlinkImpl.
12279 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
12281         Remove Lion bots.
12283         * BuildSlaveSupport/build.webkit.org-config/config.json:
12285 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
12287         Dashboard repaints constantly
12288         https://bugs.webkit.org/show_bug.cgi?id=122133
12290         Reviewed by Tim Horton.
12291         
12292         Pulsing shadows are really bad for battery life.
12294         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
12295         (.status-line.bad .bubble):
12296         (.status-line.bad .message):
12298 2013-10-22  Commit Queue  <commit-queue@webkit.org>
12300         Unreviewed, rolling out r157835.
12301         http://trac.webkit.org/changeset/157835
12302         https://bugs.webkit.org/show_bug.cgi?id=123192
12304         broke 32-bit builds (Requested by smfr on #webkit).
12306         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
12307         (TestWebKitAPI::TEST):
12309 2013-10-22  Jer Noble  <jer.noble@apple.com>
12311         [WTF] Add a multiplication operator (and a few others) to MediaTime
12312         https://bugs.webkit.org/show_bug.cgi?id=123137
12314         Reviewed by Eric Carlson.
12316         Add tests for new MediaTime operators.
12318         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
12319         (TestWebKitAPI::TEST):
12321 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
12323         Educate webkitpy about Mavericks.
12325         Reviewed by Ryosuke Niwa.
12327         * Scripts/webkitpy/common/system/platforminfo.py:
12328         (PlatformInfo._determine_mac_version):
12329         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
12330         (TestPlatformInfo.test_os_version):
12331         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
12332         (TestExpectationParser):
12333         * Scripts/webkitpy/port/builders.py:
12334         * Scripts/webkitpy/port/mac.py:
12335         (MacPort):
12336         * Scripts/webkitpy/port/mac_unittest.py:
12337         (test_versions):
12338         (test_baseline_search_path):
12339         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
12340         (TestRebaselineTest.test_baseline_directory):
12341         (TestRebaselineExpectations.test_rebaseline_expectations):
12343 2013-10-22  Stephanie Lewis  <slewis@apple.com>
12345         Update the build trigger list for Mavericks.
12347         Unreviewed.
12349         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
12350         (_should_file_trigger_build):
12352 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
12354         Add Mavericks bots to the dashboard.
12356         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
12357         (WebKitBuildbot):
12359 2013-10-22  Samuel White  <samuel_white@apple.com>
12361         AX: Add paramAttrs to fetch start and end text markers in a given rect.
12362         https://bugs.webkit.org/show_bug.cgi?id=122164
12364         Reviewed by Chris Fleizach.
12366         Added accessibility element hooks to test endTextMarkerForBounds and startTextMarkerForBounds.
12368         * DumpRenderTree/AccessibilityUIElement.cpp:
12369         (endTextMarkerForBoundsCallback):
12370         (startTextMarkerForBoundsCallback):
12371         (AccessibilityUIElement::endTextMarkerForBounds):
12372         (AccessibilityUIElement::startTextMarkerForBounds):
12373         (AccessibilityUIElement::getJSClass):
12374         * DumpRenderTree/AccessibilityUIElement.h:
12375         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
12376         (AccessibilityUIElement::endTextMarkerForBounds):
12377         (AccessibilityUIElement::startTextMarkerForBounds):
12378         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
12379         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
12380         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
12381         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
12382         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
12383         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
12384         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
12385         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
12386         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
12387         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
12388         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
12390 2013-10-22  Ryosuke Niwa  <rniwa@webkit.org>
12392         There should be a way to specify additional repository paths in NRWT
12393         https://bugs.webkit.org/show_bug.cgi?id=123135
12395         Reviewed by Alexey Proskuryakov.
12397         Added --additional-repository-name and --additional-repository-path options to NRWT.
12398         These options allow us to submit addtional repository information, such as of Safari's
12399         to the new flakiness dashboard.
12401         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
12402         (parse_args):
12403         * Scripts/webkitpy/port/base.py:
12404         (Port.repository_paths):
12406 2013-10-22  Commit Queue  <commit-queue@webkit.org>
12408         Unreviewed, rolling out r157774.
12409         http://trac.webkit.org/changeset/157774
12410         https://bugs.webkit.org/show_bug.cgi?id=123167
12412         causes python test to fail (Requested by smfr on #webkit).
12414         * Scripts/webkitpy/layout_tests/controllers/manager.py:
12415         (Manager.run):
12416         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
12417         (TestExpectations.__init__):
12418         (TestExpectations._add_expectations):
12419         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
12420         (parse_args):
12421         (_set_up_derived_options):
12423 2013-10-22  Lucas Forschler  <lforschler@apple.com>
12425         Prepare WebKit Buildbot master for Mavericks.
12426         This adds the following bot configurations:
12427             Mavericks Release/Debug builders
12428             Mavericks Release/Debug WK1 Testers
12429             Mavericks Release/Debug WK2 Testers
12431         Unreviewed.
12432         
12433         * BuildSlaveSupport/build.webkit.org-config/config.json:
12435 2013-10-21  Tamas Gergely  <gertom@inf.u-szeged.hu>
12437         Run tests as if they are expected to pass when --force is given.
12438         https://bugs.webkit.org/show_bug.cgi?id=112890
12440         Reviewed by Ryosuke Niwa.
12442         The --force switch of new-run-webkit-tests is now forces all tests to
12443         be run with 'PASS' as expected result.
12445         * Scripts/webkitpy/layout_tests/controllers/manager.py:
12446         (Manager.run):
12447         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
12448         (TestExpectations.__init__):
12449         (TestExpectations._add_expectations):
12450         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
12451         (parse_args):
12452         (_set_up_derived_options):
12454 2013-10-21  Mark Rowe  <mrowe@apple.com>
12456         Add a version of WebKitSystemInterface for Mavericks.
12458         Reviewed by Ryosuke Niwa.
12460         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
12461         * Scripts/copy-webkitlibraries-to-product-directory:
12462         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
12464 2013-10-21  Anders Carlsson  <andersca@apple.com>
12466         Navigation policy callback not called when performing the same fragment navigation twice
12467         https://bugs.webkit.org/show_bug.cgi?id=123121
12468         <rdar://problem/15230466>
12470         Reviewed by Beth Dakin.
12472         Add a test.
12474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12475         * TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
12476         * TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
12477         (+[WebKit1FragmentNavigationTestDelegate shared]):
12478         (-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
12479         (-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
12480         (-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
12481         (-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
12482         (TestWebKitAPI::TEST):
12484 2013-10-21  Dan Bernstein  <mitz@apple.com>
12486         Style checker should allow a space after the @property keyword
12487         https://bugs.webkit.org/show_bug.cgi?id=123117
12489         Reviewed by Anders Carlsson.
12491         * Scripts/webkitpy/style/checkers/cpp.py:
12492         (check_spacing_for_function_call): Allow a space between @property and the following (
12493         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
12494         (CppStyleTest.test_spacing_for_fncall): Added a test case.
12496 2013-10-21  peavo@outlook.com  <peavo@outlook.com>
12498         [WinCairo] Build does not start.
12499         https://bugs.webkit.org/show_bug.cgi?id=123059
12501         Reviewed by Csaba Osztrogonác.
12503         The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
12505         * Scripts/build-webkit:
12507 2013-10-21  Zan Dobersek  <zdobersek@igalia.com>
12509         [Jhbuild] Bump the required Jhbuild revision
12510         https://bugs.webkit.org/show_bug.cgi?id=123089
12512         Reviewed by Carlos Garcia Campos.
12514         * jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
12515         due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
12516         in the Jhbuild source so a more recent revision of it should be used.
12518 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
12520         Mac build fix.
12522         * DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
12524 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
12526         Enable webaudio/ tests on DRT/Mac
12527         https://bugs.webkit.org/show_bug.cgi?id=86914
12529         Reviewed by Darin Adler.
12531         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
12532         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
12533         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
12534         There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
12536         * DumpRenderTree/TestRunner.cpp:
12537         (setAudioResultCallback): 
12538         (TestRunner::staticFunctions):
12539         * DumpRenderTree/TestRunner.h:
12540         (TestRunner::audioResult):
12541         (TestRunner::setAudioResult):
12542         The function has a different name and argument type now, updated accordingly.
12543         Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
12545         * DumpRenderTree/mac/DumpRenderTree.mm:
12546         (dumpAudio): Updated for the new name of audioResult accessor.
12547         (dump): Print the result in the format webkitpy currently expects.
12549         * WebKitTestRunner/TestInvocation.cpp:
12550         (WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
12551         chunks made no sense.
12553         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
12554         (WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
12556         * DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
12557         so that "SourceProvider.h" can be found.
12559 2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
12561         run-webkit-tests should submit time and modifiers to the new flakiness dashboard
12562         https://bugs.webkit.org/show_bug.cgi?id=123070
12564         Reviewed by Alexey Proskuryakov.
12566         * Scripts/webkitpy/layout_tests/controllers/manager.py:
12567         (Manager.run):
12568         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
12569         (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
12570         in the test expectations when this argument is set to true.
12572 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
12574         Mac DumpRenderTree builds without NDEBUG even in release mode
12575         https://bugs.webkit.org/show_bug.cgi?id=123066
12577         Reviewed by Dan Bernstein.
12579         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
12580         * DumpRenderTree/mac/Configurations/Base.xcconfig:
12581         Use the same pattern as WebCore and WebKitTestRunner.
12583 2013-10-19  Zan Dobersek  <zdobersek@igalia.com>
12585         REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
12586         https://bugs.webkit.org/show_bug.cgi?id=123064
12588         Reviewed by Ryosuke Niwa.
12590         Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
12592         * Scripts/webkitpy/common/config/ports.py: Added.
12593         (DeprecatedPort):
12594         (DeprecatedPort.name):
12595         (DeprecatedPort.flag):
12596         (DeprecatedPort.script_path):
12597         (DeprecatedPort.script_shell_command):
12598         (DeprecatedPort.port):
12599         (DeprecatedPort.makeArgs):
12600         (DeprecatedPort.update_webkit_command):
12601         (DeprecatedPort.check_webkit_style_command):
12602         (DeprecatedPort.prepare_changelog_command):
12603         (DeprecatedPort.build_webkit_command):
12604         (DeprecatedPort.run_javascriptcore_tests_command):
12605         (DeprecatedPort.run_webkit_unit_tests_command):
12606         (DeprecatedPort.run_webkit_tests_command):
12607         (DeprecatedPort.run_python_unittests_command):
12608         (DeprecatedPort.run_perl_unittests_command):
12609         (DeprecatedPort.run_bindings_tests_command):
12610         (MacPort):
12611         (MacWK2Port):
12612         (MacWK2Port.run_webkit_tests_command):
12613         (WinPort):
12614         (WinPort.run_bindings_tests_command):
12615         (GtkPort):
12616         (GtkPort.build_webkit_command):
12617         (GtkPort.run_webkit_tests_command):
12618         (GtkWK2Port):
12619         (GtkWK2Port.build_webkit_command):
12620         (GtkWK2Port.run_webkit_tests_command):
12621         (QtPort):
12622         (QtPort.build_webkit_command):
12623         (QtPort.run_webkit_tests_command):
12624         (QtWK2Port):
12625         (QtWK2Port.build_webkit_command):
12626         (QtWK2Port.run_webkit_tests_command):
12627         (EflPort):
12628         (EflPort.build_webkit_command):
12629         (EflWK2Port):
12630         (EflWK2Port.build_webkit_command):
12631         * Scripts/webkitpy/common/config/ports_mock.py: Added.
12632         (MockPort):
12633         (MockPort.name):
12634         (MockPort.check_webkit_style_command):
12635         (MockPort.update_webkit_command):
12636         (MockPort.build_webkit_command):
12637         (MockPort.prepare_changelog_command):
12638         (MockPort.run_python_unittests_command):
12639         (MockPort.run_perl_unittests_command):
12640         (MockPort.run_javascriptcore_tests_command):
12641         (MockPort.run_webkit_unit_tests_command):
12642         (MockPort.run_webkit_tests_command):
12643         (MockPort.run_bindings_tests_command):
12644         * Scripts/webkitpy/common/config/ports_unittest.py: Added.
12645         (DeprecatedPortTest):
12646         (DeprecatedPortTest.test_mac_port):
12647         (DeprecatedPortTest.test_gtk_port):
12648         (DeprecatedPortTest.test_gtk_wk2_port):
12649         (DeprecatedPortTest.test_efl_port):
12650         (DeprecatedPortTest.test_qt_port):
12651         (DeprecatedPortTest.test_qt_wk2_port):
12652         * Scripts/webkitpy/port/base.py:
12653         (Port._port_flag_for_scripts):
12654         (Port._wk2_port_name):
12655         * Scripts/webkitpy/port/base_unittest.py:
12656         (PortTest.test_build_path):
12657         * Scripts/webkitpy/port/efl_unittest.py:
12658         (EflPortTest.test_show_results_html_file):
12659         * Scripts/webkitpy/port/gtk_unittest.py:
12660         (GtkPortTest.test_get_crash_log):
12661         * Scripts/webkitpy/port/mac_unittest.py:
12662         (test_64bit):
12663         * Scripts/webkitpy/port/test.py:
12664         (TestPort.virtual_test_suites):
12665         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
12666         (FlakyTestReporter.__init__):
12667         * Scripts/webkitpy/tool/bot/irc_command.py:
12668         (Rollout._update_working_copy):
12669         * Scripts/webkitpy/tool/commands/download_unittest.py:
12670         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
12671         (AbstractEarlyWarningSystem.run_command):
12672         * Scripts/webkitpy/tool/commands/queues.py:
12673         (PatchProcessingQueue.begin_work_queue):
12674         (CommitQueue.run_command):
12675         * Scripts/webkitpy/tool/main.py:
12676         (WebKitPatch.__init__):
12677         (WebKitPatch.deprecated_port):
12678         (WebKitPatch.handle_global_options):
12679         * Scripts/webkitpy/tool/mocktool.py:
12680         (MockTool.__init__):
12681         (MockTool.deprecated_port):
12682         * Scripts/webkitpy/tool/steps/build.py:
12683         (Build.build):
12684         * Scripts/webkitpy/tool/steps/checkstyle.py:
12685         (CheckStyle.run):
12686         * Scripts/webkitpy/tool/steps/commit.py:
12687         (Commit._check_test_expectations):
12688         * Scripts/webkitpy/tool/steps/preparechangelog.py:
12689         (PrepareChangeLog.run):
12690         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
12691         (PrepareChangeLogForRevert.run):
12692         * Scripts/webkitpy/tool/steps/runtests.py:
12693         (RunTests.run):
12694         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
12695         (RunTestsTest.test_webkit_run_unit_tests):
12696         * Scripts/webkitpy/tool/steps/steps_unittest.py:
12697         (StepsTest.test_runtests_args):
12698         * Scripts/webkitpy/tool/steps/update.py:
12699         (Update._update_command):
12700         * Scripts/webkitpy/tool/steps/update_unittest.py:
12701         (UpdateTest.test_update_command_non_interactive):
12702         (UpdateTest.test_update_command_interactive):
12704 2013-10-19  Andreas Kling  <akling@apple.com>
12706         RefPtr::releaseNonNull() incorrectly increments the refcount.
12707         <https://webkit.org/b/123063>
12709         Add an API test to verify that no extra refs are added when calling
12710         RefPtr::releaseNonNull().
12712         Reviewed by Anders Carlsson.
12714 2013-10-18  Rik Cabanier <cabanier@adobe.com>
12715         Add Rik Cabanier to list of committers
12716         https://bugs.webkit.org/show_bug.cgi?id=123031
12718         reviewed by Dirk Schulze.
12720         * Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
12722 2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
12724         [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
12725         https://bugs.webkit.org/show_bug.cgi?id=122970
12727         Reviewed by Mario Sanchez Prada.
12729         Removed an invalid signal to set an object state to layout-complete
12730         that does not exist. It was replaced by ATK:AtkDocument:load-complete.
12732         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
12733         (axObjectEventListener): Replaced layout-complete with load-complete.
12734         (connectAccessibilityCallbacks): Connect callback to new listener for
12735         ATK:AtkDocument:load-complete.
12736         (disconnectAccessibilityCallbacks): Disconnect callback to new listener
12737         for ATK:AtkDocument:load-complete.
12738         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
12739         (axObjectEventListener): Replaced layout-complete with load-complete.
12740         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
12741         Connect callback to new listener for ATK:AtkDocument:load-complete.
12742         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
12743         Disconnect callback to new listener for ATK:AtkDocument:load-complete.
12745 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
12747         [GTK] Generate API documentation for GObject DOM bindings
12748         https://bugs.webkit.org/show_bug.cgi?id=121538
12750         Reviewed by Gustavo Noronha Silva.
12752         The .symbols file that is now generated for checking GObject DOM
12753         bindings API compatibility while building can also be used to
12754         generate the files needed to produce the gtk-doc
12755         documentation. The new script generate-webkitdom-doc-files can
12756         generate the docs.sgml and sections.txt files from the given list
12757         of .symbols files.
12759         * gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
12760         and webkitdomgtk-sections.txt as well as rules to install the
12761         generated WebKitDOMGTK documentation.
12762         * gtk/generate-gtkdoc:
12763         (webkitdom_docs_html_path): New helper function that returns the
12764         path where the DOM API documentation has been generated.
12765         (get_webkit2_options): Include DOM API docs to the list of xref
12766         dependencies.
12767         (get_webkit1_options): Ditto.
12768         (get_webkitdom_options): Return the gtk-doc options to generate
12769         the DOM API docs.
12770         (get_webkitdom_options.derived_sources_path):
12771         (get_webkitdom_options.src_path):
12772         * gtk/generate-webkitdom-doc-files: Added.
12773         (WebKitDOMDocGenerator):
12774         (WebKitDOMDocGenerator.write_header):
12775         (WebKitDOMDocGenerator.write_section):
12776         (WebKitDOMDocGenerator.write_footer):
12777         (WebKitDOMDocGeneratorDocs):
12778         (WebKitDOMDocGeneratorDocs.write_header):
12779         (write_section):
12780         (write_footer):
12781         (WebKitDOMDocGeneratorSections):
12782         (WebKitDOMDocGeneratorSections.__init__):
12783         (WebKitDOMDocGeneratorSections._dom_class):
12784         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
12785         (WebKitDOMDocGeneratorSections._symbol_list):
12786         (WebKitDOMDocGeneratorSections.write_section):
12788 2013-10-17  Alex Christensen  <achristensen@webkit.org>
12790         Run JavaScriptCore tests again on Windows.
12791         https://bugs.webkit.org/show_bug.cgi?id=122787
12793         Reviewed by Tim Horton.
12795         * Scripts/build-jsc:
12796         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
12797         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
12798         * Scripts/webkitdirs.pm:
12799         (determineConfigurationForVisualStudio):
12800         (determineConfigurationProductDir):
12801         Build directory should end with bin64 and configuration should end with |x64 on Win64.
12802         (isAppleWinWebKit):
12803         (copyInspectorFrontendFiles):
12804         (setPathForRunningWebKitApp):
12805         Separated WinCairo directories and options from AppleWin.
12807 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
12809         Unreviewed. Add myself as a reviewer.
12811         * Scripts/webkitpy/common/config/contributors.json:
12813 2013-10-17  Andreas Kling  <akling@apple.com>
12815         Make it possible to assign a PassRef to a RefPtr.
12816         <https://webkit.org/b/122943>
12818         Added a small API test for RefPtr=(PassRef) so we know this code
12819         will compile (and work.)
12821         Reviewed by Antti Koivisto.
12823 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
12825         We need test coverage for just the Baseline JIT
12826         https://bugs.webkit.org/show_bug.cgi?id=122929
12828         Reviewed by Sam Weinig.
12829         
12830         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
12831         variant.
12833         * Scripts/run-jsc-stress-tests:
12835 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
12837         Support multiple repositories in submitting results to --results-server-host
12838         https://bugs.webkit.org/show_bug.cgi?id=122935
12840         Reviewed by Anders Carlsson.
12842         Remoevd --got-revision and added the logic to extract revision information
12843         from multiple repositories as done in run-perf-tests.
12845         * Scripts/webkitpy/layout_tests/controllers/manager.py:
12846         (Manager.upload_results):
12847         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
12848         (parse_args):
12850 2013-10-16  Darin Adler  <darin@apple.com>
12852         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
12853         https://bugs.webkit.org/show_bug.cgi?id=122904
12855         Reviewed by Anders Carlsson.
12857         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
12859 2013-10-16  Darin Adler  <darin@apple.com>
12861         Need tests for RefPtr self-assignment and self-move-assignment.
12863         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
12865 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
12867         [EFL] Minibrowser can't load child window's location
12868         https://bugs.webkit.org/show_bug.cgi?id=122485
12870         Reviewed by Gyuyoung Kim.
12872         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
12873             followed by an explicit call to ewk_view_url_set() where appropriate.
12874         (on_key_down):
12875         (on_window_create):
12876         (window_create):
12877         (elm_main):
12879 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
12881         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
12882         https://bugs.webkit.org/show_bug.cgi?id=122872
12884         Reviewed by Anders Carlsson.
12886         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
12887         failing.
12889 2013-10-15  Dean Jackson  <dino@apple.com>
12891         Add ENABLE_WEB_ANIMATIONS flag
12892         https://bugs.webkit.org/show_bug.cgi?id=122871
12894         Reviewed by Tim Horton.
12896         Eventually might be http://dev.w3.org/fxtf/web-animations/
12897         but this is just engine-internal work at the moment.
12899         * Scripts/webkitperl/FeatureList.pm:
12901 2013-10-15  Darin Adler  <darin@apple.com>
12903         Add some API tests for Vector, RefPtr, and Ref
12904         https://bugs.webkit.org/show_bug.cgi?id=122840
12906         Reviewed by Andreas Kling.
12908         * TestWebKitAPI/CMakeLists.txt: Added new files.
12909         * TestWebKitAPI/GNUmakefile.am: Ditto.
12910         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
12911         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
12912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
12914         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
12915         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
12916         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
12917         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
12919 2013-10-14  Roger Fong  <roger_fong@apple.com>
12921         Adding myself to CC list for some components.
12923         * Scripts/webkitpy/common/config/watchlist:
12925 2013-10-13  Darin Adler  <darin@apple.com>
12927         Deprecate or remove deleteAllValues functions; there are only a few call sites left
12928         https://bugs.webkit.org/show_bug.cgi?id=122738
12930         Reviewed by Anders Carlsson.
12932         * DumpRenderTree/win/DRTDataObject.cpp:
12933         (DRTDataObject::~DRTDataObject):
12934         * DumpRenderTree/win/UIDelegate.cpp:
12935         (DRTUndoStack::~DRTUndoStack):
12936         (DRTUndoStack::clear):
12937         Renamed deleteAllValues to deprecatedDeleteAllValues.
12939         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
12941 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
12943         build.webkit.org/dashboard incorrectly shows interrupted builds as green
12944         https://bugs.webkit.org/show_bug.cgi?id=122732
12946         Reviewed by Tim Hatcher.
12948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
12949         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
12950         I don't see it occur any time in recent history, but judging from what happens for
12951         status 5 (RETRY), we can just finish this function normally.
12952         Record overall text description for iteration as BuildbotIteration.text.
12954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
12955         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
12956         but no tests failed, make it yellow, and use buildbot-provided description for it.
12958 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
12960         Remove Chromium specific code from flakiness dashboard
12961         https://bugs.webkit.org/show_bug.cgi?id=122714
12963         Reviewed by Sam Weinig.
12965         Also removed code related to GPU tests and virtual suites.
12966         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
12968         * TestResultServer/model/jsonresults_unittest.py:
12969         * TestResultServer/static-dashboards/builders.js:
12970         * TestResultServer/static-dashboards/dashboard_base.js:
12971         * TestResultServer/static-dashboards/flakiness_dashboard.html:
12972         * TestResultServer/static-dashboards/flakiness_dashboard.js:
12973         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
12974         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
12975         * TestResultServer/static-dashboards/history.js:
12976         * TestResultServer/static-dashboards/loader.js:
12977         * TestResultServer/static-dashboards/ui.js:
12978         * TestResultServer/templates/uploadform.html:
12980 2013-10-11  Timothy Hatcher  <timothy@apple.com>
12982         Remove preference support for picking the old Web Inspector.
12983         https://bugs.webkit.org/show_bug.cgi?id=122655
12985         Reviewed by Alexey Proskuryakov.
12987         * WebKitTestRunner/TestController.cpp:
12988         (WTR::TestController::resetStateToConsistentValues):
12990 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
12992         Fix 64-bit build on everything but Windows.
12994         Rubber stamped by Brent Fulgham.
12996         * Scripts/webkitdirs.pm:
12997         (argumentsForConfiguration):
12999 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
13001         Touch a file to see how auto-update works.
13003         Rubber-stamped by Tim Hatcher.
13005         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
13007 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
13009         LeaksViewer fails to present recent results list if current build is still updating svn
13010         https://bugs.webkit.org/show_bug.cgi?id=122670
13012         Fixed an obvious mistake in the previous patch.
13014         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
13015         (RecentBuildsLoader.prototype.start):
13017 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
13019         LeaksViewer fails to present recent results list if current build is still updating svn
13020         https://bugs.webkit.org/show_bug.cgi?id=122670
13022         Reviewed by Adam Roben.
13024         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
13025         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
13027 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
13029         Unreviewed build fix for --64-bit target.
13031         * Scripts/webkitdirs.pm:
13032         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
13033         been removed by this point.
13034         (hasArgument): Remove unused temporary.
13036 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
13038         webkit-patch failure-reason has a quite low limit for 'too many failures'
13039         https://bugs.webkit.org/show_bug.cgi?id=122556
13041         Reviewed by Darin Adler.
13043         * Scripts/webkitpy/tool/commands/queries.py:
13044         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
13045         to match what the layout test runners use these days.
13047 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
13049         webkit-patch failure-reason should allow specifying failures one is interested in
13050         https://bugs.webkit.org/show_bug.cgi?id=122554
13052         Reviewed by Darin Adler.
13054         * Scripts/webkitpy/tool/commands/queries.py:
13055         (FailureReason):
13056         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
13057         loop if the ones we're interested in been explained.
13058         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
13059         (FailureReason.execute): initialize failures to explain and the explained set.
13061 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
13063         Make sure that DataTypes.h is in the binary drop.
13065         Rubber stamped by Michael Saboff.
13067         * Scripts/export-llvm-build:
13069 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
13071         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
13072         https://bugs.webkit.org/show_bug.cgi?id=122566
13074         Reviewed by Mark Rowe.
13076         * Scripts/configure-llvm:
13078 2013-10-10  Mark Rowe  <mrowe@apple.com>
13080         <rdar://problem/13341666> WebKit should always build against an SDK.
13082         Have all projects default to building against the OS X Internal SDK for the Production
13083         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
13084         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
13086         Reviewed by Dan Bernstein.
13088         * DumpRenderTree/mac/Configurations/Base.xcconfig:
13089         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
13090         * MiniBrowser/Configurations/Base.xcconfig:
13091         * MiniBrowser/Configurations/DebugRelease.xcconfig:
13092         * TestWebKitAPI/Configurations/Base.xcconfig:
13093         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
13094         * WebKitTestRunner/Configurations/Base.xcconfig:
13095         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
13097 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
13099         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
13101         * Scripts/run-gtk-tests:
13102         (TestRunner): skip TestInspectorServer.
13104 2013-10-10  Andres Gomez  <agomez@igalia.com>
13106         [GTK] Provide search functionality to MiniBrowser
13107         https://bugs.webkit.org/show_bug.cgi?id=117631
13109         Reviewed by Carlos Garcia Campos.
13111         Adds a search bar to MiniBrowser with the minimum functionality
13112         and a new button to the toolbar for showing the new search
13113         bar. Typical keyboard shortcuts are also added.
13115         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
13116         (doSearch):
13117         (searchNext):
13118         (searchPrevious):
13119         (searchCloseButtonClickedCallback):
13120         (searchEntryMenuIconPressedCallback):
13121         (searchEntryClearIconReleasedCallback):
13122         (searchEntryChangedCallback):
13123         (searchEntryActivatedCallback):
13124         (searchPrevButtonClickedCallback):
13125         (searchNextButtonClickedCallback):
13126         (searchMenuCheckButtonToggledCallback):
13127         (browser_search_bar_init):
13128         (browserSearchBarFinalize):
13129         (browser_search_bar_class_init):
13130         (browser_search_bar_new):
13131         (browser_search_bar_add_accelerators):
13132         (browser_search_bar_open):
13133         (browser_search_bar_close):
13134         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
13135         * MiniBrowser/gtk/BrowserWindow.c:
13136         (webViewEnterFullScreen): Closes new search bar.
13137         (webViewLeaveFullScreen): Opens new search bar if previously
13138         visible.
13139         (searchCallback): Added. Shows and hides the new search bar.
13140         (browser_window_init): Added search button to the toolbar.
13141         (browserWindowConstructed): Creates the new search bar.
13142         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
13144 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
13146         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
13147         https://bugs.webkit.org/show_bug.cgi?id=122552
13149         Reviewed by Darin Adler.
13151         * Scripts/webkitpy/common/checkout/commitinfo.py:
13152         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
13153         will cause UnicodeDecodeError for non-ascii characters.
13155 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
13157         Would like a link to dashboard from build.webkit.org main page
13158         https://bugs.webkit.org/show_bug.cgi?id=122577
13160         Reviewed by Tim Hatcher.
13162         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
13164 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
13166         [Win] Check for MathML fonts and warn user if they are missing.
13167         https://bugs.webkit.org/show_bug.cgi?id=122568
13169         Reviewed by Tim Horton.
13171         * Scripts/webkitdirs.pm:
13172         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
13173         Windows-specific code I added previously.
13174         (fontExists): Added
13175         (checkInstalledTools): Add check for MathML fonts.
13177 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
13179         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
13180         https://bugs.webkit.org/show_bug.cgi?id=122471
13182         Reviewed by Tim Hatcher.
13184         Added links to webkitpy, webkitperl and bindings-tests results.
13186         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
13187         (Buildbot.prototype.apiTestResultsURLForIteration):
13188         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
13189         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
13190         (Buildbot.prototype.bindingsTestResultsURLForIteration):
13191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
13192         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
13194 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
13196         Move some functions from WebKitBuildbot to Buildbot class.
13198         Suggested by Tim Hatcher.
13200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
13201         (Buildbot.prototype.javascriptTestResultsURLForIteration):
13202         (Buildbot.prototype.apiTestResultsURLForIteration):
13203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
13204         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
13206 2013-10-09  Timothy Hatcher  <timothy@apple.com>
13208         Add API tests to the Dashbord page.
13210         https://bugs.webkit.org/show_bug.cgi?id=122283
13212         Reviewed by Timothy Hatcher.
13214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
13215         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
13216         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
13217         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
13219 2013-10-09  Timothy Hatcher  <timothy@apple.com>
13221         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
13223         https://bugs.webkit.org/show_bug.cgi?id=122515
13225         Reviewed by Alexey Proskuryakov.
13227         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
13228         (BuildbotIteration.prototype.update):
13230 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
13232         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
13233         https://bugs.webkit.org/show_bug.cgi?id=122573
13235         Reviewed by Tim Hatcher.
13237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
13238         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
13240         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
13241         (Buildbot.prototype.buildPageURLForIteration): Added.
13243 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
13245         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
13246         https://bugs.webkit.org/show_bug.cgi?id=122569
13248         Reviewed by Tim Hatcher.
13250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
13251         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
13252         to be produced by the old Mozilla test harness that we don't use any more.
13254 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
13256         Add GTK 64 bits release to the buildbot dashboard
13257         https://bugs.webkit.org/show_bug.cgi?id=122548
13259         Reviewed by Darin Adler.
13261         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
13262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
13263         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
13264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
13265         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
13267 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
13269         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
13270         https://bugs.webkit.org/show_bug.cgi?id=120638
13272         Reviewed by Gustavo Noronha Silva.
13274         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
13275         can check both the old and new APIs to retrieve text at a given offset.
13277 2013-10-08  Alex Christensen  <achristensen@webkit.org>
13279         Improved WinLauncher.
13280         https://bugs.webkit.org/show_bug.cgi?id=122536
13282         Reviewed by Brent Fulgham.
13284         * WinLauncher/PrintWebUIDelegate.cpp:
13285         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
13286         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
13287         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
13288         * WinLauncher/WinLauncher.cpp:
13289         (createCrashReport): Use the executable name instead of "WinLauncher".
13290         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
13291         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
13292         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
13294 2013-10-08  Mark Lam  <mark.lam@apple.com>
13296         Fix ruby LoadError when running run-javascriptcore-tests.
13297         https://bugs.webkit.org/show_bug.cgi?id=122519.
13299         Reviewed by Mark Hahnenberg.
13301         The scripts needed to explicitly require 'rubygems' for older versions of ruby
13302         (versions before 1.9).
13304         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
13305         * Scripts/run-jsc-stress-tests:
13307 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
13309         Unreviewed, add my new email to contributors.json.
13311         * Scripts/webkitpy/common/config/contributors.json:
13313 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
13315         Unreviewed build correction.
13317         * Scripts/webkitpy/port/win.py:
13318         (WinPort.write_registry_value): Use string representation of error message to avoid
13319         format conversion problem.
13321 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
13323         [Win] Add checks for proper build and test environment
13324         https://bugs.webkit.org/show_bug.cgi?id=122466
13326         Reviewed by Darin Adler.
13328         This patch makes two changes:
13329         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
13330            error messages so that people know what to fix to get things working.
13331         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
13332            the various environment settings are properly configured for our test environment.
13334         * Scripts/webkitdirs.pm:
13335         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
13336         caused problems in the past.
13337         (setupAppleWinEnv):
13338         * Scripts/webkitpy/port/win.py:
13339         (WinPort):
13340         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
13341         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
13342         DWORD, etc.)
13343         (WinPort.write_registry_string): Revise to call new generic registry write function.
13344         (WinPort.setup_crash_log_saving): Revise for new API
13345         (WinPort.restore_crash_log_saving): Ditto
13346         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
13347         servers from running.
13348         (WinPort.allow_error_dialogs): Ditto.
13349         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
13350         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
13352 2013-10-08  Philippe Normand  <pnormand@igalia.com>
13354         [GStreamer] enable v4l2 plugin
13355         https://bugs.webkit.org/show_bug.cgi?id=122503
13357         Reviewed by Martin Robinson.
13359         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
13360         we updated our GStreamer version to 1.0.8.
13362 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
13364         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
13365         https://bugs.webkit.org/show_bug.cgi?id=122104
13367         Reviewed by Chris Fleizach.
13369         Updated stringAttributeValue to double check that the exposure of
13370         aria-invalid as a state is consistent with its exposure as a text
13371         attribute as well, when it applies (implementations of AtkText).
13373         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
13374         (AccessibilityUIElement::stringAttributeValue): Add double check.
13375         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
13376         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
13378 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
13380         run-jsc-stress-tests progress meter should update more quickly on older Rubies
13381         https://bugs.webkit.org/show_bug.cgi?id=122459
13383         Reviewed by Darin Adler.
13385         * Scripts/run-jsc-stress-tests:
13387 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
13389         [buildbot] parse tests that are reported as crashed correctly for GTK+
13390         https://bugs.webkit.org/show_bug.cgi?id=122476
13392         Reviewed by Martin Robinson.
13394         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
13395         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
13396         as a failure of the API tests.
13398 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
13400         Unreviewed. Skipping API test that is causing the next one to crash,
13401         see https://bugs.webkit.org/show_bug.cgi?id=121970.
13403         * Scripts/run-gtk-tests:
13404         (TestRunner):
13406 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
13408         [GTK] run-gtk-tests does not distinguish between failure and crashes
13409         https://bugs.webkit.org/show_bug.cgi?id=122135
13411         Reviewed by Martin Robinson.
13413         The GTK+ API test runner does not distinguish between failures and crashes. This change
13414         makes it do that, so it's easier for us to spot the more important/higher priority crash
13415         case.
13417         * Scripts/run-gtk-tests:
13418         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
13419         so we have more information on how the process ended.
13420         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
13421         (TestRunner.run_tests): report crashes.
13423 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
13425         [GTK] Missing packages for APT on install-dependencies
13426         https://bugs.webkit.org/show_bug.cgi?id=121555
13428         Reviewed by Martin Robinson.
13430         * gtk/install-dependencies: add packages that are needed for
13431         building WebKit itself and the jhbuild dependencies.
13433 2013-10-07  Anders Carlsson  <andersca@apple.com>
13435         Fix test failures.
13437         * Scripts/webkitpy/port/base.py:
13438         (Port.to.start_helper):
13439         * Scripts/webkitpy/port/mock_drt.py:
13440         (MockDRTPort.start_helper):
13442 2013-10-07  Anders Carlsson  <andersca@apple.com>
13444         Always force discrete mode when running layout tests
13445         https://bugs.webkit.org/show_bug.cgi?id=122465
13447         Reviewed by Tim Horton.
13449         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
13450         
13451         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
13452         Link with IOKit.
13454         * DumpRenderTree/mac/LayoutTestHelper.m:
13455         (installLayoutTestColorProfile):
13456         Check installColorProfile.
13458         (restoreUserColorProfile):
13459         Check installColorProfile.
13461         (lockDownDiscreteGraphics):
13462         New function to force discrete graphics.
13464         (main):
13465         Add '--install-color-profile' option.
13467         * Scripts/webkitpy/layout_tests/controllers/manager.py:
13468         (Manager._set_up_run):
13469         Always start the helper, but pass self._options.pixel_tests to it.
13471         * Scripts/webkitpy/port/mac.py:
13472         (MacPort.start_helper):
13473         Pass --install-color-profile' to the helper if pixel_tests is true.
13475 2013-10-07  Timothy Hatcher  <timothy@apple.com>
13477         Properly count binding test failures as failures.
13479         Fix the total for multiple failures in different steps too by avoiding undefined.
13481         https://bugs.webkit.org/show_bug.cgi?id=122232
13483         Reviewed by Alexey Proskuryakov.
13485         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
13486         (BuildbotTestResults):
13487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
13488         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
13490 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
13492         [GTK] Fails to build with jhbuild with newer system glib
13493         https://bugs.webkit.org/show_bug.cgi?id=122132
13495         Reviewed by Martin Robinson.
13497         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
13498         started relying on. glib is not a dependency that should change test results, and is provided in
13499         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
13500         should not be an issue.
13502         * gtk/jhbuild.modules:
13504 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
13506         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
13507         https://bugs.webkit.org/show_bug.cgi?id=122437
13509         Reviewed by Antoine Quint.
13511         * Scripts/run-jsc-stress-tests:
13513 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
13515         Unreviewed, fix build on old Rubies.
13517         * Scripts/run-jsc-stress-tests:
13519 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
13521         Unified test infrastructure via the jsc shell
13522         https://bugs.webkit.org/show_bug.cgi?id=120696
13524         Reviewed by Oliver Hunt.
13525         
13526         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
13527         output (silent or noisy) and different styles of test failure (just bad exit code,
13528         text diff, filtering for some magical text, etc.). This allows me to get rid of the
13529         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
13530         running in run-jsc-stress-tests.
13531         
13532         Also removes all of the code paths that defended against not having shellwords. Just
13533         install the shellwords gem if you want to run tests.
13534         
13535         Also removes the non-parallel test running code. No reason for it to exist anymore.
13536         
13537         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
13538         as part of this patch, and left three more as new bugzillas.
13540         * Scripts/create-mozilla-js-test-list: Added.
13541         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
13542         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
13543         * Scripts/run-javascriptcore-tests:
13544         * Scripts/run-jsc-stress-tests:
13546 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
13548         run-jsc-stress-tests should be less verbose
13549         https://bugs.webkit.org/show_bug.cgi?id=122397
13551         Reviewed by Sam Weinig.
13552         
13553         It now just prints something like:
13554         
13555          965/1831 ....
13556         
13557         Where the first number is the number of tests that completed, the second number is the
13558         number of tests total, and the dots are the number of tests running right now - which is
13559         useful towards the end when you're waiting for the last slow tests to finish.
13560         
13561         It will also print out the output from failing tests and it will print a line for skipped
13562         tests (to annoy you into getting them into a shape where they can be unskipped). For
13563         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
13565         * Scripts/run-jsc-stress-tests:
13567 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
13569         Allow skipping of run-jsc-stress-tests that are configured using yaml files
13570         https://bugs.webkit.org/show_bug.cgi?id=122385
13572         Reviewed by Sam Wieinig.
13573         
13574         Make tests run via YAML be able to do the parse-for-commands trick that allows
13575         us to skip tests and do other custom per-test stuff.
13577         * Scripts/jsc-stress-test-helpers/layout-test-helper:
13578         * Scripts/run-jsc-stress-tests:
13580 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
13582         Unreviewed, fix tests on older Rubies.
13584         * Scripts/run-jsc-stress-tests:
13586 2013-10-05  Anders Carlsson  <andersca@apple.com>
13588         Don't filter the weak symbols.
13590         * Scripts/check-for-weak-vtables-and-externals:
13592 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
13594         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
13595         https://bugs.webkit.org/show_bug.cgi?id=122376
13597         Reviewed by Mark Hahnenberg.
13599         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
13600         * Scripts/run-javascriptcore-tests:
13601         (printThingsFound):
13602         * Scripts/run-jsc-stress-tests:
13604 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
13606         It should be even easier to run and debug a failing JSC stress test
13607         https://bugs.webkit.org/show_bug.cgi?id=122337
13609         Reviewed by Oliver Hunt.
13610         
13611         If a test fails, you can now just say:
13613         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
13615         and get the reproduction. You don't have to set any environment variables like before.
13616         Also if you want to debug the failing test you can now just say:
13618         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
13620         Broadly, any arguments passed to the reproduction script are prepended to the command to
13621         run the test. This is sort of quirky and won't work for some tests (for example the
13622         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
13623         them and that's good enough for now.
13625         * Scripts/run-jsc-stress-tests:
13627 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
13629         [Windows] Correct run-path when using 64-bit binaries.
13631         Reviewed by David Kilzer.
13633         * Scripts/webkitdirs.pm:
13634         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
13635         directory. Otherwise use the existing 'bin32' directory.
13637 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
13639         Teach webkitdirs.pm to honor the --64-bit flag
13640         https://bugs.webkit.org/show_bug.cgi?id=122357
13642         Reviewed by David Kilzer.
13644         * Scripts/webkitdirs.pm:
13645         (argumentsForConfiguration): Modify to check if --64-bit is supplied
13646         by the user.
13647         (findMatchingArguments): Added.
13648         (hasArgument): Added.
13649         (checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
13650         findMatchingArguments subroutine.
13652 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
13654         Update svn-config for new Visual Studio extensions
13655         https://bugs.webkit.org/show_bug.cgi?id=122344
13657         Reviewed by Brent Fulgham.
13659         * svn-config: Add new Visual Studio extensions.
13661 2013-10-04  Alex Christensen  <achristensen@webkit.org>
13663         Made WinLauncher have better error handling, crash reporting, and modifiability.
13664         https://bugs.webkit.org/show_bug.cgi?id=122319
13666         Reviewed by Brent Fulgham.
13668         * WinLauncher/WinLauncher.cpp:
13669         (WinLauncherWebHost::didFailProvisionalLoadWithError):
13670         Don't display the numerous "Cancelled" messages that are obviously from the user.
13671         (createCrashReport): Added.
13672         (dllLauncherEntryPoint):
13673         Made main loop back into while loop and write a crash report if it crashes.
13674         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
13675         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
13676         Added WinLauncherReplace.h.
13677         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
13678         Added linking to DbgHelp.lib.
13679         * WinLauncher/WinLauncherReplace.h:
13680         Added to make modifying WinLauncher behaviour and appearance easy.
13681         (processCrashDump): Added.
13683 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
13685         remove dpranke from webkitpy watchlist
13686         https://bugs.webkit.org/show_bug.cgi?id=122331
13688         Reviewed by Brent Fulgham.
13690         * Scripts/webkitpy/common/config/watchlist:
13692 2013-10-04  Tim Horton  <timothy_horton@apple.com>
13694         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
13695         https://bugs.webkit.org/show_bug.cgi?id=122299
13697         Reviewed by Beth Dakin.
13699         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
13700         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
13701         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
13703 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
13705         Watchlist is broken after <http://trac.webkit.org/r156880>
13707         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
13709 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
13711         Remove Qt features from build and test tools
13712         https://bugs.webkit.org/show_bug.cgi?id=122312
13714         Reviewed by Anders Carlsson.
13716         * Scripts/build-dumprendertree:
13717         * Scripts/build-jsc:
13718         * Scripts/build-webkit:
13719         * Scripts/build-webkittestrunner:
13720         * Scripts/old-run-webkit-tests:
13721         (openDumpTool):
13722         (buildPlatformResultHierarchy):
13723         (buildPlatformTestHierarchy):
13724         (readSkippedFiles):
13725         * Scripts/run-launcher:
13726         * Scripts/run-qtwebkit-tests: Removed.
13727         * Scripts/run-webkit-tests:
13728         (useNewRunWebKitTests):
13729         * Scripts/update-webkit:
13730         * Scripts/webkit-build-directory:
13731         * Scripts/webkitdirs.pm:
13732         (argumentsForConfiguration):
13733         (jscProductDir):
13734         (builtDylibPathForName):
13735         (isAppleWebKit):
13736         (launcherPath):
13737         (launcherName):
13738         (checkRequiredSystemConfig):
13739         (setupCygwinEnv):
13740         (copyInspectorFrontendFiles):
13741         (setPathForRunningWebKitApp):
13742         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
13743         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
13744         (BaselineOptimizerTest.test_mac_future):
13745         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
13746         (BaselineOptimizerTest.test_common_directory_includes_root):
13747         (BaselineOptimizerTest.test_virtual_ports_filtered):
13748         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
13749         (test_parse_reviewer_text):
13750         * Scripts/webkitpy/common/config/watchlist:
13751         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
13752         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
13753         * Scripts/webkitpy/port/base.py:
13754         (Port.__init__):
13755         (Port._port_flag_for_scripts):
13756         (Port._wk2_port_name):
13757         * Scripts/webkitpy/port/builders.py:
13758         * Scripts/webkitpy/port/factory.py:
13759         (platform_options):
13760         (PortFactory):
13761         (PortFactory._default_port):
13762         * Scripts/webkitpy/port/factory_unittest.py:
13763         (FactoryTest.test_gtk):
13764         * Scripts/webkitpy/port/qt.py: Removed.
13765         * Scripts/webkitpy/port/qt_unittest.py: Removed.
13766         * Scripts/webkitpy/style/checker.py:
13767         * Scripts/webkitpy/style/checker_unittest.py:
13768         (GlobalVariablesTest.test_path_rules_specifier):
13769         * Scripts/webkitpy/style/checkers/cmake.py:
13770         (CMakeChecker):
13771         * Scripts/webkitpy/style/checkers/cpp.py:
13772         (_classify_include):
13773         (check_include_line):
13774         (check_identifier_name_in_declaration):
13775         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
13776         (OrderOfIncludesTest.test_classify_include):
13777         (WebKitStyleTest.test_names):
13778         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
13779         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
13780         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
13781         (TestRebaselineTest.test_baseline_directory):
13782         * Scripts/webkitpy/tool/main.py:
13783         (WebKitPatch):
13785 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
13787         Unreviewed. Add myself to some watchlists.
13789         * Scripts/webkitpy/common/config/watchlist:
13791 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
13793         Remove Qt builders from the flakiness dashboard.
13795         * TestResultServer/static-dashboards/builders.jsonp:
13796         * TestResultServer/static-dashboards/flakiness_dashboard.js:
13797         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
13798         * TestResultServer/static-dashboards/loader_unittests.js:
13800 2013-10-03  Tim Horton  <timothy_horton@apple.com>
13802         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
13803         https://bugs.webkit.org/show_bug.cgi?id=122299
13805         Reviewed by Beth Dakin.
13807         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
13808         Disable threaded scrolling.
13810         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
13811         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
13812         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
13814 2013-10-03  Anders Carlsson  <andersca@apple.com>
13816         Use numeric strings in the OS version dictionary
13817         https://bugs.webkit.org/show_bug.cgi?id=122300
13819         Reviewed by Mark Rowe.
13821         * Scripts/webkitpy/common/system/platforminfo.py:
13822         (PlatformInfo._determine_mac_version):
13824 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
13826         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
13828         Rubber-stamped by Tim Horton.
13830         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
13831         (LeaksViewer._displayURLPrompt):
13833 2013-10-03  Dan Bernstein  <mitz@apple.com>
13835         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
13836         https://bugs.webkit.org/show_bug.cgi?id=122260
13838         Reviewed by Alexey Proskuryakov.
13840         For the API to work, the tests need to be compiled with a newer version of the LLVM
13841         compiler. Until the bots are updated to that version, disable the tests on 10.8.
13843         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
13845 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
13847         [ATK] Expose aria-invalid as a text attribute (not object attribute)
13848         https://bugs.webkit.org/show_bug.cgi?id=122015
13850         Reviewed by Chris Fleizach.
13852         Adapted DRT and WKTR to check the exposure of the aria-invalid
13853         attribute as a text attribute, instead of an object attribute.
13855         Also, done some refactoring of the code to try to keep things
13856         simpler and more coherent, by defining new helper functions,
13857         simplifying code, moving static variables and functions into
13858         unnammed namespaces and so on, without altering the logic other
13859         than for checking the text attribute for aria-invalid.
13861         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
13862         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
13863         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
13864         Also, never return an empty string if not falling through any of
13865         the cases checked here, and return the original attribute instead.
13866         (atkAttributeValueToCoreAttributeValue): New helper function to
13867         match the attributes values returned by the ATK wrapper with the
13868         values expected by the layout tests. Moved the mappings for the
13869         values of AXSortDirection here as well.
13870         (getAttributeSet): New helper function to retrieve a list of
13871         attributes (an AtkAttributeSet) from an AtkObject using the right
13872         API depending on whether we want the object attributes or the text
13873         attributes (in case the object implements AtkText).
13874         (getAttributeSetValueForId): Simplified by using getAttributeSet
13875         and atkAttributeValueToCoreAttributeValue. Also, added a new
13876         parameter to indicater whether we are interested in object
13877         attributes or text attributes.
13878         (getAtkAttributeSetAsString): Ditto.
13879         (attributesOfElement): Updated to pass the new required parameter
13880         to getAtkAttributeSetAsString, indicating that we want the object
13881         attributes in this case, for backwards compatibility.
13882         (indexRangeInTable): Moved up in the file into the unnammed namespace.
13883         (alterCurrentValue): Ditto.
13884         (AccessibilityUIElement::stringAttributeValue): After moving most
13885         of the code here to the new helper functions, simplified it by
13886         just checking whether the required attribute is provided as an
13887         object attribute or, if that's not the case, as a text attribute.
13888         (AccessibilityUIElement::isAttributeSupported): Ditto.
13889         (AccessibilityUIElement::intValue): Updated to pass the new
13890         required parameter to getAttributeSetValueForId, indicating that
13891         we want the object attributes in this case.
13892         (AccessibilityUIElement::hasPopup): Ditto.
13894         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
13895         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
13896         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
13897         (WTR::getAttributeSet): Ditto.
13898         (WTR::getAttributeSetValueForId): Ditto.
13899         (WTR::getAtkAttributeSetAsString): Ditto.
13900         (WTR::attributesOfElement): Ditto.
13901         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
13902         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
13903         (WTR::AccessibilityUIElement::intValue): Ditto.
13904         (WTR::AccessibilityUIElement::hasPopup): Ditto.
13906 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
13908         EWS build fix after the Qt EWS removal.
13910         * QueueStatusServer/model/attachment.py:
13911         (Attachment._calculate_queue_positions):
13913 2013-10-02  Anders Carlsson  <andersca@apple.com>
13915         Remove Qt code from Tools/
13916         https://bugs.webkit.org/show_bug.cgi?id=122227
13918         Reviewed by Andreas Kling.
13920         * DumpRenderTree/WorkQueue.cpp:
13921         * DumpRenderTree/blackberry/src.pro: Removed.
13922         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
13923         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
13924         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
13925         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
13926         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
13927         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
13928         * DumpRenderTree/qt/EventSenderQt.h: Removed.
13929         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
13930         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
13931         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
13932         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
13933         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
13934         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
13935         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
13936         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
13937         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
13938         * DumpRenderTree/qt/resources/user.css: Removed.
13939         * DumpRenderTree/qt/testplugin.cpp: Removed.
13940         * DumpRenderTree/qt/testplugin.h: Removed.
13941         * ImageDiff/ImageDiff.pro: Removed.
13942         * ImageDiff/qt/ImageDiff.cpp: Removed.
13943         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
13944         * MiniBrowser/qt/BrowserWindow.h: Removed.
13945         * MiniBrowser/qt/MiniBrowser.pro: Removed.
13946         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
13947         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
13948         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
13949         * MiniBrowser/qt/UrlLoader.cpp: Removed.
13950         * MiniBrowser/qt/UrlLoader.h: Removed.
13951         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
13952         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
13953         * MiniBrowser/qt/icons/contents_width.png: Removed.
13954         * MiniBrowser/qt/icons/favicon.png: Removed.
13955         * MiniBrowser/qt/icons/find.png: Removed.
13956         * MiniBrowser/qt/icons/folder.png: Removed.
13957         * MiniBrowser/qt/icons/info.png: Removed.
13958         * MiniBrowser/qt/icons/next.png: Removed.
13959         * MiniBrowser/qt/icons/plus.png: Removed.
13960         * MiniBrowser/qt/icons/previous.png: Removed.
13961         * MiniBrowser/qt/icons/refresh.png: Removed.
13962         * MiniBrowser/qt/icons/stop.png: Removed.
13963         * MiniBrowser/qt/icons/titlebar.png: Removed.
13964         * MiniBrowser/qt/icons/touch.png: Removed.
13965         * MiniBrowser/qt/icons/touchpoint.png: Removed.
13966         * MiniBrowser/qt/icons/up.png: Removed.
13967         * MiniBrowser/qt/js/MultiSelect.js: Removed.
13968         * MiniBrowser/qt/main.cpp: Removed.
13969         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
13970         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
13971         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
13972         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
13973         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
13974         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
13975         * MiniBrowser/qt/qml/Dialog.qml: Removed.
13976         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
13977         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
13978         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
13979         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
13980         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
13981         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
13982         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
13983         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
13984         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
13985         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
13986         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
13987         * MiniBrowser/qt/raw/Target.pri: Removed.
13988         * MiniBrowser/qt/raw/View.cpp: Removed.
13989         * MiniBrowser/qt/raw/View.h: Removed.
13990         * MiniBrowser/qt/utils.cpp: Removed.
13991         * MiniBrowser/qt/utils.h: Removed.
13992         * QtTestBrowser/QtTestBrowser.pro: Removed.
13993         * QtTestBrowser/QtTestBrowser.qrc: Removed.
13994         * QtTestBrowser/cookiejar.cpp: Removed.
13995         * QtTestBrowser/cookiejar.h: Removed.
13996         * QtTestBrowser/favicon.png: Removed.
13997         * QtTestBrowser/fpstimer.cpp: Removed.
13998         * QtTestBrowser/fpstimer.h: Removed.
13999         * QtTestBrowser/launcherwindow.cpp: Removed.
14000         * QtTestBrowser/launcherwindow.h: Removed.
14001         * QtTestBrowser/locationedit.cpp: Removed.
14002         * QtTestBrowser/locationedit.h: Removed.
14003         * QtTestBrowser/mainwindow.cpp: Removed.
14004         * QtTestBrowser/mainwindow.h: Removed.
14005         * QtTestBrowser/qttestbrowser.cpp: Removed.
14006         * QtTestBrowser/urlloader.cpp: Removed.
14007         * QtTestBrowser/urlloader.h: Removed.
14008         * QtTestBrowser/useragentlist.txt: Removed.
14009         * QtTestBrowser/utils.cpp: Removed.
14010         * QtTestBrowser/utils.h: Removed.
14011         * QtTestBrowser/webinspector.h: Removed.
14012         * QtTestBrowser/webpage.cpp: Removed.
14013         * QtTestBrowser/webpage.h: Removed.
14014         * QtTestBrowser/webview.cpp: Removed.
14015         * QtTestBrowser/webview.h: Removed.
14016         * TestWebKitAPI/DerivedSources.pri: Removed.
14017         * TestWebKitAPI/InjectedBundle.pri: Removed.
14018         * TestWebKitAPI/PlatformWebView.h:
14019         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
14020         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
14021         * TestWebKitAPI/Tests.pri: Removed.
14022         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
14023         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
14024         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
14025         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
14026         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
14027         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
14028         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
14029         * TestWebKitAPI/qt/main.cpp: Removed.
14030         * Tools.pro: Removed.
14031         * WebKitTestRunner/DerivedSources.pri: Removed.
14032         * WebKitTestRunner/EventSenderProxy.h:
14033         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
14034         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
14035         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
14036         (WTR::InjectedBundlePage::resetAfterTest):
14037         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
14038         (WTR::InjectedBundlePage::didClearWindowForFrame):
14039         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
14040         * WebKitTestRunner/InjectedBundle/TestRunner.h:
14041         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
14042         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
14043         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
14044         * WebKitTestRunner/PlatformWebView.h:
14045         * WebKitTestRunner/Target.pri: Removed.
14046         * WebKitTestRunner/TestController.cpp:
14047         (WTR::TestController::resetStateToConsistentValues):
14048         * WebKitTestRunner/TestController.h:
14049         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
14050         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
14051         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
14052         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
14053         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
14054         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
14055         * WebKitTestRunner/qt/main.cpp: Removed.
14056         * WebKitTestRunner/qt/resources/user.css: Removed.
14057         * qmake/.qmake.cache: Removed.
14058         * qmake/.qmake.conf: Removed.
14059         * qmake/README: Removed.
14060         * qmake/config.tests/README: Removed.
14061         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
14062         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
14063         * qmake/config.tests/gccdepends/empty.cpp: Removed.
14064         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
14065         * qmake/config.tests/glx/glx.cpp: Removed.
14066         * qmake/config.tests/glx/glx.pro: Removed.
14067         * qmake/config.tests/gnuld/gnuld.pro: Removed.
14068         * qmake/config.tests/gnuld/main.cpp: Removed.
14069         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
14070         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
14071         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
14072         * qmake/config.tests/libXrender/libXrender.pro: Removed.
14073         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
14074         * qmake/config.tests/libwebp/libwebp.pro: Removed.
14075         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
14076         * qmake/config.tests/libxml2/libxml2.pro: Removed.
14077         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
14078         * qmake/config.tests/libxslt/libxslt.pro: Removed.
14079         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
14080         * qmake/config.tests/libzlib/libzlib.pro: Removed.
14081         * qmake/dump-features.pl: Removed.
14082         * qmake/mkspecs/features/configure.prf: Removed.
14083         * qmake/mkspecs/features/default_post.prf: Removed.
14084         * qmake/mkspecs/features/default_pre.prf: Removed.
14085         * qmake/mkspecs/features/features.prf: Removed.
14086         * qmake/mkspecs/features/features.pri: Removed.
14087         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
14088         * qmake/mkspecs/features/functions.prf: Removed.
14089         * qmake/mkspecs/features/gprof.prf: Removed.
14090         * qmake/mkspecs/features/mac/default_post.prf: Removed.
14091         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
14092         * qmake/mkspecs/features/minimal_qt.prf: Removed.
14093         * qmake/mkspecs/features/production_build.prf: Removed.
14094         * qmake/mkspecs/features/rpath.prf: Removed.
14095         * qmake/mkspecs/features/unix/default_post.prf: Removed.
14096         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
14097         * qmake/mkspecs/features/unix/icc.prf: Removed.
14098         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
14099         * qmake/mkspecs/features/valgrind.prf: Removed.
14100         * qmake/mkspecs/features/webkit_modules.prf: Removed.
14101         * qmake/mkspecs/features/win32/default_post.prf: Removed.
14102         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
14103         * qmake/mkspecs/modules/angle.prf: Removed.
14104         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
14105         * qmake/mkspecs/modules/webcore.prf: Removed.
14106         * qmake/mkspecs/modules/webkit1.prf: Removed.
14107         * qmake/mkspecs/modules/webkit2.prf: Removed.
14108         * qmake/mkspecs/modules/wtf.prf: Removed.
14110 2013-10-02  Tim Horton  <timothy_horton@apple.com>
14112         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) 
14113         https://bugs.webkit.org/show_bug.cgi?id=121859
14114         <rdar://problem/15069359>
14116         Reviewed by Anders Carlsson.
14118         * WebKitTestRunner/TestInvocation.cpp:
14119         (WTR::shouldUseThreadedScrolling):
14120         (WTR::updateThreadedScrollingForCurrentTest):
14121         (WTR::TestInvocation::invoke):
14122         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
14123         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
14124         (WTR::PlatformWebView::PlatformWebView):
14125         (WTR::PlatformWebView::viewSupportsOptions):
14126         Rename the tiled drawing switch to threaded scrolling, since that's really
14127         all it switches now that we use tiled drawing everywhere.
14129         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
14130         and to more closely match the case we're interested in testing.
14132 2013-10-02  Anders Carlsson  <andersca@apple.com>
14134         Move AHEM____.TTF from qt/fonts/ to fonts/.
14136         Rubber-stamped by Andreas Kling.
14138         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
14139         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
14141 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
14143         Remove Qt bots and EWS from trunk.
14144         https://bugs.webkit.org/show_bug.cgi?id=122210.
14146         Reviewed by Allan Sandfeld Jensen.
14148         Remove Qt buil dbots.
14150         * BuildSlaveSupport/build.webkit.org-config/config.json:
14151         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
14152         (appendCustomBuildFlags):
14153         (RunGtkAPITests.getText2):
14154         (Factory.__init__):
14155         (TestFactory.__init__):
14156         (BuildAndTestFactory.__init__):
14157         (loadBuilderConfig):
14158         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
14160 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
14162         Remove Qt bots and EWS from trunk.
14163         https://bugs.webkit.org/show_bug.cgi?id=122210.
14165         Reviewed by Allan Sandfeld Jensen.
14167         Remove Qt EWS bots.
14169         * QueueStatusServer/config/queues.py:
14170         * Scripts/webkitpy/common/config/ews.json:
14172 2013-10-01  Timothy Hatcher  <timothy@apple.com>
14174         Fix singular labels for test failures.
14176         https://bugs.webkit.org/show_bug.cgi?id=122200
14178         Reviewed by Joseph Pecoraro.
14180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
14181         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
14183 2013-10-01  Timothy Hatcher  <timothy@apple.com>
14185         Don't keep appending iterations each time the queue updates.
14187         https://bugs.webkit.org/show_bug.cgi?id=122198
14189         Reviewed by Joseph Pecoraro.
14191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
14192         (BuildbotQueue.prototype.update):
14194 2013-10-01  Timothy Hatcher  <timothy@apple.com>
14196         Properly sort iterations in the Dashboard by revision for out-of-order queues.
14198         https://bugs.webkit.org/show_bug.cgi?id=122196
14200         Reviewed by Brent Fulgham.
14202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
14203         (BuildbotIteration):
14204         (BuildbotIteration.prototype.update):
14205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
14206         (BuildbotQueue.prototype.update):
14207         (BuildbotQueue.prototype.sortIterations):
14209 2013-10-01  Timothy Hatcher  <timothy@apple.com>
14211         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
14213         Also fix some URLs to not have extras slashes and add a page title.
14215         https://bugs.webkit.org/show_bug.cgi?id=122192
14217         Reviewed by Joseph Pecoraro.
14219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
14220         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
14221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
14222         (WebKitBuildbot.prototype.buildLogURLForIteration):
14223         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
14224         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
14225         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
14227 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
14229         [Mac] Set NSApplication current event while sending events directly to views
14230         https://bugs.webkit.org/show_bug.cgi?id=122179
14232         Reviewed by Darin Adler.
14234         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
14235         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
14236         use the current event.
14238         * DumpRenderTree/mac/EventSendingController.mm:
14239         (-[EventSendingController mouseDown:withModifiers:]):
14240         (-[EventSendingController mouseUp:withModifiers:]):
14241         (-[EventSendingController mouseMoveToX:Y:]):
14242         (-[EventSendingController mouseScrollByX:andY:continuously:]):
14243         (-[EventSendingController contextClick]):
14244         (-[EventSendingController keyDown:withModifiers:withLocation:]):
14245         * WebKitTestRunner/mac/EventSenderProxy.mm:
14246         (WTR::EventSenderProxy::mouseDown):
14247         (WTR::EventSenderProxy::mouseUp):
14248         (WTR::EventSenderProxy::mouseMoveTo):
14249         (WTR::EventSenderProxy::keyDown):
14250         (WTR::EventSenderProxy::mouseScrollBy):
14251         Update the current event. We were already using the SPI in WebKit.
14253 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
14255         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
14256         https://bugs.webkit.org/show_bug.cgi?id=122183
14258         Reviewed by Timothy Hatcher.
14260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
14261         (BuildbotIteration.prototype.update):
14263 2013-10-01  Timothy Hatcher  <timothy@apple.com>
14265         Tweaks to the Buildbot Dashboard
14267         https://bugs.webkit.org/show_bug.cgi?id=122169
14269         Reviewed by Alexey Proskuryakov.
14271         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
14272         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
14273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
14274         (BuildbotQueueView.prototype.revisionLinksForIteration):
14275         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
14276         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
14277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
14278         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
14279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
14280         (WebKitBuildbot.prototype.buildLogURLForIteration):
14281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
14283 2013-10-01  Commit Queue  <commit-queue@webkit.org>
14285         Unreviewed, rolling out r156725.
14286         http://trac.webkit.org/changeset/156725
14287         https://bugs.webkit.org/show_bug.cgi?id=122176
14289         broke all the mismatch tests again (Requested by thorton on
14290         #webkit).
14292         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
14293         (WTR::PlatformWebView::PlatformWebView):
14295 2013-10-01  Alex Christensen  <achristensen@webkit.org>
14297         Implemented createWebViewWithRequest in WinLauncher.
14298         https://bugs.webkit.org/show_bug.cgi?id=122069
14300         Reviewed by Brent Fulgham.
14302         * WinLauncher/PrintWebUIDelegate.cpp:
14303         (PrintWebUIDelegate::createWebViewWithRequest): Added.
14304         * WinLauncher/PrintWebUIDelegate.h:
14305         Removed createWebViewWithRequest stub.
14307 2013-10-01  Tim Horton  <timothy_horton@apple.com>
14309         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
14310         https://bugs.webkit.org/show_bug.cgi?id=122006
14311         <rdar://problem/15095197>
14313         Reviewed by Dean Jackson.
14315         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
14316         (WTR::PlatformWebView::PlatformWebView):
14317         Layer-back the root view in WebKitTestRunner's window, to work around a bug
14318         where the window server snapshot API returns blank snapshots.
14320         Re-landing after r156724, this should not break everything now.
14322 2013-10-01  Tim Horton  <timothy_horton@apple.com>
14324         [mac] 1x emulation on Retina hardware shouldn't use SPI
14325         https://bugs.webkit.org/show_bug.cgi?id=122152
14326         <rdar://problem/15119384>
14328         Reviewed by Anders Carlsson.
14330         * DumpRenderTree/mac/DumpRenderTree.mm:
14331         (createWebViewAndOffscreenWindow):
14332         (main):
14333         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
14334         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
14335         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
14336         (WTR::PlatformWebView::PlatformWebView):
14337         * WebKitTestRunner/mac/main.mm:
14338         (main):
14339         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
14341 2013-09-30  Sam Weinig  <sam@webkit.org>
14343         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
14344         https://bugs.webkit.org/show_bug.cgi?id=116474
14346         Reviewed by Ryosuke Niwa.
14348         * Scripts/webkitpy/style/checkers/cpp.py:
14349         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
14351 2013-09-30  Sam Weinig  <sam@webkit.org>
14353         Remove support for DOMFileSystem
14354         https://bugs.webkit.org/show_bug.cgi?id=122137
14356         Reviewed by Anders Carlsson.
14358         * Scripts/webkitperl/FeatureList.pm:
14359         * Scripts/webkitpy/style/checkers/cpp.py:
14360         (check_spacing):
14361         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
14362         (CppStyleTest.test_spacing_for_binary_ops):
14363         * qmake/mkspecs/features/features.pri:
14365 2013-09-30  Mark Rowe  <mrowe@apple.com>
14367         More build fixage for builds with SDKs.
14369         * WebKitTestRunner/Configurations/Base.xcconfig:
14370         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
14372 2013-09-30  Timothy Hatcher  <timothy@apple.com>
14374         Add initial version of a new Buildbot dashboard view.
14376         https://bugs.webkit.org/show_bug.cgi?id=122131
14378         Reviewed by Alexey Proskuryakov.
14380         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
14381         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
14382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
14383         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
14384         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
14385         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
14386         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
14387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
14388         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
14389         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
14390         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
14391         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
14392         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
14393         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
14394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
14395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
14396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
14397         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
14398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
14399         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
14400         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
14401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
14402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
14403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
14404         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
14405         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
14406         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
14407         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
14408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
14409         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
14410         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
14411         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
14413 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
14415         Remove the code guarded by STYLE_SCOPED
14416         https://bugs.webkit.org/show_bug.cgi?id=122123
14418         Reviewed by Anders Carlsson.
14420         * DumpRenderTree/gtk/DumpRenderTree.cpp:
14421         (resetDefaultsToConsistentValues):
14422         * Scripts/webkitperl/FeatureList.pm:
14423         * qmake/mkspecs/features/features.pri:
14425 2013-09-30  Mark Rowe  <mrowe@apple.com>
14427         Fix the build when building against an SDK.
14429         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
14430         the compiler command lines. It can't know to do this for the system framework search paths
14431         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
14433         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
14434         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
14436 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
14438         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
14440         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
14441         it to be double-freed.
14443         * WinLauncher/WinLauncher.cpp:
14444         (EditProc): Be explicit about type passed to loadURL.
14445         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
14446         that reallocating the BSTR is done with the knowledge of the smart pointer.
14448 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
14450         [Qt] Fix force_static_libs_as_shared in WebKit2
14451         https://bugs.webkit.org/show_bug.cgi?id=121961
14453         Reviewed by Csaba Osztrogonác.
14455         Get rid of the unused WebKit2QML library
14457         * qmake/mkspecs/features/webkit_modules.prf:
14458         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
14460 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
14462         [EFL] Fix incorrect click counting in EventSenderProxy
14463         https://bugs.webkit.org/show_bug.cgi?id=122098
14465         Reviewed by Gyuyoung Kim.
14467         Previously used two types of recording time, which conflicted with each other.
14469         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
14470         (WTR::EventSenderProxy::mouseUp):
14472 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
14474         [webkitpy] Make the Xvfb screen depth overridable
14475         https://bugs.webkit.org/show_bug.cgi?id=122089
14477         Reviewed by Gyuyoung Kim.
14479         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
14480         was set. The default value that's used if the variable wasn't set is 24.
14482         * Scripts/webkitpy/port/xvfbdriver.py:
14483         (XvfbDriver._xvfb_screen_depth):
14484         (XvfbDriver._start):
14485         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
14486         (XvfbDriverTest.make_driver):
14487         (XvfbDriverTest.test_start_no_pixel_tests):
14488         (XvfbDriverTest.test_start_pixel_tests):
14489         (XvfbDriverTest.test_start_arbitrary_worker_number):
14490         (XvfbDriverTest.test_next_free_display):
14491         (XvfbDriverTest.test_start_next_worker):
14493 2013-09-29  Mark Rowe  <mrowe@apple.com>
14495         Fix the Lion build.
14497         Ensure that C++ and Objective-C++ files build with the right compiler flags.
14499         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
14500         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
14502 2013-09-28  Mark Rowe  <mrowe@apple.com>
14504         Fix some failures with newer versions of clang.
14506         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
14507         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
14508         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
14509         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
14510         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
14512         Reviewed by Dan Bernstein.
14514         * DumpRenderTree/mac/Configurations/Base.xcconfig:
14515         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
14516         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
14517         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
14518         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
14519         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
14520         * WebKitTestRunner/Configurations/Base.xcconfig:
14521         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
14522         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
14523         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
14524         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
14526 2013-09-27  Commit Queue  <commit-queue@webkit.org>
14528         Unreviewed, rolling out r156569.
14529         http://trac.webkit.org/changeset/156569
14530         https://bugs.webkit.org/show_bug.cgi?id=122035
14532         broke a lot of mismatch tests (Requested by thorton on
14533         #webkit).
14535         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
14536         (WTR::PlatformWebView::PlatformWebView):
14538 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
14540         Don't retry failures on Apple MountainLion Release WK1 tester
14541         https://bugs.webkit.org/show_bug.cgi?id=122026
14543         Reviewed by Mark Rowe.
14545         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
14546         on this bot.
14548 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
14550         Don't hardcode builder specific configuration in buildbot master.cfg
14551         https://bugs.webkit.org/show_bug.cgi?id=122023
14553         Reviewed by Mark Rowe.
14555         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
14556         property to Qt Mountain Lion Release, making it run pixel tests.
14558         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
14559         (RunWebKitTests.start): Use additionalArguments.
14560         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
14562 2013-09-27  Tim Horton  <timothy_horton@apple.com>
14564         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
14565         https://bugs.webkit.org/show_bug.cgi?id=122006
14566         <rdar://problem/15095197>
14568         Reviewed by Dean Jackson.
14570         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
14571         (WTR::PlatformWebView::PlatformWebView):
14572         Layer-back the root view in WebKitTestRunner's window, to work around a bug
14573         where the window server snapshot API returns blank snapshots.
14575 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
14577         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
14578         https://bugs.webkit.org/show_bug.cgi?id=106924
14580         Reviewed by Chris Fleizach.
14582         Consider headings levels as values to be returned in intValue()
14583         both in DRT and WKTR, so we can share more tests with other ports.
14585         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
14586         (AccessibilityUIElement::intValue): Consider headings too.
14587         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
14588         (WTR::AccessibilityUIElement::intValue): Ditto.
14590 2013-09-26  Darin Adler  <darin@apple.com>
14592         rename KURL to URL
14593         https://bugs.webkit.org/show_bug.cgi?id=16214
14595         Reviewed by Andreas Kling.
14597         * many files: Renamed, using script.
14599 2013-09-27  Darin Adler  <darin@apple.com>
14601         Fix Python scripts test failures.
14603         * Scripts/webkitpy/style/checkers/cpp.py:
14604         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
14605         now, not by the checker itself.
14607 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
14609         [GTK][WK2] Logging of accessibility events is not disabled between tests
14610         https://bugs.webkit.org/show_bug.cgi?id=121957
14612         Reviewed by Mario Sanchez Prada.
14614         Fixed an issue in AccessibilityNotificationHandler where the destructor
14615         was not disconnecting accessibility event callbacks if logging was on.
14616         The decision of disconnecting events can solely rely on the existence of
14617         notification handlers because logging uses the global notification
14618         handler.
14620         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
14621         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
14622         disconnection when logging is on.
14624 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
14626         Add general CMakeLists.txt for DRT
14627         https://bugs.webkit.org/show_bug.cgi?id=119268
14629         Reviewed by Gyuyoung Kim.
14631         The new file allows better sharing between ports.
14633         * CMakeLists.txt:
14634         * DumpRenderTree/CMakeLists.txt: Added.
14635         * DumpRenderTree/PlatformEfl.cmake: Added.
14636         * DumpRenderTree/efl/CMakeLists.txt: Removed.
14638 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
14640         [Qt] Fix force_static_libs_as_shared in WebKit2
14641         https://bugs.webkit.org/show_bug.cgi?id=121961
14643         Reviewed by Csaba Osztrogonác.
14645         Reenable force_static_libs_as_shared when building WebKit2.
14647         * qmake/mkspecs/features/default_post.prf:
14649 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
14651         [Qt] Mock implementations of positioning and orientation not used
14652         https://bugs.webkit.org/show_bug.cgi?id=121956
14654         Reviewed by Csaba Osztrogonác.
14656         Move production_build checks to sanitizeFeatures where its value is actually known.
14658         * qmake/mkspecs/features/features.prf:
14659         * qmake/mkspecs/features/features.pri:
14661 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
14663         [ATK] Normalize checks in entry points for DRT and WKTR
14664         https://bugs.webkit.org/show_bug.cgi?id=121959
14666         Reviewed by Chris Fleizach.
14668         Always check if we have a proper instance of AtkObject,
14669         implementing the interfaces that we might need for each case, at
14670         the entry point of every method of AccessibilityUIElement for ATK,
14671         and do those checks in an uniform way across DRT and WKTR, to
14672         avoid confusion and issues when modifying these files in the future.
14674         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
14675         (AccessibilityUIElement::getChildren): Use normalized checks.
14676         (AccessibilityUIElement::getChildrenWithRange): Ditto.
14677         (AccessibilityUIElement::rowCount): Ditto.
14678         (AccessibilityUIElement::columnCount): Ditto.
14679         (AccessibilityUIElement::childrenCount): Ditto.
14680         (AccessibilityUIElement::elementAtPoint): Ditto.
14681         (AccessibilityUIElement::getChildAtIndex): Ditto.
14682         (AccessibilityUIElement::allAttributes): Ditto.
14683         (AccessibilityUIElement::titleUIElement): Ditto.
14684         (AccessibilityUIElement::parentElement): Ditto.
14685         (AccessibilityUIElement::attributesOfChildren): Ditto.
14686         (AccessibilityUIElement::role): Ditto.
14687         (AccessibilityUIElement::title): Ditto.
14688         (AccessibilityUIElement::description): Ditto.
14689         (AccessibilityUIElement::stringValue): Ditto.
14690         (AccessibilityUIElement::language): Ditto.
14691         (AccessibilityUIElement::x): Ditto.
14692         (AccessibilityUIElement::y): Ditto.
14693         (AccessibilityUIElement::width): Ditto.
14694         (AccessibilityUIElement::height): Ditto.
14695         (AccessibilityUIElement::orientation): Ditto.
14696         (AccessibilityUIElement::intValue): Ditto.
14697         (AccessibilityUIElement::minValue): Ditto.
14698         (AccessibilityUIElement::maxValue): Ditto.
14699         (indexRangeInTable): Ditto.
14700         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
14701         (AccessibilityUIElement::stringAttributeValue): Ditto.
14702         (alterCurrentValue): Ditto.
14703         (AccessibilityUIElement::press): Ditto.
14704         (AccessibilityUIElement::documentEncoding): Ditto.
14705         (AccessibilityUIElement::documentURI): Ditto.
14706         (AccessibilityUIElement::hasPopup): Ditto.
14708         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
14709         (WTR::indexRangeInTable): Use normalized checks.
14710         (WTR::alterCurrentValue): Ditto.
14711         (WTR::AccessibilityUIElement::getChildren): Ditto.
14712         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
14713         (WTR::AccessibilityUIElement::childrenCount): Ditto.
14714         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
14715         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
14716         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
14717         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
14718         (WTR::AccessibilityUIElement::parentElement): Ditto.
14719         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
14720         (WTR::AccessibilityUIElement::allAttributes): Ditto.
14721         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
14722         (WTR::AccessibilityUIElement::role): Ditto.
14723         (WTR::AccessibilityUIElement::title): Ditto.
14724         (WTR::AccessibilityUIElement::description): Ditto.
14725         (WTR::AccessibilityUIElement::orientation): Ditto.
14726         (WTR::AccessibilityUIElement::stringValue): Ditto.
14727         (WTR::AccessibilityUIElement::language): Ditto.
14728         (WTR::AccessibilityUIElement::x): Ditto.
14729         (WTR::AccessibilityUIElement::y): Ditto.
14730         (WTR::AccessibilityUIElement::width): Ditto.
14731         (WTR::AccessibilityUIElement::height): Ditto.
14732         (WTR::AccessibilityUIElement::intValue): Ditto.
14733         (WTR::AccessibilityUIElement::minValue): Ditto.
14734         (WTR::AccessibilityUIElement::maxValue): Ditto.
14735         (WTR::AccessibilityUIElement::rowCount): Ditto.
14736         (WTR::AccessibilityUIElement::columnCount): Ditto.
14737         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
14738         (WTR::AccessibilityUIElement::press): Ditto.
14739         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
14740         (WTR::AccessibilityUIElement::documentURI): Ditto.
14741         (WTR::AccessibilityUIElement::hasPopup): Ditto.
14743 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
14745         [ATK] accessibility/aria-sort.html is failing after r156409
14746         https://bugs.webkit.org/show_bug.cgi?id=121947
14748         Reviewed by Chris Fleizach.
14750         Implement AccessibilityUIElement::isSupported for the ATK
14751         platforms, just by checking whether we have an associated object
14752         attribute exposed for the wrapper object matching the required
14753         attribute in the layout test (e.g "AXSortDirection" -> "sort").
14755         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
14756         (AccessibilityUIElement::isAttributeSupported): Implemented.
14757         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
14758         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
14760 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
14762         [MediaStream] make MediaStream testable
14763         https://bugs.webkit.org/show_bug.cgi?id=121967
14765         Reviewed by Dean Jackson.
14767         * DumpRenderTree/mac/UIDelegate.mm:
14768         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
14769             user media request policy delegate.
14771 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
14773         build-webkit --inspector-frontend should copy WebInspectorUI files
14774         https://bugs.webkit.org/show_bug.cgi?id=117851
14776         Reviewed by Joseph Pecoraro.
14778         Change the --inspector-frontend build option to additionally build/copy 
14779         WebInspectorUI by setting it as the only project that needs to be built.
14781         * Scripts/build-webkit:
14783 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
14785         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
14786         https://bugs.webkit.org/show_bug.cgi?id=121951
14788         Reviewed by Carlos Garcia Campos.
14790         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
14791         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
14792         500 layout tests that trigger accelerated compositing to be used.
14794         * Scripts/webkitpy/port/xvfbdriver.py:
14795         (XvfbDriver._start):
14796         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
14797         (XvfbDriverTest.test_start_no_pixel_tests):
14798         (XvfbDriverTest.test_start_pixel_tests):
14799         (XvfbDriverTest.test_start_arbitrary_worker_number):
14800         (XvfbDriverTest.test_next_free_display):
14801         (XvfbDriverTest.test_start_next_worker):
14803 2013-09-26  Tim Horton  <timothy_horton@apple.com>
14805         Tiled drawing should not imply threaded scrolling
14806         https://bugs.webkit.org/show_bug.cgi?id=121874
14807         <rdar://problem/15071494>
14809         Reviewed by Sam Weinig.
14811         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
14812         (WTR::PlatformWebView::PlatformWebView):
14813         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
14815 2013-09-26  Commit Queue  <commit-queue@webkit.org>
14817         Unreviewed, rolling out r156457.
14818         http://trac.webkit.org/changeset/156457
14819         https://bugs.webkit.org/show_bug.cgi?id=121960
14821         Broke webkitpy tests. (Requested by kling on #webkit).
14823         * Scripts/webkitpy/port/xvfbdriver.py:
14824         (XvfbDriver._start):
14826 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
14828         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
14829         https://bugs.webkit.org/show_bug.cgi?id=121951
14831         Reviewed by Carlos Garcia Campos.
14833         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
14834         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
14835         500 layout tests that trigger accelerated compositing to be used.
14837         * Scripts/webkitpy/port/xvfbdriver.py:
14838         (XvfbDriver._start):
14840 2013-09-25  Alex Christensen  <achristensen@webkit.org>
14842         Removed check for Apple Application Support directory in WinCairo port.
14843         https://bugs.webkit.org/show_bug.cgi?id=121869
14845         Reviewed by Brent Fulgham.
14847         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
14848         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
14849         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
14850         Use DLLLauncherWinCairo.props for WinCairo ports.
14851         * win/DLLLauncher/DLLLauncherMain.cpp:
14852         (wWinMain):
14853         Don't call modifyPath to check for AAS in the WinCairo port.
14854         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
14856 2013-09-25  Alex Christensen  <achristensen@webkit.org>
14858         Enabled AssembleBuildLogs on WinCairo port.
14859         https://bugs.webkit.org/show_bug.cgi?id=121923
14861         Reviewed by Brent Fulgham.
14863         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
14864         Fixed reference to README, added WinCairo configurations.
14865         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
14866         Fixed reference to README.
14867         * win/AssembleBuildLogs/AssembleLogs.cmd:
14868         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
14869         * win/AssembleBuildLogs/README: Fixed spelling.
14871 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
14873         [WIN] Fix MSVC C4146 compiler warning
14874         https://bugs.webkit.org/show_bug.cgi?id=121838
14876         Reviewed by Brent Fulgham.
14878         Fix some variables from unsinged to int to fix the compiler warning
14879         "unary minus operator applied to unsigned type, result still unsigned".
14881         * DumpRenderTree/WorkQueueItem.h:
14882         (BackItem::BackItem):
14883         (ForwardItem::ForwardItem):
14884         * DumpRenderTree/win/DumpRenderTree.cpp:
14885         (createWebViewAndOffscreenWindow):
14887 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
14889         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
14890         https://bugs.webkit.org/show_bug.cgi?id=121256
14892         Reviewed by Martin Robinson.
14894         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
14895         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
14897         * BuildSlaveSupport/build.webkit.org-config/config.json:
14899 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
14901         Add style checker for CMake lists
14902         https://bugs.webkit.org/show_bug.cgi?id=121764
14904         Reviewed by Ryosuke Niwa.
14906         Add an additional check to make sure that list of files are sorted.
14907         Exclude lists of include directories for now, since the order
14908         can be importent for compilation of some files.
14910         * Scripts/webkitpy/style/checkers/cmake.py:
14911         (CMakeChecker.check):
14912         (CMakeChecker._check_indent):
14913         (CMakeChecker):
14914         (CMakeChecker._check_list_order):
14915         (CMakeChecker._list_item_path):
14916         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
14917         (CMakeCheckerTest.test_check):
14919 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
14921         CMakeChecker takes unusually long time to run
14922         https://bugs.webkit.org/show_bug.cgi?id=105662
14924         Reviewed by Ryosuke Niwa.
14926         Move the caching mechanism for regular expression of the C++ checker into
14927         a common file and use it for the CMake and ChangeLog checkers too.
14929         * Scripts/webkitpy/style/checkers/changelog.py:
14930         (ChangeLogChecker.check_entry):
14931         * Scripts/webkitpy/style/checkers/cmake.py:
14932         (CMakeChecker._process_line):
14933         (CMakeChecker._check_no_space_cmds):
14934         (CMakeChecker._check_one_space_cmds):
14935         (CMakeChecker._check_non_lowercase_cmd):
14936         * Scripts/webkitpy/style/checkers/common.py:
14937         (match):
14938         (search):
14939         (searchIgnorecase):
14940         (sub):
14941         (subn):
14942         * Scripts/webkitpy/style/checkers/cpp.py:
14944 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
14946         [Qt] Fix build with Qt 5.2 QtPosition module
14947         https://bugs.webkit.org/show_bug.cgi?id=121089
14949         Reviewed by Simon Hausmann.
14951         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
14952         that might depend on them.
14954         * qmake/mkspecs/features/default_pre.prf:
14955         * qmake/mkspecs/features/features.prf:
14957 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
14959         [ATK] Fix style issues in AccessibilityUIElementAtk
14960         https://bugs.webkit.org/show_bug.cgi?id=121898
14962         Reviewed by Chris Fleizach.
14964         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
14965         instead of { 0, { { 0 } } } to initialize a GValue.
14967         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
14968         (AccessibilityUIElement::clickPointX): Remove suffix.
14969         (AccessibilityUIElement::clickPointY): Ditto.
14970         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
14971         (AccessibilityUIElement::minValue): Ditto.
14972         (AccessibilityUIElement::maxValue): Ditto.
14973         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
14974         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
14975         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
14976         (WTR::AccessibilityUIElement::x): Ditto.
14977         (WTR::AccessibilityUIElement::y): Ditto.
14978         (WTR::AccessibilityUIElement::width): Ditto.
14979         (WTR::AccessibilityUIElement::height): Ditto.
14980         (WTR::AccessibilityUIElement::clickPointX): Ditto.
14981         (WTR::AccessibilityUIElement::clickPointY): Ditto.
14982         (WTR::AccessibilityUIElement::intValue): Ditto.
14983         (WTR::AccessibilityUIElement::minValue): Ditto.
14984         (WTR::AccessibilityUIElement::maxValue): Ditto.
14986 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
14988         [EFL] accessibility/loading-iframe-sends-notification.html is failing
14989         https://bugs.webkit.org/show_bug.cgi?id=112003
14991         Reviewed by Mario Sanchez Prada.
14993         Enabled addNotificationListener and removeNotificationListener for EFL port.
14995         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
14996         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
14997         (WTR::AccessibilityController::removeNotificationListener):
14999 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
15001         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
15002         https://bugs.webkit.org/show_bug.cgi?id=121844
15004         Reviewed by Mark Hahnenberg.
15006         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
15008 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
15010         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
15011         https://bugs.webkit.org/show_bug.cgi?id=121854
15013         Reviewed by Anders Carlsson.
15015         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
15016         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
15017         settings in underlying frameworks.
15019 2013-09-24  Mark Rowe  <mrowe@apple.com>
15021         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
15023         Reviewed by Dan Bernstein.
15025         * DumpRenderTree/mac/Configurations/Base.xcconfig:
15026         * MiniBrowser/Configurations/Base.xcconfig:
15027         * TestWebKitAPI/Configurations/Base.xcconfig:
15028         * WebKitLauncher/Configurations/Base.xcconfig:
15029         * WebKitTestRunner/Configurations/Base.xcconfig:
15031 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
15033         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
15034         https://bugs.webkit.org/show_bug.cgi?id=121674
15036         Reviewed by Mario Sanchez Prada.
15038         Implemented the global notification listener for
15039         AccessibilityController. The signal is generated by
15040         AXObjectCache::postPlatformNotification() and received by
15041         axObjectEventListener(). axObjectEventListener will then invoke
15042         JSObjectCallAsFunction() with the respective callback function.
15044         There is no additional test for this patch since its implementation will
15045         be tested by an accessibility layout test that is currently failing
15046         (accessibility/loading-iframe-sends-notification.html).
15048         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
15049         stub implementations of addNotificationListener and
15050         removeNotificationListener for the GTK port.
15051         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
15052         (WTR::AccessibilityController::addNotificationListener): Creates the
15053         notification handler and sets the notification function callback.
15054         (WTR::AccessibilityController::removeNotificationListener): Removes the
15055         global handler.
15057 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
15059         [GTK] fast/images/exif-orientation-composited.html is failing
15060         https://bugs.webkit.org/show_bug.cgi?id=119731
15062         Reviewed by Carlos Garcia Campos.
15064         Add handling respect image orientation property in DRT.
15066         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
15067         (TestRunner::overridePreference):
15069 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
15071         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
15072         https://bugs.webkit.org/show_bug.cgi?id=121787
15074         Reviewed by Gustavo Noronha Silva.
15076         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
15077         with the Wayland target enabled to version 3.10.0.
15079 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
15081         use NOMINMAX instead of #define min min
15082         https://bugs.webkit.org/show_bug.cgi?id=73563
15084         Reviewed by Brent Fulgham.
15086         Use NOMINMAX instead of #define min/max as a cleaner
15087         way of ensuring that Windows system header files don't
15088         define min/max as macro in the first place.
15090         * DumpRenderTree/DumpRenderTreePrefix.h:
15091         * DumpRenderTree/cg/ImageDiffCG.cpp:
15092         * DumpRenderTree/config.h:
15093         * DumpRenderTree/win/ImageDiffCairo.cpp:
15094         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
15095         * WebKitTestRunner/config.h:
15097 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
15099         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
15100         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
15102         Reviewed by Alexey Proskuryakov.
15104         Previously, initalizing a WebPreference would change the cache model
15105         to WebCacheModelDocumentBrowser. That behavior was due to a stale
15106         preference file on disk.
15108         This patch fixes the tests by resetting the default, and using the proper
15109         default values after initializing WebPreference.
15111         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
15112         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
15113         to the previous runs.
15115         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
15116         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
15117         cache model to the one required.
15119         * TestWebKitAPI/ios/mainIOS.mm:
15120         (main): Reset the preferences before testing.
15121         * TestWebKitAPI/mac/mainMac.mm:
15122         (main): Ditto.
15124 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
15126         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
15127         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
15129         Reviewed by Alexey Proskuryakov.
15131         Previously, initalizing a WebPreference would change the cache model
15132         to WebCacheModelDocumentBrowser. That behavior was due to a stale
15133         preference file on disk.
15135         This patch fixes the tests by resetting the default, and using the proper
15136         default values after initializing WebPreference.
15138         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
15139         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
15140         to the previous runs.
15142         * TestWebKitAPI/ios/mainIOS.mm:
15143         (main): Reset the preferences before testing.
15144         * TestWebKitAPI/mac/mainMac.mm:
15145         (main): Ditto.
15147 2013-09-23  Anders Carlsson  <andersca@apple.com>
15149         ListHashSet should work with move-only types
15150         https://bugs.webkit.org/show_bug.cgi?id=121802
15152         Reviewed by Andreas Kling.
15154         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
15155         (TestWebKitAPI::TEST):
15156         Add a test for move-only types.
15158 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
15160         Added --64-bit option for Windows build.
15161         https://bugs.webkit.org/show_bug.cgi?id=121799
15163         Reviewed by Brent Fulgham.
15165         * Scripts/webkitdirs.pm:
15166         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
15167         (isWin64): Added.
15168         (determineIsWin64): Added.
15170 2013-09-23  Anders Carlsson  <andersca@apple.com>
15172         ListHashSet should use std::reverse_iterator for reverse iterators
15173         https://bugs.webkit.org/show_bug.cgi?id=121795
15175         Reviewed by Antti Koivisto.
15177         Add test for reverse iterators.
15179         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
15180         (TestWebKitAPI::TEST):
15182 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
15184         [EFL] accessibility/aria-invalid is failing
15185         https://bugs.webkit.org/show_bug.cgi?id=111986
15187         Reviewed by Mario Sanchez Prada.
15189         Adds possibility to retrieve JS context.
15190         This is part of the implementation of AccessibilityUIElement::addNotificationListener
15191         from 119883 and 120421.
15193         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
15194         (axObjectEventListener):
15195         (addAccessibilityNotificationHandler):
15196         (removeAccessibilityNotificationHandler):
15197         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
15198         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
15199         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
15201 2013-09-20  Mark Rowe  <mrowe@apple.com>
15203         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
15205         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
15207         Reviewed by David Kilzer.
15209         * Scripts/webkitdirs.pm:
15210         (checkRequiredSystemConfig):
15212 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
15214         [ATK] Do not expose aria-help in ATK based platforms
15215         https://bugs.webkit.org/show_bug.cgi?id=121675
15217         Reviewed by Chris Fleizach.
15219         Remove the implementations for AccessibilityUIElement::helpText()
15220         from DRT and WKTR for GTK and EFL, since they are based on the
15221         AccessibilityObject::helpText() method and the 'aria-help'
15222         attributes, which is wrong since they should not depend on that
15223         but in ATK specific API (see also http://webkit.org/b/121684).
15225         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
15226         (AccessibilityUIElement::helpText): Added a new and empty
15227         implementation, now that we are no longer using this in ATK.
15228         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
15229         as the only function provided here was helpText().
15230         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
15231         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
15232         removed from the list of sources to compile.
15233         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
15234         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
15235         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
15236         based in DumpRenderTreeSupportGtk with an empty one.
15238 2013-09-20  Dan Bernstein  <mitz@apple.com>
15240         Make extract-localizable-strings available to WebCore clients
15241         https://bugs.webkit.org/show_bug.cgi?id=121699
15243         Reviewed by Darin Adler.
15245         * Scripts/extract-localizable-strings: Copied to
15246         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
15247         executes the script from its new location. This is a temporary measure until certain code
15248         that is external to WebKit is adapted to the new location.
15249         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
15250         from its new location.
15252 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
15254         Nuke remaining VS2005 tools from the tree.
15255         https://bugs.webkit.org/show_bug.cgi?id=121691
15257         Reviewed by Brent Fulgham.
15259         * CLWrapper/CLWrapper.cpp: Removed.
15260         * CLWrapper/CLWrapper.sln: Removed.
15261         * CLWrapper/CLWrapper.vcproj: Removed.
15262         * MIDLWrapper/MIDLWrapper.cpp: Removed.
15263         * MIDLWrapper/MIDLWrapper.sln: Removed.
15264         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
15265         * Scripts/parallelcl: Removed.
15266         * vcbin/cl.exe: Removed.
15267         * vcbin/midl.exe: Removed.
15269 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
15271         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
15272         https://bugs.webkit.org/show_bug.cgi?id=121294
15274         Reviewed by Martin Robinson.
15276         Provide a new patch to deal with the issue in the GTK+ module from
15277         the internal jhbuild environment. This issue has been reported
15278         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
15280         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
15281         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
15283 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
15285         [ATK][WTR] accessibility/aria-invalid.html times out
15286         https://bugs.webkit.org/show_bug.cgi?id=121668
15288         Reviewed by Mario Sanchez Prada.
15290         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
15291         false in case of aria-invalid event with empty value.
15293         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
15294         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
15295         case of aria-invalid event with empty value.
15297 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
15299         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
15300         https://bugs.webkit.org/show_bug.cgi?id=120421
15302         Reviewed by Mario Sanchez Prada.
15304         Implemented the notification listener for AccessibilityUIElement for
15305         WebKitTestRunner. The signal is generated by
15306         AXObjectCache::postPlatformNotification() and received by
15307         axObjectEventListener(). axObjectEventListener() will then invoke
15308         JSObjectCallAsFunction() with the respective callback function. The
15309         notification handlers are stored in HashMap in
15310         AccessibilityNotificationHandlerAtk.cpp.
15312         Moved ATK signal handling (printAccessibilityEvent and
15313         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
15315         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
15316         include path.
15317         * WebKitTestRunner/GNUmakefile.am:
15318         Added AccessibilityNotificationHandlerAtk.cpp/h.
15319         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
15320         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
15321         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
15322         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
15323         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
15324         notification handler for GTK+ and EFL.
15325         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
15326         Moved printAccessibilityEvent and axObjectEventListener to
15327         AccessibilityNotificationHandlerAtk.cpp.
15328         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
15329         IDs to AccessibilityNotificationHandlerAtk.cpp.
15330         (WTR::AccessibilityController::resetToConsistentState): Moved listener
15331         IDs to AccessibilityNotificationHandlerAtk.cpp.
15332         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
15333         (WTR::printAccessibilityEvent): Prints accessibility events. This
15334         function was moved from AccessibilityControllerAtk.cpp.
15335         (WTR::axObjectEventListener): Callback for signals. This function was
15336         moved from AccessibilityControllerAtk.cpp.
15337         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
15338         Initialize element and function callback.
15339         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
15340         Removes handler from HashMap and disconnects callbacks if necessary.
15341         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
15342         logging mode and connects callbacks.
15343         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
15344         Sets the notification callback and connects callback to signals.
15345         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
15346         Removes the notification callback from HashMap.
15347         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
15348         Connects axObjectEventListener to ATK signals.
15349         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
15350         Disconnects callback.
15351         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
15352         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
15353         of AccessibilityNotificationHandler.
15354         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
15355         element.
15356         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
15357         element.
15358         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
15359         Gets the notification callback.
15360         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
15361         (WTR::AccessibilityUIElement::addNotificationListener): Creates
15362         notification handler, set the platform element and the notification
15363         callback.
15364         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
15365         notification handler.
15366         * WebKitTestRunner/PlatformEfl.cmake:
15367         Added AccessibilityNotificationHandlerAtk.cpp.
15369 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
15371         Update features.pri
15372         https://bugs.webkit.org/show_bug.cgi?id=121670
15374         Reviewed by Jocelyn Turcotte.
15376         Remove feature flags that no longer exists and new ones added to FeatureList.pm
15378         * qmake/mkspecs/features/features.pri:
15380 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
15382         [GTK][WK2] accessibility/selection-states.html is failing
15383         https://bugs.webkit.org/show_bug.cgi?id=116972
15385         Reviewed by Mario Sanchez Prada.
15387         isSelectable() was not exposed in Accessibility.
15389         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
15391 2013-09-19  Dan Bernstein  <mitz@apple.com>
15393         Attempted build fix after r156114.
15395         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
15397 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
15399         REGRESSION (r129451): run-safari --no-saved-state is broken
15400         https://bugs.webkit.org/show_bug.cgi?id=121566
15402         Undo a last minute change that doesn't actually work.
15404         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
15405         via command line, <rdar://problem/15032886>.
15407 2013-09-19  Dan Bernstein  <mitz@apple.com>
15409         Add a style guideline regarding spacing in range-based for loops
15410         https://bugs.webkit.org/show_bug.cgi?id=121620
15412         Reviewed by Anders Carlsson.
15414         * Scripts/webkitpy/style/checkers/cpp.py:
15415         (check_spacing): Added checking that there are spaces around the colon in a range-based for
15416         loop.
15417         (CppChecker): Added whitespace/colon to the categories set.
15418         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
15419         (WebKitStyleTest.test_spacing): Added two tests for the new check.
15421 2013-09-18  Sam Weinig  <sam@webkit.org>
15423         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
15424         https://bugs.webkit.org/show_bug.cgi?id=121588
15426         Reviewed by Anders Carlsson.
15428         * DumpRenderTree/TestRunner.cpp:
15429         * ImageDiff/efl/ImageDiff.cpp:
15430         * TestWebKitAPI/JavaScriptTest.cpp:
15431         * TestWebKitAPI/PlatformUtilities.cpp:
15432         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
15433         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
15434         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
15435         * WebKitTestRunner/StringFunctions.h:
15436         * WebKitTestRunner/TestInvocation.cpp:
15437         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
15438         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
15440 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
15442         W3C Test Import script reformats test HTML
15443         https://bugs.webkit.org/show_bug.cgi?id=119159
15445         Reviewed by Dirk Pranke.
15447         Completely rewrite the test conversion process to minimize
15448         reformatting when adding prefixes, etc. This isn't 100% perfect, there
15449         are still places where it will end up changing the formatting, but it
15450         is much better than before. Most notably, the public interface to the
15451         test converter has changed: now one calls a method instead of creating
15452         an instance of the test converter class. This is because the test
15453         converter class now has state, so one really needs a new instance for
15454         each test.
15456         Note that this also lays some simple groundwork for being able to use
15457         a MockHost in the tests.
15459         * Scripts/webkitpy/w3c/test_converter.py:
15460         (convert_for_webkit):
15461         (_W3CTestConverter):
15462         (_W3CTestConverter.__init__):
15463         (_W3CTestConverter.output):
15464         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
15465         (_W3CTestConverter.convert_style_data):
15466         (_W3CTestConverter.convert_attributes_if_needed):
15467         (_W3CTestConverter.handle_starttag):
15468         (_W3CTestConverter.handle_endtag):
15469         (_W3CTestConverter.handle_startendtag):
15470         (_W3CTestConverter.handle_data):
15471         (_W3CTestConverter.handle_entityref):
15472         (_W3CTestConverter.handle_charref):
15473         (_W3CTestConverter.handle_comment):
15474         (_W3CTestConverter.handle_decl):
15475         (_W3CTestConverter.handle_pi):
15476         * Scripts/webkitpy/w3c/test_converter_unittest.py:
15477         (W3CTestConverterTest):
15478         (W3CTestConverterTest.fake_dir_path):
15479         (W3CTestConverterTest.test_read_prefixed_property_list):
15480         (verify_no_conversion_happened):
15481         * Scripts/webkitpy/w3c/test_importer.py:
15482         (TestImporter.import_tests):
15484 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
15486         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
15487         https://bugs.webkit.org/show_bug.cgi?id=121578
15489         Rubber stamped by Geoffrey Garen.
15491         * Scripts/run-layout-jsc:
15493 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
15495         Unreviewed, fix for Ruby 1.8.
15497         * Scripts/run-jsc-stress-tests:
15499 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
15501         run-jsc-stress-tests should make it easier to look at error spew from tests
15502         https://bugs.webkit.org/show_bug.cgi?id=121531
15504         Reviewed by Mark Hahnenberg.
15505         
15506         This makes two changes:
15507         
15508         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
15509         
15510         - The same spew also goes to the console but is prefixed by the test's name.
15511         
15512         This required some tee and awk hacks, and then some sh hacks to work around the fact
15513         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
15514         operator will only see a failure of bar failed. So to pass output to tee and awk, I
15515         needed to do weird things.
15517         * Scripts/run-jsc-stress-tests:
15519 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
15521         REGRESSION (r129451): run-safari --no-saved-state is broken
15522         https://bugs.webkit.org/show_bug.cgi?id=121566
15524         Reviewed by Mark Rowe.
15526         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
15527         Check arguments, not the newly created empty array. Pass a value that silences warnings.
15528         While at it, removed a check for Snow Leopard.
15530 2013-09-18  Alex Christensen  <achristensen@webkit.org>
15532         Improved WinLauncher's URL handling.
15533         https://bugs.webkit.org/show_bug.cgi?id=121535
15535         Reviewed by Brent Fulgham.
15537         * WinLauncher/WinLauncher.cpp:
15538         (EditProc):
15539         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
15540         (loadURL):
15541         Prepend "http://" to URLs with no scheme.
15543 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
15545         DFG should support Int52 for local variables
15546         https://bugs.webkit.org/show_bug.cgi?id=121064
15548         Reviewed by Oliver Hunt.
15550         * Scripts/run-jsc-stress-tests:
15552 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
15554         [Win] TestWebKitAPI does not compile.
15555         https://bugs.webkit.org/show_bug.cgi?id=121485
15557         Reviewed by Brent Fulgham.
15559         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
15560         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
15561         to return null, which is the case we want to test.
15563         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
15564         (TestWebKitAPI::TEST):
15566 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
15568         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
15569         https://bugs.webkit.org/show_bug.cgi?id=121495
15571         Reviewed by Chris Fleizach.
15573         Adapted DRT and WKTR to deal with the new names for the ATK object
15574         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
15576         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
15577         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
15578         (AccessibilityUIElement::stringAttributeValue): Ditto.
15579         (AccessibilityUIElement::hasPopup): Ditto.
15580         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
15581         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
15582         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
15583         (WTR::AccessibilityUIElement::hasPopup): Ditto.
15585 2013-09-18  Commit Queue  <commit-queue@webkit.org>
15587         Unreviewed, rolling out r156019 and r156020.
15588         http://trac.webkit.org/changeset/156019
15589         http://trac.webkit.org/changeset/156020
15590         https://bugs.webkit.org/show_bug.cgi?id=121540
15592         Broke tests (Requested by ap on #webkit).
15594         * Scripts/run-jsc-stress-tests:
15596 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
15598         Unreviewed. Add myself as a committer.
15600         * Scripts/webkitpy/common/config/contributors.json:
15602 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
15604         Unreviewed. Add myself as a committer.
15606         * Scripts/webkitpy/common/config/contributors.json:
15608 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
15610         DFG should support Int52 for local variables
15611         https://bugs.webkit.org/show_bug.cgi?id=121064
15613         Reviewed by Oliver Hunt.
15615         * Scripts/run-jsc-stress-tests:
15617 2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>
15619         Added back and forward buttons to WinLauncher.
15620         https://bugs.webkit.org/show_bug.cgi?id=121212
15622         Reviewed by Brent Fulgham.
15624         * WinLauncher/WinLauncher.cpp:
15625         (resizeSubViews):
15626         Move new back and forward buttons to correct positions before URL bar.
15627         (dllLauncherEntryPoint): 
15628         Store the default button window procedure and replace with my button procedures.
15629         (EditProc): Updated style and renamed from MyEditProc.
15630         (BackButtonProc): Added.
15631         (ForwardButtonProc): Added.
15633 2013-09-17  Michael Saboff  <msaboff@apple.com>
15635         Unreviewed typo fix after r155999
15637         Changed en_US.UTB-8 to en_US.UTF-8
15639         * Scripts/run-javascriptcore-tests:
15641 2013-09-17  Michael Saboff  <msaboff@apple.com>
15643         run-jsc-stress-tests fails with ruby version 2
15644         https://bugs.webkit.org/show_bug.cgi?id=121521
15646         Reviewed by Jessie Berlin.
15648         Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
15650         * Scripts/run-javascriptcore-tests:
15652 2013-09-17  Brent Fulgham  <bfulgham@apple.com>
15654         [Windows] Unreviewed build fix after r155963.
15656         * DumpRenderTree/win/TestRunnerWin.cpp:
15657         (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
15659 2013-09-17  Anders Carlsson  <andersca@apple.com>
15661         Fix a typo.
15663         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
15664         (TestWebKitAPI::TEST):
15666 2013-09-16  Anders Carlsson  <andersca@apple.com>
15668         HashMap should work with move-only keys
15669         https://bugs.webkit.org/show_bug.cgi?id=121310
15671         Reviewed by Darin Adler.
15673         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
15674         (TestWebKitAPI::TEST):
15675         Add test.
15677 2013-09-17  YuTeh Shen  <shenyute@hotmail.com>
15679         BrowserMarshal.h build fail
15680         https://bugs.webkit.org/show_bug.cgi?id=102938
15682         Reviewed by Carlos Garcia Campos.
15684         Fix variable name.
15686         * MiniBrowser/gtk/GNUmakefile.am:
15688 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
15690         [Windows] Clean up WinLauncher by using smart pointers
15691         https://bugs.webkit.org/show_bug.cgi?id=121467
15693         Reviewed by Anders Carlsson.
15695         * WinLauncher/PrintWebUIDelegate.cpp:
15696         (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
15697         * WinLauncher/WinLauncher.cpp:
15698         (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
15699         (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
15700         (showLastVisitedSites): Smart pointer updates.
15701         (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
15702         (setToDefaultPreferences): Ditto.
15703         (dllLauncherEntryPoint): Ditto.
15704         (PrintView): Ditto.
15705         (LaunchInspector): Ditto.
15706         (NavigateToHistory): Ditto.
15707         (MyEditProc): Ditto.
15708         (loadURL): Ditto.
15710 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
15712         [Windows] Add rudimentary history to WinLauncher.
15713         https://bugs.webkit.org/show_bug.cgi?id=121463
15715         Reviewed by Anders Carlsson.
15717         * WinLauncher/WinLauncher.cpp:
15718         (updateMenuItemForHistoryItem): Added
15719         (showLastVisitedSites): Added
15720         (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
15721         a new page has been visited.
15722         (dllLauncherEntryPoint): Deallocate history on exit.
15723         (NavigateToHistory): Added
15724         (WndProc): Add handler for history entries
15725         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
15726         up to 10 history slots.
15727         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
15728         Windows utility library to allow use of _bstr_t type.
15729         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
15730         to hold up to 10 history slots.
15731         * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
15733 2013-09-16  Gustavo Noronha Silva  <gns@gnome.org>
15735         [GTK] Make symbol export filter more strict, and disable for dev/test builds
15736         https://bugs.webkit.org/show_bug.cgi?id=120586
15738         Reviewed by Martin Robinson.
15740         * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
15741         makefiles, so they can be included unconditionally.
15742         * GtkLauncher/GNUmakefile.am: added.
15743         * Scripts/webkitdirs.pm:
15744         (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
15745         to configure, since we consider builds done through build-webkit to be development
15746         and test builds.
15747         * gtk/GNUmakefile.am: added.
15748         * gtk/common.py: do not use the Scripts directory as a reference to the top path;
15749         it's not necessary and it will not work now that the Scripts directory is not
15750         shipped in the tarball.
15752 2013-09-16  Anders Carlsson  <andersca@apple.com>
15754         WTF::Deque should work with move only types
15755         https://bugs.webkit.org/show_bug.cgi?id=121446
15757         Reviewed by Andreas Kling.
15759         * TestWebKitAPI/Tests/WTF/Deque.cpp:
15760         (TestWebKitAPI::TEST):
15761         Add a test.
15763 2013-09-16  Wojciech Bielawski  <w.bielawski@samsung.com>
15765         [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
15766         https://bugs.webkit.org/show_bug.cgi?id=98410
15768         Reviewed by Darin Adler.
15770         Add implementation of click() method of objects returned by eventSender.contextClick().
15772         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
15773         (MenuItemPrivateData):
15774         (WTR::menuItemClickCallback):
15775         (WTR::getMenuItemTitleCallback):
15776         (WTR::staticMenuItemFinalize):
15777         (WTR::getMenuItemClass):
15778         (WTR::EventSendingController::contextClick):
15780 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
15782         Make the GDB webkit.py script compatible with Python v3
15783         https://bugs.webkit.org/show_bug.cgi?id=121395
15785         Reviewed by Ryosuke Niwa.
15787         GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
15788         uses of xrange() in the script are replaced with range(), and the print statements are changed into
15789         the print() function invocations.
15791         * gdb/webkit.py:
15792         (guess_string_length):
15793         (ustring_to_string):
15794         (lstring_to_string):
15795         (WTFCStringPrinter.to_string):
15796         (PrintPathToRootCommand.invoke):
15798 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
15800         [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
15801         https://bugs.webkit.org/show_bug.cgi?id=119631
15803         Reviewed by Ryosuke Niwa.
15805         The perf profiler is attached to the test runner after the test runner has been launched,
15806         but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
15807         UIProcess, meaning that WebProcess operations will not be profiled.
15809         To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
15810         This is done in the scope of already present support for wrapper scripts (such as valgrind)
15811         that are settable through the --wrapper option. This causes the perf profiler to correctly
15812         continue profiling the WebProcess after it was spawned.
15814         When the profiler is launched, a wait process is launched with the profiler's pid as the
15815         argument. This ensures we can check that the profiler exited normally. If it did not, its
15816         output can be corrupted and can cause problems when that output is examined. The after-exit
15817         report is avoided in that case.
15819         * Scripts/webkitpy/common/system/profiler.py:
15820         (Profiler.wrapper_arguments): The method returns an empty list by default.
15821         (Perf.__init__): Remove unnecessary member variables.
15822         (Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
15823         (Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
15824         the method returns a list of arguments that should be used as a wrapper for the test runner.
15825         The arguments specify the 'perf record' command, with the output file and the instruction to
15826         construct the call graph given as well.
15827         (Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
15828         whitespace in the profile lines.
15829         (Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
15830         running. If it is running even after that, or if the profiler process produced a non-zero exit
15831         code, the method reports the profiling failure and returns. Otherwise it continues on reporting
15832         the top 10 lines of the profile and how to examine the profile further.
15833         * Scripts/webkitpy/port/driver.py:
15834         (Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
15835         as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
15836         or an empty list otherwise.
15837         (Driver.cmd_line):
15838         * Scripts/webkitpy/port/driver_unittest.py:
15839         (DriverTest.make_port): Adjusted so mock host or options objects can be specified
15840         for the testing-specific Port object.
15841         (DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
15842         as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
15843         a parameter.
15844         (DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
15845         when profiling on the Linux platform with the perf profiler.
15847 2013-09-14  Dan Bernstein  <mitz@apple.com>
15849         [mac] Check For Framework Include Consistency build phase checks the wrong framework
15850         https://bugs.webkit.org/show_bug.cgi?id=121215
15852         Reviewed by Mark Rowe.
15854         * Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
15855         WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
15856         public and private headers folder paths. Also tweaked the error messages’ format to make
15857         Xcode recognize them as errors.
15859 2013-09-14  Alberto Garcia  <berto@igalia.com>
15861         [GTK] Fails to compile if the build directory is in a different partition
15862         https://bugs.webkit.org/show_bug.cgi?id=121296
15864         Reviewed by Martin Robinson.
15866         Instead of using os.symlink() to install the gtk-doc templates,
15867         use os.link() first and fall back to os.symlink() if it fails.
15869         * gtk/gtkdoc.py:
15870         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
15872 2013-09-14  Alberto Garcia  <berto@igalia.com>
15874         [GTK] WebKitGTK+ is linking against libxslt in too many places
15875         https://bugs.webkit.org/show_bug.cgi?id=121356
15877         Reviewed by Martin Robinson.
15879         TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
15880         so we don't need to link against it.
15882         * MiniBrowser/gtk/GNUmakefile.am:
15883         * TestWebKitAPI/GNUmakefile.am:
15884         * WebKitTestRunner/GNUmakefile.am:
15886 2013-09-14  Ross Burton  <ross.burton@intel.com>
15888         Uses gtk-doc tools even when --disable-gtk-doc passed
15889         https://bugs.webkit.org/show_bug.cgi?id=91239
15891         Reviewed by Martin Robinson.
15893         Don't run generate-gtkdoc on install if gtk-doc is disabled.
15895         * GNUmakefile.am:
15897 2013-09-14  Alberto Garcia  <berto@igalia.com>
15899         [GTK] Fails to compile if the build directory is in a different partition
15900         https://bugs.webkit.org/show_bug.cgi?id=121296
15902         Reviewed by Carlos Garcia Campos.
15904         Use symlinks instead of hard links to support building on a
15905         different file system.
15907         * gtk/gtkdoc.py:
15908         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
15910 2013-09-13  Darin Adler  <darin@apple.com>
15912         Use a better name than m_invertibleCTM
15913         https://bugs.webkit.org/show_bug.cgi?id=121341
15915         Reviewed by Andreas Kling.
15917         * Scripts/do-webcore-rename: Updated to do this replace as we do.
15919 2013-09-13  Anders Carlsson  <andersca@apple.com>
15921         Pick the correct overload when a const reference is passed to appendSlowCase.
15922         https://bugs.webkit.org/show_bug.cgi?id=121326
15924         Reviewed by Darin Adler.
15926         * TestWebKitAPI/Tests/WTF/Vector.cpp:
15927         (TestWebKitAPI::TEST):
15929 2013-09-13  Darin Adler  <darin@apple.com>
15931         Rename confusingly named "runtimeObject" functions
15932         https://bugs.webkit.org/show_bug.cgi?id=121339
15934         Reviewed by Sam Weinig.
15936         * Scripts/do-webcore-rename: Updated to do this replace as usual.
15938 2013-09-13  Filip Pizlo  <fpizlo@apple.com>
15940         DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
15941         https://bugs.webkit.org/show_bug.cgi?id=121330
15943         Reviewed by Mark Hahnenberg and Oliver Hunt.
15945         We should run tests even if they don't have expected files yet.
15946         
15947         * Scripts/run-layout-jsc:
15949 2013-09-13  Anders Carlsson  <andersca@apple.com>
15951         Use nullptr instead of 0 in calls to HashMap::add
15952         https://bugs.webkit.org/show_bug.cgi?id=121322
15954         Reviewed by Sam Weinig.
15956         * DumpRenderTree/mac/TestRunnerMac.mm:
15957         (TestRunner::evaluateScriptInIsolatedWorld):
15958         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
15959         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
15961 2013-09-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
15963         [GTK] Move to the new web inspector
15964         https://bugs.webkit.org/show_bug.cgi?id=120647
15966         Reviewed by Carlos Garcia Campos.
15968         * GtkLauncher/main.c:
15969         (main): no longer set WEBKIT_INSPECTOR_PATH.
15970         * MiniBrowser/gtk/main.c:
15971         (main): ditto.
15972         * Scripts/old-run-webkit-tests:
15973         (openDumpTool): ditto.
15974         * Scripts/run-gtk-tests: ditto.
15975         * Scripts/webkitpy/port/gtk.py:
15976         (GtkPort.setup_environ_for_server): ditto.
15978 2013-09-13  Allan Sandfeld Jensen  <allan.jensen@digia.com>
15980         [Qt] REGRESSION(r154444): xss-DENIED test results changed
15981         https://bugs.webkit.org/show_bug.cgi?id=120595
15983         Reviewed by Jocelyn Turcotte.
15985         Avoid overwriting Qt meta properties, which we identify by them being undeletable.
15987         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
15988         (DumpRenderTree::initJSObjects):
15990 2013-09-13  Darin Adler  <darin@apple.com>
15992         Give actions in Range class NON_SHOUTING_NAMES
15993         https://bugs.webkit.org/show_bug.cgi?id=121280
15995         Reviewed by Andreas Kling.
15997         * Scripts/do-webcore-rename: Updated to do this replace, keeping with
15998         the tradition of checking in the last one we did, along with other
15999         rename ideas for the future.
16001 2013-09-12  Lucas Forschler  <lforschler@apple.com>
16003         Create short build logs for errors and warnings.
16004         https://bugs.webkit.org/show_bug.cgi?id=120614
16006         Reviewed by Ryosuke Niwa.
16008         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
16009             -include StringIO 
16010         (CompileWebKit.createSummary):
16011             -add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
16013 2013-09-12  Roger Fong  <roger_fong@apple.com>
16015         Update cygwin downloader to search for packages in the right location.
16017         * CygwinDownloader/cygwin-downloader.py:
16018         * CygwinDownloader/cygwin-downloader.zip:
16020 2013-09-12  Anders Carlsson  <andersca@apple.com>
16022         Add rudimentary support for move-only types as values in HashMap
16023         https://bugs.webkit.org/show_bug.cgi?id=121226
16025         Reviewed by Andreas Kling.
16027         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
16028         (TestWebKitAPI::TEST):
16029         Add a HashMap<unsigned, MoveOnly> test.
16031 2013-09-12  Gabor Abraham  <abrhm@inf.u-szeged.hu>
16033         Auto GDB backtrace generation for EFL/GTK/Qt bots.
16034         https://bugs.webkit.org/show_bug.cgi?id=119338
16036         Reviewed by Csaba Osztrogonác.
16038         * Scripts/webkitpy/port/efl.py:
16039         (EflPort.check_sys_deps):
16040         (EflPort):
16041         (EflPort._get_crash_log):
16042         * Scripts/webkitpy/port/efl_unittest.py:
16043         (EflPortTest.test_show_results_html_file):
16044         (EflPortTest):
16045         (EflPortTest.test_get_crash_log):
16046         * Scripts/webkitpy/port/gtk.py:
16047         (GtkPort._get_crash_log):
16048         * Scripts/webkitpy/port/gtk_unittest.py:
16049         (GtkPortTest.test_get_crash_log):
16050         * Scripts/webkitpy/port/linux_get_crash_log.py: Added.
16051         (GDBCrashLogGenerator):
16052         (GDBCrashLogGenerator.__init__):
16053         (GDBCrashLogGenerator._get_gdb_output):
16054         (GDBCrashLogGenerator.generate_crash_log):
16055         (GDBCrashLogGenerator.generate_crash_log.match_filename):
16056         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
16057         (GDBCrashLogGeneratorTest):
16058         (GDBCrashLogGeneratorTest.test_generate_crash_log):
16059         (_mock_gdb_output):
16060         * Scripts/webkitpy/port/qt.py:
16061         (QtPort.default_child_processes):
16062         (QtPort):
16063         (QtPort._get_crash_log):
16064         * Scripts/webkitpy/port/qt_unittest.py:
16065         (QtPortTest.test_check_sys_deps):
16066         (QtPortTest):
16067         (QtPortTest.test_get_crash_log):
16069 2013-09-12  Peter Gal  <galpeter@inf.u-szeged.hu>
16071         Unreviewed. Moving myself to the commiters list.
16073         * Scripts/webkitpy/common/config/contributors.json:
16075 2013-09-12  ChangSeok Oh  <changseok.oh@collabora.com>
16077         [GTK] Add jhbuild-wayland.modules
16078         https://bugs.webkit.org/show_bug.cgi?id=120455
16080         Reviewed by Gustavo Noronha Silva.
16082         Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
16083         With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
16084         WEBKIT_EXTRA_MODULESETS.
16086         * gtk/jhbuild-wayland.modules: Added.
16088 2013-09-12  Mario Sanchez Prada  <mario.prada@samsung.com>
16090         [GTK][WK2] a11y tests unconditionally launching a11y daemons
16091         https://bugs.webkit.org/show_bug.cgi?id=120299
16093         Reviewed by Carlos Garcia Campos.
16095         Use the right variable name to store a reference to the at-spi2
16096         bus launcher process, so we can be sure we are terminating it when
16097         calling _tear_down_testing_environment().
16099         * Scripts/run-gtk-tests:
16100         (TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
16101         instead of _ally_bus_launcher.
16103 2013-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
16105         [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
16106         https://bugs.webkit.org/show_bug.cgi?id=121218
16108         Reviewed by Philippe Normand.
16110         Skipping the entire suite was added to skip tests when they can't
16111         be run because of the environment, for example to skip the a11y
16112         tests when the at-spi daemons fail to start. This is no longer
16113         true for all the cases, so we can disable the tests that are
16114         impossible to run instead of skipping them.
16116         * Scripts/run-gtk-tests:
16117         (TestRunner.__init__): Initialize the skipped tests list.
16118         (TestRunner._setup_testing_environment): Add
16119         TestWebKitAccessibility path to the list of disabled tests when
16120         at-spi daemon fail to start.
16121         (TestRunner._should_run_test_program): Check first if the test
16122         program is disabled and then whether it's skipped honoring the
16123         skipped command line option.
16125 2013-09-12  Samuel White  <samuel_white@apple.com>
16127         <meter> element text value exposed as AXTitle; should be exposing AXValueDescription
16128         https://bugs.webkit.org/show_bug.cgi?id=117651
16130         Reviewed by Mario Sanchez Prada.
16132         Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.
16134         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
16135         (AccessibilityUIElement::valueDescription):
16136         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
16137         (WTR::AccessibilityUIElement::valueDescription):
16139 2013-09-12  Denis Nomiyama  <d.nomiyama@samsung.com>
16141         REGRESSION(r154781): accessibility/notification-listeners.html is failing
16142         https://bugs.webkit.org/show_bug.cgi?id=120669
16144         Reviewed by Chris Fleizach.
16146         Fixed 4 problems that were causing notification-listeners.html to fail.
16148         Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
16149         implemented in axObjectEventListener().
16151         A notification for AXFocusedUIElementChanged was incorrectly sent when
16152         the element lost focus.
16154         Global notification was not dispatched if an element notification was
16155         present in the HashMap.
16157         connectAccessibilityCallbacks() was connecting signals to callbacks
16158         multiple times because it was not checking if
16159         disconnectAccessibilityCallbacks() had an early return if there were
16160         active handlers.
16162         * DumpRenderTree/atk/AccessibilityCallbacks.h: Modified
16163         disconnectAccessibilityCallbacks() to inform if the callbacks were
16164         successfully disconnected.
16165         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
16166         (axObjectEventListener): Implemented notifications for
16167         AXFocusedUIElementChanged and AXValueChanged. Fixed the global
16168         notification, which was not dispatched if an element notification
16169         existed. Fixed the notification for AXFocusedUIElementChanged that was
16170         incorrectly sent when the element lost focus. In addition, fixed a typo
16171         where TRUE should be true.
16172         (connectAccessibilityCallbacks): Added early return if
16173         disconnectAccessibilityCallbacks() did not disconnect the callbacks.
16174         (disconnectAccessibilityCallbacks): Added a return value to inform if
16175         callbacks were successfully disconnected.
16177 2013-09-11  Anders Carlsson  <andersca@apple.com>
16179         Try to fix GCC builds.
16181         * TestWebKitAPI/Tests/WTF/MoveOnly.h:
16183 2013-09-11  Anders Carlsson  <andersca@apple.com>
16185         Try to fix the build.
16187         Move MoveOnly.h to Tests/WTF and fix the broken Xcode project that caused me to add the header
16188         file in the Tests/ directory in the first place.
16190         * TestWebKitAPI/CMakeLists.txt:
16191         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
16192         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
16193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16194         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Renamed from Tools/TestWebKitAPI/Tests/MoveOnly.h.
16196 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
16198         [Windows] Build fix for MoveOnly
16200         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Add
16201         Tests to include search path.
16202         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
16203         Ditto.
16205 2013-09-11  Anders Carlsson  <andersca@apple.com>
16207         Add HashSet::take
16208         https://bugs.webkit.org/show_bug.cgi?id=121192
16210         Reviewed by Darin Adler.
16212         Add a test for HashSet::take.
16214         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
16215         (TestWebKitAPI::TEST):
16217 2013-09-11  Anders Carlsson  <andersca@apple.com>
16219         HashSet should work with move only types
16220         https://bugs.webkit.org/show_bug.cgi?id=121188
16222         Reviewed by Geoffrey Garen.
16224         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16225         * TestWebKitAPI/Tests/MoveOnly.h: Added.
16226         Move the MoveOnly class from Vector out into its own header.
16228         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
16229         (TestWebKitAPI::TEST):
16230         Add aHashSet<MoveOnly> test.
16232         * TestWebKitAPI/Tests/WTF/Vector.cpp:
16233         Include MoveOnly.h.
16235 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
16237         [Windows] Avoid converting from IntSize->SIZE->IntSize
16238         https://bugs.webkit.org/show_bug.cgi?id=121180
16240         Reviewed by Anders Carlsson.
16242         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
16243         (TestWebKitAPI::TEST): Use IntSize instead of SIZE struct.
16245 2013-09-11  Dan Bernstein  <mitz@apple.com>
16247         REGRESSION (r155561): extract-localizable-strings can miss strings
16248         https://bugs.webkit.org/show_bug.cgi?id=121184
16250         Reviewed by Darin Adler.
16252         * Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing
16253         parenthesis or bracket.
16255 2013-09-11  Dan Bernstein  <mitz@apple.com>
16257         update-webkit-localizable-strings is at least 5.8x slower than it should be
16258         https://bugs.webkit.org/show_bug.cgi?id=121178
16260         Reviewed by Darin Adler.
16262         * Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.
16263         Note that this does not change functionality, because the script already does not understand
16264         the line continuation sequence (backslash followed by a newline).
16266 2013-09-11  Anders Carlsson  <andersca@apple.com>
16268         Vector::append doesn't work if element type has overloaded operator&
16269         https://bugs.webkit.org/show_bug.cgi?id=121175
16271         Reviewed by Brent Fulgham.
16273         Add a test case.
16275         * TestWebKitAPI/Tests/WTF/Vector.cpp:
16276         (TestWebKitAPI::TEST):
16278 2013-09-11  Anders Carlsson  <andersca@apple.com>
16280         Implement Vector::append for move-only types
16281         https://bugs.webkit.org/show_bug.cgi?id=120805
16283         Reviewed by Sam Weinig.
16285         Add a test for Vector<MoveOnly>::append.
16287         * TestWebKitAPI/Tests/WTF/Vector.cpp:
16288         (TestWebKitAPI::TEST):
16290 2013-09-11  Csaba Osztrogonác  <ossy@webkit.org>
16292         Unreviewed. Fix the indentation after r105848. Typo fix after r155523.
16294         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
16295         (RunAndUploadPerfTests):
16296         (RunAndUploadPerfTests.start):
16297         (RunAndUploadPerfTests.getText2):
16299 2013-09-11  Anders Carlsson  <andersca@apple.com>
16301         The style checker shouldn't complain about returning or passing OwnPtr
16302         https://bugs.webkit.org/show_bug.cgi?id=121163
16304         Reviewed by Antti Koivisto.
16306         * Scripts/webkitpy/style/checkers/cpp.py:
16307         (check_function_definition_and_pass_ptr):
16308         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
16309         (PassPtrTest.test_pass_ref_ptr_return_value):
16310         (PassPtrTest.test_own_ptr_parameter_value):
16312 2013-09-11  Mario Sanchez Prada  <mario.prada@samsung.com>
16314         [GTK] Remove Gail dependency from build system for GTK3
16315         https://bugs.webkit.org/show_bug.cgi?id=119673
16317         Reviewed by Gustavo Noronha Silva.
16319         * EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
16320         * Scripts/webkitpy/port/gtk.py:
16321         (GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
16322         * TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
16324 2013-09-11  Gabor Abraham  <abrhm@inf.u-szeged.hu>
16326         Performance tester bots should report the number of failing tests
16327         https://bugs.webkit.org/show_bug.cgi?id=120462
16329         Reviewed by Csaba Osztrogonác.
16331         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
16332         (RunAndUploadPerfTests.start.getText):
16333         (RunAndUploadPerfTests.start):
16334         (RunAndUploadPerfTests):
16335         (RunAndUploadPerfTests.start.getText2):
16337 2013-09-11  Krzysztof Czech  <k.czech@samsung.com>
16339         [ATK] Adds mapping MenuItemRadioRole to ATK
16340         https://bugs.webkit.org/show_bug.cgi?id=121149
16342         Reviewed by Mario Sanchez Prada.
16344         Adds mapping MenuItemRadioRole to ATK.
16346         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
16347         (roleToString):
16348         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
16349         (WTR::roleToString):
16351 2013-09-10  Csaba Osztrogonác  <ossy@webkit.org>
16353         Unreviewed fix after the unreviewed r155498 to unbreak the failure
16354         counter of run-javascriptcore-tests build step on build.webkit.org.
16356         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
16357         (RunJavaScriptCoreTests.commandComplete):
16358         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
16360 2013-09-10  Filip Pizlo  <fpizlo@apple.com>
16362         Unreviewed, be a bit more clear about what we mean by 'js' tests. I think this
16363         got a bit overlooked from the fast/js->js refactoring.
16365         * Scripts/run-javascriptcore-tests:
16367 2013-09-10  Daniel Bates  <dabates@apple.com>
16369         [iOS] Upstream text autosizing
16370         https://bugs.webkit.org/show_bug.cgi?id=121111
16372         Reviewed by Andy Estes and Sam Weinig.
16374         Implement infrastructure to test the iOS text autosizing code.
16376         * DumpRenderTree/TestRunner.cpp:
16377         (setTextAutosizingEnabledCallback): Added.
16378         (TestRunner::staticFunctions):
16379         * DumpRenderTree/TestRunner.h:
16380         * DumpRenderTree/mac/DumpRenderTree.mm:
16381         (resetDefaultsToConsistentValues):
16382         * DumpRenderTree/mac/TestRunnerMac.mm:
16383         (TestRunner::setTextAutosizingEnabled): Added.
16385 2013-09-10  Mark Hahnenberg  <mhahnenberg@apple.com>
16387         run-jsc-stress-tests should have a mode for always running the copy phase
16388         https://bugs.webkit.org/show_bug.cgi?id=121128
16390         Reviewed by Geoffrey Garen.
16392         This will increase test coverage of the copying phase, which might not always get 
16393         triggered normally with our default parameters for required Heap/CopiedBlock utilization.
16395         * Scripts/run-jsc-stress-tests:
16397 2013-09-10  Sergio Correia  <sergio.correia@openbossa.org>
16399         [EFL][JHBUILD] Use a tarball for libseccomp, instead of git
16400         https://bugs.webkit.org/show_bug.cgi?id=121114
16402         Reviewed by Christophe Dumez.
16404         Use a tarball for libseccomp instead of git to avoid network issues on
16405         the buildbots while checking out the git repo. Using tarballs has the
16406         advantage of them being cached if the checksum matches, in which case
16407         there will be no need to download them again.
16409         * efl/jhbuild.modules:
16411 2013-09-10  Mark Lam  <mark.lam@apple.com>
16413         Replace remaining "fast js" names in scripts.
16414         https://bugs.webkit.org/show_bug.cgi?id=120899.
16416         Rubber stamped by Filip Pizlo.
16418         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
16419         (test_layout_failure_new_output):
16420         (test_layout_crash_new_output):
16421         (test_mozilla_and_layout_failure_new_output):
16422         * Scripts/run-fast-jsc: Removed.
16423         * Scripts/run-javascriptcore-tests:
16424         * Scripts/run-layout-jsc: Copied from Tools/Scripts/run-fast-jsc.
16426 2013-09-10  Zan Dobersek  <zdobersek@igalia.com>
16428         Enable JSC stress tests for the rest of non-Windows platforms
16429         https://bugs.webkit.org/show_bug.cgi?id=121021
16431         Reviewed by Filip Pizlo.
16433         The JSC stress tests can already be enabled on Linux-based ports.
16435         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
16436         (RunJavaScriptCoreTests.commandComplete): Reformulate the regular expressions used to find the number of regressed
16437         JSC tests of various test suites. The expressions now look for the suite-specific report compartment over the
16438         complete output, with the number of failing or crashing tests properly extracted.
16439         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a couple of unit tests and expand the tested
16440         output in other unit tests testing the parsing of the output in the new format.
16441         (test_jsc_stress_failure_new_output):
16442         (test_fast_js_crashes_and_jsc_stress_failures_new_output):
16443         * Scripts/run-javascriptcore-tests: Enable the JSC stress tests on all but the Apple Win port.
16444         * Scripts/run-jsc-stress-tests: `sysctl -n hw.availcpu` doesn't work on Linux-based ports but the numProcesses
16445         variable is still gracefully assigned a zero value. In that case, try running `nproc --all` to gather the number
16446         of available CPUs so the stress tests can be run in parallel.
16448 2013-09-10  Chris Fleizach  <cfleizach@apple.com>
16450         AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
16451         https://bugs.webkit.org/show_bug.cgi?id=120552
16453         Unreviewed build fix.
16455         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
16456         (AccessibilityUIElement::classList):
16458 2013-09-10  Chris Fleizach  <cfleizach@apple.com>
16460         AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
16461         https://bugs.webkit.org/show_bug.cgi?id=120552
16463         Reviewed by Darin Adler.
16465         * DumpRenderTree/AccessibilityUIElement.cpp:
16466         (getClassListCallback):
16467         (AccessibilityUIElement::getJSClass):
16468         * DumpRenderTree/AccessibilityUIElement.h:
16469         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
16470         (AccessibilityUIElement::classList):
16471         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
16472         (AccessibilityUIElement::classList):
16473         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
16474         (AccessibilityUIElement::classList):
16475         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
16476         (AccessibilityUIElement::classList):
16477         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
16478         (WTR::AccessibilityUIElement::classList):
16479         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
16480         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
16481         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
16482         (WTR::AccessibilityUIElement::classList):
16483         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
16484         (WTR::AccessibilityUIElement::classList):
16486 2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
16488         [GTK] accessibility/loading-iframe-sends-notification.html is failing
16489         https://bugs.webkit.org/show_bug.cgi?id=98370
16491         Reviewed by Chris Fleizach.
16493         Added AXLayoutComplete for the GTK platform.
16495         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
16496         (axObjectEventListener): Added notification AXLayoutComplete for
16497         layout-complete signal.
16499 2013-09-09  Brent Fulgham  <bfulgham@apple.com>
16501         [Windows] Change from using OwnPtr<GDI Stuff> to new GDIObject.
16502         https://bugs.webkit.org/show_bug.cgi?id=120778
16504         Reviewed by Anders Carlsson.
16506         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
16507         (createBitmapContextFromWebView): Use GDIObject.
16508         * Scripts/webkitpy/style/checkers/cpp.py:
16509         (check_for_leaky_patterns): Update for GDIObject instead of adoptPtr and OwnPtr.
16510         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
16511         (LeakyPatternTest.test_create_dc): Update for GDIObject instead of adoptPtr/OwnPtr.
16512         (LeakyPatternTest.test_create_compatible_dc): Ditto.
16514 2013-09-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
16516         Unreviewed. Add myself as a committer.
16518         * Scripts/webkitpy/common/config/contributors.json:
16520 2013-09-10  Mark Lam  <mark.lam@apple.com>
16522         Move LayoutTests/fast/js to LayoutTests/js.
16523         https://bugs.webkit.org/show_bug.cgi?id=120899.
16525         Rubber stamped by Filip Pizlo.
16527         Changed scripts to reflect the path change.
16529         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
16530         (RunJavaScriptCoreTests.commandComplete):
16531         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
16532         (test_fast_js_failure_new_output):
16533         (test_fast_js_crash_new_output):
16534         (test_mozilla_and_fast_js_failure_new_output):
16535         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
16536         (BlackBerry::WebKit::DumpRenderTree::runTests):
16537         * Scripts/make-script-test-wrappers:
16538         (findTemplateFiles):
16539         * Scripts/run-fast-jsc:
16540         * Scripts/run-javascriptcore-tests:
16541         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
16542         (TestExpectations):
16544 2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
16546         [GTK] Missing DRT AccessibilityController::addNotificationListener implementation
16547         https://bugs.webkit.org/show_bug.cgi?id=70606
16549         Reviewed by Mario Sanchez Prada.
16551         Implemented the global notification listener for
16552         AccessibilityController. The signal is generated by
16553         AXObjectCache::postPlatformNotification() and received by
16554         axObjectEventListener(). axObjectEventListener will then invoke
16555         JSObjectCallAsFunction() with the respective callback function.
16557         There is no additional test for this patch since its implementation will
16558         be tested by a11y layout tests that are currently skipped (e.g. bug
16559         98370).
16561         * DumpRenderTree/AccessibilityController.h: Added a global notification
16562         handler for GTK+.
16563         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
16564         (AccessibilityController::AccessibilityController): Initializes the
16565         global handler with 0.
16566         (AccessibilityController::addNotificationListener): Creates the
16567         notification handler and sets the notification function callback.
16568         (AccessibilityController::removeNotificationListener): Removes the
16569         global handler.
16571 2013-09-10  Krzysztof Czech  <k.czech@samsung.com>
16573         [ATK] Incorrect type for holding float value
16574         https://bugs.webkit.org/show_bug.cgi?id=121091
16576         Reviewed by Mario Sanchez Prada.
16578         Variable is not set properly, because of it's type.
16580         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
16581         (WTR::alterCurrentValue):
16583 2013-09-10  Allan Sandfeld Jensen  <allan.jensen@digia.com>
16585         [Qt] make use of qtHaveModule() 
16586         https://bugs.webkit.org/show_bug.cgi?id=121090
16588         Reviewed by Jocelyn Turcotte.
16589         Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com>
16591         Use qtHaveModule instead of our own haveQtModule.
16593         * QtTestBrowser/QtTestBrowser.pro:
16594         * qmake/mkspecs/features/configure.prf:
16595         * qmake/mkspecs/features/features.prf:
16596         * qmake/mkspecs/features/functions.prf:
16598 2013-09-10  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
16600         Unreviewed. Add myself as a committer.
16602         * Scripts/webkitpy/common/config/contributors.json:
16604 2013-09-10  Radu Stavila  <stavila@adobe.com>
16606         Unreviewed. Added myself as a committer.
16608         * Scripts/webkitpy/common/config/contributors.json:
16610 2013-09-10  Mario Sanchez Prada  <mario.prada@samsung.com>
16612         [GTK] Test /webkit/atk/getTextInParagraphAndBodyModerate fails
16613         https://bugs.webkit.org/show_bug.cgi?id=105538
16615         Reviewed by Chris Fleizach.
16617         Unskip passing test getTextInParagraphAndBodyModerate.
16619         * Scripts/run-gtk-tests:
16620         (TestRunner): Unskip pasing test.
16622 2013-09-09  Mark Lam  <mark.lam@apple.com>
16624         Remove more references to the deleted js-test-style.css.
16625         https://bugs.webkit.org/show_bug.cgi?id=120899.
16627         Reviewed by Ryosuke Niwa.
16629         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
16630         (translate_includes):
16632 2013-09-09  Mark Lam  <mark.lam@apple.com>
16634         Re-landing r155392 (Point Tools scripts to LayoutTests/resources).
16635         https://bugs.webkit.org/show_bug.cgi?id=120899.
16637         Not reviewed.
16639         The webkitpy test failure that resulted in the rollout is due to
16640         update_webgl_conformance_tests_unittest.py referencing js-test-style.css
16641         which is to be deleted. Deleting that line fixes the issue.
16643         * Scripts/make-new-script-test:
16644         (makePathToSharedSources):
16645         * Scripts/run-fast-jsc:
16646         * Scripts/webkitperl/httpd.pm:
16647         (getDefaultConfigForTestDirectory):
16648         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
16649         (LayoutTestApacheHttpd.__init__):
16650         * Scripts/webkitpy/layout_tests/servers/http_server.py:
16651         (Lighttpd.__init__):
16652         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
16653         (BaseTest.integration_test_port_and_root):
16654         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
16655         (TestHttpServer.test_start_cmd):
16656         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
16657         (translate_includes):
16658         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
16659         (TestTranslation.test_include_rewriting):
16661 2013-09-09  Mark Lam  <mark.lam@apple.com>
16663         Rolling out r155392 (Point Tools scripts to LayoutTests/resources): breaks tests.
16664         https://bugs.webkit.org/show_bug.cgi?id=120899.
16666         Not reviewed.
16668         * Scripts/make-new-script-test:
16669         (makePathToSharedSources):
16670         * Scripts/run-fast-jsc:
16671         * Scripts/webkitperl/httpd.pm:
16672         (getDefaultConfigForTestDirectory):
16673         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
16674         (LayoutTestApacheHttpd.__init__):
16675         * Scripts/webkitpy/layout_tests/servers/http_server.py:
16676         (Lighttpd.__init__):
16677         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
16678         (BaseTest.integration_test_port_and_root):
16679         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
16680         (TestHttpServer.test_start_cmd):
16681         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
16682         (translate_includes):
16683         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
16684         (TestTranslation.test_include_rewriting):
16686 2013-09-09  Mark Lam  <mark.lam@apple.com>
16688         Point Tools scripts to LayoutTests/resources.
16689         https://bugs.webkit.org/show_bug.cgi?id=120899.
16691         Reviewed by Ryosuke Niwa.
16693         * Scripts/make-new-script-test:
16694         (makePathToSharedSources):
16695         * Scripts/run-fast-jsc:
16696         * Scripts/webkitperl/httpd.pm:
16697         (getDefaultConfigForTestDirectory):
16698         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
16699         (LayoutTestApacheHttpd.__init__):
16700         * Scripts/webkitpy/layout_tests/servers/http_server.py:
16701         (Lighttpd.__init__):
16702         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
16703         (BaseTest.integration_test_port_and_root):
16704         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
16705         (TestHttpServer.test_start_cmd):
16706         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
16707         (translate_includes):
16708         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
16709         (TestTranslation.test_include_rewriting):
16711 2013-09-09  Roger Fong  <roger_fong@apple.com>
16713         Unreviewed. Update Cygwin Downloader to include lighttpd and download setup-x86.exe.
16715         * CygwinDownloader/cygwin-downloader.py:
16716         * CygwinDownloader/cygwin-downloader.zip:
16718 2013-09-09  Filip Pizlo  <fpizlo@apple.com>
16720         Unreviewed, fix Ruby exception handling.
16722         * Scripts/run-jsc-stress-tests:
16724 2013-09-09  Filip Pizlo  <fpizlo@apple.com>
16726         Stress tests should test the jsc profiler (-p)
16727         https://bugs.webkit.org/show_bug.cgi?id=121043
16729         Reviewed by Mark Hahnenberg.
16730         
16731         Add a runProfiler command that all tests could use. This requires profiler-test-helper,
16732         which first runs the JS test and then tries the output with display-profiler-output.
16733         But if any of the things required for this to work aren't present, we just do a simpler
16734         test that just uses "-p".
16735         
16736         Because I didn't want to pollute SunSpider with "//@ runProfiler", I added the ability
16737         to create test collections using a yaml file that specifies the test path and the
16738         command to run.
16740         * Scripts/jsc-stress-test-helpers: Added.
16741         * Scripts/jsc-stress-test-helpers/profiler-test-helper: Added.
16742         * Scripts/run-javascriptcore-tests:
16743         * Scripts/run-jsc-stress-tests:
16745 2013-09-09  Zan Dobersek  <zdobersek@igalia.com>
16747         [webkitpy] Remove the DeprecatedPort class
16748         https://bugs.webkit.org/show_bug.cgi?id=121030
16750         Reviewed by Ryosuke Niwa.
16752         Remove the remaining uses of DeprecatedPort, folding its functionality into the Port class.
16754         The various methods returning commands are moved from the DeprecatedPort class into the Port class,
16755         with the Port subclasses overriding specific methods as required.
16757         * Scripts/webkitpy/common/config/ports.py: Removed.
16758         * Scripts/webkitpy/common/config/ports_mock.py: Removed.
16759         * Scripts/webkitpy/common/config/ports_unittest.py: Removed.
16760         * Scripts/webkitpy/port/base.py:
16761         (Port.tooling_flag): This method returns the command line argument that corresponds to the type of the port.
16762         It's formatted as '--port=port_name', where port_name is the port's name that's additionally appended the '-wk2'
16763         string if the port instance represents the WK2 variation of the port.
16764         (Port.script_shell_command): Moved here from the DeprecatedPort interface.
16765         (Port.make_args): Ditto.
16766         (Port.update_webkit_command): Ditto.
16767         (Port.check_webkit_style_command): Ditto.
16768         (Port.prepare_changelog_command): Ditto.
16769         (Port.build_webkit_command): Ditto.
16770         (Port.run_javascriptcore_tests_command): Ditto.
16771         (Port.run_webkit_unit_tests_command): Ditto.
16772         (Port.run_webkit_tests_command): Ditto.
16773         (Port.run_python_unittests_command): Ditto.
16774         (Port.run_perl_unittests_command): Ditto.
16775         (Port.run_bindings_tests_command): Ditto.
16776         * Scripts/webkitpy/port/base_unittest.py:
16777         (PortTest.test_build_webkit_command): Add a test for the Port.build_webkit_command() method that tests correct
16778         return value with different build types passed to the method.
16779         * Scripts/webkitpy/port/efl.py:
16780         (EflPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
16781         to the command line.
16782         * Scripts/webkitpy/port/efl_unittest.py:
16783         (EflPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
16784         variations of the EflPort class.
16785         * Scripts/webkitpy/port/gtk.py:
16786         (GtkPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
16787         to the command line.
16788         (GtkPort.run_webkit_tests_command): Ditto for Port.run_webkit_tests_command().
16789         * Scripts/webkitpy/port/gtk_unittest.py:
16790         (GtkPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1
16791         and WK2 variations of the GtkPort class.
16792         * Scripts/webkitpy/port/mac_unittest.py:
16793         (MacTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
16794         variations of the MacPort class.
16795         * Scripts/webkitpy/port/qt.py:
16796         (QtPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
16797         to the command line.
16798         (QtPort.run_webkit_tests_command): Ditto for Port.run_webkit_tests_command().
16799         * Scripts/webkitpy/port/qt_unittest.py:
16800         (QtPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
16801         variations of the QtPort class.
16802         * Scripts/webkitpy/port/test.py:
16803         (TestPort.make_args): Return a mock value that's intended for testing.
16804         (TestPort.check_webkit_style_command): Return the script's name prepended with 'mock-'.
16805         (TestPort.update_webkit_command): Ditto.
16806         (TestPort.build_webkit_command): Ditto.
16807         (TestPort.prepare_changelog_command): Ditto.
16808         (TestPort.run_python_unittests_command): Ditto.
16809         (TestPort.run_perl_unittests_command): Ditto.
16810         (TestPort.run_javascriptcore_tests_command): Ditto.
16811         (TestPort.run_webkit_unit_tests_command): Ditto.
16812         (TestPort.run_webkit_tests_command): Ditto.
16813         (TestPort.run_bindings_tests_command): Ditto.
16814         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
16815         (FlakyTestReporter.__init__): WebKitPatch.port() should be called now.
16816         * Scripts/webkitpy/tool/bot/irc_command.py:
16817         (Rollout._update_working_copy): Ditto.
16818         * Scripts/webkitpy/tool/commands/download_unittest.py:
16819         (DownloadCommandsTest.test_land_cowhand): Fix a typo, javacriptcore -> javascriptcore.
16820         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
16821         (AbstractEarlyWarningSystem.run_command): Use the tooling flag as provided by the Port interface.
16822         * Scripts/webkitpy/tool/commands/queues.py:
16823         (PatchProcessingQueue.begin_work_queue): Remove the use of the DeprecatedPort. Create the port that will be used
16824         by the PatchProcessingQueue through the tool's port factory, and also pass it to the tool, keeping the nasty
16825         abstraction violation.
16826         (CommitQueue.run_command): Use the tooling flag as provided by the Port interface.
16827         * Scripts/webkitpy/tool/main.py:
16828         (WebKitPatch.__init__): self._deprecated_port -> self._port.
16829         (WebKitPatch.port): Replaces the WebKitPatch.deprecated_port() method, returns self._port.
16830         (WebKitPatch.handle_global_options): Create the Port object through the PortFactory.
16831         * Scripts/webkitpy/tool/mocktool.py:
16832         (MockTool.__init__): self._deprecated_port -> self._port. The TestPort object also has its name method overridden
16833         to return 'MockPort', as many output comparisons rely on the MockPort name. These should all be replaced later, in
16834         a separate patch.
16835         (MockTool.port): Mimicks WebKitPatch.port().
16836         * Scripts/webkitpy/tool/steps/build.py:
16837         (Build.build): WebKitPatch.port() should be called now.
16838         * Scripts/webkitpy/tool/steps/checkstyle.py:
16839         (CheckStyle.run): Ditto.
16840         * Scripts/webkitpy/tool/steps/commit.py:
16841         (Commit._check_test_expectations): Ditto.
16842         * Scripts/webkitpy/tool/steps/preparechangelog.py:
16843         (PrepareChangeLog.run): Ditto.
16844         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
16845         (PrepareChangeLogForRevert.run): Ditto.
16846         * Scripts/webkitpy/tool/steps/runtests.py:
16847         (RunTests.run): Ditto.
16848         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
16849         (RunTestsTest.test_webkit_run_unit_tests): The unnecessary methods should now be overridden on MockTool._port.
16850         * Scripts/webkitpy/tool/steps/steps_unittest.py:
16851         (StepsTest.test_runtests_args): Remove the MockTool._deprecated_port override, but don't replace it. Rather than
16852         that the expected test output is adjusted to contain the mock-* command names.
16853         * Scripts/webkitpy/tool/steps/update.py:
16854         (Update._update_command): WebKitPatch.port() should be called now.
16855         * Scripts/webkitpy/tool/steps/update_unittest.py:
16856         (UpdateTest.test_update_command_non_interactive): Override the MockTool._port for testing purposes with the port
16857         that corresponds to the removed DeprecatedPort subclasses.
16858         (UpdateTest.test_update_command_interactive): Ditto.
16860 2013-09-09  Zan Dobersek  <zdobersek@igalia.com>
16862         [GTK] 32-bit builder should run the JSC tests
16863         https://bugs.webkit.org/show_bug.cgi?id=119215
16865         Reviewed by Philippe Normand.
16867         Rename the TestClass member of the TestFactory and BuildAndTestFactory classes
16868         to a more descriptive name, 'LayoutTestClass'. In these two factory classes, the layout testing-specific
16869         steps are only added if the LayoutTestClass member was not overridden to the value of None in a
16870         derived class.
16872         Remove the BuildAndAPITestFactory class and replace it with the BuildAndNonLayoutTestFactory class that
16873         is derived from the BuildAndTestFactory class and overrides the LayoutTestClass member to the value of None.
16874         This allows for builders of the BuildAndNonLayoutTest type to run all but the layout tests. This type
16875         is currently used by the GTK 32-bit builder - there's at the moment no interest to have the builder cover
16876         layout testing while other types of testing are still expected to be performed.
16878         * BuildSlaveSupport/build.webkit.org-config/config.json:
16879         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
16880         (BuildFactory.__init__):
16881         (TestFactory):
16882         (TestFactory.__init__):
16883         (BuildAndTestFactory):
16884         (BuildAndTestFactory.__init__):
16885         (BuildAndTestWebKit2Factory):
16886         (BuildAndTestWebKit2OnlyFactory):
16887         (BuildAndNonLayoutTestFactory):
16888         (TestLeaksFactory):
16889         (TestWebKit2Factory):
16891 2013-09-09  Manuel Rego Casasnovas  <rego@igalia.com>
16893         Unreviewed. Add myself as a committer.
16895         * Scripts/webkitpy/common/config/contributors.json:
16897 2013-09-09  Krzysztof Czech  <k.czech@samsung.com>
16899         [AX][ATK] AccessibilityObject representing ProgressBar element should be ATK_VALUE type
16900         https://bugs.webkit.org/show_bug.cgi?id=121023
16902         Reviewed by Mario Sanchez Prada.
16904         Added mappings to ATK's ProgressBar element.
16906         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
16907         (roleToString):
16908         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
16909         (WTR::roleToString):
16911 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
16913         run-jsc-stress-tests should be more paranoid about calling make
16914         https://bugs.webkit.org/show_bug.cgi?id=121011
16916         Reviewed by Oliver Hunt.
16917         
16918         If it returns with any kind of error then bail out.  Also print the command being used
16919         in case we have to debug this, for example on the bots.  The extra verbosity isn't a
16920         big deal.
16922         * Scripts/run-jsc-stress-tests:
16924 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
16926         Unreviewed, never pass Pathname to shellescape() as old versions of Ruby don't
16927         like that. Pass a string instead.
16929         * Scripts/run-jsc-stress-tests:
16931 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
16933         run-jsc-stress-tests should run tests in parallel if possible
16934         https://bugs.webkit.org/show_bug.cgi?id=120996
16936         Reviewed by Oliver Hunt.
16937         
16938         Run tests in parallel by using Makefile hacks. This lets make take care of all load
16939         balancing. It's a really awesome speed-up for these tests.
16940         
16941         This reduces the FTL debug build stress test run time from 8m18s to 2m11s. The 
16942         no-FTL debug build stress test time goes from 1m11s to 16s. This patch is pretty
16943         much awesome.
16945         * Scripts/run-jsc-stress-tests:
16947 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
16949         run-jsc-stress-tests should be smart enough to call JSRegress "regress/script-tests" rather than "script-tests"
16950         https://bugs.webkit.org/show_bug.cgi?id=120994
16952         Reviewed by Geoffrey Garen.
16953         
16954         run-jsc-stress-tests accepts a list of directories containing tests.  It needs to
16955         come up with names for all of them.  Currently it uses the basename of the test
16956         directory.  But that means that JSRegress gets called "script-tests", which is
16957         unfortunate since any directory in LayoutTests containing .js files will be
16958         called "script-tests".  So, this changes run-jsc-stress-tests to use more than
16959         just the basename if the basename has the word "tests" in it.  This causes
16960         JSRegress to be called "regress/script-tests".
16962         * Scripts/run-jsc-stress-tests:
16964 2013-09-08  Sergio Correia  <sergio.correia@openbossa.org>
16966         [EFL][JHBUILD] Fix evas build with giflib5
16967         https://bugs.webkit.org/show_bug.cgi?id=120863
16969         Original patch from Doug Newgard, at https://phab.enlightenment.org/D200.
16971         Reviewed by Anders Carlsson.
16973         * efl/jhbuild.modules: Apply patch to fix evas build with giflib5.
16974         * efl/patches/evas-fix-build-with-giflib5.patch: Added.
16976 2013-09-07  Filip Pizlo  <fpizlo@apple.com>
16978         Only run FTL tests if we have the FTL
16979         https://bugs.webkit.org/show_bug.cgi?id=120974
16981         Reviewed by Geoffrey Garen.
16982         
16983         Pass --ftl-jit down into run-jsc-stress-tests so that it knows what test
16984         variants to run.
16986         * Scripts/build-jsc:
16987         * Scripts/run-javascriptcore-tests:
16988         * Scripts/run-jsc-stress-tests:
16990 2013-09-07  Santosh Mahto  <santosh.ma@samsung.com>
16992         removing --dialog-element from build-webkit --help option message
16993         https://bugs.webkit.org/show_bug.cgi?id=120955
16995         Reviewed by Daniel Bates.
16997         --dialog-element option is useless while building as
16998         Dialog Element support has been removed in following changeset.
16999         http://trac.webkit.org/changeset/154835
17000         http://trac.webkit.org/changeset/154870
17002         * Scripts/webkitperl/FeatureList.pm:
17003         Removed --dialog-element option message.
17005 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
17007         It should be possible to run-javascriptcore-tests with only a subset of the test suites
17008         https://bugs.webkit.org/show_bug.cgi?id=120918
17010         Reviewed by Dan Bernstein.
17012         * Scripts/run-javascriptcore-tests:
17014 2013-09-06  Commit Queue  <commit-queue@webkit.org>
17016         Unreviewed, rolling out r155196.
17017         http://trac.webkit.org/changeset/155196
17018         https://bugs.webkit.org/show_bug.cgi?id=120919
17020         Broke 16 tests on build.webkit.org (Requested by rniwa on
17021         #webkit).
17023         * Scripts/webkitpy/layout_tests/controllers/manager.py:
17024         (Manager._set_up_run):
17026 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
17028         The 'failed' file should report collectionName/testName rather than just
17029         testName.
17031         Rubber stamped by Mark Hahnenberg.
17033         * Scripts/run-jsc-stress-tests:
17035 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
17037         Fix run-jsc-stress-tests to run on bots with old Ruby.
17038         
17039         Also make it create a repro file.
17041         Rubber stamped by Mark Hahnenberg.
17043         * Scripts/run-jsc-stress-tests:
17045 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
17047         Actually increment $numFailures
17049         Reviewed by Mark Hahnenberg.
17051         * Scripts/run-jsc-stress-tests:
17053 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
17055         Fix run-jsc-stress-tests to use Pathname instead of File.realpath.
17056         
17057         Also make it uses system() instead of popen(); that means that test output
17058         will go to the console. This reduces error detection flakiness. It's fine
17059         because stress tests don't print() unless they really have to.
17061         Rubber stamped by Mark Hahnenberg.
17063         * Scripts/run-jsc-stress-tests:
17065 2013-09-05  Filip Pizlo  <fpizlo@apple.com>
17067         Introduce a way to run benchmarks and JSRegress as stress tests with different jsc command-line options
17068         https://bugs.webkit.org/show_bug.cgi?id=120808
17070         Reviewed by Mark Hahnenberg and rubber stamped by Geoffrey Garen.
17071         
17072         Add a script for running stress tests.  A stress test is a .js file that is run
17073         through different configurations of JSC.  It can control which configurations it
17074         runs by using "//@ <ruby code>" to guide the script.
17075         
17076         This script is now run as part of run-javascriptcore-tests, on Mac only.
17078         * Scripts/run-javascriptcore-tests:
17079         * Scripts/run-jsc-stress-tests: Added.
17081 2013-09-06  Mario Sanchez Prada  <mario.prada@samsung.com>
17083         [GTK] Desktop proxy settings are ignored inside the internal jhbuild
17084         https://bugs.webkit.org/show_bug.cgi?id=120833
17086         Reviewed by Gustavo Noronha Silva.
17088         Add dconf as an optional module for the internal jhbuild, along
17089         with vala 0.17 as a dependency, and make sure we do not explicitly
17090         set always the 'memory' backend, so we can have an easy way to
17091         allow apps access desktop settings from the jhbuild. This is
17092         useful for example to be able to run apps such as MiniBrowser
17093         inside the jhbuild (by means of run-launcher, for instance) while
17094         working behind a proxy, since those network settings have to be
17095         read from the system global configuration in org.gnome.system.proxy.
17097         * gtk/jhbuild-optional.modules: Added dconf 0.14 and vala 0.17.
17098         * gtk/jhbuildrc: Do not explicitly choose the GSettings memory
17099         backend here, since that will make more difficult to use the dconf
17100         backend from inside the jhbuild if we need to do it so.
17102 2013-09-06  Alexey Proskuryakov  <ap@apple.com>
17104         Lots of pixel tests are failing on first run, so tests cannot finish
17105         https://bugs.webkit.org/show_bug.cgi?id=120755
17107         Reviewed by Ryosuke Niwa.
17109         For whatever reason, many reftests are color profile sensitive, and we only set
17110         color profile to a known one for pixel tests, not for reftests.
17112         Pixel testing mode is also enabled  when retrying tests, so these failures used to
17113         be essentially hidden - the tests were "flaky", but that was not reported loudly enough.
17114         But now, so many tests fail that it makes run-webkit-tests stop early, and never retry.
17116         This probably shouldn't happen, as reftests should not be color profile sensitive.
17117         The fix is a stopgap measure to unblock EWS until a better fix can be investigated.
17119         * Scripts/webkitpy/layout_tests/controllers/manager.py:
17120         (Manager._set_up_run): Roll out <http://trac.webkit.org/changeset/115601>.
17122 2013-09-06  Denis Nomiyama  <d.nomiyama@samsung.com>
17124         [GTK] AccessibilityUIElement::addNotificationListener() crashes on debug build
17125         https://bugs.webkit.org/show_bug.cgi?id=120416
17127         Reviewed by Mario Sanchez Prada.
17129         Fixed crashes when running debug DRT. Simplified loops at AccessibilityCallbackAtk.cpp where the HashMap
17130         iterator was removed inside a loop. Fixed AccessibilityUIElement::addNotificationListener() where
17131         m_notificationHandler expected RefPtr.
17133         The global notification handler was stored in the HashMap with key 0. And this caused an assertion when
17134         HashMap::add() or find() are called. To fix it, moved the global handler to a separated pointer.
17136         * DumpRenderTree/atk/AccessibilityCallbacks.h: Removed the global notification key.
17137         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
17138         (axObjectEventListener): Simplified the code by using HashMap::find() and a separate pointer for the
17139         global notification handler.
17140         (addAccessibilityNotificationHandler): Simplified the code by using HashMap::find() and a separate pointer
17141         for the global notification handler.
17142         (removeAccessibilityNotificationHandler): Added the removal for the global notification handler.
17143         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
17144         (AccessibilityNotificationHandler::create): Added static function to create
17145         AccessibilityNotificationHandler.
17146         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
17147         (AccessibilityUIElement::addNotificationListener): Assigned m_notificationHandler with
17148         AccessibilityNotificationHandler::create().
17150 2013-09-06  Gabor Abraham  <abrhm@inf.u-szeged.hu>
17152         [Qt] REGRESSION(r155140) Pixel tests is still broken on Qt with QT_WEBKIT_DISABLE_UIPROCESS_DUMPPIXELS=1
17153         https://bugs.webkit.org/show_bug.cgi?id=120847
17155         Reviewed by Csaba Osztrogonác.
17157         Move the force repaint code back to if (PlatformWebView::windowSnapshotEnabled()) block to support Qt.
17158         Typo fixed: windowShapshotEnabled -> windowSnapshotEnabled.
17159         Add a default PlatformWebView::windowSnapshotEnabled() to the !PLATFORM(QT).
17161         * WebKitTestRunner/PlatformWebView.h:
17162         (WTR::PlatformWebView::windowSnapshotEnabled):
17163         * WebKitTestRunner/TestInvocation.cpp:
17164         (WTR::TestInvocation::dumpResults):
17165         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
17166         (WTR::WrapperWindow::handleStatusChanged):
17167         (WTR::PlatformWebView::windowSnapshotEnabled):
17168         * WebKitTestRunner/qt/TestInvocationQt.cpp:
17169         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
17171 2013-09-06  Allan Sandfeld Jensen  <allan.jensen@digia.com>
17173         REGRESSION(r155140) Broke pixel tests on EFL/GTK/Qt
17174         https://bugs.webkit.org/show_bug.cgi?id=120843
17176         Reviewed by Csaba Osztrogonác.
17178         Call notifyDone like the platform specific forceRepaintDoneCallback methods
17179         it replaced did. The method is empty on the Apple ports.
17181         * WebKitTestRunner/TestInvocation.cpp:
17182         (WTR::TestInvocation::forceRepaintDoneCallback):
17184 2013-09-06  Allan Sandfeld Jensen  <allan.jensen@digia.com>
17186         [Qt][WK2] Window used by WebKitTestRunner loses active status
17187         https://bugs.webkit.org/show_bug.cgi?id=120774
17189         Reviewed by Jocelyn Turcotte.
17191         When focusing the PlatformWebView which is done at the start of each test, we should
17192         ensure the host window of PlatformWebView is also made active, otherwise we will
17193         not receive the keyboard events send by EventSenderProxy.
17195         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
17196         (WTR::PlatformWebView::focus):
17198 2013-09-05  Seokju Kwon  <seokju@webkit.org>
17200         Unreviewed build fix. VectorReverse.cpp was removed after r155151.
17202         * TestWebKitAPI/CMakeLists.txt:
17204 2013-09-05  Anders Carlsson  <andersca@apple.com>
17206         Make Vector::uncheckedAppend work with move-only types
17207         https://bugs.webkit.org/show_bug.cgi?id=120799
17209         Reviewed by Andreas Kling.
17211         * TestWebKitAPI/Tests/WTF/Vector.cpp:
17212         (TestWebKitAPI::MoveOnly):
17213         Add a move-only class.
17215         (TestWebKitAPI::TEST):
17216         Add a test for Vector<MoveOnly>::uncheckedAppend.
17218 2013-09-05  Anders Carlsson  <andersca@apple.com>
17220         Move all Vector tests into Vector.cpp
17221         https://bugs.webkit.org/show_bug.cgi?id=120797
17223         Reviewed by Andreas Kling.
17225         * TestWebKitAPI/CMakeLists.txt:
17226         * TestWebKitAPI/GNUmakefile.am:
17227         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
17228         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
17229         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17230         * TestWebKitAPI/Tests/WTF/Vector.cpp:
17231         (TestWebKitAPI::TEST):
17232         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp: Removed.
17233         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Removed.
17234         * TestWebKitAPI/Tests/WTF/WTF.pro:
17236 2013-09-05  Simon Fraser  <simon.fraser@apple.com>
17238         Expected result images are sometimes blank in WKTR
17239         https://bugs.webkit.org/show_bug.cgi?id=120715
17241         Reviewed by Tim Horton.
17242         
17243         In WebKitTestRunner, snapshots obtained via windowSnapshotImage() were
17244         sometimes blank if a previous test triggered compositing mode, and the
17245         current test or reference did not require compositing. This happened
17246         because the UI process didn't wait for the web process to complete
17247         its compositing mode switch before snapshotting. Fix by calling
17248         WKPageForceRepaint() before we take the snapshot; this is async,
17249         so we have to spin the runloop for a while.
17250         
17251         Remove the Qt/EFL code that does the same thing.
17253         * WebKitTestRunner/TestInvocation.cpp:
17254         (WTR::TestInvocation::forceRepaintDoneCallback):
17255         (WTR::TestInvocation::dumpResults):
17256         * WebKitTestRunner/TestInvocation.h:
17257         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
17258         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
17259         * WebKitTestRunner/qt/TestInvocationQt.cpp:
17260         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
17262 2013-09-05  Csaba Osztrogonác  <ossy@webkit.org>
17264         Make build.webkit.org report the number of failing run-fast-jsc tests
17265         https://bugs.webkit.org/show_bug.cgi?id=120766
17267         Reviewed by Filip Pizlo.
17269         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
17270         (RunJavaScriptCoreTests.commandComplete):
17271         (RunJavaScriptCoreTests.getText2):
17272         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
17273         (RunJavaScriptCoreTestsTest): Added.
17274         (RunJavaScriptCoreTestsTest.assertResults):
17275         (RunJavaScriptCoreTestsTest.test_no_regressions_old_output):
17276         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
17277         (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output):
17278         (RunJavaScriptCoreTestsTest.test_fast_js_failure_new_output):
17279         (RunJavaScriptCoreTestsTest.test_fast_js_crash_new_output):
17280         (RunJavaScriptCoreTestsTest.test_mozilla_and_fast_js_failure_new_output):
17282 2013-09-05  Csaba Osztrogonác  <ossy@webkit.org>
17284         Make run-fast-jsc script bash, dash and Darwin's /bin/sh friendly
17285         https://bugs.webkit.org/show_bug.cgi?id=120759
17287         Reviewed by Filip Pizlo.
17289         * Scripts/run-fast-jsc: Remove bashisms to make bash, dash and Darwin's /bin/sh happy.
17290         * Scripts/run-javascriptcore-tests: Enable run-fast-jsc tests everywhere, except Windows.
17292 2013-09-05  Filip Pizlo  <fpizlo@apple.com>
17294         Unreviewed, green the Mac bots by boosting the timeout on JSC tests. One of the
17295         Mozilla tests appears to run for a longer time.
17296         
17297         I think we want to continue to allow a few tests here and there to be
17298         longer-running, rather than excluding them. I seem to recall that those tests
17299         catch good bugs.
17301         * Scripts/run-javascriptcore-tests:
17303 2013-09-05  Filip Pizlo  <fpizlo@apple.com>
17305         Unreviewed, don't run fast/js tests in run-javascriptcore-tests on platforms that
17306         can't support it because if non-bourne shells. This fixes part #2 of the Linux
17307         bot breakage.
17309         * Scripts/run-javascriptcore-tests:
17311 2013-09-05  Filip Pizlo  <fpizlo@apple.com>
17313         Unreviewed, don't rely on File::Slurp. This fixes part #1 of Linux bot breakage.
17315         * Scripts/run-javascriptcore-tests:
17316         (readAllLines):
17318 2013-09-04  Filip Pizlo  <fpizlo@apple.com>
17320         jsc tests should have timeouts
17321         https://bugs.webkit.org/show_bug.cgi?id=120725
17323         Reviewed by Geoffrey Garen.
17324         
17325         Set the timeout to 20 seconds per test for now.
17327         * Scripts/run-javascriptcore-tests:
17329 2013-09-04  Filip Pizlo  <fpizlo@apple.com>
17331         run-javascriptcore-tests should run-fast-jsc as well
17332         https://bugs.webkit.org/show_bug.cgi?id=120722
17334         Reviewed by Geoffrey Garen.
17335         
17336         Makes run-javascriptcore-tests run the fast/js tests via run-fast-jsc tool.
17337         Integrates run-fast-jsc's error reporting into run-javascriptcore-tests.
17339         * Scripts/run-javascriptcore-tests:
17340         (printThingsFound):
17342 2013-09-04  Sergio Correia  <sergio.correia@openbossa.org>
17344         [EFL][WK2] Move ShouldGoToBackForwardListItem to the list of passing API tests
17345         https://bugs.webkit.org/show_bug.cgi?id=120646
17347         Reviewed by Gyuyoung Kim.
17349         * TestWebKitAPI/PlatformEfl.cmake: Move ShouldGoToBackForwardListItem to the
17350         list of passing tests, since it started to pass after r154045.
17352 2013-09-04  Krzysztof Czech  <k.czech@samsung.com>
17354         [ATK] Adds an accessibility support to access a value of the color control element
17355         https://bugs.webkit.org/show_bug.cgi?id=114354
17357         Reviewed by Mario Sanchez Prada.
17359         Added accessibility role of the color control element.
17361         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
17362         (roleToString):
17363         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
17364         (WTR::roleToString):
17366 2013-09-04  Mario Sanchez Prada  <mario.prada@samsung.com>
17368         REGRESSION (r132328): /WebKit2APITests/TestWebKitAccessibility unit test is failing
17369         https://bugs.webkit.org/show_bug.cgi?id=100408
17371         Unreviewed gardening. Unskip TestWebKitAccessibility after
17372         manually checking that it's running properly in the bot.
17374         * Scripts/run-gtk-tests:
17375         (TestRunner): Unskipped TestWebKitAccessibility.
17377 2013-09-04  Zan Dobersek  <zdobersek@igalia.com>
17379         [GTK] Add support for the Wayland build target
17380         https://bugs.webkit.org/show_bug.cgi?id=120627
17382         Reviewed by Gustavo Noronha Silva.
17384         * GNUmakefile.am: Define the additional macros also if building the Wayland target.
17386 2013-09-04  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
17388         [GStreamer] cannot play live streams
17389         https://bugs.webkit.org/show_bug.cgi?id=116831
17391         Reviewed by Philippe Normand.
17393         Fix timeout issues with rtspsrc/udpsrc gstreamer elements.
17395         * gtk/jhbuild.modules:
17396         * gtk/patches/rtspsrc-timeout-on-udpsrc-is-in-nanoseconds.patch: Added.
17397         * gtk/patches/udpsrc-improve-timeouts.patch: Added.
17398         Changed gstreamer jhbuild modules to use tarball repos (required to add patches)
17399         and added 2 patches to gst-plugins-good to fix timeout issues with rtsp streams.
17400         Both patches are applied upstream and can be removed once a new gstreamer release
17401         is out (up to 1.0.10 the patches are not included) and we bump the requirements.
17403 2013-09-03  Alexey Proskuryakov  <ap@apple.com>
17405         [Mac] WebKitTestRunner still beeps sometimes
17406         https://bugs.webkit.org/show_bug.cgi?id=120652
17408         Reviewed by Tim Horton.
17410         In bug 107251, we disabled beeping in WebProcess, but some of the beeps happen in
17411         UI process (notably, AppKit beeps when handling a key equivalent returns NO).
17413         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
17414         Use the same SPI that we use in DRT and in WebProcess to disable beeping.
17416 2013-09-03  Krzysztof Czech  <k.czech@samsung.com>
17418         [AX][ATK] Added support for sort and help attributes
17419         https://bugs.webkit.org/show_bug.cgi?id=120456
17421         Reviewed by Chris Fleizach.
17423         Added missing implementation to AccessibilityUIElement::helpText and support for
17424         aria-sort attribute.
17426         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
17427         (coreAttributeToAtkAttribute):
17428         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
17429         (WTR::coreAttributeToAtkAttribute):
17430         (WTR::AccessibilityUIElement::helpText):
17432 2013-09-03  Allan Sandfeld Jensen  <allan.jensen@digia.com>
17434         [Qt][WK1] PageVisibility tests are flaky
17435         https://bugs.webkit.org/show_bug.cgi?id=120418
17437         Reviewed by Jocelyn Turcotte.
17439         Implement resetPageVisibility so we can reset visibility without
17440         emiting visibility state change events.
17442         * DumpRenderTree/qt/TestRunnerQt.cpp:
17443         (TestRunner::resetPageVisibility):
17445 2013-09-03  ChangSeok Oh  <changseok.oh@collabora.com>
17447         [GTK] libsoup upversion to fix a gstreamer issue, bug115354
17448         https://bugs.webkit.org/show_bug.cgi?id=120613
17450         Reviewed by Philippe Normand.
17452         Up version of libsoup to 2.43.90. But the exact version which we'll use is not 2.43.90.
17453         To fix bug115354, we need the Andre's patch for libsoup, but the lastest release
17454         does not contain it. https://bugzilla.gnome.org/show_bug.cgi?id=706338
17455         For the reason, we'll use libsoup git repo directly for a while until the next
17456         libsoup release.
17458         * gtk/jhbuild.modules:
17460 2013-09-02  Darin Adler  <darin@apple.com>
17462         [Mac] No need for HardAutorelease, which is same as CFBridgingRelease
17463         https://bugs.webkit.org/show_bug.cgi?id=120569
17465         Reviewed by Andy Estes.
17467         * DumpRenderTree/mac/DumpRenderTree.mm:
17468         (dump): Use CFBridgingRelease.
17470 2013-09-02  Anton Obzhirov  <a.obzhirov@samsung.com>
17472         <https://webkit.org/b/98350> [GTK] accessibility/aria-invalid.html times out
17474         Reviewed by Mario Sanchez Prada.
17476         Added few mappings in DumpRenderTree and WebKitTestRunner for aria-invalid in order to get the tests run properly.
17478         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
17479         (axObjectEventListener):
17480         Added mapping for invalid-entry event parameter.
17481         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
17482         (coreAttributeToAtkAttribute):
17483         Added mapping to aria-invalid.
17484         (AccessibilityUIElement::stringAttributeValue):
17485         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
17486         (WTR::coreAttributeToAtkAttribute):
17487         Added mapping to aria-invalid.
17489 2013-09-02  Nick Diego Yamane  <nick.yamane@openbossa.org>
17491         Save md5 correctly when jhbuildPath doesn't exist yet
17492         https://bugs.webkit.org/show_bug.cgi?id=120548
17494         Reviewed by Gustavo Noronha Silva.
17496         After r152605, Md5 for jhbuild files are saved before the update
17497         process, this prevents the script to restart update from scratch
17498         when initial checkouts fail. However it causes an issue when builddir
17499         (or builddir/Dependencies) doesn't exist yet. In that case the
17500         saveJhbuildMd5 function fails to create md5 files.
17501         This patch adds a checking for the jhbuildPath and creates it if
17502         necessary before trying to open the md5 files.
17504         * Scripts/update-webkit-libs-jhbuild:
17505         (saveJhbuildMd5):
17507 2013-09-02  Mario Sanchez Prada  <mario.prada@samsung.com>
17509         Unreviewed. Move myself to the reviewers list.
17511         * Scripts/webkitpy/common/config/contributors.json:
17513 2013-09-01  Alexey Proskuryakov  <ap@apple.com>
17515         [WK2][Mac] Drag and drop tests interfere with user's UI
17516         https://bugs.webkit.org/show_bug.cgi?id=120538
17518         Reviewed by Dan Bernstein.
17520         This makes running WebKit2 regression tests locally more viable. The patch doesn't
17521         fix drag and drop tests to work as expected, I posted some thought about that in
17522         <https://bugs.webkit.org/show_bug.cgi?id=68552>.
17524         * WebKitTestRunner/EventSenderProxy.h:
17525         (WTR::EventSenderProxy::position):
17526         * WebKitTestRunner/TestController.h:
17527         (WTR::TestController::eventSenderProxy):
17528         Expose a way to get current mouse position from anywhere in WKTR code.
17530         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new files.
17532         * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::mouseUp):
17533         Copied a FIXME comment from DumpRenderTree.
17535         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
17536         (-[TestRunnerWKView dragImage:at:offset:event:pasteboard:source:slideBack:]):
17537         Override drag initiation, using a custom NSDraggingInfo implementation.
17539         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
17540         Replace NSEvent with a custom class.
17542         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h: Added.
17543         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Added.
17544         * WebKitTestRunner/mac/WebKitTestRunnerEvent.h: Added.
17545         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Added.
17546         Largely a copy of DumpRenderTree classes, modified to not use global variables.
17547         We should consider making these variables static in EventSenderProxy though, as
17548         it's strange that mouse state in WKTR is reset between tests without WebKit ever
17549         being told about that.
17551 2013-08-30  Brent Fulgham  <bfulgham@apple.com>
17553         [Windows] Unreviewed build fix.
17555         * win/AssembleBuildLogs/AssembleLogs.cmd: Make sure WebInspectorUI build output is reported
17556         from the build machines.
17558 2013-08-30  Gabor Abraham  <abrhm@inf.u-szeged.hu>
17560         [Qt] Remove qt-5.0-wk2 from the baseline search paths because the migration of expectations to qt-wk2 is done.
17561         https://bugs.webkit.org/show_bug.cgi?id=120464
17563         Reviewed by Jocelyn Turcotte.
17565         * Scripts/webkitpy/port/qt.py:
17566         (QtPort._search_paths):
17567         * Scripts/webkitpy/port/qt_unittest.py:
17568         (QtPortTest):
17570 2013-08-29  Filip Pizlo  <fpizlo@apple.com>
17572         Just linking LLVM into JSC causes all plugin tests to fail
17573         https://bugs.webkit.org/show_bug.cgi?id=113915
17575         Reviewed by Oliver Hunt.
17576         
17577         Hide all LLVM symbols. This should prevent us from exporting LLVM's overrides for
17578         raise/abort/__assert_rtn.
17580         * Scripts/configure-llvm:
17582 2013-08-29  Joseph Pecoraro  <pecoraro@apple.com>
17584         new-run-webkit-tests does not respect --no-sample-on-timeout switch
17585         https://bugs.webkit.org/show_bug.cgi?id=120491
17587         Reviewed by Darin Adler.
17589         * Scripts/webkitpy/port/server_process.py:
17590         (ServerProcess._handle_timeout):
17592 2013-08-29  Sam Weinig  <sam@webkit.org>
17594         Add ENABLE guards for Promises
17595         https://bugs.webkit.org/show_bug.cgi?id=120488
17597         Reviewed by Andreas Kling.
17599         * Scripts/webkitperl/FeatureList.pm:
17600         * qmake/mkspecs/features/features.pri:
17602 2013-08-29  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
17604         [GTK] Should enable WebGL by default on MiniBrowser
17605         https://bugs.webkit.org/show_bug.cgi?id=120420
17607         Reviewed by Gustavo Noronha Silva.
17609         Enable WebGL by default on MiniBrowser.
17611         * MiniBrowser/gtk/main.c:
17612         (main):
17614 2013-08-28  Simon Fraser  <simon.fraser@apple.com>
17616         Add a Command-R shortcut in MiniBrowser
17617         https://bugs.webkit.org/show_bug.cgi?id=120442
17619         Reviewed by Dean Jackson.
17620         
17621         Add a "Reload Page" item to the View menu with a Command-R
17622         shortcut.
17624         * MiniBrowser/mac/MainMenu.xib:
17626 2013-08-29  Alberto Garcia  <berto@igalia.com>
17628         [GTK] Update apt dependency list
17629         https://bugs.webkit.org/show_bug.cgi?id=120399
17631         Reviewed by Philippe Normand.
17633         Remove bogus package gail-3.0, add xfonts-utils (needed by
17634         xorg-xserver) and switch to the latest versions of libtiff and
17635         libjpeg.
17637         * gtk/install-dependencies:
17639 2013-08-28  Alexey Proskuryakov  <ap@apple.com>
17641         [WK2][Mac] WebKitTestRunner doesn't force system appearance
17642         https://bugs.webkit.org/show_bug.cgi?id=120437
17644         Reviewed by Darin Adler.
17646         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
17647         (WTR::InjectedBundle::platformInitialize): Set AppleAquaColorVariant,
17648         AppleHighlightColor and AppleOtherHighlightColor to the same values that DRT uses.
17649         Fixed formatting.
17651 2013-08-16  Ryosuke Niwa  <rniwa@webkit.org>
17653         <https://webkit.org/b/119806> [Mac] Add a way to easily test attributed string generation
17655         Reviewed by Darin Adler.
17657         Add textInputController.legacyAttributedString to retrieve the attributed string for copy & paste.
17659         We can't use textInputController.attributedSubstringFromRange as it uses WebHTMLConverter's static
17660         editingAttributedStringFromRange function, which doesn't implement the full converter at the moment.
17662         Also NSMutableAttributedString.ranges and WebNSRange so that JavaScript can get a list of all
17663         ranges in a given attributed string.
17665         * DumpRenderTree/mac/TextInputController.m:
17666         (-[WebNSRange initWithNSRange:]):
17667         (-[WebNSRange location]):
17668         (-[WebNSRange length]):
17669         (+[WebNSRange isSelectorExcludedFromWebScript:]):
17670         (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
17671         (+[NSMutableAttributedString webScriptNameForSelector:]):
17672         (-[NSMutableAttributedString ranges]): Added.
17673         (+[TextInputController isSelectorExcludedFromWebScript:]):
17674         (+[TextInputController webScriptNameForSelector:]):
17675         (-[TextInputController legacyAttributedString:]):
17677 2013-08-28  Denis Nomiyama  <d.nomiyama@samsung.com>
17679         [GTK] accessibility/menu-list-sends-change-notification.html has incorrect expected results
17680         https://bugs.webkit.org/show_bug.cgi?id=120419
17682         Reviewed by Chris Fleizach.
17684         Added a notification for AXFocusedUIElementChanged.
17686         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
17687         (axObjectEventListener): Added a notification for AXFocusedUIElementChanged.
17689 2013-08-28  Roger Fong  <roger_fong@apple.com>
17691         Decrease number of workers used in NRWT by the Windows port.
17692         https://bugs.webkit.org/show_bug.cgi?id=120435.
17694         Reviewed by Brent Fulgham.
17696         * Scripts/webkitpy/port/win.py:
17697         (WinPort.default_child_processes):
17699 2013-08-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
17701         Http tests fails on Debian with Apache 2.4
17702         https://bugs.webkit.org/show_bug.cgi?id=120352
17704         Unreviewed fix-up.
17706         Remember to update unit-test expectations and old-run-webkit-tests as well.
17708         * Scripts/webkitperl/httpd.pm:
17709         (getHTTPDConfigPathForTestDirectory):
17710         * Scripts/webkitpy/port/port_testcase.py:
17711         (test_apache_config_file_name_for_platform):
17713 2013-08-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
17715         Http tests fails on Debian with Apache 2.4
17716         https://bugs.webkit.org/show_bug.cgi?id=120352
17718         Reviewed by Andreas Kling.
17720         Select httpd.conf file for debian based on version, matching Fedora behavior.
17722         * Scripts/webkitpy/port/base.py:
17723         (Port._apache_config_file_name_for_platform):
17725 2013-08-28  Commit Queue  <commit-queue@webkit.org>
17727         Unreviewed, rolling out r154593.
17728         http://trac.webkit.org/changeset/154593
17729         https://bugs.webkit.org/show_bug.cgi?id=120403
17731         Caused 50+ flaky tests on WebKit1 bots (Requested by carewolf
17732         on #webkit).
17734         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
17735         (WebPage::~WebPage):
17737 2013-08-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
17739         [Qt][Wk2] Many tests are flaky on Qt 5.1
17740         https://bugs.webkit.org/show_bug.cgi?id=118232
17742         Reviewed by Jocelyn Turcotte.
17744         We need to set renderToOffscreenBuffer since we won't otherwise get
17745         the paint calls necessary to synchronize UI- and Web-Process. It was
17746         only disabled in Qt 5.0 because it conflicted with setRenderWithoutShowing
17747         which is no longer supported or needed.
17749         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
17750         (WTR::WrapperWindow::handleStatusChanged):
17752 2013-08-27  Alexey Proskuryakov  <ap@apple.com>
17754         [WK2] Remove USE_WEBPROCESS_EVENT_SIMULATION
17755         https://bugs.webkit.org/show_bug.cgi?id=120379
17757         Reviewed by Darin Adler.
17759         All major platforms have implemented UI process eventSender support, keeping old
17760         web process side code only adds confusion.
17762         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
17763         (WTR::EventSendingController::EventSendingController):
17764         (WTR::EventSendingController::mouseDown):
17765         (WTR::EventSendingController::mouseUp):
17766         (WTR::EventSendingController::mouseMoveTo):
17767         (WTR::EventSendingController::leapForward):
17768         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
17769         * WebKitTestRunner/TestController.cpp:
17770         (WTR::TestController::resetStateToConsistentValues):
17771         (WTR::TestController::didReceiveMessageFromInjectedBundle):
17772         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
17773         * WebKitTestRunner/TestController.h:
17775 2013-08-27  Roger Fong  <roger_fong@apple.com>
17777         NRWT on AppleWin port should delete semaphore lock files during cleanup tasks.
17778         https://bugs.webkit.org/show_bug.cgi?id=120370.
17780         Reviewed by Brent Fulgham.
17782         * Scripts/webkitpy/port/win.py:
17783         (WinPort.delete_sem_locks):
17784         (WinPort.setup_test_run):
17786 2013-08-27  Denis Nomiyama  <d.nomiyama@samsung.com>
17788         [GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation
17789         https://bugs.webkit.org/show_bug.cgi?id=119883
17791         Implemented the notification listener for AccessibilityUIElement. The signal is generated
17792         by AXObjectCache::postPlatformNotification() and received by axObjectEventListener().
17793         axObjectEventListener will then invoke JSObjectCallAsFunction() with the respective
17794         callback function. The global callback function and callbacks for specific elements are
17795         stored in a HashMap in AccessibilityCallbacksAtk.cpp.
17797         Reviewed by Chris Fleizach.
17799         * DumpRenderTree/AccessibilityUIElement.h: Added a notification handler for GTK+
17800         * DumpRenderTree/atk/AccessibilityCallbacks.h: Added addAccessibilityNotificationListener()
17801         and removeAccessibilityNotificationListener()
17802         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
17803         (axObjectEventListener): Call JS callback for global notification or for a specific element
17804         (disconnectAccessibilityCallbacks): Only disconnect if logging is off and there is no
17805         notification handler
17806         (addAccessibilityNotificationHandler): Add notification listener to the list
17807         (removeAccessibilityNotificationHandler): Remove notification listener from the list
17808         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
17809         (AccessibilityController::setLogAccessibilityEvents): Set logging off before disconnecting
17810         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
17811         (AccessibilityNotificationHandler::AccessibilityNotificationHandler): Create handler
17812         (AccessibilityNotificationHandler::~AccessibilityNotificationHandler): Destroy handler.
17813         Remove handler from the list and disconnect callbacks
17814         (AccessibilityNotificationHandler::setNotificationFunctionCallback): Set the notification
17815         callback and connect callbacks to signals
17816         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Added.
17817         (AccessibilityNotificationHandler::setPlatformElement): Set platform element
17818         (AccessibilityNotificationHandler::platformElement): Get platform element
17819         (AccessibilityNotificationHandler::notificationFunctionCallback): Get notification callback
17820         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
17821         (AccessibilityUIElement::addNotificationListener): Create notification handler, set the
17822         platform element and the notification callback
17823         (AccessibilityUIElement::removeNotificationListener):
17824         * DumpRenderTree/efl/CMakeLists.txt: Added AccessibilityNotificationHandlerAtk.cpp/h
17825         * GNUmakefile.am: Added AccessibilityNotificationHandlerAtk.cpp/h
17827 2013-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
17829         Unreviewed. Fix GTK+ build after r154601.
17831         * TestWebKitAPI/GNUmakefile.am: Remove mac specific file from
17832         compilation added by mistake in r154601.
17834 2013-08-26  Alexey Proskuryakov  <ap@apple.com>
17836         WebKitTestRunner needs to protect the user's pasteboard contents while running
17837         https://bugs.webkit.org/show_bug.cgi?id=81419
17838         <rdar://problem/11066794>
17840         Reviewed by Darin Adler.
17842         Mostly a copy/paste of DRT code.
17844         Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
17845         doesn't interfere with my clipboard while being run in a loop.
17847         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
17848         * WebKitTestRunner/mac/PoseAsClass.h: Added.
17849         * WebKitTestRunner/mac/PoseAsClass.mm: Added.
17850         * WebKitTestRunner/mac/TestControllerMac.mm:
17851         (WTR::TestController::platformInitialize):
17852         (WTR::TestController::platformDestroy):
17853         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
17854         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
17856 2013-08-26  Commit Queue  <commit-queue@webkit.org>
17858         Unreviewed, rolling out r154640.
17859         http://trac.webkit.org/changeset/154640
17860         https://bugs.webkit.org/show_bug.cgi?id=120329
17862         Caused flaky crashes on a lot of editing tests (Requested by
17863         rniwa on #webkit).
17865         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
17866         * WebKitTestRunner/mac/PoseAsClass.h: Removed.
17867         * WebKitTestRunner/mac/PoseAsClass.mm: Removed.
17868         * WebKitTestRunner/mac/TestControllerMac.mm:
17869         (WTR::TestController::platformInitialize):
17870         (WTR::TestController::platformDestroy):
17871         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Removed.
17872         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Removed.
17874 2013-08-26  Dan Bernstein  <mitz@apple.com>
17876         Automatic bug reports case pain
17877         https://bugs.webkit.org/show_bug.cgi?id=120330
17879         Reviewed by Anders Carlsson.
17881         * Scripts/webkitpy/tool/commands/download.py: Made the following changes to the Description
17882         of bugs filed by the bot: changed “the sheriff-bot” to “webkitbot”, changed “case pain” to
17883         “fail”, and removed “"Only you can prevent forest fires." -- Smokey the Bear”.
17885 2013-08-23  Andy Estes  <aestes@apple.com>
17887         Fix issues found by the Clang Static Analyzer
17888         https://bugs.webkit.org/show_bug.cgi?id=120230
17890         Reviewed by Darin Adler.
17892         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
17893         (-[LocalPasteboard initWithName:]): Called [super init] first so that we
17894         don't later use ivars from the wrong self.
17895         * DumpRenderTree/mac/TestRunnerMac.mm:
17896         (-[APITestDelegate initWithCompletionCondition:]): Ditto.
17897         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
17898         (TestWebKitAPI::TEST): Don't leak WKProcessGroups,
17899         WKBrowsingContextGroups, and WKViews.
17901 2013-08-26  Alexey Proskuryakov  <ap@apple.com>
17903         WebKitTestRunner needs to protect the user's pasteboard contents while running
17904         https://bugs.webkit.org/show_bug.cgi?id=81419
17905         <rdar://problem/11066794>
17907         Reviewed by Darin Adler.
17909         Mostly a copy/paste of DRT code.
17911         Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
17912         doesn't interfere with my clipboard while being run in a loop.
17914         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
17915         * WebKitTestRunner/mac/PoseAsClass.h: Added.
17916         * WebKitTestRunner/mac/PoseAsClass.mm: Added.
17917         * WebKitTestRunner/mac/TestControllerMac.mm:
17918         (WTR::TestController::platformInitialize):
17919         (WTR::TestController::platformDestroy):
17920         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
17921         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
17923 2013-08-26  Zan Dobersek  <zdobersek@igalia.com>
17925         [GTK] Include most of the WebKit2 unit tests into the build and testing
17926         https://bugs.webkit.org/show_bug.cgi?id=120307
17928         Reviewed by Philippe Normand.
17930         There are still various unit test source files that are not being included into
17931         the build. This patch includes most of these, only leaving out tests that do not
17932         compile or test features that are not supported by the GTK port.
17934         * Scripts/run-gtk-tests: Skip four newly-added tests that are failing or timing out.
17935         (TestRunner):
17936         * TestWebKitAPI/GNUmakefile.am:
17938 2013-08-26  Carlos Garcia Campos  <cgarcia@igalia.com>
17940         [GTK] Allow to run tests without Xvfb in run-gtk-tests
17941         https://bugs.webkit.org/show_bug.cgi?id=120298
17943         Reviewed by Philippe Normand.
17945         Add --no-xvfb command line option to run tests in the current
17946         display.
17948         * Scripts/run-gtk-tests:
17949         (TestRunner._run_xvfb): Return early if option --no-xvfb has been
17950         passed.
17951         (TestRunner._setup_testing_environment): Use helper function
17952         _run_xvfb to start Xvfb if needed.
17953         (TestRunner._tear_down_testing_environment): Check Xvfb is
17954         actually running before trying to terminate it.
17956 2013-08-26  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
17958         Adding Gabor Abraham to contributors.json.
17960         Reviewed by Csaba Osztrogonác.
17962         * Scripts/webkitpy/common/config/contributors.json:
17964 2013-08-26  Carlos Garcia Campos  <cgarcia@igalia.com>
17966         [GTK] Add support for passing test directories to run-gtk-tests
17967         https://bugs.webkit.org/show_bug.cgi?id=120296
17969         Reviewed by Philippe Normand.
17971         * Scripts/run-gtk-tests:
17972         (TestRunner._get_tests_from_dir): Helper function to return all
17973         unit tests found in a given directory.
17974         (TestRunner._get_tests): Check the given tests passed in the
17975         command line, so that if a directory is found the tests contained
17976         in the directory are added to the list of tests to run.
17978 2013-08-26  Carlos Garcia Campos  <cgarcia@igalia.com>
17980         [GTK] Improve the stop/reload button implementation in MiniBrowser
17981         https://bugs.webkit.org/show_bug.cgi?id=120292
17983         Reviewed by Philippe Normand.
17985         - Use an instance member of BrowserWindow for the button widget
17986           instead of a global variable.
17987         - Use notify::is-loading to monitor the WebView load instead of
17988           the estimated-load-progress property.
17989         - Use webkit_web_view_is_loading() to check whether the view
17990           is loading to change the button icon instead of a string
17991           comparison of the gtk stock icon id.
17992         - Use the right casts to fix compile warning.
17994         * MiniBrowser/gtk/BrowserWindow.c:
17995         (reloadOrStopCallback):
17996         (webViewLoadProgressChanged):
17997         (webViewIsLoadingChanged):
17998         (browser_window_init):
17999         (browserWindowConstructed):
18001 2013-08-26  Arunprasad Rajkumar  <arurajku@cisco.com>
18003         [Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433)
18004         https://bugs.webkit.org/show_bug.cgi?id=119791
18006         Reviewed by Jocelyn Turcotte.
18007         
18008         Load empty url to send onunload event to currently running page. onunload event is 
18009         mandatory for LayoutTests/plugins/open-and-close-window-with-plugin.html and
18010         LayoutTests/plugins/geturlnotify-during-document-teardown.html.
18012         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
18013         (WebPage::~WebPage):
18015 2013-08-26  Carlos Garcia Campos  <cgarcia@igalia.com>
18017         [GTK] Silence MiniBrowser compile warnings due to recent GTK+ deprecations
18018         https://bugs.webkit.org/show_bug.cgi?id=120290
18020         Reviewed by Philippe Normand.
18022         * MiniBrowser/gtk/GNUmakefile.am: Add
18023         -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_6 compile option.
18025 2013-08-26  Zan Dobersek  <zdobersek@igalia.com>
18027         [GTK] Add WillLoad test files to the TestWebKitAPI/TestWebKit2 program
18028         https://bugs.webkit.org/show_bug.cgi?id=120288
18030         Reviewed by Carlos Garcia Campos.
18032         * TestWebKitAPI/GNUmakefile.am: Add the WillLoad.cpp build target that should be compiled
18033         into the TestWebKit2 program. The InjectedBundle counterpart file is added to the build as well.
18034         These unit tests are at the moment failing in debug configurations, so it would be nice to
18035         have the GTK builds report these failures as well.
18037 2013-08-25  Ryuan Choi  <ryuan.choi@samsung.com>
18039         [EFL] EWebLauncher is executed as full screen with device pixel ratio
18040         https://bugs.webkit.org/show_bug.cgi?id=120282
18042         Reviewed by Gyuyoung Kim.
18044         * EWebLauncher/main.c:
18045         Use double instead of float for device_pixel_ratio which is passed to ECORE_GETOPT_VALUE_DOUBLE.
18047 2013-08-25  Zan Dobersek  <zdobersek@igalia.com>
18049         [gdb] Remove the pretty printer for KURLGooglePrivate
18050         https://bugs.webkit.org/show_bug.cgi?id=120263
18052         Reviewed by Benjamin Poulain.
18054         Remove the pretty printer for the WebCore::KURLGooglePrivate structure that
18055         was usable inside the gdb debugger. The structure was remove from the codebase
18056         along with the GoogleURL backend for KURL.
18058         * gdb/webkit.py:
18059         (JSCJSStringPrinter.to_string):
18060         (add_pretty_printers):
18062 2013-08-24  Filip Pizlo  <fpizlo@apple.com>
18064         Unreviewed, fix build-webkit --ftl-jit in the case that you have your own llvm directory. We need to
18065         prune 'libgtest' and friends from the llvm build, since WebKit builds its own and none of the llvm
18066         libraries depend on libgtest anyway.
18068         * Scripts/copy-webkitlibraries-to-product-directory:
18070 2013-08-24  Darin Adler  <darin@apple.com>
18072         RetainPtr lacks move constructor for case when argument is a RetainPtr of a different type
18073         https://bugs.webkit.org/show_bug.cgi?id=120255
18075         Reviewed by Andreas Kling.
18077         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added four tests covering move assignment and construction.
18079 2013-08-24  Anders Carlsson  <andersca@apple.com>
18081         Don't treat NSLocalizedDescriptionKey and NSLocalizedRecoverySuggestionErrorKey as NSLocalized macros
18082         https://bugs.webkit.org/show_bug.cgi?id=120249
18084         Reviewed by Andreas Kling.
18086         * Scripts/extract-localizable-strings:
18088 2013-08-24  Carlos Garcia Campos  <cgarcia@igalia.com>
18090         [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API
18091         https://bugs.webkit.org/show_bug.cgi?id=119743
18093         Reviewed by Anders Carlsson.
18095         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
18096         (WTR::InjectedBundlePage::InjectedBundlePage): Add
18097         willDestroyFrame.
18099 2013-08-23  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
18101         Move TestWebKitAPI_LIBRARIES before platform specific cmake include
18102         https://bugs.webkit.org/show_bug.cgi?id=120220
18104         Reviewed by Martin Robinson.
18106         * TestWebKitAPI/CMakeLists.txt:
18108 2013-08-22  Filip Pizlo  <fpizlo@apple.com>
18110         build-jsc --ftl-jit should work
18111         https://bugs.webkit.org/show_bug.cgi?id=120194
18113         Reviewed by Oliver Hunt.
18115         * Scripts/build-jsc: Need to pass the feature flag to xcodebuild
18117 2013-08-23  Commit Queue  <commit-queue@webkit.org>
18119         Unreviewed, rolling out r153534.
18120         http://trac.webkit.org/changeset/153534
18121         https://bugs.webkit.org/show_bug.cgi?id=120216
18123         Too many tests failing just WinEWS bots (Requested by rfong on
18124         #webkit).
18126         * Scripts/webkitpy/common/config/ews.json:
18128 2013-08-23  Alex Christensen  <alex.christensen@flexsim.com>
18130         Unreviewed.  Added my webkit.org email address.
18132         * Scripts/webkitpy/common/config/contributors.json:
18134 2013-08-23  Peter Gal  <galpeter@inf.u-szeged.hu>
18136         [WTR] Should dump as text when the mimetype is text/plain
18137         https://bugs.webkit.org/show_bug.cgi?id=118306
18139         Reviewed by Christophe Dumez.
18141         Check for the text/plain mimetype and if true then mark it as
18142         text dump.
18144         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
18145         (WTR::InjectedBundlePage::dump):
18147 2013-08-22  Filip Pizlo  <fpizlo@apple.com>
18149         Update LLVM binary drops and scripts to the latest version from SVN
18150         https://bugs.webkit.org/show_bug.cgi?id=120184
18152         Reviewed by Mark Hahnenberg.
18154         * ReducedFTL/build.sh:
18155         * Scripts/configure-llvm: Added.
18156         * Scripts/copy-webkitlibraries-to-product-directory:
18157         * Scripts/export-llvm-build:
18159 2013-08-22  Andy Estes  <aestes@apple.com>
18161         <https://webkit.org/b/120180> Fix issues with OTHER_LDFLAGS in various .xcconfig files
18163         Reviewed by David Kilzer.
18165         * TestWebKitAPI/Configurations/Base.xcconfig: Removed the definition of
18166         OTHER_CPLUSPLUSFLAGS since -ftemplate-depth=256 is already set in
18167         DebugRelease.xcconfig and TestWebKitAPI isn't built in Production.
18169 2013-08-22  Ryosuke Niwa  <rniwa@webkit.org>
18171         NRWT: Add the ability to upload test results to new test results server
18172         https://bugs.webkit.org/show_bug.cgi?id=120146
18174         Reviewed by Andreas Kling.
18175         
18176         For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format
18177         that contains the full summary of the test run including information about passed tests.
18179         Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT:
18180         --build-slave
18181         --got-revision
18182         --results-server-host
18184         The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server
18185         so we should be able to delete --test-results-server in time.
18187         * Scripts/webkitpy/layout_tests/controllers/manager.py:
18188         (Manager.run):
18189         (Manager._upload_json_files):
18190         (Manager):
18191         (Manager.upload_results):
18192         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
18193         (summarize_results):
18194         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
18195         (summarized_results):
18196         (SummarizedResultsTest.test_summarized_results_wontfix):
18197         (SummarizedResultsTest):
18198         (SummarizedResultsTest.test_summarized_results_include_passes):
18199         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
18200         (parse_args):
18202 2013-08-22  Ryosuke Niwa  <rniwa@webkit.org>
18204         WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that.
18206         * Scripts/webkitpy/tool/bot/irc_command.py:
18207         (Hi.execute):
18209 2013-08-22  Allan Sandfeld Jensen  <allan.jensen@digia.com>
18211         [Qt] DRT bug revealed/caused by r154300
18212         https://bugs.webkit.org/show_bug.cgi?id=120151
18214         Reviewed by Simon Hausmann.
18216         Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor,
18217         the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot
18218         in r154300.
18220         DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish
18221         between native Qt methods and JSC bound methods. This patch changes the check to see if the 
18222         property is writable since the Qt methods are ReadOnly.
18224         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
18225         (DumpRenderTree::initJSObjects):
18227 2013-08-21  Joseph Pecoraro  <pecoraro@apple.com>
18229         <https://webkit.org/b/120134> [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings
18231         Reviewed by Benjamin Poulain.
18233         WTFString moved the is8bit bit by one in r152201.
18235         * lldb/lldb_webkit.py:
18236         (WTFStringImplProvider.is_8bit):
18238 2013-08-21  Tim Horton  <timothy_horton@apple.com>
18240         Revert http://trac.webkit.org/changeset/154022, as it failed to update
18241         a variety of scripts that depended on the old format.
18243         See https://bugs.webkit.org/show_bug.cgi?id=120131 for one such example.
18245         * Scripts/prepare-ChangeLog:
18246         (main):
18247         (generateNewChangeLogs):
18249 2013-08-21  Brent Fulgham  <bfulgham@apple.com>
18251         [Windows] Unreviewed gardening: WebInspector should always be enabled for WinLauncher.
18253         * WinLauncher/WinLauncher.cpp:
18254         (setToDefaultPreferences): Activate Developer Extras on Release (as well as Debug) builds.
18256 2013-08-21  Zan Dobersek  <zdobersek@igalia.com>
18258         <https://webkit.org/b/120116> [GTK] Fix a typo in ActivateFontsGtk.cpp
18260         Reviewed by Andreas Kling.
18262         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
18263         (WTR::initializeFontConfigSetting): Fix a typo - inititialize -> initialize.
18264         (WTR::activateFonts): Ditto.
18266 2013-08-21  Brian Holt  <brian.holt@samsung.com>
18268         [GTK] Suppress irrelevant or known leaks for Valgrind
18269         https://bugs.webkit.org/show_bug.cgi?id=119448
18271         Reviewed by Martin Robinson.
18273         Add a suppressions file to suppress known leaks for Valgrind.
18274         Valgrind also takes longer when using suppressions and
18275         times out unless the driver timeout is increased.
18277         * Scripts/valgrind/suppressions.txt: Added.
18278         * Scripts/webkitpy/port/gtk.py:
18279         (GtkPort.driver_stop_timeout):
18280         (GtkPort.setup_environ_for_server):
18282 2013-08-20  Alex Christensen  <achristensen@apple.com>
18284         [Windows] Linking fix for Win64.
18286         Rubberstamped by Brent Fulgham.
18288         * win/DLLLauncher/DLLLauncherMain.cpp:
18289         (wWinMain): Corrected 64-bit linker symbol for dllLauncherEntryPoint.
18291 2013-08-20  Brent Fulgham  <bfulgham@apple.com>
18293         <https://webkit.org/b/120090> Report better error messages from WinLauncher/DRT
18295         Reviewed by Tim Horton.
18297         * win/DLLLauncher/DLLLauncherMain.cpp:
18298         (getLastErrorString): New method to convert GetLastError to text.
18299         (wWinMain): Use new error formatter to provide useful diagnostic text to user.
18301 2013-08-19  Gustavo Noronha Silva  <gns@gnome.org>
18303         <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings
18305         Reviewed by Martin Robinson.
18307         * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
18308         from naming/enum_casing rules, since it needs to provide GObject-style APIs.
18310 2013-08-20  Anton Obzhirov  <a.obzhirov@samsung.com>
18312         <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser
18314         Reviewed by Martin Robinson.
18316         Added stop button in MiniBrowser
18318         * MiniBrowser/gtk/BrowserWindow.c:
18319         (reloadOrStopCallback): Callback to handle stop or reload button click.
18320         (webViewLoadProgressChanged): Update reload or stop button icon.
18321         (browser_window_init): Save button pointer for further icon updates.
18323 2013-08-20  Simon Pena  <simon.pena@samsung.com>
18325         <https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
18327         Reviewed by Alexey Proskuryakov.
18329         Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status,
18330         printing didFailLoadWithError.
18332         Behave like other ports, and handle WEBKIT_LOAD_FAILED status in
18333         DumpRenderTree, printing didFailLoadWithError.
18335         * DumpRenderTree/gtk/DumpRenderTree.cpp:
18336         (webFrameLoadStatusNotified):
18338 2013-08-19  Ryosuke Niwa  <rniwa@webkit.org>
18340         <https://webkit.org/b/120049> Delete code for Snow Leopard
18342         Reviewed by Benjamin Poulain.
18344         * DumpRenderTree/mac/CheckedMalloc.cpp:
18345         (protectionOfRegion):
18346         (makeLargeMallocFailSilently):
18347         * DumpRenderTree/mac/DumpRenderTree.mm:
18348         (resetDefaultsToConsistentValues):
18349         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
18350         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
18351         * DumpRenderTree/mac/FrameLoadDelegate.mm:
18352         (testPathFromURL):
18353         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
18354         * DumpRenderTree/mac/LayoutTestHelper.m:
18355         * DumpRenderTree/mac/TestRunnerMac.mm:
18356         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
18357         (WTR::InjectedBundle::platformInitialize):
18358         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
18359         (WTR::testPathFromURL):
18360         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
18362 2013-08-19  Alexey Proskuryakov  <ap@apple.com>
18364         https://bugs.webkit.org/show_bug.cgi?id=119915
18365         REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
18367         Reviewed by Darin Adler.
18369         The issue was that we ended up having no CFNetwork cache in the testing session due
18370         to an incorrect cache model. There is a number of things not implemented when it
18371         comes to dynamically changing cache model as attempted by WebKitTestRunner, but
18372         the easiest way to get this going is to initialize it to correct value upfront.
18374         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
18376 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
18378         REGRESSION(r154275): webkitpy tests failing
18379         https://bugs.webkit.org/show_bug.cgi?id=120010
18381         Reviewed by Jocelyn Turcotte.
18383         Update unit-tests to tests the new search-path structure,
18384         but reverting the architecture search path addition.
18386         * Scripts/webkitpy/port/qt.py:
18387         (QtPort):
18388         (QtPort.__init__):
18389         (QtPort._generate_all_test_configurations):
18390         (QtPort.qt_architecture):
18391         * Scripts/webkitpy/port/qt_unittest.py:
18392         (QtPortTest):
18393         (QtPortTest._assert_search_path):
18394         (QtPortTest._assert_expectations_files):
18395         (QtPortTest._qt_version):
18397 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
18399         [Qt] Keep the qt-5.0-wk2 search path until the expectation migration is completed
18401         Unreviewed meta gardening.
18403         We need to keep using the qt-5.0-wk2 path until it is fully migrated.
18405         * Scripts/webkitpy/port/qt.py:
18406         (QtPort._search_paths):
18408 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
18410         Restructure Qt test expectations
18412         Unreviewed meta gardening.
18414         Removed 5.0 name from WK1 and WK2 results and made it possible to set
18415         expectations by both Qt version and mayor architectures.
18417         * Scripts/webkitpy/port/qt.py:
18418         (QtPort._wk2_port_name):
18419         (QtPort.__init__):
18420         (QtPort.qt_version):
18421         (QtPort.architecture):
18422         (QtPort._search_paths):
18423         (QtPort._port_specific_expectations_files):
18425 2013-08-16  Brent Fulgham  <bfulgham@apple.com>
18427         [Windows] DRT is not using the same preferences as the Mac build.
18428         https://bugs.webkit.org/show_bug.cgi?id=119822
18430         Reviewed by Darin Adler.
18432         * DumpRenderTree/win/DumpRenderTree.cpp:
18433         (runTest): Process Windows message queue using CFRunLoop to allow
18434         dispatch routines to run properly.
18435         (dllLauncherEntryPoint): Wrap CG-specific setup code in a macro
18436         to prevent problems on WinCairo port.
18438 2013-08-16  Brent Fulgham  <bfulgham@apple.com>
18440         [Windows] URL printing code in DRT doesn't match WTR or Mac DRT
18441         https://bugs.webkit.org/show_bug.cgi?id=119583
18443         Reviewed by Alexey Proskuryakov.
18445         * DumpRenderTree/win/DumpRenderTree.cpp:
18446         (urlSuitableForTestResult): Revise URL output to match Mac DRT by emiting last path
18447         component if the URL does not contain the expected base URL.
18449 2013-08-16  Pratik Solanki  <psolanki@apple.com>
18451         <https://webkit.org/b/119852> Frame::scriptController() should return a reference
18453         Reviewed by Andreas Kling.
18455         m_script is never NULL so we can just return a reference. Also remove some pointless null
18456         checks as a result of doing this.
18458         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
18459         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
18461 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
18463         [WK2] NetworkProcess should use a temporary storage session for test
18464         https://bugs.webkit.org/show_bug.cgi?id=119855
18466         Reviewed by Darin Adler.
18468         Use a new API that takes care of both WebProcess and NetworkProcess.
18470         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
18471         (WTR::InjectedBundle::initialize):
18472         * WebKitTestRunner/TestController.cpp:
18473         (WTR::TestController::initialize):
18475 2013-08-15  Bem Jones-Bey  <bjonesbe@adobe.com>
18477         <https://webkit.org/b/119850> Speed up test importing by doing all the regex matching in a single pass
18479         Reviewed by Dirk Pranke.
18481         This is a port from Blink of
18482         https://src.chromium.org/viewvc/blink?revision=155647&view=revision
18483         originally by Dirk Pranke.
18485         From the original commit:
18487         This gives something like a 15x speedup over compiling and matching
18488         one property at a time and doing multiple passes over the file.
18490         * Scripts/webkitpy/w3c/test_converter.py:
18491         (W3CTestConverter.__init__):
18492         (W3CTestConverter.convert_prefixed_properties):
18493         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
18495 2013-08-15  Dan Bernstein  <mitz@apple.com>
18497         <https://webkit.org/b/119856> Improve extract-localizable-strings messages
18499         Reviewed by Darin Adler.
18501         * Scripts/extract-localizable-strings: When the strings file disagrees with the source code,
18502         added a message that points to the source code. Removed some unnecessary repetition of what
18503         is already in the file.
18505 2013-08-15  Andy Estes  <aestes@apple.com>
18507         <https://webkit.org/b/119853> REGRESSION (r139343): WebKit crashes when canceling a load inside webView:resource:didFinishLoadingFromDataSource:
18509         Reviewed by Brady Eidson.
18511         Wrote an API test that verifies -[WebView stopLoading:] can be called
18512         inside webView:resource:didFinishLoadingFromDataSource: without crashing.
18514         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
18515         * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: Added.
18516         (-[StopLoadingFromDidFinishLoadingDelegate webView:resource:didFinishLoadingFromDataSource:]):
18517         (TestWebKitAPI::TEST):
18519 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
18521         Adding Myles Maxfield to contributors.json.
18523         Oops, wrong section, fixing.
18525         * Scripts/webkitpy/common/config/contributors.json:
18527 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
18529         Adding Myles Maxfield to contributors.json.
18531         * Scripts/webkitpy/common/config/contributors.json:
18533 2013-08-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
18535         [Qt] Do not check specifically for version 5.0
18536         https://bugs.webkit.org/show_bug.cgi?id=119846
18538         Reviewed by Jocelyn Turcotte.
18540         For Qt 5.x we should always use both wk1 and wk2 basepath results.
18542         * Scripts/webkitpy/port/qt.py:
18543         (QtPort._search_paths):
18545 2013-08-15  Simon Pena  <simon.pena@samsung.com>
18547         <https://webkit.org/b/119584> [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
18549         Reviewed by Gustavo Noronha Silva.
18551         Following a similar approach as in r153977, return a path string
18552         that is relative to main frame URL or just file name if the
18553         resource is not in the same directory subtree, and replace empty
18554         strings with "(null)".
18556         Update pathFromSoupURI so it behaves more closely to the other
18557         ports, and remove the unused code after we no longer print
18558         <unknown> in certain cases. Also move
18559         soupURIToStringPreservingPassword to DumpRenderTreeGtk so it can
18560         be used both in TestRunnerGtk and in DumpRenderTree.
18562         * DumpRenderTree/gtk/DumpRenderTree.cpp:
18563         (soupURIToStringPreservingPassword): Moved from TestRunnerGtk so
18564         we can print Soup URIs with the password, since soup_uri_to_string
18565         doesn't preserve them.
18566         (pathFromSoupURI): Updated following EFL implementation in
18567         r153977, and return a WTFString instead of a CString.
18568         (convertSoupMessageToURLPath): Return "(null)" instead of empty
18569         strings, and handle the new return type of pathFromSoupURI.
18570         (convertWebResourceToURLPath): Use a GOwnPtr to hold the Soup URI
18571         reference, and handle the new return type of pathFromSoupURI.
18572         (descriptionSuitableForTestResult): Remove unused code.
18573         (didFinishLoading): Use convertResourceToURLPath.
18574         (didFailLoadingWithError): Use convertResourceToURLPath.
18575         (authenticationCallback): Display the URL of the authentication
18576         challenge.
18577         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Declare
18578         soupURIToStringPreservingPassword.
18579         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove
18580         soupURIToStringPreservingPassword.
18582 2013-08-14  Tim Horton  <timothy_horton@apple.com>
18584         Un-inline dataLog dumpers for IntSize and IntPoint
18585         https://bugs.webkit.org/show_bug.cgi?id=119697
18587         Reviewed by Sam Weinig.
18589         * TestWebKitAPI/GNUmakefile.am:
18591 2013-08-14  Ryosuke Niwa  <rniwa@webkit.org>
18593         Flakiness dashboard build fix.
18595         * TestResultServer/static-dashboards/flakiness_dashboard.js:
18596         (processTestRunsForBuilder):
18598 2013-08-14  Martin Robinson  <mrobinson@igalia.com>
18600         [GTK] [CMake] Add support for building TestWebKitAPI
18601         https://bugs.webkit.org/show_bug.cgi?id=116987
18603         Reviewed by Philippe Normand.
18605         * TestWebKitAPI/CMakeLists.txt: Move the library listings to before the inclusion of the
18606         platform-specific file, so that GTK+ can override them.
18607         * TestWebKitAPI/PlatformGTK.cmake: Added.
18609 2013-08-14  Brent Fulgham  <bfulgham@apple.com>
18611         [Windows] Simplify Setting WebKit Debugging Options in WinLauncher
18612         https://bugs.webkit.org/show_bug.cgi?id=119775
18614         This bug updates the WinLauncher program with a few useful menu
18615         options to toggle certain debugging and development features of
18616         WebKit.
18618         Reviewed by Tim Horton.
18620         * WinLauncher/WinLauncher.cpp:
18621         (dllLauncherEntryPoint): Clean up preference objects on exit.
18622         (ToggleMenuItem): New function.
18623         (LaunchInspector): New function.
18624         (WndProc): Add handler for new menu items. Also properly terminate
18625         CFRunLoop operation on program exit.
18626         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new
18627         menu items.
18628         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Add
18629         resource folder to search path.
18630         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
18631         for new menu items.
18633 2013-08-14  Ryosuke Niwa  <rniwa@webkit.org>
18635         Add a hyperlink from build.webkit.org to the flakiness dashboard.
18637         Rubbers-tamped by Simon Fraser.
18639         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
18641 2013-08-14  Benjamin Dupont   <bdupont@nds.com>
18643         [Qt] Activate visibility API layout tests
18644         https://bugs.webkit.org/show_bug.cgi?id=119790
18646         Reviewed by Allan Sandfeld Jensen.
18648         * DumpRenderTree/qt/TestRunnerQt.cpp:
18649         (TestRunner::resetPageVisibility):
18650         (TestRunner::setPageVisibility):
18652 2013-08-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
18654         [GTK] WK does not link properly against libxslt
18655         https://bugs.webkit.org/show_bug.cgi?id=119688
18657         Reviewed by Gustavo Noronha Silva.
18659         * MiniBrowser/gtk/GNUmakefile.am: Added LIBXSLT_LIBS to
18660         MiniBrowser.
18661         * WebKitTestRunner/GNUmakefile.am: Added LIBXSLT_LIBS to WTR.
18663 2013-08-13  Alexey Proskuryakov  <ap@apple.com>
18665         [Mac] fast/dom/attr-style-too-lazy.html is flaky
18666         https://bugs.webkit.org/show_bug.cgi?id=119763
18668         Reviewed by Darin Adler.
18670         * DumpRenderTree/mac/UIDelegate.mm:
18671         (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
18672         a test, it would just semi-randomly leak to the next one.
18673         (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
18674         for good measure.
18676 2013-08-13  Tim Horton  <timothy_horton@apple.com>
18678         [mac] Give MiniBrowser a reasonable bundle identifier
18679         https://bugs.webkit.org/show_bug.cgi?id=119773
18681         Rubber-stamped by Simon Fraser.
18683         Give MiniBrowser the bundle identifier org.webkit.MiniBrowser.
18685         * MiniBrowser/mac/Info.plist:
18686         * MiniBrowser/mac/WebBundle/Info.plist:
18688 2013-08-13  Dean Jackson  <dino@apple.com>
18690         <https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
18692         Reviewed by Mark Rowe.
18694         Have prepare-ChangeLog produce webkit.org/b/id style
18695         URLs rather than exposing the inner workings of our
18696         cgi. I was going to use the term "Future Proofing"
18697         but that seems excessive :)
18699         * Scripts/prepare-ChangeLog:
18700         (main): Generate a more human readable form.
18701         (generateNewChangeLogs): Use it when printing out the ChangeLog entry.
18703 2013-08-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
18705         [EFL][DRT] Simplify call to reverseFind()
18706         https://bugs.webkit.org/show_bug.cgi?id=119746
18708         Reviewed by Christophe Dumez.
18710         Follow-up to r153977.
18712         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
18713         (pathSuitableForTestResult): Instead of defining a static variable
18714         that's only used in a single place, pass '/' to reverseFind() directly.
18716 2013-08-13  Alberto Garcia  <berto@igalia.com>
18718         [GTK] Closing inspector window crashes wk
18719         https://bugs.webkit.org/show_bug.cgi?id=110865
18721         Reviewed by Carlos Garcia Campos.
18723         Disconnect all signal handlers if the inspector window is
18724         destroyed.
18726         * GtkLauncher/LauncherInspectorWindow.c:
18727         (inspectorWindowDestroyed):
18728         (launcherInspectorWindowNew):
18730 2013-08-12  Dan Bernstein  <mitz@apple.com>
18732         extract-localizable-strings output is not suited for parsing by Xcode
18733         https://bugs.webkit.org/show_bug.cgi?id=119728
18735         Reviewed by Darin Adler.
18737         Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
18738         removed “ERROR” since messages that refer to a line in a file are shown as error by default,
18739         added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
18740         with 0).
18742         * Scripts/extract-localizable-strings:
18744 2013-08-12  Ryuan Choi  <ryuan.choi@samsung.com>
18746         [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
18747         https://bugs.webkit.org/show_bug.cgi?id=119585
18749         Reviewed by Gyuyoung Kim.
18751         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
18752         (pathSuitableForTestResult):
18753         Return path string that's relative to main frame URL, or just file name if
18754         the resource is not in the same directory subtree.
18755         Referenced WebKitTestRunner code in r153852.
18756         (descriptionSuitableForTestResult):
18757         (DumpRenderTreeChrome::onFrameRedirectRequested):
18758         (DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.
18760 2013-08-12  Dan Bernstein  <mitz@apple.com>
18762         extract-localizable-strings doesn't know how to verify an existing strings file
18763         https://bugs.webkit.org/show_bug.cgi?id=119704
18765         Reviewed by Darin Adler.
18767         * Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
18768         exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
18769         exceptions file name to omitting the --exceptions option. Added a --skip option, changing
18770         the way directories to skip are specified from prefixing the directory with a “-” to
18771         specifying it with --skip.
18772         Finally, added a --verify option. When specified, the strings file is not written to, but
18773         instead read in and checked for consistency with the comments, keys and values derived from
18774         the source files and the exceptions file. Missing keys, unused keys, mismatching values and
18775         mismatching comments are reported as errors.
18776         * Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
18777         directories to skip and no exceptions file.
18779 2013-08-12  Alexey Proskuryakov  <ap@apple.com>
18781         http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
18782         https://bugs.webkit.org/show_bug.cgi?id=85522
18784         Reviewed by Andy Estes.
18786         * DumpRenderTree/mac/UIDelegate.mm:
18787         (-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
18788         when already done with a test. We already had this check in all UI delegate functions,
18789         except for -webView:addMessageToConsole:withSource: somehow.
18791 2013-08-12  Alexey Proskuryakov  <ap@apple.com>
18793         https://bugs.webkit.org/show_bug.cgi?id=119693
18794         [Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
18795         because of connect-src-websocket-allowed.html
18797         Reviewed by Darin Adler.
18799         Starting a load of about:blank and immediately stopping it cancels outstanding
18800         resource loads, but the page has to transition to committed state to have timers
18801         or WebSockets stopped too.
18803         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
18804         ensure that transition to committed state happens before we start the next test.
18806 2013-08-12  Beth Dakin  <bdakin@apple.com>
18808         The LayoutMilestones didLayout callback should only fire for the main frame
18809         https://bugs.webkit.org/show_bug.cgi?id=119457
18811         Reviewed by Sam Weinig.
18813         Now that the didLayout callback only fires for the main frame, we want to make 
18814         sure it will fire even when all of the content is in a subframe.
18816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
18817         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
18818         (TestWebKitAPI::didLayout):
18819         (TestWebKitAPI::TEST):
18820         * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
18822 2013-08-12  Beth Dakin  <bdakin@apple.com>
18824         Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
18825         https://bugs.webkit.org/show_bug.cgi?id=119658
18827         Reviewed by Darin Adler.
18829         * MiniBrowser/mac/WK2BrowserWindowController.m:
18830         (-[WK2BrowserWindowController awakeFromNib]):
18831         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
18832         (WTR::InjectedBundlePage::InjectedBundlePage):
18833         * WebKitTestRunner/TestController.cpp:
18834         (WTR::TestController::createWebViewWithOptions):
18836 2013-08-12  Seokju Kwon  <seokju@webkit.org>
18838         Remove glu's libtest rule from checker.py
18839         https://bugs.webkit.org/show_bug.cgi?id=119674
18841         Reviewed by Darin Adler.
18843         * Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
18845 2013-08-11  ChangSeok Oh  <changseok.oh@collabora.com>
18847         Unreviewed. Change my primary mail address.
18849         * Scripts/webkitpy/common/config/contributors.json:
18851 2013-08-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
18853         [GTK] Misses mod_ssl and php in the list of packages required for tests for yum
18854         https://bugs.webkit.org/show_bug.cgi?id=115751
18856         Reviewed by Martin Robinson.
18858         * gtk/install-dependencies: add mod_ssl and php to the packages installed for tests
18859         with yum.
18861 2013-08-09  Beth Dakin  <bdakin@apple.com>
18863         AX: Not able to use arrow keys to read text in a WK2 app
18864         https://bugs.webkit.org/show_bug.cgi?id=119605
18865         -and corresponding-
18866         <rdar://problem/14281275>
18868         Reviewed by Darin Adler.
18870         New test verifies that didNotHandleKeyEvent will be called when there is nothing 
18871         to scroll. 
18872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
18873         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.
18874         (TestWebKitAPI::didFinishLoadForFrame):
18875         (TestWebKitAPI::didNotHandleKeyEventCallback):
18876         (TestWebKitAPI::TEST):
18878 2013-08-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
18880         Add support for KeyboardEvent.location attribute
18881         https://bugs.webkit.org/show_bug.cgi?id=119326
18883         Reviewed by Benjamin Poulain.
18885         Rename the deprecated 'keyLocation' to 'location' in Mac's DRT code.
18887         * DumpRenderTree/mac/EventSendingController.mm:
18888         (-[EventSendingController keyDown:withModifiers:withLocation:]):
18889         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
18890         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
18891         (-[EventSendingController handleEvent:]):
18892         (-[EventSendingController fireKeyboardEventsToElement:]):
18894 2013-08-09  Alexey Proskuryakov  <ap@apple.com>
18896         <unknown> is often dumped instead of path in test output
18897         https://bugs.webkit.org/show_bug.cgi?id=119590
18899         Reviewed by Anders Carlsson.
18901         There were two reasons for <unknown>:
18902         1. When delegate logging is enabled via a testRunner call, that obviously happens
18903         after main resource load starts, so we don't record its URL.
18904         2. Authentication delegate logging relied on URL recording, but it's only turned on
18905         when enabling resource loading delegate logging, not auth one.
18907         URL recording was made conditional in <http://trac.webkit.org/r19316>, which was
18908         landed without posted rationale and unreviewed. Just undoing that change now.
18910         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
18911         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
18912         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
18913         (WTR::InjectedBundlePage::didInitiateLoadForResource):
18915 2013-08-08  Alex Christensen  <achristensen@apple.com>
18917         Windows build fixes.
18919         Rubberstamped by Brent Fulgham.
18921         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
18922         Removed /SAFESEH link option which doesn't work with x64.
18924 2013-08-08  Daniel Bates  <dabates@apple.com>
18926         Add iOS support to run-javascriptcore-tests
18927         https://bugs.webkit.org/show_bug.cgi?id=119602
18929         Reviewed by Joseph Pecoraro.
18931         Make run-javascriptcore-tests work for iOS WebKit.
18933         * Scripts/run-javascriptcore-tests:
18935 2013-08-08  Alexey Proskuryakov  <ap@apple.com>
18937         [WK2] loader/go-back-cached-main-resource.html fails
18938         https://bugs.webkit.org/show_bug.cgi?id=116491
18940         Reviewed by Tim Horton.
18942         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
18943         * DumpRenderTree/gtk/DumpRenderTree.cpp:
18944         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
18945         * DumpRenderTree/win/DumpRenderTree.cpp:
18946         Added FIXMEs about making path printing normalization more compatible.
18948         * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
18949         Return last path component in cases where we used to return a full path, which is
18950         never desirable. Added a null check to basePath to prevent potentially getting
18951         an Objective C exception.
18953         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
18954         (WTR::pathSuitableForTestResult): Changed to use path for main test window, not
18955         for a currently loading one (which is different for tests that use multiple windows).
18956         Changed to return "(null)" for empty URLs to match WK1 output. Changed to return
18957         last path component as last fallback.
18958         (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main
18959         frame URL here, and it was potentially a wrong frame.
18960         (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto.
18961         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto.
18962         (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto.
18963         (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto.
18964         (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.
18966 2013-08-08  Alex Christensen  <achristensen@apple.com>
18968         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
18969         https://bugs.webkit.org/show_bug.cgi?id=116125
18971         Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.
18973         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
18974         (WTR::pathSuitableForTestResult):
18975         Changed string operations to match _drt_descriptionSuitableForTestResult.
18976         (WTR::dumpRequestDescriptionSuitableForTestResult):
18977         (WTR::dumpResponseDescriptionSuitableForTestResult):
18978         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
18979         (WTR::InjectedBundlePage::didInitiateLoadForResource):
18980         (WTR::InjectedBundlePage::willSendRequestForFrame):
18981         (WTR::InjectedBundlePage::didReceiveResponseForResource):
18982         Pass the main frame's URL to pathSuitableForTestResult.
18983         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
18984         Added WKBundlePageRef to willPerformClientRedirectForFrame.
18986 2013-08-07  Simon Fraser  <simon.fraser@apple.com>
18988         Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
18989         https://bugs.webkit.org/show_bug.cgi?id=119317
18991         Reviewed by Tim Horton.
18992         
18993         The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
18994         the test to complete, which is not power friendly. Although DRT instances
18995         are generally busy anyway, not sitting in a busy loop should free up some CPU
18996         cycles for other instances of DRT.
18997         
18998         Editing tests continue to pass. All Java tests are skipped and were not
18999         tested, but when run fail similarly with and without the patch.
19001         * DumpRenderTree/mac/DumpRenderTree.mm:
19002         (dump):
19003         (runTest):
19005 2013-08-07  Daniel Bates  <dabates@apple.com>
19007         Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
19008         <https://bugs.webkit.org/show_bug.cgi?id=119558>
19010         Reviewed by Martin Robinson.
19012         Currently we build the command line to execute jsDriver.pl twice so as to both
19013         print it to standard output and actually execute it. We should only build up
19014         this command line once. Moreover, we should print to standard output the actual
19015         command line that we are going to use including the GTK- and EFL-specific call
19016         to /Tools/jhbuild/jhbuild-wrapper.
19018         * Scripts/run-javascriptcore-tests:
19020 2013-08-07  Mario Sanchez Prada  <mario.prada@samsung.com>
19022         [EFL] REGRESSION after r153432: some accessibility tests crash.
19023         https://bugs.webkit.org/show_bug.cgi?id=119333
19025         Reviewed by Darin Adler.
19027         Use a RefPtr to store a reference to the parent element of
19028         an AccessibilityUIElement instead of the raw pointer, so we
19029         never derefence a function from an invalid pointer.
19031         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
19032         (WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
19034 2013-08-07  Cosmin Truta  <ctruta@blackberry.com>
19036         Unreviewed. Add myself as a committer.
19038         * Scripts/webkitpy/common/config/contributors.json:
19040 2013-08-04  Sam Weinig  <sam@webkit.org>
19042         Remove support for HTML5 MicroData
19043         https://bugs.webkit.org/show_bug.cgi?id=119480
19045         Reviewed by Anders Carlsson.
19047         * Scripts/webkitperl/FeatureList.pm:
19048         * qmake/mkspecs/features/features.pri:
19050 2013-07-23  David Farler  <dfarler@apple.com>
19052         Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
19053         https://bugs.webkit.org/show_bug.cgi?id=117762
19055         Reviewed by Mark Rowe.
19057         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
19058         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
19059         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
19060         Add ASAN_OTHER_LDFLAGS.
19061         * MiniBrowser/Configurations/DebugRelease.xcconfig:
19062         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
19063         * Scripts/check-for-weak-vtables-and-externals:
19064         Ignore ___asan externals, these are populated by compiler-rt.
19065         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
19066         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
19067         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
19068         Add ASAN_OTHER_LDFLAGS.
19069         * WebKitLauncher/Configurations/Base.xcconfig:
19070         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
19071         * WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:
19072         Add ASAN_OTHER_LDFLAGS.
19073         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
19074         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
19075         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
19076         Add ASAN_OTHER_LDFLAGS.
19077         * asan/asan.xcconfig: Added.
19078         * asan/webkit-asan-ignore.txt: Added.
19080 2013-08-05  Brian Holt  <brian.holt@samsung.com>
19082         [GTK] Implement leak checking with valgrind
19083         https://bugs.webkit.org/show_bug.cgi?id=118785
19085         Reviewed by Dirk Pranke.
19087         Launch the DRT under Valgrind to generate xml files with details
19088         of leaks found.
19090         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
19091         (parse_args):
19092         * Scripts/webkitpy/port/gtk.py:
19093         (GtkPort.__init__):
19094         (GtkPort.default_timeout_ms): Allow extra time to run under
19095         Valgrind.
19096         (GtkPort.setup_environ_for_server): Pass Valgrind instructions
19097         using environment variables.
19099 2013-08-02  Mario Sanchez Prada  <mario.prada@samsung.com>
19101         [EFL] REGRESSION after r153432: some accessibility tests crash.
19102         https://bugs.webkit.org/show_bug.cgi?id=119333
19104         Reviewed by Gustavo Noronha Silva.
19106         Add missing null-check to avoid dereferencing a non-existent parent.
19108         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
19109         (WTR::attributesOfElement): Ditto.
19111 2013-08-02  Patrick Gansterer  <paroga@webkit.org>
19113         Add --rmdir option to git svn dcommit
19114         https://bugs.webkit.org/show_bug.cgi?id=119398
19116         Reviewed by Ryosuke Niwa.
19118         Add this option tells git-svn to remove empty directories
19119         from the svn tree so they do not leave over there.
19121         * Scripts/webkitpy/common/checkout/scm/git.py:
19122         (Git.push_local_commits_to_server):
19124 2013-08-01  Brent Fulgham  <bfulgham@apple.com>
19126         [Windows] WebKit1 Fullscreen Video Play is Broken
19127         https://bugs.webkit.org/show_bug.cgi?id=119415
19129         Reviewed by Jer Noble.
19131         * WinLauncher/WinLauncher.cpp:
19132         (dllLauncherEntryPoint): Activate full screen mode via
19133         IWebPreferencesInternal interface.
19135 2013-08-01  ChangSeok Oh  <changseok.oh@collabora.com>
19137         Unreviewed. Add an alternative address to show my affiliation in team.html.
19139         * Scripts/webkitpy/common/config/contributors.json:
19141 2013-08-01  Bem Jones-Bey  <bjonesbe@adobe.com>
19143         Duplicate property names can cause test to fail
19144         https://bugs.webkit.org/show_bug.cgi?id=119399
19146         Reviewed by Dirk Pranke.
19148         This problem was noticed when porting the patch for
19149         http://wkb.ug/119357 to Blink: a test would fail because the converted
19150         and test property lists weren't the same length, but they contained
19151         all of the same property names. It looks like this is actually caused
19152         by a bug in converting the HTML, which is being currently rewritten.
19153         In the meantime, as long as this compares the number of unique
19154         properties, it makes the test more robust.
19156         * Scripts/webkitpy/w3c/test_converter_unittest.py:
19157         (verify_prefixed_properties):
19159 2013-08-01  Bem Jones-Bey  <bjonesbe@adobe.com>
19161         Unreviewed. Adding my expertise.
19163         * Scripts/webkitpy/common/config/contributors.json:
19165 2013-08-01  ChangSeok Oh  <changseok.oh@collabora.com>
19167         Unreviewed. Add myself as a committer. Yoo-hoo! \o/
19169         * Scripts/webkitpy/common/config/contributors.json:
19171 2013-08-01  Commit Queue  <commit-queue@webkit.org>
19173         Unreviewed, rolling out r153518.
19174         http://trac.webkit.org/changeset/153518
19175         https://bugs.webkit.org/show_bug.cgi?id=119386
19177         The Jhbuild dep bump of GTK+ is not actually required by
19178         layout testing, is causing pango dep problems (Requested by
19179         zdobersek on #webkit).
19181         * gtk/jhbuild.modules:
19183 2013-08-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
19185         Unreviewed. Add myself as a committer.
19187         * Scripts/webkitpy/common/config/contributors.json:
19189 2013-08-01  Jaehun Lim  <ljaehun.lim@samsung.com>
19191         Unreviewed. Add myself as a committer.
19193         * Scripts/webkitpy/common/config/contributors.json:
19195 2013-07-31  Jinwoo Song  <jinwoo7.song@samsung.com>
19197         Unreviewed. Add myself as a committer.
19199         * Scripts/webkitpy/common/config/contributors.json:
19201 2013-08-01  Alberto Garcia  <berto@igalia.com>
19203         Unreviewed. Add myself as a committer.
19205         * Scripts/webkitpy/common/config/contributors.json:
19207 2013-07-31  Seokju Kwon  <seokju@webkit.org>
19209         Unreviewed. Add myself as a committer.
19211         * Scripts/webkitpy/common/config/contributors.json:
19213 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
19215         W3C test import script prefixes some properties that it shouldn't
19216         https://bugs.webkit.org/show_bug.cgi?id=119357
19218         Reviewed by Dirk Pranke.
19220         Some prefixed properties also have unprefixed implemetations, but when
19221         the implementations aren't identical, they aren't declared in
19222         CSSPropertyNames.in on the same line. This fixes the import script so
19223         that it catches all instances of prefixed properties that have an
19224         unprefixed variant, and does not add the prefix in those cases.
19226         * Scripts/webkitpy/w3c/test_converter.py:
19227         (W3CTestConverter.read_webkit_prefixed_css_property_list): Read all of
19228         the properties on every line and record if they are prefixed or not.
19229         Use this information to only return prefixed properties that do not
19230         have any unprefixed variant. The prefixed property list has also
19231         changed to not include the '-webkit-' prefix, making it much easier to
19232         do the comparison, and removing the need to remove the prefix later.
19233         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): This no
19234         longer needs to remove the '-webkit-' prefix, but needs to add it in
19235         the case where a property that needs a prefix is found.
19236         * Scripts/webkitpy/w3c/test_converter_unittest.py:
19237         (W3CTestConverterTest.test_read_prefixed_property_list): Remove assert
19238         for '-webkit-' prefix, as it is no longer included in the properties
19239         in the prefixed property list.
19241 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
19243         Update location of w3c shapes tests to reflect new import location
19244         https://bugs.webkit.org/show_bug.cgi?id=118156
19246         Reviewed by Dirk Pranke.
19248         Partial imports should not be imported to the same place as the full
19249         import, so this adds an option to allow importing to a different
19250         location than the default. In doing that, I found that imports from
19251         contributor directories didn't seem to be working correctly, so I
19252         updated the import to be smarter about both contributor directories
19253         and the test status directories. It should now be more likely that the
19254         script guesses the root directory properly.
19256         * Scripts/webkitpy/w3c/test_importer.py: Remove comment about the
19257             script not working with the full set of contributors, as that is
19258             no longer true, and I didn't see a good way to keep that behavior.
19259             Also update documentation to properly explain what happens when a
19260             contributor dir is imported.
19261         (main): Attempt to find the proper repo dir by looking at the
19262             directory above the "test status" in the given path, this is still
19263             not exactly right, but is less error prone than just trimming.
19264         (parse_args): Add -d option to set the import directory.
19265         (TestImporter.__init__): Stop appending the subdirs to the
19266             destination_directory because it was making things more complex
19267             and isn't really needed.
19268         (TestImporter.update_test_status): Remove hardcoded strings and use
19269             the TEST_STATUS constants instead.
19270         * Scripts/webkitpy/w3c/test_importer_unittest.py:
19271         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add
19272             support for new option.
19273         (TestImporterTest.test_import_dir_with_no_tests): Ditto.
19275 2013-07-31  Brent Fulgham  <bfulgham@apple.com>
19277         [Windows] Winlauncher shouldn't look for Safari Install Directory
19278         https://bugs.webkit.org/show_bug.cgi?id=119351
19280         Reviewed by Darin Adler.
19282         * win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for
19283         the Safari install location. Instead, use the proper support
19284         library path for the build architecture.
19286 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
19288         Update scripts to reference contributors.json instead of committers.py in messaging
19289         https://bugs.webkit.org/show_bug.cgi?id=119342
19291         Reviewed by Ryosuke Niwa.
19293         Change the scripts to point people to contributors.json instead of
19294         committers.py since the latter no longer contains the list of
19295         contributors.
19297         * Scripts/webkitpy/common/config/committervalidator.py:
19298         (CommitterValidator._contributors_json_path):
19299         (CommitterValidator._flag_permission_rejection_message):
19300         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
19301         (CommitterValidatorTest.test_flag_permission_rejection_message):
19302         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
19303         (Bugzilla._commit_queue_flag):
19304         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
19305         (WatchListParser._validate):
19306         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
19307         (WatchListParserTest.test_cc_rule_with_invalid_email):
19308         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
19309         * Scripts/webkitpy/tool/commands/queues_unittest.py:
19310         * Scripts/webkitpy/tool/steps/validatereviewer.py:
19311         (ValidateReviewer.run):
19313 2013-07-31  Roger Fong  <roger_fong@apple.com>
19315         Unreviewed. Re-enable WinEWS tests following r153527.
19317         * Scripts/webkitpy/common/config/ews.json:
19319 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
19321         Unreviewed: Adding myself to the committers' list.
19323         * Scripts/webkitpy/common/config/contributors.json:
19325 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
19327         [Qt] Build WebKit with C++11
19328         https://bugs.webkit.org/show_bug.cgi?id=119337
19330         Reviewed by Csaba Osztrogonác.
19332         Enable building with C++11.
19334         * qmake/mkspecs/features/default_pre.prf:
19335         * qmake/mkspecs/features/unix/default_post.prf:
19336         * qmake/mkspecs/features/unix/default_pre.prf:
19338 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
19340         [Qt] ASSERTS trigger in release builds
19341         https://bugs.webkit.org/show_bug.cgi?id=119336
19343         Reviewed by Jocelyn Turcotte.
19345         Ensure the qmake also defaults to release if no configuration is known.
19347         * qmake/mkspecs/features/default_post.prf:
19349 2013-07-31  Zan Dobersek  <zdobersek@igalia.com>
19351         [texmap][GStreamer][GTK] composited video shows tearing
19352         https://bugs.webkit.org/show_bug.cgi?id=118253
19354         Reviewed by Martin Robinson.
19356         * gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
19357         The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
19358         screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.
19360 2013-07-30  Ruth Fong  <ruth_fong@apple.com>
19362         Unreviewed: Adding myself to the committers' list.
19364         * Scripts/webkitpy/common/config/contributors.json:
19366 2013-07-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
19368         Unreviewed, add my new email to contributors.json.
19370         * Scripts/webkitpy/common/config/contributors.json:
19372 2013-07-30  Krzysztof Czech  <k.czech@samsung.com>
19374         [EFL] REGRESSION after r153439: layout tests do not run.
19375         https://bugs.webkit.org/show_bug.cgi?id=119240
19377         Reviewed by Christophe Dumez.
19379         Changed attribute name from check_xvfb to check_driver.
19381         * Scripts/webkitpy/port/efl.py:
19382         (EflPort.check_sys_deps):
19384 2013-07-29  Commit Queue  <commit-queue@webkit.org>
19386         Unreviewed, rolling out r152860.
19387         http://trac.webkit.org/changeset/152860
19388         https://bugs.webkit.org/show_bug.cgi?id=119227
19390         Disable WinEWS tests until tests stop crashing (Requested by
19391         rfong on #webkit).
19393         * Scripts/webkitpy/common/config/ews.json:
19395 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
19397         [GTK] Add WestonDriver, use it when appropriate
19398         https://bugs.webkit.org/show_bug.cgi?id=119100
19400         Reviewed by Dirk Pranke.
19402         Introduce the WestonDriver, a Driver-implementing class that sets up an instance of Weston, the Wayland compositor,
19403         and sets up an environment that enables the test runner to run inside it.
19405         The design very much mimics the XvfbDriver class. It is currently used by the GTK port when the WAYLAND_DISPLAY
19406         environment variable is set, that is when NRWT is being run under a Wayland display.
19408         * Scripts/webkitpy/port/base.py:
19409         (Port.to.setup_environ_for_server): Also copy the XDG_RUNTIME_DIR env from the original environment for Linux-using ports.
19410         * Scripts/webkitpy/port/gtk.py:
19411         (GtkPort):
19412         (GtkPort._driver_class): Make the method memoized - the display type is not going to change during the testing, so we
19413         should only check once for the presence of the WAYLAND_DISPLAY env and determine the proper driver class to use based on that.
19414         (GtkPort.check_sys_deps): Call the static check_driver method on the class as returned by the _driver_class method
19415         instead of hard-coding the XvfbDriver class in the check.
19416         * Scripts/webkitpy/port/westondriver.py: Added.
19417         (WestonDriver):
19418         (WestonDriver.check_driver): Similarly to XvfbDriver, this checks for existance of the weston executable.
19419         (WestonDriver.__init__): Again, like in XvfbDriver, we use a small delay between launching the Weston display and launching the driver.
19420         (WestonDriver._start): Sets up the driver-specific temporary directory, launches the Weston display, sets up the environment for the
19421         driver and then launches the driver in said environment, using the driver's Weston display.
19422         (WestonDriver.stop): Cleans up the Weston instance and the temporary directory.
19423         (WestonDriver._ensure_driver_tmpdir_subdirectory): A helper function that creates a subdirectory in the driver's temporary directory
19424         and returns the absolute path to it.
19425         * Scripts/webkitpy/port/xvfbdriver.py:
19426         (XvfbDriver.check_driver): Renamed from check_xvfb.
19427         (XvfbDriver._start): Access the FileSystem object through the Port's Host object, instead of the Port's private member.
19429 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
19431         [ATK] Implement attributesOfChildren() for AccessibilityUIElement
19432         https://bugs.webkit.org/show_bug.cgi?id=118967
19434         Reviewed by Gustavo Noronha Silva.
19436         Implemented AccessibilityUIElement::attributesOfChildren() both
19437         in DumpRenderTree and the WebKitTestRunner.
19439         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
19440         (AccessibilityUIElement::attributesOfChildren): Implemented.
19442         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
19443         (WTR::AccessibilityUIElement::attributesOfChildren): Implemented.
19445 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
19447         [ATK] Implement allAttributes() for AccessibilityUIElement
19448         https://bugs.webkit.org/show_bug.cgi?id=118966
19450         Reviewed by Gustavo Noronha Silva.
19452         Implemented AccessibilityUIElement::allAttributes() both in
19453         DumpRenderTree and the WebKitTestRunner.
19455         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
19456         (getAtkAttributeSetAsString): Moved up in the file, and refactored
19457         to use StringBuilder and return a String instead of a gchar*.
19458         (roleToString): Changed not to return the "AXRole: " prefix, so
19459         we can use it as well from attributesOfElement().
19460         (attributesOfElement): New function to dump attributes for an object.
19461         (AccessibilityUIElement::allAttributes): Call attributesOfElement().
19462         (AccessibilityUIElement::role): Updated to prefix "AXRole: ".
19464         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
19465         (getAtkAttributeSetAsString): Refactored to use StringBuilder and return
19466         a String instead of a gchar*.
19468         (WTF::roleToString): Changed not to return the "AXRole: " prefix,
19469         so we can use it as well from attributesOfElement().
19470         (WTF::attributesOfElement): New function to dump attributes for an object.
19471         (WTR::AccessibilityUIElement::allAttributes): Call attributesOfElement().
19472         (WTR::AccessibilityUIElement::role): Updated to prefix "AXRole: ".
19474 2013-07-29  Daniel Bates  <dabates@apple.com>
19476         Add support infrastructure for iOS WebKit port
19477         https://bugs.webkit.org/show_bug.cgi?id=119168
19479         Reviewed by Ryosuke Niwa.
19481         Implement support infrastructure towards building iOS WebKit.
19483         * Scripts/webkitdirs.pm:
19484         (xcodeSDKPlatformName): Added.
19485         (determineConfigurationProductDir):
19486         (builtDylibPathForName):
19487         (willUseIOSDeviceSDKWhenBuilding): Added.
19488         (willUseIOSSimulatorSDKWhenBuilding): Added.
19489         (isIOSWebKit): Added.
19490         (copyInspectorFrontendFiles):
19492 2013-07-29  Sergio Correia  <sergio.correia@openbossa.org>
19494         CoordinatedGraphics: Add API to get and set the active state of a WebView
19495         https://bugs.webkit.org/show_bug.cgi?id=119067
19497         Reviewed by Noam Rosenthal.
19499         Added API tests for WKViewIsActive and WKViewSetIsActive.
19501         * TestWebKitAPI/PlatformEfl.cmake:
19502         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Added.
19503         (TestWebKitAPI::didFinishLoadForFrame):
19504         (TestWebKitAPI::webProcessCrashed):
19505         (TestWebKitAPI::webProcessRelaunched):
19506         (TestWebKitAPI::TEST):
19507         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
19508         Bundle added to allow crashing the WebProcess and testing the active state of a view
19509         under such condition.
19510         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::WKViewIsActiveSetIsActiveTest):
19511         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::didReceiveMessage):
19513 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
19515         [Automake] Remove references to non-existent *_CFLAGS and *_LIBS variables
19516         https://bugs.webkit.org/show_bug.cgi?id=119212
19518         Reviewed by Carlos Garcia Campos.
19520         * GNUmakefile.am: Remove references to GLOBALDEPS_(CFLAGS|LIBS) and CLUTTER_(CFLAGS|LIBS)
19521         variables that are not defined during the configuration process.
19522         * TestWebKitAPI/GNUmakefile.am: Ditto.
19523         * WebKitTestRunner/GNUmakefile.am: Ditto.
19525 2013-07-28  Andy Estes  <aestes@apple.com>
19527         Include <stdio.h> to declare perror()
19528         https://bugs.webkit.org/show_bug.cgi?id=119198
19530         Reviewed by Andreas Kling.
19532         Silences an implicit declaration warning.
19534         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c:
19536 2013-07-27  Ryuan Choi  <ryuan.choi@samsung.com>
19538         [EFL] Bump required version of EFL to 1.7
19539         https://bugs.webkit.org/show_bug.cgi?id=119144
19541         Reviewed by Christophe Dumez.
19543         * MiniBrowser/efl/CMakeLists.txt: Bumped EFL to 1.7
19545 2013-07-26  Filip Pizlo  <fpizlo@apple.com>
19547         WKTR should know about the JSC extensions to testRunner
19548         https://bugs.webkit.org/show_bug.cgi?id=119154
19550         Reviewed by Mark Hahnenberg and Geoffrey Garen.
19551         
19552         This makes some fast/js tests pass.
19554         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
19555         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
19556         (WTR::TestRunner::numberOfDFGCompiles):
19557         (WTR::TestRunner::neverInlineFunction):
19558         * WebKitTestRunner/InjectedBundle/TestRunner.h:
19560 2013-07-25  Mark Rowe  <mrowe@apple.com>
19562         Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK.
19564         * DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
19565         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework
19566         so they pull the version out of the SDK.
19568 2013-07-25  Anders Carlsson  <andersca@apple.com>
19570         Localizable.strings generated by extract-localizable-strings should be UTF-8
19571         https://bugs.webkit.org/show_bug.cgi?id=119106
19573         Reviewed by Mark Rowe.
19575         Output strings as UTF-8.
19577         * Scripts/extract-localizable-strings:
19579 2013-07-25  Sam Weinig  <sam@webkit.org>
19581         -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
19582         https://bugs.webkit.org/show_bug.cgi?id=119099
19583         <rdar://problem/13439291>
19585         Reviewed by Enrica Casucci.
19587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19588         * TestWebKitAPI/Tests/mac/AttributedString.mm:
19589         (TestWebKitAPI::attributedString):
19590         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
19591         (TestWebKitAPI::AttributedStringTest_CustomFont::url):
19592         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
19593         (TestWebKitAPI::TEST_F):
19594         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
19595         (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
19596         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
19597         * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
19598         Add tests for attributed strings with strikethrough.  Refactor the attributed string tests
19599         to make adding more easier in the future.
19601 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
19603         fourthTier: FTL should be able to generate LLVM IR that uses an intrinsic for OSR exit
19604         https://bugs.webkit.org/show_bug.cgi?id=118948
19606         Reviewed by Sam Weinig.
19607         
19608         - Make ReducedFTL capable of dealing with code that uses the fake OSR exit intrinsic,
19609           by exporting it as a function.
19610         
19611         - Make combineModules.rb idempotent. Sometimes it's convenient to run a file through
19612           it even if you know that you've already done so. See processIRDump.sh.
19613         
19614         - Add a script, processIRDump.sh, that takes the output of --dumpLLVMIR=true and
19615           runs it through ReducedFTL automatically. You typically want to say something like:
19616           
19617           jsc --dumpLLVMIR=true <program(s)> > jsc-output.txt
19618           ./processIRDump.sh --timing < jsc-output.txt
19620         * ReducedFTL/ReducedFTL.c:
19621         (webkit_osr_exit):
19622         * ReducedFTL/combineModules.rb:
19623         * ReducedFTL/processIRDump.sh: Added.
19625 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
19627         fourthTier: We should use the no-asserts build of LLVM if that's what the user configured
19628         https://bugs.webkit.org/show_bug.cgi?id=118947
19630         Reviewed by Dan Bernstein.
19632         * Scripts/copy-webkitlibraries-to-product-directory:
19634 2013-07-16  Filip Pizlo  <fpizlo@apple.com>
19636         fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
19637         https://bugs.webkit.org/show_bug.cgi?id=118647
19639         Rubber stamped by Geoffrey Garen and Mark Hahnenberg.
19641         Add a tool that takes in an LLVM bitcode file and JITs it in exactly the same
19642         way that the FTL would.
19643         
19644         Also add a tool that combines multiple LLVM modules generated by FTL into a
19645         single module.
19647         * ReducedFTL: Added.
19648         * ReducedFTL/ReducedFTL.c: Added.
19649         (usage):
19650         (currentTime):
19651         (MemorySection):
19652         (mmAllocateCodeSection):
19653         (mmAllocateDataSection):
19654         (mmApplyPermissions):
19655         (mmDestroy):
19656         (symbolLookupCallback):
19657         (main):
19658         * ReducedFTL/build.sh: Added.
19659         * ReducedFTL/combineModules.rb: Added.
19661 2013-06-09  Filip Pizlo  <fpizlo@apple.com>
19663         Unreviewed, fix minor goof in profiling output layout. We weren't accounting
19664         for the "/" that is printed between engine counts.
19666         * Scripts/display-profiler-output:
19668 2013-05-28  Filip Pizlo  <fpizlo@apple.com>
19670         testRunner should have a way of disabling inlining of functions
19671         https://bugs.webkit.org/show_bug.cgi?id=116875
19673         Reviewed by Mark Hahnenberg.
19675         * DumpRenderTree/TestRunner.cpp:
19676         (neverInlineFunction):
19677         (TestRunner::staticFunctions):
19679 2013-05-27  Filip Pizlo  <fpizlo@apple.com>
19681         testRunner should be able to tell you if a function is DFG compiled
19682         https://bugs.webkit.org/show_bug.cgi?id=116847
19684         Reviewed by Mark Hahnenberg.
19686         * DumpRenderTree/TestRunner.cpp:
19687         (numberOfDFGCompiles):
19688         (TestRunner::staticFunctions):
19690 2013-05-21  Filip Pizlo  <fpizlo@apple.com>
19692         fourthTier: display-profiler-output should make it even easier to diff the compilation story between two different runs
19693         https://bugs.webkit.org/show_bug.cgi?id=116556
19695         Reviewed by Oliver Hunt.
19696         
19697         This adds three new capabilities:
19698         
19699         - 'display' now accepts negative compilation indices, and allows specifying
19700           wildcard hashes combined with combination indices. Previously you could say
19701           'display <hash>', 'display <hash>-<index>-<engine>', or 'display *'. The
19702           latter would display every compilation. This improves this so that you can
19703           say 'display *-<index>-<engine>'. It also makes it so that you can give a
19704           negative index, which allows you to say things like 'display blah--1-dfg',
19705           which displays just the last DFG compilation. Also you can say
19706           'display *--1-dfg', which displays the last DFG compilation for each code
19707           block. I realize that this is kind of ugly, but gosh is it practical.
19708         
19709         - You can now say 'sort hash', which will henceforth sort all of the output
19710           by code hash rather than by the time when it was compiled. This means that
19711           if you're doing 'dispay *--1-dfg' and then want to diff the results against
19712           something else, you can ensure that this doesn't get confused just by
19713           changes in compilation order.
19714         
19715         - You can now say 'counts off', which will henceforth disable the display of
19716           execution counts from 'bytecode' and 'display'. This is also useful for
19717           diffs, since if you're trying to figure out why two compilations are
19718           different, they probably have radically different counts. 'counts off' gets
19719           this out of the output so that it doesn't confuse your diff.
19720         
19721         Note that to use this effectively you should also have a script that scrubs
19722         pointers from text so that the diff doesn't get confused by pointers. I'll
19723         post my elimptr script to the bug. Maybe at some point I'll integrate that
19724         into display-profiler-output.
19725         
19726         Put together this is pretty awesome. I was able to do the following:
19727         
19728         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-serial.profile | elimptr > richards-serial.asm
19729         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-concurrent.profile | elimptr > richards-concurrent.asm
19730         diff -u richards-serial.asm richards-concurrent.asm
19731         
19732         And this immediately told me that the reason why richards is slower in the
19733         concurrent compilation case is just that we end up compiling *tons* more
19734         functions, most of which are trivially inlineable. Basically, concurrent
19735         compilation breaks our previous heuristics for delaying compilation of
19736         inlineables just enough that they never trigger compilation. We should fix
19737         that in a separate bug.
19739         * Scripts/display-profiler-output:
19741 2013-04-30  Filip Pizlo  <fpizlo@apple.com>
19743         fourthTier: Use hw.availcpu instead of hw.ncpu, and configure LLVM with --enable-zlib=no
19745         Rubber stamped by Mark Rowe.
19747         * Scripts/copy-webkitlibraries-to-product-directory:
19749 2013-07-16  Oliver Hunt <oliver@apple.com>
19751         Merge dfgFourthTier r148853
19753     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
19755         fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
19756         https://bugs.webkit.org/show_bug.cgi?id=114933
19758         Reviewed by Andy Estes.
19759         
19760         This makes it easy to get set up for tandem LLVM builds.
19762         * Scripts/copy-webkitlibraries-to-product-directory:
19764 2013-07-16  Oliver Hunt <oliver@apple.com>
19766         Merge dfgFourthTier r148850
19768     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
19770         fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
19771         https://bugs.webkit.org/show_bug.cgi?id=114926
19773         Reviewed by Geoffrey Garen.
19774         
19775         If the LLVM libraries change, then touch a phony header, which will force relink
19776         of JavaScriptCore.
19778         * Scripts/copy-webkitlibraries-to-product-directory:
19779         (unpackIfNecessary):
19781 2013-07-16  Oliver Hunt <oliver@apple.com>
19783         Merge dfgFourthTier r148848
19785     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
19787         fourthTier: developing LLVM in tandem with WebKit should be fun and easy
19788         https://bugs.webkit.org/show_bug.cgi?id=114925
19790         Reviewed by Geoffrey Garen.
19791         
19792         This enables building LLVM along with WebKit, so that build-jsc and build-webkit
19793         will also optionally build LLVM and quickly symlink LLVM's built products into
19794         the right places.
19795         
19796         Most WebKit and JSC hackers will want to rely on the checked-in already-built
19797         versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
19798         increasingly common use-case for me, and it may become a common use case for a
19799         handful of others. Currently, this is really painful: you first have to build
19800         LLVM, then you have to export-llvm-build (which takes a while), and then you
19801         have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
19802         variables are set to point to the thing you exported. The whole process loses
19803         track of dependencies very quickly: making a tiny change in LLVM requires
19804         packaging, and then unpackaging, a large number of potentially large headers and
19805         static libraries. Not only is this slow but it then causes the WebKit build
19806         system to rebuild anything that transitively includes any LLVM header, which is
19807         now quite a few files. While this sort of use pattern is still worthwhile if
19808         you're trying to package a binary drop and test it, it's not great if you're
19809         just trying to do experimental development that involves making small changes
19810         in both trees.
19811         
19812         This change fixes this use case while keeping the old use cases intact. You can
19813         do tandem development using one of two modes:
19814         
19815         Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
19816         the LLVM directory you're using. Once this is done, any invocation of a WebKit
19817         build via build-jsc or build-webkit will also build LLVM, and then quickly
19818         symlink things into place without perturbing dependency tracking.
19819         
19820         Internal LLVM directory: if you check out llvm into a directory called 'llvm'
19821         right off of the WebKit source tree, then the build system will automatically
19822         use this.
19823         
19824         Here's how this takes care of dependencies:
19825         
19826         Headers: the include/llvm and include/llvm-c directories are symlinked into
19827         $productsDir/usr/local/include. And then everything just works.
19828         
19829         Libraries: the build system detects, by reading LLVM's Makefile.config, which
19830         mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
19831         the .a files into $productsDir/<thingy>. It will ranlib those libraries only
19832         if they have changed, by checking both the modification time and also whether
19833         the last time we had a symlink, that symlink was from the same directory.
19834         This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
19835         but that build wasn't yet ranlib'd.
19836         
19837         One problem that this does not yet solve is that xcodebuild will not relink
19838         JavaScriptCore if the only thing that changed was the libraries. I will work
19839         on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
19841         * Scripts/copy-webkitlibraries-to-product-directory:
19842         (unpackIfNecessary):
19843         (fileContains):
19844         (fileContentsEquals):
19846 2013-04-15  Filip Pizlo  <fpizlo@apple.com>
19848         fourthTier: Update LLVM-related build scripts to copy generated headers as well
19849         https://bugs.webkit.org/show_bug.cgi?id=114551
19851         Reviewed by Oliver Hunt.
19852         
19853         Also added the ability to use something other than bzip2 compression, since although
19854         it is great for checking things into the tree, it increases turn-around times when
19855         experimenting.
19857         * Scripts/copy-webkitlibraries-to-product-directory:
19858         (unpackIfNecessary):
19859         * Scripts/export-llvm-build:
19861 2013-04-03  Filip Pizlo  <fpizlo@apple.com>
19863         fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
19864         https://bugs.webkit.org/show_bug.cgi?id=113921
19866         Reviewed by Oliver Hunt.
19868         The LLVM community wants us to continue including all of LLVM's C++ headers. Change
19869         the export script to do this.
19870         
19871         * Scripts/export-llvm-build:
19873 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
19875         fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
19876         https://bugs.webkit.org/show_bug.cgi?id=113452
19878         Rubber stamped by Mark Hahnenberg.
19880         * Scripts/copy-webkitlibraries-to-product-directory:
19881         * Scripts/export-llvm-build:
19883 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
19885         fourthTier: FTL JIT should be able run some simple function
19886         https://bugs.webkit.org/show_bug.cgi?id=113481
19888         Reviewed by Geoffrey Garen.
19889         
19890         Give the scripts the ability to find an LLVM build and use it.
19891         
19892         Also added a script, export-llvm-build, that allows you to take your
19893         own build of LLVM and package it for use by WebKit's build system.
19894         
19895         The build system treats a "build" of LLVM as a pair of .tar.bz2's,
19896         one for the library archives and one for the headers. It then unpacks
19897         them into your built products directory in a mannner that is mostly
19898         analogous to how WebKitSystemInterface works.
19900         * Scripts/build-jsc:
19901         * Scripts/copy-webkitlibraries-to-product-directory:
19902         (unpackIfNecessary):
19903         (dittoHeaders):
19904         * Scripts/export-llvm-build: Added.
19906 2013-07-24  Anders Carlsson  <andersca@apple.com>
19908         Crash when calling WKPageGetProcessIdentifier after aborted process launch
19909         https://bugs.webkit.org/show_bug.cgi?id=119069
19910         <rdar://problem/14494064>
19912         Reviewed by Andreas Kling.
19914         Add a test.
19916         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19917         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Added.
19918         (TestWebKitAPI::didFinishLoadForFrame):
19919         (TestWebKitAPI::TEST):
19921 2013-07-24  Zan Dobersek  <zdobersek@igalia.com>
19923         Make KURL::hasPath private
19924         https://bugs.webkit.org/show_bug.cgi?id=118279
19926         Reviewed by Darin Adler.
19928         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
19929         (TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
19931 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
19933         [GTK] TestInspectorServer unit test is timing out
19934         https://bugs.webkit.org/show_bug.cgi?id=105866
19936         Reviewed by Gustavo Noronha Silva.
19938         * Scripts/run-gtk-tests:
19939         (TestRunner):
19941 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
19943         [GTK] [WK2] Handle wheel event with delta zero
19944         https://bugs.webkit.org/show_bug.cgi?id=118973
19946         Reviewed by Gustavo Noronha Silva.
19948         Added handling of zero mouse scroll deltas in EventSenderProxy similar
19949         to WK1 and Qt/EFL ports.
19951         fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
19952         failing on WK2.
19954         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
19955         (WTR::EventSenderProxy::mouseScrollBy):
19957 2013-07-23  Andreas Kling  <akling@apple.com>
19959         REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
19960         <rdar://problem/14324895>
19961         <http://webkit.org/b/119023>
19963         Reviewed by Simon Fraser.
19965         Add a test for this rather specific problem.
19967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19968         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
19969         (TestWebKitAPI::TEST):
19970         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
19971         (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
19972         (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
19973         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
19975 2013-07-23  Tim Horton  <timothy_horton@apple.com>
19977         Add a test for plug-in unavailability indicator obscurity detection
19978         https://bugs.webkit.org/show_bug.cgi?id=119007
19980         Reviewed by Anders Carlsson.
19982         Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
19984         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
19985         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
19986         (WTR::TestRunner::setBlockAllPlugins):
19987         * WebKitTestRunner/InjectedBundle/TestRunner.h:
19988         * WebKitTestRunner/TestInvocation.cpp:
19989         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
19990         Add testRunner.setBlockAllPlugins function (and corresponding message to
19991         forward it through to TestController).
19993         * WebKitTestRunner/TestController.cpp:
19994         Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
19996         (WTR::TestController::createWebViewWithOptions):
19997         Register our pluginLoadPolicy callback.
19999         (WTR::TestController::resetStateToConsistentValues):
20000         Reset m_shouldBlockAllPlugins to false.
20002         (WTR::TestController::pluginLoadPolicy):
20003         Return the existing plugin load policy, unless setBlockAllPlugins(true)
20004         was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
20006         * WebKitTestRunner/TestController.h:
20007         (WTR::TestController::setBlockAllPlugins):
20009 2013-07-21  Andreas Kling  <akling@apple.com>
20011         KURL creates duplicate strings when completing data: URIs.
20012         <http://webkit.org/b/118952>
20013         <rdar://problem/14504480>
20015         Reviewed by Anders Carlsson.
20017         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
20018         (TestWebKitAPI::TEST_F):
20020 2013-07-19  Chris Fleizach  <cfleizach@apple.com>
20022         AX: VoiceOver not detecting misspelled words don't work in all cases
20023         https://bugs.webkit.org/show_bug.cgi?id=118924
20025         Reviewed by Tim Horton.
20027         Make the misspelled detection dependent on both types of attributes being present.
20029         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
20030         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
20031         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
20032         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
20034 2013-07-19  Alex Christensen  <achristensen@apple.com>
20036         Improved code coverage generation.
20037         https://bugs.webkit.org/show_bug.cgi?id=118926
20039         Reviewed by Tim Horton.
20041         * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
20042         * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
20043         (generateReport): Moved report generation to a subroutine.
20045 2013-07-19  Stephanie Lewis  <slewis@apple.com>
20047         <rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
20049         Unreviewed.
20051         Rebaseline pagination test after http://trac.webkit.org/changeset/152911
20053         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
20054         (TestWebKitAPI::didLayout):
20056 2013-07-19  Daniel Bates  <dabates@apple.com>
20058         Make Perl tools work when using git bisect with Git branch build setup
20059         https://bugs.webkit.org/show_bug.cgi?id=118512
20061         Reviewed by Martin Robinson.
20063         The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
20064         during a git bisect session with a Git branch build setup (i.e. git config
20065         core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
20066         specific build of WebKit because they cannot determine the branch Git is on (since
20067         git bisect puts Git into a detached HEAD state). We should teach our tooling to
20068         parse the file .git/BISECT_START (created by git bisect start) for the name of the
20069         branch Git was on when we began a git bisect session. Then the tools can determine
20070         the path to the built WebKit.
20072         * Scripts/VCSUtils.pm:
20073         (gitDirectory): Added.
20074         (gitBisectStartBranch): Added.
20075         (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
20076         HEAD (e.g. running git bisect).
20077         (determineVCSRoot): Modified to call gitDirectory() to determine the path to
20078         the .git directory in the Git checkout.
20080 2013-07-19  Alex Christensen  <achristensen@apple.com>
20082         Added x64 configuration to Visual Studio build.
20083         https://bugs.webkit.org/show_bug.cgi?id=118888
20085         Reviewed by Brent Fulgham.
20087         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
20088         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
20089         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
20090         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
20091         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
20092         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
20093         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
20094         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
20095         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
20096         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
20097         * win/record-memory/record-memory.vcxproj:
20099 2013-07-19  Martin Robinson  <mrobinson@igalia.com>
20101         Add a couple people to the MathML watchlist
20102         https://bugs.webkit.org/show_bug.cgi?id=118909
20104         Reviewed by Andreas Kling.
20106         Add a couple people to the MathML watchlist and add Kalyan's other
20107         email address to fix style checker warnings about the watchlist
20108         contents.
20110         * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
20111         list of contributors and add Kalyan's second email address.
20112         * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
20113         watchlist.
20115 2013-07-19  Simon Pena  <simon.pena@samsung.com>
20117         [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
20118         https://bugs.webkit.org/show_bug.cgi?id=118895
20120         Reviewed by Philippe Normand.
20122         In r152782 an uri is used to create an string representation without checking first if it
20123         is valid. That fails later when the string is used to check for existing redirections. This
20124         patch ensures that the uri is valid before using it.
20126         * DumpRenderTree/gtk/DumpRenderTree.cpp:
20127         (willSendRequestCallback): Ensure an uri is valid before using it.
20129 2013-07-18  Timothy Hatcher  <timothy@apple.com>
20131         Add extract-localizable-js-strings and use it for WebInspectorUI.
20133         https://bugs.webkit.org/show_bug.cgi?id=118851
20135         Reviewed by Joseph Pecoraro.
20137         * Scripts/extract-localizable-js-strings: Added.
20138         * Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
20139         * Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
20140         the WebInspectorUI project.
20142 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
20144         [Windows] Build correction #2 after r152861.
20146         * WinLauncher/WinLauncher.cpp: Declare proper linkage.
20148 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
20150         [Windows] Build correction after r152861.
20152         * WinLauncher/WinLauncher.cpp: Don't reference private header.
20154 2013-07-16  Brent Fulgham  <bfulgham@apple.com>
20156         [Win] Support in-band text tracks.
20157         https://bugs.webkit.org/show_bug.cgi?id=103770
20159         Reviewed by Eric Carlson.
20161         Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
20162         libdispatch and CFRunLoop elements are services during the run loop.
20164         * WinLauncher/WinLauncher.cpp:
20165         (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
20166         a CoreFoundation (or CFLite) support library.
20167         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
20168         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
20169         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
20170         and WinLauncherCFLite.props.
20172 2013-07-18  Roger Fong  <roger_fong@apple.com>
20174         Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
20176         * Scripts/webkitpy/common/config/ews.json:
20178 2013-07-18  Daniel Bates  <dabates@apple.com>
20180         REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
20181         https://bugs.webkit.org/show_bug.cgi?id=118854
20182         <rdar://problem/14081339>
20184         Reviewed by David Kilzer.
20186         Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
20187         Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
20188         run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
20189         listen on these ports so that we can run tests that use port 8443 and 8080.
20191         * Scripts/old-run-webkit-tests:
20192         (configureAndOpenHTTPDIfNeeded):
20194 2013-07-17  Tim Horton  <timothy_horton@apple.com>
20196         Update blocked/missing plug-in UI
20197         https://bugs.webkit.org/show_bug.cgi?id=118347
20198         <rdar://problem/14209318>
20200         Reviewed by Sam Weinig.
20202         * MiniBrowser/mac/WK2BrowserWindowController.m:
20203         (-[WK2BrowserWindowController awakeFromNib]):
20204         * WebKitTestRunner/TestController.cpp:
20205         (WTR::TestController::createWebViewWithOptions):
20206         Match new WKPageLoaderClient entry.
20208 2013-07-17  Commit Queue  <commit-queue@webkit.org>
20210         Unreviewed, rolling out r152701, r152703, r152739, r152754,
20211         and r152756.
20212         http://trac.webkit.org/changeset/152701
20213         http://trac.webkit.org/changeset/152703
20214         http://trac.webkit.org/changeset/152739
20215         http://trac.webkit.org/changeset/152754
20216         http://trac.webkit.org/changeset/152756
20217         https://bugs.webkit.org/show_bug.cgi?id=118821
20219         this was a buggy fix and we're going to try something
20220         different (Requested by thorton on #webkit).
20222         * MiniBrowser/mac/WK2BrowserWindowController.m:
20223         (-[WK2BrowserWindowController awakeFromNib]):
20224         * WebKitTestRunner/TestController.cpp:
20225         (WTR::TestController::createWebViewWithOptions):
20227 2013-07-17  Commit Queue  <commit-queue@webkit.org>
20229         Unreviewed, rolling out r151535.
20230         http://trac.webkit.org/changeset/151535
20231         https://bugs.webkit.org/show_bug.cgi?id=118804
20233         Re-disable WinEWS tests (Requested by rfong on #webkit).
20235         * Scripts/webkitpy/common/config/ews.json:
20237 2013-07-17  Simon Pena  <simon.pena@samsung.com>
20239         [GTK] Make DRT obbey testRunner's addURLToRedirect
20240         https://bugs.webkit.org/show_bug.cgi?id=118239
20242         Reviewed by Gustavo Noronha Silva.
20244         Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
20245         to the proper URI when indicated.
20247         * DumpRenderTree/gtk/DumpRenderTree.cpp:
20248         (willSendRequestCallback):
20250 2013-07-17  Gabor Abraham  <abrhm@inf.u-szeged.hu>
20252         Add a new find-resolved-bugs command to webkit-patch.
20253         https://bugs.webkit.org/show_bug.cgi?id=118060
20255         Reviewed by Csaba Osztrogonác.
20257         * Scripts/webkitpy/tool/commands/queries.py:
20258         (PrintBaselines._platform_for_path):
20259         (FindResolvedBugs):
20260         (FindResolvedBugs.execute):
20262 2013-07-16  Balazs Kelemen  <kbalazs@webkit.org>
20264         [CMake] Undefined references should be detected at build time
20265         https://bugs.webkit.org/show_bug.cgi?id=110236
20267         Reviewed by Christophe Dumez.
20269         Add library dependencies that were not defined explicitly before.
20271         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
20272         * TestWebKitAPI/CMakeLists.txt:
20273         * WebKitTestRunner/CMakeLists.txt:
20275 2013-07-16  Kwang Yul Seo  <skyul@company100.net>
20277         check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
20278         https://bugs.webkit.org/show_bug.cgi?id=118755
20280         Reviewed by Ryosuke Niwa.
20282         Fix r152719 to check "using namespace foo;" only in headers.
20284         * Scripts/webkitpy/style/checkers/cpp.py:
20285         (check_using_namespace):
20286         (check_style):
20287         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
20288         (WebKitStyleTest.test_using_namespace):
20290 2013-07-16  Christophe Dumez  <ch.dumez@sisa.samsung.com>
20292         Get rid of multiple inheritance support from the bindings generators
20293         https://bugs.webkit.org/show_bug.cgi?id=118353
20295         Reviewed by Kentaro Hara.
20297         Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
20298         deprecated domInterface->parents.
20300         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
20301         (_parentInterface):
20303 2013-07-16  Brian Holt  <brian.holt@samsung.com>
20305         check-webkit-style: "using namespace foo;" should be flagged as an error in headers
20306         https://bugs.webkit.org/show_bug.cgi?id=57241
20308         Reviewed by Ryosuke Niwa.
20310         Added check for "using namespace foo" and unit test.
20312         * Scripts/webkitpy/style/checkers/cpp.py:
20313         (check_using_namespace):
20314         (check_style):
20315         (CppChecker):
20316         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
20317         (WebKitStyleTest.test_using_namespace):
20319 2013-07-16  Anton Obzhirov  <a.obzhirov@samsung.com>
20321         [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
20322         https://bugs.webkit.org/show_bug.cgi?id=110222
20324         Reviewed by Gustavo Noronha Silva.
20326         Added handling of zero mouse scroll deltas in EventSender.
20328         * DumpRenderTree/gtk/EventSender.cpp:
20329         (mouseScrollByCallback):
20331 2013-07-16  Brian Holt  <brian.holt@samsung.com>
20333         webkitpy: replace urllib with urllib2 for downloading additional modules
20334         https://bugs.webkit.org/show_bug.cgi?id=118671
20336         Reviewed by Ryosuke Niwa.
20338         Urllib2 is available whereever urllib is, but has better proxy support.
20340         * Scripts/webkitpy/common/system/autoinstall.py:
20341         (AutoInstaller._download_to_stream):
20343 2013-07-16  Krzysztof Czech  <k.czech@samsung.com>
20345         [ATK] Adds support for aria-haspopup property.
20346         https://bugs.webkit.org/show_bug.cgi?id=117834
20348         Reviewed by Christophe Dumez.
20350         Adds implementation for testing aria-haspopup property.
20352         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
20353         (getAttributeSetValueForId):
20354         (AccessibilityUIElement::stringAttributeValue):
20355         (AccessibilityUIElement::hasPopup):
20356         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
20357         (WTR::getAttributeSetValueForId):
20358         (WTR::AccessibilityUIElement::stringAttributeValue):
20359         (WTR::AccessibilityUIElement::hasPopup):
20361 2013-07-16  Michael Brüning  <michael.bruning@digia.com>
20363         [Qt] Replace Nokia references.
20364         https://bugs.webkit.org/show_bug.cgi?id=118728
20366         Reviewed by Simon Hausmann.
20368         * MiniBrowser/qt/MiniBrowserApplication.cpp:
20369         (MiniBrowserApplication::MiniBrowserApplication):
20370         * QtTestBrowser/qttestbrowser.cpp:
20371         (LauncherApplication::LauncherApplication):
20373 2013-07-15  Tim Horton  <timothy_horton@apple.com>
20375         Update blocked/missing plug-in UI
20376         https://bugs.webkit.org/show_bug.cgi?id=118347
20377         <rdar://problem/14209318>
20379         Reviewed by Sam Weinig.
20381         * MiniBrowser/mac/WK2BrowserWindowController.m:
20382         (-[WK2BrowserWindowController awakeFromNib]):
20383         * WebKitTestRunner/TestController.cpp:
20384         (WTR::TestController::createWebViewWithOptions):
20385         Match new WKPageLoaderClient entry.
20387 2013-07-15  Chris Fleizach  <cfleizach@apple.com>
20389         Update James Craig's email address.
20391         * Scripts/webkitpy/common/config/contributors.json:
20393 2013-07-15  Dong-Gwan Kim  <donggwan.kim@samsung.com>
20395         [EFL] Add fallback for TestWebKitAPI if opengl is not available.
20396         https://bugs.webkit.org/show_bug.cgi?id=118583
20398         Reviewed by Christophe Dumez.
20400         There're many fails on efl webkit2 API test if opengl is not available.
20401         So, add fallback to non-opengl evas engine.
20403         * TestWebKitAPI/efl/PlatformWebView.cpp:
20404         (TestWebKitAPI::initEcoreEvas):
20406 2013-07-15  Brian Holt  <brian.holt@samsung.com>
20408         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
20409         https://bugs.webkit.org/show_bug.cgi?id=118592
20411         Reviewed by Martin Robinson.
20413         Added a suppression for pylint false positives and a unit test.
20415         * Scripts/webkitpy/style/checkers/python.py:
20416         (Pylinter):
20417         * Scripts/webkitpy/style/checkers/python_unittest.py:
20418         (PythonCheckerTest.test_check):
20419         (PythonCheckerTest):
20420         (PythonCheckerTest.test_pylint_false_positives):
20421         (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
20422         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
20423         (test_popen):
20425 2013-07-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
20427         [GTK] Increase the JHBuild version of GStreamer to 1.0.7
20428         https://bugs.webkit.org/show_bug.cgi?id=115166
20430         Reviewed by Philippe Normand.
20432         * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
20434 2013-07-12  Kwang Yul Seo  <skyul@company100.net>
20436         Unreviewed. Add an email address and update my domain of experts.
20438         * Scripts/webkitpy/common/config/contributors.json:
20440 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
20442         [jhbuild] Avoid restarting from scratch failed initial checkouts
20443         https://bugs.webkit.org/show_bug.cgi?id=118603
20445         Reviewed by Martin Robinson.
20447         If the initial checkout is interrupted midway (eg. because the internet
20448         connection went down) config files do not get generated and that causes
20449         the next checkout to start from scratch (the missing files cause the
20450         script to delete the build root and the downloaded sources).
20452         By generating the files before invoking jhbuild, subsequent runs are able
20453         to start where the previous run left.
20455         * Scripts/update-webkit-libs-jhbuild:
20456         (saveJhbuildMd5): invoke it before runJhbuild().
20458 2013-07-12  Brent Fulgham  <bfulgham@apple.com>
20460         [Windows] Remove single-worker restriction on tests.
20462         * Scripts/webkitpy/port/win.py: Remove restriction of one worker.
20464 2013-07-12  Commit Queue  <commit-queue@webkit.org>
20466         Unreviewed, rolling out r152599.
20467         http://trac.webkit.org/changeset/152599
20468         https://bugs.webkit.org/show_bug.cgi?id=118612
20470         This patch includes a failing unit test (Requested by
20471         mrobinson on #webkit).
20473         * Scripts/webkitpy/style/checkers/python.py:
20474         (Pylinter):
20475         * Scripts/webkitpy/style/checkers/python_unittest.py:
20476         (PythonCheckerTest.test_check):
20477         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
20479 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
20481         [Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
20482         https://bugs.webkit.org/show_bug.cgi?id=91223
20484         Reviewed by Martin Robinson.
20486         When run on a clean checkout, `build-webkit` complains that no
20487         GNUmakefile exists when trying to detect the previously configured
20488         architecture, but in this case there's no previous configuration so
20489         the warning is pointless.
20491         * Scripts/webkitdirs.pm:
20492         (determineArchitecture): Redirect grep stderr to /dev/null.
20494 2013-07-12  Brian Holt  <brian.holt@samsung.com>
20496         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
20497         https://bugs.webkit.org/show_bug.cgi?id=118592
20499         Reviewed by Martin Robinson.
20501         Added a suppression for pylint false positives and a unit test.
20503         * Scripts/webkitpy/style/checkers/python.py:
20504         (Pylinter):
20505         * Scripts/webkitpy/style/checkers/python_unittest.py:
20506         (PythonCheckerTest.test_check):
20507         (PythonCheckerTest):
20508         (PythonCheckerTest.test_pylint_false_positives):
20509         (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
20510         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
20511         (test_popen):
20513 2013-07-11  Arnaud Renevier  <a.renevier@samsung.com>
20515         Unreviewed. Add myself as a committer.
20517         * Scripts/webkitpy/common/config/contributors.json:
20519 2013-07-10  Sergio Correia  <sergio.correia@openbossa.org>
20521         Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
20522         https://bugs.webkit.org/show_bug.cgi?id=118538
20524         Reviewed by Christophe Dumez.
20526         When attempting some odd url such as ``foo'', MiniBrowser will now show an
20527         error message such as "Cannot resolve hostname (foo)".
20529         Previously, it had the following behavior if MiniBrowser was started with
20530         such urls, e.g ``./MiniBrowser foo'':
20532         - Debug:
20533         It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
20535         - Release:
20536         No asserts, naturally, but the view would remain blank, even if we tried to
20537         change to a valid url.
20539         * MiniBrowser/efl/main.c:
20540         (window_create):
20542 2013-07-10  Simon Pena  <simon.pena@samsung.com>
20544         [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
20545         https://bugs.webkit.org/show_bug.cgi?id=118509
20547         Reviewed by Martin Robinson.
20549         In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
20550         when trying to remove an event already removed, if another event is
20551         processed in the middle. By using a Deque's takeFirst, we ensure the
20552         element is removed before we dispatch it.
20554         fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
20555         crashes after this fix is added.
20557         * WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
20558         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
20559         (WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
20560         from the queue.
20562 2013-07-09  Ryuan Choi  <ryuan.choi@samsung.com>
20564         [EFL] Add ewk_view_device_pixel_ratio_set
20565         https://bugs.webkit.org/show_bug.cgi?id=118521
20567         Reviewed by Gyuyoung Kim.
20569         * EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
20570         (windowCreate):
20571         (parseUserArguments):
20573 2013-07-09  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
20575         Unreviewed change of my email addresses.
20576         https://bugs.webkit.org/show_bug.cgi?id=100122
20578         * Scripts/webkitpy/common/config/contributors.json:
20580 2013-07-09  Anders Carlsson  <andersca@apple.com>
20582         DumpRenderTree should stop sending unsupported URLs to NSWorkspace
20583         https://bugs.webkit.org/show_bug.cgi?id=118514
20584         <rdar://problem/13686836>
20586         Reviewed by Sam Weinig.
20588         Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
20590         * DumpRenderTree/DefaultPolicyDelegate.h: Added.
20591         * DumpRenderTree/DefaultPolicyDelegate.m: Added.
20592         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
20593         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
20594         Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
20596         * DumpRenderTree/mac/DumpRenderTree.mm:
20597         (allocateGlobalControllers):
20598         Allocate a DefaultPolicyDelegate object.
20600         (resetWebViewToConsistentStateBeforeTesting):
20601         Set the policy delegate to the default policy delegate.
20603         * DumpRenderTree/mac/DumpRenderTreeMac.h:
20604         Declare the defaultPolicyDelegate object.
20606         * DumpRenderTree/mac/TestRunnerMac.mm:
20607         (TestRunner::setCustomPolicyDelegate):
20608         Set the policy delegate to the default delegate if setDelegate is false.
20610 2013-07-08  Zan Dobersek  <zdobersek@igalia.com>
20612         KURL unit test fixture class should have a meaningful name
20613         https://bugs.webkit.org/show_bug.cgi?id=118467
20615         Reviewed by Sam Weinig.
20617         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
20618         (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
20619         instead of the generic and inappropriate 'WebCore' name.
20621 2013-07-08  Antti Koivisto  <antti@apple.com>
20623         Add Deque::removeLast
20624         https://bugs.webkit.org/show_bug.cgi?id=118466
20626         Reviewed by Andreas Kling.
20628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20629         * TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
20630         (TestWebKitAPI::TEST):
20632 2013-07-08  Brian Holt  <brian.holt@samsung.com>
20634         [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
20635         https://bugs.webkit.org/show_bug.cgi?id=118412
20637         Reviewed by Martin Robinson.
20639         An adoptRef is required to balance ref and deref calls.
20641         * DumpRenderTree/gtk/EventSender.cpp:
20642         (beginDragWithFilesCallback):
20644 2013-07-06  Sergio Correia  <sergio.correia@openbossa.org>
20646         Update list of EFL WK2 API tests
20647         https://bugs.webkit.org/show_bug.cgi?id=118443
20649         Reviewed by Christophe Dumez.
20651         The following tests were included:
20653         Passing:
20654         - CloseThenTerminate
20655         - DidAssociateFormControls
20656         - PageVisibilityState
20657         - ResponsivenessTimerDoesntFireEarly
20658         - TerminateTwice
20659         - WillLoad
20661         Failing:
20662         - ResizeReversePaginatedWebView
20663         - ScrollPinningBehaviors
20665         This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
20666         alphabetical order.
20668         * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
20669         * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
20671 2013-07-05  Tim Horton  <timothy_horton@apple.com>
20673         Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
20674         https://bugs.webkit.org/show_bug.cgi?id=118439
20675         <rdar://problem/14366120>
20677         Reviewed by Anders Carlsson.
20679         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
20680         (TestWebKitAPI::didLayout):
20681         (TestWebKitAPI::TEST):
20682         - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
20683         - Assert that we got the right number of pages for sanity.
20684         - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
20685             so much memory that SharedMemory asserts and makes the test time out.
20686         - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
20687             because paint doesn't fire if the window is offscreen.
20689 2013-07-05  Tim Horton  <timothy_horton@apple.com>
20691         [wk2] Add API to lock the scroll position at the top or bottom of the page
20692         https://bugs.webkit.org/show_bug.cgi?id=118429
20693         <rdar://problem/14120323>
20695         Reviewed by Anders Carlsson.
20697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20698         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
20699         (TestWebKitAPI::didFinishDocumentLoadForFrame):
20700         (TestWebKitAPI::TEST):
20701         Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
20702         all work correctly in the face of resizing the view and scrolling from JS.
20704 2013-07-05  Michael Pruett  <michael@68k.org>
20706         Unreviewed. Add myself as a committer.
20708         * Scripts/webkitpy/common/config/contributors.json:
20710 2013-07-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
20712         [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
20713         https://bugs.webkit.org/show_bug.cgi?id=111434
20715         Reviewed by Carlos Garcia Campos.
20717         * Scripts/run-gtk-tests:
20718         (TestRunner): Unskipped TestWebKitFaviconDatabase tests.
20720 2013-07-04  Viatcheslav Ostapenko  <sl.ostapenko@samsung.com>
20722         [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
20723         https://bugs.webkit.org/show_bug.cgi?id=118370
20725         Reviewed by Christophe Dumez.
20727         Add fallback to software X11 engine if opengl_x11 engine creation fails.
20729         * DumpRenderTree/efl/DumpRenderTree.cpp:
20730         (initEcoreEvas):
20732 2013-07-04  Brian Holt  <brian.holt@samsung.com>
20734         [ATK] Leak: AtkAttributeSet* should be freed
20735         https://bugs.webkit.org/show_bug.cgi?id=118307
20737         Reviewed by Christophe Dumez.
20739         Fixed memory leaks for AtkAttributeSet by calling
20740         atk_attribute_set_free().
20742         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
20743         (AccessibilityController::childElementById):
20744         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
20745         (getAtkAttributeSetAsString):
20746         (AccessibilityUIElement::allAttributes):
20747         (AccessibilityUIElement::stringAttributeValue):
20748         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
20749         (WTR::childElementById):
20750         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
20751         (WTR::getAtkAttributeSetAsString):
20752         (WTR::AccessibilityUIElement::allAttributes):
20753         (WTR::AccessibilityUIElement::stringAttributeValue):
20755 2013-07-03  David Farler  <dfarler@apple.com>
20757         Add Makefile to WebKitLauncher
20758         https://bugs.webkit.org/show_bug.cgi?id=118365
20760         Reviewed by Mark Rowe.
20762         * WebKitLauncher/Makefile: Added.
20764 2013-07-03  Brian Holt  <brian.holt@samsung.com>
20766         [ATK] Leak: more leaks in AccessibilityUIElement
20767         https://bugs.webkit.org/show_bug.cgi?id=118362
20769         Reviewed by Christophe Dumez.
20771         Free the memory created by g_strdup_printf.
20773         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
20774         (AccessibilityUIElement::language):
20775         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
20776         (WTR::AccessibilityUIElement::language):
20778 2013-07-03  Jer Noble  <jer.noble@apple.com>
20780         Xcode often gets in a state where the debugger is completely unresponsive
20781         https://bugs.webkit.org/show_bug.cgi?id=118157
20783         The GetPointeeData() operations we use to retrieve strings is extremely expensive.
20784         Rather than pull the character data out of the debugger one byte at a time
20785         through the GetPointeeData() API, retrieve the memory contents of the string through
20786         the ReadMemory() API, and convert the retrieved memory into a python string.
20788         Reviewed by Anders Carlsson.
20790         * lldb/lldb_webkit.py:
20791         (__lldb_init_module.lldb_webkit):
20792         (guess_string_length):
20793         (ustring_to_string):
20794         (lstring_to_string):
20796 2013-07-03  Morten Stenshorne  <mstensho@opera.com>
20798         [GTK] Let F5 refresh the page in MiniBrowser
20799         https://bugs.webkit.org/show_bug.cgi?id=117638
20801         Reviewed by Carlos Garcia Campos.
20803         Also use the correct icon for the refresh button that was already there.
20805         * MiniBrowser/gtk/BrowserWindow.c:
20806         (browser_window_init):
20808 2013-07-02  Kondapally Kalyan  <kalyan.kondapally@intel.com>
20810         Unreviewed. Add my email to a few watchlists.
20812         * Scripts/webkitpy/common/config/watchlist:
20814 2013-07-02  David Farler  <dfarler@apple.com>
20816         Unreviewed. Adding myself to contributors.json.
20818         * Scripts/webkitpy/common/config/contributors.json:
20820 2013-07-02  Brian Holt  <brian.holt@samsung.com>
20822         [ATK] Leak: leaks in AccessibilityUIElement
20823         https://bugs.webkit.org/show_bug.cgi?id=118297
20825         Fixed memory leak.
20827         Reviewed by Christophe Dumez.
20829         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
20830         (AccessibilityUIElement::stringValue):
20832 2013-07-02  Byungwoo Lee  <bw80.lee@samsung.com>
20834         Fix WebKitTestRunner crashes.
20835         https://bugs.webkit.org/show_bug.cgi?id=117630
20837         Reviewed by Darin Adler.
20839         Create static function to dump for WebProcess unresponsiveness status,
20840         and use it before calling TestController::runTest().
20842         Accessing TestController::m_currentInvocation before calling
20843         TestController::runTest() can make crash because the invocation
20844         instance will be assigned at the function.
20846         * WebKitTestRunner/TestController.cpp:
20847         (WTR::TestController::run):
20848         * WebKitTestRunner/TestInvocation.cpp:
20849         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
20850         * WebKitTestRunner/TestInvocation.h:
20852 2013-07-02  Allan Sandfeld Jensen  <allan.jensen@digia.com>
20854         [Qt][WK1] Support WebGL with EGL on Linux
20855         https://bugs.webkit.org/show_bug.cgi?id=118251
20857         Reviewed by Kenneth Rohde Christiansen.
20859         * qmake/mkspecs/features/features.prf:
20861 2013-07-01  Nick Diego Yamane  <nick.yamane@openbossa.org>
20863         [Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
20864         https://bugs.webkit.org/show_bug.cgi?id=118267
20866         Reviewed by Gyuyoung Kim.
20868         After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
20869         WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
20870         Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
20872         * efl/jhbuildrc:
20873         * gtk/jhbuildrc:
20875 2013-07-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
20877         [GTK] Remove unsupported AC backends
20878         https://bugs.webkit.org/show_bug.cgi?id=117362
20880         Reviewed by Martin Robinson.
20882         * gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
20883         and cogl, so removed.
20885 2013-07-01  Timothy Hatcher  <timothy@apple.com>
20887         Link to WebInspectorUI.framework at build time instead of soft linking.
20889         https://bugs.webkit.org/show_bug.cgi?id=118261
20891         Reviewed by Joseph Pecoraro.
20893         * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
20895 2013-07-01  Tim Horton  <timothy_horton@apple.com>
20897         Maximum scroll position can be negative in some cases
20898         https://bugs.webkit.org/show_bug.cgi?id=118175
20899         <rdar://problem/14301217>
20901         Reviewed by Anders Carlsson.
20903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20904         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
20905         (TestWebKitAPI::didRunJavaScript):
20906         (TestWebKitAPI::didLayout):
20907         (TestWebKitAPI::TEST):
20908         * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
20909         Add a test that loads a vertical-lr document, paginates it horizontally
20910         from right to left, resizes the view to fit the entire document, and
20911         verifies that the scroll position is negative, as it must be for the
20912         document to be enclosed by the view.
20914 2013-07-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
20916         [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
20917         https://bugs.webkit.org/show_bug.cgi?id=117249
20919         Reviewed by Brent Fulgham.
20921         Finish converting all use cases of WEBKITOUTPUTDIR to
20922         WEBKIT_OUTPUTDIR, which seems to be preferred these days.
20924         * DumpRenderTree/efl/FontManagement.cpp:
20925         (getCustomBuildDir):
20926         (getPlatformFontsPath):
20927         * DumpRenderTree/gtk/DumpRenderTree.cpp:
20928         (getOutputDir):
20929         * Scripts/webkitdirs.pm:
20930         (determineBaseProductDir):
20931         (usesPerConfigurationBuildDirectory):
20932         * Scripts/webkitpy/port/base.py:
20933         (Port.to.setup_environ_for_server):
20934         * Scripts/webkitpy/port/driver.py:
20935         (Driver._setup_environ_for_driver):
20936         * Scripts/webkitpy/port/gtk.py:
20937         (GtkPort.setup_environ_for_server):
20938         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
20939         (WTR::getOutputDir):
20940         * jhbuild/jhbuildutils.py:
20941         (get_dependencies_path):
20943 2013-07-01  Rafael Brandao  <rafael.lobo@webkit.org>
20945         Unreviewed change of my email address.
20947         * Scripts/webkitpy/common/config/contributors.json:
20949 2013-06-28  Andreas Kling  <akling@apple.com>
20951         Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
20953         * DumpRenderTree/win/DumpRenderTree.cpp:
20954         (addFontFallbackIfPresent):
20955         (removeFontFallbackIfPresent):
20957 2013-06-28  Anders Carlsson  <andersca@apple.com>
20959         Remove String::deprecatedCharactersWithNullTermination() and related code
20960         https://bugs.webkit.org/show_bug.cgi?id=118211
20962         Reviewed by Benjamin Poulain.
20964         Remove all hasTerminatingNullCharacter() checks.
20966         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
20967         (TestWebKitAPI::TEST):
20968         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
20969         (TestWebKitAPI::TEST):
20970         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
20971         (TestWebKitAPI::TEST):
20973 2013-06-28  Alexey Proskuryakov  <ap@apple.com>
20975         [Mac] Crash when loading is stopped from -didReceiveResponse
20976         https://bugs.webkit.org/show_bug.cgi?id=118209
20977         <rdar://problem/14259249>
20979         Reviewed by Brady Eidson.
20981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20982         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
20983         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
20984         (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
20985         (TestWebKitAPI::TEST):
20987 2013-06-28  Andy Estes  <aestes@apple.com>
20989         [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
20990         https://bugs.webkit.org/show_bug.cgi?id=118208
20992         Reviewed by Mark Rowe.
20994         Newer versions of clang use a default template depth of 128, but this
20995         is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
20996         previous default.
20998         Clang lowered the default to keep recursive template instantiation
20999         from overflowing the stack (see <rdar://problem/13935016>), but
21000         TestWebKitAPI's C++ files don't trigger a stack overflow even with the
21001         higher limit. If for some reason this starts happening then we can
21002         lower the limit back down.
21004         * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
21006 2013-06-28  Nick Diego Yamane  <nick.yamane@openbossa.org>
21008         [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
21009         https://bugs.webkit.org/show_bug.cgi?id=118195
21011         Reviewed by Daniel Bates.
21013         Currently, ports that use jhbuild fail to determine jhbuild directory
21014         when "webKitBranchBuild" git configuration property is enabled. To reproduce
21015         that issue in Efl port, enable that flag in .git/config, switch to a git branch
21016         other than "master" and try to build webkit. The build will fail to
21017         locate dependencies due to lack of pkg-config paths which should be set
21018         by jhbuild.
21020         For more details about "webKitBranchBuild" option, see:
21021         https://trac.webkit.org/wiki/UsingGitWithWebKit
21023         * Scripts/webkitdirs.pm:
21024         (getJhbuildPath):
21026 2013-06-28  Jessie Berlin  <jberlin@apple.com>
21028         WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
21029         https://bugs.webkit.org/show_bug.cgi?id=118201
21031         Reviewed by Dean Jackson.
21033         * WebKitTestRunner/mac/main.mm:
21034         (main):
21035         Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
21036         setAutomaticDashSubstitutionEnabled are not exposed on WKView.
21038 2013-06-28  David Farler  <dfarler@apple.com>
21040         Upstream WebKit Nightly’s WebKitLauncher
21041         https://bugs.webkit.org/show_bug.cgi?id=117418
21043         Reviewed by Mark Rowe.
21045         Literal patch from Nightly's OpenSource repo.
21047         * WebKitLauncher/Configurations/Base.xcconfig:
21048         * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
21049         * WebKitLauncher/Info.plist:
21050         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
21051         * WebKitLauncher/WebKitLauncherURLProtocol.m:
21052         (+[WebKitLauncherURLProtocol load]):
21053         (+[WebKitLauncherURLProtocol canInitWithRequest:]):
21054         (-[WebKitLauncherURLProtocol startLoading]):
21055         (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
21056         (-[WebKitLauncherURLProtocol resourceNotFound]):
21057         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
21058         (initializeSparkle):
21059         * WebKitLauncher/main.m:
21060         (determineExecutablePath):
21061         (currentMacOSXVersion):
21062         (main):
21063         * WebKitLauncher/start.html:
21065 2013-06-28  Balazs Kelemen  <b.kelemen@samsung.com>
21067         [EFL] back/forward keyboard shortcuts are non-intuitive
21068         https://bugs.webkit.org/show_bug.cgi?id=118193
21070         Reviewed by Christophe Dumez.
21072         Changed shortcuts for go-back/go-forward to alt+left and alt+right.
21074         * EWebLauncher/main.c:
21075         (on_key_down):
21076         * MiniBrowser/efl/main.c:
21077         (on_key_down):
21079 2013-06-28  Roger Fong  <roger_fong@apple.com>
21081         Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
21082         https://bugs.webkit.org/show_bug.cgi?id=118194.
21084         Reviewed by Brent Fulgham.
21086         * DumpRenderTree/win/DumpRenderTree.cpp:
21087         (dllLauncherEntryPoint):
21088         * WinLauncher/WinLauncher.cpp:
21089         (dllLauncherEntryPoint):
21091 2013-06-28  Roger Fong  <roger_fong@apple.com>
21093         Unreviewed build fix for AppleWin port. Fix some file paths.
21095         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
21096         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
21098 2013-06-27  Roger Fong  <roger_fong@apple.com>
21100         Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
21101         https://bugs.webkit.org/show_bug.cgi?id=118160.
21103         Reviewed by Brent Fulgham.
21105         * WinLauncher/AccessibilityDelegate.cpp: Added.
21106         (AccessibilityDelegate::QueryInterface):
21107         (AccessibilityDelegate::AddRef):
21108         (AccessibilityDelegate::Release):
21109         (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
21110         (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
21111         * WinLauncher/AccessibilityDelegate.h: Added.
21112         (AccessibilityDelegate::AccessibilityDelegate):
21113         * WinLauncher/WinLauncher.cpp:
21114         (dllLauncherEntryPoint):
21115         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
21116         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
21118 2013-06-28  Christophe Dumez  <ch.dumez@sisa.samsung.com>
21120         Clean up temporary files created by the bindings test script
21121         https://bugs.webkit.org/show_bug.cgi?id=118189
21123         Reviewed by Kentaro Hara.
21125         Remove temporary files created by preprocess-idls.pl script after
21126         the bindings tests are executed.
21128         Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
21130         * Scripts/webkitpy/bindings/main.py:
21131         (BindingsTests.main):
21133 2013-06-26  Dean Jackson  <dino@apple.com>
21135         [Mac] Add Mavericks system font to Test systems
21136         https://bugs.webkit.org/show_bug.cgi?id=118109
21138         Reviewed by Simon Fraser.
21140         OS X Mavericks uses a different font for system controls. Tell DRT and
21141         WKTR about them otherwise they use a fallback font. Unfortunately the
21142         fonts are hidden (not found in the list of available fonts) so I
21143         had to add them manually.
21145         Even though there is only one at the moment, I implemented this
21146         as a set so it will be easier to add new fonts if necessary.
21148         * DumpRenderTree/mac/DumpRenderTree.mm:
21149         (allowedFontFamilySet): Fixed typo.
21150         (systemHiddenFontFamilySet): New method that returns the system control font.
21151         (drt_NSFontManager_availableFonts): Merge the hidden fonts.
21152         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
21153         (WTR::allowedFontFamilySet): Fixed typo.
21154         (WTR::systemHiddenFontFamilySet): As above.
21155         (WTR::wtr_NSFontManager_availableFonts):
21157 2013-06-27  Anders Carlsson  <andersca@apple.com>
21159         Get rid of the last uses of deprecatedCharactersWithNullTermination()
21160         https://bugs.webkit.org/show_bug.cgi?id=118159
21162         Reviewed by Andreas Kling.
21164         Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
21166         * DumpRenderTree/win/DumpRenderTree.cpp:
21167         (findFontFallback):
21169 2013-06-27  Bem Jones-Bey  <bjonesbe@adobe.com>
21171         Sync up w3c import script with changes in Blink
21172         https://bugs.webkit.org/show_bug.cgi?id=118149
21174         Reviewed by Dirk Pranke.
21176         This is a port of the following blink changes:
21178         https://codereview.chromium.org/15366004
21179         https://chromiumcodereview.appspot.com/15592005
21180         https://codereview.chromium.org/16021006
21181         https://codereview.chromium.org/15590004
21182         https://codereview.chromium.org/15901008
21183         https://codereview.chromium.org/16171009
21184         https://codereview.chromium.org/16465007
21185         https://codereview.chromium.org/15981013
21187         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
21188         (setUp):
21189         (test_commit_message_for_this_commit):
21190         * Scripts/webkitpy/port/base.py:
21191         (Port):
21192         * Scripts/webkitpy/port/test.py:
21193         * Scripts/webkitpy/w3c/test_converter.py:
21194         (W3CTestConverter.__init__):
21195         (W3CTestConverter.read_webkit_prefixed_css_property_list):
21196         (W3CTestConverter.convert_for_webkit):
21197         (W3CTestConverter.convert_css):
21198         (W3CTestConverter.convert_html):
21199         (W3CTestConverter.convert_testharness_paths):
21200         (W3CTestConverter.convert_prefixed_properties):
21201         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
21202         * Scripts/webkitpy/w3c/test_converter_unittest.py:
21203         * Scripts/webkitpy/w3c/test_importer.py:
21204         (main):
21205         (configure_logging):
21206         (configure_logging.LogHandler):
21207         (configure_logging.LogHandler.format):
21208         (parse_args):
21209         (TestImporter.__init__):
21210         (TestImporter.find_importable_tests):
21211         (TestImporter.import_tests):
21212         (TestImporter.setup_destination_directory):
21213         (TestImporter.remove_deleted_files):
21214         * Scripts/webkitpy/w3c/test_importer_unittest.py:
21215         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
21216         (TestImporterTest.test_import_dir_with_no_tests):
21217         (TestImporterTest):
21218         * Scripts/webkitpy/w3c/test_parser.py:
21219         (TestParser.load_file):
21220         (TestParser.analyze_test):
21221         (TestParser.support_files):
21222         * Scripts/webkitpy/w3c/test_parser_unittest.py:
21224 2013-06-27  Csaba Osztrogonác  <ossy@webkit.org>
21226         [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
21227         https://bugs.webkit.org/show_bug.cgi?id=118128
21229         Reviewed by Ryosuke Niwa.
21231         It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
21232         https://bugs.webkit.org/show_bug.cgi?id=117831
21234         * Scripts/webkitpy/tool/commands/download.py:
21235         (AbstractPatchSequencingCommand):
21236         (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
21237         (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
21238         (AbstractPatchSequencingCommand._prepare_state): Added.
21240 2013-06-27  Brendan Long  <b.long@cablelabs.com>
21242         [Qt] Build overrides -j when given --makeargs="-sj40"
21243         https://bugs.webkit.org/show_bug.cgi?id=116897
21245         Reviewed by Csaba Osztrogonác.
21247         * Scripts/webkitdirs.pm:
21248         (buildQMakeProjects):
21249         Change regex checking for -j* to also check for -*j*
21251 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
21253         Remove [NoInterfaceObject] from WorkerGlobalScope
21254         https://bugs.webkit.org/show_bug.cgi?id=118071
21256         Reviewed by Kentaro Hara.
21258         Update bindings test script to pass 2 additional parameters
21259         now needed by the preprocess-idls.pl script.
21261         * Scripts/webkitpy/bindings/main.py:
21262         (BindingsTests.generate_supplemental_dependency):
21263         (BindingsTests.main):
21265 2013-06-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
21267         Fixing some compiler warnings
21268         https://bugs.webkit.org/show_bug.cgi?id=117791
21270         Reviewed by Martin Robinson.
21272         * GNUmakefile.am: Silenced format warning.
21273         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
21274         (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
21275         Solved warning about uninitialized variable.
21277 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
21279         Fix bindings tests after r152080
21280         https://bugs.webkit.org/show_bug.cgi?id=118118
21282         Reviewed by Gyuyoung Kim.
21284         r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
21285         to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
21286         accordingly.
21288         * Scripts/webkitpy/bindings/main.py:
21289         (BindingsTests.generate_supplemental_dependency):
21290         (BindingsTests.main):
21292 2013-06-26  Carlos Garcia Campos  <cargarcia@blackberry.com>
21294         [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
21295         https://bugs.webkit.org/show_bug.cgi?id=117982
21297         Reviewed by Rob Buis.
21299         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
21300         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
21301         m_policyDelegateIsPermissive.
21302         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
21303         Reset m_policyDelegateIsPermissive.
21304         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
21305         m_policyDelegateIsPermissive.
21306         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
21307         (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
21308         Return whether custom policy is enabled.
21309         (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
21310         Return whether custom policy is permissive.
21312 2013-06-26  Anders Carlsson  <andersca@apple.com>
21314         Deprecate StringImpl::charactersWithNullTermination
21315         https://bugs.webkit.org/show_bug.cgi?id=118108
21317         Reviewed by Beth Dakin.
21319         Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
21321         * DumpRenderTree/win/DumpRenderTree.cpp:
21322         (findFontFallback):
21323         (addFontFallbackIfPresent):
21324         (removeFontFallbackIfPresent):
21326 2013-06-26  Nico Weber  <thakis@chromium.org>
21328         Remove detect-mismached-virtual-const.
21329         https://bugs.webkit.org/show_bug.cgi?id=117999
21331         Reviewed by Anders Carlsson.
21333         Clang warns on mismatched virtual const, so there's no need for this
21334         script any more.
21336         * Scripts/detect-mismatched-virtual-const: Removed.
21338 2013-06-26  Alex Christensen  <achristensen@apple.com>
21340         Added a code coverage report.
21341         https://bugs.webkit.org/show_bug.cgi?id=117941
21343         Reviewed by Joseph Pecoraro.
21345         * CodeCoverage: Added.
21346         * CodeCoverage/results-template.html: Added.
21347         * Scripts/generate-coverage-data: Generate and open the new report.
21349 2013-06-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
21351         gdb: Remove the webcore.py pretty printer.
21352         https://bugs.webkit.org/show_bug.cgi?id=117992
21354         Reviewed by Jochen Eisinger.
21356         webcore.py has been only a placeholder for backwards compatibility
21357         for almost 3 years. It should be safe enough to remove it now.
21359         * gdb/webcore.py: Removed.
21361 2013-05-26  Peter Gal  <galpeter@inf.u-szeged.hu>
21363         Creating cURL watchlist and adding myself to it.
21365         Reviewed by Csaba Osztrogonác.
21367         * Scripts/webkitpy/common/config/watchlist:
21369 2013-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
21371         Unreviewed, change my email address for watch list.
21373         * Scripts/webkitpy/common/config/watchlist:
21375 2013-06-25  Byungwoo Lee  <bw80.lee@samsung.com>
21377         [EFL] Add a script to install dependencies.
21378         https://bugs.webkit.org/show_bug.cgi?id=117968
21380         Reviewed by Christophe Dumez.
21382         Add a script which installs basic dependencies for building WebKit EFL.
21384         The dependencies are from the current EFLWebKit wiki page.
21385         After this patch is landed, the wiki page will be updated to use
21386         this script.
21388         * efl/install-dependencies: Added.
21390 2013-06-24  Dean Jackson  <dino@apple.com>
21392         [Mac] Update font used for Chinese in test systems
21393         https://bugs.webkit.org/show_bug.cgi?id=117970
21395         Reviewed by Alexey Proskuryakov.
21397         Add "Songti TC" and "Songti SC" to the list of allowed fonts
21398         in DRT and WKTR.
21400         * DumpRenderTree/mac/DumpRenderTree.mm:
21401         (allowedFontFamilySet):
21402         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
21403         (WTR::allowedFontFamilySet):
21405 2013-06-24  Tim Horton  <timothy_horton@apple.com>
21407         Make MiniBrowser paginated mode work with WebKit1
21408         https://bugs.webkit.org/show_bug.cgi?id=117950
21410         Reviewed by Beth Dakin.
21412         * MiniBrowser/mac/WK1BrowserWindowController.m:
21413         (-[WK1BrowserWindowController isPaginated]):
21414         (-[WK1BrowserWindowController togglePaginationMode:]):
21415         Hook up isPaginated and togglePaginationMode just as for WebKit2.
21417 2013-06-24  David Kilzer  <ddkilzer@apple.com>
21419         bisect-builds: improve heuristic for choosing the next build after a broken build
21420         <http://webkit.org/b/117918>
21422         Reviewed by Simon Fraser.
21424         * Scripts/bisect-builds: When a build is broken, use a heuristic
21425         that "bisects" the left side or the right side of the remaining
21426         revisions to pick a revision that's sufficiently different from
21427         the revision of the broken build.  This heuristic assumes there
21428         is a sequential range of broken builds whenever one broken build
21429         is found.
21431 2013-06-24  Chris Rogers  <crogers@google.com>
21433         WaveTable name has changed to PeriodicWave
21434         https://bugs.webkit.org/show_bug.cgi?id=117748
21436         Reviewed by Jer Noble.
21438         * Scripts/do-webcore-rename:
21440 2013-06-22  Santosh Mahto  <santosh.ma@samsung.com>
21442         [EFL] Add support for MHTML save/load feature to MiniBrowser
21443         https://bugs.webkit.org/show_bug.cgi?id=106620
21445         Reviewed by Christophe Dumez.
21447         Enable CTRL + S as save page in mhtml and CTRL + L to load any page
21448         from filesystem.
21450         * MiniBrowser/efl/CMakeLists.txt:
21451         * MiniBrowser/efl/main.c:
21452         (page_contents_callback):
21453         (on_key_down):
21454         (show_file_entry_dialog): generic function to show file enrty
21455         selector dialogue
21457 2013-06-21  Brent Fulgham  <bfulgham@apple.com>
21459         [Windows] Unreviewed crash protection for DRT
21461         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
21462         to avoid crashing during test runs.
21464 2013-06-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
21466         REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
21467         https://bugs.webkit.org/show_bug.cgi?id=117825
21469         Reviewed by Kentaro Hara.
21471         DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
21473         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
21474         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
21475         * DumpRenderTree/efl/TestRunnerEfl.cpp:
21476         (TestRunner::overridePreference):
21478 2013-06-21  Krzysztof Czech  <k.czech@samsung.com>
21480         [ATK] Added support for aria-required attribute.
21481         https://bugs.webkit.org/show_bug.cgi?id=117730
21483         Reviewed by Chris Fleizach.
21485         Added support for testing aria-required attribute.
21487         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
21488         (AccessibilityUIElement::isRequired):
21489         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
21490         (WTR::AccessibilityUIElement::isRequired):
21492 2013-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
21494         [CMAKE][EFL] Enable DOM4 Events Constructor
21495         https://bugs.webkit.org/show_bug.cgi?id=117858
21497         Reviewed by Laszlo Gombos.
21499         * Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
21501 2013-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
21503         [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
21504         https://bugs.webkit.org/show_bug.cgi?id=117827
21506         Reviewed by Rob Buis.
21508         Reset the passed in request if willSendRequestReturnsNull() is
21509         true or willSendRequestReturnsNullOnRedirect() is true and it's a
21510         redirection.
21512         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
21513         (BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
21514         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
21516 2013-06-20  Csaba Osztrogonác  <ossy@webkit.org>
21518         Commit queue shouldn't reopen unrelated bugs because of flakiness
21519         https://bugs.webkit.org/show_bug.cgi?id=117503
21521         Reviewed by Ryosuke Niwa.
21523         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
21524         (_follow_duplicate_chain):
21525         (_update_bug_for_flaky_test):
21527 2013-06-19  Brent Fulgham  <bfulgham@apple.com>
21529         [Windows] AX: Expand notification support.
21530         https://bugs.webkit.org/show_bug.cgi?id=117761
21532         Reviewed by Anders Carlsson.
21534         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
21535         (AccessibilityUIElement::isPressActionSupported): Provide implementation.
21536         (AccessibilityUIElement::press): Provide implementation.
21538 2013-06-19  Benjamin Poulain  <bpoulain@apple.com>
21540         Use the PlatformEvent timestamp when creating a DOM Event
21541         https://bugs.webkit.org/show_bug.cgi?id=117179
21543         Reviewed by Darin Adler.
21545         * WebKitTestRunner/mac/EventSenderProxy.mm:
21546         (WTR::EventSenderProxy::mouseDown):
21547         (WTR::EventSenderProxy::mouseUp):
21548         (WTR::EventSenderProxy::mouseMoveTo):
21549         (WTR::EventSenderProxy::keyDown):
21551 2013-06-18  Alex Christensen  <achristensen@apple.com>
21553         Working on coverage script, added xml to json data extraction script.
21554         https://bugs.webkit.org/show_bug.cgi?id=117648
21556         This is part of a new test code coverage analysis tool.  This compiles WebKit to generate
21557         coverage data, runs the tests, and collects all of the data in json format.
21559         Reviewed by Stephanie Lewis.
21561         * Scripts/generate-coverage-data:
21562         (parseGcovrOutput):
21563         (getFileHitsAndBranches):
21564         (addLineCounts):
21565         (createResultName):
21566         * Scripts/webkitpy/tool/gcovr: Added.
21568 2013-06-18  Ryuan Choi  <ryuan.choi@samsung.com>
21570         Unreviewed build fix after r151699.
21572         * TestWebKitAPI/CMakeLists.txt:
21573         * WebKitTestRunner/CMakeLists.txt:
21574         Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
21576 2013-06-18  Roger Fong  <roger_fong@apple.com>
21578         Replace tools32 folder with tools and update WebKit Windows solution accordingly.
21579         <rdar://problem/14118143>.
21581         Rubberstamped by Brent Fulgham.
21583         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
21584         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
21585         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
21586         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
21587         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
21588         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
21589         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
21590         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
21591         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
21592         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
21593         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
21594         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
21595         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
21596         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
21597         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
21598         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
21599         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
21600         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
21601         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
21602         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
21603         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
21604         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
21605         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
21606         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
21607         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
21608         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
21609         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
21610         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
21611         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
21612         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
21613         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
21614         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
21615         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
21616         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
21617         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
21618         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
21619         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
21620         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
21621         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
21622         * win/record-memory/record-memory.vcxproj:
21623         * win/record-memory/record-memoryDebug.props:
21624         * win/record-memory/record-memoryDebugWinCairo.props:
21625         * win/record-memory/record-memoryProduction.props:
21626         * win/record-memory/record-memoryRelease.props:
21627         * win/record-memory/record-memoryReleaseWinCairo.props:
21629 2013-06-17  Kangil Han  <kangil.han@samsung.com>
21631         Unreviewed. Add my email to a DOM watchlist.
21633         * Scripts/webkitpy/common/config/watchlist:
21635 2013-06-17  Zan Dobersek  <zdobersek@igalia.com>
21637         Unreviewed GTK gardening.
21639         * Scripts/run-gtk-tests:
21640         (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
21642 2013-06-15  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
21644         Unreviewed. Reorder my email addresses.
21645         https://bugs.webkit.org/show_bug.cgi?id=100122
21647         * Scripts/webkitpy/common/config/contributors.json:
21649 2013-06-14  Enrica Casucci  <enrica@apple.com>
21651         WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
21652         https://bugs.webkit.org/show_bug.cgi?id=117647
21653         <rdar://problem/13881024>
21655         Reviewed by Darin Adler.
21656         
21657         The test now uses content with a selection and tests both
21658         forwards and backward find as well as the case of a find
21659         that has no matches after the user selection.
21661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21662         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
21663         (TestWebKitAPI::didFindStringMatches):
21664         * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
21666 2013-06-14  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
21668         Remove myself from Qt build system watchlist
21670         Reviewed by Simon Hausmann.
21672         * Scripts/webkitpy/common/config/watchlist:
21674 2013-06-13  Michael Brüning  <michael.bruning@digia.com>
21676         [Qt][Mac] Disable QTKit video on OS X.
21677         https://bugs.webkit.org/show_bug.cgi?id=117591
21679         Reviewed by Tor Arne Vestbø.
21681         Deployment of Qt binaries to different Mac OS X
21682         platform version makes it impossible to link against
21683         the correct version of the WebKitSystemInterface library,
21684         so we need to disable QTKit for media elements.
21686         * qmake/mkspecs/features/features.prf:
21688 2013-06-13  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
21690         [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
21691         https://bugs.webkit.org/show_bug.cgi?id=116610
21693         Reviewed by Noam Rosenthal.
21695         Remove unnecessary code adjusting context menu position to webview position.
21696         Now position is calculcated in EwkView.
21698         * MiniBrowser/efl/main.c:
21699         (on_context_menu_show):
21701 2013-06-12  Roger Fong  <roger_fong@apple.com>
21703         Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
21705         * Scripts/webkitpy/common/config/ews.json:
21707 2013-06-12  Eduardo Lima Mitev  <elima@igalia.com>
21709         [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
21710         https://bugs.webkit.org/show_bug.cgi?id=115647
21712         Reviewed by Martin Robinson.
21714         Locale resolution is moved to WebKitAccessibleWrapperAtk using
21715         AtkObject::get_object_locale() API. Now, implementation of
21716         AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
21717         be leveraged to get_object_locale() of AtkObject.
21719         Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
21720         method.
21722         No new functionality, no new tests.
21724         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
21725         (AccessibilityUIElement::language): Leverage locale resolution to
21726         AtkObject::get_object_locale().
21727         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
21728         (WTR::AccessibilityUIElement::language): Leverage locale resolution to
21729         AtkObject::get_object_locale().
21731 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
21733         Remove last bits of GYP from build-webkit and update-webkit scripts
21734         https://bugs.webkit.org/show_bug.cgi?id=117557
21736         Reviewed by Ryosuke Niwa.
21738         * Scripts/build-webkit:
21739         * Scripts/update-webkit:
21741 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
21743         Remove forgotten unused Tools/Script/make-gypi script
21744         https://bugs.webkit.org/show_bug.cgi?id=117558
21746         Reviewed by Ryosuke Niwa.
21748         This script isn't used since the GYP removal from WebKit.
21750         * Scripts/make-gypi: Removed.
21752 2013-06-12  Andres Gomez  <agomez@igalia.com>
21754         [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
21755         https://bugs.webkit.org/show_bug.cgi?id=117533
21757         Reviewed by Carlos Garcia Campos.
21759         MiniBrowser now starts automatically the download of the documents
21760         that cannot be shown just by WebKit itself on link left clicking.
21762         * MiniBrowser/gtk/BrowserWindow.c:
21763         (webViewDecidePolicy): handled the
21764         WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
21766 2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
21768         [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
21769         https://bugs.webkit.org/show_bug.cgi?id=116723
21771         Reviewed by Carlos Garcia Campos.
21773         * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
21774         remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
21775         and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
21776         not expensive and produces a working archive without problems even on incremental builds.
21778 2013-06-11  Santosh Mahto  <santosh.ma@samsung.com>
21780         [EFL] Window resize should close the popupmenu
21781         https://bugs.webkit.org/show_bug.cgi?id=117391
21783         Reviewed by Christophe Dumez.
21784         
21785         Added the code to close the popup when main window is resized.
21787         * MiniBrowser/efl/main.c:
21788         (on_window_resize):
21790 2013-06-11  Alex Christensen  <achristensen@apple.com>
21792         Removed old broken code coverage tool.
21793         https://bugs.webkit.org/show_bug.cgi?id=117520
21795         Reviewed by Sam Weinig.
21797         * CodeCoverage: Removed.
21798         * CodeCoverage/README: Removed.
21799         * CodeCoverage/amber.png: Removed.
21800         * CodeCoverage/cov.py: Removed.
21801         * CodeCoverage/emerald.png: Removed.
21802         * CodeCoverage/gcov.css: Removed.
21803         * CodeCoverage/glass.png: Removed.
21804         * CodeCoverage/regenerate-coverage-display: Removed.
21805         * CodeCoverage/ruby.png: Removed.
21806         * CodeCoverage/run-generate-coverage-data: Removed.
21807         * CodeCoverage/snow.png: Removed.
21809 2013-06-11  Timothy Hatcher  <timothy@apple.com>
21811         Have build-webkit build the WebInspectorUI project.
21813         * Scripts/build-webkit:
21815 2013-06-11  Ryosuke Niwa  <rniwa@webkit.org>
21817         Add an option to run-webkit-tests to skip java dependency check
21818         https://bugs.webkit.org/show_bug.cgi?id=117516
21820         Reviewed by Andreas Kling.
21822         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
21823         (parse_args):
21824         * Scripts/webkitpy/port/mac.py:
21825         (MacPort._check_port_build):
21827 2013-06-11  Alex Christensen  <achristensen@apple.com>
21829         https://bugs.webkit.org/show_bug.cgi?id=117514
21830         Removed extra Xcode code coverage flags.
21832         Reviewed by Sam Weinig.
21834         * Scripts/webkitdirs.pm:
21835         (XcodeCoverageSupportOptions):
21837 2013-06-11  Brent Fulgham  <bfulgham@apple.com>
21839         [Windows] Implement 'attributeValue' accessor to support testing
21840         https://bugs.webkit.org/show_bug.cgi?id=117513
21842         Reviewed by Anders Carlsson.
21844         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
21845         (comparableObject): Move earlier in file.
21846         (findAccessibleObjectById): New implemenation.
21847         (AccessibilityController::accessibleElementById): New implementation.
21849 2013-06-11  Csaba Osztrogonác  <ossy@webkit.org>
21851         Make WTR use its own temporary directory for application cache
21852         https://bugs.webkit.org/show_bug.cgi?id=117143
21854         Reviewed by Alexey Proskuryakov.
21856         * WebKitTestRunner/TestController.cpp:
21857         (WTR::TestController::initialize):
21859 2013-06-10  Alexey Proskuryakov  <ap@apple.com>
21861         https://bugs.webkit.org/show_bug.cgi?id=117449
21862         Remove dead code for storing fonts in __DATA section
21864         Reviewed by Dan Bernstein.
21866         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
21867         Don't copy font resources to __DATA, as we don't have any code that reads them
21868         from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").
21870         * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
21871         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
21872         Removed comments suggesting that we want to restore the old solution.
21874 2013-06-10  Bear Travis  <betravis@adobe.com>
21876         [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
21877         https://bugs.webkit.org/show_bug.cgi?id=117162
21879         Reviewed by Alexandru Chiculita.
21881         Adding the WebCore/rendering/shapes directory to the include list.
21883         * DumpRenderTree/efl/CMakeLists.txt:
21885 2013-06-09  Brent Fulgham  <bfulgham@apple.com>
21887         [Windows] Unreviewed test correction:  Prevent DumpRenderTree crashes
21888         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
21889         (AccessibilityUIElement::role): Prevent crashes when m_element is null. This
21890         happends in some of the 'accessibility' test cases.
21892 2013-06-08  peavo@outlook.com  <peavo@outlook.com>
21894         [WinCairo] TestWebKitAPI fails to link.
21895         https://bugs.webkit.org/show_bug.cgi?id=117345
21897         Reviewed by Brent Fulgham.
21899         Need to link with WTF.lib.
21901         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
21903 2013-06-07  Roger Fong  <roger_fong@apple.com>
21905         Get rid of not very helpful test that fails only on some machines because xcrun is not installed.
21907         Rubberstamped by Ryousuke Niwa.
21909         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
21910         (RunTest.test_build_check):
21912 2013-06-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
21914         [Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
21915         https://bugs.webkit.org/show_bug.cgi?id=117315
21917         Reviewed by Benjamin Poulain.
21919         Qt doesn't use the default values specified on FeatureList since r44681,
21920         this patch just remove a bit of noise.
21922         * Scripts/webkitperl/FeatureList.pm:
21924 2013-06-07  Jungsik Tae  <davidtlay88@gmail.com>
21926         [EFL] Implement colorpicker for HTML5 input type color on Minibrowser
21927         https://bugs.webkit.org/show_bug.cgi?id=115890
21929         Reviewed by Christophe Dumez.
21931         When user clicks HTML5 input type color,
21932         color selector window is created on browser object by using elm_colorchooser_add().
21933         It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
21934         The evas_object_color_set() sets a color value returning to browser.
21936         * MiniBrowser/efl/main.c:
21937         (window_free): When we delete parent window, deleting the colorpicker object.
21938         (on_color_changed): Change color of rectangle to show color selected by user.
21939         (on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
21940         (on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
21941         (on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
21942         (on_color_picker_dismiss): Delete colorpicker object.
21943         (on_color_picker_request): Create colorpicker window object.
21944         (window_create):
21946 2013-06-06  Yuki Sekiguchi  <yuki.sekiguchi@access-company.com>
21948         svn-apply cannot apply patches which is generated by git to files that contain space characters in their path
21949         https://bugs.webkit.org/show_bug.cgi?id=111066
21951         Reviewed by Daniel Bates.
21953         Fixes an issue where parseGitDiffHeader() would extract the wrong substring of the diff --git line as the target file path when the source file path contains a space character.
21955         ParseGitDiffHeader() should support the path which line has space characters.
21956         To support this, I changed parsing algorithm like the following:
21957         - When the diff have prefix, we consider next characters after "b/" as part of a file path.
21958         - When the diff have no prefix, we assume that both path have same directory prefix, and we split the diff line using the prefix.
21960         We only support --src-prefix and --dst-prefix don't contain a non-word character (\W) and end with '/' because we cannot distinguish the prefix from directory path.
21962         If the path has a tab, the patch(1) command thinks file path is characters before the tab.
21963         I added a dummy tab and revision when we convert git diff to svn diff.
21965         * Scripts/VCSUtils.pm:
21966         (parseGitDiffHeader):
21967         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Update expectations for dummy revision.
21968         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Ditto.
21969         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Ditto.
21970           - Added test case for files which have space in their path and --src-prefix and --dst-prefix option.
21972 2013-06-06  Simon Fraser  <simon.fraser@apple.com>
21974         Add a menu item to MiniBrowser to toggle Transparent windows
21975         https://bugs.webkit.org/show_bug.cgi?id=117316
21977         Reviewed by Anders Carlsson.
21978         
21979         Add a menu item that toggles "Transparent window" mode, which is exposed
21980         via private WebKit API and WebKit2 API.
21982         * MiniBrowser/mac/BrowserWindowController.h:
21983         * MiniBrowser/mac/MainMenu.xib:
21984         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
21985         * MiniBrowser/mac/WK1BrowserWindowController.m:
21986         (-[WK1BrowserWindowController validateMenuItem:]):
21987         (-[WK1BrowserWindowController toggleTransparentWindow:]):
21988         * MiniBrowser/mac/WK2BrowserWindowController.m:
21989         (-[WK2BrowserWindowController validateMenuItem:]):
21990         (-[WK2BrowserWindowController toggleTransparentWindow:]):
21991         (-[WK2BrowserWindowController dumpSourceToConsole:]): Fix a crash that was seen
21992         when testing.
21994 2013-06-06  Roger Fong  <roger_fong@apple.com>
21996         Stop copying AAS binaries into build folder.
21997         https://bugs.webkit.org/show_bug.cgi?id=117319.
21999         Rubberstamped by Darin Adler.
22001         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
22003 2013-06-06  Hugo Parente Lima  <hugo.lima@openbossa.org>
22005         Aligning build-webkit command line switch names to the WebKit flag names
22006         https://bugs.webkit.org/show_bug.cgi?id=117254
22008         Reviewed by Laszlo Gombos.
22010         * Scripts/webkitperl/FeatureList.pm: Rename some command line switches.
22012 2013-06-06  Chris Fleizach  <cfleizach@apple.com>
22014         AX: iOS ignores ARIA progressbar elements
22015         https://bugs.webkit.org/show_bug.cgi?id=116727
22017         Reviewed by David Kilzer.
22019         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
22020         (AccessibilityUIElement::minValue):
22021         (AccessibilityUIElement::maxValue):
22023 2013-06-06  peavo@outlook.com  <peavo@outlook.com>
22025         [WinCairo] Fix build-webkit to build WinCairo under VS2010.
22026         https://bugs.webkit.org/show_bug.cgi?id=117255
22028         Reviewed by Daniel Bates.
22030         Need to update configuration names according to solution file.
22032         * Scripts/webkitdirs.pm:
22033         (determineConfiguration):
22034         (determinePassedConfiguration):
22036 2013-06-06  Ryosuke Niwa  <rniwa@webkit.org>
22038         Remove run-performance-tests
22039         https://bugs.webkit.org/show_bug.cgi?id=117285
22041         Reviewed by Andreas Kling.
22042         
22043         Remove the script since it's not used anywhere.
22045         * BuildSlaveSupport/run-performance-tests: Removed.
22047 2013-06-05  Bear Travis  <betravis@adobe.com>
22049         [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
22050         https://bugs.webkit.org/show_bug.cgi?id=117172
22052         Reviewed by Alexandru Chiculita.
22054         Adding the CSS_SHAPES compile flag.
22056         * Scripts/webkitperl/FeatureList.pm:
22057         * qmake/mkspecs/features/features.pri:
22059 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
22061         [Windows] Unreviewed build fix. Add CRLF eol-style for DOS shell scripts; if they accidentally change
22062         to UNIX-style they will not execute properly.
22064         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added property svn:eol-style.
22065         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added property svn:eol-style.
22067 2013-06-05  Roger Fong  <roger_fong@apple.com>
22069         Unreviewed build fix. Don't pass in --use-remote-links argument on Windows now that we use NRWT.
22071         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
22072         (RunWebKitTests.start):
22074 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
22076         [Windows] Switch to NRWT
22077         https://bugs.webkit.org/show_bug.cgi?id=117200
22079         Reviewed by Anders Carlsson.
22081         * Scripts/run-webkit-tests:
22082         (useNewRunWebKitTests): No longer use old-run-webkit-tests for Windows port.
22084 2013-06-05  Dominik Röttsches  <dominik.rottsches@intel.com>
22086         Unreviewed name fix after r150662
22088         My firstname got duplicated when fixing bug 116737.
22090         * Scripts/webkitpy/common/config/contributors.json:
22092 2013-06-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
22094         Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
22095         https://bugs.webkit.org/show_bug.cgi?id=117244
22097         Reviewed by Daniel Bates.
22099         Fixed a regression introduced by r151196: not only does webkit.org
22100         still mention WEBKITOUTPUTDIR instead of WEBKIT_OUTPUTDIR, but the
22101         infrastructure used by ports such as GTK+ and EFL also use on it for
22102         things such as jhbuild.
22104         While everything is not fully transitioned to WEBKIT_OUTPUTDIR, read
22105         both environment variables.
22107         * Scripts/webkitdirs.pm:
22108         (determineBaseProductDir):
22110 2013-06-05  Wojciech Bielawski  <w.bielawski@samsung.com>
22112         [GTK] Forwarding headers not generated for incremental build
22113         https://bugs.webkit.org/show_bug.cgi?id=117198
22115         Reviewed by Carlos Garcia Campos.
22117         * WebKitTestRunner/GNUmakefile.am: libTestRunnerInjectedBundle added to dependencies.
22119 2013-06-05  Andras Becsi  <andras.becsi@digia.com>
22121         [Qt][WK2] Fix layout testing with Qt 5.1
22122         https://bugs.webkit.org/show_bug.cgi?id=117203
22124         Reviewed by Jocelyn Turcotte.
22126         With Qt 5.1 synchronous requests via QNetworkAccessManager do not
22127         go into loading state but directly call handler functions for
22128         finished state instead of relying on a connection.
22129         Our wrapper QQuickView uses a data URI scheme to create the root
22130         item for testing which results in a synchronous request when loading
22131         the QML data, therefore the state of the QQuickWindow immediately
22132         becomes Ready.
22133         Since the final initialization of the root item depended on the
22134         emission of QQuickView::statusChanged(QQuickView::Ready) we ended
22135         up with a partially initialized wrapper window, thus most of our
22136         layout tests were failing.
22137         For compatibility with pre-5.1 Qt versions keep the old behaviour
22138         in case the WrapperWindow is not ready in the constructor yet.
22140         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
22141         (WTR::WrapperWindow::WrapperWindow):
22142         * TestWebKitAPI/qt/PlatformWebViewQt.cpp:
22143         (TestWebKitAPI::WrapperWindow::WrapperWindow):
22145 2013-06-05  Dariusz Frankiewicz  <d.frankiewic@samsung.com>
22147         Bad value in tests counter at new-run-webkit-tests
22148         in --debug-rwt-logging mode
22149         https://bugs.webkit.org/show_bug.cgi?id=116858
22151         Reviewed by Dirk Pranke.
22153         Fix by moving counter incrementation, from after printing line,
22154         to before printing. Also changed variable name.
22156         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
22157         (LayoutTestRunner.run_tests):
22158         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
22159         (FakePrinter):
22160         * Scripts/webkitpy/layout_tests/views/printing.py:
22161         (Printer.__init__):
22162         (Printer._test_status_line):
22163         (Printer.print_started_test):
22164         (Printer.print_finished_test):
22165         * Scripts/webkitpy/test/printer.py:
22166         (Printer.__init__):
22167         (Printer.print_finished_test):
22168         (Printer._test_line):
22169         (Printer.print_result):
22171 2013-06-05  Zan Dobersek  <zdobersek@igalia.com>
22173         Move MemoryInfo under window.internals
22174         https://bugs.webkit.org/show_bug.cgi?id=117197
22176         Reviewed by Ryosuke Niwa.
22178         * GNUmakefile.am: Add the testing/MemoryInfo.(h|idl) files and the generated targets to
22179         the Automake build
22180         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: List the
22181         testing/MemoryInfo.idl file instead of page/MemoryInfo.idl.
22183 2013-06-03  Roger Fong  <roger_fong@apple.com>
22185         Remove uses of VS2005 scripts, executables and associated environment variables from scripts.
22186         <rdar://problem/14042021>.
22188         Reviewed by Brent Fulgham.
22190         * Scripts/build-api-tests:
22191         * Scripts/build-dumprendertree:
22192         * Scripts/build-webkit:
22193         * Scripts/update-webkit-dependency:
22194         * Scripts/update-webkit-support-libs:
22195         * Scripts/webkitdirs.pm:
22196         (determineBaseProductDir):
22197         (setupAppleWinEnv):
22198         (setupCygwinEnv):
22200 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
22202         [Windows] NRWT is not putting crash logs in proper place (corrections)
22203         https://bugs.webkit.org/show_bug.cgi?id=117212
22205         Reviewed by Dirk Pranke.
22207         * Scripts/webkitpy/common/system/crashlogs.py:
22208         (CrashLogs.__init__): Accept a result directory argument in constructor.
22209         (CrashLogs.find_newest_log): Don't require 'port' argument anymore.
22210         (CrashLogs._find_newest_log_win): No longer use 'port' argument.
22211         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
22212         (CrashLogsTest.test_find_log_win): Simplify test.
22213         * Scripts/webkitpy/common/system/executive.py:
22214         (Executive.running_pids): Handle "win32" case separately from "cygwin" case.
22215         * Scripts/webkitpy/port/win.py:
22216         (WinPort._get_crash_log): No longer require 'port' argument.
22218 2013-06-04  Ryosuke Niwa  <rniwa@webkit.org>
22220         Build fix after r150592. We need to disable \2 shouldn't be treated as an escape character.
22222         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
22224 2013-06-04  Greg Hughes  <ghughes@apple.com>
22226         Add "VisibleOnly" key to search predicate
22227         https://bugs.webkit.org/show_bug.cgi?id=115491
22229         Reviewed by Chris Fleizach.
22231         Added support for accessibility clients to use the search predicate to find only visible elements
22233         * DumpRenderTree/AccessibilityUIElement.cpp:
22234         (uiElementForSearchPredicateCallback):
22235         * DumpRenderTree/AccessibilityUIElement.h:
22236         (AccessibilityUIElement):
22237         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
22238         (AccessibilityUIElement::uiElementForSearchPredicate):
22239         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
22240         (AccessibilityUIElement::uiElementForSearchPredicate):
22241         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
22242         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
22243         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
22244         (AccessibilityUIElement):
22245         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
22246         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
22247         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
22249 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
22251         [Windows] Unreviewed build fix.  The last check-in lost CR/LF endings on the batch file,
22252         causing build failure.
22254         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Revert to
22255         DOS-style CR/LF endings.
22257 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
22259         [Windows] Unreviewed test correction.
22261         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Also copy the
22262         QuartzCore dll's, which are needed by TestWebKitAPI.
22263         * TestWebKitAPI/win/main.cpp: Declare proper manfifest dependencies to ensure TestWebKitAPI built
22264         with VS2010 will run when linked against VS2005 support libraries.
22266 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
22268         Automatically generate WorkerContext constructor attributes
22269         https://bugs.webkit.org/show_bug.cgi?id=117183
22271         Reviewed by Kentaro Hara.
22273         Pass new --workerContextConstructorsFile to preprocess-idl.pl for bindings
22274         tests.
22276         * Scripts/webkitpy/bindings/main.py:
22277         (BindingsTests.generate_supplemental_dependency):
22278         (BindingsTests.main):
22280 2013-06-04  Ryuan Choi  <ryuan.choi@samsung.com>
22282         [EFL] File dialog of MiniBrowser have broken background.
22283         https://bugs.webkit.org/show_bug.cgi?id=117189
22285         Reviewed by Christophe Dumez.
22287         * MiniBrowser/efl/main.c:
22288         (on_file_chooser_request): Added elm_bg for elm_win of file chooser.
22290 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
22292         [WKTR][WTK] Undefined symbols in libTestRunnerInjectedBundle.so after r151124
22293         https://bugs.webkit.org/show_bug.cgi?id=117184
22295         Reviewed by Gyuyoung Kim.
22297         Add ATK stubs for mathPostscriptsDescription() and mathPrescriptsDescription() so
22298         that we don't have undefined symbols in libTestRunnerInjectedBundle.so.
22300         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
22301         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
22302         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
22304 2013-06-03  Simon Pena  <simon.pena@samsung.com>
22306         validate-committer-lists script is now outdated and does not work
22307         https://bugs.webkit.org/show_bug.cgi?id=115860
22309         Reviewed by Brent Fulgham.
22311         The script validate-committer-lists was outdated, still using the deprecated log
22312         system and having the old addresses for the mailing lists, as well as still referring
22313         to committers.py, after this was renamed to contributors.json. This patch fixes that
22314         so it can be used again.
22316         * Scripts/validate-committer-lists: Replace calls to log and error with the
22317         new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
22318         to committers.py, which should be contributors.json.
22319         (CommitterListFromMailingList):
22320         (CommitterListFromMailingList.check_for_emails_missing_from_list):
22321         (CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
22322         (CommitterListFromGit._fill_in_emails_for_old_logins):
22323         (CommitterListFromGit.print_committers_missing_from_committer_list):
22325 2013-06-03  Dirk Pranke  <dpranke@chromium.org>
22327         add a script to dump the tests run most recently by a given worker
22328         https://bugs.webkit.org/show_bug.cgi?id=116571
22330         Reviewed by Brent Fulgham.
22332         The tests_run*.txt results files in layout-test-results/ were removed
22333         in r137356, in favor of collecting more data about how the tests were
22334         run and compressing it and storing it in stats.json. However, it was
22335         nice to just be able to look at a flat text file.
22337         This script will extract the tests run by a given worker from a
22338         given stats.json file, and should help to address that.
22340         * Scripts/dump-webkit-tests-run: Added.
22341         (main):
22342         (convert_trie_to_flat_paths):
22344 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
22346         [Windows] NRWT is not putting crash logs in proper place
22347         https://bugs.webkit.org/show_bug.cgi?id=117098
22349         Reviewed by Ryosuke Niwa.
22351         Provide windows-specific overloads for various Port features needed to create and capture
22352         crash logs.  This change makes it possible to view crash logs (when created) as part of the
22353         summary report at the end of the NRWT run.
22355         * Scripts/webkitpy/common/system/crashlogs.py:
22356         (CrashLogs.find_newest_log): Add support for win32 crash logs
22357         (CrashLogs._find_newest_log_win): Added
22358         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
22359         (make_mock_crash_report_win): Added
22360         (CrashLogsTest.test_find_log_win): Added.
22361         * Scripts/webkitpy/common/system/executive.py:
22362         (Executive.running_pids): Add support for Cygwin win32 crash logs
22363         * Scripts/webkitpy/common/system/executive_mock.py:
22364         (MockExecutive.__init__):
22365         * Scripts/webkitpy/common/system/filesystem_unittest.py:
22366         (RealFileSystemTest.test_read_and_write_file): Add tests for
22367         malformed ascii/utf8 handling (i.e., Windows log files)
22368         * Scripts/webkitpy/port/base.py:
22369         (Port.find_system_pid): Added
22370         * Scripts/webkitpy/port/server_process.py:
22371         (ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs
22372         * Scripts/webkitpy/port/win.py:
22373         (WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
22374         for user to hit enter.
22375         (WinPort._get_crash_log): Added
22376         (WinPort.look_for_new_crash_logs): Added
22377         (WinPort.find_system_pid): Added
22378         * Scripts/webkitpy/port/win_unittest.py:
22379         (WinPortTest.test_get_crash_log): Added test
22381 2013-06-03  Eduardo Lima Mitev  <elima@igalia.com>
22383         [EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
22384         https://bugs.webkit.org/show_bug.cgi?id=116726
22386         Reviewed by Gyuyoung Kim.
22388         Current version of ATK in efl-ews environment is 2.4.0 and is taken from
22389         the platform (it is not listed in jhbuild moduleset). That version is
22390         old-ish and contain deprecated symbols and missing API, that are blocking
22391         patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
22392         moduleset, which is the same version the gtk port uses.
22394         See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
22395         why this is needed.
22397         * efl/jhbuild.modules: Adds ATK module as dependency
22399 2013-06-03  Erik van Pienbroek  <epienbro@fedoraproject.org>
22401         [GTK] Respect PKG_CONFIG env variable when generating gtk-doc
22402         https://bugs.webkit.org/show_bug.cgi?id=117168
22404         Reviewed by Martin Robinson.
22406         The tool generate-gtkdoc internally calls pkg-config.
22407         When cross-compiling it shouldn't use pkg-config, but
22408         it should use the pkg-config which was detected by
22409         the ./configure script (for example this can be
22410         i686-w64-mingw32-pkg-config when cross-compiling)
22412         * GNUmakefile.am:
22413         * gtk/gtkdoc.py:
22414         (PkgConfigGTKDoc.__init__):
22416 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
22418         [Windows] Unreviewed build fix.
22420         * TestWebKitAPI/win/main.cpp: Embed proper manifest information to
22421         allow VS2010 builds to use VS2005 runtime libraries as needed.
22423 2013-06-03  Roger Fong  <roger_fong@apple.com>
22425         Nuke VS2005 files from the tree.
22426         <rdar://problem/14042021>.
22428         Rubberstamped by Brent Fulgham.
22430         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Removed.
22431         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Removed.
22432         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Removed.
22433         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Removed.
22434         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Removed.
22435         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Removed.
22436         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Removed.
22437         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Removed.
22438         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Removed.
22439         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Removed.
22440         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Removed.
22441         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Removed.
22442         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Removed.
22443         * DumpRenderTree/win/DumpRenderTree.vcproj: Removed.
22444         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Removed.
22445         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Removed.
22446         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Removed.
22447         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Removed.
22448         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Removed.
22449         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Removed.
22450         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Removed.
22451         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Removed.
22452         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Removed.
22453         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Removed.
22454         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Removed.
22455         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Removed.
22456         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Removed.
22457         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Removed.
22458         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Removed.
22459         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Removed.
22460         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Removed.
22461         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Removed.
22462         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Removed.
22463         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Removed.
22464         * DumpRenderTree/win/ImageDiff.vcproj: Removed.
22465         * DumpRenderTree/win/ImageDiffCommon.vsprops: Removed.
22466         * DumpRenderTree/win/ImageDiffDebug.vsprops: Removed.
22467         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Removed.
22468         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Removed.
22469         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Removed.
22470         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Removed.
22471         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Removed.
22472         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Removed.
22473         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Removed.
22474         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Removed.
22475         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Removed.
22476         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Removed.
22477         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Removed.
22478         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Removed.
22479         * DumpRenderTree/win/ImageDiffProduction.vsprops: Removed.
22480         * DumpRenderTree/win/ImageDiffRelease.vsprops: Removed.
22481         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Removed.
22482         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Removed.
22483         * Scripts/pdevenv: Removed.
22484         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Removed.
22485         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Removed.
22486         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Removed.
22487         * WebKitLauncherWin: Removed.
22488         * WebKitLauncherWin/Resource.h: Removed.
22489         * WebKitLauncherWin/WebKitLauncherWin.cpp: Removed.
22490         * WebKitLauncherWin/WebKitLauncherWin.rc: Removed.
22491         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Removed.
22492         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Removed.
22493         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Removed.
22494         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Removed.
22495         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Removed.
22496         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Removed.
22497         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Removed.
22498         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Removed.
22499         * WebKitLauncherWin/webkit.ico: Removed.
22500         * WinLauncher/WinLauncher.ico: Removed.
22501         * WinLauncher/WinLauncher.rc: Removed.
22502         * WinLauncher/WinLauncher.vcproj: Removed.
22503         * WinLauncher/WinLauncherCommon.vsprops: Removed.
22504         * WinLauncher/WinLauncherDebug.vsprops: Removed.
22505         * WinLauncher/WinLauncherDebugAll.vsprops: Removed.
22506         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Removed.
22507         * WinLauncher/WinLauncherLauncher.rc: Removed.
22508         * WinLauncher/WinLauncherLauncher.vcproj: Removed.
22509         * WinLauncher/WinLauncherLauncherCommon.vsprops: Removed.
22510         * WinLauncher/WinLauncherLauncherDebug.vsprops: Removed.
22511         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Removed.
22512         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Removed.
22513         * WinLauncher/WinLauncherLauncherProduction.vsprops: Removed.
22514         * WinLauncher/WinLauncherLauncherRelease.vsprops: Removed.
22515         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Removed.
22516         * WinLauncher/WinLauncherLauncherResource.h: Removed.
22517         * WinLauncher/WinLauncherPostBuild.cmd: Removed.
22518         * WinLauncher/WinLauncherPreBuild.cmd: Removed.
22519         * WinLauncher/WinLauncherProduction.vsprops: Removed.
22520         * WinLauncher/WinLauncherRelease.vsprops: Removed.
22521         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Removed.
22522         * WinLauncher/small.ico: Removed.
22523         * record-memory-win: Removed.
22524         * record-memory-win/main.cpp: Removed.
22525         * record-memory-win/record-memory-win-common.vsprops: Removed.
22526         * record-memory-win/record-memory-win.vcproj: Removed.
22527         * record-memory-win/record-memory-winDebug.vsprops: Removed.
22528         * record-memory-win/record-memory-winDebugAll.vsprops: Removed.
22529         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Removed.
22530         * record-memory-win/record-memory-winProduction.vsprops: Removed.
22531         * record-memory-win/record-memory-winRelease.vsprops: Removed.
22532         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Removed.
22534 2013-06-03  Chris Fleizach  <cfleizach@apple.com>
22536         AX: MathML multiscripts not exposed in Accessibility
22537         https://bugs.webkit.org/show_bug.cgi?id=115069
22539         Reviewed by Tim Horton.
22541         Add methods to help output components of math multiscripts for accessibility.
22543         * DumpRenderTree/AccessibilityUIElement.cpp:
22544         (mathPostscriptsDescriptionCallback):
22545         (mathPrescriptsDescriptionCallback):
22546         (AccessibilityUIElement::getJSClass):
22547         * DumpRenderTree/AccessibilityUIElement.h:
22548         (AccessibilityUIElement):
22549         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
22550         (convertMathMultiscriptPairsToString):
22551         (AccessibilityUIElement::mathPostscriptsDescription):
22552         (AccessibilityUIElement::mathPrescriptsDescription):
22553         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
22554         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
22555         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
22556         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
22557         (AccessibilityUIElement):
22558         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
22559         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
22560         (WTR::_convertMathMultiscriptPairsToString):
22561         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
22562         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
22564 2013-06-03  Commit Queue  <commit-queue@webkit.org>
22566         Unreviewed, rolling out r151109.
22567         http://trac.webkit.org/changeset/151109
22568         https://bugs.webkit.org/show_bug.cgi?id=117145
22570         "Plugins in WK2 aren't implemented yet." (Requested by
22571         jturcotte on #webkit).
22573         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
22574         * qmake/mkspecs/features/features.prf:
22575         * qmake/mkspecs/features/unix/default_pre.prf:
22577 2013-05-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
22579         [Qt] Re-enable plugins on Mac.
22580         https://bugs.webkit.org/show_bug.cgi?id=116622
22582         Reviewed by Tor Arne Vestbø.
22584         Plugins on Mac were only enabled if !embedded but the later was set if
22585         QPA is enabled, which is the default since Qt 5.0.
22587         Remove references to 'embedded' and fix various build issues,
22588         PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
22589         months.
22591         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
22592         * qmake/mkspecs/features/features.prf:
22593         * qmake/mkspecs/features/unix/default_pre.prf:
22595 2013-06-03  Krzysztof Czech  <k.czech@samsung.com>
22597         [GTK][WK2] accessibility/placeholder.html is failing
22598         https://bugs.webkit.org/show_bug.cgi?id=106344
22600         Reviewed by Gyuyoung Kim.
22602         Adds support for retrieving attribute value.
22604         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
22605         (WTR::coreAttributeToAtkAttribute):
22606         (WTR::AccessibilityUIElement::stringAttributeValue):
22608 2013-06-01  Tim Horton  <timothy_horton@apple.com>
22610         Add a preferred email address and "expertise" for me.
22612         * Scripts/webkitpy/common/config/contributors.json:
22614 2013-05-31  Roger Fong  <roger_fong@apple.com>
22616         Unreviewed. Make windows test bots search in the correct directory for build output.
22618         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
22619         (RunWebKitTests.start):
22620         * Scripts/webkitdirs.pm:
22621         (determineConfigurationProductDir):
22623 2013-05-31  Roger Fong  <roger_fong@apple.com>
22625         Unreviewed. Windows build fix...
22627         * BuildSlaveSupport/built-product-archive:
22628         (createZip):
22630 2013-05-31  Roger Fong  <roger_fong@apple.com>
22632         Unreviewed. Windows build fix. One more time!
22634         * BuildSlaveSupport/built-product-archive:
22635         (archiveBuiltProduct):
22636         (extractBuiltProduct):
22638 2013-05-31  Roger Fong  <roger_fong@apple.com>
22640         Unreviewed. Windows build fix.
22642         * Scripts/build-webkit:
22644 2013-05-31  Roger Fong  <roger_fong@apple.com>
22646         Unreviewed. Windows build fix.
22648         * Scripts/build-webkit:
22650 2013-05-31  Roger Fong  <roger_fong@apple.com>
22652         Make build-webkit output VCExpress 2010 build logs properly.
22653         https://bugs.webkit.org/show_bug.cgi?id=117096
22655         Reviewed by Brent Fulgham.
22657         Make it so that output from VCExpress is always printed to console.
22658         Get build log results from AssembleBuildLogs project output.
22659         We don't need those old VCExpress scripts anymore either. 
22661         * Scripts/build-webkit:
22662         * Scripts/print-msvc-project-dependencies: Removed.
22663         * Scripts/print-vse-failure-logs: Removed.
22665 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
22667         [Windows] Use WinLauncher to display LayoutTest results
22668         https://bugs.webkit.org/show_bug.cgi?id=117085
22670         Reviewed by Oliver Hunt.
22672         * Scripts/webkitdirs.pm:
22673         (runSafari): Use WinLauncher to display content
22674         * WinLauncher/WinLauncher.cpp:
22675         (dllLauncherEntryPoint): Check for URL argument.
22677 2013-05-31  Roger Fong  <roger_fong@apple.com>
22679         Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
22681         * win/AssembleBuildLogs/AssembleLogs.cmd:
22683 2013-05-31  Commit Queue  <commit-queue@webkit.org>
22685         Unreviewed, rolling out r151022.
22686         http://trac.webkit.org/changeset/151022
22687         https://bugs.webkit.org/show_bug.cgi?id=117084
22689         Also breaks build by introducing duplicate symbols (Requested
22690         by bfulgham on #webkit).
22692         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
22694 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
22696         [Windows] Unreviewed build fix to NRWT
22698         * Scripts/webkitpy/port/win.py:
22699         (WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.
22701 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
22703         [Windows] Unreviewed build fix after r151012
22705         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on
22706         WTF library to support SHA tests
22708 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
22710         [Windows] Unreviewed build fix after r151012
22712         * TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide
22713         snprintf definition for Windows.
22715 2013-05-31  Zan Dobersek  <zdobersek@igalia.com>
22717         Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
22718         https://bugs.webkit.org/show_bug.cgi?id=116445
22720         Reviewed by Benjamin Poulain.
22722         Add the MD5 and SHA1 unit tests that were previously located inside WTF.
22724         * TestWebKitAPI/CMakeLists.txt:
22725         * TestWebKitAPI/GNUmakefile.am:
22726         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
22727         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
22728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22729         * TestWebKitAPI/Tests/WTF/MD5.cpp: Added.
22730         (TestWebKitAPI):
22731         (TestWebKitAPI::expectMD5):
22732         (TestWebKitAPI::TEST):
22733         * TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.
22734         (TestWebKitAPI):
22735         (TestWebKitAPI::expectSHA1):
22736         (TestWebKitAPI::TEST):
22737         * TestWebKitAPI/Tests/WTF/WTF.pro:
22738         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
22740 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
22742         [Windows] Unreviewed build correction.
22744         * Scripts/webkitpy/port/win.py:
22745         (WinPort.create_debugger_command_file): The directory needs to be
22746         a string, not a temporary directory object.
22748 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
22750         [Windows] NRWT doesn't save crash logs on Apple's Windows port.
22751         https://bugs.webkit.org/show_bug.cgi?id=76935
22753         Reviewed by Ryosuke Niwa.
22755         Extend the WinPort class with commands to set and clean up various registry
22756         values needed to invoke the correct debugger to get crash files.
22758         * Scripts/webkitpy/port/win.py:
22759         (WinPort): Added global caches for registry keys and settings
22760         (WinPort._ntsd_location): Added
22761         (WinPort.create_debugger_command_file): Added
22762         (WinPort.read_registry_string): Added
22763         (WinPort.write_registry_string): Added
22764         (WinPort.setup_crash_log_saving): Added
22765         (WinPort.restore_crash_log_saving): Added
22766         (WinPort.setup_test_run): Added overload to add registry settings.
22767         (WinPort.clean_up_test_run): Added overload to clean up registry settings.
22769 2013-05-30  Roger Fong  <roger_fong@apple.com>
22771         Get rid of JavaScript exports file on AppleWin port.
22772         https://bugs.webkit.org/show_bug.cgi?id=117050.
22774         Reviewed by Darin Adler.
22776         Start linking in WTF.lib now that it's a shared library.
22778         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
22779         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
22780         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
22782 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
22784         Web Inspector: tests in PerformanceTests/inspector/ are timing out
22785         https://bugs.webkit.org/show_bug.cgi?id=77024
22787         Reviewed by Andreas Kling.
22789         Remove inspector performance tests since they have been disabled for ages,
22790         and they don't use the standard parser-style performance output.
22792         It's adding a lot of code complexity to our infrastructure.
22794         * Scripts/webkitpy/performance_tests/perftest.py:
22795         (SingleProcessPerfTest.__init__):
22796         (PerfTestFactory):
22797         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
22798         (TestPerfTestFactory.test_regular_test):
22799         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
22800         (TestDriver.run_test):
22801         (MainTest.run_test):
22802         (MainTest._tests_for_runner):
22803         (MainTest.test_run_test_set_kills_drt_per_run):
22804         (MainTest._test_run_with_json_output):
22805         (MainTest):
22806         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
22808 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
22810         Remove requires_http_server as Chromium Android was the only port that needed this
22811         https://bugs.webkit.org/show_bug.cgi?id=117018
22813         Reviewed by Benjamin Poulain.
22815         Removed the unused code that existed for Chromium Android port.
22817         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
22818         (LayoutTestRunner.run_tests):
22819         (LayoutTestRunner._handle_finished_test_list):
22820         * Scripts/webkitpy/layout_tests/controllers/manager.py:
22821         (Manager._run_tests):
22822         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
22823         (PerfTestsRunner._collect_tests):
22824         (PerfTestsRunner.run):
22825         * Scripts/webkitpy/port/base.py:
22826         (Port.to.start_helper):
22827         * Scripts/webkitpy/port/base_unittest.py:
22828         (PortTest.test_build_path):
22830 2013-05-29  Ruth Fong  <ruth_fong@apple.com>
22832         prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
22833         https://bugs.webkit.org/show_bug.cgi?id=113221
22835         Reviewed by Ryosuke Niwa.
22837         Teach prepare-Changelog to not list the names of modified namespaces, 
22838         classes, or structs in C++ files. Thus, if a change is made 
22839         within a namespace/class/struct yet outside a function, it will 
22840         not be reflected in the ChangeLog entry. 
22841         See https://bugs.webkit.org/show_bug.cgi?id=113221#c8 
22842         for more details on how ChangeLog entries are affected.
22844         * Scripts/prepare-ChangeLog:
22845         (get_function_line_ranges_for_cpp): 
22846         (delete_namespaces_from_ranges_for_cpp): Added.
22847         (is_function_in_namespace): Added.
22848         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Updated
22849         to reflect revised definition of a function (i.e. excludes namespaces, classes, structs)
22851 2013-05-29  Praveen R Jadhav  <praveen.j@samsung.com>
22853         Cleanup AudioSourceNode.idl from WebKit build.
22854         https://bugs.webkit.org/show_bug.cgi?id=116905.
22856         Reviewed by Darin Adler.
22858         AudioSourceNode.idl is not part of WebAudio Specifications anymore.
22859         AudioNode is inherited directly in all the audio source nodes.
22861         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
22863 2013-05-29  Andrew Lo  <anlo@rim.com>
22865         Add Andrew Lo to contributors.json
22866         https://bugs.webkit.org/show_bug.cgi?id=116981
22868         Reviewed by Rob Buis.
22870         Adding Andrew Lo to contributors.json.
22872         * Scripts/webkitpy/common/config/contributors.json:
22874 2013-05-29  Adenilson Cavalcanti  <cavalcantii@gmail.com>
22876         Unreviewed. Adding myself as a committer.
22878         * Scripts/webkitpy/common/config/contributors.json:
22880 2013-05-29  Marcelo Lira  <marcelo.lira@openbossa.org>
22882         [WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says
22883         https://bugs.webkit.org/show_bug.cgi?id=116683
22885         Reviewed by Noam Rosenthal.
22887         A coordinates conversion test for WKViewUserViewportToContents was
22888         added to WebKit2 API tests.
22890         * TestWebKitAPI/PlatformEfl.cmake:
22891         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.
22892         (TestWebKitAPI):
22893         (TestWebKitAPI::TEST):
22895 2013-05-29  Yong Li  <yong.li.webkit@outlook.com>
22897         Unreviewed. Update my info.
22899         * Scripts/webkitpy/common/config/contributors.json:
22901 2013-05-29  Dongseong Hwang  <dongseong.hwang@intel.com>
22903         Unreviewed. Add myself as committer in contributors.json.
22905         * Scripts/webkitpy/common/config/contributors.json:
22907 2013-05-29  Carlos Garcia Campos  <cgarcia@igalia.com>
22909         Unreviewed. Fix make distcheck.
22911         * TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
22912         DISTCLEANFILES.
22914 2013-05-29  Mary Wu  <mawu@blackberry.com>
22916         Unreviewed: update my email address in contributors.json.
22918         * Scripts/webkitpy/common/config/contributors.json:
22920 2013-05-29  Kalyan Kondapally  <kalyan.kondapally@intel.com>
22922         Unreviewed: Adding myself to committers list.
22924         * Scripts/webkitpy/common/config/contributors.json:
22926 2013-05-28  Arpita Bahuguna  <a.bah@samsung.com>
22928         Unreviewed: Adding myself to committers list.
22930         * Scripts/webkitpy/common/config/contributors.json:
22932 2013-05-28  Brent Fulgham  <bfulgham@webkit.org>
22934         [Windows] Many CSS2.1 tests fail under NRWT.
22935         https://bugs.webkit.org/show_bug.cgi?id=75707
22937         Reviewed by Darin Adler.
22939         * DumpRenderTree/win/DumpRenderTree.cpp:
22940         (findFontFallback): Added
22941         (addFontFallbackIfPresent): Added
22942         (removeFontFallbackIfPresent): Added
22943         (runTest): Set up/remove font fallbacks when needed.
22945 2013-05-28  Brent Fulgham  <bfulgham@apple.com>
22947         [Windows] NRWT reports failure for 'mac' test cases.
22948         https://bugs.webkit.org/show_bug.cgi?id=116698
22950         Reviewed by Ryosuke Niwa.
22952         The Windows port falls back to the Mac port for many test results,
22953         and so adds the mac and mac-wk2 to its set of fallbacks.
22954         Unfortunately, NRWT thinks that this means that tests in these
22955         folders should be executed, resulting in many failures on
22956         Windows.
22958         This change overloads the '_tests_for_other_platforms' method
22959         to return a subset of the result fallback list so that we do
22960         not attempt to execute Mac tests on Windows.
22962         * Scripts/webkitpy/port/base.py:
22963         (Port.test_search_path): Added. Defaults to just calling the
22964         baseline_search_path method, which is how most ports behave.
22965         (Port._test_for_other_platforms): Modified to call the new
22966         test_search_path method.
22968         * Scripts/webkitpy/port/win.py:
22969         (WinPort.test_search_path): Added custom overload. Strips
22970         out mac-specific test paths.
22972 2013-05-28  Martin Robinson  <mrobinson@igalia.com>
22974         Fix GTK+ CMake build
22976         * MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
22977         library target is simply "WebKit2."
22979 2013-05-28  Zan Dobersek  <zdobersek@igalia.com>
22981         [webkitpy] Explicitly specify the reference file extensions
22982         https://bugs.webkit.org/show_bug.cgi?id=116333
22984         Reviewed by Benjamin Poulain.
22986         Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
22987         between valid reference files required by reftests and text baselines that have the same extension as
22988         potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
22989         that were until this change recognized as reference files).
22991         Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.
22993         * Scripts/webkitpy/port/base.py:
22994         (Port.reference_files): Iterate through the _supported_reference_extensions set.
22995         (Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
22996         _supported_reference_extensions set, containing the extensions allowed for reference files.
22997         (Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
22998         (Port._has_supported_extension): Use _supported_test_extensions.
22999         * Scripts/webkitpy/port/base_unittest.py:
23000         (PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
23001         Port.is_reference_html_file method.
23003 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
23005         Yet another WKR build fix. Sorry for the mess. It seems like I can't win today :(
23007         * Scripts/webkitpy/tool/commands/newcommitbot.py:
23008         (NewCommitBot.next_work_item):
23010 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
23012         WKR and webkitbot build fixes.
23014         * Scripts/webkitpy/tool/bot/irc_command.py:
23015         (RollChromiumDEPS.execute):
23016         * Scripts/webkitpy/tool/commands/newcommitbot.py:
23017         (NewCommitBot.next_work_item):
23019 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
23021         roll-chromium-deps doesn't repeat the full name.
23023         Rubber-stamped by Andreas Kling.
23025         * Scripts/webkitpy/tool/bot/irc_command.py:
23026         (RollChromiumDEPS.execute):
23028 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
23030         Revert another erroneous change.
23032         * Scripts/webkitpy/tool/commands/newcommitbot.py:
23033         (NewCommitBot.next_work_item):
23035 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
23037         Revert an erroneous change.
23039         * Scripts/webkitpy/tool/commands/sheriffbot.py:
23040         (SheriffBot):
23042 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
23044         Some build fixes for WKR and webkitbot.
23046         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
23047         (IRCBotTest.test_help):
23048         * Scripts/webkitpy/tool/commands/newcommitbot.py:
23049         (Agent):
23050         (Agent.__init__):
23051         (Agent.name):
23052         (NewCommitBot):
23053         (NewCommitBot.begin_work_queue):
23054         (NewCommitBot.next_work_item):
23055         * Scripts/webkitpy/tool/commands/sheriffbot.py:
23056         (SheriffBot):
23058 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
23060         Teach webkitbot and WKR how to respond to yt?
23061         https://bugs.webkit.org/show_bug.cgi?id=116775
23063         Reviewed by Andreas Kling.
23065         * Scripts/webkitpy/tool/bot/irc_command.py:
23066         (Hi): Fixed the usage string.
23067         (Hi.execute): Made it more generic so that it works in WKR.
23068         (YouThere): Added.
23069         (YouThere.execute): Added.
23070         * Scripts/webkitpy/tool/commands/newcommitbot.py:
23072 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
23074         Try to fix the EFL build.
23075         
23076         * DumpRenderTree/efl/TestRunnerEfl.cpp:
23077         (TestRunner::setPageVisibility):
23079 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
23081         Unprefix Page Visibility API
23082         https://bugs.webkit.org/show_bug.cgi?id=102340
23084         Reviewed by Tim Horton.
23085         
23086         Rename "preview" state to "unloaded" state, and adjust the tests
23087         to test for it.
23089         * DumpRenderTree/mac/TestRunnerMac.mm:
23090         (TestRunner::setPageVisibility):
23091         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
23092         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
23093         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
23094         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
23095         (TestWebKitAPI::didRunStep4InStateUnloaded):
23096         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
23097         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
23098         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
23099         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
23100         (WTR::TestRunner::setPageVisibility):
23102 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
23104         Unreviewed build fix. Don't use new NRWT logic needed
23105         by Windows yet. Activate (and fix test) when we cut over.
23107         * Scripts/webkitpy/port/driver.py:
23108         (Driver._setup_environ_for_driver):
23109         (Driver._start):
23111 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
23113         [Windows] Expose database storage and cache locations via preferences.
23114         https://bugs.webkit.org/show_bug.cgi?id=116729
23116         Reviewed by Tim Horton.
23118         Update DumpRenderTree to use CFPreferences to control where WebKit
23119         stores its local databases, URL caches, etc.
23121         * DumpRenderTree/win/DumpRenderTree.cpp:
23122         (libraryPathForDumpRenderTree): Added.
23123         (dllLauncherEntryPoint): Set up DRT-specific cache locations.
23124         * Scripts/webkitpy/port/base.py:
23125         (Port._driver_tempdir): Added (to allow port-specific overload).
23126         (Port._driver_tempdir_for_environment): Ditto
23127         * Scripts/webkitpy/port/driver.py:
23128         (Driver._setup_environ_for_driver): Use new overload to set
23129         environment variable.
23130         (Driver._start): Use new overload for temp directory location.
23131         * Scripts/webkitpy/port/win.py:
23132         (WinPort._driver_tempdir_for_environment): New overload to supply
23133         Windows path to DumpRenderTree environment (while still using
23134         cygwin paths for internal operations.
23136 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
23138         Remove custom code for webkitAudioContext global constructor getter
23139         https://bugs.webkit.org/show_bug.cgi?id=116530
23141         Reviewed by Geoffrey Garen.
23143         Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
23144         WebAudio feature instead of public ewk_view API since that API was
23145         removed.
23147         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
23148         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
23149         * DumpRenderTree/efl/TestRunnerEfl.cpp:
23150         (TestRunner::overridePreference):
23152 2013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
23154         Make team.html have each contributor's area of expertise
23155         https://bugs.webkit.org/show_bug.cgi?id=116737
23157         Reviewed by Benjamin Poulain.
23159         * Scripts/webkitpy/common/config/contributors.json:
23160         Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
23161         
23162         Changed formatting of the file because the lines are getting way to
23163         long, and I generated this, so it's easier if the formatting of the
23164         file is regular.
23166 2013-05-24  Simon Pena  <simon.pena@samsung.com>
23168         Update WTF::Vector pretty printers
23169         https://bugs.webkit.org/show_bug.cgi?id=116719
23171         Reviewed by Anders Carlsson.
23173         After r148891, WTF::Vector pretty printers were left outdated, as
23174         the WTF::Vector was made to extend a VectorBuffer, instead of keeping
23175         one as a member. This patch updates the pretty printers so they work
23176         again. 
23178         * gdb/webkit.py:
23179         (WTFVectorPrinter.children):
23180         (WTFVectorPrinter.to_string):
23182 2013-05-24  Steve Falkenburg  <sfalken@apple.com>
23184         Update prepareConsistentTestingEnvironment to use a non-deprecated API.
23185         https://bugs.webkit.org/show_bug.cgi?id=116710
23187         Reviewed by Mark Rowe.
23189         * DumpRenderTree/mac/DumpRenderTree.mm:
23190         (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
23192 2013-05-23  Lauro Neto  <lauro.neto@openbossa.org>
23194         Add missing dependencies to deps script.
23196         [GTK] Missing packages in install-dependencies script.
23197         https://bugs.webkit.org/show_bug.cgi?id=116632
23199         Reviewed by Martin Robinson.
23201         * gtk/install-dependencies:
23203 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
23205         [Windows] Unreviewed change for NRWT support.
23207         * Scripts/webkitpy/port/win.py:
23208         (WinPort.default_child_processes): Added a default implementation
23209         that limits NRWT to a single instance.
23211 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
23213         Remove meaningless "test_uses_apache" from Python test cases.
23214         https://bugs.webkit.org/show_bug.cgi?id=38756
23216         Reviewed by Ryosuke Niwa.
23218         * Scripts/webkitpy/port/port_testcase.py:
23219         (PortTestCase.test_driver_cmd_line): Remove the meaningless
23220         "test_uses_apache" test case from the Python test infrastructure.
23221         It was hard-coded to true, even though not all ports use
23222         Apache.
23224 2013-05-23  Brent Fulgham  <bfulgham@webkit.org>
23226         [Windows] Update new-run-webkit-tests for Windows port.
23227         https://bugs.webkit.org/show_bug.cgi?id=38756
23229         Reviewed by Ryosuke Niwa.
23231         * Scripts/new-run-webkit-httpd:
23232         (run): Switch from 'chromium' to 'win'
23233         * Scripts/webkitpy/port/win.py:
23234         (WinPort): Add support methods for lighttpd server.
23235         (WinPort._uses_apache):
23236         (WinPort._path_to_lighttpd):
23237         (WinPort._path_to_lighttpd_modules):
23238         (WinPort._path_to_lighttpd_php):
23240 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
23242         Make default bug links in buildbot clickable
23243         https://bugs.webkit.org/show_bug.cgi?id=116673
23245         Reviewed by Ryosuke Niwa.
23247         Use changecommentlink of html.WebStatus to make the links clickable.
23249         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
23251 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
23253         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
23254         https://bugs.webkit.org/show_bug.cgi?id=116595
23256         Temporarily skip this test.
23258         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
23259         (TestWebKitAPI::TEST):
23261 2013-05-22  Alex Christensen  <achristensen@apple.com>
23263         Unreviewed.  Added myself to contributors.json.
23265         * Scripts/webkitpy/common/config/contributors.json:
23266         Added myself.
23268 2013-05-22  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
23270         [EFL][WK2] Add sub menus to MiniBrowser
23271         https://bugs.webkit.org/show_bug.cgi?id=114728
23273         Reviewed by Christophe Dumez.
23275         Elementary Ctxpopup widget API does not provide support for submenu item.
23276         To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
23277         Elementary Menu widget.
23279         * MiniBrowser/efl/main.c:
23280         (_Browser_Window):
23281         (on_window_resize):
23282         (window_free):
23283         (context_menu_item_selected_cb):
23284         (context_menu_populate):
23285         (on_context_menu_show):
23286         (on_context_menu_hide):
23287         (window_create):
23289 2013-05-22  Andrzej Badowski  <a.badowski@samsung.com>
23291         [EFL] Add command line option to MiniBrowser to set cookies policy.
23292         https://bugs.webkit.org/show_bug.cgi?id=115028
23294         Reviewed by Christophe Dumez.
23296         Add command line option to MiniBrowser EFL to set cookies policy:
23297         -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
23298         EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
23300         * MiniBrowser/efl/main.c:
23301         (elm_main):
23303 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
23305         REGRESSION(r150369): WebKit2WillLoadTest tests are failing
23306         https://bugs.webkit.org/show_bug.cgi?id=116585
23308         Reviewed by Alexey Proskuryakov.
23310         willLoadURLRequest and willLoadDataRequest require the API version 6.
23312         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
23314 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
23316         REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
23317         https://bugs.webkit.org/show_bug.cgi?id=116516
23319         Reviewed by Alexey Proskuryakov.
23321         Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
23323         * DumpRenderTree/mac/DumpRenderTree.mm:
23324         (createWebViewAndOffscreenWindow): Match the ordering.
23325         (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
23327 2013-05-21  Alexey Proskuryakov  <ap@apple.com>
23329         <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
23330         https://bugs.webkit.org/show_bug.cgi?id=116568
23332         Reviewed by Anders Carlsson.
23334         * WebKitTestRunner/WebNotificationProvider.cpp:
23335         (WTR::WebNotificationProvider::~WebNotificationProvider):
23336         * WebKitTestRunner/WebNotificationProvider.h:
23337         When the provider is destroyed, it should no longer be registered with the manager.
23339         * WebKitTestRunner/GeolocationProviderMock.cpp:
23340         (WTR::GeolocationProviderMock::~GeolocationProviderMock):
23341         * WebKitTestRunner/GeolocationProviderMock.h:
23342         I wasn't seeing a crash here, but this code has the same issue as notification
23343         provider, so applying the same fix.
23345         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
23346         Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
23347         destructor having fixed the above.
23349 2013-05-21  Commit Queue  <commit-queue@webkit.org>
23351         Unreviewed, rolling out r150386 and r150397.
23352         http://trac.webkit.org/changeset/150386
23353         http://trac.webkit.org/changeset/150397
23354         https://bugs.webkit.org/show_bug.cgi?id=116572
23356         Broke a test; Alex is going to try again later. (Requested by
23357         thorton on #webkit).
23359         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
23360         (WTR::pathSuitableForTestResult):
23361         (WTR::dumpRequestDescriptionSuitableForTestResult):
23362         (WTR::dumpResponseDescriptionSuitableForTestResult):
23363         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
23364         (WTR::InjectedBundlePage::didInitiateLoadForResource):
23365         (WTR::InjectedBundlePage::willSendRequestForFrame):
23366         (WTR::InjectedBundlePage::didReceiveResponseForResource):
23367         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
23368         (InjectedBundlePage):
23370 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
23372         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
23374         * Scripts/webkitpy/tool/commands/suggestnominations.py:
23375         (AbstractCommitLogCommand._recent_commit_messages):
23377 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
23379         [GTK] [CMake] Add support for building WebKit2
23380         https://bugs.webkit.org/show_bug.cgi?id=116372
23382         Reviewed by Gustavo Noronha Silva.
23384         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
23385         * MiniBrowser/gtk/CMakeLists.txt: Added.
23387 2013-05-21  Jessie Berlin  <jberlin@apple.com>
23389         Revert r149635, it was too optimistic.
23391         Rubber-stamped by Andreas Kling.
23393         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
23394         #ifdefs in WebCore code outside of WebCore/platform.
23396         * Scripts/webkitpy/style/checkers/cpp.py:
23397         (check_invalid_increment):
23398         (process_line):
23399         (CppChecker):
23400         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
23401         (CppStyleTest.test_plain_integral_bitfields):
23403 2013-05-21  Jer Noble  <jer.noble@apple.com>
23405         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
23407         * lldb/lldb_webkit.py:
23408         (WTFVectorProvider.num_children):
23409         (WTFVectorProvider.get_child_index):
23410         (WTFVectorProvider.get_child_at_index):
23411         (WTFVectorProvider.update):
23413 2013-05-21  Jessie Berlin  <jberlin@apple.com>
23415         Expose a way to know when forms are added to a page or when form controls are added to a form
23416         in the injected bundle
23417         https://bugs.webkit.org/show_bug.cgi?id=116334
23419         Reviewed by Alexey Proskuryakov.
23421         Add tests for the new callbacks.
23423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23424         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
23426         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
23427         (TestWebKitAPI::nullJavaScriptCallback):
23428         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
23429         being passed in for the callback.
23430         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
23431         After receiving the message that didAssociateFormControls callback was invoked from adding
23432         the form in the onload handler, tell the page to add a password field to the form, which
23433         should also invoke didAssociateFormControls callback.
23434         (TestWebKitAPI::setInjectedBundleClient):
23435         Register to receive messages.
23436         (TestWebKitAPI::TEST):
23437         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
23438         been invoked for both adding the form and for adding a password field to the form.
23440         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
23441         (TestWebKitAPI::shouldNotifyOnFormChanges):
23442         Return true so the didAssociateFormControls callback is invoked.
23443         (TestWebKitAPI::didAssociateFormControls):
23444         Tell the UI process.
23445         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
23446         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
23447         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
23449         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
23450         Add a form in response to the onload event. Add a button that will add the password field
23451         for manual testing.
23453 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
23455         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
23456         https://bugs.webkit.org/show_bug.cgi?id=106341
23458         Reviewed by Martin Robinson.
23460         Adds support for retrieving accessibility element at exact point.
23462         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
23463         (WTR::AccessibilityUIElement::elementAtPoint):
23465 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
23467         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
23468         https://bugs.webkit.org/show_bug.cgi?id=112913
23470         Reviewed by Martin Robinson.
23472         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
23473         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
23474         so the leak appears.
23476         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
23477         (WTR):
23478         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
23479         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
23480         (WTR::AccessibilityController::rootElement):
23481         (WTR):
23482         (WTR::AccessibilityController::focusedElement):
23483         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
23484         (WTR::checkElementState):
23485         (WTR::indexRangeInTable):
23486         (WTR::alterCurrentValue):
23487         (WTR::AccessibilityUIElement::getChildren):
23488         (WTR::AccessibilityUIElement::getChildrenWithRange):
23489         (WTR::AccessibilityUIElement::childrenCount):
23490         (WTR::AccessibilityUIElement::indexOfChild):
23491         (WTR::AccessibilityUIElement::titleUIElement):
23492         (WTR::AccessibilityUIElement::parentElement):
23493         (WTR::AccessibilityUIElement::allAttributes):
23494         (WTR::AccessibilityUIElement::role):
23495         (WTR::AccessibilityUIElement::title):
23496         (WTR::AccessibilityUIElement::description):
23497         (WTR::AccessibilityUIElement::orientation):
23498         (WTR::AccessibilityUIElement::stringValue):
23499         (WTR::AccessibilityUIElement::language):
23500         (WTR::AccessibilityUIElement::x):
23501         (WTR::AccessibilityUIElement::y):
23502         (WTR::AccessibilityUIElement::width):
23503         (WTR::AccessibilityUIElement::height):
23504         (WTR::AccessibilityUIElement::intValue):
23505         (WTR::AccessibilityUIElement::minValue):
23506         (WTR::AccessibilityUIElement::maxValue):
23507         (WTR::AccessibilityUIElement::isEnabled):
23508         (WTR::AccessibilityUIElement::isFocused):
23509         (WTR::AccessibilityUIElement::isSelected):
23510         (WTR::AccessibilityUIElement::isExpanded):
23511         (WTR::AccessibilityUIElement::isChecked):
23512         (WTR::AccessibilityUIElement::rowCount):
23513         (WTR::AccessibilityUIElement::columnCount):
23514         (WTR::AccessibilityUIElement::rowIndexRange):
23515         (WTR::AccessibilityUIElement::columnIndexRange):
23516         (WTR::AccessibilityUIElement::cellForColumnAndRow):
23517         (WTR::AccessibilityUIElement::increment):
23518         (WTR::AccessibilityUIElement::decrement):
23519         (WTR::AccessibilityUIElement::press):
23520         (WTR::AccessibilityUIElement::documentEncoding):
23521         (WTR::AccessibilityUIElement::documentURI):
23522         (WTR::AccessibilityUIElement::isFocusable):
23523         (WTR::AccessibilityUIElement::isSelectable):
23524         (WTR::AccessibilityUIElement::isMultiSelectable):
23525         (WTR::AccessibilityUIElement::isVisible):
23527 2013-05-20  Lucas Forschler  <lforschler@apple.com>
23529     Rollout 150398.
23530     
23531 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
23533         [GTK] Fix concatenations of string literals that are not C++11-compliant
23534         https://bugs.webkit.org/show_bug.cgi?id=116449
23536         Reviewed by Martin Robinson.
23538         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
23539         is simply a matter of separating the string and the string literal that are being concatenated with a space.
23541         * ImageDiff/gtk/ImageDiff.cpp:
23542         (printImage):
23544 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
23546         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
23547         https://bugs.webkit.org/show_bug.cgi?id=116450
23549         Reviewed by Martin Robinson.
23551         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
23552         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
23553         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
23554         TestWebKitAPI programs when compiling them.
23556         * TestWebKitAPI/GNUmakefile.am:
23558 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
23560         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
23561         https://bugs.webkit.org/show_bug.cgi?id=116492
23563         Reviewed by Dirk Pranke.
23565         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
23567         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
23568         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
23569         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
23570         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
23571         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
23572         to memory pressure on the machine.
23574         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
23575         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
23576         for a subsequent patch just to make things easier to follow.
23578         * Scripts/webkitpy/port/driver.py:
23579         (DriverProxy.__init__):
23580         (DriverProxy.run_test):
23581         (DriverProxy.has_crashed):
23582         (DriverProxy.stop):
23584 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
23586         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
23587         https://bugs.webkit.org/show_bug.cgi?id=116423
23589         Reviewed by Ryosuke Niwa.
23591         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
23593         * BuildSlaveSupport/build.webkit.org-config/config.json:
23595 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
23597         Remove remaining link-prerender code
23598         https://bugs.webkit.org/show_bug.cgi?id=116429
23600         Reviewed by Darin Adler.
23602         Link prerendering code was removed in r150356.
23604         * Scripts/webkitperl/FeatureList.pm:
23605         * qmake/mkspecs/features/features.pri:
23607 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
23609         commit-queue should check for oops in changelog entries
23610         https://bugs.webkit.org/show_bug.cgi?id=116395
23612         Reviewed by Martin Robinson.
23614         Make changelog validation fail when it contains oops!.
23616         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
23617         (CommitQueueTask._validate_changelog):
23618         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
23619         (CommitQueueTaskTest._run_through_task):
23620         * Scripts/webkitpy/tool/commands/queues_unittest.py:
23621         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
23622         (ValidateChangeLogs.options):
23623         (ValidateChangeLogs._check_changelog_diff):
23624         (ValidateChangeLogs._changelog_contains_oops):
23625         (ValidateChangeLogs.run):
23626         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
23627         (ValidateChangeLogsTest._assert_start_line_produces_output):
23628         (ValidateChangeLogsTest.test_check_changelog_diff):
23629         (ValidateChangeLogsTest):
23630         (ValidateChangeLogsTest.test_changelog_contains_oops):
23632 2013-05-20  Jessie Berlin  <jberlin@apple.com>
23634         Expose a way to know when forms are added to a page or when form controls are added to a form
23635         in the injected bundle
23636         https://bugs.webkit.org/show_bug.cgi?id=116334
23638         Reviewed by Alexey Proskuryakov.
23640         Add tests for the new callbacks.
23642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23643         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
23645         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
23646         (TestWebKitAPI::nullJavaScriptCallback):
23647         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
23648         being passed in for the callback.
23649         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
23650         After receiving the message that didAssociateFormControls callback was invoked from adding
23651         the form in the onload handler, tell the page to add a password field to the form, which
23652         should also invoke didAssociateFormControls callback.
23653         (TestWebKitAPI::setInjectedBundleClient):
23654         Register to receive messages.
23655         (TestWebKitAPI::TEST):
23656         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
23657         been invoked for both adding the form and for adding a password field to the form.
23659         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
23660         (TestWebKitAPI::shouldNotifyOnFormChanges):
23661         Return true so the didAssociateFormControls callback is invoked.
23662         (TestWebKitAPI::didAssociateFormControls):
23663         Tell the UI process.
23664         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
23665         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
23666         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
23668         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
23669         Add a form in response to the onload event. Add a button that will add the password field
23670         for manual testing.
23672 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
23674         [EFL][JHBUILD] Make sure eet is built before evas
23675         https://bugs.webkit.org/show_bug.cgi?id=116440
23677         Reviewed by Gyuyoung Kim.
23679         Mark eet as a dependency of evas since evas requires eet to enable some of its
23680         functionality.
23682         * efl/jhbuild.modules:
23684 2013-05-20  Alex Christensen  <achristensen@apple.com>
23686         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
23687         https://bugs.webkit.org/show_bug.cgi?id=116125
23689         Reviewed by Tim Horton.
23691         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
23692         (WTR::pathSuitableForTestResult):
23693         Changed string operations to match _drt_descriptionSuitableForTestResult.
23694         (WTR::dumpRequestDescriptionSuitableForTestResult):
23695         (WTR::dumpResponseDescriptionSuitableForTestResult):
23696         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
23697         (WTR::InjectedBundlePage::didInitiateLoadForResource):
23698         (WTR::InjectedBundlePage::willSendRequestForFrame):
23699         (WTR::InjectedBundlePage::didReceiveResponseForResource):
23700         Pass the main frame's URL to pathSuitableForTestResult.
23701         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
23702         Added WKBundlePageRef to willPerformClientRedirectForFrame.
23704 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
23706         fix w3c test importer unit tests after r150324
23707         https://bugs.webkit.org/show_bug.cgi?id=116459
23709         Reviewed by Ryosuke Niwa.
23711         This patch fixes the unit tests to not actually call out to
23712         'hg' (by using a mock executive) and also changes the real
23713         directory we crawl from Source/WebCore/css to
23714         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
23715         still change this to a mock filesystem, but that's a separate change.
23717         * Scripts/webkitpy/w3c/test_importer.py:
23718         (main):
23719         (TestImporter.__init__):
23720         (TestImporter.load_changeset):
23721         * Scripts/webkitpy/w3c/test_importer_unittest.py:
23722         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
23723         (TestImporterTest.test_import_dir_with_no_tests):
23725 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
23727         Unreviewed EFL build fix.
23729         Fix linking errors due to undefined symbols on Ubuntu 13.04.
23731         * DumpRenderTree/efl/CMakeLists.txt:
23732         * EWebLauncher/CMakeLists.txt:
23733         * MiniBrowser/efl/CMakeLists.txt:
23735 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
23737         [EFL] Reenabled INDEXED_DATABASE after r150344
23738         https://bugs.webkit.org/show_bug.cgi?id=116430
23740         Reviewed by Gyuyoung Kim.
23742         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
23743         build was fixed in r150344.
23745         * Scripts/webkitperl/FeatureList.pm:
23747 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
23749         [EFL] init/shutdown should be paired in EWebLauncher
23750         https://bugs.webkit.org/show_bug.cgi?id=116427
23752         Reviewed by Christophe Dumez.
23754         Added ecore_file_shutdown() for cleanup of ecore_file.
23755         Removed edje_init and ecore_evas_init because it was in ewk_init().
23757         * EWebLauncher/main.c:
23758         (main):
23760 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
23762         [EFL] Add command line option to MiniBrowser to set user agent
23763         https://bugs.webkit.org/show_bug.cgi?id=116387
23765         Reviewed by Christophe Dumez.
23767         We need this option to compare the rendering differences according to different user agents.
23769         * MiniBrowser/efl/main.c:
23770         (window_create):
23771         (elm_main):
23773 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
23775         Unreviewed, addressing test-webkitpy failures after r150317.
23777         * Scripts/webkitpy/w3c/test_converter.py:
23778         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
23780 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
23782         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
23783         https://bugs.webkit.org/show_bug.cgi?id=114554
23785         Reviewed by Gyuyoung Kim.
23787         Using variables as target names is very uncommon in CMake.
23788         The usual way to specify the name of the resulting binary
23789         is to set the OUTPUT_NAME target property.
23791         * DumpRenderTree/efl/CMakeLists.txt:
23792         * EWebLauncher/CMakeLists.txt:
23793         * ImageDiff/CMakeLists.txt:
23794         * MiniBrowser/efl/CMakeLists.txt:
23795         * TestWebKitAPI/CMakeLists.txt:
23796         * WebKitTestRunner/CMakeLists.txt:
23797         * WebKitTestRunner/PlatformEfl.cmake:
23798         * WinCELauncher/CMakeLists.txt:
23800 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
23802         Unreviewed EFL build fix.
23804         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
23805         WK2 build after r150305.
23807         * Scripts/webkitperl/FeatureList.pm:
23809 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
23811         [GTK] Parallel build fails if gtk-doc is enabled
23812         https://bugs.webkit.org/show_bug.cgi?id=116227
23814         Reviewed by Martin Robinson.
23816         * GNUmakefile.am:
23817         Don't use the 'all' target to generate the documentation.
23818         The prerequisites of this target must be files that need to be
23819         built _before_ the actual compilation of WebKit starts. Since the
23820         documentation depends on WebKit being built first, this means in
23821         practice that the code will be built in parallel with the
23822         generation of its dependencies, potentially making the build fail.
23824 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
23826         Don't run hg.
23828         * Scripts/webkitpy/w3c/test_importer_unittest.py:
23829         (TestImporterTest):
23831 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
23833         Create a script to import W3C tests
23834         https://bugs.webkit.org/show_bug.cgi?id=111513
23836         Reviewed by Ryosuke Niwa.
23838         This patch attempts to re-land the 'import-w3c-tests'
23839         script and accompanying modules.  The tests and code have
23840         been cleaned up so that we do not log anything to stdout/stderr
23841         while running the tests (thanks to outputcapture) and do not
23842         write into the source tree while running the tests, and much
23843         but not all of the code has been converted over to using the webkitpy
23845         * Scripts/import-w3c-tests: Added.
23846         * Scripts/webkitpy/w3c/__init__.py: Added.
23847         * Scripts/webkitpy/w3c/test_converter.py: Added.
23848         (W3CTestConverter):
23849         (W3CTestConverter.__init__):
23850         (W3CTestConverter.path_from_webkit_root):
23851         (W3CTestConverter.read_webkit_prefixed_css_property_list):
23852         (W3CTestConverter.convert_for_webkit):
23853         (W3CTestConverter.convert_css):
23854         (W3CTestConverter.convert_html):
23855         (W3CTestConverter.convert_testharness_paths):
23856         (W3CTestConverter.convert_prefixed_properties):
23857         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
23858         (W3CTestConverter.replace_tag):
23859         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
23860         (W3CTestConverterTest):
23861         (W3CTestConverterTest.fake_dir_path):
23862         (W3CTestConverterTest.test_read_prefixed_property_list):
23863         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
23864         (test_convert_for_webkit_harness_only):
23865         (test_convert_for_webkit_properties_only):
23866         (test_convert_for_webkit_harness_and_properties):
23867         (test_convert_test_harness_paths):
23868         (test_convert_prefixed_properties):
23869         (verify_conversion_happened):
23870         (verify_no_conversion_happened):
23871         (verify_test_harness_paths):
23872         (verify_prefixed_properties):
23873         (generate_test_content):
23874         * Scripts/webkitpy/w3c/test_importer.py: Added.
23875         (main):
23876         (parse_args):
23877         (validate_import_directory):
23878         (TestImporter):
23879         (TestImporter.__init__):
23880         (TestImporter.path_from_webkit_root):
23881         (TestImporter.do_import):
23882         (TestImporter.load_changeset):
23883         (TestImporter.find_importable_tests):
23884         (TestImporter.import_tests):
23885         (TestImporter.setup_destination_directory):
23886         (TestImporter.update_test_status):
23887         (TestImporter.remove_deleted_files):
23888         (TestImporter.write_import_log):
23889         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
23890         (TestImporterTest):
23891         (TestImporterTest.test_import_dir_with_no_tests):
23892         * Scripts/webkitpy/w3c/test_parser.py: Added.
23893         (TestParser):
23894         (TestParser.__init__):
23895         (TestParser.load_file):
23896         (TestParser.analyze_test):
23897         (TestParser.reference_links_of_type):
23898         (TestParser.is_jstest):
23899         (TestParser.support_files):
23900         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
23901         (TestParserTest):
23902         (TestParserTest.test_analyze_test_reftest_one_match):
23903         (test_analyze_test_reftest_multiple_matches):
23904         (test_analyze_test_reftest_match_and_mismatch):
23905         (test_analyze_test_reftest_with_ref_support_Files):
23906         (test_analyze_jstest):
23907         (test_analyze_pixel_test_all_true):
23908         (test_analyze_pixel_test_all_false):
23909         (test_analyze_non_html_file):
23911 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
23913         Leaks builders exit early frequently
23914         https://bugs.webkit.org/show_bug.cgi?id=116355
23916         Reviewed by Stephanie Lewis.
23918         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
23919         we tolerate from 20 to 50.
23921         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
23922         (RunWebKitTests.start):
23923         * Scripts/webkitpy/port/mac.py:
23924         (MacPort.default_child_processes):
23926 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
23928         Remove chrome-channels command from the webkit-patch
23929         https://bugs.webkit.org/show_bug.cgi?id=116303
23931         Reviewed by Ryosuke Niwa.
23933         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
23934         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
23935         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
23936         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
23937         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
23938         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
23940 2013-05-17  David Kilzer  <ddkilzer@apple.com>
23942         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
23943         Part 3 of 3: <http://webkit.org/b/116247>
23945         Reviewed by Benjamin Poulain.
23947         * Scripts/filter-build-webkit: Change while() loop to for() loop
23948         to track $previousLine, then pass $previousLine into
23949         shouldIgnoreLine().
23950         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
23951         line that begins with four spaces if the previous line is a
23952         linker error message.
23953         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
23954         - Add "Ignored: " to test descriptions to document expected
23955           behavior.
23956         - Add comment blocks for various groups of tests.
23957         - Expand "Build settings" tests since we're changing the code in
23958           shouldIgnoreLine() that ignores those lines.
23959         - Add tests for undefined symbols error message.
23960         (description): Add.  Extract from global code.
23962 2013-05-17  David Kilzer  <ddkilzer@apple.com>
23964         Add tests for shouldIgnoreLine() in filter-build-webkit
23965         Part 2 of 3: <http://webkit.org/b/116247>
23967         Reviewed by Benjamin Poulain.
23969         * Scripts/filter-build-webkit:
23970         (shouldIgnoreLine): Add.  Extract code from global scope into
23971         subroutine to make it testable.
23972         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
23973         Tests shouldIgnoreLine() using output from a real build
23974         transcript.
23976 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
23978         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
23979         https://bugs.webkit.org/show_bug.cgi?id=116341
23981         Reviewed by Brady Eidson.
23983         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
23985 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
23987         [Windows] Don't use pdevenv when building with VS2010.
23988         https://bugs.webkit.org/show_bug.cgi?id=116338.
23990         Reviewed by Adam Roben.
23992         * Scripts/webkitdirs.pm:
23993         (setupCygwinEnv): Check if we are using VS2005, and only use
23994         the 'pdevenv' hack if we are. Otherwise, just build with
23995         our standard project since it uses VS2010+'s native
23996         parallel building features.
23998 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
24000         Unreviewed. Disable accelerated compositing until we figure out why it does not work
24001         properly in the 64 bits release bot.
24003         * DumpRenderTree/gtk/DumpRenderTree.cpp:
24004         (resetDefaultsToConsistentValues):
24006 2013-05-17  David Kilzer  <ddkilzer@apple.com>
24008         Make filter-build-webkit testable using LoadAsModule
24009         Part 1 of 3: <http://webkit.org/b/116247>
24011         Reviewed by Benjamin Poulain.
24013         * Scripts/filter-build-webkit: Change global variables that are
24014         used in subroutines from 'my' to 'our' to make it possible to
24015         evaluate the script in a package context in LoadAsModule.pm.
24017 2013-05-14  Sam Weinig  <sam@webkit.org>
24019         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
24020         https://bugs.webkit.org/show_bug.cgi?id=116132
24022         Reviewed by Anders Carlsson.
24024         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
24025         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
24027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24028         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
24029         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
24030         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
24032 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
24034         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
24035         https://bugs.webkit.org/show_bug.cgi?id=114781
24037         Reviewed by Christophe Dumez.
24039         Add run_before_unload_confirm and
24040         Print the log message with "CONFIRM NAVIGATION: " in console.
24042         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
24043         (onBeforeUnloadConfirm):
24044         (drtViewAdd):
24046 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
24048         Fix Analyze ChangeLog's entry processing
24049         https://bugs.webkit.org/show_bug.cgi?id=116219
24051         Reviewed by Ryosuke Niwa.
24053         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
24054         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
24056 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
24058         [Qt] UrlLoader::loadNext is broken in MiniBrowser
24059         https://bugs.webkit.org/show_bug.cgi?id=116099
24061         Reviewed by Jocelyn Turcotte.
24063         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
24064         are not available any more. So, UrlLoader::loadNext was broken
24065         because it failed to connect to those signals.
24067         * MiniBrowser/qt/UrlLoader.cpp:
24068         (UrlLoader::UrlLoader):
24069         (UrlLoader::loadingChanged):
24070         * MiniBrowser/qt/UrlLoader.h:
24071         (UrlLoader):
24073 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
24075         [WebSocket] Update pywebsocket to r760
24076         https://bugs.webkit.org/show_bug.cgi?id=115863
24078         Reviewed by Alexey Proskuryakov.
24080         Version r760 supports a newer draft of message compression.
24081         We need this update to finish the permessage compression patch in
24082         bug 98840. This patch also fixes failing unit tests after the update.
24084         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
24085         (StreamBase._read):
24086         (StreamBase._read.of):
24087         (StreamBase._write):
24088         (StreamBase.receive_bytes):
24089         (StreamBase._read_until):
24090         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
24091         (parse_frame):
24092         (StreamOptions.__init__):
24093         (Stream.__init__):
24094         (Stream._receive_frame_as_frame_object):
24095         (Stream._get_message_from_frame):
24096         (Stream._process_close_message):
24097         (Stream.close_connection):
24098         (Stream.get_last_received_opcode):
24099         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
24100         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
24101         (Dispatcher.do_extra_handshake):
24102         (Dispatcher.transfer_data):
24103         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
24104         (ExtensionProcessorInterface.__init__):
24105         (ExtensionProcessorInterface.request):
24106         (ExtensionProcessorInterface):
24107         (ExtensionProcessorInterface.name):
24108         (ExtensionProcessorInterface.check_consistency_with_other_processors):
24109         (ExtensionProcessorInterface.set_active):
24110         (ExtensionProcessorInterface.is_active):
24111         (ExtensionProcessorInterface._get_extension_response_internal):
24112         (ExtensionProcessorInterface.get_extension_response):
24113         (ExtensionProcessorInterface._setup_stream_options_internal):
24114         (ExtensionProcessorInterface.setup_stream_options):
24115         (_log_outgoing_compression_ratio):
24116         (_log_incoming_compression_ratio):
24117         (_parse_window_bits):
24118         (_AverageRatioCalculator):
24119         (_AverageRatioCalculator.__init__):
24120         (_AverageRatioCalculator.add_original_bytes):
24121         (_AverageRatioCalculator.add_result_bytes):
24122         (_AverageRatioCalculator.get_average_ratio):
24123         (DeflateFrameExtensionProcessor):
24124         (DeflateFrameExtensionProcessor.__init__):
24125         (DeflateFrameExtensionProcessor._get_extension_response_internal):
24126         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
24127         (DeflateFrameExtensionProcessor._outgoing_filter):
24128         (DeflateFrameExtensionProcessor._incoming_filter):
24129         (CompressionExtensionProcessorBase.for):
24130         (CompressionExtensionProcessorBase.__init__):
24131         (CompressionExtensionProcessorBase._get_extension_response_internal):
24132         (CompressionExtensionProcessorBase._setup_stream_options_internal):
24133         (PerFrameCompressExtensionProcessor):
24134         (PerMessageDeflateExtensionProcessor):
24135         (PerMessageDeflateExtensionProcessor.__init__):
24136         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
24137         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
24138         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
24139         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
24140         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
24141         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
24142         (PerMessageDeflateExtensionProcessor.set_bfinal):
24143         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
24144         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
24145         (_PerMessageDeflateFramer):
24146         (_PerMessageDeflateFramer.__init__):
24147         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
24148         (_PerMessageDeflateFramer._process_incoming_message):
24149         (_PerMessageDeflateFramer._process_outgoing_message):
24150         (_PerMessageDeflateFramer.setup_stream_options):
24151         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
24152         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
24153         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
24154         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
24155         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
24156         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
24157         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
24158         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
24159         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
24160         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
24161         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
24162         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
24163         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
24164         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
24165         (PerMessageCompressExtensionProcessor):
24166         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
24167         (MuxExtensionProcessor.__init__):
24168         (MuxExtensionProcessor.check_consistency_with_other_processors):
24169         (MuxExtensionProcessor):
24170         (MuxExtensionProcessor._get_extension_response_internal):
24171         (MuxExtensionProcessor._setup_stream_options_internal):
24172         (MuxExtensionProcessor.set_quota):
24173         (MuxExtensionProcessor.quota):
24174         (MuxExtensionProcessor.set_extensions):
24175         (MuxExtensionProcessor.extensions):
24176         (is_compression_extension):
24177         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
24178         (validate_subprotocol):
24179         (parse_host_header):
24180         (format_header):
24181         (check_request_line):
24182         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
24183         (Handshaker.do_handshake):
24184         (Handshaker._create_handshake_response):
24185         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
24186         (_validate_subprotocol):
24187         (_check_header_lines):
24188         (_build_location):
24189         (Handshaker.do_handshake):
24190         (Handshaker._set_subprotocol):
24191         (Handshaker._set_location):
24192         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
24193         (_create_dispatcher):
24194         (headerparserhandler):
24195         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
24196         (_create_add_channel_response):
24197         (_create_drop_channel):
24198         (_create_flow_control):
24199         (_create_new_channel_slot):
24200         (_create_fallback_new_channel_slot):
24201         (_MuxFramePayloadParser._read_number):
24202         (_MuxFramePayloadParser._read_size_and_contents):
24203         (_MuxFramePayloadParser._read_flow_control):
24204         (_MuxFramePayloadParser._read_new_channel_slot):
24205         (_LogicalConnection.__init__):
24206         (_LogicalConnection.write):
24207         (_LogicalConnection.on_write_data_done):
24208         (_LogicalConnection):
24209         (_LogicalConnection.on_writer_done):
24210         (_InnerMessage):
24211         (_InnerMessage.__init__):
24212         (_InnerMessageBuilder):
24213         (_InnerMessageBuilder.that):
24214         (_InnerMessageBuilder.__init__):
24215         (_InnerMessageBuilder._handle_first):
24216         (_InnerMessageBuilder._process_first_fragmented_control):
24217         (_InnerMessageBuilder._process_first_fragmented_message):
24218         (_InnerMessageBuilder._handle_fragmented_control):
24219         (_InnerMessageBuilder._reassemble_fragmented_control):
24220         (_InnerMessageBuilder._handle_fragmented_message):
24221         (_InnerMessageBuilder._reassemble_fragmented_message):
24222         (_InnerMessageBuilder.build):
24223         (_LogicalStream.__init__):
24224         (_LogicalStream._create_inner_frame):
24225         (_LogicalStream._write_inner_frame):
24226         (_LogicalStream.replenish_send_quota):
24227         (_LogicalStream.send_message):
24228         (_LogicalStream._receive_frame):
24229         (_LogicalStream._get_message_from_frame):
24230         (_LogicalStream.stop_sending):
24231         (_PhysicalConnectionWriter.__init__):
24232         (_PhysicalConnectionWriter._write_data):
24233         (_PhysicalConnectionWriter.run):
24234         (_PhysicalConnectionWriter.stop):
24235         (_Worker.run):
24236         (_MuxHandshaker.__init__):
24237         (_MuxHandshaker._create_stream):
24238         (_MuxHandshaker._create_handshake_response):
24239         (_HandshakeDeltaBase.create_headers):
24240         (_MuxHandler.start):
24241         (_MuxHandler.wait_until_done):
24242         (_MuxHandler.notify_write_data_done):
24243         (_MuxHandler._process_drop_channel):
24244         (_MuxHandler._process_logical_frame):
24245         (_MuxHandler.notify_reader_done):
24246         (_MuxHandler):
24247         (_MuxHandler.notify_writer_done):
24248         (_MuxHandler.fail_physical_connection):
24249         (_MuxHandler.fail_logical_channel):
24250         (use_mux):
24251         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
24252         (_StandaloneRequest.get_uri):
24253         (_StandaloneRequest.get_unparsed_uri):
24254         (_StandaloneRequest):
24255         (_StandaloneRequest.is_https):
24256         (_import_ssl):
24257         (_import_pyopenssl):
24258         (_StandaloneSSLConnection.for):
24259         (_StandaloneSSLConnection):
24260         (_StandaloneSSLConnection.__getattribute__):
24261         (_StandaloneSSLConnection.__setattr__):
24262         (_StandaloneSSLConnection.makefile):
24263         (_StandaloneSSLConnection.shutdown):
24264         (_StandaloneSSLConnection.recv):
24265         (WebSocketServer.__init__):
24266         (WebSocketServer._create_sockets):
24267         (WebSocketServer.handle_error):
24268         (WebSocketServer.get_request):
24269         (WebSocketServer.get_request.default_callback):
24270         (WebSocketRequestHandler.parse_request):
24271         (_build_option_parser):
24272         (_main):
24273         (_main.if):
24274         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
24275         (RepeatedXorMasker.__init__):
24276         (RepeatedXorMasker._mask_using_swig):
24277         (RepeatedXorMasker):
24278         (RepeatedXorMasker._mask_using_array):
24279         (_Deflater.compress_and_finish):
24280         (_RFC1979Deflater.filter):
24281         (DeflateSocket.send):
24283 2013-05-16  Jonathan Liu  <net147@gmail.com>
24285         Fix testing if program exists in PATH
24286         https://bugs.webkit.org/show_bug.cgi?id=116216
24288         Reviewed by Jocelyn Turcotte.
24290         functions.prf incorrectly uses win_cmd_shell to test whether to
24291         add .exe to the executable name when checking if it exists in
24292         the PATH environment variable. This works correctly when
24293         building using Windows Command Prompt but not under MSYS shell.
24295         To resolve this, check the win32 platform scope instead of
24296         win_cmd_shell so that it correctly adds .exe to the executable
24297         name on Windows regardless of the shell used when testing if
24298         it exists in PATH.
24300         * qmake/mkspecs/features/functions.prf:
24302 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
24304         Fix the hard-coded names of EWS bots that run tests.
24306         * Scripts/webkitpy/tool/commands/queues.py:
24307         (CommitQueue.did_pass_testing_ews):
24309 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
24311         [GTK] Build Xvfb with jhbuild
24312         https://bugs.webkit.org/show_bug.cgi?id=115907
24314         Reviewed by Martin Robinson.
24316         Build our own Xvfb so that we can avoid problems with the system Xvfb
24317         relying on symbols not present in our jhbuilt libraries such as pixman,
24318         and also to ensure we have the fix for a GLX module crasher.
24320         * DumpRenderTree/gtk/DumpRenderTree.cpp:
24321         (resetDefaultsToConsistentValues): enable accelerated compositing.
24322         * gtk/install-dependencies: list packages required for building Xvfb.
24323         * gtk/jhbuild.modules: add xserver as a jhbuild module.
24324         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
24325         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
24326         initializing the GLX module for Xvfb.
24328 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
24330         [jhbuild] Should remove the sources directory as well when cleaning
24331         https://bugs.webkit.org/show_bug.cgi?id=116229
24333         Reviewed by Martin Robinson.
24335         * Scripts/update-webkit-libs-jhbuild:
24336         (cleanJhbuild): remove the Source directory as well when cleaning.
24338 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
24340         [EFL] Remove Intel Wk2 Buildbots from Master
24341         https://bugs.webkit.org/show_bug.cgi?id=116149
24343         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
24344         since Gyuyoung Kim from Samsung plans to take over and maintain it.
24346         Reviewed by Benjamin Poulain.
24348         * BuildSlaveSupport/build.webkit.org-config/config.json:
24350 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
24352         [Windows] Update various build tools to understand VS2010 environment.
24353         https://bugs.webkit.org/show_bug.cgi?id=116169.
24355         Reviewed by Anders Carlsson.
24357         * Scripts/build-api-tests: Identify VS2010 environment.
24358         * Scripts/build-dumprendertree: Ditto.
24359         * Scripts/build-webkit: Ditto.
24360         * Scripts/webkitdirs.pm:
24361         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
24362         range of acceptable SDK's.
24364 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
24366         Allow http tests on Arch Linux
24367         https://bugs.webkit.org/show_bug.cgi?id=116155
24369         Reviewed by Ryosuke Niwa.
24371         * Scripts/webkitpy/port/base.py:
24372         (Port._is_arch_based): Added check for /etc/arch-release file.
24373         (Port._apache_config_file_name_for_platform): Call the check.
24374         * Scripts/webkitpy/port/port_testcase.py:
24375         (test_linux_distro_detection): Testcase added.
24377 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
24379         Remove a leftover v8 file from the watchlist
24380         https://bugs.webkit.org/show_bug.cgi?id=116158
24382         Reviewed by Csaba Osztrogonác.
24384         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
24386 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
24388         [GTK] Fails to build while generating gtkdoc
24389         https://bugs.webkit.org/show_bug.cgi?id=115612
24391         Reviewed by Philippe Normand.
24393         Fix typo in the prerequisites of docs-build.stamp.
24395         * GNUmakefile.am:
24397 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
24399         Unreviewed, fixing the current test-webkitpy failure.
24401         * Scripts/webkitpy/port/mac_unittest.py:
24402         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
24403         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
24405 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
24407         Fix build after r150090.
24408         https://bugs.webkit.org/show_bug.cgi?id=116129
24410         Unreviewed build fix after r150090.
24412         * WebKitTestRunner/TestInvocation.cpp:
24413         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
24415 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
24417         [Windows, others] Unreviewed build fix after r150090.
24419         * DumpRenderTree/TestRunner.cpp:
24420         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
24421         doesn't exist on other platforms.
24423 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
24425         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
24426         https://bugs.webkit.org/show_bug.cgi?id=115889
24428         Reviewed by Benjamin Poulain.
24430         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
24431         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
24433 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
24435         [Windows] Identify proper run environment for scripts.
24436         https://bugs.webkit.org/show_bug.cgi?id=116114
24438         Reviewed by David Kilzer.
24440         Determine (based on Visual Studio version) which path to use for
24441         executables (bin versus bin32).
24443         * Scripts/webkitdirs.pm:
24444         (determineVisualStudioInstallDir): Added.
24445         (determineVisualStudioVersion): Added.
24446         (determineConfigurationProductDir): Modified to choose proper bin
24447         or bin32 directory.
24448         (visualStudioVersion): Added
24449         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
24451 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
24453         [Mac] Add tests for secure event input
24454         https://bugs.webkit.org/show_bug.cgi?id=116121
24456         Reviewed by Mark Rowe.
24458         * DumpRenderTree/TestRunner.cpp:
24459         (getSecureEventInputIsEnabledCallback):
24460         (TestRunner::staticValues):
24461         Expose an accessor for current secure event input state.
24463         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
24464         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
24465         (WTR::TestRunner::secureEventInputIsEnabled):
24466         * WebKitTestRunner/InjectedBundle/TestRunner.h:
24467         * WebKitTestRunner/TestInvocation.cpp:
24468         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
24469         Expose an accessor for current secure event input state. This has to be done in
24470         UI process, as this is where it's changed by WebKit.
24472 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
24474         [Mac] Add a testing shim for secure event input functions
24475         https://bugs.webkit.org/show_bug.cgi?id=116122
24477         Reviewed by Mark Rowe.
24479         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
24480         Inject WebCore testing shim library to override system framework functions.
24482 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
24484         [Windows] Switch to embedded manifest commands for launcher executables.
24485         https://bugs.webkit.org/show_bug.cgi?id=116109
24487         Reviewed by Darin Adler.
24489         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
24490         now-unused WinLauncher.exe.manifest file.
24491         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
24492         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
24493         when building with VS2010 or newer.
24495 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
24497         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
24498         https://bugs.webkit.org/show_bug.cgi?id=116079
24500         Reviewed by David Kilzer.
24502         * Scripts/old-run-webkit-tests:
24503         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
24505 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
24507         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
24508         https://bugs.webkit.org/show_bug.cgi?id=115921
24510         Reviewed by Gustavo Noronha Silva.
24512         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
24513         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
24515 2013-05-13  Alex Christensen  <achristensen@apple.com>
24517         Added testRunner.setPrinting.
24518         https://bugs.webkit.org/show_bug.cgi?id=42693
24519         rdar://problem/8213845
24521         Reviewed by Darin Adler.
24523         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
24524         Added setPrinting JavaScript function.
24525         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
24526         (WTR::InjectedBundlePage::dump):
24527         Dump the external representation for printing if setPrinting has been called.
24528         * WebKitTestRunner/InjectedBundle/TestRunner.h:
24529         (WTR::TestRunner::isPrinting): Added.
24530         (WTR::TestRunner::setPrinting): Added.
24531         Added and initialized m_isPrinting member boolean.
24533 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
24535         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
24536         https://bugs.webkit.org/show_bug.cgi?id=116016
24538         Reviewed by Dirk Pranke.
24540         Same fix as in the upstream style checker, but without hg support.
24541         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
24543         * Scripts/webkitpy/style/checkers/cpp.py:
24544         (FileInfo.repository_name):
24546 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
24548         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
24549         https://bugs.webkit.org/show_bug.cgi?id=115918
24551         Reviewed by Gustavo Noronha Silva.
24553         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
24554         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
24555         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
24556         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
24557         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
24558         problems.
24560         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
24561         These are then used as dependencies for the archive creation rule as well as the list from which the archive
24562         file paths are constructed and then used to dump the member files from these archives. The member files are
24563         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
24564         successfully link.
24566         * TestWebKitAPI/GNUmakefile.am:
24568 2013-05-13  Anders Carlsson  <andersca@apple.com>
24570         Remove UnusedParam.h
24571         https://bugs.webkit.org/show_bug.cgi?id=116029
24573         Reviewed by Andreas Kling.
24575         Stop including UnusedParam.h.
24577         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
24578         * WebKitTestRunner/qt/TestInvocationQt.cpp:
24580 2013-05-12  Commit Queue  <commit-queue@webkit.org>
24582         Unreviewed, rolling out r149955.
24583         http://trac.webkit.org/changeset/149955
24584         https://bugs.webkit.org/show_bug.cgi?id=115990
24586         Broke lots of tests (Requested by smfr on #webkit).
24588         * Scripts/webkitpy/port/mac.py:
24590 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
24592         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
24593         https://bugs.webkit.org/show_bug.cgi?id=115914
24595         Reviewed by Martin Robinson.
24597         * GtkLauncher/main.c:
24598         (createToolbar):
24599         * MiniBrowser/gtk/BrowserWindow.c:
24600         (_BrowserWindow):
24601         (browserWindowSetStatusText):
24602         (fullScreenMessageTimeoutCallback):
24603         (webViewEnterFullScreen):
24604         (webViewLeaveFullScreen):
24605         (browserWindowFinalize):
24606         (browserWindowConstructed):
24607         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
24608         (WTR::EventSenderProxy::mouseScrollBy):
24609         (WTR::EventSenderProxy::continuousMouseScrollBy):
24611 2013-05-11  Anders Carlsson  <andersca@apple.com>
24613         Crash when terminating a process that has not been fully launched
24614         https://bugs.webkit.org/show_bug.cgi?id=115962
24615         <rdar://problem/13660916>
24617         Reviewed by Andreas Kling.
24619         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
24620         before the process has had a chance to be fully launched.
24622         * TestWebKitAPI/GNUmakefile.am:
24623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24624         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
24625         (TestWebKitAPI):
24626         (TestWebKitAPI::didFinishLoadForFrame):
24627         (TestWebKitAPI::TEST):
24628         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
24630 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
24632         Remove Mac OS X Leopard (10.5) support
24633         https://bugs.webkit.org/show_bug.cgi?id=107964
24635         Reviewed by Ryosuke Niwa.
24637         Removed the code for 10.5 and removed if-def for 10.6.
24639         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
24640         (convertMIMEType):
24641         (createXMLStringFromWebArchiveData):
24642         * DumpRenderTree/mac/TestRunnerMac.mm:
24643         (TestRunner::authenticateSession):
24644         (TestRunner::setTextDirection):
24645         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
24646         (convertMIMEType):
24647         (createXMLStringFromWebArchiveData):
24649 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
24651         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
24652         https://bugs.webkit.org/show_bug.cgi?id=115935
24654         Reviewed by Jer Noble.
24656         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
24657         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
24658         to the new manifest file.
24659         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
24661 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
24663         Fix some compiler warnings (miscellaneous)
24664         https://bugs.webkit.org/show_bug.cgi?id=80790
24666         Reviewed by Rob Buis.
24668         Fix the following warnings for BlackBerry:
24669         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
24670         used as truth value [-Wparentheses].
24672         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
24673         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
24675 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
24677         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
24678         https://bugs.webkit.org/show_bug.cgi?id=115928
24680         Reviewed by Kenneth Rohde Christiansen.
24682         WKViewSetThemePath was moved to WKViewEfl.h.
24684         * TestWebKitAPI/efl/PlatformWebView.cpp:
24686 2013-05-10  Andreas Kling  <akling@apple.com>
24688         I accidentally the Java testing.
24690         * Scripts/webkitpy/port/mac.py:
24692 2013-05-10  Brian Holt  <brian.holt@samsung.com>
24694         [GTK] Module Cairo fails to build under jhbuild
24695         https://bugs.webkit.org/show_bug.cgi?id=115854
24697         Reviewed by Martin Robinson.
24699         Make cairo depend on glib in jhbuild.modules.
24701         * gtk/jhbuild.modules:
24703 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
24705         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
24706         https://bugs.webkit.org/show_bug.cgi?id=115904
24708         Reviewed by Martin Robinson.
24710         * ImageDiff/gtk/ImageDiff.cpp:
24711         (main):
24713 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
24715         Add my new address to contributors.json. (Unreviewed)
24717         * Scripts/webkitpy/common/config/contributors.json:
24719 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
24721         Unreviewed. Move myself to the reviewers list.
24723         * Scripts/webkitpy/common/config/contributors.json:
24725 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
24727         Unreviewed. Add my email to a few watchlists.
24729         * Scripts/webkitpy/common/config/watchlist:
24731 2013-05-10  Simon Pena  <simon.pena@samsung.com>
24733         Unicode support missing from string representation of Contributors in committers.py
24734         https://bugs.webkit.org/show_bug.cgi?id=115859
24736         Reviewed by Darin Adler.
24738         Contributors, in committers.py, provided a string representation in __str__ which
24739         didn't support unicode characters, so printing a contributor would fail in that case.
24740         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
24741         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
24743         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
24744         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
24745         representation.
24746         (Contributor.__str__):
24747         (Contributor):
24748         (Contributor.__unicode__):
24749         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
24750         a contributor with unicode characters can be represented as a string.
24751         (CommittersTest):
24752         (CommittersTest.test_contributor_encoding):
24754 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
24756         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
24757         https://bugs.webkit.org/show_bug.cgi?id=92371
24759         Reviewed by Brent Fulgham.
24761         Use JavaScriptThreading.cpp where the same functionality is
24762         implemented too. This reduces the dependency on the pthread
24763         library. Also replace assert() with WebKit ASSERT().
24765         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
24766         * DumpRenderTree/win/DumpRenderTree.cpp:
24767         (dumpHistoryItem):
24768         (dumpBackForwardList):
24769         * DumpRenderTree/win/DumpRenderTree.vcproj:
24771 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
24773         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
24774         https://bugs.webkit.org/show_bug.cgi?id=92505
24776         Reviewed by Brent Fulgham.
24778         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
24779         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
24780         (javaScriptThreadsMutex):
24781         (javaScriptThreads):
24782         (runJavaScriptThread):
24783         (startJavaScriptThreads):
24784         (stopJavaScriptThreads):
24785         * DumpRenderTree/pthreads: Removed.
24786         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
24788 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
24790         Unreviewed. Update Simon Pena email on his behalf.
24792         * Scripts/webkitpy/common/config/contributors.json:
24794 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
24796         Add support for [NoInterfaceObject] Web IDL extended attribute
24797         https://bugs.webkit.org/show_bug.cgi?id=115714
24799         Reviewed by Kentaro Hara.
24801         Update BindingsTests.generate_supplemental_dependency() to pass an
24802         additional windowConstructorsFile argument to preprocess-idls.pl.
24804         * Scripts/webkitpy/bindings/main.py:
24805         (BindingsTests.generate_supplemental_dependency):
24806         (BindingsTests.main):
24808 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
24810         [GTK][AC] Buildfix after r149694
24811         https://bugs.webkit.org/show_bug.cgi?id=115797
24813         Reviewed by Gustavo Noronha Silva.
24815         Add CLUTTER_LIBS for linking TestWebCore.
24817         * TestWebKitAPI/GNUmakefile.am:
24819 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
24821         [EFL] Remove unnecessary pkgs in EFL jhbuild
24822         https://bugs.webkit.org/show_bug.cgi?id=114908
24824         Reviewed by Laszlo Gombos.
24826         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
24827         handle them using jhbuild. We can reduce build time when using --update-efl.
24829         * efl/jhbuild.modules:
24831 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
24833         [EFL] Disable SHADOW DOM feature in FeatureList.pm
24834         https://bugs.webkit.org/show_bug.cgi?id=115834
24836         Reviewed by Gyuyoung Kim.
24838         * Scripts/webkitperl/FeatureList.pm:
24840 2013-05-08  Lucas Forschler  <lforschler@apple.com>
24842         Add Scheduler for Mac MtnLion 32bit Release builder.
24843         
24844         Unreviewed.
24845         
24846         * BuildSlaveSupport/build.webkit.org-config/config.json:
24848 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
24850         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
24851         https://bugs.webkit.org/show_bug.cgi?id=115808
24853         Reviewed by Darin Adler.
24855         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
24856         was left outdated after r127191, when the m_string member was changed
24857         from UString to String. This patch calls the right pretty printer for it.
24859         * gdb/webkit.py:
24860         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
24861         WTFImplPrettyPrinter.
24863 2013-05-08  Andy Estes  <aestes@apple.com>
24865         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
24866         https://bugs.webkit.org/show_bug.cgi?id=115790
24868         Reviewed by Alexey Proskuryakov.
24870         Added two API tests:
24872         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
24873         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
24875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24876         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
24877         (TestWebKitAPI):
24878         (TestWebKitAPI::TEST):
24879         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
24880         (TestWebKitAPI):
24881         (TestWebKitAPI::decidePolicyForNavigationAction):
24882         (CustomProtocolInvalidSchemeTest):
24883         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
24885 2013-05-08  Lucas Forschler  <lforschler@apple.com>
24887         Teach buildbot how to compile 32-bit on Mac.
24889         Reviewed by Ryosuke Niwa.
24891         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
24892         (CompileWebKit.start):
24893         (ExtractTestResultsAndLeaks):
24895 2013-05-08  Eli Fidler  <efidler@blackberry.com>
24897         [BlackBerry] Fix usage of BlackBerry::Platform::String
24898         https://bugs.webkit.org/show_bug.cgi?id=115781
24900         Reviewed by Rob Buis.
24902         BlackBerry PRs 304193 and 327181
24903         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
24905         We currently have a problem where we're passing UTF-8 encoded data into
24906         the char* constructors of BlackBerry::Platform::String. This means the string
24907         thinks its data is not UTF-8.
24909         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
24910         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
24911         (BlackBerry::WebKit::dumpHistoryItem):
24912         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
24913         (TestRunner::setUserStyleSheetLocation):
24914         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
24915         (LoadHTMLStringItem::invoke):
24917 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
24919         Tools: add new BlackBerry include dirs.
24920         https://bugs.webkit.org/show_bug.cgi?id=115514
24922         Reviewed by Rob Buis.
24924         iType include dirs are missing, and HarfBuzz needs to be fixed.
24926         * Scripts/webkitdirs.pm:
24927         (blackberryCMakeArguments):
24929 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
24931         [GTK] Plumb the Automake build system for the Battery Status API feature
24932         https://bugs.webkit.org/show_bug.cgi?id=115718
24934         Reviewed by Martin Robinson.
24936         * Scripts/webkitdirs.pm:
24937         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
24938         through the --(enable|disable)-battery-status flag passed to configure.
24940 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
24942         new-run-webkit-websocketserver doesn't work after Chromium removal
24943         https://bugs.webkit.org/show_bug.cgi?id=115816
24945         Reviewed by Joseph Pecoraro.
24947         Fix the bug by instantiating the correct port object.
24949         * Scripts/new-run-webkit-websocketserver:
24950         (main):
24952 2013-05-07  Lucas Forschler  <lforschler@apple.com>
24954         Configure buildbot for 32bit builder.
24955         https://bugs.webkit.org/show_bug.cgi?id=115769
24956         
24957         Reviewed by Ryosuke Niwa.
24959         * BuildSlaveSupport/build.webkit.org-config/config.json:
24961 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
24963         Unreviewed. Update to show my apple.com address.
24965         * Scripts/webkitpy/common/config/contributors.json: Added
24966         my apple.com e-mail address.
24968 2013-05-08  David Kilzer  <ddkilzer@apple.com>
24970         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
24972         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
24973         (concatenateAttributeAndValue): Switch to appendVector().
24975 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
24977         [Qt][WTR] Fix the build on Mac after r149692
24979         Unreviewed build fix.
24981         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
24982         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
24984 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
24986         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
24987         to the watchlist for Accessibility.
24989         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
24990         * Scripts/webkitpy/common/config/watchlist: Added myself.
24992 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
24994         [Qt] Build fails with clang
24995         https://bugs.webkit.org/show_bug.cgi?id=115741
24997         Reviewed by Benjamin Poulain.
24999         Since r149112 std::move is used in AtomicString for compilers that
25000         support rvalue references and this requires a standard library
25001         implementing c++11 move semantics.
25002         We only explicitely require c++11 for WebKit2, but since clang supports
25003         rvalue references the build of subtargets using AtomicString fails because
25004         of missing std::move.
25005         It is safe to add CONFIG += c++11 for the whole project when using clang
25006         since we explicitely disable c++11 for ANGLE that had probems with libc++.
25008         * qmake/mkspecs/features/unix/default_pre.prf:
25010 2013-05-08  Darin Adler  <darin@apple.com>
25012         Fix one more place that needed to use adoptCF/NS
25013         https://bugs.webkit.org/show_bug.cgi?id=115778
25015         Reviewed by Benjamin Poulain.
25017         Not sure why I missed this code last time, but found a bit more code that needs
25018         to switch to the newer style adoptCF/NS.
25020         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
25021         (convertWebResourceDataToString): Use adoptCF.
25022         (convertWebResourceResponseToDictionary): Ditto.
25023         (createXMLStringFromWebArchiveData): Ditto.
25024         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
25025         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
25027 2013-05-08  Commit Queue  <commit-queue@webkit.org>
25029         Unreviewed, rolling out r149271.
25030         http://trac.webkit.org/changeset/149271
25031         https://bugs.webkit.org/show_bug.cgi?id=115780
25033         The mangled symbols are now enforced through LDFLAGS
25034         (Requested by zdobersek on #webkit).
25036         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
25038 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
25040         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
25041         https://bugs.webkit.org/show_bug.cgi?id=115636
25043         Reviewed by Ryosuke Niwa.
25045         * TestResultServer/static-dashboards/flakiness_dashboard.js:
25046         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
25047         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
25048         while Chromium-specific, can't be removed just yet as there's more code that uses it.
25050 2013-05-06  Darin Adler  <darin@apple.com>
25052         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
25053         https://bugs.webkit.org/show_bug.cgi?id=115657
25055         Reviewed by Sam Weinig.
25057         This is similar to my last set of changes, but covers code that I missed with
25058         global replace using the Safari Xcode workspace.
25060         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
25061         (convertWebResourceDataToString):
25062         (convertWebResourceResponseToDictionary):
25063         (createXMLStringFromWebArchiveData):
25064         * DumpRenderTree/cg/ImageDiffCG.cpp:
25065         (createImageFromStdin):
25066         (createDifferenceImage):
25067         (main):
25068         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
25069         (printPNG):
25070         (dumpBitmap):
25071         * DumpRenderTree/cg/PixelDumpSupportCG.h:
25072         (BitmapContext::BitmapContext):
25073         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
25074         (-[MockWebNotificationProvider init]):
25075         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
25076         (createBitmapContext):
25077         * DumpRenderTree/mac/TestRunnerMac.mm:
25078         (TestRunner::addDisallowedURL):
25079         (TestRunner::applicationCacheDiskUsageForOrigin):
25080         (TestRunner::localStorageDiskUsageForOrigin):
25081         (TestRunner::clearApplicationCacheForOrigin):
25082         (TestRunner::deleteLocalStorageForOrigin):
25083         (TestRunner::copyDecodedHostName):
25084         (TestRunner::copyEncodedHostName):
25085         (TestRunner::queueLoad):
25086         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
25087         (TestRunner::setMockGeolocationPositionUnavailableError):
25088         (TestRunner::setUserStyleSheetLocation):
25089         (TestRunner::setValueForUser):
25090         (TestRunner::overridePreference):
25091         (TestRunner::setPersistentUserStyleSheetLocation):
25092         (TestRunner::execCommand):
25093         (TestRunner::findString):
25094         (TestRunner::isCommandEnabled):
25095         (TestRunner::addOriginAccessWhitelistEntry):
25096         (TestRunner::removeOriginAccessWhitelistEntry):
25097         (TestRunner::addUserScript):
25098         (TestRunner::addUserStyleSheet):
25099         (TestRunner::evaluateInWebInspector):
25100         (TestRunner::evaluateScriptInIsolatedWorld):
25101         (TestRunner::apiTestNewWindowDataLoadBaseURL):
25102         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
25103         (TestRunner::authenticateSession):
25104         (TestRunner::grantWebNotificationPermission):
25105         (TestRunner::denyWebNotificationPermission):
25106         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
25107         (createCFURLResponseFromResponseData):
25108         * DumpRenderTree/mac/WorkQueueItemMac.mm:
25109         (LoadItem::invoke):
25110         (LoadHTMLStringItem::invoke):
25111         (ScriptItem::invoke):
25112         * DumpRenderTree/win/DumpRenderTree.cpp:
25113         (substringFromIndex):
25114         (urlSuitableForTestResult):
25115         (lastPathComponent):
25116         (sharedCFURLCache):
25117         * DumpRenderTree/win/ImageDiffCairo.cpp:
25118         (createImageFromStdin):
25119         (main):
25120         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
25121         (createBitmapContextFromWebView):
25122         * DumpRenderTree/win/TestRunnerWin.cpp:
25123         (TestRunner::setUserStyleSheetLocation):
25124         (TestRunner::setPersistentUserStyleSheetLocation):
25125         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
25126         (TestWebKitAPI::TEST):
25127         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
25128         (TestWebKitAPI::TEST):
25129         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
25130         (TestWebKitAPI::TEST):
25131         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
25132         (TestWebKitAPI::TEST):
25133         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
25134         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
25135         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
25136         (TestWebKitAPI::createWindow):
25137         (TestWebKitAPI::TEST):
25138         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
25139         (TestWebKitAPI::TEST):
25140         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
25141         (TestWebKitAPI::AcceptsFirstMouse::runTest):
25142         * TestWebKitAPI/Tests/mac/AttributedString.mm:
25143         (TestWebKitAPI::TEST):
25144         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
25145         (TestWebKitAPI::TEST):
25146         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
25147         (TestWebKitAPI::TEST):
25148         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
25149         (TestWebKitAPI::TEST):
25150         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
25151         (TestWebKitAPI::TEST):
25152         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
25153         (TestWebKitAPI::TEST):
25154         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
25155         (TestWebKitAPI::TEST):
25156         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
25157         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
25158         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
25159         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
25160         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
25161         (TestWebKitAPI::TEST):
25162         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
25163         (TestWebKitAPI::TEST):
25164         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
25165         (TestWebKitAPI::TEST):
25166         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
25167         (TestWebKitAPI::TEST):
25168         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
25169         (TestWebKitAPI::TEST):
25170         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
25171         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
25172         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
25173         (TestWebKitAPI::TEST):
25174         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
25175         (TestWebKitAPI::TEST):
25176         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
25177         (TestWebKitAPI::TEST):
25178         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
25179         (TestWebKitAPI::TEST):
25180         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
25181         (TestWebKitAPI::TEST):
25182         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
25183         (TestWebKitAPI::TEST):
25184         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
25185         (TestWebKitAPI::TEST):
25186         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
25187         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
25188         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
25189         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
25190         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
25191         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
25192         (WTR::testPathFromURL):
25193         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
25194         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
25195         * WebKitTestRunner/cg/TestInvocationCG.cpp:
25196         (WTR::createCGContextFromImage):
25197         (WTR::dumpBitmap):
25198         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
25199         * WebKitTestRunner/mac/EventSenderProxy.mm:
25200         (WTR::EventSenderProxy::mouseScrollBy):
25201         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
25202         (WTR::PlatformWebView::windowSnapshotImage):
25203         * WebKitTestRunner/win/TestControllerWin.cpp:
25204         (WTR::TestController::initializeTestPluginDirectory):
25205         Use adoptCF and adoptNS.
25207 2013-05-07  Alex Christensen  <achristensen@apple.com>
25209         Fix a memory leak introduced in r149692
25210         https://bugs.webkit.org/show_bug.cgi?id=115766
25212         Reviewed by Mark Rowe.
25214         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
25215         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
25217         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
25218         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
25219         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
25221 2013-05-07  Darin Adler  <darin@apple.com>
25223         [Win] Fix storage leak in Windows DumpRenderTree
25224         https://bugs.webkit.org/show_bug.cgi?id=115651
25226         Reviewed by Sam Weinig.
25228         * DumpRenderTree/win/DumpRenderTree.cpp:
25229         (lastPathComponent): Added a missing call to adoptCF.
25231 2013-05-07  Alex Christensen  <achristensen@apple.com>
25233         fixed a memory leak introduced by bug 42324 by using a RetainPtr
25234         https://bugs.webkit.org/show_bug.cgi?id=115760
25236         Reviewed by Tim Horton.
25238         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
25239         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
25240         fixed memory leak, added UNUSED_PARAM macros
25242 2013-05-07  Alex Christensen  <achristensen@apple.com>
25244         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
25245         https://bugs.webkit.org/show_bug.cgi?id=42324
25246         <rdar://problem/8193633>
25248         Reviewed by Tim Horton.
25250         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
25251         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
25252         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
25253         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
25254         Added dumpDOMAsWebArchive code that is called when dumping.        
25255         (WTR::InjectedBundlePage::dump):
25256         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
25257         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
25258         (InjectedBundlePage):
25259         Added dumpDOMAsWebArchive declaration.
25260         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
25261         (WTR::TestRunner::dumpDOMAsWebArchive):
25262         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
25263         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
25264         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
25265         * Tools/WebKitTestRunner/cf: Added.
25266         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
25267         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
25268         (convertMIMEType):
25269         (convertWebResourceDataToString):
25270         (normalizeHTTPResponseHeaderFields):
25271         (normalizeWebResourceURL):
25272         (convertWebResourceResponseToDictionary):
25273         (compareResourceURLs):
25274         (createXMLStringFromWebArchiveData):
25275         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
25276         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
25277         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
25278         Copied from Tools/DumpRenderTree/mac for used functions.
25279         (createCFURLResponseFromResponseData):
25280         (supportedNonImageMIMETypes):
25282 2013-05-07  Alex Christensen  <achristensen@apple.com>
25284         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
25285         https://bugs.webkit.org/show_bug.cgi?id=115745
25287         Reviewed by Tim Horton.
25289         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
25290         (compareResourceURLs):
25291         Updated style.
25293 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
25295         Add an 'isReadOnly' member to IDL parse tree structure
25296         https://bugs.webkit.org/show_bug.cgi?id=115704
25298         Reviewed by Kentaro Hara.
25300         Use newly added isReadOnly attribute.
25302         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
25303         (_generateHeaderFile):
25304         (_generateImplementationFile):
25305         (_staticValuesGetterImplementation):
25307 2013-05-07  Anders Carlsson  <andersca@apple.com>
25309         Remove AlwaysInline.h from WTF
25310         https://bugs.webkit.org/show_bug.cgi?id=115727
25312         Reviewed by Brent Fulgham.
25314         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
25315         to keep AlwaysInline.h around anymore.
25317         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
25318         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
25320 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
25322         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
25323         https://bugs.webkit.org/show_bug.cgi?id=114808
25325         Reviewed by Jocelyn Turcotte.
25327         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
25328         (https://codereview.qt-project.org/#change,54234)
25330         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
25331         (WTR::WrapperWindow::handleStatusChanged):
25333 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
25335         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
25337         * Scripts/webkitpy/common/config/watchlist:
25339 2013-05-06  Kangil Han  <kangil.han@samsung.com>
25341         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
25342         https://bugs.webkit.org/show_bug.cgi?id=115645
25344         Reviewed by Gyuyoung Kim.
25346         To run performance tests in wk1, we need --no-timeout option implementation.
25347         So adopt it from gtk+ port.
25349         * DumpRenderTree/efl/DumpRenderTree.cpp:
25350         (shouldSetWaitToDumpWatchdog):
25351         (parseCommandLineOptions):
25352         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
25353         * DumpRenderTree/efl/TestRunnerEfl.cpp:
25354         (TestRunner::setWaitToDump):
25356 2013-05-06  Commit Queue  <commit-queue@webkit.org>
25358         Unreviewed, rolling out r149547.
25359         http://trac.webkit.org/changeset/149547
25360         https://bugs.webkit.org/show_bug.cgi?id=115682
25362         Added unittests that fail on bots and spits out text into
25363         stdout (Requested by rniwa on #webkit).
25365         * Scripts/import-w3c-tests: Removed.
25366         * Scripts/webkitpy/w3c/__init__.py: Removed.
25367         * Scripts/webkitpy/w3c/test_converter.py: Removed.
25368         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
25369         * Scripts/webkitpy/w3c/test_importer.py: Removed.
25370         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
25371         * Scripts/webkitpy/w3c/test_parser.py: Removed.
25372         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
25374 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
25376         [jhbuild] bump jhbuild version to take advantage of new improvements
25377         https://bugs.webkit.org/show_bug.cgi?id=115558
25379         Reviewed by Martin Robinson.
25381         One of the important improvements is jhbuild no longer fetches git
25382         repositories if they are already at the expected revision, which should
25383         make the EWS bots more robust to git servers unavailability.
25385         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
25387 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
25389         [GTK] Add webkit_uri_scheme_request_finish_error
25390         https://bugs.webkit.org/show_bug.cgi?id=94316
25392         Reviewed by Anders Carlsson.
25394         * MiniBrowser/gtk/main.c:
25395         (miniBrowserErrorQuark): Add function to create a global quark for
25396         MiniBrowser.
25397         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
25398         function webkit_uri_scheme_request_finish_error().
25400 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
25402         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
25403         https://bugs.webkit.org/show_bug.cgi?id=113808
25405         Reviewed by Rob Buis.
25407         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
25408         to true for BlackBerry.
25410         * Scripts/webkitperl/FeatureList.pm:
25412 2013-05-06  Jessie Berlin  <jberlin@apple.com>
25414         check-webkit-style should complain about a layering violation if platform-specific guards are
25415         used in WebCore outside of the platform directory
25416         https://bugs.webkit.org/show_bug.cgi?id=115567
25418         Reviewed by Benjamin Poulain.
25420         * Scripts/webkitpy/style/checkers/cpp.py:
25421         (check_for_webcore_platform_layering_violation):
25422         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
25423         (process_line):
25424         Add the check_for_webcore_platform_layering_violation.
25425         (CppChecker):
25426         List the new check.
25428         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
25429         (CppStyleTest.test_webcore_platform_layering_violation):
25430         Add tests.
25432 2013-05-06  David Kilzer  <ddkilzer@apple.com>
25434         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
25435         <http://webkit.org/b/115667>
25437         Reviewed by Dirk Pranke.
25439         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
25440         (Bugzilla._check_create_bug_response): Update regex to work with
25441         Bugzilla 3.2.3 and 4.2.5.
25442         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
25443         (test__check_create_bug_response): Add new test that covers both
25444         old and new <title> variations.
25446 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
25448         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
25449         https://bugs.webkit.org/show_bug.cgi?id=115661
25451         Reviewed by Ryosuke Niwa.
25453         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
25454         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
25455         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
25457         * TestResultServer/static-dashboards/flakiness_dashboard.js:
25458         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
25460 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
25462         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
25463         https://bugs.webkit.org/show_bug.cgi?id=114603
25465         Reviewed by Ryosuke Niwa.
25467         * TestResultServer/generate_builders_json.py:
25468         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
25469         to represent these to be 'layout-test', for backwards compatibility.
25470         (main): Remove all the build.chromium.org masters.
25471         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
25472         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
25473         (GenerateBuildersJsonTest):
25474         (GenerateBuildersJsonTest.test_generate_json_data):
25475         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
25476         test-running builders from the webkit.org master.
25478 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
25480         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
25481         https://bugs.webkit.org/show_bug.cgi?id=114988
25483         Reviewed by Ryosuke Niwa.
25485         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
25486         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
25487         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
25488         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
25489         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
25491 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
25493         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
25494         https://bugs.webkit.org/show_bug.cgi?id=114954
25496         Reviewed by Ryosuke Niwa.
25498         * TestResultServer/static-dashboards/flakiness_dashboard.js:
25499         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
25500         modifier unions in the list of modifiers.
25501         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
25502         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
25504 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
25506         [Flakiness Dashboard] Simplify builder-name-based platform recognition
25507         https://bugs.webkit.org/show_bug.cgi?id=114957
25509         Reviewed by Ryosuke Niwa.
25511         * TestResultServer/static-dashboards/flakiness_dashboard.js:
25512         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
25513         (chromiumPlatform): Removed, unnecessary.
25514         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
25515         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
25516         the builder operates with debug builds, no webkit.org builders are named this way.
25517         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
25518         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
25520 2013-05-06  Andy Estes  <aestes@apple.com>
25522         Added two files I neglected to commit in r149589.
25524         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
25525         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
25527 2013-05-04  Andy Estes  <aestes@apple.com>
25529         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
25530         https://bugs.webkit.org/show_bug.cgi?id=115609
25532         Reviewed by Oliver Hunt.
25534         Added an API test.
25536         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25537         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
25538         (+[TestDelegate shared]):
25539         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
25540         (-[TestDelegate webView:createWebViewWithRequest:]):
25541         (TestWebKitAPI):
25542         (TestWebKitAPI::TEST):
25543         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
25545 2013-05-06  Antoine Quint  <graouts@apple.com>
25547         Manage the presentation of the snapshotted plug-in using JavaScript
25548         https://bugs.webkit.org/show_bug.cgi?id=115548
25550         Reviewed by Dean Jackson.
25552         Take into account the new plugInExtraScript method added to support
25553         the injection of a JS file from the chrome client to customize the
25554         rendering of a snapshotted plug-in's shadow tree.
25556         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
25557         (WTR::InjectedBundlePage::InjectedBundlePage):
25559 2013-05-05  Anders Carlsson  <andersca@apple.com>
25561         Remove the Vector::append overload that takes a Vector
25562         https://bugs.webkit.org/show_bug.cgi?id=115535
25564         Reviewed by Andreas Kling.
25566         Use Vector::appendVector instead.
25568         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
25569         (concatenateAttributeAndValue):
25570         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
25571         (WTR::concatenateAttributeAndValue):
25573 2013-05-04  Sam Weinig  <sam@webkit.org>
25575         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
25576         <rdar://problem/13702008>
25577         https://bugs.webkit.org/show_bug.cgi?id=115607
25579         Reviewed by Benjamin Poulain.
25581         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25582         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
25583         (TestWebKitAPI::didFinishLoadForFrame):
25584         (TestWebKitAPI::TEST):
25585         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
25587 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
25589         Unreviewed.
25591         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
25593 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
25595         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
25597         * Scripts/webkitpy/common/config/contributors.json:
25599 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
25601         [GTK] Catch select.error exceptions in parse_output_lines
25602         https://bugs.webkit.org/show_bug.cgi?id=115253
25604         Reviewed by Gustavo Noronha Silva.
25606         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
25607         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
25608         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
25609         error code and the error message) and the loop is re-entered.
25611         * gtk/common.py:
25612         (parse_output_lines):
25614 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
25616         [GTK] Set up the TestWebCore in TestWebKitAPI
25617         https://bugs.webkit.org/show_bug.cgi?id=115237
25619         Reviewed by Gustavo Noronha Silva.
25621         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
25622         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
25623         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
25624         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
25625         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
25627         * TestWebKitAPI/GNUmakefile.am:
25629 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
25631         Create a script to import W3C tests
25632         https://bugs.webkit.org/show_bug.cgi?id=111513
25634         Reviewed by Dirk Pranke.
25636         Script to automate the import of W3C tests into WebKit. 
25637         For the full description of how it works, see the comments
25638         at the top of test_importer.py.
25640         * Scripts/import-w3c-tests: Added.
25641         * Scripts/webkitpy/w3c/__init__.py: Added.
25642         * Scripts/webkitpy/w3c/test_converter.py: Added.
25643         (TestConverter):
25644         (TestConverter.__init__):
25645         (TestConverter.load_prefixed_prop_list):
25646         (TestConverter.load_file):
25647         (TestConverter.convert_for_webkit):
25648         (TestConverter.convert_testharness_paths):
25649         (TestConverter.convert_prefixed_properties):
25650         (TestConverter.scrub_unprefixed_props):
25651         (TestConverter.replace_tag):
25652         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
25653         (TestConverterTest):
25654         (TestConverterTest.testLoadPrefixedPropList):
25655         (TestConverterTest.test_convertForWebkitNothingToConvert):
25656         (test_convertForWebkitHarnessOnly):
25657         (test_convertForWebkitPropsOnly):
25658         (test_convertForWebkitHarnessAndProps):
25659         (test_convertTestHarnessPaths):
25660         (test_convertPrefixedProperties):
25661         (verifyTestHarnessPaths):
25662         (verifyPrefixedProperties):
25663         (generateTestContent):
25664         * Scripts/webkitpy/w3c/test_importer.py: Added.
25665         (main):
25666         (parse_args):
25667         (validate_import_directory):
25668         (TestImporter):
25669         (TestImporter.__init__):
25670         (TestImporter.do_import):
25671         (TestImporter.get_changeset):
25672         (TestImporter.scan_source_directory):
25673         (TestImporter.import_tests):
25674         (TestImporter.setup_destination_directory):
25675         (TestImporter.get_test_status):
25676         (TestImporter.remove_deleted_files):
25677         (TestImporter.write_import_log):
25678         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
25679         (TestImporterTest):
25680         (TestImporterTest.test_ImportDirWithNoTests):
25681         * Scripts/webkitpy/w3c/test_parser.py: Added.
25682         (TestParser):
25683         (TestParser.__init__):
25684         (TestParser.load_file):
25685         (TestParser.analyze_test):
25686         (TestParser.get_reftests):
25687         (TestParser.is_jstest):
25688         (TestParser.get_support_files):
25689         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
25690         (TestParserTest):
25691         (TestParserTest.test_analyzeTestReftestOneMatch):
25692         (test_analyzeTestReftestMultipleMatches):
25693         (test_analyzeTestReftestMatchAndMismatch):
25694         (test_analyzeTestReftestWithRefSupportFiles):
25695         (test_analyzeJSTest):
25696         (test_analyzePixelTestAllTrue):
25697         (test_analyzePixelTestAllFalse):
25698         (test_analyzeNonHTMLFile):
25700 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
25702         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
25704         * Scripts/webkitpy/common/config/contributors.json:
25706 2013-05-02  Nico Weber  <thakis@chromium.org>
25708         Remove a stale script file.
25709         https://bugs.webkit.org/show_bug.cgi?id=115521
25711         Reviewed by Anders Carlsson.
25713         This script was added in
25714         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
25715         Bakefile system that was removed in
25716         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
25717         script just asserts when it's run and is useless.
25719         * Scripts/update-sources-list.py: Removed.
25721 2013-05-01  Glenn Adams  <glenn@skynav.com>
25723         [webkitpy] Need abstract base class for commands that analyze commit logs
25724         https://bugs.webkit.org/show_bug.cgi?id=115391
25726         Reviewed by Benjamin Poulain.
25728         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
25729         in preparation for adding two new commands that will reuse this functionality along with
25730         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
25731         https://bugs.webkit.org/show_bug.cgi?id=115388.
25733         No new tests as this patch does not change existing functionality or behavior.
25735         * Scripts/webkitpy/tool/commands/suggestnominations.py:
25736         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
25737         (AbstractCommitLogCommand.__init__):
25738         (AbstractCommitLogCommand._init_options):
25739         (AbstractCommitLogCommand._parse_commit_message):
25740         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
25741         (SuggestNominations.__init__): 
25742         (SuggestNominations._init_options):
25744 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
25746         Web Inspector: Fix check-inspector-strings script and fix localized strings
25747         https://bugs.webkit.org/show_bug.cgi?id=115495
25749         Reviewed by Joseph Pecoraro.
25751         * Scripts/check-inspector-strings:
25753 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
25755         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
25756         https://bugs.webkit.org/show_bug.cgi?id=115470
25758         Reviewed by Martin Robinson.
25760         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
25761         not building either of the IOS, Windows or GTK-WK1 platforms.
25763         Up until now the header was included for everything but the IOS and Windows platforms due to
25764         an incorrectly stated condition regarding the GTK platform.
25766         * TestWebKitAPI/config.h:
25768 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
25770         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
25771         https://bugs.webkit.org/show_bug.cgi?id=115469
25773         Reviewed by Martin Robinson.
25775         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
25776         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
25777         for the WebKit2 tests and the injected bundle required by them.
25779         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
25780         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
25781         under the WebKit2 code).
25783         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
25784         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
25785         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
25787         * TestWebKitAPI/GNUmakefile.am:
25789 2013-04-30  Glenn Adams  <glenn@skynav.com>
25791         Unreviewed. Add myself to watchlist entries.
25793         * Scripts/webkitpy/common/config/watchlist:
25795 2013-04-30  Glenn Adams  <glenn@skynav.com>
25797         [webkitpy] suggest-nominations doesn't count all qualified patches
25798         https://bugs.webkit.org/show_bug.cgi?id=115285
25800         Reviewed by Benjamin Poulain.
25802         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
25803         nomination. Improve commit log parsing.
25805         * Scripts/webkitpy/tool/commands/suggestnominations.py:
25806         (CommitLogError):
25807         (CommitLogError.__init__):
25808         (CommitLogMissingReviewer):
25809         (CommitLogMissingReviewer.__init__):
25810         (SuggestNominations):
25811         (SuggestNominations.__init__):
25812         (SuggestNominations._recent_commit_messages):
25813         (SuggestNominations._author_name_from_email):
25814         (SuggestNominations._contributor_from_email):
25815         (SuggestNominations._parse_commit_message):
25816         (SuggestNominations._count_commit):
25817         (SuggestNominations._count_recent_patches):
25818         (SuggestNominations._collect_nominations):
25819         (SuggestNominations._print_nominations):
25820         (SuggestNominations.execute):
25821         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
25822         (_make_options):
25823         (test_recent_commit_messages):
25824         (test_basic):
25826 2013-04-30  Commit Queue  <rniwa@webkit.org>
25828         Unreviewed, rolling out r149309.
25829         http://trac.webkit.org/changeset/149309
25830         https://bugs.webkit.org/show_bug.cgi?id=115430
25832         The patch does not build on WK1-only builds of the GTK port
25833         (Requested by zdobersek on #webkit).
25835         * TestWebKitAPI/GNUmakefile.am:
25837 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
25839         Stop using "in" keyword in IDL files
25840         https://bugs.webkit.org/show_bug.cgi?id=115418
25842         Reviewed by Kentaro Hara.
25844         Remove "in" keyword from IDL files as this is no longer part of the Web
25845         IDL specification.
25847         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
25848         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
25849         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
25850         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
25851         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
25852         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
25853         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
25854         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
25856 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
25858         [EFL] Enable scaled cursors
25859         https://bugs.webkit.org/show_bug.cgi?id=106242
25861         Reviewed by Gyuyoung Kim.
25863         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
25865         * Scripts/webkitperl/FeatureList.pm:
25867 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
25869         Replace "Optional" extended attribute by proper Web IDL "optional" keyword
25870         https://bugs.webkit.org/show_bug.cgi?id=115380
25872         Reviewed by Kentaro Hara.
25874         Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
25875         keyword.
25877         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
25878         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
25880 2013-04-30  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
25882         Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
25883         https://bugs.webkit.org/show_bug.cgi?id=114684
25885         Reviewed by Simon Hausmann.
25887         Remove the ANGLE requirement for USE(3D_GRAPHICS).
25888         This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
25890         * qmake/mkspecs/features/features.prf:
25892 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
25894         [GTK] Disable Shadow DOM feature
25895         https://bugs.webkit.org/show_bug.cgi?id=115374
25897         Reviewed by Martin Robinson.
25899         Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
25901         * Scripts/webkitperl/FeatureList.pm:
25903 2013-04-29  Glenn Adams  <glenn@skynav.com>
25905         [webkitpy] Add missing contributor email addresses
25906         https://bugs.webkit.org/show_bug.cgi?id=115394
25908         Reviewed by Ryosuke Niwa.
25910         * Scripts/webkitpy/common/config/contributors.json:
25912 2013-04-29  Alberto Garcia  <agarcia@igalia.com>
25914         Remove all remaining Skia code
25915         https://bugs.webkit.org/show_bug.cgi?id=115263
25917         Reviewed by Benjamin Poulain.
25919         Remove all remaining references to Skia.
25921         * Scripts/webkitdirs.pm:
25922         (blackberryCMakeArguments):
25923         * Scripts/webkitpy/common/config/contributionareas.py:
25924         * Scripts/webkitpy/common/config/watchlist:
25926 2013-04-29  Seokju Kwon  <seokju.kwon@gmail.com>
25928         Get rid of unused options in Tools/Scripts/webkit-build-directory
25929         https://bugs.webkit.org/show_bug.cgi?id=115383
25931         Reviewed by Darin Adler.
25933         * Scripts/webkit-build-directory:
25935 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
25937         [WK2][Mac] Test with NetworkProcess enabled.
25939         Fix the build for non-Mac.
25941         * WebKitTestRunner/TestController.cpp:
25942         (WTR::TestController::initialize):
25944 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
25946         [WK2][Mac] Test with NetworkProcess enabled.
25948         Reviewed by Sam Weinig.
25950         * WebKitTestRunner/TestController.cpp:
25951         (WTR::TestController::initialize):
25953 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
25955         [GTK] Set up the TestWebCore in TestWebKitAPI
25956         https://bugs.webkit.org/show_bug.cgi?id=115237
25958         Reviewed by Gustavo Noronha Silva.
25960         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
25961         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
25962         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
25963         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
25964         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
25966         * TestWebKitAPI/GNUmakefile.am:
25968 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
25970         [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
25971         https://bugs.webkit.org/show_bug.cgi?id=115236
25973         Reviewed by Gustavo Noronha Silva.
25975         Set up the TestJavaScriptCore unit test program, consisting of the unit tests
25976         under the TestWebKitAPI/Tests/JavaScriptCore directory.
25978         * TestWebKitAPI/GNUmakefile.am:
25980 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
25982         [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
25983         https://bugs.webkit.org/show_bug.cgi?id=115323
25985         Reviewed by Philippe Normand.
25987         Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
25988         Its presence enforces linkers to output mangled symbols when reporting linking failures
25989         due to unresolved references. People trying to fix the build can then simply copy
25990         the printed mangled symbol into the symbols.filter file instead of doing a manual build
25991         or connecting to the builders to discover the mangled version of the missing symbol.
25993         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
25995 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
25997         Remove Chromium code from Tools/BuildSlaveSupport
25998         https://bugs.webkit.org/show_bug.cgi?id=115325
26000         Reviewed by Benjamin Poulain.
26002         Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
26003         covering archiving test results and built products.
26005         * BuildSlaveSupport/built-product-archive:
26006         (archiveBuiltProduct):
26007         (extractBuiltProduct):
26008         * BuildSlaveSupport/chromium/output-android-device-status: Removed.
26009         * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
26010         * BuildSlaveSupport/test-result-archive:
26011         (archiveTestResults):
26013 2013-04-28  Seokju Kwon  <seokju.kwon@gmail.com>
26015         Remove support for Chromium from webkitdirs.pm
26016         https://bugs.webkit.org/show_bug.cgi?id=115338
26018         Reviewed by Darin Adler.
26020         * Scripts/webkitdirs.pm:
26021         (determineBaseProductDir):
26022         (argumentsForConfiguration):
26023         (builtDylibPathForName):
26024         (determineIsQt):
26025         (isAppleWebKit):
26027 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
26029         Rename TestRunner's setAudioData to setAudioResult
26030         https://bugs.webkit.org/show_bug.cgi?id=115326
26032         Reviewed by Darin Adler.
26034         Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
26035         than the previous one. The change is a simple rename, there's no change in the method's functionality. The
26036         affected tests are adjusted accordingly.
26038         * DumpRenderTree/qt/TestRunnerQt.cpp:
26039         (TestRunnerQt::setAudioResult):
26040         * DumpRenderTree/qt/TestRunnerQt.h:
26041         (TestRunnerQt):
26042         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
26043         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
26044         (WTR::TestRunner::setAudioResult):
26045         * WebKitTestRunner/InjectedBundle/TestRunner.h:
26046         (TestRunner):
26048 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
26050         [WKTR] Tests dumping audio data shouldn't dump pixels
26051         https://bugs.webkit.org/show_bug.cgi?id=115270
26053         Reviewed by Benjamin Poulain.
26055         Prevent dumping the pixel output when Web Audio tests are dumping output data
26056         as the testing output. Pixel output in these tests has no real meaning and is
26057         as such unnecessary.
26059         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
26060         (WTR::TestRunner::setAudioData):
26062 2013-04-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
26064         [EFL] Unreviewed Intel bots fix after r149231.
26066         * efl/jhbuild.modules: Disable the libxml Python bindings since the
26067         bots don't have Python's development files installed. libxml should
26068         detect this kind of thing better.
26070 2013-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
26072         [EFL] Build break using jhbuild on ubuntu 13.04
26073         https://bugs.webkit.org/show_bug.cgi?id=115225
26075         Reviewed by Gyuyoung Kim.
26077         libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
26078         libxml 2.9.0 has a bug to make regression which r138422 mentioned.
26079         So this patch bumped libxml version to 2.9.1.
26081         * efl/jhbuild.modules:
26083 2013-04-26  Jeffrey Pfau  <jpfau@apple.com>
26085         delete-stale-build-files does not clear .d files
26086         http://bugs.webkit.org/show_bug.cgi?id=115293
26088         Reviewed by Ryosuke Niwa.
26090         * BuildSlaveSupport/delete-stale-build-files:
26091         (main): Add .d to the file type list
26093 2013-04-26  Roger Fong  <roger_fong@apple.com>
26095         Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
26096         Make the DebugSuffix configuration use _debug dependencies.
26098         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
26099         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
26100         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
26101         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
26102         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
26103         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
26104         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
26105         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
26106         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
26107         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
26108         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
26109         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
26110         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
26111         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
26112         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
26113         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
26114         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
26115         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
26116         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
26117         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
26118         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
26119         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
26120         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
26121         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
26122         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
26123         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
26124         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
26125         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
26126         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
26127         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
26128         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
26129         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
26130         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
26131         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
26132         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
26133         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
26134         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
26135         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
26136         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
26137         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
26138         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
26139         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
26140         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
26141         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
26142         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
26143         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
26144         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
26145         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
26146         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
26147         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
26148         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
26149         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
26150         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
26151         * win/AssembleBuildLogs/AssembleLogs.cmd:
26152         * win/record-memory/record-memory.vcxproj:
26153         * win/record-memory/record-memoryDebug.props:
26154         * win/record-memory/record-memoryDebugWinCairo.props:
26155         * win/record-memory/record-memoryProduction.props:
26156         * win/record-memory/record-memoryRelease.props:
26157         * win/record-memory/record-memoryReleaseWinCairo.props:
26159 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
26161         [GTK] Clean up the TestWebKitAPI GNUmakefile.am
26162         https://bugs.webkit.org/show_bug.cgi?id=115233
26164         Reviewed by Martin Robinson.
26166         Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
26167         WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
26168         Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
26169         Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
26170         be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
26172         * TestWebKitAPI/GNUmakefile.am:
26174 2013-04-25  Andy Estes  <aestes@apple.com>
26176         [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
26177         https://bugs.webkit.org/show_bug.cgi?id=115223
26179         Reviewed by Darin Adler.
26181         Added an API test.
26183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
26184         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
26185         (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
26186         when it loads a request with a custom protocol.
26187         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
26188         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
26189         NSURLProtocol subclass to TestProtocol.{h, mm} and did some
26190         miscellaneous cleanup.
26191         * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
26192         * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
26193         (+[TestProtocol canInitWithRequest:]):
26194         (+[TestProtocol canonicalRequestForRequest:]):
26195         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
26196         (+[TestProtocol scheme]):
26197         (-[TestProtocol startLoading]):
26198         (-[TestProtocol stopLoading]):
26200 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
26202         Remove the remaining Skia #ifdefs
26203         https://bugs.webkit.org/show_bug.cgi?id=114886
26205         Reviewed by Benjamin Poulain.
26207         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
26208         (createBitmapContextFromWebView): Remove Skia #ifdef references.
26210 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
26212         [BlackBerry] Clean up load interface in WebPage
26213         https://bugs.webkit.org/show_bug.cgi?id=113267
26215         Reviewed by Rob Buis.
26217         Update DumpRenderTree with change of load() interface in WebPage.
26218         RIM Bug# 315535, internally reviewed by Joe Mason.
26220         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
26221         (BlackBerry::WebKit::DumpRenderTree::runTest):
26223 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
26225         Remove the HeapGraphSerializer unit test
26226         https://bugs.webkit.org/show_bug.cgi?id=115231
26228         Reviewed by Andreas Kling.
26230         Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
26231         specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
26233         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
26235 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
26237         Remove support for Chromium from build/update scripts
26238         https://bugs.webkit.org/show_bug.cgi?id=115218
26240         Reviewed by Darin Adler.
26242         * Scripts/build-webkit:
26243         (writeCongrats):
26244         * Scripts/update-webkit:
26246 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
26248         Remove support for Chromium from api-test
26249         https://bugs.webkit.org/show_bug.cgi?id=115211
26251         Reviewed by Dirk Pranke.
26253         * Scripts/build-api-tests:
26254         * Scripts/run-api-tests:
26255         (isSupportedPlatform):
26257 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
26259         Get rid of Chromium in build-dumprendertree
26260         https://bugs.webkit.org/show_bug.cgi?id=115212
26262         Reviewed by Dirk Pranke.
26264         * Scripts/build-dumprendertree:
26266 2013-04-25  Alexey Proskuryakov  <ap@apple.com>
26268         Pass relatedPage when creating a page in WebKitTestRunner
26269         https://bugs.webkit.org/show_bug.cgi?id=115206
26271         Reviewed by Geoffrey Garen.
26273         To make sure that window.open() opens in the same process even when using multiple processes.
26275         * WebKitTestRunner/PlatformWebView.h:
26276         * WebKitTestRunner/TestController.cpp:
26277         (WTR::TestController::createOtherPage):
26278         (WTR::TestController::createWebViewWithOptions):
26279         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
26280         (WTR::PlatformWebView::PlatformWebView):
26281         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
26282         (WTR::PlatformWebView::PlatformWebView):
26283         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
26284         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
26285         (WTR::PlatformWebView::PlatformWebView):
26286         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
26287         (WTR::PlatformWebView::PlatformWebView):
26288         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
26289         (WTR::PlatformWebView::PlatformWebView):
26291 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
26293         Fix autocompletion for Benjamin. The Bugzilla email address must come first.
26295         * Scripts/webkitpy/common/config/contributors.json:
26297 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
26299         Build fix. Forgot to merge args.
26301         * Scripts/webkitpy/tool/bot/irc_command.py:
26302         (Hi.execute):
26304 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
26306         webkitbot should recognize its own nickname in greetings.
26307         https://bugs.webkit.org/show_bug.cgi?id=115196
26309         Reviewed by Andreas Kling.
26311         Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
26313         * Scripts/webkitpy/tool/bot/irc_command.py:
26314         (Hi.execute):
26316 2013-04-25  Xavier Castano  <xcastanho@igalia.com>
26318         [GTK] Tools/gtk/install-dependencies added ragel dependency
26319         https://bugs.webkit.org/show_bug.cgi?id=115163
26321         Reviewed by Xan Lopez.
26323         The install-dependencies script was missing a dependency on ragel
26324         which is expected when building HarfBuzz.
26326         * gtk/install-dependencies: Added a dependency on ragel for both
26327         apt and yum.
26329 2013-04-25  Eduardo Lima Mitev  <elima@igalia.com>
26331         [GTK] Remove pango from optional jhbuild dependencies
26332         https://bugs.webkit.org/show_bug.cgi?id=115162
26334         Reviewed by Martin Robinson.
26336         Pango is not needed since revision r148293 that lowers the pango
26337         dependency to 1.30, which is available in most distributions.
26339         * gtk/jhbuild-optional.modules: Removes description of pango module.
26341 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
26343         Remove Chromium-specific cases from FeatureList.pm
26344         https://bugs.webkit.org/show_bug.cgi?id=115169
26346         Reviewed by Andreas Kling.
26348         * Scripts/webkitperl/FeatureList.pm:
26350 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
26352         Remove checking chromium from run-webkit-tests
26353         https://bugs.webkit.org/show_bug.cgi?id=115139
26355         Reviewed by Benjamin Poulain.
26357         * Scripts/run-webkit-tests:
26358         (useNewRunWebKitTests):
26360 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
26362         Pixel tests in SVG are all broken in WK2
26363         https://bugs.webkit.org/show_bug.cgi?id=114218
26365         Reviewed by Darin Adler.
26366         
26367         Window snapshots in WebKitTestRunner on Mac are window-sized
26368         (800x600), which is wrong for the W3C SVG tests that require a
26369         480x360 snapshot.
26370         
26371         Fix by resizing the window, as well as the web view in
26372         PlatformWebView::resizeTo() so that window snapshots are correctly
26373         sized.
26374         
26375         Also do some drive-by cleanup of the window size constants in both
26376         DRT and WTR to remove magic numbers, and make the code more similar.
26377         
26378         * DumpRenderTree/TestRunner.cpp:
26379         (TestRunner::setShouldPaintBrokenImage):
26380         * DumpRenderTree/TestRunner.h:
26381         * DumpRenderTree/efl/DumpRenderTree.cpp:
26382         * DumpRenderTree/gtk/DumpRenderTree.cpp:
26383         (webInspectorShowWindow):
26384         * DumpRenderTree/mac/DumpRenderTree.mm:
26385         (createWebViewAndOffscreenWindow):
26386         (sizeWebViewForCurrentTest):
26387         * DumpRenderTree/mac/DumpRenderTreeMac.h:
26388         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
26389         (createPagedBitmapContext):
26390         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
26391         (DumpRenderTree::DumpRenderTree):
26392         (DumpRenderTree::open):
26393         * DumpRenderTree/qt/TestRunnerQt.cpp:
26394         * DumpRenderTree/qt/TestRunnerQt.h:
26395         * DumpRenderTree/win/DumpRenderTree.cpp:
26396         (sizeWebViewForCurrentTest):
26397         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
26398         * WebKitTestRunner/TestController.cpp:
26399         (WTR::TestController::resetStateToConsistentValues):
26400         * WebKitTestRunner/TestController.h:
26401         * WebKitTestRunner/TestInvocation.cpp:
26402         (WTR::sizeWebViewForCurrentTest):
26403         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
26404         (WTR::PlatformWebView::PlatformWebView):
26405         (WTR::PlatformWebView::resizeTo):
26407 2013-04-24  Byungwoo Lee  <bw80.lee@samsung.com>
26409         [EFL] Fix build error after r148963.
26410         https://bugs.webkit.org/show_bug.cgi?id=115126
26412         Reviewed by Laszlo Gombos.
26414         Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
26416         * TestWebKitAPI/PlatformEfl.cmake:
26418 2013-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
26420         [GTK] Use stamp files for generate-forwarding-headers makefile rules
26421         https://bugs.webkit.org/show_bug.cgi?id=115118
26423         Reviewed by Martin Robinson.
26425         Use a stamp file for the TestWebKitAPI and WebKitTestRunner
26426         forwarding generator rules and don't call it for soup since there
26427         aren't soup directories in TestWebKitAPI and WebKitTestRunner.
26429         * TestWebKitAPI/GNUmakefile.am:
26430         * WebKitTestRunner/GNUmakefile.am:
26432 2013-04-24  Simon Pena  <simon.pena@samsung.com>
26434         [GTK] Update build dependencies
26435         https://bugs.webkit.org/show_bug.cgi?id=115111
26437         Reviewed by Martin Robinson.
26439         The install-dependencies script was missing a dependency on EGL,
26440         which is expected when building Cairo.
26442         * gtk/install-dependencies: Added a dependency on libegl1-mesa
26443         for both apt and yum.
26445 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
26447         Remove the Chromium-specific helper from run_webkit_tests.py
26448         https://bugs.webkit.org/show_bug.cgi?id=114996
26450         Reviewed by Dirk Pranke.
26452         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
26453         (parse_args):
26455 2013-04-24  Sergio Correia  <sergio.correia@openbossa.org>
26457         [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
26458         https://bugs.webkit.org/show_bug.cgi?id=114850
26460         Reviewed by Andreas Kling.
26462         Revision r148312 fixed WebPageProxy cleanup and also changed the process
26463         termination semantics when requested by the user so that a client is not
26464         notified of a crash anymore, since there was no crash anyway.
26466         That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
26467         relied on being notified of a crash after calling WKPageTerminate(). As
26468         a result of not being notified of such non-existent crash, the test would
26469         timeout right after making the terminate call.
26471         This patch adds an InjectedBundle to be used for simulating a crash, by
26472         calling abort() upon receiving a "Crash" message, and thus we are able to
26473         keep testing the crash callback.
26475         This patch also re-enables the WKViewClientWebProcessCallbacks test, which
26476         had been disabled in revisions r148858 and r148855, since it was failing.
26478         * TestWebKitAPI/PlatformEfl.cmake:
26479         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
26480         (TestWebKitAPI::TEST):
26481         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
26482         (TestWebKitAPI):
26483         (WKViewClientWebProcessCallbacksTest):
26484         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
26485         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
26487 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
26489         [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
26490         https://bugs.webkit.org/show_bug.cgi?id=115095
26492         Reviewed by Antonio Gomes.
26494         Use different subfolders under DumpRenderTree Temp folder for every
26495         functionality (icon database, cache, localstorage, ...). This makes
26496         sure there is no conflict between the functionalities.
26498         In EFL's case, libsoup cache was causing problems for the icon
26499         database if sharing the same folder.
26501         * WebKitTestRunner/TestController.cpp:
26502         (WTR::TestController::initialize):
26504 == Rolled over to ChangeLog-2013-04-24 ==