1 2009-07-02 Brent Fulgham <bfulgham@webkit.org>
3 Windows build fix, no review.
6 Reverting PixelDumpSupportWin.cpp change to avoid strange
7 error on the build-bot.
9 * DumpRenderTree/win/PixelDumpSupportWin.cpp:
10 (createBitmapContextFromWebView):
12 2009-07-02 Brent Fulgham <bfulgham@webkit.org>
16 * DumpRenderTree/config.h:
18 2009-07-02 Eric Seidel <eric@webkit.org>
20 Reviewed by David Levin.
22 bugzilla-tool needs to handle login failure
23 https://bugs.webkit.org/show_bug.cgi?id=26913
25 We now exit(1) on login failure.
27 * Scripts/modules/bugzilla.py:
29 2009-06-30 Brent Fulgham <bfulgham@webkit.org>
31 Reviewed by Adam Roben.
33 Add build support for a Windows Cairo version of
34 DumpRenderTree. Share as much logic between the
35 CG and Cairo builds as possible.
36 https://bugs.webkit.org/show_bug.cgi?id=26457
38 * DumpRenderTree/PixelDumpSupport.cpp: Added.
39 (dumpWebViewAsPixelsAndCompareWithExpected): Moved common logic
40 from CG-specific file.
41 (printPNG): Moved common logic from CG-specific file.
42 * DumpRenderTree/PixelDumpSupport.h: Add declaration for new
43 common printPNG function.
44 * DumpRenderTree/cairo: Added.
45 * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Added.
46 Implement cairo-specific logic for dealing with Cairo surfaces.
48 (printPNG): Cairo-specific PNG handling logic.
49 (computeMD5HashStringForBitmapContext): New Cairo routine using
50 the generic BitmapContext signature.
51 (dumpBitmap): New function containing Cairo-specific portions of
53 * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Added.
54 Provide Cairo version of the BitmapContext structure so that
55 dumping routines can work on an abstract type.
56 (BitmapContext::createByAdoptingBitmapAndContext):
57 (BitmapContext::~BitmapContext):
58 (BitmapContext::cairoContext):
59 (BitmapContext::BitmapContext):
60 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
61 (printPNG): CG-specific PNG handling logic.
62 (computeMD5HashStringForBitmapContext): Revised to use generic
63 BitmapContext signature.
64 (dumpBitmap): New function containing CG-specific portions of
66 * DumpRenderTree/cg/PixelDumpSupportCG.h: Add new signatures.
67 * DumpRenderTree/win/DumpRenderTree.cpp: Disable CFNetwork logic
68 when building the non-CFNetwork version.
70 * DumpRenderTree/win/DumpRenderTree.vcproj:
71 * DumpRenderTree/win/PixelDumpSupportWin.cpp:
72 (createBitmapContextFromWebView): Provide parallel Cairo implementation
73 of CG bitmap/context setup.
75 2009-07-02 Eric Seidel <eric@webkit.org>
77 No review, just adding Antti as a reviewer.
79 * Scripts/modules/bugzilla.py:
81 2009-07-02 Antonio Gomes <antonio.gomes@openbossa.org>
83 Reviewed by Simon Hausmann.
85 https://bugs.webkit.org/show_bug.cgi?id=26896
87 [Qt] Set DRT's default fontsize to 13.
89 * DumpRenderTree/qt/DumpRenderTree.cpp:
90 (WebCore::WebPage::WebPage):
92 2009-07-01 Eric Seidel <eric@webkit.org>
94 Reviewed by Adam Barth.
96 bugzilla-tool fails for SVN users
97 https://bugs.webkit.org/show_bug.cgi?id=26914
99 To fix this I moved svn from -F - to using -m
100 In order for -m to work I had to move us off of shell=True
101 To move off of shell=True all call sites for run_command
102 which take args, need to pass their args as an list instead of a string.
104 In order for the final bug update to work correctly, I had to
105 abstract the way that we parse out revision numbers from the commit text.
107 * Scripts/bugzilla-tool:
108 * Scripts/modules/scm.py:
110 2009-07-01 Eric Seidel <eric@webkit.org>
112 Reviewed by Maciej Stachowiak.
114 prepare-ChangeLog should have a --bug= argument and use it for url autofill
115 https://bugs.webkit.org/show_bug.cgi?id=26383
117 prepare-ChangeLog now knows how to grab the bug title from bugs.webkit.org
118 I also added a bit more template text in an effort to get better ChangeLogs
119 from casual contributers.
121 * Scripts/prepare-ChangeLog:
123 2009-07-01 Eric Seidel <eric@webkit.org>
125 Reviewed by Adam Roben.
127 prepare-ChangeLog should fail when EMAIL_ADDRESS or REAL_NAME are missing:
128 https://bugs.webkit.org/show_bug.cgi?id=26692
130 I also made prepare-ChangeLog sanity-check names and email addresses a little.
131 Names must contain a space, and email addresses must contain '@'
133 Also "fixed" $email_address to $emailAddress. This script uses mixed variable name styles.
135 * Scripts/prepare-ChangeLog:
137 2009-07-01 Chris Fleizach <cfleizach@apple.com>
139 Reviewed by Beth Dakin.
141 Bug 26900: AX: Manual spell check with Command-; does not bring up suggestions
142 https://bugs.webkit.org/show_bug.cgi?id=26900
144 Expose the ability to get the click point of an element through accessibility.
146 * DumpRenderTree/AccessibilityUIElement.cpp:
147 (getClickPointXCallback):
148 (getClickPointYCallback):
149 (AccessibilityUIElement::getJSClass):
150 * DumpRenderTree/AccessibilityUIElement.h:
151 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
152 (AccessibilityUIElement::clickPointX):
153 (AccessibilityUIElement::clickPointY):
154 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
155 (AccessibilityUIElement::clickPointX):
156 (AccessibilityUIElement::clickPointY):
158 2009-07-01 Mark Rowe <mrowe@apple.com>
160 Reviewed by Simon Fraser.
162 Change how WebKitNightlyEnabler.dylib lies about Safari's identity to LaunchServices.
163 This makes WebKit.app behave as expected when set as the default web browser on a wider
164 range of OS versions.
166 * WebKitLauncher/WebKitNightlyEnabler.m:
168 (enableWebKitNightlyBehaviour):
170 2009-07-01 Mark Rowe <mrowe@apple.com>
172 Reviewed by Simon Fraser.
174 Shuffle some code around in preparation for a change to how poseAsWebKitApp works.
176 * WebKitLauncher/WebKitNightlyEnabler.m:
178 (webKitLauncherBundle):
179 (insideSafari4OnTigerTrampoline):
181 2009-06-30 Xan Lopez <xlopez@igalia.com>
183 Reviewed by Jan Alonzo.
185 https://bugs.webkit.org/show_bug.cgi?id=26877
186 [GTK] DRT fixes to pass new plugin test
188 Silence compiler warnings.
190 Newer GCC don't like using or returning a static string where a
191 'char*' is expected. Ideally we'd change the function signatures
192 to return or take 'const char*' I suppose, but since we can't do
193 that just cast the strings to 'char*'.
195 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
196 (webkit_test_plugin_get_value):
198 2009-06-30 Xan Lopez <xlopez@igalia.com>
200 Reviewed by Jan Alonzo.
202 https://bugs.webkit.org/show_bug.cgi?id=26877
203 [GTK] DRT fixes to pass new plugin test
205 Use the common pluginLog function instead of a local copy.
207 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
208 (webkit_test_plugin_new_instance):
209 (webkit_test_plugin_destroy_instance):
210 (webkit_test_plugin_set_window):
211 (webkit_test_plugin_handle_event):
213 2009-06-30 Xan Lopez <xlopez@igalia.com>
215 Reviewed by Jan Alonzo.
217 https://bugs.webkit.org/show_bug.cgi?id=26877
218 [GTK] DRT fixes to pass new plugin test
220 Modify our DRT as done in bug #15457 to log logSrc as src in order
221 to pass test plugins/netscape-plugin-map-data-to-src.html.
223 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
224 (webkit_test_plugin_new_instance):
226 2009-06-30 Adrien Nader <camaradetux@gmail.com>
228 Reviewed by Jan Alonzo.
230 [GTK] GtkLauncher depends on gtk+2-2.15 because of gtk_orientable_set_orientation()
231 https://bugs.webkit.org/show_bug.cgi?id=26835
233 * GtkLauncher/main.c:
236 2009-06-30 Eric Seidel <eric@webkit.org>
238 Typo fix only, no review.
240 Fix typo causing failure during land-diff
242 * Scripts/bugzilla-tool:
244 2009-06-30 Simon Fraser <simon.fraser@apple.com>
246 Reviewed by Dan Bernstein.
248 Fix drawing of view background in pixel snapshots when using compositing.
249 We still need to call -displayIfNeeded to ensure that the NSView drawing
252 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
253 (createBitmapContextFromWebView):
255 2009-06-30 Simon Fraser <simon.fraser@apple.com>
257 Reviewed by Mark Rowe.
259 createBitmapContextFromWebView() incorrectly used #ifdef BUILDING_ON_LEOPARD,
260 and thus failed on SnowLeopard.
262 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
263 (createBitmapContextFromWebView):
265 2009-06-30 Eric Seidel <eric@webkit.org>
267 Reviewed by Nikolas Zimmermann.
269 Make bugzilla tool print a message explaining how to get help on failure:
270 https://bugs.webkit.org/show_bug.cgi?id=26861
273 Usage: bugzilla-tool [options] command [command-options] [command-arguments]
275 bugzilla-tool: error: No command specified
277 Type 'bugzilla-tool --help' to see usage.
279 * Scripts/bugzilla-tool:
281 2009-06-30 Eric Seidel <eric@webkit.org>
283 Reviewed by Maciej Stachowiak.
285 Include a built copy of BeautifulSoup 3.1.0.1 so that
286 bugzilla-tool users do not need to install it manually.
287 https://bugs.webkit.org/show_bug.cgi?id=26833
289 BeautifulSoup is BSD-licensed (thus WebKit compatible) and available from:
290 http://www.crummy.com/software/BeautifulSoup
292 * Scripts/bugzilla-tool: fixed a typo in a log message.
293 * Scripts/modules/BeautifulSoup.py: Added.
294 * Scripts/modules/bugzilla.py:
296 2009-06-30 Eric Seidel <eric@webkit.org>
298 Reviewed by Simon Hausmann.
300 Fix our create_patch handling to not
301 hang when creating large patches.
302 https://bugs.webkit.org/show_bug.cgi?id=26834
304 We're now using StringIO to make an in-memory buffer for the patch
305 instead of piping from the patch command directly to the upload.
306 The previous hang was caused by calling wait() when the process had already
307 filed the stdout buffer.
309 * Scripts/modules/scm.py:
311 2009-06-29 Sam Weinig <sam@webkit.org>
313 Reviewed by Mark Rowe.
315 Remove more unused scons support.
318 * Scripts/build-webkit:
319 * Scripts/webkitdirs.pm:
321 2009-06-26 Eric Seidel <eric@webkit.org>
323 Reviewed by David Levin.
325 Rename land-and-update to land-diff and make it awesome.
326 https://bugs.webkit.org/show_bug.cgi?id=26734
328 Renamed land-and-update to land-diff
329 Made the BUGID argument optional.
330 Added optional support for building and testing before landing.
332 land-diff [options] [BUGID] Lands the current working directory diff and updates the bug if provided.
334 -r REVIEWER, --reviewer=REVIEWER
335 Update ChangeLogs to say Reviewed by REVIEWER.
336 --no-close Leave bug open after landing.
337 --no-build Commit without building first, implies --no-test.
338 --no-test Commit without running run-webkit-tests.
340 * Scripts/bugzilla-tool:
342 2009-06-28 Jan Michael Alonzo <jmalonzo@webkit.org>
344 Gtk build fix - include stdarg.h for va_start/va_end.
346 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
348 2009-06-28 John Abd-El-Malek <jam@chromium.org>
350 https://bugs.webkit.org/show_bug.cgi?id=15457
352 Modify NPAPI test plugin to verify that "src" paramater is added when
353 it's missing but "data" is present.
355 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
357 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
358 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
364 * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
367 2009-06-27 Emilio Pozuelo Monfort <pochu27@gmail.com>
369 Reviewed by Jan Alonzo.
371 [GTK] Don't use deprecated GTK+ symbols.
372 https://bugs.webkit.org/show_bug.cgi?id=26583
374 * GtkLauncher/main.c:
377 2009-06-26 Adam Barth <abarth@webkit.org>
379 Reviewed by Eric Seidel.
381 Make SVN work (again?).
383 * Scripts/modules/scm.py:
385 2009-06-26 Chris Fleizach <cfleizach@apple.com>
387 Reviewed by Oliver Hunt.
389 Add ability to query isEnabled
391 * DumpRenderTree/AccessibilityUIElement.cpp:
392 (getIsEnabledCallback):
393 (AccessibilityUIElement::getJSClass):
394 * DumpRenderTree/AccessibilityUIElement.h:
395 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
396 (AccessibilityUIElement::isEnabled):
397 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
398 (AccessibilityUIElement::isEnabled):
400 2009-06-26 Brady Eidson <beidson@apple.com>
402 Reviewed by Sam Weinig
404 <rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails
406 Add a dumpResourceResponseMIMETypes() mode so the ResourceLoadDelegate will dump the mime type from
407 the NSURLResponse. Needed for the test for this bug fix.
409 * DumpRenderTree/LayoutTestController.cpp:
410 (LayoutTestController::LayoutTestController):
411 (dumpResourceResponseMIMETypesCallback):
412 (LayoutTestController::staticFunctions):
413 * DumpRenderTree/LayoutTestController.h:
414 (LayoutTestController::dumpResourceResponseMIMETypes):
415 (LayoutTestController::setDumpResourceResponseMIMETypes):
417 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
418 (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
420 2009-06-26 David Kilzer <ddkilzer@apple.com>
422 Update build-dumprendertree to use buildXCodeProject()
424 Reviewed by Adam Roben.
426 * Scripts/build-dumprendertree: Updated to use
427 buildXCodeProject() when building for isAppleMacWebKit(). This
428 provides additional command-line switch parsing for free. Also
429 added --clean and --help switches. Updated copyright.
431 2009-06-26 Eric Seidel <eric@webkit.org>
433 Reviewed by Tor Arne Vestbø.
435 Remove non-sense --update option to land-patches
436 and make land-patches update before every patch application.
437 This makes it slightly less likely that multi-patch landings will fail.
439 Also updated git diff command to include staged modifications.
441 * Scripts/bugzilla-tool:
442 * Scripts/modules/scm.py:
444 2009-06-25 Eric Seidel <eric@webkit.org>
446 Reviewed by Jan Alonzo.
448 Fix obsolete_attachment to work when passed a comment.
449 https://bugs.webkit.org/show_bug.cgi?id=26745
451 * Scripts/modules/bugzilla.py:
453 2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>
455 Reviewed by Mark Rowe.
457 bugzilla-tool apply-patch throws exception in Linux
458 https://bugs.webkit.org/show_bug.cgi?id=26738
460 HEAD is case-sensitive in Linux. Convert uses of head to HEAD in
463 * Scripts/modules/scm.py:
465 2009-06-25 Eric Seidel <eric@webkit.org>
467 Reviewed by Jan Alonzo.
469 bugzilla-tool post-diff needs to obsolete old patches before posting
470 https://bugs.webkit.org/show_bug.cgi?id=26740
472 I've also added a --no-obsolete to disable this behavior.
474 I also finally updated the bug page parsing to use XML. So much less code!
476 * Scripts/bugzilla-tool:
477 * Scripts/modules/bugzilla.py:
479 2009-06-25 Eric Seidel <eric@webkit.org>
481 Reviewed by Mark Rowe.
483 Call WebKitTools/Scripts scripts by their absolute paths
484 https://bugs.webkit.org/show_bug.cgi?id=26704
486 bugzilla-tool used to use whatever build-webkit was in your path.
487 That could end up building the wrong copy of WebKit.
489 * Scripts/bugzilla-tool:
490 * Scripts/modules/scm.py:
492 2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
494 Reviewed by Dave Levin.
496 Use unicode() instead of str when reading from bugzilla.
497 Also add Simon Fraser as a reviewer.
498 https://bugs.webkit.org/show_bug.cgi?id=26719
500 * Scripts/modules/bugzilla.py:
502 2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
504 Reviewed by Simon Hausmann.
506 Use Q_ASSERT in Qt's DumpRenderTree instead of JSC's ASSERT
508 The WTFReportAssertionFailure function in JSC is not exported when
509 building QtWebKit in both debug and release on Mac, so DRT fails to
512 We can revert this patch once the Qt port builds JSC as a separate
513 library, and we add the proper export macros to Assertions.cpp
515 * DumpRenderTree/qt/WorkQueue.cpp:
517 (WorkQueue::dequeue):
519 2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
521 Reviewed by Jan Alonzo.
523 bugzilla-tool: Add Simon Hausmann as reviewer
525 * Scripts/modules/bugzilla.py:
527 2009-06-24 Eric Seidel <eric@webkit.org>
529 Reviewed by Dave Levin.
531 Support local commits during apply-patches
532 and let land-patches take multiple bug ids.
533 https://bugs.webkit.org/show_bug.cgi?id=26703
535 I also restructured parts of land-patches into
536 class methods and static methods in preparation
537 for future code sharing with other commands.
539 * Scripts/bugzilla-tool:
540 * Scripts/modules/bugzilla.py:
541 * Scripts/modules/scm.py:
543 2009-06-25 Eric Seidel <eric@webkit.org>
545 Reviewed by Tor Arne Vestbø.
547 Make svn-apply work with Git too
548 https://bugs.webkit.org/show_bug.cgi?id=26299
550 Add an --force option to svn-apply and otherwise make svn-apply
551 exit non-zero when patch application fails.
552 https://bugs.webkit.org/show_bug.cgi?id=26300
554 I did not update svn-unapply, because it makes no sense in a Git world.
555 You don't roll in and out patch files. You make commits and deal with those.
556 Git users can just git reset --hard to get the same functionality.
560 2009-06-25 Eric Seidel <eric@webkit.org>
562 Reviewed by Tor Arne Vestbø.
564 Remove use of os.system to fix reviewers with unicode chars in their names
565 https://bugs.webkit.org/show_bug.cgi?id=26713
567 Also change to latin1 encoding of ø to make python happy.
569 * Scripts/modules/bugzilla.py:
570 * Scripts/modules/scm.py:
572 2009-06-25 Eric Seidel <eric@webkit.org>
574 Reviewed by Tor Arne Vestbø.
576 Add Adam Roben and Tor Arne Vestbø to the reviewers list.
578 * Scripts/modules/bugzilla.py:
580 2009-06-24 Chris Fleizach <cfleizach@apple.com>
584 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
585 (AccessibilityUIElement::language):
587 2009-06-24 Chris Fleizach <cfleizach@apple.com>
589 Reviewed by Oliver Hunt.
591 Bug 26668: AX: need a way to retrieve the language for an element
592 Support ability to retrieve AXLanguage for testing
594 * DumpRenderTree/AccessibilityUIElement.cpp:
595 (getLanguageCallback):
596 (AccessibilityUIElement::getJSClass):
597 * DumpRenderTree/AccessibilityUIElement.h:
598 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
599 (AccessibilityUIElement::language):
601 2009-06-24 Eric Seidel <eric@webkit.org>
603 Reviewed by Maciej Stachowiak.
605 Spell Maciej's name right and add Brady Eidson.
607 * Scripts/modules/bugzilla.py:
609 2009-06-23 Eric Seidel <eric@webkit.org>
611 Reviewed by Dave Levin.
613 Fix missing comment message during land-patches and SVN.commit_with_message respecting --dry-run
614 https://bugs.webkit.org/show_bug.cgi?id=26669
616 * Scripts/bugzilla-tool:
617 * Scripts/modules/scm.py:
619 2009-06-23 Takeshi Yoshino <tyoshino@google.com>
621 Reviewed by Mark Rowe.
623 Bug 26537: Builds from command-line fail if custom build product directory is set and ~/Library/Preferences/xcodebuild.plist exists
624 https://bugs.webkit.org/show_bug.cgi?id=26537
626 Let determineBaseProductDir subroutine remove
627 ~/Library/Preferences/xcodebuild.plist. It can prevent xcodebuild from
628 respecting global settings such as a custom build products directory
629 (<rdar://problem/5585899>).
631 * Scripts/webkitdirs.pm:
633 2009-06-23 Eric Seidel <eric@webkit.org>
635 Reviewed by Dave Levin.
637 Make SCM.run_command smarter, and make all previous
638 os.system and subprocess.popen use SCM.run_command instead.
639 https://bugs.webkit.org/show_bug.cgi?id=26666
641 This makes it easier to handle errors in a standard way throughout all the code.
642 Since this new code raises by default when the exit_code != 0,
643 we should prevent future problems of bugzilla-tool continuing after
644 a git or svn command failed.
646 * Scripts/modules/scm.py:
648 2009-06-23 Joe Mason <joe.mason@torchmobile.com>
650 Reviewed by Adam Treat.
652 https://bugs.webkit.org/show_bug.cgi?id=26664
653 * Scripts/prepare-ChangeLog: Added --git-index mode to list only the
654 changes which are already staged in the index. Useful to create an
655 entry for what you're about to commit while ignoring unstaged changes.
657 2009-06-23 Anders Carlsson <andersca@apple.com>
659 Reviewed by Darin Adler.
661 Update for WebKit changes.
663 * DumpRenderTree/win/UIDelegate.h:
664 (UIDelegate::willPerformDragSourceAction):
666 2009-06-23 Eric Seidel <eric@webkit.org>
668 Reviewed by Mark Rowe.
670 * Scripts/modules/scm.py: Fix commit_with_message to return the commit output.
672 2009-06-23 Eric Seidel <eric@webkit.org>
674 Reviewed by Mark Rowe.
676 * Scripts/modules/scm.py: Fix error seen when commiting r44979.
678 2009-06-18 Eric Seidel <eric@webkit.org>
680 Reviewed by Dave Levin.
682 WebKit needs a script to interact with bugzilla and automate
683 parts of the patch posting and commit processes.
684 https://bugs.webkit.org/show_bug.cgi?id=26283
686 This is really a first-draft tool.
687 It's to the point where it's useful to more people than just me now though.
688 Git support works. SVN support is written, but mostly untested.
690 This tool requires BeautifulSoup and mechanize python modules to run:
691 sudo easy_install BeautifulSoup
692 sudo easy_install mechanize
694 More important than the tool itself are the Bugzilla, Git and SVN class abstractions
695 which I hope will allow easy writing of future tools.
697 The tool currently implements 10 commands, described below.
699 Helpers for scripting dealing with the commit queue:
700 bugs-to-commit Bugs in the commit queue
701 patches-to-commit Patches attached to bugs in the commit queue
703 Dealing with bugzilla:
704 reviewed-patches BUGID r+'d patches on a bug
705 apply-patches BUGID Applies all patches on a bug to the local working directory without committing.
706 land-and-update BUGID Lands the current working directory diff and updates the bug.
707 land-patches [options] BUGID Lands all patches on a bug optionally testing them first
708 obsolete-attachments BUGID Marks all attachments on a bug as obsolete.
709 commit-message Prints a commit message suitable for the uncommitted changes.
711 These effectively replace git-send-bugzilla:
712 post-diff BUGID Attaches the current working directory diff to a bug as a patch file.
713 post-commits BUGID COMMITISH Attaches a range of local commits to a bug as patch files.
715 post-diff works for SVN and Git, post-commits only works for SCMs with local-commit support (like Git)
717 land-* commands in a Git environment only work with simple patches due to svn-apply bugs:
718 https://bugs.webkit.org/show_bug.cgi?id=26299
719 https://bugs.webkit.org/show_bug.cgi?id=26300
721 This script follows python style (similar to how for Obj-C we follow AppKit style)
722 http://www.python.org/doc/essays/styleguide.html
723 The Python community has a strong style culture and the WebKit style guide is silent re: Python.
725 I've filed a bug to update the WebKit style guide to mention python:
726 https://bugs.webkit.org/show_bug.cgi?id=26524
728 * Scripts/bugzilla-tool: Added.
730 2009-06-22 Steve Falkenburg <sfalken@apple.com>
732 Remove errant line of code mistakenly checked in.
734 * DumpRenderTree/win/DumpRenderTree.cpp:
737 2009-06-22 Steve Falkenburg <sfalken@apple.com>
739 Pass correct value to setShouldPaintNativeControls.
741 Rubber stamped by Mark Rowe.
743 * DumpRenderTree/win/DumpRenderTree.cpp:
746 2009-06-22 Steve Falkenburg <sfalken@apple.com>
748 Fix last DumpRenderTree change to correctly set preferences flag without crashing.
750 Reviewed by Mark Rowe.
752 * DumpRenderTree/win/DumpRenderTree.cpp:
755 2009-06-21 Steve Falkenburg <sfalken@apple.com>
757 Set up global native controls flag before creating the first WebView.
759 Reviewed by Darin Adler.
761 * DumpRenderTree/win/DumpRenderTree.cpp:
764 2009-06-21 Mark Rowe <mrowe@apple.com>
766 Reviewed by Sam Weinig.
768 Set a sensible user agent string for the HTTP requests that Sparkle makes (checking for and downloading updates).
770 * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
771 (userAgentStringForSparkle):
774 2009-06-21 Mark Rowe <mrowe@apple.com>
776 Reviewed by Sam Weinig.
778 Add a hook to the WebKit launcher application to allow a link on the nightly build start page to
779 trigger an update via the built-in software update mechanism.
781 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
782 * WebKitLauncher/WebKitLauncherURLProtocol.h: Added.
783 * WebKitLauncher/WebKitLauncherURLProtocol.m: Added.
784 (+[WebKitLauncherURLProtocol load]):
785 (+[WebKitLauncherURLProtocol canInitWithRequest:]): Only allow use of the x-webkit-launcher scheme from .webkit.org subdomains.
786 (+[WebKitLauncherURLProtocol canonicalRequestForRequest:]):
787 (-[WebKitLauncherURLProtocol startLoading]):
788 (-[WebKitLauncherURLProtocol stopLoading]):
789 (-[WebKitLauncherURLProtocol handleIsWebKitLauncherAvailableJS]): Return a brief JavaScript snippet that can be used to programatically
790 determine whether the x-webkit-launcher is available and working.
791 (-[WebKitLauncherURLProtocol handleCheckForUpdates]): Trigger a software update on the main thread.
792 (-[WebKitLauncherURLProtocol resourceNotFound]): Fail with a generic "File does not exist" error.
794 2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
796 Reviewed by Gustavo Noronha and Xan Lopez.
798 [Gtk] Implement DRT XSS auditor support
799 https://bugs.webkit.org/show_bug.cgi?id=26571
801 * DumpRenderTree/gtk/DumpRenderTree.cpp:
802 (resetWebViewToConsistentStateBeforeTesting):
803 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
804 (LayoutTestController::setXSSAuditorEnabled):
806 2009-06-19 Darin Adler <darin@apple.com>
808 * Scripts/do-webcore-rename: More renaming ideas.
810 2009-06-15 Andre Pedralho <andre.pedralho@openbossa.org>
812 Reviewed by Tor Arne Vestbø.
814 Only pass --makeargs along if an argument is given.
816 * Scripts/build-webkit:
818 2009-06-19 Adam Barth <abarth@webkit.org>
820 Unreviewed attempt to fix Windows build.
822 * DumpRenderTree/win/DumpRenderTree.cpp:
823 (resetWebViewToConsistentStateBeforeTesting):
824 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
825 (LayoutTestController::setXSSAuditorEnabled):
827 2009-06-18 Adam Barth <abarth@webkit.org>
829 Reviewed by Sam Weinig.
831 https://bugs.webkit.org/show_bug.cgi?id=26199
833 Add support for testing the XSSAuditor.
835 * DumpRenderTree/LayoutTestController.cpp:
836 (setXSSAuditorEnabledCallback):
837 (LayoutTestController::staticFunctions):
838 * DumpRenderTree/LayoutTestController.h:
839 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
840 (LayoutTestController::setXSSAuditorEnabled):
841 * DumpRenderTree/mac/DumpRenderTree.mm:
842 (resetWebViewToConsistentStateBeforeTesting):
843 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
844 (LayoutTestController::setXSSAuditorEnabled):
845 * DumpRenderTree/win/DumpRenderTree.cpp:
846 (resetWebViewToConsistentStateBeforeTesting):
847 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
848 (LayoutTestController::setXSSAuditorEnabled):
849 (LayoutTestController::setPopupBlockingEnabled):
850 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
851 (LayoutTestController::setXSSAuditorEnabled):
853 2009-06-18 Darin Adler <darin@apple.com>
855 Rubber stamped by Mark Rowe.
857 * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
858 (-[DumpRenderTreeWindow close]): Resolved crashes seen during regression
859 tests. The close method can be called on a window that's already closed
860 so we can't assert here.
862 2009-06-17 Steve Falkenburg <sfalken@apple.com>
864 Updated for consolidated WebKit COM interfaces.
866 Reviewed by Adam Roben.
868 * DumpRenderTree/win/FrameLoadDelegate.cpp:
869 * DumpRenderTree/win/FrameLoadDelegate.h:
870 * DumpRenderTree/win/UIDelegate.cpp:
871 * DumpRenderTree/win/UIDelegate.h:
872 * WinLauncher/WinLauncher.h:
874 2009-06-16 Adam Barth <abarth@webkit.org>
876 Reviewed by Darin Adler.
878 https://bugs.webkit.org/show_bug.cgi?id=26437
880 Make the commit-log-editor match the ambient line endings in commit
883 * Scripts/commit-log-editor:
885 2009-06-16 Xan Lopez <xlopez@igalia.com>
887 Reviewed by Gustavo Noronha.
889 Update GtkLauncher to recent API changes in the progress property,
890 which now goes from 0.0 to 1.0.
892 * GtkLauncher/main.c:
894 2009-06-16 Adam Barth <abarth@webkit.org>
896 Reviewed by Darin Adler.
898 https://bugs.webkit.org/show_bug.cgi?id=26000
900 Teach prepare-ChangeLog to match the line ends that are already present
901 in ChangeLog files. This helps folks whose use cygwin perl with CR LF
902 line endings on Windows.
904 Also, teach prepare-ChangeLog to normalize backslashes in paths. This
905 helps folks who use Windows SVN prepare correct ChangeLogs.
907 * Scripts/prepare-ChangeLog:
909 == Rolled over to ChangeLog-2009-06-16 ==