src/misc/variables.c

   1 /*****************************************************************************
   2  * variables.c: routines for object variables handling
   3  *****************************************************************************
   4  * Copyright (C) 2002-2009 the VideoLAN team
   5  * $Id$
   6  *
   7  * Authors: Samuel Hocevar <sam@zoy.org>
   8  *
   9  * This program is free software; you can redistribute it and/or modify
  10  * it under the terms of the GNU General Public License as published by
  11  * the Free Software Foundation; either version 2 of the License, or
  12  * (at your option) any later version.
  13  *
  14  * This program is distributed in the hope that it will be useful,
  15  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  16  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  17  * GNU General Public License for more details.
  18  *
  19  * You should have received a copy of the GNU General Public License
  20  * along with this program; if not, write to the Free Software
  21  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  22  *****************************************************************************/
  23
  24 /*****************************************************************************
  25  * Preamble
  26  *****************************************************************************/
  27 #ifdef HAVE_CONFIG_H
  28 # include "config.h"
  29 #endif
  30
  31 #include <vlc_common.h>
  32 #include <vlc_charset.h>
  33 #include "variables.h"
  34
  35 #ifdef HAVE_SEARCH_H
  36 # include <search.h>
  37 #endif
  38
  39 #include "libvlc.h"
  40
  41 #include <assert.h>
  42 #include <math.h>
  43 #include <limits.h>
  44
  45 /*****************************************************************************
  46  * Private types
  47  *****************************************************************************/
  48 struct callback_entry_t
  49 {
  50     vlc_callback_t pf_callback;
  51     void *         p_data;
  52 };
  53
  54 /*****************************************************************************
  55  * Local comparison functions, returns 0 if v == w, < 0 if v < w, > 0 if v > w
  56  *****************************************************************************/
  57 static int CmpBool( vlc_value_t v, vlc_value_t w )
  58 {
  59     return v.b_bool ? w.b_bool ? 0 : 1 : w.b_bool ? -1 : 0;
  60 }
  61
  62 static int CmpInt( vlc_value_t v, vlc_value_t w )
  63 {
  64     return v.i_int == w.i_int ? 0 : v.i_int > w.i_int ? 1 : -1;
  65 }
  66
  67 static int CmpTime( vlc_value_t v, vlc_value_t w )
  68 {
  69     return v.i_time == w.i_time ? 0 : v.i_time > w.i_time ? 1 : -1;
  70 }
  71
  72 static int CmpString( vlc_value_t v, vlc_value_t w )
  73 {
  74     if( !v.psz_string )
  75         return !w.psz_string ? 0 : -1;
  76     else
  77         return !w.psz_string ? 1 : strcmp( v.psz_string, w.psz_string );
  78 }
  79 static int CmpFloat( vlc_value_t v, vlc_value_t w ) { return v.f_float == w.f_float ? 0 : v.f_float > w.f_float ? 1 : -1; }
  80 static int CmpAddress( vlc_value_t v, vlc_value_t w ) { return v.p_address == w.p_address ? 0 : v.p_address > w.p_address ? 1 : -1; }
  81
  82 /*****************************************************************************
  83  * Local duplication functions, and local deallocation functions
  84  *****************************************************************************/
  85 static void DupDummy( vlc_value_t *p_val ) { (void)p_val; /* unused */ }
  86 static void DupString( vlc_value_t *p_val )
  87 {
  88     p_val->psz_string = strdup( p_val->psz_string ? p_val->psz_string :  "" );
  89 }
  90
  91 static void FreeDummy( vlc_value_t *p_val ) { (void)p_val; /* unused */ }
  92 static void FreeString( vlc_value_t *p_val ) { free( p_val->psz_string ); }
  93 static void FreeMutex( vlc_value_t *p_val ) { vlc_mutex_destroy( (vlc_mutex_t*)p_val->p_address ); free( p_val->p_address ); }
  94
  95 static void FreeList( vlc_value_t *p_val )
  96 {
  97     int i;
  98     for( i = 0; i < p_val->p_list->i_count; i++ )
  99     {
 100         switch( p_val->p_list->pi_types[i] & VLC_VAR_CLASS )
 101         {
 102         case VLC_VAR_STRING:
 103             FreeString( &p_val->p_list->p_values[i] );
 104             break;
 105         case VLC_VAR_MUTEX:
 106             FreeMutex( &p_val->p_list->p_values[i] );
 107             break;
 108         default:
 109             break;
 110         }
 111     }
 112
 113     if( p_val->p_list->i_count )
 114     {
 115         free( p_val->p_list->p_values );
 116         free( p_val->p_list->pi_types );
 117     }
 118     free( p_val->p_list );
 119 }
 120
 121 static const struct variable_ops_t
 122 void_ops   = { NULL,       DupDummy,  FreeDummy,  },
 123 addr_ops   = { CmpAddress, DupDummy,  FreeDummy,  },
 124 bool_ops   = { CmpBool,    DupDummy,  FreeDummy,  },
 125 float_ops  = { CmpFloat,   DupDummy,  FreeDummy,  },
 126 int_ops    = { CmpInt,     DupDummy,  FreeDummy,  },
 127 mutex_ops  = { CmpAddress, DupDummy,  FreeMutex,  },
 128 string_ops = { CmpString,  DupString, FreeString, },
 129 time_ops   = { CmpTime,    DupDummy,  FreeDummy,  },
 130 coords_ops = { NULL,       DupDummy,  FreeDummy,  };
 131
 132 /*****************************************************************************
 133  * Local prototypes
 134  *****************************************************************************/
 135 static void     WaitUnused  ( vlc_object_t *, variable_t * );
 136
 137 static void     CheckValue  ( variable_t *, vlc_value_t * );
 138
 139 static int      TriggerCallback( vlc_object_t *, variable_t *, const char *,
 140                                  vlc_value_t );
 141
 142 static int varcmp( const void *a, const void *b )
 143 {
 144     const variable_t *va = a, *vb = b;
 145
 146     /* psz_name must be first */
 147     assert( va == (const void *)&va->psz_name );
 148     return strcmp( va->psz_name, vb->psz_name );
 149 }
 150
 151 static variable_t *Lookup( vlc_object_t *obj, const char *psz_name )
 152 {
 153     vlc_object_internals_t *priv = vlc_internals( obj );
 154     variable_t **pp_var;
 155
 156     vlc_assert_locked( &priv->var_lock );
 157     pp_var = tfind( &psz_name, &priv->var_root, varcmp );
 158     return (pp_var != NULL) ? *pp_var : NULL;
 159 }
 160
 161 static void Destroy( variable_t *p_var )
 162 {
 163     p_var->ops->pf_free( &p_var->val );
 164     if( p_var->choices.i_count )
 165     {
 166         for( int i = 0 ; i < p_var->choices.i_count ; i++ )
 167         {
 168             p_var->ops->pf_free( &p_var->choices.p_values[i] );
 169             free( p_var->choices_text.p_values[i].psz_string );
 170         }
 171         free( p_var->choices.p_values );
 172         free( p_var->choices_text.p_values );
 173     }
 174     free( p_var->psz_name );
 175     free( p_var->psz_text );
 176     free( p_var->p_entries );
 177     free( p_var );
 178 }
 179
 180 #undef var_Create
 181 /**
 182  * Initialize a vlc variable
 183  *
 184  * We hash the given string and insert it into the sorted list. The insertion
 185  * may require slow memory copies, but think about what we gain in the log(n)
 186  * lookup phase when setting/getting the variable value!
 187  *
 188  * \param p_this The object in which to create the variable
 189  * \param psz_name The name of the variable
 190  * \param i_type The variables type. Must be one of \ref var_type combined with
 191  *               zero or more \ref var_flags
 192  */
 193 int var_Create( vlc_object_t *p_this, const char *psz_name, int i_type )
 194 {
 195     assert( p_this );
 196
 197     variable_t *p_var = calloc( 1, sizeof( *p_var ) );
 198     if( p_var == NULL )
 199         return VLC_ENOMEM;
 200
 201     p_var->psz_name = strdup( psz_name );
 202     p_var->psz_text = NULL;
 203
 204     p_var->i_type = i_type & ~VLC_VAR_DOINHERIT;
 205
 206     p_var->i_usage = 1;
 207
 208     p_var->i_default = -1;
 209     p_var->choices.i_count = 0;
 210     p_var->choices.p_values = NULL;
 211     p_var->choices_text.i_count = 0;
 212     p_var->choices_text.p_values = NULL;
 213
 214     p_var->b_incallback = false;
 215     p_var->i_entries = 0;
 216     p_var->p_entries = NULL;
 217
 218     /* Always initialize the variable, even if it is a list variable; this
 219      * will lead to errors if the variable is not initialized, but it will
 220      * not cause crashes in the variable handling. */
 221     switch( i_type & VLC_VAR_CLASS )
 222     {
 223         case VLC_VAR_BOOL:
 224             p_var->ops = &bool_ops;
 225             p_var->val.b_bool = false;
 226             break;
 227         case VLC_VAR_INTEGER:
 228             p_var->ops = &int_ops;
 229             p_var->val.i_int = 0;
 230             break;
 231         case VLC_VAR_STRING:
 232             p_var->ops = &string_ops;
 233             p_var->val.psz_string = NULL;
 234             break;
 235         case VLC_VAR_FLOAT:
 236             p_var->ops = &float_ops;
 237             p_var->val.f_float = 0.0;
 238             break;
 239         case VLC_VAR_TIME:
 240             p_var->ops = &time_ops;
 241             p_var->val.i_time = 0;
 242             break;
 243         case VLC_VAR_COORDS:
 244             p_var->ops = &coords_ops;
 245             p_var->val.coords.x = p_var->val.coords.y = 0;
 246             break;
 247         case VLC_VAR_ADDRESS:
 248             p_var->ops = &addr_ops;
 249             p_var->val.p_address = NULL;
 250             break;
 251         case VLC_VAR_MUTEX:
 252             p_var->ops = &mutex_ops;
 253             p_var->val.p_address = malloc( sizeof(vlc_mutex_t) );
 254             vlc_mutex_init( (vlc_mutex_t*)p_var->val.p_address );
 255             break;
 256         default:
 257             p_var->ops = &void_ops;
 258 #ifndef NDEBUG
 259             if( (i_type & VLC_VAR_CLASS) != VLC_VAR_VOID )
 260                 msg_Err( p_this, "Creating the variable '%s' without a type",
 261                           psz_name );
 262 #endif
 263     }
 264
 265     if( i_type & VLC_VAR_DOINHERIT )
 266     {
 267         if( var_Inherit( p_this, psz_name, i_type, &p_var->val ) )
 268             msg_Err( p_this, "cannot inherit value for %s", psz_name );
 269         else if( i_type & VLC_VAR_HASCHOICE )
 270         {
 271             /* We must add the inherited value to our choice list */
 272             p_var->i_default = 0;
 273
 274             INSERT_ELEM( p_var->choices.p_values, p_var->choices.i_count,
 275                          0, p_var->val );
 276             INSERT_ELEM( p_var->choices_text.p_values,
 277                          p_var->choices_text.i_count, 0, p_var->val );
 278             p_var->ops->pf_dup( &p_var->choices.p_values[0] );
 279             p_var->choices_text.p_values[0].psz_string = NULL;
 280         }
 281     }
 282
 283     vlc_object_internals_t *p_priv = vlc_internals( p_this );
 284     variable_t **pp_var, *p_oldvar;
 285     int ret = VLC_SUCCESS;
 286
 287     vlc_mutex_lock( &p_priv->var_lock );
 288
 289     pp_var = tsearch( p_var, &p_priv->var_root, varcmp );
 290     if( unlikely(pp_var == NULL) )
 291         ret = VLC_ENOMEM;
 292     else if( (p_oldvar = *pp_var) == p_var )
 293         p_var = NULL;
 294     else if( unlikely((i_type ^ p_oldvar->i_type) & VLC_VAR_CLASS) )
 295     {    /* If the types differ, variable creation failed. */
 296          msg_Err( p_this, "Variable '%s' (0x%04x) already exist "
 297                   "but with a different type (0x%04x)",
 298                   psz_name, p_oldvar->i_type, i_type );
 299          ret = VLC_EBADVAR;
 300     }
 301     else
 302     {
 303         p_oldvar->i_usage++;
 304         p_oldvar->i_type |= i_type & (VLC_VAR_ISCOMMAND|VLC_VAR_HASCHOICE);
 305     }
 306     vlc_mutex_unlock( &p_priv->var_lock );
 307
 308     /* If we did not need to create a new variable, free everything... */
 309     if( p_var != NULL )
 310         Destroy( p_var );
 311     return ret;
 312 }
 313
 314 #undef var_Destroy
 315 /**
 316  * Destroy a vlc variable
 317  *
 318  * Look for the variable and destroy it if it is found. As in var_Create we
 319  * do a call to memmove() but we have performance counterparts elsewhere.
 320  *
 321  * \param p_this The object that holds the variable
 322  * \param psz_name The name of the variable
 323  */
 324 int var_Destroy( vlc_object_t *p_this, const char *psz_name )
 325 {
 326     variable_t *p_var;
 327
 328     assert( p_this );
 329
 330     vlc_object_internals_t *p_priv = vlc_internals( p_this );
 331
 332     vlc_mutex_lock( &p_priv->var_lock );
 333
 334     p_var = Lookup( p_this, psz_name );
 335     if( p_var == NULL )
 336     {
 337         vlc_mutex_unlock( &p_priv->var_lock );
 338         return VLC_ENOVAR;
 339     }
 340
 341     WaitUnused( p_this, p_var );
 342
 343     if( --p_var->i_usage == 0 )
 344         tdelete( p_var, &p_priv->var_root, varcmp );
 345     else
 346         p_var = NULL;
 347     vlc_mutex_unlock( &p_priv->var_lock );
 348
 349     if( p_var != NULL )
 350         Destroy( p_var );
 351     return VLC_SUCCESS;
 352 }
 353
 354 static void CleanupVar( void *var )
 355 {
 356     Destroy( var );
 357 }
 358
 359 void var_DestroyAll( vlc_object_t *obj )
 360 {
 361     vlc_object_internals_t *priv = vlc_internals( obj );
 362
 363     tdestroy( priv->var_root, CleanupVar );
 364     priv->var_root = NULL;
 365 }
 366
 367 #undef var_Change
 368 /**
 369  * Perform an action on a variable
 370  *
 371  * \param p_this The object that holds the variable
 372  * \param psz_name The name of the variable
 373  * \param i_action The action to perform. Must be one of \ref var_action
 374  * \param p_val First action parameter
 375  * \param p_val2 Second action parameter
 376  */
 377 int var_Change( vlc_object_t *p_this, const char *psz_name,
 378                 int i_action, vlc_value_t *p_val, vlc_value_t *p_val2 )
 379 {
 380     int i;
 381     variable_t *p_var;
 382     vlc_value_t oldval;
 383     vlc_value_t newval;
 384
 385     assert( p_this );
 386
 387     vlc_object_internals_t *p_priv = vlc_internals( p_this );
 388
 389     vlc_mutex_lock( &p_priv->var_lock );
 390
 391     p_var = Lookup( p_this, psz_name );
 392     if( p_var == NULL )
 393     {
 394         vlc_mutex_unlock( &p_priv->var_lock );
 395         return VLC_ENOVAR;
 396     }
 397
 398     switch( i_action )
 399     {
 400         case VLC_VAR_SETMIN:
 401             if( p_var->i_type & VLC_VAR_HASMIN )
 402             {
 403                 p_var->ops->pf_free( &p_var->min );
 404             }
 405             p_var->i_type |= VLC_VAR_HASMIN;
 406             p_var->min = *p_val;
 407             p_var->ops->pf_dup( &p_var->min );
 408             CheckValue( p_var, &p_var->val );
 409             break;
 410         case VLC_VAR_GETMIN:
 411             if( p_var->i_type & VLC_VAR_HASMIN )
 412             {
 413                 *p_val = p_var->min;
 414             }
 415             break;
 416         case VLC_VAR_SETMAX:
 417             if( p_var->i_type & VLC_VAR_HASMAX )
 418             {
 419                 p_var->ops->pf_free( &p_var->max );
 420             }
 421             p_var->i_type |= VLC_VAR_HASMAX;
 422             p_var->max = *p_val;
 423             p_var->ops->pf_dup( &p_var->max );
 424             CheckValue( p_var, &p_var->val );
 425             break;
 426         case VLC_VAR_GETMAX:
 427             if( p_var->i_type & VLC_VAR_HASMAX )
 428             {
 429                 *p_val = p_var->max;
 430             }
 431             break;
 432         case VLC_VAR_SETSTEP:
 433             if( p_var->i_type & VLC_VAR_HASSTEP )
 434             {
 435                 p_var->ops->pf_free( &p_var->step );
 436             }
 437             p_var->i_type |= VLC_VAR_HASSTEP;
 438             p_var->step = *p_val;
 439             p_var->ops->pf_dup( &p_var->step );
 440             CheckValue( p_var, &p_var->val );
 441             break;
 442         case VLC_VAR_GETSTEP:
 443             if( p_var->i_type & VLC_VAR_HASSTEP )
 444             {
 445                 *p_val = p_var->step;
 446             }
 447             break;
 448         case VLC_VAR_ADDCHOICE:
 449             i = p_var->choices.i_count;
 450
 451             INSERT_ELEM( p_var->choices.p_values, p_var->choices.i_count,
 452                          i, *p_val );
 453             INSERT_ELEM( p_var->choices_text.p_values,
 454                          p_var->choices_text.i_count, i, *p_val );
 455             p_var->ops->pf_dup( &p_var->choices.p_values[i] );
 456             p_var->choices_text.p_values[i].psz_string =
 457                 ( p_val2 && p_val2->psz_string ) ?
 458                 strdup( p_val2->psz_string ) : NULL;
 459
 460             CheckValue( p_var, &p_var->val );
 461             break;
 462         case VLC_VAR_DELCHOICE:
 463             for( i = 0 ; i < p_var->choices.i_count ; i++ )
 464             {
 465                 if( p_var->ops->pf_cmp( p_var->choices.p_values[i], *p_val ) == 0 )
 466                 {
 467                     break;
 468                 }
 469             }
 470
 471             if( i == p_var->choices.i_count )
 472             {
 473                 /* Not found */
 474                 vlc_mutex_unlock( &p_priv->var_lock );
 475                 return VLC_EGENERIC;
 476             }
 477
 478             if( p_var->i_default > i )
 479             {
 480                 p_var->i_default--;
 481             }
 482             else if( p_var->i_default == i )
 483             {
 484                 p_var->i_default = -1;
 485             }
 486
 487             p_var->ops->pf_free( &p_var->choices.p_values[i] );
 488             free( p_var->choices_text.p_values[i].psz_string );
 489             REMOVE_ELEM( p_var->choices.p_values, p_var->choices.i_count, i );
 490             REMOVE_ELEM( p_var->choices_text.p_values,
 491                          p_var->choices_text.i_count, i );
 492
 493             CheckValue( p_var, &p_var->val );
 494             break;
 495         case VLC_VAR_CHOICESCOUNT:
 496             p_val->i_int = p_var->choices.i_count;
 497             break;
 498         case VLC_VAR_CLEARCHOICES:
 499             for( i = 0 ; i < p_var->choices.i_count ; i++ )
 500             {
 501                 p_var->ops->pf_free( &p_var->choices.p_values[i] );
 502             }
 503             for( i = 0 ; i < p_var->choices_text.i_count ; i++ )
 504                 free( p_var->choices_text.p_values[i].psz_string );
 505
 506             if( p_var->choices.i_count ) free( p_var->choices.p_values );
 507             if( p_var->choices_text.i_count ) free( p_var->choices_text.p_values );
 508
 509             p_var->choices.i_count = 0;
 510             p_var->choices.p_values = NULL;
 511             p_var->choices_text.i_count = 0;
 512             p_var->choices_text.p_values = NULL;
 513             p_var->i_default = -1;
 514             break;
 515         case VLC_VAR_SETDEFAULT:
 516             /* FIXME: the list is sorted, dude. Use something cleverer. */
 517             for( i = 0 ; i < p_var->choices.i_count ; i++ )
 518             {
 519                 if( p_var->ops->pf_cmp( p_var->choices.p_values[i], *p_val ) == 0 )
 520                 {
 521                     break;
 522                 }
 523             }
 524
 525             if( i == p_var->choices.i_count )
 526             {
 527                 /* Not found */
 528                 break;
 529             }
 530
 531             p_var->i_default = i;
 532             CheckValue( p_var, &p_var->val );
 533             break;
 534         case VLC_VAR_SETVALUE:
 535             /* Duplicate data if needed */
 536             newval = *p_val;
 537             p_var->ops->pf_dup( &newval );
 538             /* Backup needed stuff */
 539             oldval = p_var->val;
 540             /* Check boundaries and list */
 541             CheckValue( p_var, &newval );
 542             /* Set the variable */
 543             p_var->val = newval;
 544             /* Free data if needed */
 545             p_var->ops->pf_free( &oldval );
 546             break;
 547         case VLC_VAR_GETCHOICES:
 548         case VLC_VAR_GETLIST:
 549             p_val->p_list = malloc( sizeof(vlc_list_t) );
 550             if( p_val2 ) p_val2->p_list = malloc( sizeof(vlc_list_t) );
 551             if( p_var->choices.i_count )
 552             {
 553                 p_val->p_list->p_values = malloc( p_var->choices.i_count
 554                                                   * sizeof(vlc_value_t) );
 555                 p_val->p_list->pi_types = malloc( p_var->choices.i_count
 556                                                   * sizeof(int) );
 557                 if( p_val2 )
 558                 {
 559                     p_val2->p_list->p_values =
 560                         malloc( p_var->choices.i_count * sizeof(vlc_value_t) );
 561                     p_val2->p_list->pi_types =
 562                         malloc( p_var->choices.i_count * sizeof(int) );
 563                 }
 564             }
 565             p_val->p_list->i_count = p_var->choices.i_count;
 566             if( p_val2 ) p_val2->p_list->i_count = p_var->choices.i_count;
 567             for( i = 0 ; i < p_var->choices.i_count ; i++ )
 568             {
 569                 p_val->p_list->p_values[i] = p_var->choices.p_values[i];
 570                 p_val->p_list->pi_types[i] = p_var->i_type;
 571                 p_var->ops->pf_dup( &p_val->p_list->p_values[i] );
 572                 if( p_val2 )
 573                 {
 574                     p_val2->p_list->p_values[i].psz_string =
 575                         p_var->choices_text.p_values[i].psz_string ?
 576                     strdup(p_var->choices_text.p_values[i].psz_string) : NULL;
 577                     p_val2->p_list->pi_types[i] = VLC_VAR_STRING;
 578                 }
 579             }
 580             break;
 581         case VLC_VAR_SETTEXT:
 582             free( p_var->psz_text );
 583             if( p_val && p_val->psz_string )
 584                 p_var->psz_text = strdup( p_val->psz_string );
 585             else
 586                 p_var->psz_text = NULL;
 587             break;
 588         case VLC_VAR_GETTEXT:
 589             p_val->psz_string = p_var->psz_text ? strdup( p_var->psz_text )
 590                                                 : NULL;
 591             break;
 592         case VLC_VAR_SETISCOMMAND:
 593             p_var->i_type |= VLC_VAR_ISCOMMAND;
 594             break;
 595
 596         default:
 597             break;
 598     }
 599
 600     vlc_mutex_unlock( &p_priv->var_lock );
 601
 602     return VLC_SUCCESS;
 603 }
 604
 605 #undef var_GetAndSet
 606 /**
 607  * Perform a Get and Set on a variable
 608  *
 609  * \param p_this: The object that hold the variable
 610  * \param psz_name: the name of the variable
 611  * \param i_action: the action to perform
 612  * \param p_val: The action parameter
 613  * \return vlc error codes
 614  */
 615 int var_GetAndSet( vlc_object_t *p_this, const char *psz_name, int i_action,
 616                    vlc_value_t *p_val )
 617 {
 618     int i_ret;
 619     variable_t *p_var;
 620     vlc_value_t oldval;
 621
 622     assert( p_this );
 623     assert( p_val );
 624
 625     vlc_object_internals_t *p_priv = vlc_internals( p_this );
 626
 627     vlc_mutex_lock( &p_priv->var_lock );
 628     p_var = Lookup( p_this, psz_name );
 629     if( p_var == NULL )
 630     {
 631         vlc_mutex_unlock( &p_priv->var_lock );
 632         return VLC_ENOVAR;
 633     }
 634
 635     WaitUnused( p_this, p_var );
 636
 637     /* Duplicated data if needed */
 638     //p_var->ops->pf_dup( &val );
 639
 640     /* Backup needed stuff */
 641     oldval = p_var->val;
 642
 643     /* depending of the action requiered */
 644     switch( i_action )
 645     {
 646     case VLC_VAR_BOOL_TOGGLE:
 647         assert( ( p_var->i_type & VLC_VAR_BOOL ) == VLC_VAR_BOOL );
 648         p_var->val.b_bool = !p_var->val.b_bool;
 649         break;
 650     case VLC_VAR_INTEGER_ADD:
 651         assert( ( p_var->i_type & VLC_VAR_INTEGER ) == VLC_VAR_INTEGER );
 652         p_var->val.i_int += p_val->i_int;
 653         break;
 654     case VLC_VAR_INTEGER_OR:
 655         assert( ( p_var->i_type & VLC_VAR_INTEGER ) == VLC_VAR_INTEGER );
 656         p_var->val.i_int |= p_val->i_int;
 657         break;
 658     case VLC_VAR_INTEGER_NAND:
 659         assert( ( p_var->i_type & VLC_VAR_INTEGER ) == VLC_VAR_INTEGER );
 660         p_var->val.i_int &= ~p_val->i_int;
 661         break;
 662     default:
 663         vlc_mutex_unlock( &p_priv->var_lock );
 664         return VLC_EGENERIC;
 665     }
 666
 667     /*  Check boundaries */
 668     CheckValue( p_var, &p_var->val );
 669     *p_val = p_var->val;
 670
 671     /* Deal with callbacks.*/
 672     i_ret = TriggerCallback( p_this, p_var, psz_name, oldval );
 673
 674     vlc_mutex_unlock( &p_priv->var_lock );
 675
 676     return i_ret;
 677 }
 678
 679 #undef var_Type
 680 /**
 681  * Request a variable's type
 682  *
 683  * \return The variable type if it exists, or 0 if the
 684  * variable could not be found.
 685  * \see \ref var_type
 686  */
 687 int var_Type( vlc_object_t *p_this, const char *psz_name )
 688 {
 689     variable_t *p_var;
 690     int i_type = 0;
 691
 692     assert( p_this );
 693
 694     vlc_object_internals_t *p_priv = vlc_internals( p_this );
 695
 696     vlc_mutex_lock( &p_priv->var_lock );
 697
 698     p_var = Lookup( p_this, psz_name );
 699     if( p_var != NULL )
 700         i_type = p_var->i_type;
 701
 702     vlc_mutex_unlock( &p_priv->var_lock );
 703
 704     return i_type;
 705 }
 706
 707 #undef var_SetChecked
 708 int var_SetChecked( vlc_object_t *p_this, const char *psz_name,
 709                     int expected_type, vlc_value_t val )
 710 {
 711     int i_ret = VLC_SUCCESS;
 712     variable_t *p_var;
 713     vlc_value_t oldval;
 714
 715     assert( p_this );
 716
 717     vlc_object_internals_t *p_priv = vlc_internals( p_this );
 718
 719     vlc_mutex_lock( &p_priv->var_lock );
 720
 721     p_var = Lookup( p_this, psz_name );
 722     if( p_var == NULL )
 723     {
 724         vlc_mutex_unlock( &p_priv->var_lock );
 725         return VLC_ENOVAR;
 726     }
 727
 728     assert( expected_type == 0 ||
 729             (p_var->i_type & VLC_VAR_CLASS) == expected_type );
 730 #ifndef NDEBUG
 731         /* Alert if the type is VLC_VAR_VOID */
 732         if( ( p_var->i_type & VLC_VAR_TYPE ) == VLC_VAR_VOID )
 733             msg_Warn( p_this, "Calling var_Set on the void variable '%s' (0x%04x)", psz_name, p_var->i_type );
 734 #endif
 735
 736
 737     WaitUnused( p_this, p_var );
 738
 739     /* Duplicate data if needed */
 740     p_var->ops->pf_dup( &val );
 741
 742     /* Backup needed stuff */
 743     oldval = p_var->val;
 744
 745     /* Check boundaries and list */
 746     CheckValue( p_var, &val );
 747
 748     /* Set the variable */
 749     p_var->val = val;
 750
 751     /* Deal with callbacks */
 752     i_ret = TriggerCallback( p_this, p_var, psz_name, oldval );
 753
 754     /* Free data if needed */
 755     p_var->ops->pf_free( &oldval );
 756
 757     vlc_mutex_unlock( &p_priv->var_lock );
 758
 759     return i_ret;
 760 }
 761
 762 #undef var_Set
 763 /**
 764  * Set a variable's value
 765  *
 766  * \param p_this The object that hold the variable
 767  * \param psz_name The name of the variable
 768  * \param val the value to set
 769  */
 770 int var_Set( vlc_object_t *p_this, const char *psz_name, vlc_value_t val )
 771 {
 772     return var_SetChecked( p_this, psz_name, 0, val );
 773 }
 774
 775 #undef var_GetChecked
 776 int var_GetChecked( vlc_object_t *p_this, const char *psz_name,
 777                     int expected_type, vlc_value_t *p_val )
 778 {
 779     assert( p_this );
 780
 781     vlc_object_internals_t *p_priv = vlc_internals( p_this );
 782     variable_t *p_var;
 783     int err = VLC_SUCCESS;
 784
 785     vlc_mutex_lock( &p_priv->var_lock );
 786
 787     p_var = Lookup( p_this, psz_name );
 788     if( p_var != NULL )
 789     {
 790         assert( expected_type == 0 ||
 791                 (p_var->i_type & VLC_VAR_CLASS) == expected_type );
 792
 793         /* Really get the variable */
 794         *p_val = p_var->val;
 795
 796 #ifndef NDEBUG
 797         /* Alert if the type is VLC_VAR_VOID */
 798         if( ( p_var->i_type & VLC_VAR_TYPE ) == VLC_VAR_VOID )
 799             msg_Warn( p_this, "Calling var_Get on the void variable '%s' (0x%04x)", psz_name, p_var->i_type );
 800 #endif
 801
 802         /* Duplicate value if needed */
 803         p_var->ops->pf_dup( p_val );
 804     }
 805     else
 806         err = VLC_ENOVAR;
 807
 808     vlc_mutex_unlock( &p_priv->var_lock );
 809     return err;
 810 }
 811
 812 #undef var_Get
 813 /**
 814  * Get a variable's value
 815  *
 816  * \param p_this The object that holds the variable
 817  * \param psz_name The name of the variable
 818  * \param p_val Pointer to a vlc_value_t that will hold the variable's value
 819  *              after the function is finished
 820  */
 821 int var_Get( vlc_object_t *p_this, const char *psz_name, vlc_value_t *p_val )
 822 {
 823     return var_GetChecked( p_this, psz_name, 0, p_val );
 824 }
 825
 826 #undef var_AddCallback
 827 /**
 828  * Register a callback in a variable
 829  *
 830  * We store a function pointer that will be called upon variable
 831  * modification.
 832  *
 833  * \param p_this The object that holds the variable
 834  * \param psz_name The name of the variable
 835  * \param pf_callback The function pointer
 836  * \param p_data A generic pointer that will be passed as the last
 837  *               argument to the callback function.
 838  *
 839  * \warning The callback function is run in the thread that calls var_Set on
 840  *          the variable. Use proper locking. This thread may not have much
 841  *          time to spare, so keep callback functions short.
 842  */
 843 int var_AddCallback( vlc_object_t *p_this, const char *psz_name,
 844                      vlc_callback_t pf_callback, void *p_data )
 845 {
 846     variable_t *p_var;
 847     callback_entry_t entry;
 848
 849     assert( p_this );
 850
 851     vlc_object_internals_t *p_priv = vlc_internals( p_this );
 852
 853     entry.pf_callback = pf_callback;
 854     entry.p_data = p_data;
 855
 856     vlc_mutex_lock( &p_priv->var_lock );
 857
 858     p_var = Lookup( p_this, psz_name );
 859     if( p_var == NULL )
 860     {
 861 #ifndef NDEBUG
 862         msg_Warn( p_this, "Failed to add a callback to the non-existing "
 863                           "variable '%s'", psz_name );
 864 #endif
 865         vlc_mutex_unlock( &p_priv->var_lock );
 866         return VLC_ENOVAR;
 867     }
 868
 869     WaitUnused( p_this, p_var );
 870     INSERT_ELEM( p_var->p_entries,
 871                  p_var->i_entries,
 872                  p_var->i_entries,
 873                  entry );
 874
 875     vlc_mutex_unlock( &p_priv->var_lock );
 876
 877     return VLC_SUCCESS;
 878 }
 879
 880 #undef var_DelCallback
 881 /**
 882  * Remove a callback from a variable
 883  *
 884  * pf_callback and p_data have to be given again, because different objects
 885  * might have registered the same callback function.
 886  */
 887 int var_DelCallback( vlc_object_t *p_this, const char *psz_name,
 888                      vlc_callback_t pf_callback, void *p_data )
 889 {
 890     int i_entry;
 891     variable_t *p_var;
 892 #ifndef NDEBUG
 893     bool b_found_similar = false;
 894 #endif
 895
 896     assert( p_this );
 897
 898     vlc_object_internals_t *p_priv = vlc_internals( p_this );
 899
 900     vlc_mutex_lock( &p_priv->var_lock );
 901
 902     p_var = Lookup( p_this, psz_name );
 903     if( p_var == NULL )
 904     {
 905         vlc_mutex_unlock( &p_priv->var_lock );
 906         return VLC_ENOVAR;
 907     }
 908
 909     WaitUnused( p_this, p_var );
 910
 911     for( i_entry = p_var->i_entries ; i_entry-- ; )
 912     {
 913         if( p_var->p_entries[i_entry].pf_callback == pf_callback
 914             && p_var->p_entries[i_entry].p_data == p_data )
 915         {
 916             break;
 917         }
 918 #ifndef NDEBUG
 919         else if( p_var->p_entries[i_entry].pf_callback == pf_callback )
 920             b_found_similar = true;
 921 #endif
 922     }
 923
 924     if( i_entry < 0 )
 925     {
 926 #ifndef NDEBUG
 927         if( b_found_similar )
 928             fprintf( stderr, "Calling var_DelCallback for '%s' with the same "
 929                              "function but not the same data.", psz_name );
 930         assert( 0 );
 931 #endif
 932         vlc_mutex_unlock( &p_priv->var_lock );
 933         return VLC_EGENERIC;
 934     }
 935
 936     REMOVE_ELEM( p_var->p_entries, p_var->i_entries, i_entry );
 937
 938     vlc_mutex_unlock( &p_priv->var_lock );
 939
 940     return VLC_SUCCESS;
 941 }
 942
 943 #undef var_TriggerCallback
 944 /**
 945  * Trigger callback on a variable
 946  *
 947  * \param p_this The object that hold the variable
 948  * \param psz_name The name of the variable
 949  */
 950 int var_TriggerCallback( vlc_object_t *p_this, const char *psz_name )
 951 {
 952     int i_ret;
 953     variable_t *p_var;
 954
 955     assert( p_this );
 956
 957     vlc_object_internals_t *p_priv = vlc_internals( p_this );
 958
 959     vlc_mutex_lock( &p_priv->var_lock );
 960
 961     p_var = Lookup( p_this, psz_name );
 962     if( p_var == NULL )
 963     {
 964         vlc_mutex_unlock( &p_priv->var_lock );
 965         return VLC_ENOVAR;
 966     }
 967
 968     WaitUnused( p_this, p_var );
 969
 970     /* Deal with callbacks. Tell we're in a callback, release the lock,
 971      * call stored functions, retake the lock. */
 972     i_ret = TriggerCallback( p_this, p_var, psz_name, p_var->val );
 973
 974     vlc_mutex_unlock( &p_priv->var_lock );
 975     return i_ret;
 976 }
 977
 978 /** Parse a stringified option
 979  * This function parse a string option and create the associated object
 980  * variable
 981  * The option must be of the form "[no[-]]foo[=bar]" where foo is the
 982  * option name and bar is the value of the option.
 983  * \param p_obj the object in which the variable must be created
 984  * \param psz_option the option to parse
 985  * \param trusted whether the option is set by a trusted input or not
 986  * \return nothing
 987  */
 988 void var_OptionParse( vlc_object_t *p_obj, const char *psz_option,
 989                       bool trusted )
 990 {
 991     char *psz_name, *psz_value;
 992     int  i_type;
 993     bool b_isno = false;
 994     vlc_value_t val;
 995
 996     val.psz_string = NULL;
 997
 998     /* It's too much of a hassle to remove the ':' when we parse
 999      * the cmd line :) */
1000     if( psz_option[0] == ':' )
1001         psz_option++;
1002
1003     if( !psz_option[0] )
1004         return;
1005
1006     psz_name = strdup( psz_option );
1007     if( psz_name == NULL )
1008         return;
1009
1010     psz_value = strchr( psz_name, '=' );
1011     if( psz_value != NULL )
1012         *psz_value++ = '\0';
1013
1014     i_type = config_GetType( p_obj, psz_name );
1015     if( !i_type && !psz_value )
1016     {
1017         /* check for "no-foo" or "nofoo" */
1018         if( !strncmp( psz_name, "no-", 3 ) )
1019         {
1020             memmove( psz_name, psz_name + 3, strlen(psz_name) + 1 - 3 );
1021         }
1022         else if( !strncmp( psz_name, "no", 2 ) )
1023         {
1024             memmove( psz_name, psz_name + 2, strlen(psz_name) + 1 - 2 );
1025         }
1026         else goto cleanup;           /* Option doesn't exist */
1027
1028         b_isno = true;
1029         i_type = config_GetType( p_obj, psz_name );
1030     }
1031     if( !i_type ) goto cleanup; /* Option doesn't exist */
1032
1033     if( ( i_type != VLC_VAR_BOOL ) &&
1034         ( !psz_value || !*psz_value ) ) goto cleanup; /* Invalid value */
1035
1036     /* check if option is unsafe */
1037     if( !trusted )
1038     {
1039         module_config_t *p_config = config_FindConfig( p_obj, psz_name );
1040         if( !p_config || !p_config->b_safe )
1041         {
1042             msg_Err( p_obj, "unsafe option \"%s\" has been ignored for "
1043                             "security reasons", psz_name );
1044             free( psz_name );
1045             return;
1046         }
1047     }
1048
1049     /* Create the variable in the input object.
1050      * Children of the input object will be able to retreive this value
1051      * thanks to the inheritance property of the object variables. */
1052     var_Create( p_obj, psz_name, i_type );
1053
1054     switch( i_type )
1055     {
1056     case VLC_VAR_BOOL:
1057         val.b_bool = !b_isno;
1058         break;
1059
1060     case VLC_VAR_INTEGER:
1061         val.i_int = strtoll( psz_value, NULL, 0 );
1062         break;
1063
1064     case VLC_VAR_FLOAT:
1065         val.f_float = us_atof( psz_value );
1066         break;
1067
1068     case VLC_VAR_STRING:
1069         val.psz_string = psz_value;
1070         break;
1071
1072     default:
1073         goto cleanup;
1074     }
1075
1076     var_Set( p_obj, psz_name, val );
1077
1078 cleanup:
1079     free( psz_name );
1080 }
1081
1082
1083 /* Following functions are local */
1084
1085 /**
1086  * Waits until the variable is inactive (i.e. not executing a callback)
1087  */
1088 static void WaitUnused( vlc_object_t *p_this, variable_t *p_var )
1089 {
1090     vlc_object_internals_t *p_priv = vlc_internals( p_this );
1091
1092     mutex_cleanup_push( &p_priv->var_lock );
1093     while( p_var->b_incallback )
1094         vlc_cond_wait( &p_priv->var_wait, &p_priv->var_lock );
1095     vlc_cleanup_pop( );
1096 }
1097
1098 /*****************************************************************************
1099  * CheckValue: check that a value is valid wrt. a variable
1100  *****************************************************************************
1101  * This function checks p_val's value against p_var's limitations such as
1102  * minimal and maximal value, step, in-list position, and modifies p_val if
1103  * necessary.
1104  ****************************************************************************/
1105 static void CheckValue ( variable_t *p_var, vlc_value_t *p_val )
1106 {
1107     /* Check that our variable is in the list */
1108     if( p_var->i_type & VLC_VAR_HASCHOICE && p_var->choices.i_count )
1109     {
1110         int i;
1111
1112         /* This list is not sorted so go throug it (this is a small list) */
1113         for( i = p_var->choices.i_count ; i-- ; )
1114         {
1115             if( p_var->ops->pf_cmp( *p_val, p_var->choices.p_values[i] ) == 0 )
1116             {
1117                 break;
1118             }
1119         }
1120
1121         /* If not found, change it to anything vaguely valid */
1122         if( i < 0 )
1123         {
1124             /* Free the old variable, get the new one, dup it */
1125             p_var->ops->pf_free( p_val );
1126             *p_val = p_var->choices.p_values[p_var->i_default >= 0
1127                                           ? p_var->i_default : 0 ];
1128             p_var->ops->pf_dup( p_val );
1129         }
1130     }
1131
1132     /* Check that our variable is within the bounds */
1133     switch( p_var->i_type & VLC_VAR_TYPE )
1134     {
1135         case VLC_VAR_INTEGER:
1136             if( p_var->i_type & VLC_VAR_HASSTEP && p_var->step.i_int
1137                  && (p_val->i_int % p_var->step.i_int) )
1138             {
1139                 p_val->i_int = (p_val->i_int + (p_var->step.i_int / 2))
1140                                / p_var->step.i_int * p_var->step.i_int;
1141             }
1142             if( p_var->i_type & VLC_VAR_HASMIN
1143                  && p_val->i_int < p_var->min.i_int )
1144             {
1145                 p_val->i_int = p_var->min.i_int;
1146             }
1147             if( p_var->i_type & VLC_VAR_HASMAX
1148                  && p_val->i_int > p_var->max.i_int )
1149             {
1150                 p_val->i_int = p_var->max.i_int;
1151             }
1152             break;
1153         case VLC_VAR_FLOAT:
1154             if( p_var->i_type & VLC_VAR_HASSTEP && p_var->step.f_float )
1155             {
1156                 float f_round = p_var->step.f_float * (float)(int)( 0.5 +
1157                                         p_val->f_float / p_var->step.f_float );
1158                 if( p_val->f_float != f_round )
1159                 {
1160                     p_val->f_float = f_round;
1161                 }
1162             }
1163             if( p_var->i_type & VLC_VAR_HASMIN
1164                  && p_val->f_float < p_var->min.f_float )
1165             {
1166                 p_val->f_float = p_var->min.f_float;
1167             }
1168             if( p_var->i_type & VLC_VAR_HASMAX
1169                  && p_val->f_float > p_var->max.f_float )
1170             {
1171                 p_val->f_float = p_var->max.f_float;
1172             }
1173             break;
1174         case VLC_VAR_TIME:
1175             /* FIXME: TODO */
1176             break;
1177     }
1178 }
1179
1180 /**
1181  * Finds the value of a variable. If the specified object does not hold a
1182  * variable with the specified name, try the parent object, and iterate until
1183  * the top of the tree. If no match is found, the value is read from the
1184  * configuration.
1185  */
1186 int var_Inherit( vlc_object_t *p_this, const char *psz_name, int i_type,
1187                  vlc_value_t *p_val )
1188 {
1189 #ifndef NDEBUG
1190     if (p_this != VLC_OBJECT(p_this->p_libvlc)
1191      && unlikely(p_this->p_parent == NULL))
1192     {
1193         msg_Info (p_this, "%s(%s) on detached object", __func__, psz_name);
1194         //vlc_backtrace ();
1195     }
1196 #endif
1197     i_type &= VLC_VAR_CLASS;
1198     for( vlc_object_t *obj = p_this; obj != NULL; obj = obj->p_parent )
1199     {
1200         if( var_GetChecked( obj, psz_name, i_type, p_val ) == VLC_SUCCESS )
1201             return VLC_SUCCESS;
1202 #ifndef NDEBUG
1203         if (obj != p_this && obj != VLC_OBJECT(p_this->p_libvlc)
1204          && unlikely(obj->p_parent == NULL))
1205         {
1206             msg_Info (p_this, "%s(%s) on detached tree [%p] %s", __func__,
1207                       psz_name, obj, obj->psz_object_type);
1208             //vlc_backtrace ();
1209         }
1210 #endif
1211     }
1212
1213     /* else take value from config */
1214     switch( i_type & VLC_VAR_CLASS )
1215     {
1216         case VLC_VAR_STRING:
1217             p_val->psz_string = config_GetPsz( p_this, psz_name );
1218             if( !p_val->psz_string ) p_val->psz_string = strdup("");
1219             break;
1220         case VLC_VAR_FLOAT:
1221             p_val->f_float = config_GetFloat( p_this, psz_name );
1222             break;
1223         case VLC_VAR_INTEGER:
1224             p_val->i_int = config_GetInt( p_this, psz_name );
1225             break;
1226         case VLC_VAR_BOOL:
1227             p_val->b_bool = config_GetInt( p_this, psz_name );
1228             break;
1229         case VLC_VAR_ADDRESS:
1230             return VLC_ENOOBJ;
1231         default:
1232             msg_Warn( p_this, "Could not inherit value for var %s "
1233                               "from config. Invalid Type", psz_name );
1234             return VLC_ENOOBJ;
1235     }
1236     /*msg_Dbg( p_this, "Inherited value for var %s from config", psz_name );*/
1237     return VLC_SUCCESS;
1238 }
1239
1240
1241 /**
1242  * It inherits a string as an unsigned rational number (it also accepts basic
1243  * float number).
1244  *
1245  * It returns an error if the rational number cannot be parsed (0/0 is valid).
1246  * The rational is already reduced.
1247  */
1248 int (var_InheritURational)(vlc_object_t *object,
1249                            unsigned *num, unsigned *den,
1250                            const char *var)
1251 {
1252     /* */
1253     *num = 0;
1254     *den = 0;
1255
1256     /* */
1257     char *tmp = var_InheritString(object, var);
1258     if (!tmp)
1259         goto error;
1260
1261     char *next;
1262     unsigned n = strtol(tmp,  &next, 0);
1263     unsigned d = strtol(*next ? &next[1] : "0", NULL, 0);
1264
1265     if (*next == '.') {
1266         /* Interpret as a float number */
1267         double r = us_atof(tmp);
1268         double c = ceil(r);
1269         if (c >= UINT_MAX)
1270             goto error;
1271         unsigned m = c;
1272         if (m > 0) {
1273             d = UINT_MAX / m;
1274             n = r * d;
1275         } else {
1276             n = 0;
1277             d = 0;
1278         }
1279     }
1280
1281     if (n > 0 && d > 0)
1282         vlc_ureduce(num, den, n, d, 0);
1283
1284     free(tmp);
1285     return VLC_SUCCESS;
1286
1287 error:
1288     free(tmp);
1289     return VLC_EGENERIC;
1290 }
1291
1292 /**********************************************************************
1293  * Trigger the callbacks.
1294  * Tell we're in a callback, release the lock, call stored functions,
1295  * retake the lock.
1296  **********************************************************************/
1297 static int TriggerCallback( vlc_object_t *p_this, variable_t *p_var,
1298                             const char *psz_name, vlc_value_t oldval )
1299 {
1300     assert( p_this );
1301
1302     int i_entries = p_var->i_entries;
1303     if( i_entries == 0 )
1304         return VLC_SUCCESS;
1305
1306     callback_entry_t *p_entries = p_var->p_entries;
1307     vlc_object_internals_t *p_priv = vlc_internals( p_this );
1308
1309     assert( !p_var->b_incallback );
1310     p_var->b_incallback = true;
1311     vlc_mutex_unlock( &p_priv->var_lock );
1312
1313     /* The real calls */
1314     for( ; i_entries-- ; )
1315     {
1316         p_entries[i_entries].pf_callback( p_this, psz_name, oldval, p_var->val,
1317                                           p_entries[i_entries].p_data );
1318     }
1319
1320     vlc_mutex_lock( &p_priv->var_lock );
1321     p_var->b_incallback = false;
1322     vlc_cond_broadcast( &p_priv->var_wait );
1323
1324     return VLC_SUCCESS;
1325 }
1326
1327 #undef var_Command
1328 /**********************************************************************
1329  * Execute a var command on an object identified by its name
1330  **********************************************************************/
1331 int var_Command( vlc_object_t *p_this, const char *psz_name,
1332                  const char *psz_cmd, const char *psz_arg, char **psz_msg )
1333 {
1334     vlc_object_t *p_obj = vlc_object_find_name( p_this->p_libvlc,
1335                                                 psz_name, FIND_CHILD );
1336     int i_type, i_ret;
1337
1338     if( !p_obj )
1339     {
1340         if( psz_msg )
1341             *psz_msg = strdup( "Unknown destination object." );
1342         return VLC_ENOOBJ;
1343     }
1344
1345     i_type = var_Type( p_obj, psz_cmd );
1346     if( !( i_type&VLC_VAR_ISCOMMAND ) )
1347     {
1348         vlc_object_release( p_obj );
1349         if( psz_msg )
1350             *psz_msg = strdup( "Variable doesn't exist or isn't a command." );
1351         return VLC_EGENERIC;
1352     }
1353
1354     i_type &= VLC_VAR_CLASS;
1355     switch( i_type )
1356     {
1357         case VLC_VAR_INTEGER:
1358             i_ret = var_SetInteger( p_obj, psz_cmd, atoi( psz_arg ) );
1359             break;
1360         case VLC_VAR_FLOAT:
1361             i_ret = var_SetFloat( p_obj, psz_cmd, us_atof( psz_arg ) );
1362             break;
1363         case VLC_VAR_STRING:
1364             i_ret = var_SetString( p_obj, psz_cmd, psz_arg );
1365             break;
1366         case VLC_VAR_BOOL:
1367             i_ret = var_SetBool( p_obj, psz_cmd, atoi( psz_arg ) );
1368             break;
1369         default:
1370             i_ret = VLC_EGENERIC;
1371             break;
1372     }
1373
1374     vlc_object_release( p_obj );
1375
1376     if( psz_msg )
1377     {
1378         if( asprintf( psz_msg, "%s on object %s returned %i (%s)",
1379                   psz_cmd, psz_name, i_ret, vlc_error( i_ret ) ) == -1)
1380             *psz_msg = NULL;
1381     }
1382
1383     return i_ret;
1384 }
1385
1386
1387 /**
1388  * Free a list and the associated strings
1389  * @param p_val: the list variable
1390  * @param p_val2: the variable associated or NULL
1391  */
1392 void var_FreeList( vlc_value_t *p_val, vlc_value_t *p_val2 )
1393 {
1394     FreeList( p_val );
1395     if( p_val2 && p_val2->p_list )
1396     {
1397         for( int i = 0; i < p_val2->p_list->i_count; i++ )
1398             free( p_val2->p_list->p_values[i].psz_string );
1399         if( p_val2->p_list->i_count )
1400         {
1401             free( p_val2->p_list->p_values );
1402             free( p_val2->p_list->pi_types );
1403         }
1404         free( p_val2->p_list );
1405     }
1406 }