modules/codec/avcodec/dxva2.c

   1 /*****************************************************************************
   2  * dxva2.c: Video Acceleration helpers
   3  *****************************************************************************
   4  * Copyright (C) 2009 Geoffroy Couprie
   5  * Copyright (C) 2009 Laurent Aimar
   6  * $Id$
   7  *
   8  * Authors: Geoffroy Couprie <geal@videolan.org>
   9  *          Laurent Aimar <fenrir _AT_ videolan _DOT_ org>
  10  *
  11  * This program is free software; you can redistribute it and/or modify it
  12  * under the terms of the GNU Lesser General Public License as published by
  13  * the Free Software Foundation; either version 2.1 of the License, or
  14  * (at your option) any later version.
  15  *
  16  * This program is distributed in the hope that it will be useful,
  17  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  18  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  19  * GNU Lesser General Public License for more details.
  20  *
  21  * You should have received a copy of the GNU Lesser General Public License
  22  * along with this program; if not, write to the Free Software Foundation,
  23  * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  24  *****************************************************************************/
  25
  26 #ifdef HAVE_CONFIG_H
  27 # include "config.h"
  28 #endif
  29
  30 #include <assert.h>
  31
  32 #include <vlc_common.h>
  33 #include <vlc_picture.h>
  34 #include <vlc_plugin.h>
  35
  36 #define DXVA2API_USE_BITFIELDS
  37 #define COBJMACROS
  38 #include <libavcodec/dxva2.h>
  39 #include "../../video_chroma/d3d9_fmt.h"
  40
  41 #define D3D_Device          IDirect3DDevice9
  42 #define D3D_DecoderType     IDirectXVideoDecoder
  43 #define D3D_DecoderDevice   IDirectXVideoDecoderService
  44 #define D3D_DecoderSurface  IDirect3DSurface9
  45 #include "directx_va.h"
  46
  47 static int Open(vlc_va_t *, AVCodecContext *, enum PixelFormat,
  48                 const es_format_t *, picture_sys_t *p_sys);
  49 static void Close(vlc_va_t *, void **);
  50
  51 vlc_module_begin()
  52     set_description(N_("DirectX Video Acceleration (DXVA) 2.0"))
  53     set_capability("hw decoder", 100)
  54     set_category(CAT_INPUT)
  55     set_subcategory(SUBCAT_INPUT_VCODEC)
  56     set_callbacks(Open, Close)
  57 vlc_module_end()
  58
  59 #include <initguid.h> /* must be last included to not redefine existing GUIDs */
  60
  61 /* dxva2api.h GUIDs: http://msdn.microsoft.com/en-us/library/windows/desktop/ms697067(v=vs100).aspx
  62  * assume that they are declared in dxva2api.h */
  63 #define MS_GUID(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8)
  64
  65 #ifdef __MINGW32__
  66 # include <_mingw.h>
  67
  68 # if !defined(__MINGW64_VERSION_MAJOR)
  69 #  undef MS_GUID
  70 #  define MS_GUID DEFINE_GUID /* dxva2api.h fails to declare those, redefine as static */
  71 #  define DXVA2_E_NEW_VIDEO_DEVICE MAKE_HRESULT(1, 4, 4097)
  72 # else
  73 #  include <dxva.h>
  74 # endif
  75
  76 #endif /* __MINGW32__ */
  77
  78 MS_GUID(IID_IDirectXVideoDecoderService, 0xfc51a551, 0xd5e7, 0x11d9, 0xaf,0x55,0x00,0x05,0x4e,0x43,0xff,0x02);
  79 MS_GUID(IID_IDirectXVideoAccelerationService, 0xfc51a550, 0xd5e7, 0x11d9, 0xaf,0x55,0x00,0x05,0x4e,0x43,0xff,0x02);
  80
  81 DEFINE_GUID(DXVA2_NoEncrypt,                        0x1b81bed0, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);
  82
  83 DEFINE_GUID(DXVA_Intel_H264_NoFGT_ClearVideo,       0x604F8E68, 0x4951, 0x4c54, 0x88, 0xFE, 0xAB, 0xD2, 0x5C, 0x15, 0xB3, 0xD6);
  84
  85
  86 /* */
  87 typedef struct {
  88     const char   *name;
  89     D3DFORMAT    format;
  90     vlc_fourcc_t codec;
  91 } d3d_format_t;
  92 /* XXX Prefered format must come first */
  93 static const d3d_format_t d3d_formats[] = {
  94     { "YV12",   MAKEFOURCC('Y','V','1','2'),    VLC_CODEC_YV12 },
  95     { "NV12",   MAKEFOURCC('N','V','1','2'),    VLC_CODEC_NV12 },
  96     { "IMC3",   MAKEFOURCC('I','M','C','3'),    VLC_CODEC_YV12 },
  97     { "P010",   MAKEFOURCC('P','0','1','0'),    VLC_CODEC_P010 },
  98
  99     { NULL, 0, 0 }
 100 };
 101
 102 static const d3d_format_t *D3dFindFormat(D3DFORMAT format)
 103 {
 104     for (unsigned i = 0; d3d_formats[i].name; i++) {
 105         if (d3d_formats[i].format == format)
 106             return &d3d_formats[i];
 107     }
 108     return NULL;
 109 }
 110
 111 struct vlc_va_sys_t
 112 {
 113     directx_sys_t         dx_sys;
 114
 115     /* DLL */
 116     HINSTANCE             hd3d9_dll;
 117
 118     /* Direct3D */
 119     LPDIRECT3D9            d3dobj;
 120     D3DADAPTER_IDENTIFIER9 d3dai;
 121
 122     /* Device manager */
 123     IDirect3DDeviceManager9  *devmng;
 124     HANDLE                   device;
 125
 126     /* Video service */
 127     D3DFORMAT                    render;
 128
 129     /* Video decoder */
 130     DXVA2_ConfigPictureDecode    cfg;
 131
 132     /* avcodec internals */
 133     struct dxva_context hw;
 134 };
 135
 136
 137 /* */
 138 static int D3dCreateDevice(vlc_va_t *);
 139 static void D3dDestroyDevice(vlc_va_t *);
 140 static char *DxDescribe(vlc_va_sys_t *);
 141
 142 static int D3dCreateDeviceManager(vlc_va_t *);
 143 static void D3dDestroyDeviceManager(vlc_va_t *);
 144
 145 static int DxCreateVideoService(vlc_va_t *);
 146 static void DxDestroyVideoService(vlc_va_t *);
 147 static int DxGetInputList(vlc_va_t *, input_list_t *);
 148 static int DxSetupOutput(vlc_va_t *, const GUID *, const video_format_t *);
 149
 150 static int DxCreateVideoDecoder(vlc_va_t *, int codec_id,
 151                                 const video_format_t *, unsigned surface_count);
 152 static void DxDestroyVideoDecoder(vlc_va_t *);
 153 static int DxResetVideoDecoder(vlc_va_t *);
 154 static void SetupAVCodecContext(vlc_va_t *);
 155
 156 void SetupAVCodecContext(vlc_va_t *va)
 157 {
 158     vlc_va_sys_t *sys = va->sys;
 159     directx_sys_t *dx_sys = &sys->dx_sys;
 160
 161     sys->hw.decoder = dx_sys->decoder;
 162     sys->hw.cfg = &sys->cfg;
 163     sys->hw.surface_count = dx_sys->va_pool.surface_count;
 164     sys->hw.surface = dx_sys->hw_surface;
 165
 166     if (IsEqualGUID(&dx_sys->input, &DXVA_Intel_H264_NoFGT_ClearVideo))
 167         sys->hw.workaround |= FF_DXVA2_WORKAROUND_INTEL_CLEARVIDEO;
 168 }
 169
 170 static void d3d9_pic_context_destroy(struct picture_context_t *opaque)
 171 {
 172     struct va_pic_context *pic_ctx = (struct va_pic_context*)opaque;
 173     if (pic_ctx->va_surface)
 174     {
 175         ReleasePictureSys(&pic_ctx->picsys);
 176         va_surface_Release(pic_ctx->va_surface);
 177         free(pic_ctx);
 178     }
 179 }
 180
 181 static struct va_pic_context *CreatePicContext(IDirect3DSurface9 *);
 182
 183 static struct picture_context_t *d3d9_pic_context_copy(struct picture_context_t *ctx)
 184 {
 185     struct va_pic_context *src_ctx = (struct va_pic_context*)ctx;
 186     struct va_pic_context *pic_ctx = CreatePicContext(src_ctx->picsys.surface);
 187     if (unlikely(pic_ctx==NULL))
 188         return NULL;
 189     pic_ctx->va_surface = src_ctx->va_surface;
 190     va_surface_AddRef(pic_ctx->va_surface);
 191     return &pic_ctx->s;
 192 }
 193
 194 static struct va_pic_context *CreatePicContext(IDirect3DSurface9 *surface)
 195 {
 196     struct va_pic_context *pic_ctx = calloc(1, sizeof(*pic_ctx));
 197     if (unlikely(pic_ctx==NULL))
 198         return NULL;
 199     pic_ctx->s.destroy = d3d9_pic_context_destroy;
 200     pic_ctx->s.copy    = d3d9_pic_context_copy;
 201     pic_ctx->picsys.surface = surface;
 202     AcquirePictureSys(&pic_ctx->picsys);
 203     return pic_ctx;
 204 }
 205
 206 static struct va_pic_context* NewSurfacePicContext(vlc_va_t *va, int surface_index)
 207 {
 208     directx_sys_t *dx_sys = &va->sys->dx_sys;
 209     struct va_pic_context *pic_ctx = CreatePicContext(dx_sys->hw_surface[surface_index]);
 210     if (unlikely(pic_ctx==NULL))
 211         return NULL;
 212     /* all the resources are acquired during surfaces init, and a second time in
 213      * CreatePicContext(), undo one of them otherwise we need an extra release
 214      * when the pool is emptied */
 215     ReleasePictureSys(&pic_ctx->picsys);
 216     return pic_ctx;
 217 }
 218
 219 static int Get(vlc_va_t *va, picture_t *pic, uint8_t **data)
 220 {
 221     vlc_va_sys_t *sys = va->sys;
 222
 223     /* Check the device */
 224     HRESULT hr = IDirect3DDeviceManager9_TestDevice(sys->devmng, sys->device);
 225     if (hr == DXVA2_E_NEW_VIDEO_DEVICE) {
 226         if (DxResetVideoDecoder(va))
 227             return VLC_EGENERIC;
 228     } else if (FAILED(hr)) {
 229         msg_Err(va, "IDirect3DDeviceManager9_TestDevice %u", (unsigned)hr);
 230         return VLC_EGENERIC;
 231     }
 232
 233     int res = va_pool_Get(&sys->dx_sys.va_pool, pic);
 234     if (likely(res==VLC_SUCCESS))
 235         *data = (uint8_t*)((struct va_pic_context*)pic->context)->picsys.surface;
 236     return res;
 237 }
 238
 239 static void Close(vlc_va_t *va, void **ctx)
 240 {
 241     vlc_va_sys_t *sys = va->sys;
 242
 243     (void) ctx;
 244
 245     directx_va_Close(va, &sys->dx_sys);
 246
 247     if (sys->hd3d9_dll)
 248         FreeLibrary(sys->hd3d9_dll);
 249
 250     free((char *)va->description);
 251     free(sys);
 252 }
 253
 254 static int Open(vlc_va_t *va, AVCodecContext *ctx, enum PixelFormat pix_fmt,
 255                 const es_format_t *fmt, picture_sys_t *p_sys)
 256 {
 257     int err = VLC_EGENERIC;
 258     directx_sys_t *dx_sys;
 259
 260     if (pix_fmt != AV_PIX_FMT_DXVA2_VLD)
 261         return VLC_EGENERIC;
 262
 263     ctx->hwaccel_context = NULL;
 264
 265     vlc_va_sys_t *sys = calloc(1, sizeof (*sys));
 266     if (unlikely(sys == NULL))
 267         return VLC_ENOMEM;
 268
 269     /* Load dll*/
 270     sys->hd3d9_dll = LoadLibrary(TEXT("D3D9.DLL"));
 271     if (!sys->hd3d9_dll) {
 272         msg_Warn(va, "cannot load d3d9.dll");
 273         goto error;
 274     }
 275
 276     dx_sys = &sys->dx_sys;
 277
 278     dx_sys->va_pool.pf_create_device           = D3dCreateDevice;
 279     dx_sys->va_pool.pf_destroy_device          = D3dDestroyDevice;
 280     dx_sys->va_pool.pf_create_device_manager   = D3dCreateDeviceManager;
 281     dx_sys->va_pool.pf_destroy_device_manager  = D3dDestroyDeviceManager;
 282     dx_sys->va_pool.pf_create_video_service    = DxCreateVideoService;
 283     dx_sys->va_pool.pf_destroy_video_service   = DxDestroyVideoService;
 284     dx_sys->va_pool.pf_create_decoder_surfaces = DxCreateVideoDecoder;
 285     dx_sys->va_pool.pf_destroy_surfaces        = DxDestroyVideoDecoder;
 286     dx_sys->va_pool.pf_setup_avcodec_ctx       = SetupAVCodecContext;
 287     dx_sys->va_pool.pf_new_surface_context     = NewSurfacePicContext;
 288     dx_sys->pf_get_input_list          = DxGetInputList;
 289     dx_sys->pf_setup_output            = DxSetupOutput;
 290     dx_sys->psz_decoder_dll            = TEXT("DXVA2.DLL");
 291
 292     va->sys = sys;
 293
 294     dx_sys->d3ddev = NULL;
 295     if (p_sys!=NULL)
 296     {
 297         D3DSURFACE_DESC src;
 298         if (SUCCEEDED(IDirect3DSurface9_GetDesc(p_sys->surface, &src)))
 299             sys->render = src.Format;
 300         IDirect3DSurface9_GetDevice(p_sys->surface, &dx_sys->d3ddev );
 301     }
 302
 303     err = directx_va_Open(va, &sys->dx_sys, true);
 304     if (err!=VLC_SUCCESS)
 305         goto error;
 306
 307     err = directx_va_Setup(va, &sys->dx_sys, ctx, fmt);
 308     if (err != VLC_SUCCESS)
 309         goto error;
 310
 311     ctx->hwaccel_context = &sys->hw;
 312
 313     /* TODO print the hardware name/vendor for debugging purposes */
 314     va->description = DxDescribe(sys);
 315     va->get     = Get;
 316     return VLC_SUCCESS;
 317
 318 error:
 319     Close(va, NULL);
 320     return VLC_EGENERIC;
 321 }
 322 /* */
 323
 324 /**
 325  * It creates a Direct3D device usable for DXVA 2
 326  */
 327 static int D3dCreateDevice(vlc_va_t *va)
 328 {
 329     vlc_va_sys_t *sys = va->sys;
 330
 331     if (sys->dx_sys.d3ddev) {
 332         msg_Dbg(va, "Reusing Direct3D9 device");
 333         IDirect3DDevice9_AddRef(sys->dx_sys.d3ddev);
 334         return VLC_SUCCESS;
 335     }
 336
 337     /* */
 338     LPDIRECT3D9 (WINAPI *Create9)(UINT SDKVersion);
 339     Create9 = (void *)GetProcAddress(sys->hd3d9_dll, "Direct3DCreate9");
 340     if (!Create9) {
 341         msg_Err(va, "Cannot locate reference to Direct3DCreate9 ABI in DLL");
 342         return VLC_EGENERIC;
 343     }
 344
 345     /* */
 346     LPDIRECT3D9 d3dobj;
 347     d3dobj = Create9(D3D_SDK_VERSION);
 348     if (!d3dobj) {
 349         msg_Err(va, "Direct3DCreate9 failed");
 350         return VLC_EGENERIC;
 351     }
 352     sys->d3dobj = d3dobj;
 353
 354     /* */
 355     D3DADAPTER_IDENTIFIER9 *d3dai = &sys->d3dai;
 356     if (FAILED(IDirect3D9_GetAdapterIdentifier(sys->d3dobj,
 357                                                D3DADAPTER_DEFAULT, 0, d3dai))) {
 358         msg_Warn(va, "IDirect3D9_GetAdapterIdentifier failed");
 359         ZeroMemory(d3dai, sizeof(*d3dai));
 360     }
 361
 362     /* */
 363     D3DPRESENT_PARAMETERS d3dpp;
 364     ZeroMemory(&d3dpp, sizeof(d3dpp));
 365     d3dpp.Flags                  = D3DPRESENTFLAG_VIDEO;
 366     d3dpp.Windowed               = TRUE;
 367     d3dpp.hDeviceWindow          = NULL;
 368     d3dpp.SwapEffect             = D3DSWAPEFFECT_DISCARD;
 369     d3dpp.MultiSampleType        = D3DMULTISAMPLE_NONE;
 370     d3dpp.PresentationInterval   = D3DPRESENT_INTERVAL_DEFAULT;
 371     d3dpp.BackBufferCount        = 0;                  /* FIXME what to put here */
 372     d3dpp.BackBufferFormat       = D3DFMT_X8R8G8B8;    /* FIXME what to put here */
 373     d3dpp.BackBufferWidth        = 0;
 374     d3dpp.BackBufferHeight       = 0;
 375     d3dpp.EnableAutoDepthStencil = FALSE;
 376
 377     /* Direct3D needs a HWND to create a device, even without using ::Present
 378     this HWND is used to alert Direct3D when there's a change of focus window.
 379     For now, use GetDesktopWindow, as it looks harmless */
 380     LPDIRECT3DDEVICE9 d3ddev;
 381     if (FAILED(IDirect3D9_CreateDevice(d3dobj, D3DADAPTER_DEFAULT,
 382                                        D3DDEVTYPE_HAL, GetDesktopWindow(),
 383                                        D3DCREATE_SOFTWARE_VERTEXPROCESSING |
 384                                        D3DCREATE_MULTITHREADED,
 385                                        &d3dpp, &d3ddev))) {
 386         msg_Err(va, "IDirect3D9_CreateDevice failed");
 387         return VLC_EGENERIC;
 388     }
 389     sys->dx_sys.d3ddev = d3ddev;
 390
 391     return VLC_SUCCESS;
 392 }
 393
 394 /**
 395  * It releases a Direct3D device and its resources.
 396  */
 397 static void D3dDestroyDevice(vlc_va_t *va)
 398 {
 399     directx_sys_t *dx_sys = &va->sys->dx_sys;
 400     if (va->sys->d3dobj)
 401         IDirect3D9_Release(va->sys->d3dobj);
 402     if (dx_sys->d3ddev)
 403         IDirect3DDevice9_Release(dx_sys->d3ddev);
 404 }
 405 /**
 406  * It describes our Direct3D object
 407  */
 408 static char *DxDescribe(vlc_va_sys_t *va)
 409 {
 410     static const struct {
 411         unsigned id;
 412         char     name[32];
 413     } vendors [] = {
 414         { 0x1002, "ATI" },
 415         { 0x10DE, "NVIDIA" },
 416         { 0x1106, "VIA" },
 417         { 0x8086, "Intel" },
 418         { 0x5333, "S3 Graphics" },
 419         { 0, "" }
 420     };
 421     D3DADAPTER_IDENTIFIER9 *id = &va->d3dai;
 422
 423     const char *vendor = "Unknown";
 424     for (int i = 0; vendors[i].id != 0; i++) {
 425         if (vendors[i].id == id->VendorId) {
 426             vendor = vendors[i].name;
 427             break;
 428         }
 429     }
 430
 431     char *description;
 432     if (asprintf(&description, "DXVA2 (%.*s, vendor %lu(%s), device %lu, revision %lu)",
 433                  (int)sizeof(id->Description), id->Description,
 434                  id->VendorId, vendor, id->DeviceId, id->Revision) < 0)
 435         return NULL;
 436     return description;
 437 }
 438
 439 /**
 440  * It creates a Direct3D device manager
 441  */
 442 static int D3dCreateDeviceManager(vlc_va_t *va)
 443 {
 444     vlc_va_sys_t *sys = va->sys;
 445     directx_sys_t *dx_sys = &va->sys->dx_sys;
 446
 447     HRESULT (WINAPI *CreateDeviceManager9)(UINT *pResetToken,
 448                                            IDirect3DDeviceManager9 **);
 449     CreateDeviceManager9 =
 450       (void *)GetProcAddress(dx_sys->hdecoder_dll,
 451                              "DXVA2CreateDirect3DDeviceManager9");
 452
 453     if (!CreateDeviceManager9) {
 454         msg_Err(va, "cannot load function");
 455         return VLC_EGENERIC;
 456     }
 457     msg_Dbg(va, "OurDirect3DCreateDeviceManager9 Success!");
 458
 459     UINT token;
 460     IDirect3DDeviceManager9 *devmng;
 461     if (FAILED(CreateDeviceManager9(&token, &devmng))) {
 462         msg_Err(va, " OurDirect3DCreateDeviceManager9 failed");
 463         return VLC_EGENERIC;
 464     }
 465     sys->devmng = devmng;
 466     msg_Info(va, "obtained IDirect3DDeviceManager9");
 467
 468     HRESULT hr = IDirect3DDeviceManager9_ResetDevice(devmng, dx_sys->d3ddev, token);
 469     if (FAILED(hr)) {
 470         msg_Err(va, "IDirect3DDeviceManager9_ResetDevice failed: %08x", (unsigned)hr);
 471         return VLC_EGENERIC;
 472     }
 473     return VLC_SUCCESS;
 474 }
 475 /**
 476  * It destroys a Direct3D device manager
 477  */
 478 static void D3dDestroyDeviceManager(vlc_va_t *va)
 479 {
 480     if (va->sys->devmng)
 481         IDirect3DDeviceManager9_Release(va->sys->devmng);
 482 }
 483
 484 /**
 485  * It creates a DirectX video service
 486  */
 487 static int DxCreateVideoService(vlc_va_t *va)
 488 {
 489     vlc_va_sys_t *sys = va->sys;
 490     directx_sys_t *dx_sys = &va->sys->dx_sys;
 491     HRESULT hr;
 492
 493     HANDLE device;
 494     hr = IDirect3DDeviceManager9_OpenDeviceHandle(sys->devmng, &device);
 495     if (FAILED(hr)) {
 496         msg_Err(va, "OpenDeviceHandle failed");
 497         return VLC_EGENERIC;
 498     }
 499     sys->device = device;
 500
 501     void *pv;
 502     hr = IDirect3DDeviceManager9_GetVideoService(sys->devmng, device,
 503                                         &IID_IDirectXVideoDecoderService, &pv);
 504     if (FAILED(hr)) {
 505         msg_Err(va, "GetVideoService failed");
 506         return VLC_EGENERIC;
 507     }
 508     dx_sys->d3ddec = pv;
 509
 510     return VLC_SUCCESS;
 511 }
 512
 513 /**
 514  * It destroys a DirectX video service
 515  */
 516 static void DxDestroyVideoService(vlc_va_t *va)
 517 {
 518     directx_sys_t *dx_sys = &va->sys->dx_sys;
 519     if (va->sys->device)
 520         IDirect3DDeviceManager9_CloseDeviceHandle(va->sys->devmng, va->sys->device);
 521     if (dx_sys->d3ddec)
 522         IDirectXVideoDecoderService_Release(dx_sys->d3ddec);
 523 }
 524
 525 static void ReleaseInputList(input_list_t *p_list)
 526 {
 527     CoTaskMemFree(p_list->list);
 528 }
 529
 530 static int DxGetInputList(vlc_va_t *va, input_list_t *p_list)
 531 {
 532     directx_sys_t *dx_sys = &va->sys->dx_sys;
 533     UINT input_count = 0;
 534     GUID *input_list = NULL;
 535     if (FAILED(IDirectXVideoDecoderService_GetDecoderDeviceGuids(dx_sys->d3ddec,
 536                                                                  &input_count,
 537                                                                  &input_list))) {
 538         msg_Err(va, "IDirectXVideoDecoderService_GetDecoderDeviceGuids failed");
 539         return VLC_EGENERIC;
 540     }
 541
 542     p_list->count = input_count;
 543     p_list->list = input_list;
 544     p_list->pf_release = ReleaseInputList;
 545     return VLC_SUCCESS;
 546 }
 547
 548 static int DxSetupOutput(vlc_va_t *va, const GUID *input, const video_format_t *fmt)
 549 {
 550     VLC_UNUSED(fmt);
 551     int err = VLC_EGENERIC;
 552     UINT      output_count = 0;
 553     D3DFORMAT *output_list = NULL;
 554     if (FAILED(IDirectXVideoDecoderService_GetDecoderRenderTargets(va->sys->dx_sys.d3ddec,
 555                                                                    input,
 556                                                                    &output_count,
 557                                                                    &output_list))) {
 558         msg_Err(va, "IDirectXVideoDecoderService_GetDecoderRenderTargets failed");
 559         return VLC_EGENERIC;
 560     }
 561
 562     for (unsigned j = 0; j < output_count; j++) {
 563         const D3DFORMAT f = output_list[j];
 564         const d3d_format_t *format = D3dFindFormat(f);
 565         if (format) {
 566             msg_Dbg(va, "%s is supported for output", format->name);
 567         } else {
 568             msg_Dbg(va, "%d is supported for output (%4.4s)", f, (const char*)&f);
 569         }
 570     }
 571
 572     /* */
 573     for (unsigned pass = 0; pass < 2 && err != VLC_SUCCESS; ++pass)
 574     {
 575         for (unsigned j = 0; d3d_formats[j].name; j++) {
 576             const d3d_format_t *format = &d3d_formats[j];
 577
 578             /* */
 579             bool is_supported = false;
 580             for (unsigned k = 0; !is_supported && k < output_count; k++) {
 581                 is_supported = format->format == output_list[k];
 582             }
 583             if (!is_supported)
 584                 continue;
 585             if (pass == 0 && format->format != va->sys->render)
 586                 continue;
 587
 588             /* We have our solution */
 589             msg_Dbg(va, "Using decoder output '%s'", format->name);
 590             va->sys->render = format->format;
 591             err = VLC_SUCCESS;
 592             break;
 593         }
 594     }
 595     CoTaskMemFree(output_list);
 596     return err;
 597 }
 598
 599 /**
 600  * It creates a DXVA2 decoder using the given video format
 601  */
 602 static int DxCreateVideoDecoder(vlc_va_t *va, int codec_id,
 603                                 const video_format_t *fmt, unsigned surface_count)
 604 {
 605     vlc_va_sys_t *p_sys = va->sys;
 606     directx_sys_t *sys = &va->sys->dx_sys;
 607     HRESULT hr;
 608
 609     hr = IDirectXVideoDecoderService_CreateSurface(sys->d3ddec,
 610                                                          fmt->i_width,
 611                                                          fmt->i_height,
 612                                                          surface_count - 1,
 613                                                          p_sys->render,
 614                                                          D3DPOOL_DEFAULT,
 615                                                          0,
 616                                                          DXVA2_VideoDecoderRenderTarget,
 617                                                          sys->hw_surface,
 618                                                          NULL);
 619     if (FAILED(hr)) {
 620         msg_Err(va, "IDirectXVideoAccelerationService_CreateSurface %d failed (hr=0x%0lx)", surface_count - 1, hr);
 621         return VLC_EGENERIC;
 622     }
 623     msg_Dbg(va, "IDirectXVideoAccelerationService_CreateSurface succeed with %d surfaces (%dx%d)",
 624             surface_count, fmt->i_width, fmt->i_height);
 625
 626     IDirect3DSurface9 *tstCrash;
 627     hr = IDirectXVideoDecoderService_CreateSurface(sys->d3ddec,
 628                                                          fmt->i_width,
 629                                                          fmt->i_height,
 630                                                          0,
 631                                                          p_sys->render,
 632                                                          D3DPOOL_DEFAULT,
 633                                                          0,
 634                                                          DXVA2_VideoDecoderRenderTarget,
 635                                                          &tstCrash,
 636                                                          NULL);
 637     if (FAILED(hr)) {
 638         msg_Err(va, "extra buffer impossible, avoid a crash (hr=0x%0lx)", hr);
 639         for (unsigned i = 0; i < surface_count; i++)
 640             IDirect3DSurface9_Release( sys->hw_surface[i] );
 641         return VLC_EGENERIC;
 642     }
 643     IDirect3DSurface9_Release(tstCrash);
 644
 645     /* */
 646     DXVA2_VideoDesc dsc;
 647     ZeroMemory(&dsc, sizeof(dsc));
 648     dsc.SampleWidth     = fmt->i_width;
 649     dsc.SampleHeight    = fmt->i_height;
 650     dsc.Format          = p_sys->render;
 651     if (fmt->i_frame_rate > 0 && fmt->i_frame_rate_base > 0) {
 652         dsc.InputSampleFreq.Numerator   = fmt->i_frame_rate;
 653         dsc.InputSampleFreq.Denominator = fmt->i_frame_rate_base;
 654     } else {
 655         dsc.InputSampleFreq.Numerator   = 0;
 656         dsc.InputSampleFreq.Denominator = 0;
 657     }
 658     dsc.OutputFrameFreq = dsc.InputSampleFreq;
 659     dsc.UABProtectionLevel = FALSE;
 660     dsc.Reserved = 0;
 661
 662     /* FIXME I am unsure we can let unknown everywhere */
 663     DXVA2_ExtendedFormat *ext = &dsc.SampleFormat;
 664     ext->SampleFormat = 0;//DXVA2_SampleUnknown;
 665     ext->VideoChromaSubsampling = 0;//DXVA2_VideoChromaSubsampling_Unknown;
 666     ext->NominalRange = 0;//DXVA2_NominalRange_Unknown;
 667     ext->VideoTransferMatrix = 0;//DXVA2_VideoTransferMatrix_Unknown;
 668     ext->VideoLighting = 0;//DXVA2_VideoLighting_Unknown;
 669     ext->VideoPrimaries = 0;//DXVA2_VideoPrimaries_Unknown;
 670     ext->VideoTransferFunction = 0;//DXVA2_VideoTransFunc_Unknown;
 671
 672     /* List all configurations available for the decoder */
 673     UINT                      cfg_count = 0;
 674     DXVA2_ConfigPictureDecode *cfg_list = NULL;
 675     if (FAILED(IDirectXVideoDecoderService_GetDecoderConfigurations(sys->d3ddec,
 676                                                                     &sys->input,
 677                                                                     &dsc,
 678                                                                     NULL,
 679                                                                     &cfg_count,
 680                                                                     &cfg_list))) {
 681         msg_Err(va, "IDirectXVideoDecoderService_GetDecoderConfigurations failed");
 682         for (unsigned i = 0; i < surface_count; i++)
 683             IDirect3DSurface9_Release( sys->hw_surface[i] );
 684         return VLC_EGENERIC;
 685     }
 686     msg_Dbg(va, "we got %d decoder configurations", cfg_count);
 687
 688     /* Select the best decoder configuration */
 689     int cfg_score = 0;
 690     for (unsigned i = 0; i < cfg_count; i++) {
 691         const DXVA2_ConfigPictureDecode *cfg = &cfg_list[i];
 692
 693         /* */
 694         msg_Dbg(va, "configuration[%d] ConfigBitstreamRaw %d",
 695                 i, cfg->ConfigBitstreamRaw);
 696
 697         /* */
 698         int score;
 699         if (cfg->ConfigBitstreamRaw == 1)
 700             score = 1;
 701         else if (codec_id == AV_CODEC_ID_H264 && cfg->ConfigBitstreamRaw == 2)
 702             score = 2;
 703         else
 704             continue;
 705         if (IsEqualGUID(&cfg->guidConfigBitstreamEncryption, &DXVA2_NoEncrypt))
 706             score += 16;
 707
 708         if (cfg_score < score) {
 709             p_sys->cfg = *cfg;
 710             cfg_score = score;
 711         }
 712     }
 713     CoTaskMemFree(cfg_list);
 714     if (cfg_score <= 0) {
 715         msg_Err(va, "Failed to find a supported decoder configuration");
 716         return VLC_EGENERIC;
 717     }
 718
 719     /* Create the decoder */
 720     IDirectXVideoDecoder *decoder;
 721     if (FAILED(IDirectXVideoDecoderService_CreateVideoDecoder(sys->d3ddec,
 722                                                               &sys->input,
 723                                                               &dsc,
 724                                                               &p_sys->cfg,
 725                                                               sys->hw_surface,
 726                                                               surface_count,
 727                                                               &decoder))) {
 728         msg_Err(va, "IDirectXVideoDecoderService_CreateVideoDecoder failed");
 729         for (unsigned i = 0; i < surface_count; i++)
 730             IDirect3DSurface9_Release( sys->hw_surface[i] );
 731         return VLC_EGENERIC;
 732     }
 733     sys->decoder = decoder;
 734
 735     msg_Dbg(va, "IDirectXVideoDecoderService_CreateVideoDecoder succeed");
 736     return VLC_SUCCESS;
 737 }
 738
 739 static void DxDestroyVideoDecoder(vlc_va_t *va)
 740 {
 741     directx_sys_t *dx_sys = &va->sys->dx_sys;
 742     if (dx_sys->decoder)
 743     {
 744         IDirectXVideoDecoder_Release(dx_sys->decoder);
 745         dx_sys->decoder = NULL;
 746         for (unsigned i = 0; i < dx_sys->va_pool.surface_count; i++)
 747             IDirect3DSurface9_Release(dx_sys->hw_surface[i]);
 748     }
 749 }
 750
 751 static int DxResetVideoDecoder(vlc_va_t *va)
 752 {
 753     msg_Err(va, "DxResetVideoDecoder unimplemented");
 754     return VLC_EGENERIC;
 755 }