demux: mp4: avoid audio cuts on seek
[vlc.git] / modules / codec / libass.c
blobcbc0fd2279c74de90c4ae0b24293e975401a97f0
1 /*****************************************************************************
2 * SSA/ASS subtitle decoder using libass.
3 *****************************************************************************
4 * Copyright (C) 2008-2009 VLC authors and VideoLAN
5 * $Id$
7 * Authors: Laurent Aimar <fenrir@videolan.org>
9 * This program is free software; you can redistribute it and/or modify it
10 * under the terms of the GNU Lesser General Public License as published by
11 * the Free Software Foundation; either version 2.1 of the License, or
12 * (at your option) any later version.
14 * This program is distributed in the hope that it will be useful,
15 * but WITHOUT ANY WARRANTY; without even the implied warranty of
16 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17 * GNU Lesser General Public License for more details.
19 * You should have received a copy of the GNU Lesser General Public License
20 * along with this program; if not, write to the Free Software Foundation,
21 * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
22 *****************************************************************************/
24 /*****************************************************************************
25 * Preamble
26 *****************************************************************************/
28 #ifdef HAVE_CONFIG_H
29 # include "config.h"
30 #endif
32 #include <string.h>
33 #include <limits.h>
34 #include <assert.h>
35 #include <math.h>
37 #include <vlc_common.h>
38 #include <vlc_plugin.h>
39 #include <vlc_codec.h>
40 #include <vlc_input.h>
41 #include <vlc_dialog.h>
43 #include <ass/ass.h>
45 #if defined(_WIN32)
46 # include <vlc_charset.h>
47 #endif
49 /*****************************************************************************
50 * Module descriptor
51 *****************************************************************************/
52 static int Create ( vlc_object_t * );
53 static void Destroy( vlc_object_t * );
55 vlc_module_begin ()
56 set_shortname( N_("Subtitles (advanced)"))
57 set_description( N_("Subtitle renderers using libass") )
58 set_capability( "spu decoder", 100 )
59 set_category( CAT_INPUT )
60 set_subcategory( SUBCAT_INPUT_SCODEC )
61 set_callbacks( Create, Destroy )
62 vlc_module_end ()
64 /*****************************************************************************
65 * Local prototypes
66 *****************************************************************************/
67 static int DecodeBlock( decoder_t *, block_t * );
68 static void Flush( decoder_t * );
70 /* */
71 struct decoder_sys_t
73 mtime_t i_max_stop;
75 /* The following fields of decoder_sys_t are shared between decoder and spu units */
76 vlc_mutex_t lock;
77 int i_refcount;
79 /* */
80 ASS_Library *p_library;
81 ASS_Renderer *p_renderer;
82 video_format_t fmt;
84 /* */
85 ASS_Track *p_track;
87 static void DecSysRelease( decoder_sys_t *p_sys );
88 static void DecSysHold( decoder_sys_t *p_sys );
90 /* */
91 static int SubpictureValidate( subpicture_t *,
92 bool, const video_format_t *,
93 bool, const video_format_t *,
94 mtime_t );
95 static void SubpictureUpdate( subpicture_t *,
96 const video_format_t *,
97 const video_format_t *,
98 mtime_t );
99 static void SubpictureDestroy( subpicture_t * );
101 struct subpicture_updater_sys_t
103 decoder_sys_t *p_dec_sys;
104 void *p_subs_data;
105 int i_subs_len;
106 mtime_t i_pts;
108 ASS_Image *p_img;
111 typedef struct
113 int x0;
114 int y0;
115 int x1;
116 int y1;
117 } rectangle_t;
119 static int BuildRegions( rectangle_t *p_region, int i_max_region, ASS_Image *p_img_list, int i_width, int i_height );
120 static void RegionDraw( subpicture_region_t *p_region, ASS_Image *p_img );
122 //#define DEBUG_REGION
124 /*****************************************************************************
125 * Create: Open libass decoder.
126 *****************************************************************************/
127 static int Create( vlc_object_t *p_this )
129 decoder_t *p_dec = (decoder_t *)p_this;
130 decoder_sys_t *p_sys;
132 if( p_dec->fmt_in.i_codec != VLC_CODEC_SSA )
133 return VLC_EGENERIC;
135 p_dec->pf_decode = DecodeBlock;
136 p_dec->pf_flush = Flush;
138 p_dec->p_sys = p_sys = malloc( sizeof( decoder_sys_t ) );
139 if( !p_sys )
140 return VLC_ENOMEM;
142 /* */
143 vlc_mutex_init( &p_sys->lock );
144 p_sys->i_refcount = 1;
145 memset( &p_sys->fmt, 0, sizeof(p_sys->fmt) );
146 p_sys->i_max_stop = VLC_TS_INVALID;
147 p_sys->p_library = NULL;
148 p_sys->p_renderer = NULL;
149 p_sys->p_track = NULL;
151 /* Create libass library */
152 ASS_Library *p_library = p_sys->p_library = ass_library_init();
153 if( !p_library )
155 msg_Warn( p_dec, "Libass library creation failed" );
156 DecSysRelease( p_sys );
157 return VLC_EGENERIC;
160 /* load attachments */
161 input_attachment_t **pp_attachments;
162 int i_attachments;
163 if( decoder_GetInputAttachments( p_dec, &pp_attachments, &i_attachments ))
165 i_attachments = 0;
166 pp_attachments = NULL;
168 for( int k = 0; k < i_attachments; k++ )
170 input_attachment_t *p_attach = pp_attachments[k];
172 bool found = false;
174 /* Check mimetype*/
175 if( !strcasecmp( p_attach->psz_mime, "application/x-truetype-font" ) )
176 found = true;
177 /* Then extension */
178 else if( !found && strlen( p_attach->psz_name ) > 4 )
180 char *ext = p_attach->psz_name + strlen( p_attach->psz_name ) - 4;
182 if( !strcasecmp( ext, ".ttf" ) || !strcasecmp( ext, ".otf" ) || !strcasecmp( ext, ".ttc" ) )
183 found = true;
186 if( found )
188 msg_Dbg( p_dec, "adding embedded font %s", p_attach->psz_name );
190 ass_add_font( p_sys->p_library, p_attach->psz_name, p_attach->p_data, p_attach->i_data );
192 vlc_input_attachment_Delete( p_attach );
194 free( pp_attachments );
196 ass_set_extract_fonts( p_library, true );
197 ass_set_style_overrides( p_library, NULL );
199 /* Create the renderer */
200 ASS_Renderer *p_renderer = p_sys->p_renderer = ass_renderer_init( p_library );
201 if( !p_renderer )
203 msg_Warn( p_dec, "Libass renderer creation failed" );
204 DecSysRelease( p_sys );
205 return VLC_EGENERIC;
208 ass_set_use_margins( p_renderer, false);
209 //if( false )
210 // ass_set_margins( p_renderer, int t, int b, int l, int r);
211 ass_set_font_scale( p_renderer, 1.0 );
212 ass_set_line_spacing( p_renderer, 0.0 );
214 #if defined( __ANDROID__ )
215 const char *psz_font = "/system/fonts/DroidSans-Bold.ttf";
216 const char *psz_family = "Droid Sans Bold";
217 #elif defined( __APPLE__ )
218 const char *psz_font = NULL; /* We don't ship a default font with VLC */
219 const char *psz_family = "Helvetica Neue"; /* Use HN if we can't find anything more suitable - Arial is not on all Apple platforms */
220 #else
221 const char *psz_font = NULL; /* We don't ship a default font with VLC */
222 const char *psz_family = "Arial"; /* Use Arial if we can't find anything more suitable */
223 #endif
225 #ifdef HAVE_FONTCONFIG
226 #if defined(_WIN32)
227 vlc_dialog_id *p_dialog_id =
228 vlc_dialog_display_progress( p_dec, true, 0.0, NULL,
229 _("Building font cache"),
230 _( "Please wait while your font cache is rebuilt.\n"
231 "This should take less than a minute." ) );
232 #endif
233 ass_set_fonts( p_renderer, psz_font, psz_family, 1, NULL, 1 ); // setup default font/family
234 #if defined(_WIN32)
235 if( p_dialog_id != 0 )
236 vlc_dialog_release( p_dec, p_dialog_id );
237 #endif
238 #else
239 ass_set_fonts( p_renderer, psz_font, psz_family, 1, NULL, 1 );
240 #endif
242 /* Anything else than NONE will break smooth img updating.
243 TODO: List and force ASS_HINTING_LIGHT for known problematic fonts */
244 ass_set_hinting( p_renderer, ASS_HINTING_NONE );
246 /* Add a track */
247 ASS_Track *p_track = p_sys->p_track = ass_new_track( p_sys->p_library );
248 if( !p_track )
250 DecSysRelease( p_sys );
251 return VLC_EGENERIC;
253 ass_process_codec_private( p_track, p_dec->fmt_in.p_extra, p_dec->fmt_in.i_extra );
255 p_dec->fmt_out.i_codec = VLC_CODEC_RGBA;
257 return VLC_SUCCESS;
260 /*****************************************************************************
261 * Destroy: finish
262 *****************************************************************************/
263 static void Destroy( vlc_object_t *p_this )
265 decoder_t *p_dec = (decoder_t *)p_this;
267 DecSysRelease( p_dec->p_sys );
270 static void DecSysHold( decoder_sys_t *p_sys )
272 vlc_mutex_lock( &p_sys->lock );
273 p_sys->i_refcount++;
274 vlc_mutex_unlock( &p_sys->lock );
276 static void DecSysRelease( decoder_sys_t *p_sys )
278 /* */
279 vlc_mutex_lock( &p_sys->lock );
280 p_sys->i_refcount--;
281 if( p_sys->i_refcount > 0 )
283 vlc_mutex_unlock( &p_sys->lock );
284 return;
286 vlc_mutex_unlock( &p_sys->lock );
287 vlc_mutex_destroy( &p_sys->lock );
289 if( p_sys->p_track )
290 ass_free_track( p_sys->p_track );
291 if( p_sys->p_renderer )
292 ass_renderer_done( p_sys->p_renderer );
293 if( p_sys->p_library )
294 ass_library_done( p_sys->p_library );
296 free( p_sys );
299 /*****************************************************************************
300 * Flush:
301 *****************************************************************************/
302 static void Flush( decoder_t *p_dec )
304 decoder_sys_t *p_sys = p_dec->p_sys;
306 p_sys->i_max_stop = VLC_TS_INVALID;
309 /****************************************************************************
310 * DecodeBlock:
311 ****************************************************************************/
312 static int DecodeBlock( decoder_t *p_dec, block_t *p_block )
314 decoder_sys_t *p_sys = p_dec->p_sys;
316 subpicture_t *p_spu = NULL;
318 if( p_block == NULL ) /* No Drain */
319 return VLCDEC_SUCCESS;
321 if( p_block->i_flags & BLOCK_FLAG_CORRUPTED )
323 Flush( p_dec );
324 block_Release( p_block );
325 return VLCDEC_SUCCESS;
328 if( p_block->i_buffer == 0 || p_block->p_buffer[0] == '\0' )
330 block_Release( p_block );
331 return VLCDEC_SUCCESS;
334 subpicture_updater_sys_t *p_spu_sys = malloc( sizeof(*p_spu_sys) );
335 if( !p_spu_sys )
337 block_Release( p_block );
338 return VLCDEC_SUCCESS;
341 subpicture_updater_t updater = {
342 .pf_validate = SubpictureValidate,
343 .pf_update = SubpictureUpdate,
344 .pf_destroy = SubpictureDestroy,
345 .p_sys = p_spu_sys,
347 p_spu = decoder_NewSubpicture( p_dec, &updater );
348 if( !p_spu )
350 msg_Warn( p_dec, "can't get spu buffer" );
351 free( p_spu_sys );
352 block_Release( p_block );
353 return VLCDEC_SUCCESS;
356 p_spu_sys->p_img = NULL;
357 p_spu_sys->p_dec_sys = p_sys;
358 p_spu_sys->i_subs_len = p_block->i_buffer;
359 p_spu_sys->p_subs_data = malloc( p_block->i_buffer );
360 p_spu_sys->i_pts = p_block->i_pts;
361 if( !p_spu_sys->p_subs_data )
363 subpicture_Delete( p_spu );
364 block_Release( p_block );
365 return VLCDEC_SUCCESS;
367 memcpy( p_spu_sys->p_subs_data, p_block->p_buffer,
368 p_block->i_buffer );
370 p_spu->i_start = p_block->i_pts;
371 p_spu->i_stop = __MAX( p_sys->i_max_stop, p_block->i_pts + p_block->i_length );
372 p_spu->b_ephemer = true;
373 p_spu->b_absolute = true;
375 p_sys->i_max_stop = p_spu->i_stop;
377 vlc_mutex_lock( &p_sys->lock );
378 if( p_sys->p_track )
380 ass_process_chunk( p_sys->p_track, p_spu_sys->p_subs_data, p_spu_sys->i_subs_len,
381 p_block->i_pts / 1000, p_block->i_length / 1000 );
383 vlc_mutex_unlock( &p_sys->lock );
385 DecSysHold( p_sys ); /* Keep a reference for the returned subpicture */
387 block_Release( p_block );
389 decoder_QueueSub( p_dec, p_spu );
390 return VLCDEC_SUCCESS;
393 /****************************************************************************
395 ****************************************************************************/
396 static int SubpictureValidate( subpicture_t *p_subpic,
397 bool b_fmt_src, const video_format_t *p_fmt_src,
398 bool b_fmt_dst, const video_format_t *p_fmt_dst,
399 mtime_t i_ts )
401 decoder_sys_t *p_sys = p_subpic->updater.p_sys->p_dec_sys;
403 vlc_mutex_lock( &p_sys->lock );
405 video_format_t fmt = *p_fmt_dst;
406 fmt.i_chroma = VLC_CODEC_RGBA;
407 fmt.i_bits_per_pixel = 0;
408 fmt.i_x_offset = 0;
409 fmt.i_y_offset = 0;
410 if( b_fmt_src || b_fmt_dst )
412 ass_set_frame_size( p_sys->p_renderer, fmt.i_visible_width, fmt.i_visible_height );
413 const double src_ratio = (double)p_fmt_src->i_visible_width / p_fmt_src->i_visible_height;
414 const double dst_ratio = (double)p_fmt_dst->i_visible_width / p_fmt_dst->i_visible_height;
415 ass_set_aspect_ratio( p_sys->p_renderer, dst_ratio / src_ratio, 1 );
416 p_sys->fmt = fmt;
419 /* */
420 const mtime_t i_stream_date = p_subpic->updater.p_sys->i_pts + (i_ts - p_subpic->i_start);
421 int i_changed;
422 ASS_Image *p_img = ass_render_frame( p_sys->p_renderer, p_sys->p_track,
423 i_stream_date/1000, &i_changed );
425 if( !i_changed && !b_fmt_src && !b_fmt_dst &&
426 (p_img != NULL) == (p_subpic->p_region != NULL) )
428 vlc_mutex_unlock( &p_sys->lock );
429 return VLC_SUCCESS;
431 p_subpic->updater.p_sys->p_img = p_img;
433 /* The lock is released by SubpictureUpdate */
434 return VLC_EGENERIC;
437 static void SubpictureUpdate( subpicture_t *p_subpic,
438 const video_format_t *p_fmt_src,
439 const video_format_t *p_fmt_dst,
440 mtime_t i_ts )
442 VLC_UNUSED( p_fmt_src ); VLC_UNUSED( p_fmt_dst ); VLC_UNUSED( i_ts );
444 decoder_sys_t *p_sys = p_subpic->updater.p_sys->p_dec_sys;
446 video_format_t fmt = p_sys->fmt;
447 ASS_Image *p_img = p_subpic->updater.p_sys->p_img;
449 /* */
450 p_subpic->i_original_picture_height = fmt.i_visible_height;
451 p_subpic->i_original_picture_width = fmt.i_visible_width;
453 /* XXX to improve efficiency we merge regions that are close minimizing
454 * the lost surface.
455 * libass tends to create a lot of small regions and thus spu engine
456 * reinstanciate a lot the scaler, and as we do not support subpel blending
457 * it looks ugly (text unaligned).
459 const int i_max_region = 4;
460 rectangle_t region[i_max_region];
461 const int i_region = BuildRegions( region, i_max_region, p_img, fmt.i_width, fmt.i_height );
463 if( i_region <= 0 )
465 vlc_mutex_unlock( &p_sys->lock );
466 return;
469 /* Allocate the regions and draw them */
470 subpicture_region_t **pp_region_last = &p_subpic->p_region;
472 for( int i = 0; i < i_region; i++ )
474 subpicture_region_t *r;
475 video_format_t fmt_region;
477 /* */
478 fmt_region = fmt;
479 fmt_region.i_width =
480 fmt_region.i_visible_width = region[i].x1 - region[i].x0;
481 fmt_region.i_height =
482 fmt_region.i_visible_height = region[i].y1 - region[i].y0;
484 r = subpicture_region_New( &fmt_region );
485 if( !r )
486 break;
487 r->i_x = region[i].x0;
488 r->i_y = region[i].y0;
489 r->i_align = SUBPICTURE_ALIGN_TOP | SUBPICTURE_ALIGN_LEFT;
491 /* */
492 RegionDraw( r, p_img );
494 /* */
495 *pp_region_last = r;
496 pp_region_last = &r->p_next;
498 vlc_mutex_unlock( &p_sys->lock );
501 static void SubpictureDestroy( subpicture_t *p_subpic )
503 subpicture_updater_sys_t *p_sys = p_subpic->updater.p_sys;
505 DecSysRelease( p_sys->p_dec_sys );
506 free( p_sys->p_subs_data );
507 free( p_sys );
510 static rectangle_t r_create( int x0, int y0, int x1, int y1 )
512 rectangle_t r = { x0, y0, x1, y1 };
513 return r;
515 static rectangle_t r_img( const ASS_Image *p_img )
517 return r_create( p_img->dst_x, p_img->dst_y, p_img->dst_x+p_img->w, p_img->dst_y+p_img->h );
519 static void r_add( rectangle_t *r, const rectangle_t *n )
521 r->x0 = __MIN( r->x0, n->x0 );
522 r->y0 = __MIN( r->y0, n->y0 );
523 r->x1 = __MAX( r->x1, n->x1 );
524 r->y1 = __MAX( r->y1, n->y1 );
526 static int r_surface( const rectangle_t *r )
528 return (r->x1-r->x0) * (r->y1-r->y0);
530 static bool r_overlap( const rectangle_t *a, const rectangle_t *b, int i_dx, int i_dy )
532 return __MAX(a->x0-i_dx, b->x0) < __MIN( a->x1+i_dx, b->x1 ) &&
533 __MAX(a->y0-i_dy, b->y0) < __MIN( a->y1+i_dy, b->y1 );
536 static int BuildRegions( rectangle_t *p_region, int i_max_region, ASS_Image *p_img_list, int i_width, int i_height )
538 ASS_Image *p_tmp;
539 int i_count;
541 #ifdef DEBUG_REGION
542 int64_t i_ck_start = mdate();
543 #endif
545 for( p_tmp = p_img_list, i_count = 0; p_tmp != NULL; p_tmp = p_tmp->next )
546 if( p_tmp->w > 0 && p_tmp->h > 0 )
547 i_count++;
548 if( i_count <= 0 )
549 return 0;
551 ASS_Image **pp_img = calloc( i_count, sizeof(*pp_img) );
552 if( !pp_img )
553 return 0;
555 for( p_tmp = p_img_list, i_count = 0; p_tmp != NULL; p_tmp = p_tmp->next )
556 if( p_tmp->w > 0 && p_tmp->h > 0 )
557 pp_img[i_count++] = p_tmp;
559 /* */
560 const int i_w_inc = __MAX( ( i_width + 49 ) / 50, 32 );
561 const int i_h_inc = __MAX( ( i_height + 99 ) / 100, 32 );
562 int i_maxh = i_w_inc;
563 int i_maxw = i_h_inc;
564 int i_region;
565 rectangle_t region[i_max_region+1];
567 i_region = 0;
568 for( int i_used = 0; i_used < i_count; )
570 int n;
571 for( n = 0; n < i_count; n++ )
573 if( pp_img[n] )
574 break;
576 assert( i_region < i_max_region + 1 );
577 region[i_region++] = r_img( pp_img[n] );
578 pp_img[n] = NULL; i_used++;
580 bool b_ok;
581 do {
582 b_ok = false;
583 for( n = 0; n < i_count; n++ )
585 ASS_Image *p_img = pp_img[n];
586 if( !p_img )
587 continue;
588 rectangle_t r = r_img( p_img );
590 int k;
591 int i_best = -1;
592 int i_best_s = INT_MAX;
593 for( k = 0; k < i_region; k++ )
595 if( !r_overlap( &region[k], &r, i_maxw, i_maxh ) )
596 continue;
597 int s = r_surface( &r );
598 if( s < i_best_s )
600 i_best_s = s;
601 i_best = k;
604 if( i_best >= 0 )
606 r_add( &region[i_best], &r );
607 pp_img[n] = NULL; i_used++;
608 b_ok = true;
611 } while( b_ok );
613 if( i_region > i_max_region )
615 int i_best_i = -1;
616 int i_best_j = -1;
617 int i_best_ds = INT_MAX;
619 /* merge best */
620 for( int i = 0; i < i_region; i++ )
622 for( int j = i+1; j < i_region; j++ )
624 rectangle_t rect = region[i];
625 r_add( &rect, &region[j] );
626 int ds = r_surface( &rect ) - r_surface( &region[i] ) - r_surface( &region[j] );
628 if( ds < i_best_ds )
630 i_best_i = i;
631 i_best_j = j;
632 i_best_ds = ds;
636 #ifdef DEBUG_REGION
637 msg_Err( p_spu, "Merging %d and %d", i_best_i, i_best_j );
638 #endif
639 if( i_best_j >= 0 && i_best_i >= 0 )
641 r_add( &region[i_best_i], &region[i_best_j] );
643 if( i_best_j+1 < i_region )
644 memmove( &region[i_best_j], &region[i_best_j+1], sizeof(*region) * ( i_region - (i_best_j+1) ) );
645 i_region--;
650 /* */
651 for( int n = 0; n < i_region; n++ )
652 p_region[n] = region[n];
654 #ifdef DEBUG_REGION
655 int64_t i_ck_time = mdate() - i_ck_start;
656 msg_Err( p_spu, "ASS: %d objects merged into %d region in %d micros", i_count, i_region, (int)(i_ck_time) );
657 #endif
659 free( pp_img );
661 return i_region;
664 static void RegionDraw( subpicture_region_t *p_region, ASS_Image *p_img )
666 const plane_t *p = &p_region->p_picture->p[0];
667 const int i_x = p_region->i_x;
668 const int i_y = p_region->i_y;
669 const int i_width = p_region->fmt.i_width;
670 const int i_height = p_region->fmt.i_height;
672 memset( p->p_pixels, 0x00, p->i_pitch * p->i_lines );
673 for( ; p_img != NULL; p_img = p_img->next )
675 if( p_img->dst_x < i_x || p_img->dst_x + p_img->w > i_x + i_width ||
676 p_img->dst_y < i_y || p_img->dst_y + p_img->h > i_y + i_height )
677 continue;
679 const unsigned r = (p_img->color >> 24)&0xff;
680 const unsigned g = (p_img->color >> 16)&0xff;
681 const unsigned b = (p_img->color >> 8)&0xff;
682 const unsigned a = (p_img->color )&0xff;
683 int x, y;
685 for( y = 0; y < p_img->h; y++ )
687 for( x = 0; x < p_img->w; x++ )
689 const unsigned alpha = p_img->bitmap[y*p_img->stride+x];
690 const unsigned an = (255 - a) * alpha / 255;
692 uint8_t *p_rgba = &p->p_pixels[(y+p_img->dst_y-i_y) * p->i_pitch + 4 * (x+p_img->dst_x-i_x)];
693 const unsigned ao = p_rgba[3];
695 /* Native endianness, but RGBA ordering */
696 if( ao == 0 )
698 /* Optimized but the else{} will produce the same result */
699 p_rgba[0] = r;
700 p_rgba[1] = g;
701 p_rgba[2] = b;
702 p_rgba[3] = an;
704 else
706 p_rgba[3] = 255 - ( 255 - p_rgba[3] ) * ( 255 - an ) / 255;
707 if( p_rgba[3] != 0 )
709 p_rgba[0] = ( p_rgba[0] * ao * (255-an) / 255 + r * an ) / p_rgba[3];
710 p_rgba[1] = ( p_rgba[1] * ao * (255-an) / 255 + g * an ) / p_rgba[3];
711 p_rgba[2] = ( p_rgba[2] * ao * (255-an) / 255 + b * an ) / p_rgba[3];
718 #ifdef DEBUG_REGION
719 /* XXX Draw a box for debug */
720 #define P(x,y) ((uint32_t*)&p->p_pixels[(y)*p->i_pitch + 4*(x)])
721 for( int y = 0; y < p->i_lines; y++ )
722 *P(0,y) = *P(p->i_visible_pitch/4-1,y) = 0xff000000;
723 for( int x = 0; x < p->i_visible_pitch; x++ )
724 *P(x/4,0) = *P(x/4,p->i_visible_lines-1) = 0xff000000;
725 #undef P
726 #endif