Cache the parsed value of SafeLogging as an enum.
[tor.git] / contrib / checkSpace.pl
blobdb061a08288ce471ec58652a7fb7aa8a7171d7e9
1 #!/usr/bin/perl -w
3 if ($ARGV[0] =~ /^-/) {
4 $lang = shift @ARGV;
5 $C = ($lang eq '-C');
6 # $TXT = ($lang eq '-txt');
9 for $fn (@ARGV) {
10 open(F, "$fn");
11 $lastnil = 0;
12 $lastline = "";
13 $incomment = 0;
14 while (<F>) {
15 ## Warn about windows-style newlines.
16 if (/\r/) {
17 print " CR:$fn:$.\n";
19 ## Warn about tabs.
20 if (/\t/) {
21 print " TAB:$fn:$.\n";
23 ## Warn about trailing whitespace.
24 if (/ +$/) {
25 print "Space\@EOL:$fn:$.\n";
27 ## Warn about control keywords without following space.
28 if ($C && /\s(?:if|while|for|switch)\(/) {
29 print " KW(:$fn:$.\n";
31 ## Warn about #else #if instead of #elif.
32 if (($lastline =~ /^\# *else/) and ($_ =~ /^\# *if/)) {
33 print " #else#if:$fn:$.\n";
35 $lastline = $_;
36 ## Warn about multiple empty lines.
37 if ($lastnil && /^$/) {
38 print " DoubleNL:$fn:$.\n";
39 } elsif (/^$/) {
40 $lastnil = 1;
41 } else {
42 $lastnil = 0;
44 ## Terminals are still 80 columns wide in my world. I refuse to
45 ## accept double-line lines.
46 if (/^.{80}/) {
47 print " Wide:$fn:$.\n";
49 ### Juju to skip over comments and strings, since the tests
50 ### we're about to do are okay there.
51 if ($C) {
52 if ($incomment) {
53 if (m!\*/!) {
54 s!.*?\*/!!;
55 $incomment = 0;
56 } else {
57 next;
60 if (m!/\*.*?\*/!) {
61 s!\s*/\*.*?\*/!!;
62 } elsif (m!/\*!) {
63 s!\s*/\*!!;
64 $incomment = 1;
65 next;
67 s!"(?:[^\"]+|\\.)*"!"X"!g;
68 next if /^\#/;
69 ## Warn about C++-style comments.
70 if (m!//!) {
71 # print " //:$fn:$.\n";
72 s!//.*!!;
74 ## Warn about unquoted braces preceded by non-space.
75 if (/([^\s'])\{/) {
76 print " $1\{:$fn:$.\n";
78 ## Warn about multiple internal spaces.
79 #if (/[^\s,:]\s{2,}[^\s\\=]/) {
80 # print " X X:$fn:$.\n";
82 ## Warn about { with stuff after.
83 #s/\s+$//;
84 #if (/\{[^\}\\]+$/) {
85 # print " {X:$fn:$.\n";
87 ## Warn about function calls with space before parens.
88 if (/(\w+)\s\(([A-Z]*)/) {
89 if ($1 ne "if" and $1 ne "while" and $1 ne "for" and
90 $1 ne "switch" and $1 ne "return" and $1 ne "int" and
91 $1 ne "elsif" and $1 ne "WINAPI" and $2 ne "WINAPI" and
92 $1 ne "void" and $1 ne "__attribute__") {
93 print " fn ():$fn:$.\n";
96 ## Warn about functions not declared at start of line.
97 if ($in_func_head ||
98 ($fn !~ /\.h$/ && /^[a-zA-Z0-9_]/ &&
99 ! /^(?:const |static )*(?:typedef|struct|union)[^\(]*$/ &&
100 ! /= *\{$/ && ! /;$/)) {
101 if (/.\{$/){
102 print "fn() {:$fn:$.\n";
103 $in_func_head = 0;
104 } elsif (/^\S[^\(]* +\**[a-zA-Z0-9_]+\(/) {
105 $in_func_head = -1; # started with tp fn
106 } elsif (/;$/) {
107 $in_func_head = 0;
108 } elsif (/\{/) {
109 if ($in_func_head == -1) {
110 print "tp fn():$fn:$.\n";
112 $in_func_head = 0;
117 if (! $lastnil) {
118 print " EOL\@EOF:$fn:$.\n";
120 close(F);