repo.or.cz
/
smatch.git
/
search
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
log
|
graphiclog1
|
graphiclog2
|
commit
|
commitdiff
|
tree
|
refs
|
edit
|
fork
first
·
prev
·
next
type_val: update to stree
2014-01-21
Dan Carpenter
helper
:
taki
n
g the add
r
ess
i
s not a comp
l
icated var
i
able
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2014-01-21
Dan Carpente
r
helpe
r
: NULL dereference in get_member_nam
e
(
)
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2014-01-21
Dan Carpenter
extra:
don't save whol
e
ranges in the data
b
ase
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2014-01-21
D
a
n Car
p
enter
db: add semi-c
o
l
o
ns to SQL
s
tatements
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2014-01-21
Dan Carp
e
nter
unknown_va
l
ue: make it a
functi
o
n call instead of a
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2014-01-21
Dan Carpenter
user_data: shift code
for assignments around a bit
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2014-01-21
Dan C
a
rpenter
leak
s
: check kmemdup()
l
e
aks
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2014-01-21
Dan Ca
r
pen
t
er
deref: de
r
efere
n
cing un
i
nitiali
z
e
d wa
r
nings
s
hould
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2014-01-21
D
an Car
p
ente
r
db/function_ptr
.
schem
a
:
a
d
d an
ind
e
x as a s
p
eed up
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2014-01-13
Dan Carpenter
struct
_
assignme
n
t: move
mems
e
t() hand
l
in
g
to
struct
_
assignment
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2014-01-13
Dan Carpenter
struct
_
assignm
e
nt: handle struct as
s
ign
m
ents t
o
bet
t
er
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2014-01-10
D
an Carpenter
flow: global
structs
w
i
t
hout an i
n
itializer are init
i
alized
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2014-01-10
Da
n
C
arpenter
help
e
r:
introduce get_param_nu
m
()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2014-01-06
Dan Carpenter
d
ma_on_st
a
ck: i
g
nore arrays which ar
e
a par
a
met
e
r
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-20
D
a
n
Car
p
enter
smdb
.
py: improv
e
m
e
nts to `sm
d
b
.
py buf_size` and `smdb
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-20
Dan
C
a
rpenter
flow: hid
e
a
bunch of the unreachable warnings u
n
der
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-20
Da
n
C
a
rpente
r
k
ernel
.
silenced_functions: add so
m
e more
"
as
m
goto
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-20
Dan Carpe
n
ter
extra: ass
u
me indexes are in bounds
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-19
Dan Carpenter
flow:
fix
st
r
uc
t
initializati
o
n
b
ug
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-19
D
a
n
Car
p
enter
*
new*
check_a
r
ray_c
o
ndition
.
c
:
a
r
rays can't be NULL
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-19
D
a
n Carpenter
buf_size: store range
s
in the database instead of
s
i
n
g
le
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-19
Dan Carpe
n
ter
strle
n
:
rem
o
ve some blank lin
e
s
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-19
Dan Carpenter
unreachable code: do
n
't warn abo
u
t unreachab
l
e break
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-19
D
a
n Carpe
n
ter
unreachable cod
e
:
don
'
t war
n
about
e
mp
t
y
st
a
teme
n
ts
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-19
D
an Car
p
enter
deb
u
g
:
introduce __s
m
a
tch_buf_size_rl() which is more
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-19
Da
n
Carpen
t
er
debu
g
: add __
s
m
a
tch_membe
r
_nam
e
(
)
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-19
Dan Carpenter
kernel, db: add hweigh
t
()
f
uncti
o
ns to th
e
database
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-19
Dan Ca
r
pent
e
r
kernel,
d
b
:
c
onsi
d
er x = hto
n
l(10)
a
nd x = 10 equivalent
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-19
Dan Carpent
e
r
i
ntr
o
du
c
e:
s
ma
t
ch_data/k
e
rnel
.
n
o
_inline_functions
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-18
D
a
n Carpenter
*new
*
add
s
match_
d
ata/kern
e
l
.
silenced_fu
n
ctions
to
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-17
Dan C
a
rpe
n
ter
common_fu
n
c
ti
o
n
s
.
c
:
handl
e
st
r
len()
and strnlen()
b
etter
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-17
Dan
Car
p
enter
access_ok_
m
ath: rest
r
ic
t
th
i
s ch
e
ck t
o
--spammy output
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-17
Dan Carpenter
*ne
w
* check_cast_assi
g
n
.
c: check casting a
smaller
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-13
Dan Carp
e
n
ter
check_debug: fix crashing bug on
printing non-existant
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-11
Dan Carpenter
buf_size: buffer
a
llocatio
n
s
in the same file are not
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-11
Dan Carpenter
buf_si
z
e:
i
gnore unknown arr
a
y
sizes better
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-11
Dan
C
arpenter
strle
n
: record string
l
engths
across func
t
i
o
n calls
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-06
Da
n
Carpenter
str
l
en:
r
e
c
o
r
d
assigned st
r
i
n
g
s
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-06
Dan Ca
r
penter
s
trlen: add a comment and renam
e
some thing
s
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-06
Dan Carpenter
strlen
:
handle s
t
ring literals
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-06
Dan Carpent
e
r
d
e
bug:
intro
d
uce
__smatch_strl
e
n
()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-06
Dan Ca
r
penter
strle
n
: introdu
c
e get_i
m
p
l
ie
d
_
s
t
r
le
n
()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-06
Dan C
a
rp
e
n
ter
math: revert accident
a
lly committed code
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-06
Dan Carp
e
n
t
er
b
uf_size: read a
ran
g
e_list from the
d
atabase
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-06
Da
n
Carpenter
b
u
f_size: s
t
ore type_size in two tab
l
e
s
the
s
ame as
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-06
Dan Ca
r
penter
buf
_
s
i
ze: m
a
ke size
_
fro
m
_
d
b
(
) work a
g
ain
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-06
D
an Carp
e
nte
r
b
u
f_
s
i
ze,
s
t
r
len: separate
buf_size
a
nd strlen into
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-06
Dan Ca
r
penter
over
f
low: use fuzzy_max t
o
warn
ab
o
u
t array
o
verflows
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-06
Dan C
a
rpenter
m
a
t
h
: fix get_fuzzy_min/max()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-12-06
Dan Carpenter
buf
_
size: repre
s
ent bu
f
fer size
as a ra
n
ge
l
ist instea
d
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-29
Dan Carpenter
b
u
f_
s
ize: hand
l
e p
l
aces that dynamicall
y
aloca
t
e so
m
e
t
imes
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-29
Dan Carp
e
nter
flo
w
: introdu
c
e __in_
f
unction_d
e
f
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-29
Da
n
Carpenter
extra
,
math
:
rework ho
w
fuzzy max is handl
e
d
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-29
Dan Carp
e
nter
buf_
s
i
z
e
: handle
d
ev
m
_kmalloc() alloca
t
ions
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-28
Dan Carpen
t
er
ker
n
el
.
ignored_macros: add RT
_
A
SSERT and SKD_AS
S
ERT
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-28
Da
n
Carpenter
smdb: imp
r
ove "w
h
ere"
o
u
tput
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-28
Da
n
C
arpenter
r
anges
:
introduce rl_has_sva
l
()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-28
Dan Carpenter
helpe
r
: wo
r
k
a
ro
u
nd cr
a
shing bug in get_member_nam
e
()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-28
D
an Carpenter
l
ocal_values: pull co
d
e in
one indent
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-22
Da
n
Carpenter
che
c
k_signed: ignore things
w
ith n
e
gative
n
umber of
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-22
Da
n
Carpenter
fl
o
w: ignore structs and unions in set_unse
t
_to_ze
r
o
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-22
Dan Car
p
e
nter
modification_
h
ooks
:
delete
a
b
l
ank line
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-22
Dan Carp
e
nter
recurse: introduce
has_inc_dec()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-22
Dan Carpen
t
er
type_val: fi
x
a b
u
ild warning
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-22
Dan Carpenter
typ
e
_
v
al: actually run the code
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-22
Dan Carpente
r
s
m
atc
h
: a
co
u
ple
crashing bu
g
s
o
n
invalid
c
ode
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-21
Dan
C
a
rpenter
a
l
low char to be unsigne
d
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-21
Da
n
Carpenter
helper:
impro
v
e is
_
error_re
t
ur
n
()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-21
Dan C
a
rpenter
type_
v
al: i
n
tro
d
u
ce stori
n
g struct member
l
imits
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-21
Dan Carpen
t
e
r
data_
s
ourc
e
: loa
d
where data c
o
mes
fr
o
m into the database
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-21
Dan Carpe
n
ter
.
g
itignore
:
ig
n
ore bak
.
smatch
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-21
Dan C
a
rpent
e
r
db: fixup_kernel
.
sh:
say that we only
h
a
ve 64 C
P
Us
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-21
D
a
n Carpenter
db: preserve unm
e
r
g
ed
s
tates in the
-
>
p
os
s
ible bet
t
er
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-21
Dan Carpenter
db: g
r
ou
p
function
p
ointer re
t
urn s
t
ates
t
ogeth
e
r
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-21
Da
n
C
a
rpenter
d
b: order the return
_
states
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-20
Da
n
Carpent
e
r
d
b
: fixup_kerne
l
.
s
h:
ignore
t
imer_list functio
n
s
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-20
Dan Carpenter
db: fixup_kernel
.
sh: remove some USER_DATA call
s
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-20
Dan Carpenter
db: impro
v
e d
a
t
a
base
d
e
bugging
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-11-14
D
a
n
Carpenter
smatch
.
h:
shift s
o
me stru
c
t me
m
bers around
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-10-25
Dan Carpenter
flow: clear_bu
f
fer: revert pa
r
t
of commit
that uses
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-10-11
D
an Carpenter
f
l
ow: re-w
r
ite how struct members are initi
a
l
ized
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-10-11
Dan Carpen
t
e
r
smatch
_
clear
_
buffer: memcpy() shoul
d
s
e
t the destinatio
n
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-10-11
Dan
C
a
rpenter
s
m
a
t
ch_
c
l
ear
_
bu
f
fer
:
m
ake a functio
n
static
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-10-11
D
an Carpenter
sm
a
t
ch_data/kernel
.
clears_argument: remove mems
e
t()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-10-08
D
a
n Carpenter
flow:
int
r
oduce outside_o
f
_fu
n
ction() to
f
i
x
global
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-09-17
Dan Carpente
r
db: kernel:
ignore
i40e_dbg_netdev_ops_w
r
ite()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-09-16
Dan Carpenter
flow: set members to
zer
o
by
d
e
f
ault
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-09-16
Dan C
a
rpente
r
db, extra, use
r
_d
a
ta: handl
e
: *x = 1
;
return x;"
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-09-16
Dan Carpente
r
u
ser_
d
a
t
a: rem
o
ve
k
memd
u
p_user()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-09-16
D
an Carp
e
nter
u
ser_data: make a functi
o
n s
t
atic
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-09-16
Dan Carpenter
container
_
of: peo
p
le che
c
king the return value of nla_data
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-09-12
Dan C
a
rpe
n
te
r
help
e
r: fix cr
a
shing
b
u
g
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-09-10
Dan Carpenter
user_d
a
t
a
: ma
k
e
a
function stat
i
c
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-09-05
Dan
C
arpenter
math: e
x
p
o
rt get_const_value()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-09-05
Dan C
a
r
penter
math: handle bi
t
wise O
R
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-09-05
Dan Ca
r
penter
mat
h
: handle LE
F
T_SHIFT (a << b)
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-09-05
Dan
Carpe
n
ter
ma
t
h: re
m
ove an impossible con
d
i
tion
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-09-04
D
a
n Carp
e
nter
F
ix
-
-no-data
s
o
i
t
doesn'
t
spew databas
e
errors
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-08-15
Da
n
Carpenter
extra: fix a cr
a
s
h
pars
i
ng invalid code
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2013-08-15
Dan Carpente
r
sizeof: fix typo in err
o
r
mess
a
ge
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
next