repo.or.cz
/
smatch.git
/
search
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
log
|
graphiclog1
|
graphiclog2
|
commit
|
commitdiff
|
tree
|
refs
|
edit
|
fork
first
·
prev
·
next
conditions: ignore known/implied conditions
2015-03-30
Dan Car
p
enter
cond
i
tions:
ignore known/
i
mplied conditions
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-30
Dan
C
arpenter
string
s
: r
e
c
ord string assign
m
e
n
ts
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-30
Dan Carpente
r
str
u
ct_assignment:
s
a
v
e a
lot more information
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-30
Dan Carpenter
param
_
limit/filter: f
i
x a type
bug
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-26
Dan Carpenter
co
m
paris
o
n:
handle
c
an
o
n
i
c
al for loops wit
h
varia
b
le
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-26
Dan Carpent
e
r
comparis
o
n: uns
i
g
n
ed can not be le
s
s than zero
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-26
Dan Carpenter
flo
w
: s
e
t _
_
cur_stmt and
__prev_
s
tmt inside for loops
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-26
Dan
C
arpe
n
ter
comp
a
rison:
m
erging equivalent
states is
not undefined
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-26
Dan Carpent
e
r
comparison
:
fix an i
n
dent
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-20
Dan Carpe
n
ter
function_hooks: f
i
x up d
b
_
c
ompare_ca
l
l
b
a
c
k()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-20
Dan Carpent
e
r
func
t
ion_hooks, d
e
bug: print
i
m
possible r
e
tur
n
s if
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-20
Dan Carp
e
nter
helper: don
'
t
s
t
rip casting in
g
e
t
_a
r
ray_offset
(
)
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-20
D
an Carpenter
links: e
x
port mer
g
e_link
_
states
(
)
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-20
Dan
C
arpe
n
ter
h
e
lper:
m
ake ex
p
r_
t
o_str() prin
t
forced
casts
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-20
Da
n
C
a
r
p
enter
t
y
pe: make t
y
pe_to_str() retu
r
n
a sname(
)
bu
f
f
e
r
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-20
Dan Carpent
e
r
modifi
c
ation_h
o
oks: set a variable
a
s modified when
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-20
D
a
n
Carpenter
user_da
t
a2: tag i
t
if a f
u
nction sets paramete
r
s t
o
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-20
D
an
Carpenter
stack:
cleanup a
f
unction pr
o
totype
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-20
Da
n
Carp
e
nter
deref_ch
e
ck: igno
r
e
arrays
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-18
D
an
C
arpenter
type: make sval_type_ma
x
() defaul
t
to "long long"
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-18
Da
n
Carp
e
nter
type: d
o
n't retu
r
n S
Y
M_NODE types
f
r
o
m get_real_base_type()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-15
Dan Carp
e
n
t
e
r
si
d
e_effe
c
ts: the itera
t
e_all_
k
i
n
ds() macro
has
s
id
e
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-15
D
a
n Carpenter
u
nreachable: don't complain ab
o
ut it
e
r
a
te_al
l
_k
i
nds()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-13
D
an Carpenter
flow
:
fix "foo +=
!
b
a
r;" assignmen
t
s
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-11
Dan
C
arp
e
nte
r
lib: handle -funsigned-char option
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-10
Dan Car
p
enter
k
e
rnel
.
ignore_si
d
e_effects: add
some mac
r
os
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-10
D
an Carp
e
nter
indenting: al
l
ow "break; ca
s
e XXX:"
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-05
Da
n
Carpenter
user_da
t
a2: mar
k
sscan
f
(
) o
u
t
p
ut as user d
a
ta
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-05
Dan Carpenter
ma
t
h, r
l
: fi
x
handing division involving
ne
g
ative nu
m
bers
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-05
Dan Carpenter
sval: fix sval_binop_o
v
erflows()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-05
Da
n
Car
p
enter
p
r
ecede
n
ce: c
o
mp
l
a
in about
"
foo << bar -
baz"
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-04
D
an
C
arpent
e
r
flow:
han
d
le struct in
i
t
i
alization
be
t
ter
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-03
Dan Carpenter
estate: add a NULL check
in es
t
a
tes_e
q
uiv()
commit
|
commitdiff
|
tree
2015-03-03
Dan Car
p
enter
param_used
:
store whe
n
a
p
a
r
am
e
ter is used so we d
o
n
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-02
Dan Carpen
t
er
ext
r
a
:
ignore more
_
_
i
n_fake_ass
i
gn
d
ata
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-02
Da
n
Carpen
t
er
compariso
n
: fi
x
a cr
a
shing bug
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-03-02
Dan C
a
rpenter
type: a
d
d
an expr_
s
igned() function th
a
t mat
c
hes
expr
_
u
nsigned()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-26
Dan C
a
r
p
en
t
er
smdb
.
p
y
:
a
dd functions
t
o
show funct
i
ons implementing
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-26
D
an Carpenter
extra: h
a
n
dl
e
te
m
porary
s
horth
a
nd point
e
rs better
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-26
Dan
C
arpenter
d
e
references_par
a
m: look for pointers used as an arra
y
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-26
D
an Carpente
r
check_indenting:
w
a
r
n
about
m
issing cur
l
y braces and
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-24
Dan Carpenter
par
a
m_cleared: ad
d
a comment
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-24
Dan Carpe
n
ter
validation: corr
e
ct s
o
me out
p
ut
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-23
Dan
C
ar
p
enter
db: build indexes faster
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-23
Dan Car
p
enter
s
li
s
t: fix compile
breakage
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-23
Dan Carpenter
kernel_printf: s
i
l
e
n
c
e some false p
o
sitives usi
n
g smatch_str
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-23
Dan Carpenter
strings: recor
d
which st
r
ings are being used
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-19
Dan Carp
e
nter
use
r
_data2:
turn on s
k
b
-
>data tagging
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-19
D
a
n Carpen
t
er
d
b
: rename
F
ILTER_VAL
U
E, LIMITED_VALUE,
a
nd ADDED_VAL
U
E
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-19
Dan Carpenter
k
ernel_printf: sil
e
nce some "stru
c
t sockaddr "
f
alse
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-19
Da
n
C
arpente
r
type: add
unions to t
y
pe_to_str(
)
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-18
Dan Carpente
r
type_v
a
lue: speed
u
p l
o
ading t
h
e database
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-18
Da
n
C
a
rpenter
*new*
return_cast: complain abou
t
return -EI
N
V
A
L in
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
Dan Carpenter
form
a
t_
s
tring
:
delete t
h
i
s
becau
s
e check_kernel
_
p
r
intf
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
Dan Carp
e
n
ter
f
u
nct
i
o
n_hooks: add
s
ome de
b
ug output
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
Dan Carp
e
n
ter
extra: cleanup db_p
a
ram_add_set()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
Dan Carpenter
e
x
tra: se
p
arate PAR
A
M_LIMIT
a
nd PARAM_
F
IL
T
ER
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
Dan Carpenter
f
u
n
ction_hooks: don't tak
e
a sh
o
rtcut for
"ne
e
dless
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
Dan
C
arpenter
help
e
r: int
r
od
u
ce allo
c
_
stat
e
_str()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
D
an
C
arp
e
nter
math: handle "i
f
(
likel
y
(
1)) {"
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
Dan Carpent
e
r
math: f
i
x/cleanup do_compa
r
ison()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
Dan Carpenter
cap
p
ed: don't record
single values as capped in
t
he
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
Dan Carpenter
db: expo
r
t get_static_filte
r
()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
Dan Carpenter
u
s
er_d
a
ta2: wrong
parameter
t
agge
d
as user data in
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
D
a
n C
a
rp
e
nter
rosenberg: d
e
lete so
m
e
code
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
Dan
C
arpenter
rosenberg: strip away
some
c
a
sting (eliminates
a
fals
e
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
Dan Carpenter
rosenberg: d
o
n't
save unneeded states
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
D
an Carpenter
b
u
f_size: don't sav
e
u
s
eless infor
m
ation
in th
e
database
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
Dan Carpenter
st
r
u
c
t_assig
n
ment:
i
gnore more fak
e
ass
i
gnme
n
ts
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-17
D
a
n
Carpenter
sli
s
t: fi
x
debugging output
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-16
Dan Carpe
n
ter
para
m
_clea
r
ed,
r
osenberg:
add
u
n
d
ersco
r
ed
m
emse
t
/cpy
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-16
Dan
C
arpenter
param_filter/se
t
:
don't r
e
cor
d
fake
a
ssignments
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-16
Da
n
Carpent
e
r
slis
t
, d
e
buggi
n
g: don't print -
>
p
o
ssible list if t
h
ere
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-16
Dan Car
p
enter
type
_
val: ad
d
more stuff
t
o
ignore
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-16
Dan C
a
rpenter
db/
r
eload_
p
ar
t
ial
.
sh: c
h
ange database info for one
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-13
D
an Carpenter
k
ernel_printf: put
l
ot
s
of
s
i
ngl
e
quotes
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-13
Dan
C
ar
p
enter
Merge branch
'
devel3'
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-12
Da
n
Carpente
r
check_ke
r
nel_printf
.
c: Simplify recursive calling
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-12
Dan
C
arpen
t
er
k
ernel_printf: allow
'
\b' if
i
t's the first
c
harac
t
e
r
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-12
Dan
C
arpenter
v
alid
a
tion/sm_
r
osenb
e
rg
.
c
: d
o
n't pas
s
an
uni
n
iti
a
lized
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-12
Dan Carpenter
kernel
_
printf: add som
e
more quotes
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-12
D
a
n Carpent
e
r
kernel_printf: move
a
wa
r
ning under
t
he --spammy flag
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-12
Dan Carpenter
kernel_
p
rintf: add
some quotes around the function
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-12
Dan C
a
rpe
n
ter
kerne_
p
r
intf:
'%pb' is valid
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-02-11
D
a
n Carpenter
wrong_si
z
e_arg: war
n
a
bout "if (memcmp(f
o
o, b
a
r
, siz
e
of
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-01-30
Da
n
Carp
e
n
t
er
struc
t
_assign
m
e
nt: remove a bl
a
nk line
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-01-30
Dan
C
arpent
e
r
sval:
h
andle
L
E
FTSHIFTs in sva
l
_
binop_overflows()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-01-30
D
a
n Carpen
t
e
r
sval: c
a
st the r
e
sult in sval_bino
p
()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-01-30
Dan Carpe
n
t
e
r
type_v
a
l: upda
t
e to
h
a
ndle
PARAM_SET f
r
om the db
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-01-30
Dan
C
arpenter
type_val
:
ignore
k
ma
l
lo
c
()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-01-30
Dan C
a
rpe
n
ter
type_val: ignore
a
ll the "for_each
"
ma
c
r
o
s
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-01-30
Dan C
a
rpenter
user_d
a
t
a2: r
e
move some d
e
bug
code
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-01-29
Da
n
Carp
e
nter
help
e
r: i
n
troduce
inver
t
_
o
p()
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-01-22
Dan
Carpenter
ranges:
break
t
h
e ran
g
e lis
t
parsing
into a separate
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-01-22
Da
n
Carpent
e
r
ran
g
es
:
p
repare to change a
s
tri
n
g t
o
an estate i
n
stea
d
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-01-22
Dan C
a
rpenter
m
odific
a
tion_hooks: add PAR
A
M_SET
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-01-21
Dan Carpenter
par
a
m_cle
a
red: clearing
a
m
e
mber is
not clear
i
n
g a
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-01-21
Dan Ca
r
penter
ty
p
e_
v
al: i
g
no
r
e
fake member
a
ssi
g
nments
f
r
o
m u
n
cast
e
d
.
.
.
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-01-19
Dan
C
arpenter
type_valu
e
:
list_entry is safe as well
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
2015-01-19
Dan Carpenter
db
:
use saved return esta
t
e instead of
s
earching t
h
e db
Signed-off-by:
Dan Carpenter
<dan.carpenter@oracle.com>
commit
|
commitdiff
|
tree
next