| commit | cbaabe0a71f079030baa406b3e1fe9e0ca7e785a | |
| author | Dan Carpenter <dan.carpenter@oracle.com> | |
| Thu, 20 Apr 2017 11:29:39 +0000 (20 14:29 +0300) | ||
| committer | Dan Carpenter <dan.carpenter@oracle.com> | |
| Thu, 20 Apr 2017 11:29:39 +0000 (20 14:29 +0300) | ||
| tree | 0db9966ba33890fd2392c9553879d5949e81d4cf | treesnapshot (tar.gz zip) |
| parent | b11c9d562a2aa89e7feb97f95eb9e6da7bbf56d4 | commitdiff |
balanced: delete this check
The idea here was that it would be an easy way to list functions that need
to be balanced such as lock/unlock, get/put etc. But in real life and
especially in the kernel that model is too simplistic to be worth while.
We only ever checked local_bh_disable/enable. It worked badly and
generated a false positive if we enabled first and then disabled. These
kinds of bugs are already caught by check_locking.c so it's duplicative.
Reported-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
The idea here was that it would be an easy way to list functions that need
to be balanced such as lock/unlock, get/put etc. But in real life and
especially in the kernel that model is too simplistic to be worth while.
We only ever checked local_bh_disable/enable. It worked badly and
generated a false positive if we enabled first and then disabled. These
kinds of bugs are already caught by check_locking.c so it's duplicative.
Reported-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
| check_balanced.c | [deleted file] | blobblamehistory |
| check_list.h | diffblobblamehistory | |
| smatch_data/kernel.balanced_funcs | [deleted file] | blobblamehistory |