| commit | 866a111524feed5bd9e827190856a9f394cba21f | |
| author | Dan Carpenter <dan.carpenter@oracle.com> | |
| Wed, 28 Jul 2021 11:20:19 +0000 (28 14:20 +0300) | ||
| committer | Dan Carpenter <dan.carpenter@oracle.com> | |
| Wed, 28 Jul 2021 11:20:19 +0000 (28 14:20 +0300) | ||
| tree | 27cb3bb0fd308154a854502f828b3acbf27f77f4 | treesnapshot (tar.gz zip) |
| parent | 51e4832c97690626a5b789058b58703ffa560251 | commitdiff |
ssa: fix the modification hook
The modification hook was trying to work around a theoretical ordering
issue with the assignment hook but actually there isn't really an issue at
all. We need to do the modification hook first (which is fine because
the modification hooks are already done very near the start) then checks
can set the state of expr->left, then in the assignment hook we can test
if the any checks set changed it from &undefined to something new.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
The modification hook was trying to work around a theoretical ordering
issue with the assignment hook but actually there isn't really an issue at
all. We need to do the modification hook first (which is fine because
the modification hooks are already done very near the start) then checks
can set the state of expr->left, then in the assignment hook we can test
if the any checks set changed it from &undefined to something new.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
| smatch_ssa.c | diffblobblamehistory |