extra: delete match_untracked_array()
commit7bf65c33053fd45fecc9649810a9d670898eb602
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 5 Oct 2017 07:34:56 +0000 (5 10:34 +0300)
committerDan Carpenter <dan.carpenter@oracle.com>
Thu, 5 Oct 2017 07:34:56 +0000 (5 10:34 +0300)
treeaa98c4641e0144d8b7783c4bdf7682e1ca311b3c
parent96f1aaafba16c96c59c5b693267929918d9936f2
extra: delete match_untracked_array()

I'm not sure using smatch_untracked is appropriate here.  Say we pass a
pointer "p" to a function assigned "foo->bar = p;" then we mark that
as untracked.

And sure, we *might* lose track of it, but mostly likely it's just saved
for later and not changed.  So it's better to assume that we still know the
value of "p->x;" or whatever.  This fixes a false postive:

drivers/media/usb/pulse8-cec/pulse8-cec.c:685 pulse8_connect() error: 'pulse8->adap' dereferencing possible ERR_PTR()

The check uses smatch_extra to see if a variable can possibly be in the
error pointer range, so in the original code smatch_extra says "I don't
know, it could be anything".

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch_extra.c