extra: fix some error pointer handling
commit6193b3b71beb0ee2f3482202c35f6ee6ae3edac2
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 19 Nov 2020 13:13:49 +0000 (19 16:13 +0300)
committerDan Carpenter <dan.carpenter@oracle.com>
Thu, 19 Nov 2020 13:13:49 +0000 (19 16:13 +0300)
tree2665214c6d3b33fc49570af800dbc8e7072525b7
parenta31bd40d340446234c82a6020e7ad6011a4577eb
extra: fix some error pointer handling

The truth is, I slightly don't remember what the bug is here.  It had
to do with error pointers...

The thinking behind the basically_the_same() function was that if we
call a function with an unknown pointer and at the end then we know the
pointer is either valid or NULL, then have we learned anything?  And the
answer that I thought initially was that "no, we haven't learned anything
worthwhile.  Ignore those results and preserve the original state."

But it turns out that it could also be an error pointer.  I knew that, of
course, when I originally wrote this code but I under estimated how
important that is.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch_extra.c