| commit | 504db4f71b9fe907efe8518ad27d1b9bf5554a87 | |
| author | Dan Carpenter <dan.carpenter@linaro.org> | |
| Fri, 24 May 2024 08:41:17 +0000 (24 11:41 +0300) | ||
| committer | Dan Carpenter <dan.carpenter@linaro.org> | |
| Fri, 24 May 2024 08:41:17 +0000 (24 11:41 +0300) | ||
| tree | 860f7949dee401c13c3854782c0dee33dbcf7477 | treesnapshot (tar.gz zip) |
| parent | 6a28f0fb3e98bc756475efc96f7da0919c3ce534 | commitdiff |
mixing_irq_and_irqsave: warn about mixing _irq() and _irqsave()
It seldom makes sense to mix spinlock_irq() and spinlock_irqsave(). The
one is for when we know IRQs are not disabled and the other is for when
they are. It can't be both.
These warning are mostly not bugs, but just places which should be changed
to _irq(). Except changing to _irgsave() is potentially safer. The point
is the either works. It's just sloppy and wrong to mix them.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
It seldom makes sense to mix spinlock_irq() and spinlock_irqsave(). The
one is for when we know IRQs are not disabled and the other is for when
they are. It can't be both.
These warning are mostly not bugs, but just places which should be changed
to _irq(). Except changing to _irgsave() is potentially safer. The point
is the either works. It's just sloppy and wrong to mix them.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
| check_list.h | diffblobblamehistory | |
| check_mixing_irq_and_irqsave.c | [new file with mode: 0644] | blob |