| commit | 47ee2f6424393f7a1a0b9732985d2326882337c9 | |
| author | Dan Carpenter <dan.carpenter@linaro.org> | |
| Fri, 22 Mar 2024 10:36:22 +0000 (22 13:36 +0300) | ||
| committer | Dan Carpenter <dan.carpenter@linaro.org> | |
| Fri, 22 Mar 2024 10:36:22 +0000 (22 13:36 +0300) | ||
| tree | 31bd47ed0f917e3533789250d516da4f7e63fed6 | treesnapshot (tar.gz zip) |
| parent | 58c19ea6761336444a02804edf5d466cb235c298 | commitdiff |
db: fix splitting implications
How this looks like to the user, is that you end up losing some return
states. In one particular example, Smatch said that xt_mttg_seq_next()
always dereferences *ppos, but actually there is a if statement. We lost
those states.
Originally ->merged states were not leaf states but then when we started
faking states that changed and now we have ->leaf and is_leaf() to mark
leaf states. This code should be using is_leaf() too look for leaf states
instead of checking ->merged.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
How this looks like to the user, is that you end up losing some return
states. In one particular example, Smatch said that xt_mttg_seq_next()
always dereferences *ppos, but actually there is a if statement. We lost
those states.
Originally ->merged states were not leaf states but then when we started
faking states that changed and now we have ->leaf and is_leaf() to mark
leaf states. This code should be using is_leaf() too look for leaf states
instead of checking ->merged.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
| smatch_db.c | diffblobblamehistory |