| commit | 3ce5a5b88def9da7fdf11f359a60c3f52d4a0830 | |
| author | Dan Carpenter <dan.carpenter@oracle.com> | |
| Wed, 13 Jun 2018 14:21:40 +0000 (13 17:21 +0300) | ||
| committer | Dan Carpenter <dan.carpenter@oracle.com> | |
| Wed, 13 Jun 2018 14:21:40 +0000 (13 17:21 +0300) | ||
| tree | 0bc2f632fcf8d9f801458aaa742e682e00e57fc6 | treesnapshot (tar.gz zip) |
| parent | 449cbe445a77da05c9be0f2589e8f2edc8023a70 | commitdiff |
user_data: silence some more ntohl(foo[i]); false positives
Say you had code like:
ntohl(foo[i]);
Then the problem is that Smatch marks everything from ntohl() as user
controlled. But the "i" offset into the foo[] array does not come from
ntohl() so it shouldn't be marked as user data. So we want to take the
parent and see if it's inside the macro.
TBH, I forget the exact details with this... Sorry.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Say you had code like:
ntohl(foo[i]);
Then the problem is that Smatch marks everything from ntohl() as user
controlled. But the "i" offset into the foo[] array does not come from
ntohl() so it shouldn't be marked as user data. So we want to take the
parent and see if it's inside the macro.
TBH, I forget the exact details with this... Sorry.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
| check_user_data2.c | diffblobblamehistory |