| commit | f250a42ddaee042ad2eb02022a3ebd18fcf987de | |
| author | Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | |
| Tue, 16 May 2017 09:45:29 +0000 (16 12:45 +0300) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Tue, 6 Jun 2017 18:18:35 +0000 (6 20:18 +0200) | ||
| tree | bb2c0a70e07002bebd2331c9f57d47442be3aed0 | treesnapshot (tar.gz zip) |
| parent | 7e6478e7d4f2c4b607069bf488d57089a9d3244b | commitdiff |
nbd: strict nbd_wr_syncv
nbd_wr_syncv is called either from coroutine or from client negotiation
code, when socket is in blocking mode. So, -EAGAIN is impossible.
Furthermore, EAGAIN is confusing, as, what to read/write again? With
EAGAIN as a return code we don't know how much data is already
read or written by the function, so in case of EAGAIN the whole
communication is broken.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20170516094533.6160-2-vsementsov@virtuozzo.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
nbd_wr_syncv is called either from coroutine or from client negotiation
code, when socket is in blocking mode. So, -EAGAIN is impossible.
Furthermore, EAGAIN is confusing, as, what to read/write again? With
EAGAIN as a return code we don't know how much data is already
read or written by the function, so in case of EAGAIN the whole
communication is broken.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20170516094533.6160-2-vsementsov@virtuozzo.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| nbd/common.c | diffblobblamehistory |