qcow: fix a reference leak
commit41b6513436d2ebb64c7df8f009f630922a8e8990
authorKONRAD Frederic <frederic.konrad@adacore.com>
Wed, 25 Jul 2018 18:07:29 +0000 (25 20:07 +0200)
committerKevin Wolf <kwolf@redhat.com>
Mon, 30 Jul 2018 13:35:37 +0000 (30 15:35 +0200)
tree3d8cf976a3abc9027f2230d0a86fc327c7a126d8
parent6d9dd5fb9d0e9f4a174f53a0e20a39fbe809c71e
qcow: fix a reference leak

Since 42a3e1ab367cdf38cce093de24eb406b99a4ef96 qemu asserts when using the
vvfat driver:

git clone git://qemu.org/qemu.git
cd qemu
./configure --target-list=ppc-softmmu --enable-debug
make -j8
mkdir foo
touch foo/hello
./ppc-softmmu/qemu-system-ppc -M prep --nographic --monitor null             \
                              -hda fat:rw:./foo

"Ctrl-C"

qemu-system-ppc: block.c:3368: bdrv_close_all: Assertion                     \
   `((&all_bdrv_states)->tqh_first == ((void *)0))' failed.

This is because we reference bs twice in qcow_co_create(..) one time in
bdrv_open_blockdev_ref(..) and in blk_insert_bs(..) but we unref it only once
in blk_unref which leads to the reference leak.

Note that I didn't tested much QCOW after this change as I don't use it much.

Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/qcow.c