Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging
[qemu/armbru.git] / hw / vfio / igd.c
blobb31ee79c60b5e567f84f561cfb63849960648340
1 /*
2 * IGD device quirks
4 * Copyright Red Hat, Inc. 2016
6 * Authors:
7 * Alex Williamson <alex.williamson@redhat.com>
9 * This work is licensed under the terms of the GNU GPL, version 2. See
10 * the COPYING file in the top-level directory.
13 #include "qemu/osdep.h"
14 #include "qemu/units.h"
15 #include "qemu/error-report.h"
16 #include "qapi/error.h"
17 #include "hw/hw.h"
18 #include "hw/nvram/fw_cfg.h"
19 #include "pci.h"
20 #include "trace.h"
23 * Intel IGD support
25 * Obviously IGD is not a discrete device, this is evidenced not only by it
26 * being integrated into the CPU, but by the various chipset and BIOS
27 * dependencies that it brings along with it. Intel is trying to move away
28 * from this and Broadwell and newer devices can run in what Intel calls
29 * "Universal Pass-Through" mode, or UPT. Theoretically in UPT mode, nothing
30 * more is required beyond assigning the IGD device to a VM. There are
31 * however support limitations to this mode. It only supports IGD as a
32 * secondary graphics device in the VM and it doesn't officially support any
33 * physical outputs.
35 * The code here attempts to enable what we'll call legacy mode assignment,
36 * IGD retains most of the capabilities we expect for it to have on bare
37 * metal. To enable this mode, the IGD device must be assigned to the VM
38 * at PCI address 00:02.0, it must have a ROM, it very likely needs VGA
39 * support, we must have VM BIOS support for reserving and populating some
40 * of the required tables, and we need to tweak the chipset with revisions
41 * and IDs and an LPC/ISA bridge device. The intention is to make all of
42 * this happen automatically by installing the device at the correct VM PCI
43 * bus address. If any of the conditions are not met, we cross our fingers
44 * and hope the user knows better.
46 * NB - It is possible to enable physical outputs in UPT mode by supplying
47 * an OpRegion table. We don't do this by default because the guest driver
48 * behaves differently if an OpRegion is provided and no monitor is attached
49 * vs no OpRegion and a monitor being attached or not. Effectively, if a
50 * headless setup is desired, the OpRegion gets in the way of that.
54 * This presumes the device is already known to be an Intel VGA device, so we
55 * take liberties in which device ID bits match which generation. This should
56 * not be taken as an indication that all the devices are supported, or even
57 * supportable, some of them don't even support VT-d.
58 * See linux:include/drm/i915_pciids.h for IDs.
60 static int igd_gen(VFIOPCIDevice *vdev)
62 if ((vdev->device_id & 0xfff) == 0xa84) {
63 return 8; /* Broxton */
66 switch (vdev->device_id & 0xff00) {
67 /* Old, untested, unavailable, unknown */
68 case 0x0000:
69 case 0x2500:
70 case 0x2700:
71 case 0x2900:
72 case 0x2a00:
73 case 0x2e00:
74 case 0x3500:
75 case 0xa000:
76 return -1;
77 /* SandyBridge, IvyBridge, ValleyView, Haswell */
78 case 0x0100:
79 case 0x0400:
80 case 0x0a00:
81 case 0x0c00:
82 case 0x0d00:
83 case 0x0f00:
84 return 6;
85 /* BroadWell, CherryView, SkyLake, KabyLake */
86 case 0x1600:
87 case 0x1900:
88 case 0x2200:
89 case 0x5900:
90 return 8;
93 return 8; /* Assume newer is compatible */
96 typedef struct VFIOIGDQuirk {
97 struct VFIOPCIDevice *vdev;
98 uint32_t index;
99 uint32_t bdsm;
100 } VFIOIGDQuirk;
102 #define IGD_GMCH 0x50 /* Graphics Control Register */
103 #define IGD_BDSM 0x5c /* Base Data of Stolen Memory */
107 * The rather short list of registers that we copy from the host devices.
108 * The LPC/ISA bridge values are definitely needed to support the vBIOS, the
109 * host bridge values may or may not be needed depending on the guest OS.
110 * Since we're only munging revision and subsystem values on the host bridge,
111 * we don't require our own device. The LPC/ISA bridge needs to be our very
112 * own though.
114 typedef struct {
115 uint8_t offset;
116 uint8_t len;
117 } IGDHostInfo;
119 static const IGDHostInfo igd_host_bridge_infos[] = {
120 {PCI_REVISION_ID, 2},
121 {PCI_SUBSYSTEM_VENDOR_ID, 2},
122 {PCI_SUBSYSTEM_ID, 2},
125 static const IGDHostInfo igd_lpc_bridge_infos[] = {
126 {PCI_VENDOR_ID, 2},
127 {PCI_DEVICE_ID, 2},
128 {PCI_REVISION_ID, 2},
129 {PCI_SUBSYSTEM_VENDOR_ID, 2},
130 {PCI_SUBSYSTEM_ID, 2},
133 static int vfio_pci_igd_copy(VFIOPCIDevice *vdev, PCIDevice *pdev,
134 struct vfio_region_info *info,
135 const IGDHostInfo *list, int len)
137 int i, ret;
139 for (i = 0; i < len; i++) {
140 ret = pread(vdev->vbasedev.fd, pdev->config + list[i].offset,
141 list[i].len, info->offset + list[i].offset);
142 if (ret != list[i].len) {
143 error_report("IGD copy failed: %m");
144 return -errno;
148 return 0;
152 * Stuff a few values into the host bridge.
154 static int vfio_pci_igd_host_init(VFIOPCIDevice *vdev,
155 struct vfio_region_info *info)
157 PCIBus *bus;
158 PCIDevice *host_bridge;
159 int ret;
161 bus = pci_device_root_bus(&vdev->pdev);
162 host_bridge = pci_find_device(bus, 0, PCI_DEVFN(0, 0));
164 if (!host_bridge) {
165 error_report("Can't find host bridge");
166 return -ENODEV;
169 ret = vfio_pci_igd_copy(vdev, host_bridge, info, igd_host_bridge_infos,
170 ARRAY_SIZE(igd_host_bridge_infos));
171 if (!ret) {
172 trace_vfio_pci_igd_host_bridge_enabled(vdev->vbasedev.name);
175 return ret;
179 * IGD LPC/ISA bridge support code. The vBIOS needs this, but we can't write
180 * arbitrary values into just any bridge, so we must create our own. We try
181 * to handle if the user has created it for us, which they might want to do
182 * to enable multifunction so we don't occupy the whole PCI slot.
184 static void vfio_pci_igd_lpc_bridge_realize(PCIDevice *pdev, Error **errp)
186 if (pdev->devfn != PCI_DEVFN(0x1f, 0)) {
187 error_setg(errp, "VFIO dummy ISA/LPC bridge must have address 1f.0");
191 static void vfio_pci_igd_lpc_bridge_class_init(ObjectClass *klass, void *data)
193 DeviceClass *dc = DEVICE_CLASS(klass);
194 PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
196 set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
197 dc->desc = "VFIO dummy ISA/LPC bridge for IGD assignment";
198 dc->hotpluggable = false;
199 k->realize = vfio_pci_igd_lpc_bridge_realize;
200 k->class_id = PCI_CLASS_BRIDGE_ISA;
203 static const TypeInfo vfio_pci_igd_lpc_bridge_info = {
204 .name = "vfio-pci-igd-lpc-bridge",
205 .parent = TYPE_PCI_DEVICE,
206 .class_init = vfio_pci_igd_lpc_bridge_class_init,
207 .interfaces = (InterfaceInfo[]) {
208 { INTERFACE_CONVENTIONAL_PCI_DEVICE },
209 { },
213 static void vfio_pci_igd_register_types(void)
215 type_register_static(&vfio_pci_igd_lpc_bridge_info);
218 type_init(vfio_pci_igd_register_types)
220 static int vfio_pci_igd_lpc_init(VFIOPCIDevice *vdev,
221 struct vfio_region_info *info)
223 PCIDevice *lpc_bridge;
224 int ret;
226 lpc_bridge = pci_find_device(pci_device_root_bus(&vdev->pdev),
227 0, PCI_DEVFN(0x1f, 0));
228 if (!lpc_bridge) {
229 lpc_bridge = pci_create_simple(pci_device_root_bus(&vdev->pdev),
230 PCI_DEVFN(0x1f, 0), "vfio-pci-igd-lpc-bridge");
233 ret = vfio_pci_igd_copy(vdev, lpc_bridge, info, igd_lpc_bridge_infos,
234 ARRAY_SIZE(igd_lpc_bridge_infos));
235 if (!ret) {
236 trace_vfio_pci_igd_lpc_bridge_enabled(vdev->vbasedev.name);
239 return ret;
243 * IGD Gen8 and newer support up to 8MB for the GTT and use a 64bit PTE
244 * entry, older IGDs use 2MB and 32bit. Each PTE maps a 4k page. Therefore
245 * we either have 2M/4k * 4 = 2k or 8M/4k * 8 = 16k as the maximum iobar index
246 * for programming the GTT.
248 * See linux:include/drm/i915_drm.h for shift and mask values.
250 static int vfio_igd_gtt_max(VFIOPCIDevice *vdev)
252 uint32_t gmch = vfio_pci_read_config(&vdev->pdev, IGD_GMCH, sizeof(gmch));
253 int ggms, gen = igd_gen(vdev);
255 gmch = vfio_pci_read_config(&vdev->pdev, IGD_GMCH, sizeof(gmch));
256 ggms = (gmch >> (gen < 8 ? 8 : 6)) & 0x3;
257 if (gen > 6) {
258 ggms = 1 << ggms;
261 ggms *= MiB;
263 return (ggms / (4 * KiB)) * (gen < 8 ? 4 : 8);
267 * The IGD ROM will make use of stolen memory (GGMS) for support of VESA modes.
268 * Somehow the host stolen memory range is used for this, but how the ROM gets
269 * it is a mystery, perhaps it's hardcoded into the ROM. Thankfully though, it
270 * reprograms the GTT through the IOBAR where we can trap it and transpose the
271 * programming to the VM allocated buffer. That buffer gets reserved by the VM
272 * firmware via the fw_cfg entry added below. Here we're just monitoring the
273 * IOBAR address and data registers to detect a write sequence targeting the
274 * GTTADR. This code is developed by observed behavior and doesn't have a
275 * direct spec reference, unfortunately.
277 static uint64_t vfio_igd_quirk_data_read(void *opaque,
278 hwaddr addr, unsigned size)
280 VFIOIGDQuirk *igd = opaque;
281 VFIOPCIDevice *vdev = igd->vdev;
283 igd->index = ~0;
285 return vfio_region_read(&vdev->bars[4].region, addr + 4, size);
288 static void vfio_igd_quirk_data_write(void *opaque, hwaddr addr,
289 uint64_t data, unsigned size)
291 VFIOIGDQuirk *igd = opaque;
292 VFIOPCIDevice *vdev = igd->vdev;
293 uint64_t val = data;
294 int gen = igd_gen(vdev);
297 * Programming the GGMS starts at index 0x1 and uses every 4th index (ie.
298 * 0x1, 0x5, 0x9, 0xd,...). For pre-Gen8 each 4-byte write is a whole PTE
299 * entry, with 0th bit enable set. For Gen8 and up, PTEs are 64bit, so
300 * entries 0x5 & 0xd are the high dword, in our case zero. Each PTE points
301 * to a 4k page, which we translate to a page from the VM allocated region,
302 * pointed to by the BDSM register. If this is not set, we fail.
304 * We trap writes to the full configured GTT size, but we typically only
305 * see the vBIOS writing up to (nearly) the 1MB barrier. In fact it often
306 * seems to miss the last entry for an even 1MB GTT. Doing a gratuitous
307 * write of that last entry does work, but is hopefully unnecessary since
308 * we clear the previous GTT on initialization.
310 if ((igd->index % 4 == 1) && igd->index < vfio_igd_gtt_max(vdev)) {
311 if (gen < 8 || (igd->index % 8 == 1)) {
312 uint32_t base;
314 base = pci_get_long(vdev->pdev.config + IGD_BDSM);
315 if (!base) {
316 hw_error("vfio-igd: Guest attempted to program IGD GTT before "
317 "BIOS reserved stolen memory. Unsupported BIOS?");
320 val = data - igd->bdsm + base;
321 } else {
322 val = 0; /* upper 32bits of pte, we only enable below 4G PTEs */
325 trace_vfio_pci_igd_bar4_write(vdev->vbasedev.name,
326 igd->index, data, val);
329 vfio_region_write(&vdev->bars[4].region, addr + 4, val, size);
331 igd->index = ~0;
334 static const MemoryRegionOps vfio_igd_data_quirk = {
335 .read = vfio_igd_quirk_data_read,
336 .write = vfio_igd_quirk_data_write,
337 .endianness = DEVICE_LITTLE_ENDIAN,
340 static uint64_t vfio_igd_quirk_index_read(void *opaque,
341 hwaddr addr, unsigned size)
343 VFIOIGDQuirk *igd = opaque;
344 VFIOPCIDevice *vdev = igd->vdev;
346 igd->index = ~0;
348 return vfio_region_read(&vdev->bars[4].region, addr, size);
351 static void vfio_igd_quirk_index_write(void *opaque, hwaddr addr,
352 uint64_t data, unsigned size)
354 VFIOIGDQuirk *igd = opaque;
355 VFIOPCIDevice *vdev = igd->vdev;
357 igd->index = data;
359 vfio_region_write(&vdev->bars[4].region, addr, data, size);
362 static const MemoryRegionOps vfio_igd_index_quirk = {
363 .read = vfio_igd_quirk_index_read,
364 .write = vfio_igd_quirk_index_write,
365 .endianness = DEVICE_LITTLE_ENDIAN,
368 void vfio_probe_igd_bar4_quirk(VFIOPCIDevice *vdev, int nr)
370 struct vfio_region_info *rom = NULL, *opregion = NULL,
371 *host = NULL, *lpc = NULL;
372 VFIOQuirk *quirk;
373 VFIOIGDQuirk *igd;
374 PCIDevice *lpc_bridge;
375 int i, ret, ggms_mb, gms_mb = 0, gen;
376 uint64_t *bdsm_size;
377 uint32_t gmch;
378 uint16_t cmd_orig, cmd;
379 Error *err = NULL;
382 * This must be an Intel VGA device at address 00:02.0 for us to even
383 * consider enabling legacy mode. The vBIOS has dependencies on the
384 * PCI bus address.
386 if (!vfio_pci_is(vdev, PCI_VENDOR_ID_INTEL, PCI_ANY_ID) ||
387 !vfio_is_vga(vdev) || nr != 4 ||
388 &vdev->pdev != pci_find_device(pci_device_root_bus(&vdev->pdev),
389 0, PCI_DEVFN(0x2, 0))) {
390 return;
394 * We need to create an LPC/ISA bridge at PCI bus address 00:1f.0 that we
395 * can stuff host values into, so if there's already one there and it's not
396 * one we can hack on, legacy mode is no-go. Sorry Q35.
398 lpc_bridge = pci_find_device(pci_device_root_bus(&vdev->pdev),
399 0, PCI_DEVFN(0x1f, 0));
400 if (lpc_bridge && !object_dynamic_cast(OBJECT(lpc_bridge),
401 "vfio-pci-igd-lpc-bridge")) {
402 error_report("IGD device %s cannot support legacy mode due to existing "
403 "devices at address 1f.0", vdev->vbasedev.name);
404 return;
408 * IGD is not a standard, they like to change their specs often. We
409 * only attempt to support back to SandBridge and we hope that newer
410 * devices maintain compatibility with generation 8.
412 gen = igd_gen(vdev);
413 if (gen != 6 && gen != 8) {
414 error_report("IGD device %s is unsupported in legacy mode, "
415 "try SandyBridge or newer", vdev->vbasedev.name);
416 return;
420 * Most of what we're doing here is to enable the ROM to run, so if
421 * there's no ROM, there's no point in setting up this quirk.
422 * NB. We only seem to get BIOS ROMs, so a UEFI VM would need CSM support.
424 ret = vfio_get_region_info(&vdev->vbasedev,
425 VFIO_PCI_ROM_REGION_INDEX, &rom);
426 if ((ret || !rom->size) && !vdev->pdev.romfile) {
427 error_report("IGD device %s has no ROM, legacy mode disabled",
428 vdev->vbasedev.name);
429 goto out;
433 * Ignore the hotplug corner case, mark the ROM failed, we can't
434 * create the devices we need for legacy mode in the hotplug scenario.
436 if (vdev->pdev.qdev.hotplugged) {
437 error_report("IGD device %s hotplugged, ROM disabled, "
438 "legacy mode disabled", vdev->vbasedev.name);
439 vdev->rom_read_failed = true;
440 goto out;
444 * Check whether we have all the vfio device specific regions to
445 * support legacy mode (added in Linux v4.6). If not, bail.
447 ret = vfio_get_dev_region_info(&vdev->vbasedev,
448 VFIO_REGION_TYPE_PCI_VENDOR_TYPE | PCI_VENDOR_ID_INTEL,
449 VFIO_REGION_SUBTYPE_INTEL_IGD_OPREGION, &opregion);
450 if (ret) {
451 error_report("IGD device %s does not support OpRegion access,"
452 "legacy mode disabled", vdev->vbasedev.name);
453 goto out;
456 ret = vfio_get_dev_region_info(&vdev->vbasedev,
457 VFIO_REGION_TYPE_PCI_VENDOR_TYPE | PCI_VENDOR_ID_INTEL,
458 VFIO_REGION_SUBTYPE_INTEL_IGD_HOST_CFG, &host);
459 if (ret) {
460 error_report("IGD device %s does not support host bridge access,"
461 "legacy mode disabled", vdev->vbasedev.name);
462 goto out;
465 ret = vfio_get_dev_region_info(&vdev->vbasedev,
466 VFIO_REGION_TYPE_PCI_VENDOR_TYPE | PCI_VENDOR_ID_INTEL,
467 VFIO_REGION_SUBTYPE_INTEL_IGD_LPC_CFG, &lpc);
468 if (ret) {
469 error_report("IGD device %s does not support LPC bridge access,"
470 "legacy mode disabled", vdev->vbasedev.name);
471 goto out;
474 gmch = vfio_pci_read_config(&vdev->pdev, IGD_GMCH, 4);
477 * If IGD VGA Disable is clear (expected) and VGA is not already enabled,
478 * try to enable it. Probably shouldn't be using legacy mode without VGA,
479 * but also no point in us enabling VGA if disabled in hardware.
481 if (!(gmch & 0x2) && !vdev->vga && vfio_populate_vga(vdev, &err)) {
482 error_reportf_err(err, VFIO_MSG_PREFIX, vdev->vbasedev.name);
483 error_report("IGD device %s failed to enable VGA access, "
484 "legacy mode disabled", vdev->vbasedev.name);
485 goto out;
488 /* Create our LPC/ISA bridge */
489 ret = vfio_pci_igd_lpc_init(vdev, lpc);
490 if (ret) {
491 error_report("IGD device %s failed to create LPC bridge, "
492 "legacy mode disabled", vdev->vbasedev.name);
493 goto out;
496 /* Stuff some host values into the VM PCI host bridge */
497 ret = vfio_pci_igd_host_init(vdev, host);
498 if (ret) {
499 error_report("IGD device %s failed to modify host bridge, "
500 "legacy mode disabled", vdev->vbasedev.name);
501 goto out;
504 /* Setup OpRegion access */
505 ret = vfio_pci_igd_opregion_init(vdev, opregion, &err);
506 if (ret) {
507 error_append_hint(&err, "IGD legacy mode disabled\n");
508 error_reportf_err(err, VFIO_MSG_PREFIX, vdev->vbasedev.name);
509 goto out;
512 /* Setup our quirk to munge GTT addresses to the VM allocated buffer */
513 quirk = vfio_quirk_alloc(2);
514 igd = quirk->data = g_malloc0(sizeof(*igd));
515 igd->vdev = vdev;
516 igd->index = ~0;
517 igd->bdsm = vfio_pci_read_config(&vdev->pdev, IGD_BDSM, 4);
518 igd->bdsm &= ~((1 * MiB) - 1); /* 1MB aligned */
520 memory_region_init_io(&quirk->mem[0], OBJECT(vdev), &vfio_igd_index_quirk,
521 igd, "vfio-igd-index-quirk", 4);
522 memory_region_add_subregion_overlap(vdev->bars[nr].region.mem,
523 0, &quirk->mem[0], 1);
525 memory_region_init_io(&quirk->mem[1], OBJECT(vdev), &vfio_igd_data_quirk,
526 igd, "vfio-igd-data-quirk", 4);
527 memory_region_add_subregion_overlap(vdev->bars[nr].region.mem,
528 4, &quirk->mem[1], 1);
530 QLIST_INSERT_HEAD(&vdev->bars[nr].quirks, quirk, next);
532 /* Determine the size of stolen memory needed for GTT */
533 ggms_mb = (gmch >> (gen < 8 ? 8 : 6)) & 0x3;
534 if (gen > 6) {
535 ggms_mb = 1 << ggms_mb;
539 * Assume we have no GMS memory, but allow it to be overridden by device
540 * option (experimental). The spec doesn't actually allow zero GMS when
541 * when IVD (IGD VGA Disable) is clear, but the claim is that it's unused,
542 * so let's not waste VM memory for it.
544 gmch &= ~((gen < 8 ? 0x1f : 0xff) << (gen < 8 ? 3 : 8));
546 if (vdev->igd_gms) {
547 if (vdev->igd_gms <= 0x10) {
548 gms_mb = vdev->igd_gms * 32;
549 gmch |= vdev->igd_gms << (gen < 8 ? 3 : 8);
550 } else {
551 error_report("Unsupported IGD GMS value 0x%x", vdev->igd_gms);
552 vdev->igd_gms = 0;
557 * Request reserved memory for stolen memory via fw_cfg. VM firmware
558 * must allocate a 1MB aligned reserved memory region below 4GB with
559 * the requested size (in bytes) for use by the Intel PCI class VGA
560 * device at VM address 00:02.0. The base address of this reserved
561 * memory region must be written to the device BDSM register at PCI
562 * config offset 0x5C.
564 bdsm_size = g_malloc(sizeof(*bdsm_size));
565 *bdsm_size = cpu_to_le64((ggms_mb + gms_mb) * MiB);
566 fw_cfg_add_file(fw_cfg_find(), "etc/igd-bdsm-size",
567 bdsm_size, sizeof(*bdsm_size));
569 /* GMCH is read-only, emulated */
570 pci_set_long(vdev->pdev.config + IGD_GMCH, gmch);
571 pci_set_long(vdev->pdev.wmask + IGD_GMCH, 0);
572 pci_set_long(vdev->emulated_config_bits + IGD_GMCH, ~0);
574 /* BDSM is read-write, emulated. The BIOS needs to be able to write it */
575 pci_set_long(vdev->pdev.config + IGD_BDSM, 0);
576 pci_set_long(vdev->pdev.wmask + IGD_BDSM, ~0);
577 pci_set_long(vdev->emulated_config_bits + IGD_BDSM, ~0);
580 * This IOBAR gives us access to GTTADR, which allows us to write to
581 * the GTT itself. So let's go ahead and write zero to all the GTT
582 * entries to avoid spurious DMA faults. Be sure I/O access is enabled
583 * before talking to the device.
585 if (pread(vdev->vbasedev.fd, &cmd_orig, sizeof(cmd_orig),
586 vdev->config_offset + PCI_COMMAND) != sizeof(cmd_orig)) {
587 error_report("IGD device %s - failed to read PCI command register",
588 vdev->vbasedev.name);
591 cmd = cmd_orig | PCI_COMMAND_IO;
593 if (pwrite(vdev->vbasedev.fd, &cmd, sizeof(cmd),
594 vdev->config_offset + PCI_COMMAND) != sizeof(cmd)) {
595 error_report("IGD device %s - failed to write PCI command register",
596 vdev->vbasedev.name);
599 for (i = 1; i < vfio_igd_gtt_max(vdev); i += 4) {
600 vfio_region_write(&vdev->bars[4].region, 0, i, 4);
601 vfio_region_write(&vdev->bars[4].region, 4, 0, 4);
604 if (pwrite(vdev->vbasedev.fd, &cmd_orig, sizeof(cmd_orig),
605 vdev->config_offset + PCI_COMMAND) != sizeof(cmd_orig)) {
606 error_report("IGD device %s - failed to restore PCI command register",
607 vdev->vbasedev.name);
610 trace_vfio_pci_igd_bdsm_enabled(vdev->vbasedev.name, ggms_mb + gms_mb);
612 out:
613 g_free(rom);
614 g_free(opregion);
615 g_free(host);
616 g_free(lpc);