xive: Improve irq claim/free path
commite594c2ad1c3207ff308449203fd5abc002ac89c9
authorDavid Gibson <david@gibson.dropbear.id.au>
Wed, 25 Sep 2019 03:24:14 +0000 (25 13:24 +1000)
committerDavid Gibson <david@gibson.dropbear.id.au>
Fri, 4 Oct 2019 09:08:23 +0000 (4 19:08 +1000)
tree2850a4d939536591e6c90eea10a49088cefa81b2
parent580dde5e4a4597be26cb948a711727c2a406f158
xive: Improve irq claim/free path

spapr_xive_irq_claim() returns a bool to indicate if it succeeded.
But most of the callers and one callee use int return values and/or an
Error * with more information instead.  In any case, ints are a more
common idiom for success/failure states than bools (one never knows
what sense they'll be in).

So instead change to an int return value to indicate presence of error
+ an Error * to describe the details through that call chain.

It also didn't actually check if the irq was already claimed, which is
one of the primary purposes of the claim path, so do that.

spapr_xive_irq_free() also returned a bool... which no callers checked
and was always true, so just drop it.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Greg Kurz <groug@kaod.org>
hw/intc/spapr_xive.c
hw/intc/spapr_xive_kvm.c
hw/ppc/spapr_irq.c
include/hw/ppc/spapr_xive.h
include/hw/ppc/xive.h