| commit | dfc00eb7dea43bfb6d4a2ba38c4f6bc9745f3729 | |
| author | Daniel P. Berrangé <berrange@redhat.com> | |
| Fri, 18 Sep 2020 09:31:45 +0000 (18 10:31 +0100) | ||
| committer | Daniel P. Berrangé <berrange@redhat.com> | |
| Thu, 29 Oct 2020 09:57:37 +0000 (29 09:57 +0000) | ||
| tree | e3a211dae650c740c2f46f0c163e892e08b40280 | treesnapshot (tar.gz zip) |
| parent | 77b7829e755aec2f74601190a4521617b6dab49c | commitdiff |
util: include the target address in socket connect failures
Reporting "Failed to connect socket" is essentially useless for a user
attempting to diagnose failure. It needs to include the target address
details. Similarly when failing to create a socket we should include the
socket family info, so the user understands what particular feature was
missing in their kernel build (IPv6, VSock in particular).
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reporting "Failed to connect socket" is essentially useless for a user
attempting to diagnose failure. It needs to include the target address
details. Similarly when failing to create a socket we should include the
socket family info, so the user understands what particular feature was
missing in their kernel build (IPv6, VSock in particular).
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
| tests/qemu-iotests/162.out | diffblobblamehistory | |
| util/qemu-sockets.c | diffblobblamehistory |