qemu-img: fix error reporting for -object
commitb443db97c1b60765c5e1495cb0239c5b99d6c930
authorDaniel P. Berrangé <berrange@redhat.com>
Tue, 19 Feb 2019 11:46:09 +0000 (19 11:46 +0000)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Fri, 5 Apr 2019 20:29:48 +0000 (5 15:29 -0500)
tree0fa02ea019bfe372edad881aee26c77194614993
parent6b29db871d1262c79d87b9a6ae3c84b1f013fb76
qemu-img: fix error reporting for -object

Error reporting for user_creatable_add_opts_foreach was changed so that
it no longer called 'error_report_err' in:

  commit 7e1e0c11127bde81cff260fc6859690435c509d6
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   Wed Oct 17 10:26:43 2018 +0200

    qom: Clean up error reporting in user_creatable_add_opts_foreach()

Some callers were updated to pass in "&error_fatal" but all the ones in
qemu-img were left passing NULL. As a result all errors went to
/dev/null instead of being reported to the user.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit 334c43e2c342e878311c66b4e62343f0a7c2c6be)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
qemu-img.c