| commit | 7e1e0c11127bde81cff260fc6859690435c509d6 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Wed, 17 Oct 2018 08:26:43 +0000 (17 10:26 +0200) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Fri, 19 Oct 2018 12:51:34 +0000 (19 14:51 +0200) | ||
| tree | 745ea82522c4ca1cdf0567358c2accccd16ab18d | treesnapshot (tar.gz zip) |
| parent | 6353218b8c54dc6be6abb01c07a087add07ee5ce | commitdiff |
qom: Clean up error reporting in user_creatable_add_opts_foreach()
Calling error_report() in a function that takes an Error ** argument
is suspicious. user_creatable_add_opts_foreach() does that, and then
fails without setting an error. Its caller main(), via
qemu_opts_foreach(), is fine with it, but clean it up anyway.
Cc: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20181017082702.5581-20-armbru@redhat.com>
Calling error_report() in a function that takes an Error ** argument
is suspicious. user_creatable_add_opts_foreach() does that, and then
fails without setting an error. Its caller main(), via
qemu_opts_foreach(), is fine with it, but clean it up anyway.
Cc: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20181017082702.5581-20-armbru@redhat.com>
| qemu-io.c | diffblobblamehistory | |
| qemu-nbd.c | diffblobblamehistory | |
| qom/object_interfaces.c | diffblobblamehistory | |
| vl.c | diffblobblamehistory |