hw/s390x/ipl: avoid taking address of fields in packed struct
commit5d45a332920d6dd5536ba5f886713f5a213f90bb
authorDaniel P. Berrangé <berrange@redhat.com>
Fri, 29 Mar 2019 11:11:03 +0000 (29 11:11 +0000)
committerCornelia Huck <cohuck@redhat.com>
Wed, 3 Apr 2019 09:19:57 +0000 (3 11:19 +0200)
treeb35860b97e6cafebd637552b6014979f52076abb
parentbea0279b72fcd7bf5b5305fabf3a3cbee3a3eaa6
hw/s390x/ipl: avoid taking address of fields in packed struct

Compiling with GCC 9 complains

hw/s390x/ipl.c: In function ‘s390_ipl_set_boot_menu’:
hw/s390x/ipl.c:256:25: warning: taking address of packed member of ‘struct QemuIplParameters’ may result in an unaligned pointer value [-Waddress-of-packed-member]
  256 |     uint32_t *timeout = &ipl->qipl.boot_menu_timeout;
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

This local variable is only present to save a little bit of
typing when setting the field later. Get rid of this to avoid
the warning about unaligned accesses.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20190329111104.17223-14-berrange@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Farhan Ali <alifm@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
hw/s390x/ipl.c