| commit | 52c7c9d076dc64a6d3f1938b5a4994f84744c7fa | |
| author | Daniel P. Berrangé <berrange@redhat.com> | |
| Mon, 5 Feb 2018 11:49:36 +0000 (5 11:49 +0000) | ||
| committer | Gerd Hoffmann <kraxel@redhat.com> | |
| Fri, 16 Feb 2018 11:33:02 +0000 (16 12:33 +0100) | ||
| tree | 9960f162e517b7b42c368a23ee60e44a4dfe5575 | treesnapshot (tar.gz zip) |
| parent | dffa1de071aa956308172170107b7b60d99bf34b | commitdiff |
ui: avoid 'local_err' variable shadowing in VNC SASL auth
The start_auth_sasl() method declares a 'Error *local_err' variable in
an inner if () {...} scope, which shadows a variable of the same name
declared at the start of the method. This is confusing for reviewers and
may trigger compiler warnings.
Reported-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20180205114938.15784-3-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
The start_auth_sasl() method declares a 'Error *local_err' variable in
an inner if () {...} scope, which shadows a variable of the same name
declared at the start of the method. This is confusing for reviewers and
may trigger compiler warnings.
Reported-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20180205114938.15784-3-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
| ui/vnc-auth-sasl.c | diffblobblamehistory |