virtio-balloon: Prevent guest from starting a report when we didn't request one
commit20a4da0f23078deeff5ea6d1e12f47d968d7c3c9
authorAlexander Duyck <alexander.h.duyck@linux.intel.com>
Mon, 20 Jul 2020 17:51:15 +0000 (20 10:51 -0700)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 22 Jul 2020 11:57:07 +0000 (22 07:57 -0400)
treeca99fcf6ed0a8096c6d1e3ebe58322e51b0c8258
parentcf4e3d000e438d04077a56c401b41f3336a2a09d
virtio-balloon: Prevent guest from starting a report when we didn't request one

Based on code review it appears possible for the driver to force the device
out of a stopped state when hinting by repeating the last ID it was
provided.

Prevent this by only allowing a transition to the start state when we are
in the requested state. This way the driver is only allowed to send one
descriptor that will transition the device into the start state. All others
will leave it in the stop state once it has finished.

Fixes: c13c4153f76d ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")
Acked-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Message-Id: <20200720175115.21935.99563.stgit@localhost.localdomain>
Cc: qemu-stable@nongnu.org
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/virtio/virtio-balloon.c