virtio: Drop broken and superfluous object_property_set_link()
commitcf4e3d000e438d04077a56c401b41f3336a2a09d
authorMarkus Armbruster <armbru@redhat.com>
Tue, 21 Jul 2020 12:11:53 +0000 (21 14:11 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 22 Jul 2020 11:57:07 +0000 (22 07:57 -0400)
treed32172230f69c1c30fa8749c6ca775762cd83d4d
parentdba04c3488c4699f5afe96f66e448b1d447cf3fb
virtio: Drop broken and superfluous object_property_set_link()

virtio_crypto_pci_realize() and copies the value of vcrypto->vdev's
property "cryptodev" to vcrypto's property:

    object_property_set_link(OBJECT(vrng), "rng", OBJECT(vrng->vdev.conf.rng),
                             NULL);

Since it does so only after realize, this always fails, but the error
is ignored.

It's actually superfluous: vcrypto's property is an alias of
vcrypto->vdev's property, created by virtio_instance_init_common().

Drop the call.

Same for virtio_ccw_crypto_realize(), virtio_rng_pci_realize(),
virtio_ccw_rng_realize().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200721121153.1128844-1-armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/s390x/virtio-ccw-crypto.c
hw/s390x/virtio-ccw-rng.c
hw/virtio/virtio-crypto-pci.c
hw/virtio/virtio-rng-pci.c