| commit | 00ed3da9b5c2e66e796a172df3e19545462b9c90 | |
| author | David Gibson <david@gibson.dropbear.id.au> | |
| Tue, 24 Sep 2019 06:00:33 +0000 (24 16:00 +1000) | ||
| committer | David Gibson <david@gibson.dropbear.id.au> | |
| Fri, 4 Oct 2019 09:08:21 +0000 (4 19:08 +1000) | ||
| tree | d9d14269a3d439400a63d7d2febb6cb9f1ee1688 | treesnapshot (tar.gz zip) |
| parent | 627fa61746f70f7c799f08e9048bb6a482402138 | commitdiff |
xics: Minor fixes for XICSFabric interface
Interface instances should never be directly dereferenced. So, the common
practice is to make them incomplete types to make sure no-one does that.
XICSFrabric, however, had a dummy type which is less safe.
We were also using OBJECT_CHECK() where we should have been using
INTERFACE_CHECK().
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Interface instances should never be directly dereferenced. So, the common
practice is to make them incomplete types to make sure no-one does that.
XICSFrabric, however, had a dummy type which is less safe.
We were also using OBJECT_CHECK() where we should have been using
INTERFACE_CHECK().
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
| include/hw/ppc/xics.h | diffblobblamehistory |